{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/scflode/api-plaform-core/pulls/1","id":203029416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDI5NDE2","html_url":"https://github.com/scflode/api-plaform-core/pull/1","diff_url":"https://github.com/scflode/api-plaform-core/pull/1.diff","patch_url":"https://github.com/scflode/api-plaform-core/pull/1.patch","issue_url":"https://api.github.com/repos/scflode/api-plaform-core/issues/1","number":1,"state":"closed","locked":false,"title":"Fix inconsistency of CollectionDataProviderInterface","user":{"login":"scflode","id":603218,"node_id":"MDQ6VXNlcjYwMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/603218?v=4","gravatar_id":"","url":"https://api.github.com/users/scflode","html_url":"https://github.com/scflode","followers_url":"https://api.github.com/users/scflode/followers","following_url":"https://api.github.com/users/scflode/following{/other_user}","gists_url":"https://api.github.com/users/scflode/gists{/gist_id}","starred_url":"https://api.github.com/users/scflode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scflode/subscriptions","organizations_url":"https://api.github.com/users/scflode/orgs","repos_url":"https://api.github.com/users/scflode/repos","events_url":"https://api.github.com/users/scflode/events{/privacy}","received_events_url":"https://api.github.com/users/scflode/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nThe currently defined method declaration for `getCollection` does not contain the (optional) `$context` argument. \r\nTo align with the `RestrictedDataProviderInterface` and the `ItemDataProviderInterface` it should be added.\r\n\r\nIn the end the argument is sent anyways already via the `OperationDataProviderTrait` and used in the `ApiPlatform\\Core\\EventListener\\ReadListener`. \r\n\r\nTo add it as optional parameter should also keep BC.","created_at":"2018-07-21T22:17:55Z","updated_at":"2018-07-21T22:20:34Z","closed_at":"2018-07-21T22:20:34Z","merged_at":null,"merge_commit_sha":"6a46482b2fb017e774ddfaa4e6949ce3b49b0ff6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scflode/api-plaform-core/pulls/1/commits","review_comments_url":"https://api.github.com/repos/scflode/api-plaform-core/pulls/1/comments","review_comment_url":"https://api.github.com/repos/scflode/api-plaform-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scflode/api-plaform-core/issues/1/comments","statuses_url":"https://api.github.com/repos/scflode/api-plaform-core/statuses/749b8bbde85f3af421315f4dd843f31cdf6067d2","head":{"label":"scflode:collection_data_provider_inconsistency","ref":"collection_data_provider_inconsistency","sha":"749b8bbde85f3af421315f4dd843f31cdf6067d2","user":{"login":"scflode","id":603218,"node_id":"MDQ6VXNlcjYwMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/603218?v=4","gravatar_id":"","url":"https://api.github.com/users/scflode","html_url":"https://github.com/scflode","followers_url":"https://api.github.com/users/scflode/followers","following_url":"https://api.github.com/users/scflode/following{/other_user}","gists_url":"https://api.github.com/users/scflode/gists{/gist_id}","starred_url":"https://api.github.com/users/scflode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scflode/subscriptions","organizations_url":"https://api.github.com/users/scflode/orgs","repos_url":"https://api.github.com/users/scflode/repos","events_url":"https://api.github.com/users/scflode/events{/privacy}","received_events_url":"https://api.github.com/users/scflode/received_events","type":"User","site_admin":false},"repo":{"id":141848946,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4NDg5NDY=","name":"api-plaform-core","full_name":"scflode/api-plaform-core","owner":{"login":"scflode","id":603218,"node_id":"MDQ6VXNlcjYwMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/603218?v=4","gravatar_id":"","url":"https://api.github.com/users/scflode","html_url":"https://github.com/scflode","followers_url":"https://api.github.com/users/scflode/followers","following_url":"https://api.github.com/users/scflode/following{/other_user}","gists_url":"https://api.github.com/users/scflode/gists{/gist_id}","starred_url":"https://api.github.com/users/scflode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scflode/subscriptions","organizations_url":"https://api.github.com/users/scflode/orgs","repos_url":"https://api.github.com/users/scflode/repos","events_url":"https://api.github.com/users/scflode/events{/privacy}","received_events_url":"https://api.github.com/users/scflode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scflode/api-plaform-core","description":"The server component of API Platform: hypermedia and GraphQL APIs in minutes","fork":true,"url":"https://api.github.com/repos/scflode/api-plaform-core","forks_url":"https://api.github.com/repos/scflode/api-plaform-core/forks","keys_url":"https://api.github.com/repos/scflode/api-plaform-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scflode/api-plaform-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scflode/api-plaform-core/teams","hooks_url":"https://api.github.com/repos/scflode/api-plaform-core/hooks","issue_events_url":"https://api.github.com/repos/scflode/api-plaform-core/issues/events{/number}","events_url":"https://api.github.com/repos/scflode/api-plaform-core/events","assignees_url":"https://api.github.com/repos/scflode/api-plaform-core/assignees{/user}","branches_url":"https://api.github.com/repos/scflode/api-plaform-core/branches{/branch}","tags_url":"https://api.github.com/repos/scflode/api-plaform-core/tags","blobs_url":"https://api.github.com/repos/scflode/api-plaform-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scflode/api-plaform-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scflode/api-plaform-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/scflode/api-plaform-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scflode/api-plaform-core/statuses/{sha}","languages_url":"https://api.github.com/repos/scflode/api-plaform-core/languages","stargazers_url":"https://api.github.com/repos/scflode/api-plaform-core/stargazers","contributors_url":"https://api.github.com/repos/scflode/api-plaform-core/contributors","subscribers_url":"https://api.github.com/repos/scflode/api-plaform-core/subscribers","subscription_url":"https://api.github.com/repos/scflode/api-plaform-core/subscription","commits_url":"https://api.github.com/repos/scflode/api-plaform-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/scflode/api-plaform-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/scflode/api-plaform-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/scflode/api-plaform-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/scflode/api-plaform-core/contents/{+path}","compare_url":"https://api.github.com/repos/scflode/api-plaform-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scflode/api-plaform-core/merges","archive_url":"https://api.github.com/repos/scflode/api-plaform-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scflode/api-plaform-core/downloads","issues_url":"https://api.github.com/repos/scflode/api-plaform-core/issues{/number}","pulls_url":"https://api.github.com/repos/scflode/api-plaform-core/pulls{/number}","milestones_url":"https://api.github.com/repos/scflode/api-plaform-core/milestones{/number}","notifications_url":"https://api.github.com/repos/scflode/api-plaform-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scflode/api-plaform-core/labels{/name}","releases_url":"https://api.github.com/repos/scflode/api-plaform-core/releases{/id}","deployments_url":"https://api.github.com/repos/scflode/api-plaform-core/deployments","created_at":"2018-07-21T22:09:30Z","updated_at":"2018-07-21T22:10:53Z","pushed_at":"2018-07-21T22:17:56Z","git_url":"git://github.com/scflode/api-plaform-core.git","ssh_url":"git@github.com:scflode/api-plaform-core.git","clone_url":"https://github.com/scflode/api-plaform-core.git","svn_url":"https://github.com/scflode/api-plaform-core","homepage":"https://api-platform.com","size":9033,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scflode:master","ref":"master","sha":"797cea682956871c0a848275bbaeabf1339ad615","user":{"login":"scflode","id":603218,"node_id":"MDQ6VXNlcjYwMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/603218?v=4","gravatar_id":"","url":"https://api.github.com/users/scflode","html_url":"https://github.com/scflode","followers_url":"https://api.github.com/users/scflode/followers","following_url":"https://api.github.com/users/scflode/following{/other_user}","gists_url":"https://api.github.com/users/scflode/gists{/gist_id}","starred_url":"https://api.github.com/users/scflode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scflode/subscriptions","organizations_url":"https://api.github.com/users/scflode/orgs","repos_url":"https://api.github.com/users/scflode/repos","events_url":"https://api.github.com/users/scflode/events{/privacy}","received_events_url":"https://api.github.com/users/scflode/received_events","type":"User","site_admin":false},"repo":{"id":141848946,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4NDg5NDY=","name":"api-plaform-core","full_name":"scflode/api-plaform-core","owner":{"login":"scflode","id":603218,"node_id":"MDQ6VXNlcjYwMzIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/603218?v=4","gravatar_id":"","url":"https://api.github.com/users/scflode","html_url":"https://github.com/scflode","followers_url":"https://api.github.com/users/scflode/followers","following_url":"https://api.github.com/users/scflode/following{/other_user}","gists_url":"https://api.github.com/users/scflode/gists{/gist_id}","starred_url":"https://api.github.com/users/scflode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scflode/subscriptions","organizations_url":"https://api.github.com/users/scflode/orgs","repos_url":"https://api.github.com/users/scflode/repos","events_url":"https://api.github.com/users/scflode/events{/privacy}","received_events_url":"https://api.github.com/users/scflode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scflode/api-plaform-core","description":"The server component of API Platform: hypermedia and GraphQL APIs in minutes","fork":true,"url":"https://api.github.com/repos/scflode/api-plaform-core","forks_url":"https://api.github.com/repos/scflode/api-plaform-core/forks","keys_url":"https://api.github.com/repos/scflode/api-plaform-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scflode/api-plaform-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scflode/api-plaform-core/teams","hooks_url":"https://api.github.com/repos/scflode/api-plaform-core/hooks","issue_events_url":"https://api.github.com/repos/scflode/api-plaform-core/issues/events{/number}","events_url":"https://api.github.com/repos/scflode/api-plaform-core/events","assignees_url":"https://api.github.com/repos/scflode/api-plaform-core/assignees{/user}","branches_url":"https://api.github.com/repos/scflode/api-plaform-core/branches{/branch}","tags_url":"https://api.github.com/repos/scflode/api-plaform-core/tags","blobs_url":"https://api.github.com/repos/scflode/api-plaform-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scflode/api-plaform-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scflode/api-plaform-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/scflode/api-plaform-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scflode/api-plaform-core/statuses/{sha}","languages_url":"https://api.github.com/repos/scflode/api-plaform-core/languages","stargazers_url":"https://api.github.com/repos/scflode/api-plaform-core/stargazers","contributors_url":"https://api.github.com/repos/scflode/api-plaform-core/contributors","subscribers_url":"https://api.github.com/repos/scflode/api-plaform-core/subscribers","subscription_url":"https://api.github.com/repos/scflode/api-plaform-core/subscription","commits_url":"https://api.github.com/repos/scflode/api-plaform-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/scflode/api-plaform-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/scflode/api-plaform-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/scflode/api-plaform-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/scflode/api-plaform-core/contents/{+path}","compare_url":"https://api.github.com/repos/scflode/api-plaform-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scflode/api-plaform-core/merges","archive_url":"https://api.github.com/repos/scflode/api-plaform-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scflode/api-plaform-core/downloads","issues_url":"https://api.github.com/repos/scflode/api-plaform-core/issues{/number}","pulls_url":"https://api.github.com/repos/scflode/api-plaform-core/pulls{/number}","milestones_url":"https://api.github.com/repos/scflode/api-plaform-core/milestones{/number}","notifications_url":"https://api.github.com/repos/scflode/api-plaform-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scflode/api-plaform-core/labels{/name}","releases_url":"https://api.github.com/repos/scflode/api-plaform-core/releases{/id}","deployments_url":"https://api.github.com/repos/scflode/api-plaform-core/deployments","created_at":"2018-07-21T22:09:30Z","updated_at":"2018-07-21T22:10:53Z","pushed_at":"2018-07-21T22:17:56Z","git_url":"git://github.com/scflode/api-plaform-core.git","ssh_url":"git@github.com:scflode/api-plaform-core.git","clone_url":"https://github.com/scflode/api-plaform-core.git","svn_url":"https://github.com/scflode/api-plaform-core","homepage":"https://api-platform.com","size":9033,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scflode/api-plaform-core/pulls/1"},"html":{"href":"https://github.com/scflode/api-plaform-core/pull/1"},"issue":{"href":"https://api.github.com/repos/scflode/api-plaform-core/issues/1"},"comments":{"href":"https://api.github.com/repos/scflode/api-plaform-core/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/scflode/api-plaform-core/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/scflode/api-plaform-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scflode/api-plaform-core/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/scflode/api-plaform-core/statuses/749b8bbde85f3af421315f4dd843f31cdf6067d2"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"scflode"}}