{"action":"opened","number":2935,"pull_request":{"url":"https://api.github.com/repos/summernote/summernote/pulls/2935","id":209820088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODIwMDg4","html_url":"https://github.com/summernote/summernote/pull/2935","diff_url":"https://github.com/summernote/summernote/pull/2935.diff","patch_url":"https://github.com/summernote/summernote/pull/2935.patch","issue_url":"https://api.github.com/repos/summernote/summernote/issues/2935","number":2935,"state":"open","locked":false,"title":"Fix link autodetection","user":{"login":"mikkoaf","id":16817737,"node_id":"MDQ6VXNlcjE2ODE3NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/16817737?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkoaf","html_url":"https://github.com/mikkoaf","followers_url":"https://api.github.com/users/mikkoaf/followers","following_url":"https://api.github.com/users/mikkoaf/following{/other_user}","gists_url":"https://api.github.com/users/mikkoaf/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkoaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkoaf/subscriptions","organizations_url":"https://api.github.com/users/mikkoaf/orgs","repos_url":"https://api.github.com/users/mikkoaf/repos","events_url":"https://api.github.com/users/mikkoaf/events{/privacy}","received_events_url":"https://api.github.com/users/mikkoaf/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\n- Fixes #2753\r\n- Allows for any kind of protocols to be written and used to create a link, as long as there are exactly 2 /-characters\r\n\r\n#### Where should the reviewer start?\r\n\r\n- start on the src/js/base/module/AutoLink.js\r\n\r\n#### How should this be manually tested?\r\n\r\n- As described in #2753 \r\n\r\n#### Any background context you want to provide?\r\n\r\n- No additional context to provide\r\n\r\n#### What are the relevant tickets?\r\n\r\n#2753 \r\n\r\n#### Screenshot (if for frontend)\r\nPrior:\r\n![image](https://user-images.githubusercontent.com/16817737/44403136-510a3d80-a55c-11e8-9a16-44cc5b0ab7be.png)\r\n\r\nEnd result:\r\n![image](https://user-images.githubusercontent.com/16817737/44402640-148a1200-a55b-11e8-876e-16d6d4e578b5.png)\r\n\r\n\r\n### Checklist\r\n- [x] didn't break anything","created_at":"2018-08-21T13:09:01Z","updated_at":"2018-08-21T13:09:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/summernote/summernote/pulls/2935/commits","review_comments_url":"https://api.github.com/repos/summernote/summernote/pulls/2935/comments","review_comment_url":"https://api.github.com/repos/summernote/summernote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/summernote/summernote/issues/2935/comments","statuses_url":"https://api.github.com/repos/summernote/summernote/statuses/7fd408b9af6bc310bae817d2e9a140efca541f73","head":{"label":"mikkoaf:dev-maf-regex","ref":"dev-maf-regex","sha":"7fd408b9af6bc310bae817d2e9a140efca541f73","user":{"login":"mikkoaf","id":16817737,"node_id":"MDQ6VXNlcjE2ODE3NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/16817737?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkoaf","html_url":"https://github.com/mikkoaf","followers_url":"https://api.github.com/users/mikkoaf/followers","following_url":"https://api.github.com/users/mikkoaf/following{/other_user}","gists_url":"https://api.github.com/users/mikkoaf/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkoaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkoaf/subscriptions","organizations_url":"https://api.github.com/users/mikkoaf/orgs","repos_url":"https://api.github.com/users/mikkoaf/repos","events_url":"https://api.github.com/users/mikkoaf/events{/privacy}","received_events_url":"https://api.github.com/users/mikkoaf/received_events","type":"User","site_admin":false},"repo":{"id":145524223,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1MjQyMjM=","name":"summernote","full_name":"mikkoaf/summernote","owner":{"login":"mikkoaf","id":16817737,"node_id":"MDQ6VXNlcjE2ODE3NzM3","avatar_url":"https://avatars2.githubusercontent.com/u/16817737?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkoaf","html_url":"https://github.com/mikkoaf","followers_url":"https://api.github.com/users/mikkoaf/followers","following_url":"https://api.github.com/users/mikkoaf/following{/other_user}","gists_url":"https://api.github.com/users/mikkoaf/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkoaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkoaf/subscriptions","organizations_url":"https://api.github.com/users/mikkoaf/orgs","repos_url":"https://api.github.com/users/mikkoaf/repos","events_url":"https://api.github.com/users/mikkoaf/events{/privacy}","received_events_url":"https://api.github.com/users/mikkoaf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikkoaf/summernote","description":"Super simple WYSIWYG editor","fork":true,"url":"https://api.github.com/repos/mikkoaf/summernote","forks_url":"https://api.github.com/repos/mikkoaf/summernote/forks","keys_url":"https://api.github.com/repos/mikkoaf/summernote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikkoaf/summernote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikkoaf/summernote/teams","hooks_url":"https://api.github.com/repos/mikkoaf/summernote/hooks","issue_events_url":"https://api.github.com/repos/mikkoaf/summernote/issues/events{/number}","events_url":"https://api.github.com/repos/mikkoaf/summernote/events","assignees_url":"https://api.github.com/repos/mikkoaf/summernote/assignees{/user}","branches_url":"https://api.github.com/repos/mikkoaf/summernote/branches{/branch}","tags_url":"https://api.github.com/repos/mikkoaf/summernote/tags","blobs_url":"https://api.github.com/repos/mikkoaf/summernote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikkoaf/summernote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikkoaf/summernote/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikkoaf/summernote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikkoaf/summernote/statuses/{sha}","languages_url":"https://api.github.com/repos/mikkoaf/summernote/languages","stargazers_url":"https://api.github.com/repos/mikkoaf/summernote/stargazers","contributors_url":"https://api.github.com/repos/mikkoaf/summernote/contributors","subscribers_url":"https://api.github.com/repos/mikkoaf/summernote/subscribers","subscription_url":"https://api.github.com/repos/mikkoaf/summernote/subscription","commits_url":"https://api.github.com/repos/mikkoaf/summernote/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikkoaf/summernote/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikkoaf/summernote/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikkoaf/summernote/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikkoaf/summernote/contents/{+path}","compare_url":"https://api.github.com/repos/mikkoaf/summernote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikkoaf/summernote/merges","archive_url":"https://api.github.com/repos/mikkoaf/summernote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikkoaf/summernote/downloads","issues_url":"https://api.github.com/repos/mikkoaf/summernote/issues{/number}","pulls_url":"https://api.github.com/repos/mikkoaf/summernote/pulls{/number}","milestones_url":"https://api.github.com/repos/mikkoaf/summernote/milestones{/number}","notifications_url":"https://api.github.com/repos/mikkoaf/summernote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikkoaf/summernote/labels{/name}","releases_url":"https://api.github.com/repos/mikkoaf/summernote/releases{/id}","deployments_url":"https://api.github.com/repos/mikkoaf/summernote/deployments","created_at":"2018-08-21T07:28:01Z","updated_at":"2018-08-21T07:28:04Z","pushed_at":"2018-08-21T12:49:56Z","git_url":"git://github.com/mikkoaf/summernote.git","ssh_url":"git@github.com:mikkoaf/summernote.git","clone_url":"https://github.com/mikkoaf/summernote.git","svn_url":"https://github.com/mikkoaf/summernote","homepage":"https://summernote.org","size":11082,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"summernote:develop","ref":"develop","sha":"9909070f079f424435653f540bf1d868a0f490d5","user":{"login":"summernote","id":7778517,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3Nzg1MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7778517?v=4","gravatar_id":"","url":"https://api.github.com/users/summernote","html_url":"https://github.com/summernote","followers_url":"https://api.github.com/users/summernote/followers","following_url":"https://api.github.com/users/summernote/following{/other_user}","gists_url":"https://api.github.com/users/summernote/gists{/gist_id}","starred_url":"https://api.github.com/users/summernote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summernote/subscriptions","organizations_url":"https://api.github.com/users/summernote/orgs","repos_url":"https://api.github.com/users/summernote/repos","events_url":"https://api.github.com/users/summernote/events{/privacy}","received_events_url":"https://api.github.com/users/summernote/received_events","type":"Organization","site_admin":false},"repo":{"id":9709563,"node_id":"MDEwOlJlcG9zaXRvcnk5NzA5NTYz","name":"summernote","full_name":"summernote/summernote","owner":{"login":"summernote","id":7778517,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3Nzg1MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/7778517?v=4","gravatar_id":"","url":"https://api.github.com/users/summernote","html_url":"https://github.com/summernote","followers_url":"https://api.github.com/users/summernote/followers","following_url":"https://api.github.com/users/summernote/following{/other_user}","gists_url":"https://api.github.com/users/summernote/gists{/gist_id}","starred_url":"https://api.github.com/users/summernote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summernote/subscriptions","organizations_url":"https://api.github.com/users/summernote/orgs","repos_url":"https://api.github.com/users/summernote/repos","events_url":"https://api.github.com/users/summernote/events{/privacy}","received_events_url":"https://api.github.com/users/summernote/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/summernote/summernote","description":"Super simple WYSIWYG editor","fork":false,"url":"https://api.github.com/repos/summernote/summernote","forks_url":"https://api.github.com/repos/summernote/summernote/forks","keys_url":"https://api.github.com/repos/summernote/summernote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/summernote/summernote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/summernote/summernote/teams","hooks_url":"https://api.github.com/repos/summernote/summernote/hooks","issue_events_url":"https://api.github.com/repos/summernote/summernote/issues/events{/number}","events_url":"https://api.github.com/repos/summernote/summernote/events","assignees_url":"https://api.github.com/repos/summernote/summernote/assignees{/user}","branches_url":"https://api.github.com/repos/summernote/summernote/branches{/branch}","tags_url":"https://api.github.com/repos/summernote/summernote/tags","blobs_url":"https://api.github.com/repos/summernote/summernote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/summernote/summernote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/summernote/summernote/git/refs{/sha}","trees_url":"https://api.github.com/repos/summernote/summernote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/summernote/summernote/statuses/{sha}","languages_url":"https://api.github.com/repos/summernote/summernote/languages","stargazers_url":"https://api.github.com/repos/summernote/summernote/stargazers","contributors_url":"https://api.github.com/repos/summernote/summernote/contributors","subscribers_url":"https://api.github.com/repos/summernote/summernote/subscribers","subscription_url":"https://api.github.com/repos/summernote/summernote/subscription","commits_url":"https://api.github.com/repos/summernote/summernote/commits{/sha}","git_commits_url":"https://api.github.com/repos/summernote/summernote/git/commits{/sha}","comments_url":"https://api.github.com/repos/summernote/summernote/comments{/number}","issue_comment_url":"https://api.github.com/repos/summernote/summernote/issues/comments{/number}","contents_url":"https://api.github.com/repos/summernote/summernote/contents/{+path}","compare_url":"https://api.github.com/repos/summernote/summernote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/summernote/summernote/merges","archive_url":"https://api.github.com/repos/summernote/summernote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/summernote/summernote/downloads","issues_url":"https://api.github.com/repos/summernote/summernote/issues{/number}","pulls_url":"https://api.github.com/repos/summernote/summernote/pulls{/number}","milestones_url":"https://api.github.com/repos/summernote/summernote/milestones{/number}","notifications_url":"https://api.github.com/repos/summernote/summernote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/summernote/summernote/labels{/name}","releases_url":"https://api.github.com/repos/summernote/summernote/releases{/id}","deployments_url":"https://api.github.com/repos/summernote/summernote/deployments","created_at":"2013-04-27T04:59:48Z","updated_at":"2018-08-21T07:22:36Z","pushed_at":"2018-08-21T05:47:32Z","git_url":"git://github.com/summernote/summernote.git","ssh_url":"git@github.com:summernote/summernote.git","clone_url":"https://github.com/summernote/summernote.git","svn_url":"https://github.com/summernote/summernote","homepage":"https://summernote.org","size":11082,"stargazers_count":7632,"watchers_count":7632,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1599,"mirror_url":null,"archived":false,"open_issues_count":666,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1599,"open_issues":666,"watchers":7632,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/summernote/summernote/pulls/2935"},"html":{"href":"https://github.com/summernote/summernote/pull/2935"},"issue":{"href":"https://api.github.com/repos/summernote/summernote/issues/2935"},"comments":{"href":"https://api.github.com/repos/summernote/summernote/issues/2935/comments"},"review_comments":{"href":"https://api.github.com/repos/summernote/summernote/pulls/2935/comments"},"review_comment":{"href":"https://api.github.com/repos/summernote/summernote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/summernote/summernote/pulls/2935/commits"},"statuses":{"href":"https://api.github.com/repos/summernote/summernote/statuses/7fd408b9af6bc310bae817d2e9a140efca541f73"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":22,"additions":29173,"deletions":62,"changed_files":105}}
{"actor":{"display_login":"mikkoaf"}}