{"action":"created","issue":{"url":"https://api.github.com/repos/afTrolle/geode/issues/1","repository_url":"https://api.github.com/repos/afTrolle/geode","labels_url":"https://api.github.com/repos/afTrolle/geode/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/afTrolle/geode/issues/1/comments","events_url":"https://api.github.com/repos/afTrolle/geode/issues/1/events","html_url":"https://github.com/afTrolle/geode/pull/1","id":297841754,"number":1,"title":"Feat: Moved methods out of Message to subclasses","user":{"login":"Filipjansson95","id":17430769,"avatar_url":"https://avatars1.githubusercontent.com/u/17430769?v=4","gravatar_id":"","url":"https://api.github.com/users/Filipjansson95","html_url":"https://github.com/Filipjansson95","followers_url":"https://api.github.com/users/Filipjansson95/followers","following_url":"https://api.github.com/users/Filipjansson95/following{/other_user}","gists_url":"https://api.github.com/users/Filipjansson95/gists{/gist_id}","starred_url":"https://api.github.com/users/Filipjansson95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Filipjansson95/subscriptions","organizations_url":"https://api.github.com/users/Filipjansson95/orgs","repos_url":"https://api.github.com/users/Filipjansson95/repos","events_url":"https://api.github.com/users/Filipjansson95/events{/privacy}","received_events_url":"https://api.github.com/users/Filipjansson95/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-16T16:24:55Z","updated_at":"2018-02-16T19:38:01Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/afTrolle/geode/pulls/1","html_url":"https://github.com/afTrolle/geode/pull/1","diff_url":"https://github.com/afTrolle/geode/pull/1.diff","patch_url":"https://github.com/afTrolle/geode/pull/1.patch"},"body":"I changed a few parameters from private to protected to make them available for the subclasses. Should we perhaps create an own package for all Message classes?\r\n\r\nWhen reviewing this PR look for additional methods to move from the Message class (if you find any). Note that parts of the Project are still broken."},"comment":{"url":"https://api.github.com/repos/afTrolle/geode/issues/comments/366337434","html_url":"https://github.com/afTrolle/geode/pull/1#issuecomment-366337434","issue_url":"https://api.github.com/repos/afTrolle/geode/issues/1","id":366337434,"user":{"login":"jacobhal","id":7457680,"avatar_url":"https://avatars3.githubusercontent.com/u/7457680?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobhal","html_url":"https://github.com/jacobhal","followers_url":"https://api.github.com/users/jacobhal/followers","following_url":"https://api.github.com/users/jacobhal/following{/other_user}","gists_url":"https://api.github.com/users/jacobhal/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobhal/subscriptions","organizations_url":"https://api.github.com/users/jacobhal/orgs","repos_url":"https://api.github.com/users/jacobhal/repos","events_url":"https://api.github.com/users/jacobhal/events{/privacy}","received_events_url":"https://api.github.com/users/jacobhal/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T19:38:01Z","updated_at":"2018-02-16T19:38:01Z","author_association":"COLLABORATOR","body":"I see, since the functions that you moved are more straightforward to refactor I suggest we merge them first and get everything to compile before taking on the other functions.\r\nOther functions that I found were:\r\n**addStringPart(String str, boolean enableCaching)**: used mainly in ClientUpdateMessageImpl a\r\nand has a cache flag, so I assume this is used by client-side only\r\n**addObjPart(Object o, boolean zipValues)**: used mainly in BaseCommand which seem to be for server-side as mentioned in the email\r\n**addObjPartNoCopying(Object o)**: used similarly to the function above, so I think this one is for the server as well\r\n"}}
{"actor":{"display_login":"jacobhal"}}