{"action":"closed","number":1386,"pull_request":{"url":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/1386","id":222272574,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjcyNTc0","html_url":"https://github.com/Microsoft/pxt-microbit/pull/1386","diff_url":"https://github.com/Microsoft/pxt-microbit/pull/1386.diff","patch_url":"https://github.com/Microsoft/pxt-microbit/pull/1386.patch","issue_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/1386","number":1386,"state":"closed","locked":false,"title":"game sprite brightness","user":{"login":"pelikhan","id":4175913,"node_id":"MDQ6VXNlcjQxNzU5MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4175913?v=4","gravatar_id":"","url":"https://api.github.com/users/pelikhan","html_url":"https://github.com/pelikhan","followers_url":"https://api.github.com/users/pelikhan/followers","following_url":"https://api.github.com/users/pelikhan/following{/other_user}","gists_url":"https://api.github.com/users/pelikhan/gists{/gist_id}","starred_url":"https://api.github.com/users/pelikhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelikhan/subscriptions","organizations_url":"https://api.github.com/users/pelikhan/orgs","repos_url":"https://api.github.com/users/pelikhan/repos","events_url":"https://api.github.com/users/pelikhan/events{/privacy}","received_events_url":"https://api.github.com/users/pelikhan/received_events","type":"User","site_admin":false},"body":"Fix for https://github.com/Microsoft/pxt-microbit/issues/1344\r\n\r\nThe game engine needs the screen to go in greyscale mode. In v0, this had sideeffects on showLeds because showLeds was setting the brightness to 1 so it would just go dark.\r\n\r\nIn this change, the game engine sets the greyscale mode and keeps it there. ShowLeds creates images with 255 brightness so there is no visible side effect.\r\n\r\n![brightness](https://user-images.githubusercontent.com/4175913/46832473-f8387380-cd5a-11e8-9e29-13a5353bf3b5.gif)\r\n\r\nTo allow users to control the screen mode, I have expose led.setDisplayMode as a block\r\n\r\n![image](https://user-images.githubusercontent.com/4175913/46832469-f53d8300-cd5a-11e8-94f2-f3fb12e3db33.png)\r\n","created_at":"2018-10-11T20:40:28Z","updated_at":"2018-10-11T21:08:47Z","closed_at":"2018-10-11T21:08:47Z","merged_at":"2018-10-11T21:08:47Z","merge_commit_sha":"4b2ed73382715abe016176dc8e51b810c4dc8670","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/1386/comments","statuses_url":"https://api.github.com/repos/Microsoft/pxt-microbit/statuses/90d41c17b55fa5b9fd2a5e10eecf151d10305462","head":{"label":"Microsoft:pixelbrightness","ref":"pixelbrightness","sha":"90d41c17b55fa5b9fd2a5e10eecf151d10305462","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":53611065,"node_id":"MDEwOlJlcG9zaXRvcnk1MzYxMTA2NQ==","name":"pxt-microbit","full_name":"Microsoft/pxt-microbit","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pxt-microbit","description":"A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode","fork":false,"url":"https://api.github.com/repos/Microsoft/pxt-microbit","forks_url":"https://api.github.com/repos/Microsoft/pxt-microbit/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt-microbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt-microbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt-microbit/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt-microbit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt-microbit/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt-microbit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt-microbit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt-microbit/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt-microbit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt-microbit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt-microbit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt-microbit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt-microbit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt-microbit/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt-microbit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt-microbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt-microbit/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt-microbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt-microbit/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt-microbit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt-microbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt-microbit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt-microbit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt-microbit/deployments","created_at":"2016-03-10T19:27:31Z","updated_at":"2018-10-11T20:53:16Z","pushed_at":"2018-10-11T21:08:47Z","git_url":"git://github.com/Microsoft/pxt-microbit.git","ssh_url":"git@github.com:Microsoft/pxt-microbit.git","clone_url":"https://github.com/Microsoft/pxt-microbit.git","svn_url":"https://github.com/Microsoft/pxt-microbit","homepage":"https://makecode.microbit.org","size":170641,"stargazers_count":196,"watchers_count":196,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":189,"open_issues":137,"watchers":196,"default_branch":"master"}},"base":{"label":"Microsoft:v1","ref":"v1","sha":"37404acbcccb6b93c58c84732b4537553865dce3","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":53611065,"node_id":"MDEwOlJlcG9zaXRvcnk1MzYxMTA2NQ==","name":"pxt-microbit","full_name":"Microsoft/pxt-microbit","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/pxt-microbit","description":"A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode","fork":false,"url":"https://api.github.com/repos/Microsoft/pxt-microbit","forks_url":"https://api.github.com/repos/Microsoft/pxt-microbit/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt-microbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt-microbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt-microbit/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt-microbit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt-microbit/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt-microbit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt-microbit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt-microbit/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt-microbit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt-microbit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt-microbit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt-microbit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt-microbit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt-microbit/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt-microbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt-microbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt-microbit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt-microbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt-microbit/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt-microbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt-microbit/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt-microbit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt-microbit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt-microbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt-microbit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt-microbit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt-microbit/deployments","created_at":"2016-03-10T19:27:31Z","updated_at":"2018-10-11T20:53:16Z","pushed_at":"2018-10-11T21:08:47Z","git_url":"git://github.com/Microsoft/pxt-microbit.git","ssh_url":"git@github.com:Microsoft/pxt-microbit.git","clone_url":"https://github.com/Microsoft/pxt-microbit.git","svn_url":"https://github.com/Microsoft/pxt-microbit","homepage":"https://makecode.microbit.org","size":170641,"stargazers_count":196,"watchers_count":196,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":189,"open_issues":137,"watchers":196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/1386"},"html":{"href":"https://github.com/Microsoft/pxt-microbit/pull/1386"},"issue":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/1386"},"comments":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pxt-microbit/statuses/90d41c17b55fa5b9fd2a5e10eecf151d10305462"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pelikhan","id":4175913,"node_id":"MDQ6VXNlcjQxNzU5MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/4175913?v=4","gravatar_id":"","url":"https://api.github.com/users/pelikhan","html_url":"https://github.com/pelikhan","followers_url":"https://api.github.com/users/pelikhan/followers","following_url":"https://api.github.com/users/pelikhan/following{/other_user}","gists_url":"https://api.github.com/users/pelikhan/gists{/gist_id}","starred_url":"https://api.github.com/users/pelikhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelikhan/subscriptions","organizations_url":"https://api.github.com/users/pelikhan/orgs","repos_url":"https://api.github.com/users/pelikhan/repos","events_url":"https://api.github.com/users/pelikhan/events{/privacy}","received_events_url":"https://api.github.com/users/pelikhan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"pelikhan"}}