{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/olinlibrary/abe-web/pulls/166","id":185245092,"html_url":"https://github.com/olinlibrary/abe-web/pull/166","diff_url":"https://github.com/olinlibrary/abe-web/pull/166.diff","patch_url":"https://github.com/olinlibrary/abe-web/pull/166.patch","issue_url":"https://api.github.com/repos/olinlibrary/abe-web/issues/166","number":166,"state":"closed","locked":false,"title":"Invalid events weren't showing alerts","user":{"login":"osteele","id":674,"avatar_url":"https://avatars2.githubusercontent.com/u/674?v=4","gravatar_id":"","url":"https://api.github.com/users/osteele","html_url":"https://github.com/osteele","followers_url":"https://api.github.com/users/osteele/followers","following_url":"https://api.github.com/users/osteele/following{/other_user}","gists_url":"https://api.github.com/users/osteele/gists{/gist_id}","starred_url":"https://api.github.com/users/osteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osteele/subscriptions","organizations_url":"https://api.github.com/users/osteele/orgs","repos_url":"https://api.github.com/users/osteele/repos","events_url":"https://api.github.com/users/osteele/events{/privacy}","received_events_url":"https://api.github.com/users/osteele/received_events","type":"User","site_admin":false},"body":"`AddEditEventPage.validateInput()` was ignoring the rest of the tests if the title was non-empty.\r\n\r\nThis would be a great spot to add tests, but I foundered on `import MenuIconSVG from 'svg-react-loader?name=Icon!../../assets/menu-icon.svg';` in `menu-icon-button.jsx` not working in Jest, and timed out on workarounds / solutions.\r\n\r\nInstead, I tested some of the cases manually.\r\n\r\n## Required\r\nChanges must conform to these requirements:\r\n* [x] `yarn test` passes.  All new and existing tests pass.\r\n* [x] `yarn lint` passes. All new code follows the code style of this project.\r\n\r\n## Aspirational\r\nWe don't yet require these, but they are nice to have:\r\n* [ ] New code is covered by new or existing tests.\r\n* [ ] Changed code is covered by new or existing tests.","created_at":"2018-05-01T18:43:23Z","updated_at":"2018-05-02T20:33:18Z","closed_at":"2018-05-02T20:33:18Z","merged_at":"2018-05-02T20:33:18Z","merge_commit_sha":"21068cd0d9ae5d6291e892b317896f2d699cf61f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/olinlibrary/abe-web/pulls/166/commits","review_comments_url":"https://api.github.com/repos/olinlibrary/abe-web/pulls/166/comments","review_comment_url":"https://api.github.com/repos/olinlibrary/abe-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/olinlibrary/abe-web/issues/166/comments","statuses_url":"https://api.github.com/repos/olinlibrary/abe-web/statuses/fbaae073eced210d4808616ae5a969d5982780d7","head":{"label":"olinlibrary:osteele/dev","ref":"osteele/dev","sha":"fbaae073eced210d4808616ae5a969d5982780d7","user":{"login":"olinlibrary","id":12943194,"avatar_url":"https://avatars3.githubusercontent.com/u/12943194?v=4","gravatar_id":"","url":"https://api.github.com/users/olinlibrary","html_url":"https://github.com/olinlibrary","followers_url":"https://api.github.com/users/olinlibrary/followers","following_url":"https://api.github.com/users/olinlibrary/following{/other_user}","gists_url":"https://api.github.com/users/olinlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/olinlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olinlibrary/subscriptions","organizations_url":"https://api.github.com/users/olinlibrary/orgs","repos_url":"https://api.github.com/users/olinlibrary/repos","events_url":"https://api.github.com/users/olinlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/olinlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":94138060,"name":"abe-web","full_name":"olinlibrary/abe-web","owner":{"login":"olinlibrary","id":12943194,"avatar_url":"https://avatars3.githubusercontent.com/u/12943194?v=4","gravatar_id":"","url":"https://api.github.com/users/olinlibrary","html_url":"https://github.com/olinlibrary","followers_url":"https://api.github.com/users/olinlibrary/followers","following_url":"https://api.github.com/users/olinlibrary/following{/other_user}","gists_url":"https://api.github.com/users/olinlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/olinlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olinlibrary/subscriptions","organizations_url":"https://api.github.com/users/olinlibrary/orgs","repos_url":"https://api.github.com/users/olinlibrary/repos","events_url":"https://api.github.com/users/olinlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/olinlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/olinlibrary/abe-web","description":"A Web front-end for ABE (the Amorphous Blog of Events).","fork":false,"url":"https://api.github.com/repos/olinlibrary/abe-web","forks_url":"https://api.github.com/repos/olinlibrary/abe-web/forks","keys_url":"https://api.github.com/repos/olinlibrary/abe-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olinlibrary/abe-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olinlibrary/abe-web/teams","hooks_url":"https://api.github.com/repos/olinlibrary/abe-web/hooks","issue_events_url":"https://api.github.com/repos/olinlibrary/abe-web/issues/events{/number}","events_url":"https://api.github.com/repos/olinlibrary/abe-web/events","assignees_url":"https://api.github.com/repos/olinlibrary/abe-web/assignees{/user}","branches_url":"https://api.github.com/repos/olinlibrary/abe-web/branches{/branch}","tags_url":"https://api.github.com/repos/olinlibrary/abe-web/tags","blobs_url":"https://api.github.com/repos/olinlibrary/abe-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olinlibrary/abe-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olinlibrary/abe-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/olinlibrary/abe-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olinlibrary/abe-web/statuses/{sha}","languages_url":"https://api.github.com/repos/olinlibrary/abe-web/languages","stargazers_url":"https://api.github.com/repos/olinlibrary/abe-web/stargazers","contributors_url":"https://api.github.com/repos/olinlibrary/abe-web/contributors","subscribers_url":"https://api.github.com/repos/olinlibrary/abe-web/subscribers","subscription_url":"https://api.github.com/repos/olinlibrary/abe-web/subscription","commits_url":"https://api.github.com/repos/olinlibrary/abe-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/olinlibrary/abe-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/olinlibrary/abe-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/olinlibrary/abe-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/olinlibrary/abe-web/contents/{+path}","compare_url":"https://api.github.com/repos/olinlibrary/abe-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olinlibrary/abe-web/merges","archive_url":"https://api.github.com/repos/olinlibrary/abe-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olinlibrary/abe-web/downloads","issues_url":"https://api.github.com/repos/olinlibrary/abe-web/issues{/number}","pulls_url":"https://api.github.com/repos/olinlibrary/abe-web/pulls{/number}","milestones_url":"https://api.github.com/repos/olinlibrary/abe-web/milestones{/number}","notifications_url":"https://api.github.com/repos/olinlibrary/abe-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olinlibrary/abe-web/labels{/name}","releases_url":"https://api.github.com/repos/olinlibrary/abe-web/releases{/id}","deployments_url":"https://api.github.com/repos/olinlibrary/abe-web/deployments","created_at":"2017-06-12T20:35:29Z","updated_at":"2018-05-01T18:35:21Z","pushed_at":"2018-05-02T20:33:18Z","git_url":"git://github.com/olinlibrary/abe-web.git","ssh_url":"git@github.com:olinlibrary/abe-web.git","clone_url":"https://github.com/olinlibrary/abe-web.git","svn_url":"https://github.com/olinlibrary/abe-web","homepage":"https://events.olin.build/","size":3601,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":36,"watchers":4,"default_branch":"dev"}},"base":{"label":"olinlibrary:dev","ref":"dev","sha":"b59936b2e9784f28e946505a4eaa84d95fd284aa","user":{"login":"olinlibrary","id":12943194,"avatar_url":"https://avatars3.githubusercontent.com/u/12943194?v=4","gravatar_id":"","url":"https://api.github.com/users/olinlibrary","html_url":"https://github.com/olinlibrary","followers_url":"https://api.github.com/users/olinlibrary/followers","following_url":"https://api.github.com/users/olinlibrary/following{/other_user}","gists_url":"https://api.github.com/users/olinlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/olinlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olinlibrary/subscriptions","organizations_url":"https://api.github.com/users/olinlibrary/orgs","repos_url":"https://api.github.com/users/olinlibrary/repos","events_url":"https://api.github.com/users/olinlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/olinlibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":94138060,"name":"abe-web","full_name":"olinlibrary/abe-web","owner":{"login":"olinlibrary","id":12943194,"avatar_url":"https://avatars3.githubusercontent.com/u/12943194?v=4","gravatar_id":"","url":"https://api.github.com/users/olinlibrary","html_url":"https://github.com/olinlibrary","followers_url":"https://api.github.com/users/olinlibrary/followers","following_url":"https://api.github.com/users/olinlibrary/following{/other_user}","gists_url":"https://api.github.com/users/olinlibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/olinlibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olinlibrary/subscriptions","organizations_url":"https://api.github.com/users/olinlibrary/orgs","repos_url":"https://api.github.com/users/olinlibrary/repos","events_url":"https://api.github.com/users/olinlibrary/events{/privacy}","received_events_url":"https://api.github.com/users/olinlibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/olinlibrary/abe-web","description":"A Web front-end for ABE (the Amorphous Blog of Events).","fork":false,"url":"https://api.github.com/repos/olinlibrary/abe-web","forks_url":"https://api.github.com/repos/olinlibrary/abe-web/forks","keys_url":"https://api.github.com/repos/olinlibrary/abe-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olinlibrary/abe-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olinlibrary/abe-web/teams","hooks_url":"https://api.github.com/repos/olinlibrary/abe-web/hooks","issue_events_url":"https://api.github.com/repos/olinlibrary/abe-web/issues/events{/number}","events_url":"https://api.github.com/repos/olinlibrary/abe-web/events","assignees_url":"https://api.github.com/repos/olinlibrary/abe-web/assignees{/user}","branches_url":"https://api.github.com/repos/olinlibrary/abe-web/branches{/branch}","tags_url":"https://api.github.com/repos/olinlibrary/abe-web/tags","blobs_url":"https://api.github.com/repos/olinlibrary/abe-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olinlibrary/abe-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olinlibrary/abe-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/olinlibrary/abe-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olinlibrary/abe-web/statuses/{sha}","languages_url":"https://api.github.com/repos/olinlibrary/abe-web/languages","stargazers_url":"https://api.github.com/repos/olinlibrary/abe-web/stargazers","contributors_url":"https://api.github.com/repos/olinlibrary/abe-web/contributors","subscribers_url":"https://api.github.com/repos/olinlibrary/abe-web/subscribers","subscription_url":"https://api.github.com/repos/olinlibrary/abe-web/subscription","commits_url":"https://api.github.com/repos/olinlibrary/abe-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/olinlibrary/abe-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/olinlibrary/abe-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/olinlibrary/abe-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/olinlibrary/abe-web/contents/{+path}","compare_url":"https://api.github.com/repos/olinlibrary/abe-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olinlibrary/abe-web/merges","archive_url":"https://api.github.com/repos/olinlibrary/abe-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olinlibrary/abe-web/downloads","issues_url":"https://api.github.com/repos/olinlibrary/abe-web/issues{/number}","pulls_url":"https://api.github.com/repos/olinlibrary/abe-web/pulls{/number}","milestones_url":"https://api.github.com/repos/olinlibrary/abe-web/milestones{/number}","notifications_url":"https://api.github.com/repos/olinlibrary/abe-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olinlibrary/abe-web/labels{/name}","releases_url":"https://api.github.com/repos/olinlibrary/abe-web/releases{/id}","deployments_url":"https://api.github.com/repos/olinlibrary/abe-web/deployments","created_at":"2017-06-12T20:35:29Z","updated_at":"2018-05-01T18:35:21Z","pushed_at":"2018-05-02T20:33:18Z","git_url":"git://github.com/olinlibrary/abe-web.git","ssh_url":"git@github.com:olinlibrary/abe-web.git","clone_url":"https://github.com/olinlibrary/abe-web.git","svn_url":"https://github.com/olinlibrary/abe-web","homepage":"https://events.olin.build/","size":3601,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":36,"watchers":4,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/olinlibrary/abe-web/pulls/166"},"html":{"href":"https://github.com/olinlibrary/abe-web/pull/166"},"issue":{"href":"https://api.github.com/repos/olinlibrary/abe-web/issues/166"},"comments":{"href":"https://api.github.com/repos/olinlibrary/abe-web/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/olinlibrary/abe-web/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/olinlibrary/abe-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/olinlibrary/abe-web/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/olinlibrary/abe-web/statuses/fbaae073eced210d4808616ae5a969d5982780d7"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kylecombes","id":3915596,"avatar_url":"https://avatars0.githubusercontent.com/u/3915596?v=4","gravatar_id":"","url":"https://api.github.com/users/kylecombes","html_url":"https://github.com/kylecombes","followers_url":"https://api.github.com/users/kylecombes/followers","following_url":"https://api.github.com/users/kylecombes/following{/other_user}","gists_url":"https://api.github.com/users/kylecombes/gists{/gist_id}","starred_url":"https://api.github.com/users/kylecombes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylecombes/subscriptions","organizations_url":"https://api.github.com/users/kylecombes/orgs","repos_url":"https://api.github.com/users/kylecombes/repos","events_url":"https://api.github.com/users/kylecombes/events{/privacy}","received_events_url":"https://api.github.com/users/kylecombes/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"kylecombes"}}