{"action":"closed","number":9834,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/9834","id":223546124,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTQ2MTI0","html_url":"https://github.com/Sylius/Sylius/pull/9834","diff_url":"https://github.com/Sylius/Sylius/pull/9834.diff","patch_url":"https://github.com/Sylius/Sylius/pull/9834.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/9834","number":9834,"state":"closed","locked":false,"title":"Use SyliusShop simple menu template","user":{"login":"maximehuran","id":11380627,"node_id":"MDQ6VXNlcjExMzgwNjI3","avatar_url":"https://avatars1.githubusercontent.com/u/11380627?v=4","gravatar_id":"","url":"https://api.github.com/users/maximehuran","html_url":"https://github.com/maximehuran","followers_url":"https://api.github.com/users/maximehuran/followers","following_url":"https://api.github.com/users/maximehuran/following{/other_user}","gists_url":"https://api.github.com/users/maximehuran/gists{/gist_id}","starred_url":"https://api.github.com/users/maximehuran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximehuran/subscriptions","organizations_url":"https://api.github.com/users/maximehuran/orgs","repos_url":"https://api.github.com/users/maximehuran/repos","events_url":"https://api.github.com/users/maximehuran/events{/privacy}","received_events_url":"https://api.github.com/users/maximehuran/received_events","type":"User","site_admin":false},"body":"## Adding a menu template to ShopBundle\r\n\r\nI created the file `Menu/simple.html.twig` in `SyliusShopBundle` in order to be able to override this template in theme and only impact the front. With that, we can customize our shop without break the admin render.\r\n\r\n## Change UiBundle calls in ShopBundle\r\n\r\nI changed the menu called in `ShopBundle/Resources/views/Account/layout.html.twig`.\r\nThe `Menu/simple.html.twig` is only called in this template. In the future, if I want to use it on admin and/or in front I will be able to customize it.\r\n\r\nThank you for your amazing work on Sylius 🚀\r\nIf you want more information, ask me 👀","created_at":"2018-10-17T10:18:21Z","updated_at":"2018-10-18T11:15:52Z","closed_at":"2018-10-18T11:15:52Z","merged_at":"2018-10-18T11:15:52Z","merge_commit_sha":"1879e00ab2b588030f013dce31c0faca1d0780c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":236064219,"node_id":"MDU6TGFiZWwyMzYwNjQyMTk=","url":"https://api.github.com/repos/Sylius/Sylius/labels/DX","name":"DX","color":"5319e7","default":false},{"id":370902678,"node_id":"MDU6TGFiZWwzNzA5MDI2Nzg=","url":"https://api.github.com/repos/Sylius/Sylius/labels/Shop","name":"Shop","color":"1abb9c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/9834/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/9834/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/9834/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/642655b0b07a489bf7ee593992acb64c41d085d9","head":{"label":"maximehuran:feature/shop-menu-simple","ref":"feature/shop-menu-simple","sha":"642655b0b07a489bf7ee593992acb64c41d085d9","user":{"login":"maximehuran","id":11380627,"node_id":"MDQ6VXNlcjExMzgwNjI3","avatar_url":"https://avatars1.githubusercontent.com/u/11380627?v=4","gravatar_id":"","url":"https://api.github.com/users/maximehuran","html_url":"https://github.com/maximehuran","followers_url":"https://api.github.com/users/maximehuran/followers","following_url":"https://api.github.com/users/maximehuran/following{/other_user}","gists_url":"https://api.github.com/users/maximehuran/gists{/gist_id}","starred_url":"https://api.github.com/users/maximehuran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximehuran/subscriptions","organizations_url":"https://api.github.com/users/maximehuran/orgs","repos_url":"https://api.github.com/users/maximehuran/repos","events_url":"https://api.github.com/users/maximehuran/events{/privacy}","received_events_url":"https://api.github.com/users/maximehuran/received_events","type":"User","site_admin":false},"repo":{"id":145838449,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4Mzg0NDk=","name":"Sylius","full_name":"maximehuran/Sylius","private":false,"owner":{"login":"maximehuran","id":11380627,"node_id":"MDQ6VXNlcjExMzgwNjI3","avatar_url":"https://avatars1.githubusercontent.com/u/11380627?v=4","gravatar_id":"","url":"https://api.github.com/users/maximehuran","html_url":"https://github.com/maximehuran","followers_url":"https://api.github.com/users/maximehuran/followers","following_url":"https://api.github.com/users/maximehuran/following{/other_user}","gists_url":"https://api.github.com/users/maximehuran/gists{/gist_id}","starred_url":"https://api.github.com/users/maximehuran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximehuran/subscriptions","organizations_url":"https://api.github.com/users/maximehuran/orgs","repos_url":"https://api.github.com/users/maximehuran/repos","events_url":"https://api.github.com/users/maximehuran/events{/privacy}","received_events_url":"https://api.github.com/users/maximehuran/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maximehuran/Sylius","description":"Open Source eCommerce Framework on top of Symfony","fork":true,"url":"https://api.github.com/repos/maximehuran/Sylius","forks_url":"https://api.github.com/repos/maximehuran/Sylius/forks","keys_url":"https://api.github.com/repos/maximehuran/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maximehuran/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maximehuran/Sylius/teams","hooks_url":"https://api.github.com/repos/maximehuran/Sylius/hooks","issue_events_url":"https://api.github.com/repos/maximehuran/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/maximehuran/Sylius/events","assignees_url":"https://api.github.com/repos/maximehuran/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/maximehuran/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/maximehuran/Sylius/tags","blobs_url":"https://api.github.com/repos/maximehuran/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maximehuran/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maximehuran/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/maximehuran/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maximehuran/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/maximehuran/Sylius/languages","stargazers_url":"https://api.github.com/repos/maximehuran/Sylius/stargazers","contributors_url":"https://api.github.com/repos/maximehuran/Sylius/contributors","subscribers_url":"https://api.github.com/repos/maximehuran/Sylius/subscribers","subscription_url":"https://api.github.com/repos/maximehuran/Sylius/subscription","commits_url":"https://api.github.com/repos/maximehuran/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/maximehuran/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/maximehuran/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/maximehuran/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/maximehuran/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/maximehuran/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maximehuran/Sylius/merges","archive_url":"https://api.github.com/repos/maximehuran/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maximehuran/Sylius/downloads","issues_url":"https://api.github.com/repos/maximehuran/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/maximehuran/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/maximehuran/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/maximehuran/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maximehuran/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/maximehuran/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/maximehuran/Sylius/deployments","created_at":"2018-08-23T10:29:14Z","updated_at":"2018-10-17T09:43:36Z","pushed_at":"2018-10-18T07:19:47Z","git_url":"git://github.com/maximehuran/Sylius.git","ssh_url":"git@github.com:maximehuran/Sylius.git","clone_url":"https://github.com/maximehuran/Sylius.git","svn_url":"https://github.com/maximehuran/Sylius","homepage":"https://sylius.com","size":71517,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"b4988ae7c297f0080b8e218144c5c3633f01a77f","user":{"login":"Sylius","id":719423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE3NTQ5","name":"Sylius","full_name":"Sylius/Sylius","private":false,"owner":{"login":"Sylius","id":719423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Sylius/Sylius","description":"Open Source eCommerce Framework on top of Symfony","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2018-10-18T11:14:33Z","pushed_at":"2018-10-18T11:15:52Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"https://sylius.com","size":71537,"stargazers_count":4496,"watchers_count":4496,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1425,"mirror_url":null,"archived":false,"open_issues_count":225,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1425,"open_issues":225,"watchers":4496,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/9834"},"html":{"href":"https://github.com/Sylius/Sylius/pull/9834"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/9834"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/9834/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/9834/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/9834/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/642655b0b07a489bf7ee593992acb64c41d085d9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pamil","id":1897953,"node_id":"MDQ6VXNlcjE4OTc5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1897953?v=4","gravatar_id":"","url":"https://api.github.com/users/pamil","html_url":"https://github.com/pamil","followers_url":"https://api.github.com/users/pamil/followers","following_url":"https://api.github.com/users/pamil/following{/other_user}","gists_url":"https://api.github.com/users/pamil/gists{/gist_id}","starred_url":"https://api.github.com/users/pamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamil/subscriptions","organizations_url":"https://api.github.com/users/pamil/orgs","repos_url":"https://api.github.com/users/pamil/repos","events_url":"https://api.github.com/users/pamil/events{/privacy}","received_events_url":"https://api.github.com/users/pamil/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"pamil"}}