{"action":"created","comment":{"url":"https://api.github.com/repos/HadoukenIO/core/pulls/comments/207942210","pull_request_review_id":143654829,"id":207942210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzk0MjIxMA==","diff_hunk":"@@ -98,15 +97,22 @@\n \n \t\tasync function getExceptionData() {\n \t\t\tconst wnd = await fin.Window.getCurrent();\n-\t\t\tconst { customData } = await wnd.getOptions();\n+\t\t\tconst { customData: { title, error } } = await wnd.getOptions();\n+\t\t\tconst errorTitleEl = document.querySelector('#error-title');\n \t\t\tconst errorMessageEl = document.querySelector('#error-message');\n-\n-\t\t\terrorMessageEl.innerHTML = customData.error.stack;\n+\t\t\t\n+\t\t\tif (title) {\n+\t\t\t\terrorTitleEl.innerHTML = title;\n+\t\t\t} else {\n+\t\t\t\terrorTitleEl.remove();\n+\t\t\t}\n+\t\t\t\n+\t\t\terrorMessageEl.innerHTML = error;\n \t\t\t\n \t\t\t// Keep increasing the height of the error dialog until\n \t\t\t// the error message is fully visible. This will ensure\n \t\t\t// error dialogs are not too big in height.\n-\t\t\tlet resizeSafetyCount = 30; // for safety, max 30 resizes (300px)\n+\t\t\tlet resizeSafetyCount = 50; // for safety, max 50 resizes (500px)","path":"assets/error.html","position":34,"original_position":34,"commit_id":"5f807c230c5fa778141a9ad47e0091cde1d99890","original_commit_id":"3ecda0d0e6000bfc4b4b9d5e66b1c8a8c2708c4d","user":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"body":"Yeah, I agree, it doesn't look pretty, but the only alternative to this is under/over-sized error boxes which is also not pretty. This is, however, a \"hidden not pretty\" :)","created_at":"2018-08-06T15:52:46Z","updated_at":"2018-08-06T15:52:47Z","html_url":"https://github.com/HadoukenIO/core/pull/496#discussion_r207942210","pull_request_url":"https://api.github.com/repos/HadoukenIO/core/pulls/496","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/comments/207942210"},"html":{"href":"https://github.com/HadoukenIO/core/pull/496#discussion_r207942210"},"pull_request":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/496"}},"in_reply_to_id":206627946},"pull_request":{"url":"https://api.github.com/repos/HadoukenIO/core/pulls/496","id":204170633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTcwNjMz","html_url":"https://github.com/HadoukenIO/core/pull/496","diff_url":"https://github.com/HadoukenIO/core/pull/496.diff","patch_url":"https://github.com/HadoukenIO/core/pull/496.patch","issue_url":"https://api.github.com/repos/HadoukenIO/core/issues/496","number":496,"state":"open","locked":false,"title":"RUN-3911 normalize errors","user":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"body":"ℹ️ **About**\r\nThis PR:\r\n1. Improves our custom error dialog\r\n2. Uses our custom non-blocking error dialog to display app initialization errors (screenshot below)\r\n3. Uses our custom non-blocking error dialog to notify users about renderer crashes (screenshot below)\r\n\r\n➕ 3 new manual tests [here](https://github.com/openfin/test_apps/pull/32)\r\n\r\n🚥 **Automated test results**\r\n✅ [Windows 7](https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5b59de3854b21953031f380d)\r\n✅ [Windows 10](https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5b59df4054b21953031f380e)\r\n\r\n🖼 **Screenshots**\r\n\r\n1. App initialization\r\n![win10_safe_init](https://user-images.githubusercontent.com/5790216/43270134-545ba9f0-90c2-11e8-8290-86168abbc10a.png)\r\n\r\n2. App initialization custom message (our `customWindowAlert` app config flag)\r\n![win10_safe_init_custom](https://user-images.githubusercontent.com/5790216/43270191-6f6f77c6-90c2-11e8-90b4-7aa2abe7a95f.png)\r\n\r\n3. Renderer crash\r\n![win10_safe_renderer_crash](https://user-images.githubusercontent.com/5790216/43270211-7df77fdc-90c2-11e8-84fb-559add348049.png)\r\n","created_at":"2018-07-26T14:56:38Z","updated_at":"2018-08-06T15:52:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5539539c7af47bcf355ad9ba0a317bb1991b9ce5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":940152182,"node_id":"MDU6TGFiZWw5NDAxNTIxODI=","url":"https://api.github.com/repos/HadoukenIO/core/labels/cla-present","name":"cla-present","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HadoukenIO/core/pulls/496/commits","review_comments_url":"https://api.github.com/repos/HadoukenIO/core/pulls/496/comments","review_comment_url":"https://api.github.com/repos/HadoukenIO/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HadoukenIO/core/issues/496/comments","statuses_url":"https://api.github.com/repos/HadoukenIO/core/statuses/5f807c230c5fa778141a9ad47e0091cde1d99890","head":{"label":"whyn07m3:normalize_error","ref":"normalize_error","sha":"5f807c230c5fa778141a9ad47e0091cde1d99890","user":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"repo":{"id":90658340,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY1ODM0MA==","name":"core","full_name":"whyn07m3/core","owner":{"login":"whyn07m3","id":5790216,"node_id":"MDQ6VXNlcjU3OTAyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5790216?v=4","gravatar_id":"","url":"https://api.github.com/users/whyn07m3","html_url":"https://github.com/whyn07m3","followers_url":"https://api.github.com/users/whyn07m3/followers","following_url":"https://api.github.com/users/whyn07m3/following{/other_user}","gists_url":"https://api.github.com/users/whyn07m3/gists{/gist_id}","starred_url":"https://api.github.com/users/whyn07m3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyn07m3/subscriptions","organizations_url":"https://api.github.com/users/whyn07m3/orgs","repos_url":"https://api.github.com/users/whyn07m3/repos","events_url":"https://api.github.com/users/whyn07m3/events{/privacy}","received_events_url":"https://api.github.com/users/whyn07m3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whyn07m3/core","description":"Hadouken is an open-source runtime for building web applications with desktop experience. The OpenFin Core is the  reference implementation Javascript API for the Hadouken runtime.","fork":true,"url":"https://api.github.com/repos/whyn07m3/core","forks_url":"https://api.github.com/repos/whyn07m3/core/forks","keys_url":"https://api.github.com/repos/whyn07m3/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whyn07m3/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whyn07m3/core/teams","hooks_url":"https://api.github.com/repos/whyn07m3/core/hooks","issue_events_url":"https://api.github.com/repos/whyn07m3/core/issues/events{/number}","events_url":"https://api.github.com/repos/whyn07m3/core/events","assignees_url":"https://api.github.com/repos/whyn07m3/core/assignees{/user}","branches_url":"https://api.github.com/repos/whyn07m3/core/branches{/branch}","tags_url":"https://api.github.com/repos/whyn07m3/core/tags","blobs_url":"https://api.github.com/repos/whyn07m3/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whyn07m3/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whyn07m3/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/whyn07m3/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whyn07m3/core/statuses/{sha}","languages_url":"https://api.github.com/repos/whyn07m3/core/languages","stargazers_url":"https://api.github.com/repos/whyn07m3/core/stargazers","contributors_url":"https://api.github.com/repos/whyn07m3/core/contributors","subscribers_url":"https://api.github.com/repos/whyn07m3/core/subscribers","subscription_url":"https://api.github.com/repos/whyn07m3/core/subscription","commits_url":"https://api.github.com/repos/whyn07m3/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/whyn07m3/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/whyn07m3/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/whyn07m3/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/whyn07m3/core/contents/{+path}","compare_url":"https://api.github.com/repos/whyn07m3/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whyn07m3/core/merges","archive_url":"https://api.github.com/repos/whyn07m3/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whyn07m3/core/downloads","issues_url":"https://api.github.com/repos/whyn07m3/core/issues{/number}","pulls_url":"https://api.github.com/repos/whyn07m3/core/pulls{/number}","milestones_url":"https://api.github.com/repos/whyn07m3/core/milestones{/number}","notifications_url":"https://api.github.com/repos/whyn07m3/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whyn07m3/core/labels{/name}","releases_url":"https://api.github.com/repos/whyn07m3/core/releases{/id}","deployments_url":"https://api.github.com/repos/whyn07m3/core/deployments","created_at":"2017-05-08T18:10:38Z","updated_at":"2018-08-01T21:02:12Z","pushed_at":"2018-08-02T15:10:39Z","git_url":"git://github.com/whyn07m3/core.git","ssh_url":"git@github.com:whyn07m3/core.git","clone_url":"https://github.com/whyn07m3/core.git","svn_url":"https://github.com/whyn07m3/core","homepage":"http://hadouken.io/","size":1795,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HadoukenIO:develop","ref":"develop","sha":"46197793bd6343b5679c84cb4a50f5a319ea9955","user":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"repo":{"id":90180083,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE4MDA4Mw==","name":"core","full_name":"HadoukenIO/core","owner":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HadoukenIO/core","description":"Hadouken is an open-source platform for creating web applications with native desktop experience.  Hadouken is the base project used to build OpenFin OS, a desktop operating layer used by 45+ major banks, buy-side and vendors to deploy hundreds of apps to over 400 financial firms.","fork":false,"url":"https://api.github.com/repos/HadoukenIO/core","forks_url":"https://api.github.com/repos/HadoukenIO/core/forks","keys_url":"https://api.github.com/repos/HadoukenIO/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HadoukenIO/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HadoukenIO/core/teams","hooks_url":"https://api.github.com/repos/HadoukenIO/core/hooks","issue_events_url":"https://api.github.com/repos/HadoukenIO/core/issues/events{/number}","events_url":"https://api.github.com/repos/HadoukenIO/core/events","assignees_url":"https://api.github.com/repos/HadoukenIO/core/assignees{/user}","branches_url":"https://api.github.com/repos/HadoukenIO/core/branches{/branch}","tags_url":"https://api.github.com/repos/HadoukenIO/core/tags","blobs_url":"https://api.github.com/repos/HadoukenIO/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HadoukenIO/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HadoukenIO/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/HadoukenIO/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HadoukenIO/core/statuses/{sha}","languages_url":"https://api.github.com/repos/HadoukenIO/core/languages","stargazers_url":"https://api.github.com/repos/HadoukenIO/core/stargazers","contributors_url":"https://api.github.com/repos/HadoukenIO/core/contributors","subscribers_url":"https://api.github.com/repos/HadoukenIO/core/subscribers","subscription_url":"https://api.github.com/repos/HadoukenIO/core/subscription","commits_url":"https://api.github.com/repos/HadoukenIO/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/HadoukenIO/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/HadoukenIO/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/HadoukenIO/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/HadoukenIO/core/contents/{+path}","compare_url":"https://api.github.com/repos/HadoukenIO/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HadoukenIO/core/merges","archive_url":"https://api.github.com/repos/HadoukenIO/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HadoukenIO/core/downloads","issues_url":"https://api.github.com/repos/HadoukenIO/core/issues{/number}","pulls_url":"https://api.github.com/repos/HadoukenIO/core/pulls{/number}","milestones_url":"https://api.github.com/repos/HadoukenIO/core/milestones{/number}","notifications_url":"https://api.github.com/repos/HadoukenIO/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HadoukenIO/core/labels{/name}","releases_url":"https://api.github.com/repos/HadoukenIO/core/releases{/id}","deployments_url":"https://api.github.com/repos/HadoukenIO/core/deployments","created_at":"2017-05-03T18:21:22Z","updated_at":"2018-08-03T21:00:15Z","pushed_at":"2018-08-06T14:56:49Z","git_url":"git://github.com/HadoukenIO/core.git","ssh_url":"git@github.com:HadoukenIO/core.git","clone_url":"https://github.com/HadoukenIO/core.git","svn_url":"https://github.com/HadoukenIO/core","homepage":"http://hadouken.io/","size":1881,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":11,"watchers":68,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/496"},"html":{"href":"https://github.com/HadoukenIO/core/pull/496"},"issue":{"href":"https://api.github.com/repos/HadoukenIO/core/issues/496"},"comments":{"href":"https://api.github.com/repos/HadoukenIO/core/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/HadoukenIO/core/statuses/5f807c230c5fa778141a9ad47e0091cde1d99890"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"whyn07m3"}}