{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/222476436","pull_request_review_id":161373419,"id":222476436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ3NjQzNg==","diff_hunk":"@@ -30,6 +67,41 @@ def test_astype_object(self, tz_naive_fixture):\n         assert asobj.dtype == 'O'\n         assert list(asobj) == list(dti)\n \n+    @pytest.mark.parametrize('freqstr', ['D', 'B', 'W', 'M', 'Q', 'Y'])\n+    def test_to_period(self, datetime_index, freqstr):\n+        dti = datetime_index\n+        arr = DatetimeArrayMixin(dti)\n+\n+        expected = dti.to_period(freq=freqstr)\n+        result = arr.to_period(freq=freqstr)\n+        assert isinstance(result, PeriodArrayMixin)\n+\n+        # placeholder until these become actual EA subclasses and we can use\n+        #  an EA-specific tm.assert_ function\n+        tm.assert_index_equal(pd.Index(result), pd.Index(expected))","path":"pandas/tests/arrays/test_datetimelike.py","position":66,"original_position":66,"commit_id":"ed30d731b93d7518889abd1d6eece459de28776d","original_commit_id":"ed30d731b93d7518889abd1d6eece459de28776d","user":{"login":"jorisvandenbossche","id":1020496,"node_id":"MDQ6VXNlcjEwMjA0OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"I am not sure we should test the equivalence between the index and array method in the array tests, that feels a bit out of place (since it is the index one that is calling the array)","created_at":"2018-10-03T21:37:55Z","updated_at":"2018-10-03T21:37:55Z","html_url":"https://github.com/pandas-dev/pandas/pull/22961#discussion_r222476436","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/222476436"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22961#discussion_r222476436"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961","id":219901517,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTAxNTE3","html_url":"https://github.com/pandas-dev/pandas/pull/22961","diff_url":"https://github.com/pandas-dev/pandas/pull/22961.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/22961.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22961","number":22961,"state":"open","locked":false,"title":"Move some PI/DTI methods to EA subclasses, implement tests","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"If/when this goes through the basic template it creates for tests will be pretty straightforward to extend to the other relevant methods/properties.\r\n\r\n@TomAugspurger this definitely overlaps with #22862, particularly the pieces touching constructors.  LMK if this causes problems and I can try to stay in my lane.","created_at":"2018-10-03T02:58:05Z","updated_at":"2018-10-03T21:37:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c2ef617be3dc0b6eae0d87af3a42e1f3a6adbe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22961/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/ed30d731b93d7518889abd1d6eece459de28776d","head":{"label":"jbrockmendel:dlike3","ref":"dlike3","sha":"ed30d731b93d7518889abd1d6eece459de28776d","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"repo":{"id":96820953,"node_id":"MDEwOlJlcG9zaXRvcnk5NjgyMDk1Mw==","name":"pandas","full_name":"jbrockmendel/pandas","private":false,"owner":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbrockmendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jbrockmendel/pandas","forks_url":"https://api.github.com/repos/jbrockmendel/pandas/forks","keys_url":"https://api.github.com/repos/jbrockmendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrockmendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrockmendel/pandas/teams","hooks_url":"https://api.github.com/repos/jbrockmendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jbrockmendel/pandas/events","assignees_url":"https://api.github.com/repos/jbrockmendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jbrockmendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jbrockmendel/pandas/tags","blobs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrockmendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrockmendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrockmendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrockmendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jbrockmendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jbrockmendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jbrockmendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jbrockmendel/pandas/subscription","commits_url":"https://api.github.com/repos/jbrockmendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrockmendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrockmendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrockmendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jbrockmendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrockmendel/pandas/merges","archive_url":"https://api.github.com/repos/jbrockmendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrockmendel/pandas/downloads","issues_url":"https://api.github.com/repos/jbrockmendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jbrockmendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrockmendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrockmendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrockmendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jbrockmendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jbrockmendel/pandas/deployments","created_at":"2017-07-10T21:01:07Z","updated_at":"2017-07-10T21:01:15Z","pushed_at":"2018-10-03T21:34:42Z","git_url":"git://github.com/jbrockmendel/pandas.git","ssh_url":"git@github.com:jbrockmendel/pandas.git","clone_url":"https://github.com/jbrockmendel/pandas.git","svn_url":"https://github.com/jbrockmendel/pandas","homepage":"http://pandas.pydata.org","size":129754,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"ee808033bd5c546e7439a06d2ed37b57c9e66844","user":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"node_id":"MDEwOlJlcG9zaXRvcnk4NTgxMjc=","name":"pandas","full_name":"pandas-dev/pandas","private":false,"owner":{"login":"pandas-dev","id":21206976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjA2OTc2","avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-10-03T21:31:21Z","pushed_at":"2018-10-03T21:34:45Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"https://pandas.pydata.org","size":129892,"stargazers_count":16266,"watchers_count":16266,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6544,"mirror_url":null,"archived":false,"open_issues_count":2859,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6544,"open_issues":2859,"watchers":16266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/22961"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22961"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/22961/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/22961/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/ed30d731b93d7518889abd1d6eece459de28776d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jorisvandenbossche"}}