{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/203617648","pull_request_review_id":138541079,"id":203617648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzYxNzY0OA==","diff_hunk":"@@ -29,6 +32,24 @@ class ConfigurationHelperTest {\n         Assert.assertFalse(configuration.isPropertyDefined('something'))\n     }\n \n+    @Test\n+    void testGetPropertyNestedLeafNodeIsString() {\n+        def configuration = new ConfigurationHelper([a:[b: 'c']])\n+        assertThat(configuration.getConfigProperty('a/b'), is('c'))\n+    }\n+\n+    @Test\n+    void testGetPropertyNestedLeafNodeIsMap() {\n+        def configuration = new ConfigurationHelper([a:[b: [c: 'd']]])\n+        assertThat(configuration.getConfigProperty('a/b'), is([c: 'd']))\n+    }\n+\n+    @Test\n+    void testGetPropertyNestedPathNotFound() {\n+        def configuration = new ConfigurationHelper([a:[b: 'c']])\n+        assertThat(configuration.getConfigProperty('a/c'), is((nullValue())))\n+    }\n+","path":"test/groovy/com/sap/piper/ConfigurationHelperTest.groovy","position":32,"original_position":32,"commit_id":"3c25111eb39f0f930a3b7f5534f5f4245ee3c573","original_commit_id":"4f8f7be6aad9746c30f2bdb4791bf596b7f201c4","user":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"body":"Tests for the edge cases added. The underlying tokenizer handles ```//k/``` like ```k```. Any \"empty\" delimiters (also leading and trailing) are silently ignored. Now we can start an academical fight for raising exceptions in case of miss-located delimiters ...","created_at":"2018-07-19T06:50:23Z","updated_at":"2018-07-19T06:50:23Z","html_url":"https://github.com/SAP/jenkins-library/pull/216#discussion_r203617648","pull_request_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/216","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/203617648"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/216#discussion_r203617648"},"pull_request":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/216"}},"in_reply_to_id":203333711},"pull_request":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/216","id":201674599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjc0NTk5","html_url":"https://github.com/SAP/jenkins-library/pull/216","diff_url":"https://github.com/SAP/jenkins-library/pull/216.diff","patch_url":"https://github.com/SAP/jenkins-library/pull/216.patch","issue_url":"https://api.github.com/repos/SAP/jenkins-library/issues/216","number":216,"state":"open","locked":false,"title":"read nested properties","user":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"body":"See also:  #189","created_at":"2018-07-16T15:28:45Z","updated_at":"2018-07-19T06:50:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ce6165f26a638d3b9170a5b898735dd6ed36d67","assignee":null,"assignees":[],"requested_reviewers":[{"login":"daniel-kurzynski","id":4758527,"node_id":"MDQ6VXNlcjQ3NTg1Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/4758527?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-kurzynski","html_url":"https://github.com/daniel-kurzynski","followers_url":"https://api.github.com/users/daniel-kurzynski/followers","following_url":"https://api.github.com/users/daniel-kurzynski/following{/other_user}","gists_url":"https://api.github.com/users/daniel-kurzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-kurzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-kurzynski/subscriptions","organizations_url":"https://api.github.com/users/daniel-kurzynski/orgs","repos_url":"https://api.github.com/users/daniel-kurzynski/repos","events_url":"https://api.github.com/users/daniel-kurzynski/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-kurzynski/received_events","type":"User","site_admin":false},{"login":"CCFenner","id":26137398,"node_id":"MDQ6VXNlcjI2MTM3Mzk4","avatar_url":"https://avatars2.githubusercontent.com/u/26137398?v=4","gravatar_id":"","url":"https://api.github.com/users/CCFenner","html_url":"https://github.com/CCFenner","followers_url":"https://api.github.com/users/CCFenner/followers","following_url":"https://api.github.com/users/CCFenner/following{/other_user}","gists_url":"https://api.github.com/users/CCFenner/gists{/gist_id}","starred_url":"https://api.github.com/users/CCFenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCFenner/subscriptions","organizations_url":"https://api.github.com/users/CCFenner/orgs","repos_url":"https://api.github.com/users/CCFenner/repos","events_url":"https://api.github.com/users/CCFenner/events{/privacy}","received_events_url":"https://api.github.com/users/CCFenner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/216/commits","review_comments_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/216/comments","review_comment_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/issues/216/comments","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/3c25111eb39f0f930a3b7f5534f5f4245ee3c573","head":{"label":"marcusholl:pr/readNestedProperties","ref":"pr/readNestedProperties","sha":"3c25111eb39f0f930a3b7f5534f5f4245ee3c573","user":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"repo":{"id":110531482,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1MzE0ODI=","name":"jenkins-library","full_name":"marcusholl/jenkins-library","owner":{"login":"marcusholl","id":1853183,"node_id":"MDQ6VXNlcjE4NTMxODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcusholl/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":true,"url":"https://api.github.com/repos/marcusholl/jenkins-library","forks_url":"https://api.github.com/repos/marcusholl/jenkins-library/forks","keys_url":"https://api.github.com/repos/marcusholl/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcusholl/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcusholl/jenkins-library/teams","hooks_url":"https://api.github.com/repos/marcusholl/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/marcusholl/jenkins-library/events","assignees_url":"https://api.github.com/repos/marcusholl/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/marcusholl/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/marcusholl/jenkins-library/tags","blobs_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcusholl/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/marcusholl/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/marcusholl/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/marcusholl/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/marcusholl/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/marcusholl/jenkins-library/subscription","commits_url":"https://api.github.com/repos/marcusholl/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcusholl/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcusholl/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcusholl/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/marcusholl/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcusholl/jenkins-library/merges","archive_url":"https://api.github.com/repos/marcusholl/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcusholl/jenkins-library/downloads","issues_url":"https://api.github.com/repos/marcusholl/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/marcusholl/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/marcusholl/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/marcusholl/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcusholl/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/marcusholl/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/marcusholl/jenkins-library/deployments","created_at":"2017-11-13T10:05:10Z","updated_at":"2018-07-16T10:14:22Z","pushed_at":"2018-07-19T06:47:53Z","git_url":"git://github.com/marcusholl/jenkins-library.git","ssh_url":"git@github.com:marcusholl/jenkins-library.git","clone_url":"https://github.com/marcusholl/jenkins-library.git","svn_url":"https://github.com/marcusholl/jenkins-library","homepage":null,"size":1199,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"5609283a1030f8114e4e5850c741a095ad99ea56","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":107318996,"node_id":"MDEwOlJlcG9zaXRvcnkxMDczMTg5OTY=","name":"jenkins-library","full_name":"SAP/jenkins-library","owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SAP/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":false,"url":"https://api.github.com/repos/SAP/jenkins-library","forks_url":"https://api.github.com/repos/SAP/jenkins-library/forks","keys_url":"https://api.github.com/repos/SAP/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/jenkins-library/teams","hooks_url":"https://api.github.com/repos/SAP/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/SAP/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/jenkins-library/events","assignees_url":"https://api.github.com/repos/SAP/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/jenkins-library/tags","blobs_url":"https://api.github.com/repos/SAP/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/SAP/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/SAP/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/SAP/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/SAP/jenkins-library/subscription","commits_url":"https://api.github.com/repos/SAP/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/jenkins-library/merges","archive_url":"https://api.github.com/repos/SAP/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/jenkins-library/downloads","issues_url":"https://api.github.com/repos/SAP/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/SAP/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/jenkins-library/deployments","created_at":"2017-10-17T20:14:48Z","updated_at":"2018-07-18T10:56:47Z","pushed_at":"2018-07-19T06:47:55Z","git_url":"git://github.com/SAP/jenkins-library.git","ssh_url":"git@github.com:SAP/jenkins-library.git","clone_url":"https://github.com/SAP/jenkins-library.git","svn_url":"https://github.com/SAP/jenkins-library","homepage":null,"size":2151,"stargazers_count":75,"watchers_count":75,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":26,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/216"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/216"},"issue":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/216"},"comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/jenkins-library/statuses/3c25111eb39f0f930a3b7f5534f5f4245ee3c573"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marcusholl"}}