{"action":"created","issue":{"url":"https://api.github.com/repos/processwire/processwire-issues/issues/712","repository_url":"https://api.github.com/repos/processwire/processwire-issues","labels_url":"https://api.github.com/repos/processwire/processwire-issues/issues/712/labels{/name}","comments_url":"https://api.github.com/repos/processwire/processwire-issues/issues/712/comments","events_url":"https://api.github.com/repos/processwire/processwire-issues/issues/712/events","html_url":"https://github.com/processwire/processwire-issues/issues/712","id":363809769,"node_id":"MDU6SXNzdWUzNjM4MDk3Njk=","number":712,"title":"Session history grows indefinitely if $config->sessionHistory = 1","user":{"login":"Toutouwai","id":1538852,"node_id":"MDQ6VXNlcjE1Mzg4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1538852?v=4","gravatar_id":"","url":"https://api.github.com/users/Toutouwai","html_url":"https://github.com/Toutouwai","followers_url":"https://api.github.com/users/Toutouwai/followers","following_url":"https://api.github.com/users/Toutouwai/following{/other_user}","gists_url":"https://api.github.com/users/Toutouwai/gists{/gist_id}","starred_url":"https://api.github.com/users/Toutouwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toutouwai/subscriptions","organizations_url":"https://api.github.com/users/Toutouwai/orgs","repos_url":"https://api.github.com/users/Toutouwai/repos","events_url":"https://api.github.com/users/Toutouwai/events{/privacy}","received_events_url":"https://api.github.com/users/Toutouwai/received_events","type":"User","site_admin":false},"labels":[{"id":460748315,"node_id":"MDU6TGFiZWw0NjA3NDgzMTU=","url":"https://api.github.com/repos/processwire/processwire-issues/labels/resolution:%20fixed%20(close%20when%20ready)","name":"resolution: fixed (close when ready)","color":"bbbbbb","default":false},{"id":454427137,"node_id":"MDU6TGFiZWw0NTQ0MjcxMzc=","url":"https://api.github.com/repos/processwire/processwire-issues/labels/status:%20includes%20suggested%20fix","name":"status: includes suggested fix","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-26T00:02:04Z","updated_at":"2018-09-29T00:01:42Z","closed_at":"2018-09-29T00:01:42Z","author_association":"NONE","body":"### Short description of the issue\r\n\r\nIf $config->sessionHistory = 1 then the session history is not correctly limited to a single item. Instead the history keeps growing indefinitely.\r\n\r\n### Optional: Suggestion for a possible fix\r\n\r\nAt [line 1202 of Session.php](https://github.com/processwire/processwire/blob/e5900e7567215dfc4989e289bec8a3bd7ba481cb/wire/core/Session.php#L1202):\r\n\r\n```php\r\nif($cnt >= $historyCnt) $history = $historyCnt > 1 ? array_slice($history, -1 * ($historyCnt-1), null, true) : array();\r\n```\r\n\r\n### Setup/Environment\r\n\r\n* ProcessWire version: 3.0.114\r\n"},"comment":{"url":"https://api.github.com/repos/processwire/processwire-issues/issues/comments/425597460","html_url":"https://github.com/processwire/processwire-issues/issues/712#issuecomment-425597460","issue_url":"https://api.github.com/repos/processwire/processwire-issues/issues/712","id":425597460,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTU5NzQ2MA==","user":{"login":"Toutouwai","id":1538852,"node_id":"MDQ6VXNlcjE1Mzg4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1538852?v=4","gravatar_id":"","url":"https://api.github.com/users/Toutouwai","html_url":"https://github.com/Toutouwai","followers_url":"https://api.github.com/users/Toutouwai/followers","following_url":"https://api.github.com/users/Toutouwai/following{/other_user}","gists_url":"https://api.github.com/users/Toutouwai/gists{/gist_id}","starred_url":"https://api.github.com/users/Toutouwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toutouwai/subscriptions","organizations_url":"https://api.github.com/users/Toutouwai/orgs","repos_url":"https://api.github.com/users/Toutouwai/repos","events_url":"https://api.github.com/users/Toutouwai/events{/privacy}","received_events_url":"https://api.github.com/users/Toutouwai/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T00:01:42Z","updated_at":"2018-09-29T00:01:42Z","author_association":"NONE","body":"Thanks."}}
{"actor":{"display_login":"Toutouwai"}}