{"action":"closed","number":33254,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33254","id":228474653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDc0NjUz","html_url":"https://github.com/dotnet/corefx/pull/33254","diff_url":"https://github.com/dotnet/corefx/pull/33254.diff","patch_url":"https://github.com/dotnet/corefx/pull/33254.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33254","number":33254,"state":"closed","locked":false,"title":"Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop.","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"Fixes #32457 \r\n\r\nThese changes will remove the reference assets from the packages which have runtime-specific dependencies which are causing RAR to not see a conflict, and won't generate binding redirects to address the conflict. As part of this, we will also add validation that will ensure future packages won't hit the same problem either (that will come in a buildtools PR). Marking it as No Merge since we have to follow the shiproom process to get this in.\r\n\r\ncc: @ericstj @natemcmaster \r\n\r\n","created_at":"2018-11-05T20:05:24Z","updated_at":"2018-11-13T19:00:23Z","closed_at":"2018-11-13T19:00:23Z","merged_at":"2018-11-13T19:00:23Z","merge_commit_sha":"03bad43b5b063b46fdea07c2e292cf880bafb063","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/22","html_url":"https://github.com/dotnet/corefx/milestone/22","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/22/labels","id":3358829,"node_id":"MDk6TWlsZXN0b25lMzM1ODgyOQ==","number":22,"title":"2.1.x","description":".NET Core 2.1 Servicing Updates - https://github.com/dotnet/core/blob/master/release-notes/2.1/README.md","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":157,"state":"open","created_at":"2018-05-19T17:01:49Z","updated_at":"2018-11-13T19:00:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/33254/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/33254/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33254/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/79e5cd32edbee910ed38803b8ee05de0f0a73d15","head":{"label":"joperezr:RemovingRefsFromPackages","ref":"RemovingRefsFromPackages","sha":"79e5cd32edbee910ed38803b8ee05de0f0a73d15","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"repo":{"id":41888057,"node_id":"MDEwOlJlcG9zaXRvcnk0MTg4ODA1Nw==","name":"corefx","full_name":"joperezr/corefx","private":false,"owner":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joperezr/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/joperezr/corefx","forks_url":"https://api.github.com/repos/joperezr/corefx/forks","keys_url":"https://api.github.com/repos/joperezr/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joperezr/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joperezr/corefx/teams","hooks_url":"https://api.github.com/repos/joperezr/corefx/hooks","issue_events_url":"https://api.github.com/repos/joperezr/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/joperezr/corefx/events","assignees_url":"https://api.github.com/repos/joperezr/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/joperezr/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/joperezr/corefx/tags","blobs_url":"https://api.github.com/repos/joperezr/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joperezr/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joperezr/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/joperezr/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joperezr/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/joperezr/corefx/languages","stargazers_url":"https://api.github.com/repos/joperezr/corefx/stargazers","contributors_url":"https://api.github.com/repos/joperezr/corefx/contributors","subscribers_url":"https://api.github.com/repos/joperezr/corefx/subscribers","subscription_url":"https://api.github.com/repos/joperezr/corefx/subscription","commits_url":"https://api.github.com/repos/joperezr/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/joperezr/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/joperezr/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/joperezr/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/joperezr/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/joperezr/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joperezr/corefx/merges","archive_url":"https://api.github.com/repos/joperezr/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joperezr/corefx/downloads","issues_url":"https://api.github.com/repos/joperezr/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/joperezr/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/joperezr/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/joperezr/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joperezr/corefx/labels{/name}","releases_url":"https://api.github.com/repos/joperezr/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/joperezr/corefx/deployments","created_at":"2015-09-03T23:06:38Z","updated_at":"2018-11-02T20:15:16Z","pushed_at":"2018-11-11T19:39:19Z","git_url":"git://github.com/joperezr/corefx.git","ssh_url":"git@github.com:joperezr/corefx.git","clone_url":"https://github.com/joperezr/corefx.git","svn_url":"https://github.com/joperezr/corefx","homepage":"http://dotnet.github.io/core/","size":182945,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:release/2.1","ref":"release/2.1","sha":"8b52a2e8e2839ca316a748dc36fa79fd7d5f1047","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-13T18:03:52Z","pushed_at":"2018-11-13T19:00:23Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":192184,"stargazers_count":15133,"watchers_count":15133,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4481,"mirror_url":null,"archived":false,"open_issues_count":2620,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4481,"open_issues":2620,"watchers":15133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33254"},"html":{"href":"https://github.com/dotnet/corefx/pull/33254"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33254"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33254/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33254/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33254/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/79e5cd32edbee910ed38803b8ee05de0f0a73d15"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"comments":9,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":94,"deletions":26,"changed_files":15}}
{"actor":{"display_login":"joperezr"}}