{"action":"created","issue":{"url":"https://api.github.com/repos/NLog/NLog/issues/2194","repository_url":"https://api.github.com/repos/NLog/NLog","labels_url":"https://api.github.com/repos/NLog/NLog/issues/2194/labels{/name}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/2194/comments","events_url":"https://api.github.com/repos/NLog/NLog/issues/2194/events","html_url":"https://github.com/NLog/NLog/pull/2194","id":239946194,"node_id":"MDExOlB1bGxSZXF1ZXN0MTI4NDg2OTAz","number":2194,"title":"New Substring, Left & Right Wrappers","user":{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"labels":[{"id":32727452,"node_id":"MDU6TGFiZWwzMjcyNzQ1Mg==","url":"https://api.github.com/repos/NLog/NLog/labels/feature","name":"feature","color":"02e10c","default":false},{"id":179553523,"node_id":"MDU6TGFiZWwxNzk1NTM1MjM=","url":"https://api.github.com/repos/NLog/NLog/labels/needs%20documentation%20on%20wiki","name":"needs documentation on wiki","color":"d7e102","default":false},{"id":191519538,"node_id":"MDU6TGFiZWwxOTE1MTk1Mzg=","url":"https://api.github.com/repos/NLog/NLog/labels/work%20in%20progress","name":"work in progress","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/44","html_url":"https://github.com/NLog/NLog/milestone/44","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/44/labels","id":2533607,"node_id":"MDk6TWlsZXN0b25lMjUzMzYwNw==","number":44,"title":"4.6","description":"","creator":{"login":"304NotModified","id":5808377,"node_id":"MDQ6VXNlcjU4MDgzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5808377?v=4","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":7,"state":"open","created_at":"2017-05-21T12:35:33Z","updated_at":"2018-08-05T13:42:59Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2017-07-01T12:20:15Z","updated_at":"2018-08-06T10:02:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/2194","html_url":"https://github.com/NLog/NLog/pull/2194","diff_url":"https://github.com/NLog/NLog/pull/2194.diff","patch_url":"https://github.com/NLog/NLog/pull/2194.patch"},"body":"Examples:\r\n```\r\n${substring:${level}:start=2:length=2}    // from index 2, length 2\r\n${substring:${level}:start=-2:length=2}   // from end -2, length 2\r\n${left:${level}:length=2}    // from start, length 2\r\n${right:${level}:length=2}   // from end, length 2\r\n```\r\n\r\n\r\n- [x] negative start -> measure for end\r\n- [x] negative length? -> empty result\r\n- [ ] truncate stringbuilder"},"comment":{"url":"https://api.github.com/repos/NLog/NLog/issues/comments/410656122","html_url":"https://github.com/NLog/NLog/pull/2194#issuecomment-410656122","issue_url":"https://api.github.com/repos/NLog/NLog/issues/2194","id":410656122,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDY1NjEyMg==","user":{"login":"snakefoot","id":11509660,"node_id":"MDQ6VXNlcjExNTA5NjYw","avatar_url":"https://avatars3.githubusercontent.com/u/11509660?v=4","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T10:02:24Z","updated_at":"2018-08-06T10:02:24Z","author_association":"CONTRIBUTOR","body":"You should not inherit from BuilderBase but just override RenderInnerAndTransform\n________________________________\nFrom: Julian Verdurmen <notifications@github.com>\nSent: Sunday, August 5, 2018 9:58:09 PM\nTo: NLog/NLog\nCc: Rolf Kristensen; Mention\nSubject: Re: [NLog/NLog] New Substring, Left & Right Wrappers (#2194)\n\n\nInstead of doing a StringBuilder.Remove, then you should consider to allocate resulting-string, and truncate StringBuilder (assigning Length to zero), and then append string afterwards (Ofcouse if should just truncate from the right, then just truncate the StringBuilder by assigning Length to wanted value without allocating string).\n\n@snakefoot<https://github.com/snakefoot> you meant this? -> e568358<https://github.com/NLog/NLog/commit/e56835864544ecae06cbc70601d189be15ea5cbf>\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub<https://github.com/NLog/NLog/pull/2194#issuecomment-410551143>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AK-fnNcSMSs-6FTpzW96lJN989o-zWF9ks5uN2pxgaJpZM4OLTQG>.\n"}}
{"actor":{"display_login":"snakefoot"}}