{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/comments/236571012","pull_request_review_id":178668012,"id":236571012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjU3MTAxMg==","diff_hunk":"@@ -496,6 +500,9 @@ private String getSubject(Run<?, ?> build, String caption) {\n \n     /**\n      * Check whether a path (/-separated) will be archived.\n+     * @param build current build\n+     * @param path path","path":"src/main/java/hudson/tasks/MailSender.java","position":84,"original_position":84,"commit_id":"1e5f338c7112931b683703fca1b471294bc87d6a","original_commit_id":"1e5f338c7112931b683703fca1b471294bc87d6a","user":{"login":"alecharp","id":985955,"node_id":"MDQ6VXNlcjk4NTk1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/985955?v=4","gravatar_id":"","url":"https://api.github.com/users/alecharp","html_url":"https://github.com/alecharp","followers_url":"https://api.github.com/users/alecharp/followers","following_url":"https://api.github.com/users/alecharp/following{/other_user}","gists_url":"https://api.github.com/users/alecharp/gists{/gist_id}","starred_url":"https://api.github.com/users/alecharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecharp/subscriptions","organizations_url":"https://api.github.com/users/alecharp/orgs","repos_url":"https://api.github.com/users/alecharp/repos","events_url":"https://api.github.com/users/alecharp/events{/privacy}","received_events_url":"https://api.github.com/users/alecharp/received_events","type":"User","site_admin":false},"body":"please add a description","created_at":"2018-11-27T09:03:53Z","updated_at":"2018-11-27T09:21:07Z","html_url":"https://github.com/jenkinsci/mailer-plugin/pull/44#discussion_r236571012","pull_request_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/comments/236571012"},"html":{"href":"https://github.com/jenkinsci/mailer-plugin/pull/44#discussion_r236571012"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44","id":222448885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDQ4ODg1","html_url":"https://github.com/jenkinsci/mailer-plugin/pull/44","diff_url":"https://github.com/jenkinsci/mailer-plugin/pull/44.diff","patch_url":"https://github.com/jenkinsci/mailer-plugin/pull/44.patch","issue_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues/44","number":44,"state":"open","locked":false,"title":"Explicitly log not sending mails if no build result is set and fix some German umlauts apart from Javadoc warnings","user":{"login":"ottlinger","id":1323134,"node_id":"MDQ6VXNlcjEzMjMxMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1323134?v=4","gravatar_id":"","url":"https://api.github.com/users/ottlinger","html_url":"https://github.com/ottlinger","followers_url":"https://api.github.com/users/ottlinger/followers","following_url":"https://api.github.com/users/ottlinger/following{/other_user}","gists_url":"https://api.github.com/users/ottlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ottlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottlinger/subscriptions","organizations_url":"https://api.github.com/users/ottlinger/orgs","repos_url":"https://api.github.com/users/ottlinger/repos","events_url":"https://api.github.com/users/ottlinger/events{/privacy}","received_events_url":"https://api.github.com/users/ottlinger/received_events","type":"User","site_admin":false},"body":"While running into\r\nhttps://stackoverflow.com/questions/37169100/use-jenkins-mailer-inside-pipeline-workflow\r\nI realized that an explicit logging is needed if no build result is set.\r\n\r\nDuring pipeline runs no result is set and no mail is sent out.","created_at":"2018-10-12T12:23:37Z","updated_at":"2018-11-27T09:21:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56957aea7668273a13d281b01fe9866941fc383a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues/44/comments","statuses_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/statuses/1e5f338c7112931b683703fca1b471294bc87d6a","head":{"label":"ottlinger:master","ref":"master","sha":"1e5f338c7112931b683703fca1b471294bc87d6a","user":{"login":"ottlinger","id":1323134,"node_id":"MDQ6VXNlcjEzMjMxMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1323134?v=4","gravatar_id":"","url":"https://api.github.com/users/ottlinger","html_url":"https://github.com/ottlinger","followers_url":"https://api.github.com/users/ottlinger/followers","following_url":"https://api.github.com/users/ottlinger/following{/other_user}","gists_url":"https://api.github.com/users/ottlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ottlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottlinger/subscriptions","organizations_url":"https://api.github.com/users/ottlinger/orgs","repos_url":"https://api.github.com/users/ottlinger/repos","events_url":"https://api.github.com/users/ottlinger/events{/privacy}","received_events_url":"https://api.github.com/users/ottlinger/received_events","type":"User","site_admin":false},"repo":{"id":152743230,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3NDMyMzA=","name":"mailer-plugin","full_name":"ottlinger/mailer-plugin","private":false,"owner":{"login":"ottlinger","id":1323134,"node_id":"MDQ6VXNlcjEzMjMxMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1323134?v=4","gravatar_id":"","url":"https://api.github.com/users/ottlinger","html_url":"https://github.com/ottlinger","followers_url":"https://api.github.com/users/ottlinger/followers","following_url":"https://api.github.com/users/ottlinger/following{/other_user}","gists_url":"https://api.github.com/users/ottlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ottlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottlinger/subscriptions","organizations_url":"https://api.github.com/users/ottlinger/orgs","repos_url":"https://api.github.com/users/ottlinger/repos","events_url":"https://api.github.com/users/ottlinger/events{/privacy}","received_events_url":"https://api.github.com/users/ottlinger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ottlinger/mailer-plugin","description":"Breakout of the default Mailer from the Jenkins core.","fork":true,"url":"https://api.github.com/repos/ottlinger/mailer-plugin","forks_url":"https://api.github.com/repos/ottlinger/mailer-plugin/forks","keys_url":"https://api.github.com/repos/ottlinger/mailer-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ottlinger/mailer-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ottlinger/mailer-plugin/teams","hooks_url":"https://api.github.com/repos/ottlinger/mailer-plugin/hooks","issue_events_url":"https://api.github.com/repos/ottlinger/mailer-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ottlinger/mailer-plugin/events","assignees_url":"https://api.github.com/repos/ottlinger/mailer-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ottlinger/mailer-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ottlinger/mailer-plugin/tags","blobs_url":"https://api.github.com/repos/ottlinger/mailer-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ottlinger/mailer-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ottlinger/mailer-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ottlinger/mailer-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ottlinger/mailer-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ottlinger/mailer-plugin/languages","stargazers_url":"https://api.github.com/repos/ottlinger/mailer-plugin/stargazers","contributors_url":"https://api.github.com/repos/ottlinger/mailer-plugin/contributors","subscribers_url":"https://api.github.com/repos/ottlinger/mailer-plugin/subscribers","subscription_url":"https://api.github.com/repos/ottlinger/mailer-plugin/subscription","commits_url":"https://api.github.com/repos/ottlinger/mailer-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ottlinger/mailer-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ottlinger/mailer-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ottlinger/mailer-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ottlinger/mailer-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ottlinger/mailer-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ottlinger/mailer-plugin/merges","archive_url":"https://api.github.com/repos/ottlinger/mailer-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ottlinger/mailer-plugin/downloads","issues_url":"https://api.github.com/repos/ottlinger/mailer-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ottlinger/mailer-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ottlinger/mailer-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ottlinger/mailer-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ottlinger/mailer-plugin/labels{/name}","releases_url":"https://api.github.com/repos/ottlinger/mailer-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ottlinger/mailer-plugin/deployments","created_at":"2018-10-12T11:52:17Z","updated_at":"2018-10-28T21:12:37Z","pushed_at":"2018-10-28T21:12:35Z","git_url":"git://github.com/ottlinger/mailer-plugin.git","ssh_url":"git@github.com:ottlinger/mailer-plugin.git","clone_url":"https://github.com/ottlinger/mailer-plugin.git","svn_url":"https://github.com/ottlinger/mailer-plugin","homepage":null,"size":257,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"834cbd4aa6a1c3395e0e99c3edcd3a5a5402b5ad","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":5401338,"node_id":"MDEwOlJlcG9zaXRvcnk1NDAxMzM4","name":"mailer-plugin","full_name":"jenkinsci/mailer-plugin","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/mailer-plugin","description":"Breakout of the default Mailer from the Jenkins core.","fork":false,"url":"https://api.github.com/repos/jenkinsci/mailer-plugin","forks_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/mailer-plugin/deployments","created_at":"2012-08-13T16:11:00Z","updated_at":"2018-11-12T07:21:14Z","pushed_at":"2018-10-28T21:12:36Z","git_url":"git://github.com/jenkinsci/mailer-plugin.git","ssh_url":"git@github.com:jenkinsci/mailer-plugin.git","clone_url":"https://github.com/jenkinsci/mailer-plugin.git","svn_url":"https://github.com/jenkinsci/mailer-plugin","homepage":null,"size":244,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":53,"open_issues":9,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44"},"html":{"href":"https://github.com/jenkinsci/mailer-plugin/pull/44"},"issue":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues/44"},"comments":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/mailer-plugin/statuses/1e5f338c7112931b683703fca1b471294bc87d6a"}},"author_association":"NONE"}}
{"actor":{"display_login":"alecharp"}}