{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/payment-api/pulls/comments/169342479","pull_request_review_id":97852875,"id":169342479,"diff_hunk":"@@ -8,21 +8,15 @@ import play.api.inject.ApplicationLifecycle\n import scala.concurrent.Future\n \n // lifecycle used to add stop hooks so AWS clients can be closed when application is shutdown.\n-class AWSClientBuilder(lifecycle: ApplicationLifecycle) {\n+object AWSClientBuilder {","path":"src/main/scala/aws/AWSClientBuilder.scala","position":5,"original_position":5,"commit_id":"8ab1697882696b99ce77122ba126d0a69f3b5b37","original_commit_id":"8ab1697882696b99ce77122ba126d0a69f3b5b37","user":{"login":"Mullefa","id":4085817,"avatar_url":"https://avatars3.githubusercontent.com/u/4085817?v=4","gravatar_id":"","url":"https://api.github.com/users/Mullefa","html_url":"https://github.com/Mullefa","followers_url":"https://api.github.com/users/Mullefa/followers","following_url":"https://api.github.com/users/Mullefa/following{/other_user}","gists_url":"https://api.github.com/users/Mullefa/gists{/gist_id}","starred_url":"https://api.github.com/users/Mullefa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mullefa/subscriptions","organizations_url":"https://api.github.com/users/Mullefa/orgs","repos_url":"https://api.github.com/users/Mullefa/repos","events_url":"https://api.github.com/users/Mullefa/events{/privacy}","received_events_url":"https://api.github.com/users/Mullefa/received_events","type":"User","site_admin":false},"body":"I think we should introduce them at some point, but that they should be handled by another class. The specific issue I came across (which is not apparent in this pull request as I haven't included tests yet) was that the AWSClientBuilder could not be used easily to facilitate integration tests, as you have to have an `ApplicationLifecycle` in scope.","created_at":"2018-02-20T14:53:31Z","updated_at":"2018-02-20T14:53:32Z","html_url":"https://github.com/guardian/payment-api/pull/3#discussion_r169342479","pull_request_url":"https://api.github.com/repos/guardian/payment-api/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/guardian/payment-api/pulls/comments/169342479"},"html":{"href":"https://github.com/guardian/payment-api/pull/3#discussion_r169342479"},"pull_request":{"href":"https://api.github.com/repos/guardian/payment-api/pulls/3"}},"in_reply_to_id":169341081},"pull_request":{"url":"https://api.github.com/repos/guardian/payment-api/pulls/3","id":169688439,"html_url":"https://github.com/guardian/payment-api/pull/3","diff_url":"https://github.com/guardian/payment-api/pull/3.diff","patch_url":"https://github.com/guardian/payment-api/pull/3.patch","issue_url":"https://api.github.com/repos/guardian/payment-api/issues/3","number":3,"state":"open","locked":false,"title":"persist Stripe contributions to database","user":{"login":"Mullefa","id":4085817,"avatar_url":"https://avatars3.githubusercontent.com/u/4085817?v=4","gravatar_id":"","url":"https://api.github.com/users/Mullefa","html_url":"https://github.com/Mullefa","followers_url":"https://api.github.com/users/Mullefa/followers","following_url":"https://api.github.com/users/Mullefa/following{/other_user}","gists_url":"https://api.github.com/users/Mullefa/gists{/gist_id}","starred_url":"https://api.github.com/users/Mullefa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mullefa/subscriptions","organizations_url":"https://api.github.com/users/Mullefa/orgs","repos_url":"https://api.github.com/users/Mullefa/repos","events_url":"https://api.github.com/users/Mullefa/events{/privacy}","received_events_url":"https://api.github.com/users/Mullefa/received_events","type":"User","site_admin":false},"body":"This pull request aims to persist contribution data from a Stripe contribution (although the endpoint for the Stripe web hook will be handled in a separate pull request).\r\n\r\nSome things which are probably appropriate to discuss at this point:\r\n\r\n- do we want to persist all current fields to the database? e.g. contribution meta data fields - they are getting included in the acquisition event, so it is not clear which actually need them in the Postgres data base?\r\n- do we need to convert everything to be asynchronous?\r\n","created_at":"2018-02-16T17:59:18Z","updated_at":"2018-02-20T14:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d79d06a45d274601ba8a8b6537c6ccaeefc2ff96","assignee":null,"assignees":[],"requested_reviewers":[{"login":"svillafe","id":825398,"avatar_url":"https://avatars1.githubusercontent.com/u/825398?v=4","gravatar_id":"","url":"https://api.github.com/users/svillafe","html_url":"https://github.com/svillafe","followers_url":"https://api.github.com/users/svillafe/followers","following_url":"https://api.github.com/users/svillafe/following{/other_user}","gists_url":"https://api.github.com/users/svillafe/gists{/gist_id}","starred_url":"https://api.github.com/users/svillafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svillafe/subscriptions","organizations_url":"https://api.github.com/users/svillafe/orgs","repos_url":"https://api.github.com/users/svillafe/repos","events_url":"https://api.github.com/users/svillafe/events{/privacy}","received_events_url":"https://api.github.com/users/svillafe/received_events","type":"User","site_admin":false},{"login":"jranks123","id":2844554,"avatar_url":"https://avatars0.githubusercontent.com/u/2844554?v=4","gravatar_id":"","url":"https://api.github.com/users/jranks123","html_url":"https://github.com/jranks123","followers_url":"https://api.github.com/users/jranks123/followers","following_url":"https://api.github.com/users/jranks123/following{/other_user}","gists_url":"https://api.github.com/users/jranks123/gists{/gist_id}","starred_url":"https://api.github.com/users/jranks123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jranks123/subscriptions","organizations_url":"https://api.github.com/users/jranks123/orgs","repos_url":"https://api.github.com/users/jranks123/repos","events_url":"https://api.github.com/users/jranks123/events{/privacy}","received_events_url":"https://api.github.com/users/jranks123/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/payment-api/pulls/3/commits","review_comments_url":"https://api.github.com/repos/guardian/payment-api/pulls/3/comments","review_comment_url":"https://api.github.com/repos/guardian/payment-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/payment-api/issues/3/comments","statuses_url":"https://api.github.com/repos/guardian/payment-api/statuses/8ab1697882696b99ce77122ba126d0a69f3b5b37","head":{"label":"guardian:gd-stripe-endpoint-db-io","ref":"gd-stripe-endpoint-db-io","sha":"8ab1697882696b99ce77122ba126d0a69f3b5b37","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":118760328,"name":"payment-api","full_name":"guardian/payment-api","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/payment-api","description":"Placeholder description: @joelochlann created this with repo-genesis","fork":false,"url":"https://api.github.com/repos/guardian/payment-api","forks_url":"https://api.github.com/repos/guardian/payment-api/forks","keys_url":"https://api.github.com/repos/guardian/payment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/payment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/payment-api/teams","hooks_url":"https://api.github.com/repos/guardian/payment-api/hooks","issue_events_url":"https://api.github.com/repos/guardian/payment-api/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/payment-api/events","assignees_url":"https://api.github.com/repos/guardian/payment-api/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/payment-api/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/payment-api/tags","blobs_url":"https://api.github.com/repos/guardian/payment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/payment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/payment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/payment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/payment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/payment-api/languages","stargazers_url":"https://api.github.com/repos/guardian/payment-api/stargazers","contributors_url":"https://api.github.com/repos/guardian/payment-api/contributors","subscribers_url":"https://api.github.com/repos/guardian/payment-api/subscribers","subscription_url":"https://api.github.com/repos/guardian/payment-api/subscription","commits_url":"https://api.github.com/repos/guardian/payment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/payment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/payment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/payment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/payment-api/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/payment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/payment-api/merges","archive_url":"https://api.github.com/repos/guardian/payment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/payment-api/downloads","issues_url":"https://api.github.com/repos/guardian/payment-api/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/payment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/payment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/payment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/payment-api/labels{/name}","releases_url":"https://api.github.com/repos/guardian/payment-api/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/payment-api/deployments","created_at":"2018-01-24T12:07:16Z","updated_at":"2018-01-26T18:16:41Z","pushed_at":"2018-02-20T14:46:22Z","git_url":"git://github.com/guardian/payment-api.git","ssh_url":"git@github.com:guardian/payment-api.git","clone_url":"https://github.com/guardian/payment-api.git","svn_url":"https://github.com/guardian/payment-api","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"808e87e393b731665cae779d5df4691aa0fe4d41","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":118760328,"name":"payment-api","full_name":"guardian/payment-api","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/payment-api","description":"Placeholder description: @joelochlann created this with repo-genesis","fork":false,"url":"https://api.github.com/repos/guardian/payment-api","forks_url":"https://api.github.com/repos/guardian/payment-api/forks","keys_url":"https://api.github.com/repos/guardian/payment-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/payment-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/payment-api/teams","hooks_url":"https://api.github.com/repos/guardian/payment-api/hooks","issue_events_url":"https://api.github.com/repos/guardian/payment-api/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/payment-api/events","assignees_url":"https://api.github.com/repos/guardian/payment-api/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/payment-api/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/payment-api/tags","blobs_url":"https://api.github.com/repos/guardian/payment-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/payment-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/payment-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/payment-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/payment-api/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/payment-api/languages","stargazers_url":"https://api.github.com/repos/guardian/payment-api/stargazers","contributors_url":"https://api.github.com/repos/guardian/payment-api/contributors","subscribers_url":"https://api.github.com/repos/guardian/payment-api/subscribers","subscription_url":"https://api.github.com/repos/guardian/payment-api/subscription","commits_url":"https://api.github.com/repos/guardian/payment-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/payment-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/payment-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/payment-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/payment-api/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/payment-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/payment-api/merges","archive_url":"https://api.github.com/repos/guardian/payment-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/payment-api/downloads","issues_url":"https://api.github.com/repos/guardian/payment-api/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/payment-api/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/payment-api/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/payment-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/payment-api/labels{/name}","releases_url":"https://api.github.com/repos/guardian/payment-api/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/payment-api/deployments","created_at":"2018-01-24T12:07:16Z","updated_at":"2018-01-26T18:16:41Z","pushed_at":"2018-02-20T14:46:22Z","git_url":"git://github.com/guardian/payment-api.git","ssh_url":"git@github.com:guardian/payment-api.git","clone_url":"https://github.com/guardian/payment-api.git","svn_url":"https://github.com/guardian/payment-api","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/payment-api/pulls/3"},"html":{"href":"https://github.com/guardian/payment-api/pull/3"},"issue":{"href":"https://api.github.com/repos/guardian/payment-api/issues/3"},"comments":{"href":"https://api.github.com/repos/guardian/payment-api/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/payment-api/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/payment-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/payment-api/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/payment-api/statuses/8ab1697882696b99ce77122ba126d0a69f3b5b37"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mullefa"}}