{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/182279680","pull_request_review_id":113044650,"id":182279680,"diff_hunk":"@@ -13,59 +13,62 @@\n     <Copy SourceFiles=\"@(TraceEventNativePath)\" DestinationFiles=\"@(TraceEventNativePath->'$(StartWorkingDirectory)\\%(RecursiveDir)%(Filename)%(Extension)')\" />\n   </Target>\n \n+  <!-- Set platform specific values. -->\n   <PropertyGroup Condition=\"'$(TargetOS)'=='Linux'\">\n     <PerfTestCommandDotnetExecutable>$RUNTIME_PATH/dotnet</PerfTestCommandDotnetExecutable>\n     <BenchviewDir>$(ToolsDir)Microsoft.BenchView.JSONFormat/tools</BenchviewDir>\n+    <PythonCommand>python3.5</PythonCommand>\n+    <CliExitErrorCommand>exit 1</CliExitErrorCommand>\n   </PropertyGroup>\n \n   <PropertyGroup Condition=\"'$(TargetOS)'=='Windows_NT'\">\n     <PerfTestCommandDotnetExecutable>%RUNTIME_PATH%\\dotnet.exe</PerfTestCommandDotnetExecutable>\n     <BenchviewDir>$(ToolsDir)Microsoft.BenchView.JSONFormat\\tools</BenchviewDir>\n+    <PythonCommand>py.exe</PythonCommand>\n+    <CliExitErrorCommand>EXIT /B 1</CliExitErrorCommand>\n   </PropertyGroup>\n \n+  <!-- Set the PerformanceType if not defined. -->\n   <PropertyGroup>\n     <PerformanceType Condition=\"'$(PerformanceType)'==''\">Profile</PerformanceType>\n   </PropertyGroup>\n \n+  <Target Name=\"ValidatePerformanceRunType\" BeforeTargets=\"RunTestsForProject\">","path":"src/Microsoft.DotNet.Build.Tasks/PackageFiles/PerfTesting.targets","position":null,"original_position":24,"commit_id":"8e3b92e6fa70ea664bfae851b715603e017a6507","original_commit_id":"20c30d34cf40717d83f19f567f9e81bb265eb0f7","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars2.githubusercontent.com/u/7862010?v=4","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"body":"It seemed like from our conversation earlier you could check this earlier, such as in GenerateTestExecutionScripts. ","created_at":"2018-04-18T00:29:31Z","updated_at":"2018-04-18T00:29:31Z","html_url":"https://github.com/dotnet/buildtools/pull/2008#discussion_r182279680","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/2008","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/182279680"},"html":{"href":"https://github.com/dotnet/buildtools/pull/2008#discussion_r182279680"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2008"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/2008","id":181315154,"html_url":"https://github.com/dotnet/buildtools/pull/2008","diff_url":"https://github.com/dotnet/buildtools/pull/2008.diff","patch_url":"https://github.com/dotnet/buildtools/pull/2008.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/2008","number":2008,"state":"open","locked":false,"title":"Enable Profile and Diagnostic performance runs on CoreFx.","user":{"login":"jorive","id":12551699,"avatar_url":"https://avatars0.githubusercontent.com/u/12551699?v=4","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"body":"- About the run types:\r\n    - Profile run is the existing one with the addition of `Allocated bytes in current thread`\r\n    -    Profile: Stopwatch Time, Clr Etw events, Allocated bytes in current thread.\r\n    - Diagnostic: Stopwatch Time, Clr Etw events, Allocated bytes in current thread, Branch Mispredictions, Cache Misses, Instructions Retired.\r\n- In addition, cleaned up the `PerfTesting.targets` file by removing a lot of duplication.","created_at":"2018-04-12T20:21:52Z","updated_at":"2018-04-18T00:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd2e040113ad31814432187a94b5dbf6814c9c26","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brianrob","id":6210322,"avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},{"login":"DrewScoggins","id":9439069,"avatar_url":"https://avatars2.githubusercontent.com/u/9439069?v=4","gravatar_id":"","url":"https://api.github.com/users/DrewScoggins","html_url":"https://github.com/DrewScoggins","followers_url":"https://api.github.com/users/DrewScoggins/followers","following_url":"https://api.github.com/users/DrewScoggins/following{/other_user}","gists_url":"https://api.github.com/users/DrewScoggins/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewScoggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewScoggins/subscriptions","organizations_url":"https://api.github.com/users/DrewScoggins/orgs","repos_url":"https://api.github.com/users/DrewScoggins/repos","events_url":"https://api.github.com/users/DrewScoggins/events{/privacy}","received_events_url":"https://api.github.com/users/DrewScoggins/received_events","type":"User","site_admin":false},{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars0.githubusercontent.com/u/9666644?v=4","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/2008/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/2008/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/2008/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/8e3b92e6fa70ea664bfae851b715603e017a6507","head":{"label":"jorive:dev/add-perf-run-types","ref":"dev/add-perf-run-types","sha":"8e3b92e6fa70ea664bfae851b715603e017a6507","user":{"login":"jorive","id":12551699,"avatar_url":"https://avatars0.githubusercontent.com/u/12551699?v=4","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"repo":{"id":96363131,"name":"buildtools","full_name":"jorive/buildtools","owner":{"login":"jorive","id":12551699,"avatar_url":"https://avatars0.githubusercontent.com/u/12551699?v=4","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jorive/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/jorive/buildtools","forks_url":"https://api.github.com/repos/jorive/buildtools/forks","keys_url":"https://api.github.com/repos/jorive/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorive/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorive/buildtools/teams","hooks_url":"https://api.github.com/repos/jorive/buildtools/hooks","issue_events_url":"https://api.github.com/repos/jorive/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/jorive/buildtools/events","assignees_url":"https://api.github.com/repos/jorive/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/jorive/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/jorive/buildtools/tags","blobs_url":"https://api.github.com/repos/jorive/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorive/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorive/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorive/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorive/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/jorive/buildtools/languages","stargazers_url":"https://api.github.com/repos/jorive/buildtools/stargazers","contributors_url":"https://api.github.com/repos/jorive/buildtools/contributors","subscribers_url":"https://api.github.com/repos/jorive/buildtools/subscribers","subscription_url":"https://api.github.com/repos/jorive/buildtools/subscription","commits_url":"https://api.github.com/repos/jorive/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorive/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorive/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorive/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorive/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/jorive/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorive/buildtools/merges","archive_url":"https://api.github.com/repos/jorive/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorive/buildtools/downloads","issues_url":"https://api.github.com/repos/jorive/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/jorive/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/jorive/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/jorive/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorive/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/jorive/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/jorive/buildtools/deployments","created_at":"2017-07-05T21:35:58Z","updated_at":"2018-04-12T16:51:16Z","pushed_at":"2018-04-18T00:24:33Z","git_url":"git://github.com/jorive/buildtools.git","ssh_url":"git@github.com:jorive/buildtools.git","clone_url":"https://github.com/jorive/buildtools.git","svn_url":"https://github.com/jorive/buildtools","homepage":"","size":6175,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9dfdbdb2e5af4735b92a42b6c8d8b194e4d5845e","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2018-04-17T21:20:10Z","pushed_at":"2018-04-18T00:24:35Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":6183,"stargazers_count":455,"watchers_count":455,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":260,"open_issues":173,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2008"},"html":{"href":"https://github.com/dotnet/buildtools/pull/2008"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/2008"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/2008/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2008/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2008/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/8e3b92e6fa70ea664bfae851b715603e017a6507"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MattGal"}}