{"action":"closed","number":25370,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25370","id":235329509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzI5NTA5","html_url":"https://github.com/ceph/ceph/pull/25370","diff_url":"https://github.com/ceph/ceph/pull/25370.diff","patch_url":"https://github.com/ceph/ceph/pull/25370.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25370","number":25370,"state":"closed","locked":false,"title":"common/shared_cache: bumps it to the front of the LRU if key existed.","user":{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"body":"Based on comments of funtion add(), if key existed it should bumps\r\nit to the front of the LRU.\r\n\r\nSigned-off-by: Jianpeng Ma <jianpeng.ma@intel.com>\r\n\r\n\r\n<!--\r\nThank you for opening a pull request!  Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin.  For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview.  More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [ ] References tracker ticket\r\n- [ ] Updates documentation if necessary\r\n- [ ] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-12-03T05:22:07Z","updated_at":"2018-12-08T03:48:00Z","closed_at":"2018-12-08T03:48:00Z","merged_at":"2018-12-08T03:48:00Z","merge_commit_sha":"057060fc13f05754c200f3a9954b5d74adcc6492","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":199292951,"node_id":"MDU6TGFiZWwxOTkyOTI5NTE=","url":"https://api.github.com/repos/ceph/ceph/labels/common","name":"common","color":"006b75","default":false},{"id":148431321,"node_id":"MDU6TGFiZWwxNDg0MzEzMjE=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":926388012,"node_id":"MDU6TGFiZWw5MjYzODgwMTI=","url":"https://api.github.com/repos/ceph/ceph/labels/wip-kefu2-testing","name":"wip-kefu2-testing","color":"85e28f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25370/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25370/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25370/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/73297344480d7a4df4cb6176984c129d2183a570","head":{"label":"majianpeng:sharedlru-addfunc","ref":"sharedlru-addfunc","sha":"73297344480d7a4df4cb6176984c129d2183a570","user":{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"repo":{"id":22190447,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE5MDQ0Nw==","name":"ceph","full_name":"majianpeng/ceph","private":false,"owner":{"login":"majianpeng","id":1230551,"node_id":"MDQ6VXNlcjEyMzA1NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1230551?v=4","gravatar_id":"","url":"https://api.github.com/users/majianpeng","html_url":"https://github.com/majianpeng","followers_url":"https://api.github.com/users/majianpeng/followers","following_url":"https://api.github.com/users/majianpeng/following{/other_user}","gists_url":"https://api.github.com/users/majianpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/majianpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majianpeng/subscriptions","organizations_url":"https://api.github.com/users/majianpeng/orgs","repos_url":"https://api.github.com/users/majianpeng/repos","events_url":"https://api.github.com/users/majianpeng/events{/privacy}","received_events_url":"https://api.github.com/users/majianpeng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/majianpeng/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/majianpeng/ceph","forks_url":"https://api.github.com/repos/majianpeng/ceph/forks","keys_url":"https://api.github.com/repos/majianpeng/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majianpeng/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majianpeng/ceph/teams","hooks_url":"https://api.github.com/repos/majianpeng/ceph/hooks","issue_events_url":"https://api.github.com/repos/majianpeng/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/majianpeng/ceph/events","assignees_url":"https://api.github.com/repos/majianpeng/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/majianpeng/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/majianpeng/ceph/tags","blobs_url":"https://api.github.com/repos/majianpeng/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majianpeng/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majianpeng/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/majianpeng/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majianpeng/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/majianpeng/ceph/languages","stargazers_url":"https://api.github.com/repos/majianpeng/ceph/stargazers","contributors_url":"https://api.github.com/repos/majianpeng/ceph/contributors","subscribers_url":"https://api.github.com/repos/majianpeng/ceph/subscribers","subscription_url":"https://api.github.com/repos/majianpeng/ceph/subscription","commits_url":"https://api.github.com/repos/majianpeng/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/majianpeng/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/majianpeng/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/majianpeng/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/majianpeng/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/majianpeng/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majianpeng/ceph/merges","archive_url":"https://api.github.com/repos/majianpeng/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majianpeng/ceph/downloads","issues_url":"https://api.github.com/repos/majianpeng/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/majianpeng/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/majianpeng/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/majianpeng/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majianpeng/ceph/labels{/name}","releases_url":"https://api.github.com/repos/majianpeng/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/majianpeng/ceph/deployments","created_at":"2014-07-24T01:10:00Z","updated_at":"2018-12-07T03:25:45Z","pushed_at":"2018-12-07T03:25:41Z","git_url":"git://github.com/majianpeng/ceph.git","ssh_url":"git@github.com:majianpeng/ceph.git","clone_url":"https://github.com/majianpeng/ceph.git","svn_url":"https://github.com/majianpeng/ceph","homepage":"http://ceph.com","size":303196,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"b021f2cad5a97a25c7688af86d4bbfee2d3cee8f","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-12-08T03:38:21Z","pushed_at":"2018-12-08T03:48:00Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":336953,"stargazers_count":5374,"watchers_count":5374,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2822,"mirror_url":null,"archived":false,"open_issues_count":614,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2822,"open_issues":614,"watchers":5374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25370"},"html":{"href":"https://github.com/ceph/ceph/pull/25370"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25370"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25370/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25370/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25370/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/73297344480d7a4df4cb6176984c129d2183a570"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"tchaikov"}}