{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/Pkg.jl/issues/912","repository_url":"https://api.github.com/repos/JuliaLang/Pkg.jl","labels_url":"https://api.github.com/repos/JuliaLang/Pkg.jl/issues/912/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/Pkg.jl/issues/912/comments","events_url":"https://api.github.com/repos/JuliaLang/Pkg.jl/issues/912/events","html_url":"https://github.com/JuliaLang/Pkg.jl/pull/912","id":381798098,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjg0ODY3","number":912,"title":"Properly handle Manifest dependencies (Fix #894)","user":{"login":"00vareladavid","id":11048133,"node_id":"MDQ6VXNlcjExMDQ4MTMz","avatar_url":"https://avatars0.githubusercontent.com/u/11048133?v=4","gravatar_id":"","url":"https://api.github.com/users/00vareladavid","html_url":"https://github.com/00vareladavid","followers_url":"https://api.github.com/users/00vareladavid/followers","following_url":"https://api.github.com/users/00vareladavid/following{/other_user}","gists_url":"https://api.github.com/users/00vareladavid/gists{/gist_id}","starred_url":"https://api.github.com/users/00vareladavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/00vareladavid/subscriptions","organizations_url":"https://api.github.com/users/00vareladavid/orgs","repos_url":"https://api.github.com/users/00vareladavid/repos","events_url":"https://api.github.com/users/00vareladavid/events{/privacy}","received_events_url":"https://api.github.com/users/00vareladavid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-16T23:39:58Z","updated_at":"2018-11-19T01:49:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/JuliaLang/Pkg.jl/pulls/912","html_url":"https://github.com/JuliaLang/Pkg.jl/pull/912","diff_url":"https://github.com/JuliaLang/Pkg.jl/pull/912.diff","patch_url":"https://github.com/JuliaLang/Pkg.jl/pull/912.patch"},"body":"I broke `Pkg` by merging #894 last night. I hadn't realized that we save the `deps` section differently depending on whether all the dependencies have unique names.\r\n\r\nI added tests to ensure that `write_manifest(read_manifest(x)) == x`. Also added the equivalent tests for `Project.toml`."},"comment":{"url":"https://api.github.com/repos/JuliaLang/Pkg.jl/issues/comments/439748223","html_url":"https://github.com/JuliaLang/Pkg.jl/pull/912#issuecomment-439748223","issue_url":"https://api.github.com/repos/JuliaLang/Pkg.jl/issues/912","id":439748223,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTc0ODIyMw==","user":{"login":"00vareladavid","id":11048133,"node_id":"MDQ6VXNlcjExMDQ4MTMz","avatar_url":"https://avatars0.githubusercontent.com/u/11048133?v=4","gravatar_id":"","url":"https://api.github.com/users/00vareladavid","html_url":"https://github.com/00vareladavid","followers_url":"https://api.github.com/users/00vareladavid/followers","following_url":"https://api.github.com/users/00vareladavid/following{/other_user}","gists_url":"https://api.github.com/users/00vareladavid/gists{/gist_id}","starred_url":"https://api.github.com/users/00vareladavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/00vareladavid/subscriptions","organizations_url":"https://api.github.com/users/00vareladavid/orgs","repos_url":"https://api.github.com/users/00vareladavid/repos","events_url":"https://api.github.com/users/00vareladavid/events{/privacy}","received_events_url":"https://api.github.com/users/00vareladavid/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T01:49:14Z","updated_at":"2018-11-19T01:49:14Z","author_association":"COLLABORATOR","body":"Yeah, it makes sense now. Sorry about that, I realized that my mental model was not complete right after merging. I'll make sure to ask in the future :grin: "}}
{"actor":{"display_login":"00vareladavid"}}