{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/181479997","pull_request_review_id":112119631,"id":181479997,"diff_hunk":"@@ -71,61 +99,102 @@ func NewCmdReplace(f cmdutil.Factory, out io.Writer) *cobra.Command {\n \t\tExample: replaceExample,\n \t\tRun: func(cmd *cobra.Command, args []string) {\n \t\t\tcmdutil.CheckErr(cmdutil.ValidateOutputArgs(cmd))\n-\t\t\terr := RunReplace(f, out, cmd, args, options)\n-\t\t\tcmdutil.CheckErr(err)\n+\t\t\tcmdutil.CheckErr(options.Complete(f, cmd))\n+\t\t\tcmdutil.CheckErr(options.Validate(cmd))\n+\t\t\tcmdutil.CheckErr(options.Run(f, args))","path":"pkg/kubectl/cmd/replace.go","position":61,"original_position":61,"commit_id":"1aadc73f9ae9cffff4ebf9de9f1c0ff62aeff347","original_commit_id":"1aadc73f9ae9cffff4ebf9de9f1c0ff62aeff347","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"Don't pass factory here, extract whatever you need in `Complete` and use that in `Run`. The same applies to `args`. ","created_at":"2018-04-13T18:52:14Z","updated_at":"2018-04-13T18:58:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/62300#discussion_r181479997","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/181479997"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62300#discussion_r181479997"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300","id":180452130,"html_url":"https://github.com/kubernetes/kubernetes/pull/62300","diff_url":"https://github.com/kubernetes/kubernetes/pull/62300.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62300.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62300","number":62300,"state":"open","locked":false,"title":"Wire PrintFlags through delete, replace, run commands","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n\r\nWires PrintFlags through the `delete`, `replace`, and `run` commands.\r\nAll three commands grouped in this patch as they depend on DeleteOptions.\r\n\r\n~~Tagged as WIP for now, as I still need to update tests.~~\r\n\r\ncc @soltysh @deads2k ","created_at":"2018-04-09T23:16:53Z","updated_at":"2018-04-13T18:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adc7b0218512256fbaa987a5cc57216fb357f26d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62300/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1aadc73f9ae9cffff4ebf9de9f1c0ff62aeff347","head":{"label":"juanvallejo:jvallejo/wire-print-flags-delete-cmd","ref":"jvallejo/wire-print-flags-delete-cmd","sha":"1aadc73f9ae9cffff4ebf9de9f1c0ff62aeff347","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":59512855,"name":"kubernetes","full_name":"juanvallejo/kubernetes","owner":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juanvallejo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/juanvallejo/kubernetes","forks_url":"https://api.github.com/repos/juanvallejo/kubernetes/forks","keys_url":"https://api.github.com/repos/juanvallejo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/kubernetes/teams","hooks_url":"https://api.github.com/repos/juanvallejo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/kubernetes/events","assignees_url":"https://api.github.com/repos/juanvallejo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/kubernetes/tags","blobs_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/kubernetes/subscription","commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/kubernetes/merges","archive_url":"https://api.github.com/repos/juanvallejo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/kubernetes/downloads","issues_url":"https://api.github.com/repos/juanvallejo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/kubernetes/deployments","created_at":"2016-05-23T19:36:17Z","updated_at":"2018-04-11T23:11:34Z","pushed_at":"2018-04-13T17:52:36Z","git_url":"git://github.com/juanvallejo/kubernetes.git","ssh_url":"git@github.com:juanvallejo/kubernetes.git","clone_url":"https://github.com/juanvallejo/kubernetes.git","svn_url":"https://github.com/juanvallejo/kubernetes","homepage":"http://kubernetes.io","size":538002,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"cce6a95ce594b035b7c7f6fb5f5c613d49602cbe","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-13T18:46:03Z","pushed_at":"2018-04-13T18:56:40Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":770396,"stargazers_count":35014,"watchers_count":35014,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12408,"mirror_url":null,"archived":false,"open_issues_count":3482,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12408,"open_issues":3482,"watchers":35014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62300"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62300"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62300/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62300/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1aadc73f9ae9cffff4ebf9de9f1c0ff62aeff347"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"soltysh"}}