{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22661","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22661/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22661/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22661/events","html_url":"https://github.com/nodejs/node/pull/22661","id":356293392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTk5NDc4","number":22661,"title":"Remove /MP from default additonal options","user":{"login":"skelliam","id":830788,"node_id":"MDQ6VXNlcjgzMDc4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/830788?v=4","gravatar_id":"","url":"https://api.github.com/users/skelliam","html_url":"https://github.com/skelliam","followers_url":"https://api.github.com/users/skelliam/followers","following_url":"https://api.github.com/users/skelliam/following{/other_user}","gists_url":"https://api.github.com/users/skelliam/gists{/gist_id}","starred_url":"https://api.github.com/users/skelliam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skelliam/subscriptions","organizations_url":"https://api.github.com/users/skelliam/orgs","repos_url":"https://api.github.com/users/skelliam/repos","events_url":"https://api.github.com/users/skelliam/events{/privacy}","received_events_url":"https://api.github.com/users/skelliam/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":166236401,"node_id":"MDU6TGFiZWwxNjYyMzY0MDE=","url":"https://api.github.com/repos/nodejs/node/labels/windows","name":"windows","color":"9944dd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-09-02T15:59:38Z","updated_at":"2018-09-03T21:30:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22661","html_url":"https://github.com/nodejs/node/pull/22661","diff_url":"https://github.com/nodejs/node/pull/22661.diff","patch_url":"https://github.com/nodejs/node/pull/22661.patch"},"body":"Forcing this option means that the user-provided option ```MultiProcessorCompilation``` in ```msvs_settings``` (from, for example, binding.gyp) is useless.  It also means that one cannot use ```#import``` in their source code or they will be faced with this error when trying to build:\r\n\r\n```\r\nerror C2813: #import is not supported with /MP (compiling source file...)\r\n```\r\n\r\nPlease see additional discussion of this here:  https://github.com/nodejs/node-gyp/issues/1087\r\nand here: https://github.com/nodejs/node-gyp/issues/26\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/418195275","html_url":"https://github.com/nodejs/node/pull/22661#issuecomment-418195275","issue_url":"https://api.github.com/repos/nodejs/node/issues/22661","id":418195275,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODE5NTI3NQ==","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T21:30:02Z","updated_at":"2018-09-03T21:30:02Z","author_association":"MEMBER","body":"> I see CI hasn't yet been run for this PR, but it should be very noticeable there.\r\n\r\nI did:\r\n[Pre on test-rackspace-win2012r2-x64-12](https://ci.nodejs.org/job/node-compile-windows/20599/label=win-vs2017/) &mdash; 35m\r\n[Post on test-rackspace-win2012r2-x64-11](https://ci.nodejs.org/job/node-compile-windows/20600/label=win-vs2017/) &mdash; 50m\r\n34% increase in time. But if this is an issue of higher parallelism, I have a feeling we could offset that with a higher number in\r\nhttps://github.com/nodejs/node/blob/9f7efd58a1e102737694f4e3f6946dac0eb283bf/vcbuild.bat#L300"}}
{"actor":{"display_login":"refack"}}