{"action":"created","issue":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1667","repository_url":"https://api.github.com/repos/rhinstaller/anaconda","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1667/labels{/name}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1667/comments","events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1667/events","html_url":"https://github.com/rhinstaller/anaconda/issues/1667","id":371987590,"node_id":"MDU6SXNzdWUzNzE5ODc1OTA=","number":1667,"title":"Add API to disable `resume=` injection","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-19T14:42:00Z","updated_at":"2018-10-19T19:59:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"See https://pagure.io/atomic-wg/issue/513\r\n\r\nhttps://github.com/poncovka/anaconda/commit/07c8591b107c34f3825dfa2d2b20c5c95cb3b892 broke ostree-based systems (Atomic Host/Fedora CoreOS/Silverblue) and I don't really want to debug it and make it work, since hibernation doesn't make sense on servers, and it's already under-tested enough and marginal that I don't care about it for Silverblue either on desktops.\r\n\r\nMaybe the simplest thing is for us to add `noresume` to the default kernel arguments, and change the code to not add `resume` if `noresume` is present. Or we could conditionalize it on the payload type being `dnf`."},"comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments/431482084","html_url":"https://github.com/rhinstaller/anaconda/issues/1667#issuecomment-431482084","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/1667","id":431482084,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQ4MjA4NA==","user":{"login":"dustymabe","id":4530030,"node_id":"MDQ6VXNlcjQ1MzAwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/4530030?v=4","gravatar_id":"","url":"https://api.github.com/users/dustymabe","html_url":"https://github.com/dustymabe","followers_url":"https://api.github.com/users/dustymabe/followers","following_url":"https://api.github.com/users/dustymabe/following{/other_user}","gists_url":"https://api.github.com/users/dustymabe/gists{/gist_id}","starred_url":"https://api.github.com/users/dustymabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustymabe/subscriptions","organizations_url":"https://api.github.com/users/dustymabe/orgs","repos_url":"https://api.github.com/users/dustymabe/repos","events_url":"https://api.github.com/users/dustymabe/events{/privacy}","received_events_url":"https://api.github.com/users/dustymabe/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T19:59:41Z","updated_at":"2018-10-19T19:59:41Z","author_association":"CONTRIBUTOR","body":"> That almost works except Silverblue uses that install class right now.\r\n\r\nIt probably should inherit from workstation but currently the silverblue installclass does not inherit from workstation:\r\n\r\nhttps://github.com/rhinstaller/anaconda/blob/de9043d81196a4d244f56d1f7075c06efbd2c675/pyanaconda/installclasses/fedora_silverblue.py#L18-L25\r\n\r\nis it valid for people to hibernate a silverblue system? i.e. does it work? \r\n\r\nNote that this [resume= leading to device timeouts](https://pagure.io/atomic-wg/issue/513) problem is [not currently present on silverblue](https://pagure.io/atomic-wg/issue/513#comment-536990) from my testing. So the bug isn't hitting us there, but not sure if we should or should not add resume= on those systems. \r\n\r\n"}}
{"actor":{"display_login":"dustymabe"}}