{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments/174100576","pull_request_review_id":103394761,"id":174100576,"diff_hunk":"@@ -0,0 +1,34 @@\n+﻿using System;\n+using System.Threading.Tasks;\n+\n+namespace Microsoft.Bot.Builder.Core.Extensions\n+{\n+    public class CatchExceptionMiddleware : IMiddleware\n+    {\n+        private readonly CatchExceptionHandler _handler;\n+\n+        public CatchExceptionMiddleware(CatchExceptionHandler handler)\n+        {\n+            _handler = handler;\n+        }\n+\n+        public async Task OnProcessRequest(IBotContext context, MiddlewareSet.NextDelegate next)\n+        {\n+            await CatchError(context, next);","path":"libraries/Microsoft.Bot.Builder.Core.Extensions/CatchExceptionMiddleware.cs","position":null,"original_position":17,"commit_id":"4df672f5481cadee6ef3af325eb779b0ac3d0690","original_commit_id":"bfcfcd57256b6512277ad7d7f3f58ade034019e3","user":{"login":"garypretty","id":3900649,"avatar_url":"https://avatars1.githubusercontent.com/u/3900649?v=4","gravatar_id":"","url":"https://api.github.com/users/garypretty","html_url":"https://github.com/garypretty","followers_url":"https://api.github.com/users/garypretty/followers","following_url":"https://api.github.com/users/garypretty/following{/other_user}","gists_url":"https://api.github.com/users/garypretty/gists{/gist_id}","starred_url":"https://api.github.com/users/garypretty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garypretty/subscriptions","organizations_url":"https://api.github.com/users/garypretty/orgs","repos_url":"https://api.github.com/users/garypretty/repos","events_url":"https://api.github.com/users/garypretty/events{/privacy}","received_events_url":"https://api.github.com/users/garypretty/received_events","type":"User","site_admin":false},"body":"Removed the catch error method and move code directly into OnProcessRequest","created_at":"2018-03-13T11:48:44Z","updated_at":"2018-03-13T11:48:44Z","html_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/283#discussion_r174100576","pull_request_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments/174100576"},"html":{"href":"https://github.com/Microsoft/botbuilder-dotnet/pull/283#discussion_r174100576"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283"}},"in_reply_to_id":173988050},"pull_request":{"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283","id":174520520,"html_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/283","diff_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/283.diff","patch_url":"https://github.com/Microsoft/botbuilder-dotnet/pull/283.patch","issue_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/283","number":283,"state":"open","locked":false,"title":"CatchException, ShowTyping and ActivityFilter middleware core extensions","user":{"login":"garypretty","id":3900649,"avatar_url":"https://avatars1.githubusercontent.com/u/3900649?v=4","gravatar_id":"","url":"https://api.github.com/users/garypretty","html_url":"https://github.com/garypretty","followers_url":"https://api.github.com/users/garypretty/followers","following_url":"https://api.github.com/users/garypretty/following{/other_user}","gists_url":"https://api.github.com/users/garypretty/gists{/gist_id}","starred_url":"https://api.github.com/users/garypretty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garypretty/subscriptions","organizations_url":"https://api.github.com/users/garypretty/orgs","repos_url":"https://api.github.com/users/garypretty/repos","events_url":"https://api.github.com/users/garypretty/events{/privacy}","received_events_url":"https://api.github.com/users/garypretty/received_events","type":"User","site_admin":false},"body":"@cleemullins @Stevenic These are the first 3 additional middleware extensions we have previously discussed that we were waiting for the M2 changes for.  The 3 pieces of middleware are based on those @Stevenic produced, so we should have feature parity when they are added to the JS SDK.\r\n\r\nI'll add the timeout warning middleware we discussed on the other thread in another PR once that is ready.","created_at":"2018-03-12T23:18:49Z","updated_at":"2018-03-13T11:48:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47c84c357f7e5c672385f9cd9421ad60493f8efb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283/commits","review_comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283/comments","review_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/283/comments","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/4df672f5481cadee6ef3af325eb779b0ac3d0690","head":{"label":"garypretty:additional-core-extensions","ref":"additional-core-extensions","sha":"4df672f5481cadee6ef3af325eb779b0ac3d0690","user":{"login":"garypretty","id":3900649,"avatar_url":"https://avatars1.githubusercontent.com/u/3900649?v=4","gravatar_id":"","url":"https://api.github.com/users/garypretty","html_url":"https://github.com/garypretty","followers_url":"https://api.github.com/users/garypretty/followers","following_url":"https://api.github.com/users/garypretty/following{/other_user}","gists_url":"https://api.github.com/users/garypretty/gists{/gist_id}","starred_url":"https://api.github.com/users/garypretty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garypretty/subscriptions","organizations_url":"https://api.github.com/users/garypretty/orgs","repos_url":"https://api.github.com/users/garypretty/repos","events_url":"https://api.github.com/users/garypretty/events{/privacy}","received_events_url":"https://api.github.com/users/garypretty/received_events","type":"User","site_admin":false},"repo":{"id":121881999,"name":"botbuilder-dotnet","full_name":"garypretty/botbuilder-dotnet","owner":{"login":"garypretty","id":3900649,"avatar_url":"https://avatars1.githubusercontent.com/u/3900649?v=4","gravatar_id":"","url":"https://api.github.com/users/garypretty","html_url":"https://github.com/garypretty","followers_url":"https://api.github.com/users/garypretty/followers","following_url":"https://api.github.com/users/garypretty/following{/other_user}","gists_url":"https://api.github.com/users/garypretty/gists{/gist_id}","starred_url":"https://api.github.com/users/garypretty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garypretty/subscriptions","organizations_url":"https://api.github.com/users/garypretty/orgs","repos_url":"https://api.github.com/users/garypretty/repos","events_url":"https://api.github.com/users/garypretty/events{/privacy}","received_events_url":"https://api.github.com/users/garypretty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garypretty/botbuilder-dotnet","description":".NET SDK used to build chat bots for the Microsoft Bot Framework.","fork":true,"url":"https://api.github.com/repos/garypretty/botbuilder-dotnet","forks_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/forks","keys_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/teams","hooks_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/hooks","issue_events_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/events","assignees_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/tags","blobs_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/languages","stargazers_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/stargazers","contributors_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/contributors","subscribers_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/subscribers","subscription_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/subscription","commits_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/merges","archive_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/downloads","issues_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/garypretty/botbuilder-dotnet/deployments","created_at":"2018-02-17T18:42:07Z","updated_at":"2018-02-17T18:42:10Z","pushed_at":"2018-03-13T11:41:13Z","git_url":"git://github.com/garypretty/botbuilder-dotnet.git","ssh_url":"git@github.com:garypretty/botbuilder-dotnet.git","clone_url":"https://github.com/garypretty/botbuilder-dotnet.git","svn_url":"https://github.com/garypretty/botbuilder-dotnet","homepage":null,"size":1495,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"90e8c65fe3c78ca3e6104f60a26959f67e2cf44a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117021670,"name":"botbuilder-dotnet","full_name":"Microsoft/botbuilder-dotnet","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/botbuilder-dotnet","description":".NET SDK used to build chat bots for the Microsoft Bot Framework.","fork":false,"url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet","forks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/deployments","created_at":"2018-01-10T23:03:16Z","updated_at":"2018-03-13T00:36:50Z","pushed_at":"2018-03-13T11:41:14Z","git_url":"git://github.com/Microsoft/botbuilder-dotnet.git","ssh_url":"git@github.com:Microsoft/botbuilder-dotnet.git","clone_url":"https://github.com/Microsoft/botbuilder-dotnet.git","svn_url":"https://github.com/Microsoft/botbuilder-dotnet","homepage":null,"size":1459,"stargazers_count":54,"watchers_count":54,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":29,"open_issues":44,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283"},"html":{"href":"https://github.com/Microsoft/botbuilder-dotnet/pull/283"},"issue":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/283"},"comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/botbuilder-dotnet/statuses/4df672f5481cadee6ef3af325eb779b0ac3d0690"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garypretty"}}