{"action":"created","issue":{"url":"https://api.github.com/repos/sfirke/janitor/issues/214","repository_url":"https://api.github.com/repos/sfirke/janitor","labels_url":"https://api.github.com/repos/sfirke/janitor/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/sfirke/janitor/issues/214/comments","events_url":"https://api.github.com/repos/sfirke/janitor/issues/214/events","html_url":"https://github.com/sfirke/janitor/pull/214","id":335189658,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTU2MDg0","number":214,"title":"Add time handling to excel_numeric_to_date","user":{"login":"billdenney","id":10359931,"node_id":"MDQ6VXNlcjEwMzU5OTMx","avatar_url":"https://avatars1.githubusercontent.com/u/10359931?v=4","gravatar_id":"","url":"https://api.github.com/users/billdenney","html_url":"https://github.com/billdenney","followers_url":"https://api.github.com/users/billdenney/followers","following_url":"https://api.github.com/users/billdenney/following{/other_user}","gists_url":"https://api.github.com/users/billdenney/gists{/gist_id}","starred_url":"https://api.github.com/users/billdenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billdenney/subscriptions","organizations_url":"https://api.github.com/users/billdenney/orgs","repos_url":"https://api.github.com/users/billdenney/repos","events_url":"https://api.github.com/users/billdenney/events{/privacy}","received_events_url":"https://api.github.com/users/billdenney/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-24T15:48:15Z","updated_at":"2018-07-06T18:59:13Z","closed_at":"2018-07-06T18:57:09Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sfirke/janitor/pulls/214","html_url":"https://github.com/sfirke/janitor/pull/214","diff_url":"https://github.com/sfirke/janitor/pull/214.diff","patch_url":"https://github.com/sfirke/janitor/pull/214.patch"},"body":"Fix #210\r\n\r\nA few notes:\r\n\r\nI'm not sure if you want to describe the minor change of taking the floor of the value as a breaking change in the NEWS file.  It is very subtle and people shouldn't have been going into the date object that way.\r\n\r\nWhile working up the test cases, I found a bug in base R (https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=17437).  I worked around it in the result, and I think that the if the behavior changes, the code should be fine long-term."},"comment":{"url":"https://api.github.com/repos/sfirke/janitor/issues/comments/403119781","html_url":"https://github.com/sfirke/janitor/pull/214#issuecomment-403119781","issue_url":"https://api.github.com/repos/sfirke/janitor/issues/214","id":403119781,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzExOTc4MQ==","user":{"login":"sfirke","id":7569808,"node_id":"MDQ6VXNlcjc1Njk4MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/7569808?v=4","gravatar_id":"","url":"https://api.github.com/users/sfirke","html_url":"https://github.com/sfirke","followers_url":"https://api.github.com/users/sfirke/followers","following_url":"https://api.github.com/users/sfirke/following{/other_user}","gists_url":"https://api.github.com/users/sfirke/gists{/gist_id}","starred_url":"https://api.github.com/users/sfirke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfirke/subscriptions","organizations_url":"https://api.github.com/users/sfirke/orgs","repos_url":"https://api.github.com/users/sfirke/repos","events_url":"https://api.github.com/users/sfirke/events{/privacy}","received_events_url":"https://api.github.com/users/sfirke/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T18:59:13Z","updated_at":"2018-07-06T18:59:13Z","author_association":"OWNER","body":"Thanks again @billdenney !  Sorry for the delayed review + merge, I blame :baby: "}}
{"actor":{"display_login":"sfirke"}}