{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/204385133","pull_request_review_id":139453682,"id":204385133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDM4NTEzMw==","diff_hunk":"@@ -99,3 +100,35 @@ BOOST_AUTO_TEST_CASE(parse_str) {\n     assert_expr(R\"#(a.a(\"\\\\\"))#\", R\"#(a.a(\"\\\\\"))#\");\n     assert_expr(R\"#(a.a(\"  \"))#\", R\"#(a.a(\"  \"))#\");    \n }\n+\n+BOOST_AUTO_TEST_CASE(parse_legacy_tests) {\n+    assert_expr(\"stop_areas.uri=42\", \"stop_areas.uri(\\\"42\\\")\");\n+    assert_expr(\"line.code=42\", \"line.code(\\\"42\\\")\");\n+    assert_expr(\"  stop_areas.uri    =  42    \", \"stop_areas.uri(\\\"42\\\")\");\n+    assert_expr(\n+        \"stop_areas.uri = 42 and  line.name=bus\",\n+        \"(stop_areas.uri(\\\"42\\\") AND line.name(\\\"bus\\\"))\"\n+    );\n+\n+    // escaped values\n+    assert_expr(\"stop_areas.uri=\\\"42\\\"\", \"stop_areas.uri(\\\"42\\\")\");\n+    assert_expr(\"stop_areas.uri=\\\"4-2\\\"\", \"stop_areas.uri(\\\"4-2\\\")\");\n+    assert_expr(\"stop_areas.uri=\\\"4|2\\\"\", \"stop_areas.uri(\\\"4|2\\\")\");\n+    assert_expr(\"stop_areas.uri=\\\"42.\\\"\", \"stop_areas.uri(\\\"42.\\\")\");\n+    assert_expr(\"stop_areas.uri=\\\"42 12\\\"\", \"stop_areas.uri(\\\"42 12\\\")\");\n+    assert_expr(\"stop_areas.uri=\\\"  42  \\\"\", \"stop_areas.uri(\\\"  42  \\\")\");\n+    assert_expr(\"stop_areas.uri=\\\"4&2\\\"\", \"stop_areas.uri(\\\"4&2\\\")\");\n+\n+    // exception\n+    BOOST_CHECK_THROW(parse(\"\"), parsing_error);\n+    BOOST_CHECK_THROW(parse(\"mouuuhh bliiii\"), parsing_error);\n+    BOOST_CHECK_THROW(parse(\"stop_areas.uri==42\"), parsing_error);","path":"source/ptreferential/tests/ptref_ng_test.cpp","position":131,"original_position":34,"commit_id":"dceaa80dc0c158bc41fdbb54e68fc1da5af8982c","original_commit_id":"5e0f8578d57d972653a61fc140b02c17270d14a9","user":{"login":"TeXitoi","id":5787066,"node_id":"MDQ6VXNlcjU3ODcwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5787066?v=4","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-07-23T12:40:26Z","updated_at":"2018-07-23T12:40:26Z","html_url":"https://github.com/CanalTP/navitia/pull/2465#discussion_r204385133","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2465","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/204385133"},"html":{"href":"https://github.com/CanalTP/navitia/pull/2465#discussion_r204385133"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2465"}},"in_reply_to_id":204106712},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/2465","id":200419007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDE5MDA3","html_url":"https://github.com/CanalTP/navitia/pull/2465","diff_url":"https://github.com/CanalTP/navitia/pull/2465.diff","patch_url":"https://github.com/CanalTP/navitia/pull/2465.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/2465","number":2465,"state":"open","locked":false,"title":"Ptref next gen, or the OR feature","user":{"login":"TeXitoi","id":5787066,"node_id":"MDQ6VXNlcjU3ODcwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5787066?v=4","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"Readable commit by commit.\r\n\r\nTODO:\r\n - [x] imports tests from POC\r\n - [x] migrate tests from ptref legacy\r\n - [x] import the `forbidden_uris` *et al* in the request\r\n - [x] evaluate the expression\r\n - [x] check that legacy and ng returns the same thing\r\n - [x] test the `GET type <- expr` feature","created_at":"2018-07-10T14:37:25Z","updated_at":"2018-07-23T12:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4c0ccbb7bfc7cb614fae33875a87ccb5c2db297","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2465/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/2465/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/2465/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/dceaa80dc0c158bc41fdbb54e68fc1da5af8982c","head":{"label":"TeXitoi:ptref_ng","ref":"ptref_ng","sha":"dceaa80dc0c158bc41fdbb54e68fc1da5af8982c","user":{"login":"TeXitoi","id":5787066,"node_id":"MDQ6VXNlcjU3ODcwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5787066?v=4","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"repo":{"id":23435249,"node_id":"MDEwOlJlcG9zaXRvcnkyMzQzNTI0OQ==","name":"navitia","full_name":"TeXitoi/navitia","owner":{"login":"TeXitoi","id":5787066,"node_id":"MDQ6VXNlcjU3ODcwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5787066?v=4","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TeXitoi/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/TeXitoi/navitia","forks_url":"https://api.github.com/repos/TeXitoi/navitia/forks","keys_url":"https://api.github.com/repos/TeXitoi/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeXitoi/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeXitoi/navitia/teams","hooks_url":"https://api.github.com/repos/TeXitoi/navitia/hooks","issue_events_url":"https://api.github.com/repos/TeXitoi/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/TeXitoi/navitia/events","assignees_url":"https://api.github.com/repos/TeXitoi/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/TeXitoi/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/TeXitoi/navitia/tags","blobs_url":"https://api.github.com/repos/TeXitoi/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeXitoi/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeXitoi/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeXitoi/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeXitoi/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/TeXitoi/navitia/languages","stargazers_url":"https://api.github.com/repos/TeXitoi/navitia/stargazers","contributors_url":"https://api.github.com/repos/TeXitoi/navitia/contributors","subscribers_url":"https://api.github.com/repos/TeXitoi/navitia/subscribers","subscription_url":"https://api.github.com/repos/TeXitoi/navitia/subscription","commits_url":"https://api.github.com/repos/TeXitoi/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeXitoi/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeXitoi/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeXitoi/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeXitoi/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/TeXitoi/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeXitoi/navitia/merges","archive_url":"https://api.github.com/repos/TeXitoi/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeXitoi/navitia/downloads","issues_url":"https://api.github.com/repos/TeXitoi/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/TeXitoi/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/TeXitoi/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/TeXitoi/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeXitoi/navitia/labels{/name}","releases_url":"https://api.github.com/repos/TeXitoi/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/TeXitoi/navitia/deployments","created_at":"2014-08-28T16:35:05Z","updated_at":"2016-03-03T16:12:43Z","pushed_at":"2018-07-23T12:39:59Z","git_url":"git://github.com/TeXitoi/navitia.git","ssh_url":"git@github.com:TeXitoi/navitia.git","clone_url":"https://github.com/TeXitoi/navitia.git","svn_url":"https://github.com/TeXitoi/navitia","homepage":"http://www.navitia.io","size":40486,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"d126ce0fe1c53a3900e9f115bf7e9038c2fa82ea","user":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc5NzMzMw==","name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDM5ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2743985?v=4","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The open source software to build cool stuff with locomotion","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/navitia/deployments","created_at":"2013-06-19T15:34:30Z","updated_at":"2018-07-21T13:42:47Z","pushed_at":"2018-07-23T12:40:01Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":41551,"stargazers_count":250,"watchers_count":250,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":84,"open_issues":36,"watchers":250,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2465"},"html":{"href":"https://github.com/CanalTP/navitia/pull/2465"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/2465"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/2465/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2465/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/2465/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/dceaa80dc0c158bc41fdbb54e68fc1da5af8982c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TeXitoi"}}