{"action":"created","comment":{"url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/comments/174570623","pull_request_review_id":103951749,"id":174570623,"diff_hunk":"@@ -0,0 +1,208 @@\n+package classes.Scenes.Monsters.pregnancies \n+{\n+\timport classes.GlobalFlags.kGAMECLASS;\n+\timport classes.Items.Mutations;\n+\timport classes.Player;\n+\timport classes.PregnancyStore;\n+\timport classes.Scenes.PregnancyProgression;\n+\timport classes.Scenes.VaginalPregnancy;\n+\timport classes.StatusEffects;\n+\timport classes.internals.GuiOutput;\n+\timport classes.internals.PregnancyUtils;\n+\t\n+\t/**\n+\t * Contains pregnancy progression and birth scenes for a Player impregnated by a bunny.\n+\t */\n+\tpublic class PlayerBunnyPregnancy implements VaginalPregnancy \n+\t{\n+\t\tprivate var pregnancyProgression:PregnancyProgression;\n+\t\tprivate var output:GuiOutput;\n+\t\tprivate var mutations:Mutations;\n+\t\t\n+\t\t/**\n+\t\t * Create a new bunny pregnancy for the player. Registers pregnancy for bunnies.\n+\t\t * @param\tpregnancyProgression instance used for registering pregnancy scenes\n+\t\t * @param\toutput instance for gui output\n+\t\t */\n+\t\tpublic function PlayerBunnyPregnancy(pregnancyProgression:PregnancyProgression, output:GuiOutput, mutations:Mutations)\n+\t\t{\n+\t\t\tthis.pregnancyProgression = pregnancyProgression;\n+\t\t\tthis.output = output;\n+\t\t\tthis.mutations = mutations;\n+\t\t\t\n+\t\t\tpregnancyProgression.registerVaginalPregnancyScene(PregnancyStore.PREGNANCY_PLAYER, PregnancyStore.PREGNANCY_BUNNY, this);\n+\t\t}","path":"classes/classes/Scenes/Monsters/pregnancies/PlayerBunnyPregnancy.as","position":34,"original_position":34,"commit_id":"31c8af386206c1ccd15dac41f46aa218f48dd24d","original_commit_id":"31c8af386206c1ccd15dac41f46aa218f48dd24d","user":{"login":"Stadler76","id":13157984,"avatar_url":"https://avatars0.githubusercontent.com/u/13157984?v=4","gravatar_id":"","url":"https://api.github.com/users/Stadler76","html_url":"https://github.com/Stadler76","followers_url":"https://api.github.com/users/Stadler76/followers","following_url":"https://api.github.com/users/Stadler76/following{/other_user}","gists_url":"https://api.github.com/users/Stadler76/gists{/gist_id}","starred_url":"https://api.github.com/users/Stadler76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stadler76/subscriptions","organizations_url":"https://api.github.com/users/Stadler76/orgs","repos_url":"https://api.github.com/users/Stadler76/repos","events_url":"https://api.github.com/users/Stadler76/events{/privacy}","received_events_url":"https://api.github.com/users/Stadler76/received_events","type":"User","site_admin":false},"body":"This should do as well:\r\n```as3\r\n\t\tpublic function PlayerBunnyPregnancy(pregnancyProgression:PregnancyProgression)\r\n\t\t{\r\n\t\t\tthis.pregnancyProgression = pregnancyProgression;\r\n\t\t\toutput = Output.init();\r\n\t\t\tmutations = Mutations.init();\r\n\t\t\t\r\n\t\t\tpregnancyProgression.registerVaginalPregnancyScene(PregnancyStore.PREGNANCY_PLAYER, PregnancyStore.PREGNANCY_BUNNY, this);\r\n\t\t}\r\n```\r\n\r\nWell, just a suggestion, no 'must do'.","created_at":"2018-03-14T18:44:55Z","updated_at":"2018-03-14T18:44:56Z","html_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod/pull/1263#discussion_r174570623","pull_request_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/comments/174570623"},"html":{"href":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod/pull/1263#discussion_r174570623"},"pull_request":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263"}}},"pull_request":{"url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263","id":174190888,"html_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod/pull/1263","diff_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod/pull/1263.diff","patch_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod/pull/1263.patch","issue_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues/1263","number":1263,"state":"closed","locked":false,"title":"Pregnancy Progress rework","user":{"login":"brrritssocold","id":19509767,"avatar_url":"https://avatars2.githubusercontent.com/u/19509767?v=4","gravatar_id":"","url":"https://api.github.com/users/brrritssocold","html_url":"https://github.com/brrritssocold","followers_url":"https://api.github.com/users/brrritssocold/followers","following_url":"https://api.github.com/users/brrritssocold/following{/other_user}","gists_url":"https://api.github.com/users/brrritssocold/gists{/gist_id}","starred_url":"https://api.github.com/users/brrritssocold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brrritssocold/subscriptions","organizations_url":"https://api.github.com/users/brrritssocold/orgs","repos_url":"https://api.github.com/users/brrritssocold/repos","events_url":"https://api.github.com/users/brrritssocold/events{/privacy}","received_events_url":"https://api.github.com/users/brrritssocold/received_events","type":"User","site_admin":false},"body":"This PR is ongoing work in response to #322. Phew! That was a lot of work.\r\n\r\nI opted for a lookup approach as is scales better than endless `if` blocks. A scene can be registered with Pregnancy progression, specifying Mother, Father and what scene to call.\r\n\r\nIn addition it can be extended to nest maps, so Mother - > Father -> Scene lookups can be performed.\r\n\r\n- Characterisation tests for Birth\r\n- Extracted code into methods\r\n- Code cleanup (spacing, curly brackets) for extracted code\r\n- Interface for Vaginal pregnancy\r\n- Use map / associative array / dictionary for scene lookup\r\n- Extract pregnancy content into own files where applicable\r\n\r\nTODO:\r\n - Extract anal pregnancy\r\n - Extend `PregnancyProgression` where player is not the mother, using nested maps\r\n   - e.g. Cotton impregnated by player, SandWitch impregnated by player, etc.\r\n   - Allow for any pregnancy combination (NPC/NPC, NPC/Monster, Player/Player [Sheila scene, see #261], etc.)\r\n - How to deal with non-standard pregnancies (Benoit), Pre / Post hooks?\r\n - If possible extract default progression code (\"Your belly has gotten larger\", etc.)","created_at":"2018-03-10T21:39:46Z","updated_at":"2018-03-14T18:44:56Z","closed_at":"2018-03-12T17:27:57Z","merged_at":"2018-03-12T17:27:57Z","merge_commit_sha":"db98a40c9d568491b1a0990c14202cd25408d36b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263/commits","review_comments_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263/comments","review_comment_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues/1263/comments","statuses_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/statuses/31c8af386206c1ccd15dac41f46aa218f48dd24d","head":{"label":"brrritssocold:preg_prog_extract_methods","ref":"preg_prog_extract_methods","sha":"31c8af386206c1ccd15dac41f46aa218f48dd24d","user":{"login":"brrritssocold","id":19509767,"avatar_url":"https://avatars2.githubusercontent.com/u/19509767?v=4","gravatar_id":"","url":"https://api.github.com/users/brrritssocold","html_url":"https://github.com/brrritssocold","followers_url":"https://api.github.com/users/brrritssocold/followers","following_url":"https://api.github.com/users/brrritssocold/following{/other_user}","gists_url":"https://api.github.com/users/brrritssocold/gists{/gist_id}","starred_url":"https://api.github.com/users/brrritssocold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brrritssocold/subscriptions","organizations_url":"https://api.github.com/users/brrritssocold/orgs","repos_url":"https://api.github.com/users/brrritssocold/repos","events_url":"https://api.github.com/users/brrritssocold/events{/privacy}","received_events_url":"https://api.github.com/users/brrritssocold/received_events","type":"User","site_admin":false},"repo":{"id":82561615,"name":"Corruption-of-Champions-Mod","full_name":"brrritssocold/Corruption-of-Champions-Mod","owner":{"login":"brrritssocold","id":19509767,"avatar_url":"https://avatars2.githubusercontent.com/u/19509767?v=4","gravatar_id":"","url":"https://api.github.com/users/brrritssocold","html_url":"https://github.com/brrritssocold","followers_url":"https://api.github.com/users/brrritssocold/followers","following_url":"https://api.github.com/users/brrritssocold/following{/other_user}","gists_url":"https://api.github.com/users/brrritssocold/gists{/gist_id}","starred_url":"https://api.github.com/users/brrritssocold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brrritssocold/subscriptions","organizations_url":"https://api.github.com/users/brrritssocold/orgs","repos_url":"https://api.github.com/users/brrritssocold/repos","events_url":"https://api.github.com/users/brrritssocold/events{/privacy}","received_events_url":"https://api.github.com/users/brrritssocold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brrritssocold/Corruption-of-Champions-Mod","description":"CoC source from fenoxo, modded by Kitteh6660","fork":true,"url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod","forks_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/forks","keys_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/teams","hooks_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/hooks","issue_events_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/issues/events{/number}","events_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/events","assignees_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/assignees{/user}","branches_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/branches{/branch}","tags_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/tags","blobs_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/git/refs{/sha}","trees_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/statuses/{sha}","languages_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/languages","stargazers_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/stargazers","contributors_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/contributors","subscribers_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/subscribers","subscription_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/subscription","commits_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/commits{/sha}","git_commits_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/git/commits{/sha}","comments_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/comments{/number}","issue_comment_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/issues/comments{/number}","contents_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/contents/{+path}","compare_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/merges","archive_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/downloads","issues_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/issues{/number}","pulls_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/pulls{/number}","milestones_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/milestones{/number}","notifications_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/labels{/name}","releases_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/releases{/id}","deployments_url":"https://api.github.com/repos/brrritssocold/Corruption-of-Champions-Mod/deployments","created_at":"2017-02-20T13:36:23Z","updated_at":"2017-04-20T12:50:55Z","pushed_at":"2018-03-14T06:49:29Z","git_url":"git://github.com/brrritssocold/Corruption-of-Champions-Mod.git","ssh_url":"git@github.com:brrritssocold/Corruption-of-Champions-Mod.git","clone_url":"https://github.com/brrritssocold/Corruption-of-Champions-Mod.git","svn_url":"https://github.com/brrritssocold/Corruption-of-Champions-Mod","homepage":"","size":613730,"stargazers_count":0,"watchers_count":0,"language":"ActionScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kitteh6660:master","ref":"master","sha":"4f0c325e55c2555892064db728c5c54345534eae","user":{"login":"Kitteh6660","id":5838739,"avatar_url":"https://avatars0.githubusercontent.com/u/5838739?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitteh6660","html_url":"https://github.com/Kitteh6660","followers_url":"https://api.github.com/users/Kitteh6660/followers","following_url":"https://api.github.com/users/Kitteh6660/following{/other_user}","gists_url":"https://api.github.com/users/Kitteh6660/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitteh6660/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitteh6660/subscriptions","organizations_url":"https://api.github.com/users/Kitteh6660/orgs","repos_url":"https://api.github.com/users/Kitteh6660/repos","events_url":"https://api.github.com/users/Kitteh6660/events{/privacy}","received_events_url":"https://api.github.com/users/Kitteh6660/received_events","type":"User","site_admin":false},"repo":{"id":23464782,"name":"Corruption-of-Champions-Mod","full_name":"Kitteh6660/Corruption-of-Champions-Mod","owner":{"login":"Kitteh6660","id":5838739,"avatar_url":"https://avatars0.githubusercontent.com/u/5838739?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitteh6660","html_url":"https://github.com/Kitteh6660","followers_url":"https://api.github.com/users/Kitteh6660/followers","following_url":"https://api.github.com/users/Kitteh6660/following{/other_user}","gists_url":"https://api.github.com/users/Kitteh6660/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitteh6660/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitteh6660/subscriptions","organizations_url":"https://api.github.com/users/Kitteh6660/orgs","repos_url":"https://api.github.com/users/Kitteh6660/repos","events_url":"https://api.github.com/users/Kitteh6660/events{/privacy}","received_events_url":"https://api.github.com/users/Kitteh6660/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod","description":"CoC source from fenoxo, modded by Kitteh6660","fork":true,"url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod","forks_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/forks","keys_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/teams","hooks_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/hooks","issue_events_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues/events{/number}","events_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/events","assignees_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/assignees{/user}","branches_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/branches{/branch}","tags_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/tags","blobs_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/languages","stargazers_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/stargazers","contributors_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/contributors","subscribers_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/subscribers","subscription_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/subscription","commits_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/contents/{+path}","compare_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/merges","archive_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/downloads","issues_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues{/number}","pulls_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/labels{/name}","releases_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/releases{/id}","deployments_url":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/deployments","created_at":"2014-08-29T13:26:52Z","updated_at":"2018-03-14T01:15:54Z","pushed_at":"2018-03-14T08:46:47Z","git_url":"git://github.com/Kitteh6660/Corruption-of-Champions-Mod.git","ssh_url":"git@github.com:Kitteh6660/Corruption-of-Champions-Mod.git","clone_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod.git","svn_url":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod","homepage":"","size":616395,"stargazers_count":130,"watchers_count":130,"language":"ActionScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":83,"open_issues":56,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263"},"html":{"href":"https://github.com/Kitteh6660/Corruption-of-Champions-Mod/pull/1263"},"issue":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues/1263"},"comments":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/issues/1263/comments"},"review_comments":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263/comments"},"review_comment":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/pulls/1263/commits"},"statuses":{"href":"https://api.github.com/repos/Kitteh6660/Corruption-of-Champions-Mod/statuses/31c8af386206c1ccd15dac41f46aa218f48dd24d"}},"author_association":"NONE"}}
{"actor":{"display_login":"Stadler76"}}