{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/212287927","pull_request_review_id":148884782,"id":212287927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjI4NzkyNw==","diff_hunk":"@@ -543,19 +559,33 @@ private[cluster] class ClusterCoreDaemon(publisher: ActorRef, joinConfigCompatCh\n         JoinConfigCompatChecker.filterWithKeys(allowedConfigPaths, context.system.settings.config)\n       }\n \n-      joinConfigCompatChecker.check(joiningNodeConfig, configWithoutSensitiveKeys) match {\n-        case Valid ⇒\n-          val nonSensitiveKeys = JoinConfigCompatChecker.removeSensitiveKeys(joiningNodeConfig, cluster.settings)\n-          // Send back to joining node a subset of current configuration\n-          // containing the keys initially sent by the joining node minus\n-          // any sensitive keys as defined by this node configuration\n-          val clusterConfig = JoinConfigCompatChecker.filterWithKeys(nonSensitiveKeys, context.system.settings.config)\n-          sender() ! InitJoinAck(selfAddress, CompatibleConfig(clusterConfig))\n-        case Invalid(messages) ⇒\n-          // messages are only logged on the cluster side\n-          log.warning(\"Found incompatible settings when [{}] tried to join: {}\", sender().path.address, messages.mkString(\", \"))\n-          sender() ! InitJoinAck(selfAddress, IncompatibleConfig)\n-      }\n+      val configCheckReply =\n+        joinConfigCompatChecker.check(joiningNodeConfig, configWithoutSensitiveKeys) match {\n+          case Valid ⇒\n+            if (configCheckUnsupportedByJoiningNode)\n+              ConfigCheckUnsupportedByJoiningNode\n+            else {\n+              val nonSensitiveKeys = JoinConfigCompatChecker.removeSensitiveKeys(joiningNodeConfig, cluster.settings)\n+              // Send back to joining node a subset of current configuration\n+              // containing the keys initially sent by the joining node minus\n+              // any sensitive keys as defined by this node configuration\n+              val clusterConfig = JoinConfigCompatChecker.filterWithKeys(nonSensitiveKeys, context.system.settings.config)\n+              CompatibleConfig(clusterConfig)\n+            }\n+          case Invalid(messages) ⇒\n+            // messages are only logged on the cluster side\n+            log.warning(\n+              \"Found incompatible settings when [{}] tried to join: {}. \" +\n+                \"Self version [{}], Joining version [{}].\",\n+              sender().path.address, messages.mkString(\", \"),\n+              context.system.settings.ConfigVersion, joiningNodeVersion)\n+            if (configCheckUnsupportedByJoiningNode)\n+              ConfigCheckUnsupportedByJoiningNode","path":"akka-cluster/src/main/scala/akka/cluster/ClusterDaemon.scala","position":77,"original_position":77,"commit_id":"45fc3a19267485bbba65acc7d7c090dde43ea13c","original_commit_id":"45fc3a19267485bbba65acc7d7c090dde43ea13c","user":{"login":"jrudolph","id":9868,"node_id":"MDQ6VXNlcjk4Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/9868?v=4","gravatar_id":"","url":"https://api.github.com/users/jrudolph","html_url":"https://github.com/jrudolph","followers_url":"https://api.github.com/users/jrudolph/followers","following_url":"https://api.github.com/users/jrudolph/following{/other_user}","gists_url":"https://api.github.com/users/jrudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/jrudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrudolph/subscriptions","organizations_url":"https://api.github.com/users/jrudolph/orgs","repos_url":"https://api.github.com/users/jrudolph/repos","events_url":"https://api.github.com/users/jrudolph/events{/privacy}","received_events_url":"https://api.github.com/users/jrudolph/received_events","type":"User","site_admin":false},"body":"So, in the incompatible case, we just note the incompatibility but cannot report to the peer? What happens then? Will it just go on as if nothing had happened?","created_at":"2018-08-23T12:25:49Z","updated_at":"2018-08-23T12:25:50Z","html_url":"https://github.com/akka/akka/pull/25501#discussion_r212287927","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/25501","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/212287927"},"html":{"href":"https://github.com/akka/akka/pull/25501#discussion_r212287927"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/25501"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/25501","id":209478279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDc4Mjc5","html_url":"https://github.com/akka/akka/pull/25501","diff_url":"https://github.com/akka/akka/pull/25501.diff","patch_url":"https://github.com/akka/akka/pull/25501.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/25501","number":25501,"state":"open","locked":false,"title":"Support joining 2.5.9 or earlier, compat InitJoinAck, #25491","user":{"login":"patriknw","id":336161,"node_id":"MDQ6VXNlcjMzNjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"* Detect that joining node is 2.5.9 or earlier by empty ConfigCheck\r\n  config in InitJoin message. Then send back Address, which was the\r\n  old representation of InitJoinAck\r\n* Include akka.version in logging to facilitate troubleshooting\r\n\r\nSee problem description in ticket.\r\n\r\nRefs #25491","created_at":"2018-08-20T10:34:21Z","updated_at":"2018-08-23T12:25:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dc8e637ac95fab015ccec9025af731a10c81b4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":92390779,"node_id":"MDU6TGFiZWw5MjM5MDc3OQ==","url":"https://api.github.com/repos/akka/akka/labels/2%20-%20pick%20next","name":"2 - pick next","color":"207de5","default":false},{"id":37797347,"node_id":"MDU6TGFiZWwzNzc5NzM0Nw==","url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/25501/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/25501/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/25501/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/45fc3a19267485bbba65acc7d7c090dde43ea13c","head":{"label":"akka:wip-25491-conf-check-patriknw","ref":"wip-25491-conf-check-patriknw","sha":"45fc3a19267485bbba65acc7d7c090dde43ea13c","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-08-23T12:13:07Z","pushed_at":"2018-08-23T12:12:57Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":213133,"stargazers_count":8889,"watchers_count":8889,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2828,"mirror_url":null,"archived":false,"open_issues_count":729,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2828,"open_issues":729,"watchers":8889,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"5be8d975c4f69c09a071fa972985bf82a5afa268","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-08-23T12:13:07Z","pushed_at":"2018-08-23T12:12:57Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":213133,"stargazers_count":8889,"watchers_count":8889,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2828,"mirror_url":null,"archived":false,"open_issues_count":729,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2828,"open_issues":729,"watchers":8889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/25501"},"html":{"href":"https://github.com/akka/akka/pull/25501"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/25501"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/25501/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/25501/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/25501/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/45fc3a19267485bbba65acc7d7c090dde43ea13c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jrudolph"}}