{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/223143942","pull_request_review_id":162210522,"id":223143942,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE0Mzk0Mg==","diff_hunk":"@@ -45,3 +53,30 @@ func ConvertNamespaceList(namespaceList *kapi.NamespaceList) *projectapi.Project\n \t}\n \treturn projects\n }\n+\n+// GetAttrs returns labels and fields of a given object for filtering purposes.\n+func getAttrs(obj runtime.Object) (labels.Set, fields.Set, bool, error) {\n+\tprojectObj, ok := obj.(*projectapi.Project)\n+\tif !ok {\n+\t\treturn nil, nil, false, fmt.Errorf(\"not a project\")\n+\t}\n+\treturn labels.Set(projectObj.Labels), projectToSelectableFields(projectObj), projectObj.Initializers != nil, nil\n+}\n+\n+// MatchProject returns a generic matcher for a given label and field selector.\n+func MatchProject(label labels.Selector, field fields.Selector) apistorage.SelectionPredicate {\n+\treturn apistorage.SelectionPredicate{\n+\t\tLabel:    label,\n+\t\tField:    field,\n+\t\tGetAttrs: getAttrs,\n+\t}\n+}\n+\n+// NamespaceToSelectableFields returns a field set that represents the object\n+func projectToSelectableFields(projectObj *projectapi.Project) fields.Set {","path":"pkg/project/util/util.go","position":43,"original_position":43,"commit_id":"1aedf7f8cf33a6faaa85f51984199d6072b954b2","original_commit_id":"1aedf7f8cf33a6faaa85f51984199d6072b954b2","user":{"login":"soltysh","id":576341,"node_id":"MDQ6VXNlcjU3NjM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"Nit: godoc does not matches function name.","created_at":"2018-10-05T21:31:41Z","updated_at":"2018-10-05T21:32:00Z","html_url":"https://github.com/openshift/origin/pull/21167#discussion_r223143942","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/21167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/223143942"},"html":{"href":"https://github.com/openshift/origin/pull/21167#discussion_r223143942"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/21167"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/21167","id":220214597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjE0NTk3","html_url":"https://github.com/openshift/origin/pull/21167","diff_url":"https://github.com/openshift/origin/pull/21167.diff","patch_url":"https://github.com/openshift/origin/pull/21167.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/21167","number":21167,"state":"open","locked":false,"title":"fix projects when watching with selector","user":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"body":"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633101\r\n\r\nFixes fieldSelector matching when watching Projects.\r\n\r\ncc @deads2k @soltysh ","created_at":"2018-10-04T00:01:58Z","updated_at":"2018-10-05T21:32:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5c165152b8d3e3a0e75b9ca14f4019aba13809b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"smarterclayton","id":1163175,"node_id":"MDQ6VXNlcjExNjMxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":657292628,"node_id":"MDU6TGFiZWw2NTcyOTI2Mjg=","url":"https://api.github.com/repos/openshift/origin/labels/sig/security","name":"sig/security","color":"f9d0c4","default":false},{"id":640548394,"node_id":"MDU6TGFiZWw2NDA1NDgzOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/21167/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/21167/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/21167/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/1aedf7f8cf33a6faaa85f51984199d6072b954b2","head":{"label":"juanvallejo:jvallejo/fix-projects-watch-selector","ref":"jvallejo/fix-projects-watch-selector","sha":"1aedf7f8cf33a6faaa85f51984199d6072b954b2","user":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"repo":{"id":50698131,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY5ODEzMQ==","name":"origin","full_name":"juanvallejo/origin","private":false,"owner":{"login":"juanvallejo","id":3902875,"node_id":"MDQ6VXNlcjM5MDI4NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/juanvallejo/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/juanvallejo/origin","forks_url":"https://api.github.com/repos/juanvallejo/origin/forks","keys_url":"https://api.github.com/repos/juanvallejo/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juanvallejo/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juanvallejo/origin/teams","hooks_url":"https://api.github.com/repos/juanvallejo/origin/hooks","issue_events_url":"https://api.github.com/repos/juanvallejo/origin/issues/events{/number}","events_url":"https://api.github.com/repos/juanvallejo/origin/events","assignees_url":"https://api.github.com/repos/juanvallejo/origin/assignees{/user}","branches_url":"https://api.github.com/repos/juanvallejo/origin/branches{/branch}","tags_url":"https://api.github.com/repos/juanvallejo/origin/tags","blobs_url":"https://api.github.com/repos/juanvallejo/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juanvallejo/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juanvallejo/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/juanvallejo/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juanvallejo/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/juanvallejo/origin/languages","stargazers_url":"https://api.github.com/repos/juanvallejo/origin/stargazers","contributors_url":"https://api.github.com/repos/juanvallejo/origin/contributors","subscribers_url":"https://api.github.com/repos/juanvallejo/origin/subscribers","subscription_url":"https://api.github.com/repos/juanvallejo/origin/subscription","commits_url":"https://api.github.com/repos/juanvallejo/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/juanvallejo/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/juanvallejo/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/juanvallejo/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/juanvallejo/origin/contents/{+path}","compare_url":"https://api.github.com/repos/juanvallejo/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juanvallejo/origin/merges","archive_url":"https://api.github.com/repos/juanvallejo/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juanvallejo/origin/downloads","issues_url":"https://api.github.com/repos/juanvallejo/origin/issues{/number}","pulls_url":"https://api.github.com/repos/juanvallejo/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/juanvallejo/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/juanvallejo/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juanvallejo/origin/labels{/name}","releases_url":"https://api.github.com/repos/juanvallejo/origin/releases{/id}","deployments_url":"https://api.github.com/repos/juanvallejo/origin/deployments","created_at":"2016-01-29T23:22:53Z","updated_at":"2018-09-07T19:18:31Z","pushed_at":"2018-10-05T18:45:12Z","git_url":"git://github.com/juanvallejo/origin.git","ssh_url":"git@github.com:juanvallejo/origin.git","clone_url":"https://github.com/juanvallejo/origin.git","svn_url":"https://github.com/juanvallejo/origin","homepage":"http://www.openshift.org","size":923201,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0ec51491ee70d11e54502adc2f56394712098df7","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ0MjY2OA==","name":"origin","full_name":"openshift/origin","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-10-05T16:22:43Z","pushed_at":"2018-10-05T19:43:00Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":973731,"stargazers_count":5175,"watchers_count":5175,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3145,"mirror_url":null,"archived":false,"open_issues_count":574,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3145,"open_issues":574,"watchers":5175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/21167"},"html":{"href":"https://github.com/openshift/origin/pull/21167"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/21167"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/21167/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/21167/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/21167/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/1aedf7f8cf33a6faaa85f51984199d6072b954b2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"soltysh"}}