{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/174763035","pull_request_review_id":104177700,"id":174763035,"diff_hunk":"@@ -536,11 +536,14 @@ func (tx *logTX) DequeueLeaves(ctx context.Context, limit int, cutoff time.Time)\n \t\trows = genDequeueRowsOld(tx.getLogStorageConfig(), tx.treeID, now.Unix(), rand.Int31n(numByteValues))\n \t}\n \tret := make([]*trillian.LogLeaf, 0, limit)\n+\treadOpts := &spanner.ReadOptions{Limit: limit}\n+\tdrain := 0","path":"storage/cloudspanner/log_storage.go","position":5,"original_position":5,"commit_id":"13473b21120e84f619ef56b2901575c1457951b4","original_commit_id":"13473b21120e84f619ef56b2901575c1457951b4","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars2.githubusercontent.com/u/13366863?v=4","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"body":"'discarded' maybe? Wasn't immediately clear what it meant.","created_at":"2018-03-15T12:20:06Z","updated_at":"2018-03-15T12:23:04Z","html_url":"https://github.com/google/trillian/pull/1054#discussion_r174763035","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/1054","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/174763035"},"html":{"href":"https://github.com/google/trillian/pull/1054#discussion_r174763035"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/1054","id":175232017,"html_url":"https://github.com/google/trillian/pull/1054","diff_url":"https://github.com/google/trillian/pull/1054.diff","patch_url":"https://github.com/google/trillian/pull/1054.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/1054","number":1054,"state":"open","locked":false,"title":"Limit data read during operation","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"body":"Spanner seems to not take an error being returned by a RowIterator func as a reason to cancel/abandon the underlying read, and the encapsulating transaction will not commit until the read has finished and so this causes poor performance, particularly during sequencing.\r\n\r\nThis change uses `ReadOptions.Limit` to specify the number of rows to read when dequeueing leaves, and switches to SQL for fetching subtree data.\r\n\r\n#950 ","created_at":"2018-03-15T12:15:25Z","updated_at":"2018-03-15T12:23:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac6eb9f1f20a8674ca5727b7c1607a698e0c06a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":389540533,"url":"https://api.github.com/repos/google/trillian/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/1054/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/13473b21120e84f619ef56b2901575c1457951b4","head":{"label":"AlCutter:moar_sql","ref":"moar_sql","sha":"13473b21120e84f619ef56b2901575c1457951b4","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"repo":{"id":60775946,"name":"trillian","full_name":"AlCutter/trillian","owner":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlCutter/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/AlCutter/trillian","forks_url":"https://api.github.com/repos/AlCutter/trillian/forks","keys_url":"https://api.github.com/repos/AlCutter/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlCutter/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlCutter/trillian/teams","hooks_url":"https://api.github.com/repos/AlCutter/trillian/hooks","issue_events_url":"https://api.github.com/repos/AlCutter/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/AlCutter/trillian/events","assignees_url":"https://api.github.com/repos/AlCutter/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/AlCutter/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/AlCutter/trillian/tags","blobs_url":"https://api.github.com/repos/AlCutter/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlCutter/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlCutter/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlCutter/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlCutter/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/AlCutter/trillian/languages","stargazers_url":"https://api.github.com/repos/AlCutter/trillian/stargazers","contributors_url":"https://api.github.com/repos/AlCutter/trillian/contributors","subscribers_url":"https://api.github.com/repos/AlCutter/trillian/subscribers","subscription_url":"https://api.github.com/repos/AlCutter/trillian/subscription","commits_url":"https://api.github.com/repos/AlCutter/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlCutter/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlCutter/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlCutter/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlCutter/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/AlCutter/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlCutter/trillian/merges","archive_url":"https://api.github.com/repos/AlCutter/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlCutter/trillian/downloads","issues_url":"https://api.github.com/repos/AlCutter/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/AlCutter/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/AlCutter/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/AlCutter/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlCutter/trillian/labels{/name}","releases_url":"https://api.github.com/repos/AlCutter/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/AlCutter/trillian/deployments","created_at":"2016-06-09T13:14:33Z","updated_at":"2016-12-19T15:07:06Z","pushed_at":"2018-03-15T12:11:04Z","git_url":"git://github.com/AlCutter/trillian.git","ssh_url":"git@github.com:AlCutter/trillian.git","clone_url":"https://github.com/AlCutter/trillian.git","svn_url":"https://github.com/AlCutter/trillian","homepage":null,"size":9412,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0d98af7dc262cff2e6f665fed30a76d2d83dfe08","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2018-03-14T11:17:14Z","pushed_at":"2018-03-15T12:15:26Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":9440,"stargazers_count":852,"watchers_count":852,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":118,"open_issues":40,"watchers":852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/1054"},"html":{"href":"https://github.com/google/trillian/pull/1054"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/1054"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/13473b21120e84f619ef56b2901575c1457951b4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Martin2112"}}