{"action":"created","issue":{"url":"https://api.github.com/repos/DiUS/pact-jvm/issues/736","repository_url":"https://api.github.com/repos/DiUS/pact-jvm","labels_url":"https://api.github.com/repos/DiUS/pact-jvm/issues/736/labels{/name}","comments_url":"https://api.github.com/repos/DiUS/pact-jvm/issues/736/comments","events_url":"https://api.github.com/repos/DiUS/pact-jvm/issues/736/events","html_url":"https://github.com/DiUS/pact-jvm/issues/736","id":342326986,"node_id":"MDU6SXNzdWUzNDIzMjY5ODY=","number":736,"title":"JUnit5 TestResultAccumulator does not publish verification results","user":{"login":"nwholloway","id":1571880,"node_id":"MDQ6VXNlcjE1NzE4ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1571880?v=4","gravatar_id":"","url":"https://api.github.com/users/nwholloway","html_url":"https://github.com/nwholloway","followers_url":"https://api.github.com/users/nwholloway/followers","following_url":"https://api.github.com/users/nwholloway/following{/other_user}","gists_url":"https://api.github.com/users/nwholloway/gists{/gist_id}","starred_url":"https://api.github.com/users/nwholloway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwholloway/subscriptions","organizations_url":"https://api.github.com/users/nwholloway/orgs","repos_url":"https://api.github.com/users/nwholloway/repos","events_url":"https://api.github.com/users/nwholloway/events{/privacy}","received_events_url":"https://api.github.com/users/nwholloway/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-18T13:24:17Z","updated_at":"2018-07-29T01:46:41Z","closed_at":"2018-07-28T08:21:07Z","author_association":"NONE","body":"I saw [Issue 694](694) had a fix for publishing verification results, so I tried with 3.5.19.  I found that for my project the verification results were not published.\r\n\r\nResults for pacts are accumulated in the map `testResults`.  Unfortunately, the value for `pact.hashCode()` changes, so results for a pact are split across multiple entries.\r\n\r\nThe attached screenshot shows a test with 13 interactions where the results are split across 4 map entries.  You can see the same object identity is reported in all 4 keys.\r\n\r\n![image](https://user-images.githubusercontent.com/1571880/42875570-05374e0c-8a7c-11e8-8700-402ac99b670a.png)\r\n\r\nMy investigation of what might be contributing to the change in hash code has the following chain:\r\n\r\n* RequestResponsePact.iteractions\r\n* RequestResponseInteraction.response\r\n* Response.matchingRules\r\n\r\nInitially `matchingRules` is an empty list, but after the pact interaction is validated, the list has two entries:\r\n* \"header\" -> \"Category(name=header, matchingRules={})\"\r\n* \"body\" -> \"Category(name=body, matchingRules={})\"\r\n\r\nOther pact interactions are not mutated, and `matchingRules` remains an empty list.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DiUS/pact-jvm/issues/comments/408646145","html_url":"https://github.com/DiUS/pact-jvm/issues/736#issuecomment-408646145","issue_url":"https://api.github.com/repos/DiUS/pact-jvm/issues/736","id":408646145,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY0NjE0NQ==","user":{"login":"uglyog","id":863666,"node_id":"MDQ6VXNlcjg2MzY2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/863666?v=4","gravatar_id":"","url":"https://api.github.com/users/uglyog","html_url":"https://github.com/uglyog","followers_url":"https://api.github.com/users/uglyog/followers","following_url":"https://api.github.com/users/uglyog/following{/other_user}","gists_url":"https://api.github.com/users/uglyog/gists{/gist_id}","starred_url":"https://api.github.com/users/uglyog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uglyog/subscriptions","organizations_url":"https://api.github.com/users/uglyog/orgs","repos_url":"https://api.github.com/users/uglyog/repos","events_url":"https://api.github.com/users/uglyog/events{/privacy}","received_events_url":"https://api.github.com/users/uglyog/received_events","type":"User","site_admin":false},"created_at":"2018-07-29T01:46:41Z","updated_at":"2018-07-29T01:46:41Z","author_association":"MEMBER","body":"Thanks for digging into this. The JUnit 4 module has the same issue."}}
{"actor":{"display_login":"uglyog"}}