{"action":"created","issue":{"url":"https://api.github.com/repos/bblfsh/sdk/issues/251","repository_url":"https://api.github.com/repos/bblfsh/sdk","labels_url":"https://api.github.com/repos/bblfsh/sdk/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/bblfsh/sdk/issues/251/comments","events_url":"https://api.github.com/repos/bblfsh/sdk/issues/251/events","html_url":"https://github.com/bblfsh/sdk/pull/251","id":310059518,"number":251,"title":"Transformation DSL (BIP-4 and BIP-5)","user":{"login":"dennwc","id":676724,"avatar_url":"https://avatars3.githubusercontent.com/u/676724?v=4","gravatar_id":"","url":"https://api.github.com/users/dennwc","html_url":"https://github.com/dennwc","followers_url":"https://api.github.com/users/dennwc/followers","following_url":"https://api.github.com/users/dennwc/following{/other_user}","gists_url":"https://api.github.com/users/dennwc/gists{/gist_id}","starred_url":"https://api.github.com/users/dennwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennwc/subscriptions","organizations_url":"https://api.github.com/users/dennwc/orgs","repos_url":"https://api.github.com/users/dennwc/repos","events_url":"https://api.github.com/users/dennwc/events{/privacy}","received_events_url":"https://api.github.com/users/dennwc/received_events","type":"User","site_admin":false},"labels":[{"id":544767432,"url":"https://api.github.com/repos/bblfsh/sdk/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"dennwc","id":676724,"avatar_url":"https://avatars3.githubusercontent.com/u/676724?v=4","gravatar_id":"","url":"https://api.github.com/users/dennwc","html_url":"https://github.com/dennwc","followers_url":"https://api.github.com/users/dennwc/followers","following_url":"https://api.github.com/users/dennwc/following{/other_user}","gists_url":"https://api.github.com/users/dennwc/gists{/gist_id}","starred_url":"https://api.github.com/users/dennwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennwc/subscriptions","organizations_url":"https://api.github.com/users/dennwc/orgs","repos_url":"https://api.github.com/users/dennwc/repos","events_url":"https://api.github.com/users/dennwc/events{/privacy}","received_events_url":"https://api.github.com/users/dennwc/received_events","type":"User","site_admin":false},"assignees":[{"login":"dennwc","id":676724,"avatar_url":"https://avatars3.githubusercontent.com/u/676724?v=4","gravatar_id":"","url":"https://api.github.com/users/dennwc","html_url":"https://github.com/dennwc","followers_url":"https://api.github.com/users/dennwc/followers","following_url":"https://api.github.com/users/dennwc/following{/other_user}","gists_url":"https://api.github.com/users/dennwc/gists{/gist_id}","starred_url":"https://api.github.com/users/dennwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennwc/subscriptions","organizations_url":"https://api.github.com/users/dennwc/orgs","repos_url":"https://api.github.com/users/dennwc/repos","events_url":"https://api.github.com/users/dennwc/events{/privacy}","received_events_url":"https://api.github.com/users/dennwc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/bblfsh/sdk/milestones/1","html_url":"https://github.com/bblfsh/sdk/milestone/1","labels_url":"https://api.github.com/repos/bblfsh/sdk/milestones/1/labels","id":3190203,"number":1,"title":"UAST2","description":"","creator":{"login":"dennwc","id":676724,"avatar_url":"https://avatars3.githubusercontent.com/u/676724?v=4","gravatar_id":"","url":"https://api.github.com/users/dennwc","html_url":"https://github.com/dennwc","followers_url":"https://api.github.com/users/dennwc/followers","following_url":"https://api.github.com/users/dennwc/following{/other_user}","gists_url":"https://api.github.com/users/dennwc/gists{/gist_id}","starred_url":"https://api.github.com/users/dennwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennwc/subscriptions","organizations_url":"https://api.github.com/users/dennwc/orgs","repos_url":"https://api.github.com/users/dennwc/repos","events_url":"https://api.github.com/users/dennwc/events{/privacy}","received_events_url":"https://api.github.com/users/dennwc/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2018-03-15T11:59:53Z","updated_at":"2018-03-30T12:55:26Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-03-30T12:55:26Z","updated_at":"2018-04-24T08:38:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bblfsh/sdk/pulls/251","html_url":"https://github.com/bblfsh/sdk/pull/251","diff_url":"https://github.com/bblfsh/sdk/pull/251.diff","patch_url":"https://github.com/bblfsh/sdk/pull/251.patch"},"body":"Final implementation of AST transformation DSL.\r\n\r\nResolves #240\r\nResolves #241\r\nResolves #242\r\nResolves #244 "},"comment":{"url":"https://api.github.com/repos/bblfsh/sdk/issues/comments/383851167","html_url":"https://github.com/bblfsh/sdk/pull/251#issuecomment-383851167","issue_url":"https://api.github.com/repos/bblfsh/sdk/issues/251","id":383851167,"user":{"login":"dennwc","id":676724,"avatar_url":"https://avatars3.githubusercontent.com/u/676724?v=4","gravatar_id":"","url":"https://api.github.com/users/dennwc","html_url":"https://github.com/dennwc","followers_url":"https://api.github.com/users/dennwc/followers","following_url":"https://api.github.com/users/dennwc/following{/other_user}","gists_url":"https://api.github.com/users/dennwc/gists{/gist_id}","starred_url":"https://api.github.com/users/dennwc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennwc/subscriptions","organizations_url":"https://api.github.com/users/dennwc/orgs","repos_url":"https://api.github.com/users/dennwc/repos","events_url":"https://api.github.com/users/dennwc/events{/privacy}","received_events_url":"https://api.github.com/users/dennwc/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T08:38:08Z","updated_at":"2018-04-24T08:38:08Z","author_association":"MEMBER","body":"\n\n\n\nReviewed 8 of 8 files at r7.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[a discussion](https://beta.reviewable.io/reviews/bblfsh/sdk/251#-LAqlYtm2BsYBsK_TDyA:-LAqmWWI2IBBs9bcCHeR:bo26jz5) (no related file):*\n<details><summary><i>Previously, juanjux (Juanjo Alvarez Martinez) wrote…</i></summary><blockquote>\n\nFeature request: with the previous DSL you could do:\n\n```go\nOn(HasInternalRole(\"left\")).Roles(uast.Left),\nOn(HasInternalRole(\"right\")).Roles(uast.Right),\n```\n\nThis was extremely convenient for properties that could always be tagged with the same roles no matter what the parent node type was. AFAIK, this can't be done with the new DSL (you always need to annotate the property nodes in the context of a parent type, correct me if I'm wrong) but it would be great to recover it. Would also simplify a lot the annotation of operators in some languages without needing helpers.\n\nIf done, doesn't have to go into this PR, but I don't want to add issues to the project until this is merged into ~master.\n</blockquote></details>\n\nIt can be done right now, but helpers like `AnnotateTypeFields` won't work, because they expect a type to be set. Will add helpers for objects with no specific type.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/bblfsh/sdk/251)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dennwc"}}