{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/FastBlockShield/issues/36","repository_url":"https://api.github.com/repos/mozilla/FastBlockShield","labels_url":"https://api.github.com/repos/mozilla/FastBlockShield/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/FastBlockShield/issues/36/comments","events_url":"https://api.github.com/repos/mozilla/FastBlockShield/issues/36/events","html_url":"https://github.com/mozilla/FastBlockShield/pull/36","id":348498309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODM1NDU4","number":36,"title":"Use etld and uuid to generate an ID per user per domain.","user":{"login":"ericawright","id":10803178,"node_id":"MDQ6VXNlcjEwODAzMTc4","avatar_url":"https://avatars1.githubusercontent.com/u/10803178?v=4","gravatar_id":"","url":"https://api.github.com/users/ericawright","html_url":"https://github.com/ericawright","followers_url":"https://api.github.com/users/ericawright/followers","following_url":"https://api.github.com/users/ericawright/following{/other_user}","gists_url":"https://api.github.com/users/ericawright/gists{/gist_id}","starred_url":"https://api.github.com/users/ericawright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericawright/subscriptions","organizations_url":"https://api.github.com/users/ericawright/orgs","repos_url":"https://api.github.com/users/ericawright/repos","events_url":"https://api.github.com/users/ericawright/events{/privacy}","received_events_url":"https://api.github.com/users/ericawright/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-07T21:43:36Z","updated_at":"2018-08-22T18:49:18Z","closed_at":"2018-08-08T17:02:07Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mozilla/FastBlockShield/pulls/36","html_url":"https://github.com/mozilla/FastBlockShield/pull/36","diff_url":"https://github.com/mozilla/FastBlockShield/pull/36.diff","patch_url":"https://github.com/mozilla/FastBlockShield/pull/36.patch"},"body":"fixes: #21 \r\n\r\nWe no longer send the hostname unencrypted in the telemetry ping. Now we send an encrypted string made of the hostname and a user id. \r\nThis is also what is now stored in `browser.storage.local` - used for identifying how many times a user has refreshed a certain page.\r\nfrom a webextension we can't use external libraries so I've taken the sha256 code from `http://www.webtoolkit.info/javascript_sha256.html`\r\n\r\nnote: I chose to use [`sync` storage](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync) vs using `local` since This could potentially be used to record a user preference to not show the message again across devices if we chose to go that route.\r\n\r\n### to test\r\n- `npm install`\r\n- `npm run start`\r\n- go to a page with trackers, such as `https://bugzilla.mozilla.org/`\r\n- refresh the page\r\n- observe that the etld and uuid have been encrypted and should be seen in the logs of the telemetry ping as well as the log from `addToPayload`.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/FastBlockShield/issues/comments/415139300","html_url":"https://github.com/mozilla/FastBlockShield/pull/36#issuecomment-415139300","issue_url":"https://api.github.com/repos/mozilla/FastBlockShield/issues/36","id":415139300,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTEzOTMwMA==","user":{"login":"tdsmith","id":173889,"node_id":"MDQ6VXNlcjE3Mzg4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/173889?v=4","gravatar_id":"","url":"https://api.github.com/users/tdsmith","html_url":"https://github.com/tdsmith","followers_url":"https://api.github.com/users/tdsmith/followers","following_url":"https://api.github.com/users/tdsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdsmith/subscriptions","organizations_url":"https://api.github.com/users/tdsmith/orgs","repos_url":"https://api.github.com/users/tdsmith/repos","events_url":"https://api.github.com/users/tdsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdsmith/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T18:49:18Z","updated_at":"2018-08-22T18:49:18Z","author_association":"MEMBER","body":"Sorry for another rando driveby -- are you intentionally using the full hostname (like, say, www3.facebook.co.uk) instead of the etld+1 (which would be facebook.co.uk)?"}}
{"actor":{"display_login":"tdsmith"}}