{"action":"created","comment":{"url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/comments/182863177","pull_request_review_id":113750224,"id":182863177,"diff_hunk":"@@ -116,14 +90,15 @@ class RadioGroup extends React.Component {\n   }\n \n   render() {\n-    const { className } = this.props;\n+    const { className, explanationMessage, label, required, validationMessage } = this.props;\n     const classes = cx('form__group', className);\n \n     return (\n       <div className={classes}>\n-        {this.showLabel()}\n+        <FormLabel label={label} required={required} id=\"\" />","path":"src/scripts/components/RadioGroup.jsx","position":53,"original_position":53,"commit_id":"40993e8b8385d787f3bc99a0a9d46259c52fea7a","original_commit_id":"40993e8b8385d787f3bc99a0a9d46259c52fea7a","user":{"login":"zslabs","id":1018402,"avatar_url":"https://avatars2.githubusercontent.com/u/1018402?v=4","gravatar_id":"","url":"https://api.github.com/users/zslabs","html_url":"https://github.com/zslabs","followers_url":"https://api.github.com/users/zslabs/followers","following_url":"https://api.github.com/users/zslabs/following{/other_user}","gists_url":"https://api.github.com/users/zslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/zslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zslabs/subscriptions","organizations_url":"https://api.github.com/users/zslabs/orgs","repos_url":"https://api.github.com/users/zslabs/repos","events_url":"https://api.github.com/users/zslabs/events{/privacy}","received_events_url":"https://api.github.com/users/zslabs/received_events","type":"User","site_admin":false},"body":"I have it as `required` in `<FormLabel />` because ideally when this is in-use, we'd have an associated input that we can hook into so when you click on the label; it focuses on it. I used `\"\"` in this case since the labels here are more just a presentation layer since the radio group itself (and also in variable messages) doesn't have anything to focus on.","created_at":"2018-04-19T19:42:58Z","updated_at":"2018-04-19T19:42:58Z","html_url":"https://github.com/rhinogram/rhinostyle/pull/115#discussion_r182863177","pull_request_url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/comments/182863177"},"html":{"href":"https://github.com/rhinogram/rhinostyle/pull/115#discussion_r182863177"},"pull_request":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115"}},"in_reply_to_id":182862836},"pull_request":{"url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115","id":182874980,"html_url":"https://github.com/rhinogram/rhinostyle/pull/115","diff_url":"https://github.com/rhinogram/rhinostyle/pull/115.diff","patch_url":"https://github.com/rhinogram/rhinostyle/pull/115.patch","issue_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues/115","number":115,"state":"open","locked":false,"title":"Clean up form labels, validation, and explanation messages","user":{"login":"zslabs","id":1018402,"avatar_url":"https://avatars2.githubusercontent.com/u/1018402?v=4","gravatar_id":"","url":"https://api.github.com/users/zslabs","html_url":"https://github.com/zslabs","followers_url":"https://api.github.com/users/zslabs/followers","following_url":"https://api.github.com/users/zslabs/following{/other_user}","gists_url":"https://api.github.com/users/zslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/zslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zslabs/subscriptions","organizations_url":"https://api.github.com/users/zslabs/orgs","repos_url":"https://api.github.com/users/zslabs/repos","events_url":"https://api.github.com/users/zslabs/events{/privacy}","received_events_url":"https://api.github.com/users/zslabs/received_events","type":"User","site_admin":false},"body":"✔︎ I've tested in all browsers (IE11, Firefox, Safari, Chrome, and iOS)\r\n\r\n### What should this PR do?\r\nReduces the redundancy of ☝️by using compositional components. \r\n\r\n### What is the acceptance criteria?\r\n1. Looks the same, acts the same, but much better.\r\n","created_at":"2018-04-19T19:28:03Z","updated_at":"2018-04-19T19:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82ef585eda0919f0b78d5a222772e2460de164a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexgsummer","id":1727086,"avatar_url":"https://avatars0.githubusercontent.com/u/1727086?v=4","gravatar_id":"","url":"https://api.github.com/users/alexgsummer","html_url":"https://github.com/alexgsummer","followers_url":"https://api.github.com/users/alexgsummer/followers","following_url":"https://api.github.com/users/alexgsummer/following{/other_user}","gists_url":"https://api.github.com/users/alexgsummer/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgsummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgsummer/subscriptions","organizations_url":"https://api.github.com/users/alexgsummer/orgs","repos_url":"https://api.github.com/users/alexgsummer/repos","events_url":"https://api.github.com/users/alexgsummer/events{/privacy}","received_events_url":"https://api.github.com/users/alexgsummer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115/commits","review_comments_url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115/comments","review_comment_url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues/115/comments","statuses_url":"https://api.github.com/repos/rhinogram/rhinostyle/statuses/40993e8b8385d787f3bc99a0a9d46259c52fea7a","head":{"label":"rhinogram:zach/form-cleanup","ref":"zach/form-cleanup","sha":"40993e8b8385d787f3bc99a0a9d46259c52fea7a","user":{"login":"rhinogram","id":17254823,"avatar_url":"https://avatars0.githubusercontent.com/u/17254823?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinogram","html_url":"https://github.com/rhinogram","followers_url":"https://api.github.com/users/rhinogram/followers","following_url":"https://api.github.com/users/rhinogram/following{/other_user}","gists_url":"https://api.github.com/users/rhinogram/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinogram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinogram/subscriptions","organizations_url":"https://api.github.com/users/rhinogram/orgs","repos_url":"https://api.github.com/users/rhinogram/repos","events_url":"https://api.github.com/users/rhinogram/events{/privacy}","received_events_url":"https://api.github.com/users/rhinogram/received_events","type":"Organization","site_admin":false},"repo":{"id":55073706,"name":"rhinostyle","full_name":"rhinogram/rhinostyle","owner":{"login":"rhinogram","id":17254823,"avatar_url":"https://avatars0.githubusercontent.com/u/17254823?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinogram","html_url":"https://github.com/rhinogram","followers_url":"https://api.github.com/users/rhinogram/followers","following_url":"https://api.github.com/users/rhinogram/following{/other_user}","gists_url":"https://api.github.com/users/rhinogram/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinogram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinogram/subscriptions","organizations_url":"https://api.github.com/users/rhinogram/orgs","repos_url":"https://api.github.com/users/rhinogram/repos","events_url":"https://api.github.com/users/rhinogram/events{/privacy}","received_events_url":"https://api.github.com/users/rhinogram/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinogram/rhinostyle","description":"Rhinogram Style Guide","fork":false,"url":"https://api.github.com/repos/rhinogram/rhinostyle","forks_url":"https://api.github.com/repos/rhinogram/rhinostyle/forks","keys_url":"https://api.github.com/repos/rhinogram/rhinostyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinogram/rhinostyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinogram/rhinostyle/teams","hooks_url":"https://api.github.com/repos/rhinogram/rhinostyle/hooks","issue_events_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues/events{/number}","events_url":"https://api.github.com/repos/rhinogram/rhinostyle/events","assignees_url":"https://api.github.com/repos/rhinogram/rhinostyle/assignees{/user}","branches_url":"https://api.github.com/repos/rhinogram/rhinostyle/branches{/branch}","tags_url":"https://api.github.com/repos/rhinogram/rhinostyle/tags","blobs_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinogram/rhinostyle/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinogram/rhinostyle/languages","stargazers_url":"https://api.github.com/repos/rhinogram/rhinostyle/stargazers","contributors_url":"https://api.github.com/repos/rhinogram/rhinostyle/contributors","subscribers_url":"https://api.github.com/repos/rhinogram/rhinostyle/subscribers","subscription_url":"https://api.github.com/repos/rhinogram/rhinostyle/subscription","commits_url":"https://api.github.com/repos/rhinogram/rhinostyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinogram/rhinostyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinogram/rhinostyle/contents/{+path}","compare_url":"https://api.github.com/repos/rhinogram/rhinostyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinogram/rhinostyle/merges","archive_url":"https://api.github.com/repos/rhinogram/rhinostyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinogram/rhinostyle/downloads","issues_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues{/number}","pulls_url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinogram/rhinostyle/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinogram/rhinostyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinogram/rhinostyle/labels{/name}","releases_url":"https://api.github.com/repos/rhinogram/rhinostyle/releases{/id}","deployments_url":"https://api.github.com/repos/rhinogram/rhinostyle/deployments","created_at":"2016-03-30T15:16:39Z","updated_at":"2018-04-19T17:20:56Z","pushed_at":"2018-04-19T19:28:04Z","git_url":"git://github.com/rhinogram/rhinostyle.git","ssh_url":"git@github.com:rhinogram/rhinostyle.git","clone_url":"https://github.com/rhinogram/rhinostyle.git","svn_url":"https://github.com/rhinogram/rhinostyle","homepage":"https://rhinogram.github.io/rhinostyle/","size":71189,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"rhinogram:master","ref":"master","sha":"46d2ca536dee48069ce23a0122b154a3f6f5e972","user":{"login":"rhinogram","id":17254823,"avatar_url":"https://avatars0.githubusercontent.com/u/17254823?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinogram","html_url":"https://github.com/rhinogram","followers_url":"https://api.github.com/users/rhinogram/followers","following_url":"https://api.github.com/users/rhinogram/following{/other_user}","gists_url":"https://api.github.com/users/rhinogram/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinogram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinogram/subscriptions","organizations_url":"https://api.github.com/users/rhinogram/orgs","repos_url":"https://api.github.com/users/rhinogram/repos","events_url":"https://api.github.com/users/rhinogram/events{/privacy}","received_events_url":"https://api.github.com/users/rhinogram/received_events","type":"Organization","site_admin":false},"repo":{"id":55073706,"name":"rhinostyle","full_name":"rhinogram/rhinostyle","owner":{"login":"rhinogram","id":17254823,"avatar_url":"https://avatars0.githubusercontent.com/u/17254823?v=4","gravatar_id":"","url":"https://api.github.com/users/rhinogram","html_url":"https://github.com/rhinogram","followers_url":"https://api.github.com/users/rhinogram/followers","following_url":"https://api.github.com/users/rhinogram/following{/other_user}","gists_url":"https://api.github.com/users/rhinogram/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinogram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinogram/subscriptions","organizations_url":"https://api.github.com/users/rhinogram/orgs","repos_url":"https://api.github.com/users/rhinogram/repos","events_url":"https://api.github.com/users/rhinogram/events{/privacy}","received_events_url":"https://api.github.com/users/rhinogram/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinogram/rhinostyle","description":"Rhinogram Style Guide","fork":false,"url":"https://api.github.com/repos/rhinogram/rhinostyle","forks_url":"https://api.github.com/repos/rhinogram/rhinostyle/forks","keys_url":"https://api.github.com/repos/rhinogram/rhinostyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinogram/rhinostyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinogram/rhinostyle/teams","hooks_url":"https://api.github.com/repos/rhinogram/rhinostyle/hooks","issue_events_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues/events{/number}","events_url":"https://api.github.com/repos/rhinogram/rhinostyle/events","assignees_url":"https://api.github.com/repos/rhinogram/rhinostyle/assignees{/user}","branches_url":"https://api.github.com/repos/rhinogram/rhinostyle/branches{/branch}","tags_url":"https://api.github.com/repos/rhinogram/rhinostyle/tags","blobs_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinogram/rhinostyle/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinogram/rhinostyle/languages","stargazers_url":"https://api.github.com/repos/rhinogram/rhinostyle/stargazers","contributors_url":"https://api.github.com/repos/rhinogram/rhinostyle/contributors","subscribers_url":"https://api.github.com/repos/rhinogram/rhinostyle/subscribers","subscription_url":"https://api.github.com/repos/rhinogram/rhinostyle/subscription","commits_url":"https://api.github.com/repos/rhinogram/rhinostyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinogram/rhinostyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinogram/rhinostyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinogram/rhinostyle/contents/{+path}","compare_url":"https://api.github.com/repos/rhinogram/rhinostyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinogram/rhinostyle/merges","archive_url":"https://api.github.com/repos/rhinogram/rhinostyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinogram/rhinostyle/downloads","issues_url":"https://api.github.com/repos/rhinogram/rhinostyle/issues{/number}","pulls_url":"https://api.github.com/repos/rhinogram/rhinostyle/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinogram/rhinostyle/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinogram/rhinostyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinogram/rhinostyle/labels{/name}","releases_url":"https://api.github.com/repos/rhinogram/rhinostyle/releases{/id}","deployments_url":"https://api.github.com/repos/rhinogram/rhinostyle/deployments","created_at":"2016-03-30T15:16:39Z","updated_at":"2018-04-19T17:20:56Z","pushed_at":"2018-04-19T19:28:04Z","git_url":"git://github.com/rhinogram/rhinostyle.git","ssh_url":"git@github.com:rhinogram/rhinostyle.git","clone_url":"https://github.com/rhinogram/rhinostyle.git","svn_url":"https://github.com/rhinogram/rhinostyle","homepage":"https://rhinogram.github.io/rhinostyle/","size":71189,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115"},"html":{"href":"https://github.com/rhinogram/rhinostyle/pull/115"},"issue":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/issues/115"},"comments":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/rhinogram/rhinostyle/statuses/40993e8b8385d787f3bc99a0a9d46259c52fea7a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zslabs"}}