{"action":"created","issue":{"url":"https://api.github.com/repos/tawan/active-elastic-job/issues/95","repository_url":"https://api.github.com/repos/tawan/active-elastic-job","labels_url":"https://api.github.com/repos/tawan/active-elastic-job/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/tawan/active-elastic-job/issues/95/comments","events_url":"https://api.github.com/repos/tawan/active-elastic-job/issues/95/events","html_url":"https://github.com/tawan/active-elastic-job/pull/95","id":366414531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDk0MjQ3","number":95,"title":"Updating aws-sdk dependency","user":{"login":"modsaid","id":15653,"node_id":"MDQ6VXNlcjE1NjUz","avatar_url":"https://avatars0.githubusercontent.com/u/15653?v=4","gravatar_id":"","url":"https://api.github.com/users/modsaid","html_url":"https://github.com/modsaid","followers_url":"https://api.github.com/users/modsaid/followers","following_url":"https://api.github.com/users/modsaid/following{/other_user}","gists_url":"https://api.github.com/users/modsaid/gists{/gist_id}","starred_url":"https://api.github.com/users/modsaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modsaid/subscriptions","organizations_url":"https://api.github.com/users/modsaid/orgs","repos_url":"https://api.github.com/users/modsaid/repos","events_url":"https://api.github.com/users/modsaid/events{/privacy}","received_events_url":"https://api.github.com/users/modsaid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-03T16:06:35Z","updated_at":"2018-10-04T05:56:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tawan/active-elastic-job/pulls/95","html_url":"https://github.com/tawan/active-elastic-job/pull/95","diff_url":"https://github.com/tawan/active-elastic-job/pull/95.diff","patch_url":"https://github.com/tawan/active-elastic-job/pull/95.patch"},"body":"Without explicitly setting aws-sdk version. using the gem resulted in conflicts with using the aws-sdk-sqs directly (which i'm using in separate part of my project)\r\n\r\n```\r\nBundler could not find compatible versions for gem \"aws-sdk-core\":\r\n In snapshot (Gemfile.lock):\r\n    aws-sdk-core (= 3.29.0)\r\n  In Gemfile:\r\n    active_elastic_job was resolved to 2.0.1, which depends on\r\n      aws-sdk (~> 2) was resolved to 2.0.1.pre, which depends on\r\n        aws-sdk-resources (= 2.0.1.pre) was resolved to 2.0.1.pre, which depends on\r\n          aws-sdk-core (= 2.0.1)\r\n    aws-sdk-sqs was resolved to 1.7.0, which depends on\r\n      aws-sdk-core (>= 3.26.0, ~> 3)\r\nRunning `bundle update` will rebuild your snapshot from scratch, using only\r\nthe gems in your Gemfile, which may resolve the conflict.\r\n```\r\n\r\nI've managed to fix this, and deploy the whole setup in my AWS staging environment which works well now.\r\nAnother note, initially i went for FIFO queue but that needed more dependencies that wasn't supported by default, so I've have added a note in the README to make it easier for others\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tawan/active-elastic-job/issues/comments/426894364","html_url":"https://github.com/tawan/active-elastic-job/pull/95#issuecomment-426894364","issue_url":"https://api.github.com/repos/tawan/active-elastic-job/issues/95","id":426894364,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjg5NDM2NA==","user":{"login":"modsaid","id":15653,"node_id":"MDQ6VXNlcjE1NjUz","avatar_url":"https://avatars0.githubusercontent.com/u/15653?v=4","gravatar_id":"","url":"https://api.github.com/users/modsaid","html_url":"https://github.com/modsaid","followers_url":"https://api.github.com/users/modsaid/followers","following_url":"https://api.github.com/users/modsaid/following{/other_user}","gists_url":"https://api.github.com/users/modsaid/gists{/gist_id}","starred_url":"https://api.github.com/users/modsaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modsaid/subscriptions","organizations_url":"https://api.github.com/users/modsaid/orgs","repos_url":"https://api.github.com/users/modsaid/repos","events_url":"https://api.github.com/users/modsaid/events{/privacy}","received_events_url":"https://api.github.com/users/modsaid/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T05:56:57Z","updated_at":"2018-10-04T05:56:57Z","author_association":"NONE","body":"from the build failures for this pull requests and others, it seems the test environment doesn't have AWS_REGION  set.\r\n\r\ntests are confirmed to be working locally using \r\n\r\n```EXCEPT_DEPLOYED=true bundle exec rspec spec```\r\n\r\nand in the docker environment\r\n\r\n```docker build -t active-elastic-job-dev .\r\ndocker run -e EXCEPT_DEPLOYED=true -v $(pwd):/usr/src/app active-elastic-job-dev bundle exec rspec spec```\r\n\r\n\r\nnote: working with ruby 2.5.1\r\n\r\nAre we sure AWS_REGION is set properly in CI ?"}}
{"actor":{"display_login":"modsaid"}}