{"action":"closed","number":6226,"pull_request":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/6226","id":175585554,"html_url":"https://github.com/mavlink/qgroundcontrol/pull/6226","diff_url":"https://github.com/mavlink/qgroundcontrol/pull/6226.diff","patch_url":"https://github.com/mavlink/qgroundcontrol/pull/6226.patch","issue_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/6226","number":6226,"state":"closed","locked":false,"title":"Corridor Scan: Store/Load generated items from Plan file","user":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars3.githubusercontent.com/u/5876851?v=4","gravatar_id":"","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"body":"How complex items work now:\r\n* Only the meta data is stored in the plan file. The actual mission items are not.\r\n* This means that when a complex item is loaded from a plan file it must regenerate the actual mission items from the meta data.\r\n\r\nThis is a problem because:\r\n* If the algorithm for item generation changes from release to release the complex item may generate a mision which is slightly different from when it was created.\r\n* If the complex item contains terrain references then it would need internet access to re-generate the mission items. This would not work if you are trying to load a plan onto a vehicle at the field with no internet access.\r\n\r\nThe solution:\r\n* Store the generated mission data in the plan file as well as the meta data.\r\n* When you load a plan with a complex item, the complex items use the stored items instead of re-generating.\r\n* If you dirty the complex item in any way, the stored mission items are tossed and it reverts back to generating the items onthe fly.\r\n* The other benefit is that non-QGC ground stations can load plan files with complex items and use the stored items to populate a mission.\r\n\r\nCurrently this mechanism is only support by Corridor Scan. It will enventually flow to all complex items.","created_at":"2018-03-16T16:36:12Z","updated_at":"2018-03-16T17:46:48Z","closed_at":"2018-03-16T17:46:48Z","merged_at":"2018-03-16T17:46:48Z","merge_commit_sha":"c7f4ac3d6f8c6cccdf7f770ab49573de97bb1638","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/6226/commits","review_comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/6226/comments","review_comment_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/6226/comments","statuses_url":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/ee5736e14ef5a66aaf2b920c59e34f6af2d67eb9","head":{"label":"DonLakeFlyer:GeneratedItems","ref":"GeneratedItems","sha":"ee5736e14ef5a66aaf2b920c59e34f6af2d67eb9","user":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars3.githubusercontent.com/u/5876851?v=4","gravatar_id":"","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"repo":{"id":43383049,"name":"qgroundcontrol","full_name":"DonLakeFlyer/qgroundcontrol","owner":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars3.githubusercontent.com/u/5876851?v=4","gravatar_id":"","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DonLakeFlyer/qgroundcontrol","description":"QGroundControl Ground Control Station","fork":true,"url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol","forks_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/forks","keys_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/teams","hooks_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/hooks","issue_events_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/events","assignees_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/tags","blobs_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/languages","stargazers_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/stargazers","contributors_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/contributors","subscribers_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/subscribers","subscription_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/subscription","commits_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/merges","archive_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/downloads","issues_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/DonLakeFlyer/qgroundcontrol/deployments","created_at":"2015-09-29T17:29:53Z","updated_at":"2018-03-14T20:09:53Z","pushed_at":"2018-03-16T17:44:40Z","git_url":"git://github.com/DonLakeFlyer/qgroundcontrol.git","ssh_url":"git@github.com:DonLakeFlyer/qgroundcontrol.git","clone_url":"https://github.com/DonLakeFlyer/qgroundcontrol.git","svn_url":"https://github.com/DonLakeFlyer/qgroundcontrol","homepage":"http://qgroundcontrol.org","size":201196,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mavlink:master","ref":"master","sha":"2676fe2c07f1587d5ce6bbfae50112a15325bd49","user":{"login":"mavlink","id":961247,"avatar_url":"https://avatars2.githubusercontent.com/u/961247?v=4","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"repo":{"id":2567844,"name":"qgroundcontrol","full_name":"mavlink/qgroundcontrol","owner":{"login":"mavlink","id":961247,"avatar_url":"https://avatars2.githubusercontent.com/u/961247?v=4","gravatar_id":"","url":"https://api.github.com/users/mavlink","html_url":"https://github.com/mavlink","followers_url":"https://api.github.com/users/mavlink/followers","following_url":"https://api.github.com/users/mavlink/following{/other_user}","gists_url":"https://api.github.com/users/mavlink/gists{/gist_id}","starred_url":"https://api.github.com/users/mavlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavlink/subscriptions","organizations_url":"https://api.github.com/users/mavlink/orgs","repos_url":"https://api.github.com/users/mavlink/repos","events_url":"https://api.github.com/users/mavlink/events{/privacy}","received_events_url":"https://api.github.com/users/mavlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mavlink/qgroundcontrol","description":"Dronecode cross-platform ground control station for drones (Android, iOS, Mac OS, Linux, Windows)","fork":false,"url":"https://api.github.com/repos/mavlink/qgroundcontrol","forks_url":"https://api.github.com/repos/mavlink/qgroundcontrol/forks","keys_url":"https://api.github.com/repos/mavlink/qgroundcontrol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mavlink/qgroundcontrol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mavlink/qgroundcontrol/teams","hooks_url":"https://api.github.com/repos/mavlink/qgroundcontrol/hooks","issue_events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/events{/number}","events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/events","assignees_url":"https://api.github.com/repos/mavlink/qgroundcontrol/assignees{/user}","branches_url":"https://api.github.com/repos/mavlink/qgroundcontrol/branches{/branch}","tags_url":"https://api.github.com/repos/mavlink/qgroundcontrol/tags","blobs_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/refs{/sha}","trees_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/{sha}","languages_url":"https://api.github.com/repos/mavlink/qgroundcontrol/languages","stargazers_url":"https://api.github.com/repos/mavlink/qgroundcontrol/stargazers","contributors_url":"https://api.github.com/repos/mavlink/qgroundcontrol/contributors","subscribers_url":"https://api.github.com/repos/mavlink/qgroundcontrol/subscribers","subscription_url":"https://api.github.com/repos/mavlink/qgroundcontrol/subscription","commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/commits{/sha}","git_commits_url":"https://api.github.com/repos/mavlink/qgroundcontrol/git/commits{/sha}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/comments{/number}","issue_comment_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/comments{/number}","contents_url":"https://api.github.com/repos/mavlink/qgroundcontrol/contents/{+path}","compare_url":"https://api.github.com/repos/mavlink/qgroundcontrol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mavlink/qgroundcontrol/merges","archive_url":"https://api.github.com/repos/mavlink/qgroundcontrol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mavlink/qgroundcontrol/downloads","issues_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues{/number}","pulls_url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls{/number}","milestones_url":"https://api.github.com/repos/mavlink/qgroundcontrol/milestones{/number}","notifications_url":"https://api.github.com/repos/mavlink/qgroundcontrol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mavlink/qgroundcontrol/labels{/name}","releases_url":"https://api.github.com/repos/mavlink/qgroundcontrol/releases{/id}","deployments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/deployments","created_at":"2011-10-13T07:31:07Z","updated_at":"2018-03-15T23:48:50Z","pushed_at":"2018-03-16T17:46:48Z","git_url":"git://github.com/mavlink/qgroundcontrol.git","ssh_url":"git@github.com:mavlink/qgroundcontrol.git","clone_url":"https://github.com/mavlink/qgroundcontrol.git","svn_url":"https://github.com/mavlink/qgroundcontrol","homepage":"http://qgroundcontrol.io","size":212801,"stargazers_count":759,"watchers_count":759,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1067,"mirror_url":null,"archived":false,"open_issues_count":568,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1067,"open_issues":568,"watchers":759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/6226"},"html":{"href":"https://github.com/mavlink/qgroundcontrol/pull/6226"},"issue":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/6226"},"comments":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/6226/comments"},"review_comments":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/6226/comments"},"review_comment":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/6226/commits"},"statuses":{"href":"https://api.github.com/repos/mavlink/qgroundcontrol/statuses/ee5736e14ef5a66aaf2b920c59e34f6af2d67eb9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DonLakeFlyer","id":5876851,"avatar_url":"https://avatars3.githubusercontent.com/u/5876851?v=4","gravatar_id":"","url":"https://api.github.com/users/DonLakeFlyer","html_url":"https://github.com/DonLakeFlyer","followers_url":"https://api.github.com/users/DonLakeFlyer/followers","following_url":"https://api.github.com/users/DonLakeFlyer/following{/other_user}","gists_url":"https://api.github.com/users/DonLakeFlyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DonLakeFlyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonLakeFlyer/subscriptions","organizations_url":"https://api.github.com/users/DonLakeFlyer/orgs","repos_url":"https://api.github.com/users/DonLakeFlyer/repos","events_url":"https://api.github.com/users/DonLakeFlyer/events{/privacy}","received_events_url":"https://api.github.com/users/DonLakeFlyer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":194,"deletions":60,"changed_files":6}}
{"actor":{"display_login":"DonLakeFlyer"}}