{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments/241745434","pull_request_review_id":185096342,"id":241745434,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTc0NTQzNA==","diff_hunk":"@@ -616,6 +627,12 @@ declare module 'sourcegraph' {\n          * @returns The panel view.\n          */\n         export function createPanelView(id: string): PanelView\n+\n+        /**\n+         * Creates a decorationType that can be used to add decorations to code views","path":"packages/sourcegraph-extension-api/src/sourcegraph.d.ts","position":null,"original_position":41,"commit_id":"0aafb26c79e9c7f0eb3a3189d1cfa9509759cd74","original_commit_id":"36ede609947f884c1b39b1ee0facedfab298145c","user":{"login":"lguychard","id":1741180,"node_id":"MDQ6VXNlcjE3NDExODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1741180?v=4","gravatar_id":"","url":"https://api.github.com/users/lguychard","html_url":"https://github.com/lguychard","followers_url":"https://api.github.com/users/lguychard/followers","following_url":"https://api.github.com/users/lguychard/following{/other_user}","gists_url":"https://api.github.com/users/lguychard/gists{/gist_id}","starred_url":"https://api.github.com/users/lguychard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguychard/subscriptions","organizations_url":"https://api.github.com/users/lguychard/orgs","repos_url":"https://api.github.com/users/lguychard/repos","events_url":"https://api.github.com/users/lguychard/events{/privacy}","received_events_url":"https://api.github.com/users/lguychard/received_events","type":"User","site_admin":false},"body":"Improved in 8ceca88","created_at":"2018-12-14T12:54:35Z","updated_at":"2018-12-14T12:54:35Z","html_url":"https://github.com/sourcegraph/sourcegraph/pull/1393#discussion_r241745434","pull_request_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments/241745434"},"html":{"href":"https://github.com/sourcegraph/sourcegraph/pull/1393#discussion_r241745434"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393"}},"in_reply_to_id":241661234},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393","id":238477816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDc3ODE2","html_url":"https://github.com/sourcegraph/sourcegraph/pull/1393","diff_url":"https://github.com/sourcegraph/sourcegraph/pull/1393.diff","patch_url":"https://github.com/sourcegraph/sourcegraph/pull/1393.patch","issue_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/1393","number":1393,"state":"open","locked":false,"title":"Add TextDocumentDecorationType, use it to merge decorations from several sources","user":{"login":"lguychard","id":1741180,"node_id":"MDQ6VXNlcjE3NDExODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1741180?v=4","gravatar_id":"","url":"https://api.github.com/users/lguychard","html_url":"https://github.com/lguychard","followers_url":"https://api.github.com/users/lguychard/followers","following_url":"https://api.github.com/users/lguychard/following{/other_user}","gists_url":"https://api.github.com/users/lguychard/gists{/gist_id}","starred_url":"https://api.github.com/users/lguychard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguychard/subscriptions","organizations_url":"https://api.github.com/users/lguychard/orgs","repos_url":"https://api.github.com/users/lguychard/repos","events_url":"https://api.github.com/users/lguychard/events{/privacy}","received_events_url":"https://api.github.com/users/lguychard/received_events","type":"User","site_admin":false},"body":"This introduces a breaking change to the extension api: the first argument to `setDecorations()` must now be of type `TextDocumentDeclarationType` instead of `null`\r\n\r\nThis allows us to merge declarations of several types, fixing #1339 \r\n\r\nThis is inspired by [vscode's API](https://sourcegraph.com/github.com/Microsoft/vscode/-/blob/src/vs/vscode.d.ts#L1144), with two notable differences:\r\n- In vscode, the DecorationType stores the style information for a set of declarations, but this styling can still be overridden by the second argument to `setDecorations()`. I did not go down this route as it would have amounted to a much bigger change without immediate benefits for #1339 \r\n- In vscode, the DecorationType has a [`dispose()` method](https://sourcegraph.com/github.com/Microsoft/vscode/-/blob/src/vs/vscode.d.ts#690), that can be used to remove all decorations for the given type on all text editors. This is actually something I plan on implementing in a subsequent PR, as it would be really helpful to cleanup decorations when an extension gets deactivated.\r\n\r\nTODO:\r\n\r\n- [ ] Edit CHANGELOG","created_at":"2018-12-13T17:49:31Z","updated_at":"2018-12-14T12:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea34d7302e92be66d6beb6d11d0a4824a392c9ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/1393/comments","statuses_url":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/0aafb26c79e9c7f0eb3a3189d1cfa9509759cd74","head":{"label":"sourcegraph:feature/decoration-type","ref":"feature/decoration-type","sha":"0aafb26c79e9c7f0eb3a3189d1cfa9509759cd74","user":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":41288708,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI4ODcwOA==","name":"sourcegraph","full_name":"sourcegraph/sourcegraph","private":false,"owner":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sourcegraph/sourcegraph","description":"Code search and intelligence, self-hosted and scalable","fork":false,"url":"https://api.github.com/repos/sourcegraph/sourcegraph","forks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/forks","keys_url":"https://api.github.com/repos/sourcegraph/sourcegraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/sourcegraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/sourcegraph/teams","hooks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/events","assignees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/sourcegraph/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/tags","blobs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/sourcegraph/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscription","commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/sourcegraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/sourcegraph/merges","archive_url":"https://api.github.com/repos/sourcegraph/sourcegraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/sourcegraph/downloads","issues_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/sourcegraph/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/sourcegraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/sourcegraph/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/sourcegraph/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/deployments","created_at":"2015-08-24T07:27:28Z","updated_at":"2018-12-14T11:56:47Z","pushed_at":"2018-12-14T12:54:11Z","git_url":"git://github.com/sourcegraph/sourcegraph.git","ssh_url":"git@github.com:sourcegraph/sourcegraph.git","clone_url":"https://github.com/sourcegraph/sourcegraph.git","svn_url":"https://github.com/sourcegraph/sourcegraph","homepage":"https://sourcegraph.com","size":47347,"stargazers_count":948,"watchers_count":948,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":441,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":441,"watchers":948,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"12f1e90dacc8c48eef1a32fd958294ee4ddd043f","user":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":41288708,"node_id":"MDEwOlJlcG9zaXRvcnk0MTI4ODcwOA==","name":"sourcegraph","full_name":"sourcegraph/sourcegraph","private":false,"owner":{"login":"sourcegraph","id":3979584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzk1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3979584?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sourcegraph/sourcegraph","description":"Code search and intelligence, self-hosted and scalable","fork":false,"url":"https://api.github.com/repos/sourcegraph/sourcegraph","forks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/forks","keys_url":"https://api.github.com/repos/sourcegraph/sourcegraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/sourcegraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/sourcegraph/teams","hooks_url":"https://api.github.com/repos/sourcegraph/sourcegraph/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/sourcegraph/events","assignees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/sourcegraph/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/tags","blobs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/sourcegraph/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/sourcegraph/subscription","commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/sourcegraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/sourcegraph/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/sourcegraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/sourcegraph/merges","archive_url":"https://api.github.com/repos/sourcegraph/sourcegraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/sourcegraph/downloads","issues_url":"https://api.github.com/repos/sourcegraph/sourcegraph/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/sourcegraph/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/sourcegraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/sourcegraph/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/sourcegraph/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/sourcegraph/deployments","created_at":"2015-08-24T07:27:28Z","updated_at":"2018-12-14T11:56:47Z","pushed_at":"2018-12-14T12:54:11Z","git_url":"git://github.com/sourcegraph/sourcegraph.git","ssh_url":"git@github.com:sourcegraph/sourcegraph.git","clone_url":"https://github.com/sourcegraph/sourcegraph.git","svn_url":"https://github.com/sourcegraph/sourcegraph","homepage":"https://sourcegraph.com","size":47347,"stargazers_count":948,"watchers_count":948,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":441,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":441,"watchers":948,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393"},"html":{"href":"https://github.com/sourcegraph/sourcegraph/pull/1393"},"issue":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/1393"},"comments":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/issues/1393/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/pulls/1393/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/sourcegraph/statuses/0aafb26c79e9c7f0eb3a3189d1cfa9509759cd74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lguychard"}}