{"action":"created","comment":{"url":"https://api.github.com/repos/m-labs/misoc/pulls/comments/184906257","pull_request_review_id":116189760,"id":184906257,"diff_hunk":"@@ -0,0 +1,77 @@\n+.global main\n+.global isr\n+.global _start\n+\n+_start:\n+crtStart:\n+  j crtInit\n+  nop\n+  nop\n+  nop\n+  nop\n+  nop\n+  nop\n+  nop\n+\n+.global  trap_entry\n+trap_entry:\n+  sw x1,  - 1*4(sp)\n+  sw x5,  - 2*4(sp)\n+  sw x6,  - 3*4(sp)\n+  sw x7,  - 4*4(sp)\n+  sw x10, - 5*4(sp)\n+  sw x11, - 6*4(sp)\n+  sw x12, - 7*4(sp)\n+  sw x13, - 8*4(sp)\n+  sw x14, - 9*4(sp)\n+  sw x15, -10*4(sp)\n+  sw x16, -11*4(sp)\n+  sw x17, -12*4(sp)\n+  sw x28, -13*4(sp)\n+  sw x29, -14*4(sp)\n+  sw x30, -15*4(sp)\n+  sw x31, -16*4(sp)\n+  addi sp,sp,-16*4\n+  call isr\n+  lw x1 , 15*4(sp)\n+  lw x5,  14*4(sp)\n+  lw x6,  13*4(sp)\n+  lw x7,  12*4(sp)\n+  lw x10, 11*4(sp)\n+  lw x11, 10*4(sp)\n+  lw x12,  9*4(sp)\n+  lw x13,  8*4(sp)\n+  lw x14,  7*4(sp)\n+  lw x15,  6*4(sp)\n+  lw x16,  5*4(sp)\n+  lw x17,  4*4(sp)\n+  lw x28,  3*4(sp)\n+  lw x29,  2*4(sp)\n+  lw x30,  1*4(sp)\n+  lw x31,  0*4(sp)\n+  addi sp,sp,16*4\n+  mret\n+  .text\n+\n+\n+crtInit:\n+  la sp, _fstack + 4\n+  la a0, trap_entry\n+  csrw mtvec, a0\n+\n+bss_init:\n+  la a0, _fbss\n+  la a1, _ebss\n+bss_loop:\n+  beq a0,a1,bss_done\n+  sw zero,0(a0)\n+  add a0,a0,4\n+  j bss_loop\n+bss_done:\n+\n+  li a0, 0x880  //880 enable timer + external interrupt sources (until mstatus.MIE is set, they will never trigger an interrupt)\n+  csrw mie,a0\n+\n+  call main\n+infinitLoop:","path":"misoc/software/libbase/crt0-vexriscv.S","position":76,"original_position":76,"commit_id":"c10bfb8f20947c6765f20eb56295d21f6d2a6765","original_commit_id":"c10bfb8f20947c6765f20eb56295d21f6d2a6765","user":{"login":"sbourdeauducq","id":720864,"avatar_url":"https://avatars2.githubusercontent.com/u/720864?v=4","gravatar_id":"","url":"https://api.github.com/users/sbourdeauducq","html_url":"https://github.com/sbourdeauducq","followers_url":"https://api.github.com/users/sbourdeauducq/followers","following_url":"https://api.github.com/users/sbourdeauducq/following{/other_user}","gists_url":"https://api.github.com/users/sbourdeauducq/gists{/gist_id}","starred_url":"https://api.github.com/users/sbourdeauducq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbourdeauducq/subscriptions","organizations_url":"https://api.github.com/users/sbourdeauducq/orgs","repos_url":"https://api.github.com/users/sbourdeauducq/repos","events_url":"https://api.github.com/users/sbourdeauducq/events{/privacy}","received_events_url":"https://api.github.com/users/sbourdeauducq/received_events","type":"User","site_admin":false},"body":"Can we avoid javaNames here as well?","created_at":"2018-04-30T02:52:17Z","updated_at":"2018-04-30T02:56:53Z","html_url":"https://github.com/m-labs/misoc/pull/78#discussion_r184906257","pull_request_url":"https://api.github.com/repos/m-labs/misoc/pulls/78","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/m-labs/misoc/pulls/comments/184906257"},"html":{"href":"https://github.com/m-labs/misoc/pull/78#discussion_r184906257"},"pull_request":{"href":"https://api.github.com/repos/m-labs/misoc/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/m-labs/misoc/pulls/78","id":183510184,"html_url":"https://github.com/m-labs/misoc/pull/78","diff_url":"https://github.com/m-labs/misoc/pull/78.diff","patch_url":"https://github.com/m-labs/misoc/pull/78.patch","issue_url":"https://api.github.com/repos/m-labs/misoc/issues/78","number":78,"state":"open","locked":false,"title":"VexRiscv integration","user":{"login":"Dolu1990","id":4832082,"avatar_url":"https://avatars0.githubusercontent.com/u/4832082?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolu1990","html_url":"https://github.com/Dolu1990","followers_url":"https://api.github.com/users/Dolu1990/followers","following_url":"https://api.github.com/users/Dolu1990/following{/other_user}","gists_url":"https://api.github.com/users/Dolu1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolu1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolu1990/subscriptions","organizations_url":"https://api.github.com/users/Dolu1990/orgs","repos_url":"https://api.github.com/users/Dolu1990/repos","events_url":"https://api.github.com/users/Dolu1990/events{/privacy}","received_events_url":"https://api.github.com/users/Dolu1990/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThere the VexRiscv integration, it was tested with the simple.py target with iverilog and on the DE1-SoC.\r\nEverything look fine (bios + serial).\r\n\r\nJust notice that the reset vector of the CPU is fixed in the https://github.com/m-labs/VexRiscv-verilog project.\r\n\r\nThere is the GCC installation commands (from https://github.com/SpinalHDL/VexRiscv#build-the-risc-v-gcc) : \r\n\r\n```sh\r\nwget https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-20171231-x86_64-linux-centos6.tar.gz\r\ntar -xzvf riscv64-unknown-elf-gcc-20171231-x86_64-linux-centos6.tar.gz\r\nriscv64-unknown-elf-gcc-20171231-x86_64-linux-centos6.tar.gz\r\nsudo mv riscv64-unknown-elf-gcc-20171231-x86_64-linux-centos6 /opt/riscv64-unknown-elf-gcc-20171231-x86_64-linux-centos6\r\nsudo mv /opt/riscv64-unknown-elf-gcc-20171231-x86_64-linux-centos6 /opt/riscv\r\necho 'export PATH=/opt/riscv/bin:$PATH' >> ~/.bashrc \r\n```\r\n\r\nOn the DE1-SoC, the synthesis  tool can go up to 133 Mhz. So with an Artix7, it should be capable to go at 200+ Mhz. If it doesn't, It is likely that some pipelining need to be added on the instruction/data bus. It is simple to do, and would not add noticable performance penality. Let's me know if it appear to be required in larger SoC.\r\n\r\nRegards\r\nCharles","created_at":"2018-04-23T17:51:46Z","updated_at":"2018-04-30T02:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"648354e99569896c65e992aa13f4d9675c20945b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m-labs/misoc/pulls/78/commits","review_comments_url":"https://api.github.com/repos/m-labs/misoc/pulls/78/comments","review_comment_url":"https://api.github.com/repos/m-labs/misoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m-labs/misoc/issues/78/comments","statuses_url":"https://api.github.com/repos/m-labs/misoc/statuses/c10bfb8f20947c6765f20eb56295d21f6d2a6765","head":{"label":"Dolu1990:master","ref":"master","sha":"c10bfb8f20947c6765f20eb56295d21f6d2a6765","user":{"login":"Dolu1990","id":4832082,"avatar_url":"https://avatars0.githubusercontent.com/u/4832082?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolu1990","html_url":"https://github.com/Dolu1990","followers_url":"https://api.github.com/users/Dolu1990/followers","following_url":"https://api.github.com/users/Dolu1990/following{/other_user}","gists_url":"https://api.github.com/users/Dolu1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolu1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolu1990/subscriptions","organizations_url":"https://api.github.com/users/Dolu1990/orgs","repos_url":"https://api.github.com/users/Dolu1990/repos","events_url":"https://api.github.com/users/Dolu1990/events{/privacy}","received_events_url":"https://api.github.com/users/Dolu1990/received_events","type":"User","site_admin":false},"repo":{"id":130732790,"name":"misoc","full_name":"Dolu1990/misoc","owner":{"login":"Dolu1990","id":4832082,"avatar_url":"https://avatars0.githubusercontent.com/u/4832082?v=4","gravatar_id":"","url":"https://api.github.com/users/Dolu1990","html_url":"https://github.com/Dolu1990","followers_url":"https://api.github.com/users/Dolu1990/followers","following_url":"https://api.github.com/users/Dolu1990/following{/other_user}","gists_url":"https://api.github.com/users/Dolu1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Dolu1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dolu1990/subscriptions","organizations_url":"https://api.github.com/users/Dolu1990/orgs","repos_url":"https://api.github.com/users/Dolu1990/repos","events_url":"https://api.github.com/users/Dolu1990/events{/privacy}","received_events_url":"https://api.github.com/users/Dolu1990/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dolu1990/misoc","description":"A high performance and small footprint system-on-chip based on Migen","fork":true,"url":"https://api.github.com/repos/Dolu1990/misoc","forks_url":"https://api.github.com/repos/Dolu1990/misoc/forks","keys_url":"https://api.github.com/repos/Dolu1990/misoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dolu1990/misoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dolu1990/misoc/teams","hooks_url":"https://api.github.com/repos/Dolu1990/misoc/hooks","issue_events_url":"https://api.github.com/repos/Dolu1990/misoc/issues/events{/number}","events_url":"https://api.github.com/repos/Dolu1990/misoc/events","assignees_url":"https://api.github.com/repos/Dolu1990/misoc/assignees{/user}","branches_url":"https://api.github.com/repos/Dolu1990/misoc/branches{/branch}","tags_url":"https://api.github.com/repos/Dolu1990/misoc/tags","blobs_url":"https://api.github.com/repos/Dolu1990/misoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dolu1990/misoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dolu1990/misoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dolu1990/misoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dolu1990/misoc/statuses/{sha}","languages_url":"https://api.github.com/repos/Dolu1990/misoc/languages","stargazers_url":"https://api.github.com/repos/Dolu1990/misoc/stargazers","contributors_url":"https://api.github.com/repos/Dolu1990/misoc/contributors","subscribers_url":"https://api.github.com/repos/Dolu1990/misoc/subscribers","subscription_url":"https://api.github.com/repos/Dolu1990/misoc/subscription","commits_url":"https://api.github.com/repos/Dolu1990/misoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dolu1990/misoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dolu1990/misoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dolu1990/misoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dolu1990/misoc/contents/{+path}","compare_url":"https://api.github.com/repos/Dolu1990/misoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dolu1990/misoc/merges","archive_url":"https://api.github.com/repos/Dolu1990/misoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dolu1990/misoc/downloads","issues_url":"https://api.github.com/repos/Dolu1990/misoc/issues{/number}","pulls_url":"https://api.github.com/repos/Dolu1990/misoc/pulls{/number}","milestones_url":"https://api.github.com/repos/Dolu1990/misoc/milestones{/number}","notifications_url":"https://api.github.com/repos/Dolu1990/misoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dolu1990/misoc/labels{/name}","releases_url":"https://api.github.com/repos/Dolu1990/misoc/releases{/id}","deployments_url":"https://api.github.com/repos/Dolu1990/misoc/deployments","created_at":"2018-04-23T17:30:47Z","updated_at":"2018-04-25T02:12:11Z","pushed_at":"2018-04-25T02:12:08Z","git_url":"git://github.com/Dolu1990/misoc.git","ssh_url":"git@github.com:Dolu1990/misoc.git","clone_url":"https://github.com/Dolu1990/misoc.git","svn_url":"https://github.com/Dolu1990/misoc","homepage":"https://m-labs.hk","size":4683,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"m-labs:master","ref":"master","sha":"3fb4a55a52d4f343661372e85c386adf76b66a54","user":{"login":"m-labs","id":116047,"avatar_url":"https://avatars3.githubusercontent.com/u/116047?v=4","gravatar_id":"","url":"https://api.github.com/users/m-labs","html_url":"https://github.com/m-labs","followers_url":"https://api.github.com/users/m-labs/followers","following_url":"https://api.github.com/users/m-labs/following{/other_user}","gists_url":"https://api.github.com/users/m-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-labs/subscriptions","organizations_url":"https://api.github.com/users/m-labs/orgs","repos_url":"https://api.github.com/users/m-labs/repos","events_url":"https://api.github.com/users/m-labs/events{/privacy}","received_events_url":"https://api.github.com/users/m-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":2960310,"name":"misoc","full_name":"m-labs/misoc","owner":{"login":"m-labs","id":116047,"avatar_url":"https://avatars3.githubusercontent.com/u/116047?v=4","gravatar_id":"","url":"https://api.github.com/users/m-labs","html_url":"https://github.com/m-labs","followers_url":"https://api.github.com/users/m-labs/followers","following_url":"https://api.github.com/users/m-labs/following{/other_user}","gists_url":"https://api.github.com/users/m-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/m-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-labs/subscriptions","organizations_url":"https://api.github.com/users/m-labs/orgs","repos_url":"https://api.github.com/users/m-labs/repos","events_url":"https://api.github.com/users/m-labs/events{/privacy}","received_events_url":"https://api.github.com/users/m-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m-labs/misoc","description":"A high performance and small footprint system-on-chip based on Migen","fork":false,"url":"https://api.github.com/repos/m-labs/misoc","forks_url":"https://api.github.com/repos/m-labs/misoc/forks","keys_url":"https://api.github.com/repos/m-labs/misoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-labs/misoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-labs/misoc/teams","hooks_url":"https://api.github.com/repos/m-labs/misoc/hooks","issue_events_url":"https://api.github.com/repos/m-labs/misoc/issues/events{/number}","events_url":"https://api.github.com/repos/m-labs/misoc/events","assignees_url":"https://api.github.com/repos/m-labs/misoc/assignees{/user}","branches_url":"https://api.github.com/repos/m-labs/misoc/branches{/branch}","tags_url":"https://api.github.com/repos/m-labs/misoc/tags","blobs_url":"https://api.github.com/repos/m-labs/misoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-labs/misoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-labs/misoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-labs/misoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-labs/misoc/statuses/{sha}","languages_url":"https://api.github.com/repos/m-labs/misoc/languages","stargazers_url":"https://api.github.com/repos/m-labs/misoc/stargazers","contributors_url":"https://api.github.com/repos/m-labs/misoc/contributors","subscribers_url":"https://api.github.com/repos/m-labs/misoc/subscribers","subscription_url":"https://api.github.com/repos/m-labs/misoc/subscription","commits_url":"https://api.github.com/repos/m-labs/misoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-labs/misoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-labs/misoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-labs/misoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-labs/misoc/contents/{+path}","compare_url":"https://api.github.com/repos/m-labs/misoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-labs/misoc/merges","archive_url":"https://api.github.com/repos/m-labs/misoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-labs/misoc/downloads","issues_url":"https://api.github.com/repos/m-labs/misoc/issues{/number}","pulls_url":"https://api.github.com/repos/m-labs/misoc/pulls{/number}","milestones_url":"https://api.github.com/repos/m-labs/misoc/milestones{/number}","notifications_url":"https://api.github.com/repos/m-labs/misoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-labs/misoc/labels{/name}","releases_url":"https://api.github.com/repos/m-labs/misoc/releases{/id}","deployments_url":"https://api.github.com/repos/m-labs/misoc/deployments","created_at":"2011-12-11T21:50:08Z","updated_at":"2018-04-28T13:17:20Z","pushed_at":"2018-04-25T02:12:10Z","git_url":"git://github.com/m-labs/misoc.git","ssh_url":"git@github.com:m-labs/misoc.git","clone_url":"https://github.com/m-labs/misoc.git","svn_url":"https://github.com/m-labs/misoc","homepage":"https://m-labs.hk","size":4660,"stargazers_count":135,"watchers_count":135,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":40,"open_issues":23,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m-labs/misoc/pulls/78"},"html":{"href":"https://github.com/m-labs/misoc/pull/78"},"issue":{"href":"https://api.github.com/repos/m-labs/misoc/issues/78"},"comments":{"href":"https://api.github.com/repos/m-labs/misoc/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/m-labs/misoc/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/m-labs/misoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m-labs/misoc/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/m-labs/misoc/statuses/c10bfb8f20947c6765f20eb56295d21f6d2a6765"}},"author_association":"NONE"}}
{"actor":{"display_login":"sbourdeauducq"}}