{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/209421292","pull_request_review_id":145441146,"id":209421292,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQyMTI5Mg==","diff_hunk":"@@ -231,6 +231,15 @@ object TypeCoercion {\n       })\n   }\n \n+  /**\n+   * Similar to [[findTightestCommonType]] but with string promotion.\n+   */\n+  def findWiderTypeForTwoExceptDecimals(t1: DataType, t2: DataType): Option[DataType] = {","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala","position":7,"original_position":7,"commit_id":"595161fefbf55711b76530a9e53aff73491febd6","original_commit_id":"595161fefbf55711b76530a9e53aff73491febd6","user":{"login":"ueshin","id":506656,"node_id":"MDQ6VXNlcjUwNjY1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/506656?v=4","gravatar_id":"","url":"https://api.github.com/users/ueshin","html_url":"https://github.com/ueshin","followers_url":"https://api.github.com/users/ueshin/followers","following_url":"https://api.github.com/users/ueshin/following{/other_user}","gists_url":"https://api.github.com/users/ueshin/gists{/gist_id}","starred_url":"https://api.github.com/users/ueshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ueshin/subscriptions","organizations_url":"https://api.github.com/users/ueshin/orgs","repos_url":"https://api.github.com/users/ueshin/repos","events_url":"https://api.github.com/users/ueshin/events{/privacy}","received_events_url":"https://api.github.com/users/ueshin/received_events","type":"User","site_admin":false},"body":"On second thoughts, do we really need those? Seems like the current coercions rules don't contain possibly cast to null?","created_at":"2018-08-11T08:53:47Z","updated_at":"2018-08-11T08:53:47Z","html_url":"https://github.com/apache/spark/pull/22017#discussion_r209421292","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/22017","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/209421292"},"html":{"href":"https://github.com/apache/spark/pull/22017#discussion_r209421292"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/22017"}},"in_reply_to_id":209308055},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22017","id":206545189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTQ1MTg5","html_url":"https://github.com/apache/spark/pull/22017","diff_url":"https://github.com/apache/spark/pull/22017.diff","patch_url":"https://github.com/apache/spark/pull/22017.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/22017","number":22017,"state":"open","locked":false,"title":"[SPARK-23938][SQL] Add map_zip_with function","user":{"login":"mn-mikke","id":3674621,"node_id":"MDQ6VXNlcjM2NzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR adds a new SQL function called ```map_zip_with```. It merges the two given maps into a single map by applying function to the pair of values with the same key. \r\n\r\n## How was this patch tested?\r\n\r\nAdded new tests into:\r\n- DataFrameFunctionsSuite.scala\r\n- HigherOrderFunctionsSuite.scala\r\n","created_at":"2018-08-06T23:50:20Z","updated_at":"2018-08-11T08:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19d9a93d1bc8e79184e67daeae52822e36786e40","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/22017/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/22017/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/22017/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/595161fefbf55711b76530a9e53aff73491febd6","head":{"label":"mn-mikke:SPARK-23938","ref":"SPARK-23938","sha":"595161fefbf55711b76530a9e53aff73491febd6","user":{"login":"mn-mikke","id":3674621,"node_id":"MDQ6VXNlcjM2NzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"repo":{"id":116154315,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNTQzMTU=","name":"spark","full_name":"mn-mikke/spark","owner":{"login":"mn-mikke","id":3674621,"node_id":"MDQ6VXNlcjM2NzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mn-mikke/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/mn-mikke/spark","forks_url":"https://api.github.com/repos/mn-mikke/spark/forks","keys_url":"https://api.github.com/repos/mn-mikke/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mn-mikke/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mn-mikke/spark/teams","hooks_url":"https://api.github.com/repos/mn-mikke/spark/hooks","issue_events_url":"https://api.github.com/repos/mn-mikke/spark/issues/events{/number}","events_url":"https://api.github.com/repos/mn-mikke/spark/events","assignees_url":"https://api.github.com/repos/mn-mikke/spark/assignees{/user}","branches_url":"https://api.github.com/repos/mn-mikke/spark/branches{/branch}","tags_url":"https://api.github.com/repos/mn-mikke/spark/tags","blobs_url":"https://api.github.com/repos/mn-mikke/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mn-mikke/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mn-mikke/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/mn-mikke/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mn-mikke/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/mn-mikke/spark/languages","stargazers_url":"https://api.github.com/repos/mn-mikke/spark/stargazers","contributors_url":"https://api.github.com/repos/mn-mikke/spark/contributors","subscribers_url":"https://api.github.com/repos/mn-mikke/spark/subscribers","subscription_url":"https://api.github.com/repos/mn-mikke/spark/subscription","commits_url":"https://api.github.com/repos/mn-mikke/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/mn-mikke/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/mn-mikke/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/mn-mikke/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/mn-mikke/spark/contents/{+path}","compare_url":"https://api.github.com/repos/mn-mikke/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mn-mikke/spark/merges","archive_url":"https://api.github.com/repos/mn-mikke/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mn-mikke/spark/downloads","issues_url":"https://api.github.com/repos/mn-mikke/spark/issues{/number}","pulls_url":"https://api.github.com/repos/mn-mikke/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/mn-mikke/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/mn-mikke/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mn-mikke/spark/labels{/name}","releases_url":"https://api.github.com/repos/mn-mikke/spark/releases{/id}","deployments_url":"https://api.github.com/repos/mn-mikke/spark/deployments","created_at":"2018-01-03T15:48:07Z","updated_at":"2018-04-21T15:37:46Z","pushed_at":"2018-08-10T15:55:06Z","git_url":"git://github.com/mn-mikke/spark.git","ssh_url":"git@github.com:mn-mikke/spark.git","clone_url":"https://github.com/mn-mikke/spark.git","svn_url":"https://github.com/mn-mikke/spark","homepage":null,"size":278623,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8c13cb2ae4f82c0eb04939a667310b9268b1c2a7","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-11T02:02:58Z","pushed_at":"2018-08-11T08:39:49Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":279266,"stargazers_count":18364,"watchers_count":18364,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16638,"mirror_url":null,"archived":false,"open_issues_count":493,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16638,"open_issues":493,"watchers":18364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/22017"},"html":{"href":"https://github.com/apache/spark/pull/22017"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/22017"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/22017/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/22017/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/22017/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/595161fefbf55711b76530a9e53aff73491febd6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ueshin"}}