{"action":"created","issue":{"url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/273","repository_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign","labels_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/273/labels{/name}","comments_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/273/comments","events_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/273/events","html_url":"https://github.com/DeclareDesign/DeclareDesign/issues/273","id":335193798,"node_id":"MDU6SXNzdWUzMzUxOTM3OTg=","number":273,"title":"set_diagnosands","user":{"login":"graemeblair","id":3320015,"node_id":"MDQ6VXNlcjMzMjAwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3320015?v=4","gravatar_id":"","url":"https://api.github.com/users/graemeblair","html_url":"https://github.com/graemeblair","followers_url":"https://api.github.com/users/graemeblair/followers","following_url":"https://api.github.com/users/graemeblair/following{/other_user}","gists_url":"https://api.github.com/users/graemeblair/gists{/gist_id}","starred_url":"https://api.github.com/users/graemeblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemeblair/subscriptions","organizations_url":"https://api.github.com/users/graemeblair/orgs","repos_url":"https://api.github.com/users/graemeblair/repos","events_url":"https://api.github.com/users/graemeblair/events{/privacy}","received_events_url":"https://api.github.com/users/graemeblair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/milestones/1","html_url":"https://github.com/DeclareDesign/DeclareDesign/milestone/1","labels_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/milestones/1/labels","id":2722066,"node_id":"MDk6TWlsZXN0b25lMjcyMjA2Ng==","number":1,"title":"CRAN v1 release","description":null,"creator":{"login":"graemeblair","id":3320015,"node_id":"MDQ6VXNlcjMzMjAwMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/3320015?v=4","gravatar_id":"","url":"https://api.github.com/users/graemeblair","html_url":"https://github.com/graemeblair","followers_url":"https://api.github.com/users/graemeblair/followers","following_url":"https://api.github.com/users/graemeblair/following{/other_user}","gists_url":"https://api.github.com/users/graemeblair/gists{/gist_id}","starred_url":"https://api.github.com/users/graemeblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemeblair/subscriptions","organizations_url":"https://api.github.com/users/graemeblair/orgs","repos_url":"https://api.github.com/users/graemeblair/repos","events_url":"https://api.github.com/users/graemeblair/events{/privacy}","received_events_url":"https://api.github.com/users/graemeblair/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":40,"state":"open","created_at":"2017-08-24T22:30:40Z","updated_at":"2018-06-26T05:49:02Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-06-24T16:45:27Z","updated_at":"2018-06-26T07:52:47Z","closed_at":null,"author_association":"MEMBER","body":"Aims: \r\n- enable `diagnose_design(my_designer())` to work even when default diagnosands won't, so setting diagnosands specific to the designer; and \r\n- make it easy for users to tell us what diagnosands are important for their design.\r\n\r\n@macartan proposal:\r\n\r\n1. set_diagnosands to add attribute \r\n\r\n2.  Diagnose design -- if no diagnosand stipulated, default is\r\nA. Look for diagnosand attributes\r\nB. If not, try default diagnosands\r\n\r\nNeed a default for diagnose_design also when diagnosands are not set for a design."},"comment":{"url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/comments/400214898","html_url":"https://github.com/DeclareDesign/DeclareDesign/issues/273#issuecomment-400214898","issue_url":"https://api.github.com/repos/DeclareDesign/DeclareDesign/issues/273","id":400214898,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIxNDg5OA==","user":{"login":"jaspercooper","id":6787409,"node_id":"MDQ6VXNlcjY3ODc0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6787409?v=4","gravatar_id":"","url":"https://api.github.com/users/jaspercooper","html_url":"https://github.com/jaspercooper","followers_url":"https://api.github.com/users/jaspercooper/followers","following_url":"https://api.github.com/users/jaspercooper/following{/other_user}","gists_url":"https://api.github.com/users/jaspercooper/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspercooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspercooper/subscriptions","organizations_url":"https://api.github.com/users/jaspercooper/orgs","repos_url":"https://api.github.com/users/jaspercooper/repos","events_url":"https://api.github.com/users/jaspercooper/events{/privacy}","received_events_url":"https://api.github.com/users/jaspercooper/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T07:52:47Z","updated_at":"2018-06-26T07:52:47Z","author_association":"CONTRIBUTOR","body":"Also like this (MH) syntax (although I do see the multiple designs problem, I guess this would have to be in a loop?).\r\n\r\nWondering whether we still want `diagnose_design(design,diagnosands = set_diagnosands(bias ...))`. I would vote yes, and that we move `keep_defaults` out of the default handler for `declare_diagnosands` and into `diagnose_design`. When `keep_defaults = TRUE` and design already has diagnosands set, you get the union. \r\n\r\n"}}
{"actor":{"display_login":"jaspercooper"}}