{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/comments/182158374","pull_request_review_id":112909346,"id":182158374,"diff_hunk":"@@ -163,15 +166,21 @@ class BasicHealthTest\n       val key = \"TheKey\"\n \n       println(\"Producing a message\")\n-      withActivation(wsk.activation, wsk.action.invoke(s\"$messagingPackage/$messageHubProduce\", Map(\n-        \"user\" -> kafkaUtils.getAsJson(\"user\"),\n-        \"password\" -> kafkaUtils.getAsJson(\"password\"),\n-        \"kafka_brokers_sasl\" -> kafkaUtils.getAsJson(\"brokers\"),\n-        \"topic\" -> topic.toJson,\n-        \"key\" -> key.toJson,\n-        \"value\" -> currentTime.toJson\n-      ))) {\n-        _.response.success shouldBe true\n+      val producer = kafkaUtils.createProducer()\n+      val record = new ProducerRecord(topic, key, currentTime)\n+      val future = producer.send(record)\n+\n+      producer.flush()\n+      producer.close()","path":"tests/src/test/scala/system/health/BasicHealthTest.scala","position":35,"original_position":35,"commit_id":"23e08f9ec1c5b552621da6dfe991c6559d7ce55c","original_commit_id":"23e08f9ec1c5b552621da6dfe991c6559d7ce55c","user":{"login":"dubee","id":11520887,"avatar_url":"https://avatars3.githubusercontent.com/u/11520887?v=4","gravatar_id":"","url":"https://api.github.com/users/dubee","html_url":"https://github.com/dubee","followers_url":"https://api.github.com/users/dubee/followers","following_url":"https://api.github.com/users/dubee/following{/other_user}","gists_url":"https://api.github.com/users/dubee/gists{/gist_id}","starred_url":"https://api.github.com/users/dubee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubee/subscriptions","organizations_url":"https://api.github.com/users/dubee/orgs","repos_url":"https://api.github.com/users/dubee/repos","events_url":"https://api.github.com/users/dubee/events{/privacy}","received_events_url":"https://api.github.com/users/dubee/received_events","type":"User","site_admin":false},"body":"Is it safe to close the producer before we are guaranteed that the message was sent?","created_at":"2018-04-17T17:11:08Z","updated_at":"2018-04-17T17:11:11Z","html_url":"https://github.com/apache/incubator-openwhisk-package-kafka/pull/264#discussion_r182158374","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/comments/182158374"},"html":{"href":"https://github.com/apache/incubator-openwhisk-package-kafka/pull/264#discussion_r182158374"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264","id":182191337,"html_url":"https://github.com/apache/incubator-openwhisk-package-kafka/pull/264","diff_url":"https://github.com/apache/incubator-openwhisk-package-kafka/pull/264.diff","patch_url":"https://github.com/apache/incubator-openwhisk-package-kafka/pull/264.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues/264","number":264,"state":"open","locked":false,"title":"remove use of messageHubProduce action in health test and use java producer","user":{"login":"abaruni","id":8811230,"avatar_url":"https://avatars0.githubusercontent.com/u/8811230?v=4","gravatar_id":"","url":"https://api.github.com/users/abaruni","html_url":"https://github.com/abaruni","followers_url":"https://api.github.com/users/abaruni/followers","following_url":"https://api.github.com/users/abaruni/following{/other_user}","gists_url":"https://api.github.com/users/abaruni/gists{/gist_id}","starred_url":"https://api.github.com/users/abaruni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaruni/subscriptions","organizations_url":"https://api.github.com/users/abaruni/orgs","repos_url":"https://api.github.com/users/abaruni/repos","events_url":"https://api.github.com/users/abaruni/events{/privacy}","received_events_url":"https://api.github.com/users/abaruni/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-17T14:46:32Z","updated_at":"2018-04-17T17:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7e50d29c5dad8303a5b63854df1e194d0141ffc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues/264/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/statuses/23e08f9ec1c5b552621da6dfe991c6559d7ce55c","head":{"label":"abaruni:health-tests","ref":"health-tests","sha":"23e08f9ec1c5b552621da6dfe991c6559d7ce55c","user":{"login":"abaruni","id":8811230,"avatar_url":"https://avatars0.githubusercontent.com/u/8811230?v=4","gravatar_id":"","url":"https://api.github.com/users/abaruni","html_url":"https://github.com/abaruni","followers_url":"https://api.github.com/users/abaruni/followers","following_url":"https://api.github.com/users/abaruni/following{/other_user}","gists_url":"https://api.github.com/users/abaruni/gists{/gist_id}","starred_url":"https://api.github.com/users/abaruni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaruni/subscriptions","organizations_url":"https://api.github.com/users/abaruni/orgs","repos_url":"https://api.github.com/users/abaruni/repos","events_url":"https://api.github.com/users/abaruni/events{/privacy}","received_events_url":"https://api.github.com/users/abaruni/received_events","type":"User","site_admin":false},"repo":{"id":95587392,"name":"incubator-openwhisk-package-kafka","full_name":"abaruni/incubator-openwhisk-package-kafka","owner":{"login":"abaruni","id":8811230,"avatar_url":"https://avatars0.githubusercontent.com/u/8811230?v=4","gravatar_id":"","url":"https://api.github.com/users/abaruni","html_url":"https://github.com/abaruni","followers_url":"https://api.github.com/users/abaruni/followers","following_url":"https://api.github.com/users/abaruni/following{/other_user}","gists_url":"https://api.github.com/users/abaruni/gists{/gist_id}","starred_url":"https://api.github.com/users/abaruni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaruni/subscriptions","organizations_url":"https://api.github.com/users/abaruni/orgs","repos_url":"https://api.github.com/users/abaruni/repos","events_url":"https://api.github.com/users/abaruni/events{/privacy}","received_events_url":"https://api.github.com/users/abaruni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abaruni/incubator-openwhisk-package-kafka","description":"Apache OpenWhisk package for communicating with Kafka or Message Hub","fork":true,"url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka","forks_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/forks","keys_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/teams","hooks_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/hooks","issue_events_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/events","assignees_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/tags","blobs_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/languages","stargazers_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/stargazers","contributors_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/contributors","subscribers_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/subscribers","subscription_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/subscription","commits_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/merges","archive_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/downloads","issues_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/labels{/name}","releases_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/abaruni/incubator-openwhisk-package-kafka/deployments","created_at":"2017-06-27T18:13:03Z","updated_at":"2018-04-17T14:45:28Z","pushed_at":"2018-04-17T14:45:27Z","git_url":"git://github.com/abaruni/incubator-openwhisk-package-kafka.git","ssh_url":"git@github.com:abaruni/incubator-openwhisk-package-kafka.git","clone_url":"https://github.com/abaruni/incubator-openwhisk-package-kafka.git","svn_url":"https://github.com/abaruni/incubator-openwhisk-package-kafka","homepage":"","size":424,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"241d5a4f2ee99cbdce3ed445a1166c24619eb2a8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":70498479,"name":"incubator-openwhisk-package-kafka","full_name":"apache/incubator-openwhisk-package-kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-openwhisk-package-kafka","description":"Apache OpenWhisk package for communicating with Kafka or Message Hub","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/deployments","created_at":"2016-10-10T14:53:54Z","updated_at":"2018-04-16T15:45:21Z","pushed_at":"2018-04-17T14:46:33Z","git_url":"git://github.com/apache/incubator-openwhisk-package-kafka.git","ssh_url":"git@github.com:apache/incubator-openwhisk-package-kafka.git","clone_url":"https://github.com/apache/incubator-openwhisk-package-kafka.git","svn_url":"https://github.com/apache/incubator-openwhisk-package-kafka","homepage":"","size":386,"stargazers_count":8,"watchers_count":8,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264"},"html":{"href":"https://github.com/apache/incubator-openwhisk-package-kafka/pull/264"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues/264"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk-package-kafka/statuses/23e08f9ec1c5b552621da6dfe991c6559d7ce55c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dubee"}}