{"action":"created","issue":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/802","repository_url":"https://api.github.com/repos/Exa-Networks/exabgp","labels_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/802/comments","events_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/802/events","html_url":"https://github.com/Exa-Networks/exabgp/pull/802","id":315916353,"number":802,"title":"Add back in 3.x logic which stores existing routes over reload to fix…","user":{"login":"longmalx","id":38350137,"avatar_url":"https://avatars3.githubusercontent.com/u/38350137?v=4","gravatar_id":"","url":"https://api.github.com/users/longmalx","html_url":"https://github.com/longmalx","followers_url":"https://api.github.com/users/longmalx/followers","following_url":"https://api.github.com/users/longmalx/following{/other_user}","gists_url":"https://api.github.com/users/longmalx/gists{/gist_id}","starred_url":"https://api.github.com/users/longmalx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longmalx/subscriptions","organizations_url":"https://api.github.com/users/longmalx/orgs","repos_url":"https://api.github.com/users/longmalx/repos","events_url":"https://api.github.com/users/longmalx/events{/privacy}","received_events_url":"https://api.github.com/users/longmalx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-19T14:59:41Z","updated_at":"2018-04-24T10:38:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/pulls/802","html_url":"https://github.com/Exa-Networks/exabgp/pull/802","diff_url":"https://github.com/Exa-Networks/exabgp/pull/802.diff","patch_url":"https://github.com/Exa-Networks/exabgp/pull/802.patch"},"body":"I discovered that on 4.x, if I deleted a static route then did a SIGUSR1 or used the exabgpcli reload command, then the static route was not actually removed from the RIB or neighbor.\r\n\r\nI tracked this down to the configuration reload refactoring.\r\n\r\nA quick solution is to reinstate the old code which copied the changes over reload from 3.x - this doesn't seem the most elegant solution and I'm not clear whether the _previous_neighbors field was intended for something like this (albeit its logic is different).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/exa-networks/exabgp/802)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/comments/383885639","html_url":"https://github.com/Exa-Networks/exabgp/pull/802#issuecomment-383885639","issue_url":"https://api.github.com/repos/Exa-Networks/exabgp/issues/802","id":383885639,"user":{"login":"longmalx","id":38350137,"avatar_url":"https://avatars3.githubusercontent.com/u/38350137?v=4","gravatar_id":"","url":"https://api.github.com/users/longmalx","html_url":"https://github.com/longmalx","followers_url":"https://api.github.com/users/longmalx/followers","following_url":"https://api.github.com/users/longmalx/following{/other_user}","gists_url":"https://api.github.com/users/longmalx/gists{/gist_id}","starred_url":"https://api.github.com/users/longmalx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/longmalx/subscriptions","organizations_url":"https://api.github.com/users/longmalx/orgs","repos_url":"https://api.github.com/users/longmalx/repos","events_url":"https://api.github.com/users/longmalx/events{/privacy}","received_events_url":"https://api.github.com/users/longmalx/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T10:38:14Z","updated_at":"2018-04-24T10:38:14Z","author_association":"NONE","body":"Thanks Thomas.\r\nI've added a PR which fixes the RPM spec files - may be worth merging them before creating 4.0.6? See #803 "}}
{"actor":{"display_login":"longmalx"}}