{"action":"created","comment":{"url":"https://api.github.com/repos/react-component/menu/pulls/comments/201631260","pull_request_review_id":136168466,"id":201631260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTYzMTI2MA==","diff_hunk":"@@ -27,7 +28,7 @@ class DOMWrap extends React.Component {\n   }\n \n   componentDidUpdate(prevProps) {\n-    if (prevProps.children !== this.props.children\n+    if (menuChildrenChanged(prevProps.children, this.props.children)","path":"src/DOMWrap.jsx","position":null,"original_position":13,"commit_id":"5921ab026925cd69615df2b59e0fda6a52db6840","original_commit_id":"5921ab026925cd69615df2b59e0fda6a52db6840","user":{"login":"picodoth","id":1731837,"node_id":"MDQ6VXNlcjE3MzE4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1731837?v=4","gravatar_id":"","url":"https://api.github.com/users/picodoth","html_url":"https://github.com/picodoth","followers_url":"https://api.github.com/users/picodoth/followers","following_url":"https://api.github.com/users/picodoth/following{/other_user}","gists_url":"https://api.github.com/users/picodoth/gists{/gist_id}","starred_url":"https://api.github.com/users/picodoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picodoth/subscriptions","organizations_url":"https://api.github.com/users/picodoth/orgs","repos_url":"https://api.github.com/users/picodoth/repos","events_url":"https://api.github.com/users/picodoth/events{/privacy}","received_events_url":"https://api.github.com/users/picodoth/received_events","type":"User","site_admin":false},"body":"没意识到 MenuItem 的孩子才是真正的内容 Foo 发生变化咋比较好 不能直接比较 reference 否则每次都不一样，不比较 reference 比较啥啊？","created_at":"2018-07-11T09:55:46Z","updated_at":"2018-07-11T09:55:46Z","html_url":"https://github.com/react-component/menu/pull/159#discussion_r201631260","pull_request_url":"https://api.github.com/repos/react-component/menu/pulls/159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/react-component/menu/pulls/comments/201631260"},"html":{"href":"https://github.com/react-component/menu/pull/159#discussion_r201631260"},"pull_request":{"href":"https://api.github.com/repos/react-component/menu/pulls/159"}},"in_reply_to_id":201560763},"pull_request":{"url":"https://api.github.com/repos/react-component/menu/pulls/159","id":195857780,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1ODU3Nzgw","html_url":"https://github.com/react-component/menu/pull/159","diff_url":"https://github.com/react-component/menu/pull/159.diff","patch_url":"https://github.com/react-component/menu/pull/159.patch","issue_url":"https://api.github.com/repos/react-component/menu/issues/159","number":159,"state":"open","locked":false,"title":"feat: allow overflow in horizontal mode","user":{"login":"picodoth","id":1731837,"node_id":"MDQ6VXNlcjE3MzE4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1731837?v=4","gravatar_id":"","url":"https://api.github.com/users/picodoth","html_url":"https://github.com/picodoth","followers_url":"https://api.github.com/users/picodoth/followers","following_url":"https://api.github.com/users/picodoth/following{/other_user}","gists_url":"https://api.github.com/users/picodoth/gists{/gist_id}","starred_url":"https://api.github.com/users/picodoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picodoth/subscriptions","organizations_url":"https://api.github.com/users/picodoth/orgs","repos_url":"https://api.github.com/users/picodoth/repos","events_url":"https://api.github.com/users/picodoth/events{/privacy}","received_events_url":"https://api.github.com/users/picodoth/received_events","type":"User","site_admin":false},"body":"addressing https://github.com/react-component/menu/issues/148\r\n\r\n<img width=\"485\" alt=\"screen shot 2018-06-19 at 10 34 57 pm\" src=\"https://user-images.githubusercontent.com/1731837/41605466-0ae34546-7414-11e8-843a-0ba482d608c9.png\">\r\n\r\nTODO:\r\n\r\n- [x] Adding test\r\n\r\n","created_at":"2018-06-19T14:57:58Z","updated_at":"2018-07-11T09:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba4ecc5f1bac8eba88bbc20ee391012dd512e198","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-component/menu/pulls/159/commits","review_comments_url":"https://api.github.com/repos/react-component/menu/pulls/159/comments","review_comment_url":"https://api.github.com/repos/react-component/menu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-component/menu/issues/159/comments","statuses_url":"https://api.github.com/repos/react-component/menu/statuses/5921ab026925cd69615df2b59e0fda6a52db6840","head":{"label":"react-component:allow-overflow","ref":"allow-overflow","sha":"5921ab026925cd69615df2b59e0fda6a52db6840","user":{"login":"react-component","id":9441414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDE0MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9441414?v=4","gravatar_id":"","url":"https://api.github.com/users/react-component","html_url":"https://github.com/react-component","followers_url":"https://api.github.com/users/react-component/followers","following_url":"https://api.github.com/users/react-component/following{/other_user}","gists_url":"https://api.github.com/users/react-component/gists{/gist_id}","starred_url":"https://api.github.com/users/react-component/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-component/subscriptions","organizations_url":"https://api.github.com/users/react-component/orgs","repos_url":"https://api.github.com/users/react-component/repos","events_url":"https://api.github.com/users/react-component/events{/privacy}","received_events_url":"https://api.github.com/users/react-component/received_events","type":"Organization","site_admin":false},"repo":{"id":28470877,"node_id":"MDEwOlJlcG9zaXRvcnkyODQ3MDg3Nw==","name":"menu","full_name":"react-component/menu","owner":{"login":"react-component","id":9441414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDE0MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9441414?v=4","gravatar_id":"","url":"https://api.github.com/users/react-component","html_url":"https://github.com/react-component","followers_url":"https://api.github.com/users/react-component/followers","following_url":"https://api.github.com/users/react-component/following{/other_user}","gists_url":"https://api.github.com/users/react-component/gists{/gist_id}","starred_url":"https://api.github.com/users/react-component/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-component/subscriptions","organizations_url":"https://api.github.com/users/react-component/orgs","repos_url":"https://api.github.com/users/react-component/repos","events_url":"https://api.github.com/users/react-component/events{/privacy}","received_events_url":"https://api.github.com/users/react-component/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-component/menu","description":"React Menu","fork":false,"url":"https://api.github.com/repos/react-component/menu","forks_url":"https://api.github.com/repos/react-component/menu/forks","keys_url":"https://api.github.com/repos/react-component/menu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-component/menu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-component/menu/teams","hooks_url":"https://api.github.com/repos/react-component/menu/hooks","issue_events_url":"https://api.github.com/repos/react-component/menu/issues/events{/number}","events_url":"https://api.github.com/repos/react-component/menu/events","assignees_url":"https://api.github.com/repos/react-component/menu/assignees{/user}","branches_url":"https://api.github.com/repos/react-component/menu/branches{/branch}","tags_url":"https://api.github.com/repos/react-component/menu/tags","blobs_url":"https://api.github.com/repos/react-component/menu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-component/menu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-component/menu/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-component/menu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-component/menu/statuses/{sha}","languages_url":"https://api.github.com/repos/react-component/menu/languages","stargazers_url":"https://api.github.com/repos/react-component/menu/stargazers","contributors_url":"https://api.github.com/repos/react-component/menu/contributors","subscribers_url":"https://api.github.com/repos/react-component/menu/subscribers","subscription_url":"https://api.github.com/repos/react-component/menu/subscription","commits_url":"https://api.github.com/repos/react-component/menu/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-component/menu/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-component/menu/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-component/menu/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-component/menu/contents/{+path}","compare_url":"https://api.github.com/repos/react-component/menu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-component/menu/merges","archive_url":"https://api.github.com/repos/react-component/menu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-component/menu/downloads","issues_url":"https://api.github.com/repos/react-component/menu/issues{/number}","pulls_url":"https://api.github.com/repos/react-component/menu/pulls{/number}","milestones_url":"https://api.github.com/repos/react-component/menu/milestones{/number}","notifications_url":"https://api.github.com/repos/react-component/menu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-component/menu/labels{/name}","releases_url":"https://api.github.com/repos/react-component/menu/releases{/id}","deployments_url":"https://api.github.com/repos/react-component/menu/deployments","created_at":"2014-12-25T04:36:57Z","updated_at":"2018-07-11T09:14:31Z","pushed_at":"2018-07-11T04:15:22Z","git_url":"git://github.com/react-component/menu.git","ssh_url":"git@github.com:react-component/menu.git","clone_url":"https://github.com/react-component/menu.git","svn_url":"https://github.com/react-component/menu","homepage":"http://react-component.github.io/menu/","size":9588,"stargazers_count":285,"watchers_count":285,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":86,"open_issues":15,"watchers":285,"default_branch":"master"}},"base":{"label":"react-component:master","ref":"master","sha":"1421abe68634ca2b5b621225cc101c20bd7b7be6","user":{"login":"react-component","id":9441414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDE0MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9441414?v=4","gravatar_id":"","url":"https://api.github.com/users/react-component","html_url":"https://github.com/react-component","followers_url":"https://api.github.com/users/react-component/followers","following_url":"https://api.github.com/users/react-component/following{/other_user}","gists_url":"https://api.github.com/users/react-component/gists{/gist_id}","starred_url":"https://api.github.com/users/react-component/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-component/subscriptions","organizations_url":"https://api.github.com/users/react-component/orgs","repos_url":"https://api.github.com/users/react-component/repos","events_url":"https://api.github.com/users/react-component/events{/privacy}","received_events_url":"https://api.github.com/users/react-component/received_events","type":"Organization","site_admin":false},"repo":{"id":28470877,"node_id":"MDEwOlJlcG9zaXRvcnkyODQ3MDg3Nw==","name":"menu","full_name":"react-component/menu","owner":{"login":"react-component","id":9441414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NDE0MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9441414?v=4","gravatar_id":"","url":"https://api.github.com/users/react-component","html_url":"https://github.com/react-component","followers_url":"https://api.github.com/users/react-component/followers","following_url":"https://api.github.com/users/react-component/following{/other_user}","gists_url":"https://api.github.com/users/react-component/gists{/gist_id}","starred_url":"https://api.github.com/users/react-component/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-component/subscriptions","organizations_url":"https://api.github.com/users/react-component/orgs","repos_url":"https://api.github.com/users/react-component/repos","events_url":"https://api.github.com/users/react-component/events{/privacy}","received_events_url":"https://api.github.com/users/react-component/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-component/menu","description":"React Menu","fork":false,"url":"https://api.github.com/repos/react-component/menu","forks_url":"https://api.github.com/repos/react-component/menu/forks","keys_url":"https://api.github.com/repos/react-component/menu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-component/menu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-component/menu/teams","hooks_url":"https://api.github.com/repos/react-component/menu/hooks","issue_events_url":"https://api.github.com/repos/react-component/menu/issues/events{/number}","events_url":"https://api.github.com/repos/react-component/menu/events","assignees_url":"https://api.github.com/repos/react-component/menu/assignees{/user}","branches_url":"https://api.github.com/repos/react-component/menu/branches{/branch}","tags_url":"https://api.github.com/repos/react-component/menu/tags","blobs_url":"https://api.github.com/repos/react-component/menu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-component/menu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-component/menu/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-component/menu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-component/menu/statuses/{sha}","languages_url":"https://api.github.com/repos/react-component/menu/languages","stargazers_url":"https://api.github.com/repos/react-component/menu/stargazers","contributors_url":"https://api.github.com/repos/react-component/menu/contributors","subscribers_url":"https://api.github.com/repos/react-component/menu/subscribers","subscription_url":"https://api.github.com/repos/react-component/menu/subscription","commits_url":"https://api.github.com/repos/react-component/menu/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-component/menu/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-component/menu/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-component/menu/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-component/menu/contents/{+path}","compare_url":"https://api.github.com/repos/react-component/menu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-component/menu/merges","archive_url":"https://api.github.com/repos/react-component/menu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-component/menu/downloads","issues_url":"https://api.github.com/repos/react-component/menu/issues{/number}","pulls_url":"https://api.github.com/repos/react-component/menu/pulls{/number}","milestones_url":"https://api.github.com/repos/react-component/menu/milestones{/number}","notifications_url":"https://api.github.com/repos/react-component/menu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-component/menu/labels{/name}","releases_url":"https://api.github.com/repos/react-component/menu/releases{/id}","deployments_url":"https://api.github.com/repos/react-component/menu/deployments","created_at":"2014-12-25T04:36:57Z","updated_at":"2018-07-11T09:14:31Z","pushed_at":"2018-07-11T04:15:22Z","git_url":"git://github.com/react-component/menu.git","ssh_url":"git@github.com:react-component/menu.git","clone_url":"https://github.com/react-component/menu.git","svn_url":"https://github.com/react-component/menu","homepage":"http://react-component.github.io/menu/","size":9588,"stargazers_count":285,"watchers_count":285,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":86,"open_issues":15,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-component/menu/pulls/159"},"html":{"href":"https://github.com/react-component/menu/pull/159"},"issue":{"href":"https://api.github.com/repos/react-component/menu/issues/159"},"comments":{"href":"https://api.github.com/repos/react-component/menu/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/react-component/menu/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/react-component/menu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-component/menu/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/react-component/menu/statuses/5921ab026925cd69615df2b59e0fda6a52db6840"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"picodoth"}}