{"action":"closed","issue":{"url":"https://api.github.com/repos/learn-co-curriculum/js-tictactoe-rails-api/issues/29","repository_url":"https://api.github.com/repos/learn-co-curriculum/js-tictactoe-rails-api","labels_url":"https://api.github.com/repos/learn-co-curriculum/js-tictactoe-rails-api/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/learn-co-curriculum/js-tictactoe-rails-api/issues/29/comments","events_url":"https://api.github.com/repos/learn-co-curriculum/js-tictactoe-rails-api/issues/29/events","html_url":"https://github.com/learn-co-curriculum/js-tictactoe-rails-api/issues/29","id":242669444,"number":29,"title":"window.turn is NaN in tests","user":{"login":"PCGeekBrain","id":12478828,"avatar_url":"https://avatars1.githubusercontent.com/u/12478828?v=4","gravatar_id":"","url":"https://api.github.com/users/PCGeekBrain","html_url":"https://github.com/PCGeekBrain","followers_url":"https://api.github.com/users/PCGeekBrain/followers","following_url":"https://api.github.com/users/PCGeekBrain/following{/other_user}","gists_url":"https://api.github.com/users/PCGeekBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/PCGeekBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCGeekBrain/subscriptions","organizations_url":"https://api.github.com/users/PCGeekBrain/orgs","repos_url":"https://api.github.com/users/PCGeekBrain/repos","events_url":"https://api.github.com/users/PCGeekBrain/events{/privacy}","received_events_url":"https://api.github.com/users/PCGeekBrain/received_events","type":"User","site_admin":false},"labels":[{"id":501510655,"url":"https://api.github.com/repos/learn-co-curriculum/js-tictactoe-rails-api/labels/Curriculum","name":"Curriculum","color":"7edaff","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-07-13T11:26:01Z","updated_at":"2018-02-07T21:28:43Z","closed_at":"2018-02-07T21:28:43Z","author_association":"NONE","body":"In `test/tictactoe.js` function: `#resetFixtures()` there is a small bug.\r\n\r\n`window.turn *= 0`\r\n\r\nSince this function is called before each in the `player()` tests. And that `window.turn` is not defined at that point. During the first round of testing it is running as `undefined = undefined * 0` or `NaN`\r\n\r\nThis can be fixed by removing the multiplication (and would have the desired effect as `x * 0` is the same as `x = 0`. Or simply\r\n\r\n`window.turn = 0`"}}
{"actor":{"display_login":"curiositypaths"}}