{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments/238547434","pull_request_review_id":181113735,"id":238547434,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODU0NzQzNA==","diff_hunk":"@@ -18,10 +18,12 @@\n \t<visit_attribute_type visit_attribute_type_id=\"2\" name=\"Return Date\" datatype=\"org.openmrs.customdatatype.datatype.DateDatatype\" min_occurs=\"0\" max_occurs=\"2\" creator=\"1\" date_created=\"2005-01-01 00:00:00.0\" retired=\"0\" uuid=\"7770f6d6-7673-11e0-8f03-001e378eb67f\" />\n \t<visit_attribute_type visit_attribute_type_id=\"3\" name=\"Random Attribute\" datatype=\"org.openmrs.customdatatype.datatype.DateDatatype\" min_occurs=\"0\" max_occurs=\"1\" creator=\"1\" date_created=\"2005-01-01 00:00:00.0\" retired=\"0\" uuid=\"6770f6d6-7673-11e0-8f03-001e378eb67g\" />\n \t<visit_attribute_type visit_attribute_type_id=\"4\" name=\"Date Of Discharge\" datatype=\"org.openmrs.customdatatype.datatype.DateDatatype\" min_occurs=\"0\" max_occurs=\"1\" creator=\"1\" date_created=\"2005-01-01 00:00:00.0\" retired=\"1\" retire_reason=\"none\" uuid=\"5770f6d6-7673-11e0-8f03-001e378eb67h\" />\n-\t<visit_attribute visit_attribute_id=\"10\" visit_id=\"1\" attribute_type_id=\"1\" value_reference=\"2011-04-25 00:00:00.0\" creator=\"1\" date_created=\"2005-02-01 00:00:00.0\" voided=\"0\" uuid=\"4c2tyr18-6faa-11e0-7899-001e378eb66a\" />\n+\t<visit_attribute_type visit_attribute_type_id=\"5\" name=\"Random Attribute2\" datatype=\"org.openmrs.customdatatype.datatype.DateDatatype\" min_occurs=\"0\" max_occurs=\"[NULL]\" creator=\"1\" date_created=\"2005-01-01 00:00:00.0\" retired=\"0\" uuid=\"4770f6d6-7673-11e0-8f03-001e378eb67i\" /> ","path":"omod-1.9/src/test/resources/customTestDataset1_9.xml","position":null,"original_position":5,"commit_id":"f7f9ba2ddb4046cbe5d5085949d2ed497e875186","original_commit_id":"80ba4525991845b974e9255ad8a666fafbc36e49","user":{"login":"Bisht13","id":44467788,"node_id":"MDQ6VXNlcjQ0NDY3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/44467788?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisht13","html_url":"https://github.com/Bisht13","followers_url":"https://api.github.com/users/Bisht13/followers","following_url":"https://api.github.com/users/Bisht13/following{/other_user}","gists_url":"https://api.github.com/users/Bisht13/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisht13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisht13/subscriptions","organizations_url":"https://api.github.com/users/Bisht13/orgs","repos_url":"https://api.github.com/users/Bisht13/repos","events_url":"https://api.github.com/users/Bisht13/events{/privacy}","received_events_url":"https://api.github.com/users/Bisht13/received_events","type":"User","site_admin":false},"body":"Hey @dkayiwa made the changes 😄 ","created_at":"2018-12-04T07:08:26Z","updated_at":"2018-12-04T07:08:26Z","html_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/370#discussion_r238547434","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments/238547434"},"html":{"href":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/370#discussion_r238547434"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370"}},"in_reply_to_id":238544309},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370","id":235550956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTUwOTU2","html_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/370","diff_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/370.diff","patch_url":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/370.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/370","number":370,"state":"open","locked":false,"title":"RESTWS-731 Checking if maxOccurs is not null","user":{"login":"Bisht13","id":44467788,"node_id":"MDQ6VXNlcjQ0NDY3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/44467788?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisht13","html_url":"https://github.com/Bisht13","followers_url":"https://api.github.com/users/Bisht13/followers","following_url":"https://api.github.com/users/Bisht13/following{/other_user}","gists_url":"https://api.github.com/users/Bisht13/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisht13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisht13/subscriptions","organizations_url":"https://api.github.com/users/Bisht13/orgs","repos_url":"https://api.github.com/users/Bisht13/repos","events_url":"https://api.github.com/users/Bisht13/events{/privacy}","received_events_url":"https://api.github.com/users/Bisht13/received_events","type":"User","site_admin":false},"body":"<!--- Add a pull request title above in this format -->\r\n<!--- real example: 'RESTWS-738 Remove concept property setters from ObsResource classes' -->\r\n<!--- 'RESTWS-JiraIssueNumber JiraIssueTitle' -->\r\n## Description of what I changed\r\nI changed the if statement so that maxOccurs is checked to be not null.\r\nI also added a test to verify it.\r\n<!--- Describe your changes in detail -->\r\n<!--- It can simply be your commit message, which you must have -->\r\n\r\n\r\n## Issue I worked on\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- Want a new feature or change? Discuss it in an issue first -->\r\n<!--- Found a bug? Point us to the issue/or create one so we can reproduce it -->\r\n<!--- Just add the issue number at the end: -->\r\n[Issue](https://issues.openmrs.org/browse/RESTWS-731)\r\n\r\n## Checklist: I completed these to help reviewers :)\r\n<!--- Put an `x` in the box if you did the task -->\r\n<!--- If you forgot a task please follow the instructions below -->\r\n- [x] My pull request only contains **ONE single commit**\r\n\r\n- [x] My IDE is configured to follow the [**code style**]\r\n\r\n- [x] I have **added tests** to cover my changes. \r\n\r\n- [x] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n\r\n- [x] All new and existing **tests passed**.\r\n\r\n- [x] My pull request is **based on the latest changes** of the master branch.","created_at":"2018-12-03T18:42:07Z","updated_at":"2018-12-04T07:08:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"206162c78857d201471a50e6662d146fa8eb456e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/370/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/statuses/f7f9ba2ddb4046cbe5d5085949d2ed497e875186","head":{"label":"Bisht13:RESTWS-731","ref":"RESTWS-731","sha":"f7f9ba2ddb4046cbe5d5085949d2ed497e875186","user":{"login":"Bisht13","id":44467788,"node_id":"MDQ6VXNlcjQ0NDY3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/44467788?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisht13","html_url":"https://github.com/Bisht13","followers_url":"https://api.github.com/users/Bisht13/followers","following_url":"https://api.github.com/users/Bisht13/following{/other_user}","gists_url":"https://api.github.com/users/Bisht13/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisht13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisht13/subscriptions","organizations_url":"https://api.github.com/users/Bisht13/orgs","repos_url":"https://api.github.com/users/Bisht13/repos","events_url":"https://api.github.com/users/Bisht13/events{/privacy}","received_events_url":"https://api.github.com/users/Bisht13/received_events","type":"User","site_admin":false},"repo":{"id":160232753,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAyMzI3NTM=","name":"openmrs-module-webservices.rest","full_name":"Bisht13/openmrs-module-webservices.rest","private":false,"owner":{"login":"Bisht13","id":44467788,"node_id":"MDQ6VXNlcjQ0NDY3Nzg4","avatar_url":"https://avatars2.githubusercontent.com/u/44467788?v=4","gravatar_id":"","url":"https://api.github.com/users/Bisht13","html_url":"https://github.com/Bisht13","followers_url":"https://api.github.com/users/Bisht13/followers","following_url":"https://api.github.com/users/Bisht13/following{/other_user}","gists_url":"https://api.github.com/users/Bisht13/gists{/gist_id}","starred_url":"https://api.github.com/users/Bisht13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bisht13/subscriptions","organizations_url":"https://api.github.com/users/Bisht13/orgs","repos_url":"https://api.github.com/users/Bisht13/repos","events_url":"https://api.github.com/users/Bisht13/events{/privacy}","received_events_url":"https://api.github.com/users/Bisht13/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bisht13/openmrs-module-webservices.rest","description":"Provides RESTful web services for OpenMRS","fork":true,"url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest","forks_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/forks","keys_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/teams","hooks_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/hooks","issue_events_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/issues/events{/number}","events_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/events","assignees_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/assignees{/user}","branches_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/branches{/branch}","tags_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/tags","blobs_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/statuses/{sha}","languages_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/languages","stargazers_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/stargazers","contributors_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/contributors","subscribers_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/subscribers","subscription_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/subscription","commits_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/contents/{+path}","compare_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/merges","archive_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/downloads","issues_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/issues{/number}","pulls_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/pulls{/number}","milestones_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/milestones{/number}","notifications_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/labels{/name}","releases_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/releases{/id}","deployments_url":"https://api.github.com/repos/Bisht13/openmrs-module-webservices.rest/deployments","created_at":"2018-12-03T18:02:59Z","updated_at":"2018-12-03T18:03:03Z","pushed_at":"2018-12-04T06:55:28Z","git_url":"git://github.com/Bisht13/openmrs-module-webservices.rest.git","ssh_url":"git@github.com:Bisht13/openmrs-module-webservices.rest.git","clone_url":"https://github.com/Bisht13/openmrs-module-webservices.rest.git","svn_url":"https://github.com/Bisht13/openmrs-module-webservices.rest","homepage":null,"size":6699,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"18d69074efaaf808cf4428703e0eac54d5092910","user":{"login":"openmrs","id":860776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MDc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":6951233,"node_id":"MDEwOlJlcG9zaXRvcnk2OTUxMjMz","name":"openmrs-module-webservices.rest","full_name":"openmrs/openmrs-module-webservices.rest","private":false,"owner":{"login":"openmrs","id":860776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MDc3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openmrs/openmrs-module-webservices.rest","description":"Provides RESTful web services for OpenMRS","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest","forks_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/deployments","created_at":"2012-12-01T06:50:25Z","updated_at":"2018-12-02T11:10:24Z","pushed_at":"2018-12-04T06:55:30Z","git_url":"git://github.com/openmrs/openmrs-module-webservices.rest.git","ssh_url":"git@github.com:openmrs/openmrs-module-webservices.rest.git","clone_url":"https://github.com/openmrs/openmrs-module-webservices.rest.git","svn_url":"https://github.com/openmrs/openmrs-module-webservices.rest","homepage":null,"size":6697,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":299,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":299,"open_issues":5,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370"},"html":{"href":"https://github.com/openmrs/openmrs-module-webservices.rest/pull/370"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/370"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-module-webservices.rest/statuses/f7f9ba2ddb4046cbe5d5085949d2ed497e875186"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Bisht13"}}