{"action":"created","issue":{"url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4/issues/13","repository_url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4","labels_url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4/issues/13/comments","events_url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4/issues/13/events","html_url":"https://github.com/ztalbot2000/homebridge-cmd4/issues/13","id":368864016,"node_id":"MDU6SXNzdWUzNjg4NjQwMTY=","number":13,"title":"Misleading example(s)","user":{"login":"flobernd","id":8585557,"node_id":"MDQ6VXNlcjg1ODU1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8585557?v=4","gravatar_id":"","url":"https://api.github.com/users/flobernd","html_url":"https://github.com/flobernd","followers_url":"https://api.github.com/users/flobernd/followers","following_url":"https://api.github.com/users/flobernd/following{/other_user}","gists_url":"https://api.github.com/users/flobernd/gists{/gist_id}","starred_url":"https://api.github.com/users/flobernd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flobernd/subscriptions","organizations_url":"https://api.github.com/users/flobernd/orgs","repos_url":"https://api.github.com/users/flobernd/repos","events_url":"https://api.github.com/users/flobernd/events{/privacy}","received_events_url":"https://api.github.com/users/flobernd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-10T21:32:41Z","updated_at":"2018-10-11T13:54:15Z","closed_at":null,"author_association":"NONE","body":"Hi there,\r\n\r\nI just tested your plugin and got the string values `true`/`false` passed for the `On` characteristic instead of `0`/`1` like described in the README.\r\n\r\nYou might want to fix this.\r\n\r\nBest regards"},"comment":{"url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4/issues/comments/428964327","html_url":"https://github.com/ztalbot2000/homebridge-cmd4/issues/13#issuecomment-428964327","issue_url":"https://api.github.com/repos/ztalbot2000/homebridge-cmd4/issues/13","id":428964327,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODk2NDMyNw==","user":{"login":"flobernd","id":8585557,"node_id":"MDQ6VXNlcjg1ODU1NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8585557?v=4","gravatar_id":"","url":"https://api.github.com/users/flobernd","html_url":"https://github.com/flobernd","followers_url":"https://api.github.com/users/flobernd/followers","following_url":"https://api.github.com/users/flobernd/following{/other_user}","gists_url":"https://api.github.com/users/flobernd/gists{/gist_id}","starred_url":"https://api.github.com/users/flobernd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flobernd/subscriptions","organizations_url":"https://api.github.com/users/flobernd/orgs","repos_url":"https://api.github.com/users/flobernd/repos","events_url":"https://api.github.com/users/flobernd/events{/privacy}","received_events_url":"https://api.github.com/users/flobernd/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T13:54:15Z","updated_at":"2018-10-11T13:54:15Z","author_association":"NONE","body":"Just took a look and you are indeed using implicit type conversion:\r\nhttps://github.com/ztalbot2000/homebridge-cmd4/blob/master/index.js#L1246\r\n\r\nYou might want to change this for boolean values, if there really is inconsistency on different `node-js` versions or platforms."}}
{"actor":{"display_login":"flobernd"}}