{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/243452507","pull_request_review_id":187228151,"id":243452507,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ1MjUwNw==","diff_hunk":"@@ -984,7 +984,8 @@ QgsGeometry QgsVertexTool::cachedGeometry( const QgsVectorLayer *layer, QgsFeatu\n   {\n     connect( layer, &QgsVectorLayer::geometryChanged, this, &QgsVertexTool::onCachedGeometryChanged );\n     connect( layer, &QgsVectorLayer::featureDeleted, this, &QgsVertexTool::onCachedGeometryDeleted );\n-    // TODO: also clear cache when layer is deleted\n+    connect( layer, &QgsVectorLayer::willBeDeleted, this, &QgsVertexTool::clearGeometryCache );\n+    connect( layer, &QgsVectorLayer::dataChanged, this, &QgsVertexTool::clearGeometryCache );","path":"src/app/vertextool/qgsvertextool.cpp","position":6,"original_position":6,"commit_id":"0b29ed68cb2cc92de6d29efa6972e1922f51618a","original_commit_id":"0b29ed68cb2cc92de6d29efa6972e1922f51618a","user":{"login":"nyalldawson","id":1829991,"node_id":"MDQ6VXNlcjE4Mjk5OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1829991?v=4","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"body":"Thanks -- I've updated the dox in 9df3eb3e5cae9ce1df4dd3e0554989c38f9ead2c to explicitly state this!","created_at":"2018-12-20T23:43:03Z","updated_at":"2018-12-20T23:43:03Z","html_url":"https://github.com/qgis/QGIS/pull/8724#discussion_r243452507","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/8724","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/243452507"},"html":{"href":"https://github.com/qgis/QGIS/pull/8724#discussion_r243452507"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8724"}},"in_reply_to_id":243369760},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/8724","id":240187357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMTg3MzU3","html_url":"https://github.com/qgis/QGIS/pull/8724","diff_url":"https://github.com/qgis/QGIS/pull/8724.diff","patch_url":"https://github.com/qgis/QGIS/pull/8724.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/8724","number":8724,"state":"open","locked":false,"title":"Fix vertextool's geometry cache invalidation","user":{"login":"mhugo","id":1618556,"node_id":"MDQ6VXNlcjE2MTg1NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1618556?v=4","gravatar_id":"","url":"https://api.github.com/users/mhugo","html_url":"https://github.com/mhugo","followers_url":"https://api.github.com/users/mhugo/followers","following_url":"https://api.github.com/users/mhugo/following{/other_user}","gists_url":"https://api.github.com/users/mhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhugo/subscriptions","organizations_url":"https://api.github.com/users/mhugo/orgs","repos_url":"https://api.github.com/users/mhugo/repos","events_url":"https://api.github.com/users/mhugo/events{/privacy}","received_events_url":"https://api.github.com/users/mhugo/received_events","type":"User","site_admin":false},"body":"## Description\r\nThe cache must be invalidated when the layer is deleted and also on dataChanged.\r\n\r\nThis prevents very strange situations where phantom geometries were still there, even after project reload and allows a correct cache invalidation on dataChanged (from declared data dependencies for instance).\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [ ] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and contain sufficient information in the commit message to be documented\r\n- [ ] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [ ] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTING.md#contributing-to-qgis) before each commit\r\n","created_at":"2018-12-20T14:23:46Z","updated_at":"2018-12-20T23:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed6bfd79cbd05eaf8492133d50f5397cf7a0e927","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":310142088,"node_id":"MDU6TGFiZWwzMTAxNDIwODg=","url":"https://api.github.com/repos/qgis/QGIS/labels/Bugfix","name":"Bugfix","color":"e11d21","default":false},{"id":718347573,"node_id":"MDU6TGFiZWw3MTgzNDc1NzM=","url":"https://api.github.com/repos/qgis/QGIS/labels/Needs%20Forwardporting","name":"Needs Forwardporting","color":"60bfff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/8724/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/8724/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/8724/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/0b29ed68cb2cc92de6d29efa6972e1922f51618a","head":{"label":"mhugo:fix_vertex_tool_cache","ref":"fix_vertex_tool_cache","sha":"0b29ed68cb2cc92de6d29efa6972e1922f51618a","user":{"login":"mhugo","id":1618556,"node_id":"MDQ6VXNlcjE2MTg1NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1618556?v=4","gravatar_id":"","url":"https://api.github.com/users/mhugo","html_url":"https://github.com/mhugo","followers_url":"https://api.github.com/users/mhugo/followers","following_url":"https://api.github.com/users/mhugo/following{/other_user}","gists_url":"https://api.github.com/users/mhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhugo/subscriptions","organizations_url":"https://api.github.com/users/mhugo/orgs","repos_url":"https://api.github.com/users/mhugo/repos","events_url":"https://api.github.com/users/mhugo/events{/privacy}","received_events_url":"https://api.github.com/users/mhugo/received_events","type":"User","site_admin":false},"repo":{"id":26274103,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI3NDEwMw==","name":"QGIS","full_name":"mhugo/QGIS","private":false,"owner":{"login":"mhugo","id":1618556,"node_id":"MDQ6VXNlcjE2MTg1NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1618556?v=4","gravatar_id":"","url":"https://api.github.com/users/mhugo","html_url":"https://github.com/mhugo","followers_url":"https://api.github.com/users/mhugo/followers","following_url":"https://api.github.com/users/mhugo/following{/other_user}","gists_url":"https://api.github.com/users/mhugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mhugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhugo/subscriptions","organizations_url":"https://api.github.com/users/mhugo/orgs","repos_url":"https://api.github.com/users/mhugo/repos","events_url":"https://api.github.com/users/mhugo/events{/privacy}","received_events_url":"https://api.github.com/users/mhugo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhugo/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/mhugo/QGIS","forks_url":"https://api.github.com/repos/mhugo/QGIS/forks","keys_url":"https://api.github.com/repos/mhugo/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhugo/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhugo/QGIS/teams","hooks_url":"https://api.github.com/repos/mhugo/QGIS/hooks","issue_events_url":"https://api.github.com/repos/mhugo/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/mhugo/QGIS/events","assignees_url":"https://api.github.com/repos/mhugo/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/mhugo/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/mhugo/QGIS/tags","blobs_url":"https://api.github.com/repos/mhugo/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhugo/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhugo/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhugo/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhugo/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/mhugo/QGIS/languages","stargazers_url":"https://api.github.com/repos/mhugo/QGIS/stargazers","contributors_url":"https://api.github.com/repos/mhugo/QGIS/contributors","subscribers_url":"https://api.github.com/repos/mhugo/QGIS/subscribers","subscription_url":"https://api.github.com/repos/mhugo/QGIS/subscription","commits_url":"https://api.github.com/repos/mhugo/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhugo/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhugo/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhugo/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhugo/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/mhugo/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhugo/QGIS/merges","archive_url":"https://api.github.com/repos/mhugo/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhugo/QGIS/downloads","issues_url":"https://api.github.com/repos/mhugo/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/mhugo/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/mhugo/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/mhugo/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhugo/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/mhugo/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/mhugo/QGIS/deployments","created_at":"2014-11-06T14:42:05Z","updated_at":"2016-02-17T14:04:39Z","pushed_at":"2018-12-20T22:42:47Z","git_url":"git://github.com/mhugo/QGIS.git","ssh_url":"git@github.com:mhugo/QGIS.git","clone_url":"https://github.com/mhugo/QGIS.git","svn_url":"https://github.com/mhugo/QGIS","homepage":"http://qgis.org","size":1437434,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:release-3_4","ref":"release-3_4","sha":"381627ed24feea7184431a3add50e776ee382c1b","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","private":false,"owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-12-20T23:41:06Z","pushed_at":"2018-12-20T23:40:59Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1492560,"stargazers_count":2391,"watchers_count":2391,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1368,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1368,"open_issues":19,"watchers":2391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8724"},"html":{"href":"https://github.com/qgis/QGIS/pull/8724"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8724"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/8724/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8724/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/8724/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/0b29ed68cb2cc92de6d29efa6972e1922f51618a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nyalldawson"}}