{"action":"created","comment":{"url":"https://api.github.com/repos/platform9/azure-provider/pulls/comments/230521221","pull_request_review_id":171287620,"id":230521221,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUyMTIyMQ==","diff_hunk":"@@ -129,12 +129,33 @@ func NewMachineActuator(params MachineActuatorParams) (*AzureClient, error) {\n func (azure *AzureClient) Create(cluster *clusterv1.Cluster, machine *clusterv1.Machine) error {\n \tclusterConfig, err := azure.azureProviderConfigCodec.ClusterProviderFromProviderConfig(cluster.Spec.ProviderConfig)\n \tif err != nil {\n-\t\treturn err\n+\t\treturn fmt.Errorf(\"error loading cluster provider config: %v\", err)\n \t}\n-\t_, err = azure.createOrUpdateDeployment(cluster, machine)\n+\tmachineConfig, err := azure.decodeMachineProviderConfig(machine.Spec.ProviderConfig)\n \tif err != nil {\n-\t\treturn err\n+\t\treturn fmt.Errorf(\"error loading machine provider config: %v\", err)\n+\t}\n+\n+\terr = azure.resourcemanagement().ValidateDeployment(machine, clusterConfig, machineConfig)\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"error validating deployment: %v\", err)\n \t}\n+\n+\tdeploymentsFuture, err := azure.resourcemanagement().CreateOrUpdateDeployment(machine, clusterConfig, machineConfig)\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"error creating or updating deployment: %v\", err)\n+\t}\n+\terr = azure.resourcemanagement().WaitForDeploymentsCreateOrUpdateFuture(*deploymentsFuture)\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"error waitinfg for deployment creation or update: %v\", err)","path":"cloud/azure/actuators/machine/machineactuator.go","position":136,"original_position":25,"commit_id":"7c999b83a1080a755183588d899c55e0b2597795","original_commit_id":"678f279b1a8ef10452a838066eb956c70f98ae40","user":{"login":"vannrt","id":8865699,"node_id":"MDQ6VXNlcjg4NjU2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/8865699?v=4","gravatar_id":"","url":"https://api.github.com/users/vannrt","html_url":"https://github.com/vannrt","followers_url":"https://api.github.com/users/vannrt/followers","following_url":"https://api.github.com/users/vannrt/following{/other_user}","gists_url":"https://api.github.com/users/vannrt/gists{/gist_id}","starred_url":"https://api.github.com/users/vannrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vannrt/subscriptions","organizations_url":"https://api.github.com/users/vannrt/orgs","repos_url":"https://api.github.com/users/vannrt/repos","events_url":"https://api.github.com/users/vannrt/events{/privacy}","received_events_url":"https://api.github.com/users/vannrt/received_events","type":"User","site_admin":false},"body":"nit: waitinfg -> waiting","created_at":"2018-11-02T22:06:44Z","updated_at":"2018-11-02T22:20:20Z","html_url":"https://github.com/platform9/azure-provider/pull/26#discussion_r230521221","pull_request_url":"https://api.github.com/repos/platform9/azure-provider/pulls/26","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/platform9/azure-provider/pulls/comments/230521221"},"html":{"href":"https://github.com/platform9/azure-provider/pull/26#discussion_r230521221"},"pull_request":{"href":"https://api.github.com/repos/platform9/azure-provider/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/platform9/azure-provider/pulls/26","id":227113455,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTEzNDU1","html_url":"https://github.com/platform9/azure-provider/pull/26","diff_url":"https://github.com/platform9/azure-provider/pull/26.diff","patch_url":"https://github.com/platform9/azure-provider/pull/26.patch","issue_url":"https://api.github.com/repos/platform9/azure-provider/issues/26","number":26,"state":"open","locked":false,"title":"Refactor Azure Clients","user":{"login":"marwanad","id":7871596,"node_id":"MDQ6VXNlcjc4NzE1OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/7871596?v=4","gravatar_id":"","url":"https://api.github.com/users/marwanad","html_url":"https://github.com/marwanad","followers_url":"https://api.github.com/users/marwanad/followers","following_url":"https://api.github.com/users/marwanad/following{/other_user}","gists_url":"https://api.github.com/users/marwanad/gists{/gist_id}","starred_url":"https://api.github.com/users/marwanad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marwanad/subscriptions","organizations_url":"https://api.github.com/users/marwanad/orgs","repos_url":"https://api.github.com/users/marwanad/repos","events_url":"https://api.github.com/users/marwanad/events{/privacy}","received_events_url":"https://api.github.com/users/marwanad/received_events","type":"User","site_admin":false},"body":"Closes #20.","created_at":"2018-10-30T23:25:10Z","updated_at":"2018-11-02T22:20:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfc1a308fbfa3bd4c6d29a34ba862b10d9659c00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/platform9/azure-provider/pulls/26/commits","review_comments_url":"https://api.github.com/repos/platform9/azure-provider/pulls/26/comments","review_comment_url":"https://api.github.com/repos/platform9/azure-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/platform9/azure-provider/issues/26/comments","statuses_url":"https://api.github.com/repos/platform9/azure-provider/statuses/7c999b83a1080a755183588d899c55e0b2597795","head":{"label":"marwanad:refactor-azure-clients","ref":"refactor-azure-clients","sha":"7c999b83a1080a755183588d899c55e0b2597795","user":{"login":"marwanad","id":7871596,"node_id":"MDQ6VXNlcjc4NzE1OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/7871596?v=4","gravatar_id":"","url":"https://api.github.com/users/marwanad","html_url":"https://github.com/marwanad","followers_url":"https://api.github.com/users/marwanad/followers","following_url":"https://api.github.com/users/marwanad/following{/other_user}","gists_url":"https://api.github.com/users/marwanad/gists{/gist_id}","starred_url":"https://api.github.com/users/marwanad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marwanad/subscriptions","organizations_url":"https://api.github.com/users/marwanad/orgs","repos_url":"https://api.github.com/users/marwanad/repos","events_url":"https://api.github.com/users/marwanad/events{/privacy}","received_events_url":"https://api.github.com/users/marwanad/received_events","type":"User","site_admin":false},"repo":{"id":149665723,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NjU3MjM=","name":"azure-provider","full_name":"marwanad/azure-provider","private":false,"owner":{"login":"marwanad","id":7871596,"node_id":"MDQ6VXNlcjc4NzE1OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/7871596?v=4","gravatar_id":"","url":"https://api.github.com/users/marwanad","html_url":"https://github.com/marwanad","followers_url":"https://api.github.com/users/marwanad/followers","following_url":"https://api.github.com/users/marwanad/following{/other_user}","gists_url":"https://api.github.com/users/marwanad/gists{/gist_id}","starred_url":"https://api.github.com/users/marwanad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marwanad/subscriptions","organizations_url":"https://api.github.com/users/marwanad/orgs","repos_url":"https://api.github.com/users/marwanad/repos","events_url":"https://api.github.com/users/marwanad/events{/privacy}","received_events_url":"https://api.github.com/users/marwanad/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marwanad/azure-provider","description":null,"fork":true,"url":"https://api.github.com/repos/marwanad/azure-provider","forks_url":"https://api.github.com/repos/marwanad/azure-provider/forks","keys_url":"https://api.github.com/repos/marwanad/azure-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marwanad/azure-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marwanad/azure-provider/teams","hooks_url":"https://api.github.com/repos/marwanad/azure-provider/hooks","issue_events_url":"https://api.github.com/repos/marwanad/azure-provider/issues/events{/number}","events_url":"https://api.github.com/repos/marwanad/azure-provider/events","assignees_url":"https://api.github.com/repos/marwanad/azure-provider/assignees{/user}","branches_url":"https://api.github.com/repos/marwanad/azure-provider/branches{/branch}","tags_url":"https://api.github.com/repos/marwanad/azure-provider/tags","blobs_url":"https://api.github.com/repos/marwanad/azure-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marwanad/azure-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marwanad/azure-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/marwanad/azure-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marwanad/azure-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/marwanad/azure-provider/languages","stargazers_url":"https://api.github.com/repos/marwanad/azure-provider/stargazers","contributors_url":"https://api.github.com/repos/marwanad/azure-provider/contributors","subscribers_url":"https://api.github.com/repos/marwanad/azure-provider/subscribers","subscription_url":"https://api.github.com/repos/marwanad/azure-provider/subscription","commits_url":"https://api.github.com/repos/marwanad/azure-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/marwanad/azure-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/marwanad/azure-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/marwanad/azure-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/marwanad/azure-provider/contents/{+path}","compare_url":"https://api.github.com/repos/marwanad/azure-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marwanad/azure-provider/merges","archive_url":"https://api.github.com/repos/marwanad/azure-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marwanad/azure-provider/downloads","issues_url":"https://api.github.com/repos/marwanad/azure-provider/issues{/number}","pulls_url":"https://api.github.com/repos/marwanad/azure-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/marwanad/azure-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/marwanad/azure-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marwanad/azure-provider/labels{/name}","releases_url":"https://api.github.com/repos/marwanad/azure-provider/releases{/id}","deployments_url":"https://api.github.com/repos/marwanad/azure-provider/deployments","created_at":"2018-09-20T20:18:31Z","updated_at":"2018-10-02T16:58:07Z","pushed_at":"2018-11-01T18:39:12Z","git_url":"git://github.com/marwanad/azure-provider.git","ssh_url":"git@github.com:marwanad/azure-provider.git","clone_url":"https://github.com/marwanad/azure-provider.git","svn_url":"https://github.com/marwanad/azure-provider","homepage":null,"size":78872,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"updated-master"}},"base":{"label":"platform9:master","ref":"master","sha":"69cc2d532125886dd2678fbe653ce0e7d572980f","user":{"login":"platform9","id":2824585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQ1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2824585?v=4","gravatar_id":"","url":"https://api.github.com/users/platform9","html_url":"https://github.com/platform9","followers_url":"https://api.github.com/users/platform9/followers","following_url":"https://api.github.com/users/platform9/following{/other_user}","gists_url":"https://api.github.com/users/platform9/gists{/gist_id}","starred_url":"https://api.github.com/users/platform9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platform9/subscriptions","organizations_url":"https://api.github.com/users/platform9/orgs","repos_url":"https://api.github.com/users/platform9/repos","events_url":"https://api.github.com/users/platform9/events{/privacy}","received_events_url":"https://api.github.com/users/platform9/received_events","type":"Organization","site_admin":false},"repo":{"id":137134442,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzQ0NDI=","name":"azure-provider","full_name":"platform9/azure-provider","private":false,"owner":{"login":"platform9","id":2824585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQ1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2824585?v=4","gravatar_id":"","url":"https://api.github.com/users/platform9","html_url":"https://github.com/platform9","followers_url":"https://api.github.com/users/platform9/followers","following_url":"https://api.github.com/users/platform9/following{/other_user}","gists_url":"https://api.github.com/users/platform9/gists{/gist_id}","starred_url":"https://api.github.com/users/platform9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platform9/subscriptions","organizations_url":"https://api.github.com/users/platform9/orgs","repos_url":"https://api.github.com/users/platform9/repos","events_url":"https://api.github.com/users/platform9/events{/privacy}","received_events_url":"https://api.github.com/users/platform9/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/platform9/azure-provider","description":null,"fork":false,"url":"https://api.github.com/repos/platform9/azure-provider","forks_url":"https://api.github.com/repos/platform9/azure-provider/forks","keys_url":"https://api.github.com/repos/platform9/azure-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platform9/azure-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platform9/azure-provider/teams","hooks_url":"https://api.github.com/repos/platform9/azure-provider/hooks","issue_events_url":"https://api.github.com/repos/platform9/azure-provider/issues/events{/number}","events_url":"https://api.github.com/repos/platform9/azure-provider/events","assignees_url":"https://api.github.com/repos/platform9/azure-provider/assignees{/user}","branches_url":"https://api.github.com/repos/platform9/azure-provider/branches{/branch}","tags_url":"https://api.github.com/repos/platform9/azure-provider/tags","blobs_url":"https://api.github.com/repos/platform9/azure-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platform9/azure-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platform9/azure-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/platform9/azure-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platform9/azure-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/platform9/azure-provider/languages","stargazers_url":"https://api.github.com/repos/platform9/azure-provider/stargazers","contributors_url":"https://api.github.com/repos/platform9/azure-provider/contributors","subscribers_url":"https://api.github.com/repos/platform9/azure-provider/subscribers","subscription_url":"https://api.github.com/repos/platform9/azure-provider/subscription","commits_url":"https://api.github.com/repos/platform9/azure-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/platform9/azure-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/platform9/azure-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/platform9/azure-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/platform9/azure-provider/contents/{+path}","compare_url":"https://api.github.com/repos/platform9/azure-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platform9/azure-provider/merges","archive_url":"https://api.github.com/repos/platform9/azure-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platform9/azure-provider/downloads","issues_url":"https://api.github.com/repos/platform9/azure-provider/issues{/number}","pulls_url":"https://api.github.com/repos/platform9/azure-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/platform9/azure-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/platform9/azure-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platform9/azure-provider/labels{/name}","releases_url":"https://api.github.com/repos/platform9/azure-provider/releases{/id}","deployments_url":"https://api.github.com/repos/platform9/azure-provider/deployments","created_at":"2018-06-12T22:29:45Z","updated_at":"2018-10-31T20:02:26Z","pushed_at":"2018-11-02T21:56:44Z","git_url":"git://github.com/platform9/azure-provider.git","ssh_url":"git@github.com:platform9/azure-provider.git","clone_url":"https://github.com/platform9/azure-provider.git","svn_url":"https://github.com/platform9/azure-provider","homepage":null,"size":60902,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/platform9/azure-provider/pulls/26"},"html":{"href":"https://github.com/platform9/azure-provider/pull/26"},"issue":{"href":"https://api.github.com/repos/platform9/azure-provider/issues/26"},"comments":{"href":"https://api.github.com/repos/platform9/azure-provider/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/platform9/azure-provider/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/platform9/azure-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/platform9/azure-provider/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/platform9/azure-provider/statuses/7c999b83a1080a755183588d899c55e0b2597795"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vannrt"}}