{"action":"created","comment":{"url":"https://api.github.com/repos/jserv/mini-arm-os/pulls/comments/223710790","pull_request_review_id":162902475,"id":223710790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzcxMDc5MA==","diff_hunk":"@@ -63,6 +63,15 @@ unsigned int *create_task(unsigned int *stack, void (*start)(void))\n \treturn stack;\n }\n \n+/* After reset, processor is at thread and privileged mode.\n+ * Switch to handler mode to ensure an appropriate exception return.\n+ */\n+void task_init(void)\n+{\n+\tunsigned int null_stacks[32];","path":"04-Multitasking/os.c","position":9,"original_position":9,"commit_id":"893bd3104630837ec92dfd1e1ab66022a1de1664","original_commit_id":"893bd3104630837ec92dfd1e1ab66022a1de1664","user":{"login":"lecopzer","id":6748260,"node_id":"MDQ6VXNlcjY3NDgyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6748260?v=4","gravatar_id":"","url":"https://api.github.com/users/lecopzer","html_url":"https://github.com/lecopzer","followers_url":"https://api.github.com/users/lecopzer/followers","following_url":"https://api.github.com/users/lecopzer/following{/other_user}","gists_url":"https://api.github.com/users/lecopzer/gists{/gist_id}","starred_url":"https://api.github.com/users/lecopzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lecopzer/subscriptions","organizations_url":"https://api.github.com/users/lecopzer/orgs","repos_url":"https://api.github.com/users/lecopzer/repos","events_url":"https://api.github.com/users/lecopzer/events{/privacy}","received_events_url":"https://api.github.com/users/lecopzer/received_events","type":"User","site_admin":false},"body":"Ok, this may apply to 06-Preemptive too.","created_at":"2018-10-09T13:55:47Z","updated_at":"2018-10-09T13:55:48Z","html_url":"https://github.com/jserv/mini-arm-os/pull/29#discussion_r223710790","pull_request_url":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jserv/mini-arm-os/pulls/comments/223710790"},"html":{"href":"https://github.com/jserv/mini-arm-os/pull/29#discussion_r223710790"},"pull_request":{"href":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29"}},"in_reply_to_id":223217796},"pull_request":{"url":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29","id":219200082,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjAwMDgy","html_url":"https://github.com/jserv/mini-arm-os/pull/29","diff_url":"https://github.com/jserv/mini-arm-os/pull/29.diff","patch_url":"https://github.com/jserv/mini-arm-os/pull/29.patch","issue_url":"https://api.github.com/repos/jserv/mini-arm-os/issues/29","number":29,"state":"open","locked":false,"title":"Fix wrong processor mode in first time exception return","user":{"login":"lecopzer","id":6748260,"node_id":"MDQ6VXNlcjY3NDgyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6748260?v=4","gravatar_id":"","url":"https://api.github.com/users/lecopzer","html_url":"https://github.com/lecopzer","followers_url":"https://api.github.com/users/lecopzer/followers","following_url":"https://api.github.com/users/lecopzer/following{/other_user}","gists_url":"https://api.github.com/users/lecopzer/gists{/gist_id}","starred_url":"https://api.github.com/users/lecopzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lecopzer/subscriptions","organizations_url":"https://api.github.com/users/lecopzer/orgs","repos_url":"https://api.github.com/users/lecopzer/repos","events_url":"https://api.github.com/users/lecopzer/events{/privacy}","received_events_url":"https://api.github.com/users/lecopzer/received_events","type":"User","site_admin":false},"body":"Close #27 , fix 04, 07 and 08 which run first thread in wrong mode. See the comments in each commit in detail. \r\nClose #23 , add `naked` attribute before `thread_start`\r\n\r\n","created_at":"2018-09-30T11:24:39Z","updated_at":"2018-10-09T13:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ae081b15b2832f2039e01f5fdcaae7f8962a7ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29/commits","review_comments_url":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29/comments","review_comment_url":"https://api.github.com/repos/jserv/mini-arm-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jserv/mini-arm-os/issues/29/comments","statuses_url":"https://api.github.com/repos/jserv/mini-arm-os/statuses/893bd3104630837ec92dfd1e1ab66022a1de1664","head":{"label":"lecopzer:clean","ref":"clean","sha":"893bd3104630837ec92dfd1e1ab66022a1de1664","user":{"login":"lecopzer","id":6748260,"node_id":"MDQ6VXNlcjY3NDgyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6748260?v=4","gravatar_id":"","url":"https://api.github.com/users/lecopzer","html_url":"https://github.com/lecopzer","followers_url":"https://api.github.com/users/lecopzer/followers","following_url":"https://api.github.com/users/lecopzer/following{/other_user}","gists_url":"https://api.github.com/users/lecopzer/gists{/gist_id}","starred_url":"https://api.github.com/users/lecopzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lecopzer/subscriptions","organizations_url":"https://api.github.com/users/lecopzer/orgs","repos_url":"https://api.github.com/users/lecopzer/repos","events_url":"https://api.github.com/users/lecopzer/events{/privacy}","received_events_url":"https://api.github.com/users/lecopzer/received_events","type":"User","site_admin":false},"repo":{"id":123454508,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0NTQ1MDg=","name":"mini-arm-os","full_name":"lecopzer/mini-arm-os","private":false,"owner":{"login":"lecopzer","id":6748260,"node_id":"MDQ6VXNlcjY3NDgyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/6748260?v=4","gravatar_id":"","url":"https://api.github.com/users/lecopzer","html_url":"https://github.com/lecopzer","followers_url":"https://api.github.com/users/lecopzer/followers","following_url":"https://api.github.com/users/lecopzer/following{/other_user}","gists_url":"https://api.github.com/users/lecopzer/gists{/gist_id}","starred_url":"https://api.github.com/users/lecopzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lecopzer/subscriptions","organizations_url":"https://api.github.com/users/lecopzer/orgs","repos_url":"https://api.github.com/users/lecopzer/repos","events_url":"https://api.github.com/users/lecopzer/events{/privacy}","received_events_url":"https://api.github.com/users/lecopzer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lecopzer/mini-arm-os","description":"Build a minimal multi-tasking OS kernel for ARM from scratch","fork":true,"url":"https://api.github.com/repos/lecopzer/mini-arm-os","forks_url":"https://api.github.com/repos/lecopzer/mini-arm-os/forks","keys_url":"https://api.github.com/repos/lecopzer/mini-arm-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lecopzer/mini-arm-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lecopzer/mini-arm-os/teams","hooks_url":"https://api.github.com/repos/lecopzer/mini-arm-os/hooks","issue_events_url":"https://api.github.com/repos/lecopzer/mini-arm-os/issues/events{/number}","events_url":"https://api.github.com/repos/lecopzer/mini-arm-os/events","assignees_url":"https://api.github.com/repos/lecopzer/mini-arm-os/assignees{/user}","branches_url":"https://api.github.com/repos/lecopzer/mini-arm-os/branches{/branch}","tags_url":"https://api.github.com/repos/lecopzer/mini-arm-os/tags","blobs_url":"https://api.github.com/repos/lecopzer/mini-arm-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lecopzer/mini-arm-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lecopzer/mini-arm-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/lecopzer/mini-arm-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lecopzer/mini-arm-os/statuses/{sha}","languages_url":"https://api.github.com/repos/lecopzer/mini-arm-os/languages","stargazers_url":"https://api.github.com/repos/lecopzer/mini-arm-os/stargazers","contributors_url":"https://api.github.com/repos/lecopzer/mini-arm-os/contributors","subscribers_url":"https://api.github.com/repos/lecopzer/mini-arm-os/subscribers","subscription_url":"https://api.github.com/repos/lecopzer/mini-arm-os/subscription","commits_url":"https://api.github.com/repos/lecopzer/mini-arm-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/lecopzer/mini-arm-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/lecopzer/mini-arm-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/lecopzer/mini-arm-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/lecopzer/mini-arm-os/contents/{+path}","compare_url":"https://api.github.com/repos/lecopzer/mini-arm-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lecopzer/mini-arm-os/merges","archive_url":"https://api.github.com/repos/lecopzer/mini-arm-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lecopzer/mini-arm-os/downloads","issues_url":"https://api.github.com/repos/lecopzer/mini-arm-os/issues{/number}","pulls_url":"https://api.github.com/repos/lecopzer/mini-arm-os/pulls{/number}","milestones_url":"https://api.github.com/repos/lecopzer/mini-arm-os/milestones{/number}","notifications_url":"https://api.github.com/repos/lecopzer/mini-arm-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lecopzer/mini-arm-os/labels{/name}","releases_url":"https://api.github.com/repos/lecopzer/mini-arm-os/releases{/id}","deployments_url":"https://api.github.com/repos/lecopzer/mini-arm-os/deployments","created_at":"2018-03-01T15:34:37Z","updated_at":"2018-09-30T11:15:39Z","pushed_at":"2018-10-07T13:06:38Z","git_url":"git://github.com/lecopzer/mini-arm-os.git","ssh_url":"git@github.com:lecopzer/mini-arm-os.git","clone_url":"https://github.com/lecopzer/mini-arm-os.git","svn_url":"https://github.com/lecopzer/mini-arm-os","homepage":null,"size":436,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jserv:master","ref":"master","sha":"3ea03f56340bf53abb922ee871931ef7b9844a63","user":{"login":"jserv","id":478921,"node_id":"MDQ6VXNlcjQ3ODkyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/478921?v=4","gravatar_id":"","url":"https://api.github.com/users/jserv","html_url":"https://github.com/jserv","followers_url":"https://api.github.com/users/jserv/followers","following_url":"https://api.github.com/users/jserv/following{/other_user}","gists_url":"https://api.github.com/users/jserv/gists{/gist_id}","starred_url":"https://api.github.com/users/jserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jserv/subscriptions","organizations_url":"https://api.github.com/users/jserv/orgs","repos_url":"https://api.github.com/users/jserv/repos","events_url":"https://api.github.com/users/jserv/events{/privacy}","received_events_url":"https://api.github.com/users/jserv/received_events","type":"User","site_admin":false},"repo":{"id":28435595,"node_id":"MDEwOlJlcG9zaXRvcnkyODQzNTU5NQ==","name":"mini-arm-os","full_name":"jserv/mini-arm-os","private":false,"owner":{"login":"jserv","id":478921,"node_id":"MDQ6VXNlcjQ3ODkyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/478921?v=4","gravatar_id":"","url":"https://api.github.com/users/jserv","html_url":"https://github.com/jserv","followers_url":"https://api.github.com/users/jserv/followers","following_url":"https://api.github.com/users/jserv/following{/other_user}","gists_url":"https://api.github.com/users/jserv/gists{/gist_id}","starred_url":"https://api.github.com/users/jserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jserv/subscriptions","organizations_url":"https://api.github.com/users/jserv/orgs","repos_url":"https://api.github.com/users/jserv/repos","events_url":"https://api.github.com/users/jserv/events{/privacy}","received_events_url":"https://api.github.com/users/jserv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jserv/mini-arm-os","description":"Build a minimal multi-tasking OS kernel for ARM from scratch","fork":false,"url":"https://api.github.com/repos/jserv/mini-arm-os","forks_url":"https://api.github.com/repos/jserv/mini-arm-os/forks","keys_url":"https://api.github.com/repos/jserv/mini-arm-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jserv/mini-arm-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jserv/mini-arm-os/teams","hooks_url":"https://api.github.com/repos/jserv/mini-arm-os/hooks","issue_events_url":"https://api.github.com/repos/jserv/mini-arm-os/issues/events{/number}","events_url":"https://api.github.com/repos/jserv/mini-arm-os/events","assignees_url":"https://api.github.com/repos/jserv/mini-arm-os/assignees{/user}","branches_url":"https://api.github.com/repos/jserv/mini-arm-os/branches{/branch}","tags_url":"https://api.github.com/repos/jserv/mini-arm-os/tags","blobs_url":"https://api.github.com/repos/jserv/mini-arm-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jserv/mini-arm-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jserv/mini-arm-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jserv/mini-arm-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jserv/mini-arm-os/statuses/{sha}","languages_url":"https://api.github.com/repos/jserv/mini-arm-os/languages","stargazers_url":"https://api.github.com/repos/jserv/mini-arm-os/stargazers","contributors_url":"https://api.github.com/repos/jserv/mini-arm-os/contributors","subscribers_url":"https://api.github.com/repos/jserv/mini-arm-os/subscribers","subscription_url":"https://api.github.com/repos/jserv/mini-arm-os/subscription","commits_url":"https://api.github.com/repos/jserv/mini-arm-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jserv/mini-arm-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jserv/mini-arm-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jserv/mini-arm-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jserv/mini-arm-os/contents/{+path}","compare_url":"https://api.github.com/repos/jserv/mini-arm-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jserv/mini-arm-os/merges","archive_url":"https://api.github.com/repos/jserv/mini-arm-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jserv/mini-arm-os/downloads","issues_url":"https://api.github.com/repos/jserv/mini-arm-os/issues{/number}","pulls_url":"https://api.github.com/repos/jserv/mini-arm-os/pulls{/number}","milestones_url":"https://api.github.com/repos/jserv/mini-arm-os/milestones{/number}","notifications_url":"https://api.github.com/repos/jserv/mini-arm-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jserv/mini-arm-os/labels{/name}","releases_url":"https://api.github.com/repos/jserv/mini-arm-os/releases{/id}","deployments_url":"https://api.github.com/repos/jserv/mini-arm-os/deployments","created_at":"2014-12-24T05:08:15Z","updated_at":"2018-10-08T07:13:43Z","pushed_at":"2018-10-07T13:06:40Z","git_url":"git://github.com/jserv/mini-arm-os.git","ssh_url":"git@github.com:jserv/mini-arm-os.git","clone_url":"https://github.com/jserv/mini-arm-os.git","svn_url":"https://github.com/jserv/mini-arm-os","homepage":null,"size":429,"stargazers_count":383,"watchers_count":383,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":148,"open_issues":3,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29"},"html":{"href":"https://github.com/jserv/mini-arm-os/pull/29"},"issue":{"href":"https://api.github.com/repos/jserv/mini-arm-os/issues/29"},"comments":{"href":"https://api.github.com/repos/jserv/mini-arm-os/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/jserv/mini-arm-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jserv/mini-arm-os/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/jserv/mini-arm-os/statuses/893bd3104630837ec92dfd1e1ab66022a1de1664"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lecopzer"}}