{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/184275474","pull_request_review_id":115436217,"id":184275474,"diff_hunk":"@@ -2075,6 +2075,10 @@ def load_config(path, env_var, default_path=None, exit_on_config_errors=True):\n     else:\n         log.debug('Missing configuration file: {0}'.format(path))\n \n+        # This still needs to be set for the use of other config files in the\n+        # path besides the main process config file.\n+        opts['conf_file'] = path\n+","path":"salt/config/__init__.py","position":7,"original_position":7,"commit_id":"069148a04c68a4ae812d8d8328ac771e7ac54cc8","original_commit_id":"069148a04c68a4ae812d8d8328ac771e7ac54cc8","user":{"login":"isbm","id":1073714,"avatar_url":"https://avatars2.githubusercontent.com/u/1073714?v=4","gravatar_id":"","url":"https://api.github.com/users/isbm","html_url":"https://github.com/isbm","followers_url":"https://api.github.com/users/isbm/followers","following_url":"https://api.github.com/users/isbm/following{/other_user}","gists_url":"https://api.github.com/users/isbm/gists{/gist_id}","starred_url":"https://api.github.com/users/isbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isbm/subscriptions","organizations_url":"https://api.github.com/users/isbm/orgs","repos_url":"https://api.github.com/users/isbm/repos","events_url":"https://api.github.com/users/isbm/events{/privacy}","received_events_url":"https://api.github.com/users/isbm/received_events","type":"User","site_admin":false},"body":"Still. Why twice setting it? :wink:  How about this:\r\n\r\n```python\r\nif salt.utils.validate.path.is_readable(path):\r\n    try:\r\n        opts = _read_conf_file(path)\r\n    except salt.exceptions.SaltConfigurationError as error:\r\n        log.error(error)\r\n        if exit_on_config_errors:\r\n            sys.exit(salt.defaults.exitcodes.EX_GENERIC)\r\nelse:\r\n    log.debug('Missing configuration file: {0}'.format(path))\r\nopts['conf_file'] = path\r\n```\r\n","created_at":"2018-04-26T05:43:19Z","updated_at":"2018-04-26T05:46:14Z","html_url":"https://github.com/saltstack/salt/pull/47273#discussion_r184275474","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/47273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/184275474"},"html":{"href":"https://github.com/saltstack/salt/pull/47273#discussion_r184275474"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47273"}},"in_reply_to_id":184173706},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47273","id":183772946,"html_url":"https://github.com/saltstack/salt/pull/47273","diff_url":"https://github.com/saltstack/salt/pull/47273.diff","patch_url":"https://github.com/saltstack/salt/pull/47273.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47273","number":47273,"state":"open","locked":false,"title":"set conf_file even if it is not readable","user":{"login":"gtmanfred","id":732321,"avatar_url":"https://avatars0.githubusercontent.com/u/732321?v=4","gravatar_id":"","url":"https://api.github.com/users/gtmanfred","html_url":"https://github.com/gtmanfred","followers_url":"https://api.github.com/users/gtmanfred/followers","following_url":"https://api.github.com/users/gtmanfred/following{/other_user}","gists_url":"https://api.github.com/users/gtmanfred/gists{/gist_id}","starred_url":"https://api.github.com/users/gtmanfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtmanfred/subscriptions","organizations_url":"https://api.github.com/users/gtmanfred/orgs","repos_url":"https://api.github.com/users/gtmanfred/repos","events_url":"https://api.github.com/users/gtmanfred/events{/privacy}","received_events_url":"https://api.github.com/users/gtmanfred/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nThis allows for using grains from the conf_file path, for example, even if the `minion` file does not exist.\r\n\r\n### What issues does this PR fix or reference?\r\nFixes #45315\r\n\r\n### Commits signed with GPG?\r\n\r\nYes","created_at":"2018-04-24T15:17:54Z","updated_at":"2018-04-26T05:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8b6d3fa0528215bc917ef5e76ec68c76121933f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47273/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47273/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47273/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/069148a04c68a4ae812d8d8328ac771e7ac54cc8","head":{"label":"gtmanfred:conf_file","ref":"conf_file","sha":"069148a04c68a4ae812d8d8328ac771e7ac54cc8","user":{"login":"gtmanfred","id":732321,"avatar_url":"https://avatars0.githubusercontent.com/u/732321?v=4","gravatar_id":"","url":"https://api.github.com/users/gtmanfred","html_url":"https://github.com/gtmanfred","followers_url":"https://api.github.com/users/gtmanfred/followers","following_url":"https://api.github.com/users/gtmanfred/following{/other_user}","gists_url":"https://api.github.com/users/gtmanfred/gists{/gist_id}","starred_url":"https://api.github.com/users/gtmanfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtmanfred/subscriptions","organizations_url":"https://api.github.com/users/gtmanfred/orgs","repos_url":"https://api.github.com/users/gtmanfred/repos","events_url":"https://api.github.com/users/gtmanfred/events{/privacy}","received_events_url":"https://api.github.com/users/gtmanfred/received_events","type":"User","site_admin":false},"repo":{"id":16516502,"name":"salt","full_name":"gtmanfred/salt","owner":{"login":"gtmanfred","id":732321,"avatar_url":"https://avatars0.githubusercontent.com/u/732321?v=4","gravatar_id":"","url":"https://api.github.com/users/gtmanfred","html_url":"https://github.com/gtmanfred","followers_url":"https://api.github.com/users/gtmanfred/followers","following_url":"https://api.github.com/users/gtmanfred/following{/other_user}","gists_url":"https://api.github.com/users/gtmanfred/gists{/gist_id}","starred_url":"https://api.github.com/users/gtmanfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtmanfred/subscriptions","organizations_url":"https://api.github.com/users/gtmanfred/orgs","repos_url":"https://api.github.com/users/gtmanfred/repos","events_url":"https://api.github.com/users/gtmanfred/events{/privacy}","received_events_url":"https://api.github.com/users/gtmanfred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtmanfred/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/gtmanfred/salt","forks_url":"https://api.github.com/repos/gtmanfred/salt/forks","keys_url":"https://api.github.com/repos/gtmanfred/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtmanfred/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtmanfred/salt/teams","hooks_url":"https://api.github.com/repos/gtmanfred/salt/hooks","issue_events_url":"https://api.github.com/repos/gtmanfred/salt/issues/events{/number}","events_url":"https://api.github.com/repos/gtmanfred/salt/events","assignees_url":"https://api.github.com/repos/gtmanfred/salt/assignees{/user}","branches_url":"https://api.github.com/repos/gtmanfred/salt/branches{/branch}","tags_url":"https://api.github.com/repos/gtmanfred/salt/tags","blobs_url":"https://api.github.com/repos/gtmanfred/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtmanfred/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtmanfred/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtmanfred/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtmanfred/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/gtmanfred/salt/languages","stargazers_url":"https://api.github.com/repos/gtmanfred/salt/stargazers","contributors_url":"https://api.github.com/repos/gtmanfred/salt/contributors","subscribers_url":"https://api.github.com/repos/gtmanfred/salt/subscribers","subscription_url":"https://api.github.com/repos/gtmanfred/salt/subscription","commits_url":"https://api.github.com/repos/gtmanfred/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtmanfred/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtmanfred/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtmanfred/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtmanfred/salt/contents/{+path}","compare_url":"https://api.github.com/repos/gtmanfred/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtmanfred/salt/merges","archive_url":"https://api.github.com/repos/gtmanfred/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtmanfred/salt/downloads","issues_url":"https://api.github.com/repos/gtmanfred/salt/issues{/number}","pulls_url":"https://api.github.com/repos/gtmanfred/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/gtmanfred/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/gtmanfred/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtmanfred/salt/labels{/name}","releases_url":"https://api.github.com/repos/gtmanfred/salt/releases{/id}","deployments_url":"https://api.github.com/repos/gtmanfred/salt/deployments","created_at":"2014-02-04T15:49:24Z","updated_at":"2018-04-23T17:38:01Z","pushed_at":"2018-04-25T14:49:14Z","git_url":"git://github.com/gtmanfred/salt.git","ssh_url":"git@github.com:gtmanfred/salt.git","clone_url":"https://github.com/gtmanfred/salt.git","svn_url":"https://github.com/gtmanfred/salt","homepage":"saltstack.org","size":217242,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2017.7","ref":"2017.7","sha":"2e014f4746ec90c36c89485fd74787fbc180f1cf","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-04-26T02:35:33Z","pushed_at":"2018-04-26T03:46:19Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":218282,"stargazers_count":8780,"watchers_count":8780,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4117,"mirror_url":null,"archived":false,"open_issues_count":3490,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4117,"open_issues":3490,"watchers":8780,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47273"},"html":{"href":"https://github.com/saltstack/salt/pull/47273"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47273"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47273/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47273/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47273/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/069148a04c68a4ae812d8d8328ac771e7ac54cc8"}},"author_association":"OWNER"}}
{"actor":{"display_login":"isbm"}}