{"action":"created","issue":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/813","repository_url":"https://api.github.com/repos/cta-observatory/ctapipe","labels_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/813/labels{/name}","comments_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/813/comments","events_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/813/events","html_url":"https://github.com/cta-observatory/ctapipe/issues/813","id":378277348,"node_id":"MDU6SXNzdWUzNzgyNzczNDg=","number":813,"title":"Tests failing with ctapipe master and latest ctapipe-extra ","user":{"login":"watsonjj","id":17825673,"node_id":"MDQ6VXNlcjE3ODI1Njcz","avatar_url":"https://avatars0.githubusercontent.com/u/17825673?v=4","gravatar_id":"","url":"https://api.github.com/users/watsonjj","html_url":"https://github.com/watsonjj","followers_url":"https://api.github.com/users/watsonjj/followers","following_url":"https://api.github.com/users/watsonjj/following{/other_user}","gists_url":"https://api.github.com/users/watsonjj/gists{/gist_id}","starred_url":"https://api.github.com/users/watsonjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watsonjj/subscriptions","organizations_url":"https://api.github.com/users/watsonjj/orgs","repos_url":"https://api.github.com/users/watsonjj/repos","events_url":"https://api.github.com/users/watsonjj/events{/privacy}","received_events_url":"https://api.github.com/users/watsonjj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T12:59:47Z","updated_at":"2018-11-09T13:29:44Z","closed_at":null,"author_association":"COLLABORATOR","body":"```\r\nctapipe/image/tests/test_geometry_converter.py::test_convert_geometry_mock[LSTCam-001-3] FAILED\r\nctapipe/image/tests/test_geometry_converter.py::test_convert_geometry_mock[NectarCam-001-3] FAILED\r\n```\r\n\r\nTests are failing in current master branch of ctapipe with the latest version of ctapipe-extra."},"comment":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/comments/437359614","html_url":"https://github.com/cta-observatory/ctapipe/issues/813#issuecomment-437359614","issue_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/813","id":437359614,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzM1OTYxNA==","user":{"login":"kosack","id":11677812,"node_id":"MDQ6VXNlcjExNjc3ODEy","avatar_url":"https://avatars2.githubusercontent.com/u/11677812?v=4","gravatar_id":"","url":"https://api.github.com/users/kosack","html_url":"https://github.com/kosack","followers_url":"https://api.github.com/users/kosack/followers","following_url":"https://api.github.com/users/kosack/following{/other_user}","gists_url":"https://api.github.com/users/kosack/gists{/gist_id}","starred_url":"https://api.github.com/users/kosack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosack/subscriptions","organizations_url":"https://api.github.com/users/kosack/orgs","repos_url":"https://api.github.com/users/kosack/repos","events_url":"https://api.github.com/users/kosack/events{/privacy}","received_events_url":"https://api.github.com/users/kosack/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T13:29:44Z","updated_at":"2018-11-09T13:29:44Z","author_association":"CONTRIBUTOR","body":"I've identified the problem, which is a bad CameraGeometry file: `LSTCam-001.camgeom.fits.gz`.  In the code, it seems that we assume that the base name of the file (\"LSTCam-001\")  is identical to the header keyword \"CAM_ID\", since both are used in different places...\r\n\r\nIn that file, the CAM_ID is listed as \"LST1Cam\", while the filename is called \"LSTCam-001\", so some of the tests get confused by the difference. @FrancaCassol is it ok if I change the header of the file to be LSTCam-001?\r\n\r\n```sh\r\n% ftlist LSTCam-001.camgeom.fits.gz k\r\n...\r\nXTENSION= 'BINTABLE'           / binary table extension\r\nBITPIX  =                    8 / array data type\r\nNAXIS   =                    2 / number of array dimensions\r\nNAXIS1  =                   32 / length of dimension 1\r\nNAXIS2  =                 1855 / length of dimension 2\r\nPCOUNT  =                    0 / number of group parameters\r\nGCOUNT  =                    1 / number of groups\r\nTFIELDS =                    4 / number of table fields\r\nTTYPE1  = 'pix_id  '\r\nTFORM1  = 'K       '\r\nTTYPE2  = 'pix_x   '\r\nTFORM2  = 'D       '\r\nTUNIT2  = 'm       '\r\nTTYPE3  = 'pix_y   '\r\nTFORM3  = 'D       '\r\nTUNIT3  = 'm       '\r\nTTYPE4  = 'pix_area'\r\nTFORM4  = 'D       '\r\nTUNIT4  = 'm2      '\r\nTAB_TYPE= 'ctapipe.instrument.CameraGeometry'\r\nTAB_VER =                  1.0\r\nCAM_ID  = 'LST1Cam '\r\nPIX_ROT =                  0.0\r\nCAM_ROT =                  0.0\r\nPIX_TYPE= 'hexagonal'\r\nSOURCE  = 'From real LST1 data, made by F. Cassol'\r\nDATE    = '2019-10-02'\r\nEND\r\n-----------------------------------------------------------------------"}}
{"actor":{"display_login":"kosack"}}