{"action":"created","issue":{"url":"https://api.github.com/repos/openwrt/openwrt/issues/828","repository_url":"https://api.github.com/repos/openwrt/openwrt","labels_url":"https://api.github.com/repos/openwrt/openwrt/issues/828/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/openwrt/issues/828/comments","events_url":"https://api.github.com/repos/openwrt/openwrt/issues/828/events","html_url":"https://github.com/openwrt/openwrt/pull/828","id":309334339,"number":828,"title":"igmpproxy: fix creation of firewall rules","user":{"login":"Mushoz","id":18422243,"avatar_url":"https://avatars0.githubusercontent.com/u/18422243?v=4","gravatar_id":"","url":"https://api.github.com/users/Mushoz","html_url":"https://github.com/Mushoz","followers_url":"https://api.github.com/users/Mushoz/followers","following_url":"https://api.github.com/users/Mushoz/following{/other_user}","gists_url":"https://api.github.com/users/Mushoz/gists{/gist_id}","starred_url":"https://api.github.com/users/Mushoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mushoz/subscriptions","organizations_url":"https://api.github.com/users/Mushoz/orgs","repos_url":"https://api.github.com/users/Mushoz/repos","events_url":"https://api.github.com/users/Mushoz/events{/privacy}","received_events_url":"https://api.github.com/users/Mushoz/received_events","type":"User","site_admin":false},"labels":[{"id":793819779,"url":"https://api.github.com/repos/openwrt/openwrt/labels/packages","name":"packages","color":"F5D63D","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-28T11:52:34Z","updated_at":"2018-05-01T09:39:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/828","html_url":"https://github.com/openwrt/openwrt/pull/828","diff_url":"https://github.com/openwrt/openwrt/pull/828.diff","patch_url":"https://github.com/openwrt/openwrt/pull/828.patch"},"body":"The init script for igmpproxy uses the option 'network' both as an interface name for fetching the l3_device name and for creating the firewall rules. This only works if the name of the network and firewall zone are identical.\r\n\r\nThis commit introduces a new option 'zone' for configuring the upstream and downstream firewall zones in order for the init script to create the required firewall rules automatically. When no such options are given, the init script falls back to not creating the firewall rules and the user can opt to create these manually.\r\n\r\nAlso deleted the phyint name from the example config, because it might cause confusion what this value should be set to, even though this doesn't do anything."},"comment":{"url":"https://api.github.com/repos/openwrt/openwrt/issues/comments/385635226","html_url":"https://github.com/openwrt/openwrt/pull/828#issuecomment-385635226","issue_url":"https://api.github.com/repos/openwrt/openwrt/issues/828","id":385635226,"user":{"login":"bobafetthotmail","id":9494179,"avatar_url":"https://avatars0.githubusercontent.com/u/9494179?v=4","gravatar_id":"","url":"https://api.github.com/users/bobafetthotmail","html_url":"https://github.com/bobafetthotmail","followers_url":"https://api.github.com/users/bobafetthotmail/followers","following_url":"https://api.github.com/users/bobafetthotmail/following{/other_user}","gists_url":"https://api.github.com/users/bobafetthotmail/gists{/gist_id}","starred_url":"https://api.github.com/users/bobafetthotmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobafetthotmail/subscriptions","organizations_url":"https://api.github.com/users/bobafetthotmail/orgs","repos_url":"https://api.github.com/users/bobafetthotmail/repos","events_url":"https://api.github.com/users/bobafetthotmail/events{/privacy}","received_events_url":"https://api.github.com/users/bobafetthotmail/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T09:39:50Z","updated_at":"2018-05-01T09:39:50Z","author_association":"CONTRIBUTOR","body":"It may take a lot of time as people with commit access can review this when they have time. Months of waiting are normal.\r\n\r\nI think you should place the description you wrote in the OP in the actual commit, they are not going to accept it without a description in the commit."}}
{"actor":{"display_login":"bobafetthotmail"}}