{"action":"opened","number":65,"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/65","id":169236321,"html_url":"https://github.com/apollographql/apollo-link-rest/pull/65","diff_url":"https://github.com/apollographql/apollo-link-rest/pull/65.diff","patch_url":"https://github.com/apollographql/apollo-link-rest/pull/65.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/65","number":65,"state":"open","locked":false,"title":"Better error handling for HTTP Status codes (apollo-link-error)","user":{"login":"jslowack","id":797967,"avatar_url":"https://avatars2.githubusercontent.com/u/797967?v=4","gravatar_id":"","url":"https://api.github.com/users/jslowack","html_url":"https://github.com/jslowack","followers_url":"https://api.github.com/users/jslowack/followers","following_url":"https://api.github.com/users/jslowack/following{/other_user}","gists_url":"https://api.github.com/users/jslowack/gists{/gist_id}","starred_url":"https://api.github.com/users/jslowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslowack/subscriptions","organizations_url":"https://api.github.com/users/jslowack/orgs","repos_url":"https://api.github.com/users/jslowack/repos","events_url":"https://api.github.com/users/jslowack/events{/privacy}","received_events_url":"https://api.github.com/users/jslowack/received_events","type":"User","site_admin":false},"body":"Hi all,\r\n\r\nWe noticed that we couldn't use apollo-link-error in combination with apollo-link-rest.\r\nI checked the apollo-http-client source code in order to check how they've done it to support apollo-link-error and moved this error handling code to apollo-link-rest.\r\n\r\nA test has been added, feel free to give your feedback.\r\n\r\nUseful links:\r\nhttps://github.com/apollographql/apollo-link/blob/master/packages/apollo-link-http/src/httpLink.ts#L104\r\nhttps://github.com/apollographql/apollo-link/blob/master/packages/apollo-link-http/src/httpLink.ts#L257\r\nhttps://www.npmjs.com/package/apollo-link-error","created_at":"2018-02-14T22:12:03Z","updated_at":"2018-02-14T22:12:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/65/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/65/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/65/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-link-rest/statuses/0e03a43aa74ba9c6b2d8f932adee8e0d7a8f5025","head":{"label":"jslowack:feature/status-codes","ref":"feature/status-codes","sha":"0e03a43aa74ba9c6b2d8f932adee8e0d7a8f5025","user":{"login":"jslowack","id":797967,"avatar_url":"https://avatars2.githubusercontent.com/u/797967?v=4","gravatar_id":"","url":"https://api.github.com/users/jslowack","html_url":"https://github.com/jslowack","followers_url":"https://api.github.com/users/jslowack/followers","following_url":"https://api.github.com/users/jslowack/following{/other_user}","gists_url":"https://api.github.com/users/jslowack/gists{/gist_id}","starred_url":"https://api.github.com/users/jslowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslowack/subscriptions","organizations_url":"https://api.github.com/users/jslowack/orgs","repos_url":"https://api.github.com/users/jslowack/repos","events_url":"https://api.github.com/users/jslowack/events{/privacy}","received_events_url":"https://api.github.com/users/jslowack/received_events","type":"User","site_admin":false},"repo":{"id":120649350,"name":"apollo-link-rest","full_name":"jslowack/apollo-link-rest","owner":{"login":"jslowack","id":797967,"avatar_url":"https://avatars2.githubusercontent.com/u/797967?v=4","gravatar_id":"","url":"https://api.github.com/users/jslowack","html_url":"https://github.com/jslowack","followers_url":"https://api.github.com/users/jslowack/followers","following_url":"https://api.github.com/users/jslowack/following{/other_user}","gists_url":"https://api.github.com/users/jslowack/gists{/gist_id}","starred_url":"https://api.github.com/users/jslowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslowack/subscriptions","organizations_url":"https://api.github.com/users/jslowack/orgs","repos_url":"https://api.github.com/users/jslowack/repos","events_url":"https://api.github.com/users/jslowack/events{/privacy}","received_events_url":"https://api.github.com/users/jslowack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jslowack/apollo-link-rest","description":"Use existing REST endpoints with GraphQL","fork":true,"url":"https://api.github.com/repos/jslowack/apollo-link-rest","forks_url":"https://api.github.com/repos/jslowack/apollo-link-rest/forks","keys_url":"https://api.github.com/repos/jslowack/apollo-link-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jslowack/apollo-link-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jslowack/apollo-link-rest/teams","hooks_url":"https://api.github.com/repos/jslowack/apollo-link-rest/hooks","issue_events_url":"https://api.github.com/repos/jslowack/apollo-link-rest/issues/events{/number}","events_url":"https://api.github.com/repos/jslowack/apollo-link-rest/events","assignees_url":"https://api.github.com/repos/jslowack/apollo-link-rest/assignees{/user}","branches_url":"https://api.github.com/repos/jslowack/apollo-link-rest/branches{/branch}","tags_url":"https://api.github.com/repos/jslowack/apollo-link-rest/tags","blobs_url":"https://api.github.com/repos/jslowack/apollo-link-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jslowack/apollo-link-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jslowack/apollo-link-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/jslowack/apollo-link-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jslowack/apollo-link-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/jslowack/apollo-link-rest/languages","stargazers_url":"https://api.github.com/repos/jslowack/apollo-link-rest/stargazers","contributors_url":"https://api.github.com/repos/jslowack/apollo-link-rest/contributors","subscribers_url":"https://api.github.com/repos/jslowack/apollo-link-rest/subscribers","subscription_url":"https://api.github.com/repos/jslowack/apollo-link-rest/subscription","commits_url":"https://api.github.com/repos/jslowack/apollo-link-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/jslowack/apollo-link-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/jslowack/apollo-link-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/jslowack/apollo-link-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/jslowack/apollo-link-rest/contents/{+path}","compare_url":"https://api.github.com/repos/jslowack/apollo-link-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jslowack/apollo-link-rest/merges","archive_url":"https://api.github.com/repos/jslowack/apollo-link-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jslowack/apollo-link-rest/downloads","issues_url":"https://api.github.com/repos/jslowack/apollo-link-rest/issues{/number}","pulls_url":"https://api.github.com/repos/jslowack/apollo-link-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/jslowack/apollo-link-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/jslowack/apollo-link-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jslowack/apollo-link-rest/labels{/name}","releases_url":"https://api.github.com/repos/jslowack/apollo-link-rest/releases{/id}","deployments_url":"https://api.github.com/repos/jslowack/apollo-link-rest/deployments","created_at":"2018-02-07T17:44:00Z","updated_at":"2018-02-07T17:44:03Z","pushed_at":"2018-02-14T22:00:26Z","git_url":"git://github.com/jslowack/apollo-link-rest.git","ssh_url":"git@github.com:jslowack/apollo-link-rest.git","clone_url":"https://github.com/jslowack/apollo-link-rest.git","svn_url":"https://github.com/jslowack/apollo-link-rest","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"114c4cf83568312a7ded7b51a53c24de52d3b783","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":112213284,"name":"apollo-link-rest","full_name":"apollographql/apollo-link-rest","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-link-rest","description":"Use existing REST endpoints with GraphQL","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-link-rest","forks_url":"https://api.github.com/repos/apollographql/apollo-link-rest/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-link-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-link-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-link-rest/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-link-rest/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-link-rest/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-link-rest/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-link-rest/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-link-rest/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-link-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-link-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-link-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-link-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-link-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-link-rest/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-link-rest/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-link-rest/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-link-rest/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-link-rest/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-link-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-link-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-link-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-link-rest/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-link-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-link-rest/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-link-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-link-rest/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-link-rest/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-link-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-link-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-link-rest/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-link-rest/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-link-rest/deployments","created_at":"2017-11-27T15:26:14Z","updated_at":"2018-02-14T11:49:39Z","pushed_at":"2018-01-26T16:46:02Z","git_url":"git://github.com/apollographql/apollo-link-rest.git","ssh_url":"git@github.com:apollographql/apollo-link-rest.git","clone_url":"https://github.com/apollographql/apollo-link-rest.git","svn_url":"https://github.com/apollographql/apollo-link-rest","homepage":null,"size":228,"stargazers_count":132,"watchers_count":132,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17,"open_issues":14,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/65"},"html":{"href":"https://github.com/apollographql/apollo-link-rest/pull/65"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/65"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-link-rest/statuses/0e03a43aa74ba9c6b2d8f932adee8e0d7a8f5025"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":70,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"jslowack"}}