{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/comments/199136752","pull_request_review_id":133197709,"id":199136752,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTEzNjc1Mg==","diff_hunk":"@@ -2,9 +2,9 @@\n \n \n def test_package_is_installed(Package):\n-    docker = Package('docker-engine')\n+    docker = Package('docker-ce')\n     assert docker.is_installed\n-    assert docker.version.startswith('1.12.2')\n+    assert docker.version.startswith('18.03.1')","path":"test/integration/version-18.03.1/testinfra/test_docker.py","position":8,"original_position":8,"commit_id":"b79aff901304b86f35048791aded64a2b8533248","original_commit_id":"b79aff901304b86f35048791aded64a2b8533248","user":{"login":"blbradley","id":1435085,"node_id":"MDQ6VXNlcjE0MzUwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1435085?v=4","gravatar_id":"","url":"https://api.github.com/users/blbradley","html_url":"https://github.com/blbradley","followers_url":"https://api.github.com/users/blbradley/followers","following_url":"https://api.github.com/users/blbradley/following{/other_user}","gists_url":"https://api.github.com/users/blbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/blbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blbradley/subscriptions","organizations_url":"https://api.github.com/users/blbradley/orgs","repos_url":"https://api.github.com/users/blbradley/repos","events_url":"https://api.github.com/users/blbradley/events{/privacy}","received_events_url":"https://api.github.com/users/blbradley/received_events","type":"User","site_admin":false},"body":"Can't use a saltstack pillar var in test python code without non-trivial work","created_at":"2018-06-29T11:58:14Z","updated_at":"2018-06-29T11:58:14Z","html_url":"https://github.com/saltstack-formulas/docker-formula/pull/151#discussion_r199136752","pull_request_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/comments/199136752"},"html":{"href":"https://github.com/saltstack-formulas/docker-formula/pull/151#discussion_r199136752"},"pull_request":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151"}},"in_reply_to_id":198838711},"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151","id":197199494,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTk5NDk0","html_url":"https://github.com/saltstack-formulas/docker-formula/pull/151","diff_url":"https://github.com/saltstack-formulas/docker-formula/pull/151.diff","patch_url":"https://github.com/saltstack-formulas/docker-formula/pull/151.patch","issue_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues/151","number":151,"state":"open","locked":false,"title":"Add repo state and possibility to specify package name","user":{"login":"javierbertoli","id":242396,"node_id":"MDQ6VXNlcjI0MjM5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/242396?v=4","gravatar_id":"","url":"https://api.github.com/users/javierbertoli","html_url":"https://github.com/javierbertoli","followers_url":"https://api.github.com/users/javierbertoli/followers","following_url":"https://api.github.com/users/javierbertoli/following{/other_user}","gists_url":"https://api.github.com/users/javierbertoli/gists{/gist_id}","starred_url":"https://api.github.com/users/javierbertoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierbertoli/subscriptions","organizations_url":"https://api.github.com/users/javierbertoli/orgs","repos_url":"https://api.github.com/users/javierbertoli/repos","events_url":"https://api.github.com/users/javierbertoli/events{/privacy}","received_events_url":"https://api.github.com/users/javierbertoli/received_events","type":"User","site_admin":false},"body":"This PR tried to address #150, adding a separate state to manage repos `repo.sls`.\r\n\r\nWhen testing, found many issues due to old/deprecated versions/repos, so I tried to refactor the formula to be more up-to-date:\r\n\r\n* Added support for testing on:\r\n  * ubuntu-1404 \r\n  * ubuntu-1804\r\n  * debian-stretch\r\n  * debian-jessie\r\n  * centos-7 \r\n\r\n* Added `osfamilymap.yaml`\r\n* Updated repo info\r\n\r\nThis probably can fix/close #109, #150, #131, #136 and #95 \r\n\r\nI'm not using this formula heavily, so if you can check this PR and make suggestions, any comment will be welcome.\r\n\r\nIt seems that a lot of refactoring is needed to clean old stuff and perhaps this PR helps to start doing it :smile: ","created_at":"2018-06-25T18:34:36Z","updated_at":"2018-06-29T11:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a4b641bf0aa083842bfcc156a88ae6c41f97ea5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"myoung34","id":879922,"node_id":"MDQ6VXNlcjg3OTkyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/879922?v=4","gravatar_id":"","url":"https://api.github.com/users/myoung34","html_url":"https://github.com/myoung34","followers_url":"https://api.github.com/users/myoung34/followers","following_url":"https://api.github.com/users/myoung34/following{/other_user}","gists_url":"https://api.github.com/users/myoung34/gists{/gist_id}","starred_url":"https://api.github.com/users/myoung34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myoung34/subscriptions","organizations_url":"https://api.github.com/users/myoung34/orgs","repos_url":"https://api.github.com/users/myoung34/repos","events_url":"https://api.github.com/users/myoung34/events{/privacy}","received_events_url":"https://api.github.com/users/myoung34/received_events","type":"User","site_admin":false},{"login":"blbradley","id":1435085,"node_id":"MDQ6VXNlcjE0MzUwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1435085?v=4","gravatar_id":"","url":"https://api.github.com/users/blbradley","html_url":"https://github.com/blbradley","followers_url":"https://api.github.com/users/blbradley/followers","following_url":"https://api.github.com/users/blbradley/following{/other_user}","gists_url":"https://api.github.com/users/blbradley/gists{/gist_id}","starred_url":"https://api.github.com/users/blbradley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blbradley/subscriptions","organizations_url":"https://api.github.com/users/blbradley/orgs","repos_url":"https://api.github.com/users/blbradley/repos","events_url":"https://api.github.com/users/blbradley/events{/privacy}","received_events_url":"https://api.github.com/users/blbradley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151/commits","review_comments_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151/comments","review_comment_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues/151/comments","statuses_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/statuses/b79aff901304b86f35048791aded64a2b8533248","head":{"label":"netmanagers:master","ref":"master","sha":"b79aff901304b86f35048791aded64a2b8533248","user":{"login":"netmanagers","id":3914531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ1MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3914531?v=4","gravatar_id":"","url":"https://api.github.com/users/netmanagers","html_url":"https://github.com/netmanagers","followers_url":"https://api.github.com/users/netmanagers/followers","following_url":"https://api.github.com/users/netmanagers/following{/other_user}","gists_url":"https://api.github.com/users/netmanagers/gists{/gist_id}","starred_url":"https://api.github.com/users/netmanagers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netmanagers/subscriptions","organizations_url":"https://api.github.com/users/netmanagers/orgs","repos_url":"https://api.github.com/users/netmanagers/repos","events_url":"https://api.github.com/users/netmanagers/events{/privacy}","received_events_url":"https://api.github.com/users/netmanagers/received_events","type":"Organization","site_admin":false},"repo":{"id":86830748,"node_id":"MDEwOlJlcG9zaXRvcnk4NjgzMDc0OA==","name":"docker-formula","full_name":"netmanagers/docker-formula","owner":{"login":"netmanagers","id":3914531,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ1MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3914531?v=4","gravatar_id":"","url":"https://api.github.com/users/netmanagers","html_url":"https://github.com/netmanagers","followers_url":"https://api.github.com/users/netmanagers/followers","following_url":"https://api.github.com/users/netmanagers/following{/other_user}","gists_url":"https://api.github.com/users/netmanagers/gists{/gist_id}","starred_url":"https://api.github.com/users/netmanagers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netmanagers/subscriptions","organizations_url":"https://api.github.com/users/netmanagers/orgs","repos_url":"https://api.github.com/users/netmanagers/repos","events_url":"https://api.github.com/users/netmanagers/events{/privacy}","received_events_url":"https://api.github.com/users/netmanagers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netmanagers/docker-formula","description":"Install and set up Docker","fork":true,"url":"https://api.github.com/repos/netmanagers/docker-formula","forks_url":"https://api.github.com/repos/netmanagers/docker-formula/forks","keys_url":"https://api.github.com/repos/netmanagers/docker-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netmanagers/docker-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netmanagers/docker-formula/teams","hooks_url":"https://api.github.com/repos/netmanagers/docker-formula/hooks","issue_events_url":"https://api.github.com/repos/netmanagers/docker-formula/issues/events{/number}","events_url":"https://api.github.com/repos/netmanagers/docker-formula/events","assignees_url":"https://api.github.com/repos/netmanagers/docker-formula/assignees{/user}","branches_url":"https://api.github.com/repos/netmanagers/docker-formula/branches{/branch}","tags_url":"https://api.github.com/repos/netmanagers/docker-formula/tags","blobs_url":"https://api.github.com/repos/netmanagers/docker-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netmanagers/docker-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netmanagers/docker-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/netmanagers/docker-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netmanagers/docker-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/netmanagers/docker-formula/languages","stargazers_url":"https://api.github.com/repos/netmanagers/docker-formula/stargazers","contributors_url":"https://api.github.com/repos/netmanagers/docker-formula/contributors","subscribers_url":"https://api.github.com/repos/netmanagers/docker-formula/subscribers","subscription_url":"https://api.github.com/repos/netmanagers/docker-formula/subscription","commits_url":"https://api.github.com/repos/netmanagers/docker-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/netmanagers/docker-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/netmanagers/docker-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/netmanagers/docker-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/netmanagers/docker-formula/contents/{+path}","compare_url":"https://api.github.com/repos/netmanagers/docker-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netmanagers/docker-formula/merges","archive_url":"https://api.github.com/repos/netmanagers/docker-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netmanagers/docker-formula/downloads","issues_url":"https://api.github.com/repos/netmanagers/docker-formula/issues{/number}","pulls_url":"https://api.github.com/repos/netmanagers/docker-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/netmanagers/docker-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/netmanagers/docker-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netmanagers/docker-formula/labels{/name}","releases_url":"https://api.github.com/repos/netmanagers/docker-formula/releases{/id}","deployments_url":"https://api.github.com/repos/netmanagers/docker-formula/deployments","created_at":"2017-03-31T14:54:58Z","updated_at":"2018-06-25T18:47:40Z","pushed_at":"2018-06-25T18:47:38Z","git_url":"git://github.com/netmanagers/docker-formula.git","ssh_url":"git@github.com:netmanagers/docker-formula.git","clone_url":"https://github.com/netmanagers/docker-formula.git","svn_url":"https://github.com/netmanagers/docker-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":128,"stargazers_count":0,"watchers_count":0,"language":"SaltStack","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saltstack-formulas:master","ref":"master","sha":"5e8b989537c3f1a2ab2d056af11e23b507aafa0c","user":{"login":"saltstack-formulas","id":4683350,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODMzNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4683350?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"repo":{"id":12735513,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczNTUxMw==","name":"docker-formula","full_name":"saltstack-formulas/docker-formula","owner":{"login":"saltstack-formulas","id":4683350,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2ODMzNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4683350?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack-formulas","html_url":"https://github.com/saltstack-formulas","followers_url":"https://api.github.com/users/saltstack-formulas/followers","following_url":"https://api.github.com/users/saltstack-formulas/following{/other_user}","gists_url":"https://api.github.com/users/saltstack-formulas/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack-formulas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack-formulas/subscriptions","organizations_url":"https://api.github.com/users/saltstack-formulas/orgs","repos_url":"https://api.github.com/users/saltstack-formulas/repos","events_url":"https://api.github.com/users/saltstack-formulas/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack-formulas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack-formulas/docker-formula","description":"Install and set up Docker","fork":false,"url":"https://api.github.com/repos/saltstack-formulas/docker-formula","forks_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/forks","keys_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/teams","hooks_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/hooks","issue_events_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/events","assignees_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/tags","blobs_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/languages","stargazers_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/stargazers","contributors_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/contributors","subscribers_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/subscribers","subscription_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/subscription","commits_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/merges","archive_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/downloads","issues_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/labels{/name}","releases_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack-formulas/docker-formula/deployments","created_at":"2013-09-10T17:08:49Z","updated_at":"2018-06-29T11:25:58Z","pushed_at":"2018-06-29T11:25:56Z","git_url":"git://github.com/saltstack-formulas/docker-formula.git","ssh_url":"git@github.com:saltstack-formulas/docker-formula.git","clone_url":"https://github.com/saltstack-formulas/docker-formula.git","svn_url":"https://github.com/saltstack-formulas/docker-formula","homepage":"http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html","size":145,"stargazers_count":88,"watchers_count":88,"language":"SaltStack","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":237,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":237,"open_issues":11,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151"},"html":{"href":"https://github.com/saltstack-formulas/docker-formula/pull/151"},"issue":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues/151"},"comments":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack-formulas/docker-formula/statuses/b79aff901304b86f35048791aded64a2b8533248"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"blbradley"}}