{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/242572499","pull_request_review_id":186113664,"id":242572499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjU3MjQ5OQ==","diff_hunk":"@@ -1005,48 +979,21 @@ def test_ip_per_task_app_with_user_networking_and_portdefinitions(\n             req_data = resp.json()\n             assert req_data['endpoint_id'] == 'http://127.0.0.2:80'\n \n-    def test_ip_per_task_app_without_user_networking(\n+    def test_app_with_bridge_networking_and_portmappings(\n             self, nginx_class, mocker, valid_user_header):\n         app = self._scheduler_alwaysthere_app()\n-        app['ipAddress'] = {\n-            'networkName': 'samplenet',\n-            'discovery': {\n-                \"ports\": [\n-                    {\"number\": 80, \"name\": \"http\", \"protocol\": \"tcp\"}\n-                ]\n-            }\n-        }\n+        app['networks'] = [{\n+            'mode': 'container/bridge'\n+        }]\n+\n+        app['container']['portMappings'] = [{'containerPort': 80, 'hostPort': 0}]\n         app['tasks'][0]['ipAddresses'][0]['ipAddress'] = '127.0.0.2'\n \n         ar = nginx_class()\n \n-        mocker.send_command(endpoint_id='http://127.0.0.1:8080',\n-                            func_name='set_apps_response',\n-                            aux_data={\"apps\": [app]})\n-\n-        url = ar.make_url_from_path('/service/scheduler-alwaysthere/foo/bar/')\n-        with GuardedSubprocess(ar):\n-            # Trigger cache update by issuing request:\n-            resp = requests.get(url,\n-                                allow_redirects=False,\n-                                headers=valid_user_header)\n-\n-            assert resp.status_code == 200\n-            req_data = resp.json()\n-            assert req_data['endpoint_id'] == 'http://127.0.0.2:80'\n-\n-    def test_ip_per_task_app_with_unspecified_ip_address_DCOS_OSS_1366(\n-            self, nginx_class, mocker, valid_user_header):\n-        \"\"\"\n-        Test that an app that, instead of specifying 'ipAddress: null' does not\n-        specify 'ipAddress' at all, is successfully cached.\n-        \"\"\"\n-        app = self._scheduler_alwaysthere_app()\n-\n-        # Remove the 'ipAddress' key completely, thereby triggering DCOS_OSS-1366.\n-        del(app[\"ipAddress\"])\n-\n-        ar = nginx_class()\n+        pp = pprint.PrettyPrinter(indent=4)","path":"packages/adminrouter/extra/src/test-harness/tests/test_cache.py","position":112,"original_position":112,"commit_id":"15f4dee919bd0c2fe2fb5063c8b47a83ce114f37","original_commit_id":"15f4dee919bd0c2fe2fb5063c8b47a83ce114f37","user":{"login":"mhrabovcin","id":81354,"node_id":"MDQ6VXNlcjgxMzU0","avatar_url":"https://avatars2.githubusercontent.com/u/81354?v=4","gravatar_id":"","url":"https://api.github.com/users/mhrabovcin","html_url":"https://github.com/mhrabovcin","followers_url":"https://api.github.com/users/mhrabovcin/followers","following_url":"https://api.github.com/users/mhrabovcin/following{/other_user}","gists_url":"https://api.github.com/users/mhrabovcin/gists{/gist_id}","starred_url":"https://api.github.com/users/mhrabovcin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhrabovcin/subscriptions","organizations_url":"https://api.github.com/users/mhrabovcin/orgs","repos_url":"https://api.github.com/users/mhrabovcin/repos","events_url":"https://api.github.com/users/mhrabovcin/events{/privacy}","received_events_url":"https://api.github.com/users/mhrabovcin/received_events","type":"User","site_admin":false},"body":"Remove pretty printing section.","created_at":"2018-12-18T15:05:13Z","updated_at":"2018-12-18T15:05:14Z","html_url":"https://github.com/dcos/dcos/pull/3855#discussion_r242572499","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/3855","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/242572499"},"html":{"href":"https://github.com/dcos/dcos/pull/3855#discussion_r242572499"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3855"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/3855","id":234963585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTYzNTg1","html_url":"https://github.com/dcos/dcos/pull/3855","diff_url":"https://github.com/dcos/dcos/pull/3855.diff","patch_url":"https://github.com/dcos/dcos/pull/3855.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/3855","number":3855,"state":"open","locked":false,"title":"AR: supporting endpoints for services running in CNI","user":{"login":"ahairape","id":2931176,"node_id":"MDQ6VXNlcjI5MzExNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2931176?v=4","gravatar_id":"","url":"https://api.github.com/users/ahairape","html_url":"https://github.com/ahairape","followers_url":"https://api.github.com/users/ahairape/followers","following_url":"https://api.github.com/users/ahairape/following{/other_user}","gists_url":"https://api.github.com/users/ahairape/gists{/gist_id}","starred_url":"https://api.github.com/users/ahairape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahairape/subscriptions","organizations_url":"https://api.github.com/users/ahairape/orgs","repos_url":"https://api.github.com/users/ahairape/repos","events_url":"https://api.github.com/users/ahairape/events{/privacy}","received_events_url":"https://api.github.com/users/ahairape/received_events","type":"User","site_admin":false},"body":"## High-level description\r\nDue to Marathon app description syntax change https://github.com/mesosphere/marathon/blob/master/docs/docs/upgrade/network-api-migration.md#example-definitions AR is not able to expose apps defined with the new syntax. This PR fixes this issue.\r\n\r\n## Corresponding DC/OS tickets (obligatory)\r\n\r\nThese DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:\r\nhttps://jira.mesosphere.com/browse/DCOS-45468\r\n\r\n## Checklist for all PRs\r\n\r\n  - [ ] Added a comprehensible changelog entry to `CHANGES.md` or explain why this is not a user-facing change:\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)","created_at":"2018-11-30T11:54:23Z","updated_at":"2018-12-18T15:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56d3c654696f4be746050ee57d42d6dbbe4bd189","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":364878184,"node_id":"MDU6TGFiZWwzNjQ4NzgxODQ=","url":"https://api.github.com/repos/dcos/dcos/labels/Ready%20For%20Review","name":"Ready For Review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/3855/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/3855/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/3855/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/15f4dee919bd0c2fe2fb5063c8b47a83ce114f37","head":{"label":"ahairape:ah/DCOS-45468","ref":"ah/DCOS-45468","sha":"15f4dee919bd0c2fe2fb5063c8b47a83ce114f37","user":{"login":"ahairape","id":2931176,"node_id":"MDQ6VXNlcjI5MzExNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2931176?v=4","gravatar_id":"","url":"https://api.github.com/users/ahairape","html_url":"https://github.com/ahairape","followers_url":"https://api.github.com/users/ahairape/followers","following_url":"https://api.github.com/users/ahairape/following{/other_user}","gists_url":"https://api.github.com/users/ahairape/gists{/gist_id}","starred_url":"https://api.github.com/users/ahairape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahairape/subscriptions","organizations_url":"https://api.github.com/users/ahairape/orgs","repos_url":"https://api.github.com/users/ahairape/repos","events_url":"https://api.github.com/users/ahairape/events{/privacy}","received_events_url":"https://api.github.com/users/ahairape/received_events","type":"User","site_admin":false},"repo":{"id":123494628,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0OTQ2Mjg=","name":"dcos","full_name":"ahairape/dcos","private":false,"owner":{"login":"ahairape","id":2931176,"node_id":"MDQ6VXNlcjI5MzExNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/2931176?v=4","gravatar_id":"","url":"https://api.github.com/users/ahairape","html_url":"https://github.com/ahairape","followers_url":"https://api.github.com/users/ahairape/followers","following_url":"https://api.github.com/users/ahairape/following{/other_user}","gists_url":"https://api.github.com/users/ahairape/gists{/gist_id}","starred_url":"https://api.github.com/users/ahairape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahairape/subscriptions","organizations_url":"https://api.github.com/users/ahairape/orgs","repos_url":"https://api.github.com/users/ahairape/repos","events_url":"https://api.github.com/users/ahairape/events{/privacy}","received_events_url":"https://api.github.com/users/ahairape/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ahairape/dcos","description":"DC/OS - The Datacenter Operating System ","fork":true,"url":"https://api.github.com/repos/ahairape/dcos","forks_url":"https://api.github.com/repos/ahairape/dcos/forks","keys_url":"https://api.github.com/repos/ahairape/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahairape/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahairape/dcos/teams","hooks_url":"https://api.github.com/repos/ahairape/dcos/hooks","issue_events_url":"https://api.github.com/repos/ahairape/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/ahairape/dcos/events","assignees_url":"https://api.github.com/repos/ahairape/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/ahairape/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/ahairape/dcos/tags","blobs_url":"https://api.github.com/repos/ahairape/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahairape/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahairape/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahairape/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahairape/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/ahairape/dcos/languages","stargazers_url":"https://api.github.com/repos/ahairape/dcos/stargazers","contributors_url":"https://api.github.com/repos/ahairape/dcos/contributors","subscribers_url":"https://api.github.com/repos/ahairape/dcos/subscribers","subscription_url":"https://api.github.com/repos/ahairape/dcos/subscription","commits_url":"https://api.github.com/repos/ahairape/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahairape/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahairape/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahairape/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahairape/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/ahairape/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahairape/dcos/merges","archive_url":"https://api.github.com/repos/ahairape/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahairape/dcos/downloads","issues_url":"https://api.github.com/repos/ahairape/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/ahairape/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/ahairape/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/ahairape/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahairape/dcos/labels{/name}","releases_url":"https://api.github.com/repos/ahairape/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/ahairape/dcos/deployments","created_at":"2018-03-01T21:29:51Z","updated_at":"2018-12-17T20:06:06Z","pushed_at":"2018-12-18T15:02:34Z","git_url":"git://github.com/ahairape/dcos.git","ssh_url":"git@github.com:ahairape/dcos.git","clone_url":"https://github.com/ahairape/dcos.git","svn_url":"https://github.com/ahairape/dcos","homepage":"https://dcos.io","size":7161,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"db2e0afef293e0cf14f9dd0905e66b2d1f1e8877","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"node_id":"MDEwOlJlcG9zaXRvcnk1NjE4NDA1MA==","name":"dcos","full_name":"dcos/dcos","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2018-12-18T03:15:54Z","pushed_at":"2018-12-18T15:02:36Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":8089,"stargazers_count":2082,"watchers_count":2082,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":438,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":438,"open_issues":112,"watchers":2082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3855"},"html":{"href":"https://github.com/dcos/dcos/pull/3855"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/3855"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/3855/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3855/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/3855/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/15f4dee919bd0c2fe2fb5063c8b47a83ce114f37"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mhrabovcin"}}