{"action":"created","comment":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/168915526","pull_request_review_id":97368091,"id":168915526,"diff_hunk":"@@ -2,9 +2,8 @@\n \n use remacs_macros::lisp_fn;\n use remacs_sys::{current_global_map as _current_global_map, globals, EmacsInt, CHAR_META};\n-use remacs_sys::{access_keymap, get_keymap, maybe_quit, Fevent_convert_list, Ffset, Fpurecopy,\n-                 Fset};\n-use remacs_sys::Qkeymap;\n+use remacs_sys::{access_keymap, get_keymap, maybe_quit, Fcons, Fevent_convert_list, Ffset,\n+                 Fmake_char_table, Fpurecopy, Fset, Qkeymap, Qnil};","path":"rust_src/src/keymap.rs","position":8,"original_position":8,"commit_id":"33419b9d33c7d745d75e9d170eed9aa09e6e70ec","original_commit_id":"33419b9d33c7d745d75e9d170eed9aa09e6e70ec","user":{"login":"shaleh","id":1377996,"avatar_url":"https://avatars3.githubusercontent.com/u/1377996?v=4","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"body":"Ah, nevermind. Yes, it is in the CONTRIBUTING.md","created_at":"2018-02-17T07:38:06Z","updated_at":"2018-02-17T07:38:06Z","html_url":"https://github.com/Wilfred/remacs/pull/647#discussion_r168915526","pull_request_url":"https://api.github.com/repos/Wilfred/remacs/pulls/647","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/168915526"},"html":{"href":"https://github.com/Wilfred/remacs/pull/647#discussion_r168915526"},"pull_request":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/647"}},"in_reply_to_id":168913114},"pull_request":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/647","id":169620715,"html_url":"https://github.com/Wilfred/remacs/pull/647","diff_url":"https://github.com/Wilfred/remacs/pull/647.diff","patch_url":"https://github.com/Wilfred/remacs/pull/647.patch","issue_url":"https://api.github.com/repos/Wilfred/remacs/issues/647","number":647,"state":"open","locked":false,"title":"Ported make-keymap and keymapp functions with tests.","user":{"login":"accidentalrebel","id":1009214,"avatar_url":"https://avatars0.githubusercontent.com/u/1009214?v=4","gravatar_id":"","url":"https://api.github.com/users/accidentalrebel","html_url":"https://github.com/accidentalrebel","followers_url":"https://api.github.com/users/accidentalrebel/followers","following_url":"https://api.github.com/users/accidentalrebel/following{/other_user}","gists_url":"https://api.github.com/users/accidentalrebel/gists{/gist_id}","starred_url":"https://api.github.com/users/accidentalrebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accidentalrebel/subscriptions","organizations_url":"https://api.github.com/users/accidentalrebel/orgs","repos_url":"https://api.github.com/users/accidentalrebel/repos","events_url":"https://api.github.com/users/accidentalrebel/events{/privacy}","received_events_url":"https://api.github.com/users/accidentalrebel/received_events","type":"User","site_admin":false},"body":"Ported the `make-keymap` and `keymapp` function in `keymap.c` with tests.\r\n\r\nSome thoughts and observations, feel free to correct me if I'm wrong:\r\n- To access unported C code from the Rust side they first need to be added to `lib.rs`. This is why I needed to add the functions `Fmake_char_table` and `list1` to `list5` to it. After this they will be usable if they are declared like so `use::remacs_sys::Fmake_char_table`. Is this correct?\r\n- In `keymap.rs` there are multiple lines of `use::remacs_sys::` (line 4, 5, and 7), is there a reason why they are separated. Or could I merge them all into one line?\r\n\r\nThat's it. Thanks again in advance!\r\n","created_at":"2018-02-16T13:11:40Z","updated_at":"2018-02-17T07:38:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82613f1dab543f16af4d83e159dc285c7a42f04a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wilfred/remacs/pulls/647/commits","review_comments_url":"https://api.github.com/repos/Wilfred/remacs/pulls/647/comments","review_comment_url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wilfred/remacs/issues/647/comments","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/33419b9d33c7d745d75e9d170eed9aa09e6e70ec","head":{"label":"accidentalrebel:master","ref":"master","sha":"33419b9d33c7d745d75e9d170eed9aa09e6e70ec","user":{"login":"accidentalrebel","id":1009214,"avatar_url":"https://avatars0.githubusercontent.com/u/1009214?v=4","gravatar_id":"","url":"https://api.github.com/users/accidentalrebel","html_url":"https://github.com/accidentalrebel","followers_url":"https://api.github.com/users/accidentalrebel/followers","following_url":"https://api.github.com/users/accidentalrebel/following{/other_user}","gists_url":"https://api.github.com/users/accidentalrebel/gists{/gist_id}","starred_url":"https://api.github.com/users/accidentalrebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accidentalrebel/subscriptions","organizations_url":"https://api.github.com/users/accidentalrebel/orgs","repos_url":"https://api.github.com/users/accidentalrebel/repos","events_url":"https://api.github.com/users/accidentalrebel/events{/privacy}","received_events_url":"https://api.github.com/users/accidentalrebel/received_events","type":"User","site_admin":false},"repo":{"id":121388774,"name":"remacs","full_name":"accidentalrebel/remacs","owner":{"login":"accidentalrebel","id":1009214,"avatar_url":"https://avatars0.githubusercontent.com/u/1009214?v=4","gravatar_id":"","url":"https://api.github.com/users/accidentalrebel","html_url":"https://github.com/accidentalrebel","followers_url":"https://api.github.com/users/accidentalrebel/followers","following_url":"https://api.github.com/users/accidentalrebel/following{/other_user}","gists_url":"https://api.github.com/users/accidentalrebel/gists{/gist_id}","starred_url":"https://api.github.com/users/accidentalrebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/accidentalrebel/subscriptions","organizations_url":"https://api.github.com/users/accidentalrebel/orgs","repos_url":"https://api.github.com/users/accidentalrebel/repos","events_url":"https://api.github.com/users/accidentalrebel/events{/privacy}","received_events_url":"https://api.github.com/users/accidentalrebel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/accidentalrebel/remacs","description":"Rust :heart: Emacs","fork":true,"url":"https://api.github.com/repos/accidentalrebel/remacs","forks_url":"https://api.github.com/repos/accidentalrebel/remacs/forks","keys_url":"https://api.github.com/repos/accidentalrebel/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/accidentalrebel/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/accidentalrebel/remacs/teams","hooks_url":"https://api.github.com/repos/accidentalrebel/remacs/hooks","issue_events_url":"https://api.github.com/repos/accidentalrebel/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/accidentalrebel/remacs/events","assignees_url":"https://api.github.com/repos/accidentalrebel/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/accidentalrebel/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/accidentalrebel/remacs/tags","blobs_url":"https://api.github.com/repos/accidentalrebel/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/accidentalrebel/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/accidentalrebel/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/accidentalrebel/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/accidentalrebel/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/accidentalrebel/remacs/languages","stargazers_url":"https://api.github.com/repos/accidentalrebel/remacs/stargazers","contributors_url":"https://api.github.com/repos/accidentalrebel/remacs/contributors","subscribers_url":"https://api.github.com/repos/accidentalrebel/remacs/subscribers","subscription_url":"https://api.github.com/repos/accidentalrebel/remacs/subscription","commits_url":"https://api.github.com/repos/accidentalrebel/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/accidentalrebel/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/accidentalrebel/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/accidentalrebel/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/accidentalrebel/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/accidentalrebel/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/accidentalrebel/remacs/merges","archive_url":"https://api.github.com/repos/accidentalrebel/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/accidentalrebel/remacs/downloads","issues_url":"https://api.github.com/repos/accidentalrebel/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/accidentalrebel/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/accidentalrebel/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/accidentalrebel/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/accidentalrebel/remacs/labels{/name}","releases_url":"https://api.github.com/repos/accidentalrebel/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/accidentalrebel/remacs/deployments","created_at":"2018-02-13T13:57:10Z","updated_at":"2018-02-13T13:57:31Z","pushed_at":"2018-02-17T02:04:03Z","git_url":"git://github.com/accidentalrebel/remacs.git","ssh_url":"git@github.com:accidentalrebel/remacs.git","clone_url":"https://github.com/accidentalrebel/remacs.git","svn_url":"https://github.com/accidentalrebel/remacs","homepage":"","size":263786,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wilfred:master","ref":"master","sha":"0b3e23cb90d7039e370423ac620300fc19294884","user":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"repo":{"id":74522337,"name":"remacs","full_name":"Wilfred/remacs","owner":{"login":"Wilfred","id":70800,"avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wilfred/remacs","description":"Rust :heart: Emacs","fork":false,"url":"https://api.github.com/repos/Wilfred/remacs","forks_url":"https://api.github.com/repos/Wilfred/remacs/forks","keys_url":"https://api.github.com/repos/Wilfred/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wilfred/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wilfred/remacs/teams","hooks_url":"https://api.github.com/repos/Wilfred/remacs/hooks","issue_events_url":"https://api.github.com/repos/Wilfred/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/Wilfred/remacs/events","assignees_url":"https://api.github.com/repos/Wilfred/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/Wilfred/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/Wilfred/remacs/tags","blobs_url":"https://api.github.com/repos/Wilfred/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wilfred/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wilfred/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wilfred/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/Wilfred/remacs/languages","stargazers_url":"https://api.github.com/repos/Wilfred/remacs/stargazers","contributors_url":"https://api.github.com/repos/Wilfred/remacs/contributors","subscribers_url":"https://api.github.com/repos/Wilfred/remacs/subscribers","subscription_url":"https://api.github.com/repos/Wilfred/remacs/subscription","commits_url":"https://api.github.com/repos/Wilfred/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wilfred/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wilfred/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wilfred/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wilfred/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/Wilfred/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wilfred/remacs/merges","archive_url":"https://api.github.com/repos/Wilfred/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wilfred/remacs/downloads","issues_url":"https://api.github.com/repos/Wilfred/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/Wilfred/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/Wilfred/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/Wilfred/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wilfred/remacs/labels{/name}","releases_url":"https://api.github.com/repos/Wilfred/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/Wilfred/remacs/deployments","created_at":"2016-11-22T23:29:21Z","updated_at":"2018-02-16T22:37:32Z","pushed_at":"2018-02-17T02:04:04Z","git_url":"git://github.com/Wilfred/remacs.git","ssh_url":"git@github.com:Wilfred/remacs.git","clone_url":"https://github.com/Wilfred/remacs.git","svn_url":"https://github.com/Wilfred/remacs","homepage":"","size":263659,"stargazers_count":2173,"watchers_count":2173,"language":"Emacs Lisp","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":175,"open_issues":57,"watchers":2173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/647"},"html":{"href":"https://github.com/Wilfred/remacs/pull/647"},"issue":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/647"},"comments":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/647/comments"},"review_comments":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/647/comments"},"review_comment":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/647/commits"},"statuses":{"href":"https://api.github.com/repos/Wilfred/remacs/statuses/33419b9d33c7d745d75e9d170eed9aa09e6e70ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shaleh"}}