{"action":"closed","number":16694,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16694","id":188867894,"html_url":"https://github.com/apple/swift/pull/16694","diff_url":"https://github.com/apple/swift/pull/16694.diff","patch_url":"https://github.com/apple/swift/pull/16694.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16694","number":16694,"state":"closed","locked":false,"title":"[string] Skip allocation in reserveCapacity if smol","user":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\n\r\n[benchmark] Add reserveCapacity String benchmark to builder.\r\n\r\nAdd StringBuilderSmallReservingCapacity variant to measure the excess\r\noverhead caused by calls to reserve capacity. If a string is small,\r\nand the capacity is small, this will demonstrate overhead if an\r\nallocation happens.\r\n\r\n---\r\n\r\n\r\n[string] Skip allocation in reserveCapacity if smol\r\n\r\nIf the requested capacity is small enough to fit in our small string\r\nrepresentation, don't allocate a UTF-16 buffer, instead just return\r\nearly.\r\n\r\n","created_at":"2018-05-17T21:35:32Z","updated_at":"2018-05-19T16:02:31Z","closed_at":"2018-05-19T16:02:31Z","merged_at":"2018-05-19T16:02:31Z","merge_commit_sha":"ee899f0162393414d308cc6d917a7086e9d2dfff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16694/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16694/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16694/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1fe5fb717d88aebda9a834d02c6f8b45f3e0c246","head":{"label":"milseman:smol_reservations","ref":"smol_reservations","sha":"1fe5fb717d88aebda9a834d02c6f8b45f3e0c246","user":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"repo":{"id":49166817,"name":"swift","full_name":"milseman/swift","owner":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milseman/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/milseman/swift","forks_url":"https://api.github.com/repos/milseman/swift/forks","keys_url":"https://api.github.com/repos/milseman/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milseman/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milseman/swift/teams","hooks_url":"https://api.github.com/repos/milseman/swift/hooks","issue_events_url":"https://api.github.com/repos/milseman/swift/issues/events{/number}","events_url":"https://api.github.com/repos/milseman/swift/events","assignees_url":"https://api.github.com/repos/milseman/swift/assignees{/user}","branches_url":"https://api.github.com/repos/milseman/swift/branches{/branch}","tags_url":"https://api.github.com/repos/milseman/swift/tags","blobs_url":"https://api.github.com/repos/milseman/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milseman/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milseman/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/milseman/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milseman/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/milseman/swift/languages","stargazers_url":"https://api.github.com/repos/milseman/swift/stargazers","contributors_url":"https://api.github.com/repos/milseman/swift/contributors","subscribers_url":"https://api.github.com/repos/milseman/swift/subscribers","subscription_url":"https://api.github.com/repos/milseman/swift/subscription","commits_url":"https://api.github.com/repos/milseman/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/milseman/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/milseman/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/milseman/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/milseman/swift/contents/{+path}","compare_url":"https://api.github.com/repos/milseman/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milseman/swift/merges","archive_url":"https://api.github.com/repos/milseman/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milseman/swift/downloads","issues_url":"https://api.github.com/repos/milseman/swift/issues{/number}","pulls_url":"https://api.github.com/repos/milseman/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/milseman/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/milseman/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milseman/swift/labels{/name}","releases_url":"https://api.github.com/repos/milseman/swift/releases{/id}","deployments_url":"https://api.github.com/repos/milseman/swift/deployments","created_at":"2016-01-06T22:55:53Z","updated_at":"2017-08-14T22:06:25Z","pushed_at":"2018-05-19T04:31:24Z","git_url":"git://github.com/milseman/swift.git","ssh_url":"git@github.com:milseman/swift.git","clone_url":"https://github.com/milseman/swift.git","svn_url":"https://github.com/milseman/swift","homepage":"https://swift.org/","size":271221,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"8db33686226148ff5f2bb11fc8b3a21aeec36efd","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-05-19T10:14:00Z","pushed_at":"2018-05-19T16:02:31Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":290874,"stargazers_count":43873,"watchers_count":43873,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6912,"mirror_url":null,"archived":false,"open_issues_count":324,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6912,"open_issues":324,"watchers":43873,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16694"},"html":{"href":"https://github.com/apple/swift/pull/16694"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16694"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16694/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16694/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16694/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1fe5fb717d88aebda9a834d02c6f8b45f3e0c246"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"comments":10,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":34,"deletions":17,"changed_files":4}}
{"actor":{"display_login":"milseman"}}