{"action":"created","comment":{"url":"https://api.github.com/repos/propertybase/react-lds/pulls/comments/176058314","pull_request_review_id":105692418,"id":176058314,"diff_hunk":"@@ -61,9 +71,22 @@ const MenuDropdownListItem = (props) => {\n   // if selected true or false, it's a menuitemcheckbox, else it's a menuitem\n \n   return (\n-    <li {...rest} className={cx(sldsClasses)} role=\"presentation\">\n-      <a role={role} onClick={onClick} aria-checked={selected}>\n-        <span className=\"slds-truncate\" title={children}>\n+    <li\n+      className={cx(sldsClasses)}\n+      role=\"presentation\"\n+      onClick={onClick}\n+      {...rest}\n+    >\n+      <a\n+        aria-checked={selected}\n+        role={role}\n+        data-value={dataValue}","path":"src/components/Menu/MenuItem.js","position":41,"original_position":41,"commit_id":"89546e0fc95f3edda94d114d58cb06ec95ae7331","original_commit_id":"89546e0fc95f3edda94d114d58cb06ec95ae7331","user":{"login":"brunottonurb","id":6569792,"avatar_url":"https://avatars3.githubusercontent.com/u/6569792?v=4","gravatar_id":"","url":"https://api.github.com/users/brunottonurb","html_url":"https://github.com/brunottonurb","followers_url":"https://api.github.com/users/brunottonurb/followers","following_url":"https://api.github.com/users/brunottonurb/following{/other_user}","gists_url":"https://api.github.com/users/brunottonurb/gists{/gist_id}","starred_url":"https://api.github.com/users/brunottonurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunottonurb/subscriptions","organizations_url":"https://api.github.com/users/brunottonurb/orgs","repos_url":"https://api.github.com/users/brunottonurb/repos","events_url":"https://api.github.com/users/brunottonurb/events{/privacy}","received_events_url":"https://api.github.com/users/brunottonurb/received_events","type":"User","site_admin":false},"body":"It does not work with `data-value` on the `li` for some reason. Then `data-value` is always undefined in the event.","created_at":"2018-03-21T12:03:18Z","updated_at":"2018-03-21T12:03:18Z","html_url":"https://github.com/propertybase/react-lds/pull/293#discussion_r176058314","pull_request_url":"https://api.github.com/repos/propertybase/react-lds/pulls/293","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/propertybase/react-lds/pulls/comments/176058314"},"html":{"href":"https://github.com/propertybase/react-lds/pull/293#discussion_r176058314"},"pull_request":{"href":"https://api.github.com/repos/propertybase/react-lds/pulls/293"}},"in_reply_to_id":176015005},"pull_request":{"url":"https://api.github.com/repos/propertybase/react-lds/pulls/293","id":171899102,"html_url":"https://github.com/propertybase/react-lds/pull/293","diff_url":"https://github.com/propertybase/react-lds/pull/293.diff","patch_url":"https://github.com/propertybase/react-lds/pull/293.patch","issue_url":"https://api.github.com/repos/propertybase/react-lds/issues/293","number":293,"state":"open","locked":false,"title":"Rework menus #144","user":{"login":"brunottonurb","id":6569792,"avatar_url":"https://avatars3.githubusercontent.com/u/6569792?v=4","gravatar_id":"","url":"https://api.github.com/users/brunottonurb","html_url":"https://github.com/brunottonurb","followers_url":"https://api.github.com/users/brunottonurb/followers","following_url":"https://api.github.com/users/brunottonurb/following{/other_user}","gists_url":"https://api.github.com/users/brunottonurb/gists{/gist_id}","starred_url":"https://api.github.com/users/brunottonurb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunottonurb/subscriptions","organizations_url":"https://api.github.com/users/brunottonurb/orgs","repos_url":"https://api.github.com/users/brunottonurb/repos","events_url":"https://api.github.com/users/brunottonurb/events{/privacy}","received_events_url":"https://api.github.com/users/brunottonurb/received_events","type":"User","site_admin":false},"body":"- ~~Not sure about how to implement the single event listener per menu. It works, but I don't think it's good.~~\r\n- ~~I can't get the unit test to work on it: simulate('click') is not a function~~\r\n\r\n> Even though the name would imply this simulates an actual event, .simulate() will in fact target the component's prop based on the event you give it. For example, .simulate('click') will actually get the onClick prop and call it.\r\n\r\n- ~~ObjectHome still needs fixing with the new Menu~~","created_at":"2018-02-28T09:35:47Z","updated_at":"2018-03-21T12:03:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d56d67fa4fc7bf8cb951e552a78e01c3297ea82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":831627956,"url":"https://api.github.com/repos/propertybase/react-lds/labels/Status:%20Review%20Needed","name":"Status: Review Needed","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/propertybase/react-lds/pulls/293/commits","review_comments_url":"https://api.github.com/repos/propertybase/react-lds/pulls/293/comments","review_comment_url":"https://api.github.com/repos/propertybase/react-lds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/propertybase/react-lds/issues/293/comments","statuses_url":"https://api.github.com/repos/propertybase/react-lds/statuses/89546e0fc95f3edda94d114d58cb06ec95ae7331","head":{"label":"propertybase:rework-menus","ref":"rework-menus","sha":"89546e0fc95f3edda94d114d58cb06ec95ae7331","user":{"login":"propertybase","id":205216,"avatar_url":"https://avatars2.githubusercontent.com/u/205216?v=4","gravatar_id":"","url":"https://api.github.com/users/propertybase","html_url":"https://github.com/propertybase","followers_url":"https://api.github.com/users/propertybase/followers","following_url":"https://api.github.com/users/propertybase/following{/other_user}","gists_url":"https://api.github.com/users/propertybase/gists{/gist_id}","starred_url":"https://api.github.com/users/propertybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propertybase/subscriptions","organizations_url":"https://api.github.com/users/propertybase/orgs","repos_url":"https://api.github.com/users/propertybase/repos","events_url":"https://api.github.com/users/propertybase/events{/privacy}","received_events_url":"https://api.github.com/users/propertybase/received_events","type":"Organization","site_admin":false},"repo":{"id":60096098,"name":"react-lds","full_name":"propertybase/react-lds","owner":{"login":"propertybase","id":205216,"avatar_url":"https://avatars2.githubusercontent.com/u/205216?v=4","gravatar_id":"","url":"https://api.github.com/users/propertybase","html_url":"https://github.com/propertybase","followers_url":"https://api.github.com/users/propertybase/followers","following_url":"https://api.github.com/users/propertybase/following{/other_user}","gists_url":"https://api.github.com/users/propertybase/gists{/gist_id}","starred_url":"https://api.github.com/users/propertybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propertybase/subscriptions","organizations_url":"https://api.github.com/users/propertybase/orgs","repos_url":"https://api.github.com/users/propertybase/repos","events_url":"https://api.github.com/users/propertybase/events{/privacy}","received_events_url":"https://api.github.com/users/propertybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/propertybase/react-lds","description":"⚡ React components for the Salesforce Lightning Design System","fork":false,"url":"https://api.github.com/repos/propertybase/react-lds","forks_url":"https://api.github.com/repos/propertybase/react-lds/forks","keys_url":"https://api.github.com/repos/propertybase/react-lds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/propertybase/react-lds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/propertybase/react-lds/teams","hooks_url":"https://api.github.com/repos/propertybase/react-lds/hooks","issue_events_url":"https://api.github.com/repos/propertybase/react-lds/issues/events{/number}","events_url":"https://api.github.com/repos/propertybase/react-lds/events","assignees_url":"https://api.github.com/repos/propertybase/react-lds/assignees{/user}","branches_url":"https://api.github.com/repos/propertybase/react-lds/branches{/branch}","tags_url":"https://api.github.com/repos/propertybase/react-lds/tags","blobs_url":"https://api.github.com/repos/propertybase/react-lds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/propertybase/react-lds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/propertybase/react-lds/git/refs{/sha}","trees_url":"https://api.github.com/repos/propertybase/react-lds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/propertybase/react-lds/statuses/{sha}","languages_url":"https://api.github.com/repos/propertybase/react-lds/languages","stargazers_url":"https://api.github.com/repos/propertybase/react-lds/stargazers","contributors_url":"https://api.github.com/repos/propertybase/react-lds/contributors","subscribers_url":"https://api.github.com/repos/propertybase/react-lds/subscribers","subscription_url":"https://api.github.com/repos/propertybase/react-lds/subscription","commits_url":"https://api.github.com/repos/propertybase/react-lds/commits{/sha}","git_commits_url":"https://api.github.com/repos/propertybase/react-lds/git/commits{/sha}","comments_url":"https://api.github.com/repos/propertybase/react-lds/comments{/number}","issue_comment_url":"https://api.github.com/repos/propertybase/react-lds/issues/comments{/number}","contents_url":"https://api.github.com/repos/propertybase/react-lds/contents/{+path}","compare_url":"https://api.github.com/repos/propertybase/react-lds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/propertybase/react-lds/merges","archive_url":"https://api.github.com/repos/propertybase/react-lds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/propertybase/react-lds/downloads","issues_url":"https://api.github.com/repos/propertybase/react-lds/issues{/number}","pulls_url":"https://api.github.com/repos/propertybase/react-lds/pulls{/number}","milestones_url":"https://api.github.com/repos/propertybase/react-lds/milestones{/number}","notifications_url":"https://api.github.com/repos/propertybase/react-lds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/propertybase/react-lds/labels{/name}","releases_url":"https://api.github.com/repos/propertybase/react-lds/releases{/id}","deployments_url":"https://api.github.com/repos/propertybase/react-lds/deployments","created_at":"2016-05-31T14:22:12Z","updated_at":"2018-03-20T09:41:06Z","pushed_at":"2018-03-20T09:46:11Z","git_url":"git://github.com/propertybase/react-lds.git","ssh_url":"git@github.com:propertybase/react-lds.git","clone_url":"https://github.com/propertybase/react-lds.git","svn_url":"https://github.com/propertybase/react-lds","homepage":"https://propertybase.github.io/react-lds","size":5955,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":9,"watchers":16,"default_branch":"master"}},"base":{"label":"propertybase:master","ref":"master","sha":"92b1629430bbc34744e8ad195909116831a77eb1","user":{"login":"propertybase","id":205216,"avatar_url":"https://avatars2.githubusercontent.com/u/205216?v=4","gravatar_id":"","url":"https://api.github.com/users/propertybase","html_url":"https://github.com/propertybase","followers_url":"https://api.github.com/users/propertybase/followers","following_url":"https://api.github.com/users/propertybase/following{/other_user}","gists_url":"https://api.github.com/users/propertybase/gists{/gist_id}","starred_url":"https://api.github.com/users/propertybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propertybase/subscriptions","organizations_url":"https://api.github.com/users/propertybase/orgs","repos_url":"https://api.github.com/users/propertybase/repos","events_url":"https://api.github.com/users/propertybase/events{/privacy}","received_events_url":"https://api.github.com/users/propertybase/received_events","type":"Organization","site_admin":false},"repo":{"id":60096098,"name":"react-lds","full_name":"propertybase/react-lds","owner":{"login":"propertybase","id":205216,"avatar_url":"https://avatars2.githubusercontent.com/u/205216?v=4","gravatar_id":"","url":"https://api.github.com/users/propertybase","html_url":"https://github.com/propertybase","followers_url":"https://api.github.com/users/propertybase/followers","following_url":"https://api.github.com/users/propertybase/following{/other_user}","gists_url":"https://api.github.com/users/propertybase/gists{/gist_id}","starred_url":"https://api.github.com/users/propertybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/propertybase/subscriptions","organizations_url":"https://api.github.com/users/propertybase/orgs","repos_url":"https://api.github.com/users/propertybase/repos","events_url":"https://api.github.com/users/propertybase/events{/privacy}","received_events_url":"https://api.github.com/users/propertybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/propertybase/react-lds","description":"⚡ React components for the Salesforce Lightning Design System","fork":false,"url":"https://api.github.com/repos/propertybase/react-lds","forks_url":"https://api.github.com/repos/propertybase/react-lds/forks","keys_url":"https://api.github.com/repos/propertybase/react-lds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/propertybase/react-lds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/propertybase/react-lds/teams","hooks_url":"https://api.github.com/repos/propertybase/react-lds/hooks","issue_events_url":"https://api.github.com/repos/propertybase/react-lds/issues/events{/number}","events_url":"https://api.github.com/repos/propertybase/react-lds/events","assignees_url":"https://api.github.com/repos/propertybase/react-lds/assignees{/user}","branches_url":"https://api.github.com/repos/propertybase/react-lds/branches{/branch}","tags_url":"https://api.github.com/repos/propertybase/react-lds/tags","blobs_url":"https://api.github.com/repos/propertybase/react-lds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/propertybase/react-lds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/propertybase/react-lds/git/refs{/sha}","trees_url":"https://api.github.com/repos/propertybase/react-lds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/propertybase/react-lds/statuses/{sha}","languages_url":"https://api.github.com/repos/propertybase/react-lds/languages","stargazers_url":"https://api.github.com/repos/propertybase/react-lds/stargazers","contributors_url":"https://api.github.com/repos/propertybase/react-lds/contributors","subscribers_url":"https://api.github.com/repos/propertybase/react-lds/subscribers","subscription_url":"https://api.github.com/repos/propertybase/react-lds/subscription","commits_url":"https://api.github.com/repos/propertybase/react-lds/commits{/sha}","git_commits_url":"https://api.github.com/repos/propertybase/react-lds/git/commits{/sha}","comments_url":"https://api.github.com/repos/propertybase/react-lds/comments{/number}","issue_comment_url":"https://api.github.com/repos/propertybase/react-lds/issues/comments{/number}","contents_url":"https://api.github.com/repos/propertybase/react-lds/contents/{+path}","compare_url":"https://api.github.com/repos/propertybase/react-lds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/propertybase/react-lds/merges","archive_url":"https://api.github.com/repos/propertybase/react-lds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/propertybase/react-lds/downloads","issues_url":"https://api.github.com/repos/propertybase/react-lds/issues{/number}","pulls_url":"https://api.github.com/repos/propertybase/react-lds/pulls{/number}","milestones_url":"https://api.github.com/repos/propertybase/react-lds/milestones{/number}","notifications_url":"https://api.github.com/repos/propertybase/react-lds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/propertybase/react-lds/labels{/name}","releases_url":"https://api.github.com/repos/propertybase/react-lds/releases{/id}","deployments_url":"https://api.github.com/repos/propertybase/react-lds/deployments","created_at":"2016-05-31T14:22:12Z","updated_at":"2018-03-20T09:41:06Z","pushed_at":"2018-03-20T09:46:11Z","git_url":"git://github.com/propertybase/react-lds.git","ssh_url":"git@github.com:propertybase/react-lds.git","clone_url":"https://github.com/propertybase/react-lds.git","svn_url":"https://github.com/propertybase/react-lds","homepage":"https://propertybase.github.io/react-lds","size":5955,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":9,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/propertybase/react-lds/pulls/293"},"html":{"href":"https://github.com/propertybase/react-lds/pull/293"},"issue":{"href":"https://api.github.com/repos/propertybase/react-lds/issues/293"},"comments":{"href":"https://api.github.com/repos/propertybase/react-lds/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/propertybase/react-lds/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/propertybase/react-lds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/propertybase/react-lds/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/propertybase/react-lds/statuses/89546e0fc95f3edda94d114d58cb06ec95ae7331"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brunottonurb"}}