{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13247","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13247/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13247/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13247/events","html_url":"https://github.com/civicrm/civicrm-core/pull/13247","id":389062745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTU2MjMz","number":13247,"title":"(NFC) Fix PHP7.2 Count error on test testImportParserWtihEmployeeOfRelation…","user":{"login":"seamuslee001","id":6799125,"node_id":"MDQ6VXNlcjY3OTkxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false},{"id":275096971,"node_id":"MDU6TGFiZWwyNzUwOTY5NzE=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/merge%20on%20pass","name":"merge on pass","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-09T20:51:12Z","updated_at":"2018-12-09T23:06:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/13247","html_url":"https://github.com/civicrm/civicrm-core/pull/13247","diff_url":"https://github.com/civicrm/civicrm-core/pull/13247.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/13247.patch"},"body":"…ship\r\n\r\nOverview\r\n----------------------------------------\r\nThis fixes an error running the test suite on PHP7.2 \r\n\r\n```\r\n        <testcase name=\"testImportParserWtihEmployeeOfRelationship\" class=\"CRM_Contact_Import_Parser_ContactTest\" file=\"/home/jenkins/bknix-edge/build/dcmaster/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php\" line=\"54\" assertions=\"3\" time=\"0.217434\">\r\n          <error type=\"PHPUnit_Framework_Error_Warning\">CRM_Contact_Import_Parser_ContactTest::testImportParserWtihEmployeeOfRelationship\r\ncount(): Parameter must be an array or an object that implements Countable\r\n\r\n/home/jenkins/bknix-edge/build/dcmaster/sites/all/modules/civicrm/CRM/Contact/Import/Parser.php:375\r\n/home/jenkins/bknix-edge/build/dcmaster/sites/all/modules/civicrm/CRM/Contact/Import/Parser/Contact.php:199\r\n/home/jenkins/bknix-edge/build/dcmaster/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php:69\r\n/home/jenkins/bknix-edge/build/dcmaster/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:192\r\n/home/jenkins/bknix-edge/civicrm-buildkit/extern/phpunit5/phpunit5.phar:598\r\n</error>\r\n        </testcase>\r\n````\r\nBefore\r\n----------------------------------------\r\nTest failed on PHP7.2\r\n\r\nAfter\r\n----------------------------------------\r\nTest Passes on PHP7.2\r\n\r\nping @eileenmcnaughton @totten \r\n"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/445580690","html_url":"https://github.com/civicrm/civicrm-core/pull/13247#issuecomment-445580690","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/13247","id":445580690,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTU4MDY5MA==","user":{"login":"eileenmcnaughton","id":336308,"node_id":"MDQ6VXNlcjMzNjMwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"created_at":"2018-12-09T23:06:14Z","updated_at":"2018-12-09T23:06:14Z","author_association":"CONTRIBUTOR","body":"test this please"}}
{"actor":{"display_login":"eileenmcnaughton"}}