{"action":"created","comment":{"url":"https://api.github.com/repos/scalecube/scalecube-services/pulls/comments/206266373","pull_request_review_id":141648418,"id":206266373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjI2NjM3Mw==","diff_hunk":"@@ -97,16 +97,11 @@\n     <module>services</module>\n     <module>benchmarks</module>\n     <module>examples</module>\n+    <module>services-discovery</module>","path":"pom.xml","position":4,"original_position":4,"commit_id":"e4c7145816c22cdd840a57925c69933da4b2fd26","original_commit_id":"e4c7145816c22cdd840a57925c69933da4b2fd26","user":{"login":"ronenhamias","id":1706296,"node_id":"MDQ6VXNlcjE3MDYyOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1706296?v=4","gravatar_id":"","url":"https://api.github.com/users/ronenhamias","html_url":"https://github.com/ronenhamias","followers_url":"https://api.github.com/users/ronenhamias/followers","following_url":"https://api.github.com/users/ronenhamias/following{/other_user}","gists_url":"https://api.github.com/users/ronenhamias/gists{/gist_id}","starred_url":"https://api.github.com/users/ronenhamias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronenhamias/subscriptions","organizations_url":"https://api.github.com/users/ronenhamias/orgs","repos_url":"https://api.github.com/users/ronenhamias/repos","events_url":"https://api.github.com/users/ronenhamias/events{/privacy}","received_events_url":"https://api.github.com/users/ronenhamias/received_events","type":"User","site_admin":false},"body":"other modules called\r\n```\r\n <module>services-api</module>\r\n    <module>services-transport</module>\r\n    <module>services-codec</module>\r\n    <module>services-codec-jackson</module>\r\n```\r\n\r\ni guess this prefix make the discovery specific to services.","created_at":"2018-07-30T17:59:36Z","updated_at":"2018-07-30T17:59:36Z","html_url":"https://github.com/scalecube/scalecube-services/pull/223#discussion_r206266373","pull_request_url":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube-services/pulls/comments/206266373"},"html":{"href":"https://github.com/scalecube/scalecube-services/pull/223#discussion_r206266373"},"pull_request":{"href":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223"}},"in_reply_to_id":206097693},"pull_request":{"url":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223","id":204705860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzA1ODYw","html_url":"https://github.com/scalecube/scalecube-services/pull/223","diff_url":"https://github.com/scalecube/scalecube-services/pull/223.diff","patch_url":"https://github.com/scalecube/scalecube-services/pull/223.patch","issue_url":"https://api.github.com/repos/scalecube/scalecube-services/issues/223","number":223,"state":"open","locked":false,"title":"Decouple scalecube-cluster by applying discovery module","user":{"login":"ronenhamias","id":1706296,"node_id":"MDQ6VXNlcjE3MDYyOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1706296?v=4","gravatar_id":"","url":"https://api.github.com/users/ronenhamias","html_url":"https://github.com/ronenhamias","followers_url":"https://api.github.com/users/ronenhamias/followers","following_url":"https://api.github.com/users/ronenhamias/following{/other_user}","gists_url":"https://api.github.com/users/ronenhamias/gists{/gist_id}","starred_url":"https://api.github.com/users/ronenhamias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronenhamias/subscriptions","organizations_url":"https://api.github.com/users/ronenhamias/orgs","repos_url":"https://api.github.com/users/ronenhamias/repos","events_url":"https://api.github.com/users/ronenhamias/events{/privacy}","received_events_url":"https://api.github.com/users/ronenhamias/received_events","type":"User","site_admin":false},"body":"this pull request focus only on decouple service discovery from cluster by providing a model of discovery providers such as scalecube-cluster\r\n\r\n**Motivations:**\r\n1. Allow users to implement Discovery provider\r\n2. Provider a clear model for discovery behavior in scalecube services (mesh)\r\n3. Regulate the interaction model with discovery module.\r\n\r\n\r\n**The solution:**\r\n1. provide discovery api as part of service-api\r\n2. move discovery to separated module and load using ServiceLoader. \r\n3. implement scalecube-cluster as discovery provider.. \r\n\r\n#161","created_at":"2018-07-30T06:29:16Z","updated_at":"2018-07-30T17:59:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e8c8028bcf8ba3516120b706a7e10cbd0200412","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":923797589,"node_id":"MDU6TGFiZWw5MjM3OTc1ODk=","url":"https://api.github.com/repos/scalecube/scalecube-services/labels/ready%20for%20review","name":"ready for review","color":"3edd7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223/commits","review_comments_url":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223/comments","review_comment_url":"https://api.github.com/repos/scalecube/scalecube-services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalecube/scalecube-services/issues/223/comments","statuses_url":"https://api.github.com/repos/scalecube/scalecube-services/statuses/e4c7145816c22cdd840a57925c69933da4b2fd26","head":{"label":"scalecube:decouple_service_discovery_from_cluster","ref":"decouple_service_discovery_from_cluster","sha":"e4c7145816c22cdd840a57925c69933da4b2fd26","user":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":129196583,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxOTY1ODM=","name":"scalecube-services","full_name":"scalecube/scalecube-services","owner":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube-services","description":"v2.0 - ScaleCube Services provides a low latency Reactive Microservices library for serverless service registry and discovery based on gossip protocol and without single point-of-failure or bottlenecks.","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube-services","forks_url":"https://api.github.com/repos/scalecube/scalecube-services/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube-services/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube-services/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube-services/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube-services/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube-services/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube-services/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube-services/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube-services/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube-services/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube-services/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube-services/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube-services/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube-services/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube-services/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube-services/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube-services/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube-services/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube-services/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube-services/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube-services/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube-services/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube-services/deployments","created_at":"2018-04-12T05:11:43Z","updated_at":"2018-07-27T14:02:28Z","pushed_at":"2018-07-30T12:39:02Z","git_url":"git://github.com/scalecube/scalecube-services.git","ssh_url":"git@github.com:scalecube/scalecube-services.git","clone_url":"https://github.com/scalecube/scalecube-services.git","svn_url":"https://github.com/scalecube/scalecube-services","homepage":"http://scalecube.io/","size":2968,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":14,"watchers":12,"default_branch":"develop"}},"base":{"label":"scalecube:develop","ref":"develop","sha":"ad1b6732563cae941a7f63e928b4452a4ef19897","user":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":129196583,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxOTY1ODM=","name":"scalecube-services","full_name":"scalecube/scalecube-services","owner":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube-services","description":"v2.0 - ScaleCube Services provides a low latency Reactive Microservices library for serverless service registry and discovery based on gossip protocol and without single point-of-failure or bottlenecks.","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube-services","forks_url":"https://api.github.com/repos/scalecube/scalecube-services/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube-services/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube-services/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube-services/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube-services/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube-services/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube-services/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube-services/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube-services/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube-services/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube-services/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube-services/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube-services/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube-services/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube-services/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube-services/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube-services/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube-services/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube-services/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube-services/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube-services/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube-services/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube-services/deployments","created_at":"2018-04-12T05:11:43Z","updated_at":"2018-07-27T14:02:28Z","pushed_at":"2018-07-30T12:39:02Z","git_url":"git://github.com/scalecube/scalecube-services.git","ssh_url":"git@github.com:scalecube/scalecube-services.git","clone_url":"https://github.com/scalecube/scalecube-services.git","svn_url":"https://github.com/scalecube/scalecube-services","homepage":"http://scalecube.io/","size":2968,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":14,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223"},"html":{"href":"https://github.com/scalecube/scalecube-services/pull/223"},"issue":{"href":"https://api.github.com/repos/scalecube/scalecube-services/issues/223"},"comments":{"href":"https://api.github.com/repos/scalecube/scalecube-services/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/scalecube/scalecube-services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalecube/scalecube-services/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/scalecube/scalecube-services/statuses/e4c7145816c22cdd840a57925c69933da4b2fd26"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ronenhamias"}}