{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/actano/javascript/pulls/4","id":225004877,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MDA0ODc3","html_url":"https://github.com/actano/javascript/pull/4","diff_url":"https://github.com/actano/javascript/pull/4.diff","patch_url":"https://github.com/actano/javascript/pull/4.patch","issue_url":"https://api.github.com/repos/actano/javascript/issues/4","number":4,"state":"open","locked":false,"title":"Upgrade airbnb config and eslint 5","user":{"login":"hpurmann","id":1228437,"node_id":"MDQ6VXNlcjEyMjg0Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1228437?v=4","gravatar_id":"","url":"https://api.github.com/users/hpurmann","html_url":"https://github.com/hpurmann","followers_url":"https://api.github.com/users/hpurmann/followers","following_url":"https://api.github.com/users/hpurmann/following{/other_user}","gists_url":"https://api.github.com/users/hpurmann/gists{/gist_id}","starred_url":"https://api.github.com/users/hpurmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpurmann/subscriptions","organizations_url":"https://api.github.com/users/hpurmann/orgs","repos_url":"https://api.github.com/users/hpurmann/repos","events_url":"https://api.github.com/users/hpurmann/events{/privacy}","received_events_url":"https://api.github.com/users/hpurmann/received_events","type":"User","site_admin":false},"body":"This PR updates to the new version of `eslint-config-airbnb`. Additionally, ESLint 5 is supported.\r\nWhen reviewing the introduced rules / changes and running this against our biggest repository, I found two rules which we most likely don't want to adopt. Please follow the links to get examples to the rules.\r\n\r\n## Rules we most likely don't want to adopt\r\n### [`implicit-arrow-linebreak`](https://eslint.org/docs/rules/implicit-arrow-linebreak)\r\nForces us to write arrow function bodies without a line break. I think this is disruptive and unnecessary.\r\n\r\n### [`react/destructuring-assignment`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/destructuring-assignment.md)\r\nForces us to _always_ destructure `props` in React components. I think this is disruptive and unnecessary.\r\n\r\n## New / changed rules which we want to adopt\r\n\r\n### --fix able\r\n\r\n### [`operator-linebreak`](https://eslint.org/docs/rules/operator-linebreak)\r\nLinebreak after operators\r\n\r\n### [`object-curly-newline`](https://eslint.org/docs/rules/object-curly-newline)\r\nUse newline if object has >= 4 properties\r\n\r\n### non --fix able\r\n\r\n### [`import/named`]( https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/named.md)\r\nImports of dynamically created properties are forbidden.\r\n\r\n### [`react/button-has-type`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/button-has-type.md)\r\nButtons needs a type property\r\n\r\n### [`react/no-access-state-in-setstate`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-access-state-in-setstate.md)\r\nUse the callback syntax of `setState` to access the previous state\r\n\r\n### [`react/forbid-foreign-prop-types`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md)\r\nDon't access the prop types of a component, instead define them separately and use this definition in both places\r\n\r\n### [`jsx-a11y/label-has-for`](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md)\r\nRule is more strict now, but can be deactivated in special occasions.\r\n\r\n### [`react/require-default-props`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/require-default-props.md)\r\nEither define a `defaultProp` or make the prop `required` (XOR).\r\n\r\n### [`no-use-before-define`](https://eslint.org/docs/rules/no-use-before-define)\r\nDon't use variables and functions before they were defined, preventing `ReferenceError`\r\n\r\n### [`react/jsx-no-target-blank`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md)\r\nMalicious targets websites can modify the origin","created_at":"2018-10-23T11:43:50Z","updated_at":"2018-10-23T11:43:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/actano/javascript/pulls/4/commits","review_comments_url":"https://api.github.com/repos/actano/javascript/pulls/4/comments","review_comment_url":"https://api.github.com/repos/actano/javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/actano/javascript/issues/4/comments","statuses_url":"https://api.github.com/repos/actano/javascript/statuses/13432bfdbf41df91cf0b9b4ca2d8d7499ecfd144","head":{"label":"actano:eslint-5","ref":"eslint-5","sha":"13432bfdbf41df91cf0b9b4ca2d8d7499ecfd144","user":{"login":"actano","id":5420300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjAzMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5420300?v=4","gravatar_id":"","url":"https://api.github.com/users/actano","html_url":"https://github.com/actano","followers_url":"https://api.github.com/users/actano/followers","following_url":"https://api.github.com/users/actano/following{/other_user}","gists_url":"https://api.github.com/users/actano/gists{/gist_id}","starred_url":"https://api.github.com/users/actano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actano/subscriptions","organizations_url":"https://api.github.com/users/actano/orgs","repos_url":"https://api.github.com/users/actano/repos","events_url":"https://api.github.com/users/actano/events{/privacy}","received_events_url":"https://api.github.com/users/actano/received_events","type":"Organization","site_admin":false},"repo":{"id":59966534,"node_id":"MDEwOlJlcG9zaXRvcnk1OTk2NjUzNA==","name":"javascript","full_name":"actano/javascript","private":false,"owner":{"login":"actano","id":5420300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjAzMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5420300?v=4","gravatar_id":"","url":"https://api.github.com/users/actano","html_url":"https://github.com/actano","followers_url":"https://api.github.com/users/actano/followers","following_url":"https://api.github.com/users/actano/following{/other_user}","gists_url":"https://api.github.com/users/actano/gists{/gist_id}","starred_url":"https://api.github.com/users/actano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actano/subscriptions","organizations_url":"https://api.github.com/users/actano/orgs","repos_url":"https://api.github.com/users/actano/repos","events_url":"https://api.github.com/users/actano/events{/privacy}","received_events_url":"https://api.github.com/users/actano/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/actano/javascript","description":"Beautiful Javascript code at Actano","fork":false,"url":"https://api.github.com/repos/actano/javascript","forks_url":"https://api.github.com/repos/actano/javascript/forks","keys_url":"https://api.github.com/repos/actano/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actano/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actano/javascript/teams","hooks_url":"https://api.github.com/repos/actano/javascript/hooks","issue_events_url":"https://api.github.com/repos/actano/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/actano/javascript/events","assignees_url":"https://api.github.com/repos/actano/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/actano/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/actano/javascript/tags","blobs_url":"https://api.github.com/repos/actano/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actano/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actano/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/actano/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actano/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/actano/javascript/languages","stargazers_url":"https://api.github.com/repos/actano/javascript/stargazers","contributors_url":"https://api.github.com/repos/actano/javascript/contributors","subscribers_url":"https://api.github.com/repos/actano/javascript/subscribers","subscription_url":"https://api.github.com/repos/actano/javascript/subscription","commits_url":"https://api.github.com/repos/actano/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/actano/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/actano/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/actano/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/actano/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/actano/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actano/javascript/merges","archive_url":"https://api.github.com/repos/actano/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actano/javascript/downloads","issues_url":"https://api.github.com/repos/actano/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/actano/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/actano/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/actano/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actano/javascript/labels{/name}","releases_url":"https://api.github.com/repos/actano/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/actano/javascript/deployments","created_at":"2016-05-29T22:26:49Z","updated_at":"2018-08-09T15:34:34Z","pushed_at":"2018-10-23T11:09:47Z","git_url":"git://github.com/actano/javascript.git","ssh_url":"git@github.com:actano/javascript.git","clone_url":"https://github.com/actano/javascript.git","svn_url":"https://github.com/actano/javascript","homepage":null,"size":23,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"actano:master","ref":"master","sha":"3324a7d807de715faa952173391a3a7ed33fb81f","user":{"login":"actano","id":5420300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjAzMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5420300?v=4","gravatar_id":"","url":"https://api.github.com/users/actano","html_url":"https://github.com/actano","followers_url":"https://api.github.com/users/actano/followers","following_url":"https://api.github.com/users/actano/following{/other_user}","gists_url":"https://api.github.com/users/actano/gists{/gist_id}","starred_url":"https://api.github.com/users/actano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actano/subscriptions","organizations_url":"https://api.github.com/users/actano/orgs","repos_url":"https://api.github.com/users/actano/repos","events_url":"https://api.github.com/users/actano/events{/privacy}","received_events_url":"https://api.github.com/users/actano/received_events","type":"Organization","site_admin":false},"repo":{"id":59966534,"node_id":"MDEwOlJlcG9zaXRvcnk1OTk2NjUzNA==","name":"javascript","full_name":"actano/javascript","private":false,"owner":{"login":"actano","id":5420300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjAzMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5420300?v=4","gravatar_id":"","url":"https://api.github.com/users/actano","html_url":"https://github.com/actano","followers_url":"https://api.github.com/users/actano/followers","following_url":"https://api.github.com/users/actano/following{/other_user}","gists_url":"https://api.github.com/users/actano/gists{/gist_id}","starred_url":"https://api.github.com/users/actano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actano/subscriptions","organizations_url":"https://api.github.com/users/actano/orgs","repos_url":"https://api.github.com/users/actano/repos","events_url":"https://api.github.com/users/actano/events{/privacy}","received_events_url":"https://api.github.com/users/actano/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/actano/javascript","description":"Beautiful Javascript code at Actano","fork":false,"url":"https://api.github.com/repos/actano/javascript","forks_url":"https://api.github.com/repos/actano/javascript/forks","keys_url":"https://api.github.com/repos/actano/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actano/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actano/javascript/teams","hooks_url":"https://api.github.com/repos/actano/javascript/hooks","issue_events_url":"https://api.github.com/repos/actano/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/actano/javascript/events","assignees_url":"https://api.github.com/repos/actano/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/actano/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/actano/javascript/tags","blobs_url":"https://api.github.com/repos/actano/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actano/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actano/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/actano/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actano/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/actano/javascript/languages","stargazers_url":"https://api.github.com/repos/actano/javascript/stargazers","contributors_url":"https://api.github.com/repos/actano/javascript/contributors","subscribers_url":"https://api.github.com/repos/actano/javascript/subscribers","subscription_url":"https://api.github.com/repos/actano/javascript/subscription","commits_url":"https://api.github.com/repos/actano/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/actano/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/actano/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/actano/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/actano/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/actano/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actano/javascript/merges","archive_url":"https://api.github.com/repos/actano/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actano/javascript/downloads","issues_url":"https://api.github.com/repos/actano/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/actano/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/actano/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/actano/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actano/javascript/labels{/name}","releases_url":"https://api.github.com/repos/actano/javascript/releases{/id}","deployments_url":"https://api.github.com/repos/actano/javascript/deployments","created_at":"2016-05-29T22:26:49Z","updated_at":"2018-08-09T15:34:34Z","pushed_at":"2018-10-23T11:09:47Z","git_url":"git://github.com/actano/javascript.git","ssh_url":"git@github.com:actano/javascript.git","clone_url":"https://github.com/actano/javascript.git","svn_url":"https://github.com/actano/javascript","homepage":null,"size":23,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/actano/javascript/pulls/4"},"html":{"href":"https://github.com/actano/javascript/pull/4"},"issue":{"href":"https://api.github.com/repos/actano/javascript/issues/4"},"comments":{"href":"https://api.github.com/repos/actano/javascript/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/actano/javascript/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/actano/javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/actano/javascript/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/actano/javascript/statuses/13432bfdbf41df91cf0b9b4ca2d8d7499ecfd144"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":10,"changed_files":4}}
{"actor":{"display_login":"hpurmann"}}