{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/186006477","pull_request_review_id":117512220,"id":186006477,"diff_hunk":"@@ -30,23 +30,26 @@ target_include_directories(omr_example_base\n \t\tglue\n )\n \n-add_executable(example\n-\tmain.cpp\n-)\n-\n-target_link_libraries(example\n-\tomr_main_function\n-\tpugixml\n-\tomrcore\n-\t${OMR_HOOK_LIB}\n-\t${OMR_TRACE_LIB}\n-\t${OMR_GC_LIB}\n-\t${OMR_THREAD_LIB}\n-\t${OMR_PORT_LIB}\n-)\n-\n-# TODO: The example is currently broken.\n-# Hashtable iteration appears to be broken, which in turn breaks root marking, and causes the example to spin forever.\n-# add_test(example example)\n+# The current implementation of the example depends on the ${OMR_GC_LIB} library\n+# and is not able to be compiled without a GC implementation.\n+if(OMR_GC)","path":"example/CMakeLists.txt","position":null,"original_position":24,"commit_id":"8a2ac791feea6f0b743522bd796e0cc58d8f7db8","original_commit_id":"a878378962caccab3c06e2aa3d7170b3ab1fd721","user":{"login":"samolisov","id":134115,"avatar_url":"https://avatars3.githubusercontent.com/u/134115?v=4","gravatar_id":"","url":"https://api.github.com/users/samolisov","html_url":"https://github.com/samolisov","followers_url":"https://api.github.com/users/samolisov/followers","following_url":"https://api.github.com/users/samolisov/following{/other_user}","gists_url":"https://api.github.com/users/samolisov/gists{/gist_id}","starred_url":"https://api.github.com/users/samolisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samolisov/subscriptions","organizations_url":"https://api.github.com/users/samolisov/orgs","repos_url":"https://api.github.com/users/samolisov/repos","events_url":"https://api.github.com/users/samolisov/events{/privacy}","received_events_url":"https://api.github.com/users/samolisov/received_events","type":"User","site_admin":false},"body":"OK, I've changed the `example` executable to `gcexample` one. So, if we wish to add another example, for jitbuilder, we should add a new executable to `CMakeLists.txt`:\r\n\r\n```cmake\r\nif(OMR_GC)\r\n\tadd_executable(gcexample\r\n\t\tgcmain.cpp\r\n\t)\r\n\r\n     ...\r\nendif(OMR_GC)\r\n...\r\nif(OMR_JITBUILDER)\r\n\tadd_executable(jitexample\r\n\t\tjitmain.cpp\r\n\t)\r\n\r\n     ...\r\nendif(OMR_JITBUILDER)\r\n...\r\n```\r\n\r\n(I see the makefile now includes all .cpp files from the example folder to build the `omrgcexample` module, so the idea is also implemented for autoconf but when new examples are added, the makefile should be modified).\r\n\r\nI'm not sure should we maintain the `example` test here or the test must be moved to `fvtest` where the other tests are?\r\n","created_at":"2018-05-04T07:30:22Z","updated_at":"2018-05-04T07:30:23Z","html_url":"https://github.com/eclipse/omr/pull/2523#discussion_r186006477","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/2523","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/186006477"},"html":{"href":"https://github.com/eclipse/omr/pull/2523#discussion_r186006477"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2523"}},"in_reply_to_id":185829516},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2523","id":185641011,"html_url":"https://github.com/eclipse/omr/pull/2523","diff_url":"https://github.com/eclipse/omr/pull/2523.diff","patch_url":"https://github.com/eclipse/omr/pull/2523.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2523","number":2523,"state":"open","locked":false,"title":"CMake: untie fvtest from GC","user":{"login":"samolisov","id":134115,"avatar_url":"https://avatars3.githubusercontent.com/u/134115?v=4","gravatar_id":"","url":"https://api.github.com/users/samolisov","html_url":"https://github.com/samolisov","followers_url":"https://api.github.com/users/samolisov/followers","following_url":"https://api.github.com/users/samolisov/following{/other_user}","gists_url":"https://api.github.com/users/samolisov/gists{/gist_id}","starred_url":"https://api.github.com/users/samolisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samolisov/subscriptions","organizations_url":"https://api.github.com/users/samolisov/orgs","repos_url":"https://api.github.com/users/samolisov/repos","events_url":"https://api.github.com/users/samolisov/events{/privacy}","received_events_url":"https://api.github.com/users/samolisov/received_events","type":"User","site_admin":false},"body":"CMake: build fvtest without omrgc\r\n\r\nThe following problems related to build fvtest without omrgc (`OMR_FVTEST=ON OMR_GC=OFF`) were solved:\r\n\r\n * `${OMR_GC_LIB}` was removed from all fvtest targets (except the\r\n     omrgctest one): omrcore is linked against omrgc if omrgc is enabled.\r\n\r\n * omrcore is linked against the `${OMR_CORE_GLUE_TARGET}` and\r\n     `${OMR_RAS_GLUE_TARGET}` libraries.\r\n\r\n * omrcore is linked against `${OMR_TRACE_LIB}` and `${OMR_HOOK_LIB}`, these libraries are removed \r\n    from targets where they explicitly appear.\r\n\r\nAlso, the assert on `OMR_EXAMPLE` is removed: if a custom glue library is defined and appropriate values are assigned for the `OMR_GC_GLUE_TARGET`, `OMR_UTIL_GLUE_TARGET`, `OMR_RAS_GLUE_TARGET` and `OMR_CORE_GLUE_TARGET` variables, all fvtest components will be built without errors.\r\n\r\nCloses: #2481\r\nSigned-off-by: Pavel Samolysov <samolisov@gmail.com>\r\n","created_at":"2018-05-03T08:01:26Z","updated_at":"2018-05-04T07:30:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6225fb714f59502242d89efc9622eaa01c2d701a","assignee":{"login":"charliegracie","id":15161849,"avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false},"assignees":[{"login":"charliegracie","id":15161849,"avatar_url":"https://avatars3.githubusercontent.com/u/15161849?v=4","gravatar_id":"","url":"https://api.github.com/users/charliegracie","html_url":"https://github.com/charliegracie","followers_url":"https://api.github.com/users/charliegracie/followers","following_url":"https://api.github.com/users/charliegracie/following{/other_user}","gists_url":"https://api.github.com/users/charliegracie/gists{/gist_id}","starred_url":"https://api.github.com/users/charliegracie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charliegracie/subscriptions","organizations_url":"https://api.github.com/users/charliegracie/orgs","repos_url":"https://api.github.com/users/charliegracie/repos","events_url":"https://api.github.com/users/charliegracie/events{/privacy}","received_events_url":"https://api.github.com/users/charliegracie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":650663178,"url":"https://api.github.com/repos/eclipse/omr/labels/cmake","name":"cmake","color":"ff087f","default":false},{"id":463261367,"url":"https://api.github.com/repos/eclipse/omr/labels/gc","name":"gc","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/2523/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/2523/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2523/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/8a2ac791feea6f0b743522bd796e0cc58d8f7db8","head":{"label":"samolisov:untie-fvtest-from-gc","ref":"untie-fvtest-from-gc","sha":"8a2ac791feea6f0b743522bd796e0cc58d8f7db8","user":{"login":"samolisov","id":134115,"avatar_url":"https://avatars3.githubusercontent.com/u/134115?v=4","gravatar_id":"","url":"https://api.github.com/users/samolisov","html_url":"https://github.com/samolisov","followers_url":"https://api.github.com/users/samolisov/followers","following_url":"https://api.github.com/users/samolisov/following{/other_user}","gists_url":"https://api.github.com/users/samolisov/gists{/gist_id}","starred_url":"https://api.github.com/users/samolisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samolisov/subscriptions","organizations_url":"https://api.github.com/users/samolisov/orgs","repos_url":"https://api.github.com/users/samolisov/repos","events_url":"https://api.github.com/users/samolisov/events{/privacy}","received_events_url":"https://api.github.com/users/samolisov/received_events","type":"User","site_admin":false},"repo":{"id":125512151,"name":"omr","full_name":"samolisov/omr","owner":{"login":"samolisov","id":134115,"avatar_url":"https://avatars3.githubusercontent.com/u/134115?v=4","gravatar_id":"","url":"https://api.github.com/users/samolisov","html_url":"https://github.com/samolisov","followers_url":"https://api.github.com/users/samolisov/followers","following_url":"https://api.github.com/users/samolisov/following{/other_user}","gists_url":"https://api.github.com/users/samolisov/gists{/gist_id}","starred_url":"https://api.github.com/users/samolisov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samolisov/subscriptions","organizations_url":"https://api.github.com/users/samolisov/orgs","repos_url":"https://api.github.com/users/samolisov/repos","events_url":"https://api.github.com/users/samolisov/events{/privacy}","received_events_url":"https://api.github.com/users/samolisov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samolisov/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/samolisov/omr","forks_url":"https://api.github.com/repos/samolisov/omr/forks","keys_url":"https://api.github.com/repos/samolisov/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samolisov/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samolisov/omr/teams","hooks_url":"https://api.github.com/repos/samolisov/omr/hooks","issue_events_url":"https://api.github.com/repos/samolisov/omr/issues/events{/number}","events_url":"https://api.github.com/repos/samolisov/omr/events","assignees_url":"https://api.github.com/repos/samolisov/omr/assignees{/user}","branches_url":"https://api.github.com/repos/samolisov/omr/branches{/branch}","tags_url":"https://api.github.com/repos/samolisov/omr/tags","blobs_url":"https://api.github.com/repos/samolisov/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samolisov/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samolisov/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/samolisov/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samolisov/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/samolisov/omr/languages","stargazers_url":"https://api.github.com/repos/samolisov/omr/stargazers","contributors_url":"https://api.github.com/repos/samolisov/omr/contributors","subscribers_url":"https://api.github.com/repos/samolisov/omr/subscribers","subscription_url":"https://api.github.com/repos/samolisov/omr/subscription","commits_url":"https://api.github.com/repos/samolisov/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/samolisov/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/samolisov/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/samolisov/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/samolisov/omr/contents/{+path}","compare_url":"https://api.github.com/repos/samolisov/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samolisov/omr/merges","archive_url":"https://api.github.com/repos/samolisov/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samolisov/omr/downloads","issues_url":"https://api.github.com/repos/samolisov/omr/issues{/number}","pulls_url":"https://api.github.com/repos/samolisov/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/samolisov/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/samolisov/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samolisov/omr/labels{/name}","releases_url":"https://api.github.com/repos/samolisov/omr/releases{/id}","deployments_url":"https://api.github.com/repos/samolisov/omr/deployments","created_at":"2018-03-16T12:16:30Z","updated_at":"2018-03-16T12:16:40Z","pushed_at":"2018-05-04T07:30:19Z","git_url":"git://github.com/samolisov/omr.git","ssh_url":"git@github.com:samolisov/omr.git","clone_url":"https://github.com/samolisov/omr.git","svn_url":"https://github.com/samolisov/omr","homepage":"http://www.eclipse.org/omr","size":23953,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"5626c6035498aafaf93cd1cc89862fcf776835c5","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-05-03T15:01:11Z","pushed_at":"2018-05-04T07:30:20Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":23894,"stargazers_count":478,"watchers_count":478,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":430,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":212,"open_issues":430,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2523"},"html":{"href":"https://github.com/eclipse/omr/pull/2523"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/2523"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/2523/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2523/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2523/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/8a2ac791feea6f0b743522bd796e0cc58d8f7db8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samolisov"}}