{"action":"created","issue":{"url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/1078","repository_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/1078/labels{/name}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/1078/comments","events_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/1078/events","html_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/1078","id":312649494,"number":1078,"title":"Remove scroll:auto on oncoprint because it is causing various problem…","user":{"login":"alisman","id":186521,"avatar_url":"https://avatars2.githubusercontent.com/u/186521?v=4","gravatar_id":"","url":"https://api.github.com/users/alisman","html_url":"https://github.com/alisman","followers_url":"https://api.github.com/users/alisman/followers","following_url":"https://api.github.com/users/alisman/following{/other_user}","gists_url":"https://api.github.com/users/alisman/gists{/gist_id}","starred_url":"https://api.github.com/users/alisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisman/subscriptions","organizations_url":"https://api.github.com/users/alisman/orgs","repos_url":"https://api.github.com/users/alisman/repos","events_url":"https://api.github.com/users/alisman/events{/privacy}","received_events_url":"https://api.github.com/users/alisman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-09T19:06:16Z","updated_at":"2018-04-09T19:14:31Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/pulls/1078","html_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/1078","diff_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/1078.diff","patch_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/1078.patch"},"body":"I made a change to oncoprint css to hide scrollbars when they were not needed (no overflow).  This caused various problems in different browsers so I am reverting the cosmetic change.\r\n\r\n# What? Why?\r\nFix # .\r\n\r\nChanges proposed in this pull request:\r\n- a\r\n- b\r\n\r\n# Checks\r\n- [ ] Is this PR adding logic based on one or more **clinical** attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in [File-Formats Clinical data section](https://github.com/cBioPortal/cbioportal/blob/master/docs/File-Formats.md#clinical-data)!\r\n- [ ] Follows [7 rules of great commit messages](http://chris.beams.io/posts/git-commit/). For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid [merge commits, use rebase instead.](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [ ] Follows the [Airbnb React/JSX Style guide](https://github.com/airbnb/javascript/tree/master/react).\r\n- [ ] Make sure your commit messages end with a Signed-off-by string (this line\r\n  can be automatically added by git if you run the `git-commit` command with\r\n  the `-s` option)\r\n\r\n# Any screenshots or GIFs?\r\nIf this is a new visual feature please add a before/after screenshot or gif\r\nhere with e.g. [GifGrabber](http://www.gifgrabber.com/).\r\n\r\n# Notify reviewers\r\nRead our [Pull request merging\r\npolicy](../CONTRIBUTING.md#pull-request-merging-policy). If you are part of the\r\ncBioPortal organization, notify the approprate team (remove inappropriate):\r\n\r\n@cBioPortal/frontend\r\n\r\nIf you are not part of the cBioPortal organization look at who worked on the\r\nfile before you. Please use `git blame <filename>` to determine that\r\nand notify them here:\r\n"},"comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/comments/379862435","html_url":"https://github.com/cBioPortal/cbioportal-frontend/pull/1078#issuecomment-379862435","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal-frontend/issues/1078","id":379862435,"user":{"login":"adamabeshouse","id":636232,"avatar_url":"https://avatars1.githubusercontent.com/u/636232?v=4","gravatar_id":"","url":"https://api.github.com/users/adamabeshouse","html_url":"https://github.com/adamabeshouse","followers_url":"https://api.github.com/users/adamabeshouse/followers","following_url":"https://api.github.com/users/adamabeshouse/following{/other_user}","gists_url":"https://api.github.com/users/adamabeshouse/gists{/gist_id}","starred_url":"https://api.github.com/users/adamabeshouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamabeshouse/subscriptions","organizations_url":"https://api.github.com/users/adamabeshouse/orgs","repos_url":"https://api.github.com/users/adamabeshouse/repos","events_url":"https://api.github.com/users/adamabeshouse/events{/privacy}","received_events_url":"https://api.github.com/users/adamabeshouse/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T19:14:31Z","updated_at":"2018-04-09T19:14:31Z","author_association":"CONTRIBUTOR","body":"I cant find it now but, wont this bring back the issue you were fixing, with the vertical scrollbar not appearing or something like that?"}}
{"actor":{"display_login":"adamabeshouse"}}