{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments/172631360","pull_request_review_id":101681932,"id":172631360,"diff_hunk":"@@ -67,6 +67,7 @@ update_uboot_env()\n \n     (cat <<EOF\n onie_boot_reason\n+onie_nos_mode","path":"installer/u-boot-arch/install-arch","position":12,"original_position":12,"commit_id":"10cfd9e3c64c837ab1ebe408e662a10069d360fb","original_commit_id":"10cfd9e3c64c837ab1ebe408e662a10069d360fb","user":{"login":"cbrune","id":344659,"avatar_url":"https://avatars2.githubusercontent.com/u/344659?v=4","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"body":"good point.","created_at":"2018-03-06T19:25:30Z","updated_at":"2018-03-06T19:25:30Z","html_url":"https://github.com/opencomputeproject/onie/pull/706#discussion_r172631360","pull_request_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/706","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments/172631360"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/706#discussion_r172631360"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/706"}},"in_reply_to_id":172398290},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/706","id":172622240,"html_url":"https://github.com/opencomputeproject/onie/pull/706","diff_url":"https://github.com/opencomputeproject/onie/pull/706.diff","patch_url":"https://github.com/opencomputeproject/onie/pull/706.patch","issue_url":"https://api.github.com/repos/opencomputeproject/onie/issues/706","number":706,"state":"open","locked":false,"title":"NOS installed mode","user":{"login":"cbrune","id":344659,"avatar_url":"https://avatars2.githubusercontent.com/u/344659?v=4","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"body":"    This patch adds the notion of \"NOS installed\" mode.  This persistent\r\n    state is set to true after a successful NOS install.\r\n    \r\n    This patch changes the following behavior for all CPU architectures:\r\n    \r\n    1. Upon a successful NOS install, the system sets a persistent\r\n       environment variable, onie_nos_mode, to \"yes\".\r\n    \r\n    2. When onie_nos_mode is 'yes', entering install mode is no longer\r\n       sticky. I.e. entering install mode is no longer a one-way trap\r\n       door.\r\n    \r\n    Furthermore, for GRUB architectures, the default GRUB menu item now\r\n    defaults to \"rescue\" mode, instead of \"install\" mode.\r\n    \r\n    For GRUB architectures, this patch adds an \"-n\" option to the\r\n    \"onie-boot-mode\" command to set the persistent NOS installed boot\r\n    mode.  The NOS mode is consulted when no default boot mode is set.\r\n    \r\n    The default GRUB boot entry is now controlled by two persistent grub\r\n    environment variables, \"onie_mode\" and \"onie_nos_mode\".\r\n    \r\n    Previously, only the onie_mode variable existed.  Its usage is\r\n    unchanged by this commit.  If onie_mode is set, it controls which GRUB\r\n    menu to load by default.\r\n    \r\n    If onie_mode is clear, then the new variable, 'onie_nos_mode', is\r\n    consulted.  If onie_nos_mode is \"yes\", then the GRUB menu will default\r\n    to \"rescue\" mode.\r\n    \r\n    If both onie_mode and onie_nos_mode are clear then the default GRUB\r\n    menu is \"install mode\".\r\n    \r\n    The idea here is make the default GRUB menu item and the \"install\"\r\n    mode more forgiving when a NOS is installed.\r\n","created_at":"2018-03-02T22:39:31Z","updated_at":"2018-03-06T19:25:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f80a6d69752f918fbaccb6c395c714d0ed682ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/706/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/706/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/issues/706/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/10cfd9e3c64c837ab1ebe408e662a10069d360fb","head":{"label":"cbrune:nos-mode","ref":"nos-mode","sha":"10cfd9e3c64c837ab1ebe408e662a10069d360fb","user":{"login":"cbrune","id":344659,"avatar_url":"https://avatars2.githubusercontent.com/u/344659?v=4","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"repo":{"id":22216675,"name":"onie","full_name":"cbrune/onie","owner":{"login":"cbrune","id":344659,"avatar_url":"https://avatars2.githubusercontent.com/u/344659?v=4","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbrune/onie","description":"This is the code repository for ONIE.","fork":true,"url":"https://api.github.com/repos/cbrune/onie","forks_url":"https://api.github.com/repos/cbrune/onie/forks","keys_url":"https://api.github.com/repos/cbrune/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbrune/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbrune/onie/teams","hooks_url":"https://api.github.com/repos/cbrune/onie/hooks","issue_events_url":"https://api.github.com/repos/cbrune/onie/issues/events{/number}","events_url":"https://api.github.com/repos/cbrune/onie/events","assignees_url":"https://api.github.com/repos/cbrune/onie/assignees{/user}","branches_url":"https://api.github.com/repos/cbrune/onie/branches{/branch}","tags_url":"https://api.github.com/repos/cbrune/onie/tags","blobs_url":"https://api.github.com/repos/cbrune/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbrune/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbrune/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbrune/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbrune/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/cbrune/onie/languages","stargazers_url":"https://api.github.com/repos/cbrune/onie/stargazers","contributors_url":"https://api.github.com/repos/cbrune/onie/contributors","subscribers_url":"https://api.github.com/repos/cbrune/onie/subscribers","subscription_url":"https://api.github.com/repos/cbrune/onie/subscription","commits_url":"https://api.github.com/repos/cbrune/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbrune/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbrune/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbrune/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbrune/onie/contents/{+path}","compare_url":"https://api.github.com/repos/cbrune/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbrune/onie/merges","archive_url":"https://api.github.com/repos/cbrune/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbrune/onie/downloads","issues_url":"https://api.github.com/repos/cbrune/onie/issues{/number}","pulls_url":"https://api.github.com/repos/cbrune/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/cbrune/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/cbrune/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbrune/onie/labels{/name}","releases_url":"https://api.github.com/repos/cbrune/onie/releases{/id}","deployments_url":"https://api.github.com/repos/cbrune/onie/deployments","created_at":"2014-07-24T14:45:13Z","updated_at":"2016-01-12T03:30:58Z","pushed_at":"2018-03-02T22:37:45Z","git_url":"git://github.com/cbrune/onie.git","ssh_url":"git@github.com:cbrune/onie.git","clone_url":"https://github.com/cbrune/onie.git","svn_url":"https://github.com/cbrune/onie","homepage":null,"size":108989,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"4996cd7ac603580a9eef89908b418a5f1d8c62ca","user":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars0.githubusercontent.com/u/16659405?v=4","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":21219871,"name":"onie","full_name":"opencomputeproject/onie","owner":{"login":"opencomputeproject","id":16659405,"avatar_url":"https://avatars0.githubusercontent.com/u/16659405?v=4","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/onie","description":"Open Network Install Environment","fork":false,"url":"https://api.github.com/repos/opencomputeproject/onie","forks_url":"https://api.github.com/repos/opencomputeproject/onie/forks","keys_url":"https://api.github.com/repos/opencomputeproject/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/onie/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/onie/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/onie/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/onie/events","assignees_url":"https://api.github.com/repos/opencomputeproject/onie/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/onie/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/onie/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/onie/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/onie/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/onie/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/onie/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/onie/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/onie/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/onie/merges","archive_url":"https://api.github.com/repos/opencomputeproject/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/onie/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/onie/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/onie/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/onie/releases{/id}","deployments_url":"https://api.github.com/repos/opencomputeproject/onie/deployments","created_at":"2014-06-25T21:52:35Z","updated_at":"2018-03-05T20:43:55Z","pushed_at":"2018-03-02T22:39:32Z","git_url":"git://github.com/opencomputeproject/onie.git","ssh_url":"git@github.com:opencomputeproject/onie.git","clone_url":"https://github.com/opencomputeproject/onie.git","svn_url":"https://github.com/opencomputeproject/onie","homepage":"https://opencomputeproject.github.io/onie","size":112117,"stargazers_count":238,"watchers_count":238,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":165,"open_issues":46,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/706"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/706"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/706"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/onie/statuses/10cfd9e3c64c837ab1ebe408e662a10069d360fb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cbrune"}}