{"action":"closed","number":235,"pull_request":{"url":"https://api.github.com/repos/nodejs/node-core-utils/pulls/235","id":181531502,"html_url":"https://github.com/nodejs/node-core-utils/pull/235","diff_url":"https://github.com/nodejs/node-core-utils/pull/235.diff","patch_url":"https://github.com/nodejs/node-core-utils/pull/235.patch","issue_url":"https://api.github.com/repos/nodejs/node-core-utils/issues/235","number":235,"state":"closed","locked":false,"title":"feat: merge update-v8 in the project","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"body":"Moving my code from https://github.com/targos/update-v8\r\n\r\nI tried to do it with minimal code changes:\r\n* Switched CLI arguments parser to `yargs`\r\n* Changed the backport command from `update-v8 backport --sha=xxx` to `update-v8 backport xxx` because this option has always been mandatory\r\n* Restructured the documentation a bit\r\n* Did not bring all the gypfiles because they were only necessary to do the update to V8 6.6 (and that update landed on Node master)\r\n\r\nFixes: https://github.com/nodejs/node-core-utils/issues/234","created_at":"2018-04-13T16:04:10Z","updated_at":"2018-04-19T06:56:12Z","closed_at":"2018-04-19T06:56:12Z","merged_at":"2018-04-19T06:56:12Z","merge_commit_sha":"969987be85385336a89aa71e229dd2ed3f72635e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node-core-utils/pulls/235/commits","review_comments_url":"https://api.github.com/repos/nodejs/node-core-utils/pulls/235/comments","review_comment_url":"https://api.github.com/repos/nodejs/node-core-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node-core-utils/issues/235/comments","statuses_url":"https://api.github.com/repos/nodejs/node-core-utils/statuses/d12fd207ccab4924c4a77a6d7bd8d0dee4824aea","head":{"label":"targos:update-v8","ref":"update-v8","sha":"d12fd207ccab4924c4a77a6d7bd8d0dee4824aea","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"repo":{"id":109008507,"name":"node-core-utils","full_name":"targos/node-core-utils","owner":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/targos/node-core-utils","description":"CLI tools for Node.js Core collaborators","fork":true,"url":"https://api.github.com/repos/targos/node-core-utils","forks_url":"https://api.github.com/repos/targos/node-core-utils/forks","keys_url":"https://api.github.com/repos/targos/node-core-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/targos/node-core-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/targos/node-core-utils/teams","hooks_url":"https://api.github.com/repos/targos/node-core-utils/hooks","issue_events_url":"https://api.github.com/repos/targos/node-core-utils/issues/events{/number}","events_url":"https://api.github.com/repos/targos/node-core-utils/events","assignees_url":"https://api.github.com/repos/targos/node-core-utils/assignees{/user}","branches_url":"https://api.github.com/repos/targos/node-core-utils/branches{/branch}","tags_url":"https://api.github.com/repos/targos/node-core-utils/tags","blobs_url":"https://api.github.com/repos/targos/node-core-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/targos/node-core-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/targos/node-core-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/targos/node-core-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/targos/node-core-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/targos/node-core-utils/languages","stargazers_url":"https://api.github.com/repos/targos/node-core-utils/stargazers","contributors_url":"https://api.github.com/repos/targos/node-core-utils/contributors","subscribers_url":"https://api.github.com/repos/targos/node-core-utils/subscribers","subscription_url":"https://api.github.com/repos/targos/node-core-utils/subscription","commits_url":"https://api.github.com/repos/targos/node-core-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/targos/node-core-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/targos/node-core-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/targos/node-core-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/targos/node-core-utils/contents/{+path}","compare_url":"https://api.github.com/repos/targos/node-core-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/targos/node-core-utils/merges","archive_url":"https://api.github.com/repos/targos/node-core-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/targos/node-core-utils/downloads","issues_url":"https://api.github.com/repos/targos/node-core-utils/issues{/number}","pulls_url":"https://api.github.com/repos/targos/node-core-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/targos/node-core-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/targos/node-core-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/targos/node-core-utils/labels{/name}","releases_url":"https://api.github.com/repos/targos/node-core-utils/releases{/id}","deployments_url":"https://api.github.com/repos/targos/node-core-utils/deployments","created_at":"2017-10-31T14:36:03Z","updated_at":"2017-10-31T14:36:05Z","pushed_at":"2018-04-14T10:06:17Z","git_url":"git://github.com/targos/node-core-utils.git","ssh_url":"git@github.com:targos/node-core-utils.git","clone_url":"https://github.com/targos/node-core-utils.git","svn_url":"https://github.com/targos/node-core-utils","homepage":"","size":442,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"92e3fb1fe00cc07bd8e8a20a4f4b09ed26d27af8","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":107863796,"name":"node-core-utils","full_name":"nodejs/node-core-utils","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node-core-utils","description":"CLI tools for Node.js Core collaborators","fork":false,"url":"https://api.github.com/repos/nodejs/node-core-utils","forks_url":"https://api.github.com/repos/nodejs/node-core-utils/forks","keys_url":"https://api.github.com/repos/nodejs/node-core-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node-core-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node-core-utils/teams","hooks_url":"https://api.github.com/repos/nodejs/node-core-utils/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node-core-utils/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node-core-utils/events","assignees_url":"https://api.github.com/repos/nodejs/node-core-utils/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node-core-utils/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node-core-utils/tags","blobs_url":"https://api.github.com/repos/nodejs/node-core-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node-core-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node-core-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node-core-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node-core-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node-core-utils/languages","stargazers_url":"https://api.github.com/repos/nodejs/node-core-utils/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node-core-utils/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node-core-utils/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node-core-utils/subscription","commits_url":"https://api.github.com/repos/nodejs/node-core-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node-core-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node-core-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node-core-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node-core-utils/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node-core-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node-core-utils/merges","archive_url":"https://api.github.com/repos/nodejs/node-core-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node-core-utils/downloads","issues_url":"https://api.github.com/repos/nodejs/node-core-utils/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node-core-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node-core-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node-core-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node-core-utils/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node-core-utils/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node-core-utils/deployments","created_at":"2017-10-22T12:27:44Z","updated_at":"2018-04-17T08:00:12Z","pushed_at":"2018-04-19T06:56:12Z","git_url":"git://github.com/nodejs/node-core-utils.git","ssh_url":"git@github.com:nodejs/node-core-utils.git","clone_url":"https://github.com/nodejs/node-core-utils.git","svn_url":"https://github.com/nodejs/node-core-utils","homepage":"","size":408,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":31,"open_issues":38,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-core-utils/pulls/235"},"html":{"href":"https://github.com/nodejs/node-core-utils/pull/235"},"issue":{"href":"https://api.github.com/repos/nodejs/node-core-utils/issues/235"},"comments":{"href":"https://api.github.com/repos/nodejs/node-core-utils/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node-core-utils/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node-core-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node-core-utils/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node-core-utils/statuses/d12fd207ccab4924c4a77a6d7bd8d0dee4824aea"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":1652,"deletions":195,"changed_files":15}}
{"actor":{"display_login":"joyeecheung"}}