{"push_id":3011596371,"size":15,"distinct_size":15,"ref":"refs/heads/fixedtime","head":"7c9b9076bcac57687ff1361831ddab181c4e0553","before":"85648564e97c0552234d13635ee21a37c4eec170","commits":[{"sha":"dde4cb47a0a20d33d109011fd4b9dbbc95175779","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: deflake TestStoreRangeMergeSlowUnabandonedFollower_WithSplit\n\nSince 4aa93e5, we are more proactive about GC'ing orphaned\nreplicas--proactive enough that TestStoreRangeMergeSlowUnabandoned-\nFollower_WithSplit and the new event-driven GC race to clean up store2's\nreplica of LHS. This causes the test to flake if it loses the race.\n\nTeach the test to sit back and let event-driven GC clean up the LHS\nreplica. This removes the flakiness and makes for a better test.\n\nFix #31996.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/dde4cb47a0a20d33d109011fd4b9dbbc95175779"},{"sha":"ed9c03ffb8ce8e8cb29cbd84d8efc1883530cb1c","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32057\n\n32057: storage: deflake TestStoreRangeMergeSlowUnabandonedFollower_WithSplit r=tschottdorf a=benesch\n\nSince 4aa93e5, we are more proactive about GC'ing orphaned\r\nreplicas--proactive enough that TestStoreRangeMergeSlowUnabandoned-\r\nFollower_WithSplit and the new event-driven GC race to clean up store2's\r\nreplica of LHS. This causes the test to flake if it loses the race.\r\n\r\nTeach the test to sit back and let event-driven GC clean up the LHS\r\nreplica. This removes the flakiness and makes for a better test.\r\n\r\nFix #31996.\r\n\r\nRelease note: None\n\nCo-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/ed9c03ffb8ce8e8cb29cbd84d8efc1883530cb1c"},{"sha":"9f0f9d4eb1f71adaf6ff9b3326be868dc8fcd851","author":{"name":"Nikhil Benesch","email":"0e70f566aa977bafe6ad237291a2aeff1c9dbb46@gmail.com"},"message":"storage: prevent subsumed replicas from quiescing\n\nSuppose the LHS replica of a merge never applies the merge trigger on\none of the involved stores. The corresponding RHS will become orphaned\nand need to be cleaned up by the replica GC queue. If the range is\nunquiesced, the RHS replica will, within a few hundred milliseconds, try\nto contact its peers, receive a RangeNotFound error, and add itself to\nthe GC queue. If, however, the range is quiescent, it will not notice\nthat its peers have gone away, and it may not be picked up for\nprocessing by the replica GC queue for ReplicaGCQueueInactivityThreshold\n(10 days!).\n\nAvoid this problem by preventing ranges that either are in the process\nof subsuming or have been subsumed from quiescing.\n\nNote that a similar problem occurs if a node is rebooted with orphaned\nreplicas, as the replicas will be dormant after the reboot and will not\nnotice if their peers have gone away. Fixing this problem is left to\na later commit.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/9f0f9d4eb1f71adaf6ff9b3326be868dc8fcd851"},{"sha":"6ff9e55236ea58f855115693495742c74efa8f9d","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #31993\n\n31993: storage: prevent subsumed replicas from quiescing r=tschottdorf,bdarnell a=benesch\n\nSuppose the LHS replica of a merge never applies the merge trigger on\r\none of the involved stores. The corresponding RHS will become orphaned\r\nand need to be cleaned up by the replica GC queue. If the range is\r\nunquiesced, the RHS replica will, within a few hundred milliseconds, try\r\nto contact its peers, receive a RangeNotFound error, and add itself to\r\nthe GC queue. If, however, the range is quiescent, it will not notice\r\nthat its peers have gone away, and it may not be picked up for\r\nprocessing by the replica GC queue for ReplicaGCQueueInactivityThreshold\r\n(10 days!).\r\n\r\nAvoid this problem by preventing ranges that either are in the process\r\nof subsuming or have been subsumed from quiescing.\r\n\r\nNote that a similar problem occurs if a node is rebooted with orphaned\r\nreplicas, as the replicas will be dormant after the reboot and will not\r\nnotice if their peers have gone away. Fixing this problem is left to\r\na later commit.\r\n\r\nRelease note: None\n\nCo-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/6ff9e55236ea58f855115693495742c74efa8f9d"},{"sha":"c90780679bb191a5097dd2ea6876514da9435e4f","author":{"name":"Jordan Lewis","email":"d6a9c9ceebab0a60eea8692fb0aa04be2d19ee67@gmail.com"},"message":"exec: template the distinct operator\n\nTemplate the distinct operator using a new approach, where the template\nfile is normal executable Go, but prevented from being compiled normally\nby a build tag.\n\nThe generator file reads the template file in, replaces some special\nvariables with template variables, and runs the template.\n\nThere are two main warts with this approach:\n\n1. ColVec needed to be extended with a dummy _TemplateType method whose\n   signature is _TemplateType() []interface{}, so the template can\n   compile. That method is implemented to always panic().\n2. The template generator needs to textually replace things in a way\n   that can be confusing. _TYPE, _GOTYPE, _TYPES_T, _EQUALITY_FN, and\n   _TemplateType all need to be replaced, with {{.}}, {{.GoTypeName}},\n   types.{{.}}, {{.EqualityFunction}} and {{.}} respectively.\n\nAlso, rename distinctFinalizerOp to boolVecToSelOp and move to its own\nfile. The implementation doesn't change.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/c90780679bb191a5097dd2ea6876514da9435e4f"},{"sha":"04649a1cec4975a15e53ed961505aaae9d61463a","author":{"name":"Daniel Harrison","email":"3a2f0da2a0c450062f2df795b8346ad513a9734a@gmail.com"},"message":"changefeedccl: flush less\n\nFor correctness, changeAggreagator needs to flush kafka before\nforwarding a span-level resolved timestamp to changeFrontier. Before\nthis change, it was flushing once before every span-level resolved\ntimestamp. On TPCC-1000, there were about 2000 of these per second,\nwhich meant we were spending more time flushing kafka than writing to\nit. (This is especially bad because it blocks Next calls.)\n\nThis change batches span-level resolved timestamps for some amount of\ntime, before flushing once and emitting them all. This adds ~20% delay\nto the changefeed-level timestamp from being emitted to the user\nslightly, but we now spend almost no time flushing.\n\nAlong with #32023, optimistically:\nCloses #31001\n\nRelease note (bug fix): CHANGEFEEDs now spend dramatically less time\nflushing kafka writes","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/04649a1cec4975a15e53ed961505aaae9d61463a"},{"sha":"db277041731d368472f7f3024fb2307a6410a8ef","author":{"name":"Lucy Zhang","email":"800ac05931b52e956af3cd56eead66170eb5b5da@users.noreply.github.com"},"message":"docs: update sql function codelab\n\nUpdate codelab to reflect changes in filepaths and variable names.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/db277041731d368472f7f3024fb2307a6410a8ef"},{"sha":"c0e5f00dcc19a62ed7c3ed1809a0451f1d77f729","author":{"name":"Matt Jibson","email":"314fe2776746d1cb8b8611e1e315a38b2017bbff@gmail.com"},"message":"sql: use retryable txn in copy tests\n\nFixes #32043\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/c0e5f00dcc19a62ed7c3ed1809a0451f1d77f729"},{"sha":"61d783e00dc098059e36ad78c3e00ba583cdf84c","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32063\n\n32063: docs: update sql function codelab r=lucy-zhang a=lucy-zhang\n\nUpdate codelab to reflect changes in filepaths and variable names.\r\n\r\nRelease note: None\n\nCo-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/61d783e00dc098059e36ad78c3e00ba583cdf84c"},{"sha":"40cbbf0ce3199d779f018c294054d8ec42782da6","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #31957\n\n31957: exec: template the distinct operator r=jordanlewis a=jordanlewis\n\nTemplate the distinct operator using a new approach, where the template\r\nfile is normal executable Go, but prevented from being compiled normally\r\nby a build tag.\r\n\r\nThe generator file reads the template file in, replaces some special\r\nvariables with template variables, and runs the template.\r\n\r\nThere are two main warts with this approach:\r\n\r\n1. ColVec needed to be extended with a dummy _TemplateType method whose\r\n   signature is _TemplateType() []interface{}, so the template can\r\n   compile. That method is implemented to always panic().\r\n2. The template generator needs to textually replace things in a way\r\n   that can be confusing. _TYPE, _GOTYPE, _TYPES_T, _EQUALITY_FN, and\r\n   _TemplateType all need to be replaced, with {{.}}, {{.GoTypeName}},\r\n   types.{{.}}, {{.EqualityFunction}} and {{.}} respectively.\r\n\r\nAlso, rename distinctFinalizerOp to boolVecToSelOp and move to its own\r\nfile. The implementation doesn't change.\r\n\r\nRelease note: None\n\nCo-authored-by: Jordan Lewis <jordanthelewis@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/40cbbf0ce3199d779f018c294054d8ec42782da6"},{"sha":"a384f28185cbc37636d35117843c649e508354fa","author":{"name":"Daniel Harrison","email":"3a2f0da2a0c450062f2df795b8346ad513a9734a@gmail.com"},"message":"roachtest: add an end-to-end changefeed latency histogram to cdc tests\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/a384f28185cbc37636d35117843c649e508354fa"},{"sha":"e14bcf3107820a87e02f63e874720e952b39e5c8","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32060\n\n32060: changefeedccl: flush less r=mrtracy a=danhhz\n\nFor correctness, changeAggreagator needs to flush kafka before\r\nforwarding a span-level resolved timestamp to changeFrontier. Before\r\nthis change, it was flushing once before every span-level resolved\r\ntimestamp. On TPCC-1000, there were about 2000 of these per second,\r\nwhich meant we were spending more time flushing kafka than writing to\r\nit. (This is especially bad because it blocks Next calls.)\r\n\r\nThis change batches span-level resolved timestamps for some amount of\r\ntime, before flushing once and emitting them all. This adds ~20% delay\r\nto the changefeed-level timestamp from being emitted to the user\r\nslightly, but we now spend almost no time flushing.\r\n\r\nAlong with #32023, optimistically:\r\nCloses #31001\r\n\r\nRelease note (bug fix): CHANGEFEEDs now spend dramatically less time\r\nflushing kafka writes\n\nCo-authored-by: Daniel Harrison <daniel.harrison@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/e14bcf3107820a87e02f63e874720e952b39e5c8"},{"sha":"c196a52e8ec61851e32a062c13135bbb4111eb96","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32068\n\n32068: roachtest: add an end-to-end changefeed latency histogram to cdc tests r=mrtracy a=danhhz\n\nRelease note: None\n\nCo-authored-by: Daniel Harrison <daniel.harrison@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/c196a52e8ec61851e32a062c13135bbb4111eb96"},{"sha":"ac465ac89ed45e14ca92b3c7950bb9befdaba904","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #32065\n\n32065: sql: use retryable txn in copy tests r=mjibson a=mjibson\n\nFixes #32043\r\n\r\nRelease note: None\n\nCo-authored-by: Matt Jibson <matt.jibson@gmail.com>","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/ac465ac89ed45e14ca92b3c7950bb9befdaba904"},{"sha":"7c9b9076bcac57687ff1361831ddab181c4e0553","author":{"name":"Vivek Menezes","email":"be459340ddb9c8286fc08bebdce70ca287e03a1a@cockroachlabs.com"},"message":"sql: cleanup AS OF SYSTEM TIME query descriptor cache lookup\n\nThis change removes the fixedTimestamp bit introduced in #31716\n\nIt also explains problem #18354 with LeaseManager.Acquire() through\na comment and implements a work around bypassing the cache and\nreading the descriptor directly from the store.\n\nIt also fixes a problem with UncachedPhysicalAccessor.GetObjectDesc\ntested through TestTxnCanStillResolveOldName.\n\nrelated to #30967\n\nfixes #18354\nfixes #19925\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/vivekmenezes/cockroach/commits/7c9b9076bcac57687ff1361831ddab181c4e0553"}]}
{"actor":{"display_login":"vivekmenezes"}}