{"action":"created","issue":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/320","repository_url":"https://api.github.com/repos/sakura-editor/sakura","labels_url":"https://api.github.com/repos/sakura-editor/sakura/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/320/comments","events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/320/events","html_url":"https://github.com/sakura-editor/sakura/pull/320","id":347667137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjIwODYx","number":320,"title":"リソースファイルのリファクタリング (複数行にわかれているのを一行にまとめる)の対応漏れの対応","user":{"login":"m-tmatma","id":5567450,"node_id":"MDQ6VXNlcjU1Njc0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5567450?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tmatma","html_url":"https://github.com/m-tmatma","followers_url":"https://api.github.com/users/m-tmatma/followers","following_url":"https://api.github.com/users/m-tmatma/following{/other_user}","gists_url":"https://api.github.com/users/m-tmatma/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tmatma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tmatma/subscriptions","organizations_url":"https://api.github.com/users/m-tmatma/orgs","repos_url":"https://api.github.com/users/m-tmatma/repos","events_url":"https://api.github.com/users/m-tmatma/events{/privacy}","received_events_url":"https://api.github.com/users/m-tmatma/received_events","type":"User","site_admin":false},"labels":[{"id":960880110,"node_id":"MDU6TGFiZWw5NjA4ODAxMTA=","url":"https://api.github.com/repos/sakura-editor/sakura/labels/refactoring","name":"refactoring","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1","html_url":"https://github.com/sakura-editor/sakura/milestone/1","labels_url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1/labels","id":3390252,"node_id":"MDk6TWlsZXN0b25lMzM5MDI1Mg==","number":1,"title":"next release","description":"バージョン番号が確定したらマイルストーン名を変えます","creator":{"login":"kobake","id":2929454,"node_id":"MDQ6VXNlcjI5Mjk0NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2929454?v=4","gravatar_id":"","url":"https://api.github.com/users/kobake","html_url":"https://github.com/kobake","followers_url":"https://api.github.com/users/kobake/followers","following_url":"https://api.github.com/users/kobake/following{/other_user}","gists_url":"https://api.github.com/users/kobake/gists{/gist_id}","starred_url":"https://api.github.com/users/kobake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobake/subscriptions","organizations_url":"https://api.github.com/users/kobake/orgs","repos_url":"https://api.github.com/users/kobake/repos","events_url":"https://api.github.com/users/kobake/events{/privacy}","received_events_url":"https://api.github.com/users/kobake/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":193,"state":"open","created_at":"2018-05-31T12:48:23Z","updated_at":"2018-08-05T04:02:12Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-08-05T04:02:12Z","updated_at":"2018-08-05T04:42:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/320","html_url":"https://github.com/sakura-editor/sakura/pull/320","diff_url":"https://github.com/sakura-editor/sakura/pull/320.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/320.patch"},"body":"リソースファイルのリファクタリング (複数行にわかれているのを一行にまとめる) #318 \r\nの対応漏れの対応\r\n\r\n# 対応方法\r\n\r\n- Visual Studio 2017 を使って置換を行う\r\n- 正規表現を有効にする\r\n- *.rc ファイル を対象にする\r\n\r\n## 置換パターン\r\n\r\n  変換前: \"\\bNOT\\s*\\r\\n\\s*\"\r\n  変換後: \"NOT \"\r\n\r\n(↑ 変換後のパターンで末尾に空白を含む。ダブルクオートは含まない)\r\n→ 24 箇所置換した。\r\n\r\n# 確認方法\r\n\r\n## PR の最新のコミットを取得\r\n\r\n\r\n## 以下コマンドでビルド\r\n\r\n```\r\nbuild-sln.bat Win32 Release\r\nbuild-sln.bat Win32 Debug\r\nbuild-sln.bat x64   Release\r\nbuild-sln.bat x64   Debug\r\n```\r\n\r\n## 以下コマンドで移動\r\n\r\n\r\n```\r\nmkdir sakura_lang_en_US\\New\\\r\nmkdir sakura\\New\\\r\nmove sakura_lang_en_US\\Win32 sakura_lang_en_US\\New\\\r\nmove sakura_lang_en_US\\x64   sakura_lang_en_US\\New\\\r\nmove sakura\\x64              sakura\\New\\\r\nmove sakura\\Win32            sakura\\New\\\r\n```\r\n\r\n## 分岐元の git hash を表示\r\n\r\n\r\n```\r\ngit show-branch --merge-base\r\n```\r\n\r\n## 分岐元の git hash を取得\r\n\r\n```\r\ngit checkout 671f7dc0baa28edde8226f10dc6eaca5e61c6bdf\r\n```\r\n\r\n## githash.bat の先頭に ```exit /b 0``` を挿入して githash.h が更新されないようにする。\r\n\r\n\r\n## 以下コマンドでビルドする\r\n\r\n\r\n```\r\nbuild-sln.bat Win32 Release\r\nbuild-sln.bat Win32 Debug\r\nbuild-sln.bat x64   Release\r\nbuild-sln.bat x64   Debug\r\n```\r\n\r\n## 以下コマンドで移動\r\n\r\n\r\n```\r\nmkdir sakura_lang_en_US\\Old\\\r\nmkdir sakura\\Old\\\r\nmove sakura_lang_en_US\\Win32 sakura_lang_en_US\\Old\\\r\nmove sakura_lang_en_US\\x64   sakura_lang_en_US\\Old\\\r\nmove sakura\\x64              sakura\\Old\\\r\nmove sakura\\Win32            sakura\\Old\\\r\n```\r\n\r\n\r\n## #317 のスクリプトを実行する\r\n\r\n```\r\ncalc-hash-res.py hash.txt .\r\n```\r\n\r\n## 以下ローカルビルドの結果です。\r\n\r\n[hash.txt](https://github.com/sakura-editor/sakura/files/2260034/hash.txt)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments/410495428","html_url":"https://github.com/sakura-editor/sakura/pull/320#issuecomment-410495428","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/320","id":410495428,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDQ5NTQyOA==","user":{"login":"berryzplus","id":3253151,"node_id":"MDQ6VXNlcjMyNTMxNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3253151?v=4","gravatar_id":"","url":"https://api.github.com/users/berryzplus","html_url":"https://github.com/berryzplus","followers_url":"https://api.github.com/users/berryzplus/followers","following_url":"https://api.github.com/users/berryzplus/following{/other_user}","gists_url":"https://api.github.com/users/berryzplus/gists{/gist_id}","starred_url":"https://api.github.com/users/berryzplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berryzplus/subscriptions","organizations_url":"https://api.github.com/users/berryzplus/orgs","repos_url":"https://api.github.com/users/berryzplus/repos","events_url":"https://api.github.com/users/berryzplus/events{/privacy}","received_events_url":"https://api.github.com/users/berryzplus/received_events","type":"User","site_admin":false},"created_at":"2018-08-05T04:42:09Z","updated_at":"2018-08-05T04:42:09Z","author_association":"CONTRIBUTOR","body":"ＯＫ、日英とも１箇所だけでした。\r\n行番号は https://github.com/sakura-editor/sakura/pull/320/commits/f4d3f4c33df86a46883e4872cf0e48f0eef5d15b のものです。\r\n対応をお願いします。\r\n\r\n```C\r\n  C:\\gitroot\\sakura\\sakura_core\\sakura_rc.rc(1215):    CONTROL         \"改行コードNEL,PS,LSを有効にする(&O)\",IDC_CHECK_ENABLEEXTEOL,\"Button\",BS_AUTOCHECKBOX | WS_GROUP\r\n  C:\\gitroot\\sakura\\sakura_core\\sakura_rc.rc(1216):                    | WS_TABSTOP,161,138,122,10\r\n  C:\\gitroot\\sakura\\sakura_lang_en_US\\sakura_lang_rc.rc(1217):    CONTROL         \"Enable CR Code NEL,PS,LS(&O)\",IDC_CHECK_ENABLEEXTEOL,\"Button\",BS_AUTOCHECKBOX | WS_GROUP\r\n  C:\\gitroot\\sakura\\sakura_lang_en_US\\sakura_lang_rc.rc(1218):                    | WS_TABSTOP,161,138,122,10\r\n```"}}
{"actor":{"display_login":"berryzplus"}}