{"action":"created","issue":{"url":"https://api.github.com/repos/standardhealth/flux/issues/288","repository_url":"https://api.github.com/repos/standardhealth/flux","labels_url":"https://api.github.com/repos/standardhealth/flux/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/standardhealth/flux/issues/288/comments","events_url":"https://api.github.com/repos/standardhealth/flux/issues/288/events","html_url":"https://github.com/standardhealth/flux/pull/288","id":303550160,"number":288,"title":"Enrollment fixes","user":{"login":"gregquinn2001","id":20170846,"avatar_url":"https://avatars1.githubusercontent.com/u/20170846?v=4","gravatar_id":"","url":"https://api.github.com/users/gregquinn2001","html_url":"https://github.com/gregquinn2001","followers_url":"https://api.github.com/users/gregquinn2001/followers","following_url":"https://api.github.com/users/gregquinn2001/following{/other_user}","gists_url":"https://api.github.com/users/gregquinn2001/gists{/gist_id}","starred_url":"https://api.github.com/users/gregquinn2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregquinn2001/subscriptions","organizations_url":"https://api.github.com/users/gregquinn2001/orgs","repos_url":"https://api.github.com/users/gregquinn2001/repos","events_url":"https://api.github.com/users/gregquinn2001/events{/privacy}","received_events_url":"https://api.github.com/users/gregquinn2001/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-03-08T16:47:12Z","updated_at":"2018-03-14T15:47:52Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/standardhealth/flux/pulls/288","html_url":"https://github.com/standardhealth/flux/pull/288","diff_url":"https://github.com/standardhealth/flux/pull/288.diff","patch_url":"https://github.com/standardhealth/flux/pull/288.patch"},"body":"Addresses the following:\r\n- JIRA 967 - signing a note should only affect the unsigned structured data in that note. other in progress notes' structured data should remain unsigned in targeted data panel.\r\n- JIRA 978 - deleting enrollment tag from the note now deletes the structured data from model\r\n- JIRA 969 - enrolling in a clinical trial in current note now shows up as unsigned until note is signed (name and enrollment date of trial if both provided show unsigned until note is signed)\r\n- JIRA 968 - unenrollling from a clinical trial which is enrolled within model (unsigned or signed) now sets unenroll date on that same clinical trial object (Study) in the model\r\n- JIRA 1014 - tabular visualizer was producing a warning. eliminated that warning.\r\n- JIRA 1016 - Study object is incorrect and should be ResearchSubject object from SHR instead \r\n- JIRA 1019 - Inserting PATINA from targeted data panel fails\r\n- JIRA 1022 - Lab Results in tabular visualized showing ,false in names and fail to insert\r\n\r\nNOTE that we now have linkage from structured data to its source clinical note at the entry level. This was done by updating the SHR Entry ES6 class. demo2 patient has such a linkage now for the latest disease progression.\r\n\r\nShortcoming:\r\n- Need to show unenrollment date as unsigned still (JIRA 1006)\r\n\r\n## Submitter:\r\n\r\n**Running the Application**\r\n\r\n- [X] Manually tested in Chrome\r\n- [X] Manually tested in IE\r\n\r\n**Documentation**\r\n\r\n- [ ] This pull request describes why these changes were made\r\n- [ ] Recognizes any potential shortcomings/bugs in the description \r\n- [ ] Cheat sheet is updated\r\n- [ ] Demo script is updated \r\n- [ ] Documentation on Wiki has been updated \r\n- [ ] Additional technical components and libraries are documented and added to wiki as needed\r\n\r\n**NoteParser**\r\n\r\n- [ ] Note parser has been updated if structured phrases change\r\n\r\n**Code Quality**\r\n\r\n- [ ] 4-space indents - convert any tabs to spaces\r\n- [ ] Use public class field syntax for binding functions - ex. handleChange = () => { ... };\r\n- [ ] Code is commented\r\n\r\n**Tests**\r\n\r\n- [ ] Existing tests passed\r\n- [ ] Added UI tests for slim mode \r\n- [ ] Added UI tests for full mode\r\n- [ ] Added backend tests for fluxNotes code\r\n- [ ] Added note parser examples to test new functionality\r\n\r\n\r\n## Reviewer 1: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\n\r\n## Reviewer 2: Name\r\n\r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n"},"comment":{"url":"https://api.github.com/repos/standardhealth/flux/issues/comments/373070226","html_url":"https://github.com/standardhealth/flux/pull/288#issuecomment-373070226","issue_url":"https://api.github.com/repos/standardhealth/flux/issues/288","id":373070226,"user":{"login":"gregquinn2001","id":20170846,"avatar_url":"https://avatars1.githubusercontent.com/u/20170846?v=4","gravatar_id":"","url":"https://api.github.com/users/gregquinn2001","html_url":"https://github.com/gregquinn2001","followers_url":"https://api.github.com/users/gregquinn2001/followers","following_url":"https://api.github.com/users/gregquinn2001/following{/other_user}","gists_url":"https://api.github.com/users/gregquinn2001/gists{/gist_id}","starred_url":"https://api.github.com/users/gregquinn2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregquinn2001/subscriptions","organizations_url":"https://api.github.com/users/gregquinn2001/orgs","repos_url":"https://api.github.com/users/gregquinn2001/repos","events_url":"https://api.github.com/users/gregquinn2001/events{/privacy}","received_events_url":"https://api.github.com/users/gregquinn2001/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T15:47:52Z","updated_at":"2018-03-14T15:47:52Z","author_association":"OWNER","body":"I'm not sure how to handle DL1 actually. I'm going to create a JIRA for it for now. Thanks!"}}
{"actor":{"display_login":"gregquinn2001"}}