{"action":"closed","number":966,"pull_request":{"url":"https://api.github.com/repos/denoland/deno/pulls/966","id":222287262,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjg3MjYy","html_url":"https://github.com/denoland/deno/pull/966","diff_url":"https://github.com/denoland/deno/pull/966.diff","patch_url":"https://github.com/denoland/deno/pull/966.patch","issue_url":"https://api.github.com/repos/denoland/deno/issues/966","number":966,"state":"closed","locked":false,"title":"perf: Increase copy() buffer to 32k","user":{"login":"ry","id":80,"node_id":"MDQ6VXNlcjgw","avatar_url":"https://avatars1.githubusercontent.com/u/80?v=4","gravatar_id":"","url":"https://api.github.com/users/ry","html_url":"https://github.com/ry","followers_url":"https://api.github.com/users/ry/followers","following_url":"https://api.github.com/users/ry/following{/other_user}","gists_url":"https://api.github.com/users/ry/gists{/gist_id}","starred_url":"https://api.github.com/users/ry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry/subscriptions","organizations_url":"https://api.github.com/users/ry/orgs","repos_url":"https://api.github.com/users/ry/repos","events_url":"https://api.github.com/users/ry/events{/privacy}","received_events_url":"https://api.github.com/users/ry/received_events","type":"User","site_admin":false},"body":"This will improve the threshold benchmark. Using 32k because that's what\r\nGo uses, but we should explore the value in the future.\r\nhttps://github.com/golang/go/blob/a0d6420d8be2ae7164797051ec74fa2a2df466a1/src/io/io.go#L391\r\n\r\n<!--\r\n\r\nThank you for your pull request. Before submitting, please make sure the following is done.\r\n\r\n1. Ensure ./tools/test.py passes.\r\n2. Format your code with ./tools/format.py\r\n3. Make sure ./tools/lint.py passes.\r\n\r\n-->\r\n","created_at":"2018-10-11T21:37:03Z","updated_at":"2018-10-12T12:58:19Z","closed_at":"2018-10-12T12:58:19Z","merged_at":"2018-10-12T12:58:19Z","merge_commit_sha":"c9f95d51da9f6075b1f28a842dc830ec5fe7a30e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/denoland/deno/pulls/966/commits","review_comments_url":"https://api.github.com/repos/denoland/deno/pulls/966/comments","review_comment_url":"https://api.github.com/repos/denoland/deno/pulls/comments{/number}","comments_url":"https://api.github.com/repos/denoland/deno/issues/966/comments","statuses_url":"https://api.github.com/repos/denoland/deno/statuses/68e14fe514ac5b415999bf240444423d7d5d4c49","head":{"label":"ry:copy_bufsize","ref":"copy_bufsize","sha":"68e14fe514ac5b415999bf240444423d7d5d4c49","user":{"login":"ry","id":80,"node_id":"MDQ6VXNlcjgw","avatar_url":"https://avatars1.githubusercontent.com/u/80?v=4","gravatar_id":"","url":"https://api.github.com/users/ry","html_url":"https://github.com/ry","followers_url":"https://api.github.com/users/ry/followers","following_url":"https://api.github.com/users/ry/following{/other_user}","gists_url":"https://api.github.com/users/ry/gists{/gist_id}","starred_url":"https://api.github.com/users/ry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry/subscriptions","organizations_url":"https://api.github.com/users/ry/orgs","repos_url":"https://api.github.com/users/ry/repos","events_url":"https://api.github.com/users/ry/events{/privacy}","received_events_url":"https://api.github.com/users/ry/received_events","type":"User","site_admin":false},"repo":{"id":146788128,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3ODgxMjg=","name":"deno","full_name":"ry/deno","private":false,"owner":{"login":"ry","id":80,"node_id":"MDQ6VXNlcjgw","avatar_url":"https://avatars1.githubusercontent.com/u/80?v=4","gravatar_id":"","url":"https://api.github.com/users/ry","html_url":"https://github.com/ry","followers_url":"https://api.github.com/users/ry/followers","following_url":"https://api.github.com/users/ry/following{/other_user}","gists_url":"https://api.github.com/users/ry/gists{/gist_id}","starred_url":"https://api.github.com/users/ry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry/subscriptions","organizations_url":"https://api.github.com/users/ry/orgs","repos_url":"https://api.github.com/users/ry/repos","events_url":"https://api.github.com/users/ry/events{/privacy}","received_events_url":"https://api.github.com/users/ry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ry/deno","description":null,"fork":true,"url":"https://api.github.com/repos/ry/deno","forks_url":"https://api.github.com/repos/ry/deno/forks","keys_url":"https://api.github.com/repos/ry/deno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ry/deno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ry/deno/teams","hooks_url":"https://api.github.com/repos/ry/deno/hooks","issue_events_url":"https://api.github.com/repos/ry/deno/issues/events{/number}","events_url":"https://api.github.com/repos/ry/deno/events","assignees_url":"https://api.github.com/repos/ry/deno/assignees{/user}","branches_url":"https://api.github.com/repos/ry/deno/branches{/branch}","tags_url":"https://api.github.com/repos/ry/deno/tags","blobs_url":"https://api.github.com/repos/ry/deno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ry/deno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ry/deno/git/refs{/sha}","trees_url":"https://api.github.com/repos/ry/deno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ry/deno/statuses/{sha}","languages_url":"https://api.github.com/repos/ry/deno/languages","stargazers_url":"https://api.github.com/repos/ry/deno/stargazers","contributors_url":"https://api.github.com/repos/ry/deno/contributors","subscribers_url":"https://api.github.com/repos/ry/deno/subscribers","subscription_url":"https://api.github.com/repos/ry/deno/subscription","commits_url":"https://api.github.com/repos/ry/deno/commits{/sha}","git_commits_url":"https://api.github.com/repos/ry/deno/git/commits{/sha}","comments_url":"https://api.github.com/repos/ry/deno/comments{/number}","issue_comment_url":"https://api.github.com/repos/ry/deno/issues/comments{/number}","contents_url":"https://api.github.com/repos/ry/deno/contents/{+path}","compare_url":"https://api.github.com/repos/ry/deno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ry/deno/merges","archive_url":"https://api.github.com/repos/ry/deno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ry/deno/downloads","issues_url":"https://api.github.com/repos/ry/deno/issues{/number}","pulls_url":"https://api.github.com/repos/ry/deno/pulls{/number}","milestones_url":"https://api.github.com/repos/ry/deno/milestones{/number}","notifications_url":"https://api.github.com/repos/ry/deno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ry/deno/labels{/name}","releases_url":"https://api.github.com/repos/ry/deno/releases{/id}","deployments_url":"https://api.github.com/repos/ry/deno/deployments","created_at":"2018-08-30T18:09:18Z","updated_at":"2018-10-11T16:45:43Z","pushed_at":"2018-10-12T00:29:49Z","git_url":"git://github.com/ry/deno.git","ssh_url":"git@github.com:ry/deno.git","clone_url":"https://github.com/ry/deno.git","svn_url":"https://github.com/ry/deno","homepage":"https://github.com/denoland/deno","size":1486,"stargazers_count":30,"watchers_count":30,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":3,"open_issues":0,"watchers":30,"default_branch":"ry_master"}},"base":{"label":"denoland:master","ref":"master","sha":"d4f72e18bedda726a74ec0960e59e304055f9039","user":{"login":"denoland","id":42048915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQ4OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/42048915?v=4","gravatar_id":"","url":"https://api.github.com/users/denoland","html_url":"https://github.com/denoland","followers_url":"https://api.github.com/users/denoland/followers","following_url":"https://api.github.com/users/denoland/following{/other_user}","gists_url":"https://api.github.com/users/denoland/gists{/gist_id}","starred_url":"https://api.github.com/users/denoland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denoland/subscriptions","organizations_url":"https://api.github.com/users/denoland/orgs","repos_url":"https://api.github.com/users/denoland/repos","events_url":"https://api.github.com/users/denoland/events{/privacy}","received_events_url":"https://api.github.com/users/denoland/received_events","type":"Organization","site_admin":false},"repo":{"id":133442384,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDIzODQ=","name":"deno","full_name":"denoland/deno","private":false,"owner":{"login":"denoland","id":42048915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDQ4OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/42048915?v=4","gravatar_id":"","url":"https://api.github.com/users/denoland","html_url":"https://github.com/denoland","followers_url":"https://api.github.com/users/denoland/followers","following_url":"https://api.github.com/users/denoland/following{/other_user}","gists_url":"https://api.github.com/users/denoland/gists{/gist_id}","starred_url":"https://api.github.com/users/denoland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denoland/subscriptions","organizations_url":"https://api.github.com/users/denoland/orgs","repos_url":"https://api.github.com/users/denoland/repos","events_url":"https://api.github.com/users/denoland/events{/privacy}","received_events_url":"https://api.github.com/users/denoland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/denoland/deno","description":"A secure TypeScript runtime on V8","fork":false,"url":"https://api.github.com/repos/denoland/deno","forks_url":"https://api.github.com/repos/denoland/deno/forks","keys_url":"https://api.github.com/repos/denoland/deno/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denoland/deno/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denoland/deno/teams","hooks_url":"https://api.github.com/repos/denoland/deno/hooks","issue_events_url":"https://api.github.com/repos/denoland/deno/issues/events{/number}","events_url":"https://api.github.com/repos/denoland/deno/events","assignees_url":"https://api.github.com/repos/denoland/deno/assignees{/user}","branches_url":"https://api.github.com/repos/denoland/deno/branches{/branch}","tags_url":"https://api.github.com/repos/denoland/deno/tags","blobs_url":"https://api.github.com/repos/denoland/deno/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denoland/deno/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denoland/deno/git/refs{/sha}","trees_url":"https://api.github.com/repos/denoland/deno/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denoland/deno/statuses/{sha}","languages_url":"https://api.github.com/repos/denoland/deno/languages","stargazers_url":"https://api.github.com/repos/denoland/deno/stargazers","contributors_url":"https://api.github.com/repos/denoland/deno/contributors","subscribers_url":"https://api.github.com/repos/denoland/deno/subscribers","subscription_url":"https://api.github.com/repos/denoland/deno/subscription","commits_url":"https://api.github.com/repos/denoland/deno/commits{/sha}","git_commits_url":"https://api.github.com/repos/denoland/deno/git/commits{/sha}","comments_url":"https://api.github.com/repos/denoland/deno/comments{/number}","issue_comment_url":"https://api.github.com/repos/denoland/deno/issues/comments{/number}","contents_url":"https://api.github.com/repos/denoland/deno/contents/{+path}","compare_url":"https://api.github.com/repos/denoland/deno/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denoland/deno/merges","archive_url":"https://api.github.com/repos/denoland/deno/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denoland/deno/downloads","issues_url":"https://api.github.com/repos/denoland/deno/issues{/number}","pulls_url":"https://api.github.com/repos/denoland/deno/pulls{/number}","milestones_url":"https://api.github.com/repos/denoland/deno/milestones{/number}","notifications_url":"https://api.github.com/repos/denoland/deno/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denoland/deno/labels{/name}","releases_url":"https://api.github.com/repos/denoland/deno/releases{/id}","deployments_url":"https://api.github.com/repos/denoland/deno/deployments","created_at":"2018-05-15T01:34:26Z","updated_at":"2018-10-12T12:25:52Z","pushed_at":"2018-10-12T12:58:19Z","git_url":"git://github.com/denoland/deno.git","ssh_url":"git@github.com:denoland/deno.git","clone_url":"https://github.com/denoland/deno.git","svn_url":"https://github.com/denoland/deno","homepage":"","size":1828,"stargazers_count":26321,"watchers_count":26321,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1252,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1252,"open_issues":96,"watchers":26321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/denoland/deno/pulls/966"},"html":{"href":"https://github.com/denoland/deno/pull/966"},"issue":{"href":"https://api.github.com/repos/denoland/deno/issues/966"},"comments":{"href":"https://api.github.com/repos/denoland/deno/issues/966/comments"},"review_comments":{"href":"https://api.github.com/repos/denoland/deno/pulls/966/comments"},"review_comment":{"href":"https://api.github.com/repos/denoland/deno/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/denoland/deno/pulls/966/commits"},"statuses":{"href":"https://api.github.com/repos/denoland/deno/statuses/68e14fe514ac5b415999bf240444423d7d5d4c49"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ry","id":80,"node_id":"MDQ6VXNlcjgw","avatar_url":"https://avatars1.githubusercontent.com/u/80?v=4","gravatar_id":"","url":"https://api.github.com/users/ry","html_url":"https://github.com/ry","followers_url":"https://api.github.com/users/ry/followers","following_url":"https://api.github.com/users/ry/following{/other_user}","gists_url":"https://api.github.com/users/ry/gists{/gist_id}","starred_url":"https://api.github.com/users/ry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ry/subscriptions","organizations_url":"https://api.github.com/users/ry/orgs","repos_url":"https://api.github.com/users/ry/repos","events_url":"https://api.github.com/users/ry/events{/privacy}","received_events_url":"https://api.github.com/users/ry/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ry"}}