{"action":"created","comment":{"url":"https://api.github.com/repos/lightbend/helm-charts/pulls/comments/234614757","pull_request_review_id":176291404,"id":234614757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDYxNDc1Nw==","diff_hunk":"@@ -360,7 +348,21 @@ def install(creds_file):\n         else:\n             fail('Unable to install/upgrade console, an install named {} with status {} already exists. '\n                  .format(args.helm_name, status))\n-    \n+\n+        if args.wait:\n+            helm_args += ' --wait'\n+\n+        if args.reuse_resources or status == 'failed':\n+            # Reuse PVCs if present\n+            if are_pvcs_created(args.namespace):\n+                printerr('warning: found existing PVCs from previous console installation, will reuse them')","path":"enterprise-suite/scripts/lbc.py","position":null,"original_position":65,"commit_id":"a9b5acec6281dca10e18001e32c5e7ef1fc7c52d","original_commit_id":"f0d2530e441a48a04b80a8a3ec153f21f25bbda8","user":{"login":"mitkus","id":1593852,"node_id":"MDQ6VXNlcjE1OTM4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1593852?v=4","gravatar_id":"","url":"https://api.github.com/users/mitkus","html_url":"https://github.com/mitkus","followers_url":"https://api.github.com/users/mitkus/followers","following_url":"https://api.github.com/users/mitkus/following{/other_user}","gists_url":"https://api.github.com/users/mitkus/gists{/gist_id}","starred_url":"https://api.github.com/users/mitkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitkus/subscriptions","organizations_url":"https://api.github.com/users/mitkus/orgs","repos_url":"https://api.github.com/users/mitkus/repos","events_url":"https://api.github.com/users/mitkus/events{/privacy}","received_events_url":"https://api.github.com/users/mitkus/received_events","type":"User","site_admin":false},"body":"Changed to `info:`","created_at":"2018-11-19T13:20:41Z","updated_at":"2018-11-19T13:20:41Z","html_url":"https://github.com/lightbend/helm-charts/pull/189#discussion_r234614757","pull_request_url":"https://api.github.com/repos/lightbend/helm-charts/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lightbend/helm-charts/pulls/comments/234614757"},"html":{"href":"https://github.com/lightbend/helm-charts/pull/189#discussion_r234614757"},"pull_request":{"href":"https://api.github.com/repos/lightbend/helm-charts/pulls/189"}},"in_reply_to_id":234587496},"pull_request":{"url":"https://api.github.com/repos/lightbend/helm-charts/pulls/189","id":231884012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODg0MDEy","html_url":"https://github.com/lightbend/helm-charts/pull/189","diff_url":"https://github.com/lightbend/helm-charts/pull/189.diff","patch_url":"https://github.com/lightbend/helm-charts/pull/189.patch","issue_url":"https://api.github.com/repos/lightbend/helm-charts/issues/189","number":189,"state":"open","locked":false,"title":"Make `./lbc.py install` try to reuse resources from previous failed install, also better python3 behaviour","user":{"login":"mitkus","id":1593852,"node_id":"MDQ6VXNlcjE1OTM4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1593852?v=4","gravatar_id":"","url":"https://api.github.com/users/mitkus","html_url":"https://github.com/mitkus","followers_url":"https://api.github.com/users/mitkus/followers","following_url":"https://api.github.com/users/mitkus/following{/other_user}","gists_url":"https://api.github.com/users/mitkus/gists{/gist_id}","starred_url":"https://api.github.com/users/mitkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitkus/subscriptions","organizations_url":"https://api.github.com/users/mitkus/orgs","repos_url":"https://api.github.com/users/mitkus/repos","events_url":"https://api.github.com/users/mitkus/events{/privacy}","received_events_url":"https://api.github.com/users/mitkus/received_events","type":"User","site_admin":false},"body":"For https://github.com/lightbend/es-backend/issues/433\r\n\r\nIn some cases, I get failed helm install where some resources still get created. After that, `./lbc.py install` tries to clean that up with `helm delete --purge`, but our policy for PVs prevents them from being deleted. This PR makes `lbc.py` check for existing PVs if previous install failed, just like when `--reuse-resources` flag is provided. This will work only on 1.0.0-rc.5 and later, on earlier versions it'll be a no-op because `--set createPersistentVolumes=false` value will be ignored by helm.\r\n\r\nAlso, this PR slightly improves running on python3 - instead of just complaining and quitting, now we try to spawn python2 process. Tested only on Mac OS so far.","created_at":"2018-11-19T08:07:48Z","updated_at":"2018-11-19T13:20:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a134b98a8e021175648902ab69735880e86c9a2","assignee":{"login":"mitkus","id":1593852,"node_id":"MDQ6VXNlcjE1OTM4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1593852?v=4","gravatar_id":"","url":"https://api.github.com/users/mitkus","html_url":"https://github.com/mitkus","followers_url":"https://api.github.com/users/mitkus/followers","following_url":"https://api.github.com/users/mitkus/following{/other_user}","gists_url":"https://api.github.com/users/mitkus/gists{/gist_id}","starred_url":"https://api.github.com/users/mitkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitkus/subscriptions","organizations_url":"https://api.github.com/users/mitkus/orgs","repos_url":"https://api.github.com/users/mitkus/repos","events_url":"https://api.github.com/users/mitkus/events{/privacy}","received_events_url":"https://api.github.com/users/mitkus/received_events","type":"User","site_admin":false},"assignees":[{"login":"mitkus","id":1593852,"node_id":"MDQ6VXNlcjE1OTM4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1593852?v=4","gravatar_id":"","url":"https://api.github.com/users/mitkus","html_url":"https://github.com/mitkus","followers_url":"https://api.github.com/users/mitkus/followers","following_url":"https://api.github.com/users/mitkus/following{/other_user}","gists_url":"https://api.github.com/users/mitkus/gists{/gist_id}","starred_url":"https://api.github.com/users/mitkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitkus/subscriptions","organizations_url":"https://api.github.com/users/mitkus/orgs","repos_url":"https://api.github.com/users/mitkus/repos","events_url":"https://api.github.com/users/mitkus/events{/privacy}","received_events_url":"https://api.github.com/users/mitkus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":992313180,"node_id":"MDU6TGFiZWw5OTIzMTMxODA=","url":"https://api.github.com/repos/lightbend/helm-charts/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lightbend/helm-charts/pulls/189/commits","review_comments_url":"https://api.github.com/repos/lightbend/helm-charts/pulls/189/comments","review_comment_url":"https://api.github.com/repos/lightbend/helm-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightbend/helm-charts/issues/189/comments","statuses_url":"https://api.github.com/repos/lightbend/helm-charts/statuses/a9b5acec6281dca10e18001e32c5e7ef1fc7c52d","head":{"label":"lightbend:lbcpy-improvements","ref":"lbcpy-improvements","sha":"a9b5acec6281dca10e18001e32c5e7ef1fc7c52d","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":113883631,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4ODM2MzE=","name":"helm-charts","full_name":"lightbend/helm-charts","private":false,"owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightbend/helm-charts","description":"Lightbend Console Helm Charts","fork":false,"url":"https://api.github.com/repos/lightbend/helm-charts","forks_url":"https://api.github.com/repos/lightbend/helm-charts/forks","keys_url":"https://api.github.com/repos/lightbend/helm-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/helm-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/helm-charts/teams","hooks_url":"https://api.github.com/repos/lightbend/helm-charts/hooks","issue_events_url":"https://api.github.com/repos/lightbend/helm-charts/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/helm-charts/events","assignees_url":"https://api.github.com/repos/lightbend/helm-charts/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/helm-charts/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/helm-charts/tags","blobs_url":"https://api.github.com/repos/lightbend/helm-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/helm-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/helm-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/helm-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/helm-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/helm-charts/languages","stargazers_url":"https://api.github.com/repos/lightbend/helm-charts/stargazers","contributors_url":"https://api.github.com/repos/lightbend/helm-charts/contributors","subscribers_url":"https://api.github.com/repos/lightbend/helm-charts/subscribers","subscription_url":"https://api.github.com/repos/lightbend/helm-charts/subscription","commits_url":"https://api.github.com/repos/lightbend/helm-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/helm-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/helm-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/helm-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/helm-charts/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/helm-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/helm-charts/merges","archive_url":"https://api.github.com/repos/lightbend/helm-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/helm-charts/downloads","issues_url":"https://api.github.com/repos/lightbend/helm-charts/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/helm-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/helm-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/helm-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/helm-charts/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/helm-charts/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/helm-charts/deployments","created_at":"2017-12-11T16:43:41Z","updated_at":"2018-11-16T18:43:47Z","pushed_at":"2018-11-19T13:13:10Z","git_url":"git://github.com/lightbend/helm-charts.git","ssh_url":"git@github.com:lightbend/helm-charts.git","clone_url":"https://github.com/lightbend/helm-charts.git","svn_url":"https://github.com/lightbend/helm-charts","homepage":"","size":2363,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":4,"watchers":7,"default_branch":"master"}},"base":{"label":"lightbend:master","ref":"master","sha":"81eea162d0e37a84922402594861a01f57d8045c","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":113883631,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM4ODM2MzE=","name":"helm-charts","full_name":"lightbend/helm-charts","private":false,"owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightbend/helm-charts","description":"Lightbend Console Helm Charts","fork":false,"url":"https://api.github.com/repos/lightbend/helm-charts","forks_url":"https://api.github.com/repos/lightbend/helm-charts/forks","keys_url":"https://api.github.com/repos/lightbend/helm-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/helm-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/helm-charts/teams","hooks_url":"https://api.github.com/repos/lightbend/helm-charts/hooks","issue_events_url":"https://api.github.com/repos/lightbend/helm-charts/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/helm-charts/events","assignees_url":"https://api.github.com/repos/lightbend/helm-charts/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/helm-charts/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/helm-charts/tags","blobs_url":"https://api.github.com/repos/lightbend/helm-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/helm-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/helm-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/helm-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/helm-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/helm-charts/languages","stargazers_url":"https://api.github.com/repos/lightbend/helm-charts/stargazers","contributors_url":"https://api.github.com/repos/lightbend/helm-charts/contributors","subscribers_url":"https://api.github.com/repos/lightbend/helm-charts/subscribers","subscription_url":"https://api.github.com/repos/lightbend/helm-charts/subscription","commits_url":"https://api.github.com/repos/lightbend/helm-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/helm-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/helm-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/helm-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/helm-charts/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/helm-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/helm-charts/merges","archive_url":"https://api.github.com/repos/lightbend/helm-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/helm-charts/downloads","issues_url":"https://api.github.com/repos/lightbend/helm-charts/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/helm-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/helm-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/helm-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/helm-charts/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/helm-charts/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/helm-charts/deployments","created_at":"2017-12-11T16:43:41Z","updated_at":"2018-11-16T18:43:47Z","pushed_at":"2018-11-19T13:13:10Z","git_url":"git://github.com/lightbend/helm-charts.git","ssh_url":"git@github.com:lightbend/helm-charts.git","clone_url":"https://github.com/lightbend/helm-charts.git","svn_url":"https://github.com/lightbend/helm-charts","homepage":"","size":2363,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightbend/helm-charts/pulls/189"},"html":{"href":"https://github.com/lightbend/helm-charts/pull/189"},"issue":{"href":"https://api.github.com/repos/lightbend/helm-charts/issues/189"},"comments":{"href":"https://api.github.com/repos/lightbend/helm-charts/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/lightbend/helm-charts/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/lightbend/helm-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightbend/helm-charts/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/lightbend/helm-charts/statuses/a9b5acec6281dca10e18001e32c5e7ef1fc7c52d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mitkus"}}