{"action":"created","comment":{"url":"https://api.github.com/repos/urish/ngx-moment/pulls/comments/236095343","pull_request_review_id":178102543,"id":236095343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA5NTM0Mw==","diff_hunk":"@@ -61,16 +61,16 @@ export class TimeAgoPipe implements PipeTransform, OnDestroy {\n     });\n   }\n \n-\n-  private removeTimer() {\n+  private removeTimer(): void {\n     if (this.currentTimer) {\n       window.clearTimeout(this.currentTimer);\n       this.currentTimer = null;\n     }\n   }\n \n-  private getSecondsUntilUpdate(momentInstance: moment.Moment) {\n+  private getSecondsUntilUpdate(momentInstance: moment.Moment): number {","path":"src/time-ago.pipe.ts","position":49,"original_position":49,"commit_id":"c3544b668470b98c190a169aa55a806d41b57306","original_commit_id":"c3544b668470b98c190a169aa55a806d41b57306","user":{"login":"urish","id":892318,"node_id":"MDQ6VXNlcjg5MjMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/892318?v=4","gravatar_id":"","url":"https://api.github.com/users/urish","html_url":"https://github.com/urish","followers_url":"https://api.github.com/users/urish/followers","following_url":"https://api.github.com/users/urish/following{/other_user}","gists_url":"https://api.github.com/users/urish/gists{/gist_id}","starred_url":"https://api.github.com/users/urish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urish/subscriptions","organizations_url":"https://api.github.com/users/urish/orgs","repos_url":"https://api.github.com/users/urish/repos","events_url":"https://api.github.com/users/urish/events{/privacy}","received_events_url":"https://api.github.com/users/urish/received_events","type":"User","site_admin":false},"body":"why add return type? TS should automatically infer this for us","created_at":"2018-11-25T23:11:38Z","updated_at":"2018-11-25T23:16:43Z","html_url":"https://github.com/urish/ngx-moment/pull/206#discussion_r236095343","pull_request_url":"https://api.github.com/repos/urish/ngx-moment/pulls/206","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/urish/ngx-moment/pulls/comments/236095343"},"html":{"href":"https://github.com/urish/ngx-moment/pull/206#discussion_r236095343"},"pull_request":{"href":"https://api.github.com/repos/urish/ngx-moment/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/urish/ngx-moment/pulls/206","id":231340575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzQwNTc1","html_url":"https://github.com/urish/ngx-moment/pull/206","diff_url":"https://github.com/urish/ngx-moment/pull/206.diff","patch_url":"https://github.com/urish/ngx-moment/pull/206.patch","issue_url":"https://api.github.com/repos/urish/ngx-moment/issues/206","number":206,"state":"open","locked":false,"title":"Allow using all supported Moment inputs with TimeAgoPipe","user":{"login":"theodorejb","id":3053271,"node_id":"MDQ6VXNlcjMwNTMyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3053271?v=4","gravatar_id":"","url":"https://api.github.com/users/theodorejb","html_url":"https://github.com/theodorejb","followers_url":"https://api.github.com/users/theodorejb/followers","following_url":"https://api.github.com/users/theodorejb/following{/other_user}","gists_url":"https://api.github.com/users/theodorejb/gists{/gist_id}","starred_url":"https://api.github.com/users/theodorejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodorejb/subscriptions","organizations_url":"https://api.github.com/users/theodorejb/orgs","repos_url":"https://api.github.com/users/theodorejb/repos","events_url":"https://api.github.com/users/theodorejb/events{/privacy}","received_events_url":"https://api.github.com/users/theodorejb/received_events","type":"User","site_admin":false},"body":"Makes it possible to use `TimeAgoPipe` with string/number dates when the `fullTemplateTypeCheck` Angular compiler option is enabled. Fixes #204.\r\n\r\nAlso enables type checking when running tests. Previously a test could contain a type error, but all tests would be reported as passing since ts-jest only uses TypeScript as a file preprocessor (see kulshekhar/ts-jest#79).\r\n\r\nThis is a non-breaking change which can be included in a minor/patch release.","created_at":"2018-11-15T21:30:19Z","updated_at":"2018-11-25T23:16:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe8d779fdb21e86c93b9f86ac79adbf1182f2ff4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urish/ngx-moment/pulls/206/commits","review_comments_url":"https://api.github.com/repos/urish/ngx-moment/pulls/206/comments","review_comment_url":"https://api.github.com/repos/urish/ngx-moment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urish/ngx-moment/issues/206/comments","statuses_url":"https://api.github.com/repos/urish/ngx-moment/statuses/c3544b668470b98c190a169aa55a806d41b57306","head":{"label":"theodorejb:support-full-template-type-check","ref":"support-full-template-type-check","sha":"c3544b668470b98c190a169aa55a806d41b57306","user":{"login":"theodorejb","id":3053271,"node_id":"MDQ6VXNlcjMwNTMyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3053271?v=4","gravatar_id":"","url":"https://api.github.com/users/theodorejb","html_url":"https://github.com/theodorejb","followers_url":"https://api.github.com/users/theodorejb/followers","following_url":"https://api.github.com/users/theodorejb/following{/other_user}","gists_url":"https://api.github.com/users/theodorejb/gists{/gist_id}","starred_url":"https://api.github.com/users/theodorejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodorejb/subscriptions","organizations_url":"https://api.github.com/users/theodorejb/orgs","repos_url":"https://api.github.com/users/theodorejb/repos","events_url":"https://api.github.com/users/theodorejb/events{/privacy}","received_events_url":"https://api.github.com/users/theodorejb/received_events","type":"User","site_admin":false},"repo":{"id":154351897,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzNTE4OTc=","name":"ngx-moment","full_name":"theodorejb/ngx-moment","private":false,"owner":{"login":"theodorejb","id":3053271,"node_id":"MDQ6VXNlcjMwNTMyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3053271?v=4","gravatar_id":"","url":"https://api.github.com/users/theodorejb","html_url":"https://github.com/theodorejb","followers_url":"https://api.github.com/users/theodorejb/followers","following_url":"https://api.github.com/users/theodorejb/following{/other_user}","gists_url":"https://api.github.com/users/theodorejb/gists{/gist_id}","starred_url":"https://api.github.com/users/theodorejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodorejb/subscriptions","organizations_url":"https://api.github.com/users/theodorejb/orgs","repos_url":"https://api.github.com/users/theodorejb/repos","events_url":"https://api.github.com/users/theodorejb/events{/privacy}","received_events_url":"https://api.github.com/users/theodorejb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/theodorejb/ngx-moment","description":"moment.js pipes for Angular","fork":true,"url":"https://api.github.com/repos/theodorejb/ngx-moment","forks_url":"https://api.github.com/repos/theodorejb/ngx-moment/forks","keys_url":"https://api.github.com/repos/theodorejb/ngx-moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theodorejb/ngx-moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theodorejb/ngx-moment/teams","hooks_url":"https://api.github.com/repos/theodorejb/ngx-moment/hooks","issue_events_url":"https://api.github.com/repos/theodorejb/ngx-moment/issues/events{/number}","events_url":"https://api.github.com/repos/theodorejb/ngx-moment/events","assignees_url":"https://api.github.com/repos/theodorejb/ngx-moment/assignees{/user}","branches_url":"https://api.github.com/repos/theodorejb/ngx-moment/branches{/branch}","tags_url":"https://api.github.com/repos/theodorejb/ngx-moment/tags","blobs_url":"https://api.github.com/repos/theodorejb/ngx-moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theodorejb/ngx-moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theodorejb/ngx-moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/theodorejb/ngx-moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theodorejb/ngx-moment/statuses/{sha}","languages_url":"https://api.github.com/repos/theodorejb/ngx-moment/languages","stargazers_url":"https://api.github.com/repos/theodorejb/ngx-moment/stargazers","contributors_url":"https://api.github.com/repos/theodorejb/ngx-moment/contributors","subscribers_url":"https://api.github.com/repos/theodorejb/ngx-moment/subscribers","subscription_url":"https://api.github.com/repos/theodorejb/ngx-moment/subscription","commits_url":"https://api.github.com/repos/theodorejb/ngx-moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/theodorejb/ngx-moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/theodorejb/ngx-moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/theodorejb/ngx-moment/issues/comments{/number}","contents_url":"https://api.github.com/repos/theodorejb/ngx-moment/contents/{+path}","compare_url":"https://api.github.com/repos/theodorejb/ngx-moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theodorejb/ngx-moment/merges","archive_url":"https://api.github.com/repos/theodorejb/ngx-moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theodorejb/ngx-moment/downloads","issues_url":"https://api.github.com/repos/theodorejb/ngx-moment/issues{/number}","pulls_url":"https://api.github.com/repos/theodorejb/ngx-moment/pulls{/number}","milestones_url":"https://api.github.com/repos/theodorejb/ngx-moment/milestones{/number}","notifications_url":"https://api.github.com/repos/theodorejb/ngx-moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theodorejb/ngx-moment/labels{/name}","releases_url":"https://api.github.com/repos/theodorejb/ngx-moment/releases{/id}","deployments_url":"https://api.github.com/repos/theodorejb/ngx-moment/deployments","created_at":"2018-10-23T15:24:33Z","updated_at":"2018-11-15T19:54:11Z","pushed_at":"2018-11-15T21:21:45Z","git_url":"git://github.com/theodorejb/ngx-moment.git","ssh_url":"git@github.com:theodorejb/ngx-moment.git","clone_url":"https://github.com/theodorejb/ngx-moment.git","svn_url":"https://github.com/theodorejb/ngx-moment","homepage":"","size":456,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urish:master","ref":"master","sha":"ef73d5234d932177670a78b1f2a2de2f714cfcc7","user":{"login":"urish","id":892318,"node_id":"MDQ6VXNlcjg5MjMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/892318?v=4","gravatar_id":"","url":"https://api.github.com/users/urish","html_url":"https://github.com/urish","followers_url":"https://api.github.com/users/urish/followers","following_url":"https://api.github.com/users/urish/following{/other_user}","gists_url":"https://api.github.com/users/urish/gists{/gist_id}","starred_url":"https://api.github.com/users/urish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urish/subscriptions","organizations_url":"https://api.github.com/users/urish/orgs","repos_url":"https://api.github.com/users/urish/repos","events_url":"https://api.github.com/users/urish/events{/privacy}","received_events_url":"https://api.github.com/users/urish/received_events","type":"User","site_admin":false},"repo":{"id":41093724,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5MzcyNA==","name":"ngx-moment","full_name":"urish/ngx-moment","private":false,"owner":{"login":"urish","id":892318,"node_id":"MDQ6VXNlcjg5MjMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/892318?v=4","gravatar_id":"","url":"https://api.github.com/users/urish","html_url":"https://github.com/urish","followers_url":"https://api.github.com/users/urish/followers","following_url":"https://api.github.com/users/urish/following{/other_user}","gists_url":"https://api.github.com/users/urish/gists{/gist_id}","starred_url":"https://api.github.com/users/urish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urish/subscriptions","organizations_url":"https://api.github.com/users/urish/orgs","repos_url":"https://api.github.com/users/urish/repos","events_url":"https://api.github.com/users/urish/events{/privacy}","received_events_url":"https://api.github.com/users/urish/received_events","type":"User","site_admin":false},"html_url":"https://github.com/urish/ngx-moment","description":"moment.js pipes for Angular","fork":false,"url":"https://api.github.com/repos/urish/ngx-moment","forks_url":"https://api.github.com/repos/urish/ngx-moment/forks","keys_url":"https://api.github.com/repos/urish/ngx-moment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urish/ngx-moment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urish/ngx-moment/teams","hooks_url":"https://api.github.com/repos/urish/ngx-moment/hooks","issue_events_url":"https://api.github.com/repos/urish/ngx-moment/issues/events{/number}","events_url":"https://api.github.com/repos/urish/ngx-moment/events","assignees_url":"https://api.github.com/repos/urish/ngx-moment/assignees{/user}","branches_url":"https://api.github.com/repos/urish/ngx-moment/branches{/branch}","tags_url":"https://api.github.com/repos/urish/ngx-moment/tags","blobs_url":"https://api.github.com/repos/urish/ngx-moment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urish/ngx-moment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urish/ngx-moment/git/refs{/sha}","trees_url":"https://api.github.com/repos/urish/ngx-moment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urish/ngx-moment/statuses/{sha}","languages_url":"https://api.github.com/repos/urish/ngx-moment/languages","stargazers_url":"https://api.github.com/repos/urish/ngx-moment/stargazers","contributors_url":"https://api.github.com/repos/urish/ngx-moment/contributors","subscribers_url":"https://api.github.com/repos/urish/ngx-moment/subscribers","subscription_url":"https://api.github.com/repos/urish/ngx-moment/subscription","commits_url":"https://api.github.com/repos/urish/ngx-moment/commits{/sha}","git_commits_url":"https://api.github.com/repos/urish/ngx-moment/git/commits{/sha}","comments_url":"https://api.github.com/repos/urish/ngx-moment/comments{/number}","issue_comment_url":"https://api.github.com/repos/urish/ngx-moment/issues/comments{/number}","contents_url":"https://api.github.com/repos/urish/ngx-moment/contents/{+path}","compare_url":"https://api.github.com/repos/urish/ngx-moment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urish/ngx-moment/merges","archive_url":"https://api.github.com/repos/urish/ngx-moment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urish/ngx-moment/downloads","issues_url":"https://api.github.com/repos/urish/ngx-moment/issues{/number}","pulls_url":"https://api.github.com/repos/urish/ngx-moment/pulls{/number}","milestones_url":"https://api.github.com/repos/urish/ngx-moment/milestones{/number}","notifications_url":"https://api.github.com/repos/urish/ngx-moment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urish/ngx-moment/labels{/name}","releases_url":"https://api.github.com/repos/urish/ngx-moment/releases{/id}","deployments_url":"https://api.github.com/repos/urish/ngx-moment/deployments","created_at":"2015-08-20T12:11:42Z","updated_at":"2018-11-20T22:50:32Z","pushed_at":"2018-11-15T21:30:20Z","git_url":"git://github.com/urish/ngx-moment.git","ssh_url":"git@github.com:urish/ngx-moment.git","clone_url":"https://github.com/urish/ngx-moment.git","svn_url":"https://github.com/urish/ngx-moment","homepage":"","size":511,"stargazers_count":941,"watchers_count":941,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":127,"open_issues":36,"watchers":941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urish/ngx-moment/pulls/206"},"html":{"href":"https://github.com/urish/ngx-moment/pull/206"},"issue":{"href":"https://api.github.com/repos/urish/ngx-moment/issues/206"},"comments":{"href":"https://api.github.com/repos/urish/ngx-moment/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/urish/ngx-moment/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/urish/ngx-moment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urish/ngx-moment/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/urish/ngx-moment/statuses/c3544b668470b98c190a169aa55a806d41b57306"}},"author_association":"NONE"}}
{"actor":{"display_login":"urish"}}