{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/veneur/issues/378","repository_url":"https://api.github.com/repos/stripe/veneur","labels_url":"https://api.github.com/repos/stripe/veneur/issues/378/labels{/name}","comments_url":"https://api.github.com/repos/stripe/veneur/issues/378/comments","events_url":"https://api.github.com/repos/stripe/veneur/issues/378/events","html_url":"https://github.com/stripe/veneur/pull/378","id":295192672,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3NzMzODA2","number":378,"title":"Local veneur server: Add timeouts for forwarding, make events flushes parallel","user":{"login":"asf-stripe","id":23062936,"node_id":"MDQ6VXNlcjIzMDYyOTM2","avatar_url":"https://avatars0.githubusercontent.com/u/23062936?v=4","gravatar_id":"","url":"https://api.github.com/users/asf-stripe","html_url":"https://github.com/asf-stripe","followers_url":"https://api.github.com/users/asf-stripe/followers","following_url":"https://api.github.com/users/asf-stripe/following{/other_user}","gists_url":"https://api.github.com/users/asf-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/asf-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asf-stripe/subscriptions","organizations_url":"https://api.github.com/users/asf-stripe/orgs","repos_url":"https://api.github.com/users/asf-stripe/repos","events_url":"https://api.github.com/users/asf-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/asf-stripe/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"aditya-stripe","id":23102724,"node_id":"MDQ6VXNlcjIzMTAyNzI0","avatar_url":"https://avatars0.githubusercontent.com/u/23102724?v=4","gravatar_id":"","url":"https://api.github.com/users/aditya-stripe","html_url":"https://github.com/aditya-stripe","followers_url":"https://api.github.com/users/aditya-stripe/followers","following_url":"https://api.github.com/users/aditya-stripe/following{/other_user}","gists_url":"https://api.github.com/users/aditya-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya-stripe/subscriptions","organizations_url":"https://api.github.com/users/aditya-stripe/orgs","repos_url":"https://api.github.com/users/aditya-stripe/repos","events_url":"https://api.github.com/users/aditya-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/aditya-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"aditya-stripe","id":23102724,"node_id":"MDQ6VXNlcjIzMTAyNzI0","avatar_url":"https://avatars0.githubusercontent.com/u/23102724?v=4","gravatar_id":"","url":"https://api.github.com/users/aditya-stripe","html_url":"https://github.com/aditya-stripe","followers_url":"https://api.github.com/users/aditya-stripe/followers","following_url":"https://api.github.com/users/aditya-stripe/following{/other_user}","gists_url":"https://api.github.com/users/aditya-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya-stripe/subscriptions","organizations_url":"https://api.github.com/users/aditya-stripe/orgs","repos_url":"https://api.github.com/users/aditya-stripe/repos","events_url":"https://api.github.com/users/aditya-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/aditya-stripe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-02-07T16:00:55Z","updated_at":"2018-09-07T19:17:12Z","closed_at":"2018-09-07T19:17:12Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stripe/veneur/pulls/378","html_url":"https://github.com/stripe/veneur/pull/378","diff_url":"https://github.com/stripe/veneur/pull/378.diff","patch_url":"https://github.com/stripe/veneur/pull/378.patch"},"body":"<!-- Checklist For PRs\r\n\r\n* Ensure you've written tests where applicable\r\n* Add a CHANGELOG.md entry describing your change, thank yourself!\r\n* Document any changes to metrics or configuration\r\n-->\r\n\r\n\r\n#### Summary\r\nThis PR adds config options `forward_timeout`, `metrics_flush_timeout` and `span_flush_timeout`, controlling timeouts for each of these operations. This should help veneur avoid scenarios where an inability to quickly send metric batches (either upstream or to ~any of its storage backends) causes it to accumulate spans/metrics in memory and OOM the machine.\r\n\r\n#### Motivation\r\nSetting timeouts is good!\r\n\r\n\r\n#### Test plan\r\nAdded regression tests, but we should also test this in a live system to ensure it actually errors in these cases.\r\n\r\n\r\n#### Rollout/monitoring/revert plan\r\nMerge & run!\r\n"},"comment":{"url":"https://api.github.com/repos/stripe/veneur/issues/comments/419538938","html_url":"https://github.com/stripe/veneur/pull/378#issuecomment-419538938","issue_url":"https://api.github.com/repos/stripe/veneur/issues/378","id":419538938,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUzODkzOA==","user":{"login":"ChimeraCoder","id":376414,"node_id":"MDQ6VXNlcjM3NjQxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/376414?v=4","gravatar_id":"","url":"https://api.github.com/users/ChimeraCoder","html_url":"https://github.com/ChimeraCoder","followers_url":"https://api.github.com/users/ChimeraCoder/followers","following_url":"https://api.github.com/users/ChimeraCoder/following{/other_user}","gists_url":"https://api.github.com/users/ChimeraCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ChimeraCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChimeraCoder/subscriptions","organizations_url":"https://api.github.com/users/ChimeraCoder/orgs","repos_url":"https://api.github.com/users/ChimeraCoder/repos","events_url":"https://api.github.com/users/ChimeraCoder/events{/privacy}","received_events_url":"https://api.github.com/users/ChimeraCoder/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T19:17:12Z","updated_at":"2018-09-07T19:17:12Z","author_association":"COLLABORATOR","body":"I believe this is no longer necessary, but please reopen if I'm mistaken"}}
{"actor":{"display_login":"ChimeraCoder"}}