{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/comments/208936100","pull_request_review_id":144848723,"id":208936100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODkzNjEwMA==","diff_hunk":"@@ -86,11 +172,11 @@ class PlanWizard extends React.Component {\n         setMigrationsFilterAction(MIGRATIONS_FILTERS.notStarted);\n       }\n       this.setState({\n-        activeStepIndex: Math.min(activeStepIndex + 1, planWizardSteps.length - 1)\n+        activeStepIndex: Math.min(activeStepIndex + 1, wizardSteps.length - 1)\n       });\n     } else {\n       this.setState({\n-        activeStepIndex: Math.min(activeStepIndex + 1, planWizardSteps.length - 1)\n+        activeStepIndex: Math.min(activeStepIndex + 1, wizardSteps.length - 1)","path":"app/javascript/react/screens/App/Overview/screens/PlanWizard/PlanWizard.js","position":166,"original_position":166,"commit_id":"04a933b657da52f31423599d168e04a4f2900766","original_commit_id":"04a933b657da52f31423599d168e04a4f2900766","user":{"login":"michaelkro","id":15141412,"node_id":"MDQ6VXNlcjE1MTQxNDEy","avatar_url":"https://avatars3.githubusercontent.com/u/15141412?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkro","html_url":"https://github.com/michaelkro","followers_url":"https://api.github.com/users/michaelkro/followers","following_url":"https://api.github.com/users/michaelkro/following{/other_user}","gists_url":"https://api.github.com/users/michaelkro/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkro/subscriptions","organizations_url":"https://api.github.com/users/michaelkro/orgs","repos_url":"https://api.github.com/users/michaelkro/repos","events_url":"https://api.github.com/users/michaelkro/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkro/received_events","type":"User","site_admin":false},"body":"I'm sure I'm missing something, but I'm not sure I follow why we're still using the array index to track the active step if we're introducing `id`s for each step","created_at":"2018-08-09T13:50:28Z","updated_at":"2018-08-09T13:50:37Z","html_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547#discussion_r208936100","pull_request_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/comments/208936100"},"html":{"href":"https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547#discussion_r208936100"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547","id":206533766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTMzNzY2","html_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547","diff_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547.diff","patch_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547.patch","issue_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues/547","number":547,"state":"open","locked":false,"title":"[WIP][#546] OSP Support: Add Instance Properties step in Plan Wizard for OpenStack","user":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"body":"Closes #546 \r\n\r\n- [x] Add step to Plan Wizard conditionally on the special mapping name `fake-osp-mapping`.\r\n- [x] Refactor Plan Wizard to use string identifiers instead of step indexes in logic\r\n- [x] Replace `fake-osp-mapping` condition with detection of an actual Openstack target\r\n- [ ] Add the table of instance properties per mockup to the new step\r\n- [ ] Add edit functions to this table, connected to dummy Redux state\r\n- [ ] Connect dummy Redux state to API\r\n- [ ] CSS fix: the Instance Properties and Advanced Options step titles look bad when they render on 2 lines\r\n- [ ] Double check after API changes that we are detecting an OSP mapping properly","created_at":"2018-08-06T22:31:31Z","updated_at":"2018-08-09T13:50:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e229e01c72d8f0b75384affcf3d49e3e09ed9c","assignee":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"assignees":[{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1012834059,"node_id":"MDU6TGFiZWwxMDEyODM0MDU5","url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/labels/Sprint%2012","name":"Sprint 12","color":"335e9b","default":false},{"id":939988325,"node_id":"MDU6TGFiZWw5Mzk5ODgzMjU=","url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/labels/gaprindashvili/no","name":"gaprindashvili/no","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues/547/comments","statuses_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/statuses/04a933b657da52f31423599d168e04a4f2900766","head":{"label":"mturley:osp-instance-properties-step","ref":"osp-instance-properties-step","sha":"04a933b657da52f31423599d168e04a4f2900766","user":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"repo":{"id":120580525,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA1ODA1MjU=","name":"miq_v2v_ui_plugin","full_name":"mturley/miq_v2v_ui_plugin","owner":{"login":"mturley","id":811963,"node_id":"MDQ6VXNlcjgxMTk2Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/811963?v=4","gravatar_id":"","url":"https://api.github.com/users/mturley","html_url":"https://github.com/mturley","followers_url":"https://api.github.com/users/mturley/followers","following_url":"https://api.github.com/users/mturley/following{/other_user}","gists_url":"https://api.github.com/users/mturley/gists{/gist_id}","starred_url":"https://api.github.com/users/mturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mturley/subscriptions","organizations_url":"https://api.github.com/users/mturley/orgs","repos_url":"https://api.github.com/users/mturley/repos","events_url":"https://api.github.com/users/mturley/events{/privacy}","received_events_url":"https://api.github.com/users/mturley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mturley/miq_v2v_ui_plugin","description":"v2v React UI plugin for mIQ","fork":true,"url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin","forks_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/forks","keys_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/teams","hooks_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/hooks","issue_events_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/issues/events{/number}","events_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/events","assignees_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/assignees{/user}","branches_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/branches{/branch}","tags_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/tags","blobs_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/languages","stargazers_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/stargazers","contributors_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/contributors","subscribers_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/subscribers","subscription_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/subscription","commits_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/contents/{+path}","compare_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/merges","archive_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/downloads","issues_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/issues{/number}","pulls_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/labels{/name}","releases_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/releases{/id}","deployments_url":"https://api.github.com/repos/mturley/miq_v2v_ui_plugin/deployments","created_at":"2018-02-07T07:39:04Z","updated_at":"2018-06-04T16:28:00Z","pushed_at":"2018-08-08T21:22:35Z","git_url":"git://github.com/mturley/miq_v2v_ui_plugin.git","ssh_url":"git@github.com:mturley/miq_v2v_ui_plugin.git","clone_url":"https://github.com/mturley/miq_v2v_ui_plugin.git","svn_url":"https://github.com/mturley/miq_v2v_ui_plugin","homepage":null,"size":18316,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"e24ed6627bd6a2d47db5669a7d04b6c9efe9589e","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":118279623,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyNzk2MjM=","name":"miq_v2v_ui_plugin","full_name":"ManageIQ/miq_v2v_ui_plugin","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin","description":"ManageIQ plugin for v2v transformations","fork":false,"url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin","forks_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/forks","keys_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/teams","hooks_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/events","assignees_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/tags","blobs_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/subscription","commits_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/merges","archive_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/downloads","issues_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/deployments","created_at":"2018-01-20T20:50:31Z","updated_at":"2018-08-08T19:07:38Z","pushed_at":"2018-08-09T13:16:15Z","git_url":"git://github.com/ManageIQ/miq_v2v_ui_plugin.git","ssh_url":"git@github.com:ManageIQ/miq_v2v_ui_plugin.git","clone_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin.git","svn_url":"https://github.com/ManageIQ/miq_v2v_ui_plugin","homepage":"","size":18321,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":23,"open_issues":49,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547"},"html":{"href":"https://github.com/ManageIQ/miq_v2v_ui_plugin/pull/547"},"issue":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues/547"},"comments":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/issues/547/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/pulls/547/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/miq_v2v_ui_plugin/statuses/04a933b657da52f31423599d168e04a4f2900766"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michaelkro"}}