{"action":"created","comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/210814795","pull_request_review_id":147109768,"id":210814795,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDgxNDc5NQ==","diff_hunk":"@@ -1124,11 +1124,13 @@ __wt_las_sweep(WT_SESSION_IMPL *session)\n #endif\n \n \t\t/*\n-\t\t * If this entry isn't globally visible we cannot remove it.\n-\t\t * If it is visible then perform additional checks to see\n-\t\t * whether it has aged out of a live file.\n+\t\t * If this entry isn't globally visible or if it is a part of a\n+\t\t * prepared transaction, then we cannot remove it. Otherwise,\n+\t\t * perform additional checks to see whether it has aged out of a\n+\t\t * live file.\n \t\t */\n-\t\tif (!__wt_txn_visible_all(session, las_txnid, val_ts)) {\n+\t\tif (!__wt_txn_visible_all(session, las_txnid, val_ts) ||\n+\t\t    prepare_state == WT_PREPARE_INPROGRESS) {","path":"src/cache/cache_las.c","position":51,"original_position":51,"commit_id":"456c6716709ae871ac34b10b15ba9501f8b46aa1","original_commit_id":"456c6716709ae871ac34b10b15ba9501f8b46aa1","user":{"login":"agorrod","id":1930121,"node_id":"MDQ6VXNlcjE5MzAxMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/1930121?v=4","gravatar_id":"","url":"https://api.github.com/users/agorrod","html_url":"https://github.com/agorrod","followers_url":"https://api.github.com/users/agorrod/followers","following_url":"https://api.github.com/users/agorrod/following{/other_user}","gists_url":"https://api.github.com/users/agorrod/gists{/gist_id}","starred_url":"https://api.github.com/users/agorrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agorrod/subscriptions","organizations_url":"https://api.github.com/users/agorrod/orgs","repos_url":"https://api.github.com/users/agorrod/repos","events_url":"https://api.github.com/users/agorrod/events{/privacy}","received_events_url":"https://api.github.com/users/agorrod/received_events","type":"User","site_admin":false},"body":"Why don't you need to check other prepared states here?","created_at":"2018-08-17T06:24:32Z","updated_at":"2018-08-17T06:30:27Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/4215#discussion_r210814795","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/210814795"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/4215#discussion_r210814795"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215"}}},"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215","id":208162908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTYyOTA4","html_url":"https://github.com/wiredtiger/wiredtiger/pull/4215","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/4215.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/4215.patch","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4215","number":4215,"state":"open","locked":false,"title":"WT-4212 Modify lookaside schema to carry prepared update state","user":{"login":"sulabhM","id":19491057,"node_id":"MDQ6VXNlcjE5NDkxMDU3","avatar_url":"https://avatars2.githubusercontent.com/u/19491057?v=4","gravatar_id":"","url":"https://api.github.com/users/sulabhM","html_url":"https://github.com/sulabhM","followers_url":"https://api.github.com/users/sulabhM/followers","following_url":"https://api.github.com/users/sulabhM/following{/other_user}","gists_url":"https://api.github.com/users/sulabhM/gists{/gist_id}","starred_url":"https://api.github.com/users/sulabhM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulabhM/subscriptions","organizations_url":"https://api.github.com/users/sulabhM/orgs","repos_url":"https://api.github.com/users/sulabhM/repos","events_url":"https://api.github.com/users/sulabhM/events{/privacy}","received_events_url":"https://api.github.com/users/sulabhM/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-14T04:00:20Z","updated_at":"2018-08-17T06:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"765116cd5755306898ae271a42beac50c275b279","assignee":{"login":"sulabhM","id":19491057,"node_id":"MDQ6VXNlcjE5NDkxMDU3","avatar_url":"https://avatars2.githubusercontent.com/u/19491057?v=4","gravatar_id":"","url":"https://api.github.com/users/sulabhM","html_url":"https://github.com/sulabhM","followers_url":"https://api.github.com/users/sulabhM/followers","following_url":"https://api.github.com/users/sulabhM/following{/other_user}","gists_url":"https://api.github.com/users/sulabhM/gists{/gist_id}","starred_url":"https://api.github.com/users/sulabhM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulabhM/subscriptions","organizations_url":"https://api.github.com/users/sulabhM/orgs","repos_url":"https://api.github.com/users/sulabhM/repos","events_url":"https://api.github.com/users/sulabhM/events{/privacy}","received_events_url":"https://api.github.com/users/sulabhM/received_events","type":"User","site_admin":false},"assignees":[{"login":"sulabhM","id":19491057,"node_id":"MDQ6VXNlcjE5NDkxMDU3","avatar_url":"https://avatars2.githubusercontent.com/u/19491057?v=4","gravatar_id":"","url":"https://api.github.com/users/sulabhM","html_url":"https://github.com/sulabhM","followers_url":"https://api.github.com/users/sulabhM/followers","following_url":"https://api.github.com/users/sulabhM/following{/other_user}","gists_url":"https://api.github.com/users/sulabhM/gists{/gist_id}","starred_url":"https://api.github.com/users/sulabhM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulabhM/subscriptions","organizations_url":"https://api.github.com/users/sulabhM/orgs","repos_url":"https://api.github.com/users/sulabhM/repos","events_url":"https://api.github.com/users/sulabhM/events{/privacy}","received_events_url":"https://api.github.com/users/sulabhM/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215/commits","review_comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215/comments","review_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4215/comments","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/456c6716709ae871ac34b10b15ba9501f8b46aa1","head":{"label":"wiredtiger:wt-4212-las-schema","ref":"wt-4212-las-schema","sha":"456c6716709ae871ac34b10b15ba9501f8b46aa1","user":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0MzAy","name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2018-08-16T08:41:38Z","pushed_at":"2018-08-17T03:40:14Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":83155,"stargazers_count":1232,"watchers_count":1232,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":207,"open_issues":8,"watchers":1232,"default_branch":"master"}},"base":{"label":"wiredtiger:develop","ref":"develop","sha":"ec6aff799abfca3ee5395489177525bf4cb96037","user":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0MzAy","name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2018-08-16T08:41:38Z","pushed_at":"2018-08-17T03:40:14Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":83155,"stargazers_count":1232,"watchers_count":1232,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":207,"open_issues":8,"watchers":1232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/4215"},"issue":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4215"},"comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4215/comments"},"review_comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215/comments"},"review_comment":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4215/commits"},"statuses":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/456c6716709ae871ac34b10b15ba9501f8b46aa1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"agorrod"}}