{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25002","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25002/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25002/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25002/events","html_url":"https://github.com/Automattic/wp-calypso/pull/25002","id":325364799,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NzE2ODE2","number":25002,"title":"Framework: Move to using npm 6 (6.1.0)","user":{"login":"blowery","id":14350,"node_id":"MDQ6VXNlcjE0MzUw","avatar_url":"https://avatars1.githubusercontent.com/u/14350?v=4","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},"labels":[{"id":285010074,"node_id":"MDU6TGFiZWwyODUwMTAwNzQ=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Build","name":"Build","color":"bfdadc","default":false},{"id":285009988,"node_id":"MDU6TGFiZWwyODUwMDk5ODg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"c5def5","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":838866001,"node_id":"MDU6TGFiZWw4Mzg4NjYwMDE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20e2e%20Testing","name":"[Status] Needs e2e Testing","color":"ed74b2","default":false}],"state":"open","locked":false,"assignee":{"login":"blowery","id":14350,"node_id":"MDQ6VXNlcjE0MzUw","avatar_url":"https://avatars1.githubusercontent.com/u/14350?v=4","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false},"assignees":[{"login":"blowery","id":14350,"node_id":"MDQ6VXNlcjE0MzUw","avatar_url":"https://avatars1.githubusercontent.com/u/14350?v=4","gravatar_id":"","url":"https://api.github.com/users/blowery","html_url":"https://github.com/blowery","followers_url":"https://api.github.com/users/blowery/followers","following_url":"https://api.github.com/users/blowery/following{/other_user}","gists_url":"https://api.github.com/users/blowery/gists{/gist_id}","starred_url":"https://api.github.com/users/blowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blowery/subscriptions","organizations_url":"https://api.github.com/users/blowery/orgs","repos_url":"https://api.github.com/users/blowery/repos","events_url":"https://api.github.com/users/blowery/events{/privacy}","received_events_url":"https://api.github.com/users/blowery/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-05-22T16:09:36Z","updated_at":"2018-06-07T14:10:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/25002","html_url":"https://github.com/Automattic/wp-calypso/pull/25002","diff_url":"https://github.com/Automattic/wp-calypso/pull/25002.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/25002.patch"},"body":"Let's move to a current npm.\r\n\r\n[More recent releases](https://github.com/npm/npm/releases) are faster, offer new security auditing support, and generally have fewer bugs.\r\n\r\nThe main bug we're aiming to fix is https://github.com/npm/npm/issues/17379. Dependencies that come directly from git get pruned incorrectly in versions prior to 5.7.1. In addition, 5.8+ have more fixes that target the same issue. \r\n\r\n## Testing\r\nCheckout this PR locally\r\n`npm install -g npm@6.1.0`\r\n`npm run distclean`\r\n`npm test`\r\n`npm start`\r\n\r\nCompare `npm install` both with and without a node_modules present on this PR and master\r\nTry out `npm ci` if you want to smile."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/395434323","html_url":"https://github.com/Automattic/wp-calypso/pull/25002#issuecomment-395434323","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/25002","id":395434323,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTQzNDMyMw==","user":{"login":"rarkins","id":6311784,"node_id":"MDQ6VXNlcjYzMTE3ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6311784?v=4","gravatar_id":"","url":"https://api.github.com/users/rarkins","html_url":"https://github.com/rarkins","followers_url":"https://api.github.com/users/rarkins/followers","following_url":"https://api.github.com/users/rarkins/following{/other_user}","gists_url":"https://api.github.com/users/rarkins/gists{/gist_id}","starred_url":"https://api.github.com/users/rarkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rarkins/subscriptions","organizations_url":"https://api.github.com/users/rarkins/orgs","repos_url":"https://api.github.com/users/rarkins/repos","events_url":"https://api.github.com/users/rarkins/events{/privacy}","received_events_url":"https://api.github.com/users/rarkins/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T14:10:46Z","updated_at":"2018-06-07T14:10:46Z","author_association":"NONE","body":"@blowery I the npm cli team have been moving pretty fast lately, so it makes 5.6 *seem* stale. While on the topic:\r\n\r\n1. Is there any reason to keep using npm-shrinkwrap.json rather than regular package-lock.json? They're literally the same content/format these days, and I think shrinkwrap is only really needed if you publish via npm and want *downstream* dependencies to use your exact versions.\r\n\r\n2. You may now also be interested in whether `npm ci` speeds things up in dev and/or CI. It installs directly from the lock file and is faster than `npm install`, so should benefit any scenario where you're *not* intentionally updating the `package.json` or lock file."}}
{"actor":{"display_login":"rarkins"}}