{"action":"created","issue":{"url":"https://api.github.com/repos/codeship/codeship-pro-tutorial/issues/7","repository_url":"https://api.github.com/repos/codeship/codeship-pro-tutorial","labels_url":"https://api.github.com/repos/codeship/codeship-pro-tutorial/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/codeship/codeship-pro-tutorial/issues/7/comments","events_url":"https://api.github.com/repos/codeship/codeship-pro-tutorial/issues/7/events","html_url":"https://github.com/codeship/codeship-pro-tutorial/issues/7","id":134931933,"number":7,"title":"Circular links should be supported","user":{"login":"kreisys","id":1857338,"avatar_url":"https://avatars3.githubusercontent.com/u/1857338?v=4","gravatar_id":"","url":"https://api.github.com/users/kreisys","html_url":"https://github.com/kreisys","followers_url":"https://api.github.com/users/kreisys/followers","following_url":"https://api.github.com/users/kreisys/following{/other_user}","gists_url":"https://api.github.com/users/kreisys/gists{/gist_id}","starred_url":"https://api.github.com/users/kreisys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kreisys/subscriptions","organizations_url":"https://api.github.com/users/kreisys/orgs","repos_url":"https://api.github.com/users/kreisys/repos","events_url":"https://api.github.com/users/kreisys/events{/privacy}","received_events_url":"https://api.github.com/users/kreisys/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-02-19T17:55:42Z","updated_at":"2018-02-15T15:45:36Z","closed_at":"2016-02-26T04:39:26Z","author_association":"NONE","body":"So I'm having the following use case:\n\n``` yaml\napp_test:\n  image: myapp\n  links:\n    - selenium\n    - selenium_firefox\n\nselenium:\n  image: selenium/hub\n\nselenium_firefox:\n  image: selenium/node-firefox\n  links:\n    - selenium:hub\n    - app_test\n```\n\nSo when using the official Selenium images you need to create a container for the \"hub\" and then create containers for each node and link them to the hub. The link direction has to be node->hub. Now my app needs to be linked to the selenium hub to be able to run selenium tests. It does not need to know about the selenium node (selenium_firefox) but it is linked anyway because links govern which containers will be started.... However, the selenium node does need to know about my app container in order for it to run tests against it. I'm stuck now because with this configuration jet complains:\n\n```\nservices file error: Circular loop between services app_test and selenium_firefox\n```\n\nUnless I'm missing something I understand that links are used as hints to tell jets which services have to be launched along with each service. Apparently this doesn't work for all cases. Also, a potential bug: if I give app_test an alias in the links array (app_test:app for example) then the circular loop is not detected and jet happily runs and ends up in an infinite loop :)\n"},"comment":{"url":"https://api.github.com/repos/codeship/codeship-pro-tutorial/issues/comments/365967329","html_url":"https://github.com/codeship/codeship-pro-tutorial/issues/7#issuecomment-365967329","issue_url":"https://api.github.com/repos/codeship/codeship-pro-tutorial/issues/7","id":365967329,"user":{"login":"rheinwein","id":775634,"avatar_url":"https://avatars3.githubusercontent.com/u/775634?v=4","gravatar_id":"","url":"https://api.github.com/users/rheinwein","html_url":"https://github.com/rheinwein","followers_url":"https://api.github.com/users/rheinwein/followers","following_url":"https://api.github.com/users/rheinwein/following{/other_user}","gists_url":"https://api.github.com/users/rheinwein/gists{/gist_id}","starred_url":"https://api.github.com/users/rheinwein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rheinwein/subscriptions","organizations_url":"https://api.github.com/users/rheinwein/orgs","repos_url":"https://api.github.com/users/rheinwein/repos","events_url":"https://api.github.com/users/rheinwein/events{/privacy}","received_events_url":"https://api.github.com/users/rheinwein/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T15:45:36Z","updated_at":"2018-02-15T15:45:36Z","author_association":"OWNER","body":"Links are deprecated, and Codeship supports `depends_on`. Read more about it here: https://blog.codeship.com/announcing-depends_on-support/"}}
{"actor":{"display_login":"rheinwein"}}