{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments/199607936","pull_request_review_id":133761846,"id":199607936,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTYwNzkzNg==","diff_hunk":"@@ -238,6 +314,32 @@ def _set_mags(self, record, row, key_map):\n                 record.set(key_map[err_key+'_fluxSigma'],\n                            fluxErrFromABMagErr(row[error_col_name], row[err_key]))\n \n+    def _set_proper_motion(self, record, row, key_map):\n+        \"\"\"Set the proper motions from the input\n+\n+        The proper motions are read from the specified columns,\n+        scaled appropriately, and installed in the appropriate\n+        columns of the output.\n+\n+        Parameters\n+        ----------\n+        record : `lsst.afw.table.SourceRecord`\n+            Source record to modify.\n+        row : `dict`-like\n+            Row from numpy table.\n+        key_map : `dict` mapping `str` to `lsst.afw.table.Key`\n+            Map of catalog keys.\n+        \"\"\"\n+        if self.config.pm_ra_name is None:  # IngestIndexedReferenceConfig.validate ensures all or none\n+            return\n+        record.set(key_map[\"pmRa\"], row[self.config.pm_ra_name]*self.config.pm_scale)\n+        record.set(key_map[\"pmDec\"], row[self.config.pm_dec_name]*self.config.pm_scale)\n+        record.set(key_map[\"epoch\"], self.epoch_poly(row[self.config.epoch_name]))\n+        if self.config.pm_ra_err_name is None or self.config.pm_dec_err_name is None:\n+            return\n+        record.set(key_map[\"pmRaErr\"], row[self.config.pm_ra_err_name]*self.config.pm_scale)\n+        record.set(key_map[\"pmDecErr\"], row[self.config.pm_dec_err_name]*self.config.pm_scale)","path":"python/lsst/meas/algorithms/ingestIndexReferenceTask.py","position":141,"original_position":141,"commit_id":"d519d5725781259a116bf3a7c94205772e0cb323","original_commit_id":"d49559fd6e3d37bf3b2b5dd46201e01297ff494f","user":{"login":"TallJimbo","id":1330720,"node_id":"MDQ6VXNlcjEzMzA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1330720?v=4","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"(note edits in my last post - I was confusing RFC-271 with RFC-333)","created_at":"2018-07-02T20:15:03Z","updated_at":"2018-07-02T20:15:03Z","html_url":"https://github.com/lsst/meas_algorithms/pull/111#discussion_r199607936","pull_request_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments/199607936"},"html":{"href":"https://github.com/lsst/meas_algorithms/pull/111#discussion_r199607936"},"pull_request":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111"}},"in_reply_to_id":179385869},"pull_request":{"url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111","id":178659515,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4NjU5NTE1","html_url":"https://github.com/lsst/meas_algorithms/pull/111","diff_url":"https://github.com/lsst/meas_algorithms/pull/111.diff","patch_url":"https://github.com/lsst/meas_algorithms/pull/111.patch","issue_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/111","number":111,"state":"open","locked":false,"title":"DM-8828: Support proper motions in reference catalogs","user":{"login":"PaulPrice","id":1334980,"node_id":"MDQ6VXNlcjEzMzQ5ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1334980?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulPrice","html_url":"https://github.com/PaulPrice","followers_url":"https://api.github.com/users/PaulPrice/followers","following_url":"https://api.github.com/users/PaulPrice/following{/other_user}","gists_url":"https://api.github.com/users/PaulPrice/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulPrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulPrice/subscriptions","organizations_url":"https://api.github.com/users/PaulPrice/orgs","repos_url":"https://api.github.com/users/PaulPrice/repos","events_url":"https://api.github.com/users/PaulPrice/events{/privacy}","received_events_url":"https://api.github.com/users/PaulPrice/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-31T01:23:03Z","updated_at":"2018-07-02T20:15:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b293a03edf7013f272a73f743b13d08c5d049d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111/commits","review_comments_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111/comments","review_comment_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/111/comments","statuses_url":"https://api.github.com/repos/lsst/meas_algorithms/statuses/d519d5725781259a116bf3a7c94205772e0cb323","head":{"label":"lsst:tickets/DM-8828","ref":"tickets/DM-8828","sha":"d519d5725781259a116bf3a7c94205772e0cb323","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013343,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzM0Mw==","name":"meas_algorithms","full_name":"lsst/meas_algorithms","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_algorithms","description":"LSST Data Management: astronomical measurement algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_algorithms","forks_url":"https://api.github.com/repos/lsst/meas_algorithms/forks","keys_url":"https://api.github.com/repos/lsst/meas_algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_algorithms/teams","hooks_url":"https://api.github.com/repos/lsst/meas_algorithms/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_algorithms/events","assignees_url":"https://api.github.com/repos/lsst/meas_algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_algorithms/tags","blobs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_algorithms/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_algorithms/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_algorithms/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_algorithms/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_algorithms/subscription","commits_url":"https://api.github.com/repos/lsst/meas_algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_algorithms/merges","archive_url":"https://api.github.com/repos/lsst/meas_algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_algorithms/downloads","issues_url":"https://api.github.com/repos/lsst/meas_algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_algorithms/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_algorithms/deployments","created_at":"2014-08-16T07:45:05Z","updated_at":"2018-06-22T21:29:32Z","pushed_at":"2018-07-02T19:23:10Z","git_url":"git://github.com/lsst/meas_algorithms.git","ssh_url":"git@github.com:lsst/meas_algorithms.git","clone_url":"https://github.com/lsst/meas_algorithms.git","svn_url":"https://github.com/lsst/meas_algorithms","homepage":"http://dm.lsst.org/","size":11492,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":8,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"2f3508ec6f8b5968c5018733e596229809115c55","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013343,"node_id":"MDEwOlJlcG9zaXRvcnkyMzAxMzM0Mw==","name":"meas_algorithms","full_name":"lsst/meas_algorithms","owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_algorithms","description":"LSST Data Management: astronomical measurement algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_algorithms","forks_url":"https://api.github.com/repos/lsst/meas_algorithms/forks","keys_url":"https://api.github.com/repos/lsst/meas_algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_algorithms/teams","hooks_url":"https://api.github.com/repos/lsst/meas_algorithms/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_algorithms/events","assignees_url":"https://api.github.com/repos/lsst/meas_algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_algorithms/tags","blobs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_algorithms/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_algorithms/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_algorithms/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_algorithms/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_algorithms/subscription","commits_url":"https://api.github.com/repos/lsst/meas_algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_algorithms/merges","archive_url":"https://api.github.com/repos/lsst/meas_algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_algorithms/downloads","issues_url":"https://api.github.com/repos/lsst/meas_algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_algorithms/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_algorithms/deployments","created_at":"2014-08-16T07:45:05Z","updated_at":"2018-06-22T21:29:32Z","pushed_at":"2018-07-02T19:23:10Z","git_url":"git://github.com/lsst/meas_algorithms.git","ssh_url":"git@github.com:lsst/meas_algorithms.git","clone_url":"https://github.com/lsst/meas_algorithms.git","svn_url":"https://github.com/lsst/meas_algorithms","homepage":"http://dm.lsst.org/","size":11492,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":8,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111"},"html":{"href":"https://github.com/lsst/meas_algorithms/pull/111"},"issue":{"href":"https://api.github.com/repos/lsst/meas_algorithms/issues/111"},"comments":{"href":"https://api.github.com/repos/lsst/meas_algorithms/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/meas_algorithms/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/meas_algorithms/statuses/d519d5725781259a116bf3a7c94205772e0cb323"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TallJimbo"}}