{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/230612926","pull_request_review_id":171388211,"id":230612926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYxMjkyNg==","diff_hunk":"@@ -249,11 +249,11 @@ added: v1.0.0\n   - `plaintextLength` {number}\n * Returns: {Cipher} for method chaining.\n \n-When using an authenticated encryption mode (`GCM`, `CCM` and `OCB` are\n+When using an authenticated encryption mode (`GCM`, `CCM`, `OCB` and `AEAD_CHACHA20_POLY1305` are","path":"doc/api/crypto.md","position":5,"original_position":5,"commit_id":"c0c9a05c5c671223ef05fe0afce587dbb163bd35","original_commit_id":"c0c9a05c5c671223ef05fe0afce587dbb163bd35","user":{"login":"chux0519","id":14276970,"node_id":"MDQ6VXNlcjE0Mjc2OTcw","avatar_url":"https://avatars1.githubusercontent.com/u/14276970?v=4","gravatar_id":"","url":"https://api.github.com/users/chux0519","html_url":"https://github.com/chux0519","followers_url":"https://api.github.com/users/chux0519/followers","following_url":"https://api.github.com/users/chux0519/following{/other_user}","gists_url":"https://api.github.com/users/chux0519/gists{/gist_id}","starred_url":"https://api.github.com/users/chux0519/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chux0519/subscriptions","organizations_url":"https://api.github.com/users/chux0519/orgs","repos_url":"https://api.github.com/users/chux0519/repos","events_url":"https://api.github.com/users/chux0519/events{/privacy}","received_events_url":"https://api.github.com/users/chux0519/received_events","type":"User","site_admin":false},"body":"Sure, I will fix this","created_at":"2018-11-05T00:33:50Z","updated_at":"2018-11-05T00:33:50Z","html_url":"https://github.com/nodejs/node/pull/24081#discussion_r230612926","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/24081","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/230612926"},"html":{"href":"https://github.com/nodejs/node/pull/24081#discussion_r230612926"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/24081"}},"in_reply_to_id":230596044},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24081","id":228184628,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTg0NjI4","html_url":"https://github.com/nodejs/node/pull/24081","diff_url":"https://github.com/nodejs/node/pull/24081.diff","patch_url":"https://github.com/nodejs/node/pull/24081.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24081","number":24081,"state":"open","locked":false,"title":"crypto: add support for chacha20-poly1305 for AEAD","user":{"login":"chux0519","id":14276970,"node_id":"MDQ6VXNlcjE0Mjc2OTcw","avatar_url":"https://avatars1.githubusercontent.com/u/14276970?v=4","gravatar_id":"","url":"https://api.github.com/users/chux0519","html_url":"https://github.com/chux0519","followers_url":"https://api.github.com/users/chux0519/followers","following_url":"https://api.github.com/users/chux0519/following{/other_user}","gists_url":"https://api.github.com/users/chux0519/gists{/gist_id}","starred_url":"https://api.github.com/users/chux0519/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chux0519/subscriptions","organizations_url":"https://api.github.com/users/chux0519/orgs","repos_url":"https://api.github.com/users/chux0519/repos","events_url":"https://api.github.com/users/chux0519/events{/privacy}","received_events_url":"https://api.github.com/users/chux0519/received_events","type":"User","site_admin":false},"body":"Openssl support AEAD_CHACHA20_POLY1305(rfc7539) since 1.1.\r\n\r\nFixes: https://github.com/nodejs/node/issues/24080\r\nRefs: https://tools.ietf.org/html/rfc7539\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-11-04T15:47:33Z","updated_at":"2018-11-05T00:33:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d9139d375f5317730bf6428b844676c3452bec2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155267357,"node_id":"MDU6TGFiZWwxNTUyNjczNTc=","url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24081/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24081/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24081/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/c0c9a05c5c671223ef05fe0afce587dbb163bd35","head":{"label":"chux0519:chacha","ref":"chacha","sha":"c0c9a05c5c671223ef05fe0afce587dbb163bd35","user":{"login":"chux0519","id":14276970,"node_id":"MDQ6VXNlcjE0Mjc2OTcw","avatar_url":"https://avatars1.githubusercontent.com/u/14276970?v=4","gravatar_id":"","url":"https://api.github.com/users/chux0519","html_url":"https://github.com/chux0519","followers_url":"https://api.github.com/users/chux0519/followers","following_url":"https://api.github.com/users/chux0519/following{/other_user}","gists_url":"https://api.github.com/users/chux0519/gists{/gist_id}","starred_url":"https://api.github.com/users/chux0519/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chux0519/subscriptions","organizations_url":"https://api.github.com/users/chux0519/orgs","repos_url":"https://api.github.com/users/chux0519/repos","events_url":"https://api.github.com/users/chux0519/events{/privacy}","received_events_url":"https://api.github.com/users/chux0519/received_events","type":"User","site_admin":false},"repo":{"id":156047947,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYwNDc5NDc=","name":"node","full_name":"chux0519/node","private":false,"owner":{"login":"chux0519","id":14276970,"node_id":"MDQ6VXNlcjE0Mjc2OTcw","avatar_url":"https://avatars1.githubusercontent.com/u/14276970?v=4","gravatar_id":"","url":"https://api.github.com/users/chux0519","html_url":"https://github.com/chux0519","followers_url":"https://api.github.com/users/chux0519/followers","following_url":"https://api.github.com/users/chux0519/following{/other_user}","gists_url":"https://api.github.com/users/chux0519/gists{/gist_id}","starred_url":"https://api.github.com/users/chux0519/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chux0519/subscriptions","organizations_url":"https://api.github.com/users/chux0519/orgs","repos_url":"https://api.github.com/users/chux0519/repos","events_url":"https://api.github.com/users/chux0519/events{/privacy}","received_events_url":"https://api.github.com/users/chux0519/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chux0519/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/chux0519/node","forks_url":"https://api.github.com/repos/chux0519/node/forks","keys_url":"https://api.github.com/repos/chux0519/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chux0519/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chux0519/node/teams","hooks_url":"https://api.github.com/repos/chux0519/node/hooks","issue_events_url":"https://api.github.com/repos/chux0519/node/issues/events{/number}","events_url":"https://api.github.com/repos/chux0519/node/events","assignees_url":"https://api.github.com/repos/chux0519/node/assignees{/user}","branches_url":"https://api.github.com/repos/chux0519/node/branches{/branch}","tags_url":"https://api.github.com/repos/chux0519/node/tags","blobs_url":"https://api.github.com/repos/chux0519/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chux0519/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chux0519/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/chux0519/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chux0519/node/statuses/{sha}","languages_url":"https://api.github.com/repos/chux0519/node/languages","stargazers_url":"https://api.github.com/repos/chux0519/node/stargazers","contributors_url":"https://api.github.com/repos/chux0519/node/contributors","subscribers_url":"https://api.github.com/repos/chux0519/node/subscribers","subscription_url":"https://api.github.com/repos/chux0519/node/subscription","commits_url":"https://api.github.com/repos/chux0519/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/chux0519/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/chux0519/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/chux0519/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/chux0519/node/contents/{+path}","compare_url":"https://api.github.com/repos/chux0519/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chux0519/node/merges","archive_url":"https://api.github.com/repos/chux0519/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chux0519/node/downloads","issues_url":"https://api.github.com/repos/chux0519/node/issues{/number}","pulls_url":"https://api.github.com/repos/chux0519/node/pulls{/number}","milestones_url":"https://api.github.com/repos/chux0519/node/milestones{/number}","notifications_url":"https://api.github.com/repos/chux0519/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chux0519/node/labels{/name}","releases_url":"https://api.github.com/repos/chux0519/node/releases{/id}","deployments_url":"https://api.github.com/repos/chux0519/node/deployments","created_at":"2018-11-04T04:05:24Z","updated_at":"2018-11-04T04:05:49Z","pushed_at":"2018-11-04T15:56:39Z","git_url":"git://github.com/chux0519/node.git","ssh_url":"git@github.com:chux0519/node.git","clone_url":"https://github.com/chux0519/node.git","svn_url":"https://github.com/chux0519/node","homepage":"https://nodejs.org","size":428723,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"bde8eb5f82837bd035a681e1bd05be8df259e108","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-05T00:29:58Z","pushed_at":"2018-11-04T22:56:57Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":429838,"stargazers_count":55037,"watchers_count":55037,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11987,"mirror_url":null,"archived":false,"open_issues_count":877,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11987,"open_issues":877,"watchers":55037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24081"},"html":{"href":"https://github.com/nodejs/node/pull/24081"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24081"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24081/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24081/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24081/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/c0c9a05c5c671223ef05fe0afce587dbb163bd35"}},"author_association":"NONE"}}
{"actor":{"display_login":"chux0519"}}