{"action":"created","issue":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4055","repository_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4055/labels{/name}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4055/comments","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4055/events","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4055","id":299107290,"number":4055,"title":"Fix infinite recursion in scrollable pane","user":{"login":"MaxLustig","id":923575,"avatar_url":"https://avatars3.githubusercontent.com/u/923575?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxLustig","html_url":"https://github.com/MaxLustig","followers_url":"https://api.github.com/users/MaxLustig/followers","following_url":"https://api.github.com/users/MaxLustig/following{/other_user}","gists_url":"https://api.github.com/users/MaxLustig/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxLustig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxLustig/subscriptions","organizations_url":"https://api.github.com/users/MaxLustig/orgs","repos_url":"https://api.github.com/users/MaxLustig/repos","events_url":"https://api.github.com/users/MaxLustig/events{/privacy}","received_events_url":"https://api.github.com/users/MaxLustig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-21T19:58:25Z","updated_at":"2018-02-21T22:50:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4055","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4055","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4055.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4055.patch"},"body":"#### Pull request checklist\r\n\r\n- [ ] Addresses an existing issue: Fixes #0000\r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\n\r\nIt's possible to enter an infinite recursion in scrollable pane. notifySubscribers is called from _onWindowResize, which is called from forceLayoutUpdate (callable from the parent item). This calls Sticky::_onScrollEvent, which updates the Sticky's state. Sticky::componentDidUpdate can call scrollablePane.addStickyHeader, which calls _addSticky, which then calls notifySubscribers, infinitely recursing.\r\n\r\nBy removing the call to notifySubscribers in _addSticky, the infinite recursion is removed.\r\n\r\n#### Focus areas to test\r\n\r\nScrollable Pane\r\n"},"comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments/367504471","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4055#issuecomment-367504471","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4055","id":367504471,"user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars3.githubusercontent.com/u/1110944?v=4","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T22:50:13Z","updated_at":"2018-02-21T22:50:13Z","author_association":"COLLABORATOR","body":"@ThomasMichon are you ok with this?"}}
{"actor":{"display_login":"dzearing"}}