{"action":"created","issue":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1366","repository_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1366/labels{/name}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1366/comments","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1366/events","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1366","id":305978352,"number":1366,"title":"Introduced deep children text nodes rerendering","user":{"login":"f1ames","id":1061942,"avatar_url":"https://avatars2.githubusercontent.com/u/1061942?v=4","gravatar_id":"","url":"https://api.github.com/users/f1ames","html_url":"https://github.com/f1ames","followers_url":"https://api.github.com/users/f1ames/followers","following_url":"https://api.github.com/users/f1ames/following{/other_user}","gists_url":"https://api.github.com/users/f1ames/gists{/gist_id}","starred_url":"https://api.github.com/users/f1ames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f1ames/subscriptions","organizations_url":"https://api.github.com/users/f1ames/orgs","repos_url":"https://api.github.com/users/f1ames/repos","events_url":"https://api.github.com/users/f1ames/events{/privacy}","received_events_url":"https://api.github.com/users/f1ames/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-16T15:45:05Z","updated_at":"2018-03-23T13:47:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/1366","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1366","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1366.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1366.patch"},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nOther: Introduced deep children text nodes rerendering. Closes #1125. Closes #1093. Closes ckeditor/ckeditor5-typing#120. \r\n\r\n---\r\n\r\n### Additional information\r\n\r\nThe proposed solution is very similar to what was initially proposed by @scofalik - https://github.com/ckeditor/ckeditor5-engine/issues/1125#issuecomment-332791847. The logic marking text nodes is placed in `renderer._updateChildren` as this is the place where element nodes are modified and based on that modifications we can decide which elements' text nodes should be considered for rerendered.\r\n\r\nThe mutation observer change is also described here - https://github.com/ckeditor/ckeditor5-engine/issues/1125#issuecomment-373376368.\r\n"},"comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments/375669896","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/1366#issuecomment-375669896","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/1366","id":375669896,"user":{"login":"Mgsy","id":20988892,"avatar_url":"https://avatars3.githubusercontent.com/u/20988892?v=4","gravatar_id":"","url":"https://api.github.com/users/Mgsy","html_url":"https://github.com/Mgsy","followers_url":"https://api.github.com/users/Mgsy/followers","following_url":"https://api.github.com/users/Mgsy/following{/other_user}","gists_url":"https://api.github.com/users/Mgsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Mgsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mgsy/subscriptions","organizations_url":"https://api.github.com/users/Mgsy/orgs","repos_url":"https://api.github.com/users/Mgsy/repos","events_url":"https://api.github.com/users/Mgsy/events{/privacy}","received_events_url":"https://api.github.com/users/Mgsy/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T13:47:22Z","updated_at":"2018-03-23T13:47:22Z","author_association":"MEMBER","body":"I've spent some time testing this one. It fixes mentioned issues and I haven't noticed any regressions caused by this fix."}}
{"actor":{"display_login":"Mgsy"}}