{"action":"created","comment":{"url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/comments/180589352","pull_request_review_id":111036911,"id":180589352,"diff_hunk":"@@ -1,84 +1,108 @@\n ;+\n ; NAME: ESCAPE_SPECIAL_CHAR\n-; \n+;\n+; important Nota Bene : AC 2018 : it would be great to be able to *remove* this\n+; code in the future ... All \"file_*\" functions should be able to\n+; manage by them-selves the special chars.\n+;\n ; ESCAPE_SPECIAL_CHAR function escape special characteres present\n ; in input string argument and returns the result.\n ; Special characteres can be given by Keyword : list_of_special_char\n ; or default list is used.\n ;\n-; MODIFICATION HISTORY:\n-;   - June 2010: created by Lea Noreskal\n-;   - 28 June 2010: modified by Alain Coulais (N_PARAMS(), /help)\n-;-\n ; LICENCE:\n ; Copyright (C) 2010, Lea Noreskal and Alain Coulais\n ; This program is free software; you can redistribute it and/or modify  \n ; it under the terms of the GNU General Public License as published by  \n ; the Free Software Foundation; either version 2 of the License, or     \n ; (at your option) any later version.\n-;-\n ;\n-; ---------------------------------\n+; AC 2018 : we do removed \".\" in the list \n+; but not sure if \"?\" or \"*\" should be in the list ...\n+;\n+; ------------------------\n+;\n+; Modifications history :\n+; - June 2010: created by Lea Noreskal\n+; - 28 June 2010: modified by Alain Coulais (N_PARAMS(), /help)\n+;\n+; - 2018-04-10 : AC \n+;  *0* input string should be a singleton !\n+;  *1* manage repetition of same char (\"  \" --> \"\\ \\ \")\n+;  *2* remove of \".\" in the list ...\n+;  *3* adding the space \" \" in the list (and remove bad \n+;                 STRJOIN(STRSPLIT(str_out, /EXTRACT), '\\ ')  )\n+;\n+;- ------------------------\n ;\n function ESCAPE_SPECIAL_CHAR, str_in,  show_list=show_list, $\n                               list_of_special_char=list_of_special_char, $\n-                              test=test, help=help, verbose=verbose\n+                              test=test, help=help, debug=debug, verbose=verbose\n ;\n if N_PARAMS() NE 1 then begin\n-    MESSAGE, /continue, 'You must provide a input string !'\n-    help=1\n+   MESSAGE, /continue, 'You must provide a input string !'\n+   help=1\n endif\n if KEYWORD_SET(help) then begin\n-    print, 'function ESCAPE_SPECIAL_CHAR, str_in, show_list=show_list, $'\n-    print, '           list_of_special_char=list_of_special_char, $'\n-    print, '           test=test, help=help, verbose=verbose'\n-    return, -1\n+   print, 'function ESCAPE_SPECIAL_CHAR, str_in, show_list=show_list, $'\n+   print, '           list_of_special_char=list_of_special_char, $'\n+   print, '           test=test, help=help, debug=debug, verbose=verbose'\n+   return, -1\n endif\n ;\n+if N_ELEMENTS(str_in) GT 1 then MESSAGE, 'input string should not be an array'\n+;\n if KEYWORD_SET(verbose) then begin\n-    MESSAGE, /continue, '/verbose keyword not available, please contribute'\n+   MESSAGE, /continue, '/verbose keyword not available, please contribute'\n endif\n ;\n ; list of special characteres can be modified if it is not complete\n-;if( not KEYWORD_SET(list_of_special_char)) then list_of_special_char ='[*.^$,&\\]'\n+;if( not KEYWORD_SET(list_of_special_char)) then list_of_special_char ='[*^$,&\\]'","path":"src/pro/escape_special_char.pro","position":76,"original_position":76,"commit_id":"b5ce3e3b54083843de07933a0c0a08c2ac4d35a1","original_commit_id":"b5ce3e3b54083843de07933a0c0a08c2ac4d35a1","user":{"login":"alaingdl","id":38264661,"avatar_url":"https://avatars3.githubusercontent.com/u/38264661?v=4","gravatar_id":"","url":"https://api.github.com/users/alaingdl","html_url":"https://github.com/alaingdl","followers_url":"https://api.github.com/users/alaingdl/followers","following_url":"https://api.github.com/users/alaingdl/following{/other_user}","gists_url":"https://api.github.com/users/alaingdl/gists{/gist_id}","starred_url":"https://api.github.com/users/alaingdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alaingdl/subscriptions","organizations_url":"https://api.github.com/users/alaingdl/orgs","repos_url":"https://api.github.com/users/alaingdl/repos","events_url":"https://api.github.com/users/alaingdl/events{/privacy}","received_events_url":"https://api.github.com/users/alaingdl/received_events","type":"User","site_admin":false},"body":"as I said in the comments, the goal would be to *remove* this old code, and having in the C-code\r\nusing primitives (without \"spawn\")","created_at":"2018-04-10T22:45:28Z","updated_at":"2018-04-10T22:45:28Z","html_url":"https://github.com/gnudatalanguage/gdl/pull/129#discussion_r180589352","pull_request_url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/comments/180589352"},"html":{"href":"https://github.com/gnudatalanguage/gdl/pull/129#discussion_r180589352"},"pull_request":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129"}},"in_reply_to_id":180587644},"pull_request":{"url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129","id":180719713,"html_url":"https://github.com/gnudatalanguage/gdl/pull/129","diff_url":"https://github.com/gnudatalanguage/gdl/pull/129.diff","patch_url":"https://github.com/gnudatalanguage/gdl/pull/129.patch","issue_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/129","number":129,"state":"open","locked":false,"title":"post-git-migration svn r4096 (escape_special_char.pro and file_move.pro)","user":{"login":"slayoo","id":89685,"avatar_url":"https://avatars2.githubusercontent.com/u/89685?v=4","gravatar_id":"","url":"https://api.github.com/users/slayoo","html_url":"https://github.com/slayoo","followers_url":"https://api.github.com/users/slayoo/followers","following_url":"https://api.github.com/users/slayoo/following{/other_user}","gists_url":"https://api.github.com/users/slayoo/gists{/gist_id}","starred_url":"https://api.github.com/users/slayoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayoo/subscriptions","organizations_url":"https://api.github.com/users/slayoo/orgs","repos_url":"https://api.github.com/users/slayoo/repos","events_url":"https://api.github.com/users/slayoo/events{/privacy}","received_events_url":"https://api.github.com/users/slayoo/received_events","type":"User","site_admin":false},"body":"changes by @alaingdl","created_at":"2018-04-10T20:33:35Z","updated_at":"2018-04-10T22:45:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"626f9004d6db4c0b84f1081ae1dbb4c3ac567135","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":894402311,"url":"https://api.github.com/repos/gnudatalanguage/gdl/labels/todo-test","name":"todo-test","color":"261c8e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129/commits","review_comments_url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129/comments","review_comment_url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/129/comments","statuses_url":"https://api.github.com/repos/gnudatalanguage/gdl/statuses/b5ce3e3b54083843de07933a0c0a08c2ac4d35a1","head":{"label":"slayoo:svn_r4096","ref":"svn_r4096","sha":"b5ce3e3b54083843de07933a0c0a08c2ac4d35a1","user":{"login":"slayoo","id":89685,"avatar_url":"https://avatars2.githubusercontent.com/u/89685?v=4","gravatar_id":"","url":"https://api.github.com/users/slayoo","html_url":"https://github.com/slayoo","followers_url":"https://api.github.com/users/slayoo/followers","following_url":"https://api.github.com/users/slayoo/following{/other_user}","gists_url":"https://api.github.com/users/slayoo/gists{/gist_id}","starred_url":"https://api.github.com/users/slayoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayoo/subscriptions","organizations_url":"https://api.github.com/users/slayoo/orgs","repos_url":"https://api.github.com/users/slayoo/repos","events_url":"https://api.github.com/users/slayoo/events{/privacy}","received_events_url":"https://api.github.com/users/slayoo/received_events","type":"User","site_admin":false},"repo":{"id":128174929,"name":"gdl","full_name":"slayoo/gdl","owner":{"login":"slayoo","id":89685,"avatar_url":"https://avatars2.githubusercontent.com/u/89685?v=4","gravatar_id":"","url":"https://api.github.com/users/slayoo","html_url":"https://github.com/slayoo","followers_url":"https://api.github.com/users/slayoo/followers","following_url":"https://api.github.com/users/slayoo/following{/other_user}","gists_url":"https://api.github.com/users/slayoo/gists{/gist_id}","starred_url":"https://api.github.com/users/slayoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayoo/subscriptions","organizations_url":"https://api.github.com/users/slayoo/orgs","repos_url":"https://api.github.com/users/slayoo/repos","events_url":"https://api.github.com/users/slayoo/events{/privacy}","received_events_url":"https://api.github.com/users/slayoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slayoo/gdl","description":null,"fork":true,"url":"https://api.github.com/repos/slayoo/gdl","forks_url":"https://api.github.com/repos/slayoo/gdl/forks","keys_url":"https://api.github.com/repos/slayoo/gdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slayoo/gdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slayoo/gdl/teams","hooks_url":"https://api.github.com/repos/slayoo/gdl/hooks","issue_events_url":"https://api.github.com/repos/slayoo/gdl/issues/events{/number}","events_url":"https://api.github.com/repos/slayoo/gdl/events","assignees_url":"https://api.github.com/repos/slayoo/gdl/assignees{/user}","branches_url":"https://api.github.com/repos/slayoo/gdl/branches{/branch}","tags_url":"https://api.github.com/repos/slayoo/gdl/tags","blobs_url":"https://api.github.com/repos/slayoo/gdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slayoo/gdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slayoo/gdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/slayoo/gdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slayoo/gdl/statuses/{sha}","languages_url":"https://api.github.com/repos/slayoo/gdl/languages","stargazers_url":"https://api.github.com/repos/slayoo/gdl/stargazers","contributors_url":"https://api.github.com/repos/slayoo/gdl/contributors","subscribers_url":"https://api.github.com/repos/slayoo/gdl/subscribers","subscription_url":"https://api.github.com/repos/slayoo/gdl/subscription","commits_url":"https://api.github.com/repos/slayoo/gdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/slayoo/gdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/slayoo/gdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/slayoo/gdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/slayoo/gdl/contents/{+path}","compare_url":"https://api.github.com/repos/slayoo/gdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slayoo/gdl/merges","archive_url":"https://api.github.com/repos/slayoo/gdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slayoo/gdl/downloads","issues_url":"https://api.github.com/repos/slayoo/gdl/issues{/number}","pulls_url":"https://api.github.com/repos/slayoo/gdl/pulls{/number}","milestones_url":"https://api.github.com/repos/slayoo/gdl/milestones{/number}","notifications_url":"https://api.github.com/repos/slayoo/gdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slayoo/gdl/labels{/name}","releases_url":"https://api.github.com/repos/slayoo/gdl/releases{/id}","deployments_url":"https://api.github.com/repos/slayoo/gdl/deployments","created_at":"2018-04-05T07:50:26Z","updated_at":"2018-04-10T20:30:01Z","pushed_at":"2018-04-10T20:32:53Z","git_url":"git://github.com/slayoo/gdl.git","ssh_url":"git@github.com:slayoo/gdl.git","clone_url":"https://github.com/slayoo/gdl.git","svn_url":"https://github.com/slayoo/gdl","homepage":null,"size":16750,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gnudatalanguage:master","ref":"master","sha":"6a2d729ee5b1714f708db572769cf742f001b680","user":{"login":"gnudatalanguage","id":8539759,"avatar_url":"https://avatars0.githubusercontent.com/u/8539759?v=4","gravatar_id":"","url":"https://api.github.com/users/gnudatalanguage","html_url":"https://github.com/gnudatalanguage","followers_url":"https://api.github.com/users/gnudatalanguage/followers","following_url":"https://api.github.com/users/gnudatalanguage/following{/other_user}","gists_url":"https://api.github.com/users/gnudatalanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/gnudatalanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnudatalanguage/subscriptions","organizations_url":"https://api.github.com/users/gnudatalanguage/orgs","repos_url":"https://api.github.com/users/gnudatalanguage/repos","events_url":"https://api.github.com/users/gnudatalanguage/events{/privacy}","received_events_url":"https://api.github.com/users/gnudatalanguage/received_events","type":"Organization","site_admin":false},"repo":{"id":128052646,"name":"gdl","full_name":"gnudatalanguage/gdl","owner":{"login":"gnudatalanguage","id":8539759,"avatar_url":"https://avatars0.githubusercontent.com/u/8539759?v=4","gravatar_id":"","url":"https://api.github.com/users/gnudatalanguage","html_url":"https://github.com/gnudatalanguage","followers_url":"https://api.github.com/users/gnudatalanguage/followers","following_url":"https://api.github.com/users/gnudatalanguage/following{/other_user}","gists_url":"https://api.github.com/users/gnudatalanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/gnudatalanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnudatalanguage/subscriptions","organizations_url":"https://api.github.com/users/gnudatalanguage/orgs","repos_url":"https://api.github.com/users/gnudatalanguage/repos","events_url":"https://api.github.com/users/gnudatalanguage/events{/privacy}","received_events_url":"https://api.github.com/users/gnudatalanguage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnudatalanguage/gdl","description":"A free and open-source IDL/PV-WAVE compiler","fork":false,"url":"https://api.github.com/repos/gnudatalanguage/gdl","forks_url":"https://api.github.com/repos/gnudatalanguage/gdl/forks","keys_url":"https://api.github.com/repos/gnudatalanguage/gdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnudatalanguage/gdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnudatalanguage/gdl/teams","hooks_url":"https://api.github.com/repos/gnudatalanguage/gdl/hooks","issue_events_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/events{/number}","events_url":"https://api.github.com/repos/gnudatalanguage/gdl/events","assignees_url":"https://api.github.com/repos/gnudatalanguage/gdl/assignees{/user}","branches_url":"https://api.github.com/repos/gnudatalanguage/gdl/branches{/branch}","tags_url":"https://api.github.com/repos/gnudatalanguage/gdl/tags","blobs_url":"https://api.github.com/repos/gnudatalanguage/gdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnudatalanguage/gdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnudatalanguage/gdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnudatalanguage/gdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnudatalanguage/gdl/statuses/{sha}","languages_url":"https://api.github.com/repos/gnudatalanguage/gdl/languages","stargazers_url":"https://api.github.com/repos/gnudatalanguage/gdl/stargazers","contributors_url":"https://api.github.com/repos/gnudatalanguage/gdl/contributors","subscribers_url":"https://api.github.com/repos/gnudatalanguage/gdl/subscribers","subscription_url":"https://api.github.com/repos/gnudatalanguage/gdl/subscription","commits_url":"https://api.github.com/repos/gnudatalanguage/gdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnudatalanguage/gdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnudatalanguage/gdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnudatalanguage/gdl/contents/{+path}","compare_url":"https://api.github.com/repos/gnudatalanguage/gdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnudatalanguage/gdl/merges","archive_url":"https://api.github.com/repos/gnudatalanguage/gdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnudatalanguage/gdl/downloads","issues_url":"https://api.github.com/repos/gnudatalanguage/gdl/issues{/number}","pulls_url":"https://api.github.com/repos/gnudatalanguage/gdl/pulls{/number}","milestones_url":"https://api.github.com/repos/gnudatalanguage/gdl/milestones{/number}","notifications_url":"https://api.github.com/repos/gnudatalanguage/gdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnudatalanguage/gdl/labels{/name}","releases_url":"https://api.github.com/repos/gnudatalanguage/gdl/releases{/id}","deployments_url":"https://api.github.com/repos/gnudatalanguage/gdl/deployments","created_at":"2018-04-04T11:29:15Z","updated_at":"2018-04-10T22:10:41Z","pushed_at":"2018-04-10T22:10:39Z","git_url":"git://github.com/gnudatalanguage/gdl.git","ssh_url":"git@github.com:gnudatalanguage/gdl.git","clone_url":"https://github.com/gnudatalanguage/gdl.git","svn_url":"https://github.com/gnudatalanguage/gdl","homepage":"","size":16715,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":7,"open_issues":113,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129"},"html":{"href":"https://github.com/gnudatalanguage/gdl/pull/129"},"issue":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/issues/129"},"comments":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/gnudatalanguage/gdl/statuses/b5ce3e3b54083843de07933a0c0a08c2ac4d35a1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"alaingdl"}}