{"action":"created","comment":{"url":"https://api.github.com/repos/oshri/sideproject-client/pulls/comments/244929855","pull_request_review_id":188922316,"id":244929855,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDkyOTg1NQ==","diff_hunk":"@@ -0,0 +1,21 @@\n+<div  class=\"create-menu\"\n+      (mouseenter)=\"toogleMenu()\"\n+      (mouseleave)=\"toogleMenu()\"\n+      fxLayout=\"row\"\n+      fxLayoutAlign=\"start center\">\n+  <button class=\"circle-border-button\" [@showFastHideSlow]=\"!showMenu\">\n+      <mat-icon aria-label=\"Add\">add</mat-icon>\n+  </button>\n+  <div  class=\"menu-options\"\n+        [@showHide]=\"showMenu\"\n+        fxLayout=\"row\"\n+        fxLayoutAlign=\"start center\">\n+\n+    <button class=\"circle-border-button\"\n+            *ngFor=\"let option of options\"\n+            [matTooltip]=\"option\"\n+            (click)=\"onSelectAction(option)\">\n+      {{firstLetterFromType(option)}}","path":"src/app/modules/common/components/createMenu/createMenu.component.html","position":18,"original_position":18,"commit_id":"cda4e89c0d9bb4fad1178724e225dc2ce3019625","original_commit_id":"cda4e89c0d9bb4fad1178724e225dc2ce3019625","user":{"login":"Nexxado","id":12609607,"node_id":"MDQ6VXNlcjEyNjA5NjA3","avatar_url":"https://avatars0.githubusercontent.com/u/12609607?v=4","gravatar_id":"","url":"https://api.github.com/users/Nexxado","html_url":"https://github.com/Nexxado","followers_url":"https://api.github.com/users/Nexxado/followers","following_url":"https://api.github.com/users/Nexxado/following{/other_user}","gists_url":"https://api.github.com/users/Nexxado/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexxado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexxado/subscriptions","organizations_url":"https://api.github.com/users/Nexxado/orgs","repos_url":"https://api.github.com/users/Nexxado/repos","events_url":"https://api.github.com/users/Nexxado/events{/privacy}","received_events_url":"https://api.github.com/users/Nexxado/received_events","type":"User","site_admin":false},"body":"try avoiding function calls in template.\r\nWith function calls, Angular's change detection engine cannot determine if the value changed and has to run the function every change detection cycle.\r\n\r\nmaybe add it as a property for each option in the `options` array?","created_at":"2019-01-03T08:11:52Z","updated_at":"2019-01-03T08:14:17Z","html_url":"https://github.com/oshri/sideproject-client/pull/25#discussion_r244929855","pull_request_url":"https://api.github.com/repos/oshri/sideproject-client/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/oshri/sideproject-client/pulls/comments/244929855"},"html":{"href":"https://github.com/oshri/sideproject-client/pull/25#discussion_r244929855"},"pull_request":{"href":"https://api.github.com/repos/oshri/sideproject-client/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/oshri/sideproject-client/pulls/25","id":241859082,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODU5MDgy","html_url":"https://github.com/oshri/sideproject-client/pull/25","diff_url":"https://github.com/oshri/sideproject-client/pull/25.diff","patch_url":"https://github.com/oshri/sideproject-client/pull/25.patch","issue_url":"https://api.github.com/repos/oshri/sideproject-client/issues/25","number":25,"state":"open","locked":false,"title":"Build add menu by context with test","user":{"login":"oshri","id":4602814,"node_id":"MDQ6VXNlcjQ2MDI4MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4602814?v=4","gravatar_id":"","url":"https://api.github.com/users/oshri","html_url":"https://github.com/oshri","followers_url":"https://api.github.com/users/oshri/followers","following_url":"https://api.github.com/users/oshri/following{/other_user}","gists_url":"https://api.github.com/users/oshri/gists{/gist_id}","starred_url":"https://api.github.com/users/oshri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshri/subscriptions","organizations_url":"https://api.github.com/users/oshri/orgs","repos_url":"https://api.github.com/users/oshri/repos","events_url":"https://api.github.com/users/oshri/events{/privacy}","received_events_url":"https://api.github.com/users/oshri/received_events","type":"User","site_admin":false},"body":"Before running, install new dependencies. ( Yarn )\r\nI add jest __snapshots__ in createMenuComponent tests.","created_at":"2019-01-02T22:01:20Z","updated_at":"2019-01-03T08:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08318190394c4e98970c5baf1da1939ff424cc55","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nightpost","id":15824856,"node_id":"MDQ6VXNlcjE1ODI0ODU2","avatar_url":"https://avatars1.githubusercontent.com/u/15824856?v=4","gravatar_id":"","url":"https://api.github.com/users/nightpost","html_url":"https://github.com/nightpost","followers_url":"https://api.github.com/users/nightpost/followers","following_url":"https://api.github.com/users/nightpost/following{/other_user}","gists_url":"https://api.github.com/users/nightpost/gists{/gist_id}","starred_url":"https://api.github.com/users/nightpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightpost/subscriptions","organizations_url":"https://api.github.com/users/nightpost/orgs","repos_url":"https://api.github.com/users/nightpost/repos","events_url":"https://api.github.com/users/nightpost/events{/privacy}","received_events_url":"https://api.github.com/users/nightpost/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oshri/sideproject-client/pulls/25/commits","review_comments_url":"https://api.github.com/repos/oshri/sideproject-client/pulls/25/comments","review_comment_url":"https://api.github.com/repos/oshri/sideproject-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oshri/sideproject-client/issues/25/comments","statuses_url":"https://api.github.com/repos/oshri/sideproject-client/statuses/cda4e89c0d9bb4fad1178724e225dc2ce3019625","head":{"label":"oshri:feature/add-menu-option","ref":"feature/add-menu-option","sha":"cda4e89c0d9bb4fad1178724e225dc2ce3019625","user":{"login":"oshri","id":4602814,"node_id":"MDQ6VXNlcjQ2MDI4MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4602814?v=4","gravatar_id":"","url":"https://api.github.com/users/oshri","html_url":"https://github.com/oshri","followers_url":"https://api.github.com/users/oshri/followers","following_url":"https://api.github.com/users/oshri/following{/other_user}","gists_url":"https://api.github.com/users/oshri/gists{/gist_id}","starred_url":"https://api.github.com/users/oshri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshri/subscriptions","organizations_url":"https://api.github.com/users/oshri/orgs","repos_url":"https://api.github.com/users/oshri/repos","events_url":"https://api.github.com/users/oshri/events{/privacy}","received_events_url":"https://api.github.com/users/oshri/received_events","type":"User","site_admin":false},"repo":{"id":129314005,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMTQwMDU=","name":"sideproject-client","full_name":"oshri/sideproject-client","private":false,"owner":{"login":"oshri","id":4602814,"node_id":"MDQ6VXNlcjQ2MDI4MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4602814?v=4","gravatar_id":"","url":"https://api.github.com/users/oshri","html_url":"https://github.com/oshri","followers_url":"https://api.github.com/users/oshri/followers","following_url":"https://api.github.com/users/oshri/following{/other_user}","gists_url":"https://api.github.com/users/oshri/gists{/gist_id}","starred_url":"https://api.github.com/users/oshri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshri/subscriptions","organizations_url":"https://api.github.com/users/oshri/orgs","repos_url":"https://api.github.com/users/oshri/repos","events_url":"https://api.github.com/users/oshri/events{/privacy}","received_events_url":"https://api.github.com/users/oshri/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oshri/sideproject-client","description":"sideproject-client with circle CI integrate","fork":false,"url":"https://api.github.com/repos/oshri/sideproject-client","forks_url":"https://api.github.com/repos/oshri/sideproject-client/forks","keys_url":"https://api.github.com/repos/oshri/sideproject-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshri/sideproject-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshri/sideproject-client/teams","hooks_url":"https://api.github.com/repos/oshri/sideproject-client/hooks","issue_events_url":"https://api.github.com/repos/oshri/sideproject-client/issues/events{/number}","events_url":"https://api.github.com/repos/oshri/sideproject-client/events","assignees_url":"https://api.github.com/repos/oshri/sideproject-client/assignees{/user}","branches_url":"https://api.github.com/repos/oshri/sideproject-client/branches{/branch}","tags_url":"https://api.github.com/repos/oshri/sideproject-client/tags","blobs_url":"https://api.github.com/repos/oshri/sideproject-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshri/sideproject-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshri/sideproject-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshri/sideproject-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshri/sideproject-client/statuses/{sha}","languages_url":"https://api.github.com/repos/oshri/sideproject-client/languages","stargazers_url":"https://api.github.com/repos/oshri/sideproject-client/stargazers","contributors_url":"https://api.github.com/repos/oshri/sideproject-client/contributors","subscribers_url":"https://api.github.com/repos/oshri/sideproject-client/subscribers","subscription_url":"https://api.github.com/repos/oshri/sideproject-client/subscription","commits_url":"https://api.github.com/repos/oshri/sideproject-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshri/sideproject-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshri/sideproject-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshri/sideproject-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshri/sideproject-client/contents/{+path}","compare_url":"https://api.github.com/repos/oshri/sideproject-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshri/sideproject-client/merges","archive_url":"https://api.github.com/repos/oshri/sideproject-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshri/sideproject-client/downloads","issues_url":"https://api.github.com/repos/oshri/sideproject-client/issues{/number}","pulls_url":"https://api.github.com/repos/oshri/sideproject-client/pulls{/number}","milestones_url":"https://api.github.com/repos/oshri/sideproject-client/milestones{/number}","notifications_url":"https://api.github.com/repos/oshri/sideproject-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshri/sideproject-client/labels{/name}","releases_url":"https://api.github.com/repos/oshri/sideproject-client/releases{/id}","deployments_url":"https://api.github.com/repos/oshri/sideproject-client/deployments","created_at":"2018-04-12T21:40:02Z","updated_at":"2019-01-02T21:58:54Z","pushed_at":"2019-01-02T22:41:35Z","git_url":"git://github.com/oshri/sideproject-client.git","ssh_url":"git@github.com:oshri/sideproject-client.git","clone_url":"https://github.com/oshri/sideproject-client.git","svn_url":"https://github.com/oshri/sideproject-client","homepage":null,"size":1358,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"oshri:master","ref":"master","sha":"0ecc19cd917a11beb68099fc3f32715c30477eb2","user":{"login":"oshri","id":4602814,"node_id":"MDQ6VXNlcjQ2MDI4MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4602814?v=4","gravatar_id":"","url":"https://api.github.com/users/oshri","html_url":"https://github.com/oshri","followers_url":"https://api.github.com/users/oshri/followers","following_url":"https://api.github.com/users/oshri/following{/other_user}","gists_url":"https://api.github.com/users/oshri/gists{/gist_id}","starred_url":"https://api.github.com/users/oshri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshri/subscriptions","organizations_url":"https://api.github.com/users/oshri/orgs","repos_url":"https://api.github.com/users/oshri/repos","events_url":"https://api.github.com/users/oshri/events{/privacy}","received_events_url":"https://api.github.com/users/oshri/received_events","type":"User","site_admin":false},"repo":{"id":129314005,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzMTQwMDU=","name":"sideproject-client","full_name":"oshri/sideproject-client","private":false,"owner":{"login":"oshri","id":4602814,"node_id":"MDQ6VXNlcjQ2MDI4MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4602814?v=4","gravatar_id":"","url":"https://api.github.com/users/oshri","html_url":"https://github.com/oshri","followers_url":"https://api.github.com/users/oshri/followers","following_url":"https://api.github.com/users/oshri/following{/other_user}","gists_url":"https://api.github.com/users/oshri/gists{/gist_id}","starred_url":"https://api.github.com/users/oshri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshri/subscriptions","organizations_url":"https://api.github.com/users/oshri/orgs","repos_url":"https://api.github.com/users/oshri/repos","events_url":"https://api.github.com/users/oshri/events{/privacy}","received_events_url":"https://api.github.com/users/oshri/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oshri/sideproject-client","description":"sideproject-client with circle CI integrate","fork":false,"url":"https://api.github.com/repos/oshri/sideproject-client","forks_url":"https://api.github.com/repos/oshri/sideproject-client/forks","keys_url":"https://api.github.com/repos/oshri/sideproject-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshri/sideproject-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshri/sideproject-client/teams","hooks_url":"https://api.github.com/repos/oshri/sideproject-client/hooks","issue_events_url":"https://api.github.com/repos/oshri/sideproject-client/issues/events{/number}","events_url":"https://api.github.com/repos/oshri/sideproject-client/events","assignees_url":"https://api.github.com/repos/oshri/sideproject-client/assignees{/user}","branches_url":"https://api.github.com/repos/oshri/sideproject-client/branches{/branch}","tags_url":"https://api.github.com/repos/oshri/sideproject-client/tags","blobs_url":"https://api.github.com/repos/oshri/sideproject-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshri/sideproject-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshri/sideproject-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshri/sideproject-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshri/sideproject-client/statuses/{sha}","languages_url":"https://api.github.com/repos/oshri/sideproject-client/languages","stargazers_url":"https://api.github.com/repos/oshri/sideproject-client/stargazers","contributors_url":"https://api.github.com/repos/oshri/sideproject-client/contributors","subscribers_url":"https://api.github.com/repos/oshri/sideproject-client/subscribers","subscription_url":"https://api.github.com/repos/oshri/sideproject-client/subscription","commits_url":"https://api.github.com/repos/oshri/sideproject-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshri/sideproject-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshri/sideproject-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshri/sideproject-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshri/sideproject-client/contents/{+path}","compare_url":"https://api.github.com/repos/oshri/sideproject-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshri/sideproject-client/merges","archive_url":"https://api.github.com/repos/oshri/sideproject-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshri/sideproject-client/downloads","issues_url":"https://api.github.com/repos/oshri/sideproject-client/issues{/number}","pulls_url":"https://api.github.com/repos/oshri/sideproject-client/pulls{/number}","milestones_url":"https://api.github.com/repos/oshri/sideproject-client/milestones{/number}","notifications_url":"https://api.github.com/repos/oshri/sideproject-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshri/sideproject-client/labels{/name}","releases_url":"https://api.github.com/repos/oshri/sideproject-client/releases{/id}","deployments_url":"https://api.github.com/repos/oshri/sideproject-client/deployments","created_at":"2018-04-12T21:40:02Z","updated_at":"2019-01-02T21:58:54Z","pushed_at":"2019-01-02T22:41:35Z","git_url":"git://github.com/oshri/sideproject-client.git","ssh_url":"git@github.com:oshri/sideproject-client.git","clone_url":"https://github.com/oshri/sideproject-client.git","svn_url":"https://github.com/oshri/sideproject-client","homepage":null,"size":1358,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oshri/sideproject-client/pulls/25"},"html":{"href":"https://github.com/oshri/sideproject-client/pull/25"},"issue":{"href":"https://api.github.com/repos/oshri/sideproject-client/issues/25"},"comments":{"href":"https://api.github.com/repos/oshri/sideproject-client/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/oshri/sideproject-client/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/oshri/sideproject-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oshri/sideproject-client/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/oshri/sideproject-client/statuses/cda4e89c0d9bb4fad1178724e225dc2ce3019625"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Nexxado"}}