{"action":"closed","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10209","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10209/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10209/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10209/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/10209","id":308308865,"number":10209,"title":"Compilation error if TMMC2130 and EEPROM are active at the same time","user":{"login":"fsadak","id":4323357,"avatar_url":"https://avatars1.githubusercontent.com/u/4323357?v=4","gravatar_id":"","url":"https://api.github.com/users/fsadak","html_url":"https://github.com/fsadak","followers_url":"https://api.github.com/users/fsadak/followers","following_url":"https://api.github.com/users/fsadak/following{/other_user}","gists_url":"https://api.github.com/users/fsadak/gists{/gist_id}","starred_url":"https://api.github.com/users/fsadak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsadak/subscriptions","organizations_url":"https://api.github.com/users/fsadak/orgs","repos_url":"https://api.github.com/users/fsadak/repos","events_url":"https://api.github.com/users/fsadak/events{/privacy}","received_events_url":"https://api.github.com/users/fsadak/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-24T23:46:42Z","updated_at":"2018-03-28T19:44:52Z","closed_at":"2018-03-28T19:44:51Z","author_association":"NONE","body":"As mentioned in the title, when the TMC2130 and EEPROM are activated at the same time, I received a lot of compilation errors similar to the following.\r\n\r\n```\r\nsketch\\configuration_store.cpp: In static member function 'static bool MarlinSettings::save()':\r\nconfiguration_store.cpp:835: error: expected '}' before numeric constant\r\n           0\r\n           ^\r\nconfiguration_store.cpp:835: error: expected ',' or ';' before numeric constant\r\n```\r\n\r\nWhen I checked the configuration_store.cpp file, I noticed that there was no comma after the second and third zeros in the following lines, and that the last line should be 0, 0, 0. When I corrected it in this way, it was compiled without problems.\r\n```cpp\r\nint16_t tmc_sgt[XYZ] = {\r\n      #if ENABLED(SENSORLESS_HOMING)\r\n        #if defined(X_HOMING_SENSITIVITY) && (ENABLED(X_IS_TMC2130) || ENABLED(IS_TRAMS))\r\n          stepperX.sgt(),\r\n        #else\r\n          0,\r\n        #endif\r\n        #if defined(Y_HOMING_SENSITIVITY) && (ENABLED(Y_IS_TMC2130) || ENABLED(IS_TRAMS))\r\n          stepperY.sgt(),\r\n        #else\r\n          0 **<== No comma**\r\n        #endif\r\n        #if defined(Z_HOMING_SENSITIVITY) && (ENABLED(Z_IS_TMC2130) || ENABLED(IS_TRAMS))\r\n          stepperZ.sgt()\r\n        #else\r\n          0 **<== No comma**\r\n        #endif\r\n      #else\r\n        0 **<== Should be 0, 0, 0**\r\n      #endif\r\n    };\r\n```"}}
{"actor":{"display_login":"thinkyhead"}}