{"action":"created","issue":{"url":"https://api.github.com/repos/vector-im/riot-web/issues/7947","repository_url":"https://api.github.com/repos/vector-im/riot-web","labels_url":"https://api.github.com/repos/vector-im/riot-web/issues/7947/labels{/name}","comments_url":"https://api.github.com/repos/vector-im/riot-web/issues/7947/comments","events_url":"https://api.github.com/repos/vector-im/riot-web/issues/7947/events","html_url":"https://github.com/vector-im/riot-web/issues/7947","id":393807829,"node_id":"MDU6SXNzdWUzOTM4MDc4Mjk=","number":7947,"title":"matrix-react-sdk is using a 3 year old version of jest's expect library","user":{"login":"trashhalo","id":177491,"node_id":"MDQ6VXNlcjE3NzQ5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/177491?v=4","gravatar_id":"","url":"https://api.github.com/users/trashhalo","html_url":"https://github.com/trashhalo","followers_url":"https://api.github.com/users/trashhalo/followers","following_url":"https://api.github.com/users/trashhalo/following{/other_user}","gists_url":"https://api.github.com/users/trashhalo/gists{/gist_id}","starred_url":"https://api.github.com/users/trashhalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trashhalo/subscriptions","organizations_url":"https://api.github.com/users/trashhalo/orgs","repos_url":"https://api.github.com/users/trashhalo/repos","events_url":"https://api.github.com/users/trashhalo/events{/privacy}","received_events_url":"https://api.github.com/users/trashhalo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-24T04:25:25Z","updated_at":"2018-12-24T20:13:43Z","closed_at":null,"author_association":"NONE","body":"<!-- Please report security issues by email to security@matrix.org -->\r\n\r\n<!-- This is a bug report template. By following the instructions below and\r\nfilling out the sections with your information, you will help the us to get all\r\nthe necessary data to fix your issue.\r\n\r\nYou can also preview your report before submitting it. You may remove sections\r\nthat aren't relevant to your particular case.\r\n\r\nText between <!-- and --​> marks will be invisible in the report.\r\n-->\r\n\r\n### Description\r\n\r\nmatrix-react-sdk is using a 3 year old version of an expect library. The documentation for this library has exited the internet. This makes it hard for contributors to update your tests.\r\n\r\nI found this when I was looking to bring this test file out of xdescribe into a working state again https://github.com/matrix-org/matrix-react-sdk/blob/master/test/components/views/rooms/MessageComposerInput-test.js\r\n\r\n### Steps to reproduce\r\n\r\n- Look at the package json version of expect. ^1.16.0\r\n- Look at the release list on https://www.npmjs.com/package/expect\r\n- Realize that jests documentation doesn't go back that far https://jestjs.io/en/versions\r\n\r\nDescribe how what happens differs from what you expected.\r\n\r\nI find it kind of strange to be using Jest's expect with karma to begin with. But assume you have a good reason for this mix I would have `expect(matrix).toHaveUpgradedItsLibraries()` in the last 3 years.\r\n\r\n### Version information\r\ndevelop branch\r\n"},"comment":{"url":"https://api.github.com/repos/vector-im/riot-web/issues/comments/449768235","html_url":"https://github.com/vector-im/riot-web/issues/7947#issuecomment-449768235","issue_url":"https://api.github.com/repos/vector-im/riot-web/issues/7947","id":449768235,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTc2ODIzNQ==","user":{"login":"trashhalo","id":177491,"node_id":"MDQ6VXNlcjE3NzQ5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/177491?v=4","gravatar_id":"","url":"https://api.github.com/users/trashhalo","html_url":"https://github.com/trashhalo","followers_url":"https://api.github.com/users/trashhalo/followers","following_url":"https://api.github.com/users/trashhalo/following{/other_user}","gists_url":"https://api.github.com/users/trashhalo/gists{/gist_id}","starred_url":"https://api.github.com/users/trashhalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trashhalo/subscriptions","organizations_url":"https://api.github.com/users/trashhalo/orgs","repos_url":"https://api.github.com/users/trashhalo/repos","events_url":"https://api.github.com/users/trashhalo/events{/privacy}","received_events_url":"https://api.github.com/users/trashhalo/received_events","type":"User","site_admin":false},"created_at":"2018-12-24T20:13:43Z","updated_at":"2018-12-24T20:13:43Z","author_association":"NONE","body":"1. Would you be open to merging a pull request that updated expect to latest version (and dealt with any breaking changes)\n2. I noticed the library is using jest expect but with karma. Do you have an interest in switching to the jest test runner too? Is this something you would be open to someone doing in a pull request outside the main contributors?\n3. The package json is missing an engine section but the riot readme says there is a min version of node supported. Could I add the engine section in a pull request to better align how the node community communicates node version requirements?\n4. The libraries are missing lock files. Is that intentional? Just wondering what that thinking is there"}}
{"actor":{"display_login":"trashhalo"}}