{"action":"created","comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/191841334","pull_request_review_id":124494451,"id":191841334,"diff_hunk":"@@ -0,0 +1,129 @@\n+# Copyright 2018 Telefonica Investigacion y Desarrollo, S.A.U\n+#\n+# This file is part of Orion Context Broker.\n+#\n+# Orion Context Broker is free software: you can redistribute it and/or\n+# modify it under the terms of the GNU Affero General Public License as\n+# published by the Free Software Foundation, either version 3 of the\n+# License, or (at your option) any later version.\n+#\n+# Orion Context Broker is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero\n+# General Public License for more details.\n+#\n+# You should have received a copy of the GNU Affero General Public License\n+# along with Orion Context Broker. If not, see http://www.gnu.org/licenses/.\n+#\n+# For those usages not covered by this license please contact with\n+# iot_support at tid dot es\n+\n+# VALGRIND_READY - to mark the test ready for valgrindTestSuite.sh\n+\n+--NAME--","path":"test/functionalTest/cases/3001_mqtt/subscribe_and_update.test","position":23,"original_position":23,"commit_id":"d7522bf5d5d2686d4355d44258349b07a2734c45","original_commit_id":"d7522bf5d5d2686d4355d44258349b07a2734c45","user":{"login":"fgalan","id":1534240,"avatar_url":"https://avatars3.githubusercontent.com/u/1534240?v=4","gravatar_id":"","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"I'd suggest to include in this .test the following remark:\r\n\r\n\"FIXME: this .test has to be adjusted in a next PR as part of #3001 work\"\r\n\r\nor a similar wording.","created_at":"2018-05-30T16:47:08Z","updated_at":"2018-05-30T16:47:08Z","html_url":"https://github.com/telefonicaid/fiware-orion/pull/3194#discussion_r191841334","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/191841334"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/3194#discussion_r191841334"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194"}}},"pull_request":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194","id":191219861,"html_url":"https://github.com/telefonicaid/fiware-orion/pull/3194","diff_url":"https://github.com/telefonicaid/fiware-orion/pull/3194.diff","patch_url":"https://github.com/telefonicaid/fiware-orion/pull/3194.patch","issue_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3194","number":3194,"state":"open","locked":false,"title":"3001: MQTT inital module implementation","user":{"login":"McMutton","id":1322448,"avatar_url":"https://avatars3.githubusercontent.com/u/1322448?v=4","gravatar_id":"","url":"https://api.github.com/users/McMutton","html_url":"https://github.com/McMutton","followers_url":"https://api.github.com/users/McMutton/followers","following_url":"https://api.github.com/users/McMutton/following{/other_user}","gists_url":"https://api.github.com/users/McMutton/gists{/gist_id}","starred_url":"https://api.github.com/users/McMutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McMutton/subscriptions","organizations_url":"https://api.github.com/users/McMutton/orgs","repos_url":"https://api.github.com/users/McMutton/repos","events_url":"https://api.github.com/users/McMutton/events{/privacy}","received_events_url":"https://api.github.com/users/McMutton/received_events","type":"User","site_admin":false},"body":"\r\nThis PR implements the CLI and the core logic for MQTT client.\r\n\r\nOrion can now be started with the mqtt command option: \r\n`contextBroker -mqttHost <host> -mqttPort <port> -mqttKeepAlive <keepalive>`\r\n\r\nI'll leave review comments on the relevant code lines to start the discussions for the next PR.\r\n","created_at":"2018-05-29T17:37:19Z","updated_at":"2018-05-30T16:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dada309a36a01717f08417e478ee817b1bb81c40","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194/commits","review_comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194/comments","review_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3194/comments","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/d7522bf5d5d2686d4355d44258349b07a2734c45","head":{"label":"McMutton:task/3001_core_mqtt_and_cli","ref":"task/3001_core_mqtt_and_cli","sha":"d7522bf5d5d2686d4355d44258349b07a2734c45","user":{"login":"McMutton","id":1322448,"avatar_url":"https://avatars3.githubusercontent.com/u/1322448?v=4","gravatar_id":"","url":"https://api.github.com/users/McMutton","html_url":"https://github.com/McMutton","followers_url":"https://api.github.com/users/McMutton/followers","following_url":"https://api.github.com/users/McMutton/following{/other_user}","gists_url":"https://api.github.com/users/McMutton/gists{/gist_id}","starred_url":"https://api.github.com/users/McMutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McMutton/subscriptions","organizations_url":"https://api.github.com/users/McMutton/orgs","repos_url":"https://api.github.com/users/McMutton/repos","events_url":"https://api.github.com/users/McMutton/events{/privacy}","received_events_url":"https://api.github.com/users/McMutton/received_events","type":"User","site_admin":false},"repo":{"id":98644825,"name":"fiware-orion","full_name":"McMutton/fiware-orion","owner":{"login":"McMutton","id":1322448,"avatar_url":"https://avatars3.githubusercontent.com/u/1322448?v=4","gravatar_id":"","url":"https://api.github.com/users/McMutton","html_url":"https://github.com/McMutton","followers_url":"https://api.github.com/users/McMutton/followers","following_url":"https://api.github.com/users/McMutton/following{/other_user}","gists_url":"https://api.github.com/users/McMutton/gists{/gist_id}","starred_url":"https://api.github.com/users/McMutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McMutton/subscriptions","organizations_url":"https://api.github.com/users/McMutton/orgs","repos_url":"https://api.github.com/users/McMutton/repos","events_url":"https://api.github.com/users/McMutton/events{/privacy}","received_events_url":"https://api.github.com/users/McMutton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/McMutton/fiware-orion","description":"FIWARE Orion Context Broker","fork":true,"url":"https://api.github.com/repos/McMutton/fiware-orion","forks_url":"https://api.github.com/repos/McMutton/fiware-orion/forks","keys_url":"https://api.github.com/repos/McMutton/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McMutton/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McMutton/fiware-orion/teams","hooks_url":"https://api.github.com/repos/McMutton/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/McMutton/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/McMutton/fiware-orion/events","assignees_url":"https://api.github.com/repos/McMutton/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/McMutton/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/McMutton/fiware-orion/tags","blobs_url":"https://api.github.com/repos/McMutton/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McMutton/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McMutton/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/McMutton/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McMutton/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/McMutton/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/McMutton/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/McMutton/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/McMutton/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/McMutton/fiware-orion/subscription","commits_url":"https://api.github.com/repos/McMutton/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/McMutton/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/McMutton/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/McMutton/fiware-orion/issues/comments{/number}","contents_url":"https://api.github.com/repos/McMutton/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/McMutton/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McMutton/fiware-orion/merges","archive_url":"https://api.github.com/repos/McMutton/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McMutton/fiware-orion/downloads","issues_url":"https://api.github.com/repos/McMutton/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/McMutton/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/McMutton/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/McMutton/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McMutton/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/McMutton/fiware-orion/releases{/id}","deployments_url":"https://api.github.com/repos/McMutton/fiware-orion/deployments","created_at":"2017-07-28T11:51:34Z","updated_at":"2018-05-30T10:17:43Z","pushed_at":"2018-05-30T15:10:16Z","git_url":"git://github.com/McMutton/fiware-orion.git","ssh_url":"git@github.com:McMutton/fiware-orion.git","clone_url":"https://github.com/McMutton/fiware-orion.git","svn_url":"https://github.com/McMutton/fiware-orion","homepage":"http://catalogue.fiware.org/enablers/publishsubscribe-context-broker-orion-context-broker","size":34257,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telefonicaid:feature/mqtt_notifications_poc","ref":"feature/mqtt_notifications_poc","sha":"70d9000da1f251ccd773f0d491839c13564ccdec","user":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars2.githubusercontent.com/u/968363?v=4","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"repo":{"id":12808420,"name":"fiware-orion","full_name":"telefonicaid/fiware-orion","owner":{"login":"telefonicaid","id":968363,"avatar_url":"https://avatars2.githubusercontent.com/u/968363?v=4","gravatar_id":"","url":"https://api.github.com/users/telefonicaid","html_url":"https://github.com/telefonicaid","followers_url":"https://api.github.com/users/telefonicaid/followers","following_url":"https://api.github.com/users/telefonicaid/following{/other_user}","gists_url":"https://api.github.com/users/telefonicaid/gists{/gist_id}","starred_url":"https://api.github.com/users/telefonicaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telefonicaid/subscriptions","organizations_url":"https://api.github.com/users/telefonicaid/orgs","repos_url":"https://api.github.com/users/telefonicaid/repos","events_url":"https://api.github.com/users/telefonicaid/events{/privacy}","received_events_url":"https://api.github.com/users/telefonicaid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telefonicaid/fiware-orion","description":"FIWARE Orion Context Broker","fork":false,"url":"https://api.github.com/repos/telefonicaid/fiware-orion","forks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/forks","keys_url":"https://api.github.com/repos/telefonicaid/fiware-orion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telefonicaid/fiware-orion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telefonicaid/fiware-orion/teams","hooks_url":"https://api.github.com/repos/telefonicaid/fiware-orion/hooks","issue_events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/events{/number}","events_url":"https://api.github.com/repos/telefonicaid/fiware-orion/events","assignees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/assignees{/user}","branches_url":"https://api.github.com/repos/telefonicaid/fiware-orion/branches{/branch}","tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/tags","blobs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/refs{/sha}","trees_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/{sha}","languages_url":"https://api.github.com/repos/telefonicaid/fiware-orion/languages","stargazers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/stargazers","contributors_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contributors","subscribers_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscribers","subscription_url":"https://api.github.com/repos/telefonicaid/fiware-orion/subscription","commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/commits{/sha}","git_commits_url":"https://api.github.com/repos/telefonicaid/fiware-orion/git/commits{/sha}","comments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/comments{/number}","issue_comment_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/comments{/number}","contents_url":"https://api.github.com/repos/telefonicaid/fiware-orion/contents/{+path}","compare_url":"https://api.github.com/repos/telefonicaid/fiware-orion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telefonicaid/fiware-orion/merges","archive_url":"https://api.github.com/repos/telefonicaid/fiware-orion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telefonicaid/fiware-orion/downloads","issues_url":"https://api.github.com/repos/telefonicaid/fiware-orion/issues{/number}","pulls_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls{/number}","milestones_url":"https://api.github.com/repos/telefonicaid/fiware-orion/milestones{/number}","notifications_url":"https://api.github.com/repos/telefonicaid/fiware-orion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telefonicaid/fiware-orion/labels{/name}","releases_url":"https://api.github.com/repos/telefonicaid/fiware-orion/releases{/id}","deployments_url":"https://api.github.com/repos/telefonicaid/fiware-orion/deployments","created_at":"2013-09-13T11:55:25Z","updated_at":"2018-05-30T09:28:22Z","pushed_at":"2018-05-30T13:47:22Z","git_url":"git://github.com/telefonicaid/fiware-orion.git","ssh_url":"git@github.com:telefonicaid/fiware-orion.git","clone_url":"https://github.com/telefonicaid/fiware-orion.git","svn_url":"https://github.com/telefonicaid/fiware-orion","homepage":"http://catalogue.fiware.org/enablers/publishsubscribe-context-broker-orion-context-broker","size":34269,"stargazers_count":68,"watchers_count":68,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":114,"open_issues":348,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/3194"},"issue":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3194"},"comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/issues/3194/comments"},"review_comments":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194/comments"},"review_comment":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/3194/commits"},"statuses":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/statuses/d7522bf5d5d2686d4355d44258349b07a2734c45"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fgalan"}}