{"action":"created","comment":{"url":"https://api.github.com/repos/ppadma/drill/pulls/comments/191942620","pull_request_review_id":124519095,"id":191942620,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTk0MjYyMA==","diff_hunk":"@@ -230,18 +267,37 @@ protected IterOutcome doWork() {\n       container.buildSchema(SelectionVectorMode.NONE);\n     }\n \n+    memoryManager.updateOutgoingStats(outputRecords);\n+    if (logger.isDebugEnabled()) {\n+      logger.debug(\"BATCH_STATS, outgoing: {}\", new RecordBatchSizer(this));\n+    }\n     // Get the final outcome based on hasRemainder since that will determine if all the incoming records were\n     // consumed in current output batch or not\n     return getFinalOutcome(hasRemainder);\n   }\n \n   private void handleRemainder() {\n     final int remainingRecordCount = incoming.getRecordCount() - remainderIndex;\n-    if (!doAlloc(remainingRecordCount)) {\n+    assert this.memoryManager.incomingBatch == incoming;","path":"exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java","position":135,"original_position":135,"commit_id":"846fca10cae8f01c5b8b4120fafeb3d65cc09d08","original_commit_id":"3575cc5d17b2772995b3f6aca101baf7d2951873","user":{"login":"ppadma","id":1904860,"node_id":"MDQ6VXNlcjE5MDQ4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1904860?v=4","gravatar_id":"","url":"https://api.github.com/users/ppadma","html_url":"https://github.com/ppadma","followers_url":"https://api.github.com/users/ppadma/followers","following_url":"https://api.github.com/users/ppadma/following{/other_user}","gists_url":"https://api.github.com/users/ppadma/gists{/gist_id}","starred_url":"https://api.github.com/users/ppadma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppadma/subscriptions","organizations_url":"https://api.github.com/users/ppadma/orgs","repos_url":"https://api.github.com/users/ppadma/repos","events_url":"https://api.github.com/users/ppadma/events{/privacy}","received_events_url":"https://api.github.com/users/ppadma/received_events","type":"User","site_admin":false},"body":"do we really need this assert ?","created_at":"2018-05-30T22:29:04Z","updated_at":"2018-05-30T22:50:39Z","html_url":"https://github.com/ppadma/drill/pull/1#discussion_r191942620","pull_request_url":"https://api.github.com/repos/ppadma/drill/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ppadma/drill/pulls/comments/191942620"},"html":{"href":"https://github.com/ppadma/drill/pull/1#discussion_r191942620"},"pull_request":{"href":"https://api.github.com/repos/ppadma/drill/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ppadma/drill/pulls/1","id":191293206,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjkzMjA2","html_url":"https://github.com/ppadma/drill/pull/1","diff_url":"https://github.com/ppadma/drill/pull/1.diff","patch_url":"https://github.com/ppadma/drill/pull/1.patch","issue_url":"https://api.github.com/repos/ppadma/drill/issues/1","number":1,"state":"open","locked":false,"title":"Project BS Review","user":{"login":"bitblender","id":430469,"node_id":"MDQ6VXNlcjQzMDQ2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/430469?v=4","gravatar_id":"","url":"https://api.github.com/users/bitblender","html_url":"https://github.com/bitblender","followers_url":"https://api.github.com/users/bitblender/followers","following_url":"https://api.github.com/users/bitblender/following{/other_user}","gists_url":"https://api.github.com/users/bitblender/gists{/gist_id}","starred_url":"https://api.github.com/users/bitblender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitblender/subscriptions","organizations_url":"https://api.github.com/users/bitblender/orgs","repos_url":"https://api.github.com/users/bitblender/repos","events_url":"https://api.github.com/users/bitblender/events{/privacy}","received_events_url":"https://api.github.com/users/bitblender/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-29T23:09:23Z","updated_at":"2018-05-30T22:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8596048696f1a0d08f5bb5e0d3f705ea3484e24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppadma/drill/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ppadma/drill/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ppadma/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppadma/drill/issues/1/comments","statuses_url":"https://api.github.com/repos/ppadma/drill/statuses/846fca10cae8f01c5b8b4120fafeb3d65cc09d08","head":{"label":"bitblender:KM-DRILL-6340-VAR-2","ref":"KM-DRILL-6340-VAR-2","sha":"846fca10cae8f01c5b8b4120fafeb3d65cc09d08","user":{"login":"bitblender","id":430469,"node_id":"MDQ6VXNlcjQzMDQ2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/430469?v=4","gravatar_id":"","url":"https://api.github.com/users/bitblender","html_url":"https://github.com/bitblender","followers_url":"https://api.github.com/users/bitblender/followers","following_url":"https://api.github.com/users/bitblender/following{/other_user}","gists_url":"https://api.github.com/users/bitblender/gists{/gist_id}","starred_url":"https://api.github.com/users/bitblender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitblender/subscriptions","organizations_url":"https://api.github.com/users/bitblender/orgs","repos_url":"https://api.github.com/users/bitblender/repos","events_url":"https://api.github.com/users/bitblender/events{/privacy}","received_events_url":"https://api.github.com/users/bitblender/received_events","type":"User","site_admin":false},"repo":{"id":68133670,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEzMzY3MA==","name":"drill","full_name":"bitblender/drill","owner":{"login":"bitblender","id":430469,"node_id":"MDQ6VXNlcjQzMDQ2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/430469?v=4","gravatar_id":"","url":"https://api.github.com/users/bitblender","html_url":"https://github.com/bitblender","followers_url":"https://api.github.com/users/bitblender/followers","following_url":"https://api.github.com/users/bitblender/following{/other_user}","gists_url":"https://api.github.com/users/bitblender/gists{/gist_id}","starred_url":"https://api.github.com/users/bitblender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitblender/subscriptions","organizations_url":"https://api.github.com/users/bitblender/orgs","repos_url":"https://api.github.com/users/bitblender/repos","events_url":"https://api.github.com/users/bitblender/events{/privacy}","received_events_url":"https://api.github.com/users/bitblender/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitblender/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/bitblender/drill","forks_url":"https://api.github.com/repos/bitblender/drill/forks","keys_url":"https://api.github.com/repos/bitblender/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitblender/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitblender/drill/teams","hooks_url":"https://api.github.com/repos/bitblender/drill/hooks","issue_events_url":"https://api.github.com/repos/bitblender/drill/issues/events{/number}","events_url":"https://api.github.com/repos/bitblender/drill/events","assignees_url":"https://api.github.com/repos/bitblender/drill/assignees{/user}","branches_url":"https://api.github.com/repos/bitblender/drill/branches{/branch}","tags_url":"https://api.github.com/repos/bitblender/drill/tags","blobs_url":"https://api.github.com/repos/bitblender/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitblender/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitblender/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitblender/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitblender/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/bitblender/drill/languages","stargazers_url":"https://api.github.com/repos/bitblender/drill/stargazers","contributors_url":"https://api.github.com/repos/bitblender/drill/contributors","subscribers_url":"https://api.github.com/repos/bitblender/drill/subscribers","subscription_url":"https://api.github.com/repos/bitblender/drill/subscription","commits_url":"https://api.github.com/repos/bitblender/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitblender/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitblender/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitblender/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitblender/drill/contents/{+path}","compare_url":"https://api.github.com/repos/bitblender/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitblender/drill/merges","archive_url":"https://api.github.com/repos/bitblender/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitblender/drill/downloads","issues_url":"https://api.github.com/repos/bitblender/drill/issues{/number}","pulls_url":"https://api.github.com/repos/bitblender/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/bitblender/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/bitblender/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitblender/drill/labels{/name}","releases_url":"https://api.github.com/repos/bitblender/drill/releases{/id}","deployments_url":"https://api.github.com/repos/bitblender/drill/deployments","created_at":"2016-09-13T18:00:21Z","updated_at":"2016-10-27T21:35:21Z","pushed_at":"2018-05-30T22:01:50Z","git_url":"git://github.com/bitblender/drill.git","ssh_url":"git@github.com:bitblender/drill.git","clone_url":"https://github.com/bitblender/drill.git","svn_url":"https://github.com/bitblender/drill","homepage":"","size":54913,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppadma:master","ref":"master","sha":"1355bfddb1c76462366e28ff7f98fdb6823b4b2a","user":{"login":"ppadma","id":1904860,"node_id":"MDQ6VXNlcjE5MDQ4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1904860?v=4","gravatar_id":"","url":"https://api.github.com/users/ppadma","html_url":"https://github.com/ppadma","followers_url":"https://api.github.com/users/ppadma/followers","following_url":"https://api.github.com/users/ppadma/following{/other_user}","gists_url":"https://api.github.com/users/ppadma/gists{/gist_id}","starred_url":"https://api.github.com/users/ppadma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppadma/subscriptions","organizations_url":"https://api.github.com/users/ppadma/orgs","repos_url":"https://api.github.com/users/ppadma/repos","events_url":"https://api.github.com/users/ppadma/events{/privacy}","received_events_url":"https://api.github.com/users/ppadma/received_events","type":"User","site_admin":false},"repo":{"id":62423374,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQyMzM3NA==","name":"drill","full_name":"ppadma/drill","owner":{"login":"ppadma","id":1904860,"node_id":"MDQ6VXNlcjE5MDQ4NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1904860?v=4","gravatar_id":"","url":"https://api.github.com/users/ppadma","html_url":"https://github.com/ppadma","followers_url":"https://api.github.com/users/ppadma/followers","following_url":"https://api.github.com/users/ppadma/following{/other_user}","gists_url":"https://api.github.com/users/ppadma/gists{/gist_id}","starred_url":"https://api.github.com/users/ppadma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppadma/subscriptions","organizations_url":"https://api.github.com/users/ppadma/orgs","repos_url":"https://api.github.com/users/ppadma/repos","events_url":"https://api.github.com/users/ppadma/events{/privacy}","received_events_url":"https://api.github.com/users/ppadma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppadma/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/ppadma/drill","forks_url":"https://api.github.com/repos/ppadma/drill/forks","keys_url":"https://api.github.com/repos/ppadma/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppadma/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppadma/drill/teams","hooks_url":"https://api.github.com/repos/ppadma/drill/hooks","issue_events_url":"https://api.github.com/repos/ppadma/drill/issues/events{/number}","events_url":"https://api.github.com/repos/ppadma/drill/events","assignees_url":"https://api.github.com/repos/ppadma/drill/assignees{/user}","branches_url":"https://api.github.com/repos/ppadma/drill/branches{/branch}","tags_url":"https://api.github.com/repos/ppadma/drill/tags","blobs_url":"https://api.github.com/repos/ppadma/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppadma/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppadma/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppadma/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppadma/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/ppadma/drill/languages","stargazers_url":"https://api.github.com/repos/ppadma/drill/stargazers","contributors_url":"https://api.github.com/repos/ppadma/drill/contributors","subscribers_url":"https://api.github.com/repos/ppadma/drill/subscribers","subscription_url":"https://api.github.com/repos/ppadma/drill/subscription","commits_url":"https://api.github.com/repos/ppadma/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppadma/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppadma/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppadma/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppadma/drill/contents/{+path}","compare_url":"https://api.github.com/repos/ppadma/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppadma/drill/merges","archive_url":"https://api.github.com/repos/ppadma/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppadma/drill/downloads","issues_url":"https://api.github.com/repos/ppadma/drill/issues{/number}","pulls_url":"https://api.github.com/repos/ppadma/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/ppadma/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/ppadma/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppadma/drill/labels{/name}","releases_url":"https://api.github.com/repos/ppadma/drill/releases{/id}","deployments_url":"https://api.github.com/repos/ppadma/drill/deployments","created_at":"2016-07-01T22:38:58Z","updated_at":"2018-05-30T20:30:17Z","pushed_at":"2018-05-30T22:21:15Z","git_url":"git://github.com/ppadma/drill.git","ssh_url":"git@github.com:ppadma/drill.git","clone_url":"https://github.com/ppadma/drill.git","svn_url":"https://github.com/ppadma/drill","homepage":"","size":54612,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppadma/drill/pulls/1"},"html":{"href":"https://github.com/ppadma/drill/pull/1"},"issue":{"href":"https://api.github.com/repos/ppadma/drill/issues/1"},"comments":{"href":"https://api.github.com/repos/ppadma/drill/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ppadma/drill/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ppadma/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppadma/drill/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ppadma/drill/statuses/846fca10cae8f01c5b8b4120fafeb3d65cc09d08"}},"author_association":"NONE"}}
{"actor":{"display_login":"ppadma"}}