{"action":"closed","number":845,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/845","id":207700104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzAwMTA0","html_url":"https://github.com/ArkEcosystem/core/pull/845","diff_url":"https://github.com/ArkEcosystem/core/pull/845.diff","patch_url":"https://github.com/ArkEcosystem/core/pull/845.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/core/issues/845","number":845,"state":"closed","locked":false,"title":"Fix the API client (bad URLs and wrong tests)","user":{"login":"j-a-m-l","id":1161224,"node_id":"MDQ6VXNlcjExNjEyMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1161224?v=4","gravatar_id":"","url":"https://api.github.com/users/j-a-m-l","html_url":"https://github.com/j-a-m-l","followers_url":"https://api.github.com/users/j-a-m-l/followers","following_url":"https://api.github.com/users/j-a-m-l/following{/other_user}","gists_url":"https://api.github.com/users/j-a-m-l/gists{/gist_id}","starred_url":"https://api.github.com/users/j-a-m-l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-a-m-l/subscriptions","organizations_url":"https://api.github.com/users/j-a-m-l/orgs","repos_url":"https://api.github.com/users/j-a-m-l/repos","events_url":"https://api.github.com/users/j-a-m-l/events{/privacy}","received_events_url":"https://api.github.com/users/j-a-m-l/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\nThe tests of the API client were wrong, so every endpoint was working even when the URL was malformed. This wasn't detected on the last changed neither.\r\nThis PR changes how the tests work and fixes how the URL is built.\r\n\r\n## Types of changes\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n- [x] Test (adding missing tests or fixing existing tests)\r\n\r\n## Further comments\r\nThis is related to https://github.com/ArkEcosystem/core/pull/844, which was the PR that makes me realize that API Client was broken","created_at":"2018-08-10T19:17:24Z","updated_at":"2018-08-13T20:17:59Z","closed_at":"2018-08-13T20:17:58Z","merged_at":"2018-08-13T20:17:58Z","merge_commit_sha":"0a6683974071b448f6da944f73bc21ecdc613750","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexbarnsley","id":8069294,"node_id":"MDQ6VXNlcjgwNjkyOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8069294?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbarnsley","html_url":"https://github.com/alexbarnsley","followers_url":"https://api.github.com/users/alexbarnsley/followers","following_url":"https://api.github.com/users/alexbarnsley/following{/other_user}","gists_url":"https://api.github.com/users/alexbarnsley/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbarnsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbarnsley/subscriptions","organizations_url":"https://api.github.com/users/alexbarnsley/orgs","repos_url":"https://api.github.com/users/alexbarnsley/repos","events_url":"https://api.github.com/users/alexbarnsley/events{/privacy}","received_events_url":"https://api.github.com/users/alexbarnsley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/845/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/845/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/issues/845/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/ce1ea086f22e7ce773e9310dad783d947ed5102a","head":{"label":"j-a-m-l:fix-the-api-client","ref":"fix-the-api-client","sha":"ce1ea086f22e7ce773e9310dad783d947ed5102a","user":{"login":"j-a-m-l","id":1161224,"node_id":"MDQ6VXNlcjExNjEyMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1161224?v=4","gravatar_id":"","url":"https://api.github.com/users/j-a-m-l","html_url":"https://github.com/j-a-m-l","followers_url":"https://api.github.com/users/j-a-m-l/followers","following_url":"https://api.github.com/users/j-a-m-l/following{/other_user}","gists_url":"https://api.github.com/users/j-a-m-l/gists{/gist_id}","starred_url":"https://api.github.com/users/j-a-m-l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-a-m-l/subscriptions","organizations_url":"https://api.github.com/users/j-a-m-l/orgs","repos_url":"https://api.github.com/users/j-a-m-l/repos","events_url":"https://api.github.com/users/j-a-m-l/events{/privacy}","received_events_url":"https://api.github.com/users/j-a-m-l/received_events","type":"User","site_admin":false},"repo":{"id":137375239,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczNzUyMzk=","name":"core","full_name":"j-a-m-l/core","owner":{"login":"j-a-m-l","id":1161224,"node_id":"MDQ6VXNlcjExNjEyMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1161224?v=4","gravatar_id":"","url":"https://api.github.com/users/j-a-m-l","html_url":"https://github.com/j-a-m-l","followers_url":"https://api.github.com/users/j-a-m-l/followers","following_url":"https://api.github.com/users/j-a-m-l/following{/other_user}","gists_url":"https://api.github.com/users/j-a-m-l/gists{/gist_id}","starred_url":"https://api.github.com/users/j-a-m-l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-a-m-l/subscriptions","organizations_url":"https://api.github.com/users/j-a-m-l/orgs","repos_url":"https://api.github.com/users/j-a-m-l/repos","events_url":"https://api.github.com/users/j-a-m-l/events{/privacy}","received_events_url":"https://api.github.com/users/j-a-m-l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-a-m-l/core","description":"The WP of Blockchains :fireworks:","fork":true,"url":"https://api.github.com/repos/j-a-m-l/core","forks_url":"https://api.github.com/repos/j-a-m-l/core/forks","keys_url":"https://api.github.com/repos/j-a-m-l/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-a-m-l/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-a-m-l/core/teams","hooks_url":"https://api.github.com/repos/j-a-m-l/core/hooks","issue_events_url":"https://api.github.com/repos/j-a-m-l/core/issues/events{/number}","events_url":"https://api.github.com/repos/j-a-m-l/core/events","assignees_url":"https://api.github.com/repos/j-a-m-l/core/assignees{/user}","branches_url":"https://api.github.com/repos/j-a-m-l/core/branches{/branch}","tags_url":"https://api.github.com/repos/j-a-m-l/core/tags","blobs_url":"https://api.github.com/repos/j-a-m-l/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-a-m-l/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-a-m-l/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-a-m-l/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-a-m-l/core/statuses/{sha}","languages_url":"https://api.github.com/repos/j-a-m-l/core/languages","stargazers_url":"https://api.github.com/repos/j-a-m-l/core/stargazers","contributors_url":"https://api.github.com/repos/j-a-m-l/core/contributors","subscribers_url":"https://api.github.com/repos/j-a-m-l/core/subscribers","subscription_url":"https://api.github.com/repos/j-a-m-l/core/subscription","commits_url":"https://api.github.com/repos/j-a-m-l/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-a-m-l/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-a-m-l/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-a-m-l/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-a-m-l/core/contents/{+path}","compare_url":"https://api.github.com/repos/j-a-m-l/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-a-m-l/core/merges","archive_url":"https://api.github.com/repos/j-a-m-l/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-a-m-l/core/downloads","issues_url":"https://api.github.com/repos/j-a-m-l/core/issues{/number}","pulls_url":"https://api.github.com/repos/j-a-m-l/core/pulls{/number}","milestones_url":"https://api.github.com/repos/j-a-m-l/core/milestones{/number}","notifications_url":"https://api.github.com/repos/j-a-m-l/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-a-m-l/core/labels{/name}","releases_url":"https://api.github.com/repos/j-a-m-l/core/releases{/id}","deployments_url":"https://api.github.com/repos/j-a-m-l/core/deployments","created_at":"2018-06-14T15:16:13Z","updated_at":"2018-08-11T17:17:24Z","pushed_at":"2018-08-13T19:58:01Z","git_url":"git://github.com/j-a-m-l/core.git","ssh_url":"git@github.com:j-a-m-l/core.git","clone_url":"https://github.com/j-a-m-l/core.git","svn_url":"https://github.com/j-a-m-l/core","homepage":"https://ark.io","size":7361,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ArkEcosystem:master","ref":"master","sha":"cdb34dd949a9f427175041db85b7930da99e33e8","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":111684364,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2ODQzNjQ=","name":"core","full_name":"ArkEcosystem/core","owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArkEcosystem/core","description":"The Ark Blockchain :fireworks:","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/core","forks_url":"https://api.github.com/repos/ArkEcosystem/core/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/core/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/core/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/core/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/core/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/core/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/core/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/core/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/core/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/core/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/core/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/core/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/core/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/core/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/core/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/core/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/core/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/core/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/core/deployments","created_at":"2017-11-22T12:57:35Z","updated_at":"2018-08-13T19:57:48Z","pushed_at":"2018-08-13T20:17:58Z","git_url":"git://github.com/ArkEcosystem/core.git","ssh_url":"git@github.com:ArkEcosystem/core.git","clone_url":"https://github.com/ArkEcosystem/core.git","svn_url":"https://github.com/ArkEcosystem/core","homepage":"https://ark.io","size":7320,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":21,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/845"},"html":{"href":"https://github.com/ArkEcosystem/core/pull/845"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/845"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/core/statuses/ce1ea086f22e7ce773e9310dad783d947ed5102a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"j-a-m-l","id":1161224,"node_id":"MDQ6VXNlcjExNjEyMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1161224?v=4","gravatar_id":"","url":"https://api.github.com/users/j-a-m-l","html_url":"https://github.com/j-a-m-l","followers_url":"https://api.github.com/users/j-a-m-l/followers","following_url":"https://api.github.com/users/j-a-m-l/following{/other_user}","gists_url":"https://api.github.com/users/j-a-m-l/gists{/gist_id}","starred_url":"https://api.github.com/users/j-a-m-l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-a-m-l/subscriptions","organizations_url":"https://api.github.com/users/j-a-m-l/orgs","repos_url":"https://api.github.com/users/j-a-m-l/repos","events_url":"https://api.github.com/users/j-a-m-l/events{/privacy}","received_events_url":"https://api.github.com/users/j-a-m-l/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":321,"deletions":228,"changed_files":42}}
{"actor":{"display_login":"j-a-m-l"}}