{"action":"created","issue":{"url":"https://api.github.com/repos/berndbischl/ParamHelpers/issues/206","repository_url":"https://api.github.com/repos/berndbischl/ParamHelpers","labels_url":"https://api.github.com/repos/berndbischl/ParamHelpers/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/berndbischl/ParamHelpers/issues/206/comments","events_url":"https://api.github.com/repos/berndbischl/ParamHelpers/issues/206/events","html_url":"https://github.com/berndbischl/ParamHelpers/pull/206","id":384317183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTQ3Mjc4","number":206,"title":"add 'distinct' argument to VectorParams","user":{"login":"pat-s","id":8430564,"node_id":"MDQ6VXNlcjg0MzA1NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8430564?v=4","gravatar_id":"","url":"https://api.github.com/users/pat-s","html_url":"https://github.com/pat-s","followers_url":"https://api.github.com/users/pat-s/followers","following_url":"https://api.github.com/users/pat-s/following{/other_user}","gists_url":"https://api.github.com/users/pat-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pat-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat-s/subscriptions","organizations_url":"https://api.github.com/users/pat-s/orgs","repos_url":"https://api.github.com/users/pat-s/repos","events_url":"https://api.github.com/users/pat-s/events{/privacy}","received_events_url":"https://api.github.com/users/pat-s/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-26T12:53:05Z","updated_at":"2018-11-29T16:52:33Z","closed_at":"2018-11-29T16:22:18Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/berndbischl/ParamHelpers/pulls/206","html_url":"https://github.com/berndbischl/ParamHelpers/pull/206","diff_url":"https://github.com/berndbischl/ParamHelpers/pull/206.diff","patch_url":"https://github.com/berndbischl/ParamHelpers/pull/206.patch"},"body":"To enable sampling without replacement.\r\n\r\nCurrently, sampling with replacement is hardcoded for vector params.\r\n\r\nThis is needed to sample unique filter methods which are going to be used in ensemble filters.\r\n\r\n@jakob-r \tIs this possible in paradox already?\r\n\r\nEdit: The fix obv only works for tuneXXX methods that use `sampleValue`. MBO does not. So maybe we need to tackle this in multiple repos.."},"comment":{"url":"https://api.github.com/repos/berndbischl/ParamHelpers/issues/comments/442908616","html_url":"https://github.com/berndbischl/ParamHelpers/pull/206#issuecomment-442908616","issue_url":"https://api.github.com/repos/berndbischl/ParamHelpers/issues/206","id":442908616,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjkwODYxNg==","user":{"login":"berndbischl","id":1225974,"node_id":"MDQ6VXNlcjEyMjU5NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1225974?v=4","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T16:52:33Z","updated_at":"2018-11-29T16:52:33Z","author_association":"OWNER","body":"i read the code, i also read your text here, still had some problems to understand what exactly is to be adressed. \r\n\r\n\r\n\r\n> Should I open an issue in _paradox_?\r\n\r\nyes, i think it makes sense to continue discussing there. i have some things to mention"}}
{"actor":{"display_login":"berndbischl"}}