{"action":"closed","number":2540,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2540","id":223465977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDY1OTc3","html_url":"https://github.com/dotnet/corefxlab/pull/2540","diff_url":"https://github.com/dotnet/corefxlab/pull/2540.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/2540.patch","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2540","number":2540,"state":"closed","locked":false,"title":"Add JsonReaderOption to track position by UTF-8 code points","user":{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"body":"- 15-25% regression for default case (extra option checks)\r\n- 40-50% regression if JsonReaderOptions.TrackPositionAsCodePoints is enabled\r\n\r\n**Master:**\r\n\r\nMethod | TestCase | Mean\r\n-- | -- | --\r\nReadJsonEmptyLoop | BasicJson | 487.7\r\nReadJsonEmptyLoop | HelloWorld | 94.53\r\nReadJsonEmptyLoop | Json400B | 1,184.25\r\nReadJsonEmptyLoop | Json400KB | 842,661.75\r\nReadJsonEmptyLoop | Json40KB | 77,793.18\r\nReadJsonEmptyLoop | Json4KB | 6,013.05\r\n\r\n**This PR:**\r\n\r\nMethod | TestCase | Mean | Scaled\r\n-- | -- | -- | --\r\nReadJsonEmptyLoop | BasicJson | 610.4 | 1\r\nReadJsonTrackCodePoints | BasicJson | 727.2 | 1.19\r\n  |   |   |  \r\nReadJsonEmptyLoop | HelloWorld | 114.5 | 1\r\nReadJsonTrackCodePoints | HelloWorld | 146.3 | 1.29\r\n  |   |   |  \r\nReadJsonEmptyLoop | Json400B | 947.6 | 1\r\nReadJsonTrackCodePoints | Json400B | 1,165.60 | 1.23\r\n  |   |   |  \r\nReadJsonEmptyLoop | Json400KB | 944,848.70 | 1\r\nReadJsonTrackCodePoints | Json400KB | 1,190,698.80 | 1.26\r\n  |   |   |  \r\nReadJsonEmptyLoop | Json40KB | 97,522.80 | 1\r\nReadJsonTrackCodePoints | Json40KB | 111,703.40 | 1.17\r\n  |   |   |  \r\nReadJsonEmptyLoop | Json4KB | 7,074.50 | 1\r\nReadJsonTrackCodePoints | Json4KB | 8,759.90 | 1.24","created_at":"2018-10-17T04:32:25Z","updated_at":"2018-10-17T19:56:17Z","closed_at":"2018-10-17T19:56:17Z","merged_at":"2018-10-17T19:56:17Z","merge_commit_sha":"2dda4ce20cfd017bf6843aefe0b076f4b720e361","assignee":{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"assignees":[{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":448406037,"node_id":"MDU6TGFiZWw0NDg0MDYwMzc=","url":"https://api.github.com/repos/dotnet/corefxlab/labels/area-System.Text.Json","name":"area-System.Text.Json","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2540/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2540/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2540/comments","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/6a9ac8a838789ccf24e69be3ae993cdde9177af3","head":{"label":"ahsonkhan:AddTrackPositionAsCodePoints","ref":"AddTrackPositionAsCodePoints","sha":"6a9ac8a838789ccf24e69be3ae993cdde9177af3","user":{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"repo":{"id":41757604,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc1NzYwNA==","name":"corefxlab","full_name":"ahsonkhan/corefxlab","private":false,"owner":{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ahsonkhan/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":true,"url":"https://api.github.com/repos/ahsonkhan/corefxlab","forks_url":"https://api.github.com/repos/ahsonkhan/corefxlab/forks","keys_url":"https://api.github.com/repos/ahsonkhan/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahsonkhan/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahsonkhan/corefxlab/teams","hooks_url":"https://api.github.com/repos/ahsonkhan/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/ahsonkhan/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/ahsonkhan/corefxlab/events","assignees_url":"https://api.github.com/repos/ahsonkhan/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/ahsonkhan/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/ahsonkhan/corefxlab/tags","blobs_url":"https://api.github.com/repos/ahsonkhan/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahsonkhan/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahsonkhan/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahsonkhan/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahsonkhan/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/ahsonkhan/corefxlab/languages","stargazers_url":"https://api.github.com/repos/ahsonkhan/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/ahsonkhan/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/ahsonkhan/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/ahsonkhan/corefxlab/subscription","commits_url":"https://api.github.com/repos/ahsonkhan/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahsonkhan/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahsonkhan/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahsonkhan/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahsonkhan/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/ahsonkhan/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahsonkhan/corefxlab/merges","archive_url":"https://api.github.com/repos/ahsonkhan/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahsonkhan/corefxlab/downloads","issues_url":"https://api.github.com/repos/ahsonkhan/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/ahsonkhan/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/ahsonkhan/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/ahsonkhan/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahsonkhan/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/ahsonkhan/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/ahsonkhan/corefxlab/deployments","created_at":"2015-09-01T19:04:07Z","updated_at":"2018-10-16T23:16:54Z","pushed_at":"2018-10-17T03:41:23Z","git_url":"git://github.com/ahsonkhan/corefxlab.git","ssh_url":"git@github.com:ahsonkhan/corefxlab.git","clone_url":"https://github.com/ahsonkhan/corefxlab.git","svn_url":"https://github.com/ahsonkhan/corefxlab","homepage":"","size":57795,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"aed18c77939c9beb7c9a260b6f1b9e0154e068f1","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29504192,"node_id":"MDEwOlJlcG9zaXRvcnkyOTUwNDE5Mg==","name":"corefxlab","full_name":"dotnet/corefxlab","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefxlab","description":"This repo is for experimentation and exploring new ideas that may or may not make it into the main corefx repo.","fork":false,"url":"https://api.github.com/repos/dotnet/corefxlab","forks_url":"https://api.github.com/repos/dotnet/corefxlab/forks","keys_url":"https://api.github.com/repos/dotnet/corefxlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefxlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefxlab/teams","hooks_url":"https://api.github.com/repos/dotnet/corefxlab/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefxlab/events","assignees_url":"https://api.github.com/repos/dotnet/corefxlab/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefxlab/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefxlab/tags","blobs_url":"https://api.github.com/repos/dotnet/corefxlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefxlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefxlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefxlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefxlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefxlab/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefxlab/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefxlab/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefxlab/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefxlab/subscription","commits_url":"https://api.github.com/repos/dotnet/corefxlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefxlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefxlab/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefxlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefxlab/merges","archive_url":"https://api.github.com/repos/dotnet/corefxlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefxlab/downloads","issues_url":"https://api.github.com/repos/dotnet/corefxlab/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefxlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefxlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefxlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefxlab/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefxlab/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefxlab/deployments","created_at":"2015-01-20T00:44:35Z","updated_at":"2018-10-17T19:24:04Z","pushed_at":"2018-10-17T19:56:17Z","git_url":"git://github.com/dotnet/corefxlab.git","ssh_url":"git@github.com:dotnet/corefxlab.git","clone_url":"https://github.com/dotnet/corefxlab.git","svn_url":"https://github.com/dotnet/corefxlab","homepage":"","size":57778,"stargazers_count":1191,"watchers_count":1191,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":312,"mirror_url":null,"archived":false,"open_issues_count":201,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":312,"open_issues":201,"watchers":1191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2540"},"html":{"href":"https://github.com/dotnet/corefxlab/pull/2540"},"issue":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/2540"},"comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/issues/2540/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2540/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefxlab/pulls/2540/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefxlab/statuses/6a9ac8a838789ccf24e69be3ae993cdde9177af3"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":405,"deletions":217,"changed_files":4}}
{"actor":{"display_login":"ahsonkhan"}}