{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/comments/200731145","pull_request_review_id":135105126,"id":200731145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDczMTE0NQ==","diff_hunk":"@@ -60,7 +61,45 @@ export class EdgeDebugAdapter extends CoreDebugAdapter {\n         return capabilities;\n     }\n \n-    public launch(args: ILaunchRequestArgs): Promise<void> {\n+    private async _checkPortOccupiedByEDP(address: string, port: number): Promise<void> {","path":"src/edgeDebugAdapter.ts","position":13,"original_position":13,"commit_id":"6183504edbdd3023c3d7b23d65ec2df705f1a62d","original_commit_id":"6183504edbdd3023c3d7b23d65ec2df705f1a62d","user":{"login":"digeff","id":14098140,"node_id":"MDQ6VXNlcjE0MDk4MTQw","avatar_url":"https://avatars1.githubusercontent.com/u/14098140?v=4","gravatar_id":"","url":"https://api.github.com/users/digeff","html_url":"https://github.com/digeff","followers_url":"https://api.github.com/users/digeff/followers","following_url":"https://api.github.com/users/digeff/following{/other_user}","gists_url":"https://api.github.com/users/digeff/gists{/gist_id}","starred_url":"https://api.github.com/users/digeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digeff/subscriptions","organizations_url":"https://api.github.com/users/digeff/orgs","repos_url":"https://api.github.com/users/digeff/repos","events_url":"https://api.github.com/users/digeff/events{/privacy}","received_events_url":"https://api.github.com/users/digeff/received_events","type":"User","site_admin":false},"body":"Would it make sense to refactor the code in _getVersionData in vscode-chrome-debug-core to find a way to use that code, instead of creating our own version of calling /json/version here?","created_at":"2018-07-06T18:09:57Z","updated_at":"2018-07-06T18:12:03Z","html_url":"https://github.com/Microsoft/vscode-edge-debug2/pull/84#discussion_r200731145","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/comments/200731145"},"html":{"href":"https://github.com/Microsoft/vscode-edge-debug2/pull/84#discussion_r200731145"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84","id":199593369,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTkzMzY5","html_url":"https://github.com/Microsoft/vscode-edge-debug2/pull/84","diff_url":"https://github.com/Microsoft/vscode-edge-debug2/pull/84.diff","patch_url":"https://github.com/Microsoft/vscode-edge-debug2/pull/84.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/84","number":84,"state":"open","locked":false,"title":"Adding check to see if port is occupied","user":{"login":"rakatyal","id":12533467,"node_id":"MDQ6VXNlcjEyNTMzNDY3","avatar_url":"https://avatars2.githubusercontent.com/u/12533467?v=4","gravatar_id":"","url":"https://api.github.com/users/rakatyal","html_url":"https://github.com/rakatyal","followers_url":"https://api.github.com/users/rakatyal/followers","following_url":"https://api.github.com/users/rakatyal/following{/other_user}","gists_url":"https://api.github.com/users/rakatyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rakatyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakatyal/subscriptions","organizations_url":"https://api.github.com/users/rakatyal/orgs","repos_url":"https://api.github.com/users/rakatyal/repos","events_url":"https://api.github.com/users/rakatyal/events{/privacy}","received_events_url":"https://api.github.com/users/rakatyal/received_events","type":"User","site_admin":false},"body":"We now check before launch that the user specified port(for VS Code) or 2015 port given by VS is used by another process. If it's used by EDP, we continue with the launch, if not it errors out with a message.\r\n\r\nI thought about whether to make this change in core to save the duplication of code but I didn't do it for the following reasons:\r\n\r\n1. I would had to make platform specific checks in core to see whether the port is occupied by Edge/Chrome or Node to decide whether we can launch or not. I wanted to avoid it. \r\n2. The reason we have to do /json/version call to verify if EDP is using that port is because if EDP is indeed running on the port, it runs under the 'System' process name and we can't just perform the verification by using the process name. This is not the case for Chrome and node. \r\n3. This way we can give platform specific error messages to the user. This is possible in core as well but not without platform checks which again I wanted to avoid.\r\n\r\n","created_at":"2018-07-05T21:35:45Z","updated_at":"2018-07-06T18:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"508905ba8530bcf21f105720eda8cf7ddcc77186","assignee":null,"assignees":[],"requested_reviewers":[{"login":"roblourens","id":323878,"node_id":"MDQ6VXNlcjMyMzg3OA==","avatar_url":"https://avatars3.githubusercontent.com/u/323878?v=4","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/84/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/statuses/6183504edbdd3023c3d7b23d65ec2df705f1a62d","head":{"label":"Microsoft:raghav_port","ref":"raghav_port","sha":"6183504edbdd3023c3d7b23d65ec2df705f1a62d","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117901685,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MDE2ODU=","name":"vscode-edge-debug2","full_name":"Microsoft/vscode-edge-debug2","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-edge-debug2","description":"This is a VS Code extension which helps you debug your JavaScript Code inside the Edge browser.","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2","forks_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/deployments","created_at":"2018-01-17T22:42:45Z","updated_at":"2018-06-21T23:43:34Z","pushed_at":"2018-07-06T17:24:54Z","git_url":"git://github.com/Microsoft/vscode-edge-debug2.git","ssh_url":"git@github.com:Microsoft/vscode-edge-debug2.git","clone_url":"https://github.com/Microsoft/vscode-edge-debug2.git","svn_url":"https://github.com/Microsoft/vscode-edge-debug2","homepage":null,"size":387,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"fb8bbb27853ad81706f728f2ee46dcf56f09c038","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":117901685,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MDE2ODU=","name":"vscode-edge-debug2","full_name":"Microsoft/vscode-edge-debug2","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-edge-debug2","description":"This is a VS Code extension which helps you debug your JavaScript Code inside the Edge browser.","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2","forks_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/deployments","created_at":"2018-01-17T22:42:45Z","updated_at":"2018-06-21T23:43:34Z","pushed_at":"2018-07-06T17:24:54Z","git_url":"git://github.com/Microsoft/vscode-edge-debug2.git","ssh_url":"git@github.com:Microsoft/vscode-edge-debug2.git","clone_url":"https://github.com/Microsoft/vscode-edge-debug2.git","svn_url":"https://github.com/Microsoft/vscode-edge-debug2","homepage":null,"size":387,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84"},"html":{"href":"https://github.com/Microsoft/vscode-edge-debug2/pull/84"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/84"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-edge-debug2/statuses/6183504edbdd3023c3d7b23d65ec2df705f1a62d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"digeff"}}