{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/188250079","pull_request_review_id":120187276,"id":188250079,"diff_hunk":"@@ -1208,15 +1208,17 @@ def drift_add_section_field_expanded(view, section, field)\n       next if fld.nil?\n       val = fld[:_value_].to_s\n \n+      style = nil\n       if idx.zero? # On base object\n         img_bkg = \"cell-stripe\"\n       elsif fld[:_match_]\n         img_bkg = \"cell-bkg-plain-no-shade\"\n       else\n+        style = \"color: #21a0ec;\" if fld[:_match_] == false","path":"app/controllers/application_controller/compare.rb","position":10,"original_position":10,"commit_id":"9b54973aa6dd733a8fc79a3f965e080ad2bef2b6","original_commit_id":"9b54973aa6dd733a8fc79a3f965e080ad2bef2b6","user":{"login":"hstastna","id":13417815,"avatar_url":"https://avatars0.githubusercontent.com/u/13417815?v=4","gravatar_id":"","url":"https://api.github.com/users/hstastna","html_url":"https://github.com/hstastna","followers_url":"https://api.github.com/users/hstastna/followers","following_url":"https://api.github.com/users/hstastna/following{/other_user}","gists_url":"https://api.github.com/users/hstastna/gists{/gist_id}","starred_url":"https://api.github.com/users/hstastna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hstastna/subscriptions","organizations_url":"https://api.github.com/users/hstastna/orgs","repos_url":"https://api.github.com/users/hstastna/repos","events_url":"https://api.github.com/users/hstastna/events{/privacy}","received_events_url":"https://api.github.com/users/hstastna/received_events","type":"User","site_admin":false},"body":"Here we want to set style ONLY when there is `_match_` key and if it is set to `false`. Often, `fld` looks like this: {`:_value_=>\"(empty)\"}`, and then if I used `unless fld[:_match_]`, style would be set, and we don't want this in this case. So I better used condition in this format: `if fld[:_match_] == false`, to make sure that the style is set really only when we want it. Fortunatelly, when `fld` has no `_match_` key, `idx` is usually zero so it will not enter the `else` part of the block and nothing bad should happen, in fact. But I don't want to rely on this (on presence of this line: https://github.com/ManageIQ/manageiq-ui-classic/pull/3938/files#diff-559128a3af015518ec2c6d248d03ef7aR1212).","created_at":"2018-05-15T11:18:33Z","updated_at":"2018-05-15T11:18:33Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3938#discussion_r188250079","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/188250079"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3938#discussion_r188250079"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938"}},"in_reply_to_id":188235809},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938","id":187917166,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3938","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3938.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3938.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3938","number":3938,"state":"open","locked":false,"title":"Change text color to blue for different columns when displaying Drift for VM","user":{"login":"hstastna","id":13417815,"avatar_url":"https://avatars0.githubusercontent.com/u/13417815?v=4","gravatar_id":"","url":"https://api.github.com/users/hstastna","html_url":"https://github.com/hstastna","followers_url":"https://api.github.com/users/hstastna/followers","following_url":"https://api.github.com/users/hstastna/following{/other_user}","gists_url":"https://api.github.com/users/hstastna/gists{/gist_id}","starred_url":"https://api.github.com/users/hstastna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hstastna/subscriptions","organizations_url":"https://api.github.com/users/hstastna/orgs","repos_url":"https://api.github.com/users/hstastna/repos","events_url":"https://api.github.com/users/hstastna/events{/privacy}","received_events_url":"https://api.github.com/users/hstastna/received_events","type":"User","site_admin":false},"body":"**Before:**\r\n![blue_before](https://user-images.githubusercontent.com/13417815/40016843-ee20ac1e-57b7-11e8-9418-928246500e8f.png)\r\n\r\n**After:**\r\n![blue_after](https://user-images.githubusercontent.com/13417815/40016852-f29fa89e-57b7-11e8-8115-d578aa991f9a.png)\r\n","created_at":"2018-05-14T18:47:34Z","updated_at":"2018-05-15T11:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c84afff2e4013b3966dc73296f28c4cb1a48d6d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3938/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/9b54973aa6dd733a8fc79a3f965e080ad2bef2b6","head":{"label":"hstastna:Drift_diff_color_blue","ref":"Drift_diff_color_blue","sha":"9b54973aa6dd733a8fc79a3f965e080ad2bef2b6","user":{"login":"hstastna","id":13417815,"avatar_url":"https://avatars0.githubusercontent.com/u/13417815?v=4","gravatar_id":"","url":"https://api.github.com/users/hstastna","html_url":"https://github.com/hstastna","followers_url":"https://api.github.com/users/hstastna/followers","following_url":"https://api.github.com/users/hstastna/following{/other_user}","gists_url":"https://api.github.com/users/hstastna/gists{/gist_id}","starred_url":"https://api.github.com/users/hstastna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hstastna/subscriptions","organizations_url":"https://api.github.com/users/hstastna/orgs","repos_url":"https://api.github.com/users/hstastna/repos","events_url":"https://api.github.com/users/hstastna/events{/privacy}","received_events_url":"https://api.github.com/users/hstastna/received_events","type":"User","site_admin":false},"repo":{"id":77840876,"name":"manageiq-ui-classic","full_name":"hstastna/manageiq-ui-classic","owner":{"login":"hstastna","id":13417815,"avatar_url":"https://avatars0.githubusercontent.com/u/13417815?v=4","gravatar_id":"","url":"https://api.github.com/users/hstastna","html_url":"https://github.com/hstastna","followers_url":"https://api.github.com/users/hstastna/followers","following_url":"https://api.github.com/users/hstastna/following{/other_user}","gists_url":"https://api.github.com/users/hstastna/gists{/gist_id}","starred_url":"https://api.github.com/users/hstastna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hstastna/subscriptions","organizations_url":"https://api.github.com/users/hstastna/orgs","repos_url":"https://api.github.com/users/hstastna/repos","events_url":"https://api.github.com/users/hstastna/events{/privacy}","received_events_url":"https://api.github.com/users/hstastna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hstastna/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/hstastna/manageiq-ui-classic","forks_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/hstastna/manageiq-ui-classic/deployments","created_at":"2017-01-02T14:56:24Z","updated_at":"2018-05-15T08:51:37Z","pushed_at":"2018-05-15T08:51:35Z","git_url":"git://github.com/hstastna/manageiq-ui-classic.git","ssh_url":"git@github.com:hstastna/manageiq-ui-classic.git","clone_url":"https://github.com/hstastna/manageiq-ui-classic.git","svn_url":"https://github.com/hstastna/manageiq-ui-classic","homepage":null,"size":62973,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"cd8bec3d7f17c90bff04da5fcc51e3780dea403c","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2018-05-15T09:47:13Z","pushed_at":"2018-05-15T10:52:14Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":63015,"stargazers_count":24,"watchers_count":24,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":304,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":243,"open_issues":304,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/3938"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3938"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/3938/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/3938/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/9b54973aa6dd733a8fc79a3f965e080ad2bef2b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hstastna"}}