{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/che/pulls/comments/201002595","pull_request_review_id":135417360,"id":201002595,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTAwMjU5NQ==","diff_hunk":"@@ -0,0 +1,49 @@\n+/*\n+ * Copyright (c) 2012-2018 Red Hat, Inc.\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ *\n+ * Contributors:\n+ *   Red Hat, Inc. - initial API and implementation\n+ */\n+package org.eclipse.che.selenium.pageobject.upload;\n+\n+import com.google.inject.Inject;\n+import com.google.inject.Singleton;\n+import org.eclipse.che.selenium.core.SeleniumWebDriver;\n+import org.eclipse.che.selenium.core.webdriver.SeleniumWebDriverHelper;\n+import org.eclipse.che.selenium.core.webdriver.WebDriverWaitFactory;\n+import org.openqa.selenium.WebElement;\n+import org.openqa.selenium.support.FindBy;\n+\n+@Singleton\n+public class UploadDirectoryDialogPage extends AbstractUploadDialogPage {\n+  private static final String UPLOAD_BUTTON_ID = \"file-uploadFolder-upload\";\n+  private static final String TITLE_XPATH = \"//div[text()='Upload Folder']\";\n+\n+  @FindBy(id = UPLOAD_BUTTON_ID)\n+  private WebElement uploadButton;\n+\n+  @FindBy(xpath = TITLE_XPATH)\n+  private WebElement title;\n+\n+  @Inject\n+  public UploadDirectoryDialogPage(\n+      SeleniumWebDriver seleniumWebDriver,\n+      SeleniumWebDriverHelper seleniumWebDriverHelper,\n+      WebDriverWaitFactory webDriverWaitFactory) {\n+    super(seleniumWebDriver, seleniumWebDriverHelper, webDriverWaitFactory);\n+  }\n+\n+  @Override\n+  WebElement getTitle() {\n+    return title;","path":"selenium/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/upload/UploadDirectoryDialogPage.java","position":42,"original_position":42,"commit_id":"4578451598e0330f14f1fe8391da94a20774c603","original_commit_id":"8877264d61211790000b66f9ed71ae4d3554d057","user":{"login":"Ohrimenko1988","id":22724619,"node_id":"MDQ6VXNlcjIyNzI0NjE5","avatar_url":"https://avatars1.githubusercontent.com/u/22724619?v=4","gravatar_id":"","url":"https://api.github.com/users/Ohrimenko1988","html_url":"https://github.com/Ohrimenko1988","followers_url":"https://api.github.com/users/Ohrimenko1988/followers","following_url":"https://api.github.com/users/Ohrimenko1988/following{/other_user}","gists_url":"https://api.github.com/users/Ohrimenko1988/gists{/gist_id}","starred_url":"https://api.github.com/users/Ohrimenko1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ohrimenko1988/subscriptions","organizations_url":"https://api.github.com/users/Ohrimenko1988/orgs","repos_url":"https://api.github.com/users/Ohrimenko1988/repos","events_url":"https://api.github.com/users/Ohrimenko1988/events{/privacy}","received_events_url":"https://api.github.com/users/Ohrimenko1988/received_events","type":"User","site_admin":false},"body":"please use for avoiding \"ElementNotFound\" exception:\r\n```\r\nreturn seleniumWebDriverHelper.waitVisibility(title);\r\n```","created_at":"2018-07-09T13:32:15Z","updated_at":"2018-07-09T13:32:15Z","html_url":"https://github.com/eclipse/che/pull/10332#discussion_r201002595","pull_request_url":"https://api.github.com/repos/eclipse/che/pulls/10332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments/201002595"},"html":{"href":"https://github.com/eclipse/che/pull/10332#discussion_r201002595"},"pull_request":{"href":"https://api.github.com/repos/eclipse/che/pulls/10332"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/10332","id":200051649,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDUxNjQ5","html_url":"https://github.com/eclipse/che/pull/10332","diff_url":"https://github.com/eclipse/che/pull/10332.diff","patch_url":"https://github.com/eclipse/che/pull/10332.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/10332","number":10332,"state":"open","locked":false,"title":"Add selenium tests to cover the 'Upload Folder/File' feature with default options","user":{"login":"dmytro-ndp","id":1197777,"node_id":"MDQ6VXNlcjExOTc3Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1197777?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytro-ndp","html_url":"https://github.com/dmytro-ndp","followers_url":"https://api.github.com/users/dmytro-ndp/followers","following_url":"https://api.github.com/users/dmytro-ndp/following{/other_user}","gists_url":"https://api.github.com/users/dmytro-ndp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytro-ndp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytro-ndp/subscriptions","organizations_url":"https://api.github.com/users/dmytro-ndp/orgs","repos_url":"https://api.github.com/users/dmytro-ndp/repos","events_url":"https://api.github.com/users/dmytro-ndp/events{/privacy}","received_events_url":"https://api.github.com/users/dmytro-ndp/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nIt adds E2E selenium test class `UploadIntoProjectTest` which verifies uploading file and folder into the project with default options. It supports execution of selenium tests in local mode and in selenium grid.\r\n\r\n### What issues does this PR fix or reference?\r\n#10204","created_at":"2018-07-09T10:10:14Z","updated_at":"2018-07-09T13:32:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a5f938ab5d2fc391c2d58b0ab755c265200ffc5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vparfonov","id":1636592,"node_id":"MDQ6VXNlcjE2MzY1OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1636592?v=4","gravatar_id":"","url":"https://api.github.com/users/vparfonov","html_url":"https://github.com/vparfonov","followers_url":"https://api.github.com/users/vparfonov/followers","following_url":"https://api.github.com/users/vparfonov/following{/other_user}","gists_url":"https://api.github.com/users/vparfonov/gists{/gist_id}","starred_url":"https://api.github.com/users/vparfonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vparfonov/subscriptions","organizations_url":"https://api.github.com/users/vparfonov/orgs","repos_url":"https://api.github.com/users/vparfonov/repos","events_url":"https://api.github.com/users/vparfonov/events{/privacy}","received_events_url":"https://api.github.com/users/vparfonov/received_events","type":"User","site_admin":false},{"login":"artaleks9","id":5408906,"node_id":"MDQ6VXNlcjU0MDg5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/5408906?v=4","gravatar_id":"","url":"https://api.github.com/users/artaleks9","html_url":"https://github.com/artaleks9","followers_url":"https://api.github.com/users/artaleks9/followers","following_url":"https://api.github.com/users/artaleks9/following{/other_user}","gists_url":"https://api.github.com/users/artaleks9/gists{/gist_id}","starred_url":"https://api.github.com/users/artaleks9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artaleks9/subscriptions","organizations_url":"https://api.github.com/users/artaleks9/orgs","repos_url":"https://api.github.com/users/artaleks9/repos","events_url":"https://api.github.com/users/artaleks9/events{/privacy}","received_events_url":"https://api.github.com/users/artaleks9/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":345100759,"node_id":"MDU6TGFiZWwzNDUxMDA3NTk=","url":"https://api.github.com/repos/eclipse/che/labels/kind/task","name":"kind/task","color":"f7c6c7","default":false},{"id":345100523,"node_id":"MDU6TGFiZWwzNDUxMDA1MjM=","url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false},{"id":827204049,"node_id":"MDU6TGFiZWw4MjcyMDQwNDk=","url":"https://api.github.com/repos/eclipse/che/labels/team/che-qe","name":"team/che-qe","color":"fc8f00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/10332/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/10332/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/10332/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/4578451598e0330f14f1fe8391da94a20774c603","head":{"label":"eclipse:che-10204","ref":"che-10204","sha":"4578451598e0330f14f1fe8391da94a20774c603","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkzNTc0NQ==","name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2018-07-09T09:34:58Z","pushed_at":"2018-07-09T13:29:16Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":88094,"stargazers_count":4884,"watchers_count":4884,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":874,"mirror_url":null,"archived":false,"open_issues_count":808,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":874,"open_issues":808,"watchers":4884,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"f43c8d6245d06dd9b488e92c49eff4d5b4f97619","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkzNTc0NQ==","name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2018-07-09T09:34:58Z","pushed_at":"2018-07-09T13:29:16Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":88094,"stargazers_count":4884,"watchers_count":4884,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":874,"mirror_url":null,"archived":false,"open_issues_count":808,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":874,"open_issues":808,"watchers":4884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/10332"},"html":{"href":"https://github.com/eclipse/che/pull/10332"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/10332"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/10332/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/10332/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/10332/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/4578451598e0330f14f1fe8391da94a20774c603"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ohrimenko1988"}}