{"action":"created","comment":{"url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/comments/197856916","pull_request_review_id":131682921,"id":197856916,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg1NjkxNg==","diff_hunk":"@@ -7,34 +7,39 @@\n  */\n public interface HumanProfile extends Profile {\n \n+    String GENDER_MALE = \"MALE\";","path":"yoti-sdk-api/src/main/java/com/yoti/api/client/HumanProfile.java","position":4,"original_position":4,"commit_id":"3f17b9165908a4be5f0fd4409e0589cabea93b8c","original_commit_id":"3f17b9165908a4be5f0fd4409e0589cabea93b8c","user":{"login":"qzagarese","id":348149,"node_id":"MDQ6VXNlcjM0ODE0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/348149?v=4","gravatar_id":"","url":"https://api.github.com/users/qzagarese","html_url":"https://github.com/qzagarese","followers_url":"https://api.github.com/users/qzagarese/followers","following_url":"https://api.github.com/users/qzagarese/following{/other_user}","gists_url":"https://api.github.com/users/qzagarese/gists{/gist_id}","starred_url":"https://api.github.com/users/qzagarese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzagarese/subscriptions","organizations_url":"https://api.github.com/users/qzagarese/orgs","repos_url":"https://api.github.com/users/qzagarese/repos","events_url":"https://api.github.com/users/qzagarese/events{/privacy}","received_events_url":"https://api.github.com/users/qzagarese/received_events","type":"User","site_admin":false},"body":"sorry, hadn't seen it was an interface, my bad :-(","created_at":"2018-06-25T16:20:40Z","updated_at":"2018-06-25T16:20:40Z","html_url":"https://github.com/getyoti/yoti-java-sdk/pull/62#discussion_r197856916","pull_request_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/comments/197856916"},"html":{"href":"https://github.com/getyoti/yoti-java-sdk/pull/62#discussion_r197856916"},"pull_request":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62"}},"in_reply_to_id":197477150},"pull_request":{"url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62","id":195761808,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzYxODA4","html_url":"https://github.com/getyoti/yoti-java-sdk/pull/62","diff_url":"https://github.com/getyoti/yoti-java-sdk/pull/62.diff","patch_url":"https://github.com/getyoti/yoti-java-sdk/pull/62.patch","issue_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/62","number":62,"state":"open","locked":false,"title":"SDK-394: Stop using Enums for attribute values","user":{"login":"bucky-boy","id":32527026,"node_id":"MDQ6VXNlcjMyNTI3MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/32527026?v=4","gravatar_id":"","url":"https://api.github.com/users/bucky-boy","html_url":"https://github.com/bucky-boy","followers_url":"https://api.github.com/users/bucky-boy/followers","following_url":"https://api.github.com/users/bucky-boy/following{/other_user}","gists_url":"https://api.github.com/users/bucky-boy/gists{/gist_id}","starred_url":"https://api.github.com/users/bucky-boy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bucky-boy/subscriptions","organizations_url":"https://api.github.com/users/bucky-boy/orgs","repos_url":"https://api.github.com/users/bucky-boy/repos","events_url":"https://api.github.com/users/bucky-boy/events{/privacy}","received_events_url":"https://api.github.com/users/bucky-boy/received_events","type":"User","site_admin":false},"body":"I've written quite a bit in the ticket.  In short...\r\n\r\nWe will not use Enums for attribute values.  If we start to return a new value for a given attribute, say a new _Gender_ type or a new _DocumentType_ then parsing that new value will cause an error.  Users of the SDK will be forced to upgrade in order to access the new value, and that's what we're trying to avoid.","created_at":"2018-06-19T09:20:49Z","updated_at":"2018-06-25T16:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5499e768b14f5dfe8c30ca09294b6a02fccd11d2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"qzagarese","id":348149,"node_id":"MDQ6VXNlcjM0ODE0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/348149?v=4","gravatar_id":"","url":"https://api.github.com/users/qzagarese","html_url":"https://github.com/qzagarese","followers_url":"https://api.github.com/users/qzagarese/followers","following_url":"https://api.github.com/users/qzagarese/following{/other_user}","gists_url":"https://api.github.com/users/qzagarese/gists{/gist_id}","starred_url":"https://api.github.com/users/qzagarese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzagarese/subscriptions","organizations_url":"https://api.github.com/users/qzagarese/orgs","repos_url":"https://api.github.com/users/qzagarese/repos","events_url":"https://api.github.com/users/qzagarese/events{/privacy}","received_events_url":"https://api.github.com/users/qzagarese/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62/commits","review_comments_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62/comments","review_comment_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/62/comments","statuses_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/statuses/3f17b9165908a4be5f0fd4409e0589cabea93b8c","head":{"label":"getyoti:SDK-394","ref":"SDK-394","sha":"3f17b9165908a4be5f0fd4409e0589cabea93b8c","user":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"repo":{"id":66000206,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAwMDIwNg==","name":"yoti-java-sdk","full_name":"getyoti/yoti-java-sdk","owner":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getyoti/yoti-java-sdk","description":"The Java SDK for interacting with the Yoti Platform","fork":false,"url":"https://api.github.com/repos/getyoti/yoti-java-sdk","forks_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/forks","keys_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/teams","hooks_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/hooks","issue_events_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/events","assignees_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/tags","blobs_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/languages","stargazers_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/stargazers","contributors_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/contributors","subscribers_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/subscribers","subscription_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/subscription","commits_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/merges","archive_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/downloads","issues_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/labels{/name}","releases_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/deployments","created_at":"2016-08-18T13:39:20Z","updated_at":"2018-06-11T19:40:26Z","pushed_at":"2018-06-25T15:20:35Z","git_url":"git://github.com/getyoti/yoti-java-sdk.git","ssh_url":"git@github.com:getyoti/yoti-java-sdk.git","clone_url":"https://github.com/getyoti/yoti-java-sdk.git","svn_url":"https://github.com/getyoti/yoti-java-sdk","homepage":"https://www.yoti.com/developers/documentation/?java","size":654,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"getyoti:SNAPSHOT","ref":"SNAPSHOT","sha":"9566c6b4038412dff4ccdf5e3f476e46b55b50a4","user":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"repo":{"id":66000206,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAwMDIwNg==","name":"yoti-java-sdk","full_name":"getyoti/yoti-java-sdk","owner":{"login":"getyoti","id":19798626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Nzk4NjI2","avatar_url":"https://avatars0.githubusercontent.com/u/19798626?v=4","gravatar_id":"","url":"https://api.github.com/users/getyoti","html_url":"https://github.com/getyoti","followers_url":"https://api.github.com/users/getyoti/followers","following_url":"https://api.github.com/users/getyoti/following{/other_user}","gists_url":"https://api.github.com/users/getyoti/gists{/gist_id}","starred_url":"https://api.github.com/users/getyoti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getyoti/subscriptions","organizations_url":"https://api.github.com/users/getyoti/orgs","repos_url":"https://api.github.com/users/getyoti/repos","events_url":"https://api.github.com/users/getyoti/events{/privacy}","received_events_url":"https://api.github.com/users/getyoti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getyoti/yoti-java-sdk","description":"The Java SDK for interacting with the Yoti Platform","fork":false,"url":"https://api.github.com/repos/getyoti/yoti-java-sdk","forks_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/forks","keys_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/teams","hooks_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/hooks","issue_events_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/events","assignees_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/tags","blobs_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/languages","stargazers_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/stargazers","contributors_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/contributors","subscribers_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/subscribers","subscription_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/subscription","commits_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/merges","archive_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/downloads","issues_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/labels{/name}","releases_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/getyoti/yoti-java-sdk/deployments","created_at":"2016-08-18T13:39:20Z","updated_at":"2018-06-11T19:40:26Z","pushed_at":"2018-06-25T15:20:35Z","git_url":"git://github.com/getyoti/yoti-java-sdk.git","ssh_url":"git@github.com:getyoti/yoti-java-sdk.git","clone_url":"https://github.com/getyoti/yoti-java-sdk.git","svn_url":"https://github.com/getyoti/yoti-java-sdk","homepage":"https://www.yoti.com/developers/documentation/?java","size":654,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62"},"html":{"href":"https://github.com/getyoti/yoti-java-sdk/pull/62"},"issue":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/62"},"comments":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/getyoti/yoti-java-sdk/statuses/3f17b9165908a4be5f0fd4409e0589cabea93b8c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"qzagarese"}}