{"action":"created","comment":{"url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/comments/223858400","pull_request_review_id":163080336,"id":223858400,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg1ODQwMA==","diff_hunk":"@@ -36,10 +36,13 @@ def _configure(self):\n         # cores into that many virtual nodes.  cpn defaults to requested_cores,\n         # to preserve the previous behavior (1 node).\n         self.cores_per_node = self._cfg.get('cores_per_node', self.requested_cores)\n-        self.gpus_per_node  = self._cfg.get('gpus_per_node', 0) # FIXME GPU\n+        self.gpus_per_node  = self._cfg.get('gpus_per_node', 0)  # FIXME GPU\n+\n+        if not self.cores_per_node:","path":"src/radical/pilot/agent/rm/fork.py","position":7,"original_position":7,"commit_id":"dc2720af3d9ae353f55eede5fb59a4c78890ab83","original_commit_id":"dc2720af3d9ae353f55eede5fb59a4c78890ab83","user":{"login":"iparask","id":8268665,"node_id":"MDQ6VXNlcjgyNjg2NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8268665?v=4","gravatar_id":"","url":"https://api.github.com/users/iparask","html_url":"https://github.com/iparask","followers_url":"https://api.github.com/users/iparask/followers","following_url":"https://api.github.com/users/iparask/following{/other_user}","gists_url":"https://api.github.com/users/iparask/gists{/gist_id}","starred_url":"https://api.github.com/users/iparask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iparask/subscriptions","organizations_url":"https://api.github.com/users/iparask/orgs","repos_url":"https://api.github.com/users/iparask/repos","events_url":"https://api.github.com/users/iparask/events{/privacy}","received_events_url":"https://api.github.com/users/iparask/received_events","type":"User","site_admin":false},"body":"Isn't this a bit redundant, since the get above does set the cores per node to `self.requested_cores`? ","created_at":"2018-10-09T20:49:24Z","updated_at":"2018-10-09T20:58:01Z","html_url":"https://github.com/radical-cybertools/radical.pilot/pull/1714#discussion_r223858400","pull_request_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/comments/223858400"},"html":{"href":"https://github.com/radical-cybertools/radical.pilot/pull/1714#discussion_r223858400"},"pull_request":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714"}}},"pull_request":{"url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714","id":216994973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTk0OTcz","html_url":"https://github.com/radical-cybertools/radical.pilot/pull/1714","diff_url":"https://github.com/radical-cybertools/radical.pilot/pull/1714.diff","patch_url":"https://github.com/radical-cybertools/radical.pilot/pull/1714.patch","issue_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/1714","number":1714,"state":"open","locked":false,"title":"add shellfs spawner","user":{"login":"andre-merzky","id":1319674,"node_id":"MDQ6VXNlcjEzMTk2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1319674?v=4","gravatar_id":"","url":"https://api.github.com/users/andre-merzky","html_url":"https://github.com/andre-merzky","followers_url":"https://api.github.com/users/andre-merzky/followers","following_url":"https://api.github.com/users/andre-merzky/following{/other_user}","gists_url":"https://api.github.com/users/andre-merzky/gists{/gist_id}","starred_url":"https://api.github.com/users/andre-merzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre-merzky/subscriptions","organizations_url":"https://api.github.com/users/andre-merzky/orgs","repos_url":"https://api.github.com/users/andre-merzky/repos","events_url":"https://api.github.com/users/andre-merzky/events{/privacy}","received_events_url":"https://api.github.com/users/andre-merzky/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-20T14:32:52Z","updated_at":"2018-10-09T20:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"450af0b847d2ae84a8dda2d0191146b7dada69e6","assignee":{"login":"andre-merzky","id":1319674,"node_id":"MDQ6VXNlcjEzMTk2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1319674?v=4","gravatar_id":"","url":"https://api.github.com/users/andre-merzky","html_url":"https://github.com/andre-merzky","followers_url":"https://api.github.com/users/andre-merzky/followers","following_url":"https://api.github.com/users/andre-merzky/following{/other_user}","gists_url":"https://api.github.com/users/andre-merzky/gists{/gist_id}","starred_url":"https://api.github.com/users/andre-merzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre-merzky/subscriptions","organizations_url":"https://api.github.com/users/andre-merzky/orgs","repos_url":"https://api.github.com/users/andre-merzky/repos","events_url":"https://api.github.com/users/andre-merzky/events{/privacy}","received_events_url":"https://api.github.com/users/andre-merzky/received_events","type":"User","site_admin":false},"assignees":[{"login":"andre-merzky","id":1319674,"node_id":"MDQ6VXNlcjEzMTk2NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1319674?v=4","gravatar_id":"","url":"https://api.github.com/users/andre-merzky","html_url":"https://github.com/andre-merzky","followers_url":"https://api.github.com/users/andre-merzky/followers","following_url":"https://api.github.com/users/andre-merzky/following{/other_user}","gists_url":"https://api.github.com/users/andre-merzky/gists{/gist_id}","starred_url":"https://api.github.com/users/andre-merzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre-merzky/subscriptions","organizations_url":"https://api.github.com/users/andre-merzky/orgs","repos_url":"https://api.github.com/users/andre-merzky/repos","events_url":"https://api.github.com/users/andre-merzky/events{/privacy}","received_events_url":"https://api.github.com/users/andre-merzky/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":855845602,"node_id":"MDU6TGFiZWw4NTU4NDU2MDI=","url":"https://api.github.com/repos/radical-cybertools/radical.pilot/labels/comp:agent:executor","name":"comp:agent:executor","color":"d4c5f9","default":false},{"id":855843782,"node_id":"MDU6TGFiZWw4NTU4NDM3ODI=","url":"https://api.github.com/repos/radical-cybertools/radical.pilot/labels/priority:medium","name":"priority:medium","color":"b60205","default":false},{"id":851715096,"node_id":"MDU6TGFiZWw4NTE3MTUwOTY=","url":"https://api.github.com/repos/radical-cybertools/radical.pilot/labels/topic:execution","name":"topic:execution","color":"c2e0c6","default":false},{"id":855841484,"node_id":"MDU6TGFiZWw4NTU4NDE0ODQ=","url":"https://api.github.com/repos/radical-cybertools/radical.pilot/labels/type:enhancement","name":"type:enhancement","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714/commits","review_comments_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714/comments","review_comment_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/1714/comments","statuses_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/statuses/dc2720af3d9ae353f55eede5fb59a4c78890ab83","head":{"label":"radical-cybertools:feature/shellfs_spawner","ref":"feature/shellfs_spawner","sha":"dc2720af3d9ae353f55eede5fb59a4c78890ab83","user":{"login":"radical-cybertools","id":5244521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDQ1MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5244521?v=4","gravatar_id":"","url":"https://api.github.com/users/radical-cybertools","html_url":"https://github.com/radical-cybertools","followers_url":"https://api.github.com/users/radical-cybertools/followers","following_url":"https://api.github.com/users/radical-cybertools/following{/other_user}","gists_url":"https://api.github.com/users/radical-cybertools/gists{/gist_id}","starred_url":"https://api.github.com/users/radical-cybertools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical-cybertools/subscriptions","organizations_url":"https://api.github.com/users/radical-cybertools/orgs","repos_url":"https://api.github.com/users/radical-cybertools/repos","events_url":"https://api.github.com/users/radical-cybertools/events{/privacy}","received_events_url":"https://api.github.com/users/radical-cybertools/received_events","type":"Organization","site_admin":false},"repo":{"id":11224542,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyNDU0Mg==","name":"radical.pilot","full_name":"radical-cybertools/radical.pilot","private":false,"owner":{"login":"radical-cybertools","id":5244521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDQ1MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5244521?v=4","gravatar_id":"","url":"https://api.github.com/users/radical-cybertools","html_url":"https://github.com/radical-cybertools","followers_url":"https://api.github.com/users/radical-cybertools/followers","following_url":"https://api.github.com/users/radical-cybertools/following{/other_user}","gists_url":"https://api.github.com/users/radical-cybertools/gists{/gist_id}","starred_url":"https://api.github.com/users/radical-cybertools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical-cybertools/subscriptions","organizations_url":"https://api.github.com/users/radical-cybertools/orgs","repos_url":"https://api.github.com/users/radical-cybertools/repos","events_url":"https://api.github.com/users/radical-cybertools/events{/privacy}","received_events_url":"https://api.github.com/users/radical-cybertools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/radical-cybertools/radical.pilot","description":"RADICAL-Pilot","fork":false,"url":"https://api.github.com/repos/radical-cybertools/radical.pilot","forks_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/forks","keys_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/teams","hooks_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/hooks","issue_events_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/events{/number}","events_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/events","assignees_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/assignees{/user}","branches_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/branches{/branch}","tags_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/tags","blobs_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/statuses/{sha}","languages_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/languages","stargazers_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/stargazers","contributors_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/contributors","subscribers_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/subscribers","subscription_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/subscription","commits_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/contents/{+path}","compare_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/merges","archive_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/downloads","issues_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues{/number}","pulls_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls{/number}","milestones_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/milestones{/number}","notifications_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/labels{/name}","releases_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/releases{/id}","deployments_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/deployments","created_at":"2013-07-06T21:14:41Z","updated_at":"2018-10-09T18:48:48Z","pushed_at":"2018-10-09T20:46:15Z","git_url":"git://github.com/radical-cybertools/radical.pilot.git","ssh_url":"git@github.com:radical-cybertools/radical.pilot.git","clone_url":"https://github.com/radical-cybertools/radical.pilot.git","svn_url":"https://github.com/radical-cybertools/radical.pilot","homepage":"http://radical-cybertools.github.io/radical-pilot/index.html","size":120877,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":234,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":234,"watchers":25,"default_branch":"devel"}},"base":{"label":"radical-cybertools:devel","ref":"devel","sha":"8652e961ba2f38074015fa7dca2bf7cfbd554945","user":{"login":"radical-cybertools","id":5244521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDQ1MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5244521?v=4","gravatar_id":"","url":"https://api.github.com/users/radical-cybertools","html_url":"https://github.com/radical-cybertools","followers_url":"https://api.github.com/users/radical-cybertools/followers","following_url":"https://api.github.com/users/radical-cybertools/following{/other_user}","gists_url":"https://api.github.com/users/radical-cybertools/gists{/gist_id}","starred_url":"https://api.github.com/users/radical-cybertools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical-cybertools/subscriptions","organizations_url":"https://api.github.com/users/radical-cybertools/orgs","repos_url":"https://api.github.com/users/radical-cybertools/repos","events_url":"https://api.github.com/users/radical-cybertools/events{/privacy}","received_events_url":"https://api.github.com/users/radical-cybertools/received_events","type":"Organization","site_admin":false},"repo":{"id":11224542,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyNDU0Mg==","name":"radical.pilot","full_name":"radical-cybertools/radical.pilot","private":false,"owner":{"login":"radical-cybertools","id":5244521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNDQ1MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5244521?v=4","gravatar_id":"","url":"https://api.github.com/users/radical-cybertools","html_url":"https://github.com/radical-cybertools","followers_url":"https://api.github.com/users/radical-cybertools/followers","following_url":"https://api.github.com/users/radical-cybertools/following{/other_user}","gists_url":"https://api.github.com/users/radical-cybertools/gists{/gist_id}","starred_url":"https://api.github.com/users/radical-cybertools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical-cybertools/subscriptions","organizations_url":"https://api.github.com/users/radical-cybertools/orgs","repos_url":"https://api.github.com/users/radical-cybertools/repos","events_url":"https://api.github.com/users/radical-cybertools/events{/privacy}","received_events_url":"https://api.github.com/users/radical-cybertools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/radical-cybertools/radical.pilot","description":"RADICAL-Pilot","fork":false,"url":"https://api.github.com/repos/radical-cybertools/radical.pilot","forks_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/forks","keys_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/teams","hooks_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/hooks","issue_events_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/events{/number}","events_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/events","assignees_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/assignees{/user}","branches_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/branches{/branch}","tags_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/tags","blobs_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/statuses/{sha}","languages_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/languages","stargazers_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/stargazers","contributors_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/contributors","subscribers_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/subscribers","subscription_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/subscription","commits_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/contents/{+path}","compare_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/merges","archive_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/downloads","issues_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues{/number}","pulls_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls{/number}","milestones_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/milestones{/number}","notifications_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/labels{/name}","releases_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/releases{/id}","deployments_url":"https://api.github.com/repos/radical-cybertools/radical.pilot/deployments","created_at":"2013-07-06T21:14:41Z","updated_at":"2018-10-09T18:48:48Z","pushed_at":"2018-10-09T20:46:15Z","git_url":"git://github.com/radical-cybertools/radical.pilot.git","ssh_url":"git@github.com:radical-cybertools/radical.pilot.git","clone_url":"https://github.com/radical-cybertools/radical.pilot.git","svn_url":"https://github.com/radical-cybertools/radical.pilot","homepage":"http://radical-cybertools.github.io/radical-pilot/index.html","size":120877,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":234,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":234,"watchers":25,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714"},"html":{"href":"https://github.com/radical-cybertools/radical.pilot/pull/1714"},"issue":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/1714"},"comments":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/issues/1714/comments"},"review_comments":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714/comments"},"review_comment":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/pulls/1714/commits"},"statuses":{"href":"https://api.github.com/repos/radical-cybertools/radical.pilot/statuses/dc2720af3d9ae353f55eede5fb59a4c78890ab83"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"iparask"}}