{"action":"opened","number":2025,"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/2025","id":198192495,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTkyNDk1","html_url":"https://github.com/linkerd/linkerd/pull/2025","diff_url":"https://github.com/linkerd/linkerd/pull/2025.diff","patch_url":"https://github.com/linkerd/linkerd/pull/2025.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd/issues/2025","number":2025,"state":"open","locked":false,"title":"Make trace propagation pluggable","user":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"body":"Linkerd uses the `l5d-ctx-trace` header to propagate trace context while ignoring trace headers from other tracing systems such as the zipkin `x-b3`.  While this allows Linkerd's tracing to co-exist with other tracing systems without interfering with them, it does not allow Linkerd to continue the trace initiated by another system.\r\n\r\nWe make Linkerd's trace propagation a pluggable module.  A trace propagation module decides how to read the trace context from a request when Linkerd receives one, and how to write the trace context onto a request when Linkerd sends one.  This PR includes only one implementation of this module: io.l5d.default which implements the existing behavior using the l5d-ctx-trace header.\r\n\r\nSigned-off-by: Alex Leong <alex@buoyant.io>","created_at":"2018-06-29T01:20:06Z","updated_at":"2018-06-29T01:20:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"assignees":[{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd/pulls/2025/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd/pulls/2025/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd/issues/2025/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/95d3ad04b5eca47db901ad1c2c39940b698aefb3","head":{"label":"linkerd:alex/trace-propagation","ref":"alex/trace-propagation","sha":"95d3ad04b5eca47db901ad1c2c39940b698aefb3","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwNTU5Ng==","name":"linkerd","full_name":"linkerd/linkerd","owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkerd/linkerd","description":"Open source service mesh for cloud-native applications","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2018-06-28T20:06:46Z","pushed_at":"2018-06-29T01:14:44Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":17673,"stargazers_count":4297,"watchers_count":4297,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":428,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":428,"open_issues":167,"watchers":4297,"default_branch":"master"}},"base":{"label":"linkerd:master","ref":"master","sha":"62aa66e5d0c6abec77f6289d5d9249a102928397","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwNTU5Ng==","name":"linkerd","full_name":"linkerd/linkerd","owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkerd/linkerd","description":"Open source service mesh for cloud-native applications","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2018-06-28T20:06:46Z","pushed_at":"2018-06-29T01:14:44Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":17673,"stargazers_count":4297,"watchers_count":4297,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":428,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":428,"open_issues":167,"watchers":4297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2025"},"html":{"href":"https://github.com/linkerd/linkerd/pull/2025"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/2025"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/2025/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2025/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2025/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd/statuses/95d3ad04b5eca47db901ad1c2c39940b698aefb3"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":365,"deletions":142,"changed_files":15}}
{"actor":{"display_login":"adleong"}}