{"action":"opened","number":12117,"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/12117","id":217114137,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTE0MTM3","html_url":"https://github.com/RocketChat/Rocket.Chat/pull/12117","diff_url":"https://github.com/RocketChat/Rocket.Chat/pull/12117.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat/pull/12117.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/12117","number":12117,"state":"open","locked":false,"title":"[NEW] Hide inactive rooms","user":{"login":"mrsimpson","id":17176678,"node_id":"MDQ6VXNlcjE3MTc2Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/17176678?v=4","gravatar_id":"","url":"https://api.github.com/users/mrsimpson","html_url":"https://github.com/mrsimpson","followers_url":"https://api.github.com/users/mrsimpson/followers","following_url":"https://api.github.com/users/mrsimpson/following{/other_user}","gists_url":"https://api.github.com/users/mrsimpson/gists{/gist_id}","starred_url":"https://api.github.com/users/mrsimpson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrsimpson/subscriptions","organizations_url":"https://api.github.com/users/mrsimpson/orgs","repos_url":"https://api.github.com/users/mrsimpson/repos","events_url":"https://api.github.com/users/mrsimpson/events{/privacy}","received_events_url":"https://api.github.com/users/mrsimpson/received_events","type":"User","site_admin":false},"body":"## What this adds\r\n\r\nAs time does by, users are being subscribed to many rooms. The left-hand side navigation gets messy. This PR adds an action for the user to hide inactive rooms.\r\n\r\n![2018-09-20 23 22 41](https://user-images.githubusercontent.com/17176678/45847963-19460f80-bd2d-11e8-9dfb-74aeb4e43118.gif)\r\n_Remark: the icon is `eye-off` - it's just not shown on my local dev-env_\r\n\r\n## How this is implemented\r\n\r\n- It adds an option to the sort-list. There is no better place for cross-room-actions, imho - the user preferences would be too far off.\r\n- With a modal, a user can define how old the minimum age is for rooms to be hidden.\r\n- Favorites and unread rooms are exempted\r\n- The implementation is similar to the normal hide-leave-actions with respect to package and model assignment.\r\n\r\n## What could be improved\r\n\r\n- Default value for the modal. This needs a modification of the modal (`modal.html, line 36ff ({{#if input}})`). I didn't do this since it's a reuse component and wanted to get your feedback first.\r\n- Create a regular ob and have the age defined by each user in its preferences (might be a second PR)","created_at":"2018-09-20T21:36:28Z","updated_at":"2018-09-20T21:36:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"mrsimpson","id":17176678,"node_id":"MDQ6VXNlcjE3MTc2Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/17176678?v=4","gravatar_id":"","url":"https://api.github.com/users/mrsimpson","html_url":"https://github.com/mrsimpson","followers_url":"https://api.github.com/users/mrsimpson/followers","following_url":"https://api.github.com/users/mrsimpson/following{/other_user}","gists_url":"https://api.github.com/users/mrsimpson/gists{/gist_id}","starred_url":"https://api.github.com/users/mrsimpson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrsimpson/subscriptions","organizations_url":"https://api.github.com/users/mrsimpson/orgs","repos_url":"https://api.github.com/users/mrsimpson/repos","events_url":"https://api.github.com/users/mrsimpson/events{/privacy}","received_events_url":"https://api.github.com/users/mrsimpson/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrsimpson","id":17176678,"node_id":"MDQ6VXNlcjE3MTc2Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/17176678?v=4","gravatar_id":"","url":"https://api.github.com/users/mrsimpson","html_url":"https://github.com/mrsimpson","followers_url":"https://api.github.com/users/mrsimpson/followers","following_url":"https://api.github.com/users/mrsimpson/following{/other_user}","gists_url":"https://api.github.com/users/mrsimpson/gists{/gist_id}","starred_url":"https://api.github.com/users/mrsimpson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrsimpson/subscriptions","organizations_url":"https://api.github.com/users/mrsimpson/orgs","repos_url":"https://api.github.com/users/mrsimpson/repos","events_url":"https://api.github.com/users/mrsimpson/events{/privacy}","received_events_url":"https://api.github.com/users/mrsimpson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/12117/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/12117/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/12117/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/1e624540134e8748af565e487a975603c23ad775","head":{"label":"assistify:core/feature/hide-inactive-rooms","ref":"core/feature/hide-inactive-rooms","sha":"1e624540134e8748af565e487a975603c23ad775","user":{"login":"assistify","id":31436100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDM2MTAw","avatar_url":"https://avatars0.githubusercontent.com/u/31436100?v=4","gravatar_id":"","url":"https://api.github.com/users/assistify","html_url":"https://github.com/assistify","followers_url":"https://api.github.com/users/assistify/followers","following_url":"https://api.github.com/users/assistify/following{/other_user}","gists_url":"https://api.github.com/users/assistify/gists{/gist_id}","starred_url":"https://api.github.com/users/assistify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assistify/subscriptions","organizations_url":"https://api.github.com/users/assistify/orgs","repos_url":"https://api.github.com/users/assistify/repos","events_url":"https://api.github.com/users/assistify/events{/privacy}","received_events_url":"https://api.github.com/users/assistify/received_events","type":"Organization","site_admin":false},"repo":{"id":101793438,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3OTM0Mzg=","name":"Rocket.Chat","full_name":"assistify/Rocket.Chat","private":false,"owner":{"login":"assistify","id":31436100,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDM2MTAw","avatar_url":"https://avatars0.githubusercontent.com/u/31436100?v=4","gravatar_id":"","url":"https://api.github.com/users/assistify","html_url":"https://github.com/assistify","followers_url":"https://api.github.com/users/assistify/followers","following_url":"https://api.github.com/users/assistify/following{/other_user}","gists_url":"https://api.github.com/users/assistify/gists{/gist_id}","starred_url":"https://api.github.com/users/assistify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assistify/subscriptions","organizations_url":"https://api.github.com/users/assistify/orgs","repos_url":"https://api.github.com/users/assistify/repos","events_url":"https://api.github.com/users/assistify/events{/privacy}","received_events_url":"https://api.github.com/users/assistify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/assistify/Rocket.Chat","description":"Supercharged by AI: Learn the most of your communication","fork":true,"url":"https://api.github.com/repos/assistify/Rocket.Chat","forks_url":"https://api.github.com/repos/assistify/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/assistify/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assistify/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assistify/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/assistify/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/assistify/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/assistify/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/assistify/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/assistify/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/assistify/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/assistify/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assistify/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assistify/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/assistify/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assistify/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/assistify/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/assistify/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/assistify/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/assistify/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/assistify/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/assistify/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/assistify/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/assistify/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/assistify/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/assistify/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/assistify/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assistify/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/assistify/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assistify/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/assistify/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/assistify/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/assistify/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/assistify/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assistify/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/assistify/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/assistify/Rocket.Chat/deployments","created_at":"2017-08-29T18:29:26Z","updated_at":"2018-09-19T12:06:17Z","pushed_at":"2018-09-20T21:26:41Z","git_url":"git://github.com/assistify/Rocket.Chat.git","ssh_url":"git@github.com:assistify/Rocket.Chat.git","clone_url":"https://github.com/assistify/Rocket.Chat.git","svn_url":"https://github.com/assistify/Rocket.Chat","homepage":"https://www.assistify.de","size":78941,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":129,"watchers":12,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"377402ee242a8fc32fda7ce3ff7ce81db80e25e1","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":35866694,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg2NjY5NA==","name":"Rocket.Chat","full_name":"RocketChat/Rocket.Chat","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/deployments","created_at":"2015-05-19T07:36:09Z","updated_at":"2018-09-20T20:43:52Z","pushed_at":"2018-09-20T20:34:33Z","git_url":"git://github.com/RocketChat/Rocket.Chat.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.git","svn_url":"https://github.com/RocketChat/Rocket.Chat","homepage":"https://rocket.chat/","size":79092,"stargazers_count":19942,"watchers_count":19942,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4229,"mirror_url":null,"archived":false,"open_issues_count":2147,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4229,"open_issues":2147,"watchers":19942,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/12117"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/12117"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/12117"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/12117/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/12117/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/12117/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/1e624540134e8748af565e487a975603c23ad775"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":198,"additions":34139,"deletions":15755,"changed_files":1623}}
{"actor":{"display_login":"mrsimpson"}}