{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/183057747","pull_request_review_id":113986310,"id":183057747,"diff_hunk":"@@ -6124,7 +6124,6 @@ OMR::Z::Machine::initialiseRegisterFile()\n \n    // Initialize GPRs\n    _registerFile[TR::RealRegister::NoReg] = NULL;\n-   _registerFile[TR::RealRegister::SpilledReg] = NULL;","path":"compiler/z/codegen/OMRMachine.cpp","position":22,"original_position":22,"commit_id":"a83d542464e050fd52ac61f0ddb20ac7821cdd3c","original_commit_id":"a83d542464e050fd52ac61f0ddb20ac7821cdd3c","user":{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars1.githubusercontent.com/u/16259104?v=4","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"body":"> Will this new enum replace the original RegNum enum? Or will it be effectively \"inheriting\" from the RegNum enum?\r\n\r\nIt would be ","created_at":"2018-04-20T13:53:35Z","updated_at":"2018-04-20T13:53:36Z","html_url":"https://github.com/eclipse/omr/pull/2462#discussion_r183057747","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/2462","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/183057747"},"html":{"href":"https://github.com/eclipse/omr/pull/2462#discussion_r183057747"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2462"}},"in_reply_to_id":182447301},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2462","id":181995066,"html_url":"https://github.com/eclipse/omr/pull/2462","diff_url":"https://github.com/eclipse/omr/pull/2462.diff","patch_url":"https://github.com/eclipse/omr/pull/2462.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2462","number":2462,"state":"open","locked":false,"title":"Add boundary checking for _registerFile","user":{"login":"dchopra001","id":11260919,"avatar_url":"https://avatars3.githubusercontent.com/u/11260919?v=4","gravatar_id":"","url":"https://api.github.com/users/dchopra001","html_url":"https://github.com/dchopra001","followers_url":"https://api.github.com/users/dchopra001/followers","following_url":"https://api.github.com/users/dchopra001/following{/other_user}","gists_url":"https://api.github.com/users/dchopra001/gists{/gist_id}","starred_url":"https://api.github.com/users/dchopra001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchopra001/subscriptions","organizations_url":"https://api.github.com/users/dchopra001/orgs","repos_url":"https://api.github.com/users/dchopra001/repos","events_url":"https://api.github.com/users/dchopra001/events{/privacy}","received_events_url":"https://api.github.com/users/dchopra001/received_events","type":"User","site_admin":false},"body":"`_registerFile` is a list of RealRegisters whose indices are grabbed from RealRegisterEnum.hpp for all RealRegisters. This enum defines PseudoRealRegisters as well as RealRegisters. PseudoRealRegisters are not defined to be in the bounds of `_registerFile`. Thus, boundary checking needs to be added wherever needed so that no one tries to access a PseudoRealRegister in `_registerFile`. Doing so would cause undefined behaviour. \r\n\r\nThis PR does the following:\r\n\r\n- Update the isRealReg and isPseudoReg queries to accurately reflect what is a real register and what is not.\r\n- Add boundary checks using the above queries wherever needed for `_registerFile`.\r\n- Remove the initialization of an element that is outside the bounds of `_registerFile` to avoid future bugs.","created_at":"2018-04-16T21:35:30Z","updated_at":"2018-04-20T13:53:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e312387f01dbc9421f06d8090c44ce3ad6a741b7","assignee":{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars1.githubusercontent.com/u/16259104?v=4","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"assignees":[{"login":"fjeremic","id":16259104,"avatar_url":"https://avatars1.githubusercontent.com/u/16259104?v=4","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463261830,"url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/2462/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/2462/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2462/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/a83d542464e050fd52ac61f0ddb20ac7821cdd3c","head":{"label":"dchopra001:addBoundsCheckForRegisterFileArray","ref":"addBoundsCheckForRegisterFileArray","sha":"a83d542464e050fd52ac61f0ddb20ac7821cdd3c","user":{"login":"dchopra001","id":11260919,"avatar_url":"https://avatars3.githubusercontent.com/u/11260919?v=4","gravatar_id":"","url":"https://api.github.com/users/dchopra001","html_url":"https://github.com/dchopra001","followers_url":"https://api.github.com/users/dchopra001/followers","following_url":"https://api.github.com/users/dchopra001/following{/other_user}","gists_url":"https://api.github.com/users/dchopra001/gists{/gist_id}","starred_url":"https://api.github.com/users/dchopra001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchopra001/subscriptions","organizations_url":"https://api.github.com/users/dchopra001/orgs","repos_url":"https://api.github.com/users/dchopra001/repos","events_url":"https://api.github.com/users/dchopra001/events{/privacy}","received_events_url":"https://api.github.com/users/dchopra001/received_events","type":"User","site_admin":false},"repo":{"id":91725551,"name":"omr","full_name":"dchopra001/omr","owner":{"login":"dchopra001","id":11260919,"avatar_url":"https://avatars3.githubusercontent.com/u/11260919?v=4","gravatar_id":"","url":"https://api.github.com/users/dchopra001","html_url":"https://github.com/dchopra001","followers_url":"https://api.github.com/users/dchopra001/followers","following_url":"https://api.github.com/users/dchopra001/following{/other_user}","gists_url":"https://api.github.com/users/dchopra001/gists{/gist_id}","starred_url":"https://api.github.com/users/dchopra001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchopra001/subscriptions","organizations_url":"https://api.github.com/users/dchopra001/orgs","repos_url":"https://api.github.com/users/dchopra001/repos","events_url":"https://api.github.com/users/dchopra001/events{/privacy}","received_events_url":"https://api.github.com/users/dchopra001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dchopra001/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/dchopra001/omr","forks_url":"https://api.github.com/repos/dchopra001/omr/forks","keys_url":"https://api.github.com/repos/dchopra001/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchopra001/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchopra001/omr/teams","hooks_url":"https://api.github.com/repos/dchopra001/omr/hooks","issue_events_url":"https://api.github.com/repos/dchopra001/omr/issues/events{/number}","events_url":"https://api.github.com/repos/dchopra001/omr/events","assignees_url":"https://api.github.com/repos/dchopra001/omr/assignees{/user}","branches_url":"https://api.github.com/repos/dchopra001/omr/branches{/branch}","tags_url":"https://api.github.com/repos/dchopra001/omr/tags","blobs_url":"https://api.github.com/repos/dchopra001/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchopra001/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchopra001/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchopra001/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchopra001/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/dchopra001/omr/languages","stargazers_url":"https://api.github.com/repos/dchopra001/omr/stargazers","contributors_url":"https://api.github.com/repos/dchopra001/omr/contributors","subscribers_url":"https://api.github.com/repos/dchopra001/omr/subscribers","subscription_url":"https://api.github.com/repos/dchopra001/omr/subscription","commits_url":"https://api.github.com/repos/dchopra001/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchopra001/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchopra001/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchopra001/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchopra001/omr/contents/{+path}","compare_url":"https://api.github.com/repos/dchopra001/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchopra001/omr/merges","archive_url":"https://api.github.com/repos/dchopra001/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchopra001/omr/downloads","issues_url":"https://api.github.com/repos/dchopra001/omr/issues{/number}","pulls_url":"https://api.github.com/repos/dchopra001/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/dchopra001/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/dchopra001/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchopra001/omr/labels{/name}","releases_url":"https://api.github.com/repos/dchopra001/omr/releases{/id}","deployments_url":"https://api.github.com/repos/dchopra001/omr/deployments","created_at":"2017-05-18T18:28:51Z","updated_at":"2018-04-12T18:46:09Z","pushed_at":"2018-04-16T21:16:51Z","git_url":"git://github.com/dchopra001/omr.git","ssh_url":"git@github.com:dchopra001/omr.git","clone_url":"https://github.com/dchopra001/omr.git","svn_url":"https://github.com/dchopra001/omr","homepage":"http://www.eclipse.org/omr","size":23563,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"546c38660cdf15f559d3360599060ac3e853776b","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-04-20T12:14:31Z","pushed_at":"2018-04-20T11:57:13Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":23759,"stargazers_count":478,"watchers_count":478,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":212,"open_issues":432,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2462"},"html":{"href":"https://github.com/eclipse/omr/pull/2462"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/2462"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/2462/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2462/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2462/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/a83d542464e050fd52ac61f0ddb20ac7821cdd3c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fjeremic"}}