{"action":"created","issue":{"url":"https://api.github.com/repos/druid-io/druid/issues/5344","repository_url":"https://api.github.com/repos/druid-io/druid","labels_url":"https://api.github.com/repos/druid-io/druid/issues/5344/labels{/name}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/5344/comments","events_url":"https://api.github.com/repos/druid-io/druid/issues/5344/events","html_url":"https://github.com/druid-io/druid/pull/5344","id":294309558,"number":5344,"title":"Fix races in LookupSnapshotTaker, CoordinatorPollingBasicAuthenticatorCacheManager","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars3.githubusercontent.com/u/1214075?v=4","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"labels":[{"id":17287685,"url":"https://api.github.com/repos/druid-io/druid/labels/Bug","name":"Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-05T08:32:08Z","updated_at":"2018-02-05T19:48:03Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/5344","html_url":"https://github.com/druid-io/druid/pull/5344","diff_url":"https://github.com/druid-io/druid/pull/5344.diff","patch_url":"https://github.com/druid-io/druid/pull/5344.patch"},"body":"Both were susceptible to the following conditions:\r\n\r\n1. Two JVMs on the same machine (perhaps two peons) could conflict by one reading while the\r\n   other was writing, or by writing to the file at the same time.\r\n2. One JVM could partially write a file, then crash, leaving a truncated file."},"comment":{"url":"https://api.github.com/repos/druid-io/druid/issues/comments/363200077","html_url":"https://github.com/druid-io/druid/pull/5344#issuecomment-363200077","issue_url":"https://api.github.com/repos/druid-io/druid/issues/5344","id":363200077,"user":{"login":"himanshug","id":246308,"avatar_url":"https://avatars1.githubusercontent.com/u/246308?v=4","gravatar_id":"","url":"https://api.github.com/users/himanshug","html_url":"https://github.com/himanshug","followers_url":"https://api.github.com/users/himanshug/followers","following_url":"https://api.github.com/users/himanshug/following{/other_user}","gists_url":"https://api.github.com/users/himanshug/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshug/subscriptions","organizations_url":"https://api.github.com/users/himanshug/orgs","repos_url":"https://api.github.com/users/himanshug/repos","events_url":"https://api.github.com/users/himanshug/events{/privacy}","received_events_url":"https://api.github.com/users/himanshug/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T19:48:03Z","updated_at":"2018-02-05T19:48:03Z","author_association":"OWNER","body":"@gianm thanks for clarifying the usefulness of snapshot of configuration, let us keep it then.\r\n\r\n> In fact, to help them out more we may also be looking to add more aggressive on disk caching features, so a server can restore all of its lookup data on boot (not just configuration) without access to any external services.\r\n\r\nWe do that with some of our lookups which are custom extensions and use disk backed caches. In fact, to support improved cleanup of persisted data, I had added https://github.com/druid-io/druid/pull/5287 .\r\n\r\nglad to know that lookups are getting more adoption :) "}}
{"actor":{"display_login":"himanshug"}}