{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/208147674","pull_request_review_id":143897800,"id":208147674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE0NzY3NA==","diff_hunk":"@@ -53,6 +54,8 @@ def __init__(\n         self.max_ingestion_time = max_ingestion_time\n         self.header = {'content-type': 'application/json'}\n \n+        assert self.timeout >= 1","path":"airflow/hooks/druid_hook.py","position":null,"original_position":14,"commit_id":"1a8abf183738cbe3e2f073dd7909c34fcddce85c","original_commit_id":"0d1fd50a0c706c810357c745dd9d5c9b502ae7a1","user":{"login":"awelsh93","id":32643586,"node_id":"MDQ6VXNlcjMyNjQzNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/32643586?v=4","gravatar_id":"","url":"https://api.github.com/users/awelsh93","html_url":"https://github.com/awelsh93","followers_url":"https://api.github.com/users/awelsh93/followers","following_url":"https://api.github.com/users/awelsh93/following{/other_user}","gists_url":"https://api.github.com/users/awelsh93/gists{/gist_id}","starred_url":"https://api.github.com/users/awelsh93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelsh93/subscriptions","organizations_url":"https://api.github.com/users/awelsh93/orgs","repos_url":"https://api.github.com/users/awelsh93/repos","events_url":"https://api.github.com/users/awelsh93/events{/privacy}","received_events_url":"https://api.github.com/users/awelsh93/received_events","type":"User","site_admin":false},"body":"Done - thanks","created_at":"2018-08-07T08:50:13Z","updated_at":"2018-08-07T08:50:13Z","html_url":"https://github.com/apache/incubator-airflow/pull/3710#discussion_r208147674","pull_request_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/208147674"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3710#discussion_r208147674"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710"}},"in_reply_to_id":207952035},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710","id":206434886,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDM0ODg2","html_url":"https://github.com/apache/incubator-airflow/pull/3710","diff_url":"https://github.com/apache/incubator-airflow/pull/3710.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3710.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3710","number":3710,"state":"open","locked":false,"title":"[AIRFLOW-2860] Update tests for druid hook","user":{"login":"awelsh93","id":32643586,"node_id":"MDQ6VXNlcjMyNjQzNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/32643586?v=4","gravatar_id":"","url":"https://api.github.com/users/awelsh93","html_url":"https://github.com/awelsh93","followers_url":"https://api.github.com/users/awelsh93/followers","following_url":"https://api.github.com/users/awelsh93/following{/other_user}","gists_url":"https://api.github.com/users/awelsh93/gists{/gist_id}","starred_url":"https://api.github.com/users/awelsh93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelsh93/subscriptions","organizations_url":"https://api.github.com/users/awelsh93/orgs","repos_url":"https://api.github.com/users/awelsh93/repos","events_url":"https://api.github.com/users/awelsh93/events{/privacy}","received_events_url":"https://api.github.com/users/awelsh93/received_events","type":"User","site_admin":false},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n  - https://issues.apache.org/jira/browse/AIRFLOW-XXX\r\n  - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a Jira issue.\r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\nThis pull request updates the tests for `airflow/hooks/druid_hook.py` and also adds an assert so that `timeout` must be greater than or equal to 1 second. This should fix the failing build in #3707.\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\nI ran `nosetests /tests/hooks/test_druid_hook.py`\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [ ] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n","created_at":"2018-08-06T15:26:00Z","updated_at":"2018-08-07T08:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb7146359f9ff3c7c37c10a6b4d889ff3c11f6bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3710/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/1a8abf183738cbe3e2f073dd7909c34fcddce85c","head":{"label":"awelsh93:AIRFLOW-2860-FIX","ref":"AIRFLOW-2860-FIX","sha":"1a8abf183738cbe3e2f073dd7909c34fcddce85c","user":{"login":"awelsh93","id":32643586,"node_id":"MDQ6VXNlcjMyNjQzNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/32643586?v=4","gravatar_id":"","url":"https://api.github.com/users/awelsh93","html_url":"https://github.com/awelsh93","followers_url":"https://api.github.com/users/awelsh93/followers","following_url":"https://api.github.com/users/awelsh93/following{/other_user}","gists_url":"https://api.github.com/users/awelsh93/gists{/gist_id}","starred_url":"https://api.github.com/users/awelsh93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelsh93/subscriptions","organizations_url":"https://api.github.com/users/awelsh93/orgs","repos_url":"https://api.github.com/users/awelsh93/repos","events_url":"https://api.github.com/users/awelsh93/events{/privacy}","received_events_url":"https://api.github.com/users/awelsh93/received_events","type":"User","site_admin":false},"repo":{"id":143706678,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MDY2Nzg=","name":"incubator-airflow","full_name":"awelsh93/incubator-airflow","owner":{"login":"awelsh93","id":32643586,"node_id":"MDQ6VXNlcjMyNjQzNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/32643586?v=4","gravatar_id":"","url":"https://api.github.com/users/awelsh93","html_url":"https://github.com/awelsh93","followers_url":"https://api.github.com/users/awelsh93/followers","following_url":"https://api.github.com/users/awelsh93/following{/other_user}","gists_url":"https://api.github.com/users/awelsh93/gists{/gist_id}","starred_url":"https://api.github.com/users/awelsh93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awelsh93/subscriptions","organizations_url":"https://api.github.com/users/awelsh93/orgs","repos_url":"https://api.github.com/users/awelsh93/repos","events_url":"https://api.github.com/users/awelsh93/events{/privacy}","received_events_url":"https://api.github.com/users/awelsh93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awelsh93/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/awelsh93/incubator-airflow","forks_url":"https://api.github.com/repos/awelsh93/incubator-airflow/forks","keys_url":"https://api.github.com/repos/awelsh93/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awelsh93/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awelsh93/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/awelsh93/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/awelsh93/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/awelsh93/incubator-airflow/events","assignees_url":"https://api.github.com/repos/awelsh93/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/awelsh93/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/awelsh93/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/awelsh93/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awelsh93/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awelsh93/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/awelsh93/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awelsh93/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/awelsh93/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/awelsh93/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/awelsh93/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/awelsh93/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/awelsh93/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/awelsh93/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/awelsh93/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/awelsh93/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/awelsh93/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/awelsh93/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/awelsh93/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awelsh93/incubator-airflow/merges","archive_url":"https://api.github.com/repos/awelsh93/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awelsh93/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/awelsh93/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/awelsh93/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/awelsh93/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/awelsh93/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awelsh93/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/awelsh93/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/awelsh93/incubator-airflow/deployments","created_at":"2018-08-06T09:31:46Z","updated_at":"2018-08-06T09:31:51Z","pushed_at":"2018-08-07T08:30:22Z","git_url":"git://github.com/awelsh93/incubator-airflow.git","ssh_url":"git@github.com:awelsh93/incubator-airflow.git","clone_url":"https://github.com/awelsh93/incubator-airflow.git","svn_url":"https://github.com/awelsh93/incubator-airflow","homepage":"https://airflow.apache.org","size":21603,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d12aacd552878308f9b1c3663414bb7c00c0632b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"incubator-airflow","full_name":"apache/incubator-airflow","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2018-08-07T08:30:31Z","pushed_at":"2018-08-07T08:30:25Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"git@github.com:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"https://airflow.apache.org","size":21617,"stargazers_count":8911,"watchers_count":8911,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2959,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2959,"open_issues":330,"watchers":8911,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/3710"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3710"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/3710/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/3710/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/1a8abf183738cbe3e2f073dd7909c34fcddce85c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"awelsh93"}}