{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/comments/184610661","pull_request_review_id":115842129,"id":184610661,"diff_hunk":"@@ -102,26 +102,32 @@ function run_tests_with_coverage() {\n }\n \n function tag_push() {\n-  TARGET=$1\n-  docker tag fabric8-notification-deploy $TARGET\n-  docker push $TARGET\n+  local tag=$1\n+\n+  docker tag fabric8-notification-deploy $tag\n+  docker push $tag\n }\n \n function deploy() {\n+  if [ -n \"${DEVSHIFT_USERNAME}\" -a -n \"${DEVSHIFT_PASSWORD}\" ]; then\n+    docker login -u ${DEVSHIFT_USERNAME} -p ${DEVSHIFT_PASSWORD} ${REGISTRY}\n+  else\n+    echo \"Could not login, missing credentials for the registry\"","path":"cico_setup.sh","position":26,"original_position":26,"commit_id":"1466051d3f2faeecc8749f7e76abd3d0ed8f8346","original_commit_id":"1466051d3f2faeecc8749f7e76abd3d0ed8f8346","user":{"login":"surajssd","id":5815795,"avatar_url":"https://avatars0.githubusercontent.com/u/5815795?v=4","gravatar_id":"","url":"https://api.github.com/users/surajssd","html_url":"https://github.com/surajssd","followers_url":"https://api.github.com/users/surajssd/followers","following_url":"https://api.github.com/users/surajssd/following{/other_user}","gists_url":"https://api.github.com/users/surajssd/gists{/gist_id}","starred_url":"https://api.github.com/users/surajssd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surajssd/subscriptions","organizations_url":"https://api.github.com/users/surajssd/orgs","repos_url":"https://api.github.com/users/surajssd/repos","events_url":"https://api.github.com/users/surajssd/events{/privacy}","received_events_url":"https://api.github.com/users/surajssd/received_events","type":"User","site_admin":false},"body":"In my mind I was thinking since it a error statement execution will stop there, but then now I can see it is just an echo and with no exit statement.","created_at":"2018-04-27T07:24:52Z","updated_at":"2018-04-27T07:24:52Z","html_url":"https://github.com/fabric8-services/fabric8-notification/pull/68#discussion_r184610661","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/comments/184610661"},"html":{"href":"https://github.com/fabric8-services/fabric8-notification/pull/68#discussion_r184610661"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68"}},"in_reply_to_id":184605098},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68","id":181025004,"html_url":"https://github.com/fabric8-services/fabric8-notification/pull/68","diff_url":"https://github.com/fabric8-services/fabric8-notification/pull/68.diff","patch_url":"https://github.com/fabric8-services/fabric8-notification/pull/68.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues/68","number":68,"state":"open","locked":false,"title":"Build on RHEL","user":{"login":"jmelis","id":126666,"avatar_url":"https://avatars3.githubusercontent.com/u/126666?v=4","gravatar_id":"","url":"https://api.github.com/users/jmelis","html_url":"https://github.com/jmelis","followers_url":"https://api.github.com/users/jmelis/followers","following_url":"https://api.github.com/users/jmelis/following{/other_user}","gists_url":"https://api.github.com/users/jmelis/gists{/gist_id}","starred_url":"https://api.github.com/users/jmelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmelis/subscriptions","organizations_url":"https://api.github.com/users/jmelis/orgs","repos_url":"https://api.github.com/users/jmelis/repos","events_url":"https://api.github.com/users/jmelis/events{/privacy}","received_events_url":"https://api.github.com/users/jmelis/received_events","type":"User","site_admin":false},"body":"Enable build on RHEL if TARGET=rhel.\r\n\r\nThe cico environment will continue to build the CentOS based container and in a second step it will build and push a RHEL based container. As of now, the CentOS containers will be the ones being deployed to prod-preview and prod.\r\n\r\nThis PR will remain as a WIP until this PR is merged and validated:\r\nhttps://github.com/fabric8-services/fabric8-auth/pull/432\r\n","created_at":"2018-04-11T20:53:31Z","updated_at":"2018-04-27T07:24:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beade13ddda742ce578aa34e17315223c9ae71db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues/68/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/statuses/1466051d3f2faeecc8749f7e76abd3d0ed8f8346","head":{"label":"jmelis:move-to-rhel","ref":"move-to-rhel","sha":"1466051d3f2faeecc8749f7e76abd3d0ed8f8346","user":{"login":"jmelis","id":126666,"avatar_url":"https://avatars3.githubusercontent.com/u/126666?v=4","gravatar_id":"","url":"https://api.github.com/users/jmelis","html_url":"https://github.com/jmelis","followers_url":"https://api.github.com/users/jmelis/followers","following_url":"https://api.github.com/users/jmelis/following{/other_user}","gists_url":"https://api.github.com/users/jmelis/gists{/gist_id}","starred_url":"https://api.github.com/users/jmelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmelis/subscriptions","organizations_url":"https://api.github.com/users/jmelis/orgs","repos_url":"https://api.github.com/users/jmelis/repos","events_url":"https://api.github.com/users/jmelis/events{/privacy}","received_events_url":"https://api.github.com/users/jmelis/received_events","type":"User","site_admin":false},"repo":{"id":127107801,"name":"fabric8-notification","full_name":"jmelis/fabric8-notification","owner":{"login":"jmelis","id":126666,"avatar_url":"https://avatars3.githubusercontent.com/u/126666?v=4","gravatar_id":"","url":"https://api.github.com/users/jmelis","html_url":"https://github.com/jmelis","followers_url":"https://api.github.com/users/jmelis/followers","following_url":"https://api.github.com/users/jmelis/following{/other_user}","gists_url":"https://api.github.com/users/jmelis/gists{/gist_id}","starred_url":"https://api.github.com/users/jmelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmelis/subscriptions","organizations_url":"https://api.github.com/users/jmelis/orgs","repos_url":"https://api.github.com/users/jmelis/repos","events_url":"https://api.github.com/users/jmelis/events{/privacy}","received_events_url":"https://api.github.com/users/jmelis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmelis/fabric8-notification","description":null,"fork":true,"url":"https://api.github.com/repos/jmelis/fabric8-notification","forks_url":"https://api.github.com/repos/jmelis/fabric8-notification/forks","keys_url":"https://api.github.com/repos/jmelis/fabric8-notification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmelis/fabric8-notification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmelis/fabric8-notification/teams","hooks_url":"https://api.github.com/repos/jmelis/fabric8-notification/hooks","issue_events_url":"https://api.github.com/repos/jmelis/fabric8-notification/issues/events{/number}","events_url":"https://api.github.com/repos/jmelis/fabric8-notification/events","assignees_url":"https://api.github.com/repos/jmelis/fabric8-notification/assignees{/user}","branches_url":"https://api.github.com/repos/jmelis/fabric8-notification/branches{/branch}","tags_url":"https://api.github.com/repos/jmelis/fabric8-notification/tags","blobs_url":"https://api.github.com/repos/jmelis/fabric8-notification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmelis/fabric8-notification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmelis/fabric8-notification/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmelis/fabric8-notification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmelis/fabric8-notification/statuses/{sha}","languages_url":"https://api.github.com/repos/jmelis/fabric8-notification/languages","stargazers_url":"https://api.github.com/repos/jmelis/fabric8-notification/stargazers","contributors_url":"https://api.github.com/repos/jmelis/fabric8-notification/contributors","subscribers_url":"https://api.github.com/repos/jmelis/fabric8-notification/subscribers","subscription_url":"https://api.github.com/repos/jmelis/fabric8-notification/subscription","commits_url":"https://api.github.com/repos/jmelis/fabric8-notification/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmelis/fabric8-notification/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmelis/fabric8-notification/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmelis/fabric8-notification/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmelis/fabric8-notification/contents/{+path}","compare_url":"https://api.github.com/repos/jmelis/fabric8-notification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmelis/fabric8-notification/merges","archive_url":"https://api.github.com/repos/jmelis/fabric8-notification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmelis/fabric8-notification/downloads","issues_url":"https://api.github.com/repos/jmelis/fabric8-notification/issues{/number}","pulls_url":"https://api.github.com/repos/jmelis/fabric8-notification/pulls{/number}","milestones_url":"https://api.github.com/repos/jmelis/fabric8-notification/milestones{/number}","notifications_url":"https://api.github.com/repos/jmelis/fabric8-notification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmelis/fabric8-notification/labels{/name}","releases_url":"https://api.github.com/repos/jmelis/fabric8-notification/releases{/id}","deployments_url":"https://api.github.com/repos/jmelis/fabric8-notification/deployments","created_at":"2018-03-28T08:19:32Z","updated_at":"2018-03-28T08:19:34Z","pushed_at":"2018-04-26T10:53:25Z","git_url":"git://github.com/jmelis/fabric8-notification.git","ssh_url":"git@github.com:jmelis/fabric8-notification.git","clone_url":"https://github.com/jmelis/fabric8-notification.git","svn_url":"https://github.com/jmelis/fabric8-notification","homepage":null,"size":170,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"2358e9e9cbf9be6728a5a08106533c35dd16b8f2","user":{"login":"fabric8-services","id":29751612,"avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":96795323,"name":"fabric8-notification","full_name":"fabric8-services/fabric8-notification","owner":{"login":"fabric8-services","id":29751612,"avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-notification","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-notification","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-notification/deployments","created_at":"2017-07-10T15:53:01Z","updated_at":"2018-04-07T22:38:36Z","pushed_at":"2018-04-26T10:53:26Z","git_url":"git://github.com/fabric8-services/fabric8-notification.git","ssh_url":"git@github.com:fabric8-services/fabric8-notification.git","clone_url":"https://github.com/fabric8-services/fabric8-notification.git","svn_url":"https://github.com/fabric8-services/fabric8-notification","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68"},"html":{"href":"https://github.com/fabric8-services/fabric8-notification/pull/68"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues/68"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-notification/statuses/1466051d3f2faeecc8749f7e76abd3d0ed8f8346"}},"author_association":"NONE"}}
{"actor":{"display_login":"surajssd"}}