{"action":"created","issue":{"url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2/issues/12","repository_url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2","labels_url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2/issues/12/comments","events_url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2/issues/12/events","html_url":"https://github.com/yireo/Yireo_CheckoutTester2/issues/12","id":377462385,"node_id":"MDU6SXNzdWUzNzc0NjIzODU=","number":12,"title":"Support HTTP_X_FORWARDED_FOR","user":{"login":"Serializator","id":7153670,"node_id":"MDQ6VXNlcjcxNTM2NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/7153670?v=4","gravatar_id":"","url":"https://api.github.com/users/Serializator","html_url":"https://github.com/Serializator","followers_url":"https://api.github.com/users/Serializator/followers","following_url":"https://api.github.com/users/Serializator/following{/other_user}","gists_url":"https://api.github.com/users/Serializator/gists{/gist_id}","starred_url":"https://api.github.com/users/Serializator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Serializator/subscriptions","organizations_url":"https://api.github.com/users/Serializator/orgs","repos_url":"https://api.github.com/users/Serializator/repos","events_url":"https://api.github.com/users/Serializator/events{/privacy}","received_events_url":"https://api.github.com/users/Serializator/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-05T15:54:26Z","updated_at":"2018-11-06T08:35:11Z","closed_at":"2018-11-06T08:35:12Z","author_association":"CONTRIBUTOR","body":"`\\Magento\\Framework\\HTTP\\PhpEnvironment\\Request::getClientIp($proxy)` directly returns the contents of `$_SERVER['HTTP_X_FORWARDED_FOR']` if the key exists in `$_SERVER`.\r\n\r\n`HTTP_X_FORWARDED_FOR` is a comma separated list of IP's where the first IP in the array (when exploded) is the actual IP of the client and the other IP's are proxies in front of the actual web server.\r\n\r\nWhat this causes is when the web server using Checkout Tester 2 is behind a proxy or some kind of load balancer, `\\Magento\\Framework\\HTTP\\PhpEnvironment\\Request::getClientIp($proxy)` will return a string of comma separated IP's and Checkout Tester 2 checks if that string is equal to one of the IP's configured to have access, instead of taking the client IP from that comma separated string and checking that against one of the configured IP's."},"comment":{"url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2/issues/comments/436171533","html_url":"https://github.com/yireo/Yireo_CheckoutTester2/issues/12#issuecomment-436171533","issue_url":"https://api.github.com/repos/yireo/Yireo_CheckoutTester2/issues/12","id":436171533,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjE3MTUzMw==","user":{"login":"jissereitsma","id":7670482,"node_id":"MDQ6VXNlcjc2NzA0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/7670482?v=4","gravatar_id":"","url":"https://api.github.com/users/jissereitsma","html_url":"https://github.com/jissereitsma","followers_url":"https://api.github.com/users/jissereitsma/followers","following_url":"https://api.github.com/users/jissereitsma/following{/other_user}","gists_url":"https://api.github.com/users/jissereitsma/gists{/gist_id}","starred_url":"https://api.github.com/users/jissereitsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jissereitsma/subscriptions","organizations_url":"https://api.github.com/users/jissereitsma/orgs","repos_url":"https://api.github.com/users/jissereitsma/repos","events_url":"https://api.github.com/users/jissereitsma/events{/privacy}","received_events_url":"https://api.github.com/users/jissereitsma/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T08:35:11Z","updated_at":"2018-11-06T08:35:11Z","author_association":"COLLABORATOR","body":"PR merged"}}
{"actor":{"display_login":"jissereitsma"}}