{"action":"closed","number":3969,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3969","id":90795570,"html_url":"https://github.com/theforeman/foreman/pull/3969","diff_url":"https://github.com/theforeman/foreman/pull/3969.diff","patch_url":"https://github.com/theforeman/foreman/pull/3969.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3969","number":3969,"state":"closed","locked":false,"title":"Fixes #17083 - log skipped orchestration steps","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars0.githubusercontent.com/u/49752?v=4","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"If there is an ActiveRecord error during unattended/built orchestration\n(queue_tftp), the method silently does not enqueue TFTP orchestration. We\nshould print the error in logs, otherwise it is impossible to investigate the\nroot cause.\n\nSymptoms are even more difficult to spot because due to bug RM/17082 no error\nis reported when unattended \"built\" REST API call fails, so the TFTP\norchestration is silently ignored and hosts stays in provisioning loop.\n\nThe patch aims only to add logging, note this is currently sent into SQL logger\ndue to limitation of our logging stack.\n","created_at":"2016-10-25T12:16:43Z","updated_at":"2018-02-15T09:21:13Z","closed_at":"2018-02-15T09:21:13Z","merged_at":"2018-02-15T09:21:13Z","merge_commit_sha":"c629492686e8450aa00317782245f79b66346617","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":79040689,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3969/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3969/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3969/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/222eb53d820a74f96e94ff87d866125feb7d4bfd","head":{"label":"lzap:silent-tftp-orch-17083","ref":"silent-tftp-orch-17083","sha":"222eb53d820a74f96e94ff87d866125feb7d4bfd","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars0.githubusercontent.com/u/49752?v=4","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":1410439,"name":"foreman","full_name":"lzap/foreman","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars0.githubusercontent.com/u/49752?v=4","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/lzap/foreman","forks_url":"https://api.github.com/repos/lzap/foreman/forks","keys_url":"https://api.github.com/repos/lzap/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/foreman/teams","hooks_url":"https://api.github.com/repos/lzap/foreman/hooks","issue_events_url":"https://api.github.com/repos/lzap/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/foreman/events","assignees_url":"https://api.github.com/repos/lzap/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/foreman/tags","blobs_url":"https://api.github.com/repos/lzap/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/foreman/languages","stargazers_url":"https://api.github.com/repos/lzap/foreman/stargazers","contributors_url":"https://api.github.com/repos/lzap/foreman/contributors","subscribers_url":"https://api.github.com/repos/lzap/foreman/subscribers","subscription_url":"https://api.github.com/repos/lzap/foreman/subscription","commits_url":"https://api.github.com/repos/lzap/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzap/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/foreman/merges","archive_url":"https://api.github.com/repos/lzap/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/foreman/downloads","issues_url":"https://api.github.com/repos/lzap/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/foreman/labels{/name}","releases_url":"https://api.github.com/repos/lzap/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/lzap/foreman/deployments","created_at":"2011-02-25T10:13:00Z","updated_at":"2014-06-19T15:16:06Z","pushed_at":"2018-02-14T14:09:38Z","git_url":"git://github.com/lzap/foreman.git","ssh_url":"git@github.com:lzap/foreman.git","clone_url":"https://github.com/lzap/foreman.git","svn_url":"https://github.com/lzap/foreman","homepage":"http://theforeman.org","size":45937,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"41a56a22be1da6bba018bfe4fbaeeaeca95ec754","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2018-02-12T19:53:16Z","pushed_at":"2018-02-15T09:21:13Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":68976,"stargazers_count":1372,"watchers_count":1372,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":685,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":685,"open_issues":108,"watchers":1372,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3969"},"html":{"href":"https://github.com/theforeman/foreman/pull/3969"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3969"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3969/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3969/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3969/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/222eb53d820a74f96e94ff87d866125feb7d4bfd"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars2.githubusercontent.com/u/598891?v=4","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"comments":24,"review_comments":12,"maintainer_can_modify":false,"commits":1,"additions":18,"deletions":6,"changed_files":7}}
{"actor":{"display_login":"dLobatog"}}