{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/proposal/pulls/comments/219562992","pull_request_review_id":157776183,"id":219562992,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTU2Mjk5Mg==","diff_hunk":"@@ -270,6 +270,8 @@ order to log certain required headers.\n     i.e. `-<service>/*` is not supported.\n *   Specifying a method while wildcarding the service is not supported, i.e.\n     `*/<method>` is not supported.\n+*   Conflicting rules are not supported, i.e. an exact method match and\n+    a negation for the same method \"/m{h:12;m:23},-s/m\".","path":"A16-binary-logging.md","position":null,"original_position":5,"commit_id":"fa7f09d0ed2d3232f95942ee3e48ebe1b3488ab9","original_commit_id":"5dacf5ff13778067b2ae5aa094ac5e2e4a49d789","user":{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"This sounds good to me.\r\n\r\nI assume two negations for the same method would be find. I also added this to the spec. Let me know if you think otherwise.","created_at":"2018-09-21T16:56:18Z","updated_at":"2018-09-21T16:56:19Z","html_url":"https://github.com/grpc/proposal/pull/104#discussion_r219562992","pull_request_url":"https://api.github.com/repos/grpc/proposal/pulls/104","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/proposal/pulls/comments/219562992"},"html":{"href":"https://github.com/grpc/proposal/pull/104#discussion_r219562992"},"pull_request":{"href":"https://api.github.com/repos/grpc/proposal/pulls/104"}},"in_reply_to_id":219359105},"pull_request":{"url":"https://api.github.com/repos/grpc/proposal/pulls/104","id":217144936,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTQ0OTM2","html_url":"https://github.com/grpc/proposal/pull/104","diff_url":"https://github.com/grpc/proposal/pull/104.diff","patch_url":"https://github.com/grpc/proposal/pull/104.patch","issue_url":"https://api.github.com/repos/grpc/proposal/issues/104","number":104,"state":"open","locked":false,"title":"binarylog fix: conflicting rules are not supported","user":{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-21T00:54:28Z","updated_at":"2018-09-21T16:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5687c3b04be206d6fe938880e5000f6f72b6d68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/proposal/pulls/104/commits","review_comments_url":"https://api.github.com/repos/grpc/proposal/pulls/104/comments","review_comment_url":"https://api.github.com/repos/grpc/proposal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/proposal/issues/104/comments","statuses_url":"https://api.github.com/repos/grpc/proposal/statuses/fa7f09d0ed2d3232f95942ee3e48ebe1b3488ab9","head":{"label":"menghanl:binarylog_config_conflict","ref":"binarylog_config_conflict","sha":"fa7f09d0ed2d3232f95942ee3e48ebe1b3488ab9","user":{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"repo":{"id":94360219,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM2MDIxOQ==","name":"proposal","full_name":"menghanl/proposal","private":false,"owner":{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/menghanl/proposal","description":"A repository for gRFCs ","fork":true,"url":"https://api.github.com/repos/menghanl/proposal","forks_url":"https://api.github.com/repos/menghanl/proposal/forks","keys_url":"https://api.github.com/repos/menghanl/proposal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menghanl/proposal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menghanl/proposal/teams","hooks_url":"https://api.github.com/repos/menghanl/proposal/hooks","issue_events_url":"https://api.github.com/repos/menghanl/proposal/issues/events{/number}","events_url":"https://api.github.com/repos/menghanl/proposal/events","assignees_url":"https://api.github.com/repos/menghanl/proposal/assignees{/user}","branches_url":"https://api.github.com/repos/menghanl/proposal/branches{/branch}","tags_url":"https://api.github.com/repos/menghanl/proposal/tags","blobs_url":"https://api.github.com/repos/menghanl/proposal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menghanl/proposal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menghanl/proposal/git/refs{/sha}","trees_url":"https://api.github.com/repos/menghanl/proposal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menghanl/proposal/statuses/{sha}","languages_url":"https://api.github.com/repos/menghanl/proposal/languages","stargazers_url":"https://api.github.com/repos/menghanl/proposal/stargazers","contributors_url":"https://api.github.com/repos/menghanl/proposal/contributors","subscribers_url":"https://api.github.com/repos/menghanl/proposal/subscribers","subscription_url":"https://api.github.com/repos/menghanl/proposal/subscription","commits_url":"https://api.github.com/repos/menghanl/proposal/commits{/sha}","git_commits_url":"https://api.github.com/repos/menghanl/proposal/git/commits{/sha}","comments_url":"https://api.github.com/repos/menghanl/proposal/comments{/number}","issue_comment_url":"https://api.github.com/repos/menghanl/proposal/issues/comments{/number}","contents_url":"https://api.github.com/repos/menghanl/proposal/contents/{+path}","compare_url":"https://api.github.com/repos/menghanl/proposal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menghanl/proposal/merges","archive_url":"https://api.github.com/repos/menghanl/proposal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menghanl/proposal/downloads","issues_url":"https://api.github.com/repos/menghanl/proposal/issues{/number}","pulls_url":"https://api.github.com/repos/menghanl/proposal/pulls{/number}","milestones_url":"https://api.github.com/repos/menghanl/proposal/milestones{/number}","notifications_url":"https://api.github.com/repos/menghanl/proposal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menghanl/proposal/labels{/name}","releases_url":"https://api.github.com/repos/menghanl/proposal/releases{/id}","deployments_url":"https://api.github.com/repos/menghanl/proposal/deployments","created_at":"2017-06-14T18:15:17Z","updated_at":"2018-09-21T00:49:45Z","pushed_at":"2018-09-21T16:55:09Z","git_url":"git://github.com/menghanl/proposal.git","ssh_url":"git@github.com:menghanl/proposal.git","clone_url":"https://github.com/menghanl/proposal.git","svn_url":"https://github.com/menghanl/proposal","homepage":null,"size":805,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"9381de797f743d0be5714f13bf78936bf37e0e44","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":78234185,"node_id":"MDEwOlJlcG9zaXRvcnk3ODIzNDE4NQ==","name":"proposal","full_name":"grpc/proposal","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/proposal","description":"A repository for gRFCs ","fork":false,"url":"https://api.github.com/repos/grpc/proposal","forks_url":"https://api.github.com/repos/grpc/proposal/forks","keys_url":"https://api.github.com/repos/grpc/proposal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/proposal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/proposal/teams","hooks_url":"https://api.github.com/repos/grpc/proposal/hooks","issue_events_url":"https://api.github.com/repos/grpc/proposal/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/proposal/events","assignees_url":"https://api.github.com/repos/grpc/proposal/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/proposal/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/proposal/tags","blobs_url":"https://api.github.com/repos/grpc/proposal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/proposal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/proposal/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/proposal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/proposal/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/proposal/languages","stargazers_url":"https://api.github.com/repos/grpc/proposal/stargazers","contributors_url":"https://api.github.com/repos/grpc/proposal/contributors","subscribers_url":"https://api.github.com/repos/grpc/proposal/subscribers","subscription_url":"https://api.github.com/repos/grpc/proposal/subscription","commits_url":"https://api.github.com/repos/grpc/proposal/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/proposal/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/proposal/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/proposal/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/proposal/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/proposal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/proposal/merges","archive_url":"https://api.github.com/repos/grpc/proposal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/proposal/downloads","issues_url":"https://api.github.com/repos/grpc/proposal/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/proposal/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/proposal/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/proposal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/proposal/labels{/name}","releases_url":"https://api.github.com/repos/grpc/proposal/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/proposal/deployments","created_at":"2017-01-06T19:51:09Z","updated_at":"2018-09-21T06:40:16Z","pushed_at":"2018-09-21T16:55:11Z","git_url":"git://github.com/grpc/proposal.git","ssh_url":"git@github.com:grpc/proposal.git","clone_url":"https://github.com/grpc/proposal.git","svn_url":"https://github.com/grpc/proposal","homepage":null,"size":847,"stargazers_count":95,"watchers_count":95,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":22,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/proposal/pulls/104"},"html":{"href":"https://github.com/grpc/proposal/pull/104"},"issue":{"href":"https://api.github.com/repos/grpc/proposal/issues/104"},"comments":{"href":"https://api.github.com/repos/grpc/proposal/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/proposal/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/proposal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/proposal/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/proposal/statuses/fa7f09d0ed2d3232f95942ee3e48ebe1b3488ab9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"menghanl"}}