{"action":"created","comment":{"url":"https://api.github.com/repos/dynup/kpatch/pulls/comments/219085738","pull_request_review_id":157171660,"id":219085738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTA4NTczOA==","diff_hunk":"@@ -197,16 +197,24 @@ static void symtab_read(struct lookup_table *table, char *path)\n \tFILE *file;\n \tlong unsigned int value, size;\n \tunsigned int i = 0;\n+\tint matched;\n \tchar line[256], name[256], type[16], bind[16], ndx[16];\n \n \tif ((file = fopen(path, \"r\")) == NULL)\n \t\tERROR(\"fopen\");\n \n \twhile (fgets(line, 256, file)) {\n-\t\tif (sscanf(line, \"%*s %lx %lu %s %s %*s %s %s\\n\",\n-\t\t\t   &value, &size, type, bind, ndx, name) != 6 ||\n+\t\tmatched = sscanf(line, \"%*s %lx %lu %s %s %*s %s %s\\n\",\n+\t\t\t\t &value, &size, type, bind, ndx, name);\n+\n+\t\tif (matched == 5) {\n+\t\t\tname[0] = '\\0';\n+\t\t\tmatched++;\n+\t\t}\n+\n+\t\tif (matched != 6 ||\n \t\t    !strcmp(ndx, \"UNDEF\") ||\n-\t\t    !strcmp(bind, \"SECTION\"))\n+\t\t    !strcmp(type, \"SECTION\"))","path":"kpatch-build/lookup.c","position":24,"original_position":24,"commit_id":"f296cee5052c15f17f6e53625058e6dee48b4b96","original_commit_id":"f296cee5052c15f17f6e53625058e6dee48b4b96","user":{"login":"sm00th","id":194702,"node_id":"MDQ6VXNlcjE5NDcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/194702?v=4","gravatar_id":"","url":"https://api.github.com/users/sm00th","html_url":"https://github.com/sm00th","followers_url":"https://api.github.com/users/sm00th/followers","following_url":"https://api.github.com/users/sm00th/following{/other_user}","gists_url":"https://api.github.com/users/sm00th/gists{/gist_id}","starred_url":"https://api.github.com/users/sm00th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm00th/subscriptions","organizations_url":"https://api.github.com/users/sm00th/orgs","repos_url":"https://api.github.com/users/sm00th/repos","events_url":"https://api.github.com/users/sm00th/events{/privacy}","received_events_url":"https://api.github.com/users/sm00th/received_events","type":"User","site_admin":false},"body":"I am not sure I follow, it seems obvious we are skipping those with \"SECTION\" in \"type\" field. Do you have some specific wording in mind?","created_at":"2018-09-20T09:02:08Z","updated_at":"2018-09-20T09:02:08Z","html_url":"https://github.com/dynup/kpatch/pull/909#discussion_r219085738","pull_request_url":"https://api.github.com/repos/dynup/kpatch/pulls/909","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/comments/219085738"},"html":{"href":"https://github.com/dynup/kpatch/pull/909#discussion_r219085738"},"pull_request":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/909"}},"in_reply_to_id":218848049},"pull_request":{"url":"https://api.github.com/repos/dynup/kpatch/pulls/909","id":215946939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTQ2OTM5","html_url":"https://github.com/dynup/kpatch/pull/909","diff_url":"https://github.com/dynup/kpatch/pull/909.diff","patch_url":"https://github.com/dynup/kpatch/pull/909.patch","issue_url":"https://api.github.com/repos/dynup/kpatch/issues/909","number":909,"state":"open","locked":false,"title":"Symtab read fixes","user":{"login":"sm00th","id":194702,"node_id":"MDQ6VXNlcjE5NDcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/194702?v=4","gravatar_id":"","url":"https://api.github.com/users/sm00th","html_url":"https://github.com/sm00th","followers_url":"https://api.github.com/users/sm00th/followers","following_url":"https://api.github.com/users/sm00th/following{/other_user}","gists_url":"https://api.github.com/users/sm00th/gists{/gist_id}","starred_url":"https://api.github.com/users/sm00th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm00th/subscriptions","organizations_url":"https://api.github.com/users/sm00th/orgs","repos_url":"https://api.github.com/users/sm00th/repos","events_url":"https://api.github.com/users/sm00th/events{/privacy}","received_events_url":"https://api.github.com/users/sm00th/received_events","type":"User","site_admin":false},"body":"A couple of small fixes for symtab_read function.","created_at":"2018-09-17T11:16:58Z","updated_at":"2018-09-20T09:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34b6ae035f88619fb1a83355b3abef6450cf5b68","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dynup/kpatch/pulls/909/commits","review_comments_url":"https://api.github.com/repos/dynup/kpatch/pulls/909/comments","review_comment_url":"https://api.github.com/repos/dynup/kpatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dynup/kpatch/issues/909/comments","statuses_url":"https://api.github.com/repos/dynup/kpatch/statuses/f296cee5052c15f17f6e53625058e6dee48b4b96","head":{"label":"sm00th:symtab_read-fixes","ref":"symtab_read-fixes","sha":"f296cee5052c15f17f6e53625058e6dee48b4b96","user":{"login":"sm00th","id":194702,"node_id":"MDQ6VXNlcjE5NDcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/194702?v=4","gravatar_id":"","url":"https://api.github.com/users/sm00th","html_url":"https://github.com/sm00th","followers_url":"https://api.github.com/users/sm00th/followers","following_url":"https://api.github.com/users/sm00th/following{/other_user}","gists_url":"https://api.github.com/users/sm00th/gists{/gist_id}","starred_url":"https://api.github.com/users/sm00th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm00th/subscriptions","organizations_url":"https://api.github.com/users/sm00th/orgs","repos_url":"https://api.github.com/users/sm00th/repos","events_url":"https://api.github.com/users/sm00th/events{/privacy}","received_events_url":"https://api.github.com/users/sm00th/received_events","type":"User","site_admin":false},"repo":{"id":125023621,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwMjM2MjE=","name":"kpatch","full_name":"sm00th/kpatch","private":false,"owner":{"login":"sm00th","id":194702,"node_id":"MDQ6VXNlcjE5NDcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/194702?v=4","gravatar_id":"","url":"https://api.github.com/users/sm00th","html_url":"https://github.com/sm00th","followers_url":"https://api.github.com/users/sm00th/followers","following_url":"https://api.github.com/users/sm00th/following{/other_user}","gists_url":"https://api.github.com/users/sm00th/gists{/gist_id}","starred_url":"https://api.github.com/users/sm00th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sm00th/subscriptions","organizations_url":"https://api.github.com/users/sm00th/orgs","repos_url":"https://api.github.com/users/sm00th/repos","events_url":"https://api.github.com/users/sm00th/events{/privacy}","received_events_url":"https://api.github.com/users/sm00th/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sm00th/kpatch","description":"kpatch - live kernel patching","fork":true,"url":"https://api.github.com/repos/sm00th/kpatch","forks_url":"https://api.github.com/repos/sm00th/kpatch/forks","keys_url":"https://api.github.com/repos/sm00th/kpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sm00th/kpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sm00th/kpatch/teams","hooks_url":"https://api.github.com/repos/sm00th/kpatch/hooks","issue_events_url":"https://api.github.com/repos/sm00th/kpatch/issues/events{/number}","events_url":"https://api.github.com/repos/sm00th/kpatch/events","assignees_url":"https://api.github.com/repos/sm00th/kpatch/assignees{/user}","branches_url":"https://api.github.com/repos/sm00th/kpatch/branches{/branch}","tags_url":"https://api.github.com/repos/sm00th/kpatch/tags","blobs_url":"https://api.github.com/repos/sm00th/kpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sm00th/kpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sm00th/kpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/sm00th/kpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sm00th/kpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/sm00th/kpatch/languages","stargazers_url":"https://api.github.com/repos/sm00th/kpatch/stargazers","contributors_url":"https://api.github.com/repos/sm00th/kpatch/contributors","subscribers_url":"https://api.github.com/repos/sm00th/kpatch/subscribers","subscription_url":"https://api.github.com/repos/sm00th/kpatch/subscription","commits_url":"https://api.github.com/repos/sm00th/kpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/sm00th/kpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/sm00th/kpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/sm00th/kpatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/sm00th/kpatch/contents/{+path}","compare_url":"https://api.github.com/repos/sm00th/kpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sm00th/kpatch/merges","archive_url":"https://api.github.com/repos/sm00th/kpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sm00th/kpatch/downloads","issues_url":"https://api.github.com/repos/sm00th/kpatch/issues{/number}","pulls_url":"https://api.github.com/repos/sm00th/kpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/sm00th/kpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/sm00th/kpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sm00th/kpatch/labels{/name}","releases_url":"https://api.github.com/repos/sm00th/kpatch/releases{/id}","deployments_url":"https://api.github.com/repos/sm00th/kpatch/deployments","created_at":"2018-03-13T09:14:09Z","updated_at":"2018-04-26T12:55:56Z","pushed_at":"2018-09-17T11:15:31Z","git_url":"git://github.com/sm00th/kpatch.git","ssh_url":"git@github.com:sm00th/kpatch.git","clone_url":"https://github.com/sm00th/kpatch.git","svn_url":"https://github.com/sm00th/kpatch","homepage":"","size":1744,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dynup:master","ref":"master","sha":"d95be2f1688ed5300377d4bfe3f5bea758a98006","user":{"login":"dynup","id":6643594,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NDM1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6643594?v=4","gravatar_id":"","url":"https://api.github.com/users/dynup","html_url":"https://github.com/dynup","followers_url":"https://api.github.com/users/dynup/followers","following_url":"https://api.github.com/users/dynup/following{/other_user}","gists_url":"https://api.github.com/users/dynup/gists{/gist_id}","starred_url":"https://api.github.com/users/dynup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynup/subscriptions","organizations_url":"https://api.github.com/users/dynup/orgs","repos_url":"https://api.github.com/users/dynup/repos","events_url":"https://api.github.com/users/dynup/events{/privacy}","received_events_url":"https://api.github.com/users/dynup/received_events","type":"Organization","site_admin":false},"repo":{"id":16743039,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc0MzAzOQ==","name":"kpatch","full_name":"dynup/kpatch","private":false,"owner":{"login":"dynup","id":6643594,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY2NDM1OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6643594?v=4","gravatar_id":"","url":"https://api.github.com/users/dynup","html_url":"https://github.com/dynup","followers_url":"https://api.github.com/users/dynup/followers","following_url":"https://api.github.com/users/dynup/following{/other_user}","gists_url":"https://api.github.com/users/dynup/gists{/gist_id}","starred_url":"https://api.github.com/users/dynup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dynup/subscriptions","organizations_url":"https://api.github.com/users/dynup/orgs","repos_url":"https://api.github.com/users/dynup/repos","events_url":"https://api.github.com/users/dynup/events{/privacy}","received_events_url":"https://api.github.com/users/dynup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dynup/kpatch","description":"kpatch - live kernel patching","fork":false,"url":"https://api.github.com/repos/dynup/kpatch","forks_url":"https://api.github.com/repos/dynup/kpatch/forks","keys_url":"https://api.github.com/repos/dynup/kpatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dynup/kpatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dynup/kpatch/teams","hooks_url":"https://api.github.com/repos/dynup/kpatch/hooks","issue_events_url":"https://api.github.com/repos/dynup/kpatch/issues/events{/number}","events_url":"https://api.github.com/repos/dynup/kpatch/events","assignees_url":"https://api.github.com/repos/dynup/kpatch/assignees{/user}","branches_url":"https://api.github.com/repos/dynup/kpatch/branches{/branch}","tags_url":"https://api.github.com/repos/dynup/kpatch/tags","blobs_url":"https://api.github.com/repos/dynup/kpatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dynup/kpatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dynup/kpatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dynup/kpatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dynup/kpatch/statuses/{sha}","languages_url":"https://api.github.com/repos/dynup/kpatch/languages","stargazers_url":"https://api.github.com/repos/dynup/kpatch/stargazers","contributors_url":"https://api.github.com/repos/dynup/kpatch/contributors","subscribers_url":"https://api.github.com/repos/dynup/kpatch/subscribers","subscription_url":"https://api.github.com/repos/dynup/kpatch/subscription","commits_url":"https://api.github.com/repos/dynup/kpatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dynup/kpatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dynup/kpatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dynup/kpatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dynup/kpatch/contents/{+path}","compare_url":"https://api.github.com/repos/dynup/kpatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dynup/kpatch/merges","archive_url":"https://api.github.com/repos/dynup/kpatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dynup/kpatch/downloads","issues_url":"https://api.github.com/repos/dynup/kpatch/issues{/number}","pulls_url":"https://api.github.com/repos/dynup/kpatch/pulls{/number}","milestones_url":"https://api.github.com/repos/dynup/kpatch/milestones{/number}","notifications_url":"https://api.github.com/repos/dynup/kpatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dynup/kpatch/labels{/name}","releases_url":"https://api.github.com/repos/dynup/kpatch/releases{/id}","deployments_url":"https://api.github.com/repos/dynup/kpatch/deployments","created_at":"2014-02-11T19:47:52Z","updated_at":"2018-09-19T08:39:46Z","pushed_at":"2018-09-17T15:02:35Z","git_url":"git://github.com/dynup/kpatch.git","ssh_url":"git@github.com:dynup/kpatch.git","clone_url":"https://github.com/dynup/kpatch.git","svn_url":"https://github.com/dynup/kpatch","homepage":"","size":1732,"stargazers_count":648,"watchers_count":648,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":144,"open_issues":44,"watchers":648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/909"},"html":{"href":"https://github.com/dynup/kpatch/pull/909"},"issue":{"href":"https://api.github.com/repos/dynup/kpatch/issues/909"},"comments":{"href":"https://api.github.com/repos/dynup/kpatch/issues/909/comments"},"review_comments":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/909/comments"},"review_comment":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dynup/kpatch/pulls/909/commits"},"statuses":{"href":"https://api.github.com/repos/dynup/kpatch/statuses/f296cee5052c15f17f6e53625058e6dee48b4b96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sm00th"}}