{"action":"created","issue":{"url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/11","repository_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library","labels_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/11/comments","events_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/11/events","html_url":"https://github.com/kentcdodds/cypress-testing-library/pull/11","id":328848755,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjU5NDgy","number":11,"title":"feat(within): Support cy.within","user":{"login":"npeterkamps","id":25429764,"node_id":"MDQ6VXNlcjI1NDI5NzY0","avatar_url":"https://avatars1.githubusercontent.com/u/25429764?v=4","gravatar_id":"","url":"https://api.github.com/users/npeterkamps","html_url":"https://github.com/npeterkamps","followers_url":"https://api.github.com/users/npeterkamps/followers","following_url":"https://api.github.com/users/npeterkamps/following{/other_user}","gists_url":"https://api.github.com/users/npeterkamps/gists{/gist_id}","starred_url":"https://api.github.com/users/npeterkamps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npeterkamps/subscriptions","organizations_url":"https://api.github.com/users/npeterkamps/orgs","repos_url":"https://api.github.com/users/npeterkamps/repos","events_url":"https://api.github.com/users/npeterkamps/events{/privacy}","received_events_url":"https://api.github.com/users/npeterkamps/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-03T18:01:18Z","updated_at":"2018-06-05T18:52:27Z","closed_at":"2018-06-05T18:04:55Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/pulls/11","html_url":"https://github.com/kentcdodds/cypress-testing-library/pull/11","diff_url":"https://github.com/kentcdodds/cypress-testing-library/pull/11.diff","patch_url":"https://github.com/kentcdodds/cypress-testing-library/pull/11.patch"},"body":"**What / How**:\r\n\r\n* Support `cy.within` by using `cy.state('withinSubject')` when available.\r\n* Support passing in a container within the options object.\r\n* Since Cypress uses jQuery elements and `dom-testing-library` expects DOM nodes, created a helper to retrieve the DOM node. \r\n  * Used [isJquery provided by Cypress](https://github.com/cypress-io/cypress/blob/master/packages/driver/src/dom/jquery.coffee), since `instanceof` didn't work.\r\n* Installed wait-port and use it within `test:cypress:run` to avoid race-conditions.\r\n\r\n**Why**:\r\n\r\nSee #8 \r\n\r\n**Checklist**:\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n\r\n* [x] Documentation\r\n* [x] Tests\r\n* [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n* [x] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->\r\n"},"comment":{"url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/comments/394820644","html_url":"https://github.com/kentcdodds/cypress-testing-library/pull/11#issuecomment-394820644","issue_url":"https://api.github.com/repos/kentcdodds/cypress-testing-library/issues/11","id":394820644,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDgyMDY0NA==","user":{"login":"kentcdodds","id":1500684,"node_id":"MDQ6VXNlcjE1MDA2ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T18:52:27Z","updated_at":"2018-06-05T18:52:27Z","author_association":"OWNER","body":"I think it's in the maintaining.md in the `other` directory. It's squash and merge and you need to make sure that the commit message is right and you can do that in the GitHub UI"}}
{"actor":{"display_login":"kentcdodds"}}