{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/211499319","pull_request_review_id":147928606,"id":211499319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQ5OTMxOQ==","diff_hunk":"@@ -575,8 +574,8 @@ def __write_workdir_file(self, config_filename, content, context, is_template=Tr\n             value = fill_template(content, context=context)\n         else:\n             value = content\n-        with open(config_filename, \"wb\") as f:\n-            f.write(smart_str(value))\n+        with open(config_filename, \"w\") as f:","path":"lib/galaxy/tools/evaluation.py","position":14,"original_position":14,"commit_id":"cbd486bfacecc0e0bd626f025190e7fb88f7ad5a","original_commit_id":"cbd486bfacecc0e0bd626f025190e7fb88f7ad5a","user":{"login":"mvdbeek","id":6804901,"node_id":"MDQ6VXNlcjY4MDQ5MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6804901?v=4","gravatar_id":"","url":"https://api.github.com/users/mvdbeek","html_url":"https://github.com/mvdbeek","followers_url":"https://api.github.com/users/mvdbeek/followers","following_url":"https://api.github.com/users/mvdbeek/following{/other_user}","gists_url":"https://api.github.com/users/mvdbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mvdbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvdbeek/subscriptions","organizations_url":"https://api.github.com/users/mvdbeek/orgs","repos_url":"https://api.github.com/users/mvdbeek/repos","events_url":"https://api.github.com/users/mvdbeek/events{/privacy}","received_events_url":"https://api.github.com/users/mvdbeek/received_events","type":"User","site_admin":false},"body":"This was my initial attempt, but that broke the unicode test tool on docker. I might have changed the encoding in the image in the meantime though, I'll double check and point jenkins at your branch.","created_at":"2018-08-21T07:09:46Z","updated_at":"2018-08-21T07:43:13Z","html_url":"https://github.com/galaxyproject/galaxy/pull/6616#discussion_r211499319","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/211499319"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/6616#discussion_r211499319"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616","id":209680864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjgwODY0","html_url":"https://github.com/galaxyproject/galaxy/pull/6616","diff_url":"https://github.com/galaxyproject/galaxy/pull/6616.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/6616.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6616","number":6616,"state":"open","locked":false,"title":"Py3 testing cleanups","user":{"login":"nsoranzo","id":4924623,"node_id":"MDQ6VXNlcjQ5MjQ2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4924623?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoranzo","html_url":"https://github.com/nsoranzo","followers_url":"https://api.github.com/users/nsoranzo/followers","following_url":"https://api.github.com/users/nsoranzo/following{/other_user}","gists_url":"https://api.github.com/users/nsoranzo/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoranzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoranzo/subscriptions","organizations_url":"https://api.github.com/users/nsoranzo/orgs","repos_url":"https://api.github.com/users/nsoranzo/repos","events_url":"https://api.github.com/users/nsoranzo/events{/privacy}","received_events_url":"https://api.github.com/users/nsoranzo/received_events","type":"User","site_admin":false},"body":"Small follow-ups on the amazing work of @mvdbeek in #6561, #6565,  #6595 and #6605.\r\n\r\nSee individual commits for details.\r\n\r\nxref. #1715","created_at":"2018-08-21T00:52:36Z","updated_at":"2018-08-21T07:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34aa85e338ba4fb00eca3a43e18f590205b343e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":279776046,"node_id":"MDU6TGFiZWwyNzk3NzYwNDY=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/area/framework","name":"area/framework","color":"006b75","default":false},{"id":180024671,"node_id":"MDU6TGFiZWwxODAwMjQ2NzE=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false},{"id":276566862,"node_id":"MDU6TGFiZWwyNzY1NjY4NjI=","url":"https://api.github.com/repos/galaxyproject/galaxy/labels/status/review","name":"status/review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/11","html_url":"https://github.com/galaxyproject/galaxy/milestone/11","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/11/labels","id":3064200,"node_id":"MDk6TWlsZXN0b25lMzA2NDIwMA==","number":11,"title":"18.09","description":"","creator":{"login":"martenson","id":1814954,"node_id":"MDQ6VXNlcjE4MTQ5NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1814954?v=4","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":260,"state":"open","created_at":"2018-01-25T16:03:47Z","updated_at":"2018-08-21T00:52:36Z","due_on":"2018-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6616/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/cbd486bfacecc0e0bd626f025190e7fb88f7ad5a","head":{"label":"nsoranzo:followup_on_6561","ref":"followup_on_6561","sha":"cbd486bfacecc0e0bd626f025190e7fb88f7ad5a","user":{"login":"nsoranzo","id":4924623,"node_id":"MDQ6VXNlcjQ5MjQ2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4924623?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoranzo","html_url":"https://github.com/nsoranzo","followers_url":"https://api.github.com/users/nsoranzo/followers","following_url":"https://api.github.com/users/nsoranzo/following{/other_user}","gists_url":"https://api.github.com/users/nsoranzo/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoranzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoranzo/subscriptions","organizations_url":"https://api.github.com/users/nsoranzo/orgs","repos_url":"https://api.github.com/users/nsoranzo/repos","events_url":"https://api.github.com/users/nsoranzo/events{/privacy}","received_events_url":"https://api.github.com/users/nsoranzo/received_events","type":"User","site_admin":false},"repo":{"id":31215040,"node_id":"MDEwOlJlcG9zaXRvcnkzMTIxNTA0MA==","name":"galaxy","full_name":"nsoranzo/galaxy","owner":{"login":"nsoranzo","id":4924623,"node_id":"MDQ6VXNlcjQ5MjQ2MjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4924623?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoranzo","html_url":"https://github.com/nsoranzo","followers_url":"https://api.github.com/users/nsoranzo/followers","following_url":"https://api.github.com/users/nsoranzo/following{/other_user}","gists_url":"https://api.github.com/users/nsoranzo/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoranzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoranzo/subscriptions","organizations_url":"https://api.github.com/users/nsoranzo/orgs","repos_url":"https://api.github.com/users/nsoranzo/repos","events_url":"https://api.github.com/users/nsoranzo/events{/privacy}","received_events_url":"https://api.github.com/users/nsoranzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsoranzo/galaxy","description":" Data intensive biology for everyone.","fork":true,"url":"https://api.github.com/repos/nsoranzo/galaxy","forks_url":"https://api.github.com/repos/nsoranzo/galaxy/forks","keys_url":"https://api.github.com/repos/nsoranzo/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsoranzo/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsoranzo/galaxy/teams","hooks_url":"https://api.github.com/repos/nsoranzo/galaxy/hooks","issue_events_url":"https://api.github.com/repos/nsoranzo/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/nsoranzo/galaxy/events","assignees_url":"https://api.github.com/repos/nsoranzo/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/nsoranzo/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/nsoranzo/galaxy/tags","blobs_url":"https://api.github.com/repos/nsoranzo/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsoranzo/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsoranzo/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsoranzo/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsoranzo/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/nsoranzo/galaxy/languages","stargazers_url":"https://api.github.com/repos/nsoranzo/galaxy/stargazers","contributors_url":"https://api.github.com/repos/nsoranzo/galaxy/contributors","subscribers_url":"https://api.github.com/repos/nsoranzo/galaxy/subscribers","subscription_url":"https://api.github.com/repos/nsoranzo/galaxy/subscription","commits_url":"https://api.github.com/repos/nsoranzo/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsoranzo/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsoranzo/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsoranzo/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsoranzo/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/nsoranzo/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsoranzo/galaxy/merges","archive_url":"https://api.github.com/repos/nsoranzo/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsoranzo/galaxy/downloads","issues_url":"https://api.github.com/repos/nsoranzo/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/nsoranzo/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/nsoranzo/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/nsoranzo/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsoranzo/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/nsoranzo/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/nsoranzo/galaxy/deployments","created_at":"2015-02-23T15:49:44Z","updated_at":"2018-07-06T14:14:58Z","pushed_at":"2018-08-21T00:38:24Z","git_url":"git://github.com/nsoranzo/galaxy.git","ssh_url":"git@github.com:nsoranzo/galaxy.git","clone_url":"https://github.com/nsoranzo/galaxy.git","svn_url":"https://github.com/nsoranzo/galaxy","homepage":"http://galaxyproject.org/","size":453374,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"e07cc9a96009bafb47c27199cc231213ce2c3514","user":{"login":"galaxyproject","id":7937847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Mzc4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"node_id":"MDEwOlJlcG9zaXRvcnkzMTIxMTA2MQ==","name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Mzc4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2018-08-20T17:05:14Z","pushed_at":"2018-08-21T00:52:37Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":460861,"stargazers_count":486,"watchers_count":486,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":463,"mirror_url":null,"archived":false,"open_issues_count":1175,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":463,"open_issues":1175,"watchers":486,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/6616"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/6616"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/6616/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6616/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/cbd486bfacecc0e0bd626f025190e7fb88f7ad5a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mvdbeek"}}