{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/243576498","pull_request_review_id":187365002,"id":243576498,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU3NjQ5OA==","diff_hunk":"@@ -1173,17 +1171,21 @@\n \t\t},\n \n \t\tremoveSymbolText: function( element ) { // ...from a list element.\n-\t\t\tvar removed,\n-\t\t\t\tsymbol = element.attributes[ 'cke-symbol' ];\n+\t\t\tvar symbol = element.attributes[ 'cke-symbol' ],\n+\t\t\t\tremoved,\n+\t\t\t\tmatched;\n \n \t\t\telement.forEach( function( node ) {\n \t\t\t\t// Since symbol may contains special characters we use `indexOf` (instead of RegExp) which is sufficient (#877).\n-\t\t\t\tif ( !removed && node.value.indexOf( symbol ) > -1 ) {\n-\n+\t\t\t\t// Stop after after first replaced string (#2690).\n+\t\t\t\tif ( !matched && node.value.indexOf( symbol ) > -1 ) {\n+\t\t\t\t\tmatched = true;","path":"plugins/pastefromword/filter/default.js","position":25,"original_position":25,"commit_id":"c2dcd676c27f3e5594059c11173b9f2e13909e5f","original_commit_id":"ac4ac76a66ff9b55607fb6399143e2b81dd0345e","user":{"login":"Comandeer","id":1078728,"node_id":"MDQ6VXNlcjEwNzg3Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1078728?v=4","gravatar_id":"","url":"https://api.github.com/users/Comandeer","html_url":"https://github.com/Comandeer","followers_url":"https://api.github.com/users/Comandeer/followers","following_url":"https://api.github.com/users/Comandeer/following{/other_user}","gists_url":"https://api.github.com/users/Comandeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Comandeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comandeer/subscriptions","organizations_url":"https://api.github.com/users/Comandeer/orgs","repos_url":"https://api.github.com/users/Comandeer/repos","events_url":"https://api.github.com/users/Comandeer/events{/privacy}","received_events_url":"https://api.github.com/users/Comandeer/received_events","type":"User","site_admin":false},"body":"In fact `findOne` would be even better, so let's refactor it later → #2698.","created_at":"2018-12-21T13:09:02Z","updated_at":"2018-12-21T13:18:18Z","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/2695#discussion_r243576498","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/243576498"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/2695#discussion_r243576498"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695"}},"in_reply_to_id":243560525},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695","id":239882604,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODgyNjA0","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/2695","diff_url":"https://github.com/ckeditor/ckeditor-dev/pull/2695.diff","patch_url":"https://github.com/ckeditor/ckeditor-dev/pull/2695.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2695","number":2695,"state":"open","locked":false,"title":"Fix for: Decimal character is lost in list when pasting from Word","user":{"login":"engineering-this","id":23366849,"node_id":"MDQ6VXNlcjIzMzY2ODQ5","avatar_url":"https://avatars0.githubusercontent.com/u/23366849?v=4","gravatar_id":"","url":"https://api.github.com/users/engineering-this","html_url":"https://github.com/engineering-this","followers_url":"https://api.github.com/users/engineering-this/followers","following_url":"https://api.github.com/users/engineering-this/following{/other_user}","gists_url":"https://api.github.com/users/engineering-this/gists{/gist_id}","starred_url":"https://api.github.com/users/engineering-this/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineering-this/subscriptions","organizations_url":"https://api.github.com/users/engineering-this/orgs","repos_url":"https://api.github.com/users/engineering-this/repos","events_url":"https://api.github.com/users/engineering-this/events{/privacy}","received_events_url":"https://api.github.com/users/engineering-this/received_events","type":"User","site_admin":false},"body":"## What is the purpose of this pull request?\r\n\r\nBug fix\r\n\r\n## Does your PR contain necessary tests?\r\n\r\nAll patches which change the editor code must include tests. You can always read more\r\non [PR testing](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_contributing_code.html#tests),\r\n[how to set the testing environment](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_tests.html) and\r\n[how to create tests](https://ckeditor.com/docs/ckeditor4/latest/guide/dev_tests.html#creating-your-own-test)\r\nin the official CKEditor documentation.\r\n\r\n### This PR contains\r\n\r\n- [X] Unit tests\r\n- [X] Manual tests\r\n\r\n## What changes did you make?\r\n\r\nI've updated conditional which replaces text of list symbol (list number), so it will trigger only for first matched element.\r\n\r\nCloses #2690","created_at":"2018-12-19T15:47:04Z","updated_at":"2018-12-21T13:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6b7558056b33250a60faa69cbc2c0d2c8ec35c","assignee":{"login":"Comandeer","id":1078728,"node_id":"MDQ6VXNlcjEwNzg3Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1078728?v=4","gravatar_id":"","url":"https://api.github.com/users/Comandeer","html_url":"https://github.com/Comandeer","followers_url":"https://api.github.com/users/Comandeer/followers","following_url":"https://api.github.com/users/Comandeer/following{/other_user}","gists_url":"https://api.github.com/users/Comandeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Comandeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comandeer/subscriptions","organizations_url":"https://api.github.com/users/Comandeer/orgs","repos_url":"https://api.github.com/users/Comandeer/repos","events_url":"https://api.github.com/users/Comandeer/events{/privacy}","received_events_url":"https://api.github.com/users/Comandeer/received_events","type":"User","site_admin":false},"assignees":[{"login":"Comandeer","id":1078728,"node_id":"MDQ6VXNlcjEwNzg3Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1078728?v=4","gravatar_id":"","url":"https://api.github.com/users/Comandeer","html_url":"https://github.com/Comandeer","followers_url":"https://api.github.com/users/Comandeer/followers","following_url":"https://api.github.com/users/Comandeer/following{/other_user}","gists_url":"https://api.github.com/users/Comandeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Comandeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Comandeer/subscriptions","organizations_url":"https://api.github.com/users/Comandeer/orgs","repos_url":"https://api.github.com/users/Comandeer/repos","events_url":"https://api.github.com/users/Comandeer/events{/privacy}","received_events_url":"https://api.github.com/users/Comandeer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2695/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/c2dcd676c27f3e5594059c11173b9f2e13909e5f","head":{"label":"ckeditor:t/2690","ref":"t/2690","sha":"c2dcd676c27f3e5594059c11173b9f2e13909e5f","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgyMTcy","name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","private":false,"owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-12-21T08:58:23Z","pushed_at":"2018-12-21T13:16:52Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":65983,"stargazers_count":4329,"watchers_count":4329,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1945,"mirror_url":null,"archived":false,"open_issues_count":736,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1945,"open_issues":736,"watchers":4329,"default_branch":"major"}},"base":{"label":"ckeditor:master","ref":"master","sha":"599271abb67bd09f38e95752bedd9aaf0126500b","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgyMTcy","name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","private":false,"owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-12-21T08:58:23Z","pushed_at":"2018-12-21T13:16:52Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":65983,"stargazers_count":4329,"watchers_count":4329,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1945,"mirror_url":null,"archived":false,"open_issues_count":736,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1945,"open_issues":736,"watchers":4329,"default_branch":"major"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/2695"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2695"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/2695/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/2695/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/c2dcd676c27f3e5594059c11173b9f2e13909e5f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Comandeer"}}