{"comment":{"url":"https://api.github.com/repos/wmarkow/Arduino/comments/28330569","html_url":"https://github.com/wmarkow/Arduino/commit/afc25a64316e38f29cf887f546b8a09c73375838#commitcomment-28330569","id":28330569,"user":{"login":"wmarkow","id":14165380,"avatar_url":"https://avatars1.githubusercontent.com/u/14165380?v=4","gravatar_id":"","url":"https://api.github.com/users/wmarkow","html_url":"https://github.com/wmarkow","followers_url":"https://api.github.com/users/wmarkow/followers","following_url":"https://api.github.com/users/wmarkow/following{/other_user}","gists_url":"https://api.github.com/users/wmarkow/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarkow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarkow/subscriptions","organizations_url":"https://api.github.com/users/wmarkow/orgs","repos_url":"https://api.github.com/users/wmarkow/repos","events_url":"https://api.github.com/users/wmarkow/events{/privacy}","received_events_url":"https://api.github.com/users/wmarkow/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"afc25a64316e38f29cf887f546b8a09c73375838","created_at":"2018-03-29T13:11:17Z","updated_at":"2018-03-29T13:11:17Z","author_association":"OWNER","body":"Hello @CaptainMack, mostly I have added timeouts for **while** loops; only two loops are not fixed yet:\r\n\r\n```\r\ndo {\r\n      TWDR = twi_slarw;\r\n} while(TWCR & _BV(TWWC));\r\n```\r\n\r\nTo be honest in my work I have used those two pull requests:\r\n * arduino/Arduino#1842\r\n * arduino/Arduino#2489\r\nso big thanks should go to @DanNixon and @MauroMombelli as well.\r\nIn my solution I have combined ideas from those two pull requests mentioned above.\r\n\r\nYou can just retest if this will work in your project. You can make a review or improve something. Please let me know what you think.\r\n\r\nOne more thing, in [this comment](https://github.com/jrowberg/i2cdevlib/issues/252#issuecomment-300991367), @Astro-Johnny proposes some additional feature to be get notified about I2C \"latch condition\" so you can do some other stuff when I2C is frozen - by other stuff I mean to do something else outside of **Wire** library, like restarting some hardware. That would be a nice feature because I have noticed (or I have just a feeling) that in my project it would be good to reinit my I2C devices when I2C is latched. Of course **Wire** library is not able to do that but from the final application level I'm able to do this.\r\n"}}
{"actor":{"display_login":"wmarkow"}}