{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6166","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6166/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6166/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6166/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/6166","id":299396603,"number":6166,"title":"Make APN lookup the default behaviour for PPPCellularInterface","user":{"login":"RobMeades","id":6726745,"avatar_url":"https://avatars0.githubusercontent.com/u/6726745?v=4","gravatar_id":"","url":"https://api.github.com/users/RobMeades","html_url":"https://github.com/RobMeades","followers_url":"https://api.github.com/users/RobMeades/followers","following_url":"https://api.github.com/users/RobMeades/following{/other_user}","gists_url":"https://api.github.com/users/RobMeades/gists{/gist_id}","starred_url":"https://api.github.com/users/RobMeades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobMeades/subscriptions","organizations_url":"https://api.github.com/users/RobMeades/orgs","repos_url":"https://api.github.com/users/RobMeades/repos","events_url":"https://api.github.com/users/RobMeades/events{/privacy}","received_events_url":"https://api.github.com/users/RobMeades/received_events","type":"User","site_admin":false},"labels":[{"id":144902129,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-02-22T15:28:36Z","updated_at":"2018-02-27T05:57:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6166","html_url":"https://github.com/ARMmbed/mbed-os/pull/6166","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6166.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6166.patch"},"body":"# Description\r\nIf the user does not provide an APN when using `PPPCellularInterface`, the driver currently uses the APN \"internet\" as a default.  It includes the capability to look up the APN based on the IMSI of the SIM however this behaviour is only available under the compilation switch `MBED_CONF_PPP_CELL_IFACE_APN_LOOKUP`.\r\n\r\nWith this change APN look-up is the default behaviour.  If the user specifies an APN then that still takes precedence and if the look-up fails then, finally, \"internet\" is used, so this should have no adverse effect on existing users.\r\n\r\nAll of the cellular interface tests in `mbed-os-features-netsocket-cellular-generic_modem_driver-tests-unit_tests-default` pass after making this change.\r\n\r\n# Pull request type\r\n- [x] Enhancement to Feature\r\n\r\n# Dependencies\r\nThis change depends upon the fix in #6160.\r\n"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/368756749","html_url":"https://github.com/ARMmbed/mbed-os/pull/6166#issuecomment-368756749","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6166","id":368756749,"user":{"login":"cmonr","id":260086,"avatar_url":"https://avatars1.githubusercontent.com/u/260086?v=4","gravatar_id":"","url":"https://api.github.com/users/cmonr","html_url":"https://github.com/cmonr","followers_url":"https://api.github.com/users/cmonr/followers","following_url":"https://api.github.com/users/cmonr/following{/other_user}","gists_url":"https://api.github.com/users/cmonr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmonr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmonr/subscriptions","organizations_url":"https://api.github.com/users/cmonr/orgs","repos_url":"https://api.github.com/users/cmonr/repos","events_url":"https://api.github.com/users/cmonr/events{/privacy}","received_events_url":"https://api.github.com/users/cmonr/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T05:57:45Z","updated_at":"2018-02-27T05:57:45Z","author_association":"CONTRIBUTOR","body":"/morph build"}}
{"actor":{"display_login":"cmonr"}}