{"action":"created","comment":{"url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/comments/230608876","pull_request_review_id":171383255,"id":230608876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYwODg3Ng==","diff_hunk":"@@ -331,6 +355,33 @@ public function define_client_section($mform, $config) {\n \n         $mform->addElement('select', 's3_region', get_string('settings:aws:region', 'tool_objectfs'), $regionoptions);\n         $mform->addHelpButton('s3_region', 'settings:aws:region', 'tool_objectfs');\n+\n+        $mform = $this->define_proxy_config($mform, $config);\n+\n+        return $mform;\n+    }\n+\n+    private function define_proxy_config($mform, $config) {","path":"classes/client/s3_client.php","position":46,"original_position":46,"commit_id":"6751918ab895dfdcebee368fb7aa51baea7092e6","original_commit_id":"6751918ab895dfdcebee368fb7aa51baea7092e6","user":{"login":"dmitriim","id":4626431,"node_id":"MDQ6VXNlcjQ2MjY0MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4626431?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitriim","html_url":"https://github.com/dmitriim","followers_url":"https://api.github.com/users/dmitriim/followers","following_url":"https://api.github.com/users/dmitriim/following{/other_user}","gists_url":"https://api.github.com/users/dmitriim/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriim/subscriptions","organizations_url":"https://api.github.com/users/dmitriim/orgs","repos_url":"https://api.github.com/users/dmitriim/repos","events_url":"https://api.github.com/users/dmitriim/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriim/received_events","type":"User","site_admin":false},"body":"Like this abstraction :+1: ","created_at":"2018-11-04T22:48:43Z","updated_at":"2018-11-04T22:51:47Z","html_url":"https://github.com/catalyst/moodle-tool_objectfs/pull/118#discussion_r230608876","pull_request_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/comments/230608876"},"html":{"href":"https://github.com/catalyst/moodle-tool_objectfs/pull/118#discussion_r230608876"},"pull_request":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118","id":227791299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzkxMjk5","html_url":"https://github.com/catalyst/moodle-tool_objectfs/pull/118","diff_url":"https://github.com/catalyst/moodle-tool_objectfs/pull/118.diff","patch_url":"https://github.com/catalyst/moodle-tool_objectfs/pull/118.patch","issue_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/118","number":118,"state":"open","locked":false,"title":"Issue#99","user":{"login":"tuanngocnguyen","id":26221930,"node_id":"MDQ6VXNlcjI2MjIxOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/26221930?v=4","gravatar_id":"","url":"https://api.github.com/users/tuanngocnguyen","html_url":"https://github.com/tuanngocnguyen","followers_url":"https://api.github.com/users/tuanngocnguyen/followers","following_url":"https://api.github.com/users/tuanngocnguyen/following{/other_user}","gists_url":"https://api.github.com/users/tuanngocnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tuanngocnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuanngocnguyen/subscriptions","organizations_url":"https://api.github.com/users/tuanngocnguyen/orgs","repos_url":"https://api.github.com/users/tuanngocnguyen/repos","events_url":"https://api.github.com/users/tuanngocnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/tuanngocnguyen/received_events","type":"User","site_admin":false},"body":"Add Proxy Setting for AWS","created_at":"2018-11-01T23:35:10Z","updated_at":"2018-11-04T22:51:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f168e31f04bc273e3307b96228d9eed4e3ef4df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118/commits","review_comments_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118/comments","review_comment_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/118/comments","statuses_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/statuses/6751918ab895dfdcebee368fb7aa51baea7092e6","head":{"label":"catalyst:issue#99","ref":"issue#99","sha":"6751918ab895dfdcebee368fb7aa51baea7092e6","user":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":75780069,"node_id":"MDEwOlJlcG9zaXRvcnk3NTc4MDA2OQ==","name":"moodle-tool_objectfs","full_name":"catalyst/moodle-tool_objectfs","private":false,"owner":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst/moodle-tool_objectfs","description":"Object file system for Moodle.","fork":false,"url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs","forks_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/forks","keys_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/teams","hooks_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/hooks","issue_events_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/events","assignees_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/tags","blobs_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/languages","stargazers_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/stargazers","contributors_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/contributors","subscribers_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/subscribers","subscription_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/subscription","commits_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/merges","archive_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/downloads","issues_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/labels{/name}","releases_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/deployments","created_at":"2016-12-06T23:19:19Z","updated_at":"2018-10-25T19:25:18Z","pushed_at":"2018-11-01T23:35:11Z","git_url":"git://github.com/catalyst/moodle-tool_objectfs.git","ssh_url":"git@github.com:catalyst/moodle-tool_objectfs.git","clone_url":"https://github.com/catalyst/moodle-tool_objectfs.git","svn_url":"https://github.com/catalyst/moodle-tool_objectfs","homepage":"","size":348,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":10,"open_issues":31,"watchers":17,"default_branch":"master"}},"base":{"label":"catalyst:master","ref":"master","sha":"7cb100d2ad0a3019eca5c6832307fa8a5df6bb2c","user":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":75780069,"node_id":"MDEwOlJlcG9zaXRvcnk3NTc4MDA2OQ==","name":"moodle-tool_objectfs","full_name":"catalyst/moodle-tool_objectfs","private":false,"owner":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst/moodle-tool_objectfs","description":"Object file system for Moodle.","fork":false,"url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs","forks_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/forks","keys_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/teams","hooks_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/hooks","issue_events_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/events","assignees_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/tags","blobs_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/languages","stargazers_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/stargazers","contributors_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/contributors","subscribers_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/subscribers","subscription_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/subscription","commits_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/merges","archive_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/downloads","issues_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/labels{/name}","releases_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/deployments","created_at":"2016-12-06T23:19:19Z","updated_at":"2018-10-25T19:25:18Z","pushed_at":"2018-11-01T23:35:11Z","git_url":"git://github.com/catalyst/moodle-tool_objectfs.git","ssh_url":"git@github.com:catalyst/moodle-tool_objectfs.git","clone_url":"https://github.com/catalyst/moodle-tool_objectfs.git","svn_url":"https://github.com/catalyst/moodle-tool_objectfs","homepage":"","size":348,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":10,"open_issues":31,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118"},"html":{"href":"https://github.com/catalyst/moodle-tool_objectfs/pull/118"},"issue":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/118"},"comments":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/catalyst/moodle-tool_objectfs/statuses/6751918ab895dfdcebee368fb7aa51baea7092e6"}},"author_association":"NONE"}}
{"actor":{"display_login":"dmitriim"}}