{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments/176760211","pull_request_review_id":106524284,"id":176760211,"diff_hunk":"@@ -466,6 +493,10 @@ private String invalidEnumParamValueError(String param, String val) {\n     return errorRegexp(\"Invalid.*\" + param + \".*\" + val);\n   }\n \n+  private String invalidRelatedParamValueError(String param, String val, String param2, String val2) {\n+    return errorRegexp(\"Invalid.*\" + param + \".*\" + val + \" with \" + param2 + \".*\" + val2);\n+  }\n+\n   private String paramMissingError(String param) {\n     return errorRegexp(param + \".*missing\");\n   }","path":"src/test/java/oracle/kubernetes/operator/create/CreateDomainInputsValidationTest.java","position":51,"original_position":51,"commit_id":"584b41407cdaeafda391989b43852de776479953","original_commit_id":"584b41407cdaeafda391989b43852de776479953","user":{"login":"doxiao","id":32496275,"avatar_url":"https://avatars2.githubusercontent.com/u/32496275?v=4","gravatar_id":"","url":"https://api.github.com/users/doxiao","html_url":"https://github.com/doxiao","followers_url":"https://api.github.com/users/doxiao/followers","following_url":"https://api.github.com/users/doxiao/following{/other_user}","gists_url":"https://api.github.com/users/doxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/doxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxiao/subscriptions","organizations_url":"https://api.github.com/users/doxiao/orgs","repos_url":"https://api.github.com/users/doxiao/repos","events_url":"https://api.github.com/users/doxiao/events{/privacy}","received_events_url":"https://api.github.com/users/doxiao/received_events","type":"User","site_admin":false},"body":"Okay. I'll keep the enum as it is. Thanks.","created_at":"2018-03-23T14:52:34Z","updated_at":"2018-03-23T14:52:34Z","html_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/159#discussion_r176760211","pull_request_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments/176760211"},"html":{"href":"https://github.com/oracle/weblogic-kubernetes-operator/pull/159#discussion_r176760211"},"pull_request":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159"}},"in_reply_to_id":176588468},"pull_request":{"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159","id":176919551,"html_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/159","diff_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/159.diff","patch_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/159.patch","issue_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/159","number":159,"state":"open","locked":false,"title":"Domain pv reclaim policy customization","user":{"login":"doxiao","id":32496275,"avatar_url":"https://avatars2.githubusercontent.com/u/32496275?v=4","gravatar_id":"","url":"https://api.github.com/users/doxiao","html_url":"https://github.com/doxiao","followers_url":"https://api.github.com/users/doxiao/followers","following_url":"https://api.github.com/users/doxiao/following{/other_user}","gists_url":"https://api.github.com/users/doxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/doxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxiao/subscriptions","organizations_url":"https://api.github.com/users/doxiao/orgs","repos_url":"https://api.github.com/users/doxiao/repos","events_url":"https://api.github.com/users/doxiao/events{/privacy}","received_events_url":"https://api.github.com/users/doxiao/received_events","type":"User","site_admin":false},"body":"The changes include:\r\n1) add weblogicDomainStorageReclaimPolicy parameter in domain inputs\r\n2) support the new parameter in create domain job\r\n3) add unit test for the new parameter\r\n4) add integration test case for \"Recycle\" policy\r\n\r\nNote that the changes do not contain documentation update. ","created_at":"2018-03-22T21:51:01Z","updated_at":"2018-03-23T14:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9b8c6a90b5a7797ca93865218a2521e0471d7fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159/commits","review_comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159/comments","review_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/159/comments","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/584b41407cdaeafda391989b43852de776479953","head":{"label":"oracle:domain-pv-reclaim-policy-customization","ref":"domain-pv-reclaim-policy-customization","sha":"584b41407cdaeafda391989b43852de776479953","user":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":113222463,"name":"weblogic-kubernetes-operator","full_name":"oracle/weblogic-kubernetes-operator","owner":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/weblogic-kubernetes-operator","description":"Oracle Weblogic Server Kubernetes Operator","fork":false,"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator","forks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/forks","keys_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/teams","hooks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/hooks","issue_events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/events","assignees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/tags","blobs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/languages","stargazers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/stargazers","contributors_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contributors","subscribers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscribers","subscription_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscription","commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/merges","archive_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/downloads","issues_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/labels{/name}","releases_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/deployments","created_at":"2017-12-05T19:11:06Z","updated_at":"2018-03-22T15:58:55Z","pushed_at":"2018-03-23T10:25:33Z","git_url":"git://github.com/oracle/weblogic-kubernetes-operator.git","ssh_url":"git@github.com:oracle/weblogic-kubernetes-operator.git","clone_url":"https://github.com/oracle/weblogic-kubernetes-operator.git","svn_url":"https://github.com/oracle/weblogic-kubernetes-operator","homepage":"","size":8009,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":21,"watchers":23,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"fd690a3f41d2495b4f655e9cdf06cf1f5ff9e043","user":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":113222463,"name":"weblogic-kubernetes-operator","full_name":"oracle/weblogic-kubernetes-operator","owner":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/weblogic-kubernetes-operator","description":"Oracle Weblogic Server Kubernetes Operator","fork":false,"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator","forks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/forks","keys_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/teams","hooks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/hooks","issue_events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/events","assignees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/tags","blobs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/languages","stargazers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/stargazers","contributors_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contributors","subscribers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscribers","subscription_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscription","commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/merges","archive_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/downloads","issues_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/labels{/name}","releases_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/deployments","created_at":"2017-12-05T19:11:06Z","updated_at":"2018-03-22T15:58:55Z","pushed_at":"2018-03-23T10:25:33Z","git_url":"git://github.com/oracle/weblogic-kubernetes-operator.git","ssh_url":"git@github.com:oracle/weblogic-kubernetes-operator.git","clone_url":"https://github.com/oracle/weblogic-kubernetes-operator.git","svn_url":"https://github.com/oracle/weblogic-kubernetes-operator","homepage":"","size":8009,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":21,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159"},"html":{"href":"https://github.com/oracle/weblogic-kubernetes-operator/pull/159"},"issue":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/159"},"comments":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/584b41407cdaeafda391989b43852de776479953"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"doxiao"}}