{"action":"created","comment":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments/226967872","pull_request_review_id":166897287,"id":226967872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk2Nzg3Mg==","diff_hunk":"@@ -1547,9 +1581,11 @@ private int run2(String[] args) throws Exception {\n     }\n \n     // Proxy\n-    final JettyProxy.Credentials proxyCredentials = proxy ? JettyProxy.Credentials.make(userName) : null;\n-    if (proxyCredentials != null) {\n-      final byte[] hashFileData = StringUtils.bytesOf(proxyCredentials.toHashFileEntry());\n+    final Credentials proxyCredentials = proxy ? Credentials.make(userName) : null;\n+    final String hashFileEntry = proxyCredentials != null ? proxyCredentials.toHashFileEntry() : null;\n+//    H2oServletContainerLoader.INSTANCE.getHashFileEntry()","path":"h2o-hadoop/h2o-mapreduce-generic/src/main/java/water/hadoop/h2odriver.java","position":93,"original_position":93,"commit_id":"d57c1352d657d55c5a44f93117d816fa342b3e76","original_commit_id":"d57c1352d657d55c5a44f93117d816fa342b3e76","user":{"login":"jakubhava","id":4374603,"node_id":"MDQ6VXNlcjQzNzQ2MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/4374603?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubhava","html_url":"https://github.com/jakubhava","followers_url":"https://api.github.com/users/jakubhava/followers","following_url":"https://api.github.com/users/jakubhava/following{/other_user}","gists_url":"https://api.github.com/users/jakubhava/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubhava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubhava/subscriptions","organizations_url":"https://api.github.com/users/jakubhava/orgs","repos_url":"https://api.github.com/users/jakubhava/repos","events_url":"https://api.github.com/users/jakubhava/events{/privacy}","received_events_url":"https://api.github.com/users/jakubhava/received_events","type":"User","site_admin":false},"body":"Comment with code, I would remove it","created_at":"2018-10-22T12:13:02Z","updated_at":"2018-10-22T12:19:24Z","html_url":"https://github.com/h2oai/h2o-3/pull/2938#discussion_r226967872","pull_request_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments/226967872"},"html":{"href":"https://github.com/h2oai/h2o-3/pull/2938#discussion_r226967872"},"pull_request":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938"}}},"pull_request":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938","id":223891309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODkxMzA5","html_url":"https://github.com/h2oai/h2o-3/pull/2938","diff_url":"https://github.com/h2oai/h2o-3/pull/2938.diff","patch_url":"https://github.com/h2oai/h2o-3/pull/2938.patch","issue_url":"https://api.github.com/repos/h2oai/h2o-3/issues/2938","number":2938,"state":"open","locked":false,"title":"PUBDEV-5820: Jetty refactor","user":{"login":"pkozelka","id":45221,"node_id":"MDQ6VXNlcjQ1MjIx","avatar_url":"https://avatars0.githubusercontent.com/u/45221?v=4","gravatar_id":"","url":"https://api.github.com/users/pkozelka","html_url":"https://github.com/pkozelka","followers_url":"https://api.github.com/users/pkozelka/followers","following_url":"https://api.github.com/users/pkozelka/following{/other_user}","gists_url":"https://api.github.com/users/pkozelka/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozelka/subscriptions","organizations_url":"https://api.github.com/users/pkozelka/orgs","repos_url":"https://api.github.com/users/pkozelka/repos","events_url":"https://api.github.com/users/pkozelka/events{/privacy}","received_events_url":"https://api.github.com/users/pkozelka/received_events","type":"User","site_admin":false},"body":"Brings support for CDH 6 and Jetty 9. Support for Jetty 8 will remain selectively possible.\r\n\r\nFollowing steps are included here:\r\n\r\n- [x] add module for CDH6.0 build (derived from branch `cdh6`, PR #2830)\r\n- [x] upgrade Jetty to version 9 (re-introduced former attempt from @jakubhava + improvements)\r\n- [ ] minimize code requiring direct dependency on Jetty\r\n- [x] separate Jetty stuff into its own module, to enable support of both versions\r\n- [ ] tune default versions per environment\r\n\r\nNote that currently, switching to Jetty9 breaks proxy mode. This will be fixed in a later PR as switching to v9 has higher priority (security issues) and does not affect existing customers.","created_at":"2018-10-18T09:48:58Z","updated_at":"2018-10-22T12:19:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea4b915c8f65932eb60454ff7f83c840e84ecda8","assignee":{"login":"pkozelka","id":45221,"node_id":"MDQ6VXNlcjQ1MjIx","avatar_url":"https://avatars0.githubusercontent.com/u/45221?v=4","gravatar_id":"","url":"https://api.github.com/users/pkozelka","html_url":"https://github.com/pkozelka","followers_url":"https://api.github.com/users/pkozelka/followers","following_url":"https://api.github.com/users/pkozelka/following{/other_user}","gists_url":"https://api.github.com/users/pkozelka/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozelka/subscriptions","organizations_url":"https://api.github.com/users/pkozelka/orgs","repos_url":"https://api.github.com/users/pkozelka/repos","events_url":"https://api.github.com/users/pkozelka/events{/privacy}","received_events_url":"https://api.github.com/users/pkozelka/received_events","type":"User","site_admin":false},"assignees":[{"login":"pkozelka","id":45221,"node_id":"MDQ6VXNlcjQ1MjIx","avatar_url":"https://avatars0.githubusercontent.com/u/45221?v=4","gravatar_id":"","url":"https://api.github.com/users/pkozelka","html_url":"https://github.com/pkozelka","followers_url":"https://api.github.com/users/pkozelka/followers","following_url":"https://api.github.com/users/pkozelka/following{/other_user}","gists_url":"https://api.github.com/users/pkozelka/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozelka/subscriptions","organizations_url":"https://api.github.com/users/pkozelka/orgs","repos_url":"https://api.github.com/users/pkozelka/repos","events_url":"https://api.github.com/users/pkozelka/events{/privacy}","received_events_url":"https://api.github.com/users/pkozelka/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":472606676,"node_id":"MDU6TGFiZWw0NzI2MDY2NzY=","url":"https://api.github.com/repos/h2oai/h2o-3/labels/WIP","name":"WIP","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938/commits","review_comments_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938/comments","review_comment_url":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/issues/2938/comments","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/d57c1352d657d55c5a44f93117d816fa342b3e76","head":{"label":"h2oai:pk/PUBDEV-5820-JenkinsRefactor","ref":"pk/PUBDEV-5820-JenkinsRefactor","sha":"d57c1352d657d55c5a44f93117d816fa342b3e76","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":17371412,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MTQxMg==","name":"h2o-3","full_name":"h2oai/h2o-3","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/h2o-3","description":"Open Source Fast Scalable Machine Learning Platform For Smarter Applications (Deep Learning, Gradient Boosting, Random Forest, Generalized Linear Modeling (Logistic Regression, Elastic Net), K-Means, PCA, Stacked Ensembles, Automatic Machine Learning (AutoML), ...)","fork":false,"url":"https://api.github.com/repos/h2oai/h2o-3","forks_url":"https://api.github.com/repos/h2oai/h2o-3/forks","keys_url":"https://api.github.com/repos/h2oai/h2o-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/h2o-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/h2o-3/teams","hooks_url":"https://api.github.com/repos/h2oai/h2o-3/hooks","issue_events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/h2o-3/events","assignees_url":"https://api.github.com/repos/h2oai/h2o-3/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/h2o-3/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/h2o-3/tags","blobs_url":"https://api.github.com/repos/h2oai/h2o-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/h2o-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/h2o-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/h2o-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/h2o-3/languages","stargazers_url":"https://api.github.com/repos/h2oai/h2o-3/stargazers","contributors_url":"https://api.github.com/repos/h2oai/h2o-3/contributors","subscribers_url":"https://api.github.com/repos/h2oai/h2o-3/subscribers","subscription_url":"https://api.github.com/repos/h2oai/h2o-3/subscription","commits_url":"https://api.github.com/repos/h2oai/h2o-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/h2o-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/h2o-3/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/h2o-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/h2o-3/merges","archive_url":"https://api.github.com/repos/h2oai/h2o-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/h2o-3/downloads","issues_url":"https://api.github.com/repos/h2oai/h2o-3/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/h2o-3/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/h2o-3/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/h2o-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/h2o-3/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/h2o-3/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/h2o-3/deployments","created_at":"2014-03-03T16:08:07Z","updated_at":"2018-10-21T16:16:50Z","pushed_at":"2018-10-22T12:08:50Z","git_url":"git://github.com/h2oai/h2o-3.git","ssh_url":"git@github.com:h2oai/h2o-3.git","clone_url":"https://github.com/h2oai/h2o-3.git","svn_url":"https://github.com/h2oai/h2o-3","homepage":"http://h2o.ai","size":425464,"stargazers_count":3503,"watchers_count":3503,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1334,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1334,"open_issues":75,"watchers":3503,"default_branch":"master"}},"base":{"label":"h2oai:master","ref":"master","sha":"e58c70ceb24a59e921fce7ba19e5f8846f2e9c66","user":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"repo":{"id":17371412,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MTQxMg==","name":"h2o-3","full_name":"h2oai/h2o-3","private":false,"owner":{"login":"h2oai","id":1402695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDI2OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1402695?v=4","gravatar_id":"","url":"https://api.github.com/users/h2oai","html_url":"https://github.com/h2oai","followers_url":"https://api.github.com/users/h2oai/followers","following_url":"https://api.github.com/users/h2oai/following{/other_user}","gists_url":"https://api.github.com/users/h2oai/gists{/gist_id}","starred_url":"https://api.github.com/users/h2oai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h2oai/subscriptions","organizations_url":"https://api.github.com/users/h2oai/orgs","repos_url":"https://api.github.com/users/h2oai/repos","events_url":"https://api.github.com/users/h2oai/events{/privacy}","received_events_url":"https://api.github.com/users/h2oai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/h2oai/h2o-3","description":"Open Source Fast Scalable Machine Learning Platform For Smarter Applications (Deep Learning, Gradient Boosting, Random Forest, Generalized Linear Modeling (Logistic Regression, Elastic Net), K-Means, PCA, Stacked Ensembles, Automatic Machine Learning (AutoML), ...)","fork":false,"url":"https://api.github.com/repos/h2oai/h2o-3","forks_url":"https://api.github.com/repos/h2oai/h2o-3/forks","keys_url":"https://api.github.com/repos/h2oai/h2o-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h2oai/h2o-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h2oai/h2o-3/teams","hooks_url":"https://api.github.com/repos/h2oai/h2o-3/hooks","issue_events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/events{/number}","events_url":"https://api.github.com/repos/h2oai/h2o-3/events","assignees_url":"https://api.github.com/repos/h2oai/h2o-3/assignees{/user}","branches_url":"https://api.github.com/repos/h2oai/h2o-3/branches{/branch}","tags_url":"https://api.github.com/repos/h2oai/h2o-3/tags","blobs_url":"https://api.github.com/repos/h2oai/h2o-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h2oai/h2o-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h2oai/h2o-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/h2oai/h2o-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h2oai/h2o-3/statuses/{sha}","languages_url":"https://api.github.com/repos/h2oai/h2o-3/languages","stargazers_url":"https://api.github.com/repos/h2oai/h2o-3/stargazers","contributors_url":"https://api.github.com/repos/h2oai/h2o-3/contributors","subscribers_url":"https://api.github.com/repos/h2oai/h2o-3/subscribers","subscription_url":"https://api.github.com/repos/h2oai/h2o-3/subscription","commits_url":"https://api.github.com/repos/h2oai/h2o-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/h2oai/h2o-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/h2oai/h2o-3/contents/{+path}","compare_url":"https://api.github.com/repos/h2oai/h2o-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h2oai/h2o-3/merges","archive_url":"https://api.github.com/repos/h2oai/h2o-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h2oai/h2o-3/downloads","issues_url":"https://api.github.com/repos/h2oai/h2o-3/issues{/number}","pulls_url":"https://api.github.com/repos/h2oai/h2o-3/pulls{/number}","milestones_url":"https://api.github.com/repos/h2oai/h2o-3/milestones{/number}","notifications_url":"https://api.github.com/repos/h2oai/h2o-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h2oai/h2o-3/labels{/name}","releases_url":"https://api.github.com/repos/h2oai/h2o-3/releases{/id}","deployments_url":"https://api.github.com/repos/h2oai/h2o-3/deployments","created_at":"2014-03-03T16:08:07Z","updated_at":"2018-10-21T16:16:50Z","pushed_at":"2018-10-22T12:08:50Z","git_url":"git://github.com/h2oai/h2o-3.git","ssh_url":"git@github.com:h2oai/h2o-3.git","clone_url":"https://github.com/h2oai/h2o-3.git","svn_url":"https://github.com/h2oai/h2o-3","homepage":"http://h2o.ai","size":425464,"stargazers_count":3503,"watchers_count":3503,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1334,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1334,"open_issues":75,"watchers":3503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938"},"html":{"href":"https://github.com/h2oai/h2o-3/pull/2938"},"issue":{"href":"https://api.github.com/repos/h2oai/h2o-3/issues/2938"},"comments":{"href":"https://api.github.com/repos/h2oai/h2o-3/issues/2938/comments"},"review_comments":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938/comments"},"review_comment":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/h2oai/h2o-3/pulls/2938/commits"},"statuses":{"href":"https://api.github.com/repos/h2oai/h2o-3/statuses/d57c1352d657d55c5a44f93117d816fa342b3e76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jakubhava"}}