{"action":"created","issue":{"url":"https://api.github.com/repos/hfreire/modern-logger/issues/265","repository_url":"https://api.github.com/repos/hfreire/modern-logger","labels_url":"https://api.github.com/repos/hfreire/modern-logger/issues/265/labels{/name}","comments_url":"https://api.github.com/repos/hfreire/modern-logger/issues/265/comments","events_url":"https://api.github.com/repos/hfreire/modern-logger/issues/265/events","html_url":"https://github.com/hfreire/modern-logger/pull/265","id":372741545,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODQ2MTEx","number":265,"title":"Update rollbar to the latest version 🚀","user":{"login":"greenkeeper[bot]","id":23040076,"node_id":"MDM6Qm90MjMwNDAwNzY=","avatar_url":"https://avatars3.githubusercontent.com/in/505?v=4","gravatar_id":"","url":"https://api.github.com/users/greenkeeper%5Bbot%5D","html_url":"https://github.com/apps/greenkeeper","followers_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/followers","following_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/repos","events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/received_events","type":"Bot","site_admin":false},"labels":[{"id":541322225,"node_id":"MDU6TGFiZWw1NDEzMjIyMjU=","url":"https://api.github.com/repos/hfreire/modern-logger/labels/greenkeeper","name":"greenkeeper","color":"00c775","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-22T23:31:28Z","updated_at":"2018-10-22T23:34:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hfreire/modern-logger/pulls/265","html_url":"https://github.com/hfreire/modern-logger/pull/265","diff_url":"https://github.com/hfreire/modern-logger/pull/265.diff","patch_url":"https://github.com/hfreire/modern-logger/pull/265.patch"},"body":"\n## The dependency [rollbar](https://github.com/rollbar/rollbar.js) was updated from `2.4.7` to `2.5.0`.\nThis version is **not covered** by your **current version range**.\n\nIf you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.\n\n---\n\n<details>\n<summary>Release Notes for v2.5.0</summary>\n\n<p>This is a minor version release because the meaning of the <code>scrubFields</code> configuration option has changed slightly. If you upgrade without any changes we may end up scrubbing more fields than you had before. Please see the second bullet point below for how this has changed.</p>\n<ul>\n<li>\n<p>The way we work with network requests for telemetry is a bit janky because of how XHR requests work and because we want to capture data without manual instrumentation. We do this via a monkey patch, this release changes a little bit of the semantics of that monkey patch to try to capture telemetry data in more cases. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"368874571\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/rollbar/rollbar.js/issues/682\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rollbar/rollbar.js/pull/682/hovercard\" href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/pull/682\">#682</a>)</p>\n</li>\n<li>\n<p>When you set the <code>scrubFields</code> configuration option, we have two choices, we either:</p>\n<ul>\n<li>concat your supplied list to the default</li>\n<li>overwrite the default with whatever you supply</li>\n</ul>\n<p>If we do the first then how do you remove things you don't want scrubbed but which are in the default list? If we do the second, how do you add all of the defaults without having to copypasta them from our code?</p>\n<p>This release introduces the configuration boolean <code>overwriteScrubFields</code> which will determine which of the above two behaviours we follow. By default we will concat the <code>scrubFields</code> in the configuration that you set with the default set of fields defined in our package.json. If you set <code>overwriteScrubFields</code> to true then we will instead use your <code>scrubFields</code> value by itself ignoring whatever is currently set.<br>\n(<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load issue title\" data-id=\"370840598\" data-permission-text=\"Issue title is private\" data-url=\"https://github.com/rollbar/rollbar.js/issues/684\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rollbar/rollbar.js/pull/684/hovercard\" href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/pull/684\">#684</a>)</p>\n</li>\n</ul>\n</details>\n\n<details>\n<summary>Commits</summary>\n<p>The new version differs by 7 commits.</p>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/fd7f22d54bb9575f1e4deb097be2aebfee4dca3e\"><code>fd7f22d</code></a> <code>Release v2.5.0</code></li>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/3027a29538131dc9d027235757bdd174b2b2eb96\"><code>3027a29</code></a> <code>Merge pull request #684 from rollbar/expose-options-to-ts-for-debugging</code></li>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/6b3c1979bd95c0ce492b1b8069f9af014b20a4e1\"><code>6b3c197</code></a> <code>Handle scrubFields specially to concat by default and provide a boolean to overwrite</code></li>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/adeb13943a9cd34250ed2113dd012886686b04f8\"><code>adeb139</code></a> <code>Concat configured scrub fields with default</code></li>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/5d0a160b29a2252ee71e085655b569a6191e8dba\"><code>5d0a160</code></a> <code>Merge pull request #682 from rollbar/telemetry-rework</code></li>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/b50fd24b9e736e0a54faf6f35a8bf7d278a3c08b\"><code>b50fd24</code></a> <code>Run the telemetry filter at capture time to handle the majority of cases, but re-run on the way out of copy to handle network telemetry event race conditions</code></li>\n<li><a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/commit/3953b166a0cd5ea0a0e3f0bb6590914f0a899d72\"><code>3953b16</code></a> <code>XHR readyState and network telemetry</code></li>\n</ul>\n<p>See the <a href=\"https://urls.greenkeeper.io/rollbar/rollbar.js/compare/0a3f7609571027056804eaaed20d388dd99bbc6f...fd7f22d54bb9575f1e4deb097be2aebfee4dca3e\">full diff</a></p>\n</details>\n\n<details>\n  <summary>FAQ and help</summary>\n\n  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).\n</details>\n\n---\n\n\nYour [Greenkeeper](https://greenkeeper.io) bot :palm_tree:\n\n"},"comment":{"url":"https://api.github.com/repos/hfreire/modern-logger/issues/comments/432028548","html_url":"https://github.com/hfreire/modern-logger/pull/265#issuecomment-432028548","issue_url":"https://api.github.com/repos/hfreire/modern-logger/issues/265","id":432028548,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjAyODU0OA==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T23:34:58Z","updated_at":"2018-10-22T23:34:58Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/19657782/badge)](https://coveralls.io/builds/19657782)\n\nCoverage remained the same at 90.411% when pulling **fe611585153be452d81246bfacb853dc288b759a on greenkeeper/rollbar-2.5.0** into **4533e0f69dec9bfeeb1924bdc02687edc4014bf3 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}