{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/32643","repository_url":"https://api.github.com/repos/dart-lang/sdk","labels_url":"https://api.github.com/repos/dart-lang/sdk/issues/32643/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/sdk/issues/32643/comments","events_url":"https://api.github.com/repos/dart-lang/sdk/issues/32643/events","html_url":"https://github.com/dart-lang/sdk/issues/32643","id":307774231,"number":32643,"title":"VM: mirrors: missing annotations on inherited members with --preview-dart-2","user":{"login":"bwilkerson","id":5840555,"avatar_url":"https://avatars1.githubusercontent.com/u/5840555?v=4","gravatar_id":"","url":"https://api.github.com/users/bwilkerson","html_url":"https://github.com/bwilkerson","followers_url":"https://api.github.com/users/bwilkerson/followers","following_url":"https://api.github.com/users/bwilkerson/following{/other_user}","gists_url":"https://api.github.com/users/bwilkerson/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilkerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilkerson/subscriptions","organizations_url":"https://api.github.com/users/bwilkerson/orgs","repos_url":"https://api.github.com/users/bwilkerson/repos","events_url":"https://api.github.com/users/bwilkerson/events{/privacy}","received_events_url":"https://api.github.com/users/bwilkerson/received_events","type":"User","site_admin":false},"labels":[{"id":219928158,"url":"https://api.github.com/repos/dart-lang/sdk/labels/P1%20high","name":"P1 high","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dart-lang/sdk/milestones/56","html_url":"https://github.com/dart-lang/sdk/milestone/56","labels_url":"https://api.github.com/repos/dart-lang/sdk/milestones/56/labels","id":3355300,"number":56,"title":"Dart2Prerelease1","description":"","creator":{"login":"JekCharlsonYu","id":35309828,"avatar_url":"https://avatars3.githubusercontent.com/u/35309828?v=4","gravatar_id":"","url":"https://api.github.com/users/JekCharlsonYu","html_url":"https://github.com/JekCharlsonYu","followers_url":"https://api.github.com/users/JekCharlsonYu/followers","following_url":"https://api.github.com/users/JekCharlsonYu/following{/other_user}","gists_url":"https://api.github.com/users/JekCharlsonYu/gists{/gist_id}","starred_url":"https://api.github.com/users/JekCharlsonYu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JekCharlsonYu/subscriptions","organizations_url":"https://api.github.com/users/JekCharlsonYu/orgs","repos_url":"https://api.github.com/users/JekCharlsonYu/repos","events_url":"https://api.github.com/users/JekCharlsonYu/events{/privacy}","received_events_url":"https://api.github.com/users/JekCharlsonYu/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":9,"state":"open","created_at":"2018-05-17T17:10:33Z","updated_at":"2018-05-25T19:41:22Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"comments":4,"created_at":"2018-03-22T18:59:22Z","updated_at":"2018-05-25T20:32:51Z","closed_at":null,"author_association":"MEMBER","body":"It appears that mirrors support is incomplete when the `--preview-dart-2` flag is passed to the vm. In particular, inherited members appear to not have any metadata.\r\n\r\nTo reproduce, execute the following from the root of the sdk checkout:\r\n```\r\ndart --preview-dart-2 pkg/analyzer/test/src/task/strong/inferred_type_test.dart\r\n```\r\nIt will fail several tests, but all of those tests are annotated with the `@failingTest` annotation. The annotation is used by the `test_reflective_loader` package to mark tests that are expected to fail. The problem is that the reflected methods do not have any annotations associated with them. I suspect that this is because the methods are defined in a superclass.\r\n\r\nTo see this in the debugger, place a breakpoint in `sdk/third_party/pkg/test_reflective_loader/lib/test_reflective_loader.dart` on line 122. This is the point at which the presence or absence of the annotation is about to be tested. Execute until the member name is `test_circularReference_viaClosures`. If you inspect the result of executing `memberMirror.metadata` (which is what the code will do if you step into a couple of methods), you should see an empty list, even though the method has an annotation. (You can confirm the annotation by opening `sdk/pkg/analyzer/test/src/task/strong/inferred_type_test.dart` to line 388.)\r\n\r\nThis is blocking me from getting the analyzer tests to pass when passing `--preview-dart-2` to the VM."},"comment":{"url":"https://api.github.com/repos/dart-lang/sdk/issues/comments/392174797","html_url":"https://github.com/dart-lang/sdk/issues/32643#issuecomment-392174797","issue_url":"https://api.github.com/repos/dart-lang/sdk/issues/32643","id":392174797,"user":{"login":"bwilkerson","id":5840555,"avatar_url":"https://avatars1.githubusercontent.com/u/5840555?v=4","gravatar_id":"","url":"https://api.github.com/users/bwilkerson","html_url":"https://github.com/bwilkerson","followers_url":"https://api.github.com/users/bwilkerson/followers","following_url":"https://api.github.com/users/bwilkerson/following{/other_user}","gists_url":"https://api.github.com/users/bwilkerson/gists{/gist_id}","starred_url":"https://api.github.com/users/bwilkerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwilkerson/subscriptions","organizations_url":"https://api.github.com/users/bwilkerson/orgs","repos_url":"https://api.github.com/users/bwilkerson/repos","events_url":"https://api.github.com/users/bwilkerson/events{/privacy}","received_events_url":"https://api.github.com/users/bwilkerson/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T20:32:51Z","updated_at":"2018-05-25T20:32:51Z","author_association":"MEMBER","body":"Thanks! We'll look into fixing that."}}
{"actor":{"display_login":"bwilkerson"}}