{"action":"closed","number":142,"pull_request":{"url":"https://api.github.com/repos/forj-oss/forjj/pulls/142","id":184629661,"html_url":"https://github.com/forj-oss/forjj/pull/142","diff_url":"https://github.com/forj-oss/forjj/pull/142.diff","patch_url":"https://github.com/forj-oss/forjj/pull/142.patch","issue_url":"https://api.github.com/repos/forj-oss/forjj/issues/142","number":142,"state":"closed","locked":false,"title":"Make Forjfile information different for file save and usage in `forjj` ","user":{"login":"clarsonneur","id":6049591,"avatar_url":"https://avatars0.githubusercontent.com/u/6049591?v=4","gravatar_id":"","url":"https://api.github.com/users/clarsonneur","html_url":"https://github.com/clarsonneur","followers_url":"https://api.github.com/users/clarsonneur/followers","following_url":"https://api.github.com/users/clarsonneur/following{/other_user}","gists_url":"https://api.github.com/users/clarsonneur/gists{/gist_id}","starred_url":"https://api.github.com/users/clarsonneur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarsonneur/subscriptions","organizations_url":"https://api.github.com/users/clarsonneur/orgs","repos_url":"https://api.github.com/users/clarsonneur/repos","events_url":"https://api.github.com/users/clarsonneur/events{/privacy}","received_events_url":"https://api.github.com/users/clarsonneur/received_events","type":"User","site_admin":false},"body":"it fix issues to stored data in appropriate files (Forjfile/creds) and use a merged of those data in memory while forjj do the creation, update or maintenance of the forge.\r\n\r\nI re-organized the way data are collected at every layers.\r\n\r\n`create` load Forjfile template and dispatch it to several Forjfiles in the source repo.\r\nIt extract creds and dispatch them as well. All those data are saved.\r\nthen forjj build the merge of those information and use them to:\r\n- send payload data to plugins\r\n- update it from plugins for next plugins (upstream for others)\r\n\r\n`Update` do quite the same except it do not read a Forjfile template but all Forjfile from source repo and do not update them (at least today)\r\nOf course it generates the deploy code to the deploy repo.\r\nOnly credentials are saved, if we update one of them.\r\n\r\n`maintain` reads the deploy code, and send the required payload for the deploy script to work. usually credential data.\r\nnothing is saved.","created_at":"2018-04-27T13:56:39Z","updated_at":"2018-04-27T14:01:04Z","closed_at":"2018-04-27T14:01:04Z","merged_at":"2018-04-27T14:01:04Z","merge_commit_sha":"6e834e9466a71ae6749e6aecc6c0ab530b0d9555","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forj-oss/forjj/pulls/142/commits","review_comments_url":"https://api.github.com/repos/forj-oss/forjj/pulls/142/comments","review_comment_url":"https://api.github.com/repos/forj-oss/forjj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forj-oss/forjj/issues/142/comments","statuses_url":"https://api.github.com/repos/forj-oss/forjj/statuses/e29969cc83dd0d6cd6930b73ca53975d54e54394","head":{"label":"clarsonneur:re-organize-scan","ref":"re-organize-scan","sha":"e29969cc83dd0d6cd6930b73ca53975d54e54394","user":{"login":"clarsonneur","id":6049591,"avatar_url":"https://avatars0.githubusercontent.com/u/6049591?v=4","gravatar_id":"","url":"https://api.github.com/users/clarsonneur","html_url":"https://github.com/clarsonneur","followers_url":"https://api.github.com/users/clarsonneur/followers","following_url":"https://api.github.com/users/clarsonneur/following{/other_user}","gists_url":"https://api.github.com/users/clarsonneur/gists{/gist_id}","starred_url":"https://api.github.com/users/clarsonneur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarsonneur/subscriptions","organizations_url":"https://api.github.com/users/clarsonneur/orgs","repos_url":"https://api.github.com/users/clarsonneur/repos","events_url":"https://api.github.com/users/clarsonneur/events{/privacy}","received_events_url":"https://api.github.com/users/clarsonneur/received_events","type":"User","site_admin":false},"repo":{"id":79337271,"name":"forjj","full_name":"clarsonneur/forjj","owner":{"login":"clarsonneur","id":6049591,"avatar_url":"https://avatars0.githubusercontent.com/u/6049591?v=4","gravatar_id":"","url":"https://api.github.com/users/clarsonneur","html_url":"https://github.com/clarsonneur","followers_url":"https://api.github.com/users/clarsonneur/followers","following_url":"https://api.github.com/users/clarsonneur/following{/other_user}","gists_url":"https://api.github.com/users/clarsonneur/gists{/gist_id}","starred_url":"https://api.github.com/users/clarsonneur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarsonneur/subscriptions","organizations_url":"https://api.github.com/users/clarsonneur/orgs","repos_url":"https://api.github.com/users/clarsonneur/repos","events_url":"https://api.github.com/users/clarsonneur/events{/privacy}","received_events_url":"https://api.github.com/users/clarsonneur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clarsonneur/forjj","description":"Build your DevOps environment in minutes - thanks to docker!","fork":true,"url":"https://api.github.com/repos/clarsonneur/forjj","forks_url":"https://api.github.com/repos/clarsonneur/forjj/forks","keys_url":"https://api.github.com/repos/clarsonneur/forjj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clarsonneur/forjj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clarsonneur/forjj/teams","hooks_url":"https://api.github.com/repos/clarsonneur/forjj/hooks","issue_events_url":"https://api.github.com/repos/clarsonneur/forjj/issues/events{/number}","events_url":"https://api.github.com/repos/clarsonneur/forjj/events","assignees_url":"https://api.github.com/repos/clarsonneur/forjj/assignees{/user}","branches_url":"https://api.github.com/repos/clarsonneur/forjj/branches{/branch}","tags_url":"https://api.github.com/repos/clarsonneur/forjj/tags","blobs_url":"https://api.github.com/repos/clarsonneur/forjj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clarsonneur/forjj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clarsonneur/forjj/git/refs{/sha}","trees_url":"https://api.github.com/repos/clarsonneur/forjj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clarsonneur/forjj/statuses/{sha}","languages_url":"https://api.github.com/repos/clarsonneur/forjj/languages","stargazers_url":"https://api.github.com/repos/clarsonneur/forjj/stargazers","contributors_url":"https://api.github.com/repos/clarsonneur/forjj/contributors","subscribers_url":"https://api.github.com/repos/clarsonneur/forjj/subscribers","subscription_url":"https://api.github.com/repos/clarsonneur/forjj/subscription","commits_url":"https://api.github.com/repos/clarsonneur/forjj/commits{/sha}","git_commits_url":"https://api.github.com/repos/clarsonneur/forjj/git/commits{/sha}","comments_url":"https://api.github.com/repos/clarsonneur/forjj/comments{/number}","issue_comment_url":"https://api.github.com/repos/clarsonneur/forjj/issues/comments{/number}","contents_url":"https://api.github.com/repos/clarsonneur/forjj/contents/{+path}","compare_url":"https://api.github.com/repos/clarsonneur/forjj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clarsonneur/forjj/merges","archive_url":"https://api.github.com/repos/clarsonneur/forjj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clarsonneur/forjj/downloads","issues_url":"https://api.github.com/repos/clarsonneur/forjj/issues{/number}","pulls_url":"https://api.github.com/repos/clarsonneur/forjj/pulls{/number}","milestones_url":"https://api.github.com/repos/clarsonneur/forjj/milestones{/number}","notifications_url":"https://api.github.com/repos/clarsonneur/forjj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clarsonneur/forjj/labels{/name}","releases_url":"https://api.github.com/repos/clarsonneur/forjj/releases{/id}","deployments_url":"https://api.github.com/repos/clarsonneur/forjj/deployments","created_at":"2017-01-18T12:20:42Z","updated_at":"2018-04-24T10:49:00Z","pushed_at":"2018-04-27T13:41:16Z","git_url":"git://github.com/clarsonneur/forjj.git","ssh_url":"git@github.com:clarsonneur/forjj.git","clone_url":"https://github.com/clarsonneur/forjj.git","svn_url":"https://github.com/clarsonneur/forjj","homepage":"","size":854,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forj-oss:master","ref":"master","sha":"44e102d9102bc2e3516eca966b6d89d2c953de76","user":{"login":"forj-oss","id":7928860,"avatar_url":"https://avatars3.githubusercontent.com/u/7928860?v=4","gravatar_id":"","url":"https://api.github.com/users/forj-oss","html_url":"https://github.com/forj-oss","followers_url":"https://api.github.com/users/forj-oss/followers","following_url":"https://api.github.com/users/forj-oss/following{/other_user}","gists_url":"https://api.github.com/users/forj-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/forj-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forj-oss/subscriptions","organizations_url":"https://api.github.com/users/forj-oss/orgs","repos_url":"https://api.github.com/users/forj-oss/repos","events_url":"https://api.github.com/users/forj-oss/events{/privacy}","received_events_url":"https://api.github.com/users/forj-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":78142661,"name":"forjj","full_name":"forj-oss/forjj","owner":{"login":"forj-oss","id":7928860,"avatar_url":"https://avatars3.githubusercontent.com/u/7928860?v=4","gravatar_id":"","url":"https://api.github.com/users/forj-oss","html_url":"https://github.com/forj-oss","followers_url":"https://api.github.com/users/forj-oss/followers","following_url":"https://api.github.com/users/forj-oss/following{/other_user}","gists_url":"https://api.github.com/users/forj-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/forj-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forj-oss/subscriptions","organizations_url":"https://api.github.com/users/forj-oss/orgs","repos_url":"https://api.github.com/users/forj-oss/repos","events_url":"https://api.github.com/users/forj-oss/events{/privacy}","received_events_url":"https://api.github.com/users/forj-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forj-oss/forjj","description":"Build your DevOps environment in minutes - thanks to docker!","fork":false,"url":"https://api.github.com/repos/forj-oss/forjj","forks_url":"https://api.github.com/repos/forj-oss/forjj/forks","keys_url":"https://api.github.com/repos/forj-oss/forjj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forj-oss/forjj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forj-oss/forjj/teams","hooks_url":"https://api.github.com/repos/forj-oss/forjj/hooks","issue_events_url":"https://api.github.com/repos/forj-oss/forjj/issues/events{/number}","events_url":"https://api.github.com/repos/forj-oss/forjj/events","assignees_url":"https://api.github.com/repos/forj-oss/forjj/assignees{/user}","branches_url":"https://api.github.com/repos/forj-oss/forjj/branches{/branch}","tags_url":"https://api.github.com/repos/forj-oss/forjj/tags","blobs_url":"https://api.github.com/repos/forj-oss/forjj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forj-oss/forjj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forj-oss/forjj/git/refs{/sha}","trees_url":"https://api.github.com/repos/forj-oss/forjj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forj-oss/forjj/statuses/{sha}","languages_url":"https://api.github.com/repos/forj-oss/forjj/languages","stargazers_url":"https://api.github.com/repos/forj-oss/forjj/stargazers","contributors_url":"https://api.github.com/repos/forj-oss/forjj/contributors","subscribers_url":"https://api.github.com/repos/forj-oss/forjj/subscribers","subscription_url":"https://api.github.com/repos/forj-oss/forjj/subscription","commits_url":"https://api.github.com/repos/forj-oss/forjj/commits{/sha}","git_commits_url":"https://api.github.com/repos/forj-oss/forjj/git/commits{/sha}","comments_url":"https://api.github.com/repos/forj-oss/forjj/comments{/number}","issue_comment_url":"https://api.github.com/repos/forj-oss/forjj/issues/comments{/number}","contents_url":"https://api.github.com/repos/forj-oss/forjj/contents/{+path}","compare_url":"https://api.github.com/repos/forj-oss/forjj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forj-oss/forjj/merges","archive_url":"https://api.github.com/repos/forj-oss/forjj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forj-oss/forjj/downloads","issues_url":"https://api.github.com/repos/forj-oss/forjj/issues{/number}","pulls_url":"https://api.github.com/repos/forj-oss/forjj/pulls{/number}","milestones_url":"https://api.github.com/repos/forj-oss/forjj/milestones{/number}","notifications_url":"https://api.github.com/repos/forj-oss/forjj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forj-oss/forjj/labels{/name}","releases_url":"https://api.github.com/repos/forj-oss/forjj/releases{/id}","deployments_url":"https://api.github.com/repos/forj-oss/forjj/deployments","created_at":"2017-01-05T19:41:49Z","updated_at":"2018-04-24T10:48:20Z","pushed_at":"2018-04-27T14:01:04Z","git_url":"git://github.com/forj-oss/forjj.git","ssh_url":"git@github.com:forj-oss/forjj.git","clone_url":"https://github.com/forj-oss/forjj.git","svn_url":"https://github.com/forj-oss/forjj","homepage":"","size":769,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":34,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forj-oss/forjj/pulls/142"},"html":{"href":"https://github.com/forj-oss/forjj/pull/142"},"issue":{"href":"https://api.github.com/repos/forj-oss/forjj/issues/142"},"comments":{"href":"https://api.github.com/repos/forj-oss/forjj/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/forj-oss/forjj/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/forj-oss/forjj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forj-oss/forjj/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/forj-oss/forjj/statuses/e29969cc83dd0d6cd6930b73ca53975d54e54394"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"clarsonneur","id":6049591,"avatar_url":"https://avatars0.githubusercontent.com/u/6049591?v=4","gravatar_id":"","url":"https://api.github.com/users/clarsonneur","html_url":"https://github.com/clarsonneur","followers_url":"https://api.github.com/users/clarsonneur/followers","following_url":"https://api.github.com/users/clarsonneur/following{/other_user}","gists_url":"https://api.github.com/users/clarsonneur/gists{/gist_id}","starred_url":"https://api.github.com/users/clarsonneur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarsonneur/subscriptions","organizations_url":"https://api.github.com/users/clarsonneur/orgs","repos_url":"https://api.github.com/users/clarsonneur/repos","events_url":"https://api.github.com/users/clarsonneur/events{/privacy}","received_events_url":"https://api.github.com/users/clarsonneur/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":593,"deletions":228,"changed_files":20}}
{"actor":{"display_login":"clarsonneur"}}