{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/comments/195252947","pull_request_review_id":128585060,"id":195252947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI1Mjk0Nw==","diff_hunk":"@@ -145,6 +145,27 @@ var _ = Describe(\"Syslog\", func() {\n \t\tExpect(msg.Message).To(Equal([]byte(\"\\n\")))\n \t})\n \n+\tIt(\"sets the tags as part of structured data\", func() {","path":"rpc/loggregator_v2/syslog_test.go","position":4,"original_position":4,"commit_id":"2eb02cfd0a4e14a164c6f72e25a925d251fd222e","original_commit_id":"2eb02cfd0a4e14a164c6f72e25a925d251fd222e","user":{"login":"wfernandes","id":2303039,"node_id":"MDQ6VXNlcjIzMDMwMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2303039?v=4","gravatar_id":"","url":"https://api.github.com/users/wfernandes","html_url":"https://github.com/wfernandes","followers_url":"https://api.github.com/users/wfernandes/followers","following_url":"https://api.github.com/users/wfernandes/following{/other_user}","gists_url":"https://api.github.com/users/wfernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/wfernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfernandes/subscriptions","organizations_url":"https://api.github.com/users/wfernandes/orgs","repos_url":"https://api.github.com/users/wfernandes/repos","events_url":"https://api.github.com/users/wfernandes/events{/privacy}","received_events_url":"https://api.github.com/users/wfernandes/received_events","type":"User","site_admin":false},"body":"I actually wrote one up but since it was a map, the ordering of the output made the tests flaky. I can write one up with a single tag though.","created_at":"2018-06-13T22:16:13Z","updated_at":"2018-06-13T22:16:13Z","html_url":"https://github.com/cloudfoundry/go-loggregator/pull/33#discussion_r195252947","pull_request_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/comments/195252947"},"html":{"href":"https://github.com/cloudfoundry/go-loggregator/pull/33#discussion_r195252947"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33"}},"in_reply_to_id":195250186},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33","id":194724865,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzI0ODY1","html_url":"https://github.com/cloudfoundry/go-loggregator/pull/33","diff_url":"https://github.com/cloudfoundry/go-loggregator/pull/33.diff","patch_url":"https://github.com/cloudfoundry/go-loggregator/pull/33.patch","issue_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/33","number":33,"state":"open","locked":false,"title":"Add support for representing tags as structured data in syslog msg","user":{"login":"wfernandes","id":2303039,"node_id":"MDQ6VXNlcjIzMDMwMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/2303039?v=4","gravatar_id":"","url":"https://api.github.com/users/wfernandes","html_url":"https://github.com/wfernandes","followers_url":"https://api.github.com/users/wfernandes/followers","following_url":"https://api.github.com/users/wfernandes/following{/other_user}","gists_url":"https://api.github.com/users/wfernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/wfernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfernandes/subscriptions","organizations_url":"https://api.github.com/users/wfernandes/orgs","repos_url":"https://api.github.com/users/wfernandes/repos","events_url":"https://api.github.com/users/wfernandes/events{/privacy}","received_events_url":"https://api.github.com/users/wfernandes/received_events","type":"User","site_admin":false},"body":"When envelopes have tags, they will be represented as follows:\r\n\r\n```\r\n<14>1 1970-01-01T01:00:00+00:00 some-hostname some-source-id some-instance-id - [tags@47450 namespace=\"test-ns\"][gauge@47450 name=\"memory\" value=\"5423\" unit=\"bytes\"] \r\n```\r\n\r\nFor Context:\r\n@jasonkeene \r\n@ahevenor ","created_at":"2018-06-13T21:48:16Z","updated_at":"2018-06-13T22:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18fd4e961f6a2e7e10d73f982d4af7b3c6b7ca1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/33/comments","statuses_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/statuses/2eb02cfd0a4e14a164c6f72e25a925d251fd222e","head":{"label":"cloudfoundry:syslog-support-tags","ref":"syslog-support-tags","sha":"2eb02cfd0a4e14a164c6f72e25a925d251fd222e","user":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":87119574,"node_id":"MDEwOlJlcG9zaXRvcnk4NzExOTU3NA==","name":"go-loggregator","full_name":"cloudfoundry/go-loggregator","owner":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry/go-loggregator","description":"Go Client Library for Loggregator","fork":false,"url":"https://api.github.com/repos/cloudfoundry/go-loggregator","forks_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/forks","keys_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/events","assignees_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/merges","archive_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/deployments","created_at":"2017-04-03T20:50:06Z","updated_at":"2018-06-07T22:56:21Z","pushed_at":"2018-06-13T21:48:16Z","git_url":"git://github.com/cloudfoundry/go-loggregator.git","ssh_url":"git@github.com:cloudfoundry/go-loggregator.git","clone_url":"https://github.com/cloudfoundry/go-loggregator.git","svn_url":"https://github.com/cloudfoundry/go-loggregator","homepage":"","size":3815,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"cloudfoundry:master","ref":"master","sha":"91c70f8a22222480267a6301d3551403d825d483","user":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":87119574,"node_id":"MDEwOlJlcG9zaXRvcnk4NzExOTU3NA==","name":"go-loggregator","full_name":"cloudfoundry/go-loggregator","owner":{"login":"cloudfoundry","id":621746,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTc0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/621746?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry","html_url":"https://github.com/cloudfoundry","followers_url":"https://api.github.com/users/cloudfoundry/followers","following_url":"https://api.github.com/users/cloudfoundry/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry/orgs","repos_url":"https://api.github.com/users/cloudfoundry/repos","events_url":"https://api.github.com/users/cloudfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry/go-loggregator","description":"Go Client Library for Loggregator","fork":false,"url":"https://api.github.com/repos/cloudfoundry/go-loggregator","forks_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/forks","keys_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/teams","hooks_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/events","assignees_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/tags","blobs_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/subscription","commits_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/merges","archive_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/downloads","issues_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry/go-loggregator/deployments","created_at":"2017-04-03T20:50:06Z","updated_at":"2018-06-07T22:56:21Z","pushed_at":"2018-06-13T21:48:16Z","git_url":"git://github.com/cloudfoundry/go-loggregator.git","ssh_url":"git@github.com:cloudfoundry/go-loggregator.git","clone_url":"https://github.com/cloudfoundry/go-loggregator.git","svn_url":"https://github.com/cloudfoundry/go-loggregator","homepage":"","size":3815,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33"},"html":{"href":"https://github.com/cloudfoundry/go-loggregator/pull/33"},"issue":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/33"},"comments":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry/go-loggregator/statuses/2eb02cfd0a4e14a164c6f72e25a925d251fd222e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wfernandes"}}