{"action":"created","issue":{"url":"https://api.github.com/repos/urweb/urweb/issues/146","repository_url":"https://api.github.com/repos/urweb/urweb","labels_url":"https://api.github.com/repos/urweb/urweb/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/urweb/urweb/issues/146/comments","events_url":"https://api.github.com/repos/urweb/urweb/issues/146/events","html_url":"https://github.com/urweb/urweb/pull/146","id":381904884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzU0MDk3","number":146,"title":"utf-8 aware functions for basis. unit-testing.","user":{"login":"fabriceleal","id":1077306,"node_id":"MDQ6VXNlcjEwNzczMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1077306?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriceleal","html_url":"https://github.com/fabriceleal","followers_url":"https://api.github.com/users/fabriceleal/followers","following_url":"https://api.github.com/users/fabriceleal/following{/other_user}","gists_url":"https://api.github.com/users/fabriceleal/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriceleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriceleal/subscriptions","organizations_url":"https://api.github.com/users/fabriceleal/orgs","repos_url":"https://api.github.com/users/fabriceleal/repos","events_url":"https://api.github.com/users/fabriceleal/events{/privacy}","received_events_url":"https://api.github.com/users/fabriceleal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-17T21:56:17Z","updated_at":"2018-11-18T07:06:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/urweb/urweb/pulls/146","html_url":"https://github.com/urweb/urweb/pull/146","diff_url":"https://github.com/urweb/urweb/pull/146.diff","patch_url":"https://github.com/urweb/urweb/pull/146.patch"},"body":"I think I got this - I took the liberty of rebasing everything into a single commit. I made some unit tests as well. Feel free to criticize/ask stuff."},"comment":{"url":"https://api.github.com/repos/urweb/urweb/issues/comments/439672525","html_url":"https://github.com/urweb/urweb/pull/146#issuecomment-439672525","issue_url":"https://api.github.com/repos/urweb/urweb/issues/146","id":439672525,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTY3MjUyNQ==","user":{"login":"ashalkhakov","id":1270502,"node_id":"MDQ6VXNlcjEyNzA1MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1270502?v=4","gravatar_id":"","url":"https://api.github.com/users/ashalkhakov","html_url":"https://github.com/ashalkhakov","followers_url":"https://api.github.com/users/ashalkhakov/followers","following_url":"https://api.github.com/users/ashalkhakov/following{/other_user}","gists_url":"https://api.github.com/users/ashalkhakov/gists{/gist_id}","starred_url":"https://api.github.com/users/ashalkhakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashalkhakov/subscriptions","organizations_url":"https://api.github.com/users/ashalkhakov/orgs","repos_url":"https://api.github.com/users/ashalkhakov/repos","events_url":"https://api.github.com/users/ashalkhakov/events{/privacy}","received_events_url":"https://api.github.com/users/ashalkhakov/received_events","type":"User","site_admin":false},"created_at":"2018-11-18T07:06:32Z","updated_at":"2018-11-18T07:06:32Z","author_association":"CONTRIBUTOR","body":"Hi Fabrice,\r\n\r\nThat's so much good work! Thank you!\r\n\r\nOne thing I would note is that tests should cover both client and server side code: we want identical behavior. Edward Yang wrote a blog post about moving computations between client and server. So, you could have just a function that you force to evaluate on both client (JS) and server (C). Then you can use Basis.assert in it, that would fail on the first error. And the selenium tests would only have to verify absence of errors only."}}
{"actor":{"display_login":"ashalkhakov"}}