{"action":"created","comment":{"url":"https://api.github.com/repos/tarantool/smtp/pulls/comments/166308643","pull_request_review_id":94353497,"id":166308643,"diff_hunk":"@@ -154,8 +154,13 @@ curl_mt = {\n             if opts.headers and #opts.headers > 0 then\n                 header = header .. table.concat(opts.headers, '\\r\\n') .. '\\r\\n'\n             end\n+\n+            local content_type = opts.content_type or 'text/plain'\n+            local charset = opts.charset or 'UTF-8'\n             if opts.subject then\n-                header = header .. 'Subject: ' .. opts.subject .. '\\r\\n'\n+                header = header ..\n+                    'Content-Type: ' .. content_type .. '; charset=' .. charset .. '\\r\\n' ..","path":"smtp/init.lua","position":10,"original_position":10,"commit_id":"bf45f23c005e4de0f49cf322b9c8f1265f044930","original_commit_id":"bf45f23c005e4de0f49cf322b9c8f1265f044930","user":{"login":"Totktonada","id":92749,"avatar_url":"https://avatars1.githubusercontent.com/u/92749?v=4","gravatar_id":"","url":"https://api.github.com/users/Totktonada","html_url":"https://github.com/Totktonada","followers_url":"https://api.github.com/users/Totktonada/followers","following_url":"https://api.github.com/users/Totktonada/following{/other_user}","gists_url":"https://api.github.com/users/Totktonada/gists{/gist_id}","starred_url":"https://api.github.com/users/Totktonada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Totktonada/subscriptions","organizations_url":"https://api.github.com/users/Totktonada/orgs","repos_url":"https://api.github.com/users/Totktonada/repos","events_url":"https://api.github.com/users/Totktonada/events{/privacy}","received_events_url":"https://api.github.com/users/Totktonada/received_events","type":"User","site_admin":false},"body":"Hmm, you set content type only if subject provided?","created_at":"2018-02-06T14:05:49Z","updated_at":"2018-02-06T14:05:49Z","html_url":"https://github.com/tarantool/smtp/pull/5#discussion_r166308643","pull_request_url":"https://api.github.com/repos/tarantool/smtp/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tarantool/smtp/pulls/comments/166308643"},"html":{"href":"https://github.com/tarantool/smtp/pull/5#discussion_r166308643"},"pull_request":{"href":"https://api.github.com/repos/tarantool/smtp/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/tarantool/smtp/pulls/5","id":167415698,"html_url":"https://github.com/tarantool/smtp/pull/5","diff_url":"https://github.com/tarantool/smtp/pull/5.diff","patch_url":"https://github.com/tarantool/smtp/pull/5.patch","issue_url":"https://api.github.com/repos/tarantool/smtp/issues/5","number":5,"state":"open","locked":false,"title":"set content-type for subject","user":{"login":"sharonovd","id":31623709,"avatar_url":"https://avatars1.githubusercontent.com/u/31623709?v=4","gravatar_id":"","url":"https://api.github.com/users/sharonovd","html_url":"https://github.com/sharonovd","followers_url":"https://api.github.com/users/sharonovd/followers","following_url":"https://api.github.com/users/sharonovd/following{/other_user}","gists_url":"https://api.github.com/users/sharonovd/gists{/gist_id}","starred_url":"https://api.github.com/users/sharonovd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharonovd/subscriptions","organizations_url":"https://api.github.com/users/sharonovd/orgs","repos_url":"https://api.github.com/users/sharonovd/repos","events_url":"https://api.github.com/users/sharonovd/events{/privacy}","received_events_url":"https://api.github.com/users/sharonovd/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T13:37:18Z","updated_at":"2018-02-06T14:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aeafd97b935bc0e2b2deb83d13a6778b703703f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/tarantool/smtp/pulls/5/commits","review_comments_url":"https://api.github.com/repos/tarantool/smtp/pulls/5/comments","review_comment_url":"https://api.github.com/repos/tarantool/smtp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tarantool/smtp/issues/5/comments","statuses_url":"https://api.github.com/repos/tarantool/smtp/statuses/bf45f23c005e4de0f49cf322b9c8f1265f044930","head":{"label":"tarantool:fancy-headers","ref":"fancy-headers","sha":"bf45f23c005e4de0f49cf322b9c8f1265f044930","user":{"login":"tarantool","id":2344919,"avatar_url":"https://avatars0.githubusercontent.com/u/2344919?v=4","gravatar_id":"","url":"https://api.github.com/users/tarantool","html_url":"https://github.com/tarantool","followers_url":"https://api.github.com/users/tarantool/followers","following_url":"https://api.github.com/users/tarantool/following{/other_user}","gists_url":"https://api.github.com/users/tarantool/gists{/gist_id}","starred_url":"https://api.github.com/users/tarantool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarantool/subscriptions","organizations_url":"https://api.github.com/users/tarantool/orgs","repos_url":"https://api.github.com/users/tarantool/repos","events_url":"https://api.github.com/users/tarantool/events{/privacy}","received_events_url":"https://api.github.com/users/tarantool/received_events","type":"Organization","site_admin":false},"repo":{"id":106016020,"name":"smtp","full_name":"tarantool/smtp","owner":{"login":"tarantool","id":2344919,"avatar_url":"https://avatars0.githubusercontent.com/u/2344919?v=4","gravatar_id":"","url":"https://api.github.com/users/tarantool","html_url":"https://github.com/tarantool","followers_url":"https://api.github.com/users/tarantool/followers","following_url":"https://api.github.com/users/tarantool/following{/other_user}","gists_url":"https://api.github.com/users/tarantool/gists{/gist_id}","starred_url":"https://api.github.com/users/tarantool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarantool/subscriptions","organizations_url":"https://api.github.com/users/tarantool/orgs","repos_url":"https://api.github.com/users/tarantool/repos","events_url":"https://api.github.com/users/tarantool/events{/privacy}","received_events_url":"https://api.github.com/users/tarantool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tarantool/smtp","description":"Send email via SMTP from Tarantool","fork":false,"url":"https://api.github.com/repos/tarantool/smtp","forks_url":"https://api.github.com/repos/tarantool/smtp/forks","keys_url":"https://api.github.com/repos/tarantool/smtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarantool/smtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarantool/smtp/teams","hooks_url":"https://api.github.com/repos/tarantool/smtp/hooks","issue_events_url":"https://api.github.com/repos/tarantool/smtp/issues/events{/number}","events_url":"https://api.github.com/repos/tarantool/smtp/events","assignees_url":"https://api.github.com/repos/tarantool/smtp/assignees{/user}","branches_url":"https://api.github.com/repos/tarantool/smtp/branches{/branch}","tags_url":"https://api.github.com/repos/tarantool/smtp/tags","blobs_url":"https://api.github.com/repos/tarantool/smtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarantool/smtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarantool/smtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarantool/smtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarantool/smtp/statuses/{sha}","languages_url":"https://api.github.com/repos/tarantool/smtp/languages","stargazers_url":"https://api.github.com/repos/tarantool/smtp/stargazers","contributors_url":"https://api.github.com/repos/tarantool/smtp/contributors","subscribers_url":"https://api.github.com/repos/tarantool/smtp/subscribers","subscription_url":"https://api.github.com/repos/tarantool/smtp/subscription","commits_url":"https://api.github.com/repos/tarantool/smtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarantool/smtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarantool/smtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarantool/smtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarantool/smtp/contents/{+path}","compare_url":"https://api.github.com/repos/tarantool/smtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarantool/smtp/merges","archive_url":"https://api.github.com/repos/tarantool/smtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarantool/smtp/downloads","issues_url":"https://api.github.com/repos/tarantool/smtp/issues{/number}","pulls_url":"https://api.github.com/repos/tarantool/smtp/pulls{/number}","milestones_url":"https://api.github.com/repos/tarantool/smtp/milestones{/number}","notifications_url":"https://api.github.com/repos/tarantool/smtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarantool/smtp/labels{/name}","releases_url":"https://api.github.com/repos/tarantool/smtp/releases{/id}","deployments_url":"https://api.github.com/repos/tarantool/smtp/deployments","created_at":"2017-10-06T14:46:30Z","updated_at":"2018-02-05T12:23:44Z","pushed_at":"2018-02-06T14:00:57Z","git_url":"git://github.com/tarantool/smtp.git","ssh_url":"git@github.com:tarantool/smtp.git","clone_url":"https://github.com/tarantool/smtp.git","svn_url":"https://github.com/tarantool/smtp","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tarantool:master","ref":"master","sha":"de94c4adfb64e8ac6e439308b11fcaf2dd660fff","user":{"login":"tarantool","id":2344919,"avatar_url":"https://avatars0.githubusercontent.com/u/2344919?v=4","gravatar_id":"","url":"https://api.github.com/users/tarantool","html_url":"https://github.com/tarantool","followers_url":"https://api.github.com/users/tarantool/followers","following_url":"https://api.github.com/users/tarantool/following{/other_user}","gists_url":"https://api.github.com/users/tarantool/gists{/gist_id}","starred_url":"https://api.github.com/users/tarantool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarantool/subscriptions","organizations_url":"https://api.github.com/users/tarantool/orgs","repos_url":"https://api.github.com/users/tarantool/repos","events_url":"https://api.github.com/users/tarantool/events{/privacy}","received_events_url":"https://api.github.com/users/tarantool/received_events","type":"Organization","site_admin":false},"repo":{"id":106016020,"name":"smtp","full_name":"tarantool/smtp","owner":{"login":"tarantool","id":2344919,"avatar_url":"https://avatars0.githubusercontent.com/u/2344919?v=4","gravatar_id":"","url":"https://api.github.com/users/tarantool","html_url":"https://github.com/tarantool","followers_url":"https://api.github.com/users/tarantool/followers","following_url":"https://api.github.com/users/tarantool/following{/other_user}","gists_url":"https://api.github.com/users/tarantool/gists{/gist_id}","starred_url":"https://api.github.com/users/tarantool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarantool/subscriptions","organizations_url":"https://api.github.com/users/tarantool/orgs","repos_url":"https://api.github.com/users/tarantool/repos","events_url":"https://api.github.com/users/tarantool/events{/privacy}","received_events_url":"https://api.github.com/users/tarantool/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tarantool/smtp","description":"Send email via SMTP from Tarantool","fork":false,"url":"https://api.github.com/repos/tarantool/smtp","forks_url":"https://api.github.com/repos/tarantool/smtp/forks","keys_url":"https://api.github.com/repos/tarantool/smtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tarantool/smtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tarantool/smtp/teams","hooks_url":"https://api.github.com/repos/tarantool/smtp/hooks","issue_events_url":"https://api.github.com/repos/tarantool/smtp/issues/events{/number}","events_url":"https://api.github.com/repos/tarantool/smtp/events","assignees_url":"https://api.github.com/repos/tarantool/smtp/assignees{/user}","branches_url":"https://api.github.com/repos/tarantool/smtp/branches{/branch}","tags_url":"https://api.github.com/repos/tarantool/smtp/tags","blobs_url":"https://api.github.com/repos/tarantool/smtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tarantool/smtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tarantool/smtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tarantool/smtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tarantool/smtp/statuses/{sha}","languages_url":"https://api.github.com/repos/tarantool/smtp/languages","stargazers_url":"https://api.github.com/repos/tarantool/smtp/stargazers","contributors_url":"https://api.github.com/repos/tarantool/smtp/contributors","subscribers_url":"https://api.github.com/repos/tarantool/smtp/subscribers","subscription_url":"https://api.github.com/repos/tarantool/smtp/subscription","commits_url":"https://api.github.com/repos/tarantool/smtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tarantool/smtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tarantool/smtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tarantool/smtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tarantool/smtp/contents/{+path}","compare_url":"https://api.github.com/repos/tarantool/smtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tarantool/smtp/merges","archive_url":"https://api.github.com/repos/tarantool/smtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tarantool/smtp/downloads","issues_url":"https://api.github.com/repos/tarantool/smtp/issues{/number}","pulls_url":"https://api.github.com/repos/tarantool/smtp/pulls{/number}","milestones_url":"https://api.github.com/repos/tarantool/smtp/milestones{/number}","notifications_url":"https://api.github.com/repos/tarantool/smtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tarantool/smtp/labels{/name}","releases_url":"https://api.github.com/repos/tarantool/smtp/releases{/id}","deployments_url":"https://api.github.com/repos/tarantool/smtp/deployments","created_at":"2017-10-06T14:46:30Z","updated_at":"2018-02-05T12:23:44Z","pushed_at":"2018-02-06T14:00:57Z","git_url":"git://github.com/tarantool/smtp.git","ssh_url":"git@github.com:tarantool/smtp.git","clone_url":"https://github.com/tarantool/smtp.git","svn_url":"https://github.com/tarantool/smtp","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tarantool/smtp/pulls/5"},"html":{"href":"https://github.com/tarantool/smtp/pull/5"},"issue":{"href":"https://api.github.com/repos/tarantool/smtp/issues/5"},"comments":{"href":"https://api.github.com/repos/tarantool/smtp/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/tarantool/smtp/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/tarantool/smtp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tarantool/smtp/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/tarantool/smtp/statuses/bf45f23c005e4de0f49cf322b9c8f1265f044930"}},"author_association":"NONE"}}
{"actor":{"display_login":"Totktonada"}}