{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/185868742","pull_request_review_id":117345539,"id":185868742,"diff_hunk":"@@ -0,0 +1,109 @@\n+/*******************************************************************************\n+ * Copyright (c) 2018 IBM Corporation and others.\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ *\n+ * Contributors:\n+ *     IBM Corporation - initial API and implementation\n+ *******************************************************************************/\n+package com.ibm.ws.microprofile.faulttolerance.metrics.integration;\n+\n+import static org.osgi.service.component.annotations.ConfigurationPolicy.IGNORE;\n+\n+import java.lang.reflect.Method;\n+import java.security.AccessController;\n+import java.util.Map;\n+import java.util.WeakHashMap;\n+import java.util.concurrent.locks.ReentrantReadWriteLock;\n+\n+import org.eclipse.microprofile.config.Config;\n+import org.eclipse.microprofile.config.ConfigProvider;\n+import org.eclipse.microprofile.metrics.MetricRegistry;\n+import org.osgi.service.component.annotations.Component;\n+import org.osgi.service.component.annotations.Reference;\n+\n+import com.ibm.ws.kernel.service.util.SecureAction;\n+import com.ibm.ws.microprofile.faulttolerance.spi.BulkheadPolicy;\n+import com.ibm.ws.microprofile.faulttolerance.spi.CircuitBreakerPolicy;\n+import com.ibm.ws.microprofile.faulttolerance.spi.FallbackPolicy;\n+import com.ibm.ws.microprofile.faulttolerance.spi.MetricRecorder;\n+import com.ibm.ws.microprofile.faulttolerance.spi.MetricRecorderProvider;\n+import com.ibm.ws.microprofile.faulttolerance.spi.RetryPolicy;\n+import com.ibm.ws.microprofile.faulttolerance.spi.TimeoutPolicy;\n+import com.ibm.ws.microprofile.faulttolerance.utils.DummyMetricRecorder;\n+import com.ibm.ws.microprofile.metrics.impl.SharedMetricRegistries;\n+\n+@Component(name = \"com.ibm.ws.microprofile.faulttolerance.metrics.integration.MetricRecorderProviderImpl\", service = MetricRecorderProvider.class, configurationPolicy = IGNORE)\n+public class MetricRecorderProviderImpl implements MetricRecorderProvider {","path":"dev/com.ibm.ws.microprofile.faulttolerance.metrics/src/com/ibm/ws/microprofile/faulttolerance/metrics/integration/MetricRecorderProviderImpl.java","position":39,"original_position":39,"commit_id":"1033f948628f96e821d2beb41b90ed31bb728cce","original_commit_id":"1033f948628f96e821d2beb41b90ed31bb728cce","user":{"login":"tevans78","id":22099681,"avatar_url":"https://avatars1.githubusercontent.com/u/22099681?v=4","gravatar_id":"","url":"https://api.github.com/users/tevans78","html_url":"https://github.com/tevans78","followers_url":"https://api.github.com/users/tevans78/followers","following_url":"https://api.github.com/users/tevans78/following{/other_user}","gists_url":"https://api.github.com/users/tevans78/gists{/gist_id}","starred_url":"https://api.github.com/users/tevans78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tevans78/subscriptions","organizations_url":"https://api.github.com/users/tevans78/orgs","repos_url":"https://api.github.com/users/tevans78/repos","events_url":"https://api.github.com/users/tevans78/events{/privacy}","received_events_url":"https://api.github.com/users/tevans78/received_events","type":"User","site_admin":false},"body":"All methods should be `@Trivial`","created_at":"2018-05-03T16:53:54Z","updated_at":"2018-05-03T16:53:54Z","html_url":"https://github.com/OpenLiberty/open-liberty/pull/3419#discussion_r185868742","pull_request_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments/185868742"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3419#discussion_r185868742"},"pull_request":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419","id":185772664,"html_url":"https://github.com/OpenLiberty/open-liberty/pull/3419","diff_url":"https://github.com/OpenLiberty/open-liberty/pull/3419.diff","patch_url":"https://github.com/OpenLiberty/open-liberty/pull/3419.patch","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3419","number":3419,"state":"open","locked":false,"title":"Add Fault Tolerance - Metrics integration","user":{"login":"Azquelt","id":2011102,"avatar_url":"https://avatars3.githubusercontent.com/u/2011102?v=4","gravatar_id":"","url":"https://api.github.com/users/Azquelt","html_url":"https://github.com/Azquelt","followers_url":"https://api.github.com/users/Azquelt/followers","following_url":"https://api.github.com/users/Azquelt/following{/other_user}","gists_url":"https://api.github.com/users/Azquelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Azquelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azquelt/subscriptions","organizations_url":"https://api.github.com/users/Azquelt/orgs","repos_url":"https://api.github.com/users/Azquelt/repos","events_url":"https://api.github.com/users/Azquelt/events{/privacy}","received_events_url":"https://api.github.com/users/Azquelt/received_events","type":"User","site_admin":false},"body":"When mpMetrics-1.1 and mpFaultTolerance-1.1 are used together, metrics\r\nare automatically reported when methods are annotated with Fault\r\nTolerance annotations.\r\n\r\nFor #3019 ","created_at":"2018-05-03T16:33:21Z","updated_at":"2018-05-03T16:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"752bbda638aabb1ba541d81f3bdf925df823828f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706052599,"url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3419/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/1033f948628f96e821d2beb41b90ed31bb728cce","head":{"label":"Azquelt:ft-metrics-integration","ref":"ft-metrics-integration","sha":"1033f948628f96e821d2beb41b90ed31bb728cce","user":{"login":"Azquelt","id":2011102,"avatar_url":"https://avatars3.githubusercontent.com/u/2011102?v=4","gravatar_id":"","url":"https://api.github.com/users/Azquelt","html_url":"https://github.com/Azquelt","followers_url":"https://api.github.com/users/Azquelt/followers","following_url":"https://api.github.com/users/Azquelt/following{/other_user}","gists_url":"https://api.github.com/users/Azquelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Azquelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azquelt/subscriptions","organizations_url":"https://api.github.com/users/Azquelt/orgs","repos_url":"https://api.github.com/users/Azquelt/repos","events_url":"https://api.github.com/users/Azquelt/events{/privacy}","received_events_url":"https://api.github.com/users/Azquelt/received_events","type":"User","site_admin":false},"repo":{"id":103992480,"name":"open-liberty","full_name":"Azquelt/open-liberty","owner":{"login":"Azquelt","id":2011102,"avatar_url":"https://avatars3.githubusercontent.com/u/2011102?v=4","gravatar_id":"","url":"https://api.github.com/users/Azquelt","html_url":"https://github.com/Azquelt","followers_url":"https://api.github.com/users/Azquelt/followers","following_url":"https://api.github.com/users/Azquelt/following{/other_user}","gists_url":"https://api.github.com/users/Azquelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Azquelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azquelt/subscriptions","organizations_url":"https://api.github.com/users/Azquelt/orgs","repos_url":"https://api.github.com/users/Azquelt/repos","events_url":"https://api.github.com/users/Azquelt/events{/privacy}","received_events_url":"https://api.github.com/users/Azquelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Azquelt/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":true,"url":"https://api.github.com/repos/Azquelt/open-liberty","forks_url":"https://api.github.com/repos/Azquelt/open-liberty/forks","keys_url":"https://api.github.com/repos/Azquelt/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azquelt/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azquelt/open-liberty/teams","hooks_url":"https://api.github.com/repos/Azquelt/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/Azquelt/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/Azquelt/open-liberty/events","assignees_url":"https://api.github.com/repos/Azquelt/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/Azquelt/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/Azquelt/open-liberty/tags","blobs_url":"https://api.github.com/repos/Azquelt/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azquelt/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azquelt/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azquelt/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azquelt/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/Azquelt/open-liberty/languages","stargazers_url":"https://api.github.com/repos/Azquelt/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/Azquelt/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/Azquelt/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/Azquelt/open-liberty/subscription","commits_url":"https://api.github.com/repos/Azquelt/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azquelt/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azquelt/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azquelt/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azquelt/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/Azquelt/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azquelt/open-liberty/merges","archive_url":"https://api.github.com/repos/Azquelt/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azquelt/open-liberty/downloads","issues_url":"https://api.github.com/repos/Azquelt/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/Azquelt/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/Azquelt/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/Azquelt/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azquelt/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/Azquelt/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/Azquelt/open-liberty/deployments","created_at":"2017-09-18T21:12:26Z","updated_at":"2017-09-18T21:13:23Z","pushed_at":"2018-05-03T16:29:52Z","git_url":"git://github.com/Azquelt/open-liberty.git","ssh_url":"git@github.com:Azquelt/open-liberty.git","clone_url":"https://github.com/Azquelt/open-liberty.git","svn_url":"https://github.com/Azquelt/open-liberty","homepage":"http://openliberty.io","size":128990,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"OpenLiberty:integration","ref":"integration","sha":"c1f122811db70196ce52d1dbf21213950d98ca7b","user":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":103694377,"name":"open-liberty","full_name":"OpenLiberty/open-liberty","owner":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLiberty/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":false,"url":"https://api.github.com/repos/OpenLiberty/open-liberty","forks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/forks","keys_url":"https://api.github.com/repos/OpenLiberty/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/open-liberty/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/events","assignees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/open-liberty/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/open-liberty/merges","archive_url":"https://api.github.com/repos/OpenLiberty/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/open-liberty/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/deployments","created_at":"2017-09-15T19:34:25Z","updated_at":"2018-05-03T14:52:58Z","pushed_at":"2018-05-03T16:33:22Z","git_url":"git://github.com/OpenLiberty/open-liberty.git","ssh_url":"git@github.com:OpenLiberty/open-liberty.git","clone_url":"https://github.com/OpenLiberty/open-liberty.git","svn_url":"https://github.com/OpenLiberty/open-liberty","homepage":"http://openliberty.io","size":130436,"stargazers_count":289,"watchers_count":289,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":465,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":229,"open_issues":465,"watchers":289,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3419"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3419"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3419/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3419/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/1033f948628f96e821d2beb41b90ed31bb728cce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tevans78"}}