{"action":"created","issue":{"url":"https://api.github.com/repos/clawpack/riemann_book/issues/168","repository_url":"https://api.github.com/repos/clawpack/riemann_book","labels_url":"https://api.github.com/repos/clawpack/riemann_book/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/clawpack/riemann_book/issues/168/comments","events_url":"https://api.github.com/repos/clawpack/riemann_book/issues/168/events","html_url":"https://github.com/clawpack/riemann_book/pull/168","id":374692215,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzI2Mjkw","number":168,"title":"Some wording and spacing changes in Burgers.ipynb","user":{"login":"rjleveque","id":720122,"node_id":"MDQ6VXNlcjcyMDEyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/720122?v=4","gravatar_id":"","url":"https://api.github.com/users/rjleveque","html_url":"https://github.com/rjleveque","followers_url":"https://api.github.com/users/rjleveque/followers","following_url":"https://api.github.com/users/rjleveque/following{/other_user}","gists_url":"https://api.github.com/users/rjleveque/gists{/gist_id}","starred_url":"https://api.github.com/users/rjleveque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjleveque/subscriptions","organizations_url":"https://api.github.com/users/rjleveque/orgs","repos_url":"https://api.github.com/users/rjleveque/repos","events_url":"https://api.github.com/users/rjleveque/events{/privacy}","received_events_url":"https://api.github.com/users/rjleveque/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-27T21:47:46Z","updated_at":"2018-10-29T09:54:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/clawpack/riemann_book/pulls/168","html_url":"https://github.com/clawpack/riemann_book/pull/168","diff_url":"https://github.com/clawpack/riemann_book/pull/168.diff","patch_url":"https://github.com/clawpack/riemann_book/pull/168.patch"},"body":"I really like the interacts in this notebook!\r\n\r\nI wonder in this and other notebooks whether we plan to put the blocks of code setting things up at the top, or after the introductory material for the chapter?  I thought we had decided on the latter, e.g. as in `Nonconvex_scalar.ipynb`, but in the `Burgers.ipynb` and some others it cIomes first.\r\n\r\nI replaced `Eq. \\ref{eq:Burgersintclaw}` with `(\\ref{eq:Burgersintclaw})` to be consistent with what is done some other places, although I see we also use `\\eqref{eq:...}` some places, which seems to give a spurious period before the equation number (e.g. in `Acoustics.ipynb` both the above forms are used in different places).\r\n\r\nI made a few other suggested changes to wording in this PR and removed some white space from `interact(...` commands that were too wide for my window.\r\n\r\nI'm happy with this notebook!"},"comment":{"url":"https://api.github.com/repos/clawpack/riemann_book/issues/comments/433849820","html_url":"https://github.com/clawpack/riemann_book/pull/168#issuecomment-433849820","issue_url":"https://api.github.com/repos/clawpack/riemann_book/issues/168","id":433849820,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzg0OTgyMA==","user":{"login":"maojrs","id":5036733,"node_id":"MDQ6VXNlcjUwMzY3MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5036733?v=4","gravatar_id":"","url":"https://api.github.com/users/maojrs","html_url":"https://github.com/maojrs","followers_url":"https://api.github.com/users/maojrs/followers","following_url":"https://api.github.com/users/maojrs/following{/other_user}","gists_url":"https://api.github.com/users/maojrs/gists{/gist_id}","starred_url":"https://api.github.com/users/maojrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maojrs/subscriptions","organizations_url":"https://api.github.com/users/maojrs/orgs","repos_url":"https://api.github.com/users/maojrs/repos","events_url":"https://api.github.com/users/maojrs/events{/privacy}","received_events_url":"https://api.github.com/users/maojrs/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T09:54:07Z","updated_at":"2018-10-29T09:54:07Z","author_association":"CONTRIBUTOR","body":"I don't have the problem with the additional dots when using eqref, though I guess we can stick to /ref to avoid any problems. If so, I will take a pass to the acoustics notebooks and make sure all the equation references are /ref instead of /eqref and that they have parentheses.\r\n\r\nRegarding the setup code, if we are thinking of the printed version, maybe it is better after the intro, so it is not the first thing it is shown. However this cells are hidden in the printed version right? In that case, I agree with David that it is better to have it before. I'll comment more on #172."}}
{"actor":{"display_login":"maojrs"}}