{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/comments/225281054","pull_request_review_id":164850589,"id":225281054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTI4MTA1NA==","diff_hunk":"@@ -107,7 +107,14 @@ func (dn *Daemon) Run(stop <-chan struct{}) error {\n \t\tglog.Errorf(\"Marking degraded due to: %v\", err)\n \t\treturn setUpdateDegraded(dn.kubeClient.CoreV1().Nodes(), dn.name)\n \t} else if state == MachineConfigDaemonStateDegraded {\n-\t\treturn fmt.Errorf(\"Node is degraded; exiting loudly...\")\n+\t\t// just sleep so that we don't clobber output of previous run which\n+\t\t// probably contains the real reason why we marked the node as degraded\n+\t\t// in the first place\n+\t\tglog.Info(\"Node is degraded; going to sleep\")\n+\t\tselect {","path":"pkg/daemon/daemon.go","position":9,"original_position":9,"commit_id":"85deb83152da405576717fa4f177d07684a94e70","original_commit_id":"85deb83152da405576717fa4f177d07684a94e70","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"body":"Yup, that's correct!","created_at":"2018-10-15T19:01:43Z","updated_at":"2018-10-15T19:01:43Z","html_url":"https://github.com/openshift/machine-config-operator/pull/129#discussion_r225281054","pull_request_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/comments/225281054"},"html":{"href":"https://github.com/openshift/machine-config-operator/pull/129#discussion_r225281054"},"pull_request":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129"}},"in_reply_to_id":225279435},"pull_request":{"url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129","id":223006538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDA2NTM4","html_url":"https://github.com/openshift/machine-config-operator/pull/129","diff_url":"https://github.com/openshift/machine-config-operator/pull/129.diff","patch_url":"https://github.com/openshift/machine-config-operator/pull/129.patch","issue_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/129","number":129,"state":"open","locked":false,"title":"daemon: just sit quietly if node is degraded","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"body":"An issue with immediately exiting if the node is degraded is that we\r\nthen clobber the logs of the previous MCD containers, which means that\r\nthe logs from the MCD instance that actually set the node to degraded is\r\nlost in the ether.\r\n\r\nLet's just block on `poll()` so we don't exit and don't waste any CPU\r\nresources. The stop channel here isn't actually being written/closed by\r\nany other goroutine so this just sits there.\r\n\r\nSee also #127.","created_at":"2018-10-15T18:50:40Z","updated_at":"2018-10-15T19:01:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f82385dcfad7807f93a124e112664817eb163fe2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdemos","id":2341268,"node_id":"MDQ6VXNlcjIzNDEyNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2341268?v=4","gravatar_id":"","url":"https://api.github.com/users/sdemos","html_url":"https://github.com/sdemos","followers_url":"https://api.github.com/users/sdemos/followers","following_url":"https://api.github.com/users/sdemos/following{/other_user}","gists_url":"https://api.github.com/users/sdemos/gists{/gist_id}","starred_url":"https://api.github.com/users/sdemos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdemos/subscriptions","organizations_url":"https://api.github.com/users/sdemos/orgs","repos_url":"https://api.github.com/users/sdemos/repos","events_url":"https://api.github.com/users/sdemos/events{/privacy}","received_events_url":"https://api.github.com/users/sdemos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1005850192,"node_id":"MDU6TGFiZWwxMDA1ODUwMTky","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1005851688,"node_id":"MDU6TGFiZWwxMDA1ODUxNjg4","url":"https://api.github.com/repos/openshift/machine-config-operator/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129/commits","review_comments_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129/comments","review_comment_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/129/comments","statuses_url":"https://api.github.com/repos/openshift/machine-config-operator/statuses/85deb83152da405576717fa4f177d07684a94e70","head":{"label":"jlebon:pr/block-on-stop","ref":"pr/block-on-stop","sha":"85deb83152da405576717fa4f177d07684a94e70","user":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"repo":{"id":143338111,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMzgxMTE=","name":"machine-config-operator","full_name":"jlebon/machine-config-operator","private":false,"owner":{"login":"jlebon","id":11934099,"node_id":"MDQ6VXNlcjExOTM0MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jlebon/machine-config-operator","description":null,"fork":true,"url":"https://api.github.com/repos/jlebon/machine-config-operator","forks_url":"https://api.github.com/repos/jlebon/machine-config-operator/forks","keys_url":"https://api.github.com/repos/jlebon/machine-config-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlebon/machine-config-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlebon/machine-config-operator/teams","hooks_url":"https://api.github.com/repos/jlebon/machine-config-operator/hooks","issue_events_url":"https://api.github.com/repos/jlebon/machine-config-operator/issues/events{/number}","events_url":"https://api.github.com/repos/jlebon/machine-config-operator/events","assignees_url":"https://api.github.com/repos/jlebon/machine-config-operator/assignees{/user}","branches_url":"https://api.github.com/repos/jlebon/machine-config-operator/branches{/branch}","tags_url":"https://api.github.com/repos/jlebon/machine-config-operator/tags","blobs_url":"https://api.github.com/repos/jlebon/machine-config-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlebon/machine-config-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlebon/machine-config-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlebon/machine-config-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlebon/machine-config-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/jlebon/machine-config-operator/languages","stargazers_url":"https://api.github.com/repos/jlebon/machine-config-operator/stargazers","contributors_url":"https://api.github.com/repos/jlebon/machine-config-operator/contributors","subscribers_url":"https://api.github.com/repos/jlebon/machine-config-operator/subscribers","subscription_url":"https://api.github.com/repos/jlebon/machine-config-operator/subscription","commits_url":"https://api.github.com/repos/jlebon/machine-config-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlebon/machine-config-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlebon/machine-config-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlebon/machine-config-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlebon/machine-config-operator/contents/{+path}","compare_url":"https://api.github.com/repos/jlebon/machine-config-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlebon/machine-config-operator/merges","archive_url":"https://api.github.com/repos/jlebon/machine-config-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlebon/machine-config-operator/downloads","issues_url":"https://api.github.com/repos/jlebon/machine-config-operator/issues{/number}","pulls_url":"https://api.github.com/repos/jlebon/machine-config-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/jlebon/machine-config-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/jlebon/machine-config-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlebon/machine-config-operator/labels{/name}","releases_url":"https://api.github.com/repos/jlebon/machine-config-operator/releases{/id}","deployments_url":"https://api.github.com/repos/jlebon/machine-config-operator/deployments","created_at":"2018-08-02T19:43:53Z","updated_at":"2018-08-02T19:43:56Z","pushed_at":"2018-10-15T18:51:24Z","git_url":"git://github.com/jlebon/machine-config-operator.git","ssh_url":"git@github.com:jlebon/machine-config-operator.git","clone_url":"https://github.com/jlebon/machine-config-operator.git","svn_url":"https://github.com/jlebon/machine-config-operator","homepage":null,"size":5373,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"481e4f1c3baea6c7b4258031997bb6f16272f066","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":142336347,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzYzNDc=","name":"machine-config-operator","full_name":"openshift/machine-config-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/machine-config-operator","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/machine-config-operator","forks_url":"https://api.github.com/repos/openshift/machine-config-operator/forks","keys_url":"https://api.github.com/repos/openshift/machine-config-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/machine-config-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/machine-config-operator/teams","hooks_url":"https://api.github.com/repos/openshift/machine-config-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/machine-config-operator/events","assignees_url":"https://api.github.com/repos/openshift/machine-config-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/machine-config-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/machine-config-operator/tags","blobs_url":"https://api.github.com/repos/openshift/machine-config-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/machine-config-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/machine-config-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/machine-config-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/machine-config-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/machine-config-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/machine-config-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/machine-config-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/machine-config-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/machine-config-operator/subscription","commits_url":"https://api.github.com/repos/openshift/machine-config-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/machine-config-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/machine-config-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/machine-config-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/machine-config-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/machine-config-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/machine-config-operator/merges","archive_url":"https://api.github.com/repos/openshift/machine-config-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/machine-config-operator/downloads","issues_url":"https://api.github.com/repos/openshift/machine-config-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/machine-config-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/machine-config-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/machine-config-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/machine-config-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/machine-config-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/machine-config-operator/deployments","created_at":"2018-07-25T18:04:26Z","updated_at":"2018-10-15T14:54:49Z","pushed_at":"2018-10-15T18:51:25Z","git_url":"git://github.com/openshift/machine-config-operator.git","ssh_url":"git@github.com:openshift/machine-config-operator.git","clone_url":"https://github.com/openshift/machine-config-operator.git","svn_url":"https://github.com/openshift/machine-config-operator","homepage":null,"size":5373,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":16,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129"},"html":{"href":"https://github.com/openshift/machine-config-operator/pull/129"},"issue":{"href":"https://api.github.com/repos/openshift/machine-config-operator/issues/129"},"comments":{"href":"https://api.github.com/repos/openshift/machine-config-operator/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/machine-config-operator/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/machine-config-operator/statuses/85deb83152da405576717fa4f177d07684a94e70"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlebon"}}