{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/225721876","pull_request_review_id":165385107,"id":225721876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTcyMTg3Ng==","diff_hunk":"@@ -0,0 +1,88 @@\n+package cmd","path":"mixer/tools/mixgen/cmd/main_go.go","position":1,"original_position":1,"commit_id":"71a9c8bdc4b0e8e8ba81e1c59dcf430a18d38e23","original_commit_id":"71a9c8bdc4b0e8e8ba81e1c59dcf430a18d38e23","user":{"login":"bianpengyuan","id":34738376,"node_id":"MDQ6VXNlcjM0NzM4Mzc2","avatar_url":"https://avatars2.githubusercontent.com/u/34738376?v=4","gravatar_id":"","url":"https://api.github.com/users/bianpengyuan","html_url":"https://github.com/bianpengyuan","followers_url":"https://api.github.com/users/bianpengyuan/followers","following_url":"https://api.github.com/users/bianpengyuan/following{/other_user}","gists_url":"https://api.github.com/users/bianpengyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/bianpengyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bianpengyuan/subscriptions","organizations_url":"https://api.github.com/users/bianpengyuan/orgs","repos_url":"https://api.github.com/users/bianpengyuan/repos","events_url":"https://api.github.com/users/bianpengyuan/events{/privacy}","received_events_url":"https://api.github.com/users/bianpengyuan/received_events","type":"User","site_admin":false},"body":"Reviewers: this file contains template for main.go.","created_at":"2018-10-16T21:56:50Z","updated_at":"2018-10-16T21:56:51Z","html_url":"https://github.com/istio/istio/pull/9362#discussion_r225721876","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/9362","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/225721876"},"html":{"href":"https://github.com/istio/istio/pull/9362#discussion_r225721876"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/9362"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/9362","id":223408775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDA4Nzc1","html_url":"https://github.com/istio/istio/pull/9362","diff_url":"https://github.com/istio/istio/pull/9362.diff","patch_url":"https://github.com/istio/istio/pull/9362.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/9362","number":9362,"state":"open","locked":false,"title":"[WIP] Codegen for oop adapter nosession server","user":{"login":"bianpengyuan","id":34738376,"node_id":"MDQ6VXNlcjM0NzM4Mzc2","avatar_url":"https://avatars2.githubusercontent.com/u/34738376?v=4","gravatar_id":"","url":"https://api.github.com/users/bianpengyuan","html_url":"https://github.com/bianpengyuan","followers_url":"https://api.github.com/users/bianpengyuan/followers","following_url":"https://api.github.com/users/bianpengyuan/following{/other_user}","gists_url":"https://api.github.com/users/bianpengyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/bianpengyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bianpengyuan/subscriptions","organizations_url":"https://api.github.com/users/bianpengyuan/orgs","repos_url":"https://api.github.com/users/bianpengyuan/repos","events_url":"https://api.github.com/users/bianpengyuan/events{/privacy}","received_events_url":"https://api.github.com/users/bianpengyuan/received_events","type":"User","site_admin":false},"body":"Mixer codegen for oop adapter nosession server. This PR is in progress and I need to refine comment and add test for it. I am hoping to get some early feedback to make sure that this PR make sense and should proceed. This codegen could be used to generate server code for existing adapters, and for other OOT adapters as well as long as some certain assumption is met (for example, adapter config message has to be named as Params, which is the only assumption right now). Most code in this PR is generated and I will mark out the ones containing codegen logic.\r\n\r\nRight now we only have nosession client implemented in mixer. We can include session based server as well as auth options in generated code once we have that.\r\n\r\n","created_at":"2018-10-16T21:55:24Z","updated_at":"2018-10-16T21:56:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bafeff81c3a77955516956445e949955d7f7a4e1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mandarjog","id":800375,"node_id":"MDQ6VXNlcjgwMDM3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},{"login":"geeknoid","id":22780957,"node_id":"MDQ6VXNlcjIyNzgwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":957605109,"node_id":"MDU6TGFiZWw5NTc2MDUxMDk=","url":"https://api.github.com/repos/istio/istio/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/9362/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/9362/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/9362/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/71a9c8bdc4b0e8e8ba81e1c59dcf430a18d38e23","head":{"label":"bianpengyuan:oop-server","ref":"oop-server","sha":"71a9c8bdc4b0e8e8ba81e1c59dcf430a18d38e23","user":{"login":"bianpengyuan","id":34738376,"node_id":"MDQ6VXNlcjM0NzM4Mzc2","avatar_url":"https://avatars2.githubusercontent.com/u/34738376?v=4","gravatar_id":"","url":"https://api.github.com/users/bianpengyuan","html_url":"https://github.com/bianpengyuan","followers_url":"https://api.github.com/users/bianpengyuan/followers","following_url":"https://api.github.com/users/bianpengyuan/following{/other_user}","gists_url":"https://api.github.com/users/bianpengyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/bianpengyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bianpengyuan/subscriptions","organizations_url":"https://api.github.com/users/bianpengyuan/orgs","repos_url":"https://api.github.com/users/bianpengyuan/repos","events_url":"https://api.github.com/users/bianpengyuan/events{/privacy}","received_events_url":"https://api.github.com/users/bianpengyuan/received_events","type":"User","site_admin":false},"repo":{"id":120412640,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA0MTI2NDA=","name":"istio","full_name":"bianpengyuan/istio","private":false,"owner":{"login":"bianpengyuan","id":34738376,"node_id":"MDQ6VXNlcjM0NzM4Mzc2","avatar_url":"https://avatars2.githubusercontent.com/u/34738376?v=4","gravatar_id":"","url":"https://api.github.com/users/bianpengyuan","html_url":"https://github.com/bianpengyuan","followers_url":"https://api.github.com/users/bianpengyuan/followers","following_url":"https://api.github.com/users/bianpengyuan/following{/other_user}","gists_url":"https://api.github.com/users/bianpengyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/bianpengyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bianpengyuan/subscriptions","organizations_url":"https://api.github.com/users/bianpengyuan/orgs","repos_url":"https://api.github.com/users/bianpengyuan/repos","events_url":"https://api.github.com/users/bianpengyuan/events{/privacy}","received_events_url":"https://api.github.com/users/bianpengyuan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bianpengyuan/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/bianpengyuan/istio","forks_url":"https://api.github.com/repos/bianpengyuan/istio/forks","keys_url":"https://api.github.com/repos/bianpengyuan/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bianpengyuan/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bianpengyuan/istio/teams","hooks_url":"https://api.github.com/repos/bianpengyuan/istio/hooks","issue_events_url":"https://api.github.com/repos/bianpengyuan/istio/issues/events{/number}","events_url":"https://api.github.com/repos/bianpengyuan/istio/events","assignees_url":"https://api.github.com/repos/bianpengyuan/istio/assignees{/user}","branches_url":"https://api.github.com/repos/bianpengyuan/istio/branches{/branch}","tags_url":"https://api.github.com/repos/bianpengyuan/istio/tags","blobs_url":"https://api.github.com/repos/bianpengyuan/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bianpengyuan/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bianpengyuan/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/bianpengyuan/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bianpengyuan/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/bianpengyuan/istio/languages","stargazers_url":"https://api.github.com/repos/bianpengyuan/istio/stargazers","contributors_url":"https://api.github.com/repos/bianpengyuan/istio/contributors","subscribers_url":"https://api.github.com/repos/bianpengyuan/istio/subscribers","subscription_url":"https://api.github.com/repos/bianpengyuan/istio/subscription","commits_url":"https://api.github.com/repos/bianpengyuan/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/bianpengyuan/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/bianpengyuan/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/bianpengyuan/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/bianpengyuan/istio/contents/{+path}","compare_url":"https://api.github.com/repos/bianpengyuan/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bianpengyuan/istio/merges","archive_url":"https://api.github.com/repos/bianpengyuan/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bianpengyuan/istio/downloads","issues_url":"https://api.github.com/repos/bianpengyuan/istio/issues{/number}","pulls_url":"https://api.github.com/repos/bianpengyuan/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/bianpengyuan/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/bianpengyuan/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bianpengyuan/istio/labels{/name}","releases_url":"https://api.github.com/repos/bianpengyuan/istio/releases{/id}","deployments_url":"https://api.github.com/repos/bianpengyuan/istio/deployments","created_at":"2018-02-06T06:36:33Z","updated_at":"2018-08-16T22:44:49Z","pushed_at":"2018-10-16T21:52:17Z","git_url":"git://github.com/bianpengyuan/istio.git","ssh_url":"git@github.com:bianpengyuan/istio.git","clone_url":"https://github.com/bianpengyuan/istio.git","svn_url":"https://github.com/bianpengyuan/istio","homepage":"https://istio.io","size":59118,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"64a46ebdd9eec1e805a9800e09e687c0968a4462","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-10-16T20:30:07Z","pushed_at":"2018-10-16T21:55:25Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":50964,"stargazers_count":12418,"watchers_count":12418,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1833,"mirror_url":null,"archived":false,"open_issues_count":987,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1833,"open_issues":987,"watchers":12418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/9362"},"html":{"href":"https://github.com/istio/istio/pull/9362"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/9362"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/9362/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/9362/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/9362/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/71a9c8bdc4b0e8e8ba81e1c59dcf430a18d38e23"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bianpengyuan"}}