{"action":"created","issue":{"url":"https://api.github.com/repos/intel/openlldp/issues/19","repository_url":"https://api.github.com/repos/intel/openlldp","labels_url":"https://api.github.com/repos/intel/openlldp/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/intel/openlldp/issues/19/comments","events_url":"https://api.github.com/repos/intel/openlldp/issues/19/events","html_url":"https://github.com/intel/openlldp/pull/19","id":387418880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTExNDQ5","number":19,"title":"lldp: Allow lldptool to modify optional TLV's content","user":{"login":"imanti","id":3165768,"node_id":"MDQ6VXNlcjMxNjU3Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3165768?v=4","gravatar_id":"","url":"https://api.github.com/users/imanti","html_url":"https://github.com/imanti","followers_url":"https://api.github.com/users/imanti/followers","following_url":"https://api.github.com/users/imanti/following{/other_user}","gists_url":"https://api.github.com/users/imanti/gists{/gist_id}","starred_url":"https://api.github.com/users/imanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imanti/subscriptions","organizations_url":"https://api.github.com/users/imanti/orgs","repos_url":"https://api.github.com/users/imanti/repos","events_url":"https://api.github.com/users/imanti/events{/privacy}","received_events_url":"https://api.github.com/users/imanti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"praeluceo","id":335284,"node_id":"MDQ6VXNlcjMzNTI4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/335284?v=4","gravatar_id":"","url":"https://api.github.com/users/praeluceo","html_url":"https://github.com/praeluceo","followers_url":"https://api.github.com/users/praeluceo/followers","following_url":"https://api.github.com/users/praeluceo/following{/other_user}","gists_url":"https://api.github.com/users/praeluceo/gists{/gist_id}","starred_url":"https://api.github.com/users/praeluceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praeluceo/subscriptions","organizations_url":"https://api.github.com/users/praeluceo/orgs","repos_url":"https://api.github.com/users/praeluceo/repos","events_url":"https://api.github.com/users/praeluceo/events{/privacy}","received_events_url":"https://api.github.com/users/praeluceo/received_events","type":"User","site_admin":false},"assignees":[{"login":"praeluceo","id":335284,"node_id":"MDQ6VXNlcjMzNTI4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/335284?v=4","gravatar_id":"","url":"https://api.github.com/users/praeluceo","html_url":"https://github.com/praeluceo","followers_url":"https://api.github.com/users/praeluceo/followers","following_url":"https://api.github.com/users/praeluceo/following{/other_user}","gists_url":"https://api.github.com/users/praeluceo/gists{/gist_id}","starred_url":"https://api.github.com/users/praeluceo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praeluceo/subscriptions","organizations_url":"https://api.github.com/users/praeluceo/orgs","repos_url":"https://api.github.com/users/praeluceo/repos","events_url":"https://api.github.com/users/praeluceo/events{/privacy}","received_events_url":"https://api.github.com/users/praeluceo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-04T18:21:41Z","updated_at":"2018-12-10T17:23:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/intel/openlldp/pulls/19","html_url":"https://github.com/intel/openlldp/pull/19","diff_url":"https://github.com/intel/openlldp/pull/19.diff","patch_url":"https://github.com/intel/openlldp/pull/19.patch"},"body":"Add functions [get, set, test]_arg_info in lldp_basman_cmds.c to\r\nallow users to get or set the value of optional lldp TLVs.\r\n\r\nOptional tlvs are (lldptool tlv name inside brackets):\r\n\r\n[portDesc] Port description\r\n[sysName] System name\r\n[sysDesc] System description\r\n[sysCap] System capabilities\r\n[mngAddr] Management address\r\n\r\nThe format to modify a TLV content is:\r\n\tlldptool -i <ifname> -T -V sysDesc info=\"New Value\""},"comment":{"url":"https://api.github.com/repos/intel/openlldp/issues/comments/445898581","html_url":"https://github.com/intel/openlldp/pull/19#issuecomment-445898581","issue_url":"https://api.github.com/repos/intel/openlldp/issues/19","id":445898581,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTg5ODU4MQ==","user":{"login":"imanti","id":3165768,"node_id":"MDQ6VXNlcjMxNjU3Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3165768?v=4","gravatar_id":"","url":"https://api.github.com/users/imanti","html_url":"https://github.com/imanti","followers_url":"https://api.github.com/users/imanti/followers","following_url":"https://api.github.com/users/imanti/following{/other_user}","gists_url":"https://api.github.com/users/imanti/gists{/gist_id}","starred_url":"https://api.github.com/users/imanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imanti/subscriptions","organizations_url":"https://api.github.com/users/imanti/orgs","repos_url":"https://api.github.com/users/imanti/repos","events_url":"https://api.github.com/users/imanti/events{/privacy}","received_events_url":"https://api.github.com/users/imanti/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T17:23:18Z","updated_at":"2018-12-10T17:23:18Z","author_association":"CONTRIBUTOR","body":"Ronald, sorry for the delay!\r\n\r\nThe validation that I do with the info string is unnecessary because libconfig will store it as a string (enclosed by quotes) so there is no need to delete any character. This would mean that the extra variable and mallco() are not needed.\r\n\r\nIf it works for you, let me close this PR and create a new branch/PR without this validation."}}
{"actor":{"display_login":"imanti"}}