{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/28327","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/28327/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/28327/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/28327/events","html_url":"https://github.com/dotnet/roslyn/pull/28327","id":338868918,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjkyNDcy","number":28327,"title":"VB: Added support for line continuation comments","user":{"login":"paul1956","id":12789369,"node_id":"MDQ6VXNlcjEyNzg5MzY5","avatar_url":"https://avatars1.githubusercontent.com/u/12789369?v=4","gravatar_id":"","url":"https://api.github.com/users/paul1956","html_url":"https://github.com/paul1956","followers_url":"https://api.github.com/users/paul1956/followers","following_url":"https://api.github.com/users/paul1956/following{/other_user}","gists_url":"https://api.github.com/users/paul1956/gists{/gist_id}","starred_url":"https://api.github.com/users/paul1956/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul1956/subscriptions","organizations_url":"https://api.github.com/users/paul1956/orgs","repos_url":"https://api.github.com/users/paul1956/repos","events_url":"https://api.github.com/users/paul1956/events{/privacy}","received_events_url":"https://api.github.com/users/paul1956/received_events","type":"User","site_admin":false},"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":288147422,"node_id":"MDU6TGFiZWwyODgxNDc0MjI=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false},{"id":166377961,"node_id":"MDU6TGFiZWwxNjYzNzc5NjE=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Language-VB","name":"Language-VB","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"node_id":"MDQ6VXNlcjEyNDY2MjMz","avatar_url":"https://avatars2.githubusercontent.com/u/12466233?v=4","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/18","html_url":"https://github.com/dotnet/roslyn/milestone/18","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/18/labels","id":1675130,"node_id":"MDk6TWlsZXN0b25lMTY3NTEzMA==","number":18,"title":"16.0","description":"The version *after* the next major version.","creator":{"login":"gafter","id":3804346,"node_id":"MDQ6VXNlcjM4MDQzNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3804346?v=4","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"open_issues":1191,"closed_issues":561,"state":"open","created_at":"2016-03-31T00:06:25Z","updated_at":"2018-08-28T18:33:10Z","due_on":null,"closed_at":null},"comments":56,"created_at":"2018-07-06T09:26:45Z","updated_at":"2018-08-28T19:12:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/28327","html_url":"https://github.com/dotnet/roslyn/pull/28327","diff_url":"https://github.com/dotnet/roslyn/pull/28327.diff","patch_url":"https://github.com/dotnet/roslyn/pull/28327.patch"},"body":"<details><summary>Ask Mode template not completed</summary>\r\n\r\n<!-- This template is not always required. If you aren't sure about whether it's needed or want help filling out the sections,\r\nsubmit the pull request and then ask us for help. :) -->\r\n\r\n### Customer scenario\r\n\r\nIt is very useful to place comments in more places and specifically after a explicate continuation character, for example after an Attribute or before a period \r\n\r\n### Bugs this fixes\r\nNone, new feature\r\n(either VSO or GitHub links)\r\n\r\n### Workarounds, if any\r\nPut comments farther away from the code they refer to.\r\n### Risk\r\nThe change involves a very small change to the scanner, a update to test that currently fail when a comment is after an _ plus 2 new tests. The code looks for a very specific pattern of \"_ '\" or it never gets used.\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n### Performance impact\r\nI added one extra if statement, when there is an explicate line continuation so impact will be small.\r\n\r\n### Is this a regression from a previous update?\r\nno\r\n### Root cause analysis\r\nThis is a new feature but much of the infrastructure anticipated this feature and it is unclear to me why it was left out. \r\nHow did we miss it?  What tests are we adding to guard against it in the future?\r\nIt was not missed, some decided to not support this feature.\r\n### How was the bug found?\r\nNot a but, a new feature\r\n\r\n### Test documentation updated?\r\n\r\nIf this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.\r\n\r\nIt might be good to update some of the error messages that currently say this is not allowed to say how to use the feature. For Example \"_'\" is an error that could say use \"_ '\"\r\n\r\n</details>\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/416706415","html_url":"https://github.com/dotnet/roslyn/pull/28327#issuecomment-416706415","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/28327","id":416706415,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjcwNjQxNQ==","user":{"login":"AlekseyTs","id":10522107,"node_id":"MDQ6VXNlcjEwNTIyMTA3","avatar_url":"https://avatars0.githubusercontent.com/u/10522107?v=4","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T19:12:17Z","updated_at":"2018-08-28T19:12:17Z","author_association":"CONTRIBUTOR","body":"It feels like we are lacking tests that assert the shape of the trivia that end up with. It would also be good to add some tests for scenarios when there is no line break after the comment."}}
{"actor":{"display_login":"AlekseyTs"}}