{"action":"opened","number":2517,"pull_request":{"url":"https://api.github.com/repos/ParabolInc/action/pulls/2517","id":234844370,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODQ0Mzcw","html_url":"https://github.com/ParabolInc/action/pull/2517","diff_url":"https://github.com/ParabolInc/action/pull/2517.diff","patch_url":"https://github.com/ParabolInc/action/pull/2517.patch","issue_url":"https://api.github.com/repos/ParabolInc/action/issues/2517","number":2517,"state":"open","locked":false,"title":"Fix remove provider","user":{"login":"mattkrick","id":5514175,"node_id":"MDQ6VXNlcjU1MTQxNzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5514175?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkrick","html_url":"https://github.com/mattkrick","followers_url":"https://api.github.com/users/mattkrick/followers","following_url":"https://api.github.com/users/mattkrick/following{/other_user}","gists_url":"https://api.github.com/users/mattkrick/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkrick/subscriptions","organizations_url":"https://api.github.com/users/mattkrick/orgs","repos_url":"https://api.github.com/users/mattkrick/repos","events_url":"https://api.github.com/users/mattkrick/events{/privacy}","received_events_url":"https://api.github.com/users/mattkrick/received_events","type":"User","site_admin":false},"body":"After hotfixing the add provider issue i noticed we have a bug with removing providers (requires refresh to update). This has been a longstanding bug, but wasn't in the backlog. Refactored both add/remove to a modern hybrid pattern. will eventually get to the rest as time allows, but i'm not concerned with them for now.\r\n\r\nAlso fixes:\r\n- [ ] bug where additional subscriptions were ignored when moving around the app\r\n- [ ] _very_ minor security bug where we implicitly trusted GH/Slack too much\r\n\r\n\r\nTEST\r\n- [ ] can add provider (GH, Slack)\r\n- [ ] can remove provider\r\n","created_at":"2018-11-30T01:38:58Z","updated_at":"2018-11-30T01:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ParabolInc/action/pulls/2517/commits","review_comments_url":"https://api.github.com/repos/ParabolInc/action/pulls/2517/comments","review_comment_url":"https://api.github.com/repos/ParabolInc/action/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParabolInc/action/issues/2517/comments","statuses_url":"https://api.github.com/repos/ParabolInc/action/statuses/f89496eeba4063e8e15ac4f7ffd5fedc4f63b99b","head":{"label":"ParabolInc:fix-remove-provider","ref":"fix-remove-provider","sha":"f89496eeba4063e8e15ac4f7ffd5fedc4f63b99b","user":{"login":"ParabolInc","id":14169569,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY5NTY5","avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48384473,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM4NDQ3Mw==","name":"action","full_name":"ParabolInc/action","private":false,"owner":{"login":"ParabolInc","id":14169569,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY5NTY5","avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ParabolInc/action","description":"Free online agile retrospective meeting tool","fork":false,"url":"https://api.github.com/repos/ParabolInc/action","forks_url":"https://api.github.com/repos/ParabolInc/action/forks","keys_url":"https://api.github.com/repos/ParabolInc/action/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParabolInc/action/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParabolInc/action/teams","hooks_url":"https://api.github.com/repos/ParabolInc/action/hooks","issue_events_url":"https://api.github.com/repos/ParabolInc/action/issues/events{/number}","events_url":"https://api.github.com/repos/ParabolInc/action/events","assignees_url":"https://api.github.com/repos/ParabolInc/action/assignees{/user}","branches_url":"https://api.github.com/repos/ParabolInc/action/branches{/branch}","tags_url":"https://api.github.com/repos/ParabolInc/action/tags","blobs_url":"https://api.github.com/repos/ParabolInc/action/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParabolInc/action/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParabolInc/action/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParabolInc/action/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParabolInc/action/statuses/{sha}","languages_url":"https://api.github.com/repos/ParabolInc/action/languages","stargazers_url":"https://api.github.com/repos/ParabolInc/action/stargazers","contributors_url":"https://api.github.com/repos/ParabolInc/action/contributors","subscribers_url":"https://api.github.com/repos/ParabolInc/action/subscribers","subscription_url":"https://api.github.com/repos/ParabolInc/action/subscription","commits_url":"https://api.github.com/repos/ParabolInc/action/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParabolInc/action/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParabolInc/action/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParabolInc/action/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParabolInc/action/contents/{+path}","compare_url":"https://api.github.com/repos/ParabolInc/action/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParabolInc/action/merges","archive_url":"https://api.github.com/repos/ParabolInc/action/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParabolInc/action/downloads","issues_url":"https://api.github.com/repos/ParabolInc/action/issues{/number}","pulls_url":"https://api.github.com/repos/ParabolInc/action/pulls{/number}","milestones_url":"https://api.github.com/repos/ParabolInc/action/milestones{/number}","notifications_url":"https://api.github.com/repos/ParabolInc/action/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParabolInc/action/labels{/name}","releases_url":"https://api.github.com/repos/ParabolInc/action/releases{/id}","deployments_url":"https://api.github.com/repos/ParabolInc/action/deployments","created_at":"2015-12-21T17:16:49Z","updated_at":"2018-11-29T20:04:46Z","pushed_at":"2018-11-30T01:33:32Z","git_url":"git://github.com/ParabolInc/action.git","ssh_url":"git@github.com:ParabolInc/action.git","clone_url":"https://github.com/ParabolInc/action.git","svn_url":"https://github.com/ParabolInc/action","homepage":"http://parabol.co/","size":45163,"stargazers_count":642,"watchers_count":642,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":112,"open_issues":143,"watchers":642,"default_branch":"master"}},"base":{"label":"ParabolInc:master","ref":"master","sha":"8c27238b0b26b68db7310d45776913e6cad92f00","user":{"login":"ParabolInc","id":14169569,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY5NTY5","avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48384473,"node_id":"MDEwOlJlcG9zaXRvcnk0ODM4NDQ3Mw==","name":"action","full_name":"ParabolInc/action","private":false,"owner":{"login":"ParabolInc","id":14169569,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY5NTY5","avatar_url":"https://avatars1.githubusercontent.com/u/14169569?v=4","gravatar_id":"","url":"https://api.github.com/users/ParabolInc","html_url":"https://github.com/ParabolInc","followers_url":"https://api.github.com/users/ParabolInc/followers","following_url":"https://api.github.com/users/ParabolInc/following{/other_user}","gists_url":"https://api.github.com/users/ParabolInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ParabolInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParabolInc/subscriptions","organizations_url":"https://api.github.com/users/ParabolInc/orgs","repos_url":"https://api.github.com/users/ParabolInc/repos","events_url":"https://api.github.com/users/ParabolInc/events{/privacy}","received_events_url":"https://api.github.com/users/ParabolInc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ParabolInc/action","description":"Free online agile retrospective meeting tool","fork":false,"url":"https://api.github.com/repos/ParabolInc/action","forks_url":"https://api.github.com/repos/ParabolInc/action/forks","keys_url":"https://api.github.com/repos/ParabolInc/action/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParabolInc/action/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParabolInc/action/teams","hooks_url":"https://api.github.com/repos/ParabolInc/action/hooks","issue_events_url":"https://api.github.com/repos/ParabolInc/action/issues/events{/number}","events_url":"https://api.github.com/repos/ParabolInc/action/events","assignees_url":"https://api.github.com/repos/ParabolInc/action/assignees{/user}","branches_url":"https://api.github.com/repos/ParabolInc/action/branches{/branch}","tags_url":"https://api.github.com/repos/ParabolInc/action/tags","blobs_url":"https://api.github.com/repos/ParabolInc/action/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParabolInc/action/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParabolInc/action/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParabolInc/action/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParabolInc/action/statuses/{sha}","languages_url":"https://api.github.com/repos/ParabolInc/action/languages","stargazers_url":"https://api.github.com/repos/ParabolInc/action/stargazers","contributors_url":"https://api.github.com/repos/ParabolInc/action/contributors","subscribers_url":"https://api.github.com/repos/ParabolInc/action/subscribers","subscription_url":"https://api.github.com/repos/ParabolInc/action/subscription","commits_url":"https://api.github.com/repos/ParabolInc/action/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParabolInc/action/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParabolInc/action/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParabolInc/action/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParabolInc/action/contents/{+path}","compare_url":"https://api.github.com/repos/ParabolInc/action/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParabolInc/action/merges","archive_url":"https://api.github.com/repos/ParabolInc/action/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParabolInc/action/downloads","issues_url":"https://api.github.com/repos/ParabolInc/action/issues{/number}","pulls_url":"https://api.github.com/repos/ParabolInc/action/pulls{/number}","milestones_url":"https://api.github.com/repos/ParabolInc/action/milestones{/number}","notifications_url":"https://api.github.com/repos/ParabolInc/action/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParabolInc/action/labels{/name}","releases_url":"https://api.github.com/repos/ParabolInc/action/releases{/id}","deployments_url":"https://api.github.com/repos/ParabolInc/action/deployments","created_at":"2015-12-21T17:16:49Z","updated_at":"2018-11-29T20:04:46Z","pushed_at":"2018-11-30T01:33:32Z","git_url":"git://github.com/ParabolInc/action.git","ssh_url":"git@github.com:ParabolInc/action.git","clone_url":"https://github.com/ParabolInc/action.git","svn_url":"https://github.com/ParabolInc/action","homepage":"http://parabol.co/","size":45163,"stargazers_count":642,"watchers_count":642,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":112,"open_issues":143,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/2517"},"html":{"href":"https://github.com/ParabolInc/action/pull/2517"},"issue":{"href":"https://api.github.com/repos/ParabolInc/action/issues/2517"},"comments":{"href":"https://api.github.com/repos/ParabolInc/action/issues/2517/comments"},"review_comments":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/2517/comments"},"review_comment":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParabolInc/action/pulls/2517/commits"},"statuses":{"href":"https://api.github.com/repos/ParabolInc/action/statuses/f89496eeba4063e8e15ac4f7ffd5fedc4f63b99b"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":564,"deletions":529,"changed_files":39}}
{"actor":{"display_login":"mattkrick"}}