{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9383","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9383/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9383/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9383/events","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9383","id":345109089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzQyODY4","number":9383,"title":"Fix reduction exclude special feature","user":{"login":"kpodemski","id":2137763,"node_id":"MDQ6VXNlcjIxMzc3NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2137763?v=4","gravatar_id":"","url":"https://api.github.com/users/kpodemski","html_url":"https://github.com/kpodemski","followers_url":"https://api.github.com/users/kpodemski/followers","following_url":"https://api.github.com/users/kpodemski/following{/other_user}","gists_url":"https://api.github.com/users/kpodemski/gists{/gist_id}","starred_url":"https://api.github.com/users/kpodemski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpodemski/subscriptions","organizations_url":"https://api.github.com/users/kpodemski/orgs","repos_url":"https://api.github.com/users/kpodemski/repos","events_url":"https://api.github.com/users/kpodemski/events{/privacy}","received_events_url":"https://api.github.com/users/kpodemski/received_events","type":"User","site_admin":false},"labels":[{"id":19737369,"node_id":"MDU6TGFiZWwxOTczNzM2OQ==","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Bug","name":"Bug","color":"d4c5f9","default":false},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-27T06:42:57Z","updated_at":"2018-08-03T17:30:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9383","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9383","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/9383.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/9383.patch"},"body":"<!-- Thank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information: -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | before this fix you can use voucher on cart containing products with reduction even tho back-office option is checked to \"yes\" for excluding this scenario\r\n| Type?         | bug fix\r\n| Category?     | CO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed ticket? | i guess\r\n| How to test?  | Instruction below\r\n\r\n1. Add two products, for 100 EUR, one with 10% discount.\r\n2. Add these two products to cart, you should have two products in cart for a total amount of 180 EUR, (100 + 80)\r\n3. Add voucher for an order without shipping, 10%, exclude special products.\r\n4. Result? Order is worth 162 EUR which shouldn't be a case as this coupon shouldn't be valid\r\n5. Apply fix\r\n6. Test again\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/9383)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/410323241","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9383#issuecomment-410323241","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9383","id":410323241,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDMyMzI0MQ==","user":{"login":"kpodemski","id":2137763,"node_id":"MDQ6VXNlcjIxMzc3NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2137763?v=4","gravatar_id":"","url":"https://api.github.com/users/kpodemski","html_url":"https://github.com/kpodemski","followers_url":"https://api.github.com/users/kpodemski/followers","following_url":"https://api.github.com/users/kpodemski/following{/other_user}","gists_url":"https://api.github.com/users/kpodemski/gists{/gist_id}","starred_url":"https://api.github.com/users/kpodemski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpodemski/subscriptions","organizations_url":"https://api.github.com/users/kpodemski/orgs","repos_url":"https://api.github.com/users/kpodemski/repos","events_url":"https://api.github.com/users/kpodemski/events{/privacy}","received_events_url":"https://api.github.com/users/kpodemski/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T17:30:58Z","updated_at":"2018-08-03T17:30:58Z","author_association":"CONTRIBUTOR","body":"I'm all in for writing tests, just make proper documentation of how to make them, or - because most of developers know how to do that - best practices or something like that, just to follow some standard methods\r\n\r\nAbout this bug... it's simple fix which you can say by reading a code, the thing is that people are scared to upgrade from 1.7.X to 1.7.Y, very often people stay on 1.7.X branch and just update 1.7.0.X to 1.7.0.Y, why? because of years of problems with auto upgrade module - and yes, I know, there's a new version and all that... the thing is that even tho auto upgrade module is ok, some things are still not tested manually, for few days we couldn't install 1.7.4 in Polish version because ps_mbo module was badly created :) Now tell all people who tried to upgrade to 1.7.4 with all these problems to try again with 1.7.5 just to fix one important bug which saves them money :)"}}
{"actor":{"display_login":"kpodemski"}}