{"action":"created","comment":{"url":"https://api.github.com/repos/improbable-eng/thanos/pulls/comments/244963454","pull_request_review_id":188965332,"id":244963454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk2MzQ1NA==","diff_hunk":"@@ -174,17 +182,18 @@ func (q *querier) Select(params *storage.SelectParams, ms ...*labels.Matcher) (s\n \n \tresp := &seriesServer{ctx: ctx}\n \tif err := q.proxy.Series(&storepb.SeriesRequest{\n-\t\tMinTime:             q.mint,\n-\t\tMaxTime:             q.maxt,\n-\t\tMatchers:            sms,\n-\t\tMaxResolutionWindow: q.maxSourceResolution,\n-\t\tAggregates:          queryAggrs,\n+\t\tMinTime:                 q.mint,","path":"pkg/query/querier.go","position":103,"original_position":103,"commit_id":"871d4ad9827130d9ddf838bc7d56378d0241d597","original_commit_id":"2f839487ae43e923d8cf7a73ac64f7f8df05c964","user":{"login":"domgreen","id":156558,"node_id":"MDQ6VXNlcjE1NjU1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/156558?v=4","gravatar_id":"","url":"https://api.github.com/users/domgreen","html_url":"https://github.com/domgreen","followers_url":"https://api.github.com/users/domgreen/followers","following_url":"https://api.github.com/users/domgreen/following{/other_user}","gists_url":"https://api.github.com/users/domgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/domgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domgreen/subscriptions","organizations_url":"https://api.github.com/users/domgreen/orgs","repos_url":"https://api.github.com/users/domgreen/repos","events_url":"https://api.github.com/users/domgreen/events{/privacy}","received_events_url":"https://api.github.com/users/domgreen/received_events","type":"User","site_admin":false},"body":"Was only a nit, think that it was just with so much happening within the `if` statement knocked me off abit","created_at":"2019-01-03T10:47:52Z","updated_at":"2019-01-03T10:47:52Z","html_url":"https://github.com/improbable-eng/thanos/pull/687#discussion_r244963454","pull_request_url":"https://api.github.com/repos/improbable-eng/thanos/pulls/687","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/improbable-eng/thanos/pulls/comments/244963454"},"html":{"href":"https://github.com/improbable-eng/thanos/pull/687#discussion_r244963454"},"pull_request":{"href":"https://api.github.com/repos/improbable-eng/thanos/pulls/687"}},"in_reply_to_id":242631478},"pull_request":{"url":"https://api.github.com/repos/improbable-eng/thanos/pulls/687","id":239212545,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjEyNTQ1","html_url":"https://github.com/improbable-eng/thanos/pull/687","diff_url":"https://github.com/improbable-eng/thanos/pull/687.diff","patch_url":"https://github.com/improbable-eng/thanos/pull/687.patch","issue_url":"https://api.github.com/repos/improbable-eng/thanos/issues/687","number":687,"state":"open","locked":false,"title":"query: Added partial response option to query and store API.","user":{"login":"bwplotka","id":6950331,"node_id":"MDQ6VXNlcjY5NTAzMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6950331?v=4","gravatar_id":"","url":"https://api.github.com/users/bwplotka","html_url":"https://github.com/bwplotka","followers_url":"https://api.github.com/users/bwplotka/followers","following_url":"https://api.github.com/users/bwplotka/following{/other_user}","gists_url":"https://api.github.com/users/bwplotka/gists{/gist_id}","starred_url":"https://api.github.com/users/bwplotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwplotka/subscriptions","organizations_url":"https://api.github.com/users/bwplotka/orgs","repos_url":"https://api.github.com/users/bwplotka/repos","events_url":"https://api.github.com/users/bwplotka/events{/privacy}","received_events_url":"https://api.github.com/users/bwplotka/received_events","type":"User","site_admin":false},"body":"Changes:\r\n- Updated docs\r\n- Added partial response requests option to QueryAPI\r\n- Added comments StoreAPI\r\n- Added tests for Proxy.LabelValues\r\n- Moved Proxy.Series tests to table test.\r\n- Added optional msg passing to testutil.Equal\r\n\r\nFixes https://github.com/improbable-eng/thanos/issues/622\r\nSigned-off-by: Bartek Plotka <bwplotka@gmail.com>\r\n\r\n","created_at":"2018-12-17T16:47:43Z","updated_at":"2019-01-03T10:47:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64cb58c12733413973da85ccf1ce56e685d457d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/improbable-eng/thanos/pulls/687/commits","review_comments_url":"https://api.github.com/repos/improbable-eng/thanos/pulls/687/comments","review_comment_url":"https://api.github.com/repos/improbable-eng/thanos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/improbable-eng/thanos/issues/687/comments","statuses_url":"https://api.github.com/repos/improbable-eng/thanos/statuses/871d4ad9827130d9ddf838bc7d56378d0241d597","head":{"label":"improbable-eng:split-paria-response-part2","ref":"split-paria-response-part2","sha":"871d4ad9827130d9ddf838bc7d56378d0241d597","user":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"repo":{"id":109162639,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNjI2Mzk=","name":"thanos","full_name":"improbable-eng/thanos","private":false,"owner":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/improbable-eng/thanos","description":"Highly available Prometheus setup with long term storage capabilities.","fork":false,"url":"https://api.github.com/repos/improbable-eng/thanos","forks_url":"https://api.github.com/repos/improbable-eng/thanos/forks","keys_url":"https://api.github.com/repos/improbable-eng/thanos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-eng/thanos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-eng/thanos/teams","hooks_url":"https://api.github.com/repos/improbable-eng/thanos/hooks","issue_events_url":"https://api.github.com/repos/improbable-eng/thanos/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-eng/thanos/events","assignees_url":"https://api.github.com/repos/improbable-eng/thanos/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-eng/thanos/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-eng/thanos/tags","blobs_url":"https://api.github.com/repos/improbable-eng/thanos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-eng/thanos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-eng/thanos/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-eng/thanos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-eng/thanos/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-eng/thanos/languages","stargazers_url":"https://api.github.com/repos/improbable-eng/thanos/stargazers","contributors_url":"https://api.github.com/repos/improbable-eng/thanos/contributors","subscribers_url":"https://api.github.com/repos/improbable-eng/thanos/subscribers","subscription_url":"https://api.github.com/repos/improbable-eng/thanos/subscription","commits_url":"https://api.github.com/repos/improbable-eng/thanos/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-eng/thanos/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-eng/thanos/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-eng/thanos/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-eng/thanos/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-eng/thanos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-eng/thanos/merges","archive_url":"https://api.github.com/repos/improbable-eng/thanos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-eng/thanos/downloads","issues_url":"https://api.github.com/repos/improbable-eng/thanos/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-eng/thanos/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-eng/thanos/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-eng/thanos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-eng/thanos/labels{/name}","releases_url":"https://api.github.com/repos/improbable-eng/thanos/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-eng/thanos/deployments","created_at":"2017-11-01T17:38:03Z","updated_at":"2019-01-03T06:36:52Z","pushed_at":"2019-01-03T09:26:46Z","git_url":"git://github.com/improbable-eng/thanos.git","ssh_url":"git@github.com:improbable-eng/thanos.git","clone_url":"https://github.com/improbable-eng/thanos.git","svn_url":"https://github.com/improbable-eng/thanos","homepage":"","size":55617,"stargazers_count":2583,"watchers_count":2583,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":222,"open_issues":117,"watchers":2583,"default_branch":"master"}},"base":{"label":"improbable-eng:master","ref":"master","sha":"cd7963372a11cea93a832584be099d2bfa0ac19a","user":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"repo":{"id":109162639,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNjI2Mzk=","name":"thanos","full_name":"improbable-eng/thanos","private":false,"owner":{"login":"improbable-eng","id":26084283,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MDg0Mjgz","avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/improbable-eng/thanos","description":"Highly available Prometheus setup with long term storage capabilities.","fork":false,"url":"https://api.github.com/repos/improbable-eng/thanos","forks_url":"https://api.github.com/repos/improbable-eng/thanos/forks","keys_url":"https://api.github.com/repos/improbable-eng/thanos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-eng/thanos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-eng/thanos/teams","hooks_url":"https://api.github.com/repos/improbable-eng/thanos/hooks","issue_events_url":"https://api.github.com/repos/improbable-eng/thanos/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-eng/thanos/events","assignees_url":"https://api.github.com/repos/improbable-eng/thanos/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-eng/thanos/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-eng/thanos/tags","blobs_url":"https://api.github.com/repos/improbable-eng/thanos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-eng/thanos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-eng/thanos/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-eng/thanos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-eng/thanos/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-eng/thanos/languages","stargazers_url":"https://api.github.com/repos/improbable-eng/thanos/stargazers","contributors_url":"https://api.github.com/repos/improbable-eng/thanos/contributors","subscribers_url":"https://api.github.com/repos/improbable-eng/thanos/subscribers","subscription_url":"https://api.github.com/repos/improbable-eng/thanos/subscription","commits_url":"https://api.github.com/repos/improbable-eng/thanos/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-eng/thanos/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-eng/thanos/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-eng/thanos/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-eng/thanos/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-eng/thanos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-eng/thanos/merges","archive_url":"https://api.github.com/repos/improbable-eng/thanos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-eng/thanos/downloads","issues_url":"https://api.github.com/repos/improbable-eng/thanos/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-eng/thanos/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-eng/thanos/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-eng/thanos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-eng/thanos/labels{/name}","releases_url":"https://api.github.com/repos/improbable-eng/thanos/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-eng/thanos/deployments","created_at":"2017-11-01T17:38:03Z","updated_at":"2019-01-03T06:36:52Z","pushed_at":"2019-01-03T09:26:46Z","git_url":"git://github.com/improbable-eng/thanos.git","ssh_url":"git@github.com:improbable-eng/thanos.git","clone_url":"https://github.com/improbable-eng/thanos.git","svn_url":"https://github.com/improbable-eng/thanos","homepage":"","size":55617,"stargazers_count":2583,"watchers_count":2583,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":222,"open_issues":117,"watchers":2583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/improbable-eng/thanos/pulls/687"},"html":{"href":"https://github.com/improbable-eng/thanos/pull/687"},"issue":{"href":"https://api.github.com/repos/improbable-eng/thanos/issues/687"},"comments":{"href":"https://api.github.com/repos/improbable-eng/thanos/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/improbable-eng/thanos/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/improbable-eng/thanos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/improbable-eng/thanos/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/improbable-eng/thanos/statuses/871d4ad9827130d9ddf838bc7d56378d0241d597"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"domgreen"}}