{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/system_tests/pulls/comments/205273110","pull_request_review_id":140513204,"id":205273110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTI3MzExMA==","diff_hunk":"@@ -278,8 +278,13 @@ if(BUILD_TESTING)\n       endif()\n     endif()\n \n-    # TODO(mikaelarguedas) only connext and fastrtps support DDS-Security for now\n-    if(rmw_implementation STREQUAL \"rmw_connext_cpp\" OR rmw_implementation STREQUAL \"rmw_fastrtps_cpp\")\n+    # TODO(mikaelarguedas) only Connext and FastRTPS support DDS-Security for now\n+    if(\n+      rmw_implementation STREQUAL \"rmw_connext_cpp\" OR\n+      rmw_implementation STREQUAL \"rmw_connext_dynamic_cpp\" OR","path":"test_security/CMakeLists.txt","position":9,"original_position":9,"commit_id":"978805376a76da897b4a1c806c49db55c0e8cc89","original_commit_id":"978805376a76da897b4a1c806c49db55c0e8cc89","user":{"login":"dirk-thomas","id":1335366,"node_id":"MDQ6VXNlcjEzMzUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Until now the only rmw FastRTPS implementation was dynamic. Since it supported security until now the newly named rmw impl. should do the same (if nothing was broken during the refactoring).","created_at":"2018-07-25T21:48:36Z","updated_at":"2018-07-25T21:48:36Z","html_url":"https://github.com/ros2/system_tests/pull/288#discussion_r205273110","pull_request_url":"https://api.github.com/repos/ros2/system_tests/pulls/288","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros2/system_tests/pulls/comments/205273110"},"html":{"href":"https://github.com/ros2/system_tests/pull/288#discussion_r205273110"},"pull_request":{"href":"https://api.github.com/repos/ros2/system_tests/pulls/288"}},"in_reply_to_id":205269539},"pull_request":{"url":"https://api.github.com/repos/ros2/system_tests/pulls/288","id":203892309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODkyMzA5","html_url":"https://github.com/ros2/system_tests/pull/288","diff_url":"https://github.com/ros2/system_tests/pull/288.diff","patch_url":"https://github.com/ros2/system_tests/pull/288.patch","issue_url":"https://api.github.com/repos/ros2/system_tests/issues/288","number":288,"state":"open","locked":false,"title":"match rmw_fastrtps_dynamic_cpp / rmw_connext_dynamic_cpp","user":{"login":"dirk-thomas","id":1335366,"node_id":"MDQ6VXNlcjEzMzUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Related to ros2/rmw_fastrtps#218.","created_at":"2018-07-25T16:21:16Z","updated_at":"2018-07-25T21:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8d8a73afade6f37242bfe83705c354d08e4efc9","assignee":{"login":"dirk-thomas","id":1335366,"node_id":"MDQ6VXNlcjEzMzUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"assignees":[{"login":"dirk-thomas","id":1335366,"node_id":"MDQ6VXNlcjEzMzUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":222524395,"node_id":"MDU6TGFiZWwyMjI1MjQzOTU=","url":"https://api.github.com/repos/ros2/system_tests/labels/in%20review","name":"in review","color":"388be2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/system_tests/pulls/288/commits","review_comments_url":"https://api.github.com/repos/ros2/system_tests/pulls/288/comments","review_comment_url":"https://api.github.com/repos/ros2/system_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/system_tests/issues/288/comments","statuses_url":"https://api.github.com/repos/ros2/system_tests/statuses/978805376a76da897b4a1c806c49db55c0e8cc89","head":{"label":"ros2:pr203","ref":"pr203","sha":"978805376a76da897b4a1c806c49db55c0e8cc89","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":34927706,"node_id":"MDEwOlJlcG9zaXRvcnkzNDkyNzcwNg==","name":"system_tests","full_name":"ros2/system_tests","owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/system_tests","description":null,"fork":false,"url":"https://api.github.com/repos/ros2/system_tests","forks_url":"https://api.github.com/repos/ros2/system_tests/forks","keys_url":"https://api.github.com/repos/ros2/system_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/system_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/system_tests/teams","hooks_url":"https://api.github.com/repos/ros2/system_tests/hooks","issue_events_url":"https://api.github.com/repos/ros2/system_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/system_tests/events","assignees_url":"https://api.github.com/repos/ros2/system_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/system_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/system_tests/tags","blobs_url":"https://api.github.com/repos/ros2/system_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/system_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/system_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/system_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/system_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/system_tests/languages","stargazers_url":"https://api.github.com/repos/ros2/system_tests/stargazers","contributors_url":"https://api.github.com/repos/ros2/system_tests/contributors","subscribers_url":"https://api.github.com/repos/ros2/system_tests/subscribers","subscription_url":"https://api.github.com/repos/ros2/system_tests/subscription","commits_url":"https://api.github.com/repos/ros2/system_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/system_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/system_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/system_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/system_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/system_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/system_tests/merges","archive_url":"https://api.github.com/repos/ros2/system_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/system_tests/downloads","issues_url":"https://api.github.com/repos/ros2/system_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/system_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/system_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/system_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/system_tests/labels{/name}","releases_url":"https://api.github.com/repos/ros2/system_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/system_tests/deployments","created_at":"2015-05-01T22:50:12Z","updated_at":"2018-07-13T16:13:54Z","pushed_at":"2018-07-25T16:21:16Z","git_url":"git://github.com/ros2/system_tests.git","ssh_url":"git@github.com:ros2/system_tests.git","clone_url":"https://github.com/ros2/system_tests.git","svn_url":"https://github.com/ros2/system_tests","homepage":null,"size":578,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":14,"watchers":6,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"e2875de859489e75501e4994369a92510e3d26d1","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":34927706,"node_id":"MDEwOlJlcG9zaXRvcnkzNDkyNzcwNg==","name":"system_tests","full_name":"ros2/system_tests","owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/system_tests","description":null,"fork":false,"url":"https://api.github.com/repos/ros2/system_tests","forks_url":"https://api.github.com/repos/ros2/system_tests/forks","keys_url":"https://api.github.com/repos/ros2/system_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/system_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/system_tests/teams","hooks_url":"https://api.github.com/repos/ros2/system_tests/hooks","issue_events_url":"https://api.github.com/repos/ros2/system_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/system_tests/events","assignees_url":"https://api.github.com/repos/ros2/system_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/system_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/system_tests/tags","blobs_url":"https://api.github.com/repos/ros2/system_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/system_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/system_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/system_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/system_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/system_tests/languages","stargazers_url":"https://api.github.com/repos/ros2/system_tests/stargazers","contributors_url":"https://api.github.com/repos/ros2/system_tests/contributors","subscribers_url":"https://api.github.com/repos/ros2/system_tests/subscribers","subscription_url":"https://api.github.com/repos/ros2/system_tests/subscription","commits_url":"https://api.github.com/repos/ros2/system_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/system_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/system_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/system_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/system_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/system_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/system_tests/merges","archive_url":"https://api.github.com/repos/ros2/system_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/system_tests/downloads","issues_url":"https://api.github.com/repos/ros2/system_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/system_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/system_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/system_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/system_tests/labels{/name}","releases_url":"https://api.github.com/repos/ros2/system_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/system_tests/deployments","created_at":"2015-05-01T22:50:12Z","updated_at":"2018-07-13T16:13:54Z","pushed_at":"2018-07-25T16:21:16Z","git_url":"git://github.com/ros2/system_tests.git","ssh_url":"git@github.com:ros2/system_tests.git","clone_url":"https://github.com/ros2/system_tests.git","svn_url":"https://github.com/ros2/system_tests","homepage":null,"size":578,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":14,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/system_tests/pulls/288"},"html":{"href":"https://github.com/ros2/system_tests/pull/288"},"issue":{"href":"https://api.github.com/repos/ros2/system_tests/issues/288"},"comments":{"href":"https://api.github.com/repos/ros2/system_tests/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/system_tests/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/system_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/system_tests/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/system_tests/statuses/978805376a76da897b4a1c806c49db55c0e8cc89"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dirk-thomas"}}