{"action":"opened","number":1169,"pull_request":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/1169","id":184478646,"html_url":"https://github.com/scummvm/scummvm/pull/1169","diff_url":"https://github.com/scummvm/scummvm/pull/1169.diff","patch_url":"https://github.com/scummvm/scummvm/pull/1169.patch","issue_url":"https://api.github.com/repos/scummvm/scummvm/issues/1169","number":1169,"state":"open","locked":false,"title":"MOHAWK: MYST: Make Dini/Atrus endings an enum","user":{"login":"dafioram","id":5838258,"avatar_url":"https://avatars2.githubusercontent.com/u/5838258?v=4","gravatar_id":"","url":"https://api.github.com/users/dafioram","html_url":"https://github.com/dafioram","followers_url":"https://api.github.com/users/dafioram/followers","following_url":"https://api.github.com/users/dafioram/following{/other_user}","gists_url":"https://api.github.com/users/dafioram/gists{/gist_id}","starred_url":"https://api.github.com/users/dafioram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafioram/subscriptions","organizations_url":"https://api.github.com/users/dafioram/orgs","repos_url":"https://api.github.com/users/dafioram/repos","events_url":"https://api.github.com/users/dafioram/events{/privacy}","received_events_url":"https://api.github.com/users/dafioram/received_events","type":"User","site_admin":false},"body":"The global variable \"ending\" tracks various\r\nstates that Atrus can be in.\r\n\r\nThis variable determines what video of\r\nAtrus will be playing and if the brother\r\nbooks have been destroyed.\r\n\r\nDespite this variable being called ending\r\nthere are other endings not captured by\r\nthis variable (like the brother endings).\r\n\r\nAdditionally, the enum could also be called DiniState. \r\n\r\nI originally had the 4rth enum called kAtrusReturns since that state is also associated with him returning, but because of it usage in places like Myst::toggleVar were the brother book states were being checked it made sense to give it the kBooksDestroyed name. So I could have a 5th enum value that is called kAtrusReturns and just map that to kBooksDestroyed so that when it is more clear to use one form, kAtrusReturns in Dini, and, kBooksDestroyed in the myst library.","created_at":"2018-04-26T22:16:10Z","updated_at":"2018-04-26T22:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scummvm/scummvm/pulls/1169/commits","review_comments_url":"https://api.github.com/repos/scummvm/scummvm/pulls/1169/comments","review_comment_url":"https://api.github.com/repos/scummvm/scummvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scummvm/scummvm/issues/1169/comments","statuses_url":"https://api.github.com/repos/scummvm/scummvm/statuses/150832f0583152b0004de9adce84218704dfb77a","head":{"label":"dafioram:mystEndingEnum","ref":"mystEndingEnum","sha":"150832f0583152b0004de9adce84218704dfb77a","user":{"login":"dafioram","id":5838258,"avatar_url":"https://avatars2.githubusercontent.com/u/5838258?v=4","gravatar_id":"","url":"https://api.github.com/users/dafioram","html_url":"https://github.com/dafioram","followers_url":"https://api.github.com/users/dafioram/followers","following_url":"https://api.github.com/users/dafioram/following{/other_user}","gists_url":"https://api.github.com/users/dafioram/gists{/gist_id}","starred_url":"https://api.github.com/users/dafioram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafioram/subscriptions","organizations_url":"https://api.github.com/users/dafioram/orgs","repos_url":"https://api.github.com/users/dafioram/repos","events_url":"https://api.github.com/users/dafioram/events{/privacy}","received_events_url":"https://api.github.com/users/dafioram/received_events","type":"User","site_admin":false},"repo":{"id":98799327,"name":"scummvm","full_name":"dafioram/scummvm","owner":{"login":"dafioram","id":5838258,"avatar_url":"https://avatars2.githubusercontent.com/u/5838258?v=4","gravatar_id":"","url":"https://api.github.com/users/dafioram","html_url":"https://github.com/dafioram","followers_url":"https://api.github.com/users/dafioram/followers","following_url":"https://api.github.com/users/dafioram/following{/other_user}","gists_url":"https://api.github.com/users/dafioram/gists{/gist_id}","starred_url":"https://api.github.com/users/dafioram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafioram/subscriptions","organizations_url":"https://api.github.com/users/dafioram/orgs","repos_url":"https://api.github.com/users/dafioram/repos","events_url":"https://api.github.com/users/dafioram/events{/privacy}","received_events_url":"https://api.github.com/users/dafioram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dafioram/scummvm","description":"ScummVM main repository","fork":true,"url":"https://api.github.com/repos/dafioram/scummvm","forks_url":"https://api.github.com/repos/dafioram/scummvm/forks","keys_url":"https://api.github.com/repos/dafioram/scummvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dafioram/scummvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dafioram/scummvm/teams","hooks_url":"https://api.github.com/repos/dafioram/scummvm/hooks","issue_events_url":"https://api.github.com/repos/dafioram/scummvm/issues/events{/number}","events_url":"https://api.github.com/repos/dafioram/scummvm/events","assignees_url":"https://api.github.com/repos/dafioram/scummvm/assignees{/user}","branches_url":"https://api.github.com/repos/dafioram/scummvm/branches{/branch}","tags_url":"https://api.github.com/repos/dafioram/scummvm/tags","blobs_url":"https://api.github.com/repos/dafioram/scummvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dafioram/scummvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dafioram/scummvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dafioram/scummvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dafioram/scummvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dafioram/scummvm/languages","stargazers_url":"https://api.github.com/repos/dafioram/scummvm/stargazers","contributors_url":"https://api.github.com/repos/dafioram/scummvm/contributors","subscribers_url":"https://api.github.com/repos/dafioram/scummvm/subscribers","subscription_url":"https://api.github.com/repos/dafioram/scummvm/subscription","commits_url":"https://api.github.com/repos/dafioram/scummvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dafioram/scummvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dafioram/scummvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dafioram/scummvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dafioram/scummvm/contents/{+path}","compare_url":"https://api.github.com/repos/dafioram/scummvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dafioram/scummvm/merges","archive_url":"https://api.github.com/repos/dafioram/scummvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dafioram/scummvm/downloads","issues_url":"https://api.github.com/repos/dafioram/scummvm/issues{/number}","pulls_url":"https://api.github.com/repos/dafioram/scummvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dafioram/scummvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dafioram/scummvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dafioram/scummvm/labels{/name}","releases_url":"https://api.github.com/repos/dafioram/scummvm/releases{/id}","deployments_url":"https://api.github.com/repos/dafioram/scummvm/deployments","created_at":"2017-07-30T13:29:18Z","updated_at":"2017-07-30T13:29:53Z","pushed_at":"2018-04-26T22:09:16Z","git_url":"git://github.com/dafioram/scummvm.git","ssh_url":"git@github.com:dafioram/scummvm.git","clone_url":"https://github.com/dafioram/scummvm.git","svn_url":"https://github.com/dafioram/scummvm","homepage":"http://www.scummvm.org/","size":283567,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scummvm:master","ref":"master","sha":"e1c6d4485ddc2d101ddab6cbc25bdb44535c6c52","user":{"login":"scummvm","id":365181,"avatar_url":"https://avatars3.githubusercontent.com/u/365181?v=4","gravatar_id":"","url":"https://api.github.com/users/scummvm","html_url":"https://github.com/scummvm","followers_url":"https://api.github.com/users/scummvm/followers","following_url":"https://api.github.com/users/scummvm/following{/other_user}","gists_url":"https://api.github.com/users/scummvm/gists{/gist_id}","starred_url":"https://api.github.com/users/scummvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scummvm/subscriptions","organizations_url":"https://api.github.com/users/scummvm/orgs","repos_url":"https://api.github.com/users/scummvm/repos","events_url":"https://api.github.com/users/scummvm/events{/privacy}","received_events_url":"https://api.github.com/users/scummvm/received_events","type":"Organization","site_admin":false},"repo":{"id":1358940,"name":"scummvm","full_name":"scummvm/scummvm","owner":{"login":"scummvm","id":365181,"avatar_url":"https://avatars3.githubusercontent.com/u/365181?v=4","gravatar_id":"","url":"https://api.github.com/users/scummvm","html_url":"https://github.com/scummvm","followers_url":"https://api.github.com/users/scummvm/followers","following_url":"https://api.github.com/users/scummvm/following{/other_user}","gists_url":"https://api.github.com/users/scummvm/gists{/gist_id}","starred_url":"https://api.github.com/users/scummvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scummvm/subscriptions","organizations_url":"https://api.github.com/users/scummvm/orgs","repos_url":"https://api.github.com/users/scummvm/repos","events_url":"https://api.github.com/users/scummvm/events{/privacy}","received_events_url":"https://api.github.com/users/scummvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scummvm/scummvm","description":"ScummVM main repository","fork":false,"url":"https://api.github.com/repos/scummvm/scummvm","forks_url":"https://api.github.com/repos/scummvm/scummvm/forks","keys_url":"https://api.github.com/repos/scummvm/scummvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scummvm/scummvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scummvm/scummvm/teams","hooks_url":"https://api.github.com/repos/scummvm/scummvm/hooks","issue_events_url":"https://api.github.com/repos/scummvm/scummvm/issues/events{/number}","events_url":"https://api.github.com/repos/scummvm/scummvm/events","assignees_url":"https://api.github.com/repos/scummvm/scummvm/assignees{/user}","branches_url":"https://api.github.com/repos/scummvm/scummvm/branches{/branch}","tags_url":"https://api.github.com/repos/scummvm/scummvm/tags","blobs_url":"https://api.github.com/repos/scummvm/scummvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scummvm/scummvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scummvm/scummvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/scummvm/scummvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scummvm/scummvm/statuses/{sha}","languages_url":"https://api.github.com/repos/scummvm/scummvm/languages","stargazers_url":"https://api.github.com/repos/scummvm/scummvm/stargazers","contributors_url":"https://api.github.com/repos/scummvm/scummvm/contributors","subscribers_url":"https://api.github.com/repos/scummvm/scummvm/subscribers","subscription_url":"https://api.github.com/repos/scummvm/scummvm/subscription","commits_url":"https://api.github.com/repos/scummvm/scummvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/scummvm/scummvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/scummvm/scummvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/scummvm/scummvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/scummvm/scummvm/contents/{+path}","compare_url":"https://api.github.com/repos/scummvm/scummvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scummvm/scummvm/merges","archive_url":"https://api.github.com/repos/scummvm/scummvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scummvm/scummvm/downloads","issues_url":"https://api.github.com/repos/scummvm/scummvm/issues{/number}","pulls_url":"https://api.github.com/repos/scummvm/scummvm/pulls{/number}","milestones_url":"https://api.github.com/repos/scummvm/scummvm/milestones{/number}","notifications_url":"https://api.github.com/repos/scummvm/scummvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scummvm/scummvm/labels{/name}","releases_url":"https://api.github.com/repos/scummvm/scummvm/releases{/id}","deployments_url":"https://api.github.com/repos/scummvm/scummvm/deployments","created_at":"2011-02-12T15:50:57Z","updated_at":"2018-04-26T20:15:47Z","pushed_at":"2018-04-26T20:15:42Z","git_url":"git://github.com/scummvm/scummvm.git","ssh_url":"git@github.com:scummvm/scummvm.git","clone_url":"https://github.com/scummvm/scummvm.git","svn_url":"https://github.com/scummvm/scummvm","homepage":"http://www.scummvm.org/","size":282978,"stargazers_count":889,"watchers_count":889,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":433,"open_issues":17,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1169"},"html":{"href":"https://github.com/scummvm/scummvm/pull/1169"},"issue":{"href":"https://api.github.com/repos/scummvm/scummvm/issues/1169"},"comments":{"href":"https://api.github.com/repos/scummvm/scummvm/issues/1169/comments"},"review_comments":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1169/comments"},"review_comment":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1169/commits"},"statuses":{"href":"https://api.github.com/repos/scummvm/scummvm/statuses/150832f0583152b0004de9adce84218704dfb77a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":35,"deletions":26,"changed_files":4}}
{"actor":{"display_login":"dafioram"}}