{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10483","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10483/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10483/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10483/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10483","id":368663990,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzg4MDY1","number":10483,"title":"genrest/menuconfig: Fix crash for promptless choices","user":{"login":"ulfalizer","id":154768,"node_id":"MDQ6VXNlcjE1NDc2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/154768?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfalizer","html_url":"https://github.com/ulfalizer","followers_url":"https://api.github.com/users/ulfalizer/followers","following_url":"https://api.github.com/users/ulfalizer/following{/other_user}","gists_url":"https://api.github.com/users/ulfalizer/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfalizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfalizer/subscriptions","organizations_url":"https://api.github.com/users/ulfalizer/orgs","repos_url":"https://api.github.com/users/ulfalizer/repos","events_url":"https://api.github.com/users/ulfalizer/events{/privacy}","received_events_url":"https://api.github.com/users/ulfalizer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-10T13:23:54Z","updated_at":"2018-10-10T13:52:37Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/10483","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10483","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10483.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10483.patch"},"body":"Update menuconfig (and Kconfiglib, just to sync) to upstream revision\r\n256e5b3e38e92 to get the fix below in, for an issue in an external\r\nproject. Also update genrest.py with a similar fix (the genrest issue\r\nwas what originally prompted it).\r\n\r\n    menuconfig: Improve/fix promptless choice handling\r\n\r\n    The code assumed that all parent (interface) menus always have a\r\n    prompt, which is false for items in promptless choices. This led to\r\n    a crash e.g. when viewing the symbol information for a symbol within\r\n    a promptless choice.\r\n\r\n    Promptless choices with children can show up \"legitimately\" when\r\n    people define choices in multiple locations to add symbols, though\r\n    this is broken in the C tools.\r\n\r\n    Use standard_sc_expr_str(node.item) instead of the non-existing\r\n    prompt for promptless choices. That way they show up as\r\n    '<choice (name if any>)>', which is consistent with how they're\r\n    shown elsewhere.\r\n\r\n    This commit also changes how choice names are displayed in\r\n    show-name/show-all mode, to the standard_sc_expr_str() format.\r\n\r\nSigned-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>"},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/428580169","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/10483#issuecomment-428580169","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/10483","id":428580169,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODU4MDE2OQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T13:52:37Z","updated_at":"2018-10-10T13:52:37Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10483?src=pr&el=h1) Report\n> :exclamation: No coverage uploaded for pull request base (`master@47be332`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10483/graphs/tree.svg?width=650&token=ftaqgO8OOj&height=150&src=pr)](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10483?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             master   #10483   +/-   ##\n=========================================\n  Coverage          ?   53.32%           \n=========================================\n  Files             ?      210           \n  Lines             ?    25818           \n  Branches          ?     5682           \n=========================================\n  Hits              ?    13767           \n  Misses            ?     9740           \n  Partials          ?     2311\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10483?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10483?src=pr&el=footer). Last update [47be332...d166ccb](https://codecov.io/gh/zephyrproject-rtos/zephyr/pull/10483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}