{"action":"created","issue":{"url":"https://api.github.com/repos/onqtam/doctest/issues/143","repository_url":"https://api.github.com/repos/onqtam/doctest","labels_url":"https://api.github.com/repos/onqtam/doctest/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/onqtam/doctest/issues/143/comments","events_url":"https://api.github.com/repos/onqtam/doctest/issues/143/events","html_url":"https://github.com/onqtam/doctest/issues/143","id":351821611,"node_id":"MDU6SXNzdWUzNTE4MjE2MTE=","number":143,"title":"Windows clang-cl Wdeprecated-declarations warnings","user":{"login":"DaanDeMeyer","id":9395011,"node_id":"MDQ6VXNlcjkzOTUwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9395011?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanDeMeyer","html_url":"https://github.com/DaanDeMeyer","followers_url":"https://api.github.com/users/DaanDeMeyer/followers","following_url":"https://api.github.com/users/DaanDeMeyer/following{/other_user}","gists_url":"https://api.github.com/users/DaanDeMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanDeMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanDeMeyer/subscriptions","organizations_url":"https://api.github.com/users/DaanDeMeyer/orgs","repos_url":"https://api.github.com/users/DaanDeMeyer/repos","events_url":"https://api.github.com/users/DaanDeMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/DaanDeMeyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-18T13:45:53Z","updated_at":"2018-08-19T13:52:01Z","closed_at":null,"author_association":"NONE","body":"Compiling doctest with clang-cl (Clang 6.0.1) on Windows results in several Wdeprecated-declarations warnings.\r\n\r\n```\r\n..\\third-party\\doctest\\doctest.h(4205,23):  warning: 'fileno' is deprecated: The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _fileno. See online help for details. [-Wdeprecated-declarations]\r\n            if(isatty(fileno(stdout)) == false && p->force_colors == false)\r\n                      ^\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.16299.0\\ucrt\\stdio.h(2457,28):  note: 'fileno' has been explicitly marked deprecated here\r\n        _Check_return_     _CRT_NONSTDC_DEPRECATE(_fileno)    _ACRTIMP int   __cdecl fileno(_In_ FILE* _Stream);\r\n                           ^\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.16299.0\\ucrt\\corecrt.h(306,50):  note: expanded from macro '_CRT_NONSTDC_DEPRECATE'\r\n        #define _CRT_NONSTDC_DEPRECATE(_NewName) _CRT_DEPRECATE_TEXT(             \\\r\n                                                 ^\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.15.26726\\include\\vcruntime.h(245,47):  note: expanded from macro '_CRT_DEPRECATE_TEXT'\r\n#define _CRT_DEPRECATE_TEXT(_Text) __declspec(deprecated(_Text))\r\n                                              ^\r\nIn file included from ..\\test\\impl.cpp:3:\r\n..\\third-party\\doctest\\doctest.h(4205,16):  warning: 'isatty' is deprecated: The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _isatty. See online help for details. [-Wdeprecated-declarations]\r\n            if(isatty(fileno(stdout)) == false && p->force_colors == false)\r\n               ^\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.16299.0\\ucrt\\corecrt_io.h(490,24):  note: 'isatty' has been explicitly marked deprecated here\r\n        _Check_return_ _CRT_NONSTDC_DEPRECATE(_isatty)\r\n                       ^\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.16299.0\\ucrt\\corecrt.h(306,50):  note: expanded from macro '_CRT_NONSTDC_DEPRECATE'\r\n        #define _CRT_NONSTDC_DEPRECATE(_NewName) _CRT_DEPRECATE_TEXT(             \\\r\n                                                 ^\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.15.26726\\include\\vcruntime.h(245,47):  note: expanded from macro '_CRT_DEPRECATE_TEXT'\r\n#define _CRT_DEPRECATE_TEXT(_Text) __declspec(deprecated(_Text))\r\n                                              ^\r\nIn file included from ..\\test\\impl.cpp:3:\r\n..\\third-party\\doctest\\doctest.h(4895,30):  warning: 'strtok' is deprecated: This function or variable may be unsafe. Consider using strtok_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [-Wdeprecated-declarations]\r\n            char* pch = std::strtok(filtersString.c_str(), \",\"); // modifies the string\r\n                             ^\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.16299.0\\ucrt\\string.h(438,16):  note: 'strtok' has been explicitly marked deprecated here\r\n_Check_return_ _CRT_INSECURE_DEPRECATE(strtok_s)\r\n               ^\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.15.26726\\include\\vcruntime.h(255,55):  note: expanded from macro '_CRT_INSECURE_DEPRECATE'\r\n        #define _CRT_INSECURE_DEPRECATE(_Replacement) _CRT_DEPRECATE_TEXT(    \\\r\n                                                      ^\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.15.26726\\include\\vcruntime.h(245,47):  note: expanded from macro '_CRT_DEPRECATE_TEXT'\r\n#define _CRT_DEPRECATE_TEXT(_Text) __declspec(deprecated(_Text))\r\n                                              ^\r\nIn file included from ..\\test\\impl.cpp:3:\r\n..\\third-party\\doctest\\doctest.h(4901,28):  warning: 'strtok' is deprecated: This function or variable may be unsafe. Consider using strtok_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [-Wdeprecated-declarations]\r\n                pch = std::strtok(0, \",\");\r\n                           ^\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.16299.0\\ucrt\\string.h(438,16):  note: 'strtok' has been explicitly marked deprecated here\r\n_Check_return_ _CRT_INSECURE_DEPRECATE(strtok_s)\r\n               ^\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.15.26726\\include\\vcruntime.h(255,55):  note: expanded from macro '_CRT_INSECURE_DEPRECATE'\r\n        #define _CRT_INSECURE_DEPRECATE(_Replacement) _CRT_DEPRECATE_TEXT(    \\\r\n                                                      ^\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.15.26726\\include\\vcruntime.h(245,47):  note: expanded from macro '_CRT_DEPRECATE_TEXT'\r\n#define _CRT_DEPRECATE_TEXT(_Text) __declspec(deprecated(_Text))\r\n                                              ^\r\n```\r\n\r\n* doctest version: 1.2.9\r\n* Operating System: Windows 10\r\n* Compiler+version: Clang 6.0.1\r\n\r\nCan be reproduced by compiling https://github.com/DaanDeMeyer/reproc on Windows with clang-cl. If the compile output isn't sufficient to solve the warnings I can add more detailed steps to reproduce.\r\n\r\nFrom a quick look at doctest's source I think Wdeprecated-declarations just needs to be added to the list of ignored warnings. "},"comment":{"url":"https://api.github.com/repos/onqtam/doctest/issues/comments/414129285","html_url":"https://github.com/onqtam/doctest/issues/143#issuecomment-414129285","issue_url":"https://api.github.com/repos/onqtam/doctest/issues/143","id":414129285,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDEyOTI4NQ==","user":{"login":"onqtam","id":4648169,"node_id":"MDQ6VXNlcjQ2NDgxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4648169?v=4","gravatar_id":"","url":"https://api.github.com/users/onqtam","html_url":"https://github.com/onqtam","followers_url":"https://api.github.com/users/onqtam/followers","following_url":"https://api.github.com/users/onqtam/following{/other_user}","gists_url":"https://api.github.com/users/onqtam/gists{/gist_id}","starred_url":"https://api.github.com/users/onqtam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onqtam/subscriptions","organizations_url":"https://api.github.com/users/onqtam/orgs","repos_url":"https://api.github.com/users/onqtam/repos","events_url":"https://api.github.com/users/onqtam/events{/privacy}","received_events_url":"https://api.github.com/users/onqtam/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T13:52:01Z","updated_at":"2018-08-19T13:52:01Z","author_association":"OWNER","body":"you can try the header from the dev branch - this should be silenced now"}}
{"actor":{"display_login":"onqtam"}}