{"action":"created","issue":{"url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering/issues/28","repository_url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering","labels_url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering/issues/28/comments","events_url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering/issues/28/events","html_url":"https://github.com/ebruneton/precomputed_atmospheric_scattering/issues/28","id":330790380,"node_id":"MDU6SXNzdWUzMzA3OTAzODA=","number":28,"title":"Is there any reason to start fading out light shaft so early?","user":{"login":"10110111","id":6376882,"node_id":"MDQ6VXNlcjYzNzY4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6376882?v=4","gravatar_id":"","url":"https://api.github.com/users/10110111","html_url":"https://github.com/10110111","followers_url":"https://api.github.com/users/10110111/followers","following_url":"https://api.github.com/users/10110111/following{/other_user}","gists_url":"https://api.github.com/users/10110111/gists{/gist_id}","starred_url":"https://api.github.com/users/10110111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10110111/subscriptions","organizations_url":"https://api.github.com/users/10110111/orgs","repos_url":"https://api.github.com/users/10110111/repos","events_url":"https://api.github.com/users/10110111/events{/privacy}","received_events_url":"https://api.github.com/users/10110111/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-08T20:18:52Z","updated_at":"2018-06-09T09:11:10Z","closed_at":"2018-06-09T09:11:10Z","author_association":"CONTRIBUTOR","body":"Currently, when the Sun is 1° above horizon, the light shaft (and shadow) is already gone. This looks not nice, e.g. when you look at the sphere in the direction of the Sun (the shadowed part): the sphere seems to start glowing for a while until the Sun goes below horizon.\r\n\r\nWith `smoothstep` edges of `-0.026, -0.0035` instead of the current `0.02, 0.04` this looks much better but, when you look how the shadow extends into infinity, it goes into the sky:\r\n\r\n![screenshot](https://user-images.githubusercontent.com/6376882/41178519-0acbfe6a-6b57-11e8-8364-caf0d705585b.jpg)\r\n\r\nI suppose this is normal, given this real-life photo ([source](https://apod.nasa.gov/apod/ap111127.html)):\r\n\r\n<img src=\"https://apod.nasa.gov/apod/image/1111/sts98plume_nasa_1111.jpg\" height=\"400px\" alt=\"real light shaft from smoke after sunset\"><br/>\r\n\r\nOf course, the light shaft in the demo looks a bit wrong due to the lack of penumbra and corresponding too sharp shape. But was this the only reason to avoid extending light shaft into the sky by too early fading out?"},"comment":{"url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering/issues/comments/395953759","html_url":"https://github.com/ebruneton/precomputed_atmospheric_scattering/issues/28#issuecomment-395953759","issue_url":"https://api.github.com/repos/ebruneton/precomputed_atmospheric_scattering/issues/28","id":395953759,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTk1Mzc1OQ==","user":{"login":"10110111","id":6376882,"node_id":"MDQ6VXNlcjYzNzY4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6376882?v=4","gravatar_id":"","url":"https://api.github.com/users/10110111","html_url":"https://github.com/10110111","followers_url":"https://api.github.com/users/10110111/followers","following_url":"https://api.github.com/users/10110111/following{/other_user}","gists_url":"https://api.github.com/users/10110111/gists{/gist_id}","starred_url":"https://api.github.com/users/10110111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/10110111/subscriptions","organizations_url":"https://api.github.com/users/10110111/orgs","repos_url":"https://api.github.com/users/10110111/repos","events_url":"https://api.github.com/users/10110111/events{/privacy}","received_events_url":"https://api.github.com/users/10110111/received_events","type":"User","site_admin":false},"created_at":"2018-06-09T09:11:10Z","updated_at":"2018-06-09T09:11:10Z","author_association":"CONTRIBUTOR","body":"Thanks for clarification."}}
{"actor":{"display_login":"10110111"}}