{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/comments/231010574","pull_request_review_id":171875527,"id":231010574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTAxMDU3NA==","diff_hunk":"@@ -99,12 +101,12 @@ public type ConsumerConfig record {\n \n # Type related to consumer record.\n #\n-# + key - key that is included in the record\n-# + value - record content\n-# + offset - offset value\n-# + partition - partition to which the record is stored\n-# + timestamp - timestamp of the record, in milliseconds since epoch\n-# + topic - topic of the record\n+# + key - Key that is included in the record.","path":"component/src/main/wso2/kafka/consumer.bal","position":100,"original_position":100,"commit_id":"f13ab4e31ac52862be4507a205c5b1b6d165cfa0","original_commit_id":"a3df8d0d2ae022314708b75be8b2ae067f80662c","user":{"login":"pubudu91","id":6260009,"node_id":"MDQ6VXNlcjYyNjAwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6260009?v=4","gravatar_id":"","url":"https://api.github.com/users/pubudu91","html_url":"https://github.com/pubudu91","followers_url":"https://api.github.com/users/pubudu91/followers","following_url":"https://api.github.com/users/pubudu91/following{/other_user}","gists_url":"https://api.github.com/users/pubudu91/gists{/gist_id}","starred_url":"https://api.github.com/users/pubudu91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubudu91/subscriptions","organizations_url":"https://api.github.com/users/pubudu91/orgs","repos_url":"https://api.github.com/users/pubudu91/repos","events_url":"https://api.github.com/users/pubudu91/events{/privacy}","received_events_url":"https://api.github.com/users/pubudu91/received_events","type":"User","site_admin":false},"body":"Again, need to be consistent. Here, the sentences are finished with a period while in the doc block above, that is not the case","created_at":"2018-11-06T06:33:47Z","updated_at":"2018-11-06T06:40:00Z","html_url":"https://github.com/wso2-ballerina/module-kafka/pull/20#discussion_r231010574","pull_request_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/comments/231010574"},"html":{"href":"https://github.com/wso2-ballerina/module-kafka/pull/20#discussion_r231010574"},"pull_request":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20","id":223521822,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTIxODIy","html_url":"https://github.com/wso2-ballerina/module-kafka/pull/20","diff_url":"https://github.com/wso2-ballerina/module-kafka/pull/20.diff","patch_url":"https://github.com/wso2-ballerina/module-kafka/pull/20.patch","issue_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues/20","number":20,"state":"open","locked":false,"title":"Upgrade to Kafka version V2.0.0 and Improve Documentation","user":{"login":"ThisaruGuruge","id":40016057,"node_id":"MDQ6VXNlcjQwMDE2MDU3","avatar_url":"https://avatars0.githubusercontent.com/u/40016057?v=4","gravatar_id":"","url":"https://api.github.com/users/ThisaruGuruge","html_url":"https://github.com/ThisaruGuruge","followers_url":"https://api.github.com/users/ThisaruGuruge/followers","following_url":"https://api.github.com/users/ThisaruGuruge/following{/other_user}","gists_url":"https://api.github.com/users/ThisaruGuruge/gists{/gist_id}","starred_url":"https://api.github.com/users/ThisaruGuruge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThisaruGuruge/subscriptions","organizations_url":"https://api.github.com/users/ThisaruGuruge/orgs","repos_url":"https://api.github.com/users/ThisaruGuruge/repos","events_url":"https://api.github.com/users/ThisaruGuruge/events{/privacy}","received_events_url":"https://api.github.com/users/ThisaruGuruge/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n> Bump Apache Kafka version to 2.0.0 from 1.0.0\r\n> Improve documentation in `Consumer` and the `Producer`\r\n> Add support for Kafka new features.\r\n> Adding two new APIs.\r\n> Fix #21 \r\n\r\n## Release note\r\n> Ballerina Kafka Connector is now supporting to Kafka version 2.0.0. This upgrade is backward compatible, hence brokers with Kafka V1.x will work fine with this upgrade.\r\n> Existing Ballerina APIs aren't changed with the upgrade, except the ones with new default `duration` value, which will not effect older code anyway.\r\n>\r\n> Record type `Offset` is now renamed as `PartitionOffset` to remove ambiguity.\r\n>\r\n> New consumer configuration:\r\n> * `defaultApiTimeout`: This is used as the default value for the APIs which are having default timeout value, to perform. Following are the APIs which are having additional default parameter `duration`:\r\n>   * `SimpleConsumer->close()`\r\n>   * `SimpleConsumer->commitOffset()`\r\n>   * `SimpleConsumer->getBeginningOffsets()`\r\n>   * `SimpleConsumer->getCommittedOffsets()`\r\n>   * `SimpleConsumer->getEndOffsets()`\r\n>   * `SimpleConsumer->getPositionOffset()`\r\n>   * `SimpleConsumer->getTopicPartitions()`\r\n> \r\n> These APIs are now have a default parameter, `duration` which is used as the timeout of these APIs to execute. In the consumer config, there's a value `defaultApiTimeout` which is used as the default value, if user does not provide a duration. It can be overridden using `duration` parameter. If you do not want to provide a duration, simply set the value of configuration `defaultApiTimeout` to a negative int.\r\n>\r\n>\r\n> New APIs:\r\n>\r\n> * `SimpleProducer()->abortTransaction()`\r\n> This API is used to abort an ongoing transaction of a producer. When performed, producer will switch to `READY` state.\r\n>\r\n> * `SimpleProducer->getAvailableTopics()`\r\n> This API is used to retrieve all the available topics for a particular consumer. This will return an array of topics, which the consumer is authorized to subscribe.\r\n\r\n## Documentation\r\n> Updated\r\n\r\n## Security checks\r\n - Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes\r\n - Ran FindSecurityBugs plugin and verified report? yes\r\n - Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes","created_at":"2018-10-17T09:03:43Z","updated_at":"2018-11-06T06:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59be83520a9af7040cd0164e29d14b31d67d1209","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20/commits","review_comments_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20/comments","review_comment_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues/20/comments","statuses_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/statuses/f13ab4e31ac52862be4507a205c5b1b6d165cfa0","head":{"label":"ThisaruGuruge:bump-kafka-version","ref":"bump-kafka-version","sha":"f13ab4e31ac52862be4507a205c5b1b6d165cfa0","user":{"login":"ThisaruGuruge","id":40016057,"node_id":"MDQ6VXNlcjQwMDE2MDU3","avatar_url":"https://avatars0.githubusercontent.com/u/40016057?v=4","gravatar_id":"","url":"https://api.github.com/users/ThisaruGuruge","html_url":"https://github.com/ThisaruGuruge","followers_url":"https://api.github.com/users/ThisaruGuruge/followers","following_url":"https://api.github.com/users/ThisaruGuruge/following{/other_user}","gists_url":"https://api.github.com/users/ThisaruGuruge/gists{/gist_id}","starred_url":"https://api.github.com/users/ThisaruGuruge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThisaruGuruge/subscriptions","organizations_url":"https://api.github.com/users/ThisaruGuruge/orgs","repos_url":"https://api.github.com/users/ThisaruGuruge/repos","events_url":"https://api.github.com/users/ThisaruGuruge/events{/privacy}","received_events_url":"https://api.github.com/users/ThisaruGuruge/received_events","type":"User","site_admin":false},"repo":{"id":149411584,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0MTE1ODQ=","name":"module-kafka","full_name":"ThisaruGuruge/module-kafka","private":false,"owner":{"login":"ThisaruGuruge","id":40016057,"node_id":"MDQ6VXNlcjQwMDE2MDU3","avatar_url":"https://avatars0.githubusercontent.com/u/40016057?v=4","gravatar_id":"","url":"https://api.github.com/users/ThisaruGuruge","html_url":"https://github.com/ThisaruGuruge","followers_url":"https://api.github.com/users/ThisaruGuruge/followers","following_url":"https://api.github.com/users/ThisaruGuruge/following{/other_user}","gists_url":"https://api.github.com/users/ThisaruGuruge/gists{/gist_id}","starred_url":"https://api.github.com/users/ThisaruGuruge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThisaruGuruge/subscriptions","organizations_url":"https://api.github.com/users/ThisaruGuruge/orgs","repos_url":"https://api.github.com/users/ThisaruGuruge/repos","events_url":"https://api.github.com/users/ThisaruGuruge/events{/privacy}","received_events_url":"https://api.github.com/users/ThisaruGuruge/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ThisaruGuruge/module-kafka","description":null,"fork":true,"url":"https://api.github.com/repos/ThisaruGuruge/module-kafka","forks_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/forks","keys_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/teams","hooks_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/hooks","issue_events_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/events","assignees_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/tags","blobs_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/languages","stargazers_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/stargazers","contributors_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/contributors","subscribers_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/subscribers","subscription_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/subscription","commits_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/merges","archive_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/downloads","issues_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/labels{/name}","releases_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ThisaruGuruge/module-kafka/deployments","created_at":"2018-09-19T07:40:01Z","updated_at":"2018-11-06T05:42:20Z","pushed_at":"2018-11-06T06:32:50Z","git_url":"git://github.com/ThisaruGuruge/module-kafka.git","ssh_url":"git@github.com:ThisaruGuruge/module-kafka.git","clone_url":"https://github.com/ThisaruGuruge/module-kafka.git","svn_url":"https://github.com/ThisaruGuruge/module-kafka","homepage":null,"size":456,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-ballerina:master","ref":"master","sha":"b507f54dbea25b50b37b119ea27b9df609547dff","user":{"login":"wso2-ballerina","id":35947277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTQ3Mjc3","avatar_url":"https://avatars0.githubusercontent.com/u/35947277?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-ballerina","html_url":"https://github.com/wso2-ballerina","followers_url":"https://api.github.com/users/wso2-ballerina/followers","following_url":"https://api.github.com/users/wso2-ballerina/following{/other_user}","gists_url":"https://api.github.com/users/wso2-ballerina/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-ballerina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-ballerina/subscriptions","organizations_url":"https://api.github.com/users/wso2-ballerina/orgs","repos_url":"https://api.github.com/users/wso2-ballerina/repos","events_url":"https://api.github.com/users/wso2-ballerina/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-ballerina/received_events","type":"Organization","site_admin":false},"repo":{"id":114849646,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4NDk2NDY=","name":"module-kafka","full_name":"wso2-ballerina/module-kafka","private":false,"owner":{"login":"wso2-ballerina","id":35947277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTQ3Mjc3","avatar_url":"https://avatars0.githubusercontent.com/u/35947277?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-ballerina","html_url":"https://github.com/wso2-ballerina","followers_url":"https://api.github.com/users/wso2-ballerina/followers","following_url":"https://api.github.com/users/wso2-ballerina/following{/other_user}","gists_url":"https://api.github.com/users/wso2-ballerina/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-ballerina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-ballerina/subscriptions","organizations_url":"https://api.github.com/users/wso2-ballerina/orgs","repos_url":"https://api.github.com/users/wso2-ballerina/repos","events_url":"https://api.github.com/users/wso2-ballerina/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-ballerina/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wso2-ballerina/module-kafka","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-ballerina/module-kafka","forks_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/forks","keys_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/teams","hooks_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/hooks","issue_events_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/events","assignees_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/tags","blobs_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/languages","stargazers_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/stargazers","contributors_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/contributors","subscribers_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/subscribers","subscription_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/subscription","commits_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/merges","archive_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/downloads","issues_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/labels{/name}","releases_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-ballerina/module-kafka/deployments","created_at":"2017-12-20T06:08:09Z","updated_at":"2018-11-01T06:47:41Z","pushed_at":"2018-11-06T06:32:52Z","git_url":"git://github.com/wso2-ballerina/module-kafka.git","ssh_url":"git@github.com:wso2-ballerina/module-kafka.git","clone_url":"https://github.com/wso2-ballerina/module-kafka.git","svn_url":"https://github.com/wso2-ballerina/module-kafka","homepage":null,"size":364,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20"},"html":{"href":"https://github.com/wso2-ballerina/module-kafka/pull/20"},"issue":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues/20"},"comments":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-ballerina/module-kafka/statuses/f13ab4e31ac52862be4507a205c5b1b6d165cfa0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pubudu91"}}