{"action":"created","issue":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2912","repository_url":"https://api.github.com/repos/wesnoth/wesnoth","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2912/labels{/name}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2912/comments","events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2912/events","html_url":"https://github.com/wesnoth/wesnoth/issues/2912","id":314896935,"number":2912,"title":"\"Image doesn't fit on canvas\" error in TRoW","user":{"login":"inky17","id":33104698,"avatar_url":"https://avatars2.githubusercontent.com/u/33104698?v=4","gravatar_id":"","url":"https://api.github.com/users/inky17","html_url":"https://github.com/inky17","followers_url":"https://api.github.com/users/inky17/followers","following_url":"https://api.github.com/users/inky17/following{/other_user}","gists_url":"https://api.github.com/users/inky17/gists{/gist_id}","starred_url":"https://api.github.com/users/inky17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inky17/subscriptions","organizations_url":"https://api.github.com/users/inky17/orgs","repos_url":"https://api.github.com/users/inky17/repos","events_url":"https://api.github.com/users/inky17/events{/privacy}","received_events_url":"https://api.github.com/users/inky17/received_events","type":"User","site_admin":false},"labels":[{"id":35865188,"url":"https://api.github.com/repos/wesnoth/wesnoth/labels/Bug","name":"Bug","color":"fc2929","default":false},{"id":597319147,"url":"https://api.github.com/repos/wesnoth/wesnoth/labels/Campaign","name":"Campaign","color":"d455f9","default":false},{"id":595955995,"url":"https://api.github.com/repos/wesnoth/wesnoth/labels/Confirmed","name":"Confirmed","color":"0e8a16","default":false},{"id":597319480,"url":"https://api.github.com/repos/wesnoth/wesnoth/labels/Graphics","name":"Graphics","color":"d455f9","default":false},{"id":862253212,"url":"https://api.github.com/repos/wesnoth/wesnoth/labels/Stable%201.14","name":"Stable 1.14","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-17T04:01:18Z","updated_at":"2018-05-08T17:51:32Z","closed_at":null,"author_association":"NONE","body":"In TRoW Scenario 7 (Return to Oldwood cutscene), the large Rithrandil portrait gives an \"Image doesn't fit on canvas\" error, and then you get sent back to the titlescreen.\r\n\r\n(Wesnoth ver. 1.13.14, Windows 10 fullscreen, running Wesnoth at 1280x720 resolution.)\r\n\r\nIt looks like this issue was discussed in #1272 but that report is ancient so I don't know how relevant it is.\r\nHere's a forum thread where MathBrush had the same issue: https://forums.wesnoth.org/viewtopic.php?f=4&t=47927"},"comment":{"url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments/387486850","html_url":"https://github.com/wesnoth/wesnoth/issues/2912#issuecomment-387486850","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/2912","id":387486850,"user":{"login":"CelticMinstrel","id":578731,"avatar_url":"https://avatars3.githubusercontent.com/u/578731?v=4","gravatar_id":"","url":"https://api.github.com/users/CelticMinstrel","html_url":"https://github.com/CelticMinstrel","followers_url":"https://api.github.com/users/CelticMinstrel/followers","following_url":"https://api.github.com/users/CelticMinstrel/following{/other_user}","gists_url":"https://api.github.com/users/CelticMinstrel/gists{/gist_id}","starred_url":"https://api.github.com/users/CelticMinstrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CelticMinstrel/subscriptions","organizations_url":"https://api.github.com/users/CelticMinstrel/orgs","repos_url":"https://api.github.com/users/CelticMinstrel/repos","events_url":"https://api.github.com/users/CelticMinstrel/events{/privacy}","received_events_url":"https://api.github.com/users/CelticMinstrel/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T17:51:32Z","updated_at":"2018-05-08T17:51:32Z","author_association":"MEMBER","body":"It's kinda a design flaw in the GUI2 framework. If it can't find sufficient space, it gives up and crashes. It's possible to remove the assert instead, but in that case the too-large element will not show up at all.\r\n\r\nMost dialogs solve this by enclosing everything on a scroll panel, which causes all those annoying scroll bars to appear in most similar cases. I guess the message dialog doesn't do this (at least for the portrait).\r\n\r\nThis could likely be fixed by maxing the portrait dimensions either on the C++ or in the dialog or associated widget definitions, thus forcing the portrait to be scaled down if necessary. Maybe something in the image widget could fix this too."}}
{"actor":{"display_login":"CelticMinstrel"}}