{"action":"created","comment":{"url":"https://api.github.com/repos/rnystrom/GitHawk/pulls/comments/169633413","pull_request_review_id":98189148,"id":169633413,"diff_hunk":"@@ -28,16 +28,34 @@ struct GithubClient {\n         let logoutOnAuthFailure: Bool\n         let completion: (DataResponse<Any>, Page?) -> Void\n \n-        init(\n+        static func api(","path":"Classes/Systems/GithubClient.swift","position":18,"original_position":5,"commit_id":"067a3eecd085a1d0103419f7a36fd3b6e7dd073f","original_commit_id":"9d6960c6d7b3b0f39dca892de7ac1c2f66a320d1","user":{"login":"BasThomas","id":4190298,"avatar_url":"https://avatars0.githubusercontent.com/u/4190298?v=4","gravatar_id":"","url":"https://api.github.com/users/BasThomas","html_url":"https://github.com/BasThomas","followers_url":"https://api.github.com/users/BasThomas/followers","following_url":"https://api.github.com/users/BasThomas/following{/other_user}","gists_url":"https://api.github.com/users/BasThomas/gists{/gist_id}","starred_url":"https://api.github.com/users/BasThomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasThomas/subscriptions","organizations_url":"https://api.github.com/users/BasThomas/orgs","repos_url":"https://api.github.com/users/BasThomas/repos","events_url":"https://api.github.com/users/BasThomas/events{/privacy}","received_events_url":"https://api.github.com/users/BasThomas/received_events","type":"User","site_admin":false},"body":"Yep, we have to get rid of this when / if we pull out `Request`. Then we need another way of injecting the baseURL, but good catch regardless.","created_at":"2018-02-21T13:21:35Z","updated_at":"2018-02-21T13:21:35Z","html_url":"https://github.com/rnystrom/GitHawk/pull/1549#discussion_r169633413","pull_request_url":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rnystrom/GitHawk/pulls/comments/169633413"},"html":{"href":"https://github.com/rnystrom/GitHawk/pull/1549#discussion_r169633413"},"pull_request":{"href":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549"}},"in_reply_to_id":169272517},"pull_request":{"url":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549","id":170149628,"html_url":"https://github.com/rnystrom/GitHawk/pull/1549","diff_url":"https://github.com/rnystrom/GitHawk/pull/1549.diff","patch_url":"https://github.com/rnystrom/GitHawk/pull/1549.patch","issue_url":"https://api.github.com/repos/rnystrom/GitHawk/issues/1549","number":1549,"state":"open","locked":false,"title":"Move API stringiness to client","user":{"login":"BasThomas","id":4190298,"avatar_url":"https://avatars0.githubusercontent.com/u/4190298?v=4","gravatar_id":"","url":"https://api.github.com/users/BasThomas","html_url":"https://github.com/BasThomas","followers_url":"https://api.github.com/users/BasThomas/followers","following_url":"https://api.github.com/users/BasThomas/following{/other_user}","gists_url":"https://api.github.com/users/BasThomas/gists{/gist_id}","starred_url":"https://api.github.com/users/BasThomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasThomas/subscriptions","organizations_url":"https://api.github.com/users/BasThomas/orgs","repos_url":"https://api.github.com/users/BasThomas/repos","events_url":"https://api.github.com/users/BasThomas/events{/privacy}","received_events_url":"https://api.github.com/users/BasThomas/received_events","type":"User","site_admin":false},"body":"This moves some String-dependant URLs to the GithubClient, making it easier to support Enterprise at some point.","created_at":"2018-02-20T10:17:08Z","updated_at":"2018-02-21T13:21:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5acb69b37a9eb068fe542a72c542cf390a3963f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549/commits","review_comments_url":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549/comments","review_comment_url":"https://api.github.com/repos/rnystrom/GitHawk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rnystrom/GitHawk/issues/1549/comments","statuses_url":"https://api.github.com/repos/rnystrom/GitHawk/statuses/067a3eecd085a1d0103419f7a36fd3b6e7dd073f","head":{"label":"rnystrom:api-stringyness-in-client","ref":"api-stringyness-in-client","sha":"067a3eecd085a1d0103419f7a36fd3b6e7dd073f","user":{"login":"rnystrom","id":739696,"avatar_url":"https://avatars2.githubusercontent.com/u/739696?v=4","gravatar_id":"","url":"https://api.github.com/users/rnystrom","html_url":"https://github.com/rnystrom","followers_url":"https://api.github.com/users/rnystrom/followers","following_url":"https://api.github.com/users/rnystrom/following{/other_user}","gists_url":"https://api.github.com/users/rnystrom/gists{/gist_id}","starred_url":"https://api.github.com/users/rnystrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnystrom/subscriptions","organizations_url":"https://api.github.com/users/rnystrom/orgs","repos_url":"https://api.github.com/users/rnystrom/repos","events_url":"https://api.github.com/users/rnystrom/events{/privacy}","received_events_url":"https://api.github.com/users/rnystrom/received_events","type":"User","site_admin":false},"repo":{"id":89921801,"name":"GitHawk","full_name":"rnystrom/GitHawk","owner":{"login":"rnystrom","id":739696,"avatar_url":"https://avatars2.githubusercontent.com/u/739696?v=4","gravatar_id":"","url":"https://api.github.com/users/rnystrom","html_url":"https://github.com/rnystrom","followers_url":"https://api.github.com/users/rnystrom/followers","following_url":"https://api.github.com/users/rnystrom/following{/other_user}","gists_url":"https://api.github.com/users/rnystrom/gists{/gist_id}","starred_url":"https://api.github.com/users/rnystrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnystrom/subscriptions","organizations_url":"https://api.github.com/users/rnystrom/orgs","repos_url":"https://api.github.com/users/rnystrom/repos","events_url":"https://api.github.com/users/rnystrom/events{/privacy}","received_events_url":"https://api.github.com/users/rnystrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rnystrom/GitHawk","description":"A GitHub project manager app for iOS.","fork":false,"url":"https://api.github.com/repos/rnystrom/GitHawk","forks_url":"https://api.github.com/repos/rnystrom/GitHawk/forks","keys_url":"https://api.github.com/repos/rnystrom/GitHawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rnystrom/GitHawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rnystrom/GitHawk/teams","hooks_url":"https://api.github.com/repos/rnystrom/GitHawk/hooks","issue_events_url":"https://api.github.com/repos/rnystrom/GitHawk/issues/events{/number}","events_url":"https://api.github.com/repos/rnystrom/GitHawk/events","assignees_url":"https://api.github.com/repos/rnystrom/GitHawk/assignees{/user}","branches_url":"https://api.github.com/repos/rnystrom/GitHawk/branches{/branch}","tags_url":"https://api.github.com/repos/rnystrom/GitHawk/tags","blobs_url":"https://api.github.com/repos/rnystrom/GitHawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rnystrom/GitHawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rnystrom/GitHawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rnystrom/GitHawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rnystrom/GitHawk/statuses/{sha}","languages_url":"https://api.github.com/repos/rnystrom/GitHawk/languages","stargazers_url":"https://api.github.com/repos/rnystrom/GitHawk/stargazers","contributors_url":"https://api.github.com/repos/rnystrom/GitHawk/contributors","subscribers_url":"https://api.github.com/repos/rnystrom/GitHawk/subscribers","subscription_url":"https://api.github.com/repos/rnystrom/GitHawk/subscription","commits_url":"https://api.github.com/repos/rnystrom/GitHawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rnystrom/GitHawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rnystrom/GitHawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rnystrom/GitHawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rnystrom/GitHawk/contents/{+path}","compare_url":"https://api.github.com/repos/rnystrom/GitHawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rnystrom/GitHawk/merges","archive_url":"https://api.github.com/repos/rnystrom/GitHawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rnystrom/GitHawk/downloads","issues_url":"https://api.github.com/repos/rnystrom/GitHawk/issues{/number}","pulls_url":"https://api.github.com/repos/rnystrom/GitHawk/pulls{/number}","milestones_url":"https://api.github.com/repos/rnystrom/GitHawk/milestones{/number}","notifications_url":"https://api.github.com/repos/rnystrom/GitHawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rnystrom/GitHawk/labels{/name}","releases_url":"https://api.github.com/repos/rnystrom/GitHawk/releases{/id}","deployments_url":"https://api.github.com/repos/rnystrom/GitHawk/deployments","created_at":"2017-05-01T12:21:48Z","updated_at":"2018-02-21T10:40:20Z","pushed_at":"2018-02-21T03:17:43Z","git_url":"git://github.com/rnystrom/GitHawk.git","ssh_url":"git@github.com:rnystrom/GitHawk.git","clone_url":"https://github.com/rnystrom/GitHawk.git","svn_url":"https://github.com/rnystrom/GitHawk","homepage":"http://githawk.com","size":117120,"stargazers_count":759,"watchers_count":759,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":86,"open_issues":290,"watchers":759,"default_branch":"master"}},"base":{"label":"rnystrom:master","ref":"master","sha":"12fb61a318410053f5f065652a0a4094bd993202","user":{"login":"rnystrom","id":739696,"avatar_url":"https://avatars2.githubusercontent.com/u/739696?v=4","gravatar_id":"","url":"https://api.github.com/users/rnystrom","html_url":"https://github.com/rnystrom","followers_url":"https://api.github.com/users/rnystrom/followers","following_url":"https://api.github.com/users/rnystrom/following{/other_user}","gists_url":"https://api.github.com/users/rnystrom/gists{/gist_id}","starred_url":"https://api.github.com/users/rnystrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnystrom/subscriptions","organizations_url":"https://api.github.com/users/rnystrom/orgs","repos_url":"https://api.github.com/users/rnystrom/repos","events_url":"https://api.github.com/users/rnystrom/events{/privacy}","received_events_url":"https://api.github.com/users/rnystrom/received_events","type":"User","site_admin":false},"repo":{"id":89921801,"name":"GitHawk","full_name":"rnystrom/GitHawk","owner":{"login":"rnystrom","id":739696,"avatar_url":"https://avatars2.githubusercontent.com/u/739696?v=4","gravatar_id":"","url":"https://api.github.com/users/rnystrom","html_url":"https://github.com/rnystrom","followers_url":"https://api.github.com/users/rnystrom/followers","following_url":"https://api.github.com/users/rnystrom/following{/other_user}","gists_url":"https://api.github.com/users/rnystrom/gists{/gist_id}","starred_url":"https://api.github.com/users/rnystrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnystrom/subscriptions","organizations_url":"https://api.github.com/users/rnystrom/orgs","repos_url":"https://api.github.com/users/rnystrom/repos","events_url":"https://api.github.com/users/rnystrom/events{/privacy}","received_events_url":"https://api.github.com/users/rnystrom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rnystrom/GitHawk","description":"A GitHub project manager app for iOS.","fork":false,"url":"https://api.github.com/repos/rnystrom/GitHawk","forks_url":"https://api.github.com/repos/rnystrom/GitHawk/forks","keys_url":"https://api.github.com/repos/rnystrom/GitHawk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rnystrom/GitHawk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rnystrom/GitHawk/teams","hooks_url":"https://api.github.com/repos/rnystrom/GitHawk/hooks","issue_events_url":"https://api.github.com/repos/rnystrom/GitHawk/issues/events{/number}","events_url":"https://api.github.com/repos/rnystrom/GitHawk/events","assignees_url":"https://api.github.com/repos/rnystrom/GitHawk/assignees{/user}","branches_url":"https://api.github.com/repos/rnystrom/GitHawk/branches{/branch}","tags_url":"https://api.github.com/repos/rnystrom/GitHawk/tags","blobs_url":"https://api.github.com/repos/rnystrom/GitHawk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rnystrom/GitHawk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rnystrom/GitHawk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rnystrom/GitHawk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rnystrom/GitHawk/statuses/{sha}","languages_url":"https://api.github.com/repos/rnystrom/GitHawk/languages","stargazers_url":"https://api.github.com/repos/rnystrom/GitHawk/stargazers","contributors_url":"https://api.github.com/repos/rnystrom/GitHawk/contributors","subscribers_url":"https://api.github.com/repos/rnystrom/GitHawk/subscribers","subscription_url":"https://api.github.com/repos/rnystrom/GitHawk/subscription","commits_url":"https://api.github.com/repos/rnystrom/GitHawk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rnystrom/GitHawk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rnystrom/GitHawk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rnystrom/GitHawk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rnystrom/GitHawk/contents/{+path}","compare_url":"https://api.github.com/repos/rnystrom/GitHawk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rnystrom/GitHawk/merges","archive_url":"https://api.github.com/repos/rnystrom/GitHawk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rnystrom/GitHawk/downloads","issues_url":"https://api.github.com/repos/rnystrom/GitHawk/issues{/number}","pulls_url":"https://api.github.com/repos/rnystrom/GitHawk/pulls{/number}","milestones_url":"https://api.github.com/repos/rnystrom/GitHawk/milestones{/number}","notifications_url":"https://api.github.com/repos/rnystrom/GitHawk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rnystrom/GitHawk/labels{/name}","releases_url":"https://api.github.com/repos/rnystrom/GitHawk/releases{/id}","deployments_url":"https://api.github.com/repos/rnystrom/GitHawk/deployments","created_at":"2017-05-01T12:21:48Z","updated_at":"2018-02-21T10:40:20Z","pushed_at":"2018-02-21T03:17:43Z","git_url":"git://github.com/rnystrom/GitHawk.git","ssh_url":"git@github.com:rnystrom/GitHawk.git","clone_url":"https://github.com/rnystrom/GitHawk.git","svn_url":"https://github.com/rnystrom/GitHawk","homepage":"http://githawk.com","size":117120,"stargazers_count":759,"watchers_count":759,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":290,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":86,"open_issues":290,"watchers":759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549"},"html":{"href":"https://github.com/rnystrom/GitHawk/pull/1549"},"issue":{"href":"https://api.github.com/repos/rnystrom/GitHawk/issues/1549"},"comments":{"href":"https://api.github.com/repos/rnystrom/GitHawk/issues/1549/comments"},"review_comments":{"href":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549/comments"},"review_comment":{"href":"https://api.github.com/repos/rnystrom/GitHawk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rnystrom/GitHawk/pulls/1549/commits"},"statuses":{"href":"https://api.github.com/repos/rnystrom/GitHawk/statuses/067a3eecd085a1d0103419f7a36fd3b6e7dd073f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"BasThomas"}}