{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/twentynineteen/issues/503","repository_url":"https://api.github.com/repos/WordPress/twentynineteen","labels_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/503/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/503/comments","events_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/503/events","html_url":"https://github.com/WordPress/twentynineteen/issues/503","id":378137704,"node_id":"MDU6SXNzdWUzNzgxMzc3MDQ=","number":503,"title":"Styling blocks without GB","user":{"login":"joyously","id":7957680,"node_id":"MDQ6VXNlcjc5NTc2ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7957680?v=4","gravatar_id":"","url":"https://api.github.com/users/joyously","html_url":"https://github.com/joyously","followers_url":"https://api.github.com/users/joyously/followers","following_url":"https://api.github.com/users/joyously/following{/other_user}","gists_url":"https://api.github.com/users/joyously/gists{/gist_id}","starred_url":"https://api.github.com/users/joyously/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyously/subscriptions","organizations_url":"https://api.github.com/users/joyously/orgs","repos_url":"https://api.github.com/users/joyously/repos","events_url":"https://api.github.com/users/joyously/events{/privacy}","received_events_url":"https://api.github.com/users/joyously/received_events","type":"User","site_admin":false},"labels":[{"id":1092221196,"node_id":"MDU6TGFiZWwxMDkyMjIxMTk2","url":"https://api.github.com/repos/WordPress/twentynineteen/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":{"login":"kjellr","id":1202812,"node_id":"MDQ6VXNlcjEyMDI4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1202812?v=4","gravatar_id":"","url":"https://api.github.com/users/kjellr","html_url":"https://github.com/kjellr","followers_url":"https://api.github.com/users/kjellr/followers","following_url":"https://api.github.com/users/kjellr/following{/other_user}","gists_url":"https://api.github.com/users/kjellr/gists{/gist_id}","starred_url":"https://api.github.com/users/kjellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjellr/subscriptions","organizations_url":"https://api.github.com/users/kjellr/orgs","repos_url":"https://api.github.com/users/kjellr/repos","events_url":"https://api.github.com/users/kjellr/events{/privacy}","received_events_url":"https://api.github.com/users/kjellr/received_events","type":"User","site_admin":false},"assignees":[{"login":"kjellr","id":1202812,"node_id":"MDQ6VXNlcjEyMDI4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1202812?v=4","gravatar_id":"","url":"https://api.github.com/users/kjellr","html_url":"https://github.com/kjellr","followers_url":"https://api.github.com/users/kjellr/followers","following_url":"https://api.github.com/users/kjellr/following{/other_user}","gists_url":"https://api.github.com/users/kjellr/gists{/gist_id}","starred_url":"https://api.github.com/users/kjellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjellr/subscriptions","organizations_url":"https://api.github.com/users/kjellr/orgs","repos_url":"https://api.github.com/users/kjellr/repos","events_url":"https://api.github.com/users/kjellr/events{/privacy}","received_events_url":"https://api.github.com/users/kjellr/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordPress/twentynineteen/milestones/1","html_url":"https://github.com/WordPress/twentynineteen/milestone/1","labels_url":"https://api.github.com/repos/WordPress/twentynineteen/milestones/1/labels","id":3762003,"node_id":"MDk6TWlsZXN0b25lMzc2MjAwMw==","number":1,"title":"RC1","description":"","creator":{"login":"kjellr","id":1202812,"node_id":"MDQ6VXNlcjEyMDI4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1202812?v=4","gravatar_id":"","url":"https://api.github.com/users/kjellr","html_url":"https://github.com/kjellr","followers_url":"https://api.github.com/users/kjellr/followers","following_url":"https://api.github.com/users/kjellr/following{/other_user}","gists_url":"https://api.github.com/users/kjellr/gists{/gist_id}","starred_url":"https://api.github.com/users/kjellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjellr/subscriptions","organizations_url":"https://api.github.com/users/kjellr/orgs","repos_url":"https://api.github.com/users/kjellr/repos","events_url":"https://api.github.com/users/kjellr/events{/privacy}","received_events_url":"https://api.github.com/users/kjellr/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":88,"state":"open","created_at":"2018-10-23T14:39:25Z","updated_at":"2018-11-08T18:37:04Z","due_on":"2018-11-12T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-11-07T04:23:01Z","updated_at":"2018-11-08T18:59:44Z","closed_at":null,"author_association":"NONE","body":"What should a post with blocks look like if Gutenberg is deactivated?\r\nI'm thinking that it should at least be legible. I think some of the styles are split between the theme and the editor, such as `position: absolute` in one and `position: relative` in the other.\r\nThis Firefox screenshot shows the front end post testing cover blocks when GB is deactivated.\r\n\r\n![block-cover-no-gb-19](https://user-images.githubusercontent.com/7957680/48110329-2d789a00-e211-11e8-80bd-824f06254e5c.jpg)\r\n\r\nThis is how it looks in a different theme that has no GB styles.\r\n![block-cover-no-gb-18](https://user-images.githubusercontent.com/7957680/48110523-4cc3f700-e212-11e8-84ad-9cb4c265271d.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/WordPress/twentynineteen/issues/comments/437116343","html_url":"https://github.com/WordPress/twentynineteen/issues/503#issuecomment-437116343","issue_url":"https://api.github.com/repos/WordPress/twentynineteen/issues/503","id":437116343,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzExNjM0Mw==","user":{"login":"kjellr","id":1202812,"node_id":"MDQ6VXNlcjEyMDI4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1202812?v=4","gravatar_id":"","url":"https://api.github.com/users/kjellr","html_url":"https://github.com/kjellr","followers_url":"https://api.github.com/users/kjellr/followers","following_url":"https://api.github.com/users/kjellr/following{/other_user}","gists_url":"https://api.github.com/users/kjellr/gists{/gist_id}","starred_url":"https://api.github.com/users/kjellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjellr/subscriptions","organizations_url":"https://api.github.com/users/kjellr/orgs","repos_url":"https://api.github.com/users/kjellr/repos","events_url":"https://api.github.com/users/kjellr/events{/privacy}","received_events_url":"https://api.github.com/users/kjellr/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T18:59:44Z","updated_at":"2018-11-08T18:59:44Z","author_association":"COLLABORATOR","body":"Thanks, @joyously.\r\n\r\nGutenberg loads some basic front-end styles in order to make certain blocks appear as intended. For instance: making sure galleries appear in columns. This happens by default. \r\n\r\nIn addition, themes can opt in to include slightly more opinionated styles from Gutenberg. These are meant to sync up the front and back end display. For instance: adding the horizontal rule to the left of blockquote. This is done via `add_theme_support( 'wp-block-styles' );`, and is used by Twenty Nineteen (as well as many other themes) to establish a great starting point to build off of. \r\n\r\nIn 5.0, these styles are called all the time, even when you activate the Classic plugin. So there's no issue there. But on pre-5.0 versions of WordPress, if you deactivate the Gutenberg plugin, neither of these stylesheets exist. That leads to the issues you noted above. In our case, these issues will only happen if you: \r\n\r\n1. Are using WP version pre-5.0\r\n2. Manually install Twenty Nineteen\r\n3. Activate the Gutenberg plugin\r\n4. Create content that uses blocks\r\n5. Then, deactivate the Gutenberg plugin\r\n\r\nWhen this occurs, the behavior in themes will vary: most themes will likely not include fallbacks for every rule in those Gutenberg stylesheets. \r\n\r\nIf someone purposefully deactivates Gutenberg this way, I think it's reasonable to expect some loss of functionality. That said, it's not reasonable to have styles break completely. For our purposes, I suggest we take stock of what happens in this circumstance and focus on fixing things that are clearly broken. \r\n\r\nI took a look through my test site, and noted the following errors. \r\n\r\n- Tables lose their border colors. _This is a quick fix. We should take care of it._\r\n- Cover blocks lose their min-height, the positioning styles for their text and the background size/positioning styles for the image. _We should at least add the min-height._\r\n- Left/right aligned Cover blocks lose their `position: relative;` style, so the text inside them is in the wrong spot on the page. They also collapse completely. These are very broken. _We need to sort this out._\r\n- Columns are not arranged in columns anymore: they are stacked. _I think it's fine to keep them this way._\r\n- Galleries are not arranged in columns anymore: they're an unstyled list. _I suggest we add `list-style-type:none;` and leave them this way._\r\n- Dynamic blocks (Latest Posts, etc.) disappear completely. _This is expected and unavoidable._\r\n- Blockquote Size Large citation appears in a larger font size. _We can fix this._\r\n- Pullquote citations appear in a large font size. _We can fix this._\r\n- The citation in solid color Pullquotes is gray instead of white. _We can fix this._\r\n- Headline + text blocks stack vertically and have no padding. _We should at least add padding here._\r\n- Paragraphs with background colors have no additional padding. _This is easy to add._\r\n- File block download buttons lose their white text, making them unreadable. _We should fix this._ \r\n\r\n I can spin up a PR later to get these started. "}}
{"actor":{"display_login":"kjellr"}}