{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67622","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67622/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67622/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67622/events","html_url":"https://github.com/kubernetes/kubernetes/pull/67622","id":352320918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjYyNDQw","number":67622,"title":"Allow headless svc without ports to have endpoints","user":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"closed","locked":false,"assignee":{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false},"assignees":[{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-08-20T22:37:08Z","updated_at":"2018-08-24T02:29:46Z","closed_at":"2018-08-21T20:00:09Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67622","html_url":"https://github.com/kubernetes/kubernetes/pull/67622","diff_url":"https://github.com/kubernetes/kubernetes/pull/67622.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67622.patch"},"body":"As cited in\r\nhttps://github.com/kubernetes/dns/issues/174 - this is documented to\r\nwork, and I don't see why it shouldn't work.  We allowed the definition\r\nof headless services without ports, but apparently nobody tested it very\r\nwell.\r\n\r\nManually tested clusterIP services with no ports - validation error.\r\n\r\nManually tested services with negative ports - validation error.\r\n\r\nNew tests failed, output inspected and verified.  Now pass.\r\n\r\nxref https://github.com/kubernetes/dns/issues/174\r\n\r\n**Release note**:\r\n```release-note\r\nHeadless Services with no ports defined will now create Endpoints correctly, and appear in DNS.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/415632224","html_url":"https://github.com/kubernetes/kubernetes/pull/67622#issuecomment-415632224","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67622","id":415632224,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTYzMjIyNA==","user":{"login":"neolit123","id":331852,"node_id":"MDQ6VXNlcjMzMTg1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T02:29:46Z","updated_at":"2018-08-24T02:29:46Z","author_association":"MEMBER","body":"/sig api-machinery\r\nfor the release note tool.\r\n"}}
{"actor":{"display_login":"neolit123"}}