{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/6926","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/6926/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/6926/comments","events_url":"https://api.github.com/repos/helm/charts/issues/6926/events","html_url":"https://github.com/helm/charts/pull/6926","id":346252202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTYxOTQ3","number":6926,"title":"Allow the ability to provide a Sampling Strat File in the form of a ConfigMap","user":{"login":"dvonthenen","id":12752197,"node_id":"MDQ6VXNlcjEyNzUyMTk3","avatar_url":"https://avatars1.githubusercontent.com/u/12752197?v=4","gravatar_id":"","url":"https://api.github.com/users/dvonthenen","html_url":"https://github.com/dvonthenen","followers_url":"https://api.github.com/users/dvonthenen/followers","following_url":"https://api.github.com/users/dvonthenen/following{/other_user}","gists_url":"https://api.github.com/users/dvonthenen/gists{/gist_id}","starred_url":"https://api.github.com/users/dvonthenen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvonthenen/subscriptions","organizations_url":"https://api.github.com/users/dvonthenen/orgs","repos_url":"https://api.github.com/users/dvonthenen/repos","events_url":"https://api.github.com/users/dvonthenen/events{/privacy}","received_events_url":"https://api.github.com/users/dvonthenen/received_events","type":"User","site_admin":false},"labels":[{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-31T15:57:22Z","updated_at":"2018-07-31T15:57:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6926","html_url":"https://github.com/helm/charts/pull/6926","diff_url":"https://github.com/helm/charts/pull/6926.diff","patch_url":"https://github.com/helm/charts/pull/6926.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR implements new functionality which enables setting --sampling.strategies-file pointed to by a ConfigMap which contains the JSON for the sampling configuration.\r\n\r\nA ConfigMap with the sampling strategy JSON can be created using the following command:\r\n```bash\r\nkubectl create configmap jaeger-sampling --from-file=sampling.json\r\n```\r\n\r\nThe deploy the chart enabling the following helm option:\r\n`--set collector.samplingStrategiesFile=jaeger-sampling`\r\n\r\n**Which issue this PR fixes**: fixes https://github.com/helm/charts/issues/6631\r\n\r\n**Special notes for your reviewer**:\r\nNeed someone to verify the functionality. I have attached a zip file containing the helm chart tgz. Unpack the zip file and deploy the tgz file using helm.\r\n[jaeger.zip](https://github.com/helm/charts/files/2246091/jaeger.zip)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/409273117","html_url":"https://github.com/helm/charts/pull/6926#issuecomment-409273117","issue_url":"https://api.github.com/repos/helm/charts/issues/6926","id":409273117,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI3MzExNw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T15:57:37Z","updated_at":"2018-07-31T15:57:37Z","author_association":"CONTRIBUTOR","body":"Hi @dvonthenen. Thanks for your PR.\n\nI'm waiting for a [helm](https://github.com/orgs/helm/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/orgs/helm/people) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}