{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13496","repository_url":"https://api.github.com/repos/apache/incubator-mxnet","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13496/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13496/comments","events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13496/events","html_url":"https://github.com/apache/incubator-mxnet/pull/13496","id":386351469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTE2MjY2","number":13496,"title":"Optimize C++ API","user":{"login":"zhaoyao73","id":15716888,"node_id":"MDQ6VXNlcjE1NzE2ODg4","avatar_url":"https://avatars3.githubusercontent.com/u/15716888?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaoyao73","html_url":"https://github.com/zhaoyao73","followers_url":"https://api.github.com/users/zhaoyao73/followers","following_url":"https://api.github.com/users/zhaoyao73/following{/other_user}","gists_url":"https://api.github.com/users/zhaoyao73/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoyao73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoyao73/subscriptions","organizations_url":"https://api.github.com/users/zhaoyao73/orgs","repos_url":"https://api.github.com/users/zhaoyao73/repos","events_url":"https://api.github.com/users/zhaoyao73/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoyao73/received_events","type":"User","site_admin":false},"labels":[{"id":273991937,"node_id":"MDU6TGFiZWwyNzM5OTE5Mzc=","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/C++","name":"C++","color":"0052cc","default":false},{"id":1018798522,"node_id":"MDU6TGFiZWwxMDE4Nzk4NTIy","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/pr-awaiting-review","name":"pr-awaiting-review","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-11-30T21:11:10Z","updated_at":"2018-12-10T23:42:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/13496","html_url":"https://github.com/apache/incubator-mxnet/pull/13496","diff_url":"https://github.com/apache/incubator-mxnet/pull/13496.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/13496.patch"},"body":"Pass parameter with reference instead of value.\r\nAdd const as well as it is not changed.\r\n\r\n## Description ##\r\nOptimize some functions to pass reference instead of value. This could avoid unnecessary construction/destruction and copy.\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n-  tiny changes\r\n- did a successful build\r\n- For user-facing API changes, API doc string has been updated. \r\n  Didn't find the API doc in mxnet.io/doxygen\r\n- [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n\r\n## Comments ##\r\nI am not sure I could run a sanity test with it or how to run a unit test/sanity test against the change. But pass value -> pass reference, should be transparent to C++, although not like C's pass value->pass pointer."},"comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments/446017203","html_url":"https://github.com/apache/incubator-mxnet/pull/13496#issuecomment-446017203","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/13496","id":446017203,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjAxNzIwMw==","user":{"login":"marcoabreu","id":18629099,"node_id":"MDQ6VXNlcjE4NjI5MDk5","avatar_url":"https://avatars1.githubusercontent.com/u/18629099?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoabreu","html_url":"https://github.com/marcoabreu","followers_url":"https://api.github.com/users/marcoabreu/followers","following_url":"https://api.github.com/users/marcoabreu/following{/other_user}","gists_url":"https://api.github.com/users/marcoabreu/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoabreu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoabreu/subscriptions","organizations_url":"https://api.github.com/users/marcoabreu/orgs","repos_url":"https://api.github.com/users/marcoabreu/repos","events_url":"https://api.github.com/users/marcoabreu/events{/privacy}","received_events_url":"https://api.github.com/users/marcoabreu/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T23:42:11Z","updated_at":"2018-12-10T23:42:11Z","author_association":"CONTRIBUTOR","body":"Yeah, just make a new commit and it will automatically start a build"}}
{"actor":{"display_login":"marcoabreu"}}