{"action":"created","comment":{"url":"https://api.github.com/repos/PaperMC/Paper/pulls/comments/208715607","pull_request_review_id":144584033,"id":208715607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODcxNTYwNw==","diff_hunk":"@@ -0,0 +1,84 @@\n+From f558fa3f624e9833d885d35e6190abecf218c139 Mon Sep 17 00:00:00 2001\n+From: miclebrick <miclebrick@outlook.com>\n+Date: Wed, 8 Aug 2018 15:30:52 -0400\n+Subject: [PATCH] Add 5 second short dumps to watchdog\n+\n+\n+diff --git a/src/main/java/org/spigotmc/WatchdogThread.java b/src/main/java/org/spigotmc/WatchdogThread.java\n+index 57a4748a..c88bef9f 100644\n+--- a/src/main/java/org/spigotmc/WatchdogThread.java\n++++ b/src/main/java/org/spigotmc/WatchdogThread.java\n+@@ -13,8 +13,10 @@ public class WatchdogThread extends Thread\n+ \n+     private static WatchdogThread instance;\n+     private final long timeoutTime;\n++    private final long shortTimeout; // Paper - Timeout time for just printing a dump but not restarting\n+     private final boolean restart;\n+     private volatile long lastTick;\n++    private long lastShortDump; // Paper - Keep track of short dump times to avoid spamming console with short dumps\n+     private volatile boolean stopping;\n+ \n+     private WatchdogThread(long timeoutTime, boolean restart)\n+@@ -22,6 +24,7 @@ public class WatchdogThread extends Thread\n+         super( \"Paper Watchdog Thread\" );\n+         this.timeoutTime = timeoutTime;\n+         this.restart = restart;\n++        shortTimeout = Math.min(5000, timeoutTime); // Paper - Make short timeout the lower of 5 seconds, and timeout time\n+     }\n+ \n+     public static void doStart(int timeoutTime, boolean restart)\n+@@ -52,9 +55,19 @@ public class WatchdogThread extends Thread\n+         while ( !stopping )\n+         {\n+             //\n+-            if ( lastTick != 0 && System.currentTimeMillis() > lastTick + timeoutTime && !Boolean.getBoolean(\"disable.watchdog\")) // Paper - Add property to disable\n++            long currentTime = System.currentTimeMillis(); // Paper - do we REALLY need to call this method multiple times?\n++            if ( lastTick != 0 && currentTime > lastTick + shortTimeout && !Boolean.getBoolean(\"disable.watchdog\")) // Paper - Add property to disable and short timeout","path":"Spigot-Server-Patches/0349-Add-5-second-short-dumps-to-watchdog.patch","position":36,"original_position":36,"commit_id":"f5be3a0f54b0f46af871d31adfa31a1afdde0b41","original_commit_id":"f5be3a0f54b0f46af871d31adfa31a1afdde0b41","user":{"login":"Spottedleaf","id":6100722,"node_id":"MDQ6VXNlcjYxMDA3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6100722?v=4","gravatar_id":"","url":"https://api.github.com/users/Spottedleaf","html_url":"https://github.com/Spottedleaf","followers_url":"https://api.github.com/users/Spottedleaf/followers","following_url":"https://api.github.com/users/Spottedleaf/following{/other_user}","gists_url":"https://api.github.com/users/Spottedleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/Spottedleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spottedleaf/subscriptions","organizations_url":"https://api.github.com/users/Spottedleaf/orgs","repos_url":"https://api.github.com/users/Spottedleaf/repos","events_url":"https://api.github.com/users/Spottedleaf/events{/privacy}","received_events_url":"https://api.github.com/users/Spottedleaf/received_events","type":"User","site_admin":false},"body":"fits with style","created_at":"2018-08-08T20:00:44Z","updated_at":"2018-08-08T20:00:45Z","html_url":"https://github.com/PaperMC/Paper/pull/1314#discussion_r208715607","pull_request_url":"https://api.github.com/repos/PaperMC/Paper/pulls/1314","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/comments/208715607"},"html":{"href":"https://github.com/PaperMC/Paper/pull/1314#discussion_r208715607"},"pull_request":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1314"}},"in_reply_to_id":208713812},"pull_request":{"url":"https://api.github.com/repos/PaperMC/Paper/pulls/1314","id":207115824,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTE1ODI0","html_url":"https://github.com/PaperMC/Paper/pull/1314","diff_url":"https://github.com/PaperMC/Paper/pull/1314.diff","patch_url":"https://github.com/PaperMC/Paper/pull/1314.patch","issue_url":"https://api.github.com/repos/PaperMC/Paper/issues/1314","number":1314,"state":"open","locked":false,"title":"Make watchdog print every 5 seconds when it's frozen","user":{"login":"Miclebrick","id":6323125,"node_id":"MDQ6VXNlcjYzMjMxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6323125?v=4","gravatar_id":"","url":"https://api.github.com/users/Miclebrick","html_url":"https://github.com/Miclebrick","followers_url":"https://api.github.com/users/Miclebrick/followers","following_url":"https://api.github.com/users/Miclebrick/following{/other_user}","gists_url":"https://api.github.com/users/Miclebrick/gists{/gist_id}","starred_url":"https://api.github.com/users/Miclebrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miclebrick/subscriptions","organizations_url":"https://api.github.com/users/Miclebrick/orgs","repos_url":"https://api.github.com/users/Miclebrick/repos","events_url":"https://api.github.com/users/Miclebrick/events{/privacy}","received_events_url":"https://api.github.com/users/Miclebrick/received_events","type":"User","site_admin":false},"body":"too tired to rewrite this","created_at":"2018-08-08T19:40:15Z","updated_at":"2018-08-08T20:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c81e2e9ac00eb41c84c0f70b097b93b5535e9b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaperMC/Paper/pulls/1314/commits","review_comments_url":"https://api.github.com/repos/PaperMC/Paper/pulls/1314/comments","review_comment_url":"https://api.github.com/repos/PaperMC/Paper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaperMC/Paper/issues/1314/comments","statuses_url":"https://api.github.com/repos/PaperMC/Paper/statuses/f5be3a0f54b0f46af871d31adfa31a1afdde0b41","head":{"label":"Miclebrick:micles-MITtens-make-watchdog-print-after-5s-freeze","ref":"micles-MITtens-make-watchdog-print-after-5s-freeze","sha":"f5be3a0f54b0f46af871d31adfa31a1afdde0b41","user":{"login":"Miclebrick","id":6323125,"node_id":"MDQ6VXNlcjYzMjMxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6323125?v=4","gravatar_id":"","url":"https://api.github.com/users/Miclebrick","html_url":"https://github.com/Miclebrick","followers_url":"https://api.github.com/users/Miclebrick/followers","following_url":"https://api.github.com/users/Miclebrick/following{/other_user}","gists_url":"https://api.github.com/users/Miclebrick/gists{/gist_id}","starred_url":"https://api.github.com/users/Miclebrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miclebrick/subscriptions","organizations_url":"https://api.github.com/users/Miclebrick/orgs","repos_url":"https://api.github.com/users/Miclebrick/repos","events_url":"https://api.github.com/users/Miclebrick/events{/privacy}","received_events_url":"https://api.github.com/users/Miclebrick/received_events","type":"User","site_admin":false},"repo":{"id":141720951,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MjA5NTE=","name":"Paper","full_name":"Miclebrick/Paper","owner":{"login":"Miclebrick","id":6323125,"node_id":"MDQ6VXNlcjYzMjMxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/6323125?v=4","gravatar_id":"","url":"https://api.github.com/users/Miclebrick","html_url":"https://github.com/Miclebrick","followers_url":"https://api.github.com/users/Miclebrick/followers","following_url":"https://api.github.com/users/Miclebrick/following{/other_user}","gists_url":"https://api.github.com/users/Miclebrick/gists{/gist_id}","starred_url":"https://api.github.com/users/Miclebrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miclebrick/subscriptions","organizations_url":"https://api.github.com/users/Miclebrick/orgs","repos_url":"https://api.github.com/users/Miclebrick/repos","events_url":"https://api.github.com/users/Miclebrick/events{/privacy}","received_events_url":"https://api.github.com/users/Miclebrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Miclebrick/Paper","description":"High performance Spigot fork that aims to fix gameplay and mechanics inconsistencies","fork":true,"url":"https://api.github.com/repos/Miclebrick/Paper","forks_url":"https://api.github.com/repos/Miclebrick/Paper/forks","keys_url":"https://api.github.com/repos/Miclebrick/Paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Miclebrick/Paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Miclebrick/Paper/teams","hooks_url":"https://api.github.com/repos/Miclebrick/Paper/hooks","issue_events_url":"https://api.github.com/repos/Miclebrick/Paper/issues/events{/number}","events_url":"https://api.github.com/repos/Miclebrick/Paper/events","assignees_url":"https://api.github.com/repos/Miclebrick/Paper/assignees{/user}","branches_url":"https://api.github.com/repos/Miclebrick/Paper/branches{/branch}","tags_url":"https://api.github.com/repos/Miclebrick/Paper/tags","blobs_url":"https://api.github.com/repos/Miclebrick/Paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Miclebrick/Paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Miclebrick/Paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/Miclebrick/Paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Miclebrick/Paper/statuses/{sha}","languages_url":"https://api.github.com/repos/Miclebrick/Paper/languages","stargazers_url":"https://api.github.com/repos/Miclebrick/Paper/stargazers","contributors_url":"https://api.github.com/repos/Miclebrick/Paper/contributors","subscribers_url":"https://api.github.com/repos/Miclebrick/Paper/subscribers","subscription_url":"https://api.github.com/repos/Miclebrick/Paper/subscription","commits_url":"https://api.github.com/repos/Miclebrick/Paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/Miclebrick/Paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/Miclebrick/Paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/Miclebrick/Paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/Miclebrick/Paper/contents/{+path}","compare_url":"https://api.github.com/repos/Miclebrick/Paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Miclebrick/Paper/merges","archive_url":"https://api.github.com/repos/Miclebrick/Paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Miclebrick/Paper/downloads","issues_url":"https://api.github.com/repos/Miclebrick/Paper/issues{/number}","pulls_url":"https://api.github.com/repos/Miclebrick/Paper/pulls{/number}","milestones_url":"https://api.github.com/repos/Miclebrick/Paper/milestones{/number}","notifications_url":"https://api.github.com/repos/Miclebrick/Paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Miclebrick/Paper/labels{/name}","releases_url":"https://api.github.com/repos/Miclebrick/Paper/releases{/id}","deployments_url":"https://api.github.com/repos/Miclebrick/Paper/deployments","created_at":"2018-07-20T14:19:35Z","updated_at":"2018-08-08T19:31:37Z","pushed_at":"2018-08-08T19:39:41Z","git_url":"git://github.com/Miclebrick/Paper.git","ssh_url":"git@github.com:Miclebrick/Paper.git","clone_url":"https://github.com/Miclebrick/Paper.git","svn_url":"https://github.com/Miclebrick/Paper","homepage":"https://aquifermc.org/","size":11912,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PaperMC:master","ref":"master","sha":"e861035fc4596876b46037b63fb58a7fa6bfc379","user":{"login":"PaperMC","id":7608950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDg5NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7608950?v=4","gravatar_id":"","url":"https://api.github.com/users/PaperMC","html_url":"https://github.com/PaperMC","followers_url":"https://api.github.com/users/PaperMC/followers","following_url":"https://api.github.com/users/PaperMC/following{/other_user}","gists_url":"https://api.github.com/users/PaperMC/gists{/gist_id}","starred_url":"https://api.github.com/users/PaperMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaperMC/subscriptions","organizations_url":"https://api.github.com/users/PaperMC/orgs","repos_url":"https://api.github.com/users/PaperMC/repos","events_url":"https://api.github.com/users/PaperMC/events{/privacy}","received_events_url":"https://api.github.com/users/PaperMC/received_events","type":"Organization","site_admin":false},"repo":{"id":50160261,"node_id":"MDEwOlJlcG9zaXRvcnk1MDE2MDI2MQ==","name":"Paper","full_name":"PaperMC/Paper","owner":{"login":"PaperMC","id":7608950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDg5NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7608950?v=4","gravatar_id":"","url":"https://api.github.com/users/PaperMC","html_url":"https://github.com/PaperMC","followers_url":"https://api.github.com/users/PaperMC/followers","following_url":"https://api.github.com/users/PaperMC/following{/other_user}","gists_url":"https://api.github.com/users/PaperMC/gists{/gist_id}","starred_url":"https://api.github.com/users/PaperMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaperMC/subscriptions","organizations_url":"https://api.github.com/users/PaperMC/orgs","repos_url":"https://api.github.com/users/PaperMC/repos","events_url":"https://api.github.com/users/PaperMC/events{/privacy}","received_events_url":"https://api.github.com/users/PaperMC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaperMC/Paper","description":"High performance Spigot fork that aims to fix gameplay and mechanics inconsistencies","fork":false,"url":"https://api.github.com/repos/PaperMC/Paper","forks_url":"https://api.github.com/repos/PaperMC/Paper/forks","keys_url":"https://api.github.com/repos/PaperMC/Paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaperMC/Paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaperMC/Paper/teams","hooks_url":"https://api.github.com/repos/PaperMC/Paper/hooks","issue_events_url":"https://api.github.com/repos/PaperMC/Paper/issues/events{/number}","events_url":"https://api.github.com/repos/PaperMC/Paper/events","assignees_url":"https://api.github.com/repos/PaperMC/Paper/assignees{/user}","branches_url":"https://api.github.com/repos/PaperMC/Paper/branches{/branch}","tags_url":"https://api.github.com/repos/PaperMC/Paper/tags","blobs_url":"https://api.github.com/repos/PaperMC/Paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaperMC/Paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaperMC/Paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaperMC/Paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaperMC/Paper/statuses/{sha}","languages_url":"https://api.github.com/repos/PaperMC/Paper/languages","stargazers_url":"https://api.github.com/repos/PaperMC/Paper/stargazers","contributors_url":"https://api.github.com/repos/PaperMC/Paper/contributors","subscribers_url":"https://api.github.com/repos/PaperMC/Paper/subscribers","subscription_url":"https://api.github.com/repos/PaperMC/Paper/subscription","commits_url":"https://api.github.com/repos/PaperMC/Paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaperMC/Paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaperMC/Paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaperMC/Paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaperMC/Paper/contents/{+path}","compare_url":"https://api.github.com/repos/PaperMC/Paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaperMC/Paper/merges","archive_url":"https://api.github.com/repos/PaperMC/Paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaperMC/Paper/downloads","issues_url":"https://api.github.com/repos/PaperMC/Paper/issues{/number}","pulls_url":"https://api.github.com/repos/PaperMC/Paper/pulls{/number}","milestones_url":"https://api.github.com/repos/PaperMC/Paper/milestones{/number}","notifications_url":"https://api.github.com/repos/PaperMC/Paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaperMC/Paper/labels{/name}","releases_url":"https://api.github.com/repos/PaperMC/Paper/releases{/id}","deployments_url":"https://api.github.com/repos/PaperMC/Paper/deployments","created_at":"2016-01-22T05:40:19Z","updated_at":"2018-08-08T11:15:35Z","pushed_at":"2018-08-08T19:56:15Z","git_url":"git://github.com/PaperMC/Paper.git","ssh_url":"git@github.com:PaperMC/Paper.git","clone_url":"https://github.com/PaperMC/Paper.git","svn_url":"https://github.com/PaperMC/Paper","homepage":"https://aquifermc.org/","size":12874,"stargazers_count":397,"watchers_count":397,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":198,"open_issues":63,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1314"},"html":{"href":"https://github.com/PaperMC/Paper/pull/1314"},"issue":{"href":"https://api.github.com/repos/PaperMC/Paper/issues/1314"},"comments":{"href":"https://api.github.com/repos/PaperMC/Paper/issues/1314/comments"},"review_comments":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1314/comments"},"review_comment":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1314/commits"},"statuses":{"href":"https://api.github.com/repos/PaperMC/Paper/statuses/f5be3a0f54b0f46af871d31adfa31a1afdde0b41"}},"author_association":"NONE"}}
{"actor":{"display_login":"Spottedleaf"}}