{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments/215993097","pull_request_review_id":153385719,"id":215993097,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTk5MzA5Nw==","diff_hunk":"@@ -144,21 +162,10 @@ public Envelope saveEnvelope(Envelope envelope) {\n         );\n     }\n \n-    public void markAsUploaded(Envelope envelope) {\n-        persistEvent(envelope, envelope.getContainer(), envelope.getZipFileName(), DOC_UPLOADED);\n-    }\n-\n-    public void markAsProcessed(Envelope envelope) {\n-        persistEvent(envelope, envelope.getContainer(), envelope.getZipFileName(), DOC_PROCESSED);\n-    }\n-\n-    private void persistEvent(\n-        Envelope envelope,\n-        String containerName,\n-        String zipFileName,\n-        Event event\n-    ) {\n-        processEventRepository.save(new ProcessEvent(containerName, zipFileName, event));\n+    public void handleEvent(Envelope envelope, Event event) {\n+        processEventRepository.save(\n+            new ProcessEvent(envelope.getContainer(), envelope.getZipFileName(), event)\n+        );\n \n         if (envelope != null) {","path":"src/main/java/uk/gov/hmcts/reform/bulkscanprocessor/tasks/processor/EnvelopeProcessor.java","position":60,"original_position":60,"commit_id":"5ea3ee4ffba51b3137de9cbc34ed243525bcb352","original_commit_id":"5ea3ee4ffba51b3137de9cbc34ed243525bcb352","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Remove this expression which always evaluates to \"true\" ([squid:S2589](https://sonarcloud.io/organizations/hmcts/rules#rule_key=squid%3AS2589))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=uk.gov.hmcts.reform%3Abulk-scan-processor&pullRequest=163&issues=AWW0mL8z_eEZPtUmTSbP&open=AWW0mL8z_eEZPtUmTSbP)\n\n[ISSUE_KEY]: AWW0mL8z_eEZPtUmTSbP","created_at":"2018-09-07T15:13:58Z","updated_at":"2018-09-07T15:13:59Z","html_url":"https://github.com/hmcts/bulk-scan-processor/pull/163#discussion_r215993097","pull_request_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments/215993097"},"html":{"href":"https://github.com/hmcts/bulk-scan-processor/pull/163#discussion_r215993097"},"pull_request":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163","id":213930147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTMwMTQ3","html_url":"https://github.com/hmcts/bulk-scan-processor/pull/163","diff_url":"https://github.com/hmcts/bulk-scan-processor/pull/163.diff","patch_url":"https://github.com/hmcts/bulk-scan-processor/pull/163.patch","issue_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/163","number":163,"state":"open","locked":false,"title":"[PREVIEW] RPE-693 Refactor blob delete","user":{"login":"luigibk","id":41112628,"node_id":"MDQ6VXNlcjQxMTEyNjI4","avatar_url":"https://avatars3.githubusercontent.com/u/41112628?v=4","gravatar_id":"","url":"https://api.github.com/users/luigibk","html_url":"https://github.com/luigibk","followers_url":"https://api.github.com/users/luigibk/followers","following_url":"https://api.github.com/users/luigibk/following{/other_user}","gists_url":"https://api.github.com/users/luigibk/gists{/gist_id}","starred_url":"https://api.github.com/users/luigibk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigibk/subscriptions","organizations_url":"https://api.github.com/users/luigibk/orgs","repos_url":"https://api.github.com/users/luigibk/repos","events_url":"https://api.github.com/users/luigibk/events{/privacy}","received_events_url":"https://api.github.com/users/luigibk/received_events","type":"User","site_admin":false},"body":"### JIRA link (if applicable) ###\r\nhttps://tools.hmcts.net/jira/browse/RPE-693\r\n\r\n\r\n### Change description ###\r\nRefactor blob delete\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2018-09-07T13:35:42Z","updated_at":"2018-09-07T15:13:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e65ffa6887256ea7c10e2fb3a6d10021ece4de89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1005728375,"node_id":"MDU6TGFiZWwxMDA1NzI4Mzc1","url":"https://api.github.com/repos/hmcts/bulk-scan-processor/labels/WIP","name":"WIP","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163/commits","review_comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163/comments","review_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/163/comments","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/5ea3ee4ffba51b3137de9cbc34ed243525bcb352","head":{"label":"hmcts:refactor-blob-delete","ref":"refactor-blob-delete","sha":"5ea3ee4ffba51b3137de9cbc34ed243525bcb352","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":133028120,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMjgxMjA=","name":"bulk-scan-processor","full_name":"hmcts/bulk-scan-processor","owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/bulk-scan-processor","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/bulk-scan-processor","forks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/forks","keys_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/teams","hooks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/hooks","issue_events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/events","assignees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/tags","blobs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/languages","stargazers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/stargazers","contributors_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contributors","subscribers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscribers","subscription_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscription","commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/merges","archive_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/downloads","issues_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/deployments","created_at":"2018-05-11T10:51:58Z","updated_at":"2018-09-07T13:32:21Z","pushed_at":"2018-09-07T15:02:55Z","git_url":"git://github.com/hmcts/bulk-scan-processor.git","ssh_url":"git@github.com:hmcts/bulk-scan-processor.git","clone_url":"https://github.com/hmcts/bulk-scan-processor.git","svn_url":"https://github.com/hmcts/bulk-scan-processor","homepage":null,"size":1576,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"f14cb3b05fdfdf719d1dfd54dc6e304a1f60c405","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":133028120,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMjgxMjA=","name":"bulk-scan-processor","full_name":"hmcts/bulk-scan-processor","owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/bulk-scan-processor","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/bulk-scan-processor","forks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/forks","keys_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/teams","hooks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/hooks","issue_events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/events","assignees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/tags","blobs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/languages","stargazers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/stargazers","contributors_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contributors","subscribers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscribers","subscription_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscription","commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/merges","archive_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/downloads","issues_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/deployments","created_at":"2018-05-11T10:51:58Z","updated_at":"2018-09-07T13:32:21Z","pushed_at":"2018-09-07T15:02:55Z","git_url":"git://github.com/hmcts/bulk-scan-processor.git","ssh_url":"git@github.com:hmcts/bulk-scan-processor.git","clone_url":"https://github.com/hmcts/bulk-scan-processor.git","svn_url":"https://github.com/hmcts/bulk-scan-processor","homepage":null,"size":1576,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163"},"html":{"href":"https://github.com/hmcts/bulk-scan-processor/pull/163"},"issue":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/163"},"comments":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/5ea3ee4ffba51b3137de9cbc34ed243525bcb352"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sonarcloud"}}