{"action":"created","comment":{"url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/comments/180867277","pull_request_review_id":111365773,"id":180867277,"diff_hunk":"@@ -47,7 +47,7 @@ class OpenLayersMap extends React.Component{\n   }\n \n   renderTrails() {\n-    const {trails, selectedTrail, hydrants} = this.props;\n+    const {trails, selectedTrail, hydrants, mode} = this.props;","path":"src/components/OpenLayersMap.js","position":5,"original_position":5,"commit_id":"6798198ec372842067bb87af4e707b5b57021779","original_commit_id":"6798198ec372842067bb87af4e707b5b57021779","user":{"login":"caacree","id":4749248,"avatar_url":"https://avatars1.githubusercontent.com/u/4749248?v=4","gravatar_id":"","url":"https://api.github.com/users/caacree","html_url":"https://github.com/caacree","followers_url":"https://api.github.com/users/caacree/followers","following_url":"https://api.github.com/users/caacree/following{/other_user}","gists_url":"https://api.github.com/users/caacree/gists{/gist_id}","starred_url":"https://api.github.com/users/caacree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caacree/subscriptions","organizations_url":"https://api.github.com/users/caacree/orgs","repos_url":"https://api.github.com/users/caacree/repos","events_url":"https://api.github.com/users/caacree/events{/privacy}","received_events_url":"https://api.github.com/users/caacree/received_events","type":"User","site_admin":false},"body":"Yeah, something like that will be the right call. I think I'm going to try and see if I can update without storing any of those in state, just some sort of finding through the map object itself to avoid duplicating memory, but do it in a later PR for efficiency. ","created_at":"2018-04-11T19:12:38Z","updated_at":"2018-04-11T19:12:38Z","html_url":"https://github.com/jolavb/Sno_Demo/pull/28#discussion_r180867277","pull_request_url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/comments/180867277"},"html":{"href":"https://github.com/jolavb/Sno_Demo/pull/28#discussion_r180867277"},"pull_request":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28"}},"in_reply_to_id":180864257},"pull_request":{"url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28","id":180937328,"html_url":"https://github.com/jolavb/Sno_Demo/pull/28","diff_url":"https://github.com/jolavb/Sno_Demo/pull/28.diff","patch_url":"https://github.com/jolavb/Sno_Demo/pull/28.patch","issue_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues/28","number":28,"state":"open","locked":false,"title":"switch to modes","user":{"login":"caacree","id":4749248,"avatar_url":"https://avatars1.githubusercontent.com/u/4749248?v=4","gravatar_id":"","url":"https://api.github.com/users/caacree","html_url":"https://github.com/caacree","followers_url":"https://api.github.com/users/caacree/followers","following_url":"https://api.github.com/users/caacree/following{/other_user}","gists_url":"https://api.github.com/users/caacree/gists{/gist_id}","starred_url":"https://api.github.com/users/caacree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caacree/subscriptions","organizations_url":"https://api.github.com/users/caacree/orgs","repos_url":"https://api.github.com/users/caacree/repos","events_url":"https://api.github.com/users/caacree/events{/privacy}","received_events_url":"https://api.github.com/users/caacree/received_events","type":"User","site_admin":false},"body":"Top-level changes for switching between trails/hydrants modes. \r\n\r\n- All trail and hydrant updates/deletes go through uniform methods now (modifyTrail and modifyHydrant), consolidating some of the similar uses like renaming, updating coordinates, and deleting into single functions. \r\n\r\n- Removed the defaultTrails stuff since it's not relevant to the final product and wasn't doing much anymore in terms of helping development. \r\n\r\n- Updated the indexNameByElevation function to use immutable, which I missed before and was breaking when dropping hydrants. \r\n\r\n- Updated the MapControls to the new values (though feel free to change the layout/styles with whatever you're doing as long as it updates the mode like this does)\r\n\r\n- All the hydrants are shown now. \r\n\r\n\r\nNext step will be going into the map more to adjust the styling and drawing functions to be more intuitive with the modes and selected objects, and maybe a tweak or two to selecting things from the TrailList. ","created_at":"2018-04-11T15:11:57Z","updated_at":"2018-04-11T19:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4b6480643ef3c94798bb090d089303aef1fba7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28/commits","review_comments_url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28/comments","review_comment_url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues/28/comments","statuses_url":"https://api.github.com/repos/jolavb/Sno_Demo/statuses/6798198ec372842067bb87af4e707b5b57021779","head":{"label":"jolavb:modes","ref":"modes","sha":"6798198ec372842067bb87af4e707b5b57021779","user":{"login":"jolavb","id":25570080,"avatar_url":"https://avatars1.githubusercontent.com/u/25570080?v=4","gravatar_id":"","url":"https://api.github.com/users/jolavb","html_url":"https://github.com/jolavb","followers_url":"https://api.github.com/users/jolavb/followers","following_url":"https://api.github.com/users/jolavb/following{/other_user}","gists_url":"https://api.github.com/users/jolavb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolavb/subscriptions","organizations_url":"https://api.github.com/users/jolavb/orgs","repos_url":"https://api.github.com/users/jolavb/repos","events_url":"https://api.github.com/users/jolavb/events{/privacy}","received_events_url":"https://api.github.com/users/jolavb/received_events","type":"User","site_admin":false},"repo":{"id":126484611,"name":"Sno_Demo","full_name":"jolavb/Sno_Demo","owner":{"login":"jolavb","id":25570080,"avatar_url":"https://avatars1.githubusercontent.com/u/25570080?v=4","gravatar_id":"","url":"https://api.github.com/users/jolavb","html_url":"https://github.com/jolavb","followers_url":"https://api.github.com/users/jolavb/followers","following_url":"https://api.github.com/users/jolavb/following{/other_user}","gists_url":"https://api.github.com/users/jolavb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolavb/subscriptions","organizations_url":"https://api.github.com/users/jolavb/orgs","repos_url":"https://api.github.com/users/jolavb/repos","events_url":"https://api.github.com/users/jolavb/events{/privacy}","received_events_url":"https://api.github.com/users/jolavb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jolavb/Sno_Demo","description":null,"fork":false,"url":"https://api.github.com/repos/jolavb/Sno_Demo","forks_url":"https://api.github.com/repos/jolavb/Sno_Demo/forks","keys_url":"https://api.github.com/repos/jolavb/Sno_Demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jolavb/Sno_Demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jolavb/Sno_Demo/teams","hooks_url":"https://api.github.com/repos/jolavb/Sno_Demo/hooks","issue_events_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues/events{/number}","events_url":"https://api.github.com/repos/jolavb/Sno_Demo/events","assignees_url":"https://api.github.com/repos/jolavb/Sno_Demo/assignees{/user}","branches_url":"https://api.github.com/repos/jolavb/Sno_Demo/branches{/branch}","tags_url":"https://api.github.com/repos/jolavb/Sno_Demo/tags","blobs_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jolavb/Sno_Demo/statuses/{sha}","languages_url":"https://api.github.com/repos/jolavb/Sno_Demo/languages","stargazers_url":"https://api.github.com/repos/jolavb/Sno_Demo/stargazers","contributors_url":"https://api.github.com/repos/jolavb/Sno_Demo/contributors","subscribers_url":"https://api.github.com/repos/jolavb/Sno_Demo/subscribers","subscription_url":"https://api.github.com/repos/jolavb/Sno_Demo/subscription","commits_url":"https://api.github.com/repos/jolavb/Sno_Demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jolavb/Sno_Demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/jolavb/Sno_Demo/contents/{+path}","compare_url":"https://api.github.com/repos/jolavb/Sno_Demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jolavb/Sno_Demo/merges","archive_url":"https://api.github.com/repos/jolavb/Sno_Demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jolavb/Sno_Demo/downloads","issues_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues{/number}","pulls_url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls{/number}","milestones_url":"https://api.github.com/repos/jolavb/Sno_Demo/milestones{/number}","notifications_url":"https://api.github.com/repos/jolavb/Sno_Demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jolavb/Sno_Demo/labels{/name}","releases_url":"https://api.github.com/repos/jolavb/Sno_Demo/releases{/id}","deployments_url":"https://api.github.com/repos/jolavb/Sno_Demo/deployments","created_at":"2018-03-23T12:50:30Z","updated_at":"2018-04-11T13:04:59Z","pushed_at":"2018-04-11T18:40:43Z","git_url":"git://github.com/jolavb/Sno_Demo.git","ssh_url":"git@github.com:jolavb/Sno_Demo.git","clone_url":"https://github.com/jolavb/Sno_Demo.git","svn_url":"https://github.com/jolavb/Sno_Demo","homepage":null,"size":3047,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"jolavb:master","ref":"master","sha":"99c2ce9b4879bdc457094729f4a4f20ee5b5a022","user":{"login":"jolavb","id":25570080,"avatar_url":"https://avatars1.githubusercontent.com/u/25570080?v=4","gravatar_id":"","url":"https://api.github.com/users/jolavb","html_url":"https://github.com/jolavb","followers_url":"https://api.github.com/users/jolavb/followers","following_url":"https://api.github.com/users/jolavb/following{/other_user}","gists_url":"https://api.github.com/users/jolavb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolavb/subscriptions","organizations_url":"https://api.github.com/users/jolavb/orgs","repos_url":"https://api.github.com/users/jolavb/repos","events_url":"https://api.github.com/users/jolavb/events{/privacy}","received_events_url":"https://api.github.com/users/jolavb/received_events","type":"User","site_admin":false},"repo":{"id":126484611,"name":"Sno_Demo","full_name":"jolavb/Sno_Demo","owner":{"login":"jolavb","id":25570080,"avatar_url":"https://avatars1.githubusercontent.com/u/25570080?v=4","gravatar_id":"","url":"https://api.github.com/users/jolavb","html_url":"https://github.com/jolavb","followers_url":"https://api.github.com/users/jolavb/followers","following_url":"https://api.github.com/users/jolavb/following{/other_user}","gists_url":"https://api.github.com/users/jolavb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolavb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolavb/subscriptions","organizations_url":"https://api.github.com/users/jolavb/orgs","repos_url":"https://api.github.com/users/jolavb/repos","events_url":"https://api.github.com/users/jolavb/events{/privacy}","received_events_url":"https://api.github.com/users/jolavb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jolavb/Sno_Demo","description":null,"fork":false,"url":"https://api.github.com/repos/jolavb/Sno_Demo","forks_url":"https://api.github.com/repos/jolavb/Sno_Demo/forks","keys_url":"https://api.github.com/repos/jolavb/Sno_Demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jolavb/Sno_Demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jolavb/Sno_Demo/teams","hooks_url":"https://api.github.com/repos/jolavb/Sno_Demo/hooks","issue_events_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues/events{/number}","events_url":"https://api.github.com/repos/jolavb/Sno_Demo/events","assignees_url":"https://api.github.com/repos/jolavb/Sno_Demo/assignees{/user}","branches_url":"https://api.github.com/repos/jolavb/Sno_Demo/branches{/branch}","tags_url":"https://api.github.com/repos/jolavb/Sno_Demo/tags","blobs_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jolavb/Sno_Demo/statuses/{sha}","languages_url":"https://api.github.com/repos/jolavb/Sno_Demo/languages","stargazers_url":"https://api.github.com/repos/jolavb/Sno_Demo/stargazers","contributors_url":"https://api.github.com/repos/jolavb/Sno_Demo/contributors","subscribers_url":"https://api.github.com/repos/jolavb/Sno_Demo/subscribers","subscription_url":"https://api.github.com/repos/jolavb/Sno_Demo/subscription","commits_url":"https://api.github.com/repos/jolavb/Sno_Demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/jolavb/Sno_Demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/jolavb/Sno_Demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/jolavb/Sno_Demo/contents/{+path}","compare_url":"https://api.github.com/repos/jolavb/Sno_Demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jolavb/Sno_Demo/merges","archive_url":"https://api.github.com/repos/jolavb/Sno_Demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jolavb/Sno_Demo/downloads","issues_url":"https://api.github.com/repos/jolavb/Sno_Demo/issues{/number}","pulls_url":"https://api.github.com/repos/jolavb/Sno_Demo/pulls{/number}","milestones_url":"https://api.github.com/repos/jolavb/Sno_Demo/milestones{/number}","notifications_url":"https://api.github.com/repos/jolavb/Sno_Demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jolavb/Sno_Demo/labels{/name}","releases_url":"https://api.github.com/repos/jolavb/Sno_Demo/releases{/id}","deployments_url":"https://api.github.com/repos/jolavb/Sno_Demo/deployments","created_at":"2018-03-23T12:50:30Z","updated_at":"2018-04-11T13:04:59Z","pushed_at":"2018-04-11T18:40:43Z","git_url":"git://github.com/jolavb/Sno_Demo.git","ssh_url":"git@github.com:jolavb/Sno_Demo.git","clone_url":"https://github.com/jolavb/Sno_Demo.git","svn_url":"https://github.com/jolavb/Sno_Demo","homepage":null,"size":3047,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28"},"html":{"href":"https://github.com/jolavb/Sno_Demo/pull/28"},"issue":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/issues/28"},"comments":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/jolavb/Sno_Demo/statuses/6798198ec372842067bb87af4e707b5b57021779"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"caacree"}}