{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-nio/issues/123","repository_url":"https://api.github.com/repos/apple/swift-nio","labels_url":"https://api.github.com/repos/apple/swift-nio/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-nio/issues/123/comments","events_url":"https://api.github.com/repos/apple/swift-nio/issues/123/events","html_url":"https://github.com/apple/swift-nio/pull/123","id":304091251,"number":123,"title":"make isOpen a computed property","user":{"login":"toffaletti","id":145012,"avatar_url":"https://avatars0.githubusercontent.com/u/145012?v=4","gravatar_id":"","url":"https://api.github.com/users/toffaletti","html_url":"https://github.com/toffaletti","followers_url":"https://api.github.com/users/toffaletti/followers","following_url":"https://api.github.com/users/toffaletti/following{/other_user}","gists_url":"https://api.github.com/users/toffaletti/gists{/gist_id}","starred_url":"https://api.github.com/users/toffaletti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffaletti/subscriptions","organizations_url":"https://api.github.com/users/toffaletti/orgs","repos_url":"https://api.github.com/users/toffaletti/repos","events_url":"https://api.github.com/users/toffaletti/events{/privacy}","received_events_url":"https://api.github.com/users/toffaletti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-10T18:09:45Z","updated_at":"2018-03-10T18:54:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/123","html_url":"https://github.com/apple/swift-nio/pull/123","diff_url":"https://github.com/apple/swift-nio/pull/123.diff","patch_url":"https://github.com/apple/swift-nio/pull/123.patch"},"body":"Motivation:\r\n\r\nReduce memory footprint of BaseSocket and FileHandle\r\n\r\nModifications:\r\n\r\n- made isOpen a computed var from 'descriptor >= 0'\r\n- add withSocketpair to TestUtils\r\n- use real pipe and socketpair file descriptors for tests\r\n\r\nResult:\r\n\r\n- isOpen no longer requires storage space\r\n- close() sets descriptor to -1\r\n- descriptor property changed from let to var\r\n- tests will need to use valid file descriptors"},"comment":{"url":"https://api.github.com/repos/apple/swift-nio/issues/comments/372055256","html_url":"https://github.com/apple/swift-nio/pull/123#issuecomment-372055256","issue_url":"https://api.github.com/repos/apple/swift-nio/issues/123","id":372055256,"user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T18:54:45Z","updated_at":"2018-03-10T18:54:45Z","author_association":"MEMBER","body":"@swift-nio-bot test this please"}}
{"actor":{"display_login":"normanmaurer"}}