{"action":"created","issue":{"url":"https://api.github.com/repos/ButterFlight/butterflight/issues/162","repository_url":"https://api.github.com/repos/ButterFlight/butterflight","labels_url":"https://api.github.com/repos/ButterFlight/butterflight/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/ButterFlight/butterflight/issues/162/comments","events_url":"https://api.github.com/repos/ButterFlight/butterflight/issues/162/events","html_url":"https://github.com/ButterFlight/butterflight/pull/162","id":328148138,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzYxMjUw","number":162,"title":"\"Buttered Pids\" are equivalent to \"Classic Pids\" in the absence of Setpoint Weight and Dterm Notch","user":{"login":"lehftfield","id":39786580,"node_id":"MDQ6VXNlcjM5Nzg2NTgw","avatar_url":"https://avatars1.githubusercontent.com/u/39786580?v=4","gravatar_id":"","url":"https://api.github.com/users/lehftfield","html_url":"https://github.com/lehftfield","followers_url":"https://api.github.com/users/lehftfield/followers","following_url":"https://api.github.com/users/lehftfield/following{/other_user}","gists_url":"https://api.github.com/users/lehftfield/gists{/gist_id}","starred_url":"https://api.github.com/users/lehftfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehftfield/subscriptions","organizations_url":"https://api.github.com/users/lehftfield/orgs","repos_url":"https://api.github.com/users/lehftfield/repos","events_url":"https://api.github.com/users/lehftfield/events{/privacy}","received_events_url":"https://api.github.com/users/lehftfield/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-05-31T13:53:40Z","updated_at":"2018-05-31T16:32:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ButterFlight/butterflight/pulls/162","html_url":"https://github.com/ButterFlight/butterflight/pull/162","diff_url":"https://github.com/ButterFlight/butterflight/pull/162.diff","patch_url":"https://github.com/ButterFlight/butterflight/pull/162.patch"},"body":"This unit test has been built to prove that \"buttered pids\" are no different than \"classic pids\" when the dterm notch is disabled setpoint weight is set to zero.\r\n\r\nThe additional code and configuration is superfluous bloat and adds no additional value.  If you feel differently, please write a test that proves otherwise.\r\n\r\n```[==========] Running 8 tests from 1 test case.\r\n[----------] Global test environment set-up.\r\n[----------] 8 tests from ButteredPidsHypeTest\r\n[ RUN      ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_SP\r\n[       OK ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_SP (75 ms)\r\n[ RUN      ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_NOSP\r\n[       OK ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_NOSP (89 ms)\r\n[ RUN      ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_SP_LPF\r\n[       OK ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_SP_LPF (90 ms)\r\n[ RUN      ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_NOSP_LPF\r\n[       OK ] ButteredPidsHypeTest.NoSetpointWeightAndNotch_NOSP_LPF (97 ms)\r\n[ RUN      ] ButteredPidsHypeTest.FailOnSetpointWeight_SP\r\n[       OK ] ButteredPidsHypeTest.FailOnSetpointWeight_SP (0 ms)\r\n[ RUN      ] ButteredPidsHypeTest.FailOnSetpointWeight_NOSP\r\n[       OK ] ButteredPidsHypeTest.FailOnSetpointWeight_NOSP (0 ms)\r\n[ RUN      ] ButteredPidsHypeTest.FailOnNotch_SP\r\n[       OK ] ButteredPidsHypeTest.FailOnNotch_SP (0 ms)\r\n[ RUN      ] ButteredPidsHypeTest.FailOnNotch_NOSP\r\n[       OK ] ButteredPidsHypeTest.FailOnNotch_NOSP (0 ms)\r\n[----------] 8 tests from ButteredPidsHypeTest (352 ms total)```"},"comment":{"url":"https://api.github.com/repos/ButterFlight/butterflight/issues/comments/393593093","html_url":"https://github.com/ButterFlight/butterflight/pull/162#issuecomment-393593093","issue_url":"https://api.github.com/repos/ButterFlight/butterflight/issues/162","id":393593093,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzU5MzA5Mw==","user":{"login":"lehftfield","id":39786580,"node_id":"MDQ6VXNlcjM5Nzg2NTgw","avatar_url":"https://avatars1.githubusercontent.com/u/39786580?v=4","gravatar_id":"","url":"https://api.github.com/users/lehftfield","html_url":"https://github.com/lehftfield","followers_url":"https://api.github.com/users/lehftfield/followers","following_url":"https://api.github.com/users/lehftfield/following{/other_user}","gists_url":"https://api.github.com/users/lehftfield/gists{/gist_id}","starred_url":"https://api.github.com/users/lehftfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehftfield/subscriptions","organizations_url":"https://api.github.com/users/lehftfield/orgs","repos_url":"https://api.github.com/users/lehftfield/repos","events_url":"https://api.github.com/users/lehftfield/events{/privacy}","received_events_url":"https://api.github.com/users/lehftfield/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T16:32:08Z","updated_at":"2018-05-31T16:32:08Z","author_association":"NONE","body":"I have tried to join the slack but see nothing but people trolling other flight controller software.  I have no desire to join a community forum where moderators are tolerant of childish behavior."}}
{"actor":{"display_login":"lehftfield"}}