{"push_id":3067519185,"size":32,"distinct_size":32,"ref":"refs/heads/master","head":"d1d091ba73f574ae5eb189fe7655c67bf5d338cf","before":"651ac4461c2c92952df39f75a9d177c746e60b57","commits":[{"sha":"5e3bd712d1800217038e80ae2b8969484ddfa475","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Fix bip65-cltv-p2p test for pre-fork conditions\n\nSummary: Fixes this test to pass as it did pre-fork. This does *not* fix the test for post-fork testing, but gives us a passing test to build forward on.\n\nTest Plan: test_runner.py bip65-cltv-p2p\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2070","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/5e3bd712d1800217038e80ae2b8969484ddfa475"},{"sha":"df358b788cdb9ce65715b7cbabbb038479c18cde","author":{"name":"Amaury Séchet","email":"0e504717262715831a4568194b28f33dfb77b110@gmail.com"},"message":"Ensure CPU mining is reliable\n\nSummary: Generating an extra nonce in the coinbase may lead to have an undersized coinbasewhen CPU mining.\n\nTest Plan: Repeatedly use generatetoaddress RPC call.\n\nReviewers: #bitcoin_abc, jasonbcox\n\nReviewed By: #bitcoin_abc, jasonbcox\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2073","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/df358b788cdb9ce65715b7cbabbb038479c18cde"},{"sha":"8e5124edc5b5a406939ddcbd9d5b3f04d355ea0e","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Fix nulldummy.py transaction ordering\n\nSummary: Fix post-fork behavior for nulldummy tests\n\nTest Plan: test_runner.py nulldummy\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2072","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/8e5124edc5b5a406939ddcbd9d5b3f04d355ea0e"},{"sha":"013dfca8ee5c3c414f553c408b049c819747fbda","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Consolidate tx rehashing in helper function as expected\n\nSummary: Rehashing the tx in the helper method makes it's usage less error-prone\n\nTest Plan: test_runner.py bip65-cltv-p2p\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2071","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/013dfca8ee5c3c414f553c408b049c819747fbda"},{"sha":"7a3f5d84bcca37ff2a5f2bd515ba944616bbdb7a","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Fix absurdly-high-fee failure in bip65-cltv-p2p.py\n\nSummary:\nThis test is paying 49 coins in fees, which triggers absurdly-high-fee as a failure.\nAdding a tx validity check helped immensely while debug this, so leaving it in seems prudent.\n\nTest Plan: test_runner.py bip65-cltv-p2p\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2075","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/7a3f5d84bcca37ff2a5f2bd515ba944616bbdb7a"},{"sha":"2b4be88522d4dd1ebf0c4af6460376cf4760b1d6","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Fix transaction ordering in abc-mempool-accept-txn\n\nSummary: See title\n\nTest Plan: test_runner.py abc-mempool-accept-tnx\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2074","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/2b4be88522d4dd1ebf0c4af6460376cf4760b1d6"},{"sha":"0e31ab2753c0d2dbbcee303556c43b646d11e78d","author":{"name":"Amaury Séchet","email":"0e504717262715831a4568194b28f33dfb77b110@gmail.com"},"message":"Make error message more meaningful when a block contains a duplicate transaction\n\nSummary: It also allows to bail early thanks to CTOR.\n\nTest Plan: Added tests cases.\n\nReviewers: #bitcoin_abc, jasonbcox\n\nReviewed By: #bitcoin_abc, jasonbcox\n\nSubscribers: jasonbcox\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2076","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/0e31ab2753c0d2dbbcee303556c43b646d11e78d"},{"sha":"d34870389ab4df6981874c9df316d944d4080dda","author":{"name":"Amaury Séchet","email":"0e504717262715831a4568194b28f33dfb77b110@gmail.com"},"message":"Nits in AcceptBlockHeader\n\nSummary: As per title.\n\nTest Plan:\n  make check\n\nReviewers: #bitcoin_abc, jasonbcox\n\nReviewed By: #bitcoin_abc, jasonbcox\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2084","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/d34870389ab4df6981874c9df316d944d4080dda"},{"sha":"388d3c1f12b213f8dcd40234a32ed2f38e45c6cc","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Fixed p2p-compactblocks failures\n\nSummary: CTOR changes tx ordering, so selecting hand-picked tx indices in a block is no longer possible.  Fixes this + tx padding\n\nTest Plan: test_runner.py p2p-compactblocks\n\nReviewers: deadalnix, schancel, Fabien, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2078","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/388d3c1f12b213f8dcd40234a32ed2f38e45c6cc"},{"sha":"d9b8913c420408961cd313dc9fb07ffcb3d4c2ec","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"[qa] Fix invalidblockrequest to work with magnetic anomaly upgrade\n\nSummary: This update fixes issues with CTOR and CLEANSTACK enforcement after the 15th of November 2018.\n\nTest Plan: ./test/functional/test_runner.py invalidblockrequest\n\nReviewers: #bitcoin_abc, jasonbcox\n\nReviewed By: #bitcoin_abc, jasonbcox\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2082","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/d9b8913c420408961cd313dc9fb07ffcb3d4c2ec"},{"sha":"b8e3cc2f834caa187b6e18d945f9efacebd2bd4b","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Cleanup pre-fork testing for bip68-sequence\n\nSummary: Removed the pre-fork configuration.\n\nTest Plan: test_runner.py bip68-sequence (ran multiple times)\n\nReviewers: deadalnix, schancel, Fabien, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2087","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/b8e3cc2f834caa187b6e18d945f9efacebd2bd4b"},{"sha":"f0afbcc15f098499ad99d2d12a037bc69b8b8f13","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"[qa] fix abc-p2p-fullblock test to support magnetic anomaly\n\nSummary: Fix failures due to >100 byte tx size requirement, and CTOR.\n\nTest Plan:\n  ./test/functional/test_runner.py abc-p2p-fullblocktest\n\nReviewers: #bitcoin_abc, schancel, deadalnix\n\nReviewed By: #bitcoin_abc, deadalnix\n\nSubscribers: deadalnix, Fabien, teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2086","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/f0afbcc15f098499ad99d2d12a037bc69b8b8f13"},{"sha":"5e8bcc09fbbcf45829e6ea33c9f38c453118bfb9","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"[qa] fix transaction ordering and padding in abc-p2p-compactblocks.py\n\nSummary:\nFix `abc-p2p-compactblocks.py` to support magnetic anomaly upgrade's transaction ordering and padding requirements.\n\nDepends on D2086\n\nTest Plan: test_runner.py abc-p2p-compactblocks\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: schancel, #bitcoin_abc\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2079","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/5e8bcc09fbbcf45829e6ea33c9f38c453118bfb9"},{"sha":"f4c4163277153dcca7314e2a3b66157eaa639758","author":{"name":"Amaury Séchet","email":"0e504717262715831a4568194b28f33dfb77b110@gmail.com"},"message":"[qa] Fix p2p-fullblocktest.py for magnetic anomaly\n\nSummary: Make sure it pad and order transactions properly.\n\nTest Plan:\n  ./test/functional/test_runner.py p2p-fullblocktest\n\nReviewers: #bitcoin_abc, jasonbcox\n\nReviewed By: #bitcoin_abc, jasonbcox\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2088","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/f4c4163277153dcca7314e2a3b66157eaa639758"},{"sha":"65b595d16cc56c5aa621e75b39b2579942490a3d","author":{"name":"Amaury Séchet","email":"0e504717262715831a4568194b28f33dfb77b110@gmail.com"},"message":"Fix sources of flackiness in p2p-fullblocktest.py\n\nSummary: Some of the test end up being dependent on transaction order (base on ids) and therefore flacky.\n\nTest Plan:\n  ./test/functional/test_runner.py p2p-fullblocktest.py\n\nReviewers: #bitcoin_abc, schancel\n\nReviewed By: #bitcoin_abc, schancel\n\nSubscribers: schancel, teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2090","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/65b595d16cc56c5aa621e75b39b2579942490a3d"},{"sha":"5a97f9ae4add2453a51092aee63f5c2d938c6b8f","author":{"name":"Shammah Chancellor","email":"989451d7177dcf7e1da3d3c40296cac6714409ff@bitcoinabc.org"},"message":"[tests] Fix checkinputs_test to work under magnetic anomaly\n\nSummary:\nAs per title. Add CTOR ordering to test block construction.  Use NULLDUMMY\ninstead of CLEANSTACK for checking consensus vs non-consensus script cache behavior.\n\nTest Plan:\n  make -j10 VERBOSE=1 check\n\nReviewers: #bitcoin_abc, deadalnix, jasonbcox\n\nReviewed By: #bitcoin_abc, deadalnix, jasonbcox\n\nSubscribers: jasonbcox, deadalnix, teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2092","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/5a97f9ae4add2453a51092aee63f5c2d938c6b8f"},{"sha":"9b241b4087c5b48bd77bb739acb4f4bdef078794","author":{"name":"Shammah Chancellor","email":"989451d7177dcf7e1da3d3c40296cac6714409ff@bitcoinabc.org"},"message":"Updates version to v0.18.5\n\nSummary: As per title.  Update version strings to v0.18.5\n\nTest Plan:\n  make check && ./test/functional/test_runner.py\n\nReviewers: jasonbcox, Mengerian, akb, #bitcoin_abc\n\nReviewed By: jasonbcox, Mengerian, akb, #bitcoin_abc\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2066","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/9b241b4087c5b48bd77bb739acb4f4bdef078794"},{"sha":"1a1b68c4d0e8db5c986e2dbf49b822fd3e275227","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Update chainparams for 0.18.5 release\n\nSummary: Not enough blocks on testnet since the fork to bother updating testnet params.\n\nTest Plan: N/A (IBD will come later for sanity)\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: deadalnix, #bitcoin_abc\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2093","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/1a1b68c4d0e8db5c986e2dbf49b822fd3e275227"},{"sha":"e0797f6dbefea651420f474940963b470a0931fd","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Fix pad_tx off by one error + nits\n\nSummary: See title\n\nTest Plan: test_runner.py\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: schancel, #bitcoin_abc\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2096","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/e0797f6dbefea651420f474940963b470a0931fd"},{"sha":"a0038cf47f56c21b96ac1f51fe711ce297ecebce","author":{"name":"Jason B. Cox","email":"1a73af9e7ae00182733b2292511b814be66f065f@jasonbcox.com"},"message":"Assert on block number earlier in next_block\n\nSummary: This helps debug just a little better\n\nTest Plan: read it (test is currently broken)\n\nReviewers: deadalnix, schancel, #bitcoin_abc\n\nReviewed By: schancel, #bitcoin_abc\n\nSubscribers: teamcity\n\nDifferential Revision: https://reviews.bitcoinabc.org/D2097","distinct":true,"url":"https://api.github.com/repos/Scronty/bitcoin-abc/commits/a0038cf47f56c21b96ac1f51fe711ce297ecebce"}]}
{"actor":{"display_login":"Scronty"}}