{"push_id":2299943031,"size":109,"distinct_size":1,"ref":"refs/heads/lld","head":"d37e4b5f6ff39c34b50e99f3b9213c08230fbccb","before":"cbf406f4222dfce6755ccbef48382f637cb39a8b","commits":[{"sha":"c2e26121dbf6f2ca08e772415b80bc2d80c0d952","author":{"name":"James Mantooth","email":"a9f2236517f5f13e60a0e59f4ecc1141f1134ae0@gmail.com"},"message":"Punctuation and clarity fixes.","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/c2e26121dbf6f2ca08e772415b80bc2d80c0d952"},{"sha":"37771d42d72d80a3025cf1bbf2aa58df79669a4e","author":{"name":"oberien","email":"6ea95380fb47cae1e971baafed9994c956748cfa@gmx.de"},"message":"Specialize StepBy::nth","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/37771d42d72d80a3025cf1bbf2aa58df79669a4e"},{"sha":"5850f0b742430a1b1b5ae7d2491dce6ca10e20d3","author":{"name":"oberien","email":"6ea95380fb47cae1e971baafed9994c956748cfa@gmx.de"},"message":"Fix off-by-ones","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/5850f0b742430a1b1b5ae7d2491dce6ca10e20d3"},{"sha":"d33cc12eed3df459db3c9ae2dd89df9cc6e45dd6","author":{"name":"oberien","email":"6ea95380fb47cae1e971baafed9994c956748cfa@gmx.de"},"message":"Unit Tests","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/d33cc12eed3df459db3c9ae2dd89df9cc6e45dd6"},{"sha":"f08dec114f6008cb7a906ffd55c221fd30d70987","author":{"name":"oberien","email":"6ea95380fb47cae1e971baafed9994c956748cfa@gmx.de"},"message":"Handle Overflow","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/f08dec114f6008cb7a906ffd55c221fd30d70987"},{"sha":"f72b7f7c86b16fe8b76c4eb02052943dd6ef1ab2","author":{"name":"oberien","email":"6ea95380fb47cae1e971baafed9994c956748cfa@gmx.de"},"message":"Optimize StepBy::nth overflow handling","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/f72b7f7c86b16fe8b76c4eb02052943dd6ef1ab2"},{"sha":"c4befe1710b3c394018ca65a6e99e109d081f16e","author":{"name":"Mark Mansi","email":"cc3d25876970e96cb489322bc387fff2e68c6cf9@cs.wisc.edu"},"message":"Run rustfmt and add comments","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/c4befe1710b3c394018ca65a6e99e109d081f16e"},{"sha":"49431d49661af7a3e55743a398346903ef58f20f","author":{"name":"Mark Mansi","email":"cc3d25876970e96cb489322bc387fff2e68c6cf9@cs.wisc.edu"},"message":"Add a bunch of doc comments","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/49431d49661af7a3e55743a398346903ef58f20f"},{"sha":"4a0da4cf2c7a2b5903fd1b8bc124f8963ce1b535","author":{"name":"oberien","email":"6ea95380fb47cae1e971baafed9994c956748cfa@gmx.de"},"message":"Spacing","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/4a0da4cf2c7a2b5903fd1b8bc124f8963ce1b535"},{"sha":"ca0c0805693b08566cf118b676533be776005494","author":{"name":"Mark Mansi","email":"cc3d25876970e96cb489322bc387fff2e68c6cf9@cs.wisc.edu"},"message":"Fix typos","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/ca0c0805693b08566cf118b676533be776005494"},{"sha":"c6377f8e17cd7f3cf906397f3f48b522b0521471","author":{"name":"Ryan Cumming","email":"032784a37a503e1c2dc73d2d1fc40559f01a77e8@gmail.com"},"message":"Avoid underflow in render_source_line\n\nWhile testing rust-lang/rust#47655 I was able to make the compiler panic\nwhen it's compiled with debug assertions:\n\n```shell\n> rustc /dev/null --crate-type proc-macro\n\nerror: internal compiler error: unexpected panic\n\nnote: the compiler unexpectedly panicked. this is a bug.\n\nnote: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports\n\nnote: rustc 1.25.0-dev running on x86_64-apple-darwin\n\nnote: run with `RUST_BACKTRACE=1` for a backtrace\n\nthread 'rustc' panicked at 'attempt to subtract with overflow', librustc_errors/emitter.rs:287:49\n```\n\nWithout debug assertions the following warning is emitted:\n\n```shell\n> rustc /dev/null --crate-type proc-macro\n\nwarning: unused variable: `registrar`\n --> /dev/null:0:1\n  |\n  |\n  = note: #[warn(unused_variables)] on by default\n  = note: to avoid this warning, consider using `_registrar` instead\n```\n\nThe panic is due to the unused variable warning being spanned to\n`/dev/null:0:1`. When `render_source_line` subtracts 1 from the line\nnumber to look up the source line it panics due to underflow. Without\ndebug assertions this would wrap and cause us to return a blank string\ninstead.\n\nFix by explicitly testing for 0 and exiting early. I'm unsure how to\nautomatically test this now that rust-lang/rust#46655 has been approved.","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/c6377f8e17cd7f3cf906397f3f48b522b0521471"},{"sha":"831ff775703eb5126f741fc3be1cf829ec060011","author":{"name":"Corentin Henry","email":"056b5485c01afc7bf2fccddb8d6213f4d8146b38@gmail.com"},"message":"implement Send for process::Command on unix\n\ncloses https://github.com/rust-lang/rust/issues/47751","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/831ff775703eb5126f741fc3be1cf829ec060011"},{"sha":"9e6ed17c4f5befef64fa9e8a1d2b2f155c345cac","author":{"name":"Corentin Henry","email":"056b5485c01afc7bf2fccddb8d6213f4d8146b38@gmail.com"},"message":"make Command.argv Send on unix platforms\n\nImplementing Send for a specific field rather than the whole struct is\nsafer: if a field is changed/modified and becomes non-Send, we can catch\nit.","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/9e6ed17c4f5befef64fa9e8a1d2b2f155c345cac"},{"sha":"0ac465924e6ae4380b25c38cbc14f425796fa2af","author":{"name":"varkor","email":"f27a17fc90c00d8c248d8510a1084221738b492b@varkor.com"},"message":"Add line numbers and columns to error messages spanning multiple files\n\nIf an error message is emitted that spans several files, only the\nprimary file currently has line and column data attached. This is\nuseful information, even in files other than the one in which the error\noccurs. We can often work out which line and column the error\ncorresponds to in other files — in this case it is helpful to add them\n(in the case of ambiguity, the first relevant line/column is picked,\nwhich is still helpful than none).","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/0ac465924e6ae4380b25c38cbc14f425796fa2af"},{"sha":"077d3434aa8a2a3064afcc1c9406a49d0acf0a8d","author":{"name":"Corentin Henry","email":"056b5485c01afc7bf2fccddb8d6213f4d8146b38@gmail.com"},"message":"add test checking that process::Command is Send","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/077d3434aa8a2a3064afcc1c9406a49d0acf0a8d"},{"sha":"c48f46ba368a5ae77acb0db46843a3e432ff87d3","author":{"name":"Niko Matsakis","email":"aa30189ba4dad768268e0d8a2ae502b7d4faf4d2@alum.mit.edu"},"message":"add regression test\n\nFixes #47139","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/c48f46ba368a5ae77acb0db46843a3e432ff87d3"},{"sha":"aa6cc6e1898067c4311e260960bca776f3e02715","author":{"name":"varkor","email":"f27a17fc90c00d8c248d8510a1084221738b492b@varkor.com"},"message":"Fix test in macro_backtrace","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/aa6cc6e1898067c4311e260960bca776f3e02715"},{"sha":"ac0c16d3b5cc5644b3311811e127411b87f3abf0","author":{"name":"Mark Mansi","email":"cc3d25876970e96cb489322bc387fff2e68c6cf9@cs.wisc.edu"},"message":"Run rustfmt on /libsyntax/ext/tt/macro_parser.rs","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/ac0c16d3b5cc5644b3311811e127411b87f3abf0"},{"sha":"0d7f193dd358cdc13506cac2e0b84fc473b628be","author":{"name":"Mark Mansi","email":"cc3d25876970e96cb489322bc387fff2e68c6cf9@cs.wisc.edu"},"message":"Added a bunch of comments to macro_parser.rs","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/0d7f193dd358cdc13506cac2e0b84fc473b628be"},{"sha":"6d4ed65585ebdd1e5cd7aa37936682675825b919","author":{"name":"Mark Mansi","email":"cc3d25876970e96cb489322bc387fff2e68c6cf9@cs.wisc.edu"},"message":"Added lots of comments + minor reorganization","distinct":false,"url":"https://api.github.com/repos/alexcrichton/rust/commits/6d4ed65585ebdd1e5cd7aa37936682675825b919"}]}
{"actor":{"display_login":"alexcrichton"}}