{"action":"created","issue":{"url":"https://api.github.com/repos/waqasbhatti/astrobase/issues/61","repository_url":"https://api.github.com/repos/waqasbhatti/astrobase","labels_url":"https://api.github.com/repos/waqasbhatti/astrobase/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/waqasbhatti/astrobase/issues/61/comments","events_url":"https://api.github.com/repos/waqasbhatti/astrobase/issues/61/events","html_url":"https://github.com/waqasbhatti/astrobase/pull/61","id":362306233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDYzOTI5","number":61,"title":" plotbase.plot_phased_mag_series: add model option","user":{"login":"lgbouma","id":13185735,"node_id":"MDQ6VXNlcjEzMTg1NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/13185735?v=4","gravatar_id":"","url":"https://api.github.com/users/lgbouma","html_url":"https://github.com/lgbouma","followers_url":"https://api.github.com/users/lgbouma/followers","following_url":"https://api.github.com/users/lgbouma/following{/other_user}","gists_url":"https://api.github.com/users/lgbouma/gists{/gist_id}","starred_url":"https://api.github.com/users/lgbouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgbouma/subscriptions","organizations_url":"https://api.github.com/users/lgbouma/orgs","repos_url":"https://api.github.com/users/lgbouma/repos","events_url":"https://api.github.com/users/lgbouma/events{/privacy}","received_events_url":"https://api.github.com/users/lgbouma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-20T18:21:15Z","updated_at":"2018-09-20T19:29:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/waqasbhatti/astrobase/pulls/61","html_url":"https://github.com/waqasbhatti/astrobase/pull/61","diff_url":"https://github.com/waqasbhatti/astrobase/pull/61.diff","patch_url":"https://github.com/waqasbhatti/astrobase/pull/61.patch"},"body":"looks like the following if you use it\r\n\r\n![wasp-18b_phased_initialguess_fit](https://user-images.githubusercontent.com/13185735/45838705-66e85b00-bce0-11e8-8c19-a2c294b6db22.png)\r\n"},"comment":{"url":"https://api.github.com/repos/waqasbhatti/astrobase/issues/comments/423304368","html_url":"https://github.com/waqasbhatti/astrobase/pull/61#issuecomment-423304368","issue_url":"https://api.github.com/repos/waqasbhatti/astrobase/issues/61","id":423304368,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzMwNDM2OA==","user":{"login":"waqasbhatti","id":1868184,"node_id":"MDQ6VXNlcjE4NjgxODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1868184?v=4","gravatar_id":"","url":"https://api.github.com/users/waqasbhatti","html_url":"https://github.com/waqasbhatti","followers_url":"https://api.github.com/users/waqasbhatti/followers","following_url":"https://api.github.com/users/waqasbhatti/following{/other_user}","gists_url":"https://api.github.com/users/waqasbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/waqasbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waqasbhatti/subscriptions","organizations_url":"https://api.github.com/users/waqasbhatti/orgs","repos_url":"https://api.github.com/users/waqasbhatti/repos","events_url":"https://api.github.com/users/waqasbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/waqasbhatti/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T19:29:00Z","updated_at":"2018-09-20T19:29:00Z","author_association":"OWNER","body":"Thanks, this is pretty awesome!\r\n\r\nMinor comment on the linewidth of the model plot: let's make this `linewidth=2` or so instead of `linewidth=1` so it's a bit more prominent.\r\n\r\nAlso, I'll take advantage of you working on this file already to ask if you mind adding a `plot_phased_magseries` function wrapper in plotbase.py that just calls `plot_phased_mag_series` with all the same args. This will make it mirror the `lcfit.[fitype]_fit_magseries` functions and makes for a bit more fluent API.\r\n"}}
{"actor":{"display_login":"waqasbhatti"}}