{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-heron/pulls/comments/230514721","pull_request_review_id":171279514,"id":230514721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUxNDcyMQ==","diff_hunk":"@@ -49,7 +50,14 @@ trait Builder {\n     * Creates a new Streamlet using the underlying generator\n     *\n     * @param generator The generator that generates the tuples of the streamlet\n-    * @return  a Streamlet representation of the source object\n+    * @return a Streamlet representation of the source object\n     */\n   def newSource[R](generator: Source[R]): Streamlet[R]\n+\n+  /**\n+   * Creates a new Streamlet using the provided spout\n+   * @param spout The spout that emits the tuples of the streamlet\n+   * @return a Streamlet representation of the spout object\n+   */\n+  def newSource[R](spout: IRichSpout): Streamlet[R]","path":"heron/api/src/scala/org/apache/heron/streamlet/scala/Builder.scala","position":22,"original_position":22,"commit_id":"31b119538b35c6cdc79305d1a67e119d46eb1a67","original_commit_id":"31b119538b35c6cdc79305d1a67e119d46eb1a67","user":{"login":"nwangtw","id":6353055,"node_id":"MDQ6VXNlcjYzNTMwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6353055?v=4","gravatar_id":"","url":"https://api.github.com/users/nwangtw","html_url":"https://github.com/nwangtw","followers_url":"https://api.github.com/users/nwangtw/followers","following_url":"https://api.github.com/users/nwangtw/following{/other_user}","gists_url":"https://api.github.com/users/nwangtw/gists{/gist_id}","starred_url":"https://api.github.com/users/nwangtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwangtw/subscriptions","organizations_url":"https://api.github.com/users/nwangtw/orgs","repos_url":"https://api.github.com/users/nwangtw/repos","events_url":"https://api.github.com/users/nwangtw/events{/privacy}","received_events_url":"https://api.github.com/users/nwangtw/received_events","type":"User","site_admin":false},"body":"Agreed. And there could be some bugs in the API since so far it seems people are testing it but I haven't heard anyone using it in prod yet.\r\n\r\nLet me prepare another PR to at least add the two Scala tests to java. https://github.com/apache/incubator-heron/issues/3101\r\n\r\nAnd we definitely need better IT coverage for Streamlet API.","created_at":"2018-11-02T21:32:54Z","updated_at":"2018-11-02T21:32:55Z","html_url":"https://github.com/apache/incubator-heron/pull/3032#discussion_r230514721","pull_request_url":"https://api.github.com/repos/apache/incubator-heron/pulls/3032","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-heron/pulls/comments/230514721"},"html":{"href":"https://github.com/apache/incubator-heron/pull/3032#discussion_r230514721"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-heron/pulls/3032"}},"in_reply_to_id":228765430},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-heron/pulls/3032","id":216812235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODEyMjM1","html_url":"https://github.com/apache/incubator-heron/pull/3032","diff_url":"https://github.com/apache/incubator-heron/pull/3032.diff","patch_url":"https://github.com/apache/incubator-heron/pull/3032.patch","issue_url":"https://api.github.com/repos/apache/incubator-heron/issues/3032","number":3032,"state":"open","locked":false,"title":"Nwang/add spout based source streamlet","user":{"login":"nwangtw","id":6353055,"node_id":"MDQ6VXNlcjYzNTMwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6353055?v=4","gravatar_id":"","url":"https://api.github.com/users/nwangtw","html_url":"https://github.com/nwangtw","followers_url":"https://api.github.com/users/nwangtw/followers","following_url":"https://api.github.com/users/nwangtw/following{/other_user}","gists_url":"https://api.github.com/users/nwangtw/gists{/gist_id}","starred_url":"https://api.github.com/users/nwangtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwangtw/subscriptions","organizations_url":"https://api.github.com/users/nwangtw/orgs","repos_url":"https://api.github.com/users/nwangtw/repos","events_url":"https://api.github.com/users/nwangtw/events{/privacy}","received_events_url":"https://api.github.com/users/nwangtw/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-20T00:22:47Z","updated_at":"2018-11-02T21:32:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad631957bc6495ce6f1b132592a45625d0d35693","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-heron/pulls/3032/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-heron/pulls/3032/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-heron/issues/3032/comments","statuses_url":"https://api.github.com/repos/apache/incubator-heron/statuses/31b119538b35c6cdc79305d1a67e119d46eb1a67","head":{"label":"nwangtw:nwang/add_spout_based_source_streamlet","ref":"nwang/add_spout_based_source_streamlet","sha":"31b119538b35c6cdc79305d1a67e119d46eb1a67","user":{"login":"nwangtw","id":6353055,"node_id":"MDQ6VXNlcjYzNTMwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6353055?v=4","gravatar_id":"","url":"https://api.github.com/users/nwangtw","html_url":"https://github.com/nwangtw","followers_url":"https://api.github.com/users/nwangtw/followers","following_url":"https://api.github.com/users/nwangtw/following{/other_user}","gists_url":"https://api.github.com/users/nwangtw/gists{/gist_id}","starred_url":"https://api.github.com/users/nwangtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwangtw/subscriptions","organizations_url":"https://api.github.com/users/nwangtw/orgs","repos_url":"https://api.github.com/users/nwangtw/repos","events_url":"https://api.github.com/users/nwangtw/events{/privacy}","received_events_url":"https://api.github.com/users/nwangtw/received_events","type":"User","site_admin":false},"repo":{"id":108322351,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMjIzNTE=","name":"heron","full_name":"nwangtw/heron","private":false,"owner":{"login":"nwangtw","id":6353055,"node_id":"MDQ6VXNlcjYzNTMwNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6353055?v=4","gravatar_id":"","url":"https://api.github.com/users/nwangtw","html_url":"https://github.com/nwangtw","followers_url":"https://api.github.com/users/nwangtw/followers","following_url":"https://api.github.com/users/nwangtw/following{/other_user}","gists_url":"https://api.github.com/users/nwangtw/gists{/gist_id}","starred_url":"https://api.github.com/users/nwangtw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwangtw/subscriptions","organizations_url":"https://api.github.com/users/nwangtw/orgs","repos_url":"https://api.github.com/users/nwangtw/repos","events_url":"https://api.github.com/users/nwangtw/events{/privacy}","received_events_url":"https://api.github.com/users/nwangtw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nwangtw/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/nwangtw/heron","forks_url":"https://api.github.com/repos/nwangtw/heron/forks","keys_url":"https://api.github.com/repos/nwangtw/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nwangtw/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nwangtw/heron/teams","hooks_url":"https://api.github.com/repos/nwangtw/heron/hooks","issue_events_url":"https://api.github.com/repos/nwangtw/heron/issues/events{/number}","events_url":"https://api.github.com/repos/nwangtw/heron/events","assignees_url":"https://api.github.com/repos/nwangtw/heron/assignees{/user}","branches_url":"https://api.github.com/repos/nwangtw/heron/branches{/branch}","tags_url":"https://api.github.com/repos/nwangtw/heron/tags","blobs_url":"https://api.github.com/repos/nwangtw/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nwangtw/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nwangtw/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/nwangtw/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nwangtw/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/nwangtw/heron/languages","stargazers_url":"https://api.github.com/repos/nwangtw/heron/stargazers","contributors_url":"https://api.github.com/repos/nwangtw/heron/contributors","subscribers_url":"https://api.github.com/repos/nwangtw/heron/subscribers","subscription_url":"https://api.github.com/repos/nwangtw/heron/subscription","commits_url":"https://api.github.com/repos/nwangtw/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/nwangtw/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/nwangtw/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/nwangtw/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/nwangtw/heron/contents/{+path}","compare_url":"https://api.github.com/repos/nwangtw/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nwangtw/heron/merges","archive_url":"https://api.github.com/repos/nwangtw/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nwangtw/heron/downloads","issues_url":"https://api.github.com/repos/nwangtw/heron/issues{/number}","pulls_url":"https://api.github.com/repos/nwangtw/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/nwangtw/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/nwangtw/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nwangtw/heron/labels{/name}","releases_url":"https://api.github.com/repos/nwangtw/heron/releases{/id}","deployments_url":"https://api.github.com/repos/nwangtw/heron/deployments","created_at":"2017-10-25T20:27:29Z","updated_at":"2018-10-23T02:28:05Z","pushed_at":"2018-11-02T17:52:16Z","git_url":"git://github.com/nwangtw/heron.git","ssh_url":"git@github.com:nwangtw/heron.git","clone_url":"https://github.com/nwangtw/heron.git","svn_url":"https://github.com/nwangtw/heron","homepage":"http://heronstreaming.io","size":195914,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"72509b91f1744a1d85f5982d5c69741120409eb4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"node_id":"MDEwOlJlcG9zaXRvcnk0MzE1ODY5NA==","name":"incubator-heron","full_name":"apache/incubator-heron","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-heron","description":"Apache Heron (Incubating) is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/apache/incubator-heron","forks_url":"https://api.github.com/repos/apache/incubator-heron/forks","keys_url":"https://api.github.com/repos/apache/incubator-heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-heron/teams","hooks_url":"https://api.github.com/repos/apache/incubator-heron/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-heron/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-heron/events","assignees_url":"https://api.github.com/repos/apache/incubator-heron/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-heron/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-heron/tags","blobs_url":"https://api.github.com/repos/apache/incubator-heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-heron/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-heron/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-heron/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-heron/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-heron/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-heron/subscription","commits_url":"https://api.github.com/repos/apache/incubator-heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-heron/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-heron/merges","archive_url":"https://api.github.com/repos/apache/incubator-heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-heron/downloads","issues_url":"https://api.github.com/repos/apache/incubator-heron/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-heron/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-heron/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-heron/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-heron/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2018-11-02T20:45:55Z","pushed_at":"2018-11-02T20:45:41Z","git_url":"git://github.com/apache/incubator-heron.git","ssh_url":"git@github.com:apache/incubator-heron.git","clone_url":"https://github.com/apache/incubator-heron.git","svn_url":"https://github.com/apache/incubator-heron","homepage":"http://heronstreaming.io","size":222926,"stargazers_count":3275,"watchers_count":3275,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":593,"mirror_url":null,"archived":false,"open_issues_count":385,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":593,"open_issues":385,"watchers":3275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-heron/pulls/3032"},"html":{"href":"https://github.com/apache/incubator-heron/pull/3032"},"issue":{"href":"https://api.github.com/repos/apache/incubator-heron/issues/3032"},"comments":{"href":"https://api.github.com/repos/apache/incubator-heron/issues/3032/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-heron/pulls/3032/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-heron/pulls/3032/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-heron/statuses/31b119538b35c6cdc79305d1a67e119d46eb1a67"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nwangtw"}}