{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments/199319761","pull_request_review_id":133422690,"id":199319761,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMxOTc2MQ==","diff_hunk":"@@ -33,7 +34,8 @@ func contextsFromGlobalOptions(c *cli.Context) (*types.SystemContext, *types.Sys\n \n func copyHandler(c *cli.Context) error {\n \tif len(c.Args()) != 2 {\n-\t\treturn cli.ShowCommandHelp(c, \"copy\")\n+\t\tcli.ShowCommandHelp(c, \"copy\")\n+\t\treturn errors.New(\"Exactly two non-option arguments expected\")","path":"cmd/skopeo/copy.go","position":14,"original_position":14,"commit_id":"2f553268a18c0dec95ce16698686e54791ef55f9","original_commit_id":"2f553268a18c0dec95ce16698686e54791ef55f9","user":{"login":"rhatdan","id":2000835,"node_id":"MDQ6VXNlcjIwMDA4MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2000835?v=4","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"Drop `non-option`\r\nLets do.\r\nExactly two arguments required\r\n","created_at":"2018-06-30T10:45:52Z","updated_at":"2018-06-30T10:45:59Z","html_url":"https://github.com/projectatomic/skopeo/pull/520#discussion_r199319761","pull_request_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/520","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments/199319761"},"html":{"href":"https://github.com/projectatomic/skopeo/pull/520#discussion_r199319761"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/520"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/skopeo/pulls/520","id":198470946,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDcwOTQ2","html_url":"https://github.com/projectatomic/skopeo/pull/520","diff_url":"https://github.com/projectatomic/skopeo/pull/520.diff","patch_url":"https://github.com/projectatomic/skopeo/pull/520.patch","issue_url":"https://api.github.com/repos/projectatomic/skopeo/issues/520","number":520,"state":"open","locked":false,"title":"Ensure that we still return 1, and print something to stderr, on (skopeo copy) failure","user":{"login":"mtrmac","id":7052838,"node_id":"MDQ6VXNlcjcwNTI4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7052838?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"body":"https://github.com/projectatomic/skopeo/pull/519 made `skopeo copy` suceed and print nothing to stderr; that could lead to hard-to-diagnose failures in rare corner cases, e.g. shell scripts which do\r\n`skopeo copy $src $dst` (as opposed to the correct `skopeo copy \"$src\" \"$dst\"` ) if `$src` and `$dst` are empty due to a previous failure.","created_at":"2018-06-30T10:38:42Z","updated_at":"2018-06-30T10:45:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc54efbef0e2c091b01daa8c594f5c72dfb1c0d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/520/commits","review_comments_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/520/comments","review_comment_url":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/skopeo/issues/520/comments","statuses_url":"https://api.github.com/repos/projectatomic/skopeo/statuses/2f553268a18c0dec95ce16698686e54791ef55f9","head":{"label":"mtrmac:copy-error-handling","ref":"copy-error-handling","sha":"2f553268a18c0dec95ce16698686e54791ef55f9","user":{"login":"mtrmac","id":7052838,"node_id":"MDQ6VXNlcjcwNTI4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7052838?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"repo":{"id":53720952,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyMDk1Mg==","name":"skopeo","full_name":"mtrmac/skopeo","owner":{"login":"mtrmac","id":7052838,"node_id":"MDQ6VXNlcjcwNTI4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7052838?v=4","gravatar_id":"","url":"https://api.github.com/users/mtrmac","html_url":"https://github.com/mtrmac","followers_url":"https://api.github.com/users/mtrmac/followers","following_url":"https://api.github.com/users/mtrmac/following{/other_user}","gists_url":"https://api.github.com/users/mtrmac/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrmac/subscriptions","organizations_url":"https://api.github.com/users/mtrmac/orgs","repos_url":"https://api.github.com/users/mtrmac/repos","events_url":"https://api.github.com/users/mtrmac/events{/privacy}","received_events_url":"https://api.github.com/users/mtrmac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtrmac/skopeo","description":" Work with remote images registries - retrieving information, images, signing content ","fork":true,"url":"https://api.github.com/repos/mtrmac/skopeo","forks_url":"https://api.github.com/repos/mtrmac/skopeo/forks","keys_url":"https://api.github.com/repos/mtrmac/skopeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtrmac/skopeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtrmac/skopeo/teams","hooks_url":"https://api.github.com/repos/mtrmac/skopeo/hooks","issue_events_url":"https://api.github.com/repos/mtrmac/skopeo/issues/events{/number}","events_url":"https://api.github.com/repos/mtrmac/skopeo/events","assignees_url":"https://api.github.com/repos/mtrmac/skopeo/assignees{/user}","branches_url":"https://api.github.com/repos/mtrmac/skopeo/branches{/branch}","tags_url":"https://api.github.com/repos/mtrmac/skopeo/tags","blobs_url":"https://api.github.com/repos/mtrmac/skopeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtrmac/skopeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtrmac/skopeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtrmac/skopeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtrmac/skopeo/statuses/{sha}","languages_url":"https://api.github.com/repos/mtrmac/skopeo/languages","stargazers_url":"https://api.github.com/repos/mtrmac/skopeo/stargazers","contributors_url":"https://api.github.com/repos/mtrmac/skopeo/contributors","subscribers_url":"https://api.github.com/repos/mtrmac/skopeo/subscribers","subscription_url":"https://api.github.com/repos/mtrmac/skopeo/subscription","commits_url":"https://api.github.com/repos/mtrmac/skopeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtrmac/skopeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtrmac/skopeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtrmac/skopeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtrmac/skopeo/contents/{+path}","compare_url":"https://api.github.com/repos/mtrmac/skopeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtrmac/skopeo/merges","archive_url":"https://api.github.com/repos/mtrmac/skopeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtrmac/skopeo/downloads","issues_url":"https://api.github.com/repos/mtrmac/skopeo/issues{/number}","pulls_url":"https://api.github.com/repos/mtrmac/skopeo/pulls{/number}","milestones_url":"https://api.github.com/repos/mtrmac/skopeo/milestones{/number}","notifications_url":"https://api.github.com/repos/mtrmac/skopeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtrmac/skopeo/labels{/name}","releases_url":"https://api.github.com/repos/mtrmac/skopeo/releases{/id}","deployments_url":"https://api.github.com/repos/mtrmac/skopeo/deployments","created_at":"2016-03-12T08:17:36Z","updated_at":"2018-06-04T13:50:14Z","pushed_at":"2018-06-30T10:38:11Z","git_url":"git://github.com/mtrmac/skopeo.git","ssh_url":"git@github.com:mtrmac/skopeo.git","clone_url":"https://github.com/mtrmac/skopeo.git","svn_url":"https://github.com/mtrmac/skopeo","homepage":"","size":6422,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"6e23a32282bfd9a63140c8f99eed6e7ddb0a74f5","user":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":53356367,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM1NjM2Nw==","name":"skopeo","full_name":"projectatomic/skopeo","owner":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/skopeo","description":"Work with remote images registries - retrieving information, images, signing content","fork":false,"url":"https://api.github.com/repos/projectatomic/skopeo","forks_url":"https://api.github.com/repos/projectatomic/skopeo/forks","keys_url":"https://api.github.com/repos/projectatomic/skopeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/skopeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/skopeo/teams","hooks_url":"https://api.github.com/repos/projectatomic/skopeo/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/skopeo/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/skopeo/events","assignees_url":"https://api.github.com/repos/projectatomic/skopeo/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/skopeo/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/skopeo/tags","blobs_url":"https://api.github.com/repos/projectatomic/skopeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/skopeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/skopeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/skopeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/skopeo/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/skopeo/languages","stargazers_url":"https://api.github.com/repos/projectatomic/skopeo/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/skopeo/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/skopeo/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/skopeo/subscription","commits_url":"https://api.github.com/repos/projectatomic/skopeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/skopeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/skopeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/skopeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/skopeo/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/skopeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/skopeo/merges","archive_url":"https://api.github.com/repos/projectatomic/skopeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/skopeo/downloads","issues_url":"https://api.github.com/repos/projectatomic/skopeo/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/skopeo/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/skopeo/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/skopeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/skopeo/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/skopeo/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/skopeo/deployments","created_at":"2016-03-07T20:23:29Z","updated_at":"2018-06-29T15:17:08Z","pushed_at":"2018-06-30T10:38:42Z","git_url":"git://github.com/projectatomic/skopeo.git","ssh_url":"git@github.com:projectatomic/skopeo.git","clone_url":"https://github.com/projectatomic/skopeo.git","svn_url":"https://github.com/projectatomic/skopeo","homepage":"","size":6340,"stargazers_count":577,"watchers_count":577,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":110,"open_issues":67,"watchers":577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/520"},"html":{"href":"https://github.com/projectatomic/skopeo/pull/520"},"issue":{"href":"https://api.github.com/repos/projectatomic/skopeo/issues/520"},"comments":{"href":"https://api.github.com/repos/projectatomic/skopeo/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/skopeo/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/skopeo/statuses/2f553268a18c0dec95ce16698686e54791ef55f9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rhatdan"}}