{"action":"closed","number":524,"pull_request":{"url":"https://api.github.com/repos/google/conscrypt/pulls/524","id":205065865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDY1ODY1","html_url":"https://github.com/google/conscrypt/pull/524","diff_url":"https://github.com/google/conscrypt/pull/524.diff","patch_url":"https://github.com/google/conscrypt/pull/524.patch","issue_url":"https://api.github.com/repos/google/conscrypt/issues/524","number":524,"state":"closed","locked":false,"title":"Support TLS 1.3","user":{"login":"flooey","id":215991,"node_id":"MDQ6VXNlcjIxNTk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/215991?v=4","gravatar_id":"","url":"https://api.github.com/users/flooey","html_url":"https://github.com/flooey","followers_url":"https://api.github.com/users/flooey/followers","following_url":"https://api.github.com/users/flooey/following{/other_user}","gists_url":"https://api.github.com/users/flooey/gists{/gist_id}","starred_url":"https://api.github.com/users/flooey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flooey/subscriptions","organizations_url":"https://api.github.com/users/flooey/orgs","repos_url":"https://api.github.com/users/flooey/repos","events_url":"https://api.github.com/users/flooey/events{/privacy}","received_events_url":"https://api.github.com/users/flooey/received_events","type":"User","site_admin":false},"body":"Enables support for negotiating TLS 1.3.  TLS 1.3 is not enabled\r\nunless SSLContext.TLSv1.3 is requested or setEnabledProtocols() is\r\ncalled with a set of values that includes TLSv1.3.\r\n\r\nDetailed changes:\r\n\r\nAdds protocol constants for TLS 1.3, and provides SSLContext.TLSv1.3,\r\nwhich has TLS 1.3 enabled by default.\r\n\r\nAdjusts cipher suite code for TLS 1.3 suites.  When enabled, all TLS\r\n1.3 cipher suites are always returned from supportedCipherSuites() and\r\nenabledCipherSuites().  Attempts to customize TLS 1.3 cipher suites in\r\nsetEnabledCipherSuites() are ignored.\r\n\r\nSplits {SSLEngine,SSLSocket}Test into version-dependent and\r\nversion-independent tests.  The latter remain in\r\n{SSLEngine,SSLSocket}Test and the former move into new files\r\n{SSLEngine,SSLSocket}VersionCompatibilityTest, which are parameterized\r\nto test all combinations of client and server on TLS 1.2 and TLS 1.3.\r\n\r\nManufactures session IDs from tickets for sessions which have no ID\r\nbut do have a ticket (which in practice is TLS 1.3 sessions), so that\r\nwe can cache them properly.\r\n\r\nRemove a pile of RI-specific TLS-related expectation declarations from\r\nStandardNames.  We don't actually verify the behavior of the RI at any\r\npoint, so it was just making the code more confusing.\r\n\r\nFixes #479.","created_at":"2018-07-31T10:27:04Z","updated_at":"2018-09-10T09:50:31Z","closed_at":"2018-09-10T09:50:31Z","merged_at":"2018-09-10T09:50:31Z","merge_commit_sha":"50e684841f2b61d4363b444529a3e4507acb6287","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/conscrypt/pulls/524/commits","review_comments_url":"https://api.github.com/repos/google/conscrypt/pulls/524/comments","review_comment_url":"https://api.github.com/repos/google/conscrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/conscrypt/issues/524/comments","statuses_url":"https://api.github.com/repos/google/conscrypt/statuses/0bb7eb7a84ac5054c7f4893eacd478ecb94b37e9","head":{"label":"flooey:tls13","ref":"tls13","sha":"0bb7eb7a84ac5054c7f4893eacd478ecb94b37e9","user":{"login":"flooey","id":215991,"node_id":"MDQ6VXNlcjIxNTk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/215991?v=4","gravatar_id":"","url":"https://api.github.com/users/flooey","html_url":"https://github.com/flooey","followers_url":"https://api.github.com/users/flooey/followers","following_url":"https://api.github.com/users/flooey/following{/other_user}","gists_url":"https://api.github.com/users/flooey/gists{/gist_id}","starred_url":"https://api.github.com/users/flooey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flooey/subscriptions","organizations_url":"https://api.github.com/users/flooey/orgs","repos_url":"https://api.github.com/users/flooey/repos","events_url":"https://api.github.com/users/flooey/events{/privacy}","received_events_url":"https://api.github.com/users/flooey/received_events","type":"User","site_admin":false},"repo":{"id":82045552,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA0NTU1Mg==","name":"conscrypt","full_name":"flooey/conscrypt","owner":{"login":"flooey","id":215991,"node_id":"MDQ6VXNlcjIxNTk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/215991?v=4","gravatar_id":"","url":"https://api.github.com/users/flooey","html_url":"https://github.com/flooey","followers_url":"https://api.github.com/users/flooey/followers","following_url":"https://api.github.com/users/flooey/following{/other_user}","gists_url":"https://api.github.com/users/flooey/gists{/gist_id}","starred_url":"https://api.github.com/users/flooey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flooey/subscriptions","organizations_url":"https://api.github.com/users/flooey/orgs","repos_url":"https://api.github.com/users/flooey/repos","events_url":"https://api.github.com/users/flooey/events{/privacy}","received_events_url":"https://api.github.com/users/flooey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flooey/conscrypt","description":"Conscrypt is a Java Security Provider that implements parts of the Java Cryptography Extension and Java Secure Socket Extension.","fork":true,"url":"https://api.github.com/repos/flooey/conscrypt","forks_url":"https://api.github.com/repos/flooey/conscrypt/forks","keys_url":"https://api.github.com/repos/flooey/conscrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flooey/conscrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flooey/conscrypt/teams","hooks_url":"https://api.github.com/repos/flooey/conscrypt/hooks","issue_events_url":"https://api.github.com/repos/flooey/conscrypt/issues/events{/number}","events_url":"https://api.github.com/repos/flooey/conscrypt/events","assignees_url":"https://api.github.com/repos/flooey/conscrypt/assignees{/user}","branches_url":"https://api.github.com/repos/flooey/conscrypt/branches{/branch}","tags_url":"https://api.github.com/repos/flooey/conscrypt/tags","blobs_url":"https://api.github.com/repos/flooey/conscrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flooey/conscrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flooey/conscrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/flooey/conscrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flooey/conscrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/flooey/conscrypt/languages","stargazers_url":"https://api.github.com/repos/flooey/conscrypt/stargazers","contributors_url":"https://api.github.com/repos/flooey/conscrypt/contributors","subscribers_url":"https://api.github.com/repos/flooey/conscrypt/subscribers","subscription_url":"https://api.github.com/repos/flooey/conscrypt/subscription","commits_url":"https://api.github.com/repos/flooey/conscrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/flooey/conscrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/flooey/conscrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/flooey/conscrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/flooey/conscrypt/contents/{+path}","compare_url":"https://api.github.com/repos/flooey/conscrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flooey/conscrypt/merges","archive_url":"https://api.github.com/repos/flooey/conscrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flooey/conscrypt/downloads","issues_url":"https://api.github.com/repos/flooey/conscrypt/issues{/number}","pulls_url":"https://api.github.com/repos/flooey/conscrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/flooey/conscrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/flooey/conscrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flooey/conscrypt/labels{/name}","releases_url":"https://api.github.com/repos/flooey/conscrypt/releases{/id}","deployments_url":"https://api.github.com/repos/flooey/conscrypt/deployments","created_at":"2017-02-15T09:52:55Z","updated_at":"2018-08-29T10:02:39Z","pushed_at":"2018-09-05T10:52:25Z","git_url":"git://github.com/flooey/conscrypt.git","ssh_url":"git@github.com:flooey/conscrypt.git","clone_url":"https://github.com/flooey/conscrypt.git","svn_url":"https://github.com/flooey/conscrypt","homepage":"","size":21054,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"4c77d64b7a934fdd6b2c934a6aeb2c6f27679258","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":76279202,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI3OTIwMg==","name":"conscrypt","full_name":"google/conscrypt","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/conscrypt","description":"Conscrypt is a Java Security Provider that implements parts of the Java Cryptography Extension and Java Secure Socket Extension.","fork":false,"url":"https://api.github.com/repos/google/conscrypt","forks_url":"https://api.github.com/repos/google/conscrypt/forks","keys_url":"https://api.github.com/repos/google/conscrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/conscrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/conscrypt/teams","hooks_url":"https://api.github.com/repos/google/conscrypt/hooks","issue_events_url":"https://api.github.com/repos/google/conscrypt/issues/events{/number}","events_url":"https://api.github.com/repos/google/conscrypt/events","assignees_url":"https://api.github.com/repos/google/conscrypt/assignees{/user}","branches_url":"https://api.github.com/repos/google/conscrypt/branches{/branch}","tags_url":"https://api.github.com/repos/google/conscrypt/tags","blobs_url":"https://api.github.com/repos/google/conscrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/conscrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/conscrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/conscrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/conscrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/google/conscrypt/languages","stargazers_url":"https://api.github.com/repos/google/conscrypt/stargazers","contributors_url":"https://api.github.com/repos/google/conscrypt/contributors","subscribers_url":"https://api.github.com/repos/google/conscrypt/subscribers","subscription_url":"https://api.github.com/repos/google/conscrypt/subscription","commits_url":"https://api.github.com/repos/google/conscrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/conscrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/conscrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/conscrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/conscrypt/contents/{+path}","compare_url":"https://api.github.com/repos/google/conscrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/conscrypt/merges","archive_url":"https://api.github.com/repos/google/conscrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/conscrypt/downloads","issues_url":"https://api.github.com/repos/google/conscrypt/issues{/number}","pulls_url":"https://api.github.com/repos/google/conscrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/google/conscrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/google/conscrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/conscrypt/labels{/name}","releases_url":"https://api.github.com/repos/google/conscrypt/releases{/id}","deployments_url":"https://api.github.com/repos/google/conscrypt/deployments","created_at":"2016-12-12T17:24:18Z","updated_at":"2018-09-03T16:16:37Z","pushed_at":"2018-09-10T09:50:32Z","git_url":"git://github.com/google/conscrypt.git","ssh_url":"git@github.com:google/conscrypt.git","clone_url":"https://github.com/google/conscrypt.git","svn_url":"https://github.com/google/conscrypt","homepage":"","size":21123,"stargazers_count":440,"watchers_count":440,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":79,"open_issues":28,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/conscrypt/pulls/524"},"html":{"href":"https://github.com/google/conscrypt/pull/524"},"issue":{"href":"https://api.github.com/repos/google/conscrypt/issues/524"},"comments":{"href":"https://api.github.com/repos/google/conscrypt/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/google/conscrypt/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/google/conscrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/conscrypt/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/google/conscrypt/statuses/0bb7eb7a84ac5054c7f4893eacd478ecb94b37e9"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"flooey","id":215991,"node_id":"MDQ6VXNlcjIxNTk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/215991?v=4","gravatar_id":"","url":"https://api.github.com/users/flooey","html_url":"https://github.com/flooey","followers_url":"https://api.github.com/users/flooey/followers","following_url":"https://api.github.com/users/flooey/following{/other_user}","gists_url":"https://api.github.com/users/flooey/gists{/gist_id}","starred_url":"https://api.github.com/users/flooey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flooey/subscriptions","organizations_url":"https://api.github.com/users/flooey/orgs","repos_url":"https://api.github.com/users/flooey/repos","events_url":"https://api.github.com/users/flooey/events{/privacy}","received_events_url":"https://api.github.com/users/flooey/received_events","type":"User","site_admin":false},"comments":0,"review_comments":21,"maintainer_can_modify":false,"commits":4,"additions":3685,"deletions":2881,"changed_files":22}}
{"actor":{"display_login":"flooey"}}