{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/234130229","pull_request_review_id":175706798,"id":234130229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDEzMDIyOQ==","diff_hunk":"@@ -31,16 +31,21 @@\n  ****************************************************************************/\n static const char *file_path = \"/mnt/fileinputdatasource.raw\";\n static const char *test_data = \"dummydata\";\n-static int g_flag=0;\n+static int g_flag = 0;\n \n static void SetUp(void)\n {\n-\tFILE *fp;\n-\tfp = fopen(file_path, \"w\");\n-\tTC_ASSERT_NEQ(\"fopen\", fp, NULL);\n-\tTC_ASSERT_NEQ_CLEANUP(\"fputs\", fputs(test_data, fp), EOF, fclose(fp));\n-\tTC_ASSERT_EQ(\"fclose\", fclose(fp), OK);\n-\tg_flag = 1;\n+\tFILE *fp = fopen(file_path, \"w\");\n+\tif (fp != NULL) {\n+\t\tint ret = fputs(\"dummydata\", fp);","path":"apps/examples/testcase/ta_tc/media/itc/itc_media_mediaplayer.cpp","position":17,"original_position":17,"commit_id":"a618800c265a0323885cf397f087fa0c2a47937d","original_commit_id":"a618800c265a0323885cf397f087fa0c2a47937d","user":{"login":"JeongJunSik","id":25924775,"node_id":"MDQ6VXNlcjI1OTI0Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/25924775?v=4","gravatar_id":"","url":"https://api.github.com/users/JeongJunSik","html_url":"https://github.com/JeongJunSik","followers_url":"https://api.github.com/users/JeongJunSik/followers","following_url":"https://api.github.com/users/JeongJunSik/following{/other_user}","gists_url":"https://api.github.com/users/JeongJunSik/gists{/gist_id}","starred_url":"https://api.github.com/users/JeongJunSik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeongJunSik/subscriptions","organizations_url":"https://api.github.com/users/JeongJunSik/orgs","repos_url":"https://api.github.com/users/JeongJunSik/repos","events_url":"https://api.github.com/users/JeongJunSik/events{/privacy}","received_events_url":"https://api.github.com/users/JeongJunSik/received_events","type":"User","site_admin":false},"body":"how about \r\n`\r\nint ret = fputs(test_data, fp);\r\nif (ret != (int)strlen(test_data)) {\r\n\tprintf(\"fail to fputs\\n\");\r\n}\r\n`","created_at":"2018-11-16T08:58:46Z","updated_at":"2018-11-16T08:58:46Z","html_url":"https://github.com/Samsung/TizenRT/pull/2305#discussion_r234130229","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/234130229"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/2305#discussion_r234130229"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305","id":220025397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDI1Mzk3","html_url":"https://github.com/Samsung/TizenRT/pull/2305","diff_url":"https://github.com/Samsung/TizenRT/pull/2305.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/2305.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2305","number":2305,"state":"open","locked":false,"title":"apps/example/testcase/ : fix media ITC build fail and new ITC develope","user":{"login":"manoj11588612","id":35285853,"node_id":"MDQ6VXNlcjM1Mjg1ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/35285853?v=4","gravatar_id":"","url":"https://api.github.com/users/manoj11588612","html_url":"https://github.com/manoj11588612","followers_url":"https://api.github.com/users/manoj11588612/followers","following_url":"https://api.github.com/users/manoj11588612/following{/other_user}","gists_url":"https://api.github.com/users/manoj11588612/gists{/gist_id}","starred_url":"https://api.github.com/users/manoj11588612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoj11588612/subscriptions","organizations_url":"https://api.github.com/users/manoj11588612/orgs","repos_url":"https://api.github.com/users/manoj11588612/repos","events_url":"https://api.github.com/users/manoj11588612/events{/privacy}","received_events_url":"https://api.github.com/users/manoj11588612/received_events","type":"User","site_admin":false},"body":"changes are as below:\r\nitc_media_bufferoutputdatasource.cpp->\r\n1. develope 5 ITC for new api, itc are as below\r\n\t\titc_media_BufferOutputDataSource_getChannels_setChannels_p\r\n\t\titc_media_BufferOutputDataSource_getSampleRate_setSampleRate_p\r\n\t\titc_media_BufferOutputDataSource_getPcmFormat_setPcmFormat_p\r\n\t\titc_media_BufferOutputDataSource_getAudioType_setAudioType_p\r\n\t\titc_media_BufferOutputDataSource_reopen_p\r\n\r\nitc_media_fileinputdatasource.cpp->\r\nfix build issue due to namespace media class change\r\n\r\nitc_media_fileoutputdatasource.cpp->\r\nfix build issue due to namespace media class change\r\n\r\nitc_media_focusmanager.cpp->\r\n1. develope 2 ITC for new api, itc are as below\r\n\titc_media_FocusManager_getFocusManager_p\r\n\titc_media_FocusManager_requestFocus_p\r\n\r\nitc_media_focusrequest.cpp->\r\n1. develope 2 ITC for new api, itc are as below\r\n\titc_media_FocusRequest_getId\r\n\titc_media_FocusRequest_getListener_p\r\n\r\nitc_media_mediaplayer.cpp->\r\n1. itc fix by file opening logic change\r\n\r\nitc_media_mediarecorder.cpp\r\n1. itc fix due to nchange in recorder ERROR code\r\n\r\nSigned-off-by: manoj <manoj.g2@samsung.com>","created_at":"2018-10-03T12:52:17Z","updated_at":"2018-11-16T08:58:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"721809387f56e89384cc6cacf9509c77fae045de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/2305/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/a618800c265a0323885cf397f087fa0c2a47937d","head":{"label":"manoj11588612:media_itc_fix","ref":"media_itc_fix","sha":"a618800c265a0323885cf397f087fa0c2a47937d","user":{"login":"manoj11588612","id":35285853,"node_id":"MDQ6VXNlcjM1Mjg1ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/35285853?v=4","gravatar_id":"","url":"https://api.github.com/users/manoj11588612","html_url":"https://github.com/manoj11588612","followers_url":"https://api.github.com/users/manoj11588612/followers","following_url":"https://api.github.com/users/manoj11588612/following{/other_user}","gists_url":"https://api.github.com/users/manoj11588612/gists{/gist_id}","starred_url":"https://api.github.com/users/manoj11588612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoj11588612/subscriptions","organizations_url":"https://api.github.com/users/manoj11588612/orgs","repos_url":"https://api.github.com/users/manoj11588612/repos","events_url":"https://api.github.com/users/manoj11588612/events{/privacy}","received_events_url":"https://api.github.com/users/manoj11588612/received_events","type":"User","site_admin":false},"repo":{"id":118896264,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4OTYyNjQ=","name":"TizenRT","full_name":"manoj11588612/TizenRT","private":false,"owner":{"login":"manoj11588612","id":35285853,"node_id":"MDQ6VXNlcjM1Mjg1ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/35285853?v=4","gravatar_id":"","url":"https://api.github.com/users/manoj11588612","html_url":"https://github.com/manoj11588612","followers_url":"https://api.github.com/users/manoj11588612/followers","following_url":"https://api.github.com/users/manoj11588612/following{/other_user}","gists_url":"https://api.github.com/users/manoj11588612/gists{/gist_id}","starred_url":"https://api.github.com/users/manoj11588612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manoj11588612/subscriptions","organizations_url":"https://api.github.com/users/manoj11588612/orgs","repos_url":"https://api.github.com/users/manoj11588612/repos","events_url":"https://api.github.com/users/manoj11588612/events{/privacy}","received_events_url":"https://api.github.com/users/manoj11588612/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manoj11588612/TizenRT","description":"Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/manoj11588612/TizenRT","forks_url":"https://api.github.com/repos/manoj11588612/TizenRT/forks","keys_url":"https://api.github.com/repos/manoj11588612/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manoj11588612/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manoj11588612/TizenRT/teams","hooks_url":"https://api.github.com/repos/manoj11588612/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/manoj11588612/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/manoj11588612/TizenRT/events","assignees_url":"https://api.github.com/repos/manoj11588612/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/manoj11588612/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/manoj11588612/TizenRT/tags","blobs_url":"https://api.github.com/repos/manoj11588612/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manoj11588612/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manoj11588612/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/manoj11588612/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manoj11588612/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/manoj11588612/TizenRT/languages","stargazers_url":"https://api.github.com/repos/manoj11588612/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/manoj11588612/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/manoj11588612/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/manoj11588612/TizenRT/subscription","commits_url":"https://api.github.com/repos/manoj11588612/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/manoj11588612/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/manoj11588612/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/manoj11588612/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/manoj11588612/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/manoj11588612/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manoj11588612/TizenRT/merges","archive_url":"https://api.github.com/repos/manoj11588612/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manoj11588612/TizenRT/downloads","issues_url":"https://api.github.com/repos/manoj11588612/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/manoj11588612/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/manoj11588612/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/manoj11588612/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manoj11588612/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/manoj11588612/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/manoj11588612/TizenRT/deployments","created_at":"2018-01-25T10:07:27Z","updated_at":"2018-07-03T04:53:16Z","pushed_at":"2018-10-31T04:30:52Z","git_url":"git://github.com/manoj11588612/TizenRT.git","ssh_url":"git@github.com:manoj11588612/TizenRT.git","clone_url":"https://github.com/manoj11588612/TizenRT.git","svn_url":"https://github.com/manoj11588612/TizenRT","homepage":"","size":106379,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"5de8dd4e3c7bf9f7dfa6c92e5d5841d1afff4840","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"node_id":"MDEwOlJlcG9zaXRvcnk4MjUxNzI1Mg==","name":"TizenRT","full_name":"Samsung/TizenRT","private":false,"owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Samsung/TizenRT","description":"TizenRT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2018-11-16T08:34:59Z","pushed_at":"2018-11-16T08:34:52Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":106889,"stargazers_count":208,"watchers_count":208,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":295,"open_issues":60,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/2305"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/2305"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/2305/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/2305/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/a618800c265a0323885cf397f087fa0c2a47937d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JeongJunSik"}}