{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/206123360","pull_request_review_id":141520914,"id":206123360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjEyMzM2MA==","diff_hunk":"@@ -1,66 +1,58 @@\n import eyes from 'eyes.it';\n import eventually from 'wix-eventually';\n \n-import {pageTestkitFactory, waitForVisibilityOf, scrollToElement} from '../../testkit/protractor';\n+import {\n+  pageTestkitFactory,\n+  waitForVisibilityOf,\n+  scrollToElement\n+} from '../../testkit/protractor';\n import {createStoryUrl} from '../../test/utils/protractor';\n import autoExampleDriver from 'wix-storybook-utils/AutoExampleDriver';\n-import {PRIVATE} from './Page.protractor.driver';\n import {TESTS_PREFIX} from '../../stories/storyCategories';\n import {storybookConfig} from '../../stories/Page/storybookConfig';\n \n const {category, storyName} = storybookConfig;\n \n-const SCROLL_TOP_THRESHOLD = 20;\n-const SCROLL_TOP_MIN_STEP = SCROLL_TOP_THRESHOLD + 1;\n+const SCROLL_TITLE_THRESHOLD = 20;\n \n describe('Page', async () => {\n-\n   const createTestStoryUrl = testName => {\n-    return createStoryUrl({kind: `${TESTS_PREFIX}/${category}/${storyName}`, story: testName});\n+    return createStoryUrl({\n+      kind: `${TESTS_PREFIX}/${category}/${storyName}`,\n+      story: testName\n+    });\n   };\n+  const dataHook = 'story-page';\n \n   const initTest = async ({storyUrl, dataHook, props}) => {\n     await browser.get(storyUrl);\n     const driver = pageTestkitFactory({dataHook});\n     await waitForVisibilityOf(driver.element(), 'Cannot find Page');\n     await scrollToElement(driver.element());\n-    props && await autoExampleDriver.setProps(props);\n+    props && (await autoExampleDriver.setProps(props));\n     return driver;\n   };\n \n   const runTestCases = initTestConfig => {\n-    eyes.it('should display maximized (with Title)', async () => {\n-      const driver = await initTest(initTestConfig);\n-      expect(await driver.titleExists()).toBeTruthy();\n-    });\n-\n-    eyes.it('should display minimized (without Title)', async () => {\n+    eyes.it('should hide title on scroll threshold', async () => {\n       const driver = await initTest(initTestConfig);\n-      expect(await driver.titleExists()).toBeTruthy();\n-      await driver.scrollDown();\n-      await eventually(() => !driver.titleExists());\n-    });\n-\n-    eyes.it('should display minimized with header background still visible', async () => {\n-      const driver = await initTest(initTestConfig);\n-      expect(await driver.titleExists()).toBeTruthy();\n-      await driver[PRIVATE].setContentScrollOffset(SCROLL_TOP_MIN_STEP);\n+      //Should display title while scroll is under scroll threshold\n+      await expect(await driver.titleExists()).toBeTruthy();\n+      //Should not display title while sroll is over the scroll threshold\n+      await driver.scrollDown(SCROLL_TITLE_THRESHOLD + 1);\n       await eventually(() => !driver.titleExists());\n+      //Should display title again when scrolled back up\n+      await driver.scrollDown(0);","path":"src/Page/Page.e2e.js","position":67,"original_position":67,"commit_id":"195f8e75d2abba32796125d41148c642a4ffff44","original_commit_id":"195f8e75d2abba32796125d41148c642a4ffff44","user":{"login":"mykas","id":8919190,"node_id":"MDQ6VXNlcjg5MTkxOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8919190?v=4","gravatar_id":"","url":"https://api.github.com/users/mykas","html_url":"https://github.com/mykas","followers_url":"https://api.github.com/users/mykas/followers","following_url":"https://api.github.com/users/mykas/following{/other_user}","gists_url":"https://api.github.com/users/mykas/gists{/gist_id}","starred_url":"https://api.github.com/users/mykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykas/subscriptions","organizations_url":"https://api.github.com/users/mykas/orgs","repos_url":"https://api.github.com/users/mykas/repos","events_url":"https://api.github.com/users/mykas/events{/privacy}","received_events_url":"https://api.github.com/users/mykas/received_events","type":"User","site_admin":false},"body":"But then I would need to add new API endpoint for users in teskit? Can I do it?","created_at":"2018-07-30T13:00:42Z","updated_at":"2018-07-30T13:00:42Z","html_url":"https://github.com/wix/wix-style-react/pull/2044#discussion_r206123360","pull_request_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2044","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/206123360"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2044#discussion_r206123360"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2044"}},"in_reply_to_id":206120895},"pull_request":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/2044","id":204152323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTUyMzIz","html_url":"https://github.com/wix/wix-style-react/pull/2044","diff_url":"https://github.com/wix/wix-style-react/pull/2044.diff","patch_url":"https://github.com/wix/wix-style-react/pull/2044.patch","issue_url":"https://api.github.com/repos/wix/wix-style-react/issues/2044","number":2044,"state":"open","locked":false,"title":"Page. Improve e2e test.","user":{"login":"mykas","id":8919190,"node_id":"MDQ6VXNlcjg5MTkxOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8919190?v=4","gravatar_id":"","url":"https://api.github.com/users/mykas","html_url":"https://github.com/mykas","followers_url":"https://api.github.com/users/mykas/followers","following_url":"https://api.github.com/users/mykas/following{/other_user}","gists_url":"https://api.github.com/users/mykas/gists{/gist_id}","starred_url":"https://api.github.com/users/mykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykas/subscriptions","organizations_url":"https://api.github.com/users/mykas/orgs","repos_url":"https://api.github.com/users/mykas/repos","events_url":"https://api.github.com/users/mykas/events{/privacy}","received_events_url":"https://api.github.com/users/mykas/received_events","type":"User","site_admin":false},"body":"Page e2e tests were improved and now tests only takes ~ 1: instead of ~2m:42s.\r\nMade some changes to the protractor.driver.js. Removed private method and reused scrollDown() instead.\r\n\r\nMainly Page.e2e.js for now tests scroll threshold feature and of course if renders at all.\r\nScroll threshold: 20\r\n![scroll_threshold](https://user-images.githubusercontent.com/8919190/43396199-7b43c0f8-9409-11e8-9a63-f64570d2ccd0.gif)\r\n","created_at":"2018-07-26T14:00:27Z","updated_at":"2018-07-30T13:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68a137ce794f68862e34d0e3f5b6bb4b484a3a53","assignee":null,"assignees":[],"requested_reviewers":[{"login":"argshook","id":4284659,"node_id":"MDQ6VXNlcjQyODQ2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4284659?v=4","gravatar_id":"","url":"https://api.github.com/users/argshook","html_url":"https://github.com/argshook","followers_url":"https://api.github.com/users/argshook/followers","following_url":"https://api.github.com/users/argshook/following{/other_user}","gists_url":"https://api.github.com/users/argshook/gists{/gist_id}","starred_url":"https://api.github.com/users/argshook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argshook/subscriptions","organizations_url":"https://api.github.com/users/argshook/orgs","repos_url":"https://api.github.com/users/argshook/repos","events_url":"https://api.github.com/users/argshook/events{/privacy}","received_events_url":"https://api.github.com/users/argshook/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2044/commits","review_comments_url":"https://api.github.com/repos/wix/wix-style-react/pulls/2044/comments","review_comment_url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-style-react/issues/2044/comments","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/195f8e75d2abba32796125d41148c642a4ffff44","head":{"label":"wix:test/reduce-e2e-time","ref":"test/reduce-e2e-time","sha":"195f8e75d2abba32796125d41148c642a4ffff44","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-07-30T06:40:34Z","pushed_at":"2018-07-30T12:14:35Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":8549,"stargazers_count":312,"watchers_count":312,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":73,"open_issues":97,"watchers":312,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"fb8fa16c2085d97d366b23e892aef22a6c18bf9a","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-07-30T06:40:34Z","pushed_at":"2018-07-30T12:14:35Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":8549,"stargazers_count":312,"watchers_count":312,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":73,"open_issues":97,"watchers":312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2044"},"html":{"href":"https://github.com/wix/wix-style-react/pull/2044"},"issue":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2044"},"comments":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/2044/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2044/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/2044/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-style-react/statuses/195f8e75d2abba32796125d41148c642a4ffff44"}},"author_association":"NONE"}}
{"actor":{"display_login":"mykas"}}