{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/2004","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/2004/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/2004/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/2004/events","html_url":"https://github.com/ocaml/ocaml/pull/2004","id":353540473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTY2MTU4","number":2004,"title":"Windows: Use common path for standard library","user":{"login":"bryphe","id":13532591,"node_id":"MDQ6VXNlcjEzNTMyNTkx","avatar_url":"https://avatars1.githubusercontent.com/u/13532591?v=4","gravatar_id":"","url":"https://api.github.com/users/bryphe","html_url":"https://github.com/bryphe","followers_url":"https://api.github.com/users/bryphe/followers","following_url":"https://api.github.com/users/bryphe/following{/other_user}","gists_url":"https://api.github.com/users/bryphe/gists{/gist_id}","starred_url":"https://api.github.com/users/bryphe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryphe/subscriptions","organizations_url":"https://api.github.com/users/bryphe/orgs","repos_url":"https://api.github.com/users/bryphe/repos","events_url":"https://api.github.com/users/bryphe/events{/privacy}","received_events_url":"https://api.github.com/users/bryphe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-23T20:26:17Z","updated_at":"2018-08-24T11:01:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/2004","html_url":"https://github.com/ocaml/ocaml/pull/2004","diff_url":"https://github.com/ocaml/ocaml/pull/2004.diff","patch_url":"https://github.com/ocaml/ocaml/pull/2004.patch"},"body":"First off, thank you for all the incredible work you've done with the OCaml compiler!\r\n\r\nI've been experimenting with the OCaml compiler as part of the https://github.com/esy/esy project, in particular, facilitating a smooth Windows experience. \r\n\r\nI noticed that the standard library path was different on Windows vs OSX / Linux:\r\n- Windows: `<ocaml>/lib`\r\n- OSX / Linux: `<ocaml>/lib/ocaml`\r\n\r\nIt seems like it would make sense for these to be consistent cross-platform. Looking at the history of the `Makefiles`, it looks like the `LIBDIR` was set a while ago - so I'm curious if perhaps it was changed in OSX / Linux, but not on Windows. For most tools and applications, it may not be important, as the `OCAMLLIB` variable can be used - but `esy` is a somewhat special case as it implements a sandbox isolation model, and needs strict control over the environment. Having a common path from the `ocaml` root means less special casing per-platform.\r\n\r\nIn addition, I wonder if there are any compatibility issues making this change. Please let me know if you'd like any information or have any feedback on this change. Thank you!"},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/415726447","html_url":"https://github.com/ocaml/ocaml/pull/2004#issuecomment-415726447","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/2004","id":415726447,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTcyNjQ0Nw==","user":{"login":"nojb","id":113560,"node_id":"MDQ6VXNlcjExMzU2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/113560?v=4","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T11:01:23Z","updated_at":"2018-08-24T11:01:23Z","author_association":"CONTRIBUTOR","body":"In principle this seems a harmless change: Windows users typically modify their Makefiles anyway before building. But let's see what the build system experts think about it."}}
{"actor":{"display_login":"nojb"}}