{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/29058","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/29058/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/29058/comments","events_url":"https://api.github.com/repos/golang/go/issues/29058/events","html_url":"https://github.com/golang/go/issues/29058","id":386492524,"node_id":"MDU6SXNzdWUzODY0OTI1MjQ=","number":29058,"title":"cmd/go: the vendor/ folder should be kept up to date if present","user":{"login":"FiloSottile","id":1225294,"node_id":"MDQ6VXNlcjEyMjUyOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1225294?v=4","gravatar_id":"","url":"https://api.github.com/users/FiloSottile","html_url":"https://github.com/FiloSottile","followers_url":"https://api.github.com/users/FiloSottile/followers","following_url":"https://api.github.com/users/FiloSottile/following{/other_user}","gists_url":"https://api.github.com/users/FiloSottile/gists{/gist_id}","starred_url":"https://api.github.com/users/FiloSottile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FiloSottile/subscriptions","organizations_url":"https://api.github.com/users/FiloSottile/orgs","repos_url":"https://api.github.com/users/FiloSottile/repos","events_url":"https://api.github.com/users/FiloSottile/events{/privacy}","received_events_url":"https://api.github.com/users/FiloSottile/received_events","type":"User","site_admin":false},"labels":[{"id":373540105,"node_id":"MDU6TGFiZWwzNzM1NDAxMDU=","url":"https://api.github.com/repos/golang/go/labels/FeatureRequest","name":"FeatureRequest","color":"bfd4f2","default":false},{"id":503763046,"node_id":"MDU6TGFiZWw1MDM3NjMwNDY=","url":"https://api.github.com/repos/golang/go/labels/GoCommand","name":"GoCommand","color":"006b75","default":false},{"id":373401956,"node_id":"MDU6TGFiZWwzNzM0MDE5NTY=","url":"https://api.github.com/repos/golang/go/labels/NeedsDecision","name":"NeedsDecision","color":"ededed","default":false},{"id":992189327,"node_id":"MDU6TGFiZWw5OTIxODkzMjc=","url":"https://api.github.com/repos/golang/go/labels/modules","name":"modules","color":"bac2ff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/6","html_url":"https://github.com/golang/go/milestone/6","labels_url":"https://api.github.com/repos/golang/go/milestones/6/labels","id":1055141,"node_id":"MDk6TWlsZXN0b25lMTA1NTE0MQ==","number":6,"title":"Unplanned","description":"No plan to fix in any specific release.\r\n","creator":{"login":"rsc","id":104030,"node_id":"MDQ6VXNlcjEwNDAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":1824,"closed_issues":1310,"state":"open","created_at":"2015-04-06T20:47:19Z","updated_at":"2018-12-03T23:12:12Z","due_on":"2099-12-31T08:00:00Z","closed_at":null},"comments":9,"created_at":"2018-12-01T20:02:27Z","updated_at":"2018-12-04T19:06:49Z","closed_at":null,"author_association":"MEMBER","body":"Using `go mod vendor` is great for backwards compatibility (and for self-contained builds), but it requires re-running every time any dependency changes. Multiple times now I have committed changes that I tested with `GO11MODULES=on`, only to have them fail in CI where they rely on `vendor/`.\r\n\r\nThe `go` tool already updates `go.mod` and `go.sum` when making builds, I believe it should do the same with the `vendor/` folder if it's present, to avoid getting in an inconsistent state.\r\n\r\nAn out of date `vendor/` folder feels like an entirely inconsistent and confusing state to be in, causing builds to unexpectedly fail only for certain users, with no advantages, so the tooling should probably just not let it happen. If a developer doesn't want to keep the `vendor/` folder up to date, it should be deleted.\r\n\r\n/cc @rsc @bcmills "},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/444219299","html_url":"https://github.com/golang/go/issues/29058#issuecomment-444219299","issue_url":"https://api.github.com/repos/golang/go/issues/29058","id":444219299,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDIxOTI5OQ==","user":{"login":"bcmills","id":5200974,"node_id":"MDQ6VXNlcjUyMDA5NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5200974?v=4","gravatar_id":"","url":"https://api.github.com/users/bcmills","html_url":"https://github.com/bcmills","followers_url":"https://api.github.com/users/bcmills/followers","following_url":"https://api.github.com/users/bcmills/following{/other_user}","gists_url":"https://api.github.com/users/bcmills/gists{/gist_id}","starred_url":"https://api.github.com/users/bcmills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcmills/subscriptions","organizations_url":"https://api.github.com/users/bcmills/orgs","repos_url":"https://api.github.com/users/bcmills/repos","events_url":"https://api.github.com/users/bcmills/events{/privacy}","received_events_url":"https://api.github.com/users/bcmills/received_events","type":"User","site_admin":false},"created_at":"2018-12-04T19:06:49Z","updated_at":"2018-12-04T19:06:49Z","author_association":"MEMBER","body":"@nomad-software I said I want to remove the *flag*, not the `vendor` directory. If we use `vendor` by default, then we don't need an explicit flag to enable it."}}
{"actor":{"display_login":"bcmills"}}