{"action":"created","issue":{"url":"https://api.github.com/repos/globalsign/mgo/issues/258","repository_url":"https://api.github.com/repos/globalsign/mgo","labels_url":"https://api.github.com/repos/globalsign/mgo/issues/258/labels{/name}","comments_url":"https://api.github.com/repos/globalsign/mgo/issues/258/comments","events_url":"https://api.github.com/repos/globalsign/mgo/issues/258/events","html_url":"https://github.com/globalsign/mgo/pull/258","id":354672469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzc3NzM4","number":258,"title":"Changestreams db and cluster level #251","user":{"login":"peterdeka","id":1216864,"node_id":"MDQ6VXNlcjEyMTY4NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1216864?v=4","gravatar_id":"","url":"https://api.github.com/users/peterdeka","html_url":"https://github.com/peterdeka","followers_url":"https://api.github.com/users/peterdeka/followers","following_url":"https://api.github.com/users/peterdeka/following{/other_user}","gists_url":"https://api.github.com/users/peterdeka/gists{/gist_id}","starred_url":"https://api.github.com/users/peterdeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterdeka/subscriptions","organizations_url":"https://api.github.com/users/peterdeka/orgs","repos_url":"https://api.github.com/users/peterdeka/repos","events_url":"https://api.github.com/users/peterdeka/events{/privacy}","received_events_url":"https://api.github.com/users/peterdeka/received_events","type":"User","site_admin":false},"labels":[{"id":1038112236,"node_id":"MDU6TGFiZWwxMDM4MTEyMjM2","url":"https://api.github.com/repos/globalsign/mgo/labels/4.0%20feature","name":"4.0 feature","color":"9d96dd","default":false},{"id":658764468,"node_id":"MDU6TGFiZWw2NTg3NjQ0Njg=","url":"https://api.github.com/repos/globalsign/mgo/labels/needs%20tests","name":"needs tests","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-28T10:41:19Z","updated_at":"2018-09-18T15:54:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/globalsign/mgo/pulls/258","html_url":"https://github.com/globalsign/mgo/pull/258","diff_url":"https://github.com/globalsign/mgo/pull/258.diff","patch_url":"https://github.com/globalsign/mgo/pull/258.patch"},"body":"Enhancing change streams in order to support DB level and cluster level changes notifications introduced in mongoDB 4.0 as per issue #251.\r\nI strongly ask review of the way i addressed the question as i'm not really sure it is not a workaround.\r\nIf we go this way, i think it's better to make unexported all session and database methods that were added (`Pipe()`, `NewIter()`), except for the `Watch()` method in order to not pollute with meaningless methods.\r\n**Tests are still missing** and will be added once we agree on the way i implemented the functionality and Mongo 4.0 is added to the test suite."},"comment":{"url":"https://api.github.com/repos/globalsign/mgo/issues/comments/422449375","html_url":"https://github.com/globalsign/mgo/pull/258#issuecomment-422449375","issue_url":"https://api.github.com/repos/globalsign/mgo/issues/258","id":422449375,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjQ0OTM3NQ==","user":{"login":"domodwyer","id":9275968,"node_id":"MDQ6VXNlcjkyNzU5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/9275968?v=4","gravatar_id":"","url":"https://api.github.com/users/domodwyer","html_url":"https://github.com/domodwyer","followers_url":"https://api.github.com/users/domodwyer/followers","following_url":"https://api.github.com/users/domodwyer/following{/other_user}","gists_url":"https://api.github.com/users/domodwyer/gists{/gist_id}","starred_url":"https://api.github.com/users/domodwyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domodwyer/subscriptions","organizations_url":"https://api.github.com/users/domodwyer/orgs","repos_url":"https://api.github.com/users/domodwyer/repos","events_url":"https://api.github.com/users/domodwyer/events{/privacy}","received_events_url":"https://api.github.com/users/domodwyer/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T15:54:46Z","updated_at":"2018-09-18T15:54:46Z","author_association":"COLLABORATOR","body":"@peterdeka this is a really, really good PR - thanks so much for the contribution!\r\n\r\nI left a single comment regarding the visibility of `ChangeDomainType` - I see no reason this can't be merged functionally!\r\n\r\nThanks very much -  I know the mgo code base can be difficult to work with but this is a great PR.\r\n\r\nDom"}}
{"actor":{"display_login":"domodwyer"}}