{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/titus-executor/pulls/comments/204616463","pull_request_review_id":139726320,"id":204616463,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDYxNjQ2Mw==","diff_hunk":"@@ -89,6 +95,11 @@ func mainWithError(c *cli.Context, dockerCfg *docker.Config, cfg *config.Config)\n \t\tm = metrics.Discard\n \tdefault:\n \t\tm = metrics.New(ctx, log.StandardLogger(), tag.Defaults)\n+\t\tif enableDefaultTitusTags {\n+\t\t\t// If fast property titus.executor.enableDefaultTitusTags is unset or set to true,\n+\t\t\t// wrap metrics.Reporter with runner.reporter that has default Atlas tags (t.jobId, t.taskId)\n+\t\t\tm = runner.NewReporter(m)\n+\t\t}","path":"cmd/titus-executor/main.go","position":28,"original_position":28,"commit_id":"2022d45ec92c65140c1e9287fdfa0a38b61bf376","original_commit_id":"2022d45ec92c65140c1e9287fdfa0a38b61bf376","user":{"login":"rickkw","id":607371,"node_id":"MDQ6VXNlcjYwNzM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/607371?v=4","gravatar_id":"","url":"https://api.github.com/users/rickkw","html_url":"https://github.com/rickkw","followers_url":"https://api.github.com/users/rickkw/followers","following_url":"https://api.github.com/users/rickkw/following{/other_user}","gists_url":"https://api.github.com/users/rickkw/gists{/gist_id}","starred_url":"https://api.github.com/users/rickkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickkw/subscriptions","organizations_url":"https://api.github.com/users/rickkw/orgs","repos_url":"https://api.github.com/users/rickkw/repos","events_url":"https://api.github.com/users/rickkw/events{/privacy}","received_events_url":"https://api.github.com/users/rickkw/received_events","type":"User","site_admin":false},"body":"that m implements the tagger interface is enough for the Runner to tell if extra Atlas tags is needed.  We don't need to pass any extra arguments into runner.New()","created_at":"2018-07-24T03:49:17Z","updated_at":"2018-07-24T03:49:17Z","html_url":"https://github.com/Netflix/titus-executor/pull/158#discussion_r204616463","pull_request_url":"https://api.github.com/repos/Netflix/titus-executor/pulls/158","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Netflix/titus-executor/pulls/comments/204616463"},"html":{"href":"https://github.com/Netflix/titus-executor/pull/158#discussion_r204616463"},"pull_request":{"href":"https://api.github.com/repos/Netflix/titus-executor/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/titus-executor/pulls/158","id":202740041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzQwMDQx","html_url":"https://github.com/Netflix/titus-executor/pull/158","diff_url":"https://github.com/Netflix/titus-executor/pull/158.diff","patch_url":"https://github.com/Netflix/titus-executor/pull/158.patch","issue_url":"https://api.github.com/repos/Netflix/titus-executor/issues/158","number":158,"state":"open","locked":false,"title":"TITUS-895 Publish S3 upload size metrics with additional t.jobId and …","user":{"login":"rickkw","id":607371,"node_id":"MDQ6VXNlcjYwNzM3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/607371?v=4","gravatar_id":"","url":"https://api.github.com/users/rickkw","html_url":"https://github.com/rickkw","followers_url":"https://api.github.com/users/rickkw/followers","following_url":"https://api.github.com/users/rickkw/following{/other_user}","gists_url":"https://api.github.com/users/rickkw/gists{/gist_id}","starred_url":"https://api.github.com/users/rickkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickkw/subscriptions","organizations_url":"https://api.github.com/users/rickkw/orgs","repos_url":"https://api.github.com/users/rickkw/repos","events_url":"https://api.github.com/users/rickkw/events{/privacy}","received_events_url":"https://api.github.com/users/rickkw/received_events","type":"User","site_admin":false},"body":"1. Enable titus.executor.S3Uploader.successfullyUploadedBytes metics\r\n2. All titus-executor metrics are tagged with t.jobId and t.taskId by default\r\n3. Additional tags can be enabled/disabled by fast properties titus.executor.enableDefaultTitusTags.  Default is true.","created_at":"2018-07-20T03:53:18Z","updated_at":"2018-07-24T03:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4999b61521bc02a9ec847db97f04246caaa130f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fabiokung","id":5755,"node_id":"MDQ6VXNlcjU3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5755?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiokung","html_url":"https://github.com/fabiokung","followers_url":"https://api.github.com/users/fabiokung/followers","following_url":"https://api.github.com/users/fabiokung/following{/other_user}","gists_url":"https://api.github.com/users/fabiokung/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiokung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiokung/subscriptions","organizations_url":"https://api.github.com/users/fabiokung/orgs","repos_url":"https://api.github.com/users/fabiokung/repos","events_url":"https://api.github.com/users/fabiokung/events{/privacy}","received_events_url":"https://api.github.com/users/fabiokung/received_events","type":"User","site_admin":false},{"login":"andrew-leung","id":13291087,"node_id":"MDQ6VXNlcjEzMjkxMDg3","avatar_url":"https://avatars3.githubusercontent.com/u/13291087?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-leung","html_url":"https://github.com/andrew-leung","followers_url":"https://api.github.com/users/andrew-leung/followers","following_url":"https://api.github.com/users/andrew-leung/following{/other_user}","gists_url":"https://api.github.com/users/andrew-leung/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-leung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-leung/subscriptions","organizations_url":"https://api.github.com/users/andrew-leung/orgs","repos_url":"https://api.github.com/users/andrew-leung/repos","events_url":"https://api.github.com/users/andrew-leung/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-leung/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/titus-executor/pulls/158/commits","review_comments_url":"https://api.github.com/repos/Netflix/titus-executor/pulls/158/comments","review_comment_url":"https://api.github.com/repos/Netflix/titus-executor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/titus-executor/issues/158/comments","statuses_url":"https://api.github.com/repos/Netflix/titus-executor/statuses/2022d45ec92c65140c1e9287fdfa0a38b61bf376","head":{"label":"Netflix:TITUS-895_publish_log_upload_bytes_metrics_with_conditional_tags","ref":"TITUS-895_publish_log_upload_bytes_metrics_with_conditional_tags","sha":"2022d45ec92c65140c1e9287fdfa0a38b61bf376","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":108340504,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzNDA1MDQ=","name":"titus-executor","full_name":"Netflix/titus-executor","owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/titus-executor","description":null,"fork":false,"url":"https://api.github.com/repos/Netflix/titus-executor","forks_url":"https://api.github.com/repos/Netflix/titus-executor/forks","keys_url":"https://api.github.com/repos/Netflix/titus-executor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/titus-executor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/titus-executor/teams","hooks_url":"https://api.github.com/repos/Netflix/titus-executor/hooks","issue_events_url":"https://api.github.com/repos/Netflix/titus-executor/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/titus-executor/events","assignees_url":"https://api.github.com/repos/Netflix/titus-executor/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/titus-executor/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/titus-executor/tags","blobs_url":"https://api.github.com/repos/Netflix/titus-executor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/titus-executor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/titus-executor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/titus-executor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/titus-executor/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/titus-executor/languages","stargazers_url":"https://api.github.com/repos/Netflix/titus-executor/stargazers","contributors_url":"https://api.github.com/repos/Netflix/titus-executor/contributors","subscribers_url":"https://api.github.com/repos/Netflix/titus-executor/subscribers","subscription_url":"https://api.github.com/repos/Netflix/titus-executor/subscription","commits_url":"https://api.github.com/repos/Netflix/titus-executor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/titus-executor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/titus-executor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/titus-executor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/titus-executor/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/titus-executor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/titus-executor/merges","archive_url":"https://api.github.com/repos/Netflix/titus-executor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/titus-executor/downloads","issues_url":"https://api.github.com/repos/Netflix/titus-executor/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/titus-executor/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/titus-executor/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/titus-executor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/titus-executor/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/titus-executor/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/titus-executor/deployments","created_at":"2017-10-26T00:14:59Z","updated_at":"2018-07-19T08:15:56Z","pushed_at":"2018-07-24T03:47:23Z","git_url":"git://github.com/Netflix/titus-executor.git","ssh_url":"git@github.com:Netflix/titus-executor.git","clone_url":"https://github.com/Netflix/titus-executor.git","svn_url":"https://github.com/Netflix/titus-executor","homepage":null,"size":3509,"stargazers_count":131,"watchers_count":131,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":9,"watchers":131,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"c96a5cad50579db5d15072eef2b3be1abb880fb2","user":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":108340504,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzNDA1MDQ=","name":"titus-executor","full_name":"Netflix/titus-executor","owner":{"login":"Netflix","id":913567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMzU2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/titus-executor","description":null,"fork":false,"url":"https://api.github.com/repos/Netflix/titus-executor","forks_url":"https://api.github.com/repos/Netflix/titus-executor/forks","keys_url":"https://api.github.com/repos/Netflix/titus-executor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/titus-executor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/titus-executor/teams","hooks_url":"https://api.github.com/repos/Netflix/titus-executor/hooks","issue_events_url":"https://api.github.com/repos/Netflix/titus-executor/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/titus-executor/events","assignees_url":"https://api.github.com/repos/Netflix/titus-executor/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/titus-executor/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/titus-executor/tags","blobs_url":"https://api.github.com/repos/Netflix/titus-executor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/titus-executor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/titus-executor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/titus-executor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/titus-executor/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/titus-executor/languages","stargazers_url":"https://api.github.com/repos/Netflix/titus-executor/stargazers","contributors_url":"https://api.github.com/repos/Netflix/titus-executor/contributors","subscribers_url":"https://api.github.com/repos/Netflix/titus-executor/subscribers","subscription_url":"https://api.github.com/repos/Netflix/titus-executor/subscription","commits_url":"https://api.github.com/repos/Netflix/titus-executor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/titus-executor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/titus-executor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/titus-executor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/titus-executor/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/titus-executor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/titus-executor/merges","archive_url":"https://api.github.com/repos/Netflix/titus-executor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/titus-executor/downloads","issues_url":"https://api.github.com/repos/Netflix/titus-executor/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/titus-executor/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/titus-executor/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/titus-executor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/titus-executor/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/titus-executor/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/titus-executor/deployments","created_at":"2017-10-26T00:14:59Z","updated_at":"2018-07-19T08:15:56Z","pushed_at":"2018-07-24T03:47:23Z","git_url":"git://github.com/Netflix/titus-executor.git","ssh_url":"git@github.com:Netflix/titus-executor.git","clone_url":"https://github.com/Netflix/titus-executor.git","svn_url":"https://github.com/Netflix/titus-executor","homepage":null,"size":3509,"stargazers_count":131,"watchers_count":131,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":9,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/titus-executor/pulls/158"},"html":{"href":"https://github.com/Netflix/titus-executor/pull/158"},"issue":{"href":"https://api.github.com/repos/Netflix/titus-executor/issues/158"},"comments":{"href":"https://api.github.com/repos/Netflix/titus-executor/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/titus-executor/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/titus-executor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/titus-executor/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/titus-executor/statuses/2022d45ec92c65140c1e9287fdfa0a38b61bf376"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rickkw"}}