{"action":"closed","number":3558,"pull_request":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3558","id":187875462,"html_url":"https://github.com/OpenLiberty/open-liberty/pull/3558","diff_url":"https://github.com/OpenLiberty/open-liberty/pull/3558.diff","patch_url":"https://github.com/OpenLiberty/open-liberty/pull/3558.patch","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3558","number":3558,"state":"closed","locked":false,"title":"Set default ID for keyStore element so configs merge properly","user":{"login":"aguibert","id":5427967,"avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false},"body":"In the past, it has been possible to do the following to configure the default keystore:\r\n\r\n<server>\r\n  <keyStore password=\"whatever\"/>\r\n</server>\r\n\r\nAs a result of the following design issue: https://github.com/OpenLiberty/open-liberty/issues/1175 we made changes to auto-generate the default keystore out of the box.\r\n\r\nIn this case, both configurations fail because we are trying to create 2 keystores with different passwords at the same location:  one for the default instance with the generated password, and the other for the no-ID config element in server.xml.\r\n\r\nTo resolve this issue, we will default the ID to `defaultKeyStore` in metatype, so that no-ID configs will merge with the default instance.  This also has the side effect that multiple no-ID configs will now merge into one, but this sort of config is not usable currently, so it seems to be an acceptable tradeoff.","created_at":"2018-05-14T16:01:22Z","updated_at":"2018-05-22T13:21:54Z","closed_at":"2018-05-22T13:21:53Z","merged_at":"2018-05-22T13:21:53Z","merge_commit_sha":"8d070ac8d86610e990694f30af8cd01a9b0885c3","assignee":{"login":"aguibert","id":5427967,"avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false},"assignees":[{"login":"aguibert","id":5427967,"avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":693734934,"url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels/bug","name":"bug","color":"ee0701","default":true},{"id":696392977,"url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels/in:Security","name":"in:Security","color":"bfd4f2","default":false},{"id":696391265,"url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels/team:Zombie%20Apocalypse","name":"team:Zombie Apocalypse","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3558/commits","review_comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3558/comments","review_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3558/comments","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/f0a4646001a1f480b748815107faf661450502ce","head":{"label":"aguibert:defaultKeyStore-gen-default-location","ref":"defaultKeyStore-gen-default-location","sha":"f0a4646001a1f480b748815107faf661450502ce","user":{"login":"aguibert","id":5427967,"avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false},"repo":{"id":103994044,"name":"open-liberty","full_name":"aguibert/open-liberty","owner":{"login":"aguibert","id":5427967,"avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aguibert/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":true,"url":"https://api.github.com/repos/aguibert/open-liberty","forks_url":"https://api.github.com/repos/aguibert/open-liberty/forks","keys_url":"https://api.github.com/repos/aguibert/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aguibert/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aguibert/open-liberty/teams","hooks_url":"https://api.github.com/repos/aguibert/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/aguibert/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/aguibert/open-liberty/events","assignees_url":"https://api.github.com/repos/aguibert/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/aguibert/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/aguibert/open-liberty/tags","blobs_url":"https://api.github.com/repos/aguibert/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aguibert/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aguibert/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/aguibert/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aguibert/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/aguibert/open-liberty/languages","stargazers_url":"https://api.github.com/repos/aguibert/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/aguibert/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/aguibert/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/aguibert/open-liberty/subscription","commits_url":"https://api.github.com/repos/aguibert/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/aguibert/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/aguibert/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/aguibert/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/aguibert/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/aguibert/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aguibert/open-liberty/merges","archive_url":"https://api.github.com/repos/aguibert/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aguibert/open-liberty/downloads","issues_url":"https://api.github.com/repos/aguibert/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/aguibert/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/aguibert/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/aguibert/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aguibert/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/aguibert/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/aguibert/open-liberty/deployments","created_at":"2017-09-18T21:30:08Z","updated_at":"2018-05-09T17:16:32Z","pushed_at":"2018-05-22T13:07:08Z","git_url":"git://github.com/aguibert/open-liberty.git","ssh_url":"git@github.com:aguibert/open-liberty.git","clone_url":"https://github.com/aguibert/open-liberty.git","svn_url":"https://github.com/aguibert/open-liberty","homepage":"http://openliberty.io","size":131367,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"OpenLiberty:integration","ref":"integration","sha":"10ef93bb4e0aac74344492d05d0b15ac34e630c2","user":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"repo":{"id":103694377,"name":"open-liberty","full_name":"OpenLiberty/open-liberty","owner":{"login":"OpenLiberty","id":28316667,"avatar_url":"https://avatars2.githubusercontent.com/u/28316667?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenLiberty","html_url":"https://github.com/OpenLiberty","followers_url":"https://api.github.com/users/OpenLiberty/followers","following_url":"https://api.github.com/users/OpenLiberty/following{/other_user}","gists_url":"https://api.github.com/users/OpenLiberty/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLiberty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLiberty/subscriptions","organizations_url":"https://api.github.com/users/OpenLiberty/orgs","repos_url":"https://api.github.com/users/OpenLiberty/repos","events_url":"https://api.github.com/users/OpenLiberty/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLiberty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLiberty/open-liberty","description":"Open Liberty is a highly composable, fast to start, dynamic application server runtime environment ","fork":false,"url":"https://api.github.com/repos/OpenLiberty/open-liberty","forks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/forks","keys_url":"https://api.github.com/repos/OpenLiberty/open-liberty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLiberty/open-liberty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLiberty/open-liberty/teams","hooks_url":"https://api.github.com/repos/OpenLiberty/open-liberty/hooks","issue_events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/events","assignees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLiberty/open-liberty/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/tags","blobs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLiberty/open-liberty/languages","stargazers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/stargazers","contributors_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contributors","subscribers_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscribers","subscription_url":"https://api.github.com/repos/OpenLiberty/open-liberty/subscription","commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLiberty/open-liberty/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenLiberty/open-liberty/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLiberty/open-liberty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLiberty/open-liberty/merges","archive_url":"https://api.github.com/repos/OpenLiberty/open-liberty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLiberty/open-liberty/downloads","issues_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLiberty/open-liberty/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLiberty/open-liberty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels{/name}","releases_url":"https://api.github.com/repos/OpenLiberty/open-liberty/releases{/id}","deployments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/deployments","created_at":"2017-09-15T19:34:25Z","updated_at":"2018-05-22T12:52:21Z","pushed_at":"2018-05-22T13:21:53Z","git_url":"git://github.com/OpenLiberty/open-liberty.git","ssh_url":"git@github.com:OpenLiberty/open-liberty.git","clone_url":"https://github.com/OpenLiberty/open-liberty.git","svn_url":"https://github.com/OpenLiberty/open-liberty","homepage":"http://openliberty.io","size":131774,"stargazers_count":290,"watchers_count":290,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":513,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":241,"open_issues":513,"watchers":290,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3558"},"html":{"href":"https://github.com/OpenLiberty/open-liberty/pull/3558"},"issue":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3558"},"comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3558/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3558/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/pulls/3558/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLiberty/open-liberty/statuses/f0a4646001a1f480b748815107faf661450502ce"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aguibert","id":5427967,"avatar_url":"https://avatars2.githubusercontent.com/u/5427967?v=4","gravatar_id":"","url":"https://api.github.com/users/aguibert","html_url":"https://github.com/aguibert","followers_url":"https://api.github.com/users/aguibert/followers","following_url":"https://api.github.com/users/aguibert/following{/other_user}","gists_url":"https://api.github.com/users/aguibert/gists{/gist_id}","starred_url":"https://api.github.com/users/aguibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguibert/subscriptions","organizations_url":"https://api.github.com/users/aguibert/orgs","repos_url":"https://api.github.com/users/aguibert/repos","events_url":"https://api.github.com/users/aguibert/events{/privacy}","received_events_url":"https://api.github.com/users/aguibert/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"aguibert"}}