{"action":"closed","number":177,"pull_request":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/177","id":212778907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzc4OTA3","html_url":"https://github.com/stardust-ui/react/pull/177","diff_url":"https://github.com/stardust-ui/react/pull/177.diff","patch_url":"https://github.com/stardust-ui/react/pull/177.patch","issue_url":"https://api.github.com/repos/stardust-ui/react/issues/177","number":177,"state":"closed","locked":false,"title":"feat(Button): add text variant","user":{"login":"mnajdova","id":4512430,"node_id":"MDQ6VXNlcjQ1MTI0MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/4512430?v=4","gravatar_id":"","url":"https://api.github.com/users/mnajdova","html_url":"https://github.com/mnajdova","followers_url":"https://api.github.com/users/mnajdova/followers","following_url":"https://api.github.com/users/mnajdova/following{/other_user}","gists_url":"https://api.github.com/users/mnajdova/gists{/gist_id}","starred_url":"https://api.github.com/users/mnajdova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnajdova/subscriptions","organizations_url":"https://api.github.com/users/mnajdova/orgs","repos_url":"https://api.github.com/users/mnajdova/repos","events_url":"https://api.github.com/users/mnajdova/events{/privacy}","received_events_url":"https://api.github.com/users/mnajdova/received_events","type":"User","site_admin":false},"body":"# Button\r\n\r\nAdding text variant to the button, that will display the button without any background and border.\r\n\r\n### TODO\r\n\r\n- [x] Conformance test\r\n- [x] Minimal doc site example\r\n- [ ] Stardust base theme\r\n- [ ] Teams Light theme\r\n- [ ] Teams Dark theme\r\n- [ ] Teams Contrast theme\r\n- [ ] Confirm RTL usage\r\n- [ ] [W3 accessibility](https://www.w3.org/standards/webdesign/accessibility) check\r\n- [ ] [Stardust accessibility](https://github.com/stardust-ui/accessibility) check\r\n- [ ] Update glossary props table\r\n- [x] Update the CHANGELOG.md\r\n\r\n# API Proposal\r\n\r\n## text: boolean\r\n\r\n![image](https://user-images.githubusercontent.com/4512430/44994227-ee726200-af9d-11e8-9a8e-0360daa86e18.png)\r\n\r\nA button can be formatted to show only text in order to indicate some less-pronounced actions.\r\n\r\n```jsx\r\n<Button text icon=\"book\" content=\"Default\" iconPosition=\"before\" />\r\n```\r\n\r\n```html\r\n<button class=\"ui-button ...\" aria-disabled=\"false\">\r\n  <span class=\"ui-icon ...\" aria-hidden=\"true\"></span>\r\n  <span class=\"q r s\">Default</span>\r\n</button>\r\n```\r\n\r\nAt this moment, the styles of the buttons containing the text prop, are just reducing the background and border, and on hover are altering the color of the text to be the `brand` color. We may need to change this, as the current text color of the primary button is white, which is maybe not the most appropriate one. Once the API is approved, we can agree on colors used for the default, primary and secondary variations of the text button.","created_at":"2018-09-03T15:24:58Z","updated_at":"2018-09-06T17:56:15Z","closed_at":"2018-09-06T17:56:15Z","merged_at":"2018-09-06T17:56:15Z","merge_commit_sha":"9b21eea0a1678d2a6b7dcd7e68d714b7b5e79a93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"levithomason","id":5067638,"node_id":"MDQ6VXNlcjUwNjc2Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/5067638?v=4","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},{"login":"davezuko","id":6439050,"node_id":"MDQ6VXNlcjY0MzkwNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6439050?v=4","gravatar_id":"","url":"https://api.github.com/users/davezuko","html_url":"https://github.com/davezuko","followers_url":"https://api.github.com/users/davezuko/followers","following_url":"https://api.github.com/users/davezuko/following{/other_user}","gists_url":"https://api.github.com/users/davezuko/gists{/gist_id}","starred_url":"https://api.github.com/users/davezuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezuko/subscriptions","organizations_url":"https://api.github.com/users/davezuko/orgs","repos_url":"https://api.github.com/users/davezuko/repos","events_url":"https://api.github.com/users/davezuko/events{/privacy}","received_events_url":"https://api.github.com/users/davezuko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1026600697,"node_id":"MDU6TGFiZWwxMDI2NjAwNjk3","url":"https://api.github.com/repos/stardust-ui/react/labels/RFC","name":"RFC","color":"0052cc","default":false},{"id":1030124399,"node_id":"MDU6TGFiZWwxMDMwMTI0Mzk5","url":"https://api.github.com/repos/stardust-ui/react/labels/ready%20for%20merge","name":"ready for merge","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stardust-ui/react/pulls/177/commits","review_comments_url":"https://api.github.com/repos/stardust-ui/react/pulls/177/comments","review_comment_url":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stardust-ui/react/issues/177/comments","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/fb02d3c1f5993773c37a380c9ce0d677f2e1fddd","head":{"label":"stardust-ui:feat/button-text","ref":"feat/button-text","sha":"fb02d3c1f5993773c37a380c9ce0d677f2e1fddd","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-09-06T17:30:11Z","pushed_at":"2018-09-06T17:56:15Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":19043,"stargazers_count":50,"watchers_count":50,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":61,"watchers":50,"default_branch":"master"}},"base":{"label":"stardust-ui:master","ref":"master","sha":"b3467c4459a17c0eaa0c15bc8a8c05751803137a","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-09-06T17:30:11Z","pushed_at":"2018-09-06T17:56:15Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":19043,"stargazers_count":50,"watchers_count":50,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":61,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/177"},"html":{"href":"https://github.com/stardust-ui/react/pull/177"},"issue":{"href":"https://api.github.com/repos/stardust-ui/react/issues/177"},"comments":{"href":"https://api.github.com/repos/stardust-ui/react/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/stardust-ui/react/statuses/fb02d3c1f5993773c37a380c9ce0d677f2e1fddd"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mnajdova","id":4512430,"node_id":"MDQ6VXNlcjQ1MTI0MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/4512430?v=4","gravatar_id":"","url":"https://api.github.com/users/mnajdova","html_url":"https://github.com/mnajdova","followers_url":"https://api.github.com/users/mnajdova/followers","following_url":"https://api.github.com/users/mnajdova/following{/other_user}","gists_url":"https://api.github.com/users/mnajdova/gists{/gist_id}","starred_url":"https://api.github.com/users/mnajdova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnajdova/subscriptions","organizations_url":"https://api.github.com/users/mnajdova/orgs","repos_url":"https://api.github.com/users/mnajdova/repos","events_url":"https://api.github.com/users/mnajdova/events{/privacy}","received_events_url":"https://api.github.com/users/mnajdova/received_events","type":"User","site_admin":false},"comments":4,"review_comments":5,"maintainer_can_modify":false,"commits":10,"additions":118,"deletions":37,"changed_files":9}}
{"actor":{"display_login":"mnajdova"}}