{"action":"created","issue":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/5399","repository_url":"https://api.github.com/repos/pytorch/pytorch","labels_url":"https://api.github.com/repos/pytorch/pytorch/issues/5399/labels{/name}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/5399/comments","events_url":"https://api.github.com/repos/pytorch/pytorch/issues/5399/events","html_url":"https://github.com/pytorch/pytorch/pull/5399","id":299961064,"number":5399,"title":"make CuDNN finders respect library major version","user":{"login":"soumith","id":1310570,"avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-24T18:19:04Z","updated_at":"2018-02-24T22:06:10Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/5399","html_url":"https://github.com/pytorch/pytorch/pull/5399","diff_url":"https://github.com/pytorch/pytorch/pull/5399.diff","patch_url":"https://github.com/pytorch/pytorch/pull/5399.patch"},"body":"- FindCuDNN.cmake wasn't respecting `setup.py`'s found CUDNN_INCLUDE_DIR and CUDNN_LIBRARY\r\n- CUDNN_INCLUDE_DIR wasn't respecting path order (a `break` on found was missing)\r\n- There was no `setup_helpers/cudnn.py` check to make sure that the header `cudnn.h` that is found is paired with the corresponding `libcudnn.so`.\r\n\r\nAll these three issues have been fixed.\r\n\r\nFixes https://github.com/pytorch/pytorch/issues/5369\r\n\r\ncc: @ezyang "},"comment":{"url":"https://api.github.com/repos/pytorch/pytorch/issues/comments/368263941","html_url":"https://github.com/pytorch/pytorch/pull/5399#issuecomment-368263941","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/5399","id":368263941,"user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T22:06:10Z","updated_at":"2018-02-24T22:06:10Z","author_association":"COLLABORATOR","body":"This is not really related to the substance of this particular patch, but when #5383 I wonder if we can skip finding cuDNN from the Python setup helpers (needed because we previously used ctypes to call functions) and rely solely on cmake to find it."}}
{"actor":{"display_login":"ezyang"}}