{"action":"created","comment":{"url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/comments/177368226","pull_request_review_id":107222492,"id":177368226,"diff_hunk":"@@ -0,0 +1,30 @@\n+//\n+// Created by Brandon Wong on 3/26/18.\n+//\n+\n+#include \"shaka_scheme/system/gc/GC.hpp\"\n+\n+namespace shaka {\n+\n+    namespace gc {\n+\n+        GC::GC() {}\n+        GC::~GC() {}\n+\n+        GC::GC(GC&& other) : list(std::move(other.list)) {}\n+\n+        GCData* GC::create_data(const shaka::Data& data) {\n+            GCData *gcd = new GCData(data);\n+            this->list.add_data(gcd);\n+            return gcd;\n+        }\n+\n+        int GC::get_size() {\n+            return this->list.get_size();\n+        }\n+\n+        void GC::sweep() {\n+            this->list.sweep();","path":"src/shaka_scheme/system/gc/GC.cpp","position":27,"original_position":27,"commit_id":"320350106cea1cab3a476beca63fd560722c0f5d","original_commit_id":"320350106cea1cab3a476beca63fd560722c0f5d","user":{"login":"bmwfire","id":31464704,"avatar_url":"https://avatars0.githubusercontent.com/u/31464704?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwfire","html_url":"https://github.com/bmwfire","followers_url":"https://api.github.com/users/bmwfire/followers","following_url":"https://api.github.com/users/bmwfire/following{/other_user}","gists_url":"https://api.github.com/users/bmwfire/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwfire/subscriptions","organizations_url":"https://api.github.com/users/bmwfire/orgs","repos_url":"https://api.github.com/users/bmwfire/repos","events_url":"https://api.github.com/users/bmwfire/events{/privacy}","received_events_url":"https://api.github.com/users/bmwfire/received_events","type":"User","site_admin":false},"body":"Well keeping in mind that GCList is a private member of GC, it really doesn't matter where the method is specified. Recall that GCList houses the private members of the GCData head pointer as well as the size of the list. This is why we placed `sweep()` inside of the GCList class, then further called it within GC.","created_at":"2018-03-27T09:51:40Z","updated_at":"2018-03-27T09:51:40Z","html_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/68#discussion_r177368226","pull_request_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/comments/177368226"},"html":{"href":"https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/68#discussion_r177368226"},"pull_request":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68"}},"in_reply_to_id":177354701},"pull_request":{"url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68","id":177602211,"html_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/68","diff_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/68.diff","patch_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/68.patch","issue_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues/68","number":68,"state":"open","locked":false,"title":"Implemented class GC","user":{"login":"bmwfire","id":31464704,"avatar_url":"https://avatars0.githubusercontent.com/u/31464704?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwfire","html_url":"https://github.com/bmwfire","followers_url":"https://api.github.com/users/bmwfire/followers","following_url":"https://api.github.com/users/bmwfire/following{/other_user}","gists_url":"https://api.github.com/users/bmwfire/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwfire/subscriptions","organizations_url":"https://api.github.com/users/bmwfire/orgs","repos_url":"https://api.github.com/users/bmwfire/repos","events_url":"https://api.github.com/users/bmwfire/events{/privacy}","received_events_url":"https://api.github.com/users/bmwfire/received_events","type":"User","site_admin":false},"body":"PR implements factory method for garbage collector which allows to add GCData to the GCList automatically","created_at":"2018-03-27T00:27:21Z","updated_at":"2018-03-27T09:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"500b5ce472f1b047e387b68f730025ae2f49fb2c","assignee":{"login":"bmwfire","id":31464704,"avatar_url":"https://avatars0.githubusercontent.com/u/31464704?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwfire","html_url":"https://github.com/bmwfire","followers_url":"https://api.github.com/users/bmwfire/followers","following_url":"https://api.github.com/users/bmwfire/following{/other_user}","gists_url":"https://api.github.com/users/bmwfire/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwfire/subscriptions","organizations_url":"https://api.github.com/users/bmwfire/orgs","repos_url":"https://api.github.com/users/bmwfire/repos","events_url":"https://api.github.com/users/bmwfire/events{/privacy}","received_events_url":"https://api.github.com/users/bmwfire/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmwfire","id":31464704,"avatar_url":"https://avatars0.githubusercontent.com/u/31464704?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwfire","html_url":"https://github.com/bmwfire","followers_url":"https://api.github.com/users/bmwfire/followers","following_url":"https://api.github.com/users/bmwfire/following{/other_user}","gists_url":"https://api.github.com/users/bmwfire/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwfire/subscriptions","organizations_url":"https://api.github.com/users/bmwfire/orgs","repos_url":"https://api.github.com/users/bmwfire/repos","events_url":"https://api.github.com/users/bmwfire/events{/privacy}","received_events_url":"https://api.github.com/users/bmwfire/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68/commits","review_comments_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68/comments","review_comment_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues/68/comments","statuses_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/statuses/320350106cea1cab3a476beca63fd560722c0f5d","head":{"label":"bmwfire:pull-request-GC","ref":"pull-request-GC","sha":"320350106cea1cab3a476beca63fd560722c0f5d","user":{"login":"bmwfire","id":31464704,"avatar_url":"https://avatars0.githubusercontent.com/u/31464704?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwfire","html_url":"https://github.com/bmwfire","followers_url":"https://api.github.com/users/bmwfire/followers","following_url":"https://api.github.com/users/bmwfire/following{/other_user}","gists_url":"https://api.github.com/users/bmwfire/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwfire/subscriptions","organizations_url":"https://api.github.com/users/bmwfire/orgs","repos_url":"https://api.github.com/users/bmwfire/repos","events_url":"https://api.github.com/users/bmwfire/events{/privacy}","received_events_url":"https://api.github.com/users/bmwfire/received_events","type":"User","site_admin":false},"repo":{"id":119323349,"name":"shaka-scheme","full_name":"bmwfire/shaka-scheme","owner":{"login":"bmwfire","id":31464704,"avatar_url":"https://avatars0.githubusercontent.com/u/31464704?v=4","gravatar_id":"","url":"https://api.github.com/users/bmwfire","html_url":"https://github.com/bmwfire","followers_url":"https://api.github.com/users/bmwfire/followers","following_url":"https://api.github.com/users/bmwfire/following{/other_user}","gists_url":"https://api.github.com/users/bmwfire/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwfire/subscriptions","organizations_url":"https://api.github.com/users/bmwfire/orgs","repos_url":"https://api.github.com/users/bmwfire/repos","events_url":"https://api.github.com/users/bmwfire/events{/privacy}","received_events_url":"https://api.github.com/users/bmwfire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmwfire/shaka-scheme","description":"The official repository for the UH Manoa Transpiler Project's Scheme interpreter, Shaka Scheme.","fork":true,"url":"https://api.github.com/repos/bmwfire/shaka-scheme","forks_url":"https://api.github.com/repos/bmwfire/shaka-scheme/forks","keys_url":"https://api.github.com/repos/bmwfire/shaka-scheme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmwfire/shaka-scheme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmwfire/shaka-scheme/teams","hooks_url":"https://api.github.com/repos/bmwfire/shaka-scheme/hooks","issue_events_url":"https://api.github.com/repos/bmwfire/shaka-scheme/issues/events{/number}","events_url":"https://api.github.com/repos/bmwfire/shaka-scheme/events","assignees_url":"https://api.github.com/repos/bmwfire/shaka-scheme/assignees{/user}","branches_url":"https://api.github.com/repos/bmwfire/shaka-scheme/branches{/branch}","tags_url":"https://api.github.com/repos/bmwfire/shaka-scheme/tags","blobs_url":"https://api.github.com/repos/bmwfire/shaka-scheme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmwfire/shaka-scheme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmwfire/shaka-scheme/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmwfire/shaka-scheme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmwfire/shaka-scheme/statuses/{sha}","languages_url":"https://api.github.com/repos/bmwfire/shaka-scheme/languages","stargazers_url":"https://api.github.com/repos/bmwfire/shaka-scheme/stargazers","contributors_url":"https://api.github.com/repos/bmwfire/shaka-scheme/contributors","subscribers_url":"https://api.github.com/repos/bmwfire/shaka-scheme/subscribers","subscription_url":"https://api.github.com/repos/bmwfire/shaka-scheme/subscription","commits_url":"https://api.github.com/repos/bmwfire/shaka-scheme/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmwfire/shaka-scheme/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmwfire/shaka-scheme/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmwfire/shaka-scheme/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmwfire/shaka-scheme/contents/{+path}","compare_url":"https://api.github.com/repos/bmwfire/shaka-scheme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmwfire/shaka-scheme/merges","archive_url":"https://api.github.com/repos/bmwfire/shaka-scheme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmwfire/shaka-scheme/downloads","issues_url":"https://api.github.com/repos/bmwfire/shaka-scheme/issues{/number}","pulls_url":"https://api.github.com/repos/bmwfire/shaka-scheme/pulls{/number}","milestones_url":"https://api.github.com/repos/bmwfire/shaka-scheme/milestones{/number}","notifications_url":"https://api.github.com/repos/bmwfire/shaka-scheme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmwfire/shaka-scheme/labels{/name}","releases_url":"https://api.github.com/repos/bmwfire/shaka-scheme/releases{/id}","deployments_url":"https://api.github.com/repos/bmwfire/shaka-scheme/deployments","created_at":"2018-01-29T02:53:54Z","updated_at":"2018-03-26T08:30:38Z","pushed_at":"2018-03-27T01:06:56Z","git_url":"git://github.com/bmwfire/shaka-scheme.git","ssh_url":"git@github.com:bmwfire/shaka-scheme.git","clone_url":"https://github.com/bmwfire/shaka-scheme.git","svn_url":"https://github.com/bmwfire/shaka-scheme","homepage":null,"size":2790,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uhmanoa-transpiler-project:master","ref":"master","sha":"7b67f427f68d0b037f3f5e50d24e2ee46e557d48","user":{"login":"uhmanoa-transpiler-project","id":25163271,"avatar_url":"https://avatars3.githubusercontent.com/u/25163271?v=4","gravatar_id":"","url":"https://api.github.com/users/uhmanoa-transpiler-project","html_url":"https://github.com/uhmanoa-transpiler-project","followers_url":"https://api.github.com/users/uhmanoa-transpiler-project/followers","following_url":"https://api.github.com/users/uhmanoa-transpiler-project/following{/other_user}","gists_url":"https://api.github.com/users/uhmanoa-transpiler-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uhmanoa-transpiler-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uhmanoa-transpiler-project/subscriptions","organizations_url":"https://api.github.com/users/uhmanoa-transpiler-project/orgs","repos_url":"https://api.github.com/users/uhmanoa-transpiler-project/repos","events_url":"https://api.github.com/users/uhmanoa-transpiler-project/events{/privacy}","received_events_url":"https://api.github.com/users/uhmanoa-transpiler-project/received_events","type":"Organization","site_admin":false},"repo":{"id":79173180,"name":"shaka-scheme","full_name":"uhmanoa-transpiler-project/shaka-scheme","owner":{"login":"uhmanoa-transpiler-project","id":25163271,"avatar_url":"https://avatars3.githubusercontent.com/u/25163271?v=4","gravatar_id":"","url":"https://api.github.com/users/uhmanoa-transpiler-project","html_url":"https://github.com/uhmanoa-transpiler-project","followers_url":"https://api.github.com/users/uhmanoa-transpiler-project/followers","following_url":"https://api.github.com/users/uhmanoa-transpiler-project/following{/other_user}","gists_url":"https://api.github.com/users/uhmanoa-transpiler-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uhmanoa-transpiler-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uhmanoa-transpiler-project/subscriptions","organizations_url":"https://api.github.com/users/uhmanoa-transpiler-project/orgs","repos_url":"https://api.github.com/users/uhmanoa-transpiler-project/repos","events_url":"https://api.github.com/users/uhmanoa-transpiler-project/events{/privacy}","received_events_url":"https://api.github.com/users/uhmanoa-transpiler-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme","description":"The official repository for the UH Manoa Transpiler Project's Scheme interpreter, Shaka Scheme.","fork":false,"url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme","forks_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/forks","keys_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/teams","hooks_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/hooks","issue_events_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues/events{/number}","events_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/events","assignees_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/assignees{/user}","branches_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/branches{/branch}","tags_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/tags","blobs_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/git/refs{/sha}","trees_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/statuses/{sha}","languages_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/languages","stargazers_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/stargazers","contributors_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/contributors","subscribers_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/subscribers","subscription_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/subscription","commits_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/commits{/sha}","git_commits_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/git/commits{/sha}","comments_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/comments{/number}","issue_comment_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues/comments{/number}","contents_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/contents/{+path}","compare_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/merges","archive_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/downloads","issues_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues{/number}","pulls_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls{/number}","milestones_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/milestones{/number}","notifications_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/labels{/name}","releases_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/releases{/id}","deployments_url":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/deployments","created_at":"2017-01-17T00:48:50Z","updated_at":"2018-03-26T23:53:18Z","pushed_at":"2018-03-27T08:58:16Z","git_url":"git://github.com/uhmanoa-transpiler-project/shaka-scheme.git","ssh_url":"git@github.com:uhmanoa-transpiler-project/shaka-scheme.git","clone_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme.git","svn_url":"https://github.com/uhmanoa-transpiler-project/shaka-scheme","homepage":null,"size":2772,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":23,"open_issues":7,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68"},"html":{"href":"https://github.com/uhmanoa-transpiler-project/shaka-scheme/pull/68"},"issue":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues/68"},"comments":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/uhmanoa-transpiler-project/shaka-scheme/statuses/320350106cea1cab3a476beca63fd560722c0f5d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmwfire"}}