{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments/206895466","pull_request_review_id":142392491,"id":206895466,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjg5NTQ2Ng==","diff_hunk":"@@ -43,7 +43,7 @@\n      * IDs of the attributes of the M-Bus Client Setup that make up the Short\n      * ID.\n      *\n-     * The order of the IDs in {@link #ATTRIBUTE_IDS_SHORT_ID} should match the\n+     * The order of the IDs in should match the","path":"osgp-protocol-adapter-dlms/src/main/java/org/opensmartgridplatform/adapter/protocol/dlms/domain/commands/ScanMbusChannelsCommandExecutor.java","position":48,"original_position":48,"commit_id":"4303c29e14399b5580c04a05b35716aa20737667","original_commit_id":"4303c29e14399b5580c04a05b35716aa20737667","user":{"login":"smvdheijden","id":11396536,"node_id":"MDQ6VXNlcjExMzk2NTM2","avatar_url":"https://avatars1.githubusercontent.com/u/11396536?v=4","gravatar_id":"","url":"https://api.github.com/users/smvdheijden","html_url":"https://github.com/smvdheijden","followers_url":"https://api.github.com/users/smvdheijden/followers","following_url":"https://api.github.com/users/smvdheijden/following{/other_user}","gists_url":"https://api.github.com/users/smvdheijden/gists{/gist_id}","starred_url":"https://api.github.com/users/smvdheijden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smvdheijden/subscriptions","organizations_url":"https://api.github.com/users/smvdheijden/orgs","repos_url":"https://api.github.com/users/smvdheijden/repos","events_url":"https://api.github.com/users/smvdheijden/events{/privacy}","received_events_url":"https://api.github.com/users/smvdheijden/received_events","type":"User","site_admin":false},"body":"The order of the IDs in what? (Either the link should not have been removed or the comments should have been updated correctly)\r\n","created_at":"2018-08-01T14:13:45Z","updated_at":"2018-08-01T14:24:38Z","html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/266#discussion_r206895466","pull_request_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments/206895466"},"html":{"href":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/266#discussion_r206895466"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266","id":205041911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDQxOTEx","html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/266","diff_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/266.diff","patch_url":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/266.patch","issue_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/266","number":266,"state":"open","locked":false,"title":"Oc 251 remove alliander from open source code","user":{"login":"robvanmaris","id":4981256,"node_id":"MDQ6VXNlcjQ5ODEyNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4981256?v=4","gravatar_id":"","url":"https://api.github.com/users/robvanmaris","html_url":"https://github.com/robvanmaris","followers_url":"https://api.github.com/users/robvanmaris/followers","following_url":"https://api.github.com/users/robvanmaris/following{/other_user}","gists_url":"https://api.github.com/users/robvanmaris/gists{/gist_id}","starred_url":"https://api.github.com/users/robvanmaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robvanmaris/subscriptions","organizations_url":"https://api.github.com/users/robvanmaris/orgs","repos_url":"https://api.github.com/users/robvanmaris/repos","events_url":"https://api.github.com/users/robvanmaris/events{/privacy}","received_events_url":"https://api.github.com/users/robvanmaris/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-31T09:00:24Z","updated_at":"2018-08-01T14:24:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"186af28c169ffe8ee75e7f0107355969ddd6ca08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266/commits","review_comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266/comments","review_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/266/comments","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/4303c29e14399b5580c04a05b35716aa20737667","head":{"label":"OSGP:OC-251_Remove_Alliander_from_open_source_code","ref":"OC-251_Remove_Alliander_from_open_source_code","sha":"4303c29e14399b5580c04a05b35716aa20737667","user":{"login":"OSGP","id":11352045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzUyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":33675294,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY3NTI5NA==","name":"Protocol-Adapter-DLMS","full_name":"OSGP/Protocol-Adapter-DLMS","owner":{"login":"OSGP","id":11352045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzUyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","description":"Protocol adapter and device simulator for Device Language Message Specification protocol.","fork":false,"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS","forks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/forks","keys_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/teams","hooks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/events","assignees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/tags","blobs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/languages","stargazers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscription","commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/merges","archive_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/downloads","issues_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/deployments","created_at":"2015-04-09T14:59:22Z","updated_at":"2018-07-25T15:36:33Z","pushed_at":"2018-07-31T16:26:10Z","git_url":"git://github.com/OSGP/Protocol-Adapter-DLMS.git","ssh_url":"git@github.com:OSGP/Protocol-Adapter-DLMS.git","clone_url":"https://github.com/OSGP/Protocol-Adapter-DLMS.git","svn_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","homepage":"http://www.opensmartgridplatform.org/","size":10265,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"ce7d2a843fc116c290b8fbf9ae3c8773eaebe79a","user":{"login":"OSGP","id":11352045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzUyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":33675294,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY3NTI5NA==","name":"Protocol-Adapter-DLMS","full_name":"OSGP/Protocol-Adapter-DLMS","owner":{"login":"OSGP","id":11352045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzUyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/11352045?v=4","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","description":"Protocol adapter and device simulator for Device Language Message Specification protocol.","fork":false,"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS","forks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/forks","keys_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/teams","hooks_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/events","assignees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/tags","blobs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/languages","stargazers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/subscription","commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/merges","archive_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/downloads","issues_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/releases{/id}","deployments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/deployments","created_at":"2015-04-09T14:59:22Z","updated_at":"2018-07-25T15:36:33Z","pushed_at":"2018-07-31T16:26:10Z","git_url":"git://github.com/OSGP/Protocol-Adapter-DLMS.git","ssh_url":"git@github.com:OSGP/Protocol-Adapter-DLMS.git","clone_url":"https://github.com/OSGP/Protocol-Adapter-DLMS.git","svn_url":"https://github.com/OSGP/Protocol-Adapter-DLMS","homepage":"http://www.opensmartgridplatform.org/","size":10265,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":4,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266"},"html":{"href":"https://github.com/OSGP/Protocol-Adapter-DLMS/pull/266"},"issue":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/266"},"comments":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Protocol-Adapter-DLMS/statuses/4303c29e14399b5580c04a05b35716aa20737667"}},"author_association":"NONE"}}
{"actor":{"display_login":"smvdheijden"}}