{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments/204189774","pull_request_review_id":139235284,"id":204189774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE4OTc3NA==","diff_hunk":"@@ -47,14 +52,15 @@ export class Fab extends React.Component {\n           className={this.classes}\n           ref={initRipple}\n           {...otherProps}>\n-          {this.addIconClassToAllChildren()}\n+          {this.renderIcon()}","path":"packages/fab/index.js","position":31,"original_position":31,"commit_id":"cc863b377e01894edacd93602586c7190f350a5d","original_commit_id":"cc863b377e01894edacd93602586c7190f350a5d","user":{"login":"moog16","id":579873,"node_id":"MDQ6VXNlcjU3OTg3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/579873?v=4","gravatar_id":"","url":"https://api.github.com/users/moog16","html_url":"https://github.com/moog16","followers_url":"https://api.github.com/users/moog16/followers","following_url":"https://api.github.com/users/moog16/following{/other_user}","gists_url":"https://api.github.com/users/moog16/gists{/gist_id}","starred_url":"https://api.github.com/users/moog16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moog16/subscriptions","organizations_url":"https://api.github.com/users/moog16/orgs","repos_url":"https://api.github.com/users/moog16/repos","events_url":"https://api.github.com/users/moog16/events{/privacy}","received_events_url":"https://api.github.com/users/moog16/received_events","type":"User","site_admin":false},"body":"comment for line above ^ remove children from list, since you don't use it","created_at":"2018-07-20T23:20:59Z","updated_at":"2018-07-20T23:21:00Z","html_url":"https://github.com/material-components/material-components-web-react/pull/159#discussion_r204189774","pull_request_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments/204189774"},"html":{"href":"https://github.com/material-components/material-components-web-react/pull/159#discussion_r204189774"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159","id":202919466,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTE5NDY2","html_url":"https://github.com/material-components/material-components-web-react/pull/159","diff_url":"https://github.com/material-components/material-components-web-react/pull/159.diff","patch_url":"https://github.com/material-components/material-components-web-react/pull/159.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/159","number":159,"state":"open","locked":false,"title":"chore(fab): Pass icon as a prop, not a child element","user":{"login":"lynnjepsen","id":4703432,"node_id":"MDQ6VXNlcjQ3MDM0MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/4703432?v=4","gravatar_id":"","url":"https://api.github.com/users/lynnjepsen","html_url":"https://github.com/lynnjepsen","followers_url":"https://api.github.com/users/lynnjepsen/followers","following_url":"https://api.github.com/users/lynnjepsen/following{/other_user}","gists_url":"https://api.github.com/users/lynnjepsen/gists{/gist_id}","starred_url":"https://api.github.com/users/lynnjepsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynnjepsen/subscriptions","organizations_url":"https://api.github.com/users/lynnjepsen/orgs","repos_url":"https://api.github.com/users/lynnjepsen/repos","events_url":"https://api.github.com/users/lynnjepsen/events{/privacy}","received_events_url":"https://api.github.com/users/lynnjepsen/received_events","type":"User","site_admin":false},"body":"This is to prepare us for the extended FAB (#127) where we need to accept both an icon and a label as input. Both icon and label will be passed as props to the `Fab` component","created_at":"2018-07-20T18:08:18Z","updated_at":"2018-07-20T23:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07ec575a9cc11acb04a9c108ea01ce5e6a2274f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/159/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web-react/statuses/cc863b377e01894edacd93602586c7190f350a5d","head":{"label":"material-components:feat/extended-fab","ref":"feat/extended-fab","sha":"cc863b377e01894edacd93602586c7190f350a5d","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":124129430,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMjk0MzA=","name":"material-components-web-react","full_name":"material-components/material-components-web-react","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web-react","description":"Material Components for React (MDC React)","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web-react","forks_url":"https://api.github.com/repos/material-components/material-components-web-react/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web-react/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web-react/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web-react/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web-react/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web-react/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web-react/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web-react/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web-react/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web-react/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web-react/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web-react/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web-react/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web-react/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web-react/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web-react/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web-react/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web-react/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web-react/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web-react/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web-react/deployments","created_at":"2018-03-06T19:42:24Z","updated_at":"2018-07-20T20:55:54Z","pushed_at":"2018-07-20T23:16:59Z","git_url":"git://github.com/material-components/material-components-web-react.git","ssh_url":"git@github.com:material-components/material-components-web-react.git","clone_url":"https://github.com/material-components/material-components-web-react.git","svn_url":"https://github.com/material-components/material-components-web-react","homepage":"","size":1918,"stargazers_count":490,"watchers_count":490,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":27,"watchers":490,"default_branch":"master"}},"base":{"label":"material-components:master","ref":"master","sha":"8761ba9e1db9d342de91710d04b0abc440cdf9ba","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":124129430,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMjk0MzA=","name":"material-components-web-react","full_name":"material-components/material-components-web-react","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web-react","description":"Material Components for React (MDC React)","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web-react","forks_url":"https://api.github.com/repos/material-components/material-components-web-react/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web-react/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web-react/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web-react/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web-react/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web-react/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web-react/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web-react/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web-react/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web-react/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web-react/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web-react/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web-react/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web-react/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web-react/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web-react/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web-react/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web-react/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web-react/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web-react/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web-react/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web-react/deployments","created_at":"2018-03-06T19:42:24Z","updated_at":"2018-07-20T20:55:54Z","pushed_at":"2018-07-20T23:16:59Z","git_url":"git://github.com/material-components/material-components-web-react.git","ssh_url":"git@github.com:material-components/material-components-web-react.git","clone_url":"https://github.com/material-components/material-components-web-react.git","svn_url":"https://github.com/material-components/material-components-web-react","homepage":"","size":1918,"stargazers_count":490,"watchers_count":490,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":27,"watchers":490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159"},"html":{"href":"https://github.com/material-components/material-components-web-react/pull/159"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web-react/issues/159"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web-react/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web-react/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web-react/statuses/cc863b377e01894edacd93602586c7190f350a5d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"moog16"}}