{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/stack-docker/issues/39","repository_url":"https://api.github.com/repos/elastic/stack-docker","labels_url":"https://api.github.com/repos/elastic/stack-docker/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/elastic/stack-docker/issues/39/comments","events_url":"https://api.github.com/repos/elastic/stack-docker/issues/39/events","html_url":"https://github.com/elastic/stack-docker/pull/39","id":321254391,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2Njg2MTMw","number":39,"title":"Don't Use PW in ENV vars and default SSL on","user":{"login":"fxdgear","id":146550,"node_id":"MDQ6VXNlcjE0NjU1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/146550?v=4","gravatar_id":"","url":"https://api.github.com/users/fxdgear","html_url":"https://github.com/fxdgear","followers_url":"https://api.github.com/users/fxdgear/followers","following_url":"https://api.github.com/users/fxdgear/following{/other_user}","gists_url":"https://api.github.com/users/fxdgear/gists{/gist_id}","starred_url":"https://api.github.com/users/fxdgear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxdgear/subscriptions","organizations_url":"https://api.github.com/users/fxdgear/orgs","repos_url":"https://api.github.com/users/fxdgear/repos","events_url":"https://api.github.com/users/fxdgear/events{/privacy}","received_events_url":"https://api.github.com/users/fxdgear/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-05-08T16:18:25Z","updated_at":"2018-07-11T22:33:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/elastic/stack-docker/pulls/39","html_url":"https://github.com/elastic/stack-docker/pull/39","diff_url":"https://github.com/elastic/stack-docker/pull/39.diff","patch_url":"https://github.com/elastic/stack-docker/pull/39.patch"},"body":"New Description to account for changes in direction during the life of this PR and feedback received. \r\n\r\n1. Don't use ENV vars to specify passwords for running containers \r\n2. Setup script and yml file will \r\n  * generate an `ELASTIC_PASSWORD` if one is not provided by the user at script execution time.\r\n  * generate certs for security\r\n  * generate keystores to store passwords securely \r\n3. Use docker secrets (aka a volume mount in compose) to securely include the sensitive info (keystores, certs, etc) in containers at container run time. \r\n4. Each configuration file is now included in the `config` directory and no longer are configs managed via env vars. \r\n  * this makes it easier to see what the configs are\r\n  * make changes to them for personal use or experimentation\r\n  * configs pull sensitive information from keystores previously generated.\r\n5. Security is enabled by default and communication between services is done over ssl/tls.\r\n  * with the exception of kibana. Kibana runs on port 5601 without ssl enabled. This is to avoid the hoops of navigating to a website with an untrusted (self signed) cert. But communication between Kibana and Elasticsearch are secured and use SSL. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/stack-docker/issues/comments/404331359","html_url":"https://github.com/elastic/stack-docker/pull/39#issuecomment-404331359","issue_url":"https://api.github.com/repos/elastic/stack-docker/issues/39","id":404331359,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDMzMTM1OQ==","user":{"login":"fxdgear","id":146550,"node_id":"MDQ6VXNlcjE0NjU1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/146550?v=4","gravatar_id":"","url":"https://api.github.com/users/fxdgear","html_url":"https://github.com/fxdgear","followers_url":"https://api.github.com/users/fxdgear/followers","following_url":"https://api.github.com/users/fxdgear/following{/other_user}","gists_url":"https://api.github.com/users/fxdgear/gists{/gist_id}","starred_url":"https://api.github.com/users/fxdgear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxdgear/subscriptions","organizations_url":"https://api.github.com/users/fxdgear/orgs","repos_url":"https://api.github.com/users/fxdgear/repos","events_url":"https://api.github.com/users/fxdgear/events{/privacy}","received_events_url":"https://api.github.com/users/fxdgear/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T22:33:05Z","updated_at":"2018-07-11T22:33:05Z","author_association":"NONE","body":"@jordansissel if you have `make` installed you can run a `make clean` which will solve this as well. BUT unfortuanly make isn't installed by default on windows :( \r\n\r\n\r\nThank you so much for all your help on windows testing!"}}
{"actor":{"display_login":"fxdgear"}}