{"action":"created","comment":{"url":"https://api.github.com/repos/redox-os/relibc/pulls/comments/178421680","pull_request_review_id":108482621,"id":178421680,"diff_hunk":"@@ -0,0 +1,41 @@\n+use constants::*;\n+use platform::types::*;\n+\n+// compute year, month, day & day of year\n+// for description of this algorithm see\n+// http://howardhinnant.github.io/date_algorithms.html#civil_from_days\n+#[inline(always)]\n+pub(crate) fn civil_from_days(days: c_long) -> (c_int, c_int, c_int, c_int) {\n+    let (era, year): (c_int, c_int);\n+    let (erayear, mut yearday, mut month, day): (c_int, c_int, c_int, c_int);\n+    let eraday: c_ulong;\n+\n+    era = (match days >= 0 {","path":"src/time/src/helpers.rs","position":13,"original_position":13,"commit_id":"d93aed358bd3367e4c9afc42e61b5c46b28232d3","original_commit_id":"d93aed358bd3367e4c9afc42e61b5c46b28232d3","user":{"login":"xTibor","id":1627292,"avatar_url":"https://avatars2.githubusercontent.com/u/1627292?v=4","gravatar_id":"","url":"https://api.github.com/users/xTibor","html_url":"https://github.com/xTibor","followers_url":"https://api.github.com/users/xTibor/followers","following_url":"https://api.github.com/users/xTibor/following{/other_user}","gists_url":"https://api.github.com/users/xTibor/gists{/gist_id}","starred_url":"https://api.github.com/users/xTibor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xTibor/subscriptions","organizations_url":"https://api.github.com/users/xTibor/orgs","repos_url":"https://api.github.com/users/xTibor/repos","events_url":"https://api.github.com/users/xTibor/events{/privacy}","received_events_url":"https://api.github.com/users/xTibor/received_events","type":"User","site_admin":false},"body":"Instead of these `match true/false` statements `if else` statements would look slightly better. Clippy also [warns about this](https://rust-lang-nursery.github.io/rust-clippy/v0.0.190/index.html#match_bool).","created_at":"2018-03-31T03:08:12Z","updated_at":"2018-03-31T03:08:12Z","html_url":"https://github.com/redox-os/relibc/pull/112#discussion_r178421680","pull_request_url":"https://api.github.com/repos/redox-os/relibc/pulls/112","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/comments/178421680"},"html":{"href":"https://github.com/redox-os/relibc/pull/112#discussion_r178421680"},"pull_request":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/redox-os/relibc/pulls/112","id":178564089,"html_url":"https://github.com/redox-os/relibc/pull/112","diff_url":"https://github.com/redox-os/relibc/pull/112.diff","patch_url":"https://github.com/redox-os/relibc/pull/112.patch","issue_url":"https://api.github.com/repos/redox-os/relibc/issues/112","number":112,"state":"open","locked":false,"title":"add gmtime and difftime","user":{"login":"jeizsm","id":1622882,"avatar_url":"https://avatars1.githubusercontent.com/u/1622882?v=4","gravatar_id":"","url":"https://api.github.com/users/jeizsm","html_url":"https://github.com/jeizsm","followers_url":"https://api.github.com/users/jeizsm/followers","following_url":"https://api.github.com/users/jeizsm/following{/other_user}","gists_url":"https://api.github.com/users/jeizsm/gists{/gist_id}","starred_url":"https://api.github.com/users/jeizsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeizsm/subscriptions","organizations_url":"https://api.github.com/users/jeizsm/orgs","repos_url":"https://api.github.com/users/jeizsm/repos","events_url":"https://api.github.com/users/jeizsm/events{/privacy}","received_events_url":"https://api.github.com/users/jeizsm/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-30T13:51:44Z","updated_at":"2018-03-31T03:08:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96bb132a2f44d0cb96c1242b40ceaef90a81ea9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redox-os/relibc/pulls/112/commits","review_comments_url":"https://api.github.com/repos/redox-os/relibc/pulls/112/comments","review_comment_url":"https://api.github.com/repos/redox-os/relibc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redox-os/relibc/issues/112/comments","statuses_url":"https://api.github.com/repos/redox-os/relibc/statuses/d93aed358bd3367e4c9afc42e61b5c46b28232d3","head":{"label":"jeizsm:master","ref":"master","sha":"d93aed358bd3367e4c9afc42e61b5c46b28232d3","user":{"login":"jeizsm","id":1622882,"avatar_url":"https://avatars1.githubusercontent.com/u/1622882?v=4","gravatar_id":"","url":"https://api.github.com/users/jeizsm","html_url":"https://github.com/jeizsm","followers_url":"https://api.github.com/users/jeizsm/followers","following_url":"https://api.github.com/users/jeizsm/following{/other_user}","gists_url":"https://api.github.com/users/jeizsm/gists{/gist_id}","starred_url":"https://api.github.com/users/jeizsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeizsm/subscriptions","organizations_url":"https://api.github.com/users/jeizsm/orgs","repos_url":"https://api.github.com/users/jeizsm/repos","events_url":"https://api.github.com/users/jeizsm/events{/privacy}","received_events_url":"https://api.github.com/users/jeizsm/received_events","type":"User","site_admin":false},"repo":{"id":125708854,"name":"relibc","full_name":"jeizsm/relibc","owner":{"login":"jeizsm","id":1622882,"avatar_url":"https://avatars1.githubusercontent.com/u/1622882?v=4","gravatar_id":"","url":"https://api.github.com/users/jeizsm","html_url":"https://github.com/jeizsm","followers_url":"https://api.github.com/users/jeizsm/followers","following_url":"https://api.github.com/users/jeizsm/following{/other_user}","gists_url":"https://api.github.com/users/jeizsm/gists{/gist_id}","starred_url":"https://api.github.com/users/jeizsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeizsm/subscriptions","organizations_url":"https://api.github.com/users/jeizsm/orgs","repos_url":"https://api.github.com/users/jeizsm/repos","events_url":"https://api.github.com/users/jeizsm/events{/privacy}","received_events_url":"https://api.github.com/users/jeizsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeizsm/relibc","description":"C Library in Rust for Redox and Linux (WIP)","fork":true,"url":"https://api.github.com/repos/jeizsm/relibc","forks_url":"https://api.github.com/repos/jeizsm/relibc/forks","keys_url":"https://api.github.com/repos/jeizsm/relibc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeizsm/relibc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeizsm/relibc/teams","hooks_url":"https://api.github.com/repos/jeizsm/relibc/hooks","issue_events_url":"https://api.github.com/repos/jeizsm/relibc/issues/events{/number}","events_url":"https://api.github.com/repos/jeizsm/relibc/events","assignees_url":"https://api.github.com/repos/jeizsm/relibc/assignees{/user}","branches_url":"https://api.github.com/repos/jeizsm/relibc/branches{/branch}","tags_url":"https://api.github.com/repos/jeizsm/relibc/tags","blobs_url":"https://api.github.com/repos/jeizsm/relibc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeizsm/relibc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeizsm/relibc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeizsm/relibc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeizsm/relibc/statuses/{sha}","languages_url":"https://api.github.com/repos/jeizsm/relibc/languages","stargazers_url":"https://api.github.com/repos/jeizsm/relibc/stargazers","contributors_url":"https://api.github.com/repos/jeizsm/relibc/contributors","subscribers_url":"https://api.github.com/repos/jeizsm/relibc/subscribers","subscription_url":"https://api.github.com/repos/jeizsm/relibc/subscription","commits_url":"https://api.github.com/repos/jeizsm/relibc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeizsm/relibc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeizsm/relibc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeizsm/relibc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeizsm/relibc/contents/{+path}","compare_url":"https://api.github.com/repos/jeizsm/relibc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeizsm/relibc/merges","archive_url":"https://api.github.com/repos/jeizsm/relibc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeizsm/relibc/downloads","issues_url":"https://api.github.com/repos/jeizsm/relibc/issues{/number}","pulls_url":"https://api.github.com/repos/jeizsm/relibc/pulls{/number}","milestones_url":"https://api.github.com/repos/jeizsm/relibc/milestones{/number}","notifications_url":"https://api.github.com/repos/jeizsm/relibc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeizsm/relibc/labels{/name}","releases_url":"https://api.github.com/repos/jeizsm/relibc/releases{/id}","deployments_url":"https://api.github.com/repos/jeizsm/relibc/deployments","created_at":"2018-03-18T09:16:17Z","updated_at":"2018-03-30T14:46:57Z","pushed_at":"2018-03-30T14:46:56Z","git_url":"git://github.com/jeizsm/relibc.git","ssh_url":"git@github.com:jeizsm/relibc.git","clone_url":"https://github.com/jeizsm/relibc.git","svn_url":"https://github.com/jeizsm/relibc","homepage":"","size":952,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redox-os:master","ref":"master","sha":"dabd8dc6a2348052c3dd4f82e0862a3bef93ca6f","user":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars3.githubusercontent.com/u/14909902?v=4","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"repo":{"id":123522329,"name":"relibc","full_name":"redox-os/relibc","owner":{"login":"redox-os","id":14909902,"avatar_url":"https://avatars3.githubusercontent.com/u/14909902?v=4","gravatar_id":"","url":"https://api.github.com/users/redox-os","html_url":"https://github.com/redox-os","followers_url":"https://api.github.com/users/redox-os/followers","following_url":"https://api.github.com/users/redox-os/following{/other_user}","gists_url":"https://api.github.com/users/redox-os/gists{/gist_id}","starred_url":"https://api.github.com/users/redox-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redox-os/subscriptions","organizations_url":"https://api.github.com/users/redox-os/orgs","repos_url":"https://api.github.com/users/redox-os/repos","events_url":"https://api.github.com/users/redox-os/events{/privacy}","received_events_url":"https://api.github.com/users/redox-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redox-os/relibc","description":"C Library in Rust for Redox and Linux (WIP)","fork":false,"url":"https://api.github.com/repos/redox-os/relibc","forks_url":"https://api.github.com/repos/redox-os/relibc/forks","keys_url":"https://api.github.com/repos/redox-os/relibc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redox-os/relibc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redox-os/relibc/teams","hooks_url":"https://api.github.com/repos/redox-os/relibc/hooks","issue_events_url":"https://api.github.com/repos/redox-os/relibc/issues/events{/number}","events_url":"https://api.github.com/repos/redox-os/relibc/events","assignees_url":"https://api.github.com/repos/redox-os/relibc/assignees{/user}","branches_url":"https://api.github.com/repos/redox-os/relibc/branches{/branch}","tags_url":"https://api.github.com/repos/redox-os/relibc/tags","blobs_url":"https://api.github.com/repos/redox-os/relibc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redox-os/relibc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redox-os/relibc/git/refs{/sha}","trees_url":"https://api.github.com/repos/redox-os/relibc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redox-os/relibc/statuses/{sha}","languages_url":"https://api.github.com/repos/redox-os/relibc/languages","stargazers_url":"https://api.github.com/repos/redox-os/relibc/stargazers","contributors_url":"https://api.github.com/repos/redox-os/relibc/contributors","subscribers_url":"https://api.github.com/repos/redox-os/relibc/subscribers","subscription_url":"https://api.github.com/repos/redox-os/relibc/subscription","commits_url":"https://api.github.com/repos/redox-os/relibc/commits{/sha}","git_commits_url":"https://api.github.com/repos/redox-os/relibc/git/commits{/sha}","comments_url":"https://api.github.com/repos/redox-os/relibc/comments{/number}","issue_comment_url":"https://api.github.com/repos/redox-os/relibc/issues/comments{/number}","contents_url":"https://api.github.com/repos/redox-os/relibc/contents/{+path}","compare_url":"https://api.github.com/repos/redox-os/relibc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redox-os/relibc/merges","archive_url":"https://api.github.com/repos/redox-os/relibc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redox-os/relibc/downloads","issues_url":"https://api.github.com/repos/redox-os/relibc/issues{/number}","pulls_url":"https://api.github.com/repos/redox-os/relibc/pulls{/number}","milestones_url":"https://api.github.com/repos/redox-os/relibc/milestones{/number}","notifications_url":"https://api.github.com/repos/redox-os/relibc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redox-os/relibc/labels{/name}","releases_url":"https://api.github.com/repos/redox-os/relibc/releases{/id}","deployments_url":"https://api.github.com/repos/redox-os/relibc/deployments","created_at":"2018-03-02T02:58:07Z","updated_at":"2018-03-30T11:52:14Z","pushed_at":"2018-03-30T14:46:57Z","git_url":"git://github.com/redox-os/relibc.git","ssh_url":"git@github.com:redox-os/relibc.git","clone_url":"https://github.com/redox-os/relibc.git","svn_url":"https://github.com/redox-os/relibc","homepage":"","size":972,"stargazers_count":465,"watchers_count":465,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":26,"open_issues":28,"watchers":465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/112"},"html":{"href":"https://github.com/redox-os/relibc/pull/112"},"issue":{"href":"https://api.github.com/repos/redox-os/relibc/issues/112"},"comments":{"href":"https://api.github.com/repos/redox-os/relibc/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redox-os/relibc/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/redox-os/relibc/statuses/d93aed358bd3367e4c9afc42e61b5c46b28232d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xTibor"}}