{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/217689162","pull_request_review_id":155464599,"id":217689162,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzY4OTE2Mg==","diff_hunk":"@@ -565,6 +568,11 @@ def process(self, cube, weights=None):\n                                                     arr_percent=percentiles,\n                                                     arr_weights=weights,\n                                                     perc_dim=perc_dim)\n+                    # Ensure collapsed coordinates do not promote themselves\n+                    # to float64.\n+                    for coord in cube_new.coords():\n+                        if coord.points.dtype == np.float64:","path":"lib/improver/blending/weighted_blend.py","position":55,"original_position":55,"commit_id":"949fb21fb9903e8f47a06d75021d3c1944d7d3f6","original_commit_id":"949fb21fb9903e8f47a06d75021d3c1944d7d3f6","user":{"login":"LaurenceBeard","id":14344798,"node_id":"MDQ6VXNlcjE0MzQ0Nzk4","avatar_url":"https://avatars3.githubusercontent.com/u/14344798?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurenceBeard","html_url":"https://github.com/LaurenceBeard","followers_url":"https://api.github.com/users/LaurenceBeard/followers","following_url":"https://api.github.com/users/LaurenceBeard/following{/other_user}","gists_url":"https://api.github.com/users/LaurenceBeard/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenceBeard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenceBeard/subscriptions","organizations_url":"https://api.github.com/users/LaurenceBeard/orgs","repos_url":"https://api.github.com/users/LaurenceBeard/repos","events_url":"https://api.github.com/users/LaurenceBeard/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenceBeard/received_events","type":"User","site_admin":false},"body":"^ Talking about the if statement. You note that in some of the cases (not this) it could be an int.","created_at":"2018-09-14T12:02:19Z","updated_at":"2018-09-14T12:02:20Z","html_url":"https://github.com/metoppv/improver/pull/662#discussion_r217689162","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/662","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/217689162"},"html":{"href":"https://github.com/metoppv/improver/pull/662#discussion_r217689162"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/662"}},"in_reply_to_id":216966877},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/662","id":212740462,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzQwNDYy","html_url":"https://github.com/metoppv/improver/pull/662","diff_url":"https://github.com/metoppv/improver/pull/662.diff","patch_url":"https://github.com/metoppv/improver/pull/662.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/662","number":662,"state":"open","locked":false,"title":"Prevent float64","user":{"login":"benfitzpatrick","id":1138333,"node_id":"MDQ6VXNlcjExMzgzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"body":"Addresses IMPRO-778: \"Change plugins and CLIs to prevent precision escalation to float64\"\r\n\r\nThis change makes sure that IMPROVER command line utilities do not have float64 data or coordinate data output when their input is float32. AT data has been updated to be float32, and in a few cases small differences (e.g. on the level of 10^-5 K) have been introduced. Weather symbols and topographic neighbourhooding acceptance tests had a grid square or two difference where a value fell exactly on a threshold and behaves differently (correctly) under float32 in this PR.\r\n\r\nI used https://gist.github.com/benfitzpatrick/bc6d5c8831309c006085b9a60be75e64 to convert the AT data to float32.\r\n\r\nA couple of oddities:\r\n * 2 unit tests in lib/improver/tests/ensemble_calibration/ensemble_calibration/test_EnsembleCalibration.py changes answers quite significantly with float32 test data, which is a little worrying, so I've left the test alone\r\n * lib/improver/ensemble_calibration/ensemble_calibration/test_ContinuousRankedProbabilityScoreMinimisers.py: 3 normal mean predictor unit tests change numbers more than I would have expected in the first two array elements of each\r\n\r\nTesting:\r\n - [ ] Ran tests and they passed OK\r\n\r\n\r\n","created_at":"2018-09-03T12:55:19Z","updated_at":"2018-09-14T12:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7279897105c95d07359479be5e3d8bbf5d3dc81d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gavinevans","id":26933341,"node_id":"MDQ6VXNlcjI2OTMzMzQx","avatar_url":"https://avatars3.githubusercontent.com/u/26933341?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinevans","html_url":"https://github.com/gavinevans","followers_url":"https://api.github.com/users/gavinevans/followers","following_url":"https://api.github.com/users/gavinevans/following{/other_user}","gists_url":"https://api.github.com/users/gavinevans/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinevans/subscriptions","organizations_url":"https://api.github.com/users/gavinevans/orgs","repos_url":"https://api.github.com/users/gavinevans/repos","events_url":"https://api.github.com/users/gavinevans/events{/privacy}","received_events_url":"https://api.github.com/users/gavinevans/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/662/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/662/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/662/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/949fb21fb9903e8f47a06d75021d3c1944d7d3f6","head":{"label":"benfitzpatrick:prevent_float64","ref":"prevent_float64","sha":"949fb21fb9903e8f47a06d75021d3c1944d7d3f6","user":{"login":"benfitzpatrick","id":1138333,"node_id":"MDQ6VXNlcjExMzgzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"repo":{"id":85334941,"node_id":"MDEwOlJlcG9zaXRvcnk4NTMzNDk0MQ==","name":"improver","full_name":"benfitzpatrick/improver","owner":{"login":"benfitzpatrick","id":1138333,"node_id":"MDQ6VXNlcjExMzgzMzM=","avatar_url":"https://avatars2.githubusercontent.com/u/1138333?v=4","gravatar_id":"","url":"https://api.github.com/users/benfitzpatrick","html_url":"https://github.com/benfitzpatrick","followers_url":"https://api.github.com/users/benfitzpatrick/followers","following_url":"https://api.github.com/users/benfitzpatrick/following{/other_user}","gists_url":"https://api.github.com/users/benfitzpatrick/gists{/gist_id}","starred_url":"https://api.github.com/users/benfitzpatrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfitzpatrick/subscriptions","organizations_url":"https://api.github.com/users/benfitzpatrick/orgs","repos_url":"https://api.github.com/users/benfitzpatrick/repos","events_url":"https://api.github.com/users/benfitzpatrick/events{/privacy}","received_events_url":"https://api.github.com/users/benfitzpatrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfitzpatrick/improver","description":"IMPROVER","fork":true,"url":"https://api.github.com/repos/benfitzpatrick/improver","forks_url":"https://api.github.com/repos/benfitzpatrick/improver/forks","keys_url":"https://api.github.com/repos/benfitzpatrick/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfitzpatrick/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfitzpatrick/improver/teams","hooks_url":"https://api.github.com/repos/benfitzpatrick/improver/hooks","issue_events_url":"https://api.github.com/repos/benfitzpatrick/improver/issues/events{/number}","events_url":"https://api.github.com/repos/benfitzpatrick/improver/events","assignees_url":"https://api.github.com/repos/benfitzpatrick/improver/assignees{/user}","branches_url":"https://api.github.com/repos/benfitzpatrick/improver/branches{/branch}","tags_url":"https://api.github.com/repos/benfitzpatrick/improver/tags","blobs_url":"https://api.github.com/repos/benfitzpatrick/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfitzpatrick/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfitzpatrick/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfitzpatrick/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfitzpatrick/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/benfitzpatrick/improver/languages","stargazers_url":"https://api.github.com/repos/benfitzpatrick/improver/stargazers","contributors_url":"https://api.github.com/repos/benfitzpatrick/improver/contributors","subscribers_url":"https://api.github.com/repos/benfitzpatrick/improver/subscribers","subscription_url":"https://api.github.com/repos/benfitzpatrick/improver/subscription","commits_url":"https://api.github.com/repos/benfitzpatrick/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfitzpatrick/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfitzpatrick/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfitzpatrick/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfitzpatrick/improver/contents/{+path}","compare_url":"https://api.github.com/repos/benfitzpatrick/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfitzpatrick/improver/merges","archive_url":"https://api.github.com/repos/benfitzpatrick/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfitzpatrick/improver/downloads","issues_url":"https://api.github.com/repos/benfitzpatrick/improver/issues{/number}","pulls_url":"https://api.github.com/repos/benfitzpatrick/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/benfitzpatrick/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/benfitzpatrick/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfitzpatrick/improver/labels{/name}","releases_url":"https://api.github.com/repos/benfitzpatrick/improver/releases{/id}","deployments_url":"https://api.github.com/repos/benfitzpatrick/improver/deployments","created_at":"2017-03-17T16:53:45Z","updated_at":"2018-08-08T17:09:25Z","pushed_at":"2018-09-14T10:16:12Z","git_url":"git://github.com/benfitzpatrick/improver.git","ssh_url":"git@github.com:benfitzpatrick/improver.git","clone_url":"https://github.com/benfitzpatrick/improver.git","svn_url":"https://github.com/benfitzpatrick/improver","homepage":null,"size":3800,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"c687c60ee5c8c94fda428ca50a677f7adc6b34b3","user":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"node_id":"MDEwOlJlcG9zaXRvcnk4NTMzNDc2MQ==","name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-09-13T16:00:45Z","pushed_at":"2018-09-14T10:26:46Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":3733,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":109,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/662"},"html":{"href":"https://github.com/metoppv/improver/pull/662"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/662"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/949fb21fb9903e8f47a06d75021d3c1944d7d3f6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LaurenceBeard"}}