{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/vert.x/issues/2484","repository_url":"https://api.github.com/repos/eclipse/vert.x","labels_url":"https://api.github.com/repos/eclipse/vert.x/issues/2484/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/vert.x/issues/2484/comments","events_url":"https://api.github.com/repos/eclipse/vert.x/issues/2484/events","html_url":"https://github.com/eclipse/vert.x/issues/2484","id":329161408,"node_id":"MDU6SXNzdWUzMjkxNjE0MDg=","number":2484,"title":"Internal references to local Locks taken using SharedData.getLock() are not cleaned up","user":{"login":"dano","id":38807,"node_id":"MDQ6VXNlcjM4ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/38807?v=4","gravatar_id":"","url":"https://api.github.com/users/dano","html_url":"https://github.com/dano","followers_url":"https://api.github.com/users/dano/followers","following_url":"https://api.github.com/users/dano/following{/other_user}","gists_url":"https://api.github.com/users/dano/gists{/gist_id}","starred_url":"https://api.github.com/users/dano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dano/subscriptions","organizations_url":"https://api.github.com/users/dano/orgs","repos_url":"https://api.github.com/users/dano/repos","events_url":"https://api.github.com/users/dano/events{/privacy}","received_events_url":"https://api.github.com/users/dano/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"tsegismont","id":1500598,"node_id":"MDQ6VXNlcjE1MDA1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1500598?v=4","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false},"assignees":[{"login":"tsegismont","id":1500598,"node_id":"MDQ6VXNlcjE1MDA1OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1500598?v=4","gravatar_id":"","url":"https://api.github.com/users/tsegismont","html_url":"https://github.com/tsegismont","followers_url":"https://api.github.com/users/tsegismont/followers","following_url":"https://api.github.com/users/tsegismont/following{/other_user}","gists_url":"https://api.github.com/users/tsegismont/gists{/gist_id}","starred_url":"https://api.github.com/users/tsegismont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsegismont/subscriptions","organizations_url":"https://api.github.com/users/tsegismont/orgs","repos_url":"https://api.github.com/users/tsegismont/repos","events_url":"https://api.github.com/users/tsegismont/events{/privacy}","received_events_url":"https://api.github.com/users/tsegismont/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/eclipse/vert.x/milestones/48","html_url":"https://github.com/eclipse/vert.x/milestone/48","labels_url":"https://api.github.com/repos/eclipse/vert.x/milestones/48/labels","id":3101997,"node_id":"MDk6TWlsZXN0b25lMzEwMTk5Nw==","number":48,"title":"3.6.0","description":null,"creator":{"login":"vietj","id":225674,"node_id":"MDQ6VXNlcjIyNTY3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/225674?v=4","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":51,"state":"open","created_at":"2018-02-09T07:15:30Z","updated_at":"2018-06-20T12:55:56Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-06-04T18:11:22Z","updated_at":"2018-06-20T14:22:42Z","closed_at":"2018-06-20T12:55:56Z","author_association":"CONTRIBUTOR","body":"Every time a unique lock name is taken via `SharedData.getLock(...)`, it gets added to a Map inside of `SharedDataImpl`. Currently, entries added to this Map are never removed, even if all references to the lock have been released, and there are no pending waiters. This means the Map can grow infinitely if an application takes locks using generated names, rather than hard-coded ones. To avoid this, entries could be removed from the internal map at the point the lock is released, as long as there are no pending waiters."},"comment":{"url":"https://api.github.com/repos/eclipse/vert.x/issues/comments/398767762","html_url":"https://github.com/eclipse/vert.x/issues/2484#issuecomment-398767762","issue_url":"https://api.github.com/repos/eclipse/vert.x/issues/2484","id":398767762,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODc2Nzc2Mg==","user":{"login":"dano","id":38807,"node_id":"MDQ6VXNlcjM4ODA3","avatar_url":"https://avatars1.githubusercontent.com/u/38807?v=4","gravatar_id":"","url":"https://api.github.com/users/dano","html_url":"https://github.com/dano","followers_url":"https://api.github.com/users/dano/followers","following_url":"https://api.github.com/users/dano/following{/other_user}","gists_url":"https://api.github.com/users/dano/gists{/gist_id}","starred_url":"https://api.github.com/users/dano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dano/subscriptions","organizations_url":"https://api.github.com/users/dano/orgs","repos_url":"https://api.github.com/users/dano/repos","events_url":"https://api.github.com/users/dano/events{/privacy}","received_events_url":"https://api.github.com/users/dano/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T14:22:41Z","updated_at":"2018-06-20T14:22:41Z","author_association":"CONTRIBUTOR","body":"@vietj @tsegismont Thanks for the fix! Will this be backported to 3.5.3?"}}
{"actor":{"display_login":"dano"}}