{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/213608798","pull_request_review_id":150478427,"id":213608798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYwODc5OA==","diff_hunk":"@@ -22,10 +22,10 @@ SchedulerIAMLoginMethod {\n \troleAttributeName=\"role\"\n \troleSeparator=\",\"\n \tssoTicketMarker=\"action\"\n-\tjsonWebTokenSigned=\"false\"\n-\tjsonWebTokenEncrypted=\"false\"\n-\tjsonWebTokenSignatureKey=\"\"\n-\tjsonWebTokenEncryptionKey=\"\";\n+\tjsonWebTokenSigned=\"true\"\n+\tjsonWebTokenEncrypted=\"true\"\n+\tjsonWebTokenSignatureKey=\"_pyp8dL5rHqLXiS6aBzvbJ_LZdBN3-oQqbJVbC5mveTdsZ1r3WM_j3SUENB65XS7EAu7Kop3rfQx81GS_mu1Yw\"","path":"common/common-client/src/main/java/org/ow2/proactive/authentication/jaas.config","position":10,"original_position":10,"commit_id":"56a511f1b43a28b7ec755f68360f095d134076f4","original_commit_id":"56a511f1b43a28b7ec755f68360f095d134076f4","user":{"login":"nebilbenmabrouk","id":25662619,"node_id":"MDQ6VXNlcjI1NjYyNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/25662619?v=4","gravatar_id":"","url":"https://api.github.com/users/nebilbenmabrouk","html_url":"https://github.com/nebilbenmabrouk","followers_url":"https://api.github.com/users/nebilbenmabrouk/followers","following_url":"https://api.github.com/users/nebilbenmabrouk/following{/other_user}","gists_url":"https://api.github.com/users/nebilbenmabrouk/gists{/gist_id}","starred_url":"https://api.github.com/users/nebilbenmabrouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebilbenmabrouk/subscriptions","organizations_url":"https://api.github.com/users/nebilbenmabrouk/orgs","repos_url":"https://api.github.com/users/nebilbenmabrouk/repos","events_url":"https://api.github.com/users/nebilbenmabrouk/events{/privacy}","received_events_url":"https://api.github.com/users/nebilbenmabrouk/received_events","type":"User","site_admin":false},"body":"Yes, PA is considered as a client of IAM (and it uses JAAS for authentication), so the configuration of PA should be written in jaas.config ","created_at":"2018-08-29T09:34:23Z","updated_at":"2018-08-29T09:34:23Z","html_url":"https://github.com/ow2-proactive/scheduling/pull/3305#discussion_r213608798","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/213608798"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/3305#discussion_r213608798"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305"}},"in_reply_to_id":213593330},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305","id":211395641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzk1NjQx","html_url":"https://github.com/ow2-proactive/scheduling/pull/3305","diff_url":"https://github.com/ow2-proactive/scheduling/pull/3305.diff","patch_url":"https://github.com/ow2-proactive/scheduling/pull/3305.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3305","number":3305,"state":"open","locked":false,"title":"IAM microservice:: Support signed and encrypted JWT","user":{"login":"nebilbenmabrouk","id":25662619,"node_id":"MDQ6VXNlcjI1NjYyNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/25662619?v=4","gravatar_id":"","url":"https://api.github.com/users/nebilbenmabrouk","html_url":"https://github.com/nebilbenmabrouk","followers_url":"https://api.github.com/users/nebilbenmabrouk/followers","following_url":"https://api.github.com/users/nebilbenmabrouk/following{/other_user}","gists_url":"https://api.github.com/users/nebilbenmabrouk/gists{/gist_id}","starred_url":"https://api.github.com/users/nebilbenmabrouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebilbenmabrouk/subscriptions","organizations_url":"https://api.github.com/users/nebilbenmabrouk/orgs","repos_url":"https://api.github.com/users/nebilbenmabrouk/repos","events_url":"https://api.github.com/users/nebilbenmabrouk/events{/privacy}","received_events_url":"https://api.github.com/users/nebilbenmabrouk/received_events","type":"User","site_admin":false},"body":"JAAS authentication using signed and encrypted JWT is henceforth supported. \r\n- The common::common-client module is changed. The classes JWTUtils and JWTValidator are modified to deal with signed and encrypted JWT.\r\n- config/iam/application-proactive.properties is changed to add JWT signature and encryption configuration (so IAM issues signed and encrypted JWTs)\r\n- config/authentication/jaas.config is modified to consider JWT signature and encryption configuration (so JAAS can verify and decode signed and encrypted JWTs)\r\n","created_at":"2018-08-28T11:53:55Z","updated_at":"2018-08-29T09:34:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d82343f017a5f010a883a94f2278d8dc26566ab4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3305/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/56a511f1b43a28b7ec755f68360f095d134076f4","head":{"label":"nebilbenmabrouk:integrate-iam","ref":"integrate-iam","sha":"56a511f1b43a28b7ec755f68360f095d134076f4","user":{"login":"nebilbenmabrouk","id":25662619,"node_id":"MDQ6VXNlcjI1NjYyNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/25662619?v=4","gravatar_id":"","url":"https://api.github.com/users/nebilbenmabrouk","html_url":"https://github.com/nebilbenmabrouk","followers_url":"https://api.github.com/users/nebilbenmabrouk/followers","following_url":"https://api.github.com/users/nebilbenmabrouk/following{/other_user}","gists_url":"https://api.github.com/users/nebilbenmabrouk/gists{/gist_id}","starred_url":"https://api.github.com/users/nebilbenmabrouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebilbenmabrouk/subscriptions","organizations_url":"https://api.github.com/users/nebilbenmabrouk/orgs","repos_url":"https://api.github.com/users/nebilbenmabrouk/repos","events_url":"https://api.github.com/users/nebilbenmabrouk/events{/privacy}","received_events_url":"https://api.github.com/users/nebilbenmabrouk/received_events","type":"User","site_admin":false},"repo":{"id":127267358,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcyNjczNTg=","name":"scheduling","full_name":"nebilbenmabrouk/scheduling","owner":{"login":"nebilbenmabrouk","id":25662619,"node_id":"MDQ6VXNlcjI1NjYyNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/25662619?v=4","gravatar_id":"","url":"https://api.github.com/users/nebilbenmabrouk","html_url":"https://github.com/nebilbenmabrouk","followers_url":"https://api.github.com/users/nebilbenmabrouk/followers","following_url":"https://api.github.com/users/nebilbenmabrouk/following{/other_user}","gists_url":"https://api.github.com/users/nebilbenmabrouk/gists{/gist_id}","starred_url":"https://api.github.com/users/nebilbenmabrouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebilbenmabrouk/subscriptions","organizations_url":"https://api.github.com/users/nebilbenmabrouk/orgs","repos_url":"https://api.github.com/users/nebilbenmabrouk/repos","events_url":"https://api.github.com/users/nebilbenmabrouk/events{/privacy}","received_events_url":"https://api.github.com/users/nebilbenmabrouk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nebilbenmabrouk/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":true,"url":"https://api.github.com/repos/nebilbenmabrouk/scheduling","forks_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/forks","keys_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/teams","hooks_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/hooks","issue_events_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/events","assignees_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/tags","blobs_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/languages","stargazers_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/stargazers","contributors_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/contributors","subscribers_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/subscribers","subscription_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/subscription","commits_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/merges","archive_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/downloads","issues_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/nebilbenmabrouk/scheduling/deployments","created_at":"2018-03-29T09:15:36Z","updated_at":"2018-08-28T11:35:14Z","pushed_at":"2018-08-28T11:45:33Z","git_url":"git://github.com/nebilbenmabrouk/scheduling.git","ssh_url":"git@github.com:nebilbenmabrouk/scheduling.git","clone_url":"https://github.com/nebilbenmabrouk/scheduling.git","svn_url":"https://github.com/nebilbenmabrouk/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":74234,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:enhance-security","ref":"enhance-security","sha":"3d4d4358978c32e483fbec3711229e4e7e4262e0","user":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725079,"node_id":"MDEwOlJlcG9zaXRvcnkzNTcyNTA3OQ==","name":"scheduling","full_name":"ow2-proactive/scheduling","owner":{"login":"ow2-proactive","id":11553998,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTUzOTk4","avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-08-28T14:33:56Z","pushed_at":"2018-08-29T09:32:25Z","git_url":"git://github.com/ow2-proactive/scheduling.git","ssh_url":"git@github.com:ow2-proactive/scheduling.git","clone_url":"https://github.com/ow2-proactive/scheduling.git","svn_url":"https://github.com/ow2-proactive/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":74192,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":184,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":40,"open_issues":184,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/3305"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3305"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3305/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3305/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/56a511f1b43a28b7ec755f68360f095d134076f4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nebilbenmabrouk"}}