{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/196938007","pull_request_review_id":130583435,"id":196938007,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjkzODAwNw==","diff_hunk":"@@ -0,0 +1,62 @@\n+/**\n+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+describe('amp-accordion', function() {\n+  this.timeout(10000);\n+  const extensions = ['amp-accordion'];\n+  const body = `\n+  <amp-accordion media=\"(min-width: 500px)\" id=\"media-accordion\">\n+    <section>\n+      <h1>\n+        Title\n+      </h1>\n+      <p>Bunch of awesome content</p>\n+    </section>\n+  </amp-accordion>\n+  `;\n+  describes.integration('amp-accordion', {\n+    body,\n+    extensions,\n+  }, env => {\n+\n+    let win, iframe, doc;\n+    beforeEach(() => {\n+      win = env.win;\n+      iframe = env.iframe;\n+      doc = win.document;\n+      iframe.width = 300;\n+    });\n+\n+    it('should respect the media attribute', () => {\n+      const accordion = doc.getElementById('media-accordion');\n+      expect(iframe.clientWidth).to.equal(300);\n+      expect(accordion.className).to.match(/i-amphtml-hidden-by-media-query/);\n+      iframe.width = 600;\n+      expect(iframe.clientWidth).to.equal(600);\n+      return timeout(200).then(() => {","path":"extensions/amp-accordion/0.1/test/integration/test-amp-accordion.js","position":49,"original_position":49,"commit_id":"d7c8daae0d38c2fd40f7ed5d3ef53ce3509166b4","original_commit_id":"d7c8daae0d38c2fd40f7ed5d3ef53ce3509166b4","user":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"body":"Fair point re: integration tests. If these are DOM elements you're waiting to be modified, would it help to use something like http://www.chaijs.com/plugins/chai-dom?","created_at":"2018-06-20T20:50:42Z","updated_at":"2018-06-20T20:50:43Z","html_url":"https://github.com/ampproject/amphtml/pull/16159#discussion_r196938007","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16159","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/196938007"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16159#discussion_r196938007"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16159"}},"in_reply_to_id":196870875},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/16159","id":195958832,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTU4ODMy","html_url":"https://github.com/ampproject/amphtml/pull/16159","diff_url":"https://github.com/ampproject/amphtml/pull/16159.diff","patch_url":"https://github.com/ampproject/amphtml/pull/16159.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/16159","number":16159,"state":"closed","locked":false,"title":"Add media attribute to amp-accordion's validation","user":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/ampproject/amphtml/issues/16143\r\nAllow media attribute on amp-accordion. ","created_at":"2018-06-19T21:09:30Z","updated_at":"2018-06-20T20:50:43Z","closed_at":"2018-06-20T20:11:27Z","merged_at":"2018-06-20T20:11:27Z","merge_commit_sha":"db0c96198da0e0524f4c1f168991b4fcdfb3203a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16159/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16159/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/16159/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/d7c8daae0d38c2fd40f7ed5d3ef53ce3509166b4","head":{"label":"cathyxz:bugfix/accordion-media","ref":"bugfix/accordion-media","sha":"d7c8daae0d38c2fd40f7ed5d3ef53ce3509166b4","user":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"repo":{"id":108910422,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg5MTA0MjI=","name":"amphtml","full_name":"cathyxz/amphtml","owner":{"login":"cathyxz","id":1528181,"node_id":"MDQ6VXNlcjE1MjgxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cathyxz/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/cathyxz/amphtml","forks_url":"https://api.github.com/repos/cathyxz/amphtml/forks","keys_url":"https://api.github.com/repos/cathyxz/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cathyxz/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cathyxz/amphtml/teams","hooks_url":"https://api.github.com/repos/cathyxz/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cathyxz/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cathyxz/amphtml/events","assignees_url":"https://api.github.com/repos/cathyxz/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cathyxz/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cathyxz/amphtml/tags","blobs_url":"https://api.github.com/repos/cathyxz/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cathyxz/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cathyxz/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cathyxz/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cathyxz/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cathyxz/amphtml/languages","stargazers_url":"https://api.github.com/repos/cathyxz/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cathyxz/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cathyxz/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cathyxz/amphtml/subscription","commits_url":"https://api.github.com/repos/cathyxz/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cathyxz/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cathyxz/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cathyxz/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cathyxz/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cathyxz/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cathyxz/amphtml/merges","archive_url":"https://api.github.com/repos/cathyxz/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cathyxz/amphtml/downloads","issues_url":"https://api.github.com/repos/cathyxz/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cathyxz/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cathyxz/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cathyxz/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cathyxz/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cathyxz/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cathyxz/amphtml/deployments","created_at":"2017-10-30T21:27:41Z","updated_at":"2018-06-19T21:13:42Z","pushed_at":"2018-06-20T20:32:04Z","git_url":"git://github.com/cathyxz/amphtml.git","ssh_url":"git@github.com:cathyxz/amphtml.git","clone_url":"https://github.com/cathyxz/amphtml.git","svn_url":"https://github.com/cathyxz/amphtml","homepage":"https://www.ampproject.org","size":459475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"bad7adf77a3248ed9cc5e365b82f5e75f605a476","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-06-20T20:35:45Z","pushed_at":"2018-06-20T20:42:18Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":460528,"stargazers_count":11697,"watchers_count":11697,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2454,"mirror_url":null,"archived":false,"open_issues_count":1300,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2454,"open_issues":1300,"watchers":11697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16159"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16159"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16159"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16159/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16159/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16159/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/d7c8daae0d38c2fd40f7ed5d3ef53ce3509166b4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rsimha"}}