{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/215353077","pull_request_review_id":152597666,"id":215353077,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM1MzA3Nw==","diff_hunk":"@@ -632,31 +647,12 @@ function configureFailPoint(MongoDB\\Driver\\Manager $manager, $failPoint, $mode,\n \n     $cmd = new MongoDB\\Driver\\Command($doc);\n     $result = $manager->executeCommand(\"admin\", $cmd);\n-    $arr = current($result->toArray());\n-    if (empty($arr->ok)) {\n-        var_dump($result);\n-        throw new RuntimeException(\"Failpoint failed\");\n-    }\n-    return true;\n }\n \n function failMaxTimeMS(MongoDB\\Driver\\Manager $manager) {\n     return configureFailPoint($manager, \"maxTimeAlwaysTimeOut\", array(\"times\" => 1));\n }\n \n-function getMOUri() {","path":"tests/utils/tools.php","position":143,"original_position":143,"commit_id":"4ef43d09c7b1d2285db196989c7880507885f7a4","original_commit_id":"4ef43d09c7b1d2285db196989c7880507885f7a4","user":{"login":"derickr","id":208074,"node_id":"MDQ6VXNlcjIwODA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/208074?v=4","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"body":"I have soft-deprecated \"start-servers.php\", and don't want to spend any time on this. There is already a ticket for getting rid of the Vagrant stuff: https://jira.mongodb.org/browse/PHPC-1242 — I've made a note there to remove this function too.","created_at":"2018-09-05T17:08:59Z","updated_at":"2018-09-05T17:10:25Z","html_url":"https://github.com/mongodb/mongo-php-driver/pull/913#discussion_r215353077","pull_request_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments/215353077"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/913#discussion_r215353077"},"pull_request":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913"}},"in_reply_to_id":215348830},"pull_request":{"url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913","id":209107763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTA3NzYz","html_url":"https://github.com/mongodb/mongo-php-driver/pull/913","diff_url":"https://github.com/mongodb/mongo-php-driver/pull/913.diff","patch_url":"https://github.com/mongodb/mongo-php-driver/pull/913.patch","issue_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/913","number":913,"state":"open","locked":false,"title":" PHPC-1179: Reimplement tests that start servers with Mongo Orchestration ","user":{"login":"derickr","id":208074,"node_id":"MDQ6VXNlcjIwODA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/208074?v=4","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"body":"These tests could not have worked since we moved from a Wire Protocol getMore OP to the OP_COMMAND style of calling ``getMore``. Beats me how we didn't manage to detect this.\r\n\r\nThe second commit isn't strictly necessary, but it updates the code to be able to throw a ``ConnectionException`` if getMore fails.\r\n\r\nPreviously, the ``getMore`` tests use a failPoint for the getMore OP, where the driver would then (through ``libmongoc``) throw a ``ConnectionException``.  With the shift to the command-based failPoint, ``libmongoc``/the driver now converted that to a ``ServerException``. This second commit restores that behaviour. Alternatively, we can just update the test to check for a ``ServerException`` instead.","created_at":"2018-08-17T10:28:48Z","updated_at":"2018-09-05T17:10:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d673a56aceac901444c3407bca07429474148bc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913/commits","review_comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913/comments","review_comment_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/913/comments","statuses_url":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/4ef43d09c7b1d2285db196989c7880507885f7a4","head":{"label":"derickr:PHPC-1179-mo-tests","ref":"PHPC-1179-mo-tests","sha":"4ef43d09c7b1d2285db196989c7880507885f7a4","user":{"login":"derickr","id":208074,"node_id":"MDQ6VXNlcjIwODA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/208074?v=4","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"repo":{"id":33925105,"node_id":"MDEwOlJlcG9zaXRvcnkzMzkyNTEwNQ==","name":"mongo-php-driver","full_name":"derickr/mongo-php-driver","owner":{"login":"derickr","id":208074,"node_id":"MDQ6VXNlcjIwODA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/208074?v=4","gravatar_id":"","url":"https://api.github.com/users/derickr","html_url":"https://github.com/derickr","followers_url":"https://api.github.com/users/derickr/followers","following_url":"https://api.github.com/users/derickr/following{/other_user}","gists_url":"https://api.github.com/users/derickr/gists{/gist_id}","starred_url":"https://api.github.com/users/derickr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derickr/subscriptions","organizations_url":"https://api.github.com/users/derickr/orgs","repos_url":"https://api.github.com/users/derickr/repos","events_url":"https://api.github.com/users/derickr/events{/privacy}","received_events_url":"https://api.github.com/users/derickr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derickr/mongo-php-driver","description":"MongoDB PHP driver (experimental)","fork":true,"url":"https://api.github.com/repos/derickr/mongo-php-driver","forks_url":"https://api.github.com/repos/derickr/mongo-php-driver/forks","keys_url":"https://api.github.com/repos/derickr/mongo-php-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derickr/mongo-php-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derickr/mongo-php-driver/teams","hooks_url":"https://api.github.com/repos/derickr/mongo-php-driver/hooks","issue_events_url":"https://api.github.com/repos/derickr/mongo-php-driver/issues/events{/number}","events_url":"https://api.github.com/repos/derickr/mongo-php-driver/events","assignees_url":"https://api.github.com/repos/derickr/mongo-php-driver/assignees{/user}","branches_url":"https://api.github.com/repos/derickr/mongo-php-driver/branches{/branch}","tags_url":"https://api.github.com/repos/derickr/mongo-php-driver/tags","blobs_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derickr/mongo-php-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/derickr/mongo-php-driver/languages","stargazers_url":"https://api.github.com/repos/derickr/mongo-php-driver/stargazers","contributors_url":"https://api.github.com/repos/derickr/mongo-php-driver/contributors","subscribers_url":"https://api.github.com/repos/derickr/mongo-php-driver/subscribers","subscription_url":"https://api.github.com/repos/derickr/mongo-php-driver/subscription","commits_url":"https://api.github.com/repos/derickr/mongo-php-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/derickr/mongo-php-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/derickr/mongo-php-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/derickr/mongo-php-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/derickr/mongo-php-driver/contents/{+path}","compare_url":"https://api.github.com/repos/derickr/mongo-php-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derickr/mongo-php-driver/merges","archive_url":"https://api.github.com/repos/derickr/mongo-php-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derickr/mongo-php-driver/downloads","issues_url":"https://api.github.com/repos/derickr/mongo-php-driver/issues{/number}","pulls_url":"https://api.github.com/repos/derickr/mongo-php-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/derickr/mongo-php-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/derickr/mongo-php-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derickr/mongo-php-driver/labels{/name}","releases_url":"https://api.github.com/repos/derickr/mongo-php-driver/releases{/id}","deployments_url":"https://api.github.com/repos/derickr/mongo-php-driver/deployments","created_at":"2015-04-14T10:16:35Z","updated_at":"2018-09-04T16:20:19Z","pushed_at":"2018-09-05T17:10:24Z","git_url":"git://github.com/derickr/mongo-php-driver.git","ssh_url":"git@github.com:derickr/mongo-php-driver.git","clone_url":"https://github.com/derickr/mongo-php-driver.git","svn_url":"https://github.com/derickr/mongo-php-driver","homepage":"","size":7318,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mongodb:v1.5","ref":"v1.5","sha":"41dd0b93dce02fbc72cff7cb2e7ea70138f800bf","user":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":19514152,"node_id":"MDEwOlJlcG9zaXRvcnkxOTUxNDE1Mg==","name":"mongo-php-driver","full_name":"mongodb/mongo-php-driver","owner":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mongodb/mongo-php-driver","description":"MongoDB PHP driver","fork":false,"url":"https://api.github.com/repos/mongodb/mongo-php-driver","forks_url":"https://api.github.com/repos/mongodb/mongo-php-driver/forks","keys_url":"https://api.github.com/repos/mongodb/mongo-php-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/mongo-php-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/mongo-php-driver/teams","hooks_url":"https://api.github.com/repos/mongodb/mongo-php-driver/hooks","issue_events_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/mongo-php-driver/events","assignees_url":"https://api.github.com/repos/mongodb/mongo-php-driver/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/mongo-php-driver/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/mongo-php-driver/tags","blobs_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/mongo-php-driver/languages","stargazers_url":"https://api.github.com/repos/mongodb/mongo-php-driver/stargazers","contributors_url":"https://api.github.com/repos/mongodb/mongo-php-driver/contributors","subscribers_url":"https://api.github.com/repos/mongodb/mongo-php-driver/subscribers","subscription_url":"https://api.github.com/repos/mongodb/mongo-php-driver/subscription","commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/mongo-php-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/mongo-php-driver/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/mongo-php-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/mongo-php-driver/merges","archive_url":"https://api.github.com/repos/mongodb/mongo-php-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/mongo-php-driver/downloads","issues_url":"https://api.github.com/repos/mongodb/mongo-php-driver/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/mongo-php-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/mongo-php-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/mongo-php-driver/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/mongo-php-driver/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/mongo-php-driver/deployments","created_at":"2014-05-06T23:18:32Z","updated_at":"2018-09-05T09:35:39Z","pushed_at":"2018-09-05T16:43:20Z","git_url":"git://github.com/mongodb/mongo-php-driver.git","ssh_url":"git@github.com:mongodb/mongo-php-driver.git","clone_url":"https://github.com/mongodb/mongo-php-driver.git","svn_url":"https://github.com/mongodb/mongo-php-driver","homepage":"https://pecl.php.net/package/mongodb","size":6823,"stargazers_count":543,"watchers_count":543,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":144,"open_issues":23,"watchers":543,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913"},"html":{"href":"https://github.com/mongodb/mongo-php-driver/pull/913"},"issue":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/913"},"comments":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/issues/913/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/pulls/913/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/mongo-php-driver/statuses/4ef43d09c7b1d2285db196989c7880507885f7a4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"derickr"}}