{"action":"opened","issue":{"url":"https://api.github.com/repos/desktop/desktop/issues/4846","repository_url":"https://api.github.com/repos/desktop/desktop","labels_url":"https://api.github.com/repos/desktop/desktop/issues/4846/labels{/name}","comments_url":"https://api.github.com/repos/desktop/desktop/issues/4846/comments","events_url":"https://api.github.com/repos/desktop/desktop/issues/4846/events","html_url":"https://github.com/desktop/desktop/issues/4846","id":328352984,"node_id":"MDU6SXNzdWUzMjgzNTI5ODQ=","number":4846,"title":"Remove ellipses from \"Discard All Changes…\" and \"Discard Changes…\" contextual menu items","user":{"login":"zackkatz","id":870979,"node_id":"MDQ6VXNlcjg3MDk3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/870979?v=4","gravatar_id":"","url":"https://api.github.com/users/zackkatz","html_url":"https://github.com/zackkatz","followers_url":"https://api.github.com/users/zackkatz/followers","following_url":"https://api.github.com/users/zackkatz/following{/other_user}","gists_url":"https://api.github.com/users/zackkatz/gists{/gist_id}","starred_url":"https://api.github.com/users/zackkatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackkatz/subscriptions","organizations_url":"https://api.github.com/users/zackkatz/orgs","repos_url":"https://api.github.com/users/zackkatz/repos","events_url":"https://api.github.com/users/zackkatz/events{/privacy}","received_events_url":"https://api.github.com/users/zackkatz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-01T01:51:56Z","updated_at":"2018-06-01T01:51:56Z","closed_at":null,"author_association":"NONE","body":"## Description\r\n\r\nOn the Mac, when contextual menu items have ellipses (\"…\"), that means there is going to be a dialog before any action is performed.\r\n\r\nFrom the [Human Interface Guidelines for macOS Apps](https://developer.apple.com/macos/human-interface-guidelines/menus/menu-anatomy/):\r\n\r\n> **Use an ellipsis whenever choosing a menu item requires additional input from the user.** The ellipsis character (…) means a dialog or separate window will open and prompt the user for more information or to make a choice.\r\n\r\nTo be consistent with macOS, the \"Discard Changes…\" and \"Discard All Changes…\" menu items should be renamed to \"Discard Changes\" and \"Discard All Changes\".\r\n\r\n## Version\r\n\r\n* GitHub Desktop: 1.2.2\r\n* Operating system: macOS 10.13.4\r\n\r\n## Steps to Reproduce\r\n1. Right-click on a change in the \"Changes\" tab of a repository\r\n1. See \"Discard Changes…\" and \"Discard All Changes…\"\r\n2. Select \"Discard All Changes…\" or \"Discard Changes…\"\r\n\r\n### Expected Behavior\r\n\r\nAccording to macOS standards, I expected to see a dialog confirming my choice or providing options based on the selected menu item. It should not have performed the action until additional confirmation was given.\r\n\r\n### Actual Behavior\r\n\r\nThe selected action takes place right away."}}
{"actor":{"display_login":"zackkatz"}}