{"action":"created","comment":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments/195600782","pull_request_review_id":129004443,"id":195600782,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTYwMDc4Mg==","diff_hunk":"@@ -238,14 +238,12 @@ - (void)releaseObjectInBackground:(id  _Nullable __strong *)objectPtr\n \n - (void)drain\n {\n-  @autoreleasepool {\n-    _lock.lock();\n-    auto q = std::move(_queue);\n-    _lock.unlock();\n-    for (auto ref : q) {\n-      // NOTE: Could check that retain count is 1 and retry later if not.\n-      CFRelease(ref);\n-    }\n+  _lock.lock();\n+  auto q = std::move(_queue);\n+  _lock.unlock();\n+  for (auto ref : q) {\n+    // NOTE: Could check that retain count is 1 and retry later if not.\n+    CFRelease(ref);","path":"Source/ASRunLoopQueue.mm","position":17,"original_position":17,"commit_id":"56870b15dabe887623b3d653c2ab3fa221d45c50","original_commit_id":"56870b15dabe887623b3d653c2ab3fa221d45c50","user":{"login":"Adlai-Holler","id":2466893,"node_id":"MDQ6VXNlcjI0NjY4OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2466893?v=4","gravatar_id":"","url":"https://api.github.com/users/Adlai-Holler","html_url":"https://github.com/Adlai-Holler","followers_url":"https://api.github.com/users/Adlai-Holler/followers","following_url":"https://api.github.com/users/Adlai-Holler/following{/other_user}","gists_url":"https://api.github.com/users/Adlai-Holler/gists{/gist_id}","starred_url":"https://api.github.com/users/Adlai-Holler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adlai-Holler/subscriptions","organizations_url":"https://api.github.com/users/Adlai-Holler/orgs","repos_url":"https://api.github.com/users/Adlai-Holler/repos","events_url":"https://api.github.com/users/Adlai-Holler/events{/privacy}","received_events_url":"https://api.github.com/users/Adlai-Holler/received_events","type":"User","site_admin":false},"body":"I was silly for putting this in in the first place. Creating autorelease pools takes a lot of time and there's absolutely no chance of anything getting added to it in here 🤦‍♂️ ","created_at":"2018-06-14T23:32:16Z","updated_at":"2018-06-14T23:32:17Z","html_url":"https://github.com/TextureGroup/Texture/pull/968#discussion_r195600782","pull_request_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/968","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments/195600782"},"html":{"href":"https://github.com/TextureGroup/Texture/pull/968#discussion_r195600782"},"pull_request":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/968"}}},"pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/968","id":195044438,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDQ0NDM4","html_url":"https://github.com/TextureGroup/Texture/pull/968","diff_url":"https://github.com/TextureGroup/Texture/pull/968.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/968.patch","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/968","number":968,"state":"open","locked":false,"title":"Reduce reliance on the autorelease pool","user":{"login":"Adlai-Holler","id":2466893,"node_id":"MDQ6VXNlcjI0NjY4OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2466893?v=4","gravatar_id":"","url":"https://api.github.com/users/Adlai-Holler","html_url":"https://github.com/Adlai-Holler","followers_url":"https://api.github.com/users/Adlai-Holler/followers","following_url":"https://api.github.com/users/Adlai-Holler/following{/other_user}","gists_url":"https://api.github.com/users/Adlai-Holler/gists{/gist_id}","starred_url":"https://api.github.com/users/Adlai-Holler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adlai-Holler/subscriptions","organizations_url":"https://api.github.com/users/Adlai-Holler/orgs","repos_url":"https://api.github.com/users/Adlai-Holler/repos","events_url":"https://api.github.com/users/Adlai-Holler/events{/privacy}","received_events_url":"https://api.github.com/users/Adlai-Holler/received_events","type":"User","site_admin":false},"body":"Unfortunately, Foundation and UIKit are not going to be compiled with ARC any time soon.\r\n\r\nSo until then, calling methods like `+[NSArray array]` under ARC will not use the fast-return path and will result in `alloc -> autorelease -> retain` to get a +1 instead of just `alloc`. Plus draining the pool takes time! Why waste it?","created_at":"2018-06-14T23:31:40Z","updated_at":"2018-06-14T23:32:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c87d2bd0aaa5bcb5bb2f85d4feed734522996449","assignee":null,"assignees":[],"requested_reviewers":[{"login":"maicki","id":25288,"node_id":"MDQ6VXNlcjI1Mjg4","avatar_url":"https://avatars1.githubusercontent.com/u/25288?v=4","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},{"login":"garrettmoon","id":90045,"node_id":"MDQ6VXNlcjkwMDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/90045?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},{"login":"appleguy","id":565251,"node_id":"MDQ6VXNlcjU2NTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/565251?v=4","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},{"login":"nguyenhuy","id":587874,"node_id":"MDQ6VXNlcjU4Nzg3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/587874?v=4","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/968/commits","review_comments_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/968/comments","review_comment_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/968/comments","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/56870b15dabe887623b3d653c2ab3fa221d45c50","head":{"label":"TextureGroup:AHLessAutorelease","ref":"AHLessAutorelease","sha":"56870b15dabe887623b3d653c2ab3fa221d45c50","user":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"node_id":"MDEwOlJlcG9zaXRvcnk4MTUxNDA2Ng==","name":"Texture","full_name":"TextureGroup/Texture","owner":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2018-06-14T14:30:42Z","pushed_at":"2018-06-14T23:31:41Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":123693,"stargazers_count":3880,"watchers_count":3880,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":313,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":483,"open_issues":313,"watchers":3880,"default_branch":"master"}},"base":{"label":"TextureGroup:master","ref":"master","sha":"a4dd19d80859602c0564368a2e5e83435feedebb","user":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"node_id":"MDEwOlJlcG9zaXRvcnk4MTUxNDA2Ng==","name":"Texture","full_name":"TextureGroup/Texture","owner":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2018-06-14T14:30:42Z","pushed_at":"2018-06-14T23:31:41Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":123693,"stargazers_count":3880,"watchers_count":3880,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":313,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":483,"open_issues":313,"watchers":3880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/968"},"html":{"href":"https://github.com/TextureGroup/Texture/pull/968"},"issue":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/968"},"comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/968/comments"},"review_comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/968/comments"},"review_comment":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/968/commits"},"statuses":{"href":"https://api.github.com/repos/TextureGroup/Texture/statuses/56870b15dabe887623b3d653c2ab3fa221d45c50"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Adlai-Holler"}}