{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/4037","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4037/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4037/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4037/events","html_url":"https://github.com/apache/incubator-airflow/pull/4037","id":369211147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjA3NTUz","number":4037,"title":"[AIRFLOW-3191] Fix not being able to specify execution_date when creating dagrun","user":{"login":"aoen","id":1592778,"node_id":"MDQ6VXNlcjE1OTI3Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1592778?v=4","gravatar_id":"","url":"https://api.github.com/users/aoen","html_url":"https://github.com/aoen","followers_url":"https://api.github.com/users/aoen/followers","following_url":"https://api.github.com/users/aoen/following{/other_user}","gists_url":"https://api.github.com/users/aoen/gists{/gist_id}","starred_url":"https://api.github.com/users/aoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoen/subscriptions","organizations_url":"https://api.github.com/users/aoen/orgs","repos_url":"https://api.github.com/users/aoen/repos","events_url":"https://api.github.com/users/aoen/events{/privacy}","received_events_url":"https://api.github.com/users/aoen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-11T16:48:09Z","updated_at":"2018-10-15T17:54:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/4037","html_url":"https://github.com/apache/incubator-airflow/pull/4037","diff_url":"https://github.com/apache/incubator-airflow/pull/4037.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/4037.patch"},"body":"### Jira\r\n\r\n- [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n  - https://issues.apache.org/jira/browse/AIRFLOW-3191\r\n  - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a Jira issue.\r\n\r\nCreating a dagrun using the flask web UI is not possible because execution_date is hidden. This is because the column type is actually DATETIME where Flask only has a converter for DateTime (it's the same type, it's a casing issue).\r\n\r\nFix is to add a form override: form_overrides = dict(execution_date=DateTimeField)\r\n\r\n### Description\r\n\r\n- [X] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\n\r\n### Tests\r\n\r\n- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\nUI change, no tests for it. Made sure dagrun field appeared in UI and DAGRun was indeed created by the form.\r\n\r\n### Commits\r\n\r\n- [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [X] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [X] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/429951432","html_url":"https://github.com/apache/incubator-airflow/pull/4037#issuecomment-429951432","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/4037","id":429951432,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTk1MTQzMg==","user":{"login":"aoen","id":1592778,"node_id":"MDQ6VXNlcjE1OTI3Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1592778?v=4","gravatar_id":"","url":"https://api.github.com/users/aoen","html_url":"https://github.com/aoen","followers_url":"https://api.github.com/users/aoen/followers","following_url":"https://api.github.com/users/aoen/following{/other_user}","gists_url":"https://api.github.com/users/aoen/gists{/gist_id}","starred_url":"https://api.github.com/users/aoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aoen/subscriptions","organizations_url":"https://api.github.com/users/aoen/orgs","repos_url":"https://api.github.com/users/aoen/repos","events_url":"https://api.github.com/users/aoen/events{/privacy}","received_events_url":"https://api.github.com/users/aoen/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T17:54:57Z","updated_at":"2018-10-15T17:54:57Z","author_association":"CONTRIBUTOR","body":"The dagrun got created with the correct timezone, it follows the same pattern as other date elements in the forms."}}
{"actor":{"display_login":"aoen"}}