{"action":"created","comment":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments/166442377","pull_request_review_id":94504919,"id":166442377,"diff_hunk":"@@ -30,9 +56,18 @@ export class FieldGroup extends PureComponent {\n     }\n \n     componentWillMount() {\n-        const {groupKey:wrapperGroupKey}= this.context;\n-        var {groupKey, reducerFunc, keepState, initValues, actionTypes}= this.props;\n-        dispatchMountFieldGroup(groupKey, true, keepState, initValues, reducerFunc, actionTypes, wrapperGroupKey);\n+        const {groupKey}= this.props;\n+        const groupState= getFieldGroupState(groupKey);\n+        if (groupState && groupState.mounted) {","path":"src/firefly/js/ui/FieldGroup.jsx","position":44,"original_position":44,"commit_id":"8690bd3a0144efc36913fad1d399d2ddd0de5b8b","original_commit_id":"8690bd3a0144efc36913fad1d399d2ddd0de5b8b","user":{"login":"tgoldina","id":11876160,"avatar_url":"https://avatars0.githubusercontent.com/u/11876160?v=4","gravatar_id":"","url":"https://api.github.com/users/tgoldina","html_url":"https://github.com/tgoldina","followers_url":"https://api.github.com/users/tgoldina/followers","following_url":"https://api.github.com/users/tgoldina/following{/other_user}","gists_url":"https://api.github.com/users/tgoldina/gists{/gist_id}","starred_url":"https://api.github.com/users/tgoldina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgoldina/subscriptions","organizations_url":"https://api.github.com/users/tgoldina/orgs","repos_url":"https://api.github.com/users/tgoldina/repos","events_url":"https://api.github.com/users/tgoldina/events{/privacy}","received_events_url":"https://api.github.com/users/tgoldina/received_events","type":"User","site_admin":false},"body":"Should we also check for !keepMounted here? Looks like we never use this property, but if it is true, we will never dispatch unmount, hence the callback will never execute.","created_at":"2018-02-06T21:09:25Z","updated_at":"2018-02-06T21:24:35Z","html_url":"https://github.com/Caltech-IPAC/firefly/pull/542#discussion_r166442377","pull_request_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments/166442377"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/542#discussion_r166442377"},"pull_request":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542"}}},"pull_request":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542","id":167207837,"html_url":"https://github.com/Caltech-IPAC/firefly/pull/542","diff_url":"https://github.com/Caltech-IPAC/firefly/pull/542.diff","patch_url":"https://github.com/Caltech-IPAC/firefly/pull/542.patch","issue_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/542","number":542,"state":"open","locked":false,"title":"DM-13273: upgrade react to 16 and upgrade other packages","user":{"login":"robyww","id":6730519,"avatar_url":"https://avatars3.githubusercontent.com/u/6730519?v=4","gravatar_id":"","url":"https://api.github.com/users/robyww","html_url":"https://github.com/robyww","followers_url":"https://api.github.com/users/robyww/followers","following_url":"https://api.github.com/users/robyww/following{/other_user}","gists_url":"https://api.github.com/users/robyww/gists{/gist_id}","starred_url":"https://api.github.com/users/robyww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robyww/subscriptions","organizations_url":"https://api.github.com/users/robyww/orgs","repos_url":"https://api.github.com/users/robyww/repos","events_url":"https://api.github.com/users/robyww/events{/privacy}","received_events_url":"https://api.github.com/users/robyww/received_events","type":"User","site_admin":false},"body":" Upgrade react to 16 and upgrade other packages  \r\n\r\n  - removed `chartEngine` app option, and references to `highcharts`\r\n  - removed `react-component-resizable`, all code now using `react-sizeme`\r\n  - removed `react-addons-perf`, it is not longer supports for 16\r\n  - fixed a couple of files that had warning issues\r\n  - new version of `validator` now only takes strings, fixed any code using it\r\n  - removed ImageViewerView because it was no longer necessary with SizeMe\r\n  - a little code clean up if I was already working in the file.\r\n\r\n\r\n_To Test:_\r\n\r\n - Delete your node_modules directory.\r\n - Choose area of the code you know about.\r\n - Make sure it behaves like before.\r\n - Pay attention to any UI subtleties: resizing, updating correctly, layout, etc","created_at":"2018-02-05T17:33:55Z","updated_at":"2018-02-06T21:24:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f95fda5fae197239b75ca6cc372d3f13ef76084a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ejoliet","id":770124,"avatar_url":"https://avatars0.githubusercontent.com/u/770124?v=4","gravatar_id":"","url":"https://api.github.com/users/ejoliet","html_url":"https://github.com/ejoliet","followers_url":"https://api.github.com/users/ejoliet/followers","following_url":"https://api.github.com/users/ejoliet/following{/other_user}","gists_url":"https://api.github.com/users/ejoliet/gists{/gist_id}","starred_url":"https://api.github.com/users/ejoliet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejoliet/subscriptions","organizations_url":"https://api.github.com/users/ejoliet/orgs","repos_url":"https://api.github.com/users/ejoliet/repos","events_url":"https://api.github.com/users/ejoliet/events{/privacy}","received_events_url":"https://api.github.com/users/ejoliet/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542/commits","review_comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542/comments","review_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/542/comments","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/8690bd3a0144efc36913fad1d399d2ddd0de5b8b","head":{"label":"Caltech-IPAC:dm-13273-react-upgrade","ref":"dm-13273-react-upgrade","sha":"8690bd3a0144efc36913fad1d399d2ddd0de5b8b","user":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2018-02-01T19:37:40Z","pushed_at":"2018-02-06T20:18:51Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":168763,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":7,"watchers":9,"default_branch":"dev"}},"base":{"label":"Caltech-IPAC:dev","ref":"dev","sha":"5e30af621aece466c60594ac9611067125c0a412","user":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2018-02-01T19:37:40Z","pushed_at":"2018-02-06T20:18:51Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":168763,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":7,"watchers":9,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/542"},"issue":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/542"},"comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/8690bd3a0144efc36913fad1d399d2ddd0de5b8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tgoldina"}}