{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab-core/pulls/comments/227537677","pull_request_review_id":167603273,"id":227537677,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzUzNzY3Nw==","diff_hunk":"@@ -65,7 +62,7 @@ export function addObjects(room, model, floorPrefix, roomObjects) {\n             floorPrefix + room.value,\n             GROUP_PREFIX + object.value\n         ],\n-        tags: addTags(object, model),\n+        tags: object.tags,","path":"bundles/org.openhab.ui.homebuilder/web/src/restItems.js","position":44,"original_position":44,"commit_id":"4b85b673d04dd5c322313405637599fc64228a36","original_commit_id":"4b85b673d04dd5c322313405637599fc64228a36","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"body":"No it was already broken, it seems that the `onChanged` is not called when `onNewTag` is called, see:\r\n\r\nhttp://demo.openhab.org:8080/homebuilder/index.html","created_at":"2018-10-23T19:45:15Z","updated_at":"2018-10-23T19:45:16Z","html_url":"https://github.com/openhab/openhab-core/pull/417#discussion_r227537677","pull_request_url":"https://api.github.com/repos/openhab/openhab-core/pulls/417","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/comments/227537677"},"html":{"href":"https://github.com/openhab/openhab-core/pull/417#discussion_r227537677"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/417"}},"in_reply_to_id":227514953},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab-core/pulls/417","id":224752495,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzUyNDk1","html_url":"https://github.com/openhab/openhab-core/pull/417","diff_url":"https://github.com/openhab/openhab-core/pull/417.diff","patch_url":"https://github.com/openhab/openhab-core/pull/417.patch","issue_url":"https://api.github.com/repos/openhab/openhab-core/issues/417","number":417,"state":"open","locked":false,"title":"Some updates to the HomeBuilder","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"body":"New features\r\n\r\n- Added semantic labels to tags Floors, Rooms and objects\r\n- Added a Cellar as a Floor\r\n- Added support for more languages which where already available as translation\r\n\r\nChanges to the build:\r\n\r\n- Integrated the webpack build inside Maven\r\n- Only allow minor updates in the package.json to make sure new version will not easily break the build, if semver fails again\r\n- Remove dist folder because it should be generated through the build\r\n\r\nSmall updates because of some updated dependencies\r\n\r\n- Switched from 'hidden-xs-up' to 'd-none' as proposed in bootstrap migration guide\r\n- Switched from 'scope' to 'slot-scope' as suggested by vue 2.5 migration\r\n- Added some additional parents in the vue schema because they were needed\r\n\r\nSmall fixes:\r\n\r\n- removed osgi import from manifest\r\n\r\n[org.openhab.ui.homebuilder-2.4.0-SNAPSHOT.jar.zip](https://github.com/openhab/openhab-core/files/2502545/org.openhab.ui.homebuilder-2.4.0-SNAPSHOT.jar.zip)\r\n","created_at":"2018-10-22T17:26:53Z","updated_at":"2018-10-23T19:45:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbaecc358106986720320e498b335234ce9dcbfc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wborn","id":12213581,"node_id":"MDQ6VXNlcjEyMjEzNTgx","avatar_url":"https://avatars1.githubusercontent.com/u/12213581?v=4","gravatar_id":"","url":"https://api.github.com/users/wborn","html_url":"https://github.com/wborn","followers_url":"https://api.github.com/users/wborn/followers","following_url":"https://api.github.com/users/wborn/following{/other_user}","gists_url":"https://api.github.com/users/wborn/gists{/gist_id}","starred_url":"https://api.github.com/users/wborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wborn/subscriptions","organizations_url":"https://api.github.com/users/wborn/orgs","repos_url":"https://api.github.com/users/wborn/repos","events_url":"https://api.github.com/users/wborn/events{/privacy}","received_events_url":"https://api.github.com/users/wborn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab-core/pulls/417/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab-core/pulls/417/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab-core/issues/417/comments","statuses_url":"https://api.github.com/repos/openhab/openhab-core/statuses/4b85b673d04dd5c322313405637599fc64228a36","head":{"label":"martinvw:feature/home-builder-updates","ref":"feature/home-builder-updates","sha":"4b85b673d04dd5c322313405637599fc64228a36","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"repo":{"id":88042673,"node_id":"MDEwOlJlcG9zaXRvcnk4ODA0MjY3Mw==","name":"openhab-core","full_name":"martinvw/openhab-core","private":false,"owner":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/martinvw/openhab-core","description":null,"fork":true,"url":"https://api.github.com/repos/martinvw/openhab-core","forks_url":"https://api.github.com/repos/martinvw/openhab-core/forks","keys_url":"https://api.github.com/repos/martinvw/openhab-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinvw/openhab-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinvw/openhab-core/teams","hooks_url":"https://api.github.com/repos/martinvw/openhab-core/hooks","issue_events_url":"https://api.github.com/repos/martinvw/openhab-core/issues/events{/number}","events_url":"https://api.github.com/repos/martinvw/openhab-core/events","assignees_url":"https://api.github.com/repos/martinvw/openhab-core/assignees{/user}","branches_url":"https://api.github.com/repos/martinvw/openhab-core/branches{/branch}","tags_url":"https://api.github.com/repos/martinvw/openhab-core/tags","blobs_url":"https://api.github.com/repos/martinvw/openhab-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinvw/openhab-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinvw/openhab-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinvw/openhab-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinvw/openhab-core/statuses/{sha}","languages_url":"https://api.github.com/repos/martinvw/openhab-core/languages","stargazers_url":"https://api.github.com/repos/martinvw/openhab-core/stargazers","contributors_url":"https://api.github.com/repos/martinvw/openhab-core/contributors","subscribers_url":"https://api.github.com/repos/martinvw/openhab-core/subscribers","subscription_url":"https://api.github.com/repos/martinvw/openhab-core/subscription","commits_url":"https://api.github.com/repos/martinvw/openhab-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinvw/openhab-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinvw/openhab-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinvw/openhab-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinvw/openhab-core/contents/{+path}","compare_url":"https://api.github.com/repos/martinvw/openhab-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinvw/openhab-core/merges","archive_url":"https://api.github.com/repos/martinvw/openhab-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinvw/openhab-core/downloads","issues_url":"https://api.github.com/repos/martinvw/openhab-core/issues{/number}","pulls_url":"https://api.github.com/repos/martinvw/openhab-core/pulls{/number}","milestones_url":"https://api.github.com/repos/martinvw/openhab-core/milestones{/number}","notifications_url":"https://api.github.com/repos/martinvw/openhab-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinvw/openhab-core/labels{/name}","releases_url":"https://api.github.com/repos/martinvw/openhab-core/releases{/id}","deployments_url":"https://api.github.com/repos/martinvw/openhab-core/deployments","created_at":"2017-04-12T11:07:43Z","updated_at":"2017-04-12T11:07:45Z","pushed_at":"2018-10-22T19:10:23Z","git_url":"git://github.com/martinvw/openhab-core.git","ssh_url":"git@github.com:martinvw/openhab-core.git","clone_url":"https://github.com/martinvw/openhab-core.git","svn_url":"https://github.com/martinvw/openhab-core","homepage":null,"size":11514,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"49be9be62b878f985bb4a76ee83a5c30e3908d00","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":48337670,"node_id":"MDEwOlJlcG9zaXRvcnk0ODMzNzY3MA==","name":"openhab-core","full_name":"openhab/openhab-core","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab-core","description":null,"fork":false,"url":"https://api.github.com/repos/openhab/openhab-core","forks_url":"https://api.github.com/repos/openhab/openhab-core/forks","keys_url":"https://api.github.com/repos/openhab/openhab-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab-core/teams","hooks_url":"https://api.github.com/repos/openhab/openhab-core/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab-core/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab-core/events","assignees_url":"https://api.github.com/repos/openhab/openhab-core/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab-core/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab-core/tags","blobs_url":"https://api.github.com/repos/openhab/openhab-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab-core/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab-core/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab-core/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab-core/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab-core/subscription","commits_url":"https://api.github.com/repos/openhab/openhab-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab-core/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab-core/merges","archive_url":"https://api.github.com/repos/openhab/openhab-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab-core/downloads","issues_url":"https://api.github.com/repos/openhab/openhab-core/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab-core/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab-core/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab-core/deployments","created_at":"2015-12-20T21:23:20Z","updated_at":"2018-10-17T09:33:19Z","pushed_at":"2018-10-22T19:10:24Z","git_url":"git://github.com/openhab/openhab-core.git","ssh_url":"git@github.com:openhab/openhab-core.git","clone_url":"https://github.com/openhab/openhab-core.git","svn_url":"https://github.com/openhab/openhab-core","homepage":null,"size":11492,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":103,"open_issues":34,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/417"},"html":{"href":"https://github.com/openhab/openhab-core/pull/417"},"issue":{"href":"https://api.github.com/repos/openhab/openhab-core/issues/417"},"comments":{"href":"https://api.github.com/repos/openhab/openhab-core/issues/417/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/417/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab-core/pulls/417/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab-core/statuses/4b85b673d04dd5c322313405637599fc64228a36"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"martinvw"}}