{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/8151","repository_url":"https://api.github.com/repos/astropy/astropy","labels_url":"https://api.github.com/repos/astropy/astropy/issues/8151/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/8151/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/8151/events","html_url":"https://github.com/astropy/astropy/issues/8151","id":381784954,"node_id":"MDU6SXNzdWUzODE3ODQ5NTQ=","number":8151,"title":"Name of uncertainties: StdDevUncertainty vs. VarianceUncertainty vs. InverseVariance","user":{"login":"MSeifert04","id":14200878,"node_id":"MDQ6VXNlcjE0MjAwODc4","avatar_url":"https://avatars2.githubusercontent.com/u/14200878?v=4","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"labels":[{"id":316473427,"node_id":"MDU6TGFiZWwzMTY0NzM0Mjc=","url":"https://api.github.com/repos/astropy/astropy/labels/Refactoring","name":"Refactoring","color":"fef2c0","default":false},{"id":1106433757,"node_id":"MDU6TGFiZWwxMTA2NDMzNzU3","url":"https://api.github.com/repos/astropy/astropy/labels/uncertainty","name":"uncertainty","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/52","html_url":"https://github.com/astropy/astropy/milestone/52","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/52/labels","id":2929745,"node_id":"MDk6TWlsZXN0b25lMjkyOTc0NQ==","number":52,"title":"v3.1","description":"","creator":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":264,"state":"open","created_at":"2017-11-21T23:24:18Z","updated_at":"2018-11-20T23:20:57Z","due_on":"2018-10-26T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-11-16T22:35:52Z","updated_at":"2018-11-21T16:51:20Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There is a bit of inconsistency between the names. The first (`StdDevUncertainty`) is somewhat abbreviated and has the \"Uncertainty\" suffix, the second (`VarianceUncertainty`) uses the full name and the suffix, while the last one (`InverseVariance`) uses the full name without suffix.\r\n\r\nSince they shouldn't be \"offically released\" yet we still could make the names more consistent with `StdDevUncertainty` (the already released one)? Maybe `VarUncertainty` and `IVarUncertainty` (or `InvVarUncertainty`)?\r\n\r\nNot sure if this is actually necessary, I just noticed and wanted to ask if someone else is bothered about the naming. 😅 "},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/440735921","html_url":"https://github.com/astropy/astropy/issues/8151#issuecomment-440735921","issue_url":"https://api.github.com/repos/astropy/astropy/issues/8151","id":440735921,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDczNTkyMQ==","user":{"login":"mwcraig","id":1147167,"node_id":"MDQ6VXNlcjExNDcxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1147167?v=4","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T16:51:20Z","updated_at":"2018-11-21T16:51:20Z","author_association":"CONTRIBUTOR","body":"I thought about this for a while when picking the new names. What I would really like to do is go with longer names, ideally without `Uncertainty` in them at all. So my ideal would be `StandardDeviation`, `Variance`, and `InverseVariance`. These are all camera and explicit, and presumably one doesn’t need the reminder that one is using an `Uncertainty` if you know to use one.\r\n\r\nI think I went with the names actually in the PR to avoid deprecating `StdDevUncertainty` (and it avoid annoying people who use it with a deprecation warning), added `Uncertainty` to `Variance` to be consistent with `StdDevUncertainty` but didn’t put `Uncertainty` on `InverseVariance` because it was too long.\r\n\r\nWhat do you think about going the route of my preferred names? I can do the change later today or on Friday. \r\n\r\nIf we do change the name of `StdDevUncertainty` I’m inclined to leave the old name in without a deprecation warning to avoid another overwrite/clobber debate. \r\n\r\nThoughts?"}}
{"actor":{"display_login":"mwcraig"}}