{"action":"created","comment":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments/177803181","pull_request_review_id":107744481,"id":177803181,"diff_hunk":"@@ -207,7 +212,7 @@ if(HEX2DFU_TOOL_AVAILABLE)\n     NF_GENERATE_DFU_PACKAGE(\n         ${PROJECT_SOURCE_DIR}/build/${NANOBOOTER_PROJECT_NAME}.bin 08000000 \n         ${PROJECT_SOURCE_DIR}/build/${NANOCLR_PROJECT_NAME}.bin 08008000 \n-        ${PROJECT_SOURCE_DIR}/build/nanobooter-nanoclr.dfu\n+        ${PROJECT_SOURCE_DIR}/build/nanoframework-4-netduino3wifi.dfu","path":"targets/CMSIS-OS/ChibiOS/NETDUINO3_WIFI/CMakeLists.txt","position":17,"original_position":17,"commit_id":"03da80c57366f91bc6babfaa37820b2b4cb9a47a","original_commit_id":"03da80c57366f91bc6babfaa37820b2b4cb9a47a","user":{"login":"piwi1263","id":10466039,"avatar_url":"https://avatars3.githubusercontent.com/u/10466039?v=4","gravatar_id":"","url":"https://api.github.com/users/piwi1263","html_url":"https://github.com/piwi1263","followers_url":"https://api.github.com/users/piwi1263/followers","following_url":"https://api.github.com/users/piwi1263/following{/other_user}","gists_url":"https://api.github.com/users/piwi1263/gists{/gist_id}","starred_url":"https://api.github.com/users/piwi1263/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwi1263/subscriptions","organizations_url":"https://api.github.com/users/piwi1263/orgs","repos_url":"https://api.github.com/users/piwi1263/repos","events_url":"https://api.github.com/users/piwi1263/events{/privacy}","received_events_url":"https://api.github.com/users/piwi1263/received_events","type":"User","site_admin":false},"body":"Yes. If you have multiple outcomes from various boards it is of convenience to distinct the names. Plus after a certain amount of time you can't guess purely on the name for what board that one or more files were.","created_at":"2018-03-28T16:05:33Z","updated_at":"2018-03-28T16:05:33Z","html_url":"https://github.com/nanoframework/nf-interpreter/pull/656#discussion_r177803181","pull_request_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments/177803181"},"html":{"href":"https://github.com/nanoframework/nf-interpreter/pull/656#discussion_r177803181"},"pull_request":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656"}},"in_reply_to_id":177760772},"pull_request":{"url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656","id":177550333,"html_url":"https://github.com/nanoframework/nf-interpreter/pull/656","diff_url":"https://github.com/nanoframework/nf-interpreter/pull/656.diff","patch_url":"https://github.com/nanoframework/nf-interpreter/pull/656.patch","issue_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/656","number":656,"state":"open","locked":false,"title":"Various board updates for Netduino 3 Wifi","user":{"login":"piwi1263","id":10466039,"avatar_url":"https://avatars3.githubusercontent.com/u/10466039?v=4","gravatar_id":"","url":"https://api.github.com/users/piwi1263","html_url":"https://github.com/piwi1263","followers_url":"https://api.github.com/users/piwi1263/followers","following_url":"https://api.github.com/users/piwi1263/following{/other_user}","gists_url":"https://api.github.com/users/piwi1263/gists{/gist_id}","starred_url":"https://api.github.com/users/piwi1263/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwi1263/subscriptions","organizations_url":"https://api.github.com/users/piwi1263/orgs","repos_url":"https://api.github.com/users/piwi1263/repos","events_url":"https://api.github.com/users/piwi1263/events{/privacy}","received_events_url":"https://api.github.com/users/piwi1263/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis is cummulative change including the following:\r\n\r\n- Add support for ADC\r\n- Activate SPI2 on the Arduino pins\r\n- Active USART6 on the Arduino pins\r\n- Naming change on the build outcome\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes/closes/resolves an open issue, please link to the issue here using the template bellow (mind the link as all issues are open in the Home repository, not in this one) -->\r\n- Adds ADC support, fixes missing SPI2 and USART6, changes for naming to easily identify the target board. \r\n\r\n## How Has This Been Tested?<!-- (if applicable) -->\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots<!-- (if appropriate): -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Improvement (non-breaking change that improves a feature, code or algorithm)\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n\r\n<!--- It would be nice if you could sign off your contribution by replacing the name with your GitHub user name and GitHub email contact. -->\r\nSigned-off-by: piwi1263 <piwi1263@gmail.com>\r\n","created_at":"2018-03-26T19:54:06Z","updated_at":"2018-03-28T16:05:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82206190612a944c5c2afced34d36677008faebe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":550782856,"url":"https://api.github.com/repos/nanoframework/nf-interpreter/labels/area-Targets-ChibiOS","name":"area-Targets-ChibiOS","color":"d4c5f9","default":false},{"id":489219432,"url":"https://api.github.com/repos/nanoframework/nf-interpreter/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656/commits","review_comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656/comments","review_comment_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/656/comments","statuses_url":"https://api.github.com/repos/nanoframework/nf-interpreter/statuses/03da80c57366f91bc6babfaa37820b2b4cb9a47a","head":{"label":"piwi1263:origin/Various-Board-Updates-For-Netduino-3-Wifi","ref":"origin/Various-Board-Updates-For-Netduino-3-Wifi","sha":"03da80c57366f91bc6babfaa37820b2b4cb9a47a","user":{"login":"piwi1263","id":10466039,"avatar_url":"https://avatars3.githubusercontent.com/u/10466039?v=4","gravatar_id":"","url":"https://api.github.com/users/piwi1263","html_url":"https://github.com/piwi1263","followers_url":"https://api.github.com/users/piwi1263/followers","following_url":"https://api.github.com/users/piwi1263/following{/other_user}","gists_url":"https://api.github.com/users/piwi1263/gists{/gist_id}","starred_url":"https://api.github.com/users/piwi1263/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwi1263/subscriptions","organizations_url":"https://api.github.com/users/piwi1263/orgs","repos_url":"https://api.github.com/users/piwi1263/repos","events_url":"https://api.github.com/users/piwi1263/events{/privacy}","received_events_url":"https://api.github.com/users/piwi1263/received_events","type":"User","site_admin":false},"repo":{"id":123492821,"name":"nf-interpreter","full_name":"piwi1263/nf-interpreter","owner":{"login":"piwi1263","id":10466039,"avatar_url":"https://avatars3.githubusercontent.com/u/10466039?v=4","gravatar_id":"","url":"https://api.github.com/users/piwi1263","html_url":"https://github.com/piwi1263","followers_url":"https://api.github.com/users/piwi1263/followers","following_url":"https://api.github.com/users/piwi1263/following{/other_user}","gists_url":"https://api.github.com/users/piwi1263/gists{/gist_id}","starred_url":"https://api.github.com/users/piwi1263/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwi1263/subscriptions","organizations_url":"https://api.github.com/users/piwi1263/orgs","repos_url":"https://api.github.com/users/piwi1263/repos","events_url":"https://api.github.com/users/piwi1263/events{/privacy}","received_events_url":"https://api.github.com/users/piwi1263/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piwi1263/nf-interpreter","description":"nanoFramework Interpreter, CLR, HAL, PAL and reference target boards","fork":true,"url":"https://api.github.com/repos/piwi1263/nf-interpreter","forks_url":"https://api.github.com/repos/piwi1263/nf-interpreter/forks","keys_url":"https://api.github.com/repos/piwi1263/nf-interpreter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwi1263/nf-interpreter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwi1263/nf-interpreter/teams","hooks_url":"https://api.github.com/repos/piwi1263/nf-interpreter/hooks","issue_events_url":"https://api.github.com/repos/piwi1263/nf-interpreter/issues/events{/number}","events_url":"https://api.github.com/repos/piwi1263/nf-interpreter/events","assignees_url":"https://api.github.com/repos/piwi1263/nf-interpreter/assignees{/user}","branches_url":"https://api.github.com/repos/piwi1263/nf-interpreter/branches{/branch}","tags_url":"https://api.github.com/repos/piwi1263/nf-interpreter/tags","blobs_url":"https://api.github.com/repos/piwi1263/nf-interpreter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwi1263/nf-interpreter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwi1263/nf-interpreter/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwi1263/nf-interpreter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwi1263/nf-interpreter/statuses/{sha}","languages_url":"https://api.github.com/repos/piwi1263/nf-interpreter/languages","stargazers_url":"https://api.github.com/repos/piwi1263/nf-interpreter/stargazers","contributors_url":"https://api.github.com/repos/piwi1263/nf-interpreter/contributors","subscribers_url":"https://api.github.com/repos/piwi1263/nf-interpreter/subscribers","subscription_url":"https://api.github.com/repos/piwi1263/nf-interpreter/subscription","commits_url":"https://api.github.com/repos/piwi1263/nf-interpreter/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwi1263/nf-interpreter/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwi1263/nf-interpreter/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwi1263/nf-interpreter/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwi1263/nf-interpreter/contents/{+path}","compare_url":"https://api.github.com/repos/piwi1263/nf-interpreter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwi1263/nf-interpreter/merges","archive_url":"https://api.github.com/repos/piwi1263/nf-interpreter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwi1263/nf-interpreter/downloads","issues_url":"https://api.github.com/repos/piwi1263/nf-interpreter/issues{/number}","pulls_url":"https://api.github.com/repos/piwi1263/nf-interpreter/pulls{/number}","milestones_url":"https://api.github.com/repos/piwi1263/nf-interpreter/milestones{/number}","notifications_url":"https://api.github.com/repos/piwi1263/nf-interpreter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwi1263/nf-interpreter/labels{/name}","releases_url":"https://api.github.com/repos/piwi1263/nf-interpreter/releases{/id}","deployments_url":"https://api.github.com/repos/piwi1263/nf-interpreter/deployments","created_at":"2018-03-01T21:11:15Z","updated_at":"2018-03-26T16:08:47Z","pushed_at":"2018-03-26T19:50:16Z","git_url":"git://github.com/piwi1263/nf-interpreter.git","ssh_url":"git@github.com:piwi1263/nf-interpreter.git","clone_url":"https://github.com/piwi1263/nf-interpreter.git","svn_url":"https://github.com/piwi1263/nf-interpreter","homepage":"","size":19672,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"nanoframework:develop","ref":"develop","sha":"393aa43879ad38a5c0e596f95acc35f9b5326abd","user":{"login":"nanoframework","id":23728180,"avatar_url":"https://avatars1.githubusercontent.com/u/23728180?v=4","gravatar_id":"","url":"https://api.github.com/users/nanoframework","html_url":"https://github.com/nanoframework","followers_url":"https://api.github.com/users/nanoframework/followers","following_url":"https://api.github.com/users/nanoframework/following{/other_user}","gists_url":"https://api.github.com/users/nanoframework/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoframework/subscriptions","organizations_url":"https://api.github.com/users/nanoframework/orgs","repos_url":"https://api.github.com/users/nanoframework/repos","events_url":"https://api.github.com/users/nanoframework/events{/privacy}","received_events_url":"https://api.github.com/users/nanoframework/received_events","type":"Organization","site_admin":false},"repo":{"id":74834622,"name":"nf-interpreter","full_name":"nanoframework/nf-interpreter","owner":{"login":"nanoframework","id":23728180,"avatar_url":"https://avatars1.githubusercontent.com/u/23728180?v=4","gravatar_id":"","url":"https://api.github.com/users/nanoframework","html_url":"https://github.com/nanoframework","followers_url":"https://api.github.com/users/nanoframework/followers","following_url":"https://api.github.com/users/nanoframework/following{/other_user}","gists_url":"https://api.github.com/users/nanoframework/gists{/gist_id}","starred_url":"https://api.github.com/users/nanoframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanoframework/subscriptions","organizations_url":"https://api.github.com/users/nanoframework/orgs","repos_url":"https://api.github.com/users/nanoframework/repos","events_url":"https://api.github.com/users/nanoframework/events{/privacy}","received_events_url":"https://api.github.com/users/nanoframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nanoframework/nf-interpreter","description":"nanoFramework Interpreter, CLR, HAL, PAL and reference target boards","fork":false,"url":"https://api.github.com/repos/nanoframework/nf-interpreter","forks_url":"https://api.github.com/repos/nanoframework/nf-interpreter/forks","keys_url":"https://api.github.com/repos/nanoframework/nf-interpreter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanoframework/nf-interpreter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanoframework/nf-interpreter/teams","hooks_url":"https://api.github.com/repos/nanoframework/nf-interpreter/hooks","issue_events_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/events{/number}","events_url":"https://api.github.com/repos/nanoframework/nf-interpreter/events","assignees_url":"https://api.github.com/repos/nanoframework/nf-interpreter/assignees{/user}","branches_url":"https://api.github.com/repos/nanoframework/nf-interpreter/branches{/branch}","tags_url":"https://api.github.com/repos/nanoframework/nf-interpreter/tags","blobs_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanoframework/nf-interpreter/statuses/{sha}","languages_url":"https://api.github.com/repos/nanoframework/nf-interpreter/languages","stargazers_url":"https://api.github.com/repos/nanoframework/nf-interpreter/stargazers","contributors_url":"https://api.github.com/repos/nanoframework/nf-interpreter/contributors","subscribers_url":"https://api.github.com/repos/nanoframework/nf-interpreter/subscribers","subscription_url":"https://api.github.com/repos/nanoframework/nf-interpreter/subscription","commits_url":"https://api.github.com/repos/nanoframework/nf-interpreter/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanoframework/nf-interpreter/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanoframework/nf-interpreter/contents/{+path}","compare_url":"https://api.github.com/repos/nanoframework/nf-interpreter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanoframework/nf-interpreter/merges","archive_url":"https://api.github.com/repos/nanoframework/nf-interpreter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanoframework/nf-interpreter/downloads","issues_url":"https://api.github.com/repos/nanoframework/nf-interpreter/issues{/number}","pulls_url":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls{/number}","milestones_url":"https://api.github.com/repos/nanoframework/nf-interpreter/milestones{/number}","notifications_url":"https://api.github.com/repos/nanoframework/nf-interpreter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanoframework/nf-interpreter/labels{/name}","releases_url":"https://api.github.com/repos/nanoframework/nf-interpreter/releases{/id}","deployments_url":"https://api.github.com/repos/nanoframework/nf-interpreter/deployments","created_at":"2016-11-26T15:45:06Z","updated_at":"2018-03-22T23:05:02Z","pushed_at":"2018-03-26T19:54:07Z","git_url":"git://github.com/nanoframework/nf-interpreter.git","ssh_url":"git@github.com:nanoframework/nf-interpreter.git","clone_url":"https://github.com/nanoframework/nf-interpreter.git","svn_url":"https://github.com/nanoframework/nf-interpreter","homepage":"","size":19697,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":3,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656"},"html":{"href":"https://github.com/nanoframework/nf-interpreter/pull/656"},"issue":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/656"},"comments":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/nanoframework/nf-interpreter/statuses/03da80c57366f91bc6babfaa37820b2b4cb9a47a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"piwi1263"}}