{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/168877631","pull_request_review_id":97325000,"id":168877631,"diff_hunk":"@@ -1060,6 +1060,14 @@ public String toString() {\n           .setDescription(\"Netty socket option for SO_SNDBUF: the proposed buffer size that will \"\n               + \"be used for sends.\")\n           .build();\n+  public static final PropertyKey WORKER_MASTER_CONNECT_TIMEOUT =\n+      new Builder(Name.WORKER_MASTER_CONNECT_RETRY_TIMEOUT)","path":"core/common/src/main/java/alluxio/PropertyKey.java","position":5,"original_position":5,"commit_id":"cc4ac16e324b7672b6ffa7f3054f8abb7fab1bb1","original_commit_id":"cc4ac16e324b7672b6ffa7f3054f8abb7fab1bb1","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars0.githubusercontent.com/u/2223813?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"Should these match?","created_at":"2018-02-16T21:43:51Z","updated_at":"2018-02-16T22:04:20Z","html_url":"https://github.com/Alluxio/alluxio/pull/6886#discussion_r168877631","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/168877631"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/6886#discussion_r168877631"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886","id":169549434,"html_url":"https://github.com/Alluxio/alluxio/pull/6886","diff_url":"https://github.com/Alluxio/alluxio/pull/6886.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/6886.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/6886","number":6886,"state":"open","locked":false,"title":"[SMALLFIX] Retry master address lookup","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"Master address lookup does some retries of its own, but not as long as the retries needed to survive master failover. This can cause the worker to die if it starts while a master failover is happening. We address this by adding a retry around the worker's initial request for an ID from the master.\r\n\r\nThere is also a bigger issue where `AbstractClient#connect` would call `getAddress()` outside the retry loop. If getting the address throws an error, we wouldn't retry. `getAddress()` does some retries of its own, but not nearly as long as the retries we try to do for all RPC requests. To avoid super-long retries caused by nested retries, I've added a TimeBoundedExponentialRetry which uses exponential backoff up to some time limit. This handles nested retry loops gracefully.","created_at":"2018-02-16T05:14:02Z","updated_at":"2018-02-16T22:04:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6b598c7e0ba3220136e1dfb9f6f4c7b863b61aa","assignee":{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"assignees":[{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"apc999","id":1413748,"avatar_url":"https://avatars0.githubusercontent.com/u/1413748?v=4","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/6886/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/cc4ac16e324b7672b6ffa7f3054f8abb7fab1bb1","head":{"label":"aaudiber:retry-master-address-lookup","ref":"retry-master-address-lookup","sha":"cc4ac16e324b7672b6ffa7f3054f8abb7fab1bb1","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"repo":{"id":52421920,"name":"alluxio","full_name":"aaudiber/alluxio","owner":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars3.githubusercontent.com/u/3455177?v=4","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaudiber/alluxio","description":"Memory-Centric Virtual Distributed Storage System","fork":true,"url":"https://api.github.com/repos/aaudiber/alluxio","forks_url":"https://api.github.com/repos/aaudiber/alluxio/forks","keys_url":"https://api.github.com/repos/aaudiber/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaudiber/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaudiber/alluxio/teams","hooks_url":"https://api.github.com/repos/aaudiber/alluxio/hooks","issue_events_url":"https://api.github.com/repos/aaudiber/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/aaudiber/alluxio/events","assignees_url":"https://api.github.com/repos/aaudiber/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/aaudiber/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/aaudiber/alluxio/tags","blobs_url":"https://api.github.com/repos/aaudiber/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaudiber/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaudiber/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaudiber/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaudiber/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/aaudiber/alluxio/languages","stargazers_url":"https://api.github.com/repos/aaudiber/alluxio/stargazers","contributors_url":"https://api.github.com/repos/aaudiber/alluxio/contributors","subscribers_url":"https://api.github.com/repos/aaudiber/alluxio/subscribers","subscription_url":"https://api.github.com/repos/aaudiber/alluxio/subscription","commits_url":"https://api.github.com/repos/aaudiber/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaudiber/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaudiber/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaudiber/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaudiber/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/aaudiber/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaudiber/alluxio/merges","archive_url":"https://api.github.com/repos/aaudiber/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaudiber/alluxio/downloads","issues_url":"https://api.github.com/repos/aaudiber/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/aaudiber/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/aaudiber/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/aaudiber/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaudiber/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/aaudiber/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/aaudiber/alluxio/deployments","created_at":"2016-02-24T07:07:15Z","updated_at":"2017-02-08T21:57:09Z","pushed_at":"2018-02-16T05:18:33Z","git_url":"git://github.com/aaudiber/alluxio.git","ssh_url":"git@github.com:aaudiber/alluxio.git","clone_url":"https://github.com/aaudiber/alluxio.git","svn_url":"https://github.com/aaudiber/alluxio","homepage":"http://www.alluxio.org/","size":86096,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Alluxio:branch-1.7","ref":"branch-1.7","sha":"c415ad706d72708a1a86a15b2e441afdee980cb7","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars0.githubusercontent.com/u/16203694?v=4","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2018-02-16T18:45:39Z","pushed_at":"2018-02-16T21:48:49Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":86021,"stargazers_count":3342,"watchers_count":3342,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1746,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1746,"open_issues":8,"watchers":3342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/6886"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/6886"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/6886/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/6886/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/cc4ac16e324b7672b6ffa7f3054f8abb7fab1bb1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"calvinjia"}}