{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/56192","repository_url":"https://api.github.com/repos/brianchandotcom/liferay-portal","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/56192/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/56192/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/56192/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/56192","id":305232003,"number":56192,"title":"LPS-78665 UpgradeLayoutType: taking into account wrong article ids","user":{"login":"achaparro","id":861040,"avatar_url":"https://avatars1.githubusercontent.com/u/861040?v=4","gravatar_id":"","url":"https://api.github.com/users/achaparro","html_url":"https://github.com/achaparro","followers_url":"https://api.github.com/users/achaparro/followers","following_url":"https://api.github.com/users/achaparro/following{/other_user}","gists_url":"https://api.github.com/users/achaparro/gists{/gist_id}","starred_url":"https://api.github.com/users/achaparro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achaparro/subscriptions","organizations_url":"https://api.github.com/users/achaparro/orgs","repos_url":"https://api.github.com/users/achaparro/repos","events_url":"https://api.github.com/users/achaparro/events{/privacy}","received_events_url":"https://api.github.com/users/achaparro/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-14T16:23:31Z","updated_at":"2018-03-14T17:54:07Z","closed_at":"2018-03-14T17:54:05Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/56192","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/56192","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/56192.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/56192.patch"},"body":"Hi @mbowerman,\r\n\r\nAfter thinking more about it, your solution is the proper one. I just avoided to store -1 values in portlet preferences keeping old values, \r\n\r\nI have tested it and the WCD portlet shows the proper message:\r\n![article](https://user-images.githubusercontent.com/861040/37416027-1925ad14-27ad-11e8-82bb-e0e1bdb6f494.png)\r\n\r\nLet me know if you see any drawback.\r\n\r\nThanks!\r\ncc/@samziemer"},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/373116405","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/56192#issuecomment-373116405","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/56192","id":373116405,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars2.githubusercontent.com/u/4502793?v=4","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T17:54:06Z","updated_at":"2018-03-14T17:54:06Z","author_association":"COLLABORATOR","body":"<h1>The pull request tester is still running.</h1><p>Please wait until you get the <i><b>final report</b></i> before running 'ci:retest'.</p><p>See this link to check on the status of your test:</p><ul><li><a href=\"https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest(master)/1488/\">test-portal-acceptance-pullrequest(master)</a></li></ul><p>@achaparro</p><hr /><h1>However, the pull request was closed.</h1><p>The pull request was closed because the following critical batches had failed:</p><ul><li><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/221814/\">tck-jdk8</a></li></ul><p>For information as to why we automatically close out certain pull requests see this <a href=\"https://in.liferay.com/web/global.engineering/wiki/-/wiki/Quality+Assurance+Main/Test+Batch+Automatic+Close+List\">article</a>.</p><p auto-close=\"false\"><strong><em>*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.</em></strong></p><pre>ci&#58;reopen</pre><hr /><h3>Critical Failure Details:</h3><div><h5><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/221814/\">test-portal-acceptance-pullrequest-batch(master)/tck-jdk8</a></h5><div><h6>Job Results:</h6><p>599 Tests Passed.<br/>23 Tests Failed.</p></div><ol><li><div><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/221814//consoleText\">AXIS_VARIABLE=0,label_exp=!master #221814</a><ol><li><div><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/221814//testReport/com.sun.ts.tests.portlet.api.javax_portlet.ActionRequest/GetInvalidParameterTest/test\">GetInvalidParameterTest.test</a><pre><code>\nTest case throws exception: [BasePortletUrlClient] GetInvalidParameterTest failed! Test FAILED!\n\t\t</code></pre></div></li><li><div><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/221814//testReport/com.sun.ts.tests.portlet.api.javax_portlet.ActionRequest/GetLocaleTest/test\">GetLocaleTest.test</a><pre><code>\nTest case throws exception: [BasePortletUrlClient] GetLocaleTest failed! Test FAILED!\n\t\t</code></pre></div></li><li><div><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/221814//testReport/com.sun.ts.tests.portlet.api.javax_portlet.ActionRequest/GetParameterMapTest/test\">GetParameterMapTest.test</a><pre><code>\nTest case throws exception: [BasePortletUrlClient] GetParameterMapTest failed! Test FAILED!\n\t\t</code></pre></div></li><li>...</li></ol></div></li></ol></div>"}}
{"actor":{"display_login":"liferay-continuous-integration"}}