{"action":"created","issue":{"url":"https://api.github.com/repos/moby/moby/issues/36310","repository_url":"https://api.github.com/repos/moby/moby","labels_url":"https://api.github.com/repos/moby/moby/issues/36310/labels{/name}","comments_url":"https://api.github.com/repos/moby/moby/issues/36310/comments","events_url":"https://api.github.com/repos/moby/moby/issues/36310/events","html_url":"https://github.com/moby/moby/pull/36310","id":297004905,"number":36310,"title":"support unix:// addresses for --registry-mirrors","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"labels":[{"id":73635104,"url":"https://api.github.com/repos/moby/moby/labels/area/distribution","name":"area/distribution","color":"fbca04","default":false},{"id":237472270,"url":"https://api.github.com/repos/moby/moby/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf","default":false},{"id":175375318,"url":"https://api.github.com/repos/moby/moby/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-14T07:57:30Z","updated_at":"2018-02-14T07:59:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/36310","html_url":"https://github.com/moby/moby/pull/36310","diff_url":"https://github.com/moby/moby/pull/36310.diff","patch_url":"https://github.com/moby/moby/pull/36310.patch"},"body":"Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\nSupport unix:// addresses for --registry-mirrors.\r\n\r\n\r\n**- How I did it**\r\n\r\nPlease refer to the code\r\n\r\n**- How to verify it**\r\n\r\n1. Start `docker-registry serve a.yml` wit the following config\r\n```yaml\r\nversion: 0.1                               \r\nstorage:                                   \r\n  cache:                                   \r\n    blobdescriptor: inmemory               \r\n  filesystem:                              \r\n    rootdirectory: /var/lib/docker-registry-cache                                     \r\nhttp:                                      \r\n  addr: /run/docker-registry-cache.sock    \r\n  net: unix                                \r\nproxy:                                     \r\n  remoteurl: https://registry-1.docker.io\r\n```\r\n\r\n2. Start `dockerd` with `--registry-mirror=unix:///run/docker-registry-cache.sock`\r\n\r\n3. Do `docker pull something` and make sure the image is cached into the local registry.\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\nsupport unix:// addresses for --registry-mirrors\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n🐧 \r\n"},"comment":{"url":"https://api.github.com/repos/moby/moby/issues/comments/365524810","html_url":"https://github.com/moby/moby/pull/36310#issuecomment-365524810","issue_url":"https://api.github.com/repos/moby/moby/issues/36310","id":365524810,"user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T07:59:58Z","updated_at":"2018-02-14T07:59:58Z","author_association":"MEMBER","body":"cc @allencloud \r\n\r\nI think this is useful for P2P-style local registry API server such as Dragonfly or IPFS\r\n\r\n"}}
{"actor":{"display_login":"AkihiroSuda"}}