{"action":"closed","number":1829,"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/1829","id":185195766,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1MTk1NzY2","html_url":"https://github.com/theia-ide/theia/pull/1829","diff_url":"https://github.com/theia-ide/theia/pull/1829.diff","patch_url":"https://github.com/theia-ide/theia/pull/1829.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/1829","number":1829,"state":"closed","locked":false,"title":"[WIP] support multi-root workspace, the first step","user":{"login":"elaihau","id":37082801,"node_id":"MDQ6VXNlcjM3MDgyODAx","avatar_url":"https://avatars1.githubusercontent.com/u/37082801?v=4","gravatar_id":"","url":"https://api.github.com/users/elaihau","html_url":"https://github.com/elaihau","followers_url":"https://api.github.com/users/elaihau/followers","following_url":"https://api.github.com/users/elaihau/following{/other_user}","gists_url":"https://api.github.com/users/elaihau/gists{/gist_id}","starred_url":"https://api.github.com/users/elaihau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaihau/subscriptions","organizations_url":"https://api.github.com/users/elaihau/orgs","repos_url":"https://api.github.com/users/elaihau/repos","events_url":"https://api.github.com/users/elaihau/events{/privacy}","received_events_url":"https://api.github.com/users/elaihau/received_events","type":"User","site_admin":false},"body":"This PR is the initial step of #1660. I created this PR to get feedback from other contributors and have no intention to merge :)\r\n\r\n\r\nWorkspace Extension\r\n\r\n- \"add/remove folder\" options added to the right-click menu. \"remove folder\" shows up only when a root folder is selected.\r\n- rename workspace.root into workspace.activeRoot in Theia, so that extensions that are dependent on the value of workspace.root can still be built.\r\n- active root and roots are written into the config file under $HOME/.theia\r\n- associate one uuid with each theia client-side instance in order to support the scenario where multiple client-side instances are opened from different workspaces\r\n- save/load workspace config to/from a settings file\r\n\r\nFile navigator extension\r\n\r\n- introduced the \"Virtual root\" concept to display multiple roots\r\n- \"remove folder from workspace\" only shows up when a root is right clicked\r\n- \"reveal file\" highlights the file tree node that is closest to the workspace root\r\n\r\nGit extension:\r\n\r\n- user could switch to any repo in the multi-root workspace\r\n\r\nPreference extension:\r\n\r\n- added \"Workspace preference\", which has the highest priority, on top of the other 3. In other word, the \"workspace preferences\" would take precedence of the Root/Folder preferences, and User preferences.\r\n- When users go from a single root instance to multi-root workspace, theia would add Root/Folder preferences of the first folder to the new workspace preferences.\r\n- the workspace preferences would be stored in the workspace config file.\r\n\r\n Problems & missing pieces with this prototype, and challenges:\r\n\r\n- the folders are collapsed when a new root gets added to the workspace, or Theia gets reloaded. This is blocked by GH #1781 \r\n- performance of workspace service backend is not good enough. should use less file io.\r\n- for now only the file navigator extension, git extension, and preference extension are updated to adapt to changes made to workspace extension.  A few other extensions such as file-search, need change.\r\n- in vsCode users could change the \"active root\" from the git extension. In theia we could either has the \"vsCode-way\" of implementation, or completely get rid the concept of \"active root\". Which design is more preferable?\r\n- in vsCode users could either open a FOLDER or open a WORKSPACE. Do we want to consider \"opening a folder\" as \"opening a workspace that has only one root folder\"?\r\n ","created_at":"2018-05-01T14:55:23Z","updated_at":"2018-06-01T21:54:42Z","closed_at":"2018-06-01T21:54:42Z","merged_at":null,"merge_commit_sha":"fddc49c9e2f6d0ad2cbd0a598d1b10c8e097ab30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/1829/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/1829/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/1829/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/d83c3ae053cb3b1ae5551f4494c5bdb6cdce9cb6","head":{"label":"elaihau:T1660","ref":"T1660","sha":"d83c3ae053cb3b1ae5551f4494c5bdb6cdce9cb6","user":{"login":"elaihau","id":37082801,"node_id":"MDQ6VXNlcjM3MDgyODAx","avatar_url":"https://avatars1.githubusercontent.com/u/37082801?v=4","gravatar_id":"","url":"https://api.github.com/users/elaihau","html_url":"https://github.com/elaihau","followers_url":"https://api.github.com/users/elaihau/followers","following_url":"https://api.github.com/users/elaihau/following{/other_user}","gists_url":"https://api.github.com/users/elaihau/gists{/gist_id}","starred_url":"https://api.github.com/users/elaihau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaihau/subscriptions","organizations_url":"https://api.github.com/users/elaihau/orgs","repos_url":"https://api.github.com/users/elaihau/repos","events_url":"https://api.github.com/users/elaihau/events{/privacy}","received_events_url":"https://api.github.com/users/elaihau/received_events","type":"User","site_admin":false},"repo":{"id":124132590,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMzI1OTA=","name":"theia","full_name":"elaihau/theia","owner":{"login":"elaihau","id":37082801,"node_id":"MDQ6VXNlcjM3MDgyODAx","avatar_url":"https://avatars1.githubusercontent.com/u/37082801?v=4","gravatar_id":"","url":"https://api.github.com/users/elaihau","html_url":"https://github.com/elaihau","followers_url":"https://api.github.com/users/elaihau/followers","following_url":"https://api.github.com/users/elaihau/following{/other_user}","gists_url":"https://api.github.com/users/elaihau/gists{/gist_id}","starred_url":"https://api.github.com/users/elaihau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaihau/subscriptions","organizations_url":"https://api.github.com/users/elaihau/orgs","repos_url":"https://api.github.com/users/elaihau/repos","events_url":"https://api.github.com/users/elaihau/events{/privacy}","received_events_url":"https://api.github.com/users/elaihau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elaihau/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":true,"url":"https://api.github.com/repos/elaihau/theia","forks_url":"https://api.github.com/repos/elaihau/theia/forks","keys_url":"https://api.github.com/repos/elaihau/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elaihau/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elaihau/theia/teams","hooks_url":"https://api.github.com/repos/elaihau/theia/hooks","issue_events_url":"https://api.github.com/repos/elaihau/theia/issues/events{/number}","events_url":"https://api.github.com/repos/elaihau/theia/events","assignees_url":"https://api.github.com/repos/elaihau/theia/assignees{/user}","branches_url":"https://api.github.com/repos/elaihau/theia/branches{/branch}","tags_url":"https://api.github.com/repos/elaihau/theia/tags","blobs_url":"https://api.github.com/repos/elaihau/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elaihau/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elaihau/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/elaihau/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elaihau/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/elaihau/theia/languages","stargazers_url":"https://api.github.com/repos/elaihau/theia/stargazers","contributors_url":"https://api.github.com/repos/elaihau/theia/contributors","subscribers_url":"https://api.github.com/repos/elaihau/theia/subscribers","subscription_url":"https://api.github.com/repos/elaihau/theia/subscription","commits_url":"https://api.github.com/repos/elaihau/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/elaihau/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/elaihau/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/elaihau/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/elaihau/theia/contents/{+path}","compare_url":"https://api.github.com/repos/elaihau/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elaihau/theia/merges","archive_url":"https://api.github.com/repos/elaihau/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elaihau/theia/downloads","issues_url":"https://api.github.com/repos/elaihau/theia/issues{/number}","pulls_url":"https://api.github.com/repos/elaihau/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/elaihau/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/elaihau/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elaihau/theia/labels{/name}","releases_url":"https://api.github.com/repos/elaihau/theia/releases{/id}","deployments_url":"https://api.github.com/repos/elaihau/theia/deployments","created_at":"2018-03-06T20:11:22Z","updated_at":"2018-06-01T21:30:17Z","pushed_at":"2018-06-01T21:35:44Z","git_url":"git://github.com/elaihau/theia.git","ssh_url":"git@github.com:elaihau/theia.git","clone_url":"https://github.com/elaihau/theia.git","svn_url":"https://github.com/elaihau/theia","homepage":"http://theia-ide.org","size":105835,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"a2df2fafd8c98070f4e991e4cf9b1cb6162e8363","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-06-01T18:34:12Z","pushed_at":"2018-06-01T21:53:59Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":121008,"stargazers_count":778,"watchers_count":778,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":141,"open_issues":425,"watchers":778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1829"},"html":{"href":"https://github.com/theia-ide/theia/pull/1829"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/1829"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/1829/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1829/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1829/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/d83c3ae053cb3b1ae5551f4494c5bdb6cdce9cb6"}},"author_association":"COLLABORATOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1223,"deletions":226,"changed_files":43}}
{"actor":{"display_login":"elaihau"}}