{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/234458726","pull_request_review_id":176102758,"id":234458726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQ1ODcyNg==","diff_hunk":"@@ -70,10 +81,10 @@ void RPCtoDTTranslator::run(const edm::EventSetup& c) {\n      for( auto digi = (*chamber).second.first ; digi != (*chamber).second.second; ++digi ) {\n         if(detid.region()!=0 ) continue; //Region = 0 Barrel\n         if(BxToHit::outOfRange(digi->bx())) continue;\n-        if(detid.layer()==1) vrpc_hit_layer1.push_back({digi->bx(), detid.station(), detid.sector(), detid.ring(), detid, digi->strip(), detid.roll(), detid.layer()});\n-        if(detid.station()==3) vrpc_hit_st3.push_back({digi->bx(), detid.station(), detid.sector(), detid.ring(), detid, digi->strip(), detid.roll(), detid.layer()});\n-        if(detid.layer()==2) vrpc_hit_layer2.push_back({digi->bx(), detid.station(), detid.sector(), detid.ring(), detid, digi->strip(), detid.roll(), detid.layer()});\n-        if(detid.station()==4) vrpc_hit_st4.push_back({digi->bx(), detid.station(), detid.sector(), detid.ring(), detid, digi->strip(), detid.roll(), detid.layer()});\n+        if(detid.layer()==1) vrpc_hit_layer1.emplace_back(digi->bx(), detid.station(), detid.sector(), detid.ring(), detid, digi->strip(), detid.roll(), detid.layer());","path":"L1Trigger/L1TTwinMux/src/RPCtoDTTranslator.cc","position":42,"original_position":42,"commit_id":"29a8a53f561d3b66fec6218414c607d89e9162ae","original_commit_id":"29a8a53f561d3b66fec6218414c607d89e9162ae","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"`emplace_back` avoids the need to create a temporary and then copy it.","created_at":"2018-11-18T19:43:44Z","updated_at":"2018-11-18T19:44:09Z","html_url":"https://github.com/cms-sw/cmssw/pull/25275#discussion_r234458726","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/234458726"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/25275#discussion_r234458726"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275","id":231803014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODAzMDE0","html_url":"https://github.com/cms-sw/cmssw/pull/25275","diff_url":"https://github.com/cms-sw/cmssw/pull/25275.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25275.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25275","number":25275,"state":"open","locked":false,"title":"Fix RPCtoDTTranslator","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"Fixed a crash in RPCtoDTTranslator (the first commit)\r\nAlso did code improvements to the package, including one case where the orginal code would have lead to a crash.","created_at":"2018-11-18T17:53:24Z","updated_at":"2018-11-18T19:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3feab50c6eb0ef17509955925202afb1cfc9f85b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820587,"node_id":"MDU6TGFiZWw1MjgyMDU4Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":170521617,"node_id":"MDU6TGFiZWwxNzA1MjE2MTc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78","html_url":"https://github.com/cms-sw/cmssw/milestone/78","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78/labels","id":3727036,"node_id":"MDk6TWlsZXN0b25lMzcyNzAzNg==","number":78,"title":"CMSSW_10_4_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":276,"state":"open","created_at":"2018-10-10T09:27:21Z","updated_at":"2018-11-18T18:39:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25275/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/29a8a53f561d3b66fec6218414c607d89e9162ae","head":{"label":"Dr15Jones:fixRPCtoDTTranslator","ref":"fixRPCtoDTTranslator","sha":"29a8a53f561d3b66fec6218414c607d89e9162ae","user":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"repo":{"id":10974606,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3NDYwNg==","name":"cmssw","full_name":"Dr15Jones/cmssw","private":false,"owner":{"login":"Dr15Jones","id":3757616,"node_id":"MDQ6VXNlcjM3NTc2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Dr15Jones/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/Dr15Jones/cmssw","forks_url":"https://api.github.com/repos/Dr15Jones/cmssw/forks","keys_url":"https://api.github.com/repos/Dr15Jones/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dr15Jones/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dr15Jones/cmssw/teams","hooks_url":"https://api.github.com/repos/Dr15Jones/cmssw/hooks","issue_events_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/Dr15Jones/cmssw/events","assignees_url":"https://api.github.com/repos/Dr15Jones/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/Dr15Jones/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/Dr15Jones/cmssw/tags","blobs_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dr15Jones/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/Dr15Jones/cmssw/languages","stargazers_url":"https://api.github.com/repos/Dr15Jones/cmssw/stargazers","contributors_url":"https://api.github.com/repos/Dr15Jones/cmssw/contributors","subscribers_url":"https://api.github.com/repos/Dr15Jones/cmssw/subscribers","subscription_url":"https://api.github.com/repos/Dr15Jones/cmssw/subscription","commits_url":"https://api.github.com/repos/Dr15Jones/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dr15Jones/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dr15Jones/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/Dr15Jones/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dr15Jones/cmssw/merges","archive_url":"https://api.github.com/repos/Dr15Jones/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dr15Jones/cmssw/downloads","issues_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/Dr15Jones/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/Dr15Jones/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/Dr15Jones/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dr15Jones/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/Dr15Jones/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/Dr15Jones/cmssw/deployments","created_at":"2013-06-26T17:40:38Z","updated_at":"2018-11-12T17:26:53Z","pushed_at":"2018-11-18T17:52:04Z","git_url":"git://github.com/Dr15Jones/cmssw.git","ssh_url":"git@github.com:Dr15Jones/cmssw.git","clone_url":"https://github.com/Dr15Jones/cmssw.git","svn_url":"https://github.com/Dr15Jones/cmssw","homepage":null,"size":914547,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"e33a0d8f58bdaaff6389a2a010df3a728819dbb2","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","private":false,"owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-11-18T09:46:31Z","pushed_at":"2018-11-18T18:39:11Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1044466,"stargazers_count":595,"watchers_count":595,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2754,"mirror_url":null,"archived":false,"open_issues_count":469,"license":null,"forks":2754,"open_issues":469,"watchers":595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/25275"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/25275"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/25275/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/25275/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/29a8a53f561d3b66fec6218414c607d89e9162ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dr15Jones"}}