{"action":"created","issue":{"url":"https://api.github.com/repos/airbnb/epoxy/issues/502","repository_url":"https://api.github.com/repos/airbnb/epoxy","labels_url":"https://api.github.com/repos/airbnb/epoxy/issues/502/labels{/name}","comments_url":"https://api.github.com/repos/airbnb/epoxy/issues/502/comments","events_url":"https://api.github.com/repos/airbnb/epoxy/issues/502/events","html_url":"https://github.com/airbnb/epoxy/issues/502","id":352367780,"node_id":"MDU6SXNzdWUzNTIzNjc3ODA=","number":502,"title":"Data binding not updating listener variables on bind","user":{"login":"chrisbanes","id":227486,"node_id":"MDQ6VXNlcjIyNzQ4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/227486?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisbanes","html_url":"https://github.com/chrisbanes","followers_url":"https://api.github.com/users/chrisbanes/followers","following_url":"https://api.github.com/users/chrisbanes/following{/other_user}","gists_url":"https://api.github.com/users/chrisbanes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbanes/subscriptions","organizations_url":"https://api.github.com/users/chrisbanes/orgs","repos_url":"https://api.github.com/users/chrisbanes/repos","events_url":"https://api.github.com/users/chrisbanes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbanes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-21T03:02:25Z","updated_at":"2018-08-23T15:05:34Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I wanted to open this issue since I don't really understand why the some of the data binding `setDataBindingVariables()` logic is implemented as:\r\n\r\n``` java\r\nif (((popupMenuListener == null) != (that.popupMenuListener == null))) {\r\n  binding.setVariable(BR.popupMenuListener, popupMenuListener);\r\n}\r\n```\r\n\r\nI'm guessing it is implicitly using `EpoxyAttribute(NoHash)` on my behalf.\r\n\r\nAnyway my issue is that the listener is never updated on rebinds. Surely if a variable is set, it should be set on the binding. If the items are equals/==hashCode then sure don't update the binding, but the default should always be to set the binding.\r\n\r\nAt the moment it only updates the binding if the value goes from null to non-null and vice-versa, which is just confusing IMO.\r\n"},"comment":{"url":"https://api.github.com/repos/airbnb/epoxy/issues/comments/415451883","html_url":"https://github.com/airbnb/epoxy/issues/502#issuecomment-415451883","issue_url":"https://api.github.com/repos/airbnb/epoxy/issues/502","id":415451883,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTQ1MTg4Mw==","user":{"login":"elihart","id":2739242,"node_id":"MDQ6VXNlcjI3MzkyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2739242?v=4","gravatar_id":"","url":"https://api.github.com/users/elihart","html_url":"https://github.com/elihart","followers_url":"https://api.github.com/users/elihart/followers","following_url":"https://api.github.com/users/elihart/following{/other_user}","gists_url":"https://api.github.com/users/elihart/gists{/gist_id}","starred_url":"https://api.github.com/users/elihart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elihart/subscriptions","organizations_url":"https://api.github.com/users/elihart/orgs","repos_url":"https://api.github.com/users/elihart/repos","events_url":"https://api.github.com/users/elihart/events{/privacy}","received_events_url":"https://api.github.com/users/elihart/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T15:05:34Z","updated_at":"2018-08-23T15:05:34Z","author_association":"CONTRIBUTOR","body":"Sure, that would work I think. That's basically what the `OnModelClickListener` is already doing"}}
{"actor":{"display_login":"elihart"}}