{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/220176994","pull_request_review_id":158521706,"id":220176994,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDE3Njk5NA==","diff_hunk":"@@ -52,6 +52,12 @@ protected function processValue($value, $isRoot = false)\n             if (!$v instanceof Reference) {\n                 throw new InvalidArgumentException(sprintf('Invalid definition for service \"%s\": an array of references is expected as first argument when the \"container.service_locator\" tag is set, \"%s\" found for key \"%s\".', $this->currentId, \\is_object($v) ? \\get_class($v) : \\gettype($v), $k));\n             }\n+\n+            if (\\is_int($k)) {\n+                unset($arguments[0][$k]);\n+\n+                $k = (string) $v;","path":"src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php","position":8,"original_position":8,"commit_id":"55e1075ce1091495112877473768f50f3cf32333","original_commit_id":"55e1075ce1091495112877473768f50f3cf32333","user":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"I'm not sure: if the key exists *after* the numbered one, it will override it - and if it came before, then the numbered one should win to me. works for you also?","created_at":"2018-09-25T12:47:19Z","updated_at":"2018-09-25T12:47:19Z","html_url":"https://github.com/symfony/symfony/pull/28571#discussion_r220176994","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/28571","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/220176994"},"html":{"href":"https://github.com/symfony/symfony/pull/28571#discussion_r220176994"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28571"}},"in_reply_to_id":220174944},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28571","id":217528061,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTI4MDYx","html_url":"https://github.com/symfony/symfony/pull/28571","diff_url":"https://github.com/symfony/symfony/pull/28571.diff","patch_url":"https://github.com/symfony/symfony/pull/28571.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28571","number":28571,"state":"open","locked":false,"title":"[DependencyInjection] Improve ServiceLocatorTagPass service matching","user":{"login":"codedmonkey","id":203651,"node_id":"MDQ6VXNlcjIwMzY1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/203651?v=4","gravatar_id":"","url":"https://api.github.com/users/codedmonkey","html_url":"https://github.com/codedmonkey","followers_url":"https://api.github.com/users/codedmonkey/followers","following_url":"https://api.github.com/users/codedmonkey/following{/other_user}","gists_url":"https://api.github.com/users/codedmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/codedmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codedmonkey/subscriptions","organizations_url":"https://api.github.com/users/codedmonkey/orgs","repos_url":"https://api.github.com/users/codedmonkey/repos","events_url":"https://api.github.com/users/codedmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/codedmonkey/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #26892\r\n| License       | MIT\r\n| Doc PR        | https://github.com/symfony/symfony-docs/pull/10397\r\n\r\nAllows omitting of keys for service locator arguments (it will automatically take over the original definition alias).","created_at":"2018-09-23T20:01:19Z","updated_at":"2018-09-25T12:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27f9c72f0a6f82875677baec24b9523882f9a66b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":99863,"node_id":"MDU6TGFiZWw5OTg2Mw==","url":"https://api.github.com/repos/symfony/symfony/labels/DependencyInjection","name":"DependencyInjection","color":"DDDDDD","default":false},{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237550465,"node_id":"MDU6TGFiZWwyMzc1NTA0NjU=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":147,"closed_issues":263,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-09-25T09:54:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/28571/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/28571/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28571/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/55e1075ce1091495112877473768f50f3cf32333","head":{"label":"codedmonkey:service-locator","ref":"service-locator","sha":"55e1075ce1091495112877473768f50f3cf32333","user":{"login":"codedmonkey","id":203651,"node_id":"MDQ6VXNlcjIwMzY1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/203651?v=4","gravatar_id":"","url":"https://api.github.com/users/codedmonkey","html_url":"https://github.com/codedmonkey","followers_url":"https://api.github.com/users/codedmonkey/followers","following_url":"https://api.github.com/users/codedmonkey/following{/other_user}","gists_url":"https://api.github.com/users/codedmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/codedmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codedmonkey/subscriptions","organizations_url":"https://api.github.com/users/codedmonkey/orgs","repos_url":"https://api.github.com/users/codedmonkey/repos","events_url":"https://api.github.com/users/codedmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/codedmonkey/received_events","type":"User","site_admin":false},"repo":{"id":125917460,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU5MTc0NjA=","name":"symfony","full_name":"codedmonkey/symfony","private":false,"owner":{"login":"codedmonkey","id":203651,"node_id":"MDQ6VXNlcjIwMzY1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/203651?v=4","gravatar_id":"","url":"https://api.github.com/users/codedmonkey","html_url":"https://github.com/codedmonkey","followers_url":"https://api.github.com/users/codedmonkey/followers","following_url":"https://api.github.com/users/codedmonkey/following{/other_user}","gists_url":"https://api.github.com/users/codedmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/codedmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codedmonkey/subscriptions","organizations_url":"https://api.github.com/users/codedmonkey/orgs","repos_url":"https://api.github.com/users/codedmonkey/repos","events_url":"https://api.github.com/users/codedmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/codedmonkey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/codedmonkey/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/codedmonkey/symfony","forks_url":"https://api.github.com/repos/codedmonkey/symfony/forks","keys_url":"https://api.github.com/repos/codedmonkey/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codedmonkey/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codedmonkey/symfony/teams","hooks_url":"https://api.github.com/repos/codedmonkey/symfony/hooks","issue_events_url":"https://api.github.com/repos/codedmonkey/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/codedmonkey/symfony/events","assignees_url":"https://api.github.com/repos/codedmonkey/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/codedmonkey/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/codedmonkey/symfony/tags","blobs_url":"https://api.github.com/repos/codedmonkey/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codedmonkey/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codedmonkey/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/codedmonkey/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codedmonkey/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/codedmonkey/symfony/languages","stargazers_url":"https://api.github.com/repos/codedmonkey/symfony/stargazers","contributors_url":"https://api.github.com/repos/codedmonkey/symfony/contributors","subscribers_url":"https://api.github.com/repos/codedmonkey/symfony/subscribers","subscription_url":"https://api.github.com/repos/codedmonkey/symfony/subscription","commits_url":"https://api.github.com/repos/codedmonkey/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/codedmonkey/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/codedmonkey/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/codedmonkey/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/codedmonkey/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/codedmonkey/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codedmonkey/symfony/merges","archive_url":"https://api.github.com/repos/codedmonkey/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codedmonkey/symfony/downloads","issues_url":"https://api.github.com/repos/codedmonkey/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/codedmonkey/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/codedmonkey/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/codedmonkey/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codedmonkey/symfony/labels{/name}","releases_url":"https://api.github.com/repos/codedmonkey/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/codedmonkey/symfony/deployments","created_at":"2018-03-19T20:39:25Z","updated_at":"2018-03-19T20:39:44Z","pushed_at":"2018-09-24T19:13:32Z","git_url":"git://github.com/codedmonkey/symfony.git","ssh_url":"git@github.com:codedmonkey/symfony.git","clone_url":"https://github.com/codedmonkey/symfony.git","svn_url":"https://github.com/codedmonkey/symfony","homepage":"https://symfony.com","size":120133,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"3d2124e12874e6d55ce4922956e0ef9fda9f794c","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-09-25T09:54:22Z","pushed_at":"2018-09-25T12:40:45Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":125217,"stargazers_count":18651,"watchers_count":18651,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6409,"mirror_url":null,"archived":false,"open_issues_count":832,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6409,"open_issues":832,"watchers":18651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28571"},"html":{"href":"https://github.com/symfony/symfony/pull/28571"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/28571"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/28571/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28571/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28571/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/55e1075ce1091495112877473768f50f3cf32333"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nicolas-grekas"}}