{"action":"closed","number":232,"pull_request":{"url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/232","id":207769397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzY5Mzk3","html_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing/pull/232","diff_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing/pull/232.diff","patch_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing/pull/232.patch","issue_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/232","number":232,"state":"closed","locked":false,"title":"Return to being totally lenient on text decoding","user":{"login":"Mr0grog","id":74178,"node_id":"MDQ6VXNlcjc0MTc4","avatar_url":"https://avatars0.githubusercontent.com/u/74178?v=4","gravatar_id":"","url":"https://api.github.com/users/Mr0grog","html_url":"https://github.com/Mr0grog","followers_url":"https://api.github.com/users/Mr0grog/followers","following_url":"https://api.github.com/users/Mr0grog/following{/other_user}","gists_url":"https://api.github.com/users/Mr0grog/gists{/gist_id}","starred_url":"https://api.github.com/users/Mr0grog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mr0grog/subscriptions","organizations_url":"https://api.github.com/users/Mr0grog/orgs","repos_url":"https://api.github.com/users/Mr0grog/repos","events_url":"https://api.github.com/users/Mr0grog/events{/privacy}","received_events_url":"https://api.github.com/users/Mr0grog/received_events","type":"User","site_admin":false},"body":"This removes the `?ignore_decoding_errors` query param and changes the behavior to never raise exceptions when there are text decoding problems in the diffing server (instead, we just replace the error with the unicode \"REPLACEMENT CHARACTER\" character, like a browser generally would).\r\n\r\nThis winds up partially reverting #155 and removing one of our protections against incorrectly trying to diff large binary blobs, but the other content sniffing logic added in #155 is still there and should hopefully be a good enough solution to that problem. The reality is that there's lots of content on the web with actual encoding errors, and we still need to be able to diff it. To do that, the UI would have turned on `ignore_decoding_errors` all the time anyway, so it was probably a pointless switch to have.\r\n\r\nFixes #203.\r\n\r\n@danielballan I left the `UndecodableContentError` type in there, but it’s totally vestigial now. Since we’ve waffled back and forth on this, I thought it might be useful to keep, but if you think it’s just confusing cruft, I’ll pull it out.","created_at":"2018-08-11T10:45:43Z","updated_at":"2018-08-14T17:53:57Z","closed_at":"2018-08-14T17:53:57Z","merged_at":"2018-08-14T17:53:56Z","merge_commit_sha":"ad4accfa453f623359522fe127f03aed360336a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielballan","id":2279598,"node_id":"MDQ6VXNlcjIyNzk1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2279598?v=4","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659133385,"node_id":"MDU6TGFiZWw2NTkxMzMzODU=","url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/232/commits","review_comments_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/232/comments","review_comment_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/232/comments","statuses_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/statuses/de798004dc82cd83b0f7922414194a18ebeccb00","head":{"label":"edgi-govdata-archiving:203-give-up-on-strict-decoding-and-partially-revert-155","ref":"203-give-up-on-strict-decoding-and-partially-revert-155","sha":"de798004dc82cd83b0f7922414194a18ebeccb00","user":{"login":"edgi-govdata-archiving","id":24626991,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjI2OTkx","avatar_url":"https://avatars0.githubusercontent.com/u/24626991?v=4","gravatar_id":"","url":"https://api.github.com/users/edgi-govdata-archiving","html_url":"https://github.com/edgi-govdata-archiving","followers_url":"https://api.github.com/users/edgi-govdata-archiving/followers","following_url":"https://api.github.com/users/edgi-govdata-archiving/following{/other_user}","gists_url":"https://api.github.com/users/edgi-govdata-archiving/gists{/gist_id}","starred_url":"https://api.github.com/users/edgi-govdata-archiving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgi-govdata-archiving/subscriptions","organizations_url":"https://api.github.com/users/edgi-govdata-archiving/orgs","repos_url":"https://api.github.com/users/edgi-govdata-archiving/repos","events_url":"https://api.github.com/users/edgi-govdata-archiving/events{/privacy}","received_events_url":"https://api.github.com/users/edgi-govdata-archiving/received_events","type":"Organization","site_admin":false},"repo":{"id":83559947,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU1OTk0Nw==","name":"web-monitoring-processing","full_name":"edgi-govdata-archiving/web-monitoring-processing","owner":{"login":"edgi-govdata-archiving","id":24626991,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjI2OTkx","avatar_url":"https://avatars0.githubusercontent.com/u/24626991?v=4","gravatar_id":"","url":"https://api.github.com/users/edgi-govdata-archiving","html_url":"https://github.com/edgi-govdata-archiving","followers_url":"https://api.github.com/users/edgi-govdata-archiving/followers","following_url":"https://api.github.com/users/edgi-govdata-archiving/following{/other_user}","gists_url":"https://api.github.com/users/edgi-govdata-archiving/gists{/gist_id}","starred_url":"https://api.github.com/users/edgi-govdata-archiving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgi-govdata-archiving/subscriptions","organizations_url":"https://api.github.com/users/edgi-govdata-archiving/orgs","repos_url":"https://api.github.com/users/edgi-govdata-archiving/repos","events_url":"https://api.github.com/users/edgi-govdata-archiving/events{/privacy}","received_events_url":"https://api.github.com/users/edgi-govdata-archiving/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing","description":"Data processing, PageFreezer integration, and (eventually) diff filtering and processing","fork":false,"url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing","forks_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/forks","keys_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/teams","hooks_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/hooks","issue_events_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/events{/number}","events_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/events","assignees_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/assignees{/user}","branches_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/branches{/branch}","tags_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/tags","blobs_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/statuses/{sha}","languages_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/languages","stargazers_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/stargazers","contributors_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/contributors","subscribers_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/subscribers","subscription_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/subscription","commits_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/contents/{+path}","compare_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/merges","archive_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/downloads","issues_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues{/number}","pulls_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls{/number}","milestones_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/milestones{/number}","notifications_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/labels{/name}","releases_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/releases{/id}","deployments_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/deployments","created_at":"2017-03-01T13:54:56Z","updated_at":"2018-08-13T18:20:57Z","pushed_at":"2018-08-14T17:53:56Z","git_url":"git://github.com/edgi-govdata-archiving/web-monitoring-processing.git","ssh_url":"git@github.com:edgi-govdata-archiving/web-monitoring-processing.git","clone_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing.git","svn_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing","homepage":"","size":2673,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":66,"watchers":8,"default_branch":"master"}},"base":{"label":"edgi-govdata-archiving:master","ref":"master","sha":"33e99ee686c87df0254ef071a53d7c74dda1e457","user":{"login":"edgi-govdata-archiving","id":24626991,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjI2OTkx","avatar_url":"https://avatars0.githubusercontent.com/u/24626991?v=4","gravatar_id":"","url":"https://api.github.com/users/edgi-govdata-archiving","html_url":"https://github.com/edgi-govdata-archiving","followers_url":"https://api.github.com/users/edgi-govdata-archiving/followers","following_url":"https://api.github.com/users/edgi-govdata-archiving/following{/other_user}","gists_url":"https://api.github.com/users/edgi-govdata-archiving/gists{/gist_id}","starred_url":"https://api.github.com/users/edgi-govdata-archiving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgi-govdata-archiving/subscriptions","organizations_url":"https://api.github.com/users/edgi-govdata-archiving/orgs","repos_url":"https://api.github.com/users/edgi-govdata-archiving/repos","events_url":"https://api.github.com/users/edgi-govdata-archiving/events{/privacy}","received_events_url":"https://api.github.com/users/edgi-govdata-archiving/received_events","type":"Organization","site_admin":false},"repo":{"id":83559947,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU1OTk0Nw==","name":"web-monitoring-processing","full_name":"edgi-govdata-archiving/web-monitoring-processing","owner":{"login":"edgi-govdata-archiving","id":24626991,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NjI2OTkx","avatar_url":"https://avatars0.githubusercontent.com/u/24626991?v=4","gravatar_id":"","url":"https://api.github.com/users/edgi-govdata-archiving","html_url":"https://github.com/edgi-govdata-archiving","followers_url":"https://api.github.com/users/edgi-govdata-archiving/followers","following_url":"https://api.github.com/users/edgi-govdata-archiving/following{/other_user}","gists_url":"https://api.github.com/users/edgi-govdata-archiving/gists{/gist_id}","starred_url":"https://api.github.com/users/edgi-govdata-archiving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgi-govdata-archiving/subscriptions","organizations_url":"https://api.github.com/users/edgi-govdata-archiving/orgs","repos_url":"https://api.github.com/users/edgi-govdata-archiving/repos","events_url":"https://api.github.com/users/edgi-govdata-archiving/events{/privacy}","received_events_url":"https://api.github.com/users/edgi-govdata-archiving/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing","description":"Data processing, PageFreezer integration, and (eventually) diff filtering and processing","fork":false,"url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing","forks_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/forks","keys_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/teams","hooks_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/hooks","issue_events_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/events{/number}","events_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/events","assignees_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/assignees{/user}","branches_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/branches{/branch}","tags_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/tags","blobs_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/statuses/{sha}","languages_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/languages","stargazers_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/stargazers","contributors_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/contributors","subscribers_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/subscribers","subscription_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/subscription","commits_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/contents/{+path}","compare_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/merges","archive_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/downloads","issues_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues{/number}","pulls_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls{/number}","milestones_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/milestones{/number}","notifications_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/labels{/name}","releases_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/releases{/id}","deployments_url":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/deployments","created_at":"2017-03-01T13:54:56Z","updated_at":"2018-08-13T18:20:57Z","pushed_at":"2018-08-14T17:53:56Z","git_url":"git://github.com/edgi-govdata-archiving/web-monitoring-processing.git","ssh_url":"git@github.com:edgi-govdata-archiving/web-monitoring-processing.git","clone_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing.git","svn_url":"https://github.com/edgi-govdata-archiving/web-monitoring-processing","homepage":"","size":2673,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":66,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/232"},"html":{"href":"https://github.com/edgi-govdata-archiving/web-monitoring-processing/pull/232"},"issue":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/232"},"comments":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/edgi-govdata-archiving/web-monitoring-processing/statuses/de798004dc82cd83b0f7922414194a18ebeccb00"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danielballan","id":2279598,"node_id":"MDQ6VXNlcjIyNzk1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2279598?v=4","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":40,"changed_files":3}}
{"actor":{"display_login":"danielballan"}}