{"action":"created","issue":{"url":"https://api.github.com/repos/skuschel/postpic/issues/190","repository_url":"https://api.github.com/repos/skuschel/postpic","labels_url":"https://api.github.com/repos/skuschel/postpic/issues/190/labels{/name}","comments_url":"https://api.github.com/repos/skuschel/postpic/issues/190/comments","events_url":"https://api.github.com/repos/skuschel/postpic/issues/190/events","html_url":"https://github.com/skuschel/postpic/pull/190","id":389466552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDUwNDg4","number":190,"title":"Field: added method evaluate()","user":{"login":"Ablinne","id":7170853,"node_id":"MDQ6VXNlcjcxNzA4NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7170853?v=4","gravatar_id":"","url":"https://api.github.com/users/Ablinne","html_url":"https://github.com/Ablinne","followers_url":"https://api.github.com/users/Ablinne/followers","following_url":"https://api.github.com/users/Ablinne/following{/other_user}","gists_url":"https://api.github.com/users/Ablinne/gists{/gist_id}","starred_url":"https://api.github.com/users/Ablinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ablinne/subscriptions","organizations_url":"https://api.github.com/users/Ablinne/orgs","repos_url":"https://api.github.com/users/Ablinne/repos","events_url":"https://api.github.com/users/Ablinne/events{/privacy}","received_events_url":"https://api.github.com/users/Ablinne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-10T20:09:56Z","updated_at":"2018-12-11T01:52:08Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/skuschel/postpic/pulls/190","html_url":"https://github.com/skuschel/postpic/pull/190","diff_url":"https://github.com/skuschel/postpic/pull/190.diff","patch_url":"https://github.com/skuschel/postpic/pull/190.patch"},"body":"This introduces a new method `evaluate()` for `Field`, which evaluates the expression `ex` using `NumExpr` and returns a field containing the result.\r\n        This copies all metadata from `self` and just replaces the matrix.\r\n\r\nThis function is basically syntactic sugar simplifying\r\n\r\n        field.replace_data(ne.evaluate(expr))\r\n\r\nto\r\n\r\n        field.evaluate(expr)\r\n\r\nThis method replicates some logic from NumExpr.necompiler.getArguments(), seems\r\n        there is no way around it."},"comment":{"url":"https://api.github.com/repos/skuschel/postpic/issues/comments/446042859","html_url":"https://github.com/skuschel/postpic/pull/190#issuecomment-446042859","issue_url":"https://api.github.com/repos/skuschel/postpic/issues/190","id":446042859,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjA0Mjg1OQ==","user":{"login":"skuschel","id":6304649,"node_id":"MDQ6VXNlcjYzMDQ2NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6304649?v=4","gravatar_id":"","url":"https://api.github.com/users/skuschel","html_url":"https://github.com/skuschel","followers_url":"https://api.github.com/users/skuschel/followers","following_url":"https://api.github.com/users/skuschel/following{/other_user}","gists_url":"https://api.github.com/users/skuschel/gists{/gist_id}","starred_url":"https://api.github.com/users/skuschel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skuschel/subscriptions","organizations_url":"https://api.github.com/users/skuschel/orgs","repos_url":"https://api.github.com/users/skuschel/repos","events_url":"https://api.github.com/users/skuschel/events{/privacy}","received_events_url":"https://api.github.com/users/skuschel/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T01:52:08Z","updated_at":"2018-12-11T01:52:08Z","author_association":"OWNER","body":"Oh fancy! Um ehrlich zu sein, habe ich mich immer gefragt, wie numexpr das macht, dass es innerhalb einer funktion auf die Variablen ausserhalb der Funktion zugreift... :smiley: \r\n\r\nIch finds super -- das sieht wirklich nach Zeitersparnis aus. Allerdings finde ich den Funktionsnamen `evaluate` nicht so guenstig. Das erweckt den Eindruck dass das Ergebnis zurueckgegeben wird (wie bei numexp). Was haelst du von `replace_evaluate` oder `replace_eval`?"}}
{"actor":{"display_login":"skuschel"}}