{"action":"opened","number":260,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/260","id":192496563,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNDk2NTYz","html_url":"https://github.com/puppetlabs/vmpooler/pull/260","diff_url":"https://github.com/puppetlabs/vmpooler/pull/260.diff","patch_url":"https://github.com/puppetlabs/vmpooler/pull/260.patch","issue_url":"https://api.github.com/repos/puppetlabs/vmpooler/issues/260","number":260,"state":"open","locked":false,"title":"Remove propertyCollector from add_disk","user":{"login":"mattkirby","id":3004602,"node_id":"MDQ6VXNlcjMwMDQ2MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3004602?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkirby","html_url":"https://github.com/mattkirby","followers_url":"https://api.github.com/users/mattkirby/followers","following_url":"https://api.github.com/users/mattkirby/following{/other_user}","gists_url":"https://api.github.com/users/mattkirby/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkirby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkirby/subscriptions","organizations_url":"https://api.github.com/users/mattkirby/orgs","repos_url":"https://api.github.com/users/mattkirby/repos","events_url":"https://api.github.com/users/mattkirby/events{/privacy}","received_events_url":"https://api.github.com/users/mattkirby/received_events","type":"User","site_admin":false},"body":"This commit updates add_disk to remove propertyCollector, which was used\r\nto back the find_vmdks method to locate the disk file on datastore and\r\nthen use its length to name the new disk. Instead, the number of disks\r\non the VM is used to ensure a unique disk resource title. Without this\r\nchange add_disk can take 10-50x longer due to the propertyCollector\r\nmethod. Additionally, without this change propertyCollector is used in a\r\nnon threadsafe manner, which may cause stability issues for vsphere\r\nprovider backends.","created_at":"2018-06-04T18:52:57Z","updated_at":"2018-06-04T18:52:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196936768,"node_id":"MDU6TGFiZWwxOTY5MzY3Njg=","url":"https://api.github.com/repos/puppetlabs/vmpooler/labels/awaiting%20review","name":"awaiting review","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/260/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/260/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/vmpooler/issues/260/comments","statuses_url":"https://api.github.com/repos/puppetlabs/vmpooler/statuses/d1ae85c8af3df2ad397f929b2fed40bea3a974f4","head":{"label":"mattkirby:fix_check_disk","ref":"fix_check_disk","sha":"d1ae85c8af3df2ad397f929b2fed40bea3a974f4","user":{"login":"mattkirby","id":3004602,"node_id":"MDQ6VXNlcjMwMDQ2MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3004602?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkirby","html_url":"https://github.com/mattkirby","followers_url":"https://api.github.com/users/mattkirby/followers","following_url":"https://api.github.com/users/mattkirby/following{/other_user}","gists_url":"https://api.github.com/users/mattkirby/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkirby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkirby/subscriptions","organizations_url":"https://api.github.com/users/mattkirby/orgs","repos_url":"https://api.github.com/users/mattkirby/repos","events_url":"https://api.github.com/users/mattkirby/events{/privacy}","received_events_url":"https://api.github.com/users/mattkirby/received_events","type":"User","site_admin":false},"repo":{"id":62260860,"node_id":"MDEwOlJlcG9zaXRvcnk2MjI2MDg2MA==","name":"vmpooler","full_name":"mattkirby/vmpooler","owner":{"login":"mattkirby","id":3004602,"node_id":"MDQ6VXNlcjMwMDQ2MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3004602?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkirby","html_url":"https://github.com/mattkirby","followers_url":"https://api.github.com/users/mattkirby/followers","following_url":"https://api.github.com/users/mattkirby/following{/other_user}","gists_url":"https://api.github.com/users/mattkirby/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkirby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkirby/subscriptions","organizations_url":"https://api.github.com/users/mattkirby/orgs","repos_url":"https://api.github.com/users/mattkirby/repos","events_url":"https://api.github.com/users/mattkirby/events{/privacy}","received_events_url":"https://api.github.com/users/mattkirby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattkirby/vmpooler","description":"Provide configurable 'pools' of instantly-available (running) virtual machines","fork":true,"url":"https://api.github.com/repos/mattkirby/vmpooler","forks_url":"https://api.github.com/repos/mattkirby/vmpooler/forks","keys_url":"https://api.github.com/repos/mattkirby/vmpooler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattkirby/vmpooler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattkirby/vmpooler/teams","hooks_url":"https://api.github.com/repos/mattkirby/vmpooler/hooks","issue_events_url":"https://api.github.com/repos/mattkirby/vmpooler/issues/events{/number}","events_url":"https://api.github.com/repos/mattkirby/vmpooler/events","assignees_url":"https://api.github.com/repos/mattkirby/vmpooler/assignees{/user}","branches_url":"https://api.github.com/repos/mattkirby/vmpooler/branches{/branch}","tags_url":"https://api.github.com/repos/mattkirby/vmpooler/tags","blobs_url":"https://api.github.com/repos/mattkirby/vmpooler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattkirby/vmpooler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattkirby/vmpooler/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattkirby/vmpooler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattkirby/vmpooler/statuses/{sha}","languages_url":"https://api.github.com/repos/mattkirby/vmpooler/languages","stargazers_url":"https://api.github.com/repos/mattkirby/vmpooler/stargazers","contributors_url":"https://api.github.com/repos/mattkirby/vmpooler/contributors","subscribers_url":"https://api.github.com/repos/mattkirby/vmpooler/subscribers","subscription_url":"https://api.github.com/repos/mattkirby/vmpooler/subscription","commits_url":"https://api.github.com/repos/mattkirby/vmpooler/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattkirby/vmpooler/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattkirby/vmpooler/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattkirby/vmpooler/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattkirby/vmpooler/contents/{+path}","compare_url":"https://api.github.com/repos/mattkirby/vmpooler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattkirby/vmpooler/merges","archive_url":"https://api.github.com/repos/mattkirby/vmpooler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattkirby/vmpooler/downloads","issues_url":"https://api.github.com/repos/mattkirby/vmpooler/issues{/number}","pulls_url":"https://api.github.com/repos/mattkirby/vmpooler/pulls{/number}","milestones_url":"https://api.github.com/repos/mattkirby/vmpooler/milestones{/number}","notifications_url":"https://api.github.com/repos/mattkirby/vmpooler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattkirby/vmpooler/labels{/name}","releases_url":"https://api.github.com/repos/mattkirby/vmpooler/releases{/id}","deployments_url":"https://api.github.com/repos/mattkirby/vmpooler/deployments","created_at":"2016-06-29T22:02:59Z","updated_at":"2018-05-30T19:17:43Z","pushed_at":"2018-06-04T18:52:02Z","git_url":"git://github.com/mattkirby/vmpooler.git","ssh_url":"git@github.com:mattkirby/vmpooler.git","clone_url":"https://github.com/mattkirby/vmpooler.git","svn_url":"https://github.com/mattkirby/vmpooler","homepage":"","size":1945,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9b8b35395d6dfeefd72525a92a8fd6d0fb2844c0","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":13072980,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3Mjk4MA==","name":"vmpooler","full_name":"puppetlabs/vmpooler","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/vmpooler","description":"Provide configurable 'pools' of instantly-available (running) virtual machines","fork":false,"url":"https://api.github.com/repos/puppetlabs/vmpooler","forks_url":"https://api.github.com/repos/puppetlabs/vmpooler/forks","keys_url":"https://api.github.com/repos/puppetlabs/vmpooler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/vmpooler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/vmpooler/teams","hooks_url":"https://api.github.com/repos/puppetlabs/vmpooler/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/vmpooler/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/vmpooler/events","assignees_url":"https://api.github.com/repos/puppetlabs/vmpooler/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/vmpooler/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/vmpooler/tags","blobs_url":"https://api.github.com/repos/puppetlabs/vmpooler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/vmpooler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/vmpooler/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/vmpooler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/vmpooler/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/vmpooler/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/vmpooler/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/vmpooler/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/vmpooler/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/vmpooler/subscription","commits_url":"https://api.github.com/repos/puppetlabs/vmpooler/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/vmpooler/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/vmpooler/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/vmpooler/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/vmpooler/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/vmpooler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/vmpooler/merges","archive_url":"https://api.github.com/repos/puppetlabs/vmpooler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/vmpooler/downloads","issues_url":"https://api.github.com/repos/puppetlabs/vmpooler/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/vmpooler/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/vmpooler/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/vmpooler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/vmpooler/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/vmpooler/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/vmpooler/deployments","created_at":"2013-09-24T18:27:35Z","updated_at":"2018-05-30T19:19:08Z","pushed_at":"2018-06-01T18:56:00Z","git_url":"git://github.com/puppetlabs/vmpooler.git","ssh_url":"git@github.com:puppetlabs/vmpooler.git","clone_url":"https://github.com/puppetlabs/vmpooler.git","svn_url":"https://github.com/puppetlabs/vmpooler","homepage":"","size":1595,"stargazers_count":60,"watchers_count":60,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":36,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/260"},"html":{"href":"https://github.com/puppetlabs/vmpooler/pull/260"},"issue":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/issues/260"},"comments":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/vmpooler/statuses/d1ae85c8af3df2ad397f929b2fed40bea3a974f4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":73,"changed_files":2}}
{"actor":{"display_login":"mattkirby"}}