{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material/issues/11465","repository_url":"https://api.github.com/repos/angular/material","labels_url":"https://api.github.com/repos/angular/material/issues/11465/labels{/name}","comments_url":"https://api.github.com/repos/angular/material/issues/11465/comments","events_url":"https://api.github.com/repos/angular/material/issues/11465/events","html_url":"https://github.com/angular/material/pull/11465","id":364888952,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTY4MTI5","number":11465,"title":"fix(icon): stop breaking SVGs that have id references","user":{"login":"EmielH","id":5822678,"node_id":"MDQ6VXNlcjU4MjI2Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5822678?v=4","gravatar_id":"","url":"https://api.github.com/users/EmielH","html_url":"https://github.com/EmielH","followers_url":"https://api.github.com/users/EmielH/followers","following_url":"https://api.github.com/users/EmielH/following{/other_user}","gists_url":"https://api.github.com/users/EmielH/gists{/gist_id}","starred_url":"https://api.github.com/users/EmielH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmielH/subscriptions","organizations_url":"https://api.github.com/users/EmielH/orgs","repos_url":"https://api.github.com/users/EmielH/repos","events_url":"https://api.github.com/users/EmielH/events{/privacy}","received_events_url":"https://api.github.com/users/EmielH/received_events","type":"User","site_admin":false},"labels":[{"id":478730729,"node_id":"MDU6TGFiZWw0Nzg3MzA3Mjk=","url":"https://api.github.com/repos/angular/material/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-28T13:27:44Z","updated_at":"2018-09-28T13:45:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/11465","html_url":"https://github.com/angular/material/pull/11465","diff_url":"https://github.com/angular/material/pull/11465.diff","patch_url":"https://github.com/angular/material/pull/11465.patch"},"body":"<!-- \r\nFilling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed.\r\n-->\r\n## PR Checklist\r\nPlease check that your PR fulfills the following requirements:\r\n- [X] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format)\r\n- [X] Tests for the changes have been added or this is not a bug fix / enhancement\r\n- [X] Docs have been added, updated, or were not required\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[X] Bugfix\r\n[ ] Enhancement\r\n[ ] Documentation content changes\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n\r\n<!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. -->\r\nWhen the same icon is used multiple times, they all have the same id.\r\n\r\nIssue Number: \r\nThis fixes the issue found by @coennijhuis in PR #11342. \r\n\r\n## What is the new behavior?\r\nWhen the same icon is used multiple times, they all have a different id. `_cache` followed by a number is appended to the id.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[X] No\r\n```\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n<!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. -->\r\n\r\n## Other information\r\n"},"comment":{"url":"https://api.github.com/repos/angular/material/issues/comments/425440194","html_url":"https://github.com/angular/material/pull/11465#issuecomment-425440194","issue_url":"https://api.github.com/repos/angular/material/issues/11465","id":425440194,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTQ0MDE5NA==","user":{"login":"EmielH","id":5822678,"node_id":"MDQ6VXNlcjU4MjI2Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/5822678?v=4","gravatar_id":"","url":"https://api.github.com/users/EmielH","html_url":"https://github.com/EmielH","followers_url":"https://api.github.com/users/EmielH/followers","following_url":"https://api.github.com/users/EmielH/following{/other_user}","gists_url":"https://api.github.com/users/EmielH/gists{/gist_id}","starred_url":"https://api.github.com/users/EmielH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmielH/subscriptions","organizations_url":"https://api.github.com/users/EmielH/orgs","repos_url":"https://api.github.com/users/EmielH/repos","events_url":"https://api.github.com/users/EmielH/events{/privacy}","received_events_url":"https://api.github.com/users/EmielH/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T13:45:02Z","updated_at":"2018-09-28T13:45:02Z","author_association":"NONE","body":"The build failed due to an error at SauceLabs:\r\n\r\n```\r\n+./scripts/sauce/setup-tunnel.sh\r\nInstalling Sauce Connector binaries...\r\n--2018-09-28 13:29:54--  https://saucelabs.com/downloads/sc-4.4.6-linux.tar.gz\r\nResolving saucelabs.com (saucelabs.com)... 66.85.49.36\r\nConnecting to saucelabs.com (saucelabs.com)|66.85.49.36|:443... connected.\r\nHTTP request sent, awaiting response... 502 Bad Gateway\r\n2018-09-28 13:30:04 ERROR 502: Bad Gateway.\r\n```\r\n\r\nCan anyone trigger a new build without having to close this PR and open a new one?"}}
{"actor":{"display_login":"EmielH"}}