{"action":"created","comment":{"url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/comments/193228309","pull_request_review_id":126160467,"id":193228309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzIyODMwOQ==","diff_hunk":"@@ -1216,7 +1216,7 @@ export class OAuthService extends AuthConfig {\n         }\n     }\n \n-    private storeAccessTokenResponse(\n+    public storeAccessTokenResponse(","path":"projects/lib/src/oauth-service.ts","position":5,"original_position":5,"commit_id":"b29eb1c8861cb077c8f2dcba7a8db6d25b396ee2","original_commit_id":"f1fc0a98bdeb0e686617a8c8ded6b2cdd6af004d","user":{"login":"vytautas-pranskunas-","id":3918999,"node_id":"MDQ6VXNlcjM5MTg5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3918999?v=4","gravatar_id":"","url":"https://api.github.com/users/vytautas-pranskunas-","html_url":"https://github.com/vytautas-pranskunas-","followers_url":"https://api.github.com/users/vytautas-pranskunas-/followers","following_url":"https://api.github.com/users/vytautas-pranskunas-/following{/other_user}","gists_url":"https://api.github.com/users/vytautas-pranskunas-/gists{/gist_id}","starred_url":"https://api.github.com/users/vytautas-pranskunas-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytautas-pranskunas-/subscriptions","organizations_url":"https://api.github.com/users/vytautas-pranskunas-/orgs","repos_url":"https://api.github.com/users/vytautas-pranskunas-/repos","events_url":"https://api.github.com/users/vytautas-pranskunas-/events{/privacy}","received_events_url":"https://api.github.com/users/vytautas-pranskunas-/received_events","type":"User","site_admin":false},"body":"In ideal world it might be. But i have really lack of time in playing with git now tring to split it into 2 merge requests + it is not breaking change it is just open one essential method to public. Maybe we can merge it like it is this time? :)","created_at":"2018-06-05T21:28:39Z","updated_at":"2018-06-05T21:28:39Z","html_url":"https://github.com/manfredsteyer/angular-oauth2-oidc/pull/331#discussion_r193228309","pull_request_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/comments/193228309"},"html":{"href":"https://github.com/manfredsteyer/angular-oauth2-oidc/pull/331#discussion_r193228309"},"pull_request":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331"}},"in_reply_to_id":192681651},"pull_request":{"url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331","id":189608334,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NjA4MzM0","html_url":"https://github.com/manfredsteyer/angular-oauth2-oidc/pull/331","diff_url":"https://github.com/manfredsteyer/angular-oauth2-oidc/pull/331.diff","patch_url":"https://github.com/manfredsteyer/angular-oauth2-oidc/pull/331.patch","issue_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues/331","number":331,"state":"open","locked":false,"title":"Added customUrlValidation","user":{"login":"vytautas-pranskunas-","id":3918999,"node_id":"MDQ6VXNlcjM5MTg5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3918999?v=4","gravatar_id":"","url":"https://api.github.com/users/vytautas-pranskunas-","html_url":"https://github.com/vytautas-pranskunas-","followers_url":"https://api.github.com/users/vytautas-pranskunas-/followers","following_url":"https://api.github.com/users/vytautas-pranskunas-/following{/other_user}","gists_url":"https://api.github.com/users/vytautas-pranskunas-/gists{/gist_id}","starred_url":"https://api.github.com/users/vytautas-pranskunas-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytautas-pranskunas-/subscriptions","organizations_url":"https://api.github.com/users/vytautas-pranskunas-/orgs","repos_url":"https://api.github.com/users/vytautas-pranskunas-/repos","events_url":"https://api.github.com/users/vytautas-pranskunas-/events{/privacy}","received_events_url":"https://api.github.com/users/vytautas-pranskunas-/received_events","type":"User","site_admin":false},"body":"Added custom url validation because we have an issue where we are calling optile requests for payment providers and there were only allowedUrls which we also have different like on local we have full url and on other environemtns calls are local and starts from 'api'. So with current allowedUrls there were not possibility to put allowed urls because it looks for startsWith. So i thought it is better to introduce custom url validation rather then add notAllowedUrls.","created_at":"2018-05-22T10:00:32Z","updated_at":"2018-06-05T21:28:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4faa30eb1f20f17efd3a0e8ca46cf66f50f30e04","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331/commits","review_comments_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331/comments","review_comment_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues/331/comments","statuses_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/statuses/b29eb1c8861cb077c8f2dcba7a8db6d25b396ee2","head":{"label":"vytautas-pranskunas-:master","ref":"master","sha":"b29eb1c8861cb077c8f2dcba7a8db6d25b396ee2","user":{"login":"vytautas-pranskunas-","id":3918999,"node_id":"MDQ6VXNlcjM5MTg5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3918999?v=4","gravatar_id":"","url":"https://api.github.com/users/vytautas-pranskunas-","html_url":"https://github.com/vytautas-pranskunas-","followers_url":"https://api.github.com/users/vytautas-pranskunas-/followers","following_url":"https://api.github.com/users/vytautas-pranskunas-/following{/other_user}","gists_url":"https://api.github.com/users/vytautas-pranskunas-/gists{/gist_id}","starred_url":"https://api.github.com/users/vytautas-pranskunas-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytautas-pranskunas-/subscriptions","organizations_url":"https://api.github.com/users/vytautas-pranskunas-/orgs","repos_url":"https://api.github.com/users/vytautas-pranskunas-/repos","events_url":"https://api.github.com/users/vytautas-pranskunas-/events{/privacy}","received_events_url":"https://api.github.com/users/vytautas-pranskunas-/received_events","type":"User","site_admin":false},"repo":{"id":133515722,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1MTU3MjI=","name":"angular-oauth2-oidc","full_name":"vytautas-pranskunas-/angular-oauth2-oidc","owner":{"login":"vytautas-pranskunas-","id":3918999,"node_id":"MDQ6VXNlcjM5MTg5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3918999?v=4","gravatar_id":"","url":"https://api.github.com/users/vytautas-pranskunas-","html_url":"https://github.com/vytautas-pranskunas-","followers_url":"https://api.github.com/users/vytautas-pranskunas-/followers","following_url":"https://api.github.com/users/vytautas-pranskunas-/following{/other_user}","gists_url":"https://api.github.com/users/vytautas-pranskunas-/gists{/gist_id}","starred_url":"https://api.github.com/users/vytautas-pranskunas-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytautas-pranskunas-/subscriptions","organizations_url":"https://api.github.com/users/vytautas-pranskunas-/orgs","repos_url":"https://api.github.com/users/vytautas-pranskunas-/repos","events_url":"https://api.github.com/users/vytautas-pranskunas-/events{/privacy}","received_events_url":"https://api.github.com/users/vytautas-pranskunas-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vytautas-pranskunas-/angular-oauth2-oidc","description":"Support for OAuth 2 and OpenId Connect (OIDC) in Angular. ","fork":true,"url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc","forks_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/forks","keys_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/teams","hooks_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/hooks","issue_events_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/issues/events{/number}","events_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/events","assignees_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/assignees{/user}","branches_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/branches{/branch}","tags_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/tags","blobs_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/git/refs{/sha}","trees_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/statuses/{sha}","languages_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/languages","stargazers_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/stargazers","contributors_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/contributors","subscribers_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/subscribers","subscription_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/subscription","commits_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/commits{/sha}","git_commits_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/git/commits{/sha}","comments_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/comments{/number}","issue_comment_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/issues/comments{/number}","contents_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/contents/{+path}","compare_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/merges","archive_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/downloads","issues_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/issues{/number}","pulls_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/pulls{/number}","milestones_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/milestones{/number}","notifications_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/labels{/name}","releases_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/releases{/id}","deployments_url":"https://api.github.com/repos/vytautas-pranskunas-/angular-oauth2-oidc/deployments","created_at":"2018-05-15T12:52:57Z","updated_at":"2018-06-05T21:22:28Z","pushed_at":"2018-06-05T21:22:25Z","git_url":"git://github.com/vytautas-pranskunas-/angular-oauth2-oidc.git","ssh_url":"git@github.com:vytautas-pranskunas-/angular-oauth2-oidc.git","clone_url":"https://github.com/vytautas-pranskunas-/angular-oauth2-oidc.git","svn_url":"https://github.com/vytautas-pranskunas-/angular-oauth2-oidc","homepage":null,"size":2622,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"manfredsteyer:master","ref":"master","sha":"b4c87312f51b22ddb763ec1a8095d2ea6de07851","user":{"login":"manfredsteyer","id":1573728,"node_id":"MDQ6VXNlcjE1NzM3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1573728?v=4","gravatar_id":"","url":"https://api.github.com/users/manfredsteyer","html_url":"https://github.com/manfredsteyer","followers_url":"https://api.github.com/users/manfredsteyer/followers","following_url":"https://api.github.com/users/manfredsteyer/following{/other_user}","gists_url":"https://api.github.com/users/manfredsteyer/gists{/gist_id}","starred_url":"https://api.github.com/users/manfredsteyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manfredsteyer/subscriptions","organizations_url":"https://api.github.com/users/manfredsteyer/orgs","repos_url":"https://api.github.com/users/manfredsteyer/repos","events_url":"https://api.github.com/users/manfredsteyer/events{/privacy}","received_events_url":"https://api.github.com/users/manfredsteyer/received_events","type":"User","site_admin":false},"repo":{"id":77933597,"node_id":"MDEwOlJlcG9zaXRvcnk3NzkzMzU5Nw==","name":"angular-oauth2-oidc","full_name":"manfredsteyer/angular-oauth2-oidc","owner":{"login":"manfredsteyer","id":1573728,"node_id":"MDQ6VXNlcjE1NzM3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1573728?v=4","gravatar_id":"","url":"https://api.github.com/users/manfredsteyer","html_url":"https://github.com/manfredsteyer","followers_url":"https://api.github.com/users/manfredsteyer/followers","following_url":"https://api.github.com/users/manfredsteyer/following{/other_user}","gists_url":"https://api.github.com/users/manfredsteyer/gists{/gist_id}","starred_url":"https://api.github.com/users/manfredsteyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manfredsteyer/subscriptions","organizations_url":"https://api.github.com/users/manfredsteyer/orgs","repos_url":"https://api.github.com/users/manfredsteyer/repos","events_url":"https://api.github.com/users/manfredsteyer/events{/privacy}","received_events_url":"https://api.github.com/users/manfredsteyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manfredsteyer/angular-oauth2-oidc","description":"Support for OAuth 2 and OpenId Connect (OIDC) in Angular. ","fork":false,"url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc","forks_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/forks","keys_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/teams","hooks_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/hooks","issue_events_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues/events{/number}","events_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/events","assignees_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/assignees{/user}","branches_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/branches{/branch}","tags_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/tags","blobs_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/git/refs{/sha}","trees_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/statuses/{sha}","languages_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/languages","stargazers_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/stargazers","contributors_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/contributors","subscribers_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/subscribers","subscription_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/subscription","commits_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/commits{/sha}","git_commits_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/git/commits{/sha}","comments_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/comments{/number}","issue_comment_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues/comments{/number}","contents_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/contents/{+path}","compare_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/merges","archive_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/downloads","issues_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues{/number}","pulls_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls{/number}","milestones_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/milestones{/number}","notifications_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/labels{/name}","releases_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/releases{/id}","deployments_url":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/deployments","created_at":"2017-01-03T16:25:13Z","updated_at":"2018-06-05T09:59:26Z","pushed_at":"2018-06-05T21:22:26Z","git_url":"git://github.com/manfredsteyer/angular-oauth2-oidc.git","ssh_url":"git@github.com:manfredsteyer/angular-oauth2-oidc.git","clone_url":"https://github.com/manfredsteyer/angular-oauth2-oidc.git","svn_url":"https://github.com/manfredsteyer/angular-oauth2-oidc","homepage":null,"size":2614,"stargazers_count":404,"watchers_count":404,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":183,"open_issues":16,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331"},"html":{"href":"https://github.com/manfredsteyer/angular-oauth2-oidc/pull/331"},"issue":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues/331"},"comments":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/manfredsteyer/angular-oauth2-oidc/statuses/b29eb1c8861cb077c8f2dcba7a8db6d25b396ee2"}},"author_association":"NONE"}}
{"actor":{"display_login":"vytautas-pranskunas-"}}