{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/comments/230871054","pull_request_review_id":171708005,"id":230871054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDg3MTA1NA==","diff_hunk":"@@ -42,6 +42,7 @@ def run(self):\n     scripts=[\n         \"rbd-target-gw.py\"\n     ],\n+    data_files=[(\"/var/log/rbd-target-gw\", [])],","path":"setup.py","position":4,"original_position":4,"commit_id":"f1419653ff77d3219292dc5b5e559e24de43a0e2","original_commit_id":"f1419653ff77d3219292dc5b5e559e24de43a0e2","user":{"login":"dillaman","id":4739042,"node_id":"MDQ6VXNlcjQ3MzkwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/4739042?v=4","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"body":"Yeah, I was just asking if the spec needed to create the directory (not to copy that exact line). ","created_at":"2018-11-05T18:59:06Z","updated_at":"2018-11-05T18:59:07Z","html_url":"https://github.com/ceph/ceph-iscsi-config/pull/90#discussion_r230871054","pull_request_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/comments/230871054"},"html":{"href":"https://github.com/ceph/ceph-iscsi-config/pull/90#discussion_r230871054"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90"}},"in_reply_to_id":230366084},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90","id":227791753,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzkxNzUz","html_url":"https://github.com/ceph/ceph-iscsi-config/pull/90","diff_url":"https://github.com/ceph/ceph-iscsi-config/pull/90.diff","patch_url":"https://github.com/ceph/ceph-iscsi-config/pull/90.patch","issue_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues/90","number":90,"state":"open","locked":false,"title":"Move logs to dir","user":{"login":"mikechristie","id":1063316,"node_id":"MDQ6VXNlcjEwNjMzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1063316?v=4","gravatar_id":"","url":"https://api.github.com/users/mikechristie","html_url":"https://github.com/mikechristie","followers_url":"https://api.github.com/users/mikechristie/followers","following_url":"https://api.github.com/users/mikechristie/following{/other_user}","gists_url":"https://api.github.com/users/mikechristie/gists{/gist_id}","starred_url":"https://api.github.com/users/mikechristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikechristie/subscriptions","organizations_url":"https://api.github.com/users/mikechristie/orgs","repos_url":"https://api.github.com/users/mikechristie/repos","events_url":"https://api.github.com/users/mikechristie/events{/privacy}","received_events_url":"https://api.github.com/users/mikechristie/received_events","type":"User","site_admin":false},"body":"The ceph selinux policy expects the logs to be in a dir under /var/log,\r\nso this just moves our logs to /var/log/rbd-target-gw, so we do not have\r\nto special case the ceph iscsi stuff in ceph-selinux.","created_at":"2018-11-01T23:38:01Z","updated_at":"2018-11-05T18:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6506e3efb152e27abfd6965b99a4274a444d147f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues/90/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/statuses/f1419653ff77d3219292dc5b5e559e24de43a0e2","head":{"label":"mikechristie:move-log-dir","ref":"move-log-dir","sha":"f1419653ff77d3219292dc5b5e559e24de43a0e2","user":{"login":"mikechristie","id":1063316,"node_id":"MDQ6VXNlcjEwNjMzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1063316?v=4","gravatar_id":"","url":"https://api.github.com/users/mikechristie","html_url":"https://github.com/mikechristie","followers_url":"https://api.github.com/users/mikechristie/followers","following_url":"https://api.github.com/users/mikechristie/following{/other_user}","gists_url":"https://api.github.com/users/mikechristie/gists{/gist_id}","starred_url":"https://api.github.com/users/mikechristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikechristie/subscriptions","organizations_url":"https://api.github.com/users/mikechristie/orgs","repos_url":"https://api.github.com/users/mikechristie/repos","events_url":"https://api.github.com/users/mikechristie/events{/privacy}","received_events_url":"https://api.github.com/users/mikechristie/received_events","type":"User","site_admin":false},"repo":{"id":99289876,"node_id":"MDEwOlJlcG9zaXRvcnk5OTI4OTg3Ng==","name":"ceph-iscsi-config","full_name":"mikechristie/ceph-iscsi-config","private":false,"owner":{"login":"mikechristie","id":1063316,"node_id":"MDQ6VXNlcjEwNjMzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1063316?v=4","gravatar_id":"","url":"https://api.github.com/users/mikechristie","html_url":"https://github.com/mikechristie","followers_url":"https://api.github.com/users/mikechristie/followers","following_url":"https://api.github.com/users/mikechristie/following{/other_user}","gists_url":"https://api.github.com/users/mikechristie/gists{/gist_id}","starred_url":"https://api.github.com/users/mikechristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikechristie/subscriptions","organizations_url":"https://api.github.com/users/mikechristie/orgs","repos_url":"https://api.github.com/users/mikechristie/repos","events_url":"https://api.github.com/users/mikechristie/events{/privacy}","received_events_url":"https://api.github.com/users/mikechristie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikechristie/ceph-iscsi-config","description":"Repo containing common configuration modules for managing iscsi gateways for ceph","fork":true,"url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config","forks_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/forks","keys_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/teams","hooks_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/hooks","issue_events_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/issues/events{/number}","events_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/events","assignees_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/assignees{/user}","branches_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/branches{/branch}","tags_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/tags","blobs_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/statuses/{sha}","languages_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/languages","stargazers_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/stargazers","contributors_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/contributors","subscribers_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/subscribers","subscription_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/subscription","commits_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/contents/{+path}","compare_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/merges","archive_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/downloads","issues_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/issues{/number}","pulls_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/pulls{/number}","milestones_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/milestones{/number}","notifications_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/labels{/name}","releases_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/releases{/id}","deployments_url":"https://api.github.com/repos/mikechristie/ceph-iscsi-config/deployments","created_at":"2017-08-04T01:29:27Z","updated_at":"2018-10-30T17:23:12Z","pushed_at":"2018-11-02T02:38:29Z","git_url":"git://github.com/mikechristie/ceph-iscsi-config.git","ssh_url":"git@github.com:mikechristie/ceph-iscsi-config.git","clone_url":"https://github.com/mikechristie/ceph-iscsi-config.git","svn_url":"https://github.com/mikechristie/ceph-iscsi-config","homepage":null,"size":1630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"22eb28eef7201afa63804cde0a71f37cc601317c","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":69600903,"node_id":"MDEwOlJlcG9zaXRvcnk2OTYwMDkwMw==","name":"ceph-iscsi-config","full_name":"ceph/ceph-iscsi-config","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph-iscsi-config","description":"Repo containing common configuration modules for managing iscsi gateways for ceph","fork":false,"url":"https://api.github.com/repos/ceph/ceph-iscsi-config","forks_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/forks","keys_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/events","assignees_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/merges","archive_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-iscsi-config/deployments","created_at":"2016-09-29T19:32:44Z","updated_at":"2018-11-05T18:46:10Z","pushed_at":"2018-11-05T18:46:10Z","git_url":"git://github.com/ceph/ceph-iscsi-config.git","ssh_url":"git@github.com:ceph/ceph-iscsi-config.git","clone_url":"https://github.com/ceph/ceph-iscsi-config.git","svn_url":"https://github.com/ceph/ceph-iscsi-config","homepage":null,"size":1636,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":15,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90"},"html":{"href":"https://github.com/ceph/ceph-iscsi-config/pull/90"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues/90"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-iscsi-config/statuses/f1419653ff77d3219292dc5b5e559e24de43a0e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dillaman"}}