{"action":"created","comment":{"url":"https://api.github.com/repos/aantron/repromise/pulls/comments/173103178","pull_request_review_id":102233460,"id":173103178,"diff_hunk":"@@ -21,23 +21,24 @@ function unwrap(value) {\n         return value;\n }\n \n+function wrap(value) {","path":"src/js/repromise.re","position":4,"original_position":4,"commit_id":"4d539c5a393bc687cdd4d3a27391902097a6d823","original_commit_id":"4d539c5a393bc687cdd4d3a27391902097a6d823","user":{"login":"ncthbrt","id":8688217,"avatar_url":"https://avatars0.githubusercontent.com/u/8688217?v=4","gravatar_id":"","url":"https://api.github.com/users/ncthbrt","html_url":"https://github.com/ncthbrt","followers_url":"https://api.github.com/users/ncthbrt/followers","following_url":"https://api.github.com/users/ncthbrt/following{/other_user}","gists_url":"https://api.github.com/users/ncthbrt/gists{/gist_id}","starred_url":"https://api.github.com/users/ncthbrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncthbrt/subscriptions","organizations_url":"https://api.github.com/users/ncthbrt/orgs","repos_url":"https://api.github.com/users/ncthbrt/repos","events_url":"https://api.github.com/users/ncthbrt/events{/privacy}","received_events_url":"https://api.github.com/users/ncthbrt/received_events","type":"User","site_admin":false},"body":"This is cleaner, but does result in an additional function call. ","created_at":"2018-03-08T09:25:57Z","updated_at":"2018-03-08T09:25:57Z","html_url":"https://github.com/aantron/repromise/pull/14#discussion_r173103178","pull_request_url":"https://api.github.com/repos/aantron/repromise/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aantron/repromise/pulls/comments/173103178"},"html":{"href":"https://github.com/aantron/repromise/pull/14#discussion_r173103178"},"pull_request":{"href":"https://api.github.com/repos/aantron/repromise/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/aantron/repromise/pulls/14","id":173663600,"html_url":"https://github.com/aantron/repromise/pull/14","diff_url":"https://github.com/aantron/repromise/pull/14.diff","patch_url":"https://github.com/aantron/repromise/pull/14.patch","issue_url":"https://api.github.com/repos/aantron/repromise/issues/14","number":14,"state":"open","locked":false,"title":"Refactor WrappedPromise construction","user":{"login":"ckknight","id":66227,"avatar_url":"https://avatars1.githubusercontent.com/u/66227?v=4","gravatar_id":"","url":"https://api.github.com/users/ckknight","html_url":"https://github.com/ckknight","followers_url":"https://api.github.com/users/ckknight/followers","following_url":"https://api.github.com/users/ckknight/following{/other_user}","gists_url":"https://api.github.com/users/ckknight/gists{/gist_id}","starred_url":"https://api.github.com/users/ckknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckknight/subscriptions","organizations_url":"https://api.github.com/users/ckknight/orgs","repos_url":"https://api.github.com/users/ckknight/repos","events_url":"https://api.github.com/users/ckknight/events{/privacy}","received_events_url":"https://api.github.com/users/ckknight/received_events","type":"User","site_admin":false},"body":"This doesn't include exposing the `wrap` function to Reason, nor do I think it needs to at this time.","created_at":"2018-03-08T07:26:10Z","updated_at":"2018-03-08T09:25:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f800ca31cb551f7881c4d0afdbad5e17646afddf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aantron/repromise/pulls/14/commits","review_comments_url":"https://api.github.com/repos/aantron/repromise/pulls/14/comments","review_comment_url":"https://api.github.com/repos/aantron/repromise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aantron/repromise/issues/14/comments","statuses_url":"https://api.github.com/repos/aantron/repromise/statuses/4d539c5a393bc687cdd4d3a27391902097a6d823","head":{"label":"ckknight:patch-1","ref":"patch-1","sha":"4d539c5a393bc687cdd4d3a27391902097a6d823","user":{"login":"ckknight","id":66227,"avatar_url":"https://avatars1.githubusercontent.com/u/66227?v=4","gravatar_id":"","url":"https://api.github.com/users/ckknight","html_url":"https://github.com/ckknight","followers_url":"https://api.github.com/users/ckknight/followers","following_url":"https://api.github.com/users/ckknight/following{/other_user}","gists_url":"https://api.github.com/users/ckknight/gists{/gist_id}","starred_url":"https://api.github.com/users/ckknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckknight/subscriptions","organizations_url":"https://api.github.com/users/ckknight/orgs","repos_url":"https://api.github.com/users/ckknight/repos","events_url":"https://api.github.com/users/ckknight/events{/privacy}","received_events_url":"https://api.github.com/users/ckknight/received_events","type":"User","site_admin":false},"repo":{"id":124352438,"name":"repromise","full_name":"ckknight/repromise","owner":{"login":"ckknight","id":66227,"avatar_url":"https://avatars1.githubusercontent.com/u/66227?v=4","gravatar_id":"","url":"https://api.github.com/users/ckknight","html_url":"https://github.com/ckknight","followers_url":"https://api.github.com/users/ckknight/followers","following_url":"https://api.github.com/users/ckknight/following{/other_user}","gists_url":"https://api.github.com/users/ckknight/gists{/gist_id}","starred_url":"https://api.github.com/users/ckknight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckknight/subscriptions","organizations_url":"https://api.github.com/users/ckknight/orgs","repos_url":"https://api.github.com/users/ckknight/repos","events_url":"https://api.github.com/users/ckknight/events{/privacy}","received_events_url":"https://api.github.com/users/ckknight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ckknight/repromise","description":"JavaScript and native promises for Reason, OCaml","fork":true,"url":"https://api.github.com/repos/ckknight/repromise","forks_url":"https://api.github.com/repos/ckknight/repromise/forks","keys_url":"https://api.github.com/repos/ckknight/repromise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckknight/repromise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckknight/repromise/teams","hooks_url":"https://api.github.com/repos/ckknight/repromise/hooks","issue_events_url":"https://api.github.com/repos/ckknight/repromise/issues/events{/number}","events_url":"https://api.github.com/repos/ckknight/repromise/events","assignees_url":"https://api.github.com/repos/ckknight/repromise/assignees{/user}","branches_url":"https://api.github.com/repos/ckknight/repromise/branches{/branch}","tags_url":"https://api.github.com/repos/ckknight/repromise/tags","blobs_url":"https://api.github.com/repos/ckknight/repromise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckknight/repromise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckknight/repromise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckknight/repromise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckknight/repromise/statuses/{sha}","languages_url":"https://api.github.com/repos/ckknight/repromise/languages","stargazers_url":"https://api.github.com/repos/ckknight/repromise/stargazers","contributors_url":"https://api.github.com/repos/ckknight/repromise/contributors","subscribers_url":"https://api.github.com/repos/ckknight/repromise/subscribers","subscription_url":"https://api.github.com/repos/ckknight/repromise/subscription","commits_url":"https://api.github.com/repos/ckknight/repromise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckknight/repromise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckknight/repromise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckknight/repromise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckknight/repromise/contents/{+path}","compare_url":"https://api.github.com/repos/ckknight/repromise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckknight/repromise/merges","archive_url":"https://api.github.com/repos/ckknight/repromise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckknight/repromise/downloads","issues_url":"https://api.github.com/repos/ckknight/repromise/issues{/number}","pulls_url":"https://api.github.com/repos/ckknight/repromise/pulls{/number}","milestones_url":"https://api.github.com/repos/ckknight/repromise/milestones{/number}","notifications_url":"https://api.github.com/repos/ckknight/repromise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckknight/repromise/labels{/name}","releases_url":"https://api.github.com/repos/ckknight/repromise/releases{/id}","deployments_url":"https://api.github.com/repos/ckknight/repromise/deployments","created_at":"2018-03-08T07:15:31Z","updated_at":"2018-03-08T07:15:33Z","pushed_at":"2018-03-08T07:25:16Z","git_url":"git://github.com/ckknight/repromise.git","ssh_url":"git@github.com:ckknight/repromise.git","clone_url":"https://github.com/ckknight/repromise.git","svn_url":"https://github.com/ckknight/repromise","homepage":"","size":89,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aantron:master","ref":"master","sha":"519e57716c4bdf61bfa1415b17c7dc35ab6de44a","user":{"login":"aantron","id":12073668,"avatar_url":"https://avatars2.githubusercontent.com/u/12073668?v=4","gravatar_id":"","url":"https://api.github.com/users/aantron","html_url":"https://github.com/aantron","followers_url":"https://api.github.com/users/aantron/followers","following_url":"https://api.github.com/users/aantron/following{/other_user}","gists_url":"https://api.github.com/users/aantron/gists{/gist_id}","starred_url":"https://api.github.com/users/aantron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aantron/subscriptions","organizations_url":"https://api.github.com/users/aantron/orgs","repos_url":"https://api.github.com/users/aantron/repos","events_url":"https://api.github.com/users/aantron/events{/privacy}","received_events_url":"https://api.github.com/users/aantron/received_events","type":"User","site_admin":false},"repo":{"id":116451935,"name":"repromise","full_name":"aantron/repromise","owner":{"login":"aantron","id":12073668,"avatar_url":"https://avatars2.githubusercontent.com/u/12073668?v=4","gravatar_id":"","url":"https://api.github.com/users/aantron","html_url":"https://github.com/aantron","followers_url":"https://api.github.com/users/aantron/followers","following_url":"https://api.github.com/users/aantron/following{/other_user}","gists_url":"https://api.github.com/users/aantron/gists{/gist_id}","starred_url":"https://api.github.com/users/aantron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aantron/subscriptions","organizations_url":"https://api.github.com/users/aantron/orgs","repos_url":"https://api.github.com/users/aantron/repos","events_url":"https://api.github.com/users/aantron/events{/privacy}","received_events_url":"https://api.github.com/users/aantron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aantron/repromise","description":"JavaScript and native promises for Reason, OCaml","fork":false,"url":"https://api.github.com/repos/aantron/repromise","forks_url":"https://api.github.com/repos/aantron/repromise/forks","keys_url":"https://api.github.com/repos/aantron/repromise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aantron/repromise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aantron/repromise/teams","hooks_url":"https://api.github.com/repos/aantron/repromise/hooks","issue_events_url":"https://api.github.com/repos/aantron/repromise/issues/events{/number}","events_url":"https://api.github.com/repos/aantron/repromise/events","assignees_url":"https://api.github.com/repos/aantron/repromise/assignees{/user}","branches_url":"https://api.github.com/repos/aantron/repromise/branches{/branch}","tags_url":"https://api.github.com/repos/aantron/repromise/tags","blobs_url":"https://api.github.com/repos/aantron/repromise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aantron/repromise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aantron/repromise/git/refs{/sha}","trees_url":"https://api.github.com/repos/aantron/repromise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aantron/repromise/statuses/{sha}","languages_url":"https://api.github.com/repos/aantron/repromise/languages","stargazers_url":"https://api.github.com/repos/aantron/repromise/stargazers","contributors_url":"https://api.github.com/repos/aantron/repromise/contributors","subscribers_url":"https://api.github.com/repos/aantron/repromise/subscribers","subscription_url":"https://api.github.com/repos/aantron/repromise/subscription","commits_url":"https://api.github.com/repos/aantron/repromise/commits{/sha}","git_commits_url":"https://api.github.com/repos/aantron/repromise/git/commits{/sha}","comments_url":"https://api.github.com/repos/aantron/repromise/comments{/number}","issue_comment_url":"https://api.github.com/repos/aantron/repromise/issues/comments{/number}","contents_url":"https://api.github.com/repos/aantron/repromise/contents/{+path}","compare_url":"https://api.github.com/repos/aantron/repromise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aantron/repromise/merges","archive_url":"https://api.github.com/repos/aantron/repromise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aantron/repromise/downloads","issues_url":"https://api.github.com/repos/aantron/repromise/issues{/number}","pulls_url":"https://api.github.com/repos/aantron/repromise/pulls{/number}","milestones_url":"https://api.github.com/repos/aantron/repromise/milestones{/number}","notifications_url":"https://api.github.com/repos/aantron/repromise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aantron/repromise/labels{/name}","releases_url":"https://api.github.com/repos/aantron/repromise/releases{/id}","deployments_url":"https://api.github.com/repos/aantron/repromise/deployments","created_at":"2018-01-06T04:03:58Z","updated_at":"2018-03-08T08:50:00Z","pushed_at":"2018-03-08T07:26:11Z","git_url":"git://github.com/aantron/repromise.git","ssh_url":"git@github.com:aantron/repromise.git","clone_url":"https://github.com/aantron/repromise.git","svn_url":"https://github.com/aantron/repromise","homepage":"","size":87,"stargazers_count":33,"watchers_count":33,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":4,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aantron/repromise/pulls/14"},"html":{"href":"https://github.com/aantron/repromise/pull/14"},"issue":{"href":"https://api.github.com/repos/aantron/repromise/issues/14"},"comments":{"href":"https://api.github.com/repos/aantron/repromise/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/aantron/repromise/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/aantron/repromise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aantron/repromise/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/aantron/repromise/statuses/4d539c5a393bc687cdd4d3a27391902097a6d823"}},"author_association":"NONE"}}
{"actor":{"display_login":"ncthbrt"}}