{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/236097176","pull_request_review_id":178104555,"id":236097176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA5NzE3Ng==","diff_hunk":"@@ -169,13 +169,18 @@ private[csv] class CsvOutputWriter(\n     context: TaskAttemptContext,\n     params: CSVOptions) extends OutputWriter with Logging {\n \n-  private val charset = Charset.forName(params.charset)\n+  private var univocityGenerator: Option[UnivocityGenerator] = None","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVFileFormat.scala","position":5,"original_position":5,"commit_id":"76e1466a39aa2a40d999791bb9d3b09628921e85","original_commit_id":"76e1466a39aa2a40d999791bb9d3b09628921e85","user":{"login":"srowen","id":822522,"node_id":"MDQ6VXNlcjgyMjUyMg==","avatar_url":"https://avatars0.githubusercontent.com/u/822522?v=4","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"Do we have a race condition below then where multiple generators can be created?","created_at":"2018-11-25T23:54:34Z","updated_at":"2018-11-25T23:54:34Z","html_url":"https://github.com/apache/spark/pull/23052#discussion_r236097176","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/23052","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/236097176"},"html":{"href":"https://github.com/apache/spark/pull/23052#discussion_r236097176"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/23052"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23052","id":231336078,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzM2MDc4","html_url":"https://github.com/apache/spark/pull/23052","diff_url":"https://github.com/apache/spark/pull/23052.diff","patch_url":"https://github.com/apache/spark/pull/23052.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/23052","number":23052,"state":"open","locked":false,"title":"[SPARK-26081][SQL] Prevent empty files for empty partitions in Text datasources","user":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nIn the PR, I propose to postpone creation of `OutputStream`/`Univocity`/`JacksonGenerator` till the first row should be written. This prevents creation of empty files for empty partitions. So, no need to open and to read such files back while loading data from the location.\r\n\r\n## How was this patch tested?\r\n\r\nAdded tests for Text, JSON and CSV datasource where empty dataset is written but should not produce any files.\r\n","created_at":"2018-11-15T21:14:01Z","updated_at":"2018-11-25T23:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a511b9655fe092dfc4224e7abbdef3594feb284","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/23052/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/23052/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/23052/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/76e1466a39aa2a40d999791bb9d3b09628921e85","head":{"label":"MaxGekk:text-empty-files","ref":"text-empty-files","sha":"76e1466a39aa2a40d999791bb9d3b09628921e85","user":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"repo":{"id":123690489,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2OTA0ODk=","name":"spark-1","full_name":"MaxGekk/spark-1","private":false,"owner":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MaxGekk/spark-1","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/MaxGekk/spark-1","forks_url":"https://api.github.com/repos/MaxGekk/spark-1/forks","keys_url":"https://api.github.com/repos/MaxGekk/spark-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaxGekk/spark-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaxGekk/spark-1/teams","hooks_url":"https://api.github.com/repos/MaxGekk/spark-1/hooks","issue_events_url":"https://api.github.com/repos/MaxGekk/spark-1/issues/events{/number}","events_url":"https://api.github.com/repos/MaxGekk/spark-1/events","assignees_url":"https://api.github.com/repos/MaxGekk/spark-1/assignees{/user}","branches_url":"https://api.github.com/repos/MaxGekk/spark-1/branches{/branch}","tags_url":"https://api.github.com/repos/MaxGekk/spark-1/tags","blobs_url":"https://api.github.com/repos/MaxGekk/spark-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaxGekk/spark-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaxGekk/spark-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaxGekk/spark-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaxGekk/spark-1/statuses/{sha}","languages_url":"https://api.github.com/repos/MaxGekk/spark-1/languages","stargazers_url":"https://api.github.com/repos/MaxGekk/spark-1/stargazers","contributors_url":"https://api.github.com/repos/MaxGekk/spark-1/contributors","subscribers_url":"https://api.github.com/repos/MaxGekk/spark-1/subscribers","subscription_url":"https://api.github.com/repos/MaxGekk/spark-1/subscription","commits_url":"https://api.github.com/repos/MaxGekk/spark-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaxGekk/spark-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaxGekk/spark-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaxGekk/spark-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaxGekk/spark-1/contents/{+path}","compare_url":"https://api.github.com/repos/MaxGekk/spark-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaxGekk/spark-1/merges","archive_url":"https://api.github.com/repos/MaxGekk/spark-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaxGekk/spark-1/downloads","issues_url":"https://api.github.com/repos/MaxGekk/spark-1/issues{/number}","pulls_url":"https://api.github.com/repos/MaxGekk/spark-1/pulls{/number}","milestones_url":"https://api.github.com/repos/MaxGekk/spark-1/milestones{/number}","notifications_url":"https://api.github.com/repos/MaxGekk/spark-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaxGekk/spark-1/labels{/name}","releases_url":"https://api.github.com/repos/MaxGekk/spark-1/releases{/id}","deployments_url":"https://api.github.com/repos/MaxGekk/spark-1/deployments","created_at":"2018-03-03T12:37:00Z","updated_at":"2018-11-24T10:58:14Z","pushed_at":"2018-11-25T15:46:35Z","git_url":"git://github.com/MaxGekk/spark-1.git","ssh_url":"git@github.com:MaxGekk/spark-1.git","clone_url":"https://github.com/MaxGekk/spark-1.git","svn_url":"https://github.com/MaxGekk/spark-1","homepage":null,"size":288508,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"de84899204f3428f3d1d688b277dc06b021d860a","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-11-25T23:48:20Z","pushed_at":"2018-11-25T23:53:27Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":287463,"stargazers_count":19608,"watchers_count":19608,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17506,"mirror_url":null,"archived":false,"open_issues_count":509,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17506,"open_issues":509,"watchers":19608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/23052"},"html":{"href":"https://github.com/apache/spark/pull/23052"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/23052"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/23052/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/23052/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/23052/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/76e1466a39aa2a40d999791bb9d3b09628921e85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"srowen"}}