{"action":"created","issue":{"url":"https://api.github.com/repos/gardener/machine-controller-manager/issues/180","repository_url":"https://api.github.com/repos/gardener/machine-controller-manager","labels_url":"https://api.github.com/repos/gardener/machine-controller-manager/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/gardener/machine-controller-manager/issues/180/comments","events_url":"https://api.github.com/repos/gardener/machine-controller-manager/issues/180/events","html_url":"https://github.com/gardener/machine-controller-manager/pull/180","id":372542438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Njk3MzE5","number":180,"title":"Enhancement freeze logic","user":{"login":"prashanth26","id":34744389,"node_id":"MDQ6VXNlcjM0NzQ0Mzg5","avatar_url":"https://avatars0.githubusercontent.com/u/34744389?v=4","gravatar_id":"","url":"https://api.github.com/users/prashanth26","html_url":"https://github.com/prashanth26","followers_url":"https://api.github.com/users/prashanth26/followers","following_url":"https://api.github.com/users/prashanth26/following{/other_user}","gists_url":"https://api.github.com/users/prashanth26/gists{/gist_id}","starred_url":"https://api.github.com/users/prashanth26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashanth26/subscriptions","organizations_url":"https://api.github.com/users/prashanth26/orgs","repos_url":"https://api.github.com/users/prashanth26/repos","events_url":"https://api.github.com/users/prashanth26/events{/privacy}","received_events_url":"https://api.github.com/users/prashanth26/received_events","type":"User","site_admin":false},"labels":[{"id":943526932,"node_id":"MDU6TGFiZWw5NDM1MjY5MzI=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/area/dev-productivity","name":"area/dev-productivity","color":"0052cc","default":false},{"id":943519014,"node_id":"MDU6TGFiZWw5NDM1MTkwMTQ=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/component/machine-controller-manager","name":"component/machine-controller-manager","color":"25399e","default":false},{"id":785766117,"node_id":"MDU6TGFiZWw3ODU3NjYxMTc=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/kind/enhancement","name":"kind/enhancement","color":"c7def8","default":false},{"id":943513950,"node_id":"MDU6TGFiZWw5NDM1MTM5NTA=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/needs/review","name":"needs/review","color":"fef2c0","default":false},{"id":785766119,"node_id":"MDU6TGFiZWw3ODU3NjYxMTk=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/priority/critical","name":"priority/critical","color":"eb6420","default":false},{"id":943526738,"node_id":"MDU6TGFiZWw5NDM1MjY3Mzg=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/size/s","name":"size/s","color":"bfdadc","default":false},{"id":943518520,"node_id":"MDU6TGFiZWw5NDM1MTg1MjA=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/status/new","name":"status/new","color":"fef2c0","default":false},{"id":943527492,"node_id":"MDU6TGFiZWw5NDM1Mjc0OTI=","url":"https://api.github.com/repos/gardener/machine-controller-manager/labels/topology/seed","name":"topology/seed","color":"009f76","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-22T14:22:36Z","updated_at":"2018-10-26T09:30:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gardener/machine-controller-manager/pulls/180","html_url":"https://github.com/gardener/machine-controller-manager/pull/180","diff_url":"https://github.com/gardener/machine-controller-manager/pull/180.diff","patch_url":"https://github.com/gardener/machine-controller-manager/pull/180.patch"},"body":"**What this PR does / why we need it**:\r\nWe need to enhance the freeze logic of safety-controller when APIServers are not reachable to freeze the machine controller from doing any wrong/unwanted reconcilations\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #155 \r\n\r\n**Special notes for your reviewer**:\r\nThe commits have been split into the following\r\n1. (Un)freezing of machine controller based on APIServer availability - Actual logic for freezing\r\n2. Controller test suite now supports control and target clients, Testing Framework now supports faking of object tracker returns/delays - Enhancements to testing framework\r\n3. Added test cases for machine controller freezing - Adding unit test cases to test changes.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your release note in the below block.\r\n2. If no release note is required, just write \"NONE\" within the block.\r\n\r\nFormat of block header: <category> <target_group>\r\nPossible values:\r\n- category:       improvement|noteworthy\r\n- target_group:   user|operator\r\n-->\r\n```improvement operator\r\n(Un)freezing of machine controller based on APIServer availability \r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/gardener/machine-controller-manager/issues/comments/433347501","html_url":"https://github.com/gardener/machine-controller-manager/pull/180#issuecomment-433347501","issue_url":"https://api.github.com/repos/gardener/machine-controller-manager/issues/180","id":433347501,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzM0NzUwMQ==","user":{"login":"prashanth26","id":34744389,"node_id":"MDQ6VXNlcjM0NzQ0Mzg5","avatar_url":"https://avatars0.githubusercontent.com/u/34744389?v=4","gravatar_id":"","url":"https://api.github.com/users/prashanth26","html_url":"https://github.com/prashanth26","followers_url":"https://api.github.com/users/prashanth26/followers","following_url":"https://api.github.com/users/prashanth26/following{/other_user}","gists_url":"https://api.github.com/users/prashanth26/gists{/gist_id}","starred_url":"https://api.github.com/users/prashanth26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashanth26/subscriptions","organizations_url":"https://api.github.com/users/prashanth26/orgs","repos_url":"https://api.github.com/users/prashanth26/repos","events_url":"https://api.github.com/users/prashanth26/events{/privacy}","received_events_url":"https://api.github.com/users/prashanth26/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T09:30:09Z","updated_at":"2018-10-26T09:30:09Z","author_association":"CONTRIBUTOR","body":"@ggaurav10 Thanking you 👍 "}}
{"actor":{"display_login":"prashanth26"}}