{"action":"created","issue":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/126","repository_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/126/comments","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/126/events","html_url":"https://github.com/census-instrumentation/opencensus-specs/issues/126","id":335044232,"node_id":"MDU6SXNzdWUzMzUwNDQyMzI=","number":126,"title":"Tracing: Consider adding a flush API.","user":{"login":"songy23","id":10536136,"node_id":"MDQ6VXNlcjEwNTM2MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/10536136?v=4","gravatar_id":"","url":"https://api.github.com/users/songy23","html_url":"https://github.com/songy23","followers_url":"https://api.github.com/users/songy23/followers","following_url":"https://api.github.com/users/songy23/following{/other_user}","gists_url":"https://api.github.com/users/songy23/gists{/gist_id}","starred_url":"https://api.github.com/users/songy23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songy23/subscriptions","organizations_url":"https://api.github.com/users/songy23/orgs","repos_url":"https://api.github.com/users/songy23/repos","events_url":"https://api.github.com/users/songy23/events{/privacy}","received_events_url":"https://api.github.com/users/songy23/received_events","type":"User","site_admin":false},"labels":[{"id":801087642,"node_id":"MDU6TGFiZWw4MDEwODc2NDI=","url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/labels/trace","name":"trace","color":"d42cf9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-22T23:18:24Z","updated_at":"2018-06-25T21:28:19Z","closed_at":null,"author_association":"MEMBER","body":"Proposed by @reyang : \r\n\r\n> I propose to have a top level Tracing.flush() instead. The reasons are:\r\n\r\n> 1) shutdown hooks are nondeterministic, if there are other shutdown hooks trying to use OpenCensus, their trace data might get dropped (due to the order of shutdown hooks execution).\r\n\r\n> 2) shutdown hook requires RuntimePermission(\"shutdownHooks\") which could be a problem for certain scenarios.\r\n\r\n> 3) give user explicit control so they can flush the trace when appropriate."},"comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/comments/400101662","html_url":"https://github.com/census-instrumentation/opencensus-specs/issues/126#issuecomment-400101662","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/126","id":400101662,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDEwMTY2Mg==","user":{"login":"reyang","id":17327289,"node_id":"MDQ6VXNlcjE3MzI3Mjg5","avatar_url":"https://avatars1.githubusercontent.com/u/17327289?v=4","gravatar_id":"","url":"https://api.github.com/users/reyang","html_url":"https://github.com/reyang","followers_url":"https://api.github.com/users/reyang/followers","following_url":"https://api.github.com/users/reyang/following{/other_user}","gists_url":"https://api.github.com/users/reyang/gists{/gist_id}","starred_url":"https://api.github.com/users/reyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyang/subscriptions","organizations_url":"https://api.github.com/users/reyang/orgs","repos_url":"https://api.github.com/users/reyang/repos","events_url":"https://api.github.com/users/reyang/events{/privacy}","received_events_url":"https://api.github.com/users/reyang/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T21:28:19Z","updated_at":"2018-06-25T21:28:19Z","author_association":"NONE","body":"@songy23 if there are too much data going into the buffer, will we eventually block the writers? I'm concerned about the performance impact."}}
{"actor":{"display_login":"reyang"}}