{"action":"closed","number":89,"pull_request":{"url":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/89","id":181022372,"html_url":"https://github.com/simp/rubygem-simp-cli/pull/89","diff_url":"https://github.com/simp/rubygem-simp-cli/pull/89.diff","patch_url":"https://github.com/simp/rubygem-simp-cli/pull/89.patch","issue_url":"https://api.github.com/repos/simp/rubygem-simp-cli/issues/89","number":89,"state":"closed","locked":false,"title":"(SIMP-4621) simp passgen fails to process all password files","user":{"login":"lnemsick-simp","id":20050954,"avatar_url":"https://avatars0.githubusercontent.com/u/20050954?v=4","gravatar_id":"","url":"https://api.github.com/users/lnemsick-simp","html_url":"https://github.com/lnemsick-simp","followers_url":"https://api.github.com/users/lnemsick-simp/followers","following_url":"https://api.github.com/users/lnemsick-simp/following{/other_user}","gists_url":"https://api.github.com/users/lnemsick-simp/gists{/gist_id}","starred_url":"https://api.github.com/users/lnemsick-simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnemsick-simp/subscriptions","organizations_url":"https://api.github.com/users/lnemsick-simp/orgs","repos_url":"https://api.github.com/users/lnemsick-simp/repos","events_url":"https://api.github.com/users/lnemsick-simp/events{/privacy}","received_events_url":"https://api.github.com/users/lnemsick-simp/received_events","type":"User","site_admin":false},"body":"- Fixed a bug simp passgen in which password filenames containing one\r\n  or more '.' characters could not be listed, added, or removed.\r\n- Fixed a bug in simp config in which the grub password would\r\n  be **silently** generated and then set, when the -f option was used.\r\n  The user would have no way of figuring out the value of the\r\n  grub password in that scenario.\r\n- Enhanced simp passgen\r\n  - Improved password validation. This validation now uses pwscore,\r\n    when available.  cracklib-check is used otherwise.\r\n  - Added password auto-generation capability to password setting\r\n    operation. This is especially useful now that password validation\r\n    has been beefed up.\r\n  - Added backup of password salt files, when passwords are backed up.\r\n  - Per security best practices, when a password is updated, now\r\n    removes the salt file corresponding to an old password.\r\n- Enhanced simp config\r\n  - Use the password generation and validation methods from\r\n    from Simp::Cli::Utils in simp config.  This uses pwscore,\r\n    when it is available, for better validation.\r\n  - Reworked grub password validation to account for encrypted\r\n    and unencrypted password validations.\r\n  - Reworked password entry to act more like traditional Linux password\r\n    changing programs\r\n    - Only verify that the confirm password matches the already\r\n      validated password, instead of validating it by itself.  This\r\n      eliminated the confirm password re-entry loop a user could get\r\n      into that was very confusing.\r\n    - Only allow 5 <password,confirm> attempts before failing\r\n    - Fixed confusing prompt problem in which the not-especially useful\r\n      PasswordItem description was printed for every re-prompt.\r\n  - Use original prompt instead of '?  ' for re-prompt on\r\n    input failure for clarity.\r\n- Improved password generation.  To prevent the user from receiving\r\n  and auto-generated password that fails validation, the password\r\n  candidate is validated, and if it fails validation, re-generated.\r\n  This becomes important when passwords are validated using pwscore\r\n  on a locked-down system!\r\n- Made a small code refactor\r\n  - Got rid of strange lib/ within a lib/ by moving utils.rb\r\n    from lib/simp/cli/lib to lib/simp/cli/utils.rb\r\n  - Properly namespaced module in lib/simp/cli/utils.rb from Utils\r\n    to Simp::Cli::Utils\r\n  - Got rid of unused methods in Simp::Cli::Utils\r\n  - Started using simplified formatting string modifiers provided\r\n    by HighLine, instead of the templates in simp config.  This\r\n    makes the code a bit easier to understand and maintain.\r\n\r\nSIMP-4621 #close\r\nSIMP-4698 #close","created_at":"2018-04-11T20:43:00Z","updated_at":"2018-04-13T15:47:46Z","closed_at":"2018-04-13T15:47:46Z","merged_at":"2018-04-13T15:47:46Z","merge_commit_sha":"0d852e133b8457dd35a93a488512ecb091a8f391","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/89/commits","review_comments_url":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/89/comments","review_comment_url":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simp/rubygem-simp-cli/issues/89/comments","statuses_url":"https://api.github.com/repos/simp/rubygem-simp-cli/statuses/bcea5ae5430e8d759a6a15c4e613599c934ff4e3","head":{"label":"lnemsick-simp:SIMP-4621","ref":"SIMP-4621","sha":"bcea5ae5430e8d759a6a15c4e613599c934ff4e3","user":{"login":"lnemsick-simp","id":20050954,"avatar_url":"https://avatars0.githubusercontent.com/u/20050954?v=4","gravatar_id":"","url":"https://api.github.com/users/lnemsick-simp","html_url":"https://github.com/lnemsick-simp","followers_url":"https://api.github.com/users/lnemsick-simp/followers","following_url":"https://api.github.com/users/lnemsick-simp/following{/other_user}","gists_url":"https://api.github.com/users/lnemsick-simp/gists{/gist_id}","starred_url":"https://api.github.com/users/lnemsick-simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnemsick-simp/subscriptions","organizations_url":"https://api.github.com/users/lnemsick-simp/orgs","repos_url":"https://api.github.com/users/lnemsick-simp/repos","events_url":"https://api.github.com/users/lnemsick-simp/events{/privacy}","received_events_url":"https://api.github.com/users/lnemsick-simp/received_events","type":"User","site_admin":false},"repo":{"id":64774738,"name":"rubygem-simp-cli","full_name":"lnemsick-simp/rubygem-simp-cli","owner":{"login":"lnemsick-simp","id":20050954,"avatar_url":"https://avatars0.githubusercontent.com/u/20050954?v=4","gravatar_id":"","url":"https://api.github.com/users/lnemsick-simp","html_url":"https://github.com/lnemsick-simp","followers_url":"https://api.github.com/users/lnemsick-simp/followers","following_url":"https://api.github.com/users/lnemsick-simp/following{/other_user}","gists_url":"https://api.github.com/users/lnemsick-simp/gists{/gist_id}","starred_url":"https://api.github.com/users/lnemsick-simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnemsick-simp/subscriptions","organizations_url":"https://api.github.com/users/lnemsick-simp/orgs","repos_url":"https://api.github.com/users/lnemsick-simp/repos","events_url":"https://api.github.com/users/lnemsick-simp/events{/privacy}","received_events_url":"https://api.github.com/users/lnemsick-simp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lnemsick-simp/rubygem-simp-cli","description":"The Command Line Interface for SIMP","fork":true,"url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli","forks_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/forks","keys_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/teams","hooks_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/hooks","issue_events_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/issues/events{/number}","events_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/events","assignees_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/assignees{/user}","branches_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/branches{/branch}","tags_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/tags","blobs_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/languages","stargazers_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/stargazers","contributors_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/contributors","subscribers_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/subscribers","subscription_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/subscription","commits_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/contents/{+path}","compare_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/merges","archive_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/downloads","issues_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/issues{/number}","pulls_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/labels{/name}","releases_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/releases{/id}","deployments_url":"https://api.github.com/repos/lnemsick-simp/rubygem-simp-cli/deployments","created_at":"2016-08-02T16:45:38Z","updated_at":"2018-04-10T18:52:18Z","pushed_at":"2018-04-11T20:38:58Z","git_url":"git://github.com/lnemsick-simp/rubygem-simp-cli.git","ssh_url":"git@github.com:lnemsick-simp/rubygem-simp-cli.git","clone_url":"https://github.com/lnemsick-simp/rubygem-simp-cli.git","svn_url":"https://github.com/lnemsick-simp/rubygem-simp-cli","homepage":null,"size":843,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simp:master","ref":"master","sha":"b7d07f7b31e318cbeb27f62aa1f00a06ec2c7e92","user":{"login":"simp","id":12174186,"avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"repo":{"id":35873711,"name":"rubygem-simp-cli","full_name":"simp/rubygem-simp-cli","owner":{"login":"simp","id":12174186,"avatar_url":"https://avatars2.githubusercontent.com/u/12174186?v=4","gravatar_id":"","url":"https://api.github.com/users/simp","html_url":"https://github.com/simp","followers_url":"https://api.github.com/users/simp/followers","following_url":"https://api.github.com/users/simp/following{/other_user}","gists_url":"https://api.github.com/users/simp/gists{/gist_id}","starred_url":"https://api.github.com/users/simp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simp/subscriptions","organizations_url":"https://api.github.com/users/simp/orgs","repos_url":"https://api.github.com/users/simp/repos","events_url":"https://api.github.com/users/simp/events{/privacy}","received_events_url":"https://api.github.com/users/simp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simp/rubygem-simp-cli","description":"The Command Line Interface for SIMP","fork":false,"url":"https://api.github.com/repos/simp/rubygem-simp-cli","forks_url":"https://api.github.com/repos/simp/rubygem-simp-cli/forks","keys_url":"https://api.github.com/repos/simp/rubygem-simp-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simp/rubygem-simp-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simp/rubygem-simp-cli/teams","hooks_url":"https://api.github.com/repos/simp/rubygem-simp-cli/hooks","issue_events_url":"https://api.github.com/repos/simp/rubygem-simp-cli/issues/events{/number}","events_url":"https://api.github.com/repos/simp/rubygem-simp-cli/events","assignees_url":"https://api.github.com/repos/simp/rubygem-simp-cli/assignees{/user}","branches_url":"https://api.github.com/repos/simp/rubygem-simp-cli/branches{/branch}","tags_url":"https://api.github.com/repos/simp/rubygem-simp-cli/tags","blobs_url":"https://api.github.com/repos/simp/rubygem-simp-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simp/rubygem-simp-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simp/rubygem-simp-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/simp/rubygem-simp-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simp/rubygem-simp-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/simp/rubygem-simp-cli/languages","stargazers_url":"https://api.github.com/repos/simp/rubygem-simp-cli/stargazers","contributors_url":"https://api.github.com/repos/simp/rubygem-simp-cli/contributors","subscribers_url":"https://api.github.com/repos/simp/rubygem-simp-cli/subscribers","subscription_url":"https://api.github.com/repos/simp/rubygem-simp-cli/subscription","commits_url":"https://api.github.com/repos/simp/rubygem-simp-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/simp/rubygem-simp-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/simp/rubygem-simp-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/simp/rubygem-simp-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/simp/rubygem-simp-cli/contents/{+path}","compare_url":"https://api.github.com/repos/simp/rubygem-simp-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simp/rubygem-simp-cli/merges","archive_url":"https://api.github.com/repos/simp/rubygem-simp-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simp/rubygem-simp-cli/downloads","issues_url":"https://api.github.com/repos/simp/rubygem-simp-cli/issues{/number}","pulls_url":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/simp/rubygem-simp-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/simp/rubygem-simp-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simp/rubygem-simp-cli/labels{/name}","releases_url":"https://api.github.com/repos/simp/rubygem-simp-cli/releases{/id}","deployments_url":"https://api.github.com/repos/simp/rubygem-simp-cli/deployments","created_at":"2015-05-19T09:49:46Z","updated_at":"2018-04-10T17:24:16Z","pushed_at":"2018-04-13T15:47:46Z","git_url":"git://github.com/simp/rubygem-simp-cli.git","ssh_url":"git@github.com:simp/rubygem-simp-cli.git","clone_url":"https://github.com/simp/rubygem-simp-cli.git","svn_url":"https://github.com/simp/rubygem-simp-cli","homepage":null,"size":832,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/89"},"html":{"href":"https://github.com/simp/rubygem-simp-cli/pull/89"},"issue":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/issues/89"},"comments":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/simp/rubygem-simp-cli/statuses/bcea5ae5430e8d759a6a15c4e613599c934ff4e3"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jeefberkey","id":8931085,"avatar_url":"https://avatars2.githubusercontent.com/u/8931085?v=4","gravatar_id":"","url":"https://api.github.com/users/jeefberkey","html_url":"https://github.com/jeefberkey","followers_url":"https://api.github.com/users/jeefberkey/followers","following_url":"https://api.github.com/users/jeefberkey/following{/other_user}","gists_url":"https://api.github.com/users/jeefberkey/gists{/gist_id}","starred_url":"https://api.github.com/users/jeefberkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeefberkey/subscriptions","organizations_url":"https://api.github.com/users/jeefberkey/orgs","repos_url":"https://api.github.com/users/jeefberkey/repos","events_url":"https://api.github.com/users/jeefberkey/events{/privacy}","received_events_url":"https://api.github.com/users/jeefberkey/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":913,"deletions":545,"changed_files":40}}
{"actor":{"display_login":"jeefberkey"}}