{"action":"closed","number":821,"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/821","id":191602649,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjAyNjQ5","html_url":"https://github.com/wxWidgets/wxWidgets/pull/821","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/821.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/821.patch","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/821","number":821,"state":"closed","locked":false,"title":"Don't send \"page changed\" events from wxNotebook dtor with GTK+ 3","user":{"login":"vadz","id":146917,"node_id":"MDQ6VXNlcjE0NjkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/146917?v=4","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"body":"These events are unexpected and inconsistent with the other platforms,\r\nincluding GTK+ 2, so make sure we don't send them during the\r\ndestruction.\r\n\r\n---\r\n\r\nThis fixes the problem discussed in this [wx-users thread](https://groups.google.com/forum/#!topic/wx-users/mu-sW_VzeiA). Alternative solution would be to disconnect the handler in the dtor, but I don't see any reason to prefer it and this seems simpler. Please let me know if you prefer doing at GTK+ level.\r\n\r\nOTOH this PR still results in an event being sent if you just `destroy nb` instead of doing the proper and recommended `nb->Destroy()`. If we care about this, we could just call `SendDestroyEvent()` from the dtor though.","created_at":"2018-05-30T22:56:09Z","updated_at":"2018-05-31T09:48:45Z","closed_at":"2018-05-31T09:48:45Z","merged_at":null,"merge_commit_sha":"0c09e0c0573bda1a12ee4c34f24046c55f01d153","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/821/commits","review_comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/821/comments","review_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/821/comments","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/5c56f23e00e3b13f4ea4f11ffff3b171bd8f159a","head":{"label":"vadz:nb-dtor-events","ref":"nb-dtor-events","sha":"5c56f23e00e3b13f4ea4f11ffff3b171bd8f159a","user":{"login":"vadz","id":146917,"node_id":"MDQ6VXNlcjE0NjkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/146917?v=4","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"repo":{"id":6279560,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjc5NTYw","name":"wxWidgets","full_name":"vadz/wxWidgets","owner":{"login":"vadz","id":146917,"node_id":"MDQ6VXNlcjE0NjkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/146917?v=4","gravatar_id":"","url":"https://api.github.com/users/vadz","html_url":"https://github.com/vadz","followers_url":"https://api.github.com/users/vadz/followers","following_url":"https://api.github.com/users/vadz/following{/other_user}","gists_url":"https://api.github.com/users/vadz/gists{/gist_id}","starred_url":"https://api.github.com/users/vadz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadz/subscriptions","organizations_url":"https://api.github.com/users/vadz/orgs","repos_url":"https://api.github.com/users/vadz/repos","events_url":"https://api.github.com/users/vadz/events{/privacy}","received_events_url":"https://api.github.com/users/vadz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadz/wxWidgets","description":"Clone of the official wxWidgets repository with some experimental long lived branches.","fork":true,"url":"https://api.github.com/repos/vadz/wxWidgets","forks_url":"https://api.github.com/repos/vadz/wxWidgets/forks","keys_url":"https://api.github.com/repos/vadz/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadz/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadz/wxWidgets/teams","hooks_url":"https://api.github.com/repos/vadz/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/vadz/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/vadz/wxWidgets/events","assignees_url":"https://api.github.com/repos/vadz/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/vadz/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/vadz/wxWidgets/tags","blobs_url":"https://api.github.com/repos/vadz/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadz/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadz/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadz/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadz/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/vadz/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/vadz/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/vadz/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/vadz/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/vadz/wxWidgets/subscription","commits_url":"https://api.github.com/repos/vadz/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadz/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadz/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadz/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadz/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/vadz/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadz/wxWidgets/merges","archive_url":"https://api.github.com/repos/vadz/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadz/wxWidgets/downloads","issues_url":"https://api.github.com/repos/vadz/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/vadz/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/vadz/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/vadz/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadz/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/vadz/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/vadz/wxWidgets/deployments","created_at":"2012-10-18T14:07:33Z","updated_at":"2018-05-29T15:39:14Z","pushed_at":"2018-05-30T23:29:35Z","git_url":"git://github.com/vadz/wxWidgets.git","ssh_url":"git@github.com:vadz/wxWidgets.git","clone_url":"https://github.com/vadz/wxWidgets.git","svn_url":"https://github.com/vadz/wxWidgets","homepage":"http://www.wxwidgets.org/","size":305121,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wxWidgets:master","ref":"master","sha":"8c8ff2c24d7ead682b20be1f62555855c92ed2fe","user":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"repo":{"id":1764646,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0NjQ2","name":"wxWidgets","full_name":"wxWidgets/wxWidgets","owner":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wxWidgets/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":false,"url":"https://api.github.com/repos/wxWidgets/wxWidgets","forks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/forks","keys_url":"https://api.github.com/repos/wxWidgets/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wxWidgets/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wxWidgets/wxWidgets/teams","hooks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/events","assignees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/wxWidgets/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/tags","blobs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/wxWidgets/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscription","commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/wxWidgets/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wxWidgets/wxWidgets/merges","archive_url":"https://api.github.com/repos/wxWidgets/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wxWidgets/wxWidgets/downloads","issues_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/wxWidgets/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/wxWidgets/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/wxWidgets/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/deployments","created_at":"2011-05-18T05:54:03Z","updated_at":"2018-05-31T03:21:51Z","pushed_at":"2018-05-31T09:48:34Z","git_url":"git://github.com/wxWidgets/wxWidgets.git","ssh_url":"git@github.com:wxWidgets/wxWidgets.git","clone_url":"https://github.com/wxWidgets/wxWidgets.git","svn_url":"https://github.com/wxWidgets/wxWidgets","homepage":"https://www.wxwidgets.org/","size":308434,"stargazers_count":1950,"watchers_count":1950,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":774,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":774,"open_issues":35,"watchers":1950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/821"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/821"},"issue":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/821"},"comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/821/comments"},"review_comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/821/comments"},"review_comment":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/821/commits"},"statuses":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/5c56f23e00e3b13f4ea4f11ffff3b171bd8f159a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"vadz"}}