{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/atomic-reactor/issues/1033","repository_url":"https://api.github.com/repos/projectatomic/atomic-reactor","labels_url":"https://api.github.com/repos/projectatomic/atomic-reactor/issues/1033/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/atomic-reactor/issues/1033/comments","events_url":"https://api.github.com/repos/projectatomic/atomic-reactor/issues/1033/events","html_url":"https://github.com/projectatomic/atomic-reactor/pull/1033","id":336671244,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDY4NzQx","number":1033,"title":"support for arch-override in scratch builds","user":{"login":"mlangsdorf","id":8007405,"node_id":"MDQ6VXNlcjgwMDc0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8007405?v=4","gravatar_id":"","url":"https://api.github.com/users/mlangsdorf","html_url":"https://github.com/mlangsdorf","followers_url":"https://api.github.com/users/mlangsdorf/followers","following_url":"https://api.github.com/users/mlangsdorf/following{/other_user}","gists_url":"https://api.github.com/users/mlangsdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/mlangsdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlangsdorf/subscriptions","organizations_url":"https://api.github.com/users/mlangsdorf/orgs","repos_url":"https://api.github.com/users/mlangsdorf/repos","events_url":"https://api.github.com/users/mlangsdorf/events{/privacy}","received_events_url":"https://api.github.com/users/mlangsdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-28T15:29:21Z","updated_at":"2018-07-18T19:15:35Z","closed_at":"2018-06-28T19:47:33Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/projectatomic/atomic-reactor/pulls/1033","html_url":"https://github.com/projectatomic/atomic-reactor/pull/1033","diff_url":"https://github.com/projectatomic/atomic-reactor/pull/1033.diff","patch_url":"https://github.com/projectatomic/atomic-reactor/pull/1033.patch"},"body":"add support in pre_check_and_set_platforms to detect scratch and isolated builds. For those builds, if\r\nthe platform list from user_params is different than the list from koji_target, assume that the user_params list take priority."},"comment":{"url":"https://api.github.com/repos/projectatomic/atomic-reactor/issues/comments/406043540","html_url":"https://github.com/projectatomic/atomic-reactor/pull/1033#issuecomment-406043540","issue_url":"https://api.github.com/repos/projectatomic/atomic-reactor/issues/1033","id":406043540,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjA0MzU0MA==","user":{"login":"owtaylor","id":1145674,"node_id":"MDQ6VXNlcjExNDU2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1145674?v=4","gravatar_id":"","url":"https://api.github.com/users/owtaylor","html_url":"https://github.com/owtaylor","followers_url":"https://api.github.com/users/owtaylor/followers","following_url":"https://api.github.com/users/owtaylor/following{/other_user}","gists_url":"https://api.github.com/users/owtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/owtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owtaylor/subscriptions","organizations_url":"https://api.github.com/users/owtaylor/orgs","repos_url":"https://api.github.com/users/owtaylor/repos","events_url":"https://api.github.com/users/owtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/owtaylor/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T19:15:35Z","updated_at":"2018-07-18T19:15:35Z","author_association":"CONTRIBUTOR","body":"I don't think it can be right that with this patch:\r\n - If no koji_target is specified, then --arch-override will obey platforms: only and platforms: exclude from container.yaml\r\n - If a koji_target is specified (so check_and_set_platforms runs) then --arch-override overrides the settings from --container.yaml\r\n\r\nI'm about to touch this code again to change the handling of platforms not in the cluster config, and unless people think otherwise, will change things so that the container.yaml settings uniformly win (and if they conflict, and you end up with an empty set, the build fails.)"}}
{"actor":{"display_login":"owtaylor"}}