{"action":"created","comment":{"url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/comments/213283568","pull_request_review_id":150084054,"id":213283568,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI4MzU2OA==","diff_hunk":"@@ -0,0 +1,113 @@\n+---\n+# Set up the volume management\n+- name: Fetch the directory and volume details\n+  block:\n+    - name: Get the list of volumes on the machine\n+      shell: ls \"{{ glusterd_libdir }}/vols\"\n+      register: dir_list\n+\n+    - set_fact:\n+        volumes: \"{{ dir_list.stdout.split() }}\"\n+\n+    # Find the list of bricks on the machine\n+    - name: Get the list of bricks corresponding to volume\n+      shell: >\n+        gluster vol info {{ item }} | grep \"Brick.*{{ item }}:\" |\n+        awk -F: '{ print $3 }'\n+      with_items: \"{{ volumes }}\"\n+      register: brick_list\n+\n+    - set_fact:\n+        volume_bricks: {}\n+\n+    - name: Get the list of bricks into a variable\n+      set_fact:\n+        volume_bricks: \"{{ volume_bricks|combine({item.item: item.stdout}) }}\"\n+      loop: \"{{ brick_list.results }}\"\n+  delegate_to: \"{{ gluster_maintenance_cluster_node }}\"\n+\n+- name: Create the brick directory if not already present","path":"roles/replace_node/tasks/volume.yml","position":29,"original_position":29,"commit_id":"cde92cccc2b486e3d06a8b01a31ae29343613035","original_commit_id":"b7d1994ab1ec5c2414cb659e68eaee6da9cb6379","user":{"login":"sabose","id":6857979,"node_id":"MDQ6VXNlcjY4NTc5Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6857979?v=4","gravatar_id":"","url":"https://api.github.com/users/sabose","html_url":"https://github.com/sabose","followers_url":"https://api.github.com/users/sabose/followers","following_url":"https://api.github.com/users/sabose/following{/other_user}","gists_url":"https://api.github.com/users/sabose/gists{/gist_id}","starred_url":"https://api.github.com/users/sabose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabose/subscriptions","organizations_url":"https://api.github.com/users/sabose/orgs","repos_url":"https://api.github.com/users/sabose/repos","events_url":"https://api.github.com/users/sabose/events{/privacy}","received_events_url":"https://api.github.com/users/sabose/received_events","type":"User","site_admin":false},"body":"What I meant is - get rid of this step - i.e creating directory. Either we do the entire process of provisioning and mounting brick, or assume that the user has already done this","created_at":"2018-08-28T11:56:45Z","updated_at":"2018-08-28T11:58:26Z","html_url":"https://github.com/gluster/gluster-ansible-maintenance/pull/1#discussion_r213283568","pull_request_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/comments/213283568"},"html":{"href":"https://github.com/gluster/gluster-ansible-maintenance/pull/1#discussion_r213283568"},"pull_request":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1"}},"in_reply_to_id":213197747},"pull_request":{"url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1","id":207002323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDAyMzIz","html_url":"https://github.com/gluster/gluster-ansible-maintenance/pull/1","diff_url":"https://github.com/gluster/gluster-ansible-maintenance/pull/1.diff","patch_url":"https://github.com/gluster/gluster-ansible-maintenance/pull/1.patch","issue_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues/1","number":1,"state":"open","locked":false,"title":"replace-node: replace old node with another with the same name","user":{"login":"sac","id":414248,"node_id":"MDQ6VXNlcjQxNDI0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/414248?v=4","gravatar_id":"","url":"https://api.github.com/users/sac","html_url":"https://github.com/sac","followers_url":"https://api.github.com/users/sac/followers","following_url":"https://api.github.com/users/sac/following{/other_user}","gists_url":"https://api.github.com/users/sac/gists{/gist_id}","starred_url":"https://api.github.com/users/sac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sac/subscriptions","organizations_url":"https://api.github.com/users/sac/orgs","repos_url":"https://api.github.com/users/sac/repos","events_url":"https://api.github.com/users/sac/events{/privacy}","received_events_url":"https://api.github.com/users/sac/received_events","type":"User","site_admin":false},"body":"This does not include hyperconverged usecase yet.\r\nHowever, it is not much work from here, it is about adding:\r\n\r\n```\r\n# Switch host into maintenance mode:\r\n- ovirt_hosts:\r\n    state: maintenance\r\n    name: \"{{ gluster_maintenance_old_node }}\"\r\n```\r\n\r\nIn the beginning.","created_at":"2018-08-08T13:10:16Z","updated_at":"2018-08-28T11:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b453be2a710dce8c899737659512dc077aeb5d22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1/commits","review_comments_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1/comments","review_comment_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues/1/comments","statuses_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/statuses/cde92cccc2b486e3d06a8b01a31ae29343613035","head":{"label":"sac:master","ref":"master","sha":"cde92cccc2b486e3d06a8b01a31ae29343613035","user":{"login":"sac","id":414248,"node_id":"MDQ6VXNlcjQxNDI0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/414248?v=4","gravatar_id":"","url":"https://api.github.com/users/sac","html_url":"https://github.com/sac","followers_url":"https://api.github.com/users/sac/followers","following_url":"https://api.github.com/users/sac/following{/other_user}","gists_url":"https://api.github.com/users/sac/gists{/gist_id}","starred_url":"https://api.github.com/users/sac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sac/subscriptions","organizations_url":"https://api.github.com/users/sac/orgs","repos_url":"https://api.github.com/users/sac/repos","events_url":"https://api.github.com/users/sac/events{/privacy}","received_events_url":"https://api.github.com/users/sac/received_events","type":"User","site_admin":false},"repo":{"id":143983225,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5ODMyMjU=","name":"gluster-ansible-maintenance","full_name":"sac/gluster-ansible-maintenance","owner":{"login":"sac","id":414248,"node_id":"MDQ6VXNlcjQxNDI0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/414248?v=4","gravatar_id":"","url":"https://api.github.com/users/sac","html_url":"https://github.com/sac","followers_url":"https://api.github.com/users/sac/followers","following_url":"https://api.github.com/users/sac/following{/other_user}","gists_url":"https://api.github.com/users/sac/gists{/gist_id}","starred_url":"https://api.github.com/users/sac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sac/subscriptions","organizations_url":"https://api.github.com/users/sac/orgs","repos_url":"https://api.github.com/users/sac/repos","events_url":"https://api.github.com/users/sac/events{/privacy}","received_events_url":"https://api.github.com/users/sac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sac/gluster-ansible-maintenance","description":null,"fork":true,"url":"https://api.github.com/repos/sac/gluster-ansible-maintenance","forks_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/forks","keys_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/teams","hooks_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/hooks","issue_events_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/issues/events{/number}","events_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/events","assignees_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/assignees{/user}","branches_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/branches{/branch}","tags_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/tags","blobs_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/git/refs{/sha}","trees_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/statuses/{sha}","languages_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/languages","stargazers_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/stargazers","contributors_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/contributors","subscribers_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/subscribers","subscription_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/subscription","commits_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/commits{/sha}","git_commits_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/git/commits{/sha}","comments_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/comments{/number}","issue_comment_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/issues/comments{/number}","contents_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/contents/{+path}","compare_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/merges","archive_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/downloads","issues_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/issues{/number}","pulls_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/pulls{/number}","milestones_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/milestones{/number}","notifications_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/labels{/name}","releases_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/releases{/id}","deployments_url":"https://api.github.com/repos/sac/gluster-ansible-maintenance/deployments","created_at":"2018-08-08T08:21:37Z","updated_at":"2018-08-28T11:09:07Z","pushed_at":"2018-08-28T11:09:05Z","git_url":"git://github.com/sac/gluster-ansible-maintenance.git","ssh_url":"git@github.com:sac/gluster-ansible-maintenance.git","clone_url":"https://github.com/sac/gluster-ansible-maintenance.git","svn_url":"https://github.com/sac/gluster-ansible-maintenance","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gluster:master","ref":"master","sha":"910feaa1c0bfa55878d2f27c461f25aaba712791","user":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"repo":{"id":143975223,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NzUyMjM=","name":"gluster-ansible-maintenance","full_name":"gluster/gluster-ansible-maintenance","owner":{"login":"gluster","id":622644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/622644?v=4","gravatar_id":"","url":"https://api.github.com/users/gluster","html_url":"https://github.com/gluster","followers_url":"https://api.github.com/users/gluster/followers","following_url":"https://api.github.com/users/gluster/following{/other_user}","gists_url":"https://api.github.com/users/gluster/gists{/gist_id}","starred_url":"https://api.github.com/users/gluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluster/subscriptions","organizations_url":"https://api.github.com/users/gluster/orgs","repos_url":"https://api.github.com/users/gluster/repos","events_url":"https://api.github.com/users/gluster/events{/privacy}","received_events_url":"https://api.github.com/users/gluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gluster/gluster-ansible-maintenance","description":null,"fork":false,"url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance","forks_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/forks","keys_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/teams","hooks_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/hooks","issue_events_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues/events{/number}","events_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/events","assignees_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/assignees{/user}","branches_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/branches{/branch}","tags_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/tags","blobs_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/statuses/{sha}","languages_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/languages","stargazers_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/stargazers","contributors_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/contributors","subscribers_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/subscribers","subscription_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/subscription","commits_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/contents/{+path}","compare_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/merges","archive_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/downloads","issues_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues{/number}","pulls_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls{/number}","milestones_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/milestones{/number}","notifications_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/labels{/name}","releases_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/releases{/id}","deployments_url":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/deployments","created_at":"2018-08-08T07:14:03Z","updated_at":"2018-08-08T07:14:06Z","pushed_at":"2018-08-28T11:09:07Z","git_url":"git://github.com/gluster/gluster-ansible-maintenance.git","ssh_url":"git@github.com:gluster/gluster-ansible-maintenance.git","clone_url":"https://github.com/gluster/gluster-ansible-maintenance.git","svn_url":"https://github.com/gluster/gluster-ansible-maintenance","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1"},"html":{"href":"https://github.com/gluster/gluster-ansible-maintenance/pull/1"},"issue":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues/1"},"comments":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/gluster/gluster-ansible-maintenance/statuses/cde92cccc2b486e3d06a8b01a31ae29343613035"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sabose"}}