{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/ethpm/py-ethpm/pulls/40","id":193477636,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDc3NjM2","html_url":"https://github.com/ethpm/py-ethpm/pull/40","diff_url":"https://github.com/ethpm/py-ethpm/pull/40.diff","patch_url":"https://github.com/ethpm/py-ethpm/pull/40.patch","issue_url":"https://api.github.com/repos/ethpm/py-ethpm/issues/40","number":40,"state":"closed","locked":false,"title":"Improve testing","user":{"login":"njgheorghita","id":9753150,"node_id":"MDQ6VXNlcjk3NTMxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\nConsensus reached on no longer using \"package\" to refer to the manifest. It's better to enforce strict usage of the word \"manifest\" to avoid confusion with the general package concept.\r\n\r\nTesting needed (and still needs) improvement to make sure all the different use-cases are being tested against and not simply one.\r\n\r\n### How was it fixed?\r\nChanged \"package\" -> \"manifest\" where appropriate\r\nExtended testing to include all manifest types where possible. Though further extension is still needed. \r\nMinimal organization of test suite\r\n\r\n#### Cute Animal Picture\r\n![image](https://user-images.githubusercontent.com/9753150/41132111-52c46120-6a7c-11e8-8972-79135c94713f.png)\r\n","created_at":"2018-06-07T23:59:25Z","updated_at":"2018-06-15T20:01:35Z","closed_at":"2018-06-15T20:01:35Z","merged_at":"2018-06-15T20:01:35Z","merge_commit_sha":"6a3764f0a46f697b70406abda046cdce0fe90e98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":752772435,"node_id":"MDU6TGFiZWw3NTI3NzI0MzU=","url":"https://api.github.com/repos/ethpm/py-ethpm/labels/Ready%20For%20Review","name":"Ready For Review","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethpm/py-ethpm/pulls/40/commits","review_comments_url":"https://api.github.com/repos/ethpm/py-ethpm/pulls/40/comments","review_comment_url":"https://api.github.com/repos/ethpm/py-ethpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethpm/py-ethpm/issues/40/comments","statuses_url":"https://api.github.com/repos/ethpm/py-ethpm/statuses/6106c1dc0694be0def993b4d3aa624f903a7ec09","head":{"label":"njgheorghita:improve-testing","ref":"improve-testing","sha":"6106c1dc0694be0def993b4d3aa624f903a7ec09","user":{"login":"njgheorghita","id":9753150,"node_id":"MDQ6VXNlcjk3NTMxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"repo":{"id":111157447,"node_id":"MDEwOlJlcG9zaXRvcnkxMTExNTc0NDc=","name":"py-ethpm","full_name":"njgheorghita/py-ethpm","owner":{"login":"njgheorghita","id":9753150,"node_id":"MDQ6VXNlcjk3NTMxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/njgheorghita/py-ethpm","description":"ERC190 package abstraction for python","fork":true,"url":"https://api.github.com/repos/njgheorghita/py-ethpm","forks_url":"https://api.github.com/repos/njgheorghita/py-ethpm/forks","keys_url":"https://api.github.com/repos/njgheorghita/py-ethpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njgheorghita/py-ethpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njgheorghita/py-ethpm/teams","hooks_url":"https://api.github.com/repos/njgheorghita/py-ethpm/hooks","issue_events_url":"https://api.github.com/repos/njgheorghita/py-ethpm/issues/events{/number}","events_url":"https://api.github.com/repos/njgheorghita/py-ethpm/events","assignees_url":"https://api.github.com/repos/njgheorghita/py-ethpm/assignees{/user}","branches_url":"https://api.github.com/repos/njgheorghita/py-ethpm/branches{/branch}","tags_url":"https://api.github.com/repos/njgheorghita/py-ethpm/tags","blobs_url":"https://api.github.com/repos/njgheorghita/py-ethpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njgheorghita/py-ethpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njgheorghita/py-ethpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/njgheorghita/py-ethpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njgheorghita/py-ethpm/statuses/{sha}","languages_url":"https://api.github.com/repos/njgheorghita/py-ethpm/languages","stargazers_url":"https://api.github.com/repos/njgheorghita/py-ethpm/stargazers","contributors_url":"https://api.github.com/repos/njgheorghita/py-ethpm/contributors","subscribers_url":"https://api.github.com/repos/njgheorghita/py-ethpm/subscribers","subscription_url":"https://api.github.com/repos/njgheorghita/py-ethpm/subscription","commits_url":"https://api.github.com/repos/njgheorghita/py-ethpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/njgheorghita/py-ethpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/njgheorghita/py-ethpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/njgheorghita/py-ethpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/njgheorghita/py-ethpm/contents/{+path}","compare_url":"https://api.github.com/repos/njgheorghita/py-ethpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njgheorghita/py-ethpm/merges","archive_url":"https://api.github.com/repos/njgheorghita/py-ethpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njgheorghita/py-ethpm/downloads","issues_url":"https://api.github.com/repos/njgheorghita/py-ethpm/issues{/number}","pulls_url":"https://api.github.com/repos/njgheorghita/py-ethpm/pulls{/number}","milestones_url":"https://api.github.com/repos/njgheorghita/py-ethpm/milestones{/number}","notifications_url":"https://api.github.com/repos/njgheorghita/py-ethpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njgheorghita/py-ethpm/labels{/name}","releases_url":"https://api.github.com/repos/njgheorghita/py-ethpm/releases{/id}","deployments_url":"https://api.github.com/repos/njgheorghita/py-ethpm/deployments","created_at":"2017-11-17T22:40:00Z","updated_at":"2018-06-01T21:51:56Z","pushed_at":"2018-06-15T16:11:33Z","git_url":"git://github.com/njgheorghita/py-ethpm.git","ssh_url":"git@github.com:njgheorghita/py-ethpm.git","clone_url":"https://github.com/njgheorghita/py-ethpm.git","svn_url":"https://github.com/njgheorghita/py-ethpm","homepage":null,"size":147,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethpm:master","ref":"master","sha":"9e7a9f4d28ad922c9349c1ac9216a328bdb73527","user":{"login":"ethpm","id":19231566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjMxNTY2","avatar_url":"https://avatars2.githubusercontent.com/u/19231566?v=4","gravatar_id":"","url":"https://api.github.com/users/ethpm","html_url":"https://github.com/ethpm","followers_url":"https://api.github.com/users/ethpm/followers","following_url":"https://api.github.com/users/ethpm/following{/other_user}","gists_url":"https://api.github.com/users/ethpm/gists{/gist_id}","starred_url":"https://api.github.com/users/ethpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethpm/subscriptions","organizations_url":"https://api.github.com/users/ethpm/orgs","repos_url":"https://api.github.com/users/ethpm/repos","events_url":"https://api.github.com/users/ethpm/events{/privacy}","received_events_url":"https://api.github.com/users/ethpm/received_events","type":"Organization","site_admin":false},"repo":{"id":104602324,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ2MDIzMjQ=","name":"py-ethpm","full_name":"ethpm/py-ethpm","owner":{"login":"ethpm","id":19231566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjMxNTY2","avatar_url":"https://avatars2.githubusercontent.com/u/19231566?v=4","gravatar_id":"","url":"https://api.github.com/users/ethpm","html_url":"https://github.com/ethpm","followers_url":"https://api.github.com/users/ethpm/followers","following_url":"https://api.github.com/users/ethpm/following{/other_user}","gists_url":"https://api.github.com/users/ethpm/gists{/gist_id}","starred_url":"https://api.github.com/users/ethpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethpm/subscriptions","organizations_url":"https://api.github.com/users/ethpm/orgs","repos_url":"https://api.github.com/users/ethpm/repos","events_url":"https://api.github.com/users/ethpm/events{/privacy}","received_events_url":"https://api.github.com/users/ethpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethpm/py-ethpm","description":"ERC190 package abstraction for python","fork":false,"url":"https://api.github.com/repos/ethpm/py-ethpm","forks_url":"https://api.github.com/repos/ethpm/py-ethpm/forks","keys_url":"https://api.github.com/repos/ethpm/py-ethpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethpm/py-ethpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethpm/py-ethpm/teams","hooks_url":"https://api.github.com/repos/ethpm/py-ethpm/hooks","issue_events_url":"https://api.github.com/repos/ethpm/py-ethpm/issues/events{/number}","events_url":"https://api.github.com/repos/ethpm/py-ethpm/events","assignees_url":"https://api.github.com/repos/ethpm/py-ethpm/assignees{/user}","branches_url":"https://api.github.com/repos/ethpm/py-ethpm/branches{/branch}","tags_url":"https://api.github.com/repos/ethpm/py-ethpm/tags","blobs_url":"https://api.github.com/repos/ethpm/py-ethpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethpm/py-ethpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethpm/py-ethpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethpm/py-ethpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethpm/py-ethpm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethpm/py-ethpm/languages","stargazers_url":"https://api.github.com/repos/ethpm/py-ethpm/stargazers","contributors_url":"https://api.github.com/repos/ethpm/py-ethpm/contributors","subscribers_url":"https://api.github.com/repos/ethpm/py-ethpm/subscribers","subscription_url":"https://api.github.com/repos/ethpm/py-ethpm/subscription","commits_url":"https://api.github.com/repos/ethpm/py-ethpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethpm/py-ethpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethpm/py-ethpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethpm/py-ethpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethpm/py-ethpm/contents/{+path}","compare_url":"https://api.github.com/repos/ethpm/py-ethpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethpm/py-ethpm/merges","archive_url":"https://api.github.com/repos/ethpm/py-ethpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethpm/py-ethpm/downloads","issues_url":"https://api.github.com/repos/ethpm/py-ethpm/issues{/number}","pulls_url":"https://api.github.com/repos/ethpm/py-ethpm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethpm/py-ethpm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethpm/py-ethpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethpm/py-ethpm/labels{/name}","releases_url":"https://api.github.com/repos/ethpm/py-ethpm/releases{/id}","deployments_url":"https://api.github.com/repos/ethpm/py-ethpm/deployments","created_at":"2017-09-23T22:12:00Z","updated_at":"2018-06-13T01:52:15Z","pushed_at":"2018-06-15T20:01:34Z","git_url":"git://github.com/ethpm/py-ethpm.git","ssh_url":"git@github.com:ethpm/py-ethpm.git","clone_url":"https://github.com/ethpm/py-ethpm.git","svn_url":"https://github.com/ethpm/py-ethpm","homepage":null,"size":129,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":9,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethpm/py-ethpm/pulls/40"},"html":{"href":"https://github.com/ethpm/py-ethpm/pull/40"},"issue":{"href":"https://api.github.com/repos/ethpm/py-ethpm/issues/40"},"comments":{"href":"https://api.github.com/repos/ethpm/py-ethpm/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/ethpm/py-ethpm/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/ethpm/py-ethpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethpm/py-ethpm/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/ethpm/py-ethpm/statuses/6106c1dc0694be0def993b4d3aa624f903a7ec09"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"njgheorghita","id":9753150,"node_id":"MDQ6VXNlcjk3NTMxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9753150?v=4","gravatar_id":"","url":"https://api.github.com/users/njgheorghita","html_url":"https://github.com/njgheorghita","followers_url":"https://api.github.com/users/njgheorghita/followers","following_url":"https://api.github.com/users/njgheorghita/following{/other_user}","gists_url":"https://api.github.com/users/njgheorghita/gists{/gist_id}","starred_url":"https://api.github.com/users/njgheorghita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njgheorghita/subscriptions","organizations_url":"https://api.github.com/users/njgheorghita/orgs","repos_url":"https://api.github.com/users/njgheorghita/repos","events_url":"https://api.github.com/users/njgheorghita/events{/privacy}","received_events_url":"https://api.github.com/users/njgheorghita/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":258,"deletions":251,"changed_files":16}}
{"actor":{"display_login":"njgheorghita"}}