{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/2636","repository_url":"https://api.github.com/repos/apache/incubator-dubbo","labels_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/2636/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/2636/comments","events_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/2636/events","html_url":"https://github.com/apache/incubator-dubbo/pull/2636","id":368990848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMDM1MjE4","number":2636,"title":"[Dubbo] move the classes of model from config to rpc-api for reusing","user":{"login":"Jeff-Lv","id":6000915,"node_id":"MDQ6VXNlcjYwMDA5MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6000915?v=4","gravatar_id":"","url":"https://api.github.com/users/Jeff-Lv","html_url":"https://github.com/Jeff-Lv","followers_url":"https://api.github.com/users/Jeff-Lv/followers","following_url":"https://api.github.com/users/Jeff-Lv/following{/other_user}","gists_url":"https://api.github.com/users/Jeff-Lv/gists{/gist_id}","starred_url":"https://api.github.com/users/Jeff-Lv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jeff-Lv/subscriptions","organizations_url":"https://api.github.com/users/Jeff-Lv/orgs","repos_url":"https://api.github.com/users/Jeff-Lv/repos","events_url":"https://api.github.com/users/Jeff-Lv/events{/privacy}","received_events_url":"https://api.github.com/users/Jeff-Lv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-11T07:39:03Z","updated_at":"2018-10-12T03:39:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-dubbo/pulls/2636","html_url":"https://github.com/apache/incubator-dubbo/pull/2636","diff_url":"https://github.com/apache/incubator-dubbo/pull/2636.diff","patch_url":"https://github.com/apache/incubator-dubbo/pull/2636.patch"},"body":"## What is the purpose of the change\r\n\r\nreusing those model in rpc module.\r\n\r\n## Brief changelog\r\n\r\nthe refactor is very safe with unit test convering. "},"comment":{"url":"https://api.github.com/repos/apache/incubator-dubbo/issues/comments/429194307","html_url":"https://github.com/apache/incubator-dubbo/pull/2636#issuecomment-429194307","issue_url":"https://api.github.com/repos/apache/incubator-dubbo/issues/2636","id":429194307,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTE5NDMwNw==","user":{"login":"chickenlj","id":18097545,"node_id":"MDQ6VXNlcjE4MDk3NTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/18097545?v=4","gravatar_id":"","url":"https://api.github.com/users/chickenlj","html_url":"https://github.com/chickenlj","followers_url":"https://api.github.com/users/chickenlj/followers","following_url":"https://api.github.com/users/chickenlj/following{/other_user}","gists_url":"https://api.github.com/users/chickenlj/gists{/gist_id}","starred_url":"https://api.github.com/users/chickenlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chickenlj/subscriptions","organizations_url":"https://api.github.com/users/chickenlj/orgs","repos_url":"https://api.github.com/users/chickenlj/repos","events_url":"https://api.github.com/users/chickenlj/events{/privacy}","received_events_url":"https://api.github.com/users/chickenlj/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T03:39:51Z","updated_at":"2018-10-12T03:39:51Z","author_association":"CONTRIBUTOR","body":"If it prevents reuse when staying in the config module, then let's move these classes to the rpc module. \r\nThis migration will have no effect on other functionalities but for telnet, please make sure telnet still works fine when doing this."}}
{"actor":{"display_login":"chickenlj"}}