{"action":"closed","number":635,"pull_request":{"url":"https://api.github.com/repos/jnunemaker/httparty/pulls/635","id":237554632,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTU0NjMy","html_url":"https://github.com/jnunemaker/httparty/pull/635","diff_url":"https://github.com/jnunemaker/httparty/pull/635.diff","patch_url":"https://github.com/jnunemaker/httparty/pull/635.patch","issue_url":"https://api.github.com/repos/jnunemaker/httparty/issues/635","number":635,"state":"closed","locked":false,"title":"Do not stream the body of redirects","user":{"login":"will3216","id":987328,"node_id":"MDQ6VXNlcjk4NzMyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/987328?v=4","gravatar_id":"","url":"https://api.github.com/users/will3216","html_url":"https://github.com/will3216","followers_url":"https://api.github.com/users/will3216/followers","following_url":"https://api.github.com/users/will3216/following{/other_user}","gists_url":"https://api.github.com/users/will3216/gists{/gist_id}","starred_url":"https://api.github.com/users/will3216/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will3216/subscriptions","organizations_url":"https://api.github.com/users/will3216/orgs","repos_url":"https://api.github.com/users/will3216/repos","events_url":"https://api.github.com/users/will3216/events{/privacy}","received_events_url":"https://api.github.com/users/will3216/received_events","type":"User","site_admin":false},"body":"Currently, if you use the following code, the body of the redirect is written to the provided block in the request.perform method, and there is no external way to differentiate the redirect body from the destination body.\r\n```ruby\r\nres = []\r\nHTTParty.get('http://example.com') do |data|\r\n  res << data\r\nend\r\n```\r\nFor instance, with the above example, imagine the get request to http://example.com returns a page with a status of 302, and a body of \"Redirecting to some other page\". \"Redirecting to some other page\" is going to get written to the block that you provided, even though it's probably not what you want and there is currently no way to tell that the data came from the redirect.\r\n\r\nThus, this adds the `ignore_redirect_body` option which allows you to skip the body of the redirects.","created_at":"2018-12-11T05:26:06Z","updated_at":"2018-12-11T22:35:23Z","closed_at":"2018-12-11T22:35:23Z","merged_at":null,"merge_commit_sha":"abede824dd1496e16b40d29c7456558a52dfb1f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jnunemaker/httparty/pulls/635/commits","review_comments_url":"https://api.github.com/repos/jnunemaker/httparty/pulls/635/comments","review_comment_url":"https://api.github.com/repos/jnunemaker/httparty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jnunemaker/httparty/issues/635/comments","statuses_url":"https://api.github.com/repos/jnunemaker/httparty/statuses/0bf8728749771360516fb433e51155dff2e96864","head":{"label":"will3216:do_not_include_redirect_body_in_stream","ref":"do_not_include_redirect_body_in_stream","sha":"0bf8728749771360516fb433e51155dff2e96864","user":{"login":"will3216","id":987328,"node_id":"MDQ6VXNlcjk4NzMyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/987328?v=4","gravatar_id":"","url":"https://api.github.com/users/will3216","html_url":"https://github.com/will3216","followers_url":"https://api.github.com/users/will3216/followers","following_url":"https://api.github.com/users/will3216/following{/other_user}","gists_url":"https://api.github.com/users/will3216/gists{/gist_id}","starred_url":"https://api.github.com/users/will3216/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will3216/subscriptions","organizations_url":"https://api.github.com/users/will3216/orgs","repos_url":"https://api.github.com/users/will3216/repos","events_url":"https://api.github.com/users/will3216/events{/privacy}","received_events_url":"https://api.github.com/users/will3216/received_events","type":"User","site_admin":false},"repo":{"id":25994088,"node_id":"MDEwOlJlcG9zaXRvcnkyNTk5NDA4OA==","name":"httparty","full_name":"will3216/httparty","private":false,"owner":{"login":"will3216","id":987328,"node_id":"MDQ6VXNlcjk4NzMyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/987328?v=4","gravatar_id":"","url":"https://api.github.com/users/will3216","html_url":"https://github.com/will3216","followers_url":"https://api.github.com/users/will3216/followers","following_url":"https://api.github.com/users/will3216/following{/other_user}","gists_url":"https://api.github.com/users/will3216/gists{/gist_id}","starred_url":"https://api.github.com/users/will3216/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will3216/subscriptions","organizations_url":"https://api.github.com/users/will3216/orgs","repos_url":"https://api.github.com/users/will3216/repos","events_url":"https://api.github.com/users/will3216/events{/privacy}","received_events_url":"https://api.github.com/users/will3216/received_events","type":"User","site_admin":false},"html_url":"https://github.com/will3216/httparty","description":"Makes http fun again!","fork":true,"url":"https://api.github.com/repos/will3216/httparty","forks_url":"https://api.github.com/repos/will3216/httparty/forks","keys_url":"https://api.github.com/repos/will3216/httparty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/will3216/httparty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/will3216/httparty/teams","hooks_url":"https://api.github.com/repos/will3216/httparty/hooks","issue_events_url":"https://api.github.com/repos/will3216/httparty/issues/events{/number}","events_url":"https://api.github.com/repos/will3216/httparty/events","assignees_url":"https://api.github.com/repos/will3216/httparty/assignees{/user}","branches_url":"https://api.github.com/repos/will3216/httparty/branches{/branch}","tags_url":"https://api.github.com/repos/will3216/httparty/tags","blobs_url":"https://api.github.com/repos/will3216/httparty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/will3216/httparty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/will3216/httparty/git/refs{/sha}","trees_url":"https://api.github.com/repos/will3216/httparty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/will3216/httparty/statuses/{sha}","languages_url":"https://api.github.com/repos/will3216/httparty/languages","stargazers_url":"https://api.github.com/repos/will3216/httparty/stargazers","contributors_url":"https://api.github.com/repos/will3216/httparty/contributors","subscribers_url":"https://api.github.com/repos/will3216/httparty/subscribers","subscription_url":"https://api.github.com/repos/will3216/httparty/subscription","commits_url":"https://api.github.com/repos/will3216/httparty/commits{/sha}","git_commits_url":"https://api.github.com/repos/will3216/httparty/git/commits{/sha}","comments_url":"https://api.github.com/repos/will3216/httparty/comments{/number}","issue_comment_url":"https://api.github.com/repos/will3216/httparty/issues/comments{/number}","contents_url":"https://api.github.com/repos/will3216/httparty/contents/{+path}","compare_url":"https://api.github.com/repos/will3216/httparty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/will3216/httparty/merges","archive_url":"https://api.github.com/repos/will3216/httparty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/will3216/httparty/downloads","issues_url":"https://api.github.com/repos/will3216/httparty/issues{/number}","pulls_url":"https://api.github.com/repos/will3216/httparty/pulls{/number}","milestones_url":"https://api.github.com/repos/will3216/httparty/milestones{/number}","notifications_url":"https://api.github.com/repos/will3216/httparty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/will3216/httparty/labels{/name}","releases_url":"https://api.github.com/repos/will3216/httparty/releases{/id}","deployments_url":"https://api.github.com/repos/will3216/httparty/deployments","created_at":"2014-10-30T23:32:55Z","updated_at":"2014-11-03T20:53:22Z","pushed_at":"2018-12-11T22:08:29Z","git_url":"git://github.com/will3216/httparty.git","ssh_url":"git@github.com:will3216/httparty.git","clone_url":"https://github.com/will3216/httparty.git","svn_url":"https://github.com/will3216/httparty","homepage":"http://jnunemaker.github.com/httparty","size":1323,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jnunemaker:master","ref":"master","sha":"e59472b5ba3deb9afef340659ed69bf4504e2554","user":{"login":"jnunemaker","id":235,"node_id":"MDQ6VXNlcjIzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/235?v=4","gravatar_id":"","url":"https://api.github.com/users/jnunemaker","html_url":"https://github.com/jnunemaker","followers_url":"https://api.github.com/users/jnunemaker/followers","following_url":"https://api.github.com/users/jnunemaker/following{/other_user}","gists_url":"https://api.github.com/users/jnunemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/jnunemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnunemaker/subscriptions","organizations_url":"https://api.github.com/users/jnunemaker/orgs","repos_url":"https://api.github.com/users/jnunemaker/repos","events_url":"https://api.github.com/users/jnunemaker/events{/privacy}","received_events_url":"https://api.github.com/users/jnunemaker/received_events","type":"User","site_admin":false},"repo":{"id":37997,"node_id":"MDEwOlJlcG9zaXRvcnkzNzk5Nw==","name":"httparty","full_name":"jnunemaker/httparty","private":false,"owner":{"login":"jnunemaker","id":235,"node_id":"MDQ6VXNlcjIzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/235?v=4","gravatar_id":"","url":"https://api.github.com/users/jnunemaker","html_url":"https://github.com/jnunemaker","followers_url":"https://api.github.com/users/jnunemaker/followers","following_url":"https://api.github.com/users/jnunemaker/following{/other_user}","gists_url":"https://api.github.com/users/jnunemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/jnunemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnunemaker/subscriptions","organizations_url":"https://api.github.com/users/jnunemaker/orgs","repos_url":"https://api.github.com/users/jnunemaker/repos","events_url":"https://api.github.com/users/jnunemaker/events{/privacy}","received_events_url":"https://api.github.com/users/jnunemaker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jnunemaker/httparty","description":":tada: Makes http fun again!","fork":false,"url":"https://api.github.com/repos/jnunemaker/httparty","forks_url":"https://api.github.com/repos/jnunemaker/httparty/forks","keys_url":"https://api.github.com/repos/jnunemaker/httparty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnunemaker/httparty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnunemaker/httparty/teams","hooks_url":"https://api.github.com/repos/jnunemaker/httparty/hooks","issue_events_url":"https://api.github.com/repos/jnunemaker/httparty/issues/events{/number}","events_url":"https://api.github.com/repos/jnunemaker/httparty/events","assignees_url":"https://api.github.com/repos/jnunemaker/httparty/assignees{/user}","branches_url":"https://api.github.com/repos/jnunemaker/httparty/branches{/branch}","tags_url":"https://api.github.com/repos/jnunemaker/httparty/tags","blobs_url":"https://api.github.com/repos/jnunemaker/httparty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnunemaker/httparty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnunemaker/httparty/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnunemaker/httparty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnunemaker/httparty/statuses/{sha}","languages_url":"https://api.github.com/repos/jnunemaker/httparty/languages","stargazers_url":"https://api.github.com/repos/jnunemaker/httparty/stargazers","contributors_url":"https://api.github.com/repos/jnunemaker/httparty/contributors","subscribers_url":"https://api.github.com/repos/jnunemaker/httparty/subscribers","subscription_url":"https://api.github.com/repos/jnunemaker/httparty/subscription","commits_url":"https://api.github.com/repos/jnunemaker/httparty/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnunemaker/httparty/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnunemaker/httparty/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnunemaker/httparty/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnunemaker/httparty/contents/{+path}","compare_url":"https://api.github.com/repos/jnunemaker/httparty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnunemaker/httparty/merges","archive_url":"https://api.github.com/repos/jnunemaker/httparty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnunemaker/httparty/downloads","issues_url":"https://api.github.com/repos/jnunemaker/httparty/issues{/number}","pulls_url":"https://api.github.com/repos/jnunemaker/httparty/pulls{/number}","milestones_url":"https://api.github.com/repos/jnunemaker/httparty/milestones{/number}","notifications_url":"https://api.github.com/repos/jnunemaker/httparty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnunemaker/httparty/labels{/name}","releases_url":"https://api.github.com/repos/jnunemaker/httparty/releases{/id}","deployments_url":"https://api.github.com/repos/jnunemaker/httparty/deployments","created_at":"2008-07-28T20:55:11Z","updated_at":"2018-12-10T23:00:38Z","pushed_at":"2018-12-11T22:08:31Z","git_url":"git://github.com/jnunemaker/httparty.git","ssh_url":"git@github.com:jnunemaker/httparty.git","clone_url":"https://github.com/jnunemaker/httparty.git","svn_url":"https://github.com/jnunemaker/httparty","homepage":"","size":1316,"stargazers_count":4718,"watchers_count":4718,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":823,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":823,"open_issues":41,"watchers":4718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jnunemaker/httparty/pulls/635"},"html":{"href":"https://github.com/jnunemaker/httparty/pull/635"},"issue":{"href":"https://api.github.com/repos/jnunemaker/httparty/issues/635"},"comments":{"href":"https://api.github.com/repos/jnunemaker/httparty/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/jnunemaker/httparty/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/jnunemaker/httparty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jnunemaker/httparty/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/jnunemaker/httparty/statuses/0bf8728749771360516fb433e51155dff2e96864"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"will3216"}}