{"action":"created","comment":{"url":"https://api.github.com/repos/thought-machine/please/pulls/comments/221450976","pull_request_review_id":159919637,"id":221450976,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQ1MDk3Ng==","diff_hunk":"@@ -0,0 +1,75 @@\n+package main\n+\n+import (\n+\t\"context\"\n+\t\"gopkg.in/op/go-logging.v1\"\n+\t\"os\"\n+\n+\t\"cli\"\n+\t\"github.com/sourcegraph/jsonrpc2\"\n+\t\"tools/build_langserver/langserver\"\n+)\n+\n+// TODO(bnmetrics): also think about how we can implement this with .build_defs as well\n+// TODO(bnmetrics): Make the Usage part better\n+var log = logging.MustGetLogger(\"build_langserver\")\n+\n+var opts = struct {\n+\tUsage     string\n+\tVerbosity cli.Verbosity `short:\"v\" long:\"verbosity\" default:\"warning\" description:\"Verbosity of output (higher number = more output)\"`\n+\n+\tMode string `short:\"m\" long:\"mode\" default:\"stdio\" description:\"Mode of the language server communication (stdio|tcp)\"`","path":"tools/build_langserver/langserver_main.go","position":21,"original_position":21,"commit_id":"d4828e5bf26fec1cd406eb7bb885bd23317d7173","original_commit_id":"d4828e5bf26fec1cd406eb7bb885bd23317d7173","user":{"login":"peterebden","id":1479315,"node_id":"MDQ6VXNlcjE0NzkzMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1479315?v=4","gravatar_id":"","url":"https://api.github.com/users/peterebden","html_url":"https://github.com/peterebden","followers_url":"https://api.github.com/users/peterebden/followers","following_url":"https://api.github.com/users/peterebden/following{/other_user}","gists_url":"https://api.github.com/users/peterebden/gists{/gist_id}","starred_url":"https://api.github.com/users/peterebden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterebden/subscriptions","organizations_url":"https://api.github.com/users/peterebden/orgs","repos_url":"https://api.github.com/users/peterebden/repos","events_url":"https://api.github.com/users/peterebden/events{/privacy}","received_events_url":"https://api.github.com/users/peterebden/received_events","type":"User","site_admin":false},"body":"FYI the flags thing can do this for you:\r\n```\r\nchoice:\"stdio\" choice:\"tcp\" description:\"Mode of the language server communication\"\r\n```\r\nIt'll enforce the appropriate values & generate nice help too.","created_at":"2018-09-30T08:03:45Z","updated_at":"2018-09-30T08:09:34Z","html_url":"https://github.com/thought-machine/please/pull/415#discussion_r221450976","pull_request_url":"https://api.github.com/repos/thought-machine/please/pulls/415","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thought-machine/please/pulls/comments/221450976"},"html":{"href":"https://github.com/thought-machine/please/pull/415#discussion_r221450976"},"pull_request":{"href":"https://api.github.com/repos/thought-machine/please/pulls/415"}}},"pull_request":{"url":"https://api.github.com/repos/thought-machine/please/pulls/415","id":219011403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDExNDAz","html_url":"https://github.com/thought-machine/please/pull/415","diff_url":"https://github.com/thought-machine/please/pull/415.diff","patch_url":"https://github.com/thought-machine/please/pull/415.patch","issue_url":"https://api.github.com/repos/thought-machine/please/issues/415","number":415,"state":"open","locked":false,"title":"Basic structure of LSP and the initialization part","user":{"login":"BNMetrics","id":24975007,"node_id":"MDQ6VXNlcjI0OTc1MDA3","avatar_url":"https://avatars2.githubusercontent.com/u/24975007?v=4","gravatar_id":"","url":"https://api.github.com/users/BNMetrics","html_url":"https://github.com/BNMetrics","followers_url":"https://api.github.com/users/BNMetrics/followers","following_url":"https://api.github.com/users/BNMetrics/following{/other_user}","gists_url":"https://api.github.com/users/BNMetrics/gists{/gist_id}","starred_url":"https://api.github.com/users/BNMetrics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BNMetrics/subscriptions","organizations_url":"https://api.github.com/users/BNMetrics/orgs","repos_url":"https://api.github.com/users/BNMetrics/repos","events_url":"https://api.github.com/users/BNMetrics/events{/privacy}","received_events_url":"https://api.github.com/users/BNMetrics/received_events","type":"User","site_admin":false},"body":"As titled.\r\n- Rough draft stage\r\n- Many things are subjected to change","created_at":"2018-09-28T15:48:30Z","updated_at":"2018-09-30T08:09:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e8a359ed7d123403675a9472c41daadaec6409d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thought-machine/please/pulls/415/commits","review_comments_url":"https://api.github.com/repos/thought-machine/please/pulls/415/comments","review_comment_url":"https://api.github.com/repos/thought-machine/please/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thought-machine/please/issues/415/comments","statuses_url":"https://api.github.com/repos/thought-machine/please/statuses/d4828e5bf26fec1cd406eb7bb885bd23317d7173","head":{"label":"thought-machine:luna_lsp","ref":"luna_lsp","sha":"d4828e5bf26fec1cd406eb7bb885bd23317d7173","user":{"login":"thought-machine","id":16104327,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA0MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/16104327?v=4","gravatar_id":"","url":"https://api.github.com/users/thought-machine","html_url":"https://github.com/thought-machine","followers_url":"https://api.github.com/users/thought-machine/followers","following_url":"https://api.github.com/users/thought-machine/following{/other_user}","gists_url":"https://api.github.com/users/thought-machine/gists{/gist_id}","starred_url":"https://api.github.com/users/thought-machine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thought-machine/subscriptions","organizations_url":"https://api.github.com/users/thought-machine/orgs","repos_url":"https://api.github.com/users/thought-machine/repos","events_url":"https://api.github.com/users/thought-machine/events{/privacy}","received_events_url":"https://api.github.com/users/thought-machine/received_events","type":"Organization","site_admin":false},"repo":{"id":50915867,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkxNTg2Nw==","name":"please","full_name":"thought-machine/please","private":false,"owner":{"login":"thought-machine","id":16104327,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA0MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/16104327?v=4","gravatar_id":"","url":"https://api.github.com/users/thought-machine","html_url":"https://github.com/thought-machine","followers_url":"https://api.github.com/users/thought-machine/followers","following_url":"https://api.github.com/users/thought-machine/following{/other_user}","gists_url":"https://api.github.com/users/thought-machine/gists{/gist_id}","starred_url":"https://api.github.com/users/thought-machine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thought-machine/subscriptions","organizations_url":"https://api.github.com/users/thought-machine/orgs","repos_url":"https://api.github.com/users/thought-machine/repos","events_url":"https://api.github.com/users/thought-machine/events{/privacy}","received_events_url":"https://api.github.com/users/thought-machine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thought-machine/please","description":"High-performance extensible build system for reproducible builds.","fork":false,"url":"https://api.github.com/repos/thought-machine/please","forks_url":"https://api.github.com/repos/thought-machine/please/forks","keys_url":"https://api.github.com/repos/thought-machine/please/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thought-machine/please/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thought-machine/please/teams","hooks_url":"https://api.github.com/repos/thought-machine/please/hooks","issue_events_url":"https://api.github.com/repos/thought-machine/please/issues/events{/number}","events_url":"https://api.github.com/repos/thought-machine/please/events","assignees_url":"https://api.github.com/repos/thought-machine/please/assignees{/user}","branches_url":"https://api.github.com/repos/thought-machine/please/branches{/branch}","tags_url":"https://api.github.com/repos/thought-machine/please/tags","blobs_url":"https://api.github.com/repos/thought-machine/please/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thought-machine/please/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thought-machine/please/git/refs{/sha}","trees_url":"https://api.github.com/repos/thought-machine/please/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thought-machine/please/statuses/{sha}","languages_url":"https://api.github.com/repos/thought-machine/please/languages","stargazers_url":"https://api.github.com/repos/thought-machine/please/stargazers","contributors_url":"https://api.github.com/repos/thought-machine/please/contributors","subscribers_url":"https://api.github.com/repos/thought-machine/please/subscribers","subscription_url":"https://api.github.com/repos/thought-machine/please/subscription","commits_url":"https://api.github.com/repos/thought-machine/please/commits{/sha}","git_commits_url":"https://api.github.com/repos/thought-machine/please/git/commits{/sha}","comments_url":"https://api.github.com/repos/thought-machine/please/comments{/number}","issue_comment_url":"https://api.github.com/repos/thought-machine/please/issues/comments{/number}","contents_url":"https://api.github.com/repos/thought-machine/please/contents/{+path}","compare_url":"https://api.github.com/repos/thought-machine/please/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thought-machine/please/merges","archive_url":"https://api.github.com/repos/thought-machine/please/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thought-machine/please/downloads","issues_url":"https://api.github.com/repos/thought-machine/please/issues{/number}","pulls_url":"https://api.github.com/repos/thought-machine/please/pulls{/number}","milestones_url":"https://api.github.com/repos/thought-machine/please/milestones{/number}","notifications_url":"https://api.github.com/repos/thought-machine/please/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thought-machine/please/labels{/name}","releases_url":"https://api.github.com/repos/thought-machine/please/releases{/id}","deployments_url":"https://api.github.com/repos/thought-machine/please/deployments","created_at":"2016-02-02T11:27:05Z","updated_at":"2018-09-28T15:51:33Z","pushed_at":"2018-09-28T17:46:52Z","git_url":"git://github.com/thought-machine/please.git","ssh_url":"git@github.com:thought-machine/please.git","clone_url":"https://github.com/thought-machine/please.git","svn_url":"https://github.com/thought-machine/please","homepage":"https://please.build","size":5028,"stargazers_count":441,"watchers_count":441,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":17,"watchers":441,"default_branch":"master"}},"base":{"label":"thought-machine:master","ref":"master","sha":"a17957c621b7d7d473a135ff16dccfad0b23f61c","user":{"login":"thought-machine","id":16104327,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA0MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/16104327?v=4","gravatar_id":"","url":"https://api.github.com/users/thought-machine","html_url":"https://github.com/thought-machine","followers_url":"https://api.github.com/users/thought-machine/followers","following_url":"https://api.github.com/users/thought-machine/following{/other_user}","gists_url":"https://api.github.com/users/thought-machine/gists{/gist_id}","starred_url":"https://api.github.com/users/thought-machine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thought-machine/subscriptions","organizations_url":"https://api.github.com/users/thought-machine/orgs","repos_url":"https://api.github.com/users/thought-machine/repos","events_url":"https://api.github.com/users/thought-machine/events{/privacy}","received_events_url":"https://api.github.com/users/thought-machine/received_events","type":"Organization","site_admin":false},"repo":{"id":50915867,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkxNTg2Nw==","name":"please","full_name":"thought-machine/please","private":false,"owner":{"login":"thought-machine","id":16104327,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA0MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/16104327?v=4","gravatar_id":"","url":"https://api.github.com/users/thought-machine","html_url":"https://github.com/thought-machine","followers_url":"https://api.github.com/users/thought-machine/followers","following_url":"https://api.github.com/users/thought-machine/following{/other_user}","gists_url":"https://api.github.com/users/thought-machine/gists{/gist_id}","starred_url":"https://api.github.com/users/thought-machine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thought-machine/subscriptions","organizations_url":"https://api.github.com/users/thought-machine/orgs","repos_url":"https://api.github.com/users/thought-machine/repos","events_url":"https://api.github.com/users/thought-machine/events{/privacy}","received_events_url":"https://api.github.com/users/thought-machine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thought-machine/please","description":"High-performance extensible build system for reproducible builds.","fork":false,"url":"https://api.github.com/repos/thought-machine/please","forks_url":"https://api.github.com/repos/thought-machine/please/forks","keys_url":"https://api.github.com/repos/thought-machine/please/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thought-machine/please/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thought-machine/please/teams","hooks_url":"https://api.github.com/repos/thought-machine/please/hooks","issue_events_url":"https://api.github.com/repos/thought-machine/please/issues/events{/number}","events_url":"https://api.github.com/repos/thought-machine/please/events","assignees_url":"https://api.github.com/repos/thought-machine/please/assignees{/user}","branches_url":"https://api.github.com/repos/thought-machine/please/branches{/branch}","tags_url":"https://api.github.com/repos/thought-machine/please/tags","blobs_url":"https://api.github.com/repos/thought-machine/please/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thought-machine/please/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thought-machine/please/git/refs{/sha}","trees_url":"https://api.github.com/repos/thought-machine/please/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thought-machine/please/statuses/{sha}","languages_url":"https://api.github.com/repos/thought-machine/please/languages","stargazers_url":"https://api.github.com/repos/thought-machine/please/stargazers","contributors_url":"https://api.github.com/repos/thought-machine/please/contributors","subscribers_url":"https://api.github.com/repos/thought-machine/please/subscribers","subscription_url":"https://api.github.com/repos/thought-machine/please/subscription","commits_url":"https://api.github.com/repos/thought-machine/please/commits{/sha}","git_commits_url":"https://api.github.com/repos/thought-machine/please/git/commits{/sha}","comments_url":"https://api.github.com/repos/thought-machine/please/comments{/number}","issue_comment_url":"https://api.github.com/repos/thought-machine/please/issues/comments{/number}","contents_url":"https://api.github.com/repos/thought-machine/please/contents/{+path}","compare_url":"https://api.github.com/repos/thought-machine/please/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thought-machine/please/merges","archive_url":"https://api.github.com/repos/thought-machine/please/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thought-machine/please/downloads","issues_url":"https://api.github.com/repos/thought-machine/please/issues{/number}","pulls_url":"https://api.github.com/repos/thought-machine/please/pulls{/number}","milestones_url":"https://api.github.com/repos/thought-machine/please/milestones{/number}","notifications_url":"https://api.github.com/repos/thought-machine/please/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thought-machine/please/labels{/name}","releases_url":"https://api.github.com/repos/thought-machine/please/releases{/id}","deployments_url":"https://api.github.com/repos/thought-machine/please/deployments","created_at":"2016-02-02T11:27:05Z","updated_at":"2018-09-28T15:51:33Z","pushed_at":"2018-09-28T17:46:52Z","git_url":"git://github.com/thought-machine/please.git","ssh_url":"git@github.com:thought-machine/please.git","clone_url":"https://github.com/thought-machine/please.git","svn_url":"https://github.com/thought-machine/please","homepage":"https://please.build","size":5028,"stargazers_count":441,"watchers_count":441,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":37,"open_issues":17,"watchers":441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thought-machine/please/pulls/415"},"html":{"href":"https://github.com/thought-machine/please/pull/415"},"issue":{"href":"https://api.github.com/repos/thought-machine/please/issues/415"},"comments":{"href":"https://api.github.com/repos/thought-machine/please/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/thought-machine/please/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/thought-machine/please/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thought-machine/please/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/thought-machine/please/statuses/d4828e5bf26fec1cd406eb7bb885bd23317d7173"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"peterebden"}}