{"action":"created","issue":{"url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/issues/2","repository_url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements","labels_url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/issues/2/comments","events_url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/issues/2/events","html_url":"https://github.com/elishacloud/Silent-Hill-2-Enhancements/issues/2","id":310155431,"number":2,"title":"Lighting transition isn't smooth from one light source to another for a few particular areas","user":{"login":"Polymega","id":27395260,"avatar_url":"https://avatars0.githubusercontent.com/u/27395260?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymega","html_url":"https://github.com/Polymega","followers_url":"https://api.github.com/users/Polymega/followers","following_url":"https://api.github.com/users/Polymega/following{/other_user}","gists_url":"https://api.github.com/users/Polymega/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymega/subscriptions","organizations_url":"https://api.github.com/users/Polymega/orgs","repos_url":"https://api.github.com/users/Polymega/repos","events_url":"https://api.github.com/users/Polymega/events{/privacy}","received_events_url":"https://api.github.com/users/Polymega/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":38,"created_at":"2018-03-30T20:00:44Z","updated_at":"2018-05-23T18:57:27Z","closed_at":null,"author_association":"NONE","body":"Hi Elisha, \r\n\r\nThere's some particular rooms/areas in SH2 where the light source hitting James doesn't smoothly transition to the next (or lack thereof)  light source: \r\n\r\n**Blue Creek Apt. Room 203:**\r\nPC (bugged): https://youtu.be/VYTwfYWlxiw\r\n[Quick Save save file of this area](https://github.com/elishacloud/Silent-Hill-2-Enhancements/files/1864661/sh2pcsave1c.zip)\r\nPS2/Xbox (correct): https://youtu.be/32hlmhHUBPg\r\n\r\n**Alternate Hotel Hallway**\r\nPC (bugged): https://youtu.be/EknxF3p4KuM\r\n[Quick Save save file of this area](https://github.com/elishacloud/Silent-Hill-2-Enhancements/files/1986415/sh2pcsave1c.zip)\r\nPS2/Xbox (correct): https://youtu.be/PMlu8UCsIf8\r\n\r\nI've tested this on the vanilla PC version (no fix packages), using the ENB converter, and the D3D8to9 converter and they all experience this same issue. \r\n\r\nAnd there are other areas in the PC game where multiple light sources in one scene smoothly hit James as seen here which tells me this should be able to work in these areas?: \r\nhttps://youtu.be/kMA8Omf1i8s?t=41s\r\n\r\nI was wondering if this is something that could be looked in to and is an issue similar in spirit to the old flashlight bug as discussed here: \r\nhttps://github.com/crosire/d3d8to9/issues/56 \r\n\r\nNo rush or anything for this (especially as we're trucking along with the Enhanced Audio mod at this moment) but I wanted to submit a ticket while it was on my mind and for prosperity purposes. "},"comment":{"url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/issues/comments/391459448","html_url":"https://github.com/elishacloud/Silent-Hill-2-Enhancements/issues/2#issuecomment-391459448","issue_url":"https://api.github.com/repos/elishacloud/Silent-Hill-2-Enhancements/issues/2","id":391459448,"user":{"login":"Bigmanjapan","id":31383389,"avatar_url":"https://avatars1.githubusercontent.com/u/31383389?v=4","gravatar_id":"","url":"https://api.github.com/users/Bigmanjapan","html_url":"https://github.com/Bigmanjapan","followers_url":"https://api.github.com/users/Bigmanjapan/followers","following_url":"https://api.github.com/users/Bigmanjapan/following{/other_user}","gists_url":"https://api.github.com/users/Bigmanjapan/gists{/gist_id}","starred_url":"https://api.github.com/users/Bigmanjapan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bigmanjapan/subscriptions","organizations_url":"https://api.github.com/users/Bigmanjapan/orgs","repos_url":"https://api.github.com/users/Bigmanjapan/repos","events_url":"https://api.github.com/users/Bigmanjapan/events{/privacy}","received_events_url":"https://api.github.com/users/Bigmanjapan/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T18:57:27Z","updated_at":"2018-05-23T18:57:27Z","author_association":"NONE","body":"I have a semi decent solution for the problem which involves manipulating lightning source around the room and making use of it's bottom side (which also have a properly working diffusion). Although this way James model is slightly less lit when he's near the widnow because light source is shifted way above the room. \r\n\r\nThat being said, I don't want to suggest this solution until it's 100% confirmed that the diffusion cannot be fixed enabling or restoring it.\r\n\r\nLight source in ap64 is controlled via small memory region. In the next picture you can see two CE tables being opened — left for PC addresses, right for PS2 addresses. https://i.imgur.com/V9TjCDG.png\r\nThere are three different values in this memory region between the tables (highlighted), moving values from PS2 memory region to PC memory region does nothing to fix the lightning issue.\r\n\r\nNext, I managed to replicate the issue on PS2 build. Apparently if some functions that access certain addresses are disabled than the diffusion stops working. https://youtu.be/Pskp_qn1HUs Meaning that it might be possible to research those PS2 functions and replicate them on PC build. I have a limited knowledge of MIPS ASM, so maybe @AeroWidescreen can do it.\r\n\r\nCE tables for anyone how is up to the task (try playing around with the values, those control various light source parameters):\r\n\r\n[PCSX2_SH220228GH_ap64_light_source.zip](https://github.com/elishacloud/Silent-Hill-2-Enhancements/files/2032349/PCSX2_SH220228GH_ap64_light_source.zip)\r\n\r\n[PC_SH2WSF_ap64_lightning_source.zip](https://github.com/elishacloud/Silent-Hill-2-Enhancements/files/2032350/PC_SH2WSF_ap64_lightning_source.zip)\r\n\r\n>Nice! Is there anything hidden or any cool things you can play around with that (just for fun)?\r\n\r\nhttps://youtu.be/JMDpYpdkojc\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"Bigmanjapan"}}