{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18711","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18711/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18711/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18711/events","html_url":"https://github.com/magento/magento2/pull/18711","id":372089332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mzg5NTEw","number":18711,"title":"[Forwardport] Module Catalog URL Rewrite: fix issue with product URL Rewrites re-generation after changing product URL Key for product with existing url_path attribute value","user":{"login":"mage2pratik","id":33807558,"node_id":"MDQ6VXNlcjMzODA3NTU4","avatar_url":"https://avatars1.githubusercontent.com/u/33807558?v=4","gravatar_id":"","url":"https://api.github.com/users/mage2pratik","html_url":"https://github.com/mage2pratik","followers_url":"https://api.github.com/users/mage2pratik/followers","following_url":"https://api.github.com/users/mage2pratik/following{/other_user}","gists_url":"https://api.github.com/users/mage2pratik/gists{/gist_id}","starred_url":"https://api.github.com/users/mage2pratik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mage2pratik/subscriptions","organizations_url":"https://api.github.com/users/mage2pratik/orgs","repos_url":"https://api.github.com/users/mage2pratik/repos","events_url":"https://api.github.com/users/mage2pratik/events{/privacy}","received_events_url":"https://api.github.com/users/mage2pratik/received_events","type":"User","site_admin":false},"labels":[{"id":378615777,"node_id":"MDU6TGFiZWwzNzg2MTU3Nzc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20CatalogUrlRewrite","name":"Component: CatalogUrlRewrite","color":"7fb703","default":false},{"id":1036594924,"node_id":"MDU6TGFiZWwxMDM2NTk0OTI0","url":"https://api.github.com/repos/magento/magento2/labels/Partner:%20Krish%20TechnoLabs","name":"Partner: Krish TechnoLabs","color":"f9d0c4","default":false},{"id":161563561,"node_id":"MDU6TGFiZWwxNjE1NjM1NjE=","url":"https://api.github.com/repos/magento/magento2/labels/Progress:%20needs%20update","name":"Progress: needs update","color":"b60205","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false},{"id":882948356,"node_id":"MDU6TGFiZWw4ODI5NDgzNTY=","url":"https://api.github.com/repos/magento/magento2/labels/partners-contribution","name":"partners-contribution","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"slavvka","id":9741905,"node_id":"MDQ6VXNlcjk3NDE5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/9741905?v=4","gravatar_id":"","url":"https://api.github.com/users/slavvka","html_url":"https://github.com/slavvka","followers_url":"https://api.github.com/users/slavvka/followers","following_url":"https://api.github.com/users/slavvka/following{/other_user}","gists_url":"https://api.github.com/users/slavvka/gists{/gist_id}","starred_url":"https://api.github.com/users/slavvka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavvka/subscriptions","organizations_url":"https://api.github.com/users/slavvka/orgs","repos_url":"https://api.github.com/users/slavvka/repos","events_url":"https://api.github.com/users/slavvka/events{/privacy}","received_events_url":"https://api.github.com/users/slavvka/received_events","type":"User","site_admin":false},"assignees":[{"login":"slavvka","id":9741905,"node_id":"MDQ6VXNlcjk3NDE5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/9741905?v=4","gravatar_id":"","url":"https://api.github.com/users/slavvka","html_url":"https://github.com/slavvka","followers_url":"https://api.github.com/users/slavvka/followers","following_url":"https://api.github.com/users/slavvka/following{/other_user}","gists_url":"https://api.github.com/users/slavvka/gists{/gist_id}","starred_url":"https://api.github.com/users/slavvka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavvka/subscriptions","organizations_url":"https://api.github.com/users/slavvka/orgs","repos_url":"https://api.github.com/users/slavvka/repos","events_url":"https://api.github.com/users/slavvka/events{/privacy}","received_events_url":"https://api.github.com/users/slavvka/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/23","html_url":"https://github.com/magento/magento2/milestone/23","labels_url":"https://api.github.com/repos/magento/magento2/milestones/23/labels","id":3664445,"node_id":"MDk6TWlsZXN0b25lMzY2NDQ0NQ==","number":23,"title":"Release: 2.3.1","description":"Community pull requests delivered to Release: 2.3.1 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":96,"closed_issues":131,"state":"open","created_at":"2018-09-18T07:31:32Z","updated_at":"2018-10-25T19:20:10Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-10-19T19:36:20Z","updated_at":"2018-10-25T19:20:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18711","html_url":"https://github.com/magento/magento2/pull/18711","diff_url":"https://github.com/magento/magento2/pull/18711.diff","patch_url":"https://github.com/magento/magento2/pull/18711.patch"},"body":"### Original Pull Request \r\n https://github.com/magento/magento2/pull/18566\r\n\r\n<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios\r\n    Fields marked with (*) are required. Please don't remove the template.\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\nHiving saved product attribute `URL Path` value causes broken Product URL Rewrites regeneration after changing product `URL key`.\r\n\r\n### Description (*)\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\nIf there is a product with set `URL Path` attribute value, product URL Rewrites can't be re-generated clearly after changing product `URL Key` from Admin panel.\r\nFor example, after migrating from Magento 1, there are a lot of values for product attribute `URL Path`.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\nmagento/magento2#5929: Saving Product does not update URL rewrite in Magento 2.1.0.\r\n\r\n### Causes Issues\r\nmagento/magento2#18532: Module Catalog: product \"Save and Duplicate\" causes getting infinite loop.\r\n\r\n### Manual testing scenarios (*)\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. Set attribute `URL Path` value for any product.\r\n1.1. For example, execute following SQL query:\r\n```sql\r\nSET @catalogProductEntityTypeId = (SELECT `entity_type_id`\r\n                                   FROM `eav_entity_type`\r\n                                   WHERE entity_type_code = 'catalog_product');\r\n\r\nSET @productUrlPathAttributeId = (SELECT `attribute_id`\r\n                                  FROM `eav_attribute`\r\n                                  WHERE `attribute_code` = 'url_path'\r\n                                    AND entity_type_id = @catalogProductEntityTypeId);\r\n\r\nSET @productUrlKeyAttributeId = (SELECT `attribute_id`\r\n                                 FROM `eav_attribute`\r\n                                 WHERE `attribute_code` = 'url_key'\r\n                                   AND `entity_type_id` = @catalogProductEntityTypeId);\r\n\r\nSET @storeId = 1; -- change Store ID if it's required\r\n\r\nSET @testProductId = 1; -- change Product ID if it's required\r\n\r\nSET @existingProductUrlKey = (SELECT `value`\r\n                              FROM `catalog_product_entity_varchar`\r\n                              WHERE `entity_id` = @testProductId\r\n                                AND `attribute_id` = @productUrlKeyAttributeId); -- any value could be there\r\n\r\nINSERT INTO `catalog_product_entity_varchar` (`attribute_id`, `store_id`, `entity_id`, `value`)\r\n    VALUES (@productUrlPathAttributeId, @storeId, @testProductId, @existingProductUrlKey);\r\n\r\n```\r\n2. Go to Admin panel -> Catalog -> Inventory -> Products.\r\n3. Find and open testable product.\r\n4. Change `URL Key` field value.\r\n5. Save product.\r\n6. Go to product page on frontend by new `URL Key`.\r\n\r\n### Expected result\r\nProduct is available by the new `URL Key`.\r\n\r\n### Actual result\r\nProduct is not available by the new `URL Key`, but available by the previous one.\r\n\r\n### Contribution checklist (*)\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/433173823","html_url":"https://github.com/magento/magento2/pull/18711#issuecomment-433173823","issue_url":"https://api.github.com/repos/magento/magento2/issues/18711","id":433173823,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzE3MzgyMw==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T19:20:37Z","updated_at":"2018-10-25T19:20:37Z","author_association":"CONTRIBUTOR","body":"Hi @slavvka, thank you for the review.\n[ENGCOM-3277](https://jira.corp.magento.com/browse/ENGCOM-3277) has been created to process this Pull Request"}}
{"actor":{"display_login":"magento-engcom-team"}}