{"action":"created","comment":{"url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/comments/193283441","pull_request_review_id":126221296,"id":193283441,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzI4MzQ0MQ==","diff_hunk":"@@ -0,0 +1,466 @@\n+//! Recovers high-level control-flow constructs from a control-flow graph.\n+//! Implements the algorithm described in\n+//! [*No More Gotos*](https://doi.org/10.14722/ndss.2015.23185)","path":"src/backend/ctrl_flow_struct/mod.rs","position":3,"original_position":3,"commit_id":"cdd0f84a291d0a390a36f3a2ef9c2337e069250d","original_commit_id":"cdd0f84a291d0a390a36f3a2ef9c2337e069250d","user":{"login":"sushant94","id":3993360,"node_id":"MDQ6VXNlcjM5OTMzNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3993360?v=4","gravatar_id":"","url":"https://api.github.com/users/sushant94","html_url":"https://github.com/sushant94","followers_url":"https://api.github.com/users/sushant94/followers","following_url":"https://api.github.com/users/sushant94/following{/other_user}","gists_url":"https://api.github.com/users/sushant94/gists{/gist_id}","starred_url":"https://api.github.com/users/sushant94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushant94/subscriptions","organizations_url":"https://api.github.com/users/sushant94/orgs","repos_url":"https://api.github.com/users/sushant94/repos","events_url":"https://api.github.com/users/sushant94/events{/privacy}","received_events_url":"https://api.github.com/users/sushant94/received_events","type":"User","site_admin":false},"body":"Include a comment for every submodule, what they provide and how it helps this algorithm. Essentially giving a high level picture of how the different parts of this module work together.","created_at":"2018-06-06T03:36:46Z","updated_at":"2018-06-06T03:40:39Z","html_url":"https://github.com/radareorg/radeco-lib/pull/160#discussion_r193283441","pull_request_url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/radareorg/radeco-lib/pulls/comments/193283441"},"html":{"href":"https://github.com/radareorg/radeco-lib/pull/160#discussion_r193283441"},"pull_request":{"href":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160","id":190415768,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNDE1NzY4","html_url":"https://github.com/radareorg/radeco-lib/pull/160","diff_url":"https://github.com/radareorg/radeco-lib/pull/160.diff","patch_url":"https://github.com/radareorg/radeco-lib/pull/160.patch","issue_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/160","number":160,"state":"open","locked":false,"title":"Control Flow Structuring","user":{"login":"HMPerson1","id":2219904,"node_id":"MDQ6VXNlcjIyMTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2219904?v=4","gravatar_id":"","url":"https://api.github.com/users/HMPerson1","html_url":"https://github.com/HMPerson1","followers_url":"https://api.github.com/users/HMPerson1/followers","following_url":"https://api.github.com/users/HMPerson1/following{/other_user}","gists_url":"https://api.github.com/users/HMPerson1/gists{/gist_id}","starred_url":"https://api.github.com/users/HMPerson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HMPerson1/subscriptions","organizations_url":"https://api.github.com/users/HMPerson1/orgs","repos_url":"https://api.github.com/users/HMPerson1/repos","events_url":"https://api.github.com/users/HMPerson1/events{/privacy}","received_events_url":"https://api.github.com/users/HMPerson1/received_events","type":"User","site_admin":false},"body":"The output AST should be *correct*, but it's probably completely unreadable. Refinements to make the AST better will be added in the next few weeks.\r\n\r\n- [x] Data structures\r\n- [x] Compute reaching conditions\r\n  - [x] Graph slice\r\n- [x] Structure acyclic regions\r\n- [x] Region-ify loops\r\n  - [x] Funnel abnormal entries\r\n  - [x] Funnel abnormal exits\r\n    - [x] Nearest Common Dominator\r\n- [x] Structure loops\r\n- [x] Cleanup","created_at":"2018-05-24T20:49:15Z","updated_at":"2018-06-06T03:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b795874bdf272a4bbcfdf33ce0c7a85b3cbd13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160/commits","review_comments_url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160/comments","review_comment_url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/160/comments","statuses_url":"https://api.github.com/repos/radareorg/radeco-lib/statuses/cdd0f84a291d0a390a36f3a2ef9c2337e069250d","head":{"label":"HMPerson1:ctrl_flow_struct","ref":"ctrl_flow_struct","sha":"cdd0f84a291d0a390a36f3a2ef9c2337e069250d","user":{"login":"HMPerson1","id":2219904,"node_id":"MDQ6VXNlcjIyMTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2219904?v=4","gravatar_id":"","url":"https://api.github.com/users/HMPerson1","html_url":"https://github.com/HMPerson1","followers_url":"https://api.github.com/users/HMPerson1/followers","following_url":"https://api.github.com/users/HMPerson1/following{/other_user}","gists_url":"https://api.github.com/users/HMPerson1/gists{/gist_id}","starred_url":"https://api.github.com/users/HMPerson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HMPerson1/subscriptions","organizations_url":"https://api.github.com/users/HMPerson1/orgs","repos_url":"https://api.github.com/users/HMPerson1/repos","events_url":"https://api.github.com/users/HMPerson1/events{/privacy}","received_events_url":"https://api.github.com/users/HMPerson1/received_events","type":"User","site_admin":false},"repo":{"id":123658378,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2NTgzNzg=","name":"radeco-lib","full_name":"HMPerson1/radeco-lib","owner":{"login":"HMPerson1","id":2219904,"node_id":"MDQ6VXNlcjIyMTk5MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2219904?v=4","gravatar_id":"","url":"https://api.github.com/users/HMPerson1","html_url":"https://github.com/HMPerson1","followers_url":"https://api.github.com/users/HMPerson1/followers","following_url":"https://api.github.com/users/HMPerson1/following{/other_user}","gists_url":"https://api.github.com/users/HMPerson1/gists{/gist_id}","starred_url":"https://api.github.com/users/HMPerson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HMPerson1/subscriptions","organizations_url":"https://api.github.com/users/HMPerson1/orgs","repos_url":"https://api.github.com/users/HMPerson1/repos","events_url":"https://api.github.com/users/HMPerson1/events{/privacy}","received_events_url":"https://api.github.com/users/HMPerson1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HMPerson1/radeco-lib","description":"radare2-based decompiler","fork":true,"url":"https://api.github.com/repos/HMPerson1/radeco-lib","forks_url":"https://api.github.com/repos/HMPerson1/radeco-lib/forks","keys_url":"https://api.github.com/repos/HMPerson1/radeco-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HMPerson1/radeco-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HMPerson1/radeco-lib/teams","hooks_url":"https://api.github.com/repos/HMPerson1/radeco-lib/hooks","issue_events_url":"https://api.github.com/repos/HMPerson1/radeco-lib/issues/events{/number}","events_url":"https://api.github.com/repos/HMPerson1/radeco-lib/events","assignees_url":"https://api.github.com/repos/HMPerson1/radeco-lib/assignees{/user}","branches_url":"https://api.github.com/repos/HMPerson1/radeco-lib/branches{/branch}","tags_url":"https://api.github.com/repos/HMPerson1/radeco-lib/tags","blobs_url":"https://api.github.com/repos/HMPerson1/radeco-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HMPerson1/radeco-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HMPerson1/radeco-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/HMPerson1/radeco-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HMPerson1/radeco-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/HMPerson1/radeco-lib/languages","stargazers_url":"https://api.github.com/repos/HMPerson1/radeco-lib/stargazers","contributors_url":"https://api.github.com/repos/HMPerson1/radeco-lib/contributors","subscribers_url":"https://api.github.com/repos/HMPerson1/radeco-lib/subscribers","subscription_url":"https://api.github.com/repos/HMPerson1/radeco-lib/subscription","commits_url":"https://api.github.com/repos/HMPerson1/radeco-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/HMPerson1/radeco-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/HMPerson1/radeco-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/HMPerson1/radeco-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/HMPerson1/radeco-lib/contents/{+path}","compare_url":"https://api.github.com/repos/HMPerson1/radeco-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HMPerson1/radeco-lib/merges","archive_url":"https://api.github.com/repos/HMPerson1/radeco-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HMPerson1/radeco-lib/downloads","issues_url":"https://api.github.com/repos/HMPerson1/radeco-lib/issues{/number}","pulls_url":"https://api.github.com/repos/HMPerson1/radeco-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/HMPerson1/radeco-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/HMPerson1/radeco-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HMPerson1/radeco-lib/labels{/name}","releases_url":"https://api.github.com/repos/HMPerson1/radeco-lib/releases{/id}","deployments_url":"https://api.github.com/repos/HMPerson1/radeco-lib/deployments","created_at":"2018-03-03T04:19:37Z","updated_at":"2018-05-24T01:47:40Z","pushed_at":"2018-06-05T21:25:07Z","git_url":"git://github.com/HMPerson1/radeco-lib.git","ssh_url":"git@github.com:HMPerson1/radeco-lib.git","clone_url":"https://github.com/HMPerson1/radeco-lib.git","svn_url":"https://github.com/HMPerson1/radeco-lib","homepage":null,"size":1557,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radareorg:master","ref":"master","sha":"2974f978e531d98665936d286a37c7e26512c080","user":{"login":"radareorg","id":2842539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDI1Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2842539?v=4","gravatar_id":"","url":"https://api.github.com/users/radareorg","html_url":"https://github.com/radareorg","followers_url":"https://api.github.com/users/radareorg/followers","following_url":"https://api.github.com/users/radareorg/following{/other_user}","gists_url":"https://api.github.com/users/radareorg/gists{/gist_id}","starred_url":"https://api.github.com/users/radareorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radareorg/subscriptions","organizations_url":"https://api.github.com/users/radareorg/orgs","repos_url":"https://api.github.com/users/radareorg/repos","events_url":"https://api.github.com/users/radareorg/events{/privacy}","received_events_url":"https://api.github.com/users/radareorg/received_events","type":"Organization","site_admin":false},"repo":{"id":35782470,"node_id":"MDEwOlJlcG9zaXRvcnkzNTc4MjQ3MA==","name":"radeco-lib","full_name":"radareorg/radeco-lib","owner":{"login":"radareorg","id":2842539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NDI1Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2842539?v=4","gravatar_id":"","url":"https://api.github.com/users/radareorg","html_url":"https://github.com/radareorg","followers_url":"https://api.github.com/users/radareorg/followers","following_url":"https://api.github.com/users/radareorg/following{/other_user}","gists_url":"https://api.github.com/users/radareorg/gists{/gist_id}","starred_url":"https://api.github.com/users/radareorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radareorg/subscriptions","organizations_url":"https://api.github.com/users/radareorg/orgs","repos_url":"https://api.github.com/users/radareorg/repos","events_url":"https://api.github.com/users/radareorg/events{/privacy}","received_events_url":"https://api.github.com/users/radareorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/radareorg/radeco-lib","description":"radare2-based decompiler","fork":false,"url":"https://api.github.com/repos/radareorg/radeco-lib","forks_url":"https://api.github.com/repos/radareorg/radeco-lib/forks","keys_url":"https://api.github.com/repos/radareorg/radeco-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radareorg/radeco-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radareorg/radeco-lib/teams","hooks_url":"https://api.github.com/repos/radareorg/radeco-lib/hooks","issue_events_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/events{/number}","events_url":"https://api.github.com/repos/radareorg/radeco-lib/events","assignees_url":"https://api.github.com/repos/radareorg/radeco-lib/assignees{/user}","branches_url":"https://api.github.com/repos/radareorg/radeco-lib/branches{/branch}","tags_url":"https://api.github.com/repos/radareorg/radeco-lib/tags","blobs_url":"https://api.github.com/repos/radareorg/radeco-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radareorg/radeco-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radareorg/radeco-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/radareorg/radeco-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radareorg/radeco-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/radareorg/radeco-lib/languages","stargazers_url":"https://api.github.com/repos/radareorg/radeco-lib/stargazers","contributors_url":"https://api.github.com/repos/radareorg/radeco-lib/contributors","subscribers_url":"https://api.github.com/repos/radareorg/radeco-lib/subscribers","subscription_url":"https://api.github.com/repos/radareorg/radeco-lib/subscription","commits_url":"https://api.github.com/repos/radareorg/radeco-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/radareorg/radeco-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/radareorg/radeco-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/radareorg/radeco-lib/contents/{+path}","compare_url":"https://api.github.com/repos/radareorg/radeco-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radareorg/radeco-lib/merges","archive_url":"https://api.github.com/repos/radareorg/radeco-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radareorg/radeco-lib/downloads","issues_url":"https://api.github.com/repos/radareorg/radeco-lib/issues{/number}","pulls_url":"https://api.github.com/repos/radareorg/radeco-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/radareorg/radeco-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/radareorg/radeco-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radareorg/radeco-lib/labels{/name}","releases_url":"https://api.github.com/repos/radareorg/radeco-lib/releases{/id}","deployments_url":"https://api.github.com/repos/radareorg/radeco-lib/deployments","created_at":"2015-05-17T20:50:20Z","updated_at":"2018-06-05T07:50:52Z","pushed_at":"2018-06-05T21:25:09Z","git_url":"git://github.com/radareorg/radeco-lib.git","ssh_url":"git@github.com:radareorg/radeco-lib.git","clone_url":"https://github.com/radareorg/radeco-lib.git","svn_url":"https://github.com/radareorg/radeco-lib","homepage":null,"size":2478,"stargazers_count":127,"watchers_count":127,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":28,"open_issues":46,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160"},"html":{"href":"https://github.com/radareorg/radeco-lib/pull/160"},"issue":{"href":"https://api.github.com/repos/radareorg/radeco-lib/issues/160"},"comments":{"href":"https://api.github.com/repos/radareorg/radeco-lib/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/radareorg/radeco-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radareorg/radeco-lib/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/radareorg/radeco-lib/statuses/cdd0f84a291d0a390a36f3a2ef9c2337e069250d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sushant94"}}