{"action":"created","issue":{"url":"https://api.github.com/repos/aragon/aragon-apps/issues/280","repository_url":"https://api.github.com/repos/aragon/aragon-apps","labels_url":"https://api.github.com/repos/aragon/aragon-apps/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/aragon/aragon-apps/issues/280/comments","events_url":"https://api.github.com/repos/aragon/aragon-apps/issues/280/events","html_url":"https://github.com/aragon/aragon-apps/pull/280","id":315816942,"number":280,"title":"TokenManager: error if initializing as transferable when token is non-transferable","user":{"login":"sohkai","id":4166642,"avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-19T10:23:46Z","updated_at":"2018-04-20T09:31:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/aragon/aragon-apps/pulls/280","html_url":"https://github.com/aragon/aragon-apps/pull/280","diff_url":"https://github.com/aragon/aragon-apps/pull/280.diff","patch_url":"https://github.com/aragon/aragon-apps/pull/280.patch"},"body":"Adds a check to make sure the TokenManager is initialized to be non-transferable if the underlying minime token is also non-transferable.\r\n\r\nI didn't force equality because the converse is less strict—even if the token was originally transferable, initializing the TokenManager as non-transferable would effectively make the token also non-transferable.\r\n\r\nFixes\r\n\r\n> check token.transfersEnabled on init"},"comment":{"url":"https://api.github.com/repos/aragon/aragon-apps/issues/comments/383041298","html_url":"https://github.com/aragon/aragon-apps/pull/280#issuecomment-383041298","issue_url":"https://api.github.com/repos/aragon/aragon-apps/issues/280","id":383041298,"user":{"login":"sohkai","id":4166642,"avatar_url":"https://avatars2.githubusercontent.com/u/4166642?v=4","gravatar_id":"","url":"https://api.github.com/users/sohkai","html_url":"https://github.com/sohkai","followers_url":"https://api.github.com/users/sohkai/followers","following_url":"https://api.github.com/users/sohkai/following{/other_user}","gists_url":"https://api.github.com/users/sohkai/gists{/gist_id}","starred_url":"https://api.github.com/users/sohkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sohkai/subscriptions","organizations_url":"https://api.github.com/users/sohkai/orgs","repos_url":"https://api.github.com/users/sohkai/repos","events_url":"https://api.github.com/users/sohkai/events{/privacy}","received_events_url":"https://api.github.com/users/sohkai/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T09:31:07Z","updated_at":"2018-04-20T09:31:07Z","author_association":"MEMBER","body":"4fe922b replaces all the `transferable` logic in the TokenManager and instead piggybacks on the Minime token to handle that.\r\n\r\n@bingen @izqui The only API change that's affected is the inability for holders of non-transferable tokens to transfer tokens back to the TokenManager (however, the TokenManager can still burn those tokens directly): see https://github.com/aragon/aragon-apps/pull/280/files#diff-17c8771ab9c99065348cbba1b3fba658L79 and https://github.com/aragon/aragon-apps/pull/280/files#diff-17c8771ab9c99065348cbba1b3fba658R104. I'd argue that's more consistent, and fits the use case better."}}
{"actor":{"display_login":"sohkai"}}