{"action":"closed","number":19253,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19253","id":214773251,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzczMjUx","html_url":"https://github.com/apple/swift/pull/19253","diff_url":"https://github.com/apple/swift/pull/19253.diff","patch_url":"https://github.com/apple/swift/pull/19253.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19253","number":19253,"state":"closed","locked":false,"title":"Serialization: Fix deserialization of generic typealiases","user":{"login":"slavapestov","id":66486,"node_id":"MDQ6VXNlcjY2NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"The recovery logic was erronously kicking in, because it was comparing\r\nthe substituted underlying type with the declaration's underlying type.\r\n\r\nFor a generic typealias, these never equal, so instead, serialize the\r\nunsubstituted type, and substitute it in deserialization.","created_at":"2018-09-11T21:32:42Z","updated_at":"2018-09-12T14:09:09Z","closed_at":"2018-09-12T14:09:09Z","merged_at":"2018-09-12T14:09:09Z","merge_commit_sha":"d72cbbc8e1c07ff82574bfed972adb7d9c277500","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19253/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19253/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19253/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/3feaf8731accde97792e9a0333db23df33b5bf6b","head":{"label":"slavapestov:serialize-generic-typealias","ref":"serialize-generic-typealias","sha":"3feaf8731accde97792e9a0333db23df33b5bf6b","user":{"login":"slavapestov","id":66486,"node_id":"MDQ6VXNlcjY2NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"repo":{"id":50827146,"node_id":"MDEwOlJlcG9zaXRvcnk1MDgyNzE0Ng==","name":"swift","full_name":"slavapestov/swift","owner":{"login":"slavapestov","id":66486,"node_id":"MDQ6VXNlcjY2NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slavapestov/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/slavapestov/swift","forks_url":"https://api.github.com/repos/slavapestov/swift/forks","keys_url":"https://api.github.com/repos/slavapestov/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slavapestov/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slavapestov/swift/teams","hooks_url":"https://api.github.com/repos/slavapestov/swift/hooks","issue_events_url":"https://api.github.com/repos/slavapestov/swift/issues/events{/number}","events_url":"https://api.github.com/repos/slavapestov/swift/events","assignees_url":"https://api.github.com/repos/slavapestov/swift/assignees{/user}","branches_url":"https://api.github.com/repos/slavapestov/swift/branches{/branch}","tags_url":"https://api.github.com/repos/slavapestov/swift/tags","blobs_url":"https://api.github.com/repos/slavapestov/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slavapestov/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slavapestov/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/slavapestov/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slavapestov/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/slavapestov/swift/languages","stargazers_url":"https://api.github.com/repos/slavapestov/swift/stargazers","contributors_url":"https://api.github.com/repos/slavapestov/swift/contributors","subscribers_url":"https://api.github.com/repos/slavapestov/swift/subscribers","subscription_url":"https://api.github.com/repos/slavapestov/swift/subscription","commits_url":"https://api.github.com/repos/slavapestov/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/slavapestov/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/slavapestov/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/slavapestov/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/slavapestov/swift/contents/{+path}","compare_url":"https://api.github.com/repos/slavapestov/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slavapestov/swift/merges","archive_url":"https://api.github.com/repos/slavapestov/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slavapestov/swift/downloads","issues_url":"https://api.github.com/repos/slavapestov/swift/issues{/number}","pulls_url":"https://api.github.com/repos/slavapestov/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/slavapestov/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/slavapestov/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slavapestov/swift/labels{/name}","releases_url":"https://api.github.com/repos/slavapestov/swift/releases{/id}","deployments_url":"https://api.github.com/repos/slavapestov/swift/deployments","created_at":"2016-02-01T08:58:18Z","updated_at":"2018-09-10T15:51:56Z","pushed_at":"2018-09-12T06:59:38Z","git_url":"git://github.com/slavapestov/swift.git","ssh_url":"git@github.com:slavapestov/swift.git","clone_url":"https://github.com/slavapestov/swift.git","svn_url":"https://github.com/slavapestov/swift","homepage":"https://swift.org/","size":325482,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"c0275b8a44785b9b9dbcee48a0856cd24569a5d7","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-12T13:59:42Z","pushed_at":"2018-09-12T14:09:09Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":337439,"stargazers_count":45156,"watchers_count":45156,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7119,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7119,"open_issues":382,"watchers":45156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19253"},"html":{"href":"https://github.com/apple/swift/pull/19253"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19253"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19253/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19253/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19253/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/3feaf8731accde97792e9a0333db23df33b5bf6b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"slavapestov","id":66486,"node_id":"MDQ6VXNlcjY2NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"comments":12,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":72,"deletions":37,"changed_files":6}}
{"actor":{"display_login":"slavapestov"}}