{"action":"created","comment":{"url":"https://api.github.com/repos/adobe/xdm/pulls/comments/190700181","pull_request_review_id":123133659,"id":190700181,"diff_hunk":"@@ -23,19 +23,41 @@\n           \"title\": \"Runtime Type\",\n           \"type\": \"string\",\n           \"description\": \"The runtime of the ad unit itself, not the runtime of the browser or the operating system.\",\n-          \"examples\": \"unknown, HTML5\"\n+          \"meta:enum\": {\n+            \"unknown\": \"Unknown\",\n+            \"HTML5\": \"HTML5\"\n+            }\n         },\n         \"xdm:adClass\": {\n           \"title\": \"Ad Class\",\n           \"type\": \"string\",\n           \"description\": \"Ad class of driving event.\",\n-          \"examples\": \"display, video, social\"\n+          \"meta:enum\": {\n+            \"display\": \"Display\",\n+            \"video\": \"Video\",\n+            \"social\": \"Social\"\n+\n+            }\n         },\n         \"xdm:adUnitType\": {\n           \"title\": \"Ad Unit Type\",\n           \"type\": \"string\",\n           \"description\": \"Unique identifier for the literal piece of code driving display of the ad in a browser/device.\",\n-          \"examples\": \"linearVideo, interactiveVideo, banner, richMediaBanner, newsFeedVideo, newsFeedDisplay, HTML5, inPageVideo, inPageDisplay, facebook, twitter, linearTv, vod\"\n+          \"meta:enum\": {\n+            \"linearVideo\": \"Linear video\",\n+            \"interactiveVideo\": \"Interactive video\",\n+            \"banner\": \"Banner\",\n+            \"richMediaBanner\": \"Rich media banner\",\n+            \"newsFeedVideo\": \"News feed video\",\n+            \"newsFeedDisplay\": \"News feed display\",\n+            \"HTML5\": \"HTML5\",\n+            \"inPageVideo\": \"In page video\",\n+            \"inPageDisplay\": \"In page display\",\n+            \"facebook\":\"Facebook\",\n+            \"twitter\": \"Twitter\",\n+            \"linearTv\": \"linear TV\",","path":"extensions/adobe/experience/adcloud/advertisement.schema.json","position":38,"original_position":39,"commit_id":"5e96c3ab2c3e61b4a044b8df9109df878b6ad8d9","original_commit_id":"6a5323022a378ede1078a807788be44112d06ea7","user":{"login":"cdegroot-adobe","id":35702142,"avatar_url":"https://avatars0.githubusercontent.com/u/35702142?v=4","gravatar_id":"","url":"https://api.github.com/users/cdegroot-adobe","html_url":"https://github.com/cdegroot-adobe","followers_url":"https://api.github.com/users/cdegroot-adobe/followers","following_url":"https://api.github.com/users/cdegroot-adobe/following{/other_user}","gists_url":"https://api.github.com/users/cdegroot-adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdegroot-adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdegroot-adobe/subscriptions","organizations_url":"https://api.github.com/users/cdegroot-adobe/orgs","repos_url":"https://api.github.com/users/cdegroot-adobe/repos","events_url":"https://api.github.com/users/cdegroot-adobe/events{/privacy}","received_events_url":"https://api.github.com/users/cdegroot-adobe/received_events","type":"User","site_admin":false},"body":"Capitalize the \"L\"inear","created_at":"2018-05-24T19:12:09Z","updated_at":"2018-05-24T19:12:30Z","html_url":"https://github.com/adobe/xdm/pull/356#discussion_r190700181","pull_request_url":"https://api.github.com/repos/adobe/xdm/pulls/356","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adobe/xdm/pulls/comments/190700181"},"html":{"href":"https://github.com/adobe/xdm/pull/356#discussion_r190700181"},"pull_request":{"href":"https://api.github.com/repos/adobe/xdm/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/adobe/xdm/pulls/356","id":190387098,"html_url":"https://github.com/adobe/xdm/pull/356","diff_url":"https://github.com/adobe/xdm/pull/356.diff","patch_url":"https://github.com/adobe/xdm/pull/356.patch","issue_url":"https://api.github.com/repos/adobe/xdm/issues/356","number":356,"state":"open","locked":false,"title":"Fix value of \"examples\" to be array in advertisement of adcloud extension.","user":{"login":"jwen-adobe","id":35241610,"avatar_url":"https://avatars2.githubusercontent.com/u/35241610?v=4","gravatar_id":"","url":"https://api.github.com/users/jwen-adobe","html_url":"https://github.com/jwen-adobe","followers_url":"https://api.github.com/users/jwen-adobe/followers","following_url":"https://api.github.com/users/jwen-adobe/following{/other_user}","gists_url":"https://api.github.com/users/jwen-adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/jwen-adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwen-adobe/subscriptions","organizations_url":"https://api.github.com/users/jwen-adobe/orgs","repos_url":"https://api.github.com/users/jwen-adobe/repos","events_url":"https://api.github.com/users/jwen-adobe/events{/privacy}","received_events_url":"https://api.github.com/users/jwen-adobe/received_events","type":"User","site_admin":false},"body":"This PR links to the issue #355 \r\n\r\n@kstreeter @trieloff @cdegroot-adobe @gabebarcelos-adobe.\r\n\r\nThis PR fixes the \"examples\" value to be array.","created_at":"2018-05-24T18:55:23Z","updated_at":"2018-05-24T19:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"526af7d340d98dc8c7f7fd79ee9fa04358bbac0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adobe/xdm/pulls/356/commits","review_comments_url":"https://api.github.com/repos/adobe/xdm/pulls/356/comments","review_comment_url":"https://api.github.com/repos/adobe/xdm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe/xdm/issues/356/comments","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/5e96c3ab2c3e61b4a044b8df9109df878b6ad8d9","head":{"label":"adobe:platform-pr-adcloud-advertisement","ref":"platform-pr-adcloud-advertisement","sha":"5e96c3ab2c3e61b4a044b8df9109df878b6ad8d9","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":113054321,"name":"xdm","full_name":"adobe/xdm","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/xdm","description":"Experience Data Model","fork":false,"url":"https://api.github.com/repos/adobe/xdm","forks_url":"https://api.github.com/repos/adobe/xdm/forks","keys_url":"https://api.github.com/repos/adobe/xdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/xdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/xdm/teams","hooks_url":"https://api.github.com/repos/adobe/xdm/hooks","issue_events_url":"https://api.github.com/repos/adobe/xdm/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/xdm/events","assignees_url":"https://api.github.com/repos/adobe/xdm/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/xdm/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/xdm/tags","blobs_url":"https://api.github.com/repos/adobe/xdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/xdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/xdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/xdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/xdm/languages","stargazers_url":"https://api.github.com/repos/adobe/xdm/stargazers","contributors_url":"https://api.github.com/repos/adobe/xdm/contributors","subscribers_url":"https://api.github.com/repos/adobe/xdm/subscribers","subscription_url":"https://api.github.com/repos/adobe/xdm/subscription","commits_url":"https://api.github.com/repos/adobe/xdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/xdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/xdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/xdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/xdm/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/xdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/xdm/merges","archive_url":"https://api.github.com/repos/adobe/xdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/xdm/downloads","issues_url":"https://api.github.com/repos/adobe/xdm/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/xdm/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/xdm/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/xdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/xdm/labels{/name}","releases_url":"https://api.github.com/repos/adobe/xdm/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/xdm/deployments","created_at":"2017-12-04T14:40:24Z","updated_at":"2018-05-24T18:38:29Z","pushed_at":"2018-05-24T19:11:53Z","git_url":"git://github.com/adobe/xdm.git","ssh_url":"git@github.com:adobe/xdm.git","clone_url":"https://github.com/adobe/xdm.git","svn_url":"https://github.com/adobe/xdm","homepage":"","size":4503,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":46,"open_issues":83,"watchers":27,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"12d58909f7ae849a999119bb477bc8601cffd808","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":113054321,"name":"xdm","full_name":"adobe/xdm","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/xdm","description":"Experience Data Model","fork":false,"url":"https://api.github.com/repos/adobe/xdm","forks_url":"https://api.github.com/repos/adobe/xdm/forks","keys_url":"https://api.github.com/repos/adobe/xdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/xdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/xdm/teams","hooks_url":"https://api.github.com/repos/adobe/xdm/hooks","issue_events_url":"https://api.github.com/repos/adobe/xdm/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/xdm/events","assignees_url":"https://api.github.com/repos/adobe/xdm/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/xdm/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/xdm/tags","blobs_url":"https://api.github.com/repos/adobe/xdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/xdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/xdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/xdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/xdm/languages","stargazers_url":"https://api.github.com/repos/adobe/xdm/stargazers","contributors_url":"https://api.github.com/repos/adobe/xdm/contributors","subscribers_url":"https://api.github.com/repos/adobe/xdm/subscribers","subscription_url":"https://api.github.com/repos/adobe/xdm/subscription","commits_url":"https://api.github.com/repos/adobe/xdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/xdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/xdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/xdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/xdm/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/xdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/xdm/merges","archive_url":"https://api.github.com/repos/adobe/xdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/xdm/downloads","issues_url":"https://api.github.com/repos/adobe/xdm/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/xdm/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/xdm/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/xdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/xdm/labels{/name}","releases_url":"https://api.github.com/repos/adobe/xdm/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/xdm/deployments","created_at":"2017-12-04T14:40:24Z","updated_at":"2018-05-24T18:38:29Z","pushed_at":"2018-05-24T19:11:53Z","git_url":"git://github.com/adobe/xdm.git","ssh_url":"git@github.com:adobe/xdm.git","clone_url":"https://github.com/adobe/xdm.git","svn_url":"https://github.com/adobe/xdm","homepage":"","size":4503,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":46,"open_issues":83,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/xdm/pulls/356"},"html":{"href":"https://github.com/adobe/xdm/pull/356"},"issue":{"href":"https://api.github.com/repos/adobe/xdm/issues/356"},"comments":{"href":"https://api.github.com/repos/adobe/xdm/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/xdm/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/xdm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe/xdm/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/xdm/statuses/5e96c3ab2c3e61b4a044b8df9109df878b6ad8d9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cdegroot-adobe"}}