{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments/207479175","pull_request_review_id":143098964,"id":207479175,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ3OTE3NQ==","diff_hunk":"@@ -496,7 +496,12 @@\n                   \"'\\n\",\n                   \"ETCD_VERSION='\",\n                     \"{{$.Etcd.Version}}\",\n-                  \"'\\n\"\n+                  \"'\\n\",\n+                  {{if $.Etcd.FormatOpts}}\n+                  \"ETCD_OPTS='\",\n+                    \"{{$.Etcd.FormatOpts}}\",\n+                  \"'\\n\",\n+                  {{end}}","path":"core/etcd/config/templates/stack-template.json","position":10,"original_position":10,"commit_id":"700c6d5acd57b5db09dd703828cc75d5f159339e","original_commit_id":"700c6d5acd57b5db09dd703828cc75d5f159339e","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"body":"Perhaps you have an extra `,` after the last element of the format opts, that is causing this error?\r\n\r\n```\r\n    \tmaincluster_test.go:3533: failed to create cluster driver : failed to initialize etcd stack: Error while rendering template: invalid character ']' looking for beginning of value:\r\n    \t\tjson syntax error (offset=10035), in this region:\r\n    \t\t-------\r\n    \t\t,\r\n    \t\t                    \"--quota-backend-bytes=2147483648\",\r\n    \t\t                  \"'\\n\",\r\n    \t\t                  \r\n    \t\t                ]]}\r\n    \t\t              }\r\n    \t\t            }\r\n    \t\t          }\r\n    \t\t\r\n    \t\t-------\r\n```\r\n","created_at":"2018-08-03T08:42:35Z","updated_at":"2018-08-03T08:42:35Z","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1427#discussion_r207479175","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments/207479175"},"html":{"href":"https://github.com/kubernetes-incubator/kube-aws/pull/1427#discussion_r207479175"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427","id":204715021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzE1MDIx","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1427","diff_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1427.diff","patch_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1427.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1427","number":1427,"state":"open","locked":false,"title":"[Feature] Add more etcd options","user":{"login":"wwyiwzhang","id":19393210,"node_id":"MDQ6VXNlcjE5MzkzMjEw","avatar_url":"https://avatars1.githubusercontent.com/u/19393210?v=4","gravatar_id":"","url":"https://api.github.com/users/wwyiwzhang","html_url":"https://github.com/wwyiwzhang","followers_url":"https://api.github.com/users/wwyiwzhang/followers","following_url":"https://api.github.com/users/wwyiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/wwyiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/wwyiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwyiwzhang/subscriptions","organizations_url":"https://api.github.com/users/wwyiwzhang/orgs","repos_url":"https://api.github.com/users/wwyiwzhang/repos","events_url":"https://api.github.com/users/wwyiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/wwyiwzhang/received_events","type":"User","site_admin":false},"body":"This Pull request is to address the option of passing arguments to `/usr/local/bin/etcd` such as setting `--quota-backend-bytes` accordingly to the size of the etcd nodes. \r\n\r\nApologize for my rusty Golang and I am pretty sure there are more places I need to change. Really appreciate your feedback. ","created_at":"2018-07-30T07:22:03Z","updated_at":"2018-08-03T08:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f74bc7ca244d15ffdd05ee58d3e789000d78f81d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":567644993,"node_id":"MDU6TGFiZWw1Njc2NDQ5OTM=","url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"ededed","default":false},{"id":676264340,"node_id":"MDU6TGFiZWw2NzYyNjQzNDA=","url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1427/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/statuses/700c6d5acd57b5db09dd703828cc75d5f159339e","head":{"label":"wwyiwzhang:feature/more-etcd-options","ref":"feature/more-etcd-options","sha":"700c6d5acd57b5db09dd703828cc75d5f159339e","user":{"login":"wwyiwzhang","id":19393210,"node_id":"MDQ6VXNlcjE5MzkzMjEw","avatar_url":"https://avatars1.githubusercontent.com/u/19393210?v=4","gravatar_id":"","url":"https://api.github.com/users/wwyiwzhang","html_url":"https://github.com/wwyiwzhang","followers_url":"https://api.github.com/users/wwyiwzhang/followers","following_url":"https://api.github.com/users/wwyiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/wwyiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/wwyiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwyiwzhang/subscriptions","organizations_url":"https://api.github.com/users/wwyiwzhang/orgs","repos_url":"https://api.github.com/users/wwyiwzhang/repos","events_url":"https://api.github.com/users/wwyiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/wwyiwzhang/received_events","type":"User","site_admin":false},"repo":{"id":142507034,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1MDcwMzQ=","name":"kube-aws","full_name":"wwyiwzhang/kube-aws","owner":{"login":"wwyiwzhang","id":19393210,"node_id":"MDQ6VXNlcjE5MzkzMjEw","avatar_url":"https://avatars1.githubusercontent.com/u/19393210?v=4","gravatar_id":"","url":"https://api.github.com/users/wwyiwzhang","html_url":"https://github.com/wwyiwzhang","followers_url":"https://api.github.com/users/wwyiwzhang/followers","following_url":"https://api.github.com/users/wwyiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/wwyiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/wwyiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwyiwzhang/subscriptions","organizations_url":"https://api.github.com/users/wwyiwzhang/orgs","repos_url":"https://api.github.com/users/wwyiwzhang/repos","events_url":"https://api.github.com/users/wwyiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/wwyiwzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wwyiwzhang/kube-aws","description":"A command-line tool to declaratively manage Kubernetes clusters on AWS","fork":true,"url":"https://api.github.com/repos/wwyiwzhang/kube-aws","forks_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/forks","keys_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/teams","hooks_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/hooks","issue_events_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/issues/events{/number}","events_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/events","assignees_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/assignees{/user}","branches_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/branches{/branch}","tags_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/tags","blobs_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/languages","stargazers_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/stargazers","contributors_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/contributors","subscribers_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/subscribers","subscription_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/subscription","commits_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/contents/{+path}","compare_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/merges","archive_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/downloads","issues_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/issues{/number}","pulls_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/labels{/name}","releases_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/releases{/id}","deployments_url":"https://api.github.com/repos/wwyiwzhang/kube-aws/deployments","created_at":"2018-07-27T00:11:57Z","updated_at":"2018-07-27T00:12:00Z","pushed_at":"2018-08-03T04:40:58Z","git_url":"git://github.com/wwyiwzhang/kube-aws.git","ssh_url":"git@github.com:wwyiwzhang/kube-aws.git","clone_url":"https://github.com/wwyiwzhang/kube-aws.git","svn_url":"https://github.com/wwyiwzhang/kube-aws","homepage":"https://kubernetes-incubator.github.io/kube-aws/","size":36518,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"2dea8ddd19f21ae6a4f7eb26ee99eff619c87a01","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":70860688,"node_id":"MDEwOlJlcG9zaXRvcnk3MDg2MDY4OA==","name":"kube-aws","full_name":"kubernetes-incubator/kube-aws","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kube-aws","description":"A command-line tool to declaratively manage Kubernetes clusters on AWS","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws","forks_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/deployments","created_at":"2016-10-14T00:57:33Z","updated_at":"2018-08-03T05:51:14Z","pushed_at":"2018-08-03T04:40:59Z","git_url":"git://github.com/kubernetes-incubator/kube-aws.git","ssh_url":"git@github.com:kubernetes-incubator/kube-aws.git","clone_url":"https://github.com/kubernetes-incubator/kube-aws.git","svn_url":"https://github.com/kubernetes-incubator/kube-aws","homepage":"https://kubernetes-incubator.github.io/kube-aws/","size":36553,"stargazers_count":798,"watchers_count":798,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":206,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":206,"open_issues":266,"watchers":798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427"},"html":{"href":"https://github.com/kubernetes-incubator/kube-aws/pull/1427"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1427"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1427/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1427/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/statuses/700c6d5acd57b5db09dd703828cc75d5f159339e"}},"author_association":"NONE"}}
{"actor":{"display_login":"mumoshu"}}