{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/pinot/issues/3057","repository_url":"https://api.github.com/repos/linkedin/pinot","labels_url":"https://api.github.com/repos/linkedin/pinot/issues/3057/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/3057/comments","events_url":"https://api.github.com/repos/linkedin/pinot/issues/3057/events","html_url":"https://github.com/linkedin/pinot/pull/3057","id":349191898,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzY2NDk3","number":3057,"title":"Reduce heap allocation during realtime segment creation","user":{"login":"mcvsubbu","id":2279037,"node_id":"MDQ6VXNlcjIyNzkwMzc=","avatar_url":"https://avatars3.githubusercontent.com/u/2279037?v=4","gravatar_id":"","url":"https://api.github.com/users/mcvsubbu","html_url":"https://github.com/mcvsubbu","followers_url":"https://api.github.com/users/mcvsubbu/followers","following_url":"https://api.github.com/users/mcvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mcvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mcvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mcvsubbu/orgs","repos_url":"https://api.github.com/users/mcvsubbu/repos","events_url":"https://api.github.com/users/mcvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mcvsubbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-09T16:02:20Z","updated_at":"2018-08-09T16:43:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/3057","html_url":"https://github.com/linkedin/pinot/pull/3057","diff_url":"https://github.com/linkedin/pinot/pull/3057.diff","patch_url":"https://github.com/linkedin/pinot/pull/3057.patch"},"body":"In order to calculate min and max values of a no-dictionary column we walk through the entire value set,\nallocating a good bit of heap memory. But then we really don't use the value generated.\nThe getMin() and getMax() methods are called only to construct ColumnIndexCreationInfo (the values\ngathered from columnStatistics are stored in the ColumnIndexCreationInfo object). But then\nthe min/max values from ColumnIndexCreationInfo are retrieved only for the time column and not for\nany other column. Time column is never a no-dictionary column, so we can remove all the code in the\nno-dictionary column to compute min-max.\n\nThis essentially reverts #1468, which was submitted because of review comments on #1462.\nComment on #1462 should now be addressed, because we now throw exception instead of returning\nsome invalid value."},"comment":{"url":"https://api.github.com/repos/linkedin/pinot/issues/comments/411821983","html_url":"https://github.com/linkedin/pinot/pull/3057#issuecomment-411821983","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/3057","id":411821983,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTgyMTk4Mw==","user":{"login":"sunithabeeram","id":3123798,"node_id":"MDQ6VXNlcjMxMjM3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/3123798?v=4","gravatar_id":"","url":"https://api.github.com/users/sunithabeeram","html_url":"https://github.com/sunithabeeram","followers_url":"https://api.github.com/users/sunithabeeram/followers","following_url":"https://api.github.com/users/sunithabeeram/following{/other_user}","gists_url":"https://api.github.com/users/sunithabeeram/gists{/gist_id}","starred_url":"https://api.github.com/users/sunithabeeram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunithabeeram/subscriptions","organizations_url":"https://api.github.com/users/sunithabeeram/orgs","repos_url":"https://api.github.com/users/sunithabeeram/repos","events_url":"https://api.github.com/users/sunithabeeram/events{/privacy}","received_events_url":"https://api.github.com/users/sunithabeeram/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T16:43:09Z","updated_at":"2018-08-09T16:43:09Z","author_association":"CONTRIBUTOR","body":"Can we quantify how much of an improvement we see with this?"}}
{"actor":{"display_login":"sunithabeeram"}}