{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/229820178","pull_request_review_id":170411532,"id":229820178,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgyMDE3OA==","diff_hunk":"@@ -63,7 +64,7 @@ type NetworkPlugin interface {\n \t// SetUpPod is the method called after the infra container of\n \t// the pod has been created but before the other containers of the\n \t// pod are launched.\n-\tSetUpPod(namespace string, name string, podSandboxID kubecontainer.ContainerID, annotations map[string]string) error\n+\tSetUpPod(namespace string, name string, podSandboxID kubecontainer.ContainerID, annotations map[string]string, dnsConfig *runtimeapi.DNSConfig) error","path":"pkg/kubelet/dockershim/network/plugins.go","position":13,"original_position":13,"commit_id":"7b5c85536cb6b5e4f25b94794c0d13bf777cd10e","original_commit_id":"7b5c85536cb6b5e4f25b94794c0d13bf777cd10e","user":{"login":"freehan","id":1332699,"node_id":"MDQ6VXNlcjEzMzI2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"body":"Using the type from CRI as input seems a bit weird. But network plugin these days are already dedicated to dockershim. \r\n\r\nThis just make it even harder to be portable. ","created_at":"2018-10-31T18:36:29Z","updated_at":"2018-10-31T18:36:31Z","html_url":"https://github.com/kubernetes/kubernetes/pull/67435#discussion_r229820178","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/229820178"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/67435#discussion_r229820178"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435","id":208565438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTY1NDM4","html_url":"https://github.com/kubernetes/kubernetes/pull/67435","diff_url":"https://github.com/kubernetes/kubernetes/pull/67435.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67435.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67435","number":67435,"state":"open","locked":false,"title":"Add dns capabilities for Windows CNI plugins","user":{"login":"feiskyer","id":676637,"node_id":"MDQ6VXNlcjY3NjYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR adds dns capabilities for Windows CNI plugins, so that Windows plugins could setup container's dns based on the capability.\r\n\r\n```go\r\n// cniDNSConfig maps to the windows CNI dns Capability.\r\n// Note that dns capability is only used for Windows containers.\r\ntype cniDNSConfig struct {\r\n\t// List of DNS servers of the cluster.\r\n\tServers []string `json:\"servers,omitempty\"`\r\n\t// List of DNS search domains of the cluster.\r\n\tSearches []string `json:\"searches,omitempty\"`\r\n\t// List of DNS options.\r\n\tOptions []string `json:\"options,omitempty\"`\r\n}\r\n```\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #66801 #66588 #65016\r\n\r\n**Special notes for your reviewer**:\r\n\r\nWindows CNI plugins should be updated with supporting dns capability.\r\n\r\nSee also https://github.com/kubernetes/kubernetes/pull/63905#issuecomment-396709775.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAdd dns capabilities for Windows CNI plugins:\r\n\r\n\"dns\" {\r\n  \"servers\": [\"10.0.0.10\"],\r\n  \"searches\": [\"default.svc.cluster.local\",\"svc.cluster.local\",\"cluster.local\"],\r\n  \"options\": []\r\n}\r\n```\r\n\r\n/sig windows\r\n/sig network\r\n\r\n/assign @PatrickLang @madhanrm @dineshgovindasamy @dcbw","created_at":"2018-08-15T13:40:23Z","updated_at":"2018-10-31T18:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0ef9d5b6a4b24fd9e9d1273ed57ebb23e8f0f18","assignee":{"login":"freehan","id":1332699,"node_id":"MDQ6VXNlcjEzMzI2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"assignees":[{"login":"anfernee","id":174200,"node_id":"MDQ6VXNlcjE3NDIwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/174200?v=4","gravatar_id":"","url":"https://api.github.com/users/anfernee","html_url":"https://github.com/anfernee","followers_url":"https://api.github.com/users/anfernee/followers","following_url":"https://api.github.com/users/anfernee/following{/other_user}","gists_url":"https://api.github.com/users/anfernee/gists{/gist_id}","starred_url":"https://api.github.com/users/anfernee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anfernee/subscriptions","organizations_url":"https://api.github.com/users/anfernee/orgs","repos_url":"https://api.github.com/users/anfernee/repos","events_url":"https://api.github.com/users/anfernee/events{/privacy}","received_events_url":"https://api.github.com/users/anfernee/received_events","type":"User","site_admin":false},{"login":"freehan","id":1332699,"node_id":"MDQ6VXNlcjEzMzI2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1332699?v=4","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},{"login":"andyzhangx","id":4178417,"node_id":"MDQ6VXNlcjQxNzg0MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4178417?v=4","gravatar_id":"","url":"https://api.github.com/users/andyzhangx","html_url":"https://github.com/andyzhangx","followers_url":"https://api.github.com/users/andyzhangx/followers","following_url":"https://api.github.com/users/andyzhangx/following{/other_user}","gists_url":"https://api.github.com/users/andyzhangx/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzhangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzhangx/subscriptions","organizations_url":"https://api.github.com/users/andyzhangx/orgs","repos_url":"https://api.github.com/users/andyzhangx/repos","events_url":"https://api.github.com/users/andyzhangx/events{/privacy}","received_events_url":"https://api.github.com/users/andyzhangx/received_events","type":"User","site_admin":false},{"login":"dcbw","id":10926354,"node_id":"MDQ6VXNlcjEwOTI2MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},{"login":"PatrickLang","id":11345431,"node_id":"MDQ6VXNlcjExMzQ1NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/11345431?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickLang","html_url":"https://github.com/PatrickLang","followers_url":"https://api.github.com/users/PatrickLang/followers","following_url":"https://api.github.com/users/PatrickLang/following{/other_user}","gists_url":"https://api.github.com/users/PatrickLang/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickLang/subscriptions","organizations_url":"https://api.github.com/users/PatrickLang/orgs","repos_url":"https://api.github.com/users/PatrickLang/repos","events_url":"https://api.github.com/users/PatrickLang/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickLang/received_events","type":"User","site_admin":false},{"login":"dineshgovindasamy","id":13801705,"node_id":"MDQ6VXNlcjEzODAxNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/13801705?v=4","gravatar_id":"","url":"https://api.github.com/users/dineshgovindasamy","html_url":"https://github.com/dineshgovindasamy","followers_url":"https://api.github.com/users/dineshgovindasamy/followers","following_url":"https://api.github.com/users/dineshgovindasamy/following{/other_user}","gists_url":"https://api.github.com/users/dineshgovindasamy/gists{/gist_id}","starred_url":"https://api.github.com/users/dineshgovindasamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dineshgovindasamy/subscriptions","organizations_url":"https://api.github.com/users/dineshgovindasamy/orgs","repos_url":"https://api.github.com/users/dineshgovindasamy/repos","events_url":"https://api.github.com/users/dineshgovindasamy/events{/privacy}","received_events_url":"https://api.github.com/users/dineshgovindasamy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},{"login":"PatrickLang","id":11345431,"node_id":"MDQ6VXNlcjExMzQ1NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/11345431?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickLang","html_url":"https://github.com/PatrickLang","followers_url":"https://api.github.com/users/PatrickLang/followers","following_url":"https://api.github.com/users/PatrickLang/following{/other_user}","gists_url":"https://api.github.com/users/PatrickLang/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickLang/subscriptions","organizations_url":"https://api.github.com/users/PatrickLang/orgs","repos_url":"https://api.github.com/users/PatrickLang/repos","events_url":"https://api.github.com/users/PatrickLang/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickLang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":116712108,"node_id":"MDU6TGFiZWwxMTY3MTIxMDg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/network","name":"sig/network","color":"d2b48c","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":422106010,"node_id":"MDU6TGFiZWw0MjIxMDYwMTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/windows","name":"sig/windows","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40","html_url":"https://github.com/kubernetes/kubernetes/milestone/40","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/40/labels","id":2913713,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMw==","number":40,"title":"v1.13","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":66,"closed_issues":70,"state":"open","created_at":"2017-11-15T06:32:59Z","updated_at":"2018-10-31T17:32:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67435/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7b5c85536cb6b5e4f25b94794c0d13bf777cd10e","head":{"label":"feiskyer:dns-cap","ref":"dns-cap","sha":"7b5c85536cb6b5e4f25b94794c0d13bf777cd10e","user":{"login":"feiskyer","id":676637,"node_id":"MDQ6VXNlcjY3NjYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"repo":{"id":39993689,"node_id":"MDEwOlJlcG9zaXRvcnkzOTk5MzY4OQ==","name":"kubernetes","full_name":"feiskyer/kubernetes","private":false,"owner":{"login":"feiskyer","id":676637,"node_id":"MDQ6VXNlcjY3NjYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/feiskyer/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/feiskyer/kubernetes","forks_url":"https://api.github.com/repos/feiskyer/kubernetes/forks","keys_url":"https://api.github.com/repos/feiskyer/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feiskyer/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feiskyer/kubernetes/teams","hooks_url":"https://api.github.com/repos/feiskyer/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/feiskyer/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/feiskyer/kubernetes/events","assignees_url":"https://api.github.com/repos/feiskyer/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/feiskyer/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/feiskyer/kubernetes/tags","blobs_url":"https://api.github.com/repos/feiskyer/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feiskyer/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feiskyer/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/feiskyer/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feiskyer/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/feiskyer/kubernetes/languages","stargazers_url":"https://api.github.com/repos/feiskyer/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/feiskyer/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/feiskyer/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/feiskyer/kubernetes/subscription","commits_url":"https://api.github.com/repos/feiskyer/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/feiskyer/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/feiskyer/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/feiskyer/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/feiskyer/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/feiskyer/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feiskyer/kubernetes/merges","archive_url":"https://api.github.com/repos/feiskyer/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feiskyer/kubernetes/downloads","issues_url":"https://api.github.com/repos/feiskyer/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/feiskyer/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/feiskyer/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/feiskyer/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feiskyer/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/feiskyer/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/feiskyer/kubernetes/deployments","created_at":"2015-07-31T07:53:03Z","updated_at":"2018-10-29T02:14:48Z","pushed_at":"2018-10-31T11:39:19Z","git_url":"git://github.com/feiskyer/kubernetes.git","ssh_url":"git@github.com:feiskyer/kubernetes.git","clone_url":"https://github.com/feiskyer/kubernetes.git","svn_url":"https://github.com/feiskyer/kubernetes","homepage":"http://kubernetes.io","size":592581,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a34123d9c3e933b662bf0a3cb2c427f774154b01","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-10-31T18:00:09Z","pushed_at":"2018-10-31T18:32:31Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":810282,"stargazers_count":43233,"watchers_count":43233,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15046,"mirror_url":null,"archived":false,"open_issues_count":3180,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15046,"open_issues":3180,"watchers":43233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/67435"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/67435"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/67435/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67435/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7b5c85536cb6b5e4f25b94794c0d13bf777cd10e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"freehan"}}