{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/1","id":225353142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzUzMTQy","html_url":"https://github.com/yuvalkif/vacation_for_u/pull/1","diff_url":"https://github.com/yuvalkif/vacation_for_u/pull/1.diff","patch_url":"https://github.com/yuvalkif/vacation_for_u/pull/1.patch","issue_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues/1","number":1,"state":"closed","locked":false,"title":"opening connection to the db and closing it through the controller only","user":{"login":"adamCo1","id":38553798,"node_id":"MDQ6VXNlcjM4NTUzNzk4","avatar_url":"https://avatars2.githubusercontent.com/u/38553798?v=4","gravatar_id":"","url":"https://api.github.com/users/adamCo1","html_url":"https://github.com/adamCo1","followers_url":"https://api.github.com/users/adamCo1/followers","following_url":"https://api.github.com/users/adamCo1/following{/other_user}","gists_url":"https://api.github.com/users/adamCo1/gists{/gist_id}","starred_url":"https://api.github.com/users/adamCo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamCo1/subscriptions","organizations_url":"https://api.github.com/users/adamCo1/orgs","repos_url":"https://api.github.com/users/adamCo1/repos","events_url":"https://api.github.com/users/adamCo1/events{/privacy}","received_events_url":"https://api.github.com/users/adamCo1/received_events","type":"User","site_admin":false},"body":"added logger class for logging transactions and error - will maybe help in later assignments\r\n\r\neverything separated in a package / interface so we can change things easily\r\n\r\nSigned-off-by: Adam cohen <adam388cohen@gmail.com>","created_at":"2018-10-24T10:45:04Z","updated_at":"2018-10-24T10:45:50Z","closed_at":"2018-10-24T10:45:50Z","merged_at":"2018-10-24T10:45:50Z","merge_commit_sha":"8ba166dcf39f0032d1971f335f8878f1944157a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/1/commits","review_comments_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/1/comments","review_comment_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues/1/comments","statuses_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/statuses/9f500f45e08b20203eb573fbc67c38f176ce504e","head":{"label":"adamCo1:master","ref":"master","sha":"9f500f45e08b20203eb573fbc67c38f176ce504e","user":{"login":"adamCo1","id":38553798,"node_id":"MDQ6VXNlcjM4NTUzNzk4","avatar_url":"https://avatars2.githubusercontent.com/u/38553798?v=4","gravatar_id":"","url":"https://api.github.com/users/adamCo1","html_url":"https://github.com/adamCo1","followers_url":"https://api.github.com/users/adamCo1/followers","following_url":"https://api.github.com/users/adamCo1/following{/other_user}","gists_url":"https://api.github.com/users/adamCo1/gists{/gist_id}","starred_url":"https://api.github.com/users/adamCo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamCo1/subscriptions","organizations_url":"https://api.github.com/users/adamCo1/orgs","repos_url":"https://api.github.com/users/adamCo1/repos","events_url":"https://api.github.com/users/adamCo1/events{/privacy}","received_events_url":"https://api.github.com/users/adamCo1/received_events","type":"User","site_admin":false},"repo":{"id":154482050,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0ODIwNTA=","name":"vacation_for_u","full_name":"adamCo1/vacation_for_u","private":false,"owner":{"login":"adamCo1","id":38553798,"node_id":"MDQ6VXNlcjM4NTUzNzk4","avatar_url":"https://avatars2.githubusercontent.com/u/38553798?v=4","gravatar_id":"","url":"https://api.github.com/users/adamCo1","html_url":"https://github.com/adamCo1","followers_url":"https://api.github.com/users/adamCo1/followers","following_url":"https://api.github.com/users/adamCo1/following{/other_user}","gists_url":"https://api.github.com/users/adamCo1/gists{/gist_id}","starred_url":"https://api.github.com/users/adamCo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamCo1/subscriptions","organizations_url":"https://api.github.com/users/adamCo1/orgs","repos_url":"https://api.github.com/users/adamCo1/repos","events_url":"https://api.github.com/users/adamCo1/events{/privacy}","received_events_url":"https://api.github.com/users/adamCo1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adamCo1/vacation_for_u","description":null,"fork":true,"url":"https://api.github.com/repos/adamCo1/vacation_for_u","forks_url":"https://api.github.com/repos/adamCo1/vacation_for_u/forks","keys_url":"https://api.github.com/repos/adamCo1/vacation_for_u/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamCo1/vacation_for_u/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamCo1/vacation_for_u/teams","hooks_url":"https://api.github.com/repos/adamCo1/vacation_for_u/hooks","issue_events_url":"https://api.github.com/repos/adamCo1/vacation_for_u/issues/events{/number}","events_url":"https://api.github.com/repos/adamCo1/vacation_for_u/events","assignees_url":"https://api.github.com/repos/adamCo1/vacation_for_u/assignees{/user}","branches_url":"https://api.github.com/repos/adamCo1/vacation_for_u/branches{/branch}","tags_url":"https://api.github.com/repos/adamCo1/vacation_for_u/tags","blobs_url":"https://api.github.com/repos/adamCo1/vacation_for_u/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamCo1/vacation_for_u/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamCo1/vacation_for_u/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamCo1/vacation_for_u/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamCo1/vacation_for_u/statuses/{sha}","languages_url":"https://api.github.com/repos/adamCo1/vacation_for_u/languages","stargazers_url":"https://api.github.com/repos/adamCo1/vacation_for_u/stargazers","contributors_url":"https://api.github.com/repos/adamCo1/vacation_for_u/contributors","subscribers_url":"https://api.github.com/repos/adamCo1/vacation_for_u/subscribers","subscription_url":"https://api.github.com/repos/adamCo1/vacation_for_u/subscription","commits_url":"https://api.github.com/repos/adamCo1/vacation_for_u/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamCo1/vacation_for_u/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamCo1/vacation_for_u/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamCo1/vacation_for_u/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamCo1/vacation_for_u/contents/{+path}","compare_url":"https://api.github.com/repos/adamCo1/vacation_for_u/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamCo1/vacation_for_u/merges","archive_url":"https://api.github.com/repos/adamCo1/vacation_for_u/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamCo1/vacation_for_u/downloads","issues_url":"https://api.github.com/repos/adamCo1/vacation_for_u/issues{/number}","pulls_url":"https://api.github.com/repos/adamCo1/vacation_for_u/pulls{/number}","milestones_url":"https://api.github.com/repos/adamCo1/vacation_for_u/milestones{/number}","notifications_url":"https://api.github.com/repos/adamCo1/vacation_for_u/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamCo1/vacation_for_u/labels{/name}","releases_url":"https://api.github.com/repos/adamCo1/vacation_for_u/releases{/id}","deployments_url":"https://api.github.com/repos/adamCo1/vacation_for_u/deployments","created_at":"2018-10-24T10:26:54Z","updated_at":"2018-10-24T10:33:51Z","pushed_at":"2018-10-24T10:33:50Z","git_url":"git://github.com/adamCo1/vacation_for_u.git","ssh_url":"git@github.com:adamCo1/vacation_for_u.git","clone_url":"https://github.com/adamCo1/vacation_for_u.git","svn_url":"https://github.com/adamCo1/vacation_for_u","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yuvalkif:master","ref":"master","sha":"586ac4ba2fa5a20927e71be7a3e6ee3047a34184","user":{"login":"yuvalkif","id":39235359,"node_id":"MDQ6VXNlcjM5MjM1MzU5","avatar_url":"https://avatars2.githubusercontent.com/u/39235359?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalkif","html_url":"https://github.com/yuvalkif","followers_url":"https://api.github.com/users/yuvalkif/followers","following_url":"https://api.github.com/users/yuvalkif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalkif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalkif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalkif/subscriptions","organizations_url":"https://api.github.com/users/yuvalkif/orgs","repos_url":"https://api.github.com/users/yuvalkif/repos","events_url":"https://api.github.com/users/yuvalkif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalkif/received_events","type":"User","site_admin":false},"repo":{"id":153989796,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5ODk3OTY=","name":"vacation_for_u","full_name":"yuvalkif/vacation_for_u","private":false,"owner":{"login":"yuvalkif","id":39235359,"node_id":"MDQ6VXNlcjM5MjM1MzU5","avatar_url":"https://avatars2.githubusercontent.com/u/39235359?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalkif","html_url":"https://github.com/yuvalkif","followers_url":"https://api.github.com/users/yuvalkif/followers","following_url":"https://api.github.com/users/yuvalkif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalkif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalkif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalkif/subscriptions","organizations_url":"https://api.github.com/users/yuvalkif/orgs","repos_url":"https://api.github.com/users/yuvalkif/repos","events_url":"https://api.github.com/users/yuvalkif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalkif/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yuvalkif/vacation_for_u","description":null,"fork":false,"url":"https://api.github.com/repos/yuvalkif/vacation_for_u","forks_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/forks","keys_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/teams","hooks_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/hooks","issue_events_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues/events{/number}","events_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/events","assignees_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/assignees{/user}","branches_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/branches{/branch}","tags_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/tags","blobs_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/languages","stargazers_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/stargazers","contributors_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/contributors","subscribers_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/subscribers","subscription_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/subscription","commits_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/contents/{+path}","compare_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/merges","archive_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/downloads","issues_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues{/number}","pulls_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/labels{/name}","releases_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/releases{/id}","deployments_url":"https://api.github.com/repos/yuvalkif/vacation_for_u/deployments","created_at":"2018-10-21T08:56:28Z","updated_at":"2018-10-22T09:57:56Z","pushed_at":"2018-10-24T10:45:50Z","git_url":"git://github.com/yuvalkif/vacation_for_u.git","ssh_url":"git@github.com:yuvalkif/vacation_for_u.git","clone_url":"https://github.com/yuvalkif/vacation_for_u.git","svn_url":"https://github.com/yuvalkif/vacation_for_u","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/1"},"html":{"href":"https://github.com/yuvalkif/vacation_for_u/pull/1"},"issue":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues/1"},"comments":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/yuvalkif/vacation_for_u/statuses/9f500f45e08b20203eb573fbc67c38f176ce504e"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"yuvalkif","id":39235359,"node_id":"MDQ6VXNlcjM5MjM1MzU5","avatar_url":"https://avatars2.githubusercontent.com/u/39235359?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalkif","html_url":"https://github.com/yuvalkif","followers_url":"https://api.github.com/users/yuvalkif/followers","following_url":"https://api.github.com/users/yuvalkif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalkif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalkif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalkif/subscriptions","organizations_url":"https://api.github.com/users/yuvalkif/orgs","repos_url":"https://api.github.com/users/yuvalkif/repos","events_url":"https://api.github.com/users/yuvalkif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalkif/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":317,"deletions":99,"changed_files":13}}
{"actor":{"display_login":"yuvalkif"}}