{"action":"created","issue":{"url":"https://api.github.com/repos/jruby/jruby/issues/4834","repository_url":"https://api.github.com/repos/jruby/jruby","labels_url":"https://api.github.com/repos/jruby/jruby/issues/4834/labels{/name}","comments_url":"https://api.github.com/repos/jruby/jruby/issues/4834/comments","events_url":"https://api.github.com/repos/jruby/jruby/issues/4834/events","html_url":"https://github.com/jruby/jruby/issues/4834","id":270116387,"number":4834,"title":"Eliminate or configure invasive JDK class accesses for Java 9","user":{"login":"headius","id":10135,"avatar_url":"https://avatars3.githubusercontent.com/u/10135?v=4","gravatar_id":"","url":"https://api.github.com/users/headius","html_url":"https://github.com/headius","followers_url":"https://api.github.com/users/headius/followers","following_url":"https://api.github.com/users/headius/following{/other_user}","gists_url":"https://api.github.com/users/headius/gists{/gist_id}","starred_url":"https://api.github.com/users/headius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headius/subscriptions","organizations_url":"https://api.github.com/users/headius/orgs","repos_url":"https://api.github.com/users/headius/repos","events_url":"https://api.github.com/users/headius/events{/privacy}","received_events_url":"https://api.github.com/users/headius/received_events","type":"User","site_admin":false},"labels":[{"id":43748173,"url":"https://api.github.com/repos/jruby/jruby/labels/JDK%20compatibility","name":"JDK compatibility","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jruby/jruby/milestones/53","html_url":"https://github.com/jruby/jruby/milestone/53","labels_url":"https://api.github.com/repos/jruby/jruby/milestones/53/labels","id":1772709,"number":53,"title":"JRuby 9.2.0.0","description":"","creator":{"login":"headius","id":10135,"avatar_url":"https://avatars3.githubusercontent.com/u/10135?v=4","gravatar_id":"","url":"https://api.github.com/users/headius","html_url":"https://github.com/headius","followers_url":"https://api.github.com/users/headius/followers","following_url":"https://api.github.com/users/headius/following{/other_user}","gists_url":"https://api.github.com/users/headius/gists{/gist_id}","starred_url":"https://api.github.com/users/headius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headius/subscriptions","organizations_url":"https://api.github.com/users/headius/orgs","repos_url":"https://api.github.com/users/headius/repos","events_url":"https://api.github.com/users/headius/events{/privacy}","received_events_url":"https://api.github.com/users/headius/received_events","type":"User","site_admin":false},"open_issues":122,"closed_issues":118,"state":"open","created_at":"2016-05-17T21:46:32Z","updated_at":"2018-03-12T14:12:14Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2017-10-31T20:57:25Z","updated_at":"2018-03-14T16:32:49Z","closed_at":null,"author_association":"OWNER","body":"In #4111 we tracked general Java 9 support, for running JRuby and associated apps and libraries.\r\n\r\nThis bug tracks the additional flags and cleanup we should do relating to accessibility warnings.\r\n\r\nAt a minimum, we need to audit all uses of reflection to \"crack open\" classes and find alternatives or consider --add-opens flags.\r\n\r\nHere is the list of illegal accesses we do while running `gem install rails`:\r\n\r\n```\r\nWARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/Users/headius/projects/jruby/lib/ruby/stdlib/jopenssl.jar) to constructor java.security.cert.CertificateFactory(java.security.cert.CertificateFactorySpi,java.security.Provider,java.lang.String)\r\nWARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/Users/headius/projects/jruby/lib/ruby/stdlib/jopenssl.jar) to field java.security.MessageDigest.provider\r\nWARNING: Illegal reflective access by org.jruby.ext.zlib.RubyZlib to field java.util.zip.CRC32.crc\r\nWARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/Users/headius/projects/jruby/lib/ruby/stdlib/jopenssl.jar) to constructor java.security.cert.CertificateFactory(java.security.cert.CertificateFactorySpi,java.security.Provider,java.lang.String)\r\nWARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/Users/headius/projects/jruby/lib/ruby/stdlib/jopenssl.jar) to constructor java.security.cert.CertificateFactory(java.security.cert.CertificateFactorySpi,java.security.Provider,java.lang.String)\r\nWARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/Users/headius/projects/jruby/lib/ruby/stdlib/jopenssl.jar) to constructor java.security.cert.CertificateFactory(java.security.cert.CertificateFactorySpi,java.security.Provider,java.lang.String)\r\n```\r\n\r\nMore of these warnings will occur on Windows or when running without native IO, since in those cases we crack open core JDK IO classes."},"comment":{"url":"https://api.github.com/repos/jruby/jruby/issues/comments/373087531","html_url":"https://github.com/jruby/jruby/issues/4834#issuecomment-373087531","issue_url":"https://api.github.com/repos/jruby/jruby/issues/4834","id":373087531,"user":{"login":"jmiettinen","id":724318,"avatar_url":"https://avatars3.githubusercontent.com/u/724318?v=4","gravatar_id":"","url":"https://api.github.com/users/jmiettinen","html_url":"https://github.com/jmiettinen","followers_url":"https://api.github.com/users/jmiettinen/followers","following_url":"https://api.github.com/users/jmiettinen/following{/other_user}","gists_url":"https://api.github.com/users/jmiettinen/gists{/gist_id}","starred_url":"https://api.github.com/users/jmiettinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmiettinen/subscriptions","organizations_url":"https://api.github.com/users/jmiettinen/orgs","repos_url":"https://api.github.com/users/jmiettinen/repos","events_url":"https://api.github.com/users/jmiettinen/events{/privacy}","received_events_url":"https://api.github.com/users/jmiettinen/received_events","type":"User","site_admin":false},"created_at":"2018-03-14T16:32:49Z","updated_at":"2018-03-14T16:32:49Z","author_association":"CONTRIBUTOR","body":"Is there a good reason for [tinkering with CRC32 internals](https://github.com/jruby/jruby/blob/334a7f01da17071368ddb6bcb7ea6d6b0bcb2c41/core/src/main/java/org/jruby/ext/zlib/RubyZlib.java#L76)?\r\n\r\nIt seems to be just to support use of potentially faster implementation for call to `Zlib.crc(string, non_zero_value)`. Is this a very common occurrence which we want to optimize for instead of using `JZlib.crc32_combine` that can handle non-zero start values as is the current slow path?\r\n\r\nhttps://github.com/jruby/jruby/blob/334a7f01da17071368ddb6bcb7ea6d6b0bcb2c41/core/src/main/java/org/jruby/ext/zlib/RubyZlib.java#L214"}}
{"actor":{"display_login":"jmiettinen"}}