{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/tls-tris/pulls/comments/190516857","pull_request_review_id":122907067,"id":190516857,"diff_hunk":"@@ -44,6 +44,13 @@ pip install setuptools\n pip install docker\n ```\n \n+* In Ubuntu (>=18.04), you'll also need to `apt install docker.io`. If docker","path":"README.md","position":4,"original_position":4,"commit_id":"7cff71f9923bc23d5d69449795be3ed6c8fe0fb0","original_commit_id":"7cff71f9923bc23d5d69449795be3ed6c8fe0fb0","user":{"login":"henrydcase","id":1159844,"avatar_url":"https://avatars0.githubusercontent.com/u/1159844?v=4","gravatar_id":"","url":"https://api.github.com/users/henrydcase","html_url":"https://github.com/henrydcase","followers_url":"https://api.github.com/users/henrydcase/followers","following_url":"https://api.github.com/users/henrydcase/following{/other_user}","gists_url":"https://api.github.com/users/henrydcase/gists{/gist_id}","starred_url":"https://api.github.com/users/henrydcase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrydcase/subscriptions","organizations_url":"https://api.github.com/users/henrydcase/orgs","repos_url":"https://api.github.com/users/henrydcase/repos","events_url":"https://api.github.com/users/henrydcase/events{/privacy}","received_events_url":"https://api.github.com/users/henrydcase/received_events","type":"User","site_admin":false},"body":"This needs to be copy-paste'able","created_at":"2018-05-24T09:15:37Z","updated_at":"2018-05-24T09:15:38Z","html_url":"https://github.com/cloudflare/tls-tris/pull/89#discussion_r190516857","pull_request_url":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/tls-tris/pulls/comments/190516857"},"html":{"href":"https://github.com/cloudflare/tls-tris/pull/89#discussion_r190516857"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89","id":190141052,"html_url":"https://github.com/cloudflare/tls-tris/pull/89","diff_url":"https://github.com/cloudflare/tls-tris/pull/89.diff","patch_url":"https://github.com/cloudflare/tls-tris/pull/89.patch","issue_url":"https://api.github.com/repos/cloudflare/tls-tris/issues/89","number":89,"state":"closed","locked":false,"title":"Get the code to build on Ubuntu >=18.04","user":{"login":"cjpatton","id":3453007,"avatar_url":"https://avatars0.githubusercontent.com/u/3453007?v=4","gravatar_id":"","url":"https://api.github.com/users/cjpatton","html_url":"https://github.com/cjpatton","followers_url":"https://api.github.com/users/cjpatton/followers","following_url":"https://api.github.com/users/cjpatton/following{/other_user}","gists_url":"https://api.github.com/users/cjpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpatton/subscriptions","organizations_url":"https://api.github.com/users/cjpatton/orgs","repos_url":"https://api.github.com/users/cjpatton/repos","events_url":"https://api.github.com/users/cjpatton/events{/privacy}","received_events_url":"https://api.github.com/users/cjpatton/received_events","type":"User","site_admin":false},"body":"I needed to amend `_dev/Makefile` slightly. On my system, some of the folders in GOROOT are symbolic links to directories the Makefile tries to copy. Adding the `-H` flag to `cp` solves this, and AFAICT should not affect the build on other systems.\r\n\r\nI also added some notes to `README.md` for getting things to run on Ubuntu.","created_at":"2018-05-24T00:39:10Z","updated_at":"2018-05-24T09:15:38Z","closed_at":"2018-05-24T09:06:55Z","merged_at":"2018-05-24T09:06:55Z","merge_commit_sha":"160c4f5eab8da0763abccf3b17f43dcaccd729a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89/commits","review_comments_url":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89/comments","review_comment_url":"https://api.github.com/repos/cloudflare/tls-tris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/tls-tris/issues/89/comments","statuses_url":"https://api.github.com/repos/cloudflare/tls-tris/statuses/7cff71f9923bc23d5d69449795be3ed6c8fe0fb0","head":{"label":"cjpatton:master","ref":"master","sha":"7cff71f9923bc23d5d69449795be3ed6c8fe0fb0","user":{"login":"cjpatton","id":3453007,"avatar_url":"https://avatars0.githubusercontent.com/u/3453007?v=4","gravatar_id":"","url":"https://api.github.com/users/cjpatton","html_url":"https://github.com/cjpatton","followers_url":"https://api.github.com/users/cjpatton/followers","following_url":"https://api.github.com/users/cjpatton/following{/other_user}","gists_url":"https://api.github.com/users/cjpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpatton/subscriptions","organizations_url":"https://api.github.com/users/cjpatton/orgs","repos_url":"https://api.github.com/users/cjpatton/repos","events_url":"https://api.github.com/users/cjpatton/events{/privacy}","received_events_url":"https://api.github.com/users/cjpatton/received_events","type":"User","site_admin":false},"repo":{"id":134472268,"name":"tls-tris","full_name":"cjpatton/tls-tris","owner":{"login":"cjpatton","id":3453007,"avatar_url":"https://avatars0.githubusercontent.com/u/3453007?v=4","gravatar_id":"","url":"https://api.github.com/users/cjpatton","html_url":"https://github.com/cjpatton","followers_url":"https://api.github.com/users/cjpatton/followers","following_url":"https://api.github.com/users/cjpatton/following{/other_user}","gists_url":"https://api.github.com/users/cjpatton/gists{/gist_id}","starred_url":"https://api.github.com/users/cjpatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjpatton/subscriptions","organizations_url":"https://api.github.com/users/cjpatton/orgs","repos_url":"https://api.github.com/users/cjpatton/repos","events_url":"https://api.github.com/users/cjpatton/events{/privacy}","received_events_url":"https://api.github.com/users/cjpatton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjpatton/tls-tris","description":"crypto/tls, now with 100% more 1.3. THE API IS NOT STABLE AND DOCUMENTATION IS NOT GUARANTEED.","fork":true,"url":"https://api.github.com/repos/cjpatton/tls-tris","forks_url":"https://api.github.com/repos/cjpatton/tls-tris/forks","keys_url":"https://api.github.com/repos/cjpatton/tls-tris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjpatton/tls-tris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjpatton/tls-tris/teams","hooks_url":"https://api.github.com/repos/cjpatton/tls-tris/hooks","issue_events_url":"https://api.github.com/repos/cjpatton/tls-tris/issues/events{/number}","events_url":"https://api.github.com/repos/cjpatton/tls-tris/events","assignees_url":"https://api.github.com/repos/cjpatton/tls-tris/assignees{/user}","branches_url":"https://api.github.com/repos/cjpatton/tls-tris/branches{/branch}","tags_url":"https://api.github.com/repos/cjpatton/tls-tris/tags","blobs_url":"https://api.github.com/repos/cjpatton/tls-tris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjpatton/tls-tris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjpatton/tls-tris/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjpatton/tls-tris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjpatton/tls-tris/statuses/{sha}","languages_url":"https://api.github.com/repos/cjpatton/tls-tris/languages","stargazers_url":"https://api.github.com/repos/cjpatton/tls-tris/stargazers","contributors_url":"https://api.github.com/repos/cjpatton/tls-tris/contributors","subscribers_url":"https://api.github.com/repos/cjpatton/tls-tris/subscribers","subscription_url":"https://api.github.com/repos/cjpatton/tls-tris/subscription","commits_url":"https://api.github.com/repos/cjpatton/tls-tris/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjpatton/tls-tris/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjpatton/tls-tris/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjpatton/tls-tris/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjpatton/tls-tris/contents/{+path}","compare_url":"https://api.github.com/repos/cjpatton/tls-tris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjpatton/tls-tris/merges","archive_url":"https://api.github.com/repos/cjpatton/tls-tris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjpatton/tls-tris/downloads","issues_url":"https://api.github.com/repos/cjpatton/tls-tris/issues{/number}","pulls_url":"https://api.github.com/repos/cjpatton/tls-tris/pulls{/number}","milestones_url":"https://api.github.com/repos/cjpatton/tls-tris/milestones{/number}","notifications_url":"https://api.github.com/repos/cjpatton/tls-tris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjpatton/tls-tris/labels{/name}","releases_url":"https://api.github.com/repos/cjpatton/tls-tris/releases{/id}","deployments_url":"https://api.github.com/repos/cjpatton/tls-tris/deployments","created_at":"2018-05-22T20:29:11Z","updated_at":"2018-05-24T00:35:53Z","pushed_at":"2018-05-24T00:35:51Z","git_url":"git://github.com/cjpatton/tls-tris.git","ssh_url":"git@github.com:cjpatton/tls-tris.git","clone_url":"https://github.com/cjpatton/tls-tris.git","svn_url":"https://github.com/cjpatton/tls-tris","homepage":"","size":137871,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"b7765d14c45cfc0e50b625c7405ea9e99be53994","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars3.githubusercontent.com/u/314135?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":59218728,"name":"tls-tris","full_name":"cloudflare/tls-tris","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars3.githubusercontent.com/u/314135?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/tls-tris","description":"crypto/tls, now with 100% more 1.3. THE API IS NOT STABLE AND DOCUMENTATION IS NOT GUARANTEED.","fork":false,"url":"https://api.github.com/repos/cloudflare/tls-tris","forks_url":"https://api.github.com/repos/cloudflare/tls-tris/forks","keys_url":"https://api.github.com/repos/cloudflare/tls-tris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/tls-tris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/tls-tris/teams","hooks_url":"https://api.github.com/repos/cloudflare/tls-tris/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/tls-tris/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/tls-tris/events","assignees_url":"https://api.github.com/repos/cloudflare/tls-tris/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/tls-tris/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/tls-tris/tags","blobs_url":"https://api.github.com/repos/cloudflare/tls-tris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/tls-tris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/tls-tris/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/tls-tris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/tls-tris/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/tls-tris/languages","stargazers_url":"https://api.github.com/repos/cloudflare/tls-tris/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/tls-tris/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/tls-tris/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/tls-tris/subscription","commits_url":"https://api.github.com/repos/cloudflare/tls-tris/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/tls-tris/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/tls-tris/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/tls-tris/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/tls-tris/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/tls-tris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/tls-tris/merges","archive_url":"https://api.github.com/repos/cloudflare/tls-tris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/tls-tris/downloads","issues_url":"https://api.github.com/repos/cloudflare/tls-tris/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/tls-tris/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/tls-tris/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/tls-tris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/tls-tris/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/tls-tris/releases{/id}","deployments_url":"https://api.github.com/repos/cloudflare/tls-tris/deployments","created_at":"2016-05-19T15:23:09Z","updated_at":"2018-05-24T09:06:58Z","pushed_at":"2018-05-24T09:06:55Z","git_url":"git://github.com/cloudflare/tls-tris.git","ssh_url":"git@github.com:cloudflare/tls-tris.git","clone_url":"https://github.com/cloudflare/tls-tris.git","svn_url":"https://github.com/cloudflare/tls-tris","homepage":"","size":137870,"stargazers_count":137,"watchers_count":137,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":24,"open_issues":17,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89"},"html":{"href":"https://github.com/cloudflare/tls-tris/pull/89"},"issue":{"href":"https://api.github.com/repos/cloudflare/tls-tris/issues/89"},"comments":{"href":"https://api.github.com/repos/cloudflare/tls-tris/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/tls-tris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/tls-tris/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/tls-tris/statuses/7cff71f9923bc23d5d69449795be3ed6c8fe0fb0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"henrydcase"}}