{"action":"created","issue":{"url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/issues/51","repository_url":"https://api.github.com/repos/kottans/frontend-2019-homeworks","labels_url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/issues/51/comments","events_url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/issues/51/events","html_url":"https://github.com/kottans/frontend-2019-homeworks/pull/51","id":386561097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjU5NzY0","number":51,"title":"js-dom - done","user":{"login":"justdevway","id":37013371,"node_id":"MDQ6VXNlcjM3MDEzMzcx","avatar_url":"https://avatars2.githubusercontent.com/u/37013371?v=4","gravatar_id":"","url":"https://api.github.com/users/justdevway","html_url":"https://github.com/justdevway","followers_url":"https://api.github.com/users/justdevway/followers","following_url":"https://api.github.com/users/justdevway/following{/other_user}","gists_url":"https://api.github.com/users/justdevway/gists{/gist_id}","starred_url":"https://api.github.com/users/justdevway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justdevway/subscriptions","organizations_url":"https://api.github.com/users/justdevway/orgs","repos_url":"https://api.github.com/users/justdevway/repos","events_url":"https://api.github.com/users/justdevway/events{/privacy}","received_events_url":"https://api.github.com/users/justdevway/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"AMashoshyna","id":17703790,"node_id":"MDQ6VXNlcjE3NzAzNzkw","avatar_url":"https://avatars0.githubusercontent.com/u/17703790?v=4","gravatar_id":"","url":"https://api.github.com/users/AMashoshyna","html_url":"https://github.com/AMashoshyna","followers_url":"https://api.github.com/users/AMashoshyna/followers","following_url":"https://api.github.com/users/AMashoshyna/following{/other_user}","gists_url":"https://api.github.com/users/AMashoshyna/gists{/gist_id}","starred_url":"https://api.github.com/users/AMashoshyna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMashoshyna/subscriptions","organizations_url":"https://api.github.com/users/AMashoshyna/orgs","repos_url":"https://api.github.com/users/AMashoshyna/repos","events_url":"https://api.github.com/users/AMashoshyna/events{/privacy}","received_events_url":"https://api.github.com/users/AMashoshyna/received_events","type":"User","site_admin":false},"assignees":[{"login":"AMashoshyna","id":17703790,"node_id":"MDQ6VXNlcjE3NzAzNzkw","avatar_url":"https://avatars0.githubusercontent.com/u/17703790?v=4","gravatar_id":"","url":"https://api.github.com/users/AMashoshyna","html_url":"https://github.com/AMashoshyna","followers_url":"https://api.github.com/users/AMashoshyna/followers","following_url":"https://api.github.com/users/AMashoshyna/following{/other_user}","gists_url":"https://api.github.com/users/AMashoshyna/gists{/gist_id}","starred_url":"https://api.github.com/users/AMashoshyna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMashoshyna/subscriptions","organizations_url":"https://api.github.com/users/AMashoshyna/orgs","repos_url":"https://api.github.com/users/AMashoshyna/repos","events_url":"https://api.github.com/users/AMashoshyna/events{/privacy}","received_events_url":"https://api.github.com/users/AMashoshyna/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-02T13:44:47Z","updated_at":"2018-12-07T08:48:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/pulls/51","html_url":"https://github.com/kottans/frontend-2019-homeworks/pull/51","diff_url":"https://github.com/kottans/frontend-2019-homeworks/pull/51.diff","patch_url":"https://github.com/kottans/frontend-2019-homeworks/pull/51.patch"},"body":"### task name\r\n\r\n[Demo](https://justdevway.github.io/frontend-2019-homeworks/) |\r\n[Code base](https://github.com/justdevway/kottans-frontend/tree/master/task_js_dom)\r\n\r\nThe code is submitted in a dedicated feature branch.\r\nPlease, review.\r\n"},"comment":{"url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/issues/comments/445163611","html_url":"https://github.com/kottans/frontend-2019-homeworks/pull/51#issuecomment-445163611","issue_url":"https://api.github.com/repos/kottans/frontend-2019-homeworks/issues/51","id":445163611,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTE2MzYxMQ==","user":{"login":"AMashoshyna","id":17703790,"node_id":"MDQ6VXNlcjE3NzAzNzkw","avatar_url":"https://avatars0.githubusercontent.com/u/17703790?v=4","gravatar_id":"","url":"https://api.github.com/users/AMashoshyna","html_url":"https://github.com/AMashoshyna","followers_url":"https://api.github.com/users/AMashoshyna/followers","following_url":"https://api.github.com/users/AMashoshyna/following{/other_user}","gists_url":"https://api.github.com/users/AMashoshyna/gists{/gist_id}","starred_url":"https://api.github.com/users/AMashoshyna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AMashoshyna/subscriptions","organizations_url":"https://api.github.com/users/AMashoshyna/orgs","repos_url":"https://api.github.com/users/AMashoshyna/repos","events_url":"https://api.github.com/users/AMashoshyna/events{/privacy}","received_events_url":"https://api.github.com/users/AMashoshyna/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T08:48:02Z","updated_at":"2018-12-07T08:48:02Z","author_association":"COLLABORATOR","body":"Hi @justdevway! You did a great job! I will merge the PR. As possible improvements, consider the following:\r\n- in `navLinks` (line 235) event delegation can be used too. Generally, when you want to add an event listener in a loop, you propable need event delegation\r\n- using inline styles and writing to element.style directly has many disadvantages, code maintenance among them. Better to stick with css classes. Add `hidden` class and use it in js instead of writing `element.style.display = '';`"}}
{"actor":{"display_login":"AMashoshyna"}}