{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/196673986","pull_request_review_id":130269592,"id":196673986,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjY3Mzk4Ng==","diff_hunk":"@@ -1590,8 +1590,15 @@ def make_jobspec(cfg, targets, makefile='Makefile'):\n         return [\n             jobset.JobSpec(\n                 [\n-                    'cmake', '--build', '.', '--target',\n-                    '%s' % target, '--config', _MSBUILD_CONFIG[cfg]\n+                    'cmake',\n+                    '--build',\n+                    '.',\n+                    '--target',\n+                    '%s' % target,\n+                    '--config',\n+                    _MSBUILD_CONFIG[cfg],\n+                    '--',\n+                    '/maxcpucount:%d' % args.jobs,","path":"tools/run_tests/run_tests.py","position":14,"original_position":14,"commit_id":"138e6d61915c629ab60150526f48c31034d1da52","original_commit_id":"138e6d61915c629ab60150526f48c31034d1da52","user":{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"body":"heads up that there's still something funny with this PR on portability tests. Also, the ninja option sounds very interesting ","created_at":"2018-06-20T07:33:46Z","updated_at":"2018-06-20T07:33:47Z","html_url":"https://github.com/grpc/grpc/pull/15796#discussion_r196673986","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/15796","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/196673986"},"html":{"href":"https://github.com/grpc/grpc/pull/15796#discussion_r196673986"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15796"}},"in_reply_to_id":196659867},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15796","id":195580114,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTgwMTE0","html_url":"https://github.com/grpc/grpc/pull/15796","diff_url":"https://github.com/grpc/grpc/pull/15796.diff","patch_url":"https://github.com/grpc/grpc/pull/15796.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15796","number":15796,"state":"open","locked":false,"title":"Compile tests on windows with /maxcpucount switch","user":{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"body":"This is just an idea. I've used this to speed up compilation when running tests on windows locally/manually, but I'm not sure if there concerns about increasing CPU.","created_at":"2018-06-18T16:25:22Z","updated_at":"2018-06-20T07:33:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6985bd28dc50acb34ae5889749f3ded92a1cfffb","assignee":{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":218696110,"node_id":"MDU6TGFiZWwyMTg2OTYxMTA=","url":"https://api.github.com/repos/grpc/grpc/labels/area/test","name":"area/test","color":"efdb40","default":false},{"id":235846537,"node_id":"MDU6TGFiZWwyMzU4NDY1Mzc=","url":"https://api.github.com/repos/grpc/grpc/labels/disposition/FOR%20DISCUSSION","name":"disposition/FOR DISCUSSION","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/15796/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/15796/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15796/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/138e6d61915c629ab60150526f48c31034d1da52","head":{"label":"apolcyn:faster_windows_compilation","ref":"faster_windows_compilation","sha":"138e6d61915c629ab60150526f48c31034d1da52","user":{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"repo":{"id":61862132,"node_id":"MDEwOlJlcG9zaXRvcnk2MTg2MjEzMg==","name":"grpc","full_name":"apolcyn/grpc","owner":{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apolcyn/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/apolcyn/grpc","forks_url":"https://api.github.com/repos/apolcyn/grpc/forks","keys_url":"https://api.github.com/repos/apolcyn/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apolcyn/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apolcyn/grpc/teams","hooks_url":"https://api.github.com/repos/apolcyn/grpc/hooks","issue_events_url":"https://api.github.com/repos/apolcyn/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/apolcyn/grpc/events","assignees_url":"https://api.github.com/repos/apolcyn/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/apolcyn/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/apolcyn/grpc/tags","blobs_url":"https://api.github.com/repos/apolcyn/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apolcyn/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apolcyn/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/apolcyn/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apolcyn/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/apolcyn/grpc/languages","stargazers_url":"https://api.github.com/repos/apolcyn/grpc/stargazers","contributors_url":"https://api.github.com/repos/apolcyn/grpc/contributors","subscribers_url":"https://api.github.com/repos/apolcyn/grpc/subscribers","subscription_url":"https://api.github.com/repos/apolcyn/grpc/subscription","commits_url":"https://api.github.com/repos/apolcyn/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/apolcyn/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/apolcyn/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/apolcyn/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/apolcyn/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/apolcyn/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apolcyn/grpc/merges","archive_url":"https://api.github.com/repos/apolcyn/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apolcyn/grpc/downloads","issues_url":"https://api.github.com/repos/apolcyn/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/apolcyn/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/apolcyn/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/apolcyn/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apolcyn/grpc/labels{/name}","releases_url":"https://api.github.com/repos/apolcyn/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/apolcyn/grpc/deployments","created_at":"2016-06-24T06:32:25Z","updated_at":"2016-06-24T06:32:34Z","pushed_at":"2018-06-20T00:35:04Z","git_url":"git://github.com/apolcyn/grpc.git","ssh_url":"git@github.com:apolcyn/grpc.git","clone_url":"https://github.com/apolcyn/grpc.git","svn_url":"https://github.com/apolcyn/grpc","homepage":"","size":362178,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"a2769d5ee4116152eead50678741906b1667923b","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-06-20T07:30:48Z","pushed_at":"2018-06-20T06:41:49Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":185067,"stargazers_count":15863,"watchers_count":15863,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3535,"mirror_url":null,"archived":false,"open_issues_count":946,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3535,"open_issues":946,"watchers":15863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15796"},"html":{"href":"https://github.com/grpc/grpc/pull/15796"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/15796"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/15796/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15796/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/15796/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/138e6d61915c629ab60150526f48c31034d1da52"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apolcyn"}}