{"action":"closed","number":2696,"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2696","id":196905349,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTA1MzQ5","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2696","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/2696.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/2696.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2696","number":2696,"state":"closed","locked":false,"title":"If server_tokens is disabled completely remove the Server header","user":{"login":"bfin","id":3934895,"node_id":"MDQ6VXNlcjM5MzQ4OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3934895?v=4","gravatar_id":"","url":"https://api.github.com/users/bfin","html_url":"https://github.com/bfin","followers_url":"https://api.github.com/users/bfin/followers","following_url":"https://api.github.com/users/bfin/following{/other_user}","gists_url":"https://api.github.com/users/bfin/gists{/gist_id}","starred_url":"https://api.github.com/users/bfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfin/subscriptions","organizations_url":"https://api.github.com/users/bfin/orgs","repos_url":"https://api.github.com/users/bfin/repos","events_url":"https://api.github.com/users/bfin/events{/privacy}","received_events_url":"https://api.github.com/users/bfin/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nActually removes the `Server` header when `server-tokens: false`, instead of just setting a null value.\r\n\r\nThis PR makes use of the `more_clear_headers` directive instead of the `more_set_headers` directive, both of which are included in the headers-more-nginx-module that the controller is already built with. The `more_set_headers` directive is currently used to set a null value for the `Server` header, but the `more_clear_headers` directive can completely remove it.\r\n\r\nModule reference: [https://github.com/openresty/headers-more-nginx-module#more_clear_headers](https://github.com/openresty/headers-more-nginx-module#more_clear_headers)\r\n\r\n**Which issue this PR fixes**\r\n\r\nSupersedes PR #1903 to fix #1094 more thoroughly.","created_at":"2018-06-23T14:44:00Z","updated_at":"2018-06-23T15:35:19Z","closed_at":"2018-06-23T15:35:19Z","merged_at":null,"merge_commit_sha":"806e84c3a43a3ea4253863f4f53f58978248e575","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":496816953,"node_id":"MDU6TGFiZWw0OTY4MTY5NTM=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":677769656,"node_id":"MDU6TGFiZWw2Nzc3Njk2NTY=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2696/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2696/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2696/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/d59e3ee9dd6ce77b2b2a25c160f935bc474fd7a2","head":{"label":"bfin:fix/completely-remove-server-header","ref":"fix/completely-remove-server-header","sha":"d59e3ee9dd6ce77b2b2a25c160f935bc474fd7a2","user":{"login":"bfin","id":3934895,"node_id":"MDQ6VXNlcjM5MzQ4OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3934895?v=4","gravatar_id":"","url":"https://api.github.com/users/bfin","html_url":"https://github.com/bfin","followers_url":"https://api.github.com/users/bfin/followers","following_url":"https://api.github.com/users/bfin/following{/other_user}","gists_url":"https://api.github.com/users/bfin/gists{/gist_id}","starred_url":"https://api.github.com/users/bfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfin/subscriptions","organizations_url":"https://api.github.com/users/bfin/orgs","repos_url":"https://api.github.com/users/bfin/repos","events_url":"https://api.github.com/users/bfin/events{/privacy}","received_events_url":"https://api.github.com/users/bfin/received_events","type":"User","site_admin":false},"repo":{"id":138405365,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0MDUzNjU=","name":"ingress-nginx","full_name":"bfin/ingress-nginx","owner":{"login":"bfin","id":3934895,"node_id":"MDQ6VXNlcjM5MzQ4OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/3934895?v=4","gravatar_id":"","url":"https://api.github.com/users/bfin","html_url":"https://github.com/bfin","followers_url":"https://api.github.com/users/bfin/followers","following_url":"https://api.github.com/users/bfin/following{/other_user}","gists_url":"https://api.github.com/users/bfin/gists{/gist_id}","starred_url":"https://api.github.com/users/bfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfin/subscriptions","organizations_url":"https://api.github.com/users/bfin/orgs","repos_url":"https://api.github.com/users/bfin/repos","events_url":"https://api.github.com/users/bfin/events{/privacy}","received_events_url":"https://api.github.com/users/bfin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bfin/ingress-nginx","description":"NGINX Ingress Controller for Kubernetes https://kubernetes.github.io/ingress-nginx/","fork":true,"url":"https://api.github.com/repos/bfin/ingress-nginx","forks_url":"https://api.github.com/repos/bfin/ingress-nginx/forks","keys_url":"https://api.github.com/repos/bfin/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bfin/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bfin/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/bfin/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/bfin/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/bfin/ingress-nginx/events","assignees_url":"https://api.github.com/repos/bfin/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/bfin/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/bfin/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/bfin/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bfin/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bfin/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bfin/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bfin/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/bfin/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/bfin/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/bfin/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/bfin/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/bfin/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/bfin/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bfin/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bfin/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bfin/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bfin/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/bfin/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bfin/ingress-nginx/merges","archive_url":"https://api.github.com/repos/bfin/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bfin/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/bfin/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/bfin/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/bfin/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/bfin/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bfin/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/bfin/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/bfin/ingress-nginx/deployments","created_at":"2018-06-23T13:57:42Z","updated_at":"2018-06-23T13:57:44Z","pushed_at":"2018-06-23T14:31:49Z","git_url":"git://github.com/bfin/ingress-nginx.git","ssh_url":"git@github.com:bfin/ingress-nginx.git","clone_url":"https://github.com/bfin/ingress-nginx.git","svn_url":"https://github.com/bfin/ingress-nginx","homepage":"","size":68625,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4f44ddcf73c4a6162e3dff7058479dedc78abf44","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":72891330,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg5MTMzMA==","name":"ingress-nginx","full_name":"kubernetes/ingress-nginx","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-nginx","description":"NGINX Ingress Controller for Kubernetes https://kubernetes.github.io/ingress-nginx/","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-nginx","forks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-nginx/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/deployments","created_at":"2016-11-04T22:54:14Z","updated_at":"2018-06-23T15:31:57Z","pushed_at":"2018-06-23T14:44:01Z","git_url":"git://github.com/kubernetes/ingress-nginx.git","ssh_url":"git@github.com:kubernetes/ingress-nginx.git","clone_url":"https://github.com/kubernetes/ingress-nginx.git","svn_url":"https://github.com/kubernetes/ingress-nginx","homepage":"","size":79423,"stargazers_count":2185,"watchers_count":2185,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1153,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1153,"open_issues":96,"watchers":2185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2696"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/2696"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2696"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2696/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2696/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2696/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/d59e3ee9dd6ce77b2b2a25c160f935bc474fd7a2"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"aledbf"}}