{"action":"closed","number":6601,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/6601","id":210110416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMTEwNDE2","html_url":"https://github.com/apache/flink/pull/6601","diff_url":"https://github.com/apache/flink/pull/6601.diff","patch_url":"https://github.com/apache/flink/pull/6601.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/6601","number":6601,"state":"closed","locked":false,"title":"[FLINK-10193] Add @RpcTimeout to JobMasterGateway.triggerSavepoint","user":{"login":"GJL","id":1681921,"node_id":"MDQ6VXNlcjE2ODE5MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1681921?v=4","gravatar_id":"","url":"https://api.github.com/users/GJL","html_url":"https://github.com/GJL","followers_url":"https://api.github.com/users/GJL/followers","following_url":"https://api.github.com/users/GJL/following{/other_user}","gists_url":"https://api.github.com/users/GJL/gists{/gist_id}","starred_url":"https://api.github.com/users/GJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJL/subscriptions","organizations_url":"https://api.github.com/users/GJL/orgs","repos_url":"https://api.github.com/users/GJL/repos","events_url":"https://api.github.com/users/GJL/events{/privacy}","received_events_url":"https://api.github.com/users/GJL/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\n*This adds the `@RpcTimeout` annotation to `JobMasterGateway.triggerSavepoint` so that the default timeout is overridden.*\r\n\r\ncc: @uce @tillrohrmann \r\n\r\n## Brief change log\r\n\r\n  - *Add @RpcTimeout to `JobMasterGateway.triggerSavepoint`.*\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - *Manually verified the change by running `SlowToCheckpoint` job, which is attached to the FLINK-10193 issue. Savepoint duration was 45s and command used to take savepoint was: `bin/flink savepoint <JOB_ID> file:///tmp/flink-sps`*\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (yes / **no**)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)\r\n  - The serializers: (yes / **no** / don't know)\r\n  - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)\r\n  - The S3 file system connector: (yes / **no** / don't know)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (yes / **no**)\r\n  - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)\r\n","created_at":"2018-08-22T12:01:19Z","updated_at":"2018-09-07T13:41:13Z","closed_at":"2018-09-07T13:41:13Z","merged_at":null,"merge_commit_sha":"d510673550db61133fa4a955226bf5095413e547","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/6601/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/6601/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/6601/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/bec9c4d1f3994ef3a11dd81846afe0a80bded352","head":{"label":"GJL:FLINK-10193","ref":"FLINK-10193","sha":"bec9c4d1f3994ef3a11dd81846afe0a80bded352","user":{"login":"GJL","id":1681921,"node_id":"MDQ6VXNlcjE2ODE5MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1681921?v=4","gravatar_id":"","url":"https://api.github.com/users/GJL","html_url":"https://github.com/GJL","followers_url":"https://api.github.com/users/GJL/followers","following_url":"https://api.github.com/users/GJL/following{/other_user}","gists_url":"https://api.github.com/users/GJL/gists{/gist_id}","starred_url":"https://api.github.com/users/GJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJL/subscriptions","organizations_url":"https://api.github.com/users/GJL/orgs","repos_url":"https://api.github.com/users/GJL/repos","events_url":"https://api.github.com/users/GJL/events{/privacy}","received_events_url":"https://api.github.com/users/GJL/received_events","type":"User","site_admin":false},"repo":{"id":62889945,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjg4OTk0NQ==","name":"flink","full_name":"GJL/flink","owner":{"login":"GJL","id":1681921,"node_id":"MDQ6VXNlcjE2ODE5MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1681921?v=4","gravatar_id":"","url":"https://api.github.com/users/GJL","html_url":"https://github.com/GJL","followers_url":"https://api.github.com/users/GJL/followers","following_url":"https://api.github.com/users/GJL/following{/other_user}","gists_url":"https://api.github.com/users/GJL/gists{/gist_id}","starred_url":"https://api.github.com/users/GJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GJL/subscriptions","organizations_url":"https://api.github.com/users/GJL/orgs","repos_url":"https://api.github.com/users/GJL/repos","events_url":"https://api.github.com/users/GJL/events{/privacy}","received_events_url":"https://api.github.com/users/GJL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GJL/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/GJL/flink","forks_url":"https://api.github.com/repos/GJL/flink/forks","keys_url":"https://api.github.com/repos/GJL/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GJL/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GJL/flink/teams","hooks_url":"https://api.github.com/repos/GJL/flink/hooks","issue_events_url":"https://api.github.com/repos/GJL/flink/issues/events{/number}","events_url":"https://api.github.com/repos/GJL/flink/events","assignees_url":"https://api.github.com/repos/GJL/flink/assignees{/user}","branches_url":"https://api.github.com/repos/GJL/flink/branches{/branch}","tags_url":"https://api.github.com/repos/GJL/flink/tags","blobs_url":"https://api.github.com/repos/GJL/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GJL/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GJL/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/GJL/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GJL/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/GJL/flink/languages","stargazers_url":"https://api.github.com/repos/GJL/flink/stargazers","contributors_url":"https://api.github.com/repos/GJL/flink/contributors","subscribers_url":"https://api.github.com/repos/GJL/flink/subscribers","subscription_url":"https://api.github.com/repos/GJL/flink/subscription","commits_url":"https://api.github.com/repos/GJL/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/GJL/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/GJL/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/GJL/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/GJL/flink/contents/{+path}","compare_url":"https://api.github.com/repos/GJL/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GJL/flink/merges","archive_url":"https://api.github.com/repos/GJL/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GJL/flink/downloads","issues_url":"https://api.github.com/repos/GJL/flink/issues{/number}","pulls_url":"https://api.github.com/repos/GJL/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/GJL/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/GJL/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GJL/flink/labels{/name}","releases_url":"https://api.github.com/repos/GJL/flink/releases{/id}","deployments_url":"https://api.github.com/repos/GJL/flink/deployments","created_at":"2016-07-08T13:17:35Z","updated_at":"2018-07-08T15:19:45Z","pushed_at":"2018-08-31T06:36:53Z","git_url":"git://github.com/GJL/flink.git","ssh_url":"git@github.com:GJL/flink.git","clone_url":"https://github.com/GJL/flink.git","svn_url":"https://github.com/GJL/flink","homepage":null,"size":158417,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3fd6587208a16940eab327ed37fa4e23d0b7eb62","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-09-07T12:28:32Z","pushed_at":"2018-09-07T13:39:52Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":164152,"stargazers_count":4323,"watchers_count":4323,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2844,"mirror_url":null,"archived":false,"open_issues_count":402,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2844,"open_issues":402,"watchers":4323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/6601"},"html":{"href":"https://github.com/apache/flink/pull/6601"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/6601"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/6601/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/6601/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/6601/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/bec9c4d1f3994ef3a11dd81846afe0a80bded352"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":66,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"asfgit"}}