{"action":"created","comment":{"url":"https://api.github.com/repos/ideascube/ansiblecube/pulls/comments/169978391","pull_request_review_id":98588874,"id":169978391,"diff_hunk":"@@ -1,7 +1,9 @@\n ---\n #Network\n hotspot_ip: 192.168.2.1\n+hotspot_source_range : 192.168.2.2-192.168.2.254\n external_hotspot_ip: 192.168.3.1\n+external_hotspot_source_range: 192.168.3.2-192.168.3.254\n hotspot_interface: wlan0\n lan_interface: eth0\n client_interface: wlan1","path":"group_vars/all","position":9,"original_position":9,"commit_id":"4ae6c77d9d713d9ed524ce67da1ff12173061357","original_commit_id":"6fb1a9cf3c658c9e092559cfe410bf79b688ec9a","user":{"login":"swbsf","id":22593912,"avatar_url":"https://avatars0.githubusercontent.com/u/22593912?v=4","gravatar_id":"","url":"https://api.github.com/users/swbsf","html_url":"https://github.com/swbsf","followers_url":"https://api.github.com/users/swbsf/followers","following_url":"https://api.github.com/users/swbsf/following{/other_user}","gists_url":"https://api.github.com/users/swbsf/gists{/gist_id}","starred_url":"https://api.github.com/users/swbsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swbsf/subscriptions","organizations_url":"https://api.github.com/users/swbsf/orgs","repos_url":"https://api.github.com/users/swbsf/repos","events_url":"https://api.github.com/users/swbsf/events{/privacy}","received_events_url":"https://api.github.com/users/swbsf/received_events","type":"User","site_admin":false},"body":"I don't get which scenario can this happen?","created_at":"2018-02-22T14:43:45Z","updated_at":"2018-02-22T14:43:46Z","html_url":"https://github.com/ideascube/ansiblecube/pull/177#discussion_r169978391","pull_request_url":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ideascube/ansiblecube/pulls/comments/169978391"},"html":{"href":"https://github.com/ideascube/ansiblecube/pull/177#discussion_r169978391"},"pull_request":{"href":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177"}},"in_reply_to_id":169906603},"pull_request":{"url":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177","id":170682034,"html_url":"https://github.com/ideascube/ansiblecube/pull/177","diff_url":"https://github.com/ideascube/ansiblecube/pull/177.diff","patch_url":"https://github.com/ideascube/ansiblecube/pull/177.patch","issue_url":"https://api.github.com/repos/ideascube/ansiblecube/issues/177","number":177,"state":"closed","locked":false,"title":"Making sure rule match when source and destination are in same subnet.","user":{"login":"swbsf","id":22593912,"avatar_url":"https://avatars0.githubusercontent.com/u/22593912?v=4","gravatar_id":"","url":"https://api.github.com/users/swbsf","html_url":"https://github.com/swbsf","followers_url":"https://api.github.com/users/swbsf/followers","following_url":"https://api.github.com/users/swbsf/following{/other_user}","gists_url":"https://api.github.com/users/swbsf/gists{/gist_id}","starred_url":"https://api.github.com/users/swbsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swbsf/subscriptions","organizations_url":"https://api.github.com/users/swbsf/orgs","repos_url":"https://api.github.com/users/swbsf/repos","events_url":"https://api.github.com/users/swbsf/events{/privacy}","received_events_url":"https://api.github.com/users/swbsf/received_events","type":"User","site_admin":false},"body":"If I understood the problem correctly, rules are matching for user coming from wrong subnet in external_antenna scenario.\r\nThis should fix as we are linking source_range to hotspot_ip.\r\nWarning, this has not been tested.","created_at":"2018-02-22T08:15:42Z","updated_at":"2018-02-22T14:43:46Z","closed_at":"2018-02-22T14:43:35Z","merged_at":"2018-02-22T14:43:35Z","merge_commit_sha":"29e7627cd5508f2da5c24b1fd8e2c9ad2a1e8b5b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fheslouin","id":3833063,"avatar_url":"https://avatars1.githubusercontent.com/u/3833063?v=4","gravatar_id":"","url":"https://api.github.com/users/fheslouin","html_url":"https://github.com/fheslouin","followers_url":"https://api.github.com/users/fheslouin/followers","following_url":"https://api.github.com/users/fheslouin/following{/other_user}","gists_url":"https://api.github.com/users/fheslouin/gists{/gist_id}","starred_url":"https://api.github.com/users/fheslouin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fheslouin/subscriptions","organizations_url":"https://api.github.com/users/fheslouin/orgs","repos_url":"https://api.github.com/users/fheslouin/repos","events_url":"https://api.github.com/users/fheslouin/events{/privacy}","received_events_url":"https://api.github.com/users/fheslouin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177/commits","review_comments_url":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177/comments","review_comment_url":"https://api.github.com/repos/ideascube/ansiblecube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ideascube/ansiblecube/issues/177/comments","statuses_url":"https://api.github.com/repos/ideascube/ansiblecube/statuses/4ae6c77d9d713d9ed524ce67da1ff12173061357","head":{"label":"ideascube:iptables_ext_antenna_fix","ref":"iptables_ext_antenna_fix","sha":"4ae6c77d9d713d9ed524ce67da1ff12173061357","user":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars1.githubusercontent.com/u/9719862?v=4","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"repo":{"id":44964602,"name":"ansiblecube","full_name":"ideascube/ansiblecube","owner":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars1.githubusercontent.com/u/9719862?v=4","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ideascube/ansiblecube","description":"Ansible playbook to quickly deploy an ideascube server and much more !","fork":false,"url":"https://api.github.com/repos/ideascube/ansiblecube","forks_url":"https://api.github.com/repos/ideascube/ansiblecube/forks","keys_url":"https://api.github.com/repos/ideascube/ansiblecube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ideascube/ansiblecube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ideascube/ansiblecube/teams","hooks_url":"https://api.github.com/repos/ideascube/ansiblecube/hooks","issue_events_url":"https://api.github.com/repos/ideascube/ansiblecube/issues/events{/number}","events_url":"https://api.github.com/repos/ideascube/ansiblecube/events","assignees_url":"https://api.github.com/repos/ideascube/ansiblecube/assignees{/user}","branches_url":"https://api.github.com/repos/ideascube/ansiblecube/branches{/branch}","tags_url":"https://api.github.com/repos/ideascube/ansiblecube/tags","blobs_url":"https://api.github.com/repos/ideascube/ansiblecube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ideascube/ansiblecube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ideascube/ansiblecube/git/refs{/sha}","trees_url":"https://api.github.com/repos/ideascube/ansiblecube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ideascube/ansiblecube/statuses/{sha}","languages_url":"https://api.github.com/repos/ideascube/ansiblecube/languages","stargazers_url":"https://api.github.com/repos/ideascube/ansiblecube/stargazers","contributors_url":"https://api.github.com/repos/ideascube/ansiblecube/contributors","subscribers_url":"https://api.github.com/repos/ideascube/ansiblecube/subscribers","subscription_url":"https://api.github.com/repos/ideascube/ansiblecube/subscription","commits_url":"https://api.github.com/repos/ideascube/ansiblecube/commits{/sha}","git_commits_url":"https://api.github.com/repos/ideascube/ansiblecube/git/commits{/sha}","comments_url":"https://api.github.com/repos/ideascube/ansiblecube/comments{/number}","issue_comment_url":"https://api.github.com/repos/ideascube/ansiblecube/issues/comments{/number}","contents_url":"https://api.github.com/repos/ideascube/ansiblecube/contents/{+path}","compare_url":"https://api.github.com/repos/ideascube/ansiblecube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ideascube/ansiblecube/merges","archive_url":"https://api.github.com/repos/ideascube/ansiblecube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ideascube/ansiblecube/downloads","issues_url":"https://api.github.com/repos/ideascube/ansiblecube/issues{/number}","pulls_url":"https://api.github.com/repos/ideascube/ansiblecube/pulls{/number}","milestones_url":"https://api.github.com/repos/ideascube/ansiblecube/milestones{/number}","notifications_url":"https://api.github.com/repos/ideascube/ansiblecube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ideascube/ansiblecube/labels{/name}","releases_url":"https://api.github.com/repos/ideascube/ansiblecube/releases{/id}","deployments_url":"https://api.github.com/repos/ideascube/ansiblecube/deployments","created_at":"2015-10-26T11:38:10Z","updated_at":"2018-01-30T19:51:42Z","pushed_at":"2018-02-22T14:43:35Z","git_url":"git://github.com/ideascube/ansiblecube.git","ssh_url":"git@github.com:ideascube/ansiblecube.git","clone_url":"https://github.com/ideascube/ansiblecube.git","svn_url":"https://github.com/ideascube/ansiblecube","homepage":"","size":1955,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":35,"watchers":2,"default_branch":"master"}},"base":{"label":"ideascube:oneUpdateFile","ref":"oneUpdateFile","sha":"6c35071acfc97b07bc7ab16ea4ee60576469c66d","user":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars1.githubusercontent.com/u/9719862?v=4","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"repo":{"id":44964602,"name":"ansiblecube","full_name":"ideascube/ansiblecube","owner":{"login":"ideascube","id":9719862,"avatar_url":"https://avatars1.githubusercontent.com/u/9719862?v=4","gravatar_id":"","url":"https://api.github.com/users/ideascube","html_url":"https://github.com/ideascube","followers_url":"https://api.github.com/users/ideascube/followers","following_url":"https://api.github.com/users/ideascube/following{/other_user}","gists_url":"https://api.github.com/users/ideascube/gists{/gist_id}","starred_url":"https://api.github.com/users/ideascube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideascube/subscriptions","organizations_url":"https://api.github.com/users/ideascube/orgs","repos_url":"https://api.github.com/users/ideascube/repos","events_url":"https://api.github.com/users/ideascube/events{/privacy}","received_events_url":"https://api.github.com/users/ideascube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ideascube/ansiblecube","description":"Ansible playbook to quickly deploy an ideascube server and much more !","fork":false,"url":"https://api.github.com/repos/ideascube/ansiblecube","forks_url":"https://api.github.com/repos/ideascube/ansiblecube/forks","keys_url":"https://api.github.com/repos/ideascube/ansiblecube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ideascube/ansiblecube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ideascube/ansiblecube/teams","hooks_url":"https://api.github.com/repos/ideascube/ansiblecube/hooks","issue_events_url":"https://api.github.com/repos/ideascube/ansiblecube/issues/events{/number}","events_url":"https://api.github.com/repos/ideascube/ansiblecube/events","assignees_url":"https://api.github.com/repos/ideascube/ansiblecube/assignees{/user}","branches_url":"https://api.github.com/repos/ideascube/ansiblecube/branches{/branch}","tags_url":"https://api.github.com/repos/ideascube/ansiblecube/tags","blobs_url":"https://api.github.com/repos/ideascube/ansiblecube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ideascube/ansiblecube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ideascube/ansiblecube/git/refs{/sha}","trees_url":"https://api.github.com/repos/ideascube/ansiblecube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ideascube/ansiblecube/statuses/{sha}","languages_url":"https://api.github.com/repos/ideascube/ansiblecube/languages","stargazers_url":"https://api.github.com/repos/ideascube/ansiblecube/stargazers","contributors_url":"https://api.github.com/repos/ideascube/ansiblecube/contributors","subscribers_url":"https://api.github.com/repos/ideascube/ansiblecube/subscribers","subscription_url":"https://api.github.com/repos/ideascube/ansiblecube/subscription","commits_url":"https://api.github.com/repos/ideascube/ansiblecube/commits{/sha}","git_commits_url":"https://api.github.com/repos/ideascube/ansiblecube/git/commits{/sha}","comments_url":"https://api.github.com/repos/ideascube/ansiblecube/comments{/number}","issue_comment_url":"https://api.github.com/repos/ideascube/ansiblecube/issues/comments{/number}","contents_url":"https://api.github.com/repos/ideascube/ansiblecube/contents/{+path}","compare_url":"https://api.github.com/repos/ideascube/ansiblecube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ideascube/ansiblecube/merges","archive_url":"https://api.github.com/repos/ideascube/ansiblecube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ideascube/ansiblecube/downloads","issues_url":"https://api.github.com/repos/ideascube/ansiblecube/issues{/number}","pulls_url":"https://api.github.com/repos/ideascube/ansiblecube/pulls{/number}","milestones_url":"https://api.github.com/repos/ideascube/ansiblecube/milestones{/number}","notifications_url":"https://api.github.com/repos/ideascube/ansiblecube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ideascube/ansiblecube/labels{/name}","releases_url":"https://api.github.com/repos/ideascube/ansiblecube/releases{/id}","deployments_url":"https://api.github.com/repos/ideascube/ansiblecube/deployments","created_at":"2015-10-26T11:38:10Z","updated_at":"2018-01-30T19:51:42Z","pushed_at":"2018-02-22T14:43:35Z","git_url":"git://github.com/ideascube/ansiblecube.git","ssh_url":"git@github.com:ideascube/ansiblecube.git","clone_url":"https://github.com/ideascube/ansiblecube.git","svn_url":"https://github.com/ideascube/ansiblecube","homepage":"","size":1955,"stargazers_count":2,"watchers_count":2,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":35,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177"},"html":{"href":"https://github.com/ideascube/ansiblecube/pull/177"},"issue":{"href":"https://api.github.com/repos/ideascube/ansiblecube/issues/177"},"comments":{"href":"https://api.github.com/repos/ideascube/ansiblecube/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/ideascube/ansiblecube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ideascube/ansiblecube/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/ideascube/ansiblecube/statuses/4ae6c77d9d713d9ed524ce67da1ff12173061357"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"swbsf"}}