{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments/228055791","pull_request_review_id":168234210,"id":228055791,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODA1NTc5MQ==","diff_hunk":"@@ -144,10 +145,11 @@ def __init__(self, index, description=''):\n         self.description = description\n \n class MAVEnumEntry(object):\n-    def __init__(self, name, value, description='', end_marker=False, autovalue=False, origin_file='', origin_line=0):\n+    def __init__(self, name, value, description='', wip=False, end_marker=False, autovalue=False, origin_file='', origin_line=0):","path":"generator/mavparse.py","position":20,"original_position":20,"commit_id":"daa3beb724453411597e4ea7dc7d89e96ced491a","original_commit_id":"daa3beb724453411597e4ea7dc7d89e96ced491a","user":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"body":"Ah, but you haven't considered that name, value, description AND wip are properties of the XML file and hence sensibly grouped. The others are properties of this parser. IMO doesn't make sense to shove at the end. ","created_at":"2018-10-25T07:09:40Z","updated_at":"2018-10-25T07:09:40Z","html_url":"https://github.com/ArduPilot/pymavlink/pull/234#discussion_r228055791","pull_request_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments/228055791"},"html":{"href":"https://github.com/ArduPilot/pymavlink/pull/234#discussion_r228055791"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234"}},"in_reply_to_id":228049800},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234","id":225604612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjA0NjEy","html_url":"https://github.com/ArduPilot/pymavlink/pull/234","diff_url":"https://github.com/ArduPilot/pymavlink/pull/234.diff","patch_url":"https://github.com/ArduPilot/pymavlink/pull/234.patch","issue_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/234","number":234,"state":"open","locked":false,"title":"Add support for with-wip","user":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"body":"Recently we added a tag [`<wip>`](https://mavlink.io/en/guide/xml_schema.html#wip) for messages and enum values that indicates the message is a work in progress. \r\n\r\nThis adds a flag `--with--wip` that you must specify in a build to include those messages/values in the generated library. If you don't specify it, the messages are stripped (as discussed by @amilcarlucas [here](https://github.com/mavlink/mavlink/pull/910#issuecomment-408010030)).\r\n\r\nThe generator strips the wip messages/enums after validation, but before generation.","created_at":"2018-10-25T02:26:06Z","updated_at":"2018-10-25T07:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b8fb71e18722d6ce855bbea6653b250eb4ba570","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/234/comments","statuses_url":"https://api.github.com/repos/ArduPilot/pymavlink/statuses/daa3beb724453411597e4ea7dc7d89e96ced491a","head":{"label":"hamishwillee:add_wip","ref":"add_wip","sha":"daa3beb724453411597e4ea7dc7d89e96ced491a","user":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"repo":{"id":140777595,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3Nzc1OTU=","name":"pymavlink","full_name":"hamishwillee/pymavlink","private":false,"owner":{"login":"hamishwillee","id":5368500,"node_id":"MDQ6VXNlcjUzNjg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5368500?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishwillee","html_url":"https://github.com/hamishwillee","followers_url":"https://api.github.com/users/hamishwillee/followers","following_url":"https://api.github.com/users/hamishwillee/following{/other_user}","gists_url":"https://api.github.com/users/hamishwillee/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishwillee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishwillee/subscriptions","organizations_url":"https://api.github.com/users/hamishwillee/orgs","repos_url":"https://api.github.com/users/hamishwillee/repos","events_url":"https://api.github.com/users/hamishwillee/events{/privacy}","received_events_url":"https://api.github.com/users/hamishwillee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hamishwillee/pymavlink","description":"python MAVLink interface and utilities","fork":true,"url":"https://api.github.com/repos/hamishwillee/pymavlink","forks_url":"https://api.github.com/repos/hamishwillee/pymavlink/forks","keys_url":"https://api.github.com/repos/hamishwillee/pymavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hamishwillee/pymavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hamishwillee/pymavlink/teams","hooks_url":"https://api.github.com/repos/hamishwillee/pymavlink/hooks","issue_events_url":"https://api.github.com/repos/hamishwillee/pymavlink/issues/events{/number}","events_url":"https://api.github.com/repos/hamishwillee/pymavlink/events","assignees_url":"https://api.github.com/repos/hamishwillee/pymavlink/assignees{/user}","branches_url":"https://api.github.com/repos/hamishwillee/pymavlink/branches{/branch}","tags_url":"https://api.github.com/repos/hamishwillee/pymavlink/tags","blobs_url":"https://api.github.com/repos/hamishwillee/pymavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hamishwillee/pymavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hamishwillee/pymavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/hamishwillee/pymavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hamishwillee/pymavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/hamishwillee/pymavlink/languages","stargazers_url":"https://api.github.com/repos/hamishwillee/pymavlink/stargazers","contributors_url":"https://api.github.com/repos/hamishwillee/pymavlink/contributors","subscribers_url":"https://api.github.com/repos/hamishwillee/pymavlink/subscribers","subscription_url":"https://api.github.com/repos/hamishwillee/pymavlink/subscription","commits_url":"https://api.github.com/repos/hamishwillee/pymavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/hamishwillee/pymavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/hamishwillee/pymavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/hamishwillee/pymavlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/hamishwillee/pymavlink/contents/{+path}","compare_url":"https://api.github.com/repos/hamishwillee/pymavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hamishwillee/pymavlink/merges","archive_url":"https://api.github.com/repos/hamishwillee/pymavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hamishwillee/pymavlink/downloads","issues_url":"https://api.github.com/repos/hamishwillee/pymavlink/issues{/number}","pulls_url":"https://api.github.com/repos/hamishwillee/pymavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/hamishwillee/pymavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/hamishwillee/pymavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hamishwillee/pymavlink/labels{/name}","releases_url":"https://api.github.com/repos/hamishwillee/pymavlink/releases{/id}","deployments_url":"https://api.github.com/repos/hamishwillee/pymavlink/deployments","created_at":"2018-07-13T00:33:35Z","updated_at":"2018-10-22T07:19:48Z","pushed_at":"2018-10-25T03:52:17Z","git_url":"git://github.com/hamishwillee/pymavlink.git","ssh_url":"git@github.com:hamishwillee/pymavlink.git","clone_url":"https://github.com/hamishwillee/pymavlink.git","svn_url":"https://github.com/hamishwillee/pymavlink","homepage":null,"size":7027,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"33cef800d0fd30cdf4718879de2e60ecc633ecdb","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":67301306,"node_id":"MDEwOlJlcG9zaXRvcnk2NzMwMTMwNg==","name":"pymavlink","full_name":"ArduPilot/pymavlink","private":false,"owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArduPilot/pymavlink","description":"python MAVLink interface and utilities","fork":false,"url":"https://api.github.com/repos/ArduPilot/pymavlink","forks_url":"https://api.github.com/repos/ArduPilot/pymavlink/forks","keys_url":"https://api.github.com/repos/ArduPilot/pymavlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/pymavlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/pymavlink/teams","hooks_url":"https://api.github.com/repos/ArduPilot/pymavlink/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/pymavlink/events","assignees_url":"https://api.github.com/repos/ArduPilot/pymavlink/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/pymavlink/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/pymavlink/tags","blobs_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/pymavlink/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/pymavlink/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/pymavlink/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/pymavlink/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/pymavlink/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/pymavlink/subscription","commits_url":"https://api.github.com/repos/ArduPilot/pymavlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/pymavlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/pymavlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/pymavlink/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/pymavlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/pymavlink/merges","archive_url":"https://api.github.com/repos/ArduPilot/pymavlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/pymavlink/downloads","issues_url":"https://api.github.com/repos/ArduPilot/pymavlink/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/pymavlink/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/pymavlink/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/pymavlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/pymavlink/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/pymavlink/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/pymavlink/deployments","created_at":"2016-09-03T16:54:27Z","updated_at":"2018-10-23T23:00:08Z","pushed_at":"2018-10-25T03:52:19Z","git_url":"git://github.com/ArduPilot/pymavlink.git","ssh_url":"git@github.com:ArduPilot/pymavlink.git","clone_url":"https://github.com/ArduPilot/pymavlink.git","svn_url":"https://github.com/ArduPilot/pymavlink","homepage":null,"size":6972,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":159,"open_issues":44,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234"},"html":{"href":"https://github.com/ArduPilot/pymavlink/pull/234"},"issue":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/issues/234"},"comments":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/pymavlink/statuses/daa3beb724453411597e4ea7dc7d89e96ced491a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hamishwillee"}}