{"action":"created","issue":{"url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/issues/29","repository_url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket","labels_url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/issues/29/comments","events_url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/issues/29/events","html_url":"https://github.com/IBM-Swift/Kitura-WebSocket/pull/29","id":304466086,"number":29,"title":"No fragmenting control frames","user":{"login":"Andrew-Lees11","id":32634907,"avatar_url":"https://avatars2.githubusercontent.com/u/32634907?v=4","gravatar_id":"","url":"https://api.github.com/users/Andrew-Lees11","html_url":"https://github.com/Andrew-Lees11","followers_url":"https://api.github.com/users/Andrew-Lees11/followers","following_url":"https://api.github.com/users/Andrew-Lees11/following{/other_user}","gists_url":"https://api.github.com/users/Andrew-Lees11/gists{/gist_id}","starred_url":"https://api.github.com/users/Andrew-Lees11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andrew-Lees11/subscriptions","organizations_url":"https://api.github.com/users/Andrew-Lees11/orgs","repos_url":"https://api.github.com/users/Andrew-Lees11/repos","events_url":"https://api.github.com/users/Andrew-Lees11/events{/privacy}","received_events_url":"https://api.github.com/users/Andrew-Lees11/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-12T17:23:03Z","updated_at":"2018-03-12T18:17:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/pulls/29","html_url":"https://github.com/IBM-Swift/Kitura-WebSocket/pull/29","diff_url":"https://github.com/IBM-Swift/Kitura-WebSocket/pull/29.diff","patch_url":"https://github.com/IBM-Swift/Kitura-WebSocket/pull/29.patch"},"body":"By the [websockets protocol](https://tools.ietf.org/html/rfc6455#section-5.4) control frames such as ping, close and pong cannot be fragmented. \r\n\r\nThis means we should close if we receive a control frame which has a continuation.\r\n\r\nSince pong and close will close already we have only changed ping.\r\n\r\nThis now passes autobahn test 5.1 and a test to check this has been added."},"comment":{"url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/issues/comments/372411839","html_url":"https://github.com/IBM-Swift/Kitura-WebSocket/pull/29#issuecomment-372411839","issue_url":"https://api.github.com/repos/IBM-Swift/Kitura-WebSocket/issues/29","id":372411839,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T18:17:19Z","updated_at":"2018-03-12T18:17:19Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=h1) Report\n> Merging [#29](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=desc) into [master](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/commit/7633575a77a89333160d1e20dbeb690a3241305d?src=pr&el=desc) will **increase** coverage by `0.03%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29/graphs/tree.svg?height=150&width=650&token=tKnx4HhnuZ&src=pr)](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #29      +/-   ##\n==========================================\n+ Coverage   90.64%   90.68%   +0.03%     \n==========================================\n  Files           9        9              \n  Lines         481      483       +2     \n==========================================\n+ Hits          436      438       +2     \n  Misses         45       45\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #KituraWebSocket | `90.68% <100%> (+0.03%)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [Sources/KituraWebSocket/WebSocketConnection.swift](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29/diff?src=pr&el=tree#diff-U291cmNlcy9LaXR1cmFXZWJTb2NrZXQvV2ViU29ja2V0Q29ubmVjdGlvbi5zd2lmdA==) | `91.7% <100%> (+0.08%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=footer). Last update [7633575...76908b3](https://codecov.io/gh/IBM-Swift/Kitura-WebSocket/pull/29?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}