{"action":"closed","number":26865,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26865","id":210714105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzE0MTA1","html_url":"https://github.com/Automattic/wp-calypso/pull/26865","diff_url":"https://github.com/Automattic/wp-calypso/pull/26865.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/26865.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26865","number":26865,"state":"closed","locked":false,"title":"Correctly report eligibility page view and report clicks for plugin/theme upload buttons","user":{"login":"adamziel","id":205419,"node_id":"MDQ6VXNlcjIwNTQxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/205419?v=4","gravatar_id":"","url":"https://api.github.com/users/adamziel","html_url":"https://github.com/adamziel","followers_url":"https://api.github.com/users/adamziel/followers","following_url":"https://api.github.com/users/adamziel/following{/other_user}","gists_url":"https://api.github.com/users/adamziel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamziel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamziel/subscriptions","organizations_url":"https://api.github.com/users/adamziel/orgs","repos_url":"https://api.github.com/users/adamziel/repos","events_url":"https://api.github.com/users/adamziel/events{/privacy}","received_events_url":"https://api.github.com/users/adamziel/received_events","type":"User","site_admin":false},"body":"`<EligibilityWarnings />` component that is displayed on a standalone page as well as in places such as `/plugins` and `/themes` logs a page view with hardcoded URL. This PR fixes that so only the standalone page logs a page view. Also, it adds additional events when user clicks on \"Upload theme\" or \"Upload plugin\" buttons.\r\n\r\nTest plan:\r\n1. Navigate to a free site in Calypso\r\n1. Go to `/themes` and confirm in network panel of dev tools that only a page view for `/themes` is recorded\r\n1. Go to `/plugins` and confirm in network panel of dev tools that only a page view for `/plugins` is recorded\r\n1. Go to `/plugins/tinymce-advanced` and confirm in network panel of dev tools that only a page view for `/plugins/tinymce-advanced` is recorded\r\n1. Go to `/plugins/tinymce-advanced/eligibility/` and confirm in network panel of dev tools that only a page view for `/plugins/tinymce-advanced/eligibility/` is logged\r\n1. Go to `/plugins` and click on \"Upload plugin\" button, confirm in devtools that `calypso_click_plugin_upload` event was logged\r\n1. Go to `/plugins/manage` and click on \"Upload plugin\" button, confirm in devtools that `calypso_click_plugin_upload` event was logged\r\n1. Go to `/themes` and click on \"Upload theme\" button, confirm in devtools that `calypso_click_theme_upload` event was logged","created_at":"2018-08-24T11:28:35Z","updated_at":"2018-08-28T10:18:41Z","closed_at":"2018-08-28T10:18:41Z","merged_at":"2018-08-28T10:18:41Z","merge_commit_sha":"352a26cda8e155e2c9b0dc1f273aa08803499e94","assignee":{"login":"adamziel","id":205419,"node_id":"MDQ6VXNlcjIwNTQxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/205419?v=4","gravatar_id":"","url":"https://api.github.com/users/adamziel","html_url":"https://github.com/adamziel","followers_url":"https://api.github.com/users/adamziel/followers","following_url":"https://api.github.com/users/adamziel/following{/other_user}","gists_url":"https://api.github.com/users/adamziel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamziel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamziel/subscriptions","organizations_url":"https://api.github.com/users/adamziel/orgs","repos_url":"https://api.github.com/users/adamziel/repos","events_url":"https://api.github.com/users/adamziel/events{/privacy}","received_events_url":"https://api.github.com/users/adamziel/received_events","type":"User","site_admin":false},"assignees":[{"login":"adamziel","id":205419,"node_id":"MDQ6VXNlcjIwNTQxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/205419?v=4","gravatar_id":"","url":"https://api.github.com/users/adamziel","html_url":"https://github.com/adamziel","followers_url":"https://api.github.com/users/adamziel/followers","following_url":"https://api.github.com/users/adamziel/following{/other_user}","gists_url":"https://api.github.com/users/adamziel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamziel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamziel/subscriptions","organizations_url":"https://api.github.com/users/adamziel/orgs","repos_url":"https://api.github.com/users/adamziel/repos","events_url":"https://api.github.com/users/adamziel/events{/privacy}","received_events_url":"https://api.github.com/users/adamziel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":972310385,"node_id":"MDU6TGFiZWw5NzIzMTAzODU=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Marketing","name":"Marketing","color":"a1c8ed","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26865/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26865/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26865/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/d40fce9775a2ed4e9ec88032cb9bf6d5acf6f342","head":{"label":"Automattic:upsell/fix-tracks-events","ref":"upsell/fix-tracks-events","sha":"d40fce9775a2ed4e9ec88032cb9bf6d5acf6f342","user":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzNjg5NQ==","name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-08-28T10:12:34Z","pushed_at":"2018-08-28T10:18:41Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":107005,"stargazers_count":10375,"watchers_count":10375,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1458,"mirror_url":null,"archived":false,"open_issues_count":1609,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1458,"open_issues":1609,"watchers":10375,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"077588ee05cc3e532e2970bdd1a8e6ad562add03","user":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"node_id":"MDEwOlJlcG9zaXRvcnk0NTkzNjg5NQ==","name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzgwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The JavaScript and API powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2018-08-28T10:12:34Z","pushed_at":"2018-08-28T10:18:41Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":107005,"stargazers_count":10375,"watchers_count":10375,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1458,"mirror_url":null,"archived":false,"open_issues_count":1609,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1458,"open_issues":1609,"watchers":10375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26865"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/26865"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/26865"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/26865/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26865/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26865/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/d40fce9775a2ed4e9ec88032cb9bf6d5acf6f342"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adamziel","id":205419,"node_id":"MDQ6VXNlcjIwNTQxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/205419?v=4","gravatar_id":"","url":"https://api.github.com/users/adamziel","html_url":"https://github.com/adamziel","followers_url":"https://api.github.com/users/adamziel/followers","following_url":"https://api.github.com/users/adamziel/following{/other_user}","gists_url":"https://api.github.com/users/adamziel/gists{/gist_id}","starred_url":"https://api.github.com/users/adamziel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamziel/subscriptions","organizations_url":"https://api.github.com/users/adamziel/orgs","repos_url":"https://api.github.com/users/adamziel/repos","events_url":"https://api.github.com/users/adamziel/events{/privacy}","received_events_url":"https://api.github.com/users/adamziel/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":9,"deletions":4,"changed_files":5}}
{"actor":{"display_login":"adamziel"}}