{"action":"created","issue":{"url":"https://api.github.com/repos/kubeapps/kubeapps/issues/742","repository_url":"https://api.github.com/repos/kubeapps/kubeapps","labels_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/742/labels{/name}","comments_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/742/comments","events_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/742/events","html_url":"https://github.com/kubeapps/kubeapps/pull/742","id":371470565,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTA5MjA3","number":742,"title":"Refactor binding list","user":{"login":"andresmgot","id":4025665,"node_id":"MDQ6VXNlcjQwMjU2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-18T10:47:11Z","updated_at":"2018-10-22T14:30:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubeapps/kubeapps/pulls/742","html_url":"https://github.com/kubeapps/kubeapps/pull/742","diff_url":"https://github.com/kubeapps/kubeapps/pull/742.diff","patch_url":"https://github.com/kubeapps/kubeapps/pull/742.patch"},"body":"Fixes #455\r\n\r\nThis PR refactors how the binding list is represented in the Service Instance View. The summary of the changes are:\r\n\r\n - The columns of the table are now: Binding | Status | Message | Details\r\n - Since the message can be quite big it's now displayed in its own modal if the user clicks in the button \"Show message\". (Recommendation made by @Angelmmiguel )\r\n - I removed the `Extend/Collapse` button since it was adding a new row to the table which looked confusing. Instead the \"Details\" column is now always present. The format of these details has been refactored as well.\r\n - It fixes #455 since the latest condition from the list is now picked by date instead of relying in the order of the array.\r\n\r\nIf these changes are approved we should use the same approach for ordering in `ServiceInstanceCardList` and apply the \"Show message\" button to the service instance message as well.\r\n\r\nScreenshots:\r\n\r\n<img width=\"1179\" alt=\"screen shot 2018-10-18 at 10 17 07\" src=\"https://user-images.githubusercontent.com/4025665/47149126-fa5a7f00-d2d2-11e8-82a7-f4fe9560ae0a.png\">\r\n\r\nWhen clicking in \"Show message\":\r\n\r\n<img width=\"1204\" alt=\"screen shot 2018-10-17 at 18 16 34\" src=\"https://user-images.githubusercontent.com/4025665/47149140-034b5080-d2d3-11e8-978f-ca2a71f1868e.png\">\r\n\r\nFor the record this is how the table looks without these changes:\r\n\r\n<img width=\"1242\" alt=\"screen shot 2018-10-18 at 12 43 34\" src=\"https://user-images.githubusercontent.com/4025665/47149327-8c628780-d2d3-11e8-9453-179fd739b858.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/kubeapps/kubeapps/issues/comments/431852286","html_url":"https://github.com/kubeapps/kubeapps/pull/742#issuecomment-431852286","issue_url":"https://api.github.com/repos/kubeapps/kubeapps/issues/742","id":431852286,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTg1MjI4Ng==","user":{"login":"andresmgot","id":4025665,"node_id":"MDQ6VXNlcjQwMjU2NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/4025665?v=4","gravatar_id":"","url":"https://api.github.com/users/andresmgot","html_url":"https://github.com/andresmgot","followers_url":"https://api.github.com/users/andresmgot/followers","following_url":"https://api.github.com/users/andresmgot/following{/other_user}","gists_url":"https://api.github.com/users/andresmgot/gists{/gist_id}","starred_url":"https://api.github.com/users/andresmgot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresmgot/subscriptions","organizations_url":"https://api.github.com/users/andresmgot/orgs","repos_url":"https://api.github.com/users/andresmgot/repos","events_url":"https://api.github.com/users/andresmgot/events{/privacy}","received_events_url":"https://api.github.com/users/andresmgot/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T14:30:17Z","updated_at":"2018-10-22T14:30:17Z","author_association":"CONTRIBUTOR","body":"Thanks @Angelmmiguel for taking a look? Can you do a quick review again?  "}}
{"actor":{"display_login":"andresmgot"}}