{"action":"created","issue":{"url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4217","repository_url":"https://api.github.com/repos/qmk/qmk_firmware","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4217/labels{/name}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4217/comments","events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4217/events","html_url":"https://github.com/qmk/qmk_firmware/pull/4217","id":372874007,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTQ0MzYz","number":4217,"title":"Refactor process_unicode_common code + make keys used for UC_WINC and UC_OSX configurable","user":{"login":"vomindoraan","id":1969863,"node_id":"MDQ6VXNlcjE5Njk4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1969863?v=4","gravatar_id":"","url":"https://api.github.com/users/vomindoraan","html_url":"https://github.com/vomindoraan","followers_url":"https://api.github.com/users/vomindoraan/followers","following_url":"https://api.github.com/users/vomindoraan/following{/other_user}","gists_url":"https://api.github.com/users/vomindoraan/gists{/gist_id}","starred_url":"https://api.github.com/users/vomindoraan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vomindoraan/subscriptions","organizations_url":"https://api.github.com/users/vomindoraan/orgs","repos_url":"https://api.github.com/users/vomindoraan/repos","events_url":"https://api.github.com/users/vomindoraan/events{/privacy}","received_events_url":"https://api.github.com/users/vomindoraan/received_events","type":"User","site_admin":false},"labels":[{"id":155557982,"node_id":"MDU6TGFiZWwxNTU1NTc5ODI=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/enhancement","name":"enhancement","color":"c5def5","default":true},{"id":604002030,"node_id":"MDU6TGFiZWw2MDQwMDIwMzA=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/optimization","name":"optimization","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-23T08:34:20Z","updated_at":"2018-10-23T15:50:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4217","html_url":"https://github.com/qmk/qmk_firmware/pull/4217","diff_url":"https://github.com/qmk/qmk_firmware/pull/4217.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4217.patch"},"body":"While working on new Unicode features, I noticed some parts of `process_unicode_common.*` were written in a verbose and outdated way. There were also some unnecessary bits, like the unused `static uint8_t input_mode` in the header. This PR cleans up that code.\r\n\r\nI've also made the key used by WinCompose configurable, as it can be changed in the WinCompose settings. The default is  `KC_RALT`.\r\n\r\nI've removed `UC_OSX_RALT` (which worked the same as `UC_OSX`, it just sent `KC_RALT` instead of `KC_LALT`) in favor of making the sent key configurable. `UC_OSX_RALT` [wasn't being used in any keymap](https://github.com/qmk/qmk_firmware/search?q=UC_OSX_RALT).\r\n\r\nThese changes should not affect existing behavior in any way.\r\n- [x] Test on Windows\r\n- [x] Test on Linux\r\n- [x] Test on Mac (would appreciate help with this)\r\n\r\n@drashna Please review if you can.\r\nThanks."},"comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments/432304755","html_url":"https://github.com/qmk/qmk_firmware/pull/4217#issuecomment-432304755","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4217","id":432304755,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjMwNDc1NQ==","user":{"login":"vomindoraan","id":1969863,"node_id":"MDQ6VXNlcjE5Njk4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1969863?v=4","gravatar_id":"","url":"https://api.github.com/users/vomindoraan","html_url":"https://github.com/vomindoraan","followers_url":"https://api.github.com/users/vomindoraan/followers","following_url":"https://api.github.com/users/vomindoraan/following{/other_user}","gists_url":"https://api.github.com/users/vomindoraan/gists{/gist_id}","starred_url":"https://api.github.com/users/vomindoraan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vomindoraan/subscriptions","organizations_url":"https://api.github.com/users/vomindoraan/orgs","repos_url":"https://api.github.com/users/vomindoraan/repos","events_url":"https://api.github.com/users/vomindoraan/events{/privacy}","received_events_url":"https://api.github.com/users/vomindoraan/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T15:50:17Z","updated_at":"2018-10-23T15:50:17Z","author_association":"CONTRIBUTOR","body":"I've tested this with my existing keymaps that have Unicode in them on all three platforms (many thanks to my coworkers who lent me their Macs!).\r\n\r\nIf anyone else could double-check with their own keymaps, that would be great."}}
{"actor":{"display_login":"vomindoraan"}}