{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23879","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23879/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23879/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23879/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23879","id":299838479,"number":23879,"title":"react-navigation: fix to properly support navigator-level navigationOptions as a function","user":{"login":"YourGamesBeOver","id":3501739,"avatar_url":"https://avatars1.githubusercontent.com/u/3501739?v=4","gravatar_id":"","url":"https://api.github.com/users/YourGamesBeOver","html_url":"https://github.com/YourGamesBeOver","followers_url":"https://api.github.com/users/YourGamesBeOver/followers","following_url":"https://api.github.com/users/YourGamesBeOver/following{/other_user}","gists_url":"https://api.github.com/users/YourGamesBeOver/gists{/gist_id}","starred_url":"https://api.github.com/users/YourGamesBeOver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YourGamesBeOver/subscriptions","organizations_url":"https://api.github.com/users/YourGamesBeOver/orgs","repos_url":"https://api.github.com/users/YourGamesBeOver/repos","events_url":"https://api.github.com/users/YourGamesBeOver/events{/privacy}","received_events_url":"https://api.github.com/users/YourGamesBeOver/received_events","type":"User","site_admin":false},"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-23T20:21:28Z","updated_at":"2018-02-26T19:43:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/23879","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23879","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23879.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23879.patch"},"body":"navigationOptions, when specified at the Navigator level, supports being called as a function with `{navigationOptions, navigation, screenProps}` as the parameter.  However, due to a mistake in the typings, `navigation` and `screenProps` were instead included as properties on the function itself as opposed to the object passed into it.  This PR fixes this and also adds a test for this case.\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://reactnavigation.org/docs/headers.html#sharing-common-navigationoptions-across-screens \r\nhttps://reactnavigation.org/docs/headers.html#overriding-shared-navigationoptions\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/368625177","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/23879#issuecomment-368625177","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/23879","id":368625177,"user":{"login":"YourGamesBeOver","id":3501739,"avatar_url":"https://avatars1.githubusercontent.com/u/3501739?v=4","gravatar_id":"","url":"https://api.github.com/users/YourGamesBeOver","html_url":"https://github.com/YourGamesBeOver","followers_url":"https://api.github.com/users/YourGamesBeOver/followers","following_url":"https://api.github.com/users/YourGamesBeOver/following{/other_user}","gists_url":"https://api.github.com/users/YourGamesBeOver/gists{/gist_id}","starred_url":"https://api.github.com/users/YourGamesBeOver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YourGamesBeOver/subscriptions","organizations_url":"https://api.github.com/users/YourGamesBeOver/orgs","repos_url":"https://api.github.com/users/YourGamesBeOver/repos","events_url":"https://api.github.com/users/YourGamesBeOver/events{/privacy}","received_events_url":"https://api.github.com/users/YourGamesBeOver/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T19:43:38Z","updated_at":"2018-02-26T19:43:38Z","author_association":"NONE","body":"@andy-ms Merge conflicts resolved"}}
{"actor":{"display_login":"YourGamesBeOver"}}