{"action":"created","issue":{"url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5238","repository_url":"https://api.github.com/repos/protocolbuffers/protobuf","labels_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5238/labels{/name}","comments_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5238/comments","events_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5238/events","html_url":"https://github.com/protocolbuffers/protobuf/pull/5238","id":367964249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjUxOTYx","number":5238,"title":"Fix the compiling error for xcode 10","user":{"login":"JerryShih","id":5842681,"node_id":"MDQ6VXNlcjU4NDI2ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/5842681?v=4","gravatar_id":"","url":"https://api.github.com/users/JerryShih","html_url":"https://github.com/JerryShih","followers_url":"https://api.github.com/users/JerryShih/followers","following_url":"https://api.github.com/users/JerryShih/following{/other_user}","gists_url":"https://api.github.com/users/JerryShih/gists{/gist_id}","starred_url":"https://api.github.com/users/JerryShih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerryShih/subscriptions","organizations_url":"https://api.github.com/users/JerryShih/orgs","repos_url":"https://api.github.com/users/JerryShih/repos","events_url":"https://api.github.com/users/JerryShih/events{/privacy}","received_events_url":"https://api.github.com/users/JerryShih/received_events","type":"User","site_admin":false},"labels":[{"id":151794609,"node_id":"MDU6TGFiZWwxNTE3OTQ2MDk=","url":"https://api.github.com/repos/protocolbuffers/protobuf/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"TeBoring","id":5195749,"node_id":"MDQ6VXNlcjUxOTU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5195749?v=4","gravatar_id":"","url":"https://api.github.com/users/TeBoring","html_url":"https://github.com/TeBoring","followers_url":"https://api.github.com/users/TeBoring/followers","following_url":"https://api.github.com/users/TeBoring/following{/other_user}","gists_url":"https://api.github.com/users/TeBoring/gists{/gist_id}","starred_url":"https://api.github.com/users/TeBoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeBoring/subscriptions","organizations_url":"https://api.github.com/users/TeBoring/orgs","repos_url":"https://api.github.com/users/TeBoring/repos","events_url":"https://api.github.com/users/TeBoring/events{/privacy}","received_events_url":"https://api.github.com/users/TeBoring/received_events","type":"User","site_admin":false},"assignees":[{"login":"TeBoring","id":5195749,"node_id":"MDQ6VXNlcjUxOTU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5195749?v=4","gravatar_id":"","url":"https://api.github.com/users/TeBoring","html_url":"https://github.com/TeBoring","followers_url":"https://api.github.com/users/TeBoring/followers","following_url":"https://api.github.com/users/TeBoring/following{/other_user}","gists_url":"https://api.github.com/users/TeBoring/gists{/gist_id}","starred_url":"https://api.github.com/users/TeBoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeBoring/subscriptions","organizations_url":"https://api.github.com/users/TeBoring/orgs","repos_url":"https://api.github.com/users/TeBoring/repos","events_url":"https://api.github.com/users/TeBoring/events{/privacy}","received_events_url":"https://api.github.com/users/TeBoring/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-10-08T21:46:41Z","updated_at":"2018-10-25T05:01:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/protocolbuffers/protobuf/pulls/5238","html_url":"https://github.com/protocolbuffers/protobuf/pull/5238","diff_url":"https://github.com/protocolbuffers/protobuf/pull/5238.diff","patch_url":"https://github.com/protocolbuffers/protobuf/pull/5238.patch"},"body":"The xcode 10 removes the deprecated libstdc++ library. Now, we should\r\nuse libc++ instead.\r\n\r\nHere is the error message when I try to build the protobuf with cpp implementation.\r\n> warning: include path for stdlibc++ headers not found; pass '-std=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]\r\n> In file included from google/protobuf/pyext/extension_dict.cc:34:\r\n> ./google/protobuf/pyext/extension_dict.h:39:10: fatal error: 'memory' file not found\r\n> #include <memory>"},"comment":{"url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/comments/432915355","html_url":"https://github.com/protocolbuffers/protobuf/pull/5238#issuecomment-432915355","issue_url":"https://api.github.com/repos/protocolbuffers/protobuf/issues/5238","id":432915355,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjkxNTM1NQ==","user":{"login":"TeBoring","id":5195749,"node_id":"MDQ6VXNlcjUxOTU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5195749?v=4","gravatar_id":"","url":"https://api.github.com/users/TeBoring","html_url":"https://github.com/TeBoring","followers_url":"https://api.github.com/users/TeBoring/followers","following_url":"https://api.github.com/users/TeBoring/following{/other_user}","gists_url":"https://api.github.com/users/TeBoring/gists{/gist_id}","starred_url":"https://api.github.com/users/TeBoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeBoring/subscriptions","organizations_url":"https://api.github.com/users/TeBoring/orgs","repos_url":"https://api.github.com/users/TeBoring/repos","events_url":"https://api.github.com/users/TeBoring/events{/privacy}","received_events_url":"https://api.github.com/users/TeBoring/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T05:01:16Z","updated_at":"2018-10-25T05:01:16Z","author_association":"CONTRIBUTOR","body":"Yes\nOn Wed, Oct 24, 2018 at 21:52 Jerry <notifications@github.com> wrote:\n\n> @TeBoring <https://github.com/TeBoring>\n> So, what should I do for the next step?\n> We could replace the libstdc++ with libc++. The xcode 4.3 has libc++.\n> Do you mean I could add \"os.environ['MACOSX_DEPLOYMENT_TARGET'] = '10.9'\"\n> to setup.py?\n>\n> —\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/protocolbuffers/protobuf/pull/5238#issuecomment-432914023>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AE9H5ePXyLVC6D9YJShuCZoaSB9DKqCCks5uoUOfgaJpZM4XNurE>\n> .\n>\n"}}
{"actor":{"display_login":"TeBoring"}}