{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/10427","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/10427/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/10427/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/10427/events","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/10427","id":378633540,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjkwMDkz","number":10427,"title":"Feature/10323 verticals wizard","user":{"login":"ctarda","id":2722505,"node_id":"MDQ6VXNlcjI3MjI1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2722505?v=4","gravatar_id":"","url":"https://api.github.com/users/ctarda","html_url":"https://github.com/ctarda","followers_url":"https://api.github.com/users/ctarda/followers","following_url":"https://api.github.com/users/ctarda/following{/other_user}","gists_url":"https://api.github.com/users/ctarda/gists{/gist_id}","starred_url":"https://api.github.com/users/ctarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctarda/subscriptions","organizations_url":"https://api.github.com/users/ctarda/orgs","repos_url":"https://api.github.com/users/ctarda/repos","events_url":"https://api.github.com/users/ctarda/events{/privacy}","received_events_url":"https://api.github.com/users/ctarda/received_events","type":"User","site_admin":false},"labels":[{"id":1102440334,"node_id":"MDU6TGFiZWwxMTAyNDQwMzM0","url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/Site%20Creation","name":"Site Creation","color":"1eff83","default":false},{"id":216949618,"node_id":"MDU6TGFiZWwyMTY5NDk2MTg=","url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/[Status]%20DO%20NOT%20MERGE","name":"[Status] DO NOT MERGE","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"ctarda","id":2722505,"node_id":"MDQ6VXNlcjI3MjI1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2722505?v=4","gravatar_id":"","url":"https://api.github.com/users/ctarda","html_url":"https://github.com/ctarda","followers_url":"https://api.github.com/users/ctarda/followers","following_url":"https://api.github.com/users/ctarda/following{/other_user}","gists_url":"https://api.github.com/users/ctarda/gists{/gist_id}","starred_url":"https://api.github.com/users/ctarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctarda/subscriptions","organizations_url":"https://api.github.com/users/ctarda/orgs","repos_url":"https://api.github.com/users/ctarda/repos","events_url":"https://api.github.com/users/ctarda/events{/privacy}","received_events_url":"https://api.github.com/users/ctarda/received_events","type":"User","site_admin":false},"assignees":[{"login":"ctarda","id":2722505,"node_id":"MDQ6VXNlcjI3MjI1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2722505?v=4","gravatar_id":"","url":"https://api.github.com/users/ctarda","html_url":"https://github.com/ctarda","followers_url":"https://api.github.com/users/ctarda/followers","following_url":"https://api.github.com/users/ctarda/following{/other_user}","gists_url":"https://api.github.com/users/ctarda/gists{/gist_id}","starred_url":"https://api.github.com/users/ctarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctarda/subscriptions","organizations_url":"https://api.github.com/users/ctarda/orgs","repos_url":"https://api.github.com/users/ctarda/repos","events_url":"https://api.github.com/users/ctarda/events{/privacy}","received_events_url":"https://api.github.com/users/ctarda/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/117","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestone/117","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/117/labels","id":3687733,"node_id":"MDk6TWlsZXN0b25lMzY4NzczMw==","number":117,"title":"11.3","description":"Code freeze: Nov 19th, 2018 App Store submission: Nov 30th, 2018 Release: Dec 3rd, 2018","creator":{"login":"loremattei","id":4836764,"node_id":"MDQ6VXNlcjQ4MzY3NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4836764?v=4","gravatar_id":"","url":"https://api.github.com/users/loremattei","html_url":"https://github.com/loremattei","followers_url":"https://api.github.com/users/loremattei/followers","following_url":"https://api.github.com/users/loremattei/following{/other_user}","gists_url":"https://api.github.com/users/loremattei/gists{/gist_id}","starred_url":"https://api.github.com/users/loremattei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loremattei/subscriptions","organizations_url":"https://api.github.com/users/loremattei/orgs","repos_url":"https://api.github.com/users/loremattei/repos","events_url":"https://api.github.com/users/loremattei/events{/privacy}","received_events_url":"https://api.github.com/users/loremattei/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":21,"state":"open","created_at":"2018-09-25T16:00:50Z","updated_at":"2018-11-09T02:00:19Z","due_on":"2018-11-19T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-11-08T08:54:29Z","updated_at":"2018-11-09T02:58:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/10427","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/10427","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/10427.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/10427.patch"},"body":"Implements #10323 in part.\r\n\r\nThe UI is far from acceptable, but in the interest of solving the UI flow as soon as posible, I am opening this PR for discussion now.\r\n\r\nIn this PR:\r\n- Vertical step\r\n- A VC to render the content of this step\r\n- Scaffolding for navigation. It is possible to trigger navigation from one WizardStep, to another WizardStep, by passing its delegate the identifier of the destination step\r\n- Some abstractions are starting to popup. For example, a generic datasource that we can use to render both the tableview in the Segments and Verticals steps.\r\n- Add properties to the SiteCreator accordingly.\r\n\r\nMy main takeaway from this PR is that the SegmentsStep and VerticalsStep are not that different. And they are not that different from the AddressStep. I think we should be able to solve the three of them by a combination of generics and extracting the behaviour that is actually different, which is not that much. So I expect changes in the next couple of PRs, particularly with the implementation of the AddressStep, which is what I am going to attack now.\r\n\r\nTo test:\r\n- Run the tests\r\n- Navigate to My Sites > tap + to add a site > Enhanced site creation\r\n- Select any Segment, it should navigate to the Vertical screen. \r\n- Type anything in the textfield, the table view should be populated with mock data\r\n"},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments/437233663","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/10427#issuecomment-437233663","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/10427","id":437233663,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzIzMzY2Mw==","user":{"login":"ctarda","id":2722505,"node_id":"MDQ6VXNlcjI3MjI1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2722505?v=4","gravatar_id":"","url":"https://api.github.com/users/ctarda","html_url":"https://github.com/ctarda","followers_url":"https://api.github.com/users/ctarda/followers","following_url":"https://api.github.com/users/ctarda/following{/other_user}","gists_url":"https://api.github.com/users/ctarda/gists{/gist_id}","starred_url":"https://api.github.com/users/ctarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctarda/subscriptions","organizations_url":"https://api.github.com/users/ctarda/orgs","repos_url":"https://api.github.com/users/ctarda/repos","events_url":"https://api.github.com/users/ctarda/events{/privacy}","received_events_url":"https://api.github.com/users/ctarda/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T02:58:39Z","updated_at":"2018-11-09T02:58:39Z","author_association":"CONTRIBUTOR","body":"Thanks @stevebaranski I've moved those files to their right location, I'll merge as soon as the build passes"}}
{"actor":{"display_login":"ctarda"}}