{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/katzenpost/minclient/pulls/12","id":215772357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzcyMzU3","html_url":"https://github.com/katzenpost/minclient/pull/12","diff_url":"https://github.com/katzenpost/minclient/pull/12.diff","patch_url":"https://github.com/katzenpost/minclient/pull/12.patch","issue_url":"https://api.github.com/repos/katzenpost/minclient/issues/12","number":12,"state":"closed","locked":false,"title":"Fix races between pki and connection","user":{"login":"david415","id":50611,"node_id":"MDQ6VXNlcjUwNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/50611?v=4","gravatar_id":"","url":"https://api.github.com/users/david415","html_url":"https://github.com/david415","followers_url":"https://api.github.com/users/david415/followers","following_url":"https://api.github.com/users/david415/following{/other_user}","gists_url":"https://api.github.com/users/david415/gists{/gist_id}","starred_url":"https://api.github.com/users/david415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david415/subscriptions","organizations_url":"https://api.github.com/users/david415/orgs","repos_url":"https://api.github.com/users/david415/repos","events_url":"https://api.github.com/users/david415/events{/privacy}","received_events_url":"https://api.github.com/users/david415/received_events","type":"User","site_admin":false},"body":"I don't actually have a unit test that proves this change fixes the problem... however when building my ``noop`` client with the race detector it detects races without this patch to minclient.","created_at":"2018-09-15T14:41:00Z","updated_at":"2018-09-15T14:44:21Z","closed_at":"2018-09-15T14:44:21Z","merged_at":"2018-09-15T14:44:21Z","merge_commit_sha":"12a18ca7b928a7391f04ee40488dbf007f527b0f","assignee":{"login":"david415","id":50611,"node_id":"MDQ6VXNlcjUwNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/50611?v=4","gravatar_id":"","url":"https://api.github.com/users/david415","html_url":"https://github.com/david415","followers_url":"https://api.github.com/users/david415/followers","following_url":"https://api.github.com/users/david415/following{/other_user}","gists_url":"https://api.github.com/users/david415/gists{/gist_id}","starred_url":"https://api.github.com/users/david415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david415/subscriptions","organizations_url":"https://api.github.com/users/david415/orgs","repos_url":"https://api.github.com/users/david415/repos","events_url":"https://api.github.com/users/david415/events{/privacy}","received_events_url":"https://api.github.com/users/david415/received_events","type":"User","site_admin":false},"assignees":[{"login":"david415","id":50611,"node_id":"MDQ6VXNlcjUwNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/50611?v=4","gravatar_id":"","url":"https://api.github.com/users/david415","html_url":"https://github.com/david415","followers_url":"https://api.github.com/users/david415/followers","following_url":"https://api.github.com/users/david415/following{/other_user}","gists_url":"https://api.github.com/users/david415/gists{/gist_id}","starred_url":"https://api.github.com/users/david415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david415/subscriptions","organizations_url":"https://api.github.com/users/david415/orgs","repos_url":"https://api.github.com/users/david415/repos","events_url":"https://api.github.com/users/david415/events{/privacy}","received_events_url":"https://api.github.com/users/david415/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nogoegst","id":19829265,"node_id":"MDQ6VXNlcjE5ODI5MjY1","avatar_url":"https://avatars3.githubusercontent.com/u/19829265?v=4","gravatar_id":"","url":"https://api.github.com/users/nogoegst","html_url":"https://github.com/nogoegst","followers_url":"https://api.github.com/users/nogoegst/followers","following_url":"https://api.github.com/users/nogoegst/following{/other_user}","gists_url":"https://api.github.com/users/nogoegst/gists{/gist_id}","starred_url":"https://api.github.com/users/nogoegst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nogoegst/subscriptions","organizations_url":"https://api.github.com/users/nogoegst/orgs","repos_url":"https://api.github.com/users/nogoegst/repos","events_url":"https://api.github.com/users/nogoegst/events{/privacy}","received_events_url":"https://api.github.com/users/nogoegst/received_events","type":"User","site_admin":false},{"login":"mixmasala","id":33068337,"node_id":"MDQ6VXNlcjMzMDY4MzM3","avatar_url":"https://avatars1.githubusercontent.com/u/33068337?v=4","gravatar_id":"","url":"https://api.github.com/users/mixmasala","html_url":"https://github.com/mixmasala","followers_url":"https://api.github.com/users/mixmasala/followers","following_url":"https://api.github.com/users/mixmasala/following{/other_user}","gists_url":"https://api.github.com/users/mixmasala/gists{/gist_id}","starred_url":"https://api.github.com/users/mixmasala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixmasala/subscriptions","organizations_url":"https://api.github.com/users/mixmasala/orgs","repos_url":"https://api.github.com/users/mixmasala/repos","events_url":"https://api.github.com/users/mixmasala/events{/privacy}","received_events_url":"https://api.github.com/users/mixmasala/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764505289,"node_id":"MDU6TGFiZWw3NjQ1MDUyODk=","url":"https://api.github.com/repos/katzenpost/minclient/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/katzenpost/minclient/pulls/12/commits","review_comments_url":"https://api.github.com/repos/katzenpost/minclient/pulls/12/comments","review_comment_url":"https://api.github.com/repos/katzenpost/minclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/katzenpost/minclient/issues/12/comments","statuses_url":"https://api.github.com/repos/katzenpost/minclient/statuses/12a18ca7b928a7391f04ee40488dbf007f527b0f","head":{"label":"katzenpost:fix_races.0","ref":"fix_races.0","sha":"12a18ca7b928a7391f04ee40488dbf007f527b0f","user":{"login":"katzenpost","id":29903442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTAzNDQy","avatar_url":"https://avatars2.githubusercontent.com/u/29903442?v=4","gravatar_id":"","url":"https://api.github.com/users/katzenpost","html_url":"https://github.com/katzenpost","followers_url":"https://api.github.com/users/katzenpost/followers","following_url":"https://api.github.com/users/katzenpost/following{/other_user}","gists_url":"https://api.github.com/users/katzenpost/gists{/gist_id}","starred_url":"https://api.github.com/users/katzenpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katzenpost/subscriptions","organizations_url":"https://api.github.com/users/katzenpost/orgs","repos_url":"https://api.github.com/users/katzenpost/repos","events_url":"https://api.github.com/users/katzenpost/events{/privacy}","received_events_url":"https://api.github.com/users/katzenpost/received_events","type":"Organization","site_admin":false},"repo":{"id":112481800,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI0ODE4MDA=","name":"minclient","full_name":"katzenpost/minclient","owner":{"login":"katzenpost","id":29903442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTAzNDQy","avatar_url":"https://avatars2.githubusercontent.com/u/29903442?v=4","gravatar_id":"","url":"https://api.github.com/users/katzenpost","html_url":"https://github.com/katzenpost","followers_url":"https://api.github.com/users/katzenpost/followers","following_url":"https://api.github.com/users/katzenpost/following{/other_user}","gists_url":"https://api.github.com/users/katzenpost/gists{/gist_id}","starred_url":"https://api.github.com/users/katzenpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katzenpost/subscriptions","organizations_url":"https://api.github.com/users/katzenpost/orgs","repos_url":"https://api.github.com/users/katzenpost/repos","events_url":"https://api.github.com/users/katzenpost/events{/privacy}","received_events_url":"https://api.github.com/users/katzenpost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/katzenpost/minclient","description":"Minimalistic Katzenpost reference client.","fork":false,"url":"https://api.github.com/repos/katzenpost/minclient","forks_url":"https://api.github.com/repos/katzenpost/minclient/forks","keys_url":"https://api.github.com/repos/katzenpost/minclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/katzenpost/minclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/katzenpost/minclient/teams","hooks_url":"https://api.github.com/repos/katzenpost/minclient/hooks","issue_events_url":"https://api.github.com/repos/katzenpost/minclient/issues/events{/number}","events_url":"https://api.github.com/repos/katzenpost/minclient/events","assignees_url":"https://api.github.com/repos/katzenpost/minclient/assignees{/user}","branches_url":"https://api.github.com/repos/katzenpost/minclient/branches{/branch}","tags_url":"https://api.github.com/repos/katzenpost/minclient/tags","blobs_url":"https://api.github.com/repos/katzenpost/minclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/katzenpost/minclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/katzenpost/minclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/katzenpost/minclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/katzenpost/minclient/statuses/{sha}","languages_url":"https://api.github.com/repos/katzenpost/minclient/languages","stargazers_url":"https://api.github.com/repos/katzenpost/minclient/stargazers","contributors_url":"https://api.github.com/repos/katzenpost/minclient/contributors","subscribers_url":"https://api.github.com/repos/katzenpost/minclient/subscribers","subscription_url":"https://api.github.com/repos/katzenpost/minclient/subscription","commits_url":"https://api.github.com/repos/katzenpost/minclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/katzenpost/minclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/katzenpost/minclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/katzenpost/minclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/katzenpost/minclient/contents/{+path}","compare_url":"https://api.github.com/repos/katzenpost/minclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/katzenpost/minclient/merges","archive_url":"https://api.github.com/repos/katzenpost/minclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/katzenpost/minclient/downloads","issues_url":"https://api.github.com/repos/katzenpost/minclient/issues{/number}","pulls_url":"https://api.github.com/repos/katzenpost/minclient/pulls{/number}","milestones_url":"https://api.github.com/repos/katzenpost/minclient/milestones{/number}","notifications_url":"https://api.github.com/repos/katzenpost/minclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/katzenpost/minclient/labels{/name}","releases_url":"https://api.github.com/repos/katzenpost/minclient/releases{/id}","deployments_url":"https://api.github.com/repos/katzenpost/minclient/deployments","created_at":"2017-11-29T13:56:50Z","updated_at":"2018-09-08T06:00:37Z","pushed_at":"2018-09-15T14:44:21Z","git_url":"git://github.com/katzenpost/minclient.git","ssh_url":"git@github.com:katzenpost/minclient.git","clone_url":"https://github.com/katzenpost/minclient.git","svn_url":"https://github.com/katzenpost/minclient","homepage":"","size":73,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"katzenpost:master","ref":"master","sha":"07d274c662ae1ce2005cbd8fdf990614be88f1ee","user":{"login":"katzenpost","id":29903442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTAzNDQy","avatar_url":"https://avatars2.githubusercontent.com/u/29903442?v=4","gravatar_id":"","url":"https://api.github.com/users/katzenpost","html_url":"https://github.com/katzenpost","followers_url":"https://api.github.com/users/katzenpost/followers","following_url":"https://api.github.com/users/katzenpost/following{/other_user}","gists_url":"https://api.github.com/users/katzenpost/gists{/gist_id}","starred_url":"https://api.github.com/users/katzenpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katzenpost/subscriptions","organizations_url":"https://api.github.com/users/katzenpost/orgs","repos_url":"https://api.github.com/users/katzenpost/repos","events_url":"https://api.github.com/users/katzenpost/events{/privacy}","received_events_url":"https://api.github.com/users/katzenpost/received_events","type":"Organization","site_admin":false},"repo":{"id":112481800,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI0ODE4MDA=","name":"minclient","full_name":"katzenpost/minclient","owner":{"login":"katzenpost","id":29903442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTAzNDQy","avatar_url":"https://avatars2.githubusercontent.com/u/29903442?v=4","gravatar_id":"","url":"https://api.github.com/users/katzenpost","html_url":"https://github.com/katzenpost","followers_url":"https://api.github.com/users/katzenpost/followers","following_url":"https://api.github.com/users/katzenpost/following{/other_user}","gists_url":"https://api.github.com/users/katzenpost/gists{/gist_id}","starred_url":"https://api.github.com/users/katzenpost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katzenpost/subscriptions","organizations_url":"https://api.github.com/users/katzenpost/orgs","repos_url":"https://api.github.com/users/katzenpost/repos","events_url":"https://api.github.com/users/katzenpost/events{/privacy}","received_events_url":"https://api.github.com/users/katzenpost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/katzenpost/minclient","description":"Minimalistic Katzenpost reference client.","fork":false,"url":"https://api.github.com/repos/katzenpost/minclient","forks_url":"https://api.github.com/repos/katzenpost/minclient/forks","keys_url":"https://api.github.com/repos/katzenpost/minclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/katzenpost/minclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/katzenpost/minclient/teams","hooks_url":"https://api.github.com/repos/katzenpost/minclient/hooks","issue_events_url":"https://api.github.com/repos/katzenpost/minclient/issues/events{/number}","events_url":"https://api.github.com/repos/katzenpost/minclient/events","assignees_url":"https://api.github.com/repos/katzenpost/minclient/assignees{/user}","branches_url":"https://api.github.com/repos/katzenpost/minclient/branches{/branch}","tags_url":"https://api.github.com/repos/katzenpost/minclient/tags","blobs_url":"https://api.github.com/repos/katzenpost/minclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/katzenpost/minclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/katzenpost/minclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/katzenpost/minclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/katzenpost/minclient/statuses/{sha}","languages_url":"https://api.github.com/repos/katzenpost/minclient/languages","stargazers_url":"https://api.github.com/repos/katzenpost/minclient/stargazers","contributors_url":"https://api.github.com/repos/katzenpost/minclient/contributors","subscribers_url":"https://api.github.com/repos/katzenpost/minclient/subscribers","subscription_url":"https://api.github.com/repos/katzenpost/minclient/subscription","commits_url":"https://api.github.com/repos/katzenpost/minclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/katzenpost/minclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/katzenpost/minclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/katzenpost/minclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/katzenpost/minclient/contents/{+path}","compare_url":"https://api.github.com/repos/katzenpost/minclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/katzenpost/minclient/merges","archive_url":"https://api.github.com/repos/katzenpost/minclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/katzenpost/minclient/downloads","issues_url":"https://api.github.com/repos/katzenpost/minclient/issues{/number}","pulls_url":"https://api.github.com/repos/katzenpost/minclient/pulls{/number}","milestones_url":"https://api.github.com/repos/katzenpost/minclient/milestones{/number}","notifications_url":"https://api.github.com/repos/katzenpost/minclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/katzenpost/minclient/labels{/name}","releases_url":"https://api.github.com/repos/katzenpost/minclient/releases{/id}","deployments_url":"https://api.github.com/repos/katzenpost/minclient/deployments","created_at":"2017-11-29T13:56:50Z","updated_at":"2018-09-08T06:00:37Z","pushed_at":"2018-09-15T14:44:21Z","git_url":"git://github.com/katzenpost/minclient.git","ssh_url":"git@github.com:katzenpost/minclient.git","clone_url":"https://github.com/katzenpost/minclient.git","svn_url":"https://github.com/katzenpost/minclient","homepage":"","size":73,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/katzenpost/minclient/pulls/12"},"html":{"href":"https://github.com/katzenpost/minclient/pull/12"},"issue":{"href":"https://api.github.com/repos/katzenpost/minclient/issues/12"},"comments":{"href":"https://api.github.com/repos/katzenpost/minclient/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/katzenpost/minclient/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/katzenpost/minclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/katzenpost/minclient/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/katzenpost/minclient/statuses/12a18ca7b928a7391f04ee40488dbf007f527b0f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"david415","id":50611,"node_id":"MDQ6VXNlcjUwNjEx","avatar_url":"https://avatars2.githubusercontent.com/u/50611?v=4","gravatar_id":"","url":"https://api.github.com/users/david415","html_url":"https://github.com/david415","followers_url":"https://api.github.com/users/david415/followers","following_url":"https://api.github.com/users/david415/following{/other_user}","gists_url":"https://api.github.com/users/david415/gists{/gist_id}","starred_url":"https://api.github.com/users/david415/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david415/subscriptions","organizations_url":"https://api.github.com/users/david415/orgs","repos_url":"https://api.github.com/users/david415/repos","events_url":"https://api.github.com/users/david415/events{/privacy}","received_events_url":"https://api.github.com/users/david415/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"david415"}}