{"action":"created","comment":{"url":"https://api.github.com/repos/primitiv/primitiv-python/pulls/comments/203584391","pull_request_review_id":138501627,"id":203584391,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzU4NDM5MQ==","diff_hunk":"@@ -17,6 +17,10 @@ class functions:\n \n     @staticmethod\n     def raw_input(shape, vector[float] data, Device device = None, Graph graph = None):\n+        if device is None:","path":"primitiv/_function.pyx","position":4,"original_position":4,"commit_id":"043a3fdd2760c2b8504459ee7d6adbd0a237a64d","original_commit_id":"043a3fdd2760c2b8504459ee7d6adbd0a237a64d","user":{"login":"odashi","id":1023695,"node_id":"MDQ6VXNlcjEwMjM2OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1023695?v=4","gravatar_id":"","url":"https://api.github.com/users/odashi","html_url":"https://github.com/odashi","followers_url":"https://api.github.com/users/odashi/followers","following_url":"https://api.github.com/users/odashi/following{/other_user}","gists_url":"https://api.github.com/users/odashi/gists{/gist_id}","starred_url":"https://api.github.com/users/odashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odashi/subscriptions","organizations_url":"https://api.github.com/users/odashi/orgs","repos_url":"https://api.github.com/users/odashi/repos","events_url":"https://api.github.com/users/odashi/events{/privacy}","received_events_url":"https://api.github.com/users/odashi/received_events","type":"User","site_admin":false},"body":"`get_cpp_something` may return NULL and NULL is acceptable by C++ APIs (if they received NULLs, it is replaced to the C++-side default objects). This may confuse the overall behavior.\r\nIt is good to add some Python-side functions `get_default_or_die`, or adding an option to `get_default` to raise an exception if the Python-side default object is null.","created_at":"2018-07-19T02:14:07Z","updated_at":"2018-07-19T02:16:40Z","html_url":"https://github.com/primitiv/primitiv-python/pull/41#discussion_r203584391","pull_request_url":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/primitiv/primitiv-python/pulls/comments/203584391"},"html":{"href":"https://github.com/primitiv/primitiv-python/pull/41#discussion_r203584391"},"pull_request":{"href":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41","id":202401537,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDAxNTM3","html_url":"https://github.com/primitiv/primitiv-python/pull/41","diff_url":"https://github.com/primitiv/primitiv-python/pull/41.diff","patch_url":"https://github.com/primitiv/primitiv-python/pull/41.patch","issue_url":"https://api.github.com/repos/primitiv/primitiv-python/issues/41","number":41,"state":"open","locked":false,"title":"Store default objects in python","user":{"login":"vbkaisetsu","id":2175479,"node_id":"MDQ6VXNlcjIxNzU0Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2175479?v=4","gravatar_id":"","url":"https://api.github.com/users/vbkaisetsu","html_url":"https://github.com/vbkaisetsu","followers_url":"https://api.github.com/users/vbkaisetsu/followers","following_url":"https://api.github.com/users/vbkaisetsu/following{/other_user}","gists_url":"https://api.github.com/users/vbkaisetsu/gists{/gist_id}","starred_url":"https://api.github.com/users/vbkaisetsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbkaisetsu/subscriptions","organizations_url":"https://api.github.com/users/vbkaisetsu/orgs","repos_url":"https://api.github.com/users/vbkaisetsu/repos","events_url":"https://api.github.com/users/vbkaisetsu/events{/privacy}","received_events_url":"https://api.github.com/users/vbkaisetsu/received_events","type":"User","site_admin":false},"body":"Related to #39 \r\nThis branch holds default objects in the python module instead of using set/get_default() of the core library.\r\n\r\nI checked that it works fine on Windows 10.","created_at":"2018-07-18T22:51:23Z","updated_at":"2018-07-19T02:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9215d4540dee6966c2ab003e23d90014a08fd77","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":764947666,"node_id":"MDU6TGFiZWw3NjQ5NDc2NjY=","url":"https://api.github.com/repos/primitiv/primitiv-python/labels/bug:%20major","name":"bug: major","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41/commits","review_comments_url":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41/comments","review_comment_url":"https://api.github.com/repos/primitiv/primitiv-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/primitiv/primitiv-python/issues/41/comments","statuses_url":"https://api.github.com/repos/primitiv/primitiv-python/statuses/043a3fdd2760c2b8504459ee7d6adbd0a237a64d","head":{"label":"primitiv:feature/store-default-object","ref":"feature/store-default-object","sha":"043a3fdd2760c2b8504459ee7d6adbd0a237a64d","user":{"login":"primitiv","id":33832148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODMyMTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/33832148?v=4","gravatar_id":"","url":"https://api.github.com/users/primitiv","html_url":"https://github.com/primitiv","followers_url":"https://api.github.com/users/primitiv/followers","following_url":"https://api.github.com/users/primitiv/following{/other_user}","gists_url":"https://api.github.com/users/primitiv/gists{/gist_id}","starred_url":"https://api.github.com/users/primitiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primitiv/subscriptions","organizations_url":"https://api.github.com/users/primitiv/orgs","repos_url":"https://api.github.com/users/primitiv/repos","events_url":"https://api.github.com/users/primitiv/events{/privacy}","received_events_url":"https://api.github.com/users/primitiv/received_events","type":"Organization","site_admin":false},"repo":{"id":112536568,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1MzY1Njg=","name":"primitiv-python","full_name":"primitiv/primitiv-python","owner":{"login":"primitiv","id":33832148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODMyMTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/33832148?v=4","gravatar_id":"","url":"https://api.github.com/users/primitiv","html_url":"https://github.com/primitiv","followers_url":"https://api.github.com/users/primitiv/followers","following_url":"https://api.github.com/users/primitiv/following{/other_user}","gists_url":"https://api.github.com/users/primitiv/gists{/gist_id}","starred_url":"https://api.github.com/users/primitiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primitiv/subscriptions","organizations_url":"https://api.github.com/users/primitiv/orgs","repos_url":"https://api.github.com/users/primitiv/repos","events_url":"https://api.github.com/users/primitiv/events{/privacy}","received_events_url":"https://api.github.com/users/primitiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/primitiv/primitiv-python","description":"Python binding of primitiv.","fork":false,"url":"https://api.github.com/repos/primitiv/primitiv-python","forks_url":"https://api.github.com/repos/primitiv/primitiv-python/forks","keys_url":"https://api.github.com/repos/primitiv/primitiv-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/primitiv/primitiv-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/primitiv/primitiv-python/teams","hooks_url":"https://api.github.com/repos/primitiv/primitiv-python/hooks","issue_events_url":"https://api.github.com/repos/primitiv/primitiv-python/issues/events{/number}","events_url":"https://api.github.com/repos/primitiv/primitiv-python/events","assignees_url":"https://api.github.com/repos/primitiv/primitiv-python/assignees{/user}","branches_url":"https://api.github.com/repos/primitiv/primitiv-python/branches{/branch}","tags_url":"https://api.github.com/repos/primitiv/primitiv-python/tags","blobs_url":"https://api.github.com/repos/primitiv/primitiv-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/primitiv/primitiv-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/primitiv/primitiv-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/primitiv/primitiv-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/primitiv/primitiv-python/statuses/{sha}","languages_url":"https://api.github.com/repos/primitiv/primitiv-python/languages","stargazers_url":"https://api.github.com/repos/primitiv/primitiv-python/stargazers","contributors_url":"https://api.github.com/repos/primitiv/primitiv-python/contributors","subscribers_url":"https://api.github.com/repos/primitiv/primitiv-python/subscribers","subscription_url":"https://api.github.com/repos/primitiv/primitiv-python/subscription","commits_url":"https://api.github.com/repos/primitiv/primitiv-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/primitiv/primitiv-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/primitiv/primitiv-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/primitiv/primitiv-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/primitiv/primitiv-python/contents/{+path}","compare_url":"https://api.github.com/repos/primitiv/primitiv-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/primitiv/primitiv-python/merges","archive_url":"https://api.github.com/repos/primitiv/primitiv-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/primitiv/primitiv-python/downloads","issues_url":"https://api.github.com/repos/primitiv/primitiv-python/issues{/number}","pulls_url":"https://api.github.com/repos/primitiv/primitiv-python/pulls{/number}","milestones_url":"https://api.github.com/repos/primitiv/primitiv-python/milestones{/number}","notifications_url":"https://api.github.com/repos/primitiv/primitiv-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/primitiv/primitiv-python/labels{/name}","releases_url":"https://api.github.com/repos/primitiv/primitiv-python/releases{/id}","deployments_url":"https://api.github.com/repos/primitiv/primitiv-python/deployments","created_at":"2017-11-29T22:47:06Z","updated_at":"2018-07-06T09:57:28Z","pushed_at":"2018-07-18T22:51:24Z","git_url":"git://github.com/primitiv/primitiv-python.git","ssh_url":"git@github.com:primitiv/primitiv-python.git","clone_url":"https://github.com/primitiv/primitiv-python.git","svn_url":"https://github.com/primitiv/primitiv-python","homepage":null,"size":525,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":6,"watchers":16,"default_branch":"develop"}},"base":{"label":"primitiv:develop","ref":"develop","sha":"04de17a41bab55f660e009bae96dd773efba3b22","user":{"login":"primitiv","id":33832148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODMyMTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/33832148?v=4","gravatar_id":"","url":"https://api.github.com/users/primitiv","html_url":"https://github.com/primitiv","followers_url":"https://api.github.com/users/primitiv/followers","following_url":"https://api.github.com/users/primitiv/following{/other_user}","gists_url":"https://api.github.com/users/primitiv/gists{/gist_id}","starred_url":"https://api.github.com/users/primitiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primitiv/subscriptions","organizations_url":"https://api.github.com/users/primitiv/orgs","repos_url":"https://api.github.com/users/primitiv/repos","events_url":"https://api.github.com/users/primitiv/events{/privacy}","received_events_url":"https://api.github.com/users/primitiv/received_events","type":"Organization","site_admin":false},"repo":{"id":112536568,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI1MzY1Njg=","name":"primitiv-python","full_name":"primitiv/primitiv-python","owner":{"login":"primitiv","id":33832148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODMyMTQ4","avatar_url":"https://avatars2.githubusercontent.com/u/33832148?v=4","gravatar_id":"","url":"https://api.github.com/users/primitiv","html_url":"https://github.com/primitiv","followers_url":"https://api.github.com/users/primitiv/followers","following_url":"https://api.github.com/users/primitiv/following{/other_user}","gists_url":"https://api.github.com/users/primitiv/gists{/gist_id}","starred_url":"https://api.github.com/users/primitiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/primitiv/subscriptions","organizations_url":"https://api.github.com/users/primitiv/orgs","repos_url":"https://api.github.com/users/primitiv/repos","events_url":"https://api.github.com/users/primitiv/events{/privacy}","received_events_url":"https://api.github.com/users/primitiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/primitiv/primitiv-python","description":"Python binding of primitiv.","fork":false,"url":"https://api.github.com/repos/primitiv/primitiv-python","forks_url":"https://api.github.com/repos/primitiv/primitiv-python/forks","keys_url":"https://api.github.com/repos/primitiv/primitiv-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/primitiv/primitiv-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/primitiv/primitiv-python/teams","hooks_url":"https://api.github.com/repos/primitiv/primitiv-python/hooks","issue_events_url":"https://api.github.com/repos/primitiv/primitiv-python/issues/events{/number}","events_url":"https://api.github.com/repos/primitiv/primitiv-python/events","assignees_url":"https://api.github.com/repos/primitiv/primitiv-python/assignees{/user}","branches_url":"https://api.github.com/repos/primitiv/primitiv-python/branches{/branch}","tags_url":"https://api.github.com/repos/primitiv/primitiv-python/tags","blobs_url":"https://api.github.com/repos/primitiv/primitiv-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/primitiv/primitiv-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/primitiv/primitiv-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/primitiv/primitiv-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/primitiv/primitiv-python/statuses/{sha}","languages_url":"https://api.github.com/repos/primitiv/primitiv-python/languages","stargazers_url":"https://api.github.com/repos/primitiv/primitiv-python/stargazers","contributors_url":"https://api.github.com/repos/primitiv/primitiv-python/contributors","subscribers_url":"https://api.github.com/repos/primitiv/primitiv-python/subscribers","subscription_url":"https://api.github.com/repos/primitiv/primitiv-python/subscription","commits_url":"https://api.github.com/repos/primitiv/primitiv-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/primitiv/primitiv-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/primitiv/primitiv-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/primitiv/primitiv-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/primitiv/primitiv-python/contents/{+path}","compare_url":"https://api.github.com/repos/primitiv/primitiv-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/primitiv/primitiv-python/merges","archive_url":"https://api.github.com/repos/primitiv/primitiv-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/primitiv/primitiv-python/downloads","issues_url":"https://api.github.com/repos/primitiv/primitiv-python/issues{/number}","pulls_url":"https://api.github.com/repos/primitiv/primitiv-python/pulls{/number}","milestones_url":"https://api.github.com/repos/primitiv/primitiv-python/milestones{/number}","notifications_url":"https://api.github.com/repos/primitiv/primitiv-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/primitiv/primitiv-python/labels{/name}","releases_url":"https://api.github.com/repos/primitiv/primitiv-python/releases{/id}","deployments_url":"https://api.github.com/repos/primitiv/primitiv-python/deployments","created_at":"2017-11-29T22:47:06Z","updated_at":"2018-07-06T09:57:28Z","pushed_at":"2018-07-18T22:51:24Z","git_url":"git://github.com/primitiv/primitiv-python.git","ssh_url":"git@github.com:primitiv/primitiv-python.git","clone_url":"https://github.com/primitiv/primitiv-python.git","svn_url":"https://github.com/primitiv/primitiv-python","homepage":null,"size":525,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":6,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41"},"html":{"href":"https://github.com/primitiv/primitiv-python/pull/41"},"issue":{"href":"https://api.github.com/repos/primitiv/primitiv-python/issues/41"},"comments":{"href":"https://api.github.com/repos/primitiv/primitiv-python/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/primitiv/primitiv-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/primitiv/primitiv-python/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/primitiv/primitiv-python/statuses/043a3fdd2760c2b8504459ee7d6adbd0a237a64d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"odashi"}}