{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/239773977","pull_request_review_id":182649636,"id":239773977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTc3Mzk3Nw==","diff_hunk":"@@ -53,13 +53,17 @@ internal struct _SmallString {\n     self.init(raw: object.rawBits)\n   }\n \n+  @inlinable @inline(__always)\n+  internal init(_ object: _SmallString) {\n+    self.init(raw: object.rawBits)\n+  }\n+","path":"stdlib/public/core/SmallString.swift","position":8,"original_position":8,"commit_id":"febe6a6b4df06a4b653ce1f078f2241985b4c45b","original_commit_id":"febe6a6b4df06a4b653ce1f078f2241985b4c45b","user":{"login":"mundaym","id":15000766,"node_id":"MDQ6VXNlcjE1MDAwNzY2","avatar_url":"https://avatars2.githubusercontent.com/u/15000766?v=4","gravatar_id":"","url":"https://api.github.com/users/mundaym","html_url":"https://github.com/mundaym","followers_url":"https://api.github.com/users/mundaym/followers","following_url":"https://api.github.com/users/mundaym/following{/other_user}","gists_url":"https://api.github.com/users/mundaym/gists{/gist_id}","starred_url":"https://api.github.com/users/mundaym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mundaym/subscriptions","organizations_url":"https://api.github.com/users/mundaym/orgs","repos_url":"https://api.github.com/users/mundaym/repos","events_url":"https://api.github.com/users/mundaym/events{/privacy}","received_events_url":"https://api.github.com/users/mundaym/received_events","type":"User","site_admin":false},"body":"Oh, it does mean the code does an invariant check, whereas an assignment wouldn't I think.","created_at":"2018-12-07T11:16:40Z","updated_at":"2018-12-07T11:16:40Z","html_url":"https://github.com/apple/swift/pull/21077#discussion_r239773977","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/21077","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/239773977"},"html":{"href":"https://github.com/apple/swift/pull/21077#discussion_r239773977"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/21077"}},"in_reply_to_id":239657115},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/21077","id":236466078,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDY2MDc4","html_url":"https://github.com/apple/swift/pull/21077","diff_url":"https://github.com/apple/swift/pull/21077.diff","patch_url":"https://github.com/apple/swift/pull/21077.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/21077","number":21077,"state":"open","locked":false,"title":"[string] Fix string implementation for big endian platforms","user":{"login":"mundaym","id":15000766,"node_id":"MDQ6VXNlcjE1MDAwNzY2","avatar_url":"https://avatars2.githubusercontent.com/u/15000766?v=4","gravatar_id":"","url":"https://api.github.com/users/mundaym","html_url":"https://github.com/mundaym","followers_url":"https://api.github.com/users/mundaym/followers","following_url":"https://api.github.com/users/mundaym/following{/other_user}","gists_url":"https://api.github.com/users/mundaym/gists{/gist_id}","starred_url":"https://api.github.com/users/mundaym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mundaym/subscriptions","organizations_url":"https://api.github.com/users/mundaym/orgs","repos_url":"https://api.github.com/users/mundaym/repos","events_url":"https://api.github.com/users/mundaym/events{/privacy}","received_events_url":"https://api.github.com/users/mundaym/received_events","type":"User","site_admin":false},"body":"This commit supersedes 2866b4a which was overwritten by 4ab45df.\r\n\r\nWhen code points are stored in multi-byte types (e.g. UInt64) we\r\nneed to convert the order of the bytes in the value to little\r\nendian before we can access the value as raw bytes.\r\n\r\n","created_at":"2018-12-06T09:48:23Z","updated_at":"2018-12-07T11:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db694d0d460928ca7acdb957a299552dd0ca51bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/21077/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/21077/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/21077/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/febe6a6b4df06a4b653ce1f078f2241985b4c45b","head":{"label":"linux-on-ibm-z:s390x-smallstring-v2","ref":"s390x-smallstring-v2","sha":"febe6a6b4df06a4b653ce1f078f2241985b4c45b","user":{"login":"linux-on-ibm-z","id":11740175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzQwMTc1","avatar_url":"https://avatars2.githubusercontent.com/u/11740175?v=4","gravatar_id":"","url":"https://api.github.com/users/linux-on-ibm-z","html_url":"https://github.com/linux-on-ibm-z","followers_url":"https://api.github.com/users/linux-on-ibm-z/followers","following_url":"https://api.github.com/users/linux-on-ibm-z/following{/other_user}","gists_url":"https://api.github.com/users/linux-on-ibm-z/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-on-ibm-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-on-ibm-z/subscriptions","organizations_url":"https://api.github.com/users/linux-on-ibm-z/orgs","repos_url":"https://api.github.com/users/linux-on-ibm-z/repos","events_url":"https://api.github.com/users/linux-on-ibm-z/events{/privacy}","received_events_url":"https://api.github.com/users/linux-on-ibm-z/received_events","type":"Organization","site_admin":false},"repo":{"id":58820292,"node_id":"MDEwOlJlcG9zaXRvcnk1ODgyMDI5Mg==","name":"swift","full_name":"linux-on-ibm-z/swift","private":false,"owner":{"login":"linux-on-ibm-z","id":11740175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzQwMTc1","avatar_url":"https://avatars2.githubusercontent.com/u/11740175?v=4","gravatar_id":"","url":"https://api.github.com/users/linux-on-ibm-z","html_url":"https://github.com/linux-on-ibm-z","followers_url":"https://api.github.com/users/linux-on-ibm-z/followers","following_url":"https://api.github.com/users/linux-on-ibm-z/following{/other_user}","gists_url":"https://api.github.com/users/linux-on-ibm-z/gists{/gist_id}","starred_url":"https://api.github.com/users/linux-on-ibm-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linux-on-ibm-z/subscriptions","organizations_url":"https://api.github.com/users/linux-on-ibm-z/orgs","repos_url":"https://api.github.com/users/linux-on-ibm-z/repos","events_url":"https://api.github.com/users/linux-on-ibm-z/events{/privacy}","received_events_url":"https://api.github.com/users/linux-on-ibm-z/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linux-on-ibm-z/swift","description":"Porting and evolving the Swift programming language for Linux on IBM z.","fork":true,"url":"https://api.github.com/repos/linux-on-ibm-z/swift","forks_url":"https://api.github.com/repos/linux-on-ibm-z/swift/forks","keys_url":"https://api.github.com/repos/linux-on-ibm-z/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linux-on-ibm-z/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linux-on-ibm-z/swift/teams","hooks_url":"https://api.github.com/repos/linux-on-ibm-z/swift/hooks","issue_events_url":"https://api.github.com/repos/linux-on-ibm-z/swift/issues/events{/number}","events_url":"https://api.github.com/repos/linux-on-ibm-z/swift/events","assignees_url":"https://api.github.com/repos/linux-on-ibm-z/swift/assignees{/user}","branches_url":"https://api.github.com/repos/linux-on-ibm-z/swift/branches{/branch}","tags_url":"https://api.github.com/repos/linux-on-ibm-z/swift/tags","blobs_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linux-on-ibm-z/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/linux-on-ibm-z/swift/languages","stargazers_url":"https://api.github.com/repos/linux-on-ibm-z/swift/stargazers","contributors_url":"https://api.github.com/repos/linux-on-ibm-z/swift/contributors","subscribers_url":"https://api.github.com/repos/linux-on-ibm-z/swift/subscribers","subscription_url":"https://api.github.com/repos/linux-on-ibm-z/swift/subscription","commits_url":"https://api.github.com/repos/linux-on-ibm-z/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/linux-on-ibm-z/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/linux-on-ibm-z/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/linux-on-ibm-z/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/linux-on-ibm-z/swift/contents/{+path}","compare_url":"https://api.github.com/repos/linux-on-ibm-z/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linux-on-ibm-z/swift/merges","archive_url":"https://api.github.com/repos/linux-on-ibm-z/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linux-on-ibm-z/swift/downloads","issues_url":"https://api.github.com/repos/linux-on-ibm-z/swift/issues{/number}","pulls_url":"https://api.github.com/repos/linux-on-ibm-z/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/linux-on-ibm-z/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/linux-on-ibm-z/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linux-on-ibm-z/swift/labels{/name}","releases_url":"https://api.github.com/repos/linux-on-ibm-z/swift/releases{/id}","deployments_url":"https://api.github.com/repos/linux-on-ibm-z/swift/deployments","created_at":"2016-05-14T17:16:00Z","updated_at":"2016-05-14T17:21:32Z","pushed_at":"2018-12-06T18:33:40Z","git_url":"git://github.com/linux-on-ibm-z/swift.git","ssh_url":"git@github.com:linux-on-ibm-z/swift.git","clone_url":"https://github.com/linux-on-ibm-z/swift.git","svn_url":"https://github.com/linux-on-ibm-z/swift","homepage":"https://swift.org/","size":345851,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d7139bb85a52e0c02b343ecd9256fe4aa5190f8e","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-12-07T10:37:12Z","pushed_at":"2018-12-07T08:28:08Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":371208,"stargazers_count":45966,"watchers_count":45966,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7306,"mirror_url":null,"archived":false,"open_issues_count":447,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7306,"open_issues":447,"watchers":45966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/21077"},"html":{"href":"https://github.com/apple/swift/pull/21077"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/21077"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/21077/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/21077/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/21077/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/febe6a6b4df06a4b653ce1f078f2241985b4c45b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mundaym"}}