{"action":"created","comment":{"url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments/231340547","pull_request_review_id":172292048,"id":231340547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTM0MDU0Nw==","diff_hunk":"@@ -663,3 +667,8 @@ func parseSegName(reqPath string) string {\n \t}\n \treturn segName\n }\n+\n+func shouldStopStream(err error) bool {\n+\ttrimmed := strings.TrimSpace(err.Error())","path":"server/mediaserver.go","position":17,"original_position":17,"commit_id":"e2a2187d262281b58da2766f3934a22f9538feb5","original_commit_id":"e2a2187d262281b58da2766f3934a22f9538feb5","user":{"login":"j0sh","id":292510,"node_id":"MDQ6VXNlcjI5MjUxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/292510?v=4","gravatar_id":"","url":"https://api.github.com/users/j0sh","html_url":"https://github.com/j0sh","followers_url":"https://api.github.com/users/j0sh/followers","following_url":"https://api.github.com/users/j0sh/following{/other_user}","gists_url":"https://api.github.com/users/j0sh/gists{/gist_id}","starred_url":"https://api.github.com/users/j0sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j0sh/subscriptions","organizations_url":"https://api.github.com/users/j0sh/orgs","repos_url":"https://api.github.com/users/j0sh/repos","events_url":"https://api.github.com/users/j0sh/events{/privacy}","received_events_url":"https://api.github.com/users/j0sh/received_events","type":"User","site_admin":false},"body":"Should we trim when reading the error body from the response? Otherwise LGTM!","created_at":"2018-11-07T00:05:53Z","updated_at":"2018-11-07T00:05:54Z","html_url":"https://github.com/livepeer/go-livepeer/pull/590#discussion_r231340547","pull_request_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments/231340547"},"html":{"href":"https://github.com/livepeer/go-livepeer/pull/590#discussion_r231340547"},"pull_request":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590"}}},"pull_request":{"url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590","id":228876105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODc2MTA1","html_url":"https://github.com/livepeer/go-livepeer/pull/590","diff_url":"https://github.com/livepeer/go-livepeer/pull/590.diff","patch_url":"https://github.com/livepeer/go-livepeer/pull/590.patch","issue_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/590","number":590,"state":"open","locked":false,"title":"Stop stream upon expired job (WIP)","user":{"login":"eladmallel","id":1137044,"node_id":"MDQ6VXNlcjExMzcwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1137044?v=4","gravatar_id":"","url":"https://api.github.com/users/eladmallel","html_url":"https://github.com/eladmallel","followers_url":"https://api.github.com/users/eladmallel/followers","following_url":"https://api.github.com/users/eladmallel/following{/other_user}","gists_url":"https://api.github.com/users/eladmallel/gists{/gist_id}","starred_url":"https://api.github.com/users/eladmallel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eladmallel/subscriptions","organizations_url":"https://api.github.com/users/eladmallel/orgs","repos_url":"https://api.github.com/users/eladmallel/repos","events_url":"https://api.github.com/users/eladmallel/events{/privacy}","received_events_url":"https://api.github.com/users/eladmallel/received_events","type":"User","site_admin":false},"body":"This change is an optimization, not a bug fix, since T already denies\r\nany segments that belong to an expired job.\r\n\r\nSolving [this issue](https://github.com/livepeer/go-livepeer/issues/498).","created_at":"2018-11-07T00:02:53Z","updated_at":"2018-11-07T00:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2386939f1a0c8b4340ea0450badf64d9581dc8fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590/commits","review_comments_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590/comments","review_comment_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/590/comments","statuses_url":"https://api.github.com/repos/livepeer/go-livepeer/statuses/e2a2187d262281b58da2766f3934a22f9538feb5","head":{"label":"livepeer:em/stop-stream-upon-expired-job","ref":"em/stop-stream-upon-expired-job","sha":"e2a2187d262281b58da2766f3934a22f9538feb5","user":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"repo":{"id":94728962,"node_id":"MDEwOlJlcG9zaXRvcnk5NDcyODk2Mg==","name":"go-livepeer","full_name":"livepeer/go-livepeer","private":false,"owner":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/livepeer/go-livepeer","description":"Official Go implementation of the Livepeer protocol","fork":false,"url":"https://api.github.com/repos/livepeer/go-livepeer","forks_url":"https://api.github.com/repos/livepeer/go-livepeer/forks","keys_url":"https://api.github.com/repos/livepeer/go-livepeer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livepeer/go-livepeer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livepeer/go-livepeer/teams","hooks_url":"https://api.github.com/repos/livepeer/go-livepeer/hooks","issue_events_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/events{/number}","events_url":"https://api.github.com/repos/livepeer/go-livepeer/events","assignees_url":"https://api.github.com/repos/livepeer/go-livepeer/assignees{/user}","branches_url":"https://api.github.com/repos/livepeer/go-livepeer/branches{/branch}","tags_url":"https://api.github.com/repos/livepeer/go-livepeer/tags","blobs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livepeer/go-livepeer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/refs{/sha}","trees_url":"https://api.github.com/repos/livepeer/go-livepeer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livepeer/go-livepeer/statuses/{sha}","languages_url":"https://api.github.com/repos/livepeer/go-livepeer/languages","stargazers_url":"https://api.github.com/repos/livepeer/go-livepeer/stargazers","contributors_url":"https://api.github.com/repos/livepeer/go-livepeer/contributors","subscribers_url":"https://api.github.com/repos/livepeer/go-livepeer/subscribers","subscription_url":"https://api.github.com/repos/livepeer/go-livepeer/subscription","commits_url":"https://api.github.com/repos/livepeer/go-livepeer/commits{/sha}","git_commits_url":"https://api.github.com/repos/livepeer/go-livepeer/git/commits{/sha}","comments_url":"https://api.github.com/repos/livepeer/go-livepeer/comments{/number}","issue_comment_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/comments{/number}","contents_url":"https://api.github.com/repos/livepeer/go-livepeer/contents/{+path}","compare_url":"https://api.github.com/repos/livepeer/go-livepeer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livepeer/go-livepeer/merges","archive_url":"https://api.github.com/repos/livepeer/go-livepeer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livepeer/go-livepeer/downloads","issues_url":"https://api.github.com/repos/livepeer/go-livepeer/issues{/number}","pulls_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls{/number}","milestones_url":"https://api.github.com/repos/livepeer/go-livepeer/milestones{/number}","notifications_url":"https://api.github.com/repos/livepeer/go-livepeer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livepeer/go-livepeer/labels{/name}","releases_url":"https://api.github.com/repos/livepeer/go-livepeer/releases{/id}","deployments_url":"https://api.github.com/repos/livepeer/go-livepeer/deployments","created_at":"2017-06-19T02:36:09Z","updated_at":"2018-11-06T09:22:23Z","pushed_at":"2018-11-07T00:02:53Z","git_url":"git://github.com/livepeer/go-livepeer.git","ssh_url":"git@github.com:livepeer/go-livepeer.git","clone_url":"https://github.com/livepeer/go-livepeer.git","svn_url":"https://github.com/livepeer/go-livepeer","homepage":"http://livepeer.org","size":88883,"stargazers_count":167,"watchers_count":167,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":109,"watchers":167,"default_branch":"master"}},"base":{"label":"livepeer:master","ref":"master","sha":"b0340bfd9183dd06f09475cee003baad5c2b7c6e","user":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"repo":{"id":94728962,"node_id":"MDEwOlJlcG9zaXRvcnk5NDcyODk2Mg==","name":"go-livepeer","full_name":"livepeer/go-livepeer","private":false,"owner":{"login":"livepeer","id":25355022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU1MDIy","avatar_url":"https://avatars2.githubusercontent.com/u/25355022?v=4","gravatar_id":"","url":"https://api.github.com/users/livepeer","html_url":"https://github.com/livepeer","followers_url":"https://api.github.com/users/livepeer/followers","following_url":"https://api.github.com/users/livepeer/following{/other_user}","gists_url":"https://api.github.com/users/livepeer/gists{/gist_id}","starred_url":"https://api.github.com/users/livepeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livepeer/subscriptions","organizations_url":"https://api.github.com/users/livepeer/orgs","repos_url":"https://api.github.com/users/livepeer/repos","events_url":"https://api.github.com/users/livepeer/events{/privacy}","received_events_url":"https://api.github.com/users/livepeer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/livepeer/go-livepeer","description":"Official Go implementation of the Livepeer protocol","fork":false,"url":"https://api.github.com/repos/livepeer/go-livepeer","forks_url":"https://api.github.com/repos/livepeer/go-livepeer/forks","keys_url":"https://api.github.com/repos/livepeer/go-livepeer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livepeer/go-livepeer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livepeer/go-livepeer/teams","hooks_url":"https://api.github.com/repos/livepeer/go-livepeer/hooks","issue_events_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/events{/number}","events_url":"https://api.github.com/repos/livepeer/go-livepeer/events","assignees_url":"https://api.github.com/repos/livepeer/go-livepeer/assignees{/user}","branches_url":"https://api.github.com/repos/livepeer/go-livepeer/branches{/branch}","tags_url":"https://api.github.com/repos/livepeer/go-livepeer/tags","blobs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livepeer/go-livepeer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livepeer/go-livepeer/git/refs{/sha}","trees_url":"https://api.github.com/repos/livepeer/go-livepeer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livepeer/go-livepeer/statuses/{sha}","languages_url":"https://api.github.com/repos/livepeer/go-livepeer/languages","stargazers_url":"https://api.github.com/repos/livepeer/go-livepeer/stargazers","contributors_url":"https://api.github.com/repos/livepeer/go-livepeer/contributors","subscribers_url":"https://api.github.com/repos/livepeer/go-livepeer/subscribers","subscription_url":"https://api.github.com/repos/livepeer/go-livepeer/subscription","commits_url":"https://api.github.com/repos/livepeer/go-livepeer/commits{/sha}","git_commits_url":"https://api.github.com/repos/livepeer/go-livepeer/git/commits{/sha}","comments_url":"https://api.github.com/repos/livepeer/go-livepeer/comments{/number}","issue_comment_url":"https://api.github.com/repos/livepeer/go-livepeer/issues/comments{/number}","contents_url":"https://api.github.com/repos/livepeer/go-livepeer/contents/{+path}","compare_url":"https://api.github.com/repos/livepeer/go-livepeer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livepeer/go-livepeer/merges","archive_url":"https://api.github.com/repos/livepeer/go-livepeer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livepeer/go-livepeer/downloads","issues_url":"https://api.github.com/repos/livepeer/go-livepeer/issues{/number}","pulls_url":"https://api.github.com/repos/livepeer/go-livepeer/pulls{/number}","milestones_url":"https://api.github.com/repos/livepeer/go-livepeer/milestones{/number}","notifications_url":"https://api.github.com/repos/livepeer/go-livepeer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livepeer/go-livepeer/labels{/name}","releases_url":"https://api.github.com/repos/livepeer/go-livepeer/releases{/id}","deployments_url":"https://api.github.com/repos/livepeer/go-livepeer/deployments","created_at":"2017-06-19T02:36:09Z","updated_at":"2018-11-06T09:22:23Z","pushed_at":"2018-11-07T00:02:53Z","git_url":"git://github.com/livepeer/go-livepeer.git","ssh_url":"git@github.com:livepeer/go-livepeer.git","clone_url":"https://github.com/livepeer/go-livepeer.git","svn_url":"https://github.com/livepeer/go-livepeer","homepage":"http://livepeer.org","size":88883,"stargazers_count":167,"watchers_count":167,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":109,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590"},"html":{"href":"https://github.com/livepeer/go-livepeer/pull/590"},"issue":{"href":"https://api.github.com/repos/livepeer/go-livepeer/issues/590"},"comments":{"href":"https://api.github.com/repos/livepeer/go-livepeer/issues/590/comments"},"review_comments":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590/comments"},"review_comment":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livepeer/go-livepeer/pulls/590/commits"},"statuses":{"href":"https://api.github.com/repos/livepeer/go-livepeer/statuses/e2a2187d262281b58da2766f3934a22f9538feb5"}},"author_association":"NONE"}}
{"actor":{"display_login":"j0sh"}}