{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/eth-abi/pulls/comments/193523783","pull_request_review_id":126511879,"id":193523783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzUyMzc4Mw==","diff_hunk":"@@ -31,7 +31,7 @@ test-all:\n \ttox\n \n build-docs:\n-\tsphinx-apidoc -o docs/ . setup.py \"eth_abi/utils/*\" \"*conftest*\" \"tests/*\"\n+\tsphinx-apidoc -o docs/ . setup.py 'eth_typing/*' 'eth_abi/encoding.py' 'eth_abi/decoding.py' 'eth_abi/utils/*' 'tests/*'","path":"Makefile","position":5,"original_position":5,"commit_id":"e375baa9dd07b83c805465ea54b69b37312bf40a","original_commit_id":"e375baa9dd07b83c805465ea54b69b37312bf40a","user":{"login":"davesque","id":791437,"node_id":"MDQ6VXNlcjc5MTQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"body":"I guess we don't need to exclude those modules.  I think I did that because I was trying to find a way to exclude certain things from being included in the API documentation.  But then I realized I could restrict things from showing up with the `:members:` option on the `automodule` directive.  I think I can revert this change.","created_at":"2018-06-06T19:00:05Z","updated_at":"2018-06-06T19:00:06Z","html_url":"https://github.com/ethereum/eth-abi/pull/73#discussion_r193523783","pull_request_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/73","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/comments/193523783"},"html":{"href":"https://github.com/ethereum/eth-abi/pull/73#discussion_r193523783"},"pull_request":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/73"}},"in_reply_to_id":193502760},"pull_request":{"url":"https://api.github.com/repos/ethereum/eth-abi/pulls/73","id":190701357,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzAxMzU3","html_url":"https://github.com/ethereum/eth-abi/pull/73","diff_url":"https://github.com/ethereum/eth-abi/pull/73.diff","patch_url":"https://github.com/ethereum/eth-abi/pull/73.patch","issue_url":"https://api.github.com/repos/ethereum/eth-abi/issues/73","number":73,"state":"open","locked":false,"title":"Add documentation and some type hints","user":{"login":"davesque","id":791437,"node_id":"MDQ6VXNlcjc5MTQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\n\r\nDocumentation was a bit out of date in various ways.  Also needed documentation for registry feature.\r\n\r\n### How was it fixed?\r\n\r\nAdded API documentation via docstrings.  Updated existing documentation.  Added registry section.  Added informative type hints.\r\n\r\n#### Cute Animal Picture\r\n\r\n![Cute animal picture](http://4.bp.blogspot.com/-D_kGjreucoI/Tx2glkeHW5I/AAAAAAAADZo/QMHahSQSrB8/s1600/funny-animals-making-funny-faces-001.jpg)\r\n","created_at":"2018-05-25T21:51:50Z","updated_at":"2018-06-06T19:00:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f35055ee998a0dadedf2bcd293ce095181d5870","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/73/commits","review_comments_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/73/comments","review_comment_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/eth-abi/issues/73/comments","statuses_url":"https://api.github.com/repos/ethereum/eth-abi/statuses/e375baa9dd07b83c805465ea54b69b37312bf40a","head":{"label":"davesque:doc-updates","ref":"doc-updates","sha":"e375baa9dd07b83c805465ea54b69b37312bf40a","user":{"login":"davesque","id":791437,"node_id":"MDQ6VXNlcjc5MTQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"repo":{"id":125083717,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwODM3MTc=","name":"eth-abi","full_name":"davesque/eth-abi","owner":{"login":"davesque","id":791437,"node_id":"MDQ6VXNlcjc5MTQzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davesque/eth-abi","description":"Ethereum ABI utilities for python","fork":true,"url":"https://api.github.com/repos/davesque/eth-abi","forks_url":"https://api.github.com/repos/davesque/eth-abi/forks","keys_url":"https://api.github.com/repos/davesque/eth-abi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davesque/eth-abi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davesque/eth-abi/teams","hooks_url":"https://api.github.com/repos/davesque/eth-abi/hooks","issue_events_url":"https://api.github.com/repos/davesque/eth-abi/issues/events{/number}","events_url":"https://api.github.com/repos/davesque/eth-abi/events","assignees_url":"https://api.github.com/repos/davesque/eth-abi/assignees{/user}","branches_url":"https://api.github.com/repos/davesque/eth-abi/branches{/branch}","tags_url":"https://api.github.com/repos/davesque/eth-abi/tags","blobs_url":"https://api.github.com/repos/davesque/eth-abi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davesque/eth-abi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davesque/eth-abi/git/refs{/sha}","trees_url":"https://api.github.com/repos/davesque/eth-abi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davesque/eth-abi/statuses/{sha}","languages_url":"https://api.github.com/repos/davesque/eth-abi/languages","stargazers_url":"https://api.github.com/repos/davesque/eth-abi/stargazers","contributors_url":"https://api.github.com/repos/davesque/eth-abi/contributors","subscribers_url":"https://api.github.com/repos/davesque/eth-abi/subscribers","subscription_url":"https://api.github.com/repos/davesque/eth-abi/subscription","commits_url":"https://api.github.com/repos/davesque/eth-abi/commits{/sha}","git_commits_url":"https://api.github.com/repos/davesque/eth-abi/git/commits{/sha}","comments_url":"https://api.github.com/repos/davesque/eth-abi/comments{/number}","issue_comment_url":"https://api.github.com/repos/davesque/eth-abi/issues/comments{/number}","contents_url":"https://api.github.com/repos/davesque/eth-abi/contents/{+path}","compare_url":"https://api.github.com/repos/davesque/eth-abi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davesque/eth-abi/merges","archive_url":"https://api.github.com/repos/davesque/eth-abi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davesque/eth-abi/downloads","issues_url":"https://api.github.com/repos/davesque/eth-abi/issues{/number}","pulls_url":"https://api.github.com/repos/davesque/eth-abi/pulls{/number}","milestones_url":"https://api.github.com/repos/davesque/eth-abi/milestones{/number}","notifications_url":"https://api.github.com/repos/davesque/eth-abi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davesque/eth-abi/labels{/name}","releases_url":"https://api.github.com/repos/davesque/eth-abi/releases{/id}","deployments_url":"https://api.github.com/repos/davesque/eth-abi/deployments","created_at":"2018-03-13T16:42:46Z","updated_at":"2018-06-05T21:02:31Z","pushed_at":"2018-06-06T03:39:50Z","git_url":"git://github.com/davesque/eth-abi.git","ssh_url":"git@github.com:davesque/eth-abi.git","clone_url":"https://github.com/davesque/eth-abi.git","svn_url":"https://github.com/davesque/eth-abi","homepage":null,"size":550,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"b61a36ddb27ae80a9d41ac36f3cdba22e8803d27","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":52113942,"node_id":"MDEwOlJlcG9zaXRvcnk1MjExMzk0Mg==","name":"eth-abi","full_name":"ethereum/eth-abi","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/eth-abi","description":"Ethereum ABI utilities for python","fork":false,"url":"https://api.github.com/repos/ethereum/eth-abi","forks_url":"https://api.github.com/repos/ethereum/eth-abi/forks","keys_url":"https://api.github.com/repos/ethereum/eth-abi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/eth-abi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/eth-abi/teams","hooks_url":"https://api.github.com/repos/ethereum/eth-abi/hooks","issue_events_url":"https://api.github.com/repos/ethereum/eth-abi/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/eth-abi/events","assignees_url":"https://api.github.com/repos/ethereum/eth-abi/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/eth-abi/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/eth-abi/tags","blobs_url":"https://api.github.com/repos/ethereum/eth-abi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/eth-abi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/eth-abi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/eth-abi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/eth-abi/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/eth-abi/languages","stargazers_url":"https://api.github.com/repos/ethereum/eth-abi/stargazers","contributors_url":"https://api.github.com/repos/ethereum/eth-abi/contributors","subscribers_url":"https://api.github.com/repos/ethereum/eth-abi/subscribers","subscription_url":"https://api.github.com/repos/ethereum/eth-abi/subscription","commits_url":"https://api.github.com/repos/ethereum/eth-abi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/eth-abi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/eth-abi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/eth-abi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/eth-abi/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/eth-abi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/eth-abi/merges","archive_url":"https://api.github.com/repos/ethereum/eth-abi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/eth-abi/downloads","issues_url":"https://api.github.com/repos/ethereum/eth-abi/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/eth-abi/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/eth-abi/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/eth-abi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/eth-abi/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/eth-abi/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/eth-abi/deployments","created_at":"2016-02-19T20:18:56Z","updated_at":"2018-06-06T01:19:07Z","pushed_at":"2018-06-06T03:39:52Z","git_url":"git://github.com/ethereum/eth-abi.git","ssh_url":"git@github.com:ethereum/eth-abi.git","clone_url":"https://github.com/ethereum/eth-abi.git","svn_url":"https://github.com/ethereum/eth-abi","homepage":null,"size":523,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":8,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/73"},"html":{"href":"https://github.com/ethereum/eth-abi/pull/73"},"issue":{"href":"https://api.github.com/repos/ethereum/eth-abi/issues/73"},"comments":{"href":"https://api.github.com/repos/ethereum/eth-abi/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/eth-abi/statuses/e375baa9dd07b83c805465ea54b69b37312bf40a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davesque"}}