{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/comments/214393655","pull_request_review_id":151447681,"id":214393655,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM5MzY1NQ==","diff_hunk":"@@ -105,7 +157,19 @@ TEST(Baggage, testRemoteRestrictionManagerFunctionality)\n     ASSERT_EQ(Restriction(false, 0),\n               manager.getRestriction(\"test-service\", \"abc\"));\n     mockAgent->addBaggageRestriction(\"abc\", Restriction(true, 1));\n-    std::this_thread::sleep_for(std::chrono::milliseconds(200));\n+\n+    //Wait for the Update Restrictions to occurr\n+    //This is done by listening to the number of update published via the Metrics","path":"src/jaegertracing/baggage/BaggageTest.cpp","position":81,"original_position":81,"commit_id":"9091fc42ed356cd51e640c039623279e0a4de761","original_commit_id":"9091fc42ed356cd51e640c039623279e0a4de761","user":{"login":"mdouaihy","id":8843101,"node_id":"MDQ6VXNlcjg4NDMxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8843101?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouaihy","html_url":"https://github.com/mdouaihy","followers_url":"https://api.github.com/users/mdouaihy/followers","following_url":"https://api.github.com/users/mdouaihy/following{/other_user}","gists_url":"https://api.github.com/users/mdouaihy/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouaihy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouaihy/subscriptions","organizations_url":"https://api.github.com/users/mdouaihy/orgs","repos_url":"https://api.github.com/users/mdouaihy/repos","events_url":"https://api.github.com/users/mdouaihy/events{/privacy}","received_events_url":"https://api.github.com/users/mdouaihy/received_events","type":"User","site_admin":false},"body":"I dont think that the test has a race condition. it's just that some of the treatment is done asynchronously by another thread. We just need to wait to observe the result of that treatment. The reporter seemed to me as a way to observe such result.","created_at":"2018-08-31T15:36:29Z","updated_at":"2018-08-31T15:36:29Z","html_url":"https://github.com/jaegertracing/jaeger-client-cpp/pull/115#discussion_r214393655","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/comments/214393655"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-cpp/pull/115#discussion_r214393655"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115"}},"in_reply_to_id":201082555},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115","id":198498592,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDk4NTky","html_url":"https://github.com/jaegertracing/jaeger-client-cpp/pull/115","diff_url":"https://github.com/jaegertracing/jaeger-client-cpp/pull/115.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-cpp/pull/115.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues/115","number":115,"state":"open","locked":false,"title":"Resolve #112 Build Under Windows","user":{"login":"mdouaihy","id":8843101,"node_id":"MDQ6VXNlcjg4NDMxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8843101?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouaihy","html_url":"https://github.com/mdouaihy","followers_url":"https://api.github.com/users/mdouaihy/followers","following_url":"https://api.github.com/users/mdouaihy/following{/other_user}","gists_url":"https://api.github.com/users/mdouaihy/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouaihy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouaihy/subscriptions","organizations_url":"https://api.github.com/users/mdouaihy/orgs","repos_url":"https://api.github.com/users/mdouaihy/repos","events_url":"https://api.github.com/users/mdouaihy/events{/privacy}","received_events_url":"https://api.github.com/users/mdouaihy/received_events","type":"User","site_admin":false},"body":"## Which problem is this PR solving?\r\n- Resolves  #112 \r\n\r\n## Short description of the changes\r\n* Move to OpenTracing 1.5.0 that builds under Windows\r\n* Change link of OpenTracing to dynamic. With Static linking of OpenTracing, we end up with multi definition of OT Symbols. This is not acceptable especially for the OT Global Tracer\r\n* Fix OS specificities\r\n** Networking API\r\n** Windows headers\r\n* Fix some tests with random behavior that failed on Windows\r\n* Fix some MSVC specific compilation\r\n* Add appveyor build file.\r\n\r\nSigned-off-by: Mehrez Douaihy <mehrez.douaihy@gmail.com>\r\n\r\n","created_at":"2018-06-30T23:12:05Z","updated_at":"2018-08-31T15:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"803289cbe17c3346c18876fd44871a75dbb1921d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues/115/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/statuses/9091fc42ed356cd51e640c039623279e0a4de761","head":{"label":"mdouaihy:windowsbuild","ref":"windowsbuild","sha":"9091fc42ed356cd51e640c039623279e0a4de761","user":{"login":"mdouaihy","id":8843101,"node_id":"MDQ6VXNlcjg4NDMxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8843101?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouaihy","html_url":"https://github.com/mdouaihy","followers_url":"https://api.github.com/users/mdouaihy/followers","following_url":"https://api.github.com/users/mdouaihy/following{/other_user}","gists_url":"https://api.github.com/users/mdouaihy/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouaihy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouaihy/subscriptions","organizations_url":"https://api.github.com/users/mdouaihy/orgs","repos_url":"https://api.github.com/users/mdouaihy/repos","events_url":"https://api.github.com/users/mdouaihy/events{/privacy}","received_events_url":"https://api.github.com/users/mdouaihy/received_events","type":"User","site_admin":false},"repo":{"id":133972426,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5NzI0MjY=","name":"jaeger-client-cpp","full_name":"mdouaihy/jaeger-client-cpp","owner":{"login":"mdouaihy","id":8843101,"node_id":"MDQ6VXNlcjg4NDMxMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8843101?v=4","gravatar_id":"","url":"https://api.github.com/users/mdouaihy","html_url":"https://github.com/mdouaihy","followers_url":"https://api.github.com/users/mdouaihy/followers","following_url":"https://api.github.com/users/mdouaihy/following{/other_user}","gists_url":"https://api.github.com/users/mdouaihy/gists{/gist_id}","starred_url":"https://api.github.com/users/mdouaihy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdouaihy/subscriptions","organizations_url":"https://api.github.com/users/mdouaihy/orgs","repos_url":"https://api.github.com/users/mdouaihy/repos","events_url":"https://api.github.com/users/mdouaihy/events{/privacy}","received_events_url":"https://api.github.com/users/mdouaihy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdouaihy/jaeger-client-cpp","description":"C++ OpenTracing binding for Jaeger","fork":true,"url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp","forks_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/forks","keys_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/teams","hooks_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/hooks","issue_events_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/events","assignees_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/tags","blobs_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/languages","stargazers_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/stargazers","contributors_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/contributors","subscribers_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/subscribers","subscription_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/subscription","commits_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/merges","archive_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/downloads","issues_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/labels{/name}","releases_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/mdouaihy/jaeger-client-cpp/deployments","created_at":"2018-05-18T15:28:48Z","updated_at":"2018-06-30T17:24:22Z","pushed_at":"2018-07-01T15:31:48Z","git_url":"git://github.com/mdouaihy/jaeger-client-cpp.git","ssh_url":"git@github.com:mdouaihy/jaeger-client-cpp.git","clone_url":"https://github.com/mdouaihy/jaeger-client-cpp.git","svn_url":"https://github.com/mdouaihy/jaeger-client-cpp","homepage":"https://jaegertracing.io/","size":360,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"fdc3b86b22b6ec297d79ec553966efb4efa33393","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":100960701,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA5NjA3MDE=","name":"jaeger-client-cpp","full_name":"jaegertracing/jaeger-client-cpp","owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-cpp","description":"C++ OpenTracing binding for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/deployments","created_at":"2017-08-21T14:33:13Z","updated_at":"2018-08-26T11:39:30Z","pushed_at":"2018-08-17T18:18:21Z","git_url":"git://github.com/jaegertracing/jaeger-client-cpp.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-cpp.git","clone_url":"https://github.com/jaegertracing/jaeger-client-cpp.git","svn_url":"https://github.com/jaegertracing/jaeger-client-cpp","homepage":"https://jaegertracing.io/","size":351,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":12,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-cpp/pull/115"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues/115"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-cpp/statuses/9091fc42ed356cd51e640c039623279e0a4de761"}},"author_association":"NONE"}}
{"actor":{"display_login":"mdouaihy"}}