{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/181254167","pull_request_review_id":111837892,"id":181254167,"diff_hunk":"@@ -108,11 +110,35 @@ public void Dispose()\n \n         private void ProcessResponse(JToken response)\n         {\n+            ProcessResponse(response, false);\n+        }\n+\n+        private void ProcessResponse(JToken response, bool isEndOfBatch)\n+        {\n+            bool localBatchHadNativeModuleCalls;\n+\n             if (response == null || response.Type == JTokenType.Null || response.Type == JTokenType.Undefined)\n             {\n+                if (isEndOfBatch)\n+                {\n+                    localBatchHadNativeModuleCalls = _batchHadNativeModuleCalls;\n+\n+                    _nativeModulesQueueThread.Dispatch(() =>\n+                    {\n+                        // the bridge could still be processing native calls when the idle signaler fires\n+                        if (localBatchHadNativeModuleCalls)","path":"ReactWindows/ReactNative.Shared/Bridge/ReactBridge.cs","position":63,"original_position":63,"commit_id":"6b0a006d13a431737921a5cc8fa34132a4b3f441","original_commit_id":"6b0a006d13a431737921a5cc8fa34132a4b3f441","user":{"login":"rozele","id":1106239,"avatar_url":"https://avatars0.githubusercontent.com/u/1106239?v=4","gravatar_id":"","url":"https://api.github.com/users/rozele","html_url":"https://github.com/rozele","followers_url":"https://api.github.com/users/rozele/followers","following_url":"https://api.github.com/users/rozele/following{/other_user}","gists_url":"https://api.github.com/users/rozele/gists{/gist_id}","starred_url":"https://api.github.com/users/rozele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rozele/subscriptions","organizations_url":"https://api.github.com/users/rozele/orgs","repos_url":"https://api.github.com/users/rozele/repos","events_url":"https://api.github.com/users/rozele/events{/privacy}","received_events_url":"https://api.github.com/users/rozele/received_events","type":"User","site_admin":false},"body":"I don't understand this comment, can you expand?","created_at":"2018-04-12T23:53:29Z","updated_at":"2018-04-12T23:53:30Z","html_url":"https://github.com/Microsoft/react-native-windows/pull/1769#discussion_r181254167","pull_request_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments/181254167"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1769#discussion_r181254167"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769","id":181247987,"html_url":"https://github.com/Microsoft/react-native-windows/pull/1769","diff_url":"https://github.com/Microsoft/react-native-windows/pull/1769.diff","patch_url":"https://github.com/Microsoft/react-native-windows/pull/1769.patch","issue_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1769","number":1769,"state":"open","locked":false,"title":"Implement FlushQueueImmediate callback from RN Android","user":{"login":"matthargett","id":1550766,"avatar_url":"https://avatars3.githubusercontent.com/u/1550766?v=4","gravatar_id":"","url":"https://api.github.com/users/matthargett","html_url":"https://github.com/matthargett","followers_url":"https://api.github.com/users/matthargett/followers","following_url":"https://api.github.com/users/matthargett/following{/other_user}","gists_url":"https://api.github.com/users/matthargett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthargett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthargett/subscriptions","organizations_url":"https://api.github.com/users/matthargett/orgs","repos_url":"https://api.github.com/users/matthargett/repos","events_url":"https://api.github.com/users/matthargett/events{/privacy}","received_events_url":"https://api.github.com/users/matthargett/received_events","type":"User","site_admin":false},"body":"Reference:\r\nhttps://github.com/facebook/react-native/blob/8e85bf84e8139caebc79d2034313ff0f4c936bea/ReactCommon/cxxreact/JSCExecutor.cpp#L636","created_at":"2018-04-12T15:48:26Z","updated_at":"2018-04-12T23:53:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"493a09b01e6aaaf50d88502937ad567c079863e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769/commits","review_comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769/comments","review_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1769/comments","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/6b0a006d13a431737921a5cc8fa34132a4b3f441","head":{"label":"matthargett:flush_queue_immediate","ref":"flush_queue_immediate","sha":"6b0a006d13a431737921a5cc8fa34132a4b3f441","user":{"login":"matthargett","id":1550766,"avatar_url":"https://avatars3.githubusercontent.com/u/1550766?v=4","gravatar_id":"","url":"https://api.github.com/users/matthargett","html_url":"https://github.com/matthargett","followers_url":"https://api.github.com/users/matthargett/followers","following_url":"https://api.github.com/users/matthargett/following{/other_user}","gists_url":"https://api.github.com/users/matthargett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthargett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthargett/subscriptions","organizations_url":"https://api.github.com/users/matthargett/orgs","repos_url":"https://api.github.com/users/matthargett/repos","events_url":"https://api.github.com/users/matthargett/events{/privacy}","received_events_url":"https://api.github.com/users/matthargett/received_events","type":"User","site_admin":false},"repo":{"id":96360138,"name":"react-native-windows","full_name":"matthargett/react-native-windows","owner":{"login":"matthargett","id":1550766,"avatar_url":"https://avatars3.githubusercontent.com/u/1550766?v=4","gravatar_id":"","url":"https://api.github.com/users/matthargett","html_url":"https://github.com/matthargett","followers_url":"https://api.github.com/users/matthargett/followers","following_url":"https://api.github.com/users/matthargett/following{/other_user}","gists_url":"https://api.github.com/users/matthargett/gists{/gist_id}","starred_url":"https://api.github.com/users/matthargett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthargett/subscriptions","organizations_url":"https://api.github.com/users/matthargett/orgs","repos_url":"https://api.github.com/users/matthargett/repos","events_url":"https://api.github.com/users/matthargett/events{/privacy}","received_events_url":"https://api.github.com/users/matthargett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthargett/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":true,"url":"https://api.github.com/repos/matthargett/react-native-windows","forks_url":"https://api.github.com/repos/matthargett/react-native-windows/forks","keys_url":"https://api.github.com/repos/matthargett/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthargett/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthargett/react-native-windows/teams","hooks_url":"https://api.github.com/repos/matthargett/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/matthargett/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/matthargett/react-native-windows/events","assignees_url":"https://api.github.com/repos/matthargett/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/matthargett/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/matthargett/react-native-windows/tags","blobs_url":"https://api.github.com/repos/matthargett/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthargett/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthargett/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthargett/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthargett/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/matthargett/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/matthargett/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/matthargett/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/matthargett/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/matthargett/react-native-windows/subscription","commits_url":"https://api.github.com/repos/matthargett/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthargett/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthargett/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthargett/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthargett/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/matthargett/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthargett/react-native-windows/merges","archive_url":"https://api.github.com/repos/matthargett/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthargett/react-native-windows/downloads","issues_url":"https://api.github.com/repos/matthargett/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/matthargett/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/matthargett/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/matthargett/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthargett/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/matthargett/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/matthargett/react-native-windows/deployments","created_at":"2017-07-05T20:50:44Z","updated_at":"2018-04-12T04:31:14Z","pushed_at":"2018-04-12T15:46:19Z","git_url":"git://github.com/matthargett/react-native-windows.git","ssh_url":"git@github.com:matthargett/react-native-windows.git","clone_url":"https://github.com/matthargett/react-native-windows.git","svn_url":"https://github.com/matthargett/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":152373,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"bcdbae333bacf23b31d91e8cb0759450f1ffb81d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":48009214,"name":"react-native-windows","full_name":"Microsoft/react-native-windows","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/react-native-windows","description":"A framework for building native UWP and WPF apps with React.","fork":false,"url":"https://api.github.com/repos/Microsoft/react-native-windows","forks_url":"https://api.github.com/repos/Microsoft/react-native-windows/forks","keys_url":"https://api.github.com/repos/Microsoft/react-native-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/react-native-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/react-native-windows/teams","hooks_url":"https://api.github.com/repos/Microsoft/react-native-windows/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/react-native-windows/events","assignees_url":"https://api.github.com/repos/Microsoft/react-native-windows/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/react-native-windows/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/tags","blobs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/react-native-windows/languages","stargazers_url":"https://api.github.com/repos/Microsoft/react-native-windows/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/react-native-windows/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/react-native-windows/subscription","commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/react-native-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/react-native-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/react-native-windows/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/react-native-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/react-native-windows/merges","archive_url":"https://api.github.com/repos/Microsoft/react-native-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/react-native-windows/downloads","issues_url":"https://api.github.com/repos/Microsoft/react-native-windows/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/react-native-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/react-native-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/react-native-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/react-native-windows/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/react-native-windows/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/react-native-windows/deployments","created_at":"2015-12-15T00:16:54Z","updated_at":"2018-04-12T16:08:16Z","pushed_at":"2018-04-12T19:44:40Z","git_url":"git://github.com/Microsoft/react-native-windows.git","ssh_url":"git@github.com:Microsoft/react-native-windows.git","clone_url":"https://github.com/Microsoft/react-native-windows.git","svn_url":"https://github.com/Microsoft/react-native-windows","homepage":"http://facebook.github.io/react-native/","size":160340,"stargazers_count":3821,"watchers_count":3821,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":326,"mirror_url":null,"archived":false,"open_issues_count":263,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":326,"open_issues":263,"watchers":3821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769"},"html":{"href":"https://github.com/Microsoft/react-native-windows/pull/1769"},"issue":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1769"},"comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/issues/1769/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/pulls/1769/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/react-native-windows/statuses/6b0a006d13a431737921a5cc8fa34132a4b3f441"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rozele"}}