{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/191779164","pull_request_review_id":124382856,"id":191779164,"diff_hunk":"@@ -192,7 +193,7 @@ def run_spotdata(diagnostics, ancillary_data, sites, config_constants,\n         # Process diagnostics serially on one thread.\n         resulting_cubes = CubeList()\n         extrema_cubes = CubeList()\n-        for key in diagnostics.keys():\n+        for key in list(diagnostics.keys()):","path":"lib/improver/spotdata/main.py","position":37,"original_position":37,"commit_id":"cd78a8b227ab72160edbb2289b9f872c0056e2ce","original_commit_id":"cd78a8b227ab72160edbb2289b9f872c0056e2ce","user":{"login":"fionaRust","id":16209648,"avatar_url":"https://avatars3.githubusercontent.com/u/16209648?v=4","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false},"body":"`for key in diagnostics:`","created_at":"2018-05-30T14:01:59Z","updated_at":"2018-05-30T14:07:04Z","html_url":"https://github.com/metoppv/improver/pull/558#discussion_r191779164","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/558","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/191779164"},"html":{"href":"https://github.com/metoppv/improver/pull/558#discussion_r191779164"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/558","id":189897251,"html_url":"https://github.com/metoppv/improver/pull/558","diff_url":"https://github.com/metoppv/improver/pull/558.diff","patch_url":"https://github.com/metoppv/improver/pull/558.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/558","number":558,"state":"open","locked":false,"title":"Port IMPROVER to Python 3","user":{"login":"gavinevans","id":26933341,"avatar_url":"https://avatars3.githubusercontent.com/u/26933341?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinevans","html_url":"https://github.com/gavinevans","followers_url":"https://api.github.com/users/gavinevans/followers","following_url":"https://api.github.com/users/gavinevans/following{/other_user}","gists_url":"https://api.github.com/users/gavinevans/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinevans/subscriptions","organizations_url":"https://api.github.com/users/gavinevans/orgs","repos_url":"https://api.github.com/users/gavinevans/repos","events_url":"https://api.github.com/users/gavinevans/events{/privacy}","received_events_url":"https://api.github.com/users/gavinevans/received_events","type":"User","site_admin":false},"body":"Addresses #488 \r\n\r\nDescription:\r\nPorting to Python 3. \r\n\r\nPycodestyle, pylintE and unit tests now seem to pass. Building the documentation works on Travis but not locally, although I haven't investigated this so far. \r\n\r\nAll CLI tests that don't require known good output pass. CLI tests that do require known good output currently all fail due to a change to `hdf5libversion` within each file, so all known good output needs regenerating. This can be done now that #538 has been merged.\r\n\r\nNote that as this is a pull request to the Python 3 feature branch.\r\n\r\nTesting:\r\n - [] Ran tests and they passed OK\r\n","created_at":"2018-05-23T08:41:53Z","updated_at":"2018-05-30T14:07:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c038ff54c679409ff56cec36e673f71b341a6d78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/558/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/558/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/558/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/cd78a8b227ab72160edbb2289b9f872c0056e2ce","head":{"label":"gavinevans:impro_591_python_3","ref":"impro_591_python_3","sha":"cd78a8b227ab72160edbb2289b9f872c0056e2ce","user":{"login":"gavinevans","id":26933341,"avatar_url":"https://avatars3.githubusercontent.com/u/26933341?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinevans","html_url":"https://github.com/gavinevans","followers_url":"https://api.github.com/users/gavinevans/followers","following_url":"https://api.github.com/users/gavinevans/following{/other_user}","gists_url":"https://api.github.com/users/gavinevans/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinevans/subscriptions","organizations_url":"https://api.github.com/users/gavinevans/orgs","repos_url":"https://api.github.com/users/gavinevans/repos","events_url":"https://api.github.com/users/gavinevans/events{/privacy}","received_events_url":"https://api.github.com/users/gavinevans/received_events","type":"User","site_admin":false},"repo":{"id":87411485,"name":"improver","full_name":"gavinevans/improver","owner":{"login":"gavinevans","id":26933341,"avatar_url":"https://avatars3.githubusercontent.com/u/26933341?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinevans","html_url":"https://github.com/gavinevans","followers_url":"https://api.github.com/users/gavinevans/followers","following_url":"https://api.github.com/users/gavinevans/following{/other_user}","gists_url":"https://api.github.com/users/gavinevans/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinevans/subscriptions","organizations_url":"https://api.github.com/users/gavinevans/orgs","repos_url":"https://api.github.com/users/gavinevans/repos","events_url":"https://api.github.com/users/gavinevans/events{/privacy}","received_events_url":"https://api.github.com/users/gavinevans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gavinevans/improver","description":"IMPROVER","fork":true,"url":"https://api.github.com/repos/gavinevans/improver","forks_url":"https://api.github.com/repos/gavinevans/improver/forks","keys_url":"https://api.github.com/repos/gavinevans/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gavinevans/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gavinevans/improver/teams","hooks_url":"https://api.github.com/repos/gavinevans/improver/hooks","issue_events_url":"https://api.github.com/repos/gavinevans/improver/issues/events{/number}","events_url":"https://api.github.com/repos/gavinevans/improver/events","assignees_url":"https://api.github.com/repos/gavinevans/improver/assignees{/user}","branches_url":"https://api.github.com/repos/gavinevans/improver/branches{/branch}","tags_url":"https://api.github.com/repos/gavinevans/improver/tags","blobs_url":"https://api.github.com/repos/gavinevans/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gavinevans/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gavinevans/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/gavinevans/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gavinevans/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/gavinevans/improver/languages","stargazers_url":"https://api.github.com/repos/gavinevans/improver/stargazers","contributors_url":"https://api.github.com/repos/gavinevans/improver/contributors","subscribers_url":"https://api.github.com/repos/gavinevans/improver/subscribers","subscription_url":"https://api.github.com/repos/gavinevans/improver/subscription","commits_url":"https://api.github.com/repos/gavinevans/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/gavinevans/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/gavinevans/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/gavinevans/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/gavinevans/improver/contents/{+path}","compare_url":"https://api.github.com/repos/gavinevans/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gavinevans/improver/merges","archive_url":"https://api.github.com/repos/gavinevans/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gavinevans/improver/downloads","issues_url":"https://api.github.com/repos/gavinevans/improver/issues{/number}","pulls_url":"https://api.github.com/repos/gavinevans/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/gavinevans/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/gavinevans/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gavinevans/improver/labels{/name}","releases_url":"https://api.github.com/repos/gavinevans/improver/releases{/id}","deployments_url":"https://api.github.com/repos/gavinevans/improver/deployments","created_at":"2017-04-06T09:28:43Z","updated_at":"2017-04-06T10:19:29Z","pushed_at":"2018-05-30T13:20:18Z","git_url":"git://github.com/gavinevans/improver.git","ssh_url":"git@github.com:gavinevans/improver.git","clone_url":"https://github.com/gavinevans/improver.git","svn_url":"https://github.com/gavinevans/improver","homepage":null,"size":3530,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:feature_branch_python_3","ref":"feature_branch_python_3","sha":"e77bb01db3d0e4b970930342003219ce0524e53e","user":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-05-30T13:34:52Z","pushed_at":"2018-05-30T13:34:50Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":3365,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":27,"open_issues":122,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/558"},"html":{"href":"https://github.com/metoppv/improver/pull/558"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/558"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/cd78a8b227ab72160edbb2289b9f872c0056e2ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fionaRust"}}