{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/7","id":215537307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTM3MzA3","html_url":"https://github.com/kiwi-bop/flutter_crashlytics/pull/7","diff_url":"https://github.com/kiwi-bop/flutter_crashlytics/pull/7.diff","patch_url":"https://github.com/kiwi-bop/flutter_crashlytics/pull/7.patch","issue_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues/7","number":7,"state":"open","locked":false,"title":"Manually log exceptions","user":{"login":"jaggernod","id":2519463,"node_id":"MDQ6VXNlcjI1MTk0NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2519463?v=4","gravatar_id":"","url":"https://api.github.com/users/jaggernod","html_url":"https://github.com/jaggernod","followers_url":"https://api.github.com/users/jaggernod/followers","following_url":"https://api.github.com/users/jaggernod/following{/other_user}","gists_url":"https://api.github.com/users/jaggernod/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggernod/subscriptions","organizations_url":"https://api.github.com/users/jaggernod/orgs","repos_url":"https://api.github.com/users/jaggernod/repos","events_url":"https://api.github.com/users/jaggernod/events{/privacy}","received_events_url":"https://api.github.com/users/jaggernod/received_events","type":"User","site_admin":false},"body":"I'd like to hear an opinion about this PR.\r\nIt contains the mentioned before manual logging of an `Exception` (not `Error`) into the Crashlytics.\r\n\r\nThe experimental part is the usage of [stack_trace](https://github.com/dart-lang/stack_trace) library.\r\nI have noticed in the current implementation that **Global Functions** (with no class) are not correctly parsed by the regex matcher. Matching patterns might be one of the most error-prone parts of the plugin. \r\nHow about using the [stack_trace](https://github.com/dart-lang/stack_trace) library to r4esolve those issues? It is a standard dart-lang library and will ensure the stack traces are correctly parsed.\r\nDue to the built-in tree shaking of Dart those the lib will have a minimal footprint.\r\n\r\nWhat do you think?\r\n\r\nP.S. This implementation of `logException` has only the Android part implemented at the native site. iOS is still missing.","created_at":"2018-09-14T09:39:54Z","updated_at":"2018-09-14T09:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/7/commits","review_comments_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/7/comments","review_comment_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues/7/comments","statuses_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/statuses/5f77155273bebafdae2ebbe6d35948cd68f9cd6b","head":{"label":"jaggernod:feature/log-exception","ref":"feature/log-exception","sha":"5f77155273bebafdae2ebbe6d35948cd68f9cd6b","user":{"login":"jaggernod","id":2519463,"node_id":"MDQ6VXNlcjI1MTk0NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2519463?v=4","gravatar_id":"","url":"https://api.github.com/users/jaggernod","html_url":"https://github.com/jaggernod","followers_url":"https://api.github.com/users/jaggernod/followers","following_url":"https://api.github.com/users/jaggernod/following{/other_user}","gists_url":"https://api.github.com/users/jaggernod/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggernod/subscriptions","organizations_url":"https://api.github.com/users/jaggernod/orgs","repos_url":"https://api.github.com/users/jaggernod/repos","events_url":"https://api.github.com/users/jaggernod/events{/privacy}","received_events_url":"https://api.github.com/users/jaggernod/received_events","type":"User","site_admin":false},"repo":{"id":148459384,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0NTkzODQ=","name":"flutter_crashlytics","full_name":"jaggernod/flutter_crashlytics","owner":{"login":"jaggernod","id":2519463,"node_id":"MDQ6VXNlcjI1MTk0NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2519463?v=4","gravatar_id":"","url":"https://api.github.com/users/jaggernod","html_url":"https://github.com/jaggernod","followers_url":"https://api.github.com/users/jaggernod/followers","following_url":"https://api.github.com/users/jaggernod/following{/other_user}","gists_url":"https://api.github.com/users/jaggernod/gists{/gist_id}","starred_url":"https://api.github.com/users/jaggernod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaggernod/subscriptions","organizations_url":"https://api.github.com/users/jaggernod/orgs","repos_url":"https://api.github.com/users/jaggernod/repos","events_url":"https://api.github.com/users/jaggernod/events{/privacy}","received_events_url":"https://api.github.com/users/jaggernod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaggernod/flutter_crashlytics","description":":package: Flutter plugin for Crashlytics integration","fork":true,"url":"https://api.github.com/repos/jaggernod/flutter_crashlytics","forks_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/forks","keys_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/teams","hooks_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/hooks","issue_events_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/issues/events{/number}","events_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/events","assignees_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/assignees{/user}","branches_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/branches{/branch}","tags_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/tags","blobs_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/statuses/{sha}","languages_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/languages","stargazers_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/stargazers","contributors_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/contributors","subscribers_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/subscribers","subscription_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/subscription","commits_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/contents/{+path}","compare_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/merges","archive_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/downloads","issues_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/issues{/number}","pulls_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/pulls{/number}","milestones_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/milestones{/number}","notifications_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/labels{/name}","releases_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/releases{/id}","deployments_url":"https://api.github.com/repos/jaggernod/flutter_crashlytics/deployments","created_at":"2018-09-12T09:58:01Z","updated_at":"2018-09-12T09:58:03Z","pushed_at":"2018-09-14T09:32:23Z","git_url":"git://github.com/jaggernod/flutter_crashlytics.git","ssh_url":"git@github.com:jaggernod/flutter_crashlytics.git","clone_url":"https://github.com/jaggernod/flutter_crashlytics.git","svn_url":"https://github.com/jaggernod/flutter_crashlytics","homepage":"","size":172,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiwi-bop:master","ref":"master","sha":"87ba074ff078ff2f1cc864598c214c95254df22b","user":{"login":"kiwi-bop","id":7592874,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTI4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7592874?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwi-bop","html_url":"https://github.com/kiwi-bop","followers_url":"https://api.github.com/users/kiwi-bop/followers","following_url":"https://api.github.com/users/kiwi-bop/following{/other_user}","gists_url":"https://api.github.com/users/kiwi-bop/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwi-bop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwi-bop/subscriptions","organizations_url":"https://api.github.com/users/kiwi-bop/orgs","repos_url":"https://api.github.com/users/kiwi-bop/repos","events_url":"https://api.github.com/users/kiwi-bop/events{/privacy}","received_events_url":"https://api.github.com/users/kiwi-bop/received_events","type":"Organization","site_admin":false},"repo":{"id":145524259,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1MjQyNTk=","name":"flutter_crashlytics","full_name":"kiwi-bop/flutter_crashlytics","owner":{"login":"kiwi-bop","id":7592874,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTI4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7592874?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwi-bop","html_url":"https://github.com/kiwi-bop","followers_url":"https://api.github.com/users/kiwi-bop/followers","following_url":"https://api.github.com/users/kiwi-bop/following{/other_user}","gists_url":"https://api.github.com/users/kiwi-bop/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwi-bop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwi-bop/subscriptions","organizations_url":"https://api.github.com/users/kiwi-bop/orgs","repos_url":"https://api.github.com/users/kiwi-bop/repos","events_url":"https://api.github.com/users/kiwi-bop/events{/privacy}","received_events_url":"https://api.github.com/users/kiwi-bop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwi-bop/flutter_crashlytics","description":":package: Flutter plugin for Crashlytics integration","fork":false,"url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics","forks_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/forks","keys_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/teams","hooks_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/hooks","issue_events_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues/events{/number}","events_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/events","assignees_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/assignees{/user}","branches_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/branches{/branch}","tags_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/tags","blobs_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/languages","stargazers_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/stargazers","contributors_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/contributors","subscribers_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/subscribers","subscription_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/subscription","commits_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/contents/{+path}","compare_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/merges","archive_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/downloads","issues_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues{/number}","pulls_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/labels{/name}","releases_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/releases{/id}","deployments_url":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/deployments","created_at":"2018-08-21T07:28:29Z","updated_at":"2018-09-14T06:15:13Z","pushed_at":"2018-09-14T06:15:12Z","git_url":"git://github.com/kiwi-bop/flutter_crashlytics.git","ssh_url":"git@github.com:kiwi-bop/flutter_crashlytics.git","clone_url":"https://github.com/kiwi-bop/flutter_crashlytics.git","svn_url":"https://github.com/kiwi-bop/flutter_crashlytics","homepage":"","size":170,"stargazers_count":41,"watchers_count":41,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":5,"open_issues":3,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/7"},"html":{"href":"https://github.com/kiwi-bop/flutter_crashlytics/pull/7"},"issue":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues/7"},"comments":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/kiwi-bop/flutter_crashlytics/statuses/5f77155273bebafdae2ebbe6d35948cd68f9cd6b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":78,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"jaggernod"}}