{"action":"created","comment":{"url":"https://api.github.com/repos/containerd/containerd/pulls/comments/169053748","pull_request_review_id":97517330,"id":169053748,"diff_hunk":"@@ -8,6 +8,7 @@ language: go\n \n go:\n   - 1.9.x\n+  - 1.10.x","path":".travis.yml","position":null,"original_position":4,"commit_id":"519520ad27d6d217107b1a2068e70f02cc584b8e","original_commit_id":"f3de444b005cb88852b290e730dcaa33d6e0fda1","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Ah, yes, I read about the `1.10` issue, but thought that `1.10.x` would not result in that problem. Apparently though;\r\n\r\n> Travis is now recognizing 1.9.x and passing only 1.9 to gimme.\r\n\r\nSo I wonder if the `1.9.x` should also be updated to be `1.9`","created_at":"2018-02-19T11:50:28Z","updated_at":"2018-02-19T11:50:28Z","html_url":"https://github.com/containerd/containerd/pull/2008#discussion_r169053748","pull_request_url":"https://api.github.com/repos/containerd/containerd/pulls/2008","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments/169053748"},"html":{"href":"https://github.com/containerd/containerd/pull/2008#discussion_r169053748"},"pull_request":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2008"}},"in_reply_to_id":168987979},"pull_request":{"url":"https://api.github.com/repos/containerd/containerd/pulls/2008","id":163193766,"html_url":"https://github.com/containerd/containerd/pull/2008","diff_url":"https://github.com/containerd/containerd/pull/2008.diff","patch_url":"https://github.com/containerd/containerd/pull/2008.patch","issue_url":"https://api.github.com/repos/containerd/containerd/issues/2008","number":2008,"state":"open","locked":false,"title":"Bump to Go 1.10","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Given that containerd states Go 1.9 \"and up\", it's probably a good thing to have a pr checking if CI is successful on Go 1.10 now that it is in beta\r\n\r\nTo find out what has changed in Go 1.10, read the draft release notes:\r\nhttps://beta.golang.org/doc/go1.10\r\n\r\nDocumentation for Go 1.10 is available at:\r\nhttps://beta.golang.org/","created_at":"2018-01-16T14:34:00Z","updated_at":"2018-02-19T11:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c28170d9205d83fc00642428fe9a9ff8f714c02f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/containerd/containerd/pulls/2008/commits","review_comments_url":"https://api.github.com/repos/containerd/containerd/pulls/2008/comments","review_comment_url":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containerd/containerd/issues/2008/comments","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/519520ad27d6d217107b1a2068e70f02cc584b8e","head":{"label":"thaJeztah:bump-golang-to-1.10","ref":"bump-golang-to-1.10","sha":"519520ad27d6d217107b1a2068e70f02cc584b8e","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"repo":{"id":48202584,"name":"containerd","full_name":"thaJeztah/containerd","owner":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thaJeztah/containerd","description":"Standalone Container Daemon","fork":true,"url":"https://api.github.com/repos/thaJeztah/containerd","forks_url":"https://api.github.com/repos/thaJeztah/containerd/forks","keys_url":"https://api.github.com/repos/thaJeztah/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thaJeztah/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thaJeztah/containerd/teams","hooks_url":"https://api.github.com/repos/thaJeztah/containerd/hooks","issue_events_url":"https://api.github.com/repos/thaJeztah/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/thaJeztah/containerd/events","assignees_url":"https://api.github.com/repos/thaJeztah/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/thaJeztah/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/thaJeztah/containerd/tags","blobs_url":"https://api.github.com/repos/thaJeztah/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thaJeztah/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thaJeztah/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/thaJeztah/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thaJeztah/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/thaJeztah/containerd/languages","stargazers_url":"https://api.github.com/repos/thaJeztah/containerd/stargazers","contributors_url":"https://api.github.com/repos/thaJeztah/containerd/contributors","subscribers_url":"https://api.github.com/repos/thaJeztah/containerd/subscribers","subscription_url":"https://api.github.com/repos/thaJeztah/containerd/subscription","commits_url":"https://api.github.com/repos/thaJeztah/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/thaJeztah/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/thaJeztah/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/thaJeztah/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/thaJeztah/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/thaJeztah/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thaJeztah/containerd/merges","archive_url":"https://api.github.com/repos/thaJeztah/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thaJeztah/containerd/downloads","issues_url":"https://api.github.com/repos/thaJeztah/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/thaJeztah/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/thaJeztah/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/thaJeztah/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thaJeztah/containerd/labels{/name}","releases_url":"https://api.github.com/repos/thaJeztah/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/thaJeztah/containerd/deployments","created_at":"2015-12-17T22:53:23Z","updated_at":"2016-05-25T11:25:54Z","pushed_at":"2018-02-19T11:49:21Z","git_url":"git://github.com/thaJeztah/containerd.git","ssh_url":"git@github.com:thaJeztah/containerd.git","clone_url":"https://github.com/thaJeztah/containerd.git","svn_url":"https://github.com/thaJeztah/containerd","homepage":"https://containerd.tools/","size":39482,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containerd:master","ref":"master","sha":"6a50dca19687386b966a486e6ec7ca1e940580ee","user":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"repo":{"id":46089560,"name":"containerd","full_name":"containerd/containerd","owner":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containerd/containerd","description":"An open and reliable container runtime","fork":false,"url":"https://api.github.com/repos/containerd/containerd","forks_url":"https://api.github.com/repos/containerd/containerd/forks","keys_url":"https://api.github.com/repos/containerd/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containerd/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containerd/containerd/teams","hooks_url":"https://api.github.com/repos/containerd/containerd/hooks","issue_events_url":"https://api.github.com/repos/containerd/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/containerd/containerd/events","assignees_url":"https://api.github.com/repos/containerd/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/containerd/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/containerd/containerd/tags","blobs_url":"https://api.github.com/repos/containerd/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containerd/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containerd/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/containerd/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/containerd/containerd/languages","stargazers_url":"https://api.github.com/repos/containerd/containerd/stargazers","contributors_url":"https://api.github.com/repos/containerd/containerd/contributors","subscribers_url":"https://api.github.com/repos/containerd/containerd/subscribers","subscription_url":"https://api.github.com/repos/containerd/containerd/subscription","commits_url":"https://api.github.com/repos/containerd/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/containerd/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/containerd/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/containerd/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/containerd/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/containerd/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containerd/containerd/merges","archive_url":"https://api.github.com/repos/containerd/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containerd/containerd/downloads","issues_url":"https://api.github.com/repos/containerd/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/containerd/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/containerd/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/containerd/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containerd/containerd/labels{/name}","releases_url":"https://api.github.com/repos/containerd/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/containerd/containerd/deployments","created_at":"2015-11-13T00:27:43Z","updated_at":"2018-02-19T09:27:10Z","pushed_at":"2018-02-19T11:49:23Z","git_url":"git://github.com/containerd/containerd.git","ssh_url":"git@github.com:containerd/containerd.git","clone_url":"https://github.com/containerd/containerd.git","svn_url":"https://github.com/containerd/containerd","homepage":"https://containerd.io","size":39861,"stargazers_count":2278,"watchers_count":2278,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":464,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":464,"open_issues":78,"watchers":2278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2008"},"html":{"href":"https://github.com/containerd/containerd/pull/2008"},"issue":{"href":"https://api.github.com/repos/containerd/containerd/issues/2008"},"comments":{"href":"https://api.github.com/repos/containerd/containerd/issues/2008/comments"},"review_comments":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2008/comments"},"review_comment":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containerd/containerd/pulls/2008/commits"},"statuses":{"href":"https://api.github.com/repos/containerd/containerd/statuses/519520ad27d6d217107b1a2068e70f02cc584b8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thaJeztah"}}