{"action":"created","comment":{"url":"https://api.github.com/repos/yildizdb/yildiz/pulls/comments/219467087","pull_request_review_id":157651423,"id":219467087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQ2NzA4Nw==","diff_hunk":"@@ -49,27 +49,34 @@ export class RedisClient {\n         return;\n     }\n \n-    this.redis.on(\"error\", (error: Error) => {\n-        debug(`Redis error: ${error}`);\n-        this.metrics.inc(\"redis_error\");\n-    });\n-\n     this.redis.on(\"node error\", (error: Error) => {\n         debug(`Redis node error: ${error}`);\n         this.metrics.inc(\"redis_node_error\");\n     });\n \n     this.redis.on(\"connect\", () => debug(\"Redis is connected.\"));\n \n-    this.redis.on(\"ready\", () => {\n-      debug(\"Redis is ready.\");\n-    });\n-\n     this.redis.on(\"close\", () => debug(\"Redis connection is closed.\"));\n \n     this.redis.on(\"reconnecting\", () => debug(\"Redis is reconnecting...\"));\n \n     this.redis.on(\"end\", () => debug(\"Redis connection has ended.\"));\n+\n+    return new Promise((resolve, reject) => {\n+\n+      this.redis.on(\"error\", (error: Error) => {","path":"lib/bigtable/cache/RedisClient.ts","position":28,"original_position":28,"commit_id":"78ac75f98d90de3e40e5c9f829f0bbabe706e04c","original_commit_id":"78ac75f98d90de3e40e5c9f829f0bbabe706e04c","user":{"login":"krystianity","id":7975486,"node_id":"MDQ6VXNlcjc5NzU0ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/7975486?v=4","gravatar_id":"","url":"https://api.github.com/users/krystianity","html_url":"https://github.com/krystianity","followers_url":"https://api.github.com/users/krystianity/followers","following_url":"https://api.github.com/users/krystianity/following{/other_user}","gists_url":"https://api.github.com/users/krystianity/gists{/gist_id}","starred_url":"https://api.github.com/users/krystianity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krystianity/subscriptions","organizations_url":"https://api.github.com/users/krystianity/orgs","repos_url":"https://api.github.com/users/krystianity/repos","events_url":"https://api.github.com/users/krystianity/events{/privacy}","received_events_url":"https://api.github.com/users/krystianity/received_events","type":"User","site_admin":false},"body":"move out of promise, remove reject!","created_at":"2018-09-21T11:34:16Z","updated_at":"2018-09-21T11:38:48Z","html_url":"https://github.com/yildizdb/yildiz/pull/13#discussion_r219467087","pull_request_url":"https://api.github.com/repos/yildizdb/yildiz/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yildizdb/yildiz/pulls/comments/219467087"},"html":{"href":"https://github.com/yildizdb/yildiz/pull/13#discussion_r219467087"},"pull_request":{"href":"https://api.github.com/repos/yildizdb/yildiz/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/yildizdb/yildiz/pulls/13","id":217209179,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjA5MTc5","html_url":"https://github.com/yildizdb/yildiz/pull/13","diff_url":"https://github.com/yildizdb/yildiz/pull/13.diff","patch_url":"https://github.com/yildizdb/yildiz/pull/13.patch","issue_url":"https://api.github.com/repos/yildizdb/yildiz/issues/13","number":13,"state":"closed","locked":false,"title":"More polishing","user":{"login":"rjmasikome","id":4187727,"node_id":"MDQ6VXNlcjQxODc3Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/4187727?v=4","gravatar_id":"","url":"https://api.github.com/users/rjmasikome","html_url":"https://github.com/rjmasikome","followers_url":"https://api.github.com/users/rjmasikome/followers","following_url":"https://api.github.com/users/rjmasikome/following{/other_user}","gists_url":"https://api.github.com/users/rjmasikome/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmasikome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmasikome/subscriptions","organizations_url":"https://api.github.com/users/rjmasikome/orgs","repos_url":"https://api.github.com/users/rjmasikome/repos","events_url":"https://api.github.com/users/rjmasikome/events{/privacy}","received_events_url":"https://api.github.com/users/rjmasikome/received_events","type":"User","site_admin":false},"body":"* Add`.npmignore`\r\n* Edit `tsconfig.json`\r\n* Add `swagger.json` and `swagger.yml`\r\n* Minor refactoring\r\n* More defined Bigtable definition","created_at":"2018-09-21T08:32:50Z","updated_at":"2018-09-21T11:38:48Z","closed_at":"2018-09-21T08:33:00Z","merged_at":"2018-09-21T08:33:00Z","merge_commit_sha":"8839cd3fb091684c371badeeaf4cfbc39508a910","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yildizdb/yildiz/pulls/13/commits","review_comments_url":"https://api.github.com/repos/yildizdb/yildiz/pulls/13/comments","review_comment_url":"https://api.github.com/repos/yildizdb/yildiz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yildizdb/yildiz/issues/13/comments","statuses_url":"https://api.github.com/repos/yildizdb/yildiz/statuses/78ac75f98d90de3e40e5c9f829f0bbabe706e04c","head":{"label":"yildizdb:fix/polishing","ref":"fix/polishing","sha":"78ac75f98d90de3e40e5c9f829f0bbabe706e04c","user":{"login":"yildizdb","id":33395375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzk1Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/33395375?v=4","gravatar_id":"","url":"https://api.github.com/users/yildizdb","html_url":"https://github.com/yildizdb","followers_url":"https://api.github.com/users/yildizdb/followers","following_url":"https://api.github.com/users/yildizdb/following{/other_user}","gists_url":"https://api.github.com/users/yildizdb/gists{/gist_id}","starred_url":"https://api.github.com/users/yildizdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yildizdb/subscriptions","organizations_url":"https://api.github.com/users/yildizdb/orgs","repos_url":"https://api.github.com/users/yildizdb/repos","events_url":"https://api.github.com/users/yildizdb/events{/privacy}","received_events_url":"https://api.github.com/users/yildizdb/received_events","type":"Organization","site_admin":false},"repo":{"id":106202793,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyMDI3OTM=","name":"yildiz","full_name":"yildizdb/yildiz","private":false,"owner":{"login":"yildizdb","id":33395375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzk1Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/33395375?v=4","gravatar_id":"","url":"https://api.github.com/users/yildizdb","html_url":"https://github.com/yildizdb","followers_url":"https://api.github.com/users/yildizdb/followers","following_url":"https://api.github.com/users/yildizdb/following{/other_user}","gists_url":"https://api.github.com/users/yildizdb/gists{/gist_id}","starred_url":"https://api.github.com/users/yildizdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yildizdb/subscriptions","organizations_url":"https://api.github.com/users/yildizdb/orgs","repos_url":"https://api.github.com/users/yildizdb/repos","events_url":"https://api.github.com/users/yildizdb/events{/privacy}","received_events_url":"https://api.github.com/users/yildizdb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yildizdb/yildiz","description":":unicorn::star2: Big Data Event Relation Storage as HTTP layer on top of Google Big Table","fork":false,"url":"https://api.github.com/repos/yildizdb/yildiz","forks_url":"https://api.github.com/repos/yildizdb/yildiz/forks","keys_url":"https://api.github.com/repos/yildizdb/yildiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yildizdb/yildiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yildizdb/yildiz/teams","hooks_url":"https://api.github.com/repos/yildizdb/yildiz/hooks","issue_events_url":"https://api.github.com/repos/yildizdb/yildiz/issues/events{/number}","events_url":"https://api.github.com/repos/yildizdb/yildiz/events","assignees_url":"https://api.github.com/repos/yildizdb/yildiz/assignees{/user}","branches_url":"https://api.github.com/repos/yildizdb/yildiz/branches{/branch}","tags_url":"https://api.github.com/repos/yildizdb/yildiz/tags","blobs_url":"https://api.github.com/repos/yildizdb/yildiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yildizdb/yildiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yildizdb/yildiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/yildizdb/yildiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yildizdb/yildiz/statuses/{sha}","languages_url":"https://api.github.com/repos/yildizdb/yildiz/languages","stargazers_url":"https://api.github.com/repos/yildizdb/yildiz/stargazers","contributors_url":"https://api.github.com/repos/yildizdb/yildiz/contributors","subscribers_url":"https://api.github.com/repos/yildizdb/yildiz/subscribers","subscription_url":"https://api.github.com/repos/yildizdb/yildiz/subscription","commits_url":"https://api.github.com/repos/yildizdb/yildiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/yildizdb/yildiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/yildizdb/yildiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/yildizdb/yildiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/yildizdb/yildiz/contents/{+path}","compare_url":"https://api.github.com/repos/yildizdb/yildiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yildizdb/yildiz/merges","archive_url":"https://api.github.com/repos/yildizdb/yildiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yildizdb/yildiz/downloads","issues_url":"https://api.github.com/repos/yildizdb/yildiz/issues{/number}","pulls_url":"https://api.github.com/repos/yildizdb/yildiz/pulls{/number}","milestones_url":"https://api.github.com/repos/yildizdb/yildiz/milestones{/number}","notifications_url":"https://api.github.com/repos/yildizdb/yildiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yildizdb/yildiz/labels{/name}","releases_url":"https://api.github.com/repos/yildizdb/yildiz/releases{/id}","deployments_url":"https://api.github.com/repos/yildizdb/yildiz/deployments","created_at":"2017-10-08T19:15:35Z","updated_at":"2018-09-21T11:00:05Z","pushed_at":"2018-09-21T11:00:03Z","git_url":"git://github.com/yildizdb/yildiz.git","ssh_url":"git@github.com:yildizdb/yildiz.git","clone_url":"https://github.com/yildizdb/yildiz.git","svn_url":"https://github.com/yildizdb/yildiz","homepage":"","size":546,"stargazers_count":18,"watchers_count":18,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":18,"default_branch":"master"}},"base":{"label":"yildizdb:master","ref":"master","sha":"8173301c590d9d1095bfe4ff944d80c28c52f175","user":{"login":"yildizdb","id":33395375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzk1Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/33395375?v=4","gravatar_id":"","url":"https://api.github.com/users/yildizdb","html_url":"https://github.com/yildizdb","followers_url":"https://api.github.com/users/yildizdb/followers","following_url":"https://api.github.com/users/yildizdb/following{/other_user}","gists_url":"https://api.github.com/users/yildizdb/gists{/gist_id}","starred_url":"https://api.github.com/users/yildizdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yildizdb/subscriptions","organizations_url":"https://api.github.com/users/yildizdb/orgs","repos_url":"https://api.github.com/users/yildizdb/repos","events_url":"https://api.github.com/users/yildizdb/events{/privacy}","received_events_url":"https://api.github.com/users/yildizdb/received_events","type":"Organization","site_admin":false},"repo":{"id":106202793,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyMDI3OTM=","name":"yildiz","full_name":"yildizdb/yildiz","private":false,"owner":{"login":"yildizdb","id":33395375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzk1Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/33395375?v=4","gravatar_id":"","url":"https://api.github.com/users/yildizdb","html_url":"https://github.com/yildizdb","followers_url":"https://api.github.com/users/yildizdb/followers","following_url":"https://api.github.com/users/yildizdb/following{/other_user}","gists_url":"https://api.github.com/users/yildizdb/gists{/gist_id}","starred_url":"https://api.github.com/users/yildizdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yildizdb/subscriptions","organizations_url":"https://api.github.com/users/yildizdb/orgs","repos_url":"https://api.github.com/users/yildizdb/repos","events_url":"https://api.github.com/users/yildizdb/events{/privacy}","received_events_url":"https://api.github.com/users/yildizdb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yildizdb/yildiz","description":":unicorn::star2: Big Data Event Relation Storage as HTTP layer on top of Google Big Table","fork":false,"url":"https://api.github.com/repos/yildizdb/yildiz","forks_url":"https://api.github.com/repos/yildizdb/yildiz/forks","keys_url":"https://api.github.com/repos/yildizdb/yildiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yildizdb/yildiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yildizdb/yildiz/teams","hooks_url":"https://api.github.com/repos/yildizdb/yildiz/hooks","issue_events_url":"https://api.github.com/repos/yildizdb/yildiz/issues/events{/number}","events_url":"https://api.github.com/repos/yildizdb/yildiz/events","assignees_url":"https://api.github.com/repos/yildizdb/yildiz/assignees{/user}","branches_url":"https://api.github.com/repos/yildizdb/yildiz/branches{/branch}","tags_url":"https://api.github.com/repos/yildizdb/yildiz/tags","blobs_url":"https://api.github.com/repos/yildizdb/yildiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yildizdb/yildiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yildizdb/yildiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/yildizdb/yildiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yildizdb/yildiz/statuses/{sha}","languages_url":"https://api.github.com/repos/yildizdb/yildiz/languages","stargazers_url":"https://api.github.com/repos/yildizdb/yildiz/stargazers","contributors_url":"https://api.github.com/repos/yildizdb/yildiz/contributors","subscribers_url":"https://api.github.com/repos/yildizdb/yildiz/subscribers","subscription_url":"https://api.github.com/repos/yildizdb/yildiz/subscription","commits_url":"https://api.github.com/repos/yildizdb/yildiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/yildizdb/yildiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/yildizdb/yildiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/yildizdb/yildiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/yildizdb/yildiz/contents/{+path}","compare_url":"https://api.github.com/repos/yildizdb/yildiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yildizdb/yildiz/merges","archive_url":"https://api.github.com/repos/yildizdb/yildiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yildizdb/yildiz/downloads","issues_url":"https://api.github.com/repos/yildizdb/yildiz/issues{/number}","pulls_url":"https://api.github.com/repos/yildizdb/yildiz/pulls{/number}","milestones_url":"https://api.github.com/repos/yildizdb/yildiz/milestones{/number}","notifications_url":"https://api.github.com/repos/yildizdb/yildiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yildizdb/yildiz/labels{/name}","releases_url":"https://api.github.com/repos/yildizdb/yildiz/releases{/id}","deployments_url":"https://api.github.com/repos/yildizdb/yildiz/deployments","created_at":"2017-10-08T19:15:35Z","updated_at":"2018-09-21T11:00:05Z","pushed_at":"2018-09-21T11:00:03Z","git_url":"git://github.com/yildizdb/yildiz.git","ssh_url":"git@github.com:yildizdb/yildiz.git","clone_url":"https://github.com/yildizdb/yildiz.git","svn_url":"https://github.com/yildizdb/yildiz","homepage":"","size":546,"stargazers_count":18,"watchers_count":18,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":0,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yildizdb/yildiz/pulls/13"},"html":{"href":"https://github.com/yildizdb/yildiz/pull/13"},"issue":{"href":"https://api.github.com/repos/yildizdb/yildiz/issues/13"},"comments":{"href":"https://api.github.com/repos/yildizdb/yildiz/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/yildizdb/yildiz/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/yildizdb/yildiz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yildizdb/yildiz/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/yildizdb/yildiz/statuses/78ac75f98d90de3e40e5c9f829f0bbabe706e04c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"krystianity"}}