{"action":"created","comment":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/comments/168501630","pull_request_review_id":96878336,"id":168501630,"diff_hunk":"@@ -40,6 +40,10 @@ class TOOLKIT_EXPORT ToolManager {\n \n   void addTool(AbstractTool* tool);\n \n+  void removeTool(const QString& toolName);","path":"Plugin/CppApi/include/ToolManager.h","position":4,"original_position":4,"commit_id":"e20cf235ed48cd1a54be93a8378242cf73e59d1a","original_commit_id":"e20cf235ed48cd1a54be93a8378242cf73e59d1a","user":{"login":"ldanzinger","id":4107363,"avatar_url":"https://avatars2.githubusercontent.com/u/4107363?v=4","gravatar_id":"","url":"https://api.github.com/users/ldanzinger","html_url":"https://github.com/ldanzinger","followers_url":"https://api.github.com/users/ldanzinger/followers","following_url":"https://api.github.com/users/ldanzinger/following{/other_user}","gists_url":"https://api.github.com/users/ldanzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ldanzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldanzinger/subscriptions","organizations_url":"https://api.github.com/users/ldanzinger/orgs","repos_url":"https://api.github.com/users/ldanzinger/repos","events_url":"https://api.github.com/users/ldanzinger/events{/privacy}","received_events_url":"https://api.github.com/users/ldanzinger/received_events","type":"User","site_admin":false},"body":"Do we want to have a version of this function that takes in an AbstractTool instance? I wonder if you'd want to ensure you are removing a specific instance of a tool and not just some instance of a tool that is in the tool manager (in the case that you have multiple AddLocalDataToolControllers, for example)","created_at":"2018-02-15T15:03:20Z","updated_at":"2018-02-15T15:03:20Z","html_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/226#discussion_r168501630","pull_request_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/comments/168501630"},"html":{"href":"https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/226#discussion_r168501630"},"pull_request":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226"}}},"pull_request":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226","id":169390298,"html_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/226","diff_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/226.diff","patch_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/226.patch","issue_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/226","number":226,"state":"open","locked":false,"title":"Add API ref and remove tools when they are destroyed","user":{"login":"lsmallwood","id":19823035,"avatar_url":"https://avatars1.githubusercontent.com/u/19823035?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmallwood","html_url":"https://github.com/lsmallwood","followers_url":"https://api.github.com/users/lsmallwood/followers","following_url":"https://api.github.com/users/lsmallwood/following{/other_user}","gists_url":"https://api.github.com/users/lsmallwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmallwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmallwood/subscriptions","organizations_url":"https://api.github.com/users/lsmallwood/orgs","repos_url":"https://api.github.com/users/lsmallwood/repos","events_url":"https://api.github.com/users/lsmallwood/events{/privacy}","received_events_url":"https://api.github.com/users/lsmallwood/received_events","type":"User","site_admin":false},"body":"@michael-tims, @ldanzinger - please review the update to the ToolManager to remove tools which have been destroyed","created_at":"2018-02-15T14:44:57Z","updated_at":"2018-02-15T15:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec645c69b5612c05c0a9082a0947bdf7c28da431","assignee":{"login":"michael-tims","id":5607251,"avatar_url":"https://avatars1.githubusercontent.com/u/5607251?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-tims","html_url":"https://github.com/michael-tims","followers_url":"https://api.github.com/users/michael-tims/followers","following_url":"https://api.github.com/users/michael-tims/following{/other_user}","gists_url":"https://api.github.com/users/michael-tims/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-tims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-tims/subscriptions","organizations_url":"https://api.github.com/users/michael-tims/orgs","repos_url":"https://api.github.com/users/michael-tims/repos","events_url":"https://api.github.com/users/michael-tims/events{/privacy}","received_events_url":"https://api.github.com/users/michael-tims/received_events","type":"User","site_admin":false},"assignees":[{"login":"michael-tims","id":5607251,"avatar_url":"https://avatars1.githubusercontent.com/u/5607251?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-tims","html_url":"https://github.com/michael-tims","followers_url":"https://api.github.com/users/michael-tims/followers","following_url":"https://api.github.com/users/michael-tims/following{/other_user}","gists_url":"https://api.github.com/users/michael-tims/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-tims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-tims/subscriptions","organizations_url":"https://api.github.com/users/michael-tims/orgs","repos_url":"https://api.github.com/users/michael-tims/repos","events_url":"https://api.github.com/users/michael-tims/events{/privacy}","received_events_url":"https://api.github.com/users/michael-tims/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"michael-tims","id":5607251,"avatar_url":"https://avatars1.githubusercontent.com/u/5607251?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-tims","html_url":"https://github.com/michael-tims","followers_url":"https://api.github.com/users/michael-tims/followers","following_url":"https://api.github.com/users/michael-tims/following{/other_user}","gists_url":"https://api.github.com/users/michael-tims/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-tims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-tims/subscriptions","organizations_url":"https://api.github.com/users/michael-tims/orgs","repos_url":"https://api.github.com/users/michael-tims/repos","events_url":"https://api.github.com/users/michael-tims/events{/privacy}","received_events_url":"https://api.github.com/users/michael-tims/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226/commits","review_comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226/comments","review_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/226/comments","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/statuses/e20cf235ed48cd1a54be93a8378242cf73e59d1a","head":{"label":"Esri:lsmallwood/remove_tools_when_destroyed","ref":"lsmallwood/remove_tools_when_destroyed","sha":"e20cf235ed48cd1a54be93a8378242cf73e59d1a","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":23629913,"name":"arcgis-runtime-toolkit-qt","full_name":"Esri/arcgis-runtime-toolkit-qt","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt","description":"ArcGIS Runtime SDK for Qt Toolkit","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/deployments","created_at":"2014-09-03T17:20:12Z","updated_at":"2018-02-15T10:00:15Z","pushed_at":"2018-02-15T14:53:54Z","git_url":"git://github.com/Esri/arcgis-runtime-toolkit-qt.git","ssh_url":"git@github.com:Esri/arcgis-runtime-toolkit-qt.git","clone_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt.git","svn_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt","homepage":"","size":1240,"stargazers_count":31,"watchers_count":31,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":2,"watchers":31,"default_branch":"master"}},"base":{"label":"Esri:v.next","ref":"v.next","sha":"8f5056d1c04a6f159868d7adaaf20d0482f621bb","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":23629913,"name":"arcgis-runtime-toolkit-qt","full_name":"Esri/arcgis-runtime-toolkit-qt","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt","description":"ArcGIS Runtime SDK for Qt Toolkit","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/deployments","created_at":"2014-09-03T17:20:12Z","updated_at":"2018-02-15T10:00:15Z","pushed_at":"2018-02-15T14:53:54Z","git_url":"git://github.com/Esri/arcgis-runtime-toolkit-qt.git","ssh_url":"git@github.com:Esri/arcgis-runtime-toolkit-qt.git","clone_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt.git","svn_url":"https://github.com/Esri/arcgis-runtime-toolkit-qt","homepage":"","size":1240,"stargazers_count":31,"watchers_count":31,"language":"QML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":22,"open_issues":2,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226"},"html":{"href":"https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/226"},"issue":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/226"},"comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-toolkit-qt/statuses/e20cf235ed48cd1a54be93a8378242cf73e59d1a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ldanzinger"}}