{"action":"created","comment":{"url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/comments/239544020","pull_request_review_id":182355300,"id":239544020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTU0NDAyMA==","diff_hunk":"@@ -0,0 +1,197 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import ClayCriteriaGroup from './ClayCriteriaGroup.es';\n+import ClayButton from './ClayButton.es';\n+\n+class ClayCriteriaBuilder extends React.Component {\n+\tconstructor(props) {\n+\t\tsuper(props);\n+\n+\t\tthis.state = {\n+\t\t\tediting: false,\n+\t\t\tinitialCriteria: this.props.criteria","path":"modules/apps/segments/segments-web/src/main/resources/META-INF/resources/js/ClayCriteriaBuilder.es.js","position":12,"original_position":12,"commit_id":"89d5a606121cd65872247993d67cf1a3f272388f","original_commit_id":"89d5a606121cd65872247993d67cf1a3f272388f","user":{"login":"bryceosterhaus","id":6843530,"node_id":"MDQ6VXNlcjY4NDM1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6843530?v=4","gravatar_id":"","url":"https://api.github.com/users/bryceosterhaus","html_url":"https://github.com/bryceosterhaus","followers_url":"https://api.github.com/users/bryceosterhaus/followers","following_url":"https://api.github.com/users/bryceosterhaus/following{/other_user}","gists_url":"https://api.github.com/users/bryceosterhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/bryceosterhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryceosterhaus/subscriptions","organizations_url":"https://api.github.com/users/bryceosterhaus/orgs","repos_url":"https://api.github.com/users/bryceosterhaus/repos","events_url":"https://api.github.com/users/bryceosterhaus/events{/privacy}","received_events_url":"https://api.github.com/users/bryceosterhaus/received_events","type":"User","site_admin":false},"body":"Is this supposed to be used? Or is criteria supposed to be state and props is initialCriteria?","created_at":"2018-12-06T17:30:55Z","updated_at":"2018-12-06T17:38:22Z","html_url":"https://github.com/bryceosterhaus/liferay-portal/pull/6#discussion_r239544020","pull_request_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/comments/239544020"},"html":{"href":"https://github.com/bryceosterhaus/liferay-portal/pull/6#discussion_r239544020"},"pull_request":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6","id":236364103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzY0MTAz","html_url":"https://github.com/bryceosterhaus/liferay-portal/pull/6","diff_url":"https://github.com/bryceosterhaus/liferay-portal/pull/6.diff","patch_url":"https://github.com/bryceosterhaus/liferay-portal/pull/6.patch","issue_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues/6","number":6,"state":"open","locked":false,"title":"LPS-87016 Criteria builder review changes","user":{"login":"thektan","id":4496722,"node_id":"MDQ6VXNlcjQ0OTY3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/4496722?v=4","gravatar_id":"","url":"https://api.github.com/users/thektan","html_url":"https://github.com/thektan","followers_url":"https://api.github.com/users/thektan/followers","following_url":"https://api.github.com/users/thektan/following{/other_user}","gists_url":"https://api.github.com/users/thektan/gists{/gist_id}","starred_url":"https://api.github.com/users/thektan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thektan/subscriptions","organizations_url":"https://api.github.com/users/thektan/orgs","repos_url":"https://api.github.com/users/thektan/repos","events_url":"https://api.github.com/users/thektan/events{/privacy}","received_events_url":"https://api.github.com/users/thektan/received_events","type":"User","site_admin":false},"body":"https://issues.liferay.com/browse/LPS-87016\r\n\r\nMade the changes requested on https://github.com/bryceosterhaus/liferay-portal/pull/5.\r\n\r\n89d5a60","created_at":"2018-12-05T23:58:20Z","updated_at":"2018-12-06T17:38:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23d0db035986c682632d537114d9b0cd92685884","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6/commits","review_comments_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6/comments","review_comment_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues/6/comments","statuses_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/statuses/89d5a606121cd65872247993d67cf1a3f272388f","head":{"label":"thektan:LPS-87016-criteria-builder-2","ref":"LPS-87016-criteria-builder-2","sha":"89d5a606121cd65872247993d67cf1a3f272388f","user":{"login":"thektan","id":4496722,"node_id":"MDQ6VXNlcjQ0OTY3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/4496722?v=4","gravatar_id":"","url":"https://api.github.com/users/thektan","html_url":"https://github.com/thektan","followers_url":"https://api.github.com/users/thektan/followers","following_url":"https://api.github.com/users/thektan/following{/other_user}","gists_url":"https://api.github.com/users/thektan/gists{/gist_id}","starred_url":"https://api.github.com/users/thektan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thektan/subscriptions","organizations_url":"https://api.github.com/users/thektan/orgs","repos_url":"https://api.github.com/users/thektan/repos","events_url":"https://api.github.com/users/thektan/events{/privacy}","received_events_url":"https://api.github.com/users/thektan/received_events","type":"User","site_admin":false},"repo":{"id":43705364,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcwNTM2NA==","name":"liferay-portal","full_name":"thektan/liferay-portal","private":false,"owner":{"login":"thektan","id":4496722,"node_id":"MDQ6VXNlcjQ0OTY3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/4496722?v=4","gravatar_id":"","url":"https://api.github.com/users/thektan","html_url":"https://github.com/thektan","followers_url":"https://api.github.com/users/thektan/followers","following_url":"https://api.github.com/users/thektan/following{/other_user}","gists_url":"https://api.github.com/users/thektan/gists{/gist_id}","starred_url":"https://api.github.com/users/thektan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thektan/subscriptions","organizations_url":"https://api.github.com/users/thektan/orgs","repos_url":"https://api.github.com/users/thektan/repos","events_url":"https://api.github.com/users/thektan/events{/privacy}","received_events_url":"https://api.github.com/users/thektan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thektan/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/thektan/liferay-portal","forks_url":"https://api.github.com/repos/thektan/liferay-portal/forks","keys_url":"https://api.github.com/repos/thektan/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thektan/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thektan/liferay-portal/teams","hooks_url":"https://api.github.com/repos/thektan/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/thektan/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/thektan/liferay-portal/events","assignees_url":"https://api.github.com/repos/thektan/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/thektan/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/thektan/liferay-portal/tags","blobs_url":"https://api.github.com/repos/thektan/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thektan/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thektan/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/thektan/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thektan/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/thektan/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/thektan/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/thektan/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/thektan/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/thektan/liferay-portal/subscription","commits_url":"https://api.github.com/repos/thektan/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/thektan/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/thektan/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/thektan/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/thektan/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/thektan/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thektan/liferay-portal/merges","archive_url":"https://api.github.com/repos/thektan/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thektan/liferay-portal/downloads","issues_url":"https://api.github.com/repos/thektan/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/thektan/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/thektan/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/thektan/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thektan/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/thektan/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/thektan/liferay-portal/deployments","created_at":"2015-10-05T18:34:40Z","updated_at":"2018-11-29T15:28:39Z","pushed_at":"2018-12-05T23:55:29Z","git_url":"git://github.com/thektan/liferay-portal.git","ssh_url":"git@github.com:thektan/liferay-portal.git","clone_url":"https://github.com/thektan/liferay-portal.git","svn_url":"https://github.com/thektan/liferay-portal","homepage":"http://liferay.com","size":12499227,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bryceosterhaus:master","ref":"master","sha":"99355c2c2c7f03fdd0c15bd2ab3d79dc029d1814","user":{"login":"bryceosterhaus","id":6843530,"node_id":"MDQ6VXNlcjY4NDM1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6843530?v=4","gravatar_id":"","url":"https://api.github.com/users/bryceosterhaus","html_url":"https://github.com/bryceosterhaus","followers_url":"https://api.github.com/users/bryceosterhaus/followers","following_url":"https://api.github.com/users/bryceosterhaus/following{/other_user}","gists_url":"https://api.github.com/users/bryceosterhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/bryceosterhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryceosterhaus/subscriptions","organizations_url":"https://api.github.com/users/bryceosterhaus/orgs","repos_url":"https://api.github.com/users/bryceosterhaus/repos","events_url":"https://api.github.com/users/bryceosterhaus/events{/privacy}","received_events_url":"https://api.github.com/users/bryceosterhaus/received_events","type":"User","site_admin":false},"repo":{"id":17379203,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3OTIwMw==","name":"liferay-portal","full_name":"bryceosterhaus/liferay-portal","private":false,"owner":{"login":"bryceosterhaus","id":6843530,"node_id":"MDQ6VXNlcjY4NDM1MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6843530?v=4","gravatar_id":"","url":"https://api.github.com/users/bryceosterhaus","html_url":"https://github.com/bryceosterhaus","followers_url":"https://api.github.com/users/bryceosterhaus/followers","following_url":"https://api.github.com/users/bryceosterhaus/following{/other_user}","gists_url":"https://api.github.com/users/bryceosterhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/bryceosterhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryceosterhaus/subscriptions","organizations_url":"https://api.github.com/users/bryceosterhaus/orgs","repos_url":"https://api.github.com/users/bryceosterhaus/repos","events_url":"https://api.github.com/users/bryceosterhaus/events{/privacy}","received_events_url":"https://api.github.com/users/bryceosterhaus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bryceosterhaus/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/bryceosterhaus/liferay-portal","forks_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/forks","keys_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/teams","hooks_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/events","assignees_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/tags","blobs_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/subscription","commits_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/merges","archive_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/downloads","issues_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/bryceosterhaus/liferay-portal/deployments","created_at":"2014-03-03T20:34:50Z","updated_at":"2018-12-05T19:47:53Z","pushed_at":"2018-12-05T23:58:21Z","git_url":"git://github.com/bryceosterhaus/liferay-portal.git","ssh_url":"git@github.com:bryceosterhaus/liferay-portal.git","clone_url":"https://github.com/bryceosterhaus/liferay-portal.git","svn_url":"https://github.com/bryceosterhaus/liferay-portal","homepage":"http://liferay.com","size":12447863,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6"},"html":{"href":"https://github.com/bryceosterhaus/liferay-portal/pull/6"},"issue":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues/6"},"comments":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/bryceosterhaus/liferay-portal/statuses/89d5a606121cd65872247993d67cf1a3f272388f"}},"author_association":"NONE"}}
{"actor":{"display_login":"bryceosterhaus"}}