{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/msmbuilder/vde/pulls/10","id":187685150,"html_url":"https://github.com/msmbuilder/vde/pull/10","diff_url":"https://github.com/msmbuilder/vde/pull/10.diff","patch_url":"https://github.com/msmbuilder/vde/pull/10.patch","issue_url":"https://api.github.com/repos/msmbuilder/vde/issues/10","number":10,"state":"closed","locked":false,"title":"added valueerror to layer function","user":{"login":"brookehus","id":5394426,"avatar_url":"https://avatars3.githubusercontent.com/u/5394426?v=4","gravatar_id":"","url":"https://api.github.com/users/brookehus","html_url":"https://github.com/brookehus","followers_url":"https://api.github.com/users/brookehus/followers","following_url":"https://api.github.com/users/brookehus/following{/other_user}","gists_url":"https://api.github.com/users/brookehus/gists{/gist_id}","starred_url":"https://api.github.com/users/brookehus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brookehus/subscriptions","organizations_url":"https://api.github.com/users/brookehus/orgs","repos_url":"https://api.github.com/users/brookehus/repos","events_url":"https://api.github.com/users/brookehus/events{/privacy}","received_events_url":"https://api.github.com/users/brookehus/received_events","type":"User","site_admin":false},"body":"I think the design of the `Layer` function is a bit dangerous. If it doesn't recognize the activation string, it just outputs a linear model. This is especially scary given that it only recognizes `RELU` and not `ReLU`, where the latter has the pytorch case convention.\r\n\r\nI've just added a simple error here that if the activation is a string but not in the list, at least the user knows about it. A nice option might be to make everything case insensitive.","created_at":"2018-05-13T19:05:49Z","updated_at":"2018-05-13T19:40:40Z","closed_at":"2018-05-13T19:40:40Z","merged_at":"2018-05-13T19:40:40Z","merge_commit_sha":"51a8240402cbff8ed3f3362aa4577672ff2b5af1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cxhernandez","id":5142365,"avatar_url":"https://avatars2.githubusercontent.com/u/5142365?v=4","gravatar_id":"","url":"https://api.github.com/users/cxhernandez","html_url":"https://github.com/cxhernandez","followers_url":"https://api.github.com/users/cxhernandez/followers","following_url":"https://api.github.com/users/cxhernandez/following{/other_user}","gists_url":"https://api.github.com/users/cxhernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/cxhernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxhernandez/subscriptions","organizations_url":"https://api.github.com/users/cxhernandez/orgs","repos_url":"https://api.github.com/users/cxhernandez/repos","events_url":"https://api.github.com/users/cxhernandez/events{/privacy}","received_events_url":"https://api.github.com/users/cxhernandez/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/msmbuilder/vde/pulls/10/commits","review_comments_url":"https://api.github.com/repos/msmbuilder/vde/pulls/10/comments","review_comment_url":"https://api.github.com/repos/msmbuilder/vde/pulls/comments{/number}","comments_url":"https://api.github.com/repos/msmbuilder/vde/issues/10/comments","statuses_url":"https://api.github.com/repos/msmbuilder/vde/statuses/d22379c7f75643d53a82556c241830bab6e9b21b","head":{"label":"brookehus:relu-fix","ref":"relu-fix","sha":"d22379c7f75643d53a82556c241830bab6e9b21b","user":{"login":"brookehus","id":5394426,"avatar_url":"https://avatars3.githubusercontent.com/u/5394426?v=4","gravatar_id":"","url":"https://api.github.com/users/brookehus","html_url":"https://github.com/brookehus","followers_url":"https://api.github.com/users/brookehus/followers","following_url":"https://api.github.com/users/brookehus/following{/other_user}","gists_url":"https://api.github.com/users/brookehus/gists{/gist_id}","starred_url":"https://api.github.com/users/brookehus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brookehus/subscriptions","organizations_url":"https://api.github.com/users/brookehus/orgs","repos_url":"https://api.github.com/users/brookehus/repos","events_url":"https://api.github.com/users/brookehus/events{/privacy}","received_events_url":"https://api.github.com/users/brookehus/received_events","type":"User","site_admin":false},"repo":{"id":133263801,"name":"vde","full_name":"brookehus/vde","owner":{"login":"brookehus","id":5394426,"avatar_url":"https://avatars3.githubusercontent.com/u/5394426?v=4","gravatar_id":"","url":"https://api.github.com/users/brookehus","html_url":"https://github.com/brookehus","followers_url":"https://api.github.com/users/brookehus/followers","following_url":"https://api.github.com/users/brookehus/following{/other_user}","gists_url":"https://api.github.com/users/brookehus/gists{/gist_id}","starred_url":"https://api.github.com/users/brookehus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brookehus/subscriptions","organizations_url":"https://api.github.com/users/brookehus/orgs","repos_url":"https://api.github.com/users/brookehus/repos","events_url":"https://api.github.com/users/brookehus/events{/privacy}","received_events_url":"https://api.github.com/users/brookehus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brookehus/vde","description":"Variational Autoencoder for Dimensionality Reduction of Time-Series","fork":true,"url":"https://api.github.com/repos/brookehus/vde","forks_url":"https://api.github.com/repos/brookehus/vde/forks","keys_url":"https://api.github.com/repos/brookehus/vde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brookehus/vde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brookehus/vde/teams","hooks_url":"https://api.github.com/repos/brookehus/vde/hooks","issue_events_url":"https://api.github.com/repos/brookehus/vde/issues/events{/number}","events_url":"https://api.github.com/repos/brookehus/vde/events","assignees_url":"https://api.github.com/repos/brookehus/vde/assignees{/user}","branches_url":"https://api.github.com/repos/brookehus/vde/branches{/branch}","tags_url":"https://api.github.com/repos/brookehus/vde/tags","blobs_url":"https://api.github.com/repos/brookehus/vde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brookehus/vde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brookehus/vde/git/refs{/sha}","trees_url":"https://api.github.com/repos/brookehus/vde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brookehus/vde/statuses/{sha}","languages_url":"https://api.github.com/repos/brookehus/vde/languages","stargazers_url":"https://api.github.com/repos/brookehus/vde/stargazers","contributors_url":"https://api.github.com/repos/brookehus/vde/contributors","subscribers_url":"https://api.github.com/repos/brookehus/vde/subscribers","subscription_url":"https://api.github.com/repos/brookehus/vde/subscription","commits_url":"https://api.github.com/repos/brookehus/vde/commits{/sha}","git_commits_url":"https://api.github.com/repos/brookehus/vde/git/commits{/sha}","comments_url":"https://api.github.com/repos/brookehus/vde/comments{/number}","issue_comment_url":"https://api.github.com/repos/brookehus/vde/issues/comments{/number}","contents_url":"https://api.github.com/repos/brookehus/vde/contents/{+path}","compare_url":"https://api.github.com/repos/brookehus/vde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brookehus/vde/merges","archive_url":"https://api.github.com/repos/brookehus/vde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brookehus/vde/downloads","issues_url":"https://api.github.com/repos/brookehus/vde/issues{/number}","pulls_url":"https://api.github.com/repos/brookehus/vde/pulls{/number}","milestones_url":"https://api.github.com/repos/brookehus/vde/milestones{/number}","notifications_url":"https://api.github.com/repos/brookehus/vde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brookehus/vde/labels{/name}","releases_url":"https://api.github.com/repos/brookehus/vde/releases{/id}","deployments_url":"https://api.github.com/repos/brookehus/vde/deployments","created_at":"2018-05-13T18:28:27Z","updated_at":"2018-05-13T18:28:29Z","pushed_at":"2018-05-13T19:03:55Z","git_url":"git://github.com/brookehus/vde.git","ssh_url":"git@github.com:brookehus/vde.git","clone_url":"https://github.com/brookehus/vde.git","svn_url":"https://github.com/brookehus/vde","homepage":"","size":401,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"msmbuilder:master","ref":"master","sha":"40fc9ec310cc192ed33a5fc2decacbd3987bba56","user":{"login":"msmbuilder","id":10036752,"avatar_url":"https://avatars0.githubusercontent.com/u/10036752?v=4","gravatar_id":"","url":"https://api.github.com/users/msmbuilder","html_url":"https://github.com/msmbuilder","followers_url":"https://api.github.com/users/msmbuilder/followers","following_url":"https://api.github.com/users/msmbuilder/following{/other_user}","gists_url":"https://api.github.com/users/msmbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/msmbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmbuilder/subscriptions","organizations_url":"https://api.github.com/users/msmbuilder/orgs","repos_url":"https://api.github.com/users/msmbuilder/repos","events_url":"https://api.github.com/users/msmbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/msmbuilder/received_events","type":"Organization","site_admin":false},"repo":{"id":111886657,"name":"vde","full_name":"msmbuilder/vde","owner":{"login":"msmbuilder","id":10036752,"avatar_url":"https://avatars0.githubusercontent.com/u/10036752?v=4","gravatar_id":"","url":"https://api.github.com/users/msmbuilder","html_url":"https://github.com/msmbuilder","followers_url":"https://api.github.com/users/msmbuilder/followers","following_url":"https://api.github.com/users/msmbuilder/following{/other_user}","gists_url":"https://api.github.com/users/msmbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/msmbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmbuilder/subscriptions","organizations_url":"https://api.github.com/users/msmbuilder/orgs","repos_url":"https://api.github.com/users/msmbuilder/repos","events_url":"https://api.github.com/users/msmbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/msmbuilder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msmbuilder/vde","description":"Variational Autoencoder for Dimensionality Reduction of Time-Series","fork":false,"url":"https://api.github.com/repos/msmbuilder/vde","forks_url":"https://api.github.com/repos/msmbuilder/vde/forks","keys_url":"https://api.github.com/repos/msmbuilder/vde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msmbuilder/vde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msmbuilder/vde/teams","hooks_url":"https://api.github.com/repos/msmbuilder/vde/hooks","issue_events_url":"https://api.github.com/repos/msmbuilder/vde/issues/events{/number}","events_url":"https://api.github.com/repos/msmbuilder/vde/events","assignees_url":"https://api.github.com/repos/msmbuilder/vde/assignees{/user}","branches_url":"https://api.github.com/repos/msmbuilder/vde/branches{/branch}","tags_url":"https://api.github.com/repos/msmbuilder/vde/tags","blobs_url":"https://api.github.com/repos/msmbuilder/vde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msmbuilder/vde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msmbuilder/vde/git/refs{/sha}","trees_url":"https://api.github.com/repos/msmbuilder/vde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msmbuilder/vde/statuses/{sha}","languages_url":"https://api.github.com/repos/msmbuilder/vde/languages","stargazers_url":"https://api.github.com/repos/msmbuilder/vde/stargazers","contributors_url":"https://api.github.com/repos/msmbuilder/vde/contributors","subscribers_url":"https://api.github.com/repos/msmbuilder/vde/subscribers","subscription_url":"https://api.github.com/repos/msmbuilder/vde/subscription","commits_url":"https://api.github.com/repos/msmbuilder/vde/commits{/sha}","git_commits_url":"https://api.github.com/repos/msmbuilder/vde/git/commits{/sha}","comments_url":"https://api.github.com/repos/msmbuilder/vde/comments{/number}","issue_comment_url":"https://api.github.com/repos/msmbuilder/vde/issues/comments{/number}","contents_url":"https://api.github.com/repos/msmbuilder/vde/contents/{+path}","compare_url":"https://api.github.com/repos/msmbuilder/vde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msmbuilder/vde/merges","archive_url":"https://api.github.com/repos/msmbuilder/vde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msmbuilder/vde/downloads","issues_url":"https://api.github.com/repos/msmbuilder/vde/issues{/number}","pulls_url":"https://api.github.com/repos/msmbuilder/vde/pulls{/number}","milestones_url":"https://api.github.com/repos/msmbuilder/vde/milestones{/number}","notifications_url":"https://api.github.com/repos/msmbuilder/vde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msmbuilder/vde/labels{/name}","releases_url":"https://api.github.com/repos/msmbuilder/vde/releases{/id}","deployments_url":"https://api.github.com/repos/msmbuilder/vde/deployments","created_at":"2017-11-24T07:00:25Z","updated_at":"2018-05-08T17:02:11Z","pushed_at":"2018-05-13T19:40:40Z","git_url":"git://github.com/msmbuilder/vde.git","ssh_url":"git@github.com:msmbuilder/vde.git","clone_url":"https://github.com/msmbuilder/vde.git","svn_url":"https://github.com/msmbuilder/vde","homepage":"","size":401,"stargazers_count":32,"watchers_count":32,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15,"open_issues":2,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/msmbuilder/vde/pulls/10"},"html":{"href":"https://github.com/msmbuilder/vde/pull/10"},"issue":{"href":"https://api.github.com/repos/msmbuilder/vde/issues/10"},"comments":{"href":"https://api.github.com/repos/msmbuilder/vde/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/msmbuilder/vde/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/msmbuilder/vde/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/msmbuilder/vde/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/msmbuilder/vde/statuses/d22379c7f75643d53a82556c241830bab6e9b21b"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cxhernandez","id":5142365,"avatar_url":"https://avatars2.githubusercontent.com/u/5142365?v=4","gravatar_id":"","url":"https://api.github.com/users/cxhernandez","html_url":"https://github.com/cxhernandez","followers_url":"https://api.github.com/users/cxhernandez/followers","following_url":"https://api.github.com/users/cxhernandez/following{/other_user}","gists_url":"https://api.github.com/users/cxhernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/cxhernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxhernandez/subscriptions","organizations_url":"https://api.github.com/users/cxhernandez/orgs","repos_url":"https://api.github.com/users/cxhernandez/repos","events_url":"https://api.github.com/users/cxhernandez/events{/privacy}","received_events_url":"https://api.github.com/users/cxhernandez/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"cxhernandez"}}