{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/4159","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/4159/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/4159/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/4159/events","html_url":"https://github.com/openssl/openssl/pull/4159","id":250135320,"number":4159,"title":"WIP: openssl/rand.h: fix formatting.","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/9","html_url":"https://github.com/openssl/openssl/milestone/9","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/9/labels","id":2145708,"number":9,"title":"1.1.1","description":"","creator":{"login":"levitte","id":698918,"avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"open_issues":203,"closed_issues":96,"state":"open","created_at":"2016-11-19T09:18:52Z","updated_at":"2018-03-21T11:56:47Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2017-08-14T19:52:15Z","updated_at":"2018-03-21T12:06:18Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/4159","html_url":"https://github.com/openssl/openssl/pull/4159","diff_url":"https://github.com/openssl/openssl/pull/4159.diff","patch_url":"https://github.com/openssl/openssl/pull/4159.patch"},"body":"This is not for approval yet. For the moment it's just a mark that something needs to done about __NDK_FPABI__ even in RAND_poll_ex context. For reference, it won't be sufficient to modify just header. For the moment it's just formatting thing, but since there will be other occurrence[s], it might be appropriate to simplify it to something like this:\r\n```\r\n#ifndef __NDK_FPABI__\r\n# define __NDK_FPABI__\r\n#endif\r\n\r\n__NDK_FPABI__ void RAND_add(const void *buf, int num, double randomness);\r\n```\r\nThought?\r\n\r\nFor reference. What's __NDK_FPABI__? It's Android thing, and it's a way to make library agnostic to application FP calling convention. In more practical terms you can compile application code with either -mfloat-abi=soft or -mfloat-abi=hard, and still use same library. Android system libraries are like that..."},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/374915210","html_url":"https://github.com/openssl/openssl/pull/4159#issuecomment-374915210","issue_url":"https://api.github.com/repos/openssl/openssl/issues/4159","id":374915210,"user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T12:06:18Z","updated_at":"2018-03-21T12:06:18Z","author_association":"OWNER","body":"> What is the status of this?\r\n\r\nIn my view patch as it stand here is 110% appropriate, because it denotes the specific and special relation of the function and modifier. Now, there is remaining question about what to do about RAND_poll_cb. Suggestion was to get rid of double, but we couldn't agree on what would be appropriate granularity. One can also choose to give same treatment to RAND_poll_cb as to RAND_add, i.e. declare it as `__NDK_FPABI__`. Why is it interesting to do so? Because without modified declaration it would be tricky for application and library to interoperate if there are compiled separately. Multiple people would have to get small details right. **HOWEVER!** Now when I look at it I don't see that RAND_poll_cb is used anywhere. So it looks like it can be removed. And if it can, then it definitely should..."}}
{"actor":{"display_login":"dot-asm"}}