{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/219354737","pull_request_review_id":157511072,"id":219354737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTM1NDczNw==","diff_hunk":"@@ -173,6 +190,49 @@ internal LbfgsTrainerBase(ArgumentsBase args, IHostEnvironment env, string name,\n                     ch.Done();\n                 }\n             }\n+            _srcPredictor = default;\n+        }\n+\n+        internal LbfgsTrainerBase(IHostEnvironment env, TArgs args)","path":"src/Microsoft.ML.StandardLearners/Standard/LogisticRegression/LbfgsPredictorBase.cs","position":null,"original_position":139,"commit_id":"6b9791e7fb1dc727e2888819a33463e7be3ae331","original_commit_id":"95f666a5d11f8fbcf784a011cdfcbe8c2cb6f571","user":{"login":"zeahmed","id":38438266,"node_id":"MDQ6VXNlcjM4NDM4MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/38438266?v=4","gravatar_id":"","url":"https://api.github.com/users/zeahmed","html_url":"https://github.com/zeahmed","followers_url":"https://api.github.com/users/zeahmed/followers","following_url":"https://api.github.com/users/zeahmed/following{/other_user}","gists_url":"https://api.github.com/users/zeahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/zeahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeahmed/subscriptions","organizations_url":"https://api.github.com/users/zeahmed/orgs","repos_url":"https://api.github.com/users/zeahmed/repos","events_url":"https://api.github.com/users/zeahmed/events{/privacy}","received_events_url":"https://api.github.com/users/zeahmed/received_events","type":"User","site_admin":false},"body":">LbfgsTrainerBase [](start = 17, length = 16)\r\n\r\nI think you can this constructor from the other one to get ride to code redundancy.","created_at":"2018-09-21T00:19:18Z","updated_at":"2018-09-21T00:19:18Z","html_url":"https://github.com/dotnet/machinelearning/pull/957#discussion_r219354737","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/957","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/219354737"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/957#discussion_r219354737"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/957"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/957","id":216799143,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Nzk5MTQz","html_url":"https://github.com/dotnet/machinelearning/pull/957","diff_url":"https://github.com/dotnet/machinelearning/pull/957.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/957.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/957","number":957,"state":"open","locked":false,"title":"WIP: Conversion of Logistic, Multiclass Logistic, and Poisson Regression to estimators","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"body":"Fixes #956.\r\n\r\nConversion of Logistic, Multiclass Logistic, and Poisson Regression to estimators by deriving the base class LbfgsTrainerBase from TrainerEstimatorBase.\r\n\r\nWorking on testing the converted classes using TestEstimatorCore. ","created_at":"2018-09-19T22:50:10Z","updated_at":"2018-09-21T00:19:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db6c7a15ad375fc37081190b492938182b10eeef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":923215346,"node_id":"MDU6TGFiZWw5MjMyMTUzNDY=","url":"https://api.github.com/repos/dotnet/machinelearning/labels/api","name":"api","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/957/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/957/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/957/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/6b9791e7fb1dc727e2888819a33463e7be3ae331","head":{"label":"artidoro:lrandmultilr","ref":"lrandmultilr","sha":"6b9791e7fb1dc727e2888819a33463e7be3ae331","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"repo":{"id":146929905,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5Mjk5MDU=","name":"machinelearning","full_name":"artidoro/machinelearning","private":false,"owner":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/artidoro/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/artidoro/machinelearning","forks_url":"https://api.github.com/repos/artidoro/machinelearning/forks","keys_url":"https://api.github.com/repos/artidoro/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artidoro/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artidoro/machinelearning/teams","hooks_url":"https://api.github.com/repos/artidoro/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/artidoro/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/artidoro/machinelearning/events","assignees_url":"https://api.github.com/repos/artidoro/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/artidoro/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/artidoro/machinelearning/tags","blobs_url":"https://api.github.com/repos/artidoro/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artidoro/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artidoro/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/artidoro/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artidoro/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/artidoro/machinelearning/languages","stargazers_url":"https://api.github.com/repos/artidoro/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/artidoro/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/artidoro/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/artidoro/machinelearning/subscription","commits_url":"https://api.github.com/repos/artidoro/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/artidoro/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/artidoro/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/artidoro/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/artidoro/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/artidoro/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artidoro/machinelearning/merges","archive_url":"https://api.github.com/repos/artidoro/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artidoro/machinelearning/downloads","issues_url":"https://api.github.com/repos/artidoro/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/artidoro/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/artidoro/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/artidoro/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artidoro/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/artidoro/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/artidoro/machinelearning/deployments","created_at":"2018-08-31T18:37:49Z","updated_at":"2018-09-18T20:31:54Z","pushed_at":"2018-09-21T00:13:32Z","git_url":"git://github.com/artidoro/machinelearning.git","ssh_url":"git@github.com:artidoro/machinelearning.git","clone_url":"https://github.com/artidoro/machinelearning.git","svn_url":"https://github.com/artidoro/machinelearning","homepage":"https://dot.net/ml","size":22952,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"6812cb565ebaa522685571103a4e441ee908dbb0","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-09-20T23:02:29Z","pushed_at":"2018-09-21T00:13:34Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":22762,"stargazers_count":3654,"watchers_count":3654,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":588,"mirror_url":null,"archived":false,"open_issues_count":313,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":588,"open_issues":313,"watchers":3654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/957"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/957"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/957"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/957/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/957/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/957/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/6b9791e7fb1dc727e2888819a33463e7be3ae331"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zeahmed"}}