{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2645","repository_url":"https://api.github.com/repos/flutter/flutter-intellij","labels_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2645/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2645/comments","events_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2645/events","html_url":"https://github.com/flutter/flutter-intellij/pull/2645","id":365523150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDIzNzU0","number":2645,"title":"Perf inspector review","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"labels":[{"id":487496526,"node_id":"MDU6TGFiZWw0ODc0OTY1MjY=","url":"https://api.github.com/repos/flutter/flutter-intellij/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-01T15:43:24Z","updated_at":"2018-10-02T03:05:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flutter/flutter-intellij/pulls/2645","html_url":"https://github.com/flutter/flutter-intellij/pull/2645","diff_url":"https://github.com/flutter/flutter-intellij/pull/2645.diff","patch_url":"https://github.com/flutter/flutter-intellij/pull/2645.patch"},"body":"This code is loosely based on the coverage tracking work and only exposed if a checkbox in flutter settings is set. The first patch in the CL is just renames followed by a main commit to change the functionality. Over time I tweaked the functionality a lot so the diff for some files isn't useful and I recommend just reviewing the entire files.\r\n\r\nKey differences relative to the coverage tracking code:\r\n1. Uses animated icons and highlights ranges of text instead of rendering line markers\r\n2. Displays data for all visible files instead of just the single selected file to avoid confusion switching back and forth between open files.\r\n3. I did a little refactoring to make the code easier to write unit tests for.\r\n\r\nIf the experimental flag is set then the perf tools are enabled by selecting  the \"Track Widget Rebuilds\" and \"TrackWidgetRepaint\" checkboxes from the performance tab.\r\n<img width=\"481\" alt=\"screen shot 2018-10-01 at 8 39 27 am\" src=\"https://user-images.githubusercontent.com/1226812/46299240-c272de00-c555-11e8-8aef-f769bcb2e459.png\">\r\n\r\nHere is a screenshot of what the app looks like running. All visible tabs show the animations. CPU usage showing the running animations is around 30%.\r\n<img width=\"1044\" alt=\"screen shot 2018-10-01 at 8 39 48 am\" src=\"https://user-images.githubusercontent.com/1226812/46299156-9d7e6b00-c555-11e8-9273-77536f6295b2.png\">\r\n\r\nIf you click on a performance icon you get this view.\r\n<img width=\"1305\" alt=\"screen shot 2018-10-01 at 8 42 50 am\" src=\"https://user-images.githubusercontent.com/1226812/46299365-0bc32d80-c556-11e8-8c9d-0acbefdf95d4.png\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/flutter/flutter-intellij/issues/comments/426132776","html_url":"https://github.com/flutter/flutter-intellij/pull/2645#issuecomment-426132776","issue_url":"https://api.github.com/repos/flutter/flutter-intellij/issues/2645","id":426132776,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjEzMjc3Ng==","user":{"login":"jacob314","id":1226812,"node_id":"MDQ6VXNlcjEyMjY4MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1226812?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob314","html_url":"https://github.com/jacob314","followers_url":"https://api.github.com/users/jacob314/followers","following_url":"https://api.github.com/users/jacob314/following{/other_user}","gists_url":"https://api.github.com/users/jacob314/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob314/subscriptions","organizations_url":"https://api.github.com/users/jacob314/orgs","repos_url":"https://api.github.com/users/jacob314/repos","events_url":"https://api.github.com/users/jacob314/events{/privacy}","received_events_url":"https://api.github.com/users/jacob314/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T03:05:34Z","updated_at":"2018-10-02T03:05:34Z","author_association":"CONTRIBUTOR","body":"PTAL"}}
{"actor":{"display_login":"jacob314"}}