{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/comments/211686726","pull_request_review_id":148161485,"id":211686726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY4NjcyNg==","diff_hunk":"@@ -34,7 +48,9 @@ namespace rosidl_typesupport_c\n \n std::string find_library_path(const std::string & library_name);\n \n+#if !defined(ROSIDL_TYPESUPPORT_C_NO_ENV)\n std::string get_env_var(const char * env_var);\n+#endif","path":"rosidl_typesupport_c/src/type_support_dispatch.hpp","position":27,"original_position":27,"commit_id":"14d16620a07519005189aadb80088dff9f73e735","original_commit_id":"14d16620a07519005189aadb80088dff9f73e735","user":{"login":"wjwwood","id":100427,"node_id":"MDQ6VXNlcjEwMDQyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/100427?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"It might be better to leave the API in place and just always return `\"\"`. It would be nice to have the same API on the library regardless of the ability to get env vars under the hood. Ultimately this should probably be using the `rcutils` function for getting the environment variables.","created_at":"2018-08-21T17:12:36Z","updated_at":"2018-08-21T17:12:36Z","html_url":"https://github.com/ros2/rosidl_typesupport/pull/31#discussion_r211686726","pull_request_url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/comments/211686726"},"html":{"href":"https://github.com/ros2/rosidl_typesupport/pull/31#discussion_r211686726"},"pull_request":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31","id":209348342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzQ4MzQy","html_url":"https://github.com/ros2/rosidl_typesupport/pull/31","diff_url":"https://github.com/ros2/rosidl_typesupport/pull/31.diff","patch_url":"https://github.com/ros2/rosidl_typesupport/pull/31.patch","issue_url":"https://api.github.com/repos/ros2/rosidl_typesupport/issues/31","number":31,"state":"open","locked":false,"title":"Disable access to environment variables for UWP and Android","user":{"login":"esteve","id":33620,"node_id":"MDQ6VXNlcjMzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/33620?v=4","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"body":"Neither Android or UWP apps can access environment variables, this PR just disables that logic if building for either platform.","created_at":"2018-08-19T08:06:24Z","updated_at":"2018-08-21T17:12:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69cdcf51889a40b2e8d85de5372fae56f7675a11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":483794596,"node_id":"MDU6TGFiZWw0ODM3OTQ1OTY=","url":"https://api.github.com/repos/ros2/rosidl_typesupport/labels/in%20progress","name":"in progress","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31/commits","review_comments_url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31/comments","review_comment_url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rosidl_typesupport/issues/31/comments","statuses_url":"https://api.github.com/repos/ros2/rosidl_typesupport/statuses/14d16620a07519005189aadb80088dff9f73e735","head":{"label":"esteve:uwp-noenv","ref":"uwp-noenv","sha":"14d16620a07519005189aadb80088dff9f73e735","user":{"login":"esteve","id":33620,"node_id":"MDQ6VXNlcjMzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/33620?v=4","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"repo":{"id":87553971,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU1Mzk3MQ==","name":"rosidl_typesupport","full_name":"esteve/rosidl_typesupport","owner":{"login":"esteve","id":33620,"node_id":"MDQ6VXNlcjMzNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/33620?v=4","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esteve/rosidl_typesupport","description":"Packages which provide the typesupport for ROS messages and services","fork":true,"url":"https://api.github.com/repos/esteve/rosidl_typesupport","forks_url":"https://api.github.com/repos/esteve/rosidl_typesupport/forks","keys_url":"https://api.github.com/repos/esteve/rosidl_typesupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esteve/rosidl_typesupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esteve/rosidl_typesupport/teams","hooks_url":"https://api.github.com/repos/esteve/rosidl_typesupport/hooks","issue_events_url":"https://api.github.com/repos/esteve/rosidl_typesupport/issues/events{/number}","events_url":"https://api.github.com/repos/esteve/rosidl_typesupport/events","assignees_url":"https://api.github.com/repos/esteve/rosidl_typesupport/assignees{/user}","branches_url":"https://api.github.com/repos/esteve/rosidl_typesupport/branches{/branch}","tags_url":"https://api.github.com/repos/esteve/rosidl_typesupport/tags","blobs_url":"https://api.github.com/repos/esteve/rosidl_typesupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esteve/rosidl_typesupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esteve/rosidl_typesupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/esteve/rosidl_typesupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esteve/rosidl_typesupport/statuses/{sha}","languages_url":"https://api.github.com/repos/esteve/rosidl_typesupport/languages","stargazers_url":"https://api.github.com/repos/esteve/rosidl_typesupport/stargazers","contributors_url":"https://api.github.com/repos/esteve/rosidl_typesupport/contributors","subscribers_url":"https://api.github.com/repos/esteve/rosidl_typesupport/subscribers","subscription_url":"https://api.github.com/repos/esteve/rosidl_typesupport/subscription","commits_url":"https://api.github.com/repos/esteve/rosidl_typesupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/esteve/rosidl_typesupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/esteve/rosidl_typesupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/esteve/rosidl_typesupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/esteve/rosidl_typesupport/contents/{+path}","compare_url":"https://api.github.com/repos/esteve/rosidl_typesupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esteve/rosidl_typesupport/merges","archive_url":"https://api.github.com/repos/esteve/rosidl_typesupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esteve/rosidl_typesupport/downloads","issues_url":"https://api.github.com/repos/esteve/rosidl_typesupport/issues{/number}","pulls_url":"https://api.github.com/repos/esteve/rosidl_typesupport/pulls{/number}","milestones_url":"https://api.github.com/repos/esteve/rosidl_typesupport/milestones{/number}","notifications_url":"https://api.github.com/repos/esteve/rosidl_typesupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esteve/rosidl_typesupport/labels{/name}","releases_url":"https://api.github.com/repos/esteve/rosidl_typesupport/releases{/id}","deployments_url":"https://api.github.com/repos/esteve/rosidl_typesupport/deployments","created_at":"2017-04-07T14:18:39Z","updated_at":"2018-04-14T19:42:00Z","pushed_at":"2018-08-19T08:04:51Z","git_url":"git://github.com/esteve/rosidl_typesupport.git","ssh_url":"git@github.com:esteve/rosidl_typesupport.git","clone_url":"https://github.com/esteve/rosidl_typesupport.git","svn_url":"https://github.com/esteve/rosidl_typesupport","homepage":"","size":637,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"1c53fccaff3030a924e5d172cf2e7263d40ee770","user":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":73955492,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzk1NTQ5Mg==","name":"rosidl_typesupport","full_name":"ros2/rosidl_typesupport","owner":{"login":"ros2","id":3979232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzkyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/3979232?v=4","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rosidl_typesupport","description":"Packages which provide the typesupport for ROS messages and services","fork":false,"url":"https://api.github.com/repos/ros2/rosidl_typesupport","forks_url":"https://api.github.com/repos/ros2/rosidl_typesupport/forks","keys_url":"https://api.github.com/repos/ros2/rosidl_typesupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rosidl_typesupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rosidl_typesupport/teams","hooks_url":"https://api.github.com/repos/ros2/rosidl_typesupport/hooks","issue_events_url":"https://api.github.com/repos/ros2/rosidl_typesupport/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rosidl_typesupport/events","assignees_url":"https://api.github.com/repos/ros2/rosidl_typesupport/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rosidl_typesupport/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rosidl_typesupport/tags","blobs_url":"https://api.github.com/repos/ros2/rosidl_typesupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rosidl_typesupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rosidl_typesupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rosidl_typesupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rosidl_typesupport/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rosidl_typesupport/languages","stargazers_url":"https://api.github.com/repos/ros2/rosidl_typesupport/stargazers","contributors_url":"https://api.github.com/repos/ros2/rosidl_typesupport/contributors","subscribers_url":"https://api.github.com/repos/ros2/rosidl_typesupport/subscribers","subscription_url":"https://api.github.com/repos/ros2/rosidl_typesupport/subscription","commits_url":"https://api.github.com/repos/ros2/rosidl_typesupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rosidl_typesupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rosidl_typesupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rosidl_typesupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rosidl_typesupport/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rosidl_typesupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rosidl_typesupport/merges","archive_url":"https://api.github.com/repos/ros2/rosidl_typesupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rosidl_typesupport/downloads","issues_url":"https://api.github.com/repos/ros2/rosidl_typesupport/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rosidl_typesupport/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rosidl_typesupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rosidl_typesupport/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rosidl_typesupport/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/rosidl_typesupport/deployments","created_at":"2016-11-16T19:51:17Z","updated_at":"2018-08-16T21:02:55Z","pushed_at":"2018-08-19T08:06:24Z","git_url":"git://github.com/ros2/rosidl_typesupport.git","ssh_url":"git@github.com:ros2/rosidl_typesupport.git","clone_url":"https://github.com/ros2/rosidl_typesupport.git","svn_url":"https://github.com/ros2/rosidl_typesupport","homepage":"","size":632,"stargazers_count":2,"watchers_count":2,"language":"CMake","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31"},"html":{"href":"https://github.com/ros2/rosidl_typesupport/pull/31"},"issue":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/issues/31"},"comments":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rosidl_typesupport/statuses/14d16620a07519005189aadb80088dff9f73e735"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wjwwood"}}