{"action":"opened","number":241,"pull_request":{"url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/241","id":181722649,"html_url":"https://github.com/Microsoft/OpenAPI.NET/pull/241","diff_url":"https://github.com/Microsoft/OpenAPI.NET/pull/241.diff","patch_url":"https://github.com/Microsoft/OpenAPI.NET/pull/241.patch","issue_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/241","number":241,"state":"open","locked":false,"title":"Performance enhancements to validation and reference resolution","user":{"login":"darrelmiller","id":447694,"avatar_url":"https://avatars2.githubusercontent.com/u/447694?v=4","gravatar_id":"","url":"https://api.github.com/users/darrelmiller","html_url":"https://github.com/darrelmiller","followers_url":"https://api.github.com/users/darrelmiller/followers","following_url":"https://api.github.com/users/darrelmiller/following{/other_user}","gists_url":"https://api.github.com/users/darrelmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/darrelmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrelmiller/subscriptions","organizations_url":"https://api.github.com/users/darrelmiller/orgs","repos_url":"https://api.github.com/users/darrelmiller/repos","events_url":"https://api.github.com/users/darrelmiller/events{/privacy}","received_events_url":"https://api.github.com/users/darrelmiller/received_events","type":"User","site_admin":false},"body":"The primary problem resolved in this PR is the walker, which is used for both reference resolution and validation, was walking objects multiple times when they were $ref'd.  This has been resolved in the OpenApiWalker by adding a guard that does not walk the object if it has a non-null Reference and we are currently not walking through the Components section.\r\n\r\nFor the large 30MB, million line MS Graph OpenAPI, the time has gone from > 20mins, to ~ 10 secs on my Surface Pro 4.\r\n\r\nI also added some statistics to the workbench to get an overview of the parsed file.  e.g. for the Graph API file it produces:\r\n\r\nPath Items: 6783\r\nOperations: 10609\r\nParameters: 23392\r\nRequest Bodies: 3815\r\nResponses: 10609\r\nLinks: 132\r\nCallbacks: 0\r\nSchemas: 336995\r\n  \r\n","created_at":"2018-04-15T21:42:15Z","updated_at":"2018-04-15T21:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/241/commits","review_comments_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/241/comments","review_comment_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/241/comments","statuses_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/statuses/b532b1a10883bf94b383dd1dcc5037e46cc37c2a","head":{"label":"Microsoft:dm/perf","ref":"dm/perf","sha":"b532b1a10883bf94b383dd1dcc5037e46cc37c2a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97175798,"name":"OpenAPI.NET","full_name":"Microsoft/OpenAPI.NET","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/OpenAPI.NET","description":"The OpenAPI.NET SDK contains a useful object model for OpenAPI documents in .NET along with common serializers to extract raw OpenAPI JSON and YAML documents from the model.","fork":false,"url":"https://api.github.com/repos/Microsoft/OpenAPI.NET","forks_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/forks","keys_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/teams","hooks_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/events","assignees_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/tags","blobs_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/languages","stargazers_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/subscription","commits_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/merges","archive_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/downloads","issues_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/deployments","created_at":"2017-07-14T00:24:14Z","updated_at":"2018-04-10T07:56:22Z","pushed_at":"2018-04-15T21:26:57Z","git_url":"git://github.com/Microsoft/OpenAPI.NET.git","ssh_url":"git@github.com:Microsoft/OpenAPI.NET.git","clone_url":"https://github.com/Microsoft/OpenAPI.NET.git","svn_url":"https://github.com/Microsoft/OpenAPI.NET","homepage":"","size":2004,"stargazers_count":242,"watchers_count":242,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":16,"watchers":242,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"13617eb3e7a7878b8f4e145152c4ef7c76af24e1","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":97175798,"name":"OpenAPI.NET","full_name":"Microsoft/OpenAPI.NET","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/OpenAPI.NET","description":"The OpenAPI.NET SDK contains a useful object model for OpenAPI documents in .NET along with common serializers to extract raw OpenAPI JSON and YAML documents from the model.","fork":false,"url":"https://api.github.com/repos/Microsoft/OpenAPI.NET","forks_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/forks","keys_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/teams","hooks_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/events","assignees_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/tags","blobs_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/languages","stargazers_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/subscription","commits_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/merges","archive_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/downloads","issues_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/OpenAPI.NET/deployments","created_at":"2017-07-14T00:24:14Z","updated_at":"2018-04-10T07:56:22Z","pushed_at":"2018-04-15T21:26:57Z","git_url":"git://github.com/Microsoft/OpenAPI.NET.git","ssh_url":"git@github.com:Microsoft/OpenAPI.NET.git","clone_url":"https://github.com/Microsoft/OpenAPI.NET.git","svn_url":"https://github.com/Microsoft/OpenAPI.NET","homepage":"","size":2004,"stargazers_count":242,"watchers_count":242,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19,"open_issues":16,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/241"},"html":{"href":"https://github.com/Microsoft/OpenAPI.NET/pull/241"},"issue":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/241"},"comments":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/OpenAPI.NET/statuses/b532b1a10883bf94b383dd1dcc5037e46cc37c2a"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":483,"deletions":175,"changed_files":24}}
{"actor":{"display_login":"darrelmiller"}}