{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20764","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20764/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20764/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20764/events","html_url":"https://github.com/nodejs/node/pull/20764","id":323460200,"number":20764,"title":"fs: refactor fs module","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":155435785,"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-05-16T03:54:29Z","updated_at":"2018-05-19T17:37:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20764","html_url":"https://github.com/nodejs/node/pull/20764","diff_url":"https://github.com/nodejs/node/pull/20764.diff","patch_url":"https://github.com/nodejs/node/pull/20764.patch"},"body":"Fairly sizable structural refactoring of the `fs` module. It moves several pieces out into separate submodules that are lazy-loaded, switches the use the `module.exports = {}` pattern in a way that preserves the ability to monkeypatch, and uses `const`/`let` more consistently.\r\n\r\nThe changes are intended to be squashed down into a single commit when landing but are separated out for easier review.\r\n\r\nhttps://github.com/nodejs/node/pull/20735 should likely land first.\r\n\r\n~~defensively semver-major.~~ CITGM looks good, graceful-fs still appears to work as expected... so this can be semver-patch. woohoo!\r\n\r\n##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/390420802","html_url":"https://github.com/nodejs/node/pull/20764#issuecomment-390420802","issue_url":"https://api.github.com/repos/nodejs/node/issues/20764","id":390420802,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2018-05-19T17:37:49Z","updated_at":"2018-05-19T17:37:49Z","author_association":"MEMBER","body":"New CI: https://ci.nodejs.org/job/node-test-pull-request/14974/"}}
{"actor":{"display_login":"jasnell"}}