{"action":"created","comment":{"url":"https://api.github.com/repos/dhassaine/reduxless/pulls/comments/166629589","pull_request_review_id":94722547,"id":166629589,"diff_hunk":"@@ -1,24 +1,21 @@\n-import { parse, stringify } from \"query-string\";\n+export function extractStoreFromLocation(query) {\n+  try {\n+    const matches = decodeURIComponent(query).match(/storeData=({.*})/, \"\");","path":"src/router/index.js","position":4,"original_position":4,"commit_id":"8db03bc30046b03314356bea70ad503c02be6265","original_commit_id":"8db03bc30046b03314356bea70ad503c02be6265","user":{"login":"dhassaine","id":16593040,"avatar_url":"https://avatars2.githubusercontent.com/u/16593040?v=4","gravatar_id":"","url":"https://api.github.com/users/dhassaine","html_url":"https://github.com/dhassaine","followers_url":"https://api.github.com/users/dhassaine/followers","following_url":"https://api.github.com/users/dhassaine/following{/other_user}","gists_url":"https://api.github.com/users/dhassaine/gists{/gist_id}","starred_url":"https://api.github.com/users/dhassaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhassaine/subscriptions","organizations_url":"https://api.github.com/users/dhassaine/orgs","repos_url":"https://api.github.com/users/dhassaine/repos","events_url":"https://api.github.com/users/dhassaine/events{/privacy}","received_events_url":"https://api.github.com/users/dhassaine/received_events","type":"User","site_admin":false},"body":"I'm not sure I see the point here? The code decodes the global query and extracts `storeData` from the query and ignores everything else. Why would we need to decode the other parameters if we're not using them?","created_at":"2018-02-07T14:18:34Z","updated_at":"2018-02-07T14:18:34Z","html_url":"https://github.com/dhassaine/reduxless/pull/40#discussion_r166629589","pull_request_url":"https://api.github.com/repos/dhassaine/reduxless/pulls/40","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dhassaine/reduxless/pulls/comments/166629589"},"html":{"href":"https://github.com/dhassaine/reduxless/pull/40#discussion_r166629589"},"pull_request":{"href":"https://api.github.com/repos/dhassaine/reduxless/pulls/40"}},"in_reply_to_id":166608352},"pull_request":{"url":"https://api.github.com/repos/dhassaine/reduxless/pulls/40","id":167681964,"html_url":"https://github.com/dhassaine/reduxless/pull/40","diff_url":"https://github.com/dhassaine/reduxless/pull/40.diff","patch_url":"https://github.com/dhassaine/reduxless/pull/40.patch","issue_url":"https://api.github.com/repos/dhassaine/reduxless/issues/40","number":40,"state":"open","locked":false,"title":"Diet","user":{"login":"dhassaine","id":16593040,"avatar_url":"https://avatars2.githubusercontent.com/u/16593040?v=4","gravatar_id":"","url":"https://api.github.com/users/dhassaine","html_url":"https://github.com/dhassaine","followers_url":"https://api.github.com/users/dhassaine/followers","following_url":"https://api.github.com/users/dhassaine/following{/other_user}","gists_url":"https://api.github.com/users/dhassaine/gists{/gist_id}","starred_url":"https://api.github.com/users/dhassaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhassaine/subscriptions","organizations_url":"https://api.github.com/users/dhassaine/orgs","repos_url":"https://api.github.com/users/dhassaine/repos","events_url":"https://api.github.com/users/dhassaine/events{/privacy}","received_events_url":"https://api.github.com/users/dhassaine/received_events","type":"User","site_admin":false},"body":"I removed `query-string` dependency. We only care about the `storeData` parameter which is JSON stringified so using `query-string` was just overkill.","created_at":"2018-02-07T12:41:22Z","updated_at":"2018-02-07T14:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3aeb3ba2e3a467fc659239dd8ccfed2dafc0ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dhassaine/reduxless/pulls/40/commits","review_comments_url":"https://api.github.com/repos/dhassaine/reduxless/pulls/40/comments","review_comment_url":"https://api.github.com/repos/dhassaine/reduxless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhassaine/reduxless/issues/40/comments","statuses_url":"https://api.github.com/repos/dhassaine/reduxless/statuses/8db03bc30046b03314356bea70ad503c02be6265","head":{"label":"dhassaine:diet","ref":"diet","sha":"8db03bc30046b03314356bea70ad503c02be6265","user":{"login":"dhassaine","id":16593040,"avatar_url":"https://avatars2.githubusercontent.com/u/16593040?v=4","gravatar_id":"","url":"https://api.github.com/users/dhassaine","html_url":"https://github.com/dhassaine","followers_url":"https://api.github.com/users/dhassaine/followers","following_url":"https://api.github.com/users/dhassaine/following{/other_user}","gists_url":"https://api.github.com/users/dhassaine/gists{/gist_id}","starred_url":"https://api.github.com/users/dhassaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhassaine/subscriptions","organizations_url":"https://api.github.com/users/dhassaine/orgs","repos_url":"https://api.github.com/users/dhassaine/repos","events_url":"https://api.github.com/users/dhassaine/events{/privacy}","received_events_url":"https://api.github.com/users/dhassaine/received_events","type":"User","site_admin":false},"repo":{"id":104658997,"name":"reduxless","full_name":"dhassaine/reduxless","owner":{"login":"dhassaine","id":16593040,"avatar_url":"https://avatars2.githubusercontent.com/u/16593040?v=4","gravatar_id":"","url":"https://api.github.com/users/dhassaine","html_url":"https://github.com/dhassaine","followers_url":"https://api.github.com/users/dhassaine/followers","following_url":"https://api.github.com/users/dhassaine/following{/other_user}","gists_url":"https://api.github.com/users/dhassaine/gists{/gist_id}","starred_url":"https://api.github.com/users/dhassaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhassaine/subscriptions","organizations_url":"https://api.github.com/users/dhassaine/orgs","repos_url":"https://api.github.com/users/dhassaine/repos","events_url":"https://api.github.com/users/dhassaine/events{/privacy}","received_events_url":"https://api.github.com/users/dhassaine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhassaine/reduxless","description":"look ma.. no redux","fork":false,"url":"https://api.github.com/repos/dhassaine/reduxless","forks_url":"https://api.github.com/repos/dhassaine/reduxless/forks","keys_url":"https://api.github.com/repos/dhassaine/reduxless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhassaine/reduxless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhassaine/reduxless/teams","hooks_url":"https://api.github.com/repos/dhassaine/reduxless/hooks","issue_events_url":"https://api.github.com/repos/dhassaine/reduxless/issues/events{/number}","events_url":"https://api.github.com/repos/dhassaine/reduxless/events","assignees_url":"https://api.github.com/repos/dhassaine/reduxless/assignees{/user}","branches_url":"https://api.github.com/repos/dhassaine/reduxless/branches{/branch}","tags_url":"https://api.github.com/repos/dhassaine/reduxless/tags","blobs_url":"https://api.github.com/repos/dhassaine/reduxless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhassaine/reduxless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhassaine/reduxless/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhassaine/reduxless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhassaine/reduxless/statuses/{sha}","languages_url":"https://api.github.com/repos/dhassaine/reduxless/languages","stargazers_url":"https://api.github.com/repos/dhassaine/reduxless/stargazers","contributors_url":"https://api.github.com/repos/dhassaine/reduxless/contributors","subscribers_url":"https://api.github.com/repos/dhassaine/reduxless/subscribers","subscription_url":"https://api.github.com/repos/dhassaine/reduxless/subscription","commits_url":"https://api.github.com/repos/dhassaine/reduxless/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhassaine/reduxless/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhassaine/reduxless/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhassaine/reduxless/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhassaine/reduxless/contents/{+path}","compare_url":"https://api.github.com/repos/dhassaine/reduxless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhassaine/reduxless/merges","archive_url":"https://api.github.com/repos/dhassaine/reduxless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhassaine/reduxless/downloads","issues_url":"https://api.github.com/repos/dhassaine/reduxless/issues{/number}","pulls_url":"https://api.github.com/repos/dhassaine/reduxless/pulls{/number}","milestones_url":"https://api.github.com/repos/dhassaine/reduxless/milestones{/number}","notifications_url":"https://api.github.com/repos/dhassaine/reduxless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhassaine/reduxless/labels{/name}","releases_url":"https://api.github.com/repos/dhassaine/reduxless/releases{/id}","deployments_url":"https://api.github.com/repos/dhassaine/reduxless/deployments","created_at":"2017-09-24T16:27:15Z","updated_at":"2017-12-10T13:38:22Z","pushed_at":"2018-02-07T14:14:28Z","git_url":"git://github.com/dhassaine/reduxless.git","ssh_url":"git@github.com:dhassaine/reduxless.git","clone_url":"https://github.com/dhassaine/reduxless.git","svn_url":"https://github.com/dhassaine/reduxless","homepage":"https://dhassaine.github.io/reduxless","size":330,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"dhassaine:master","ref":"master","sha":"2cb21fe018c6e929e77c4b5642682d5c38f54372","user":{"login":"dhassaine","id":16593040,"avatar_url":"https://avatars2.githubusercontent.com/u/16593040?v=4","gravatar_id":"","url":"https://api.github.com/users/dhassaine","html_url":"https://github.com/dhassaine","followers_url":"https://api.github.com/users/dhassaine/followers","following_url":"https://api.github.com/users/dhassaine/following{/other_user}","gists_url":"https://api.github.com/users/dhassaine/gists{/gist_id}","starred_url":"https://api.github.com/users/dhassaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhassaine/subscriptions","organizations_url":"https://api.github.com/users/dhassaine/orgs","repos_url":"https://api.github.com/users/dhassaine/repos","events_url":"https://api.github.com/users/dhassaine/events{/privacy}","received_events_url":"https://api.github.com/users/dhassaine/received_events","type":"User","site_admin":false},"repo":{"id":104658997,"name":"reduxless","full_name":"dhassaine/reduxless","owner":{"login":"dhassaine","id":16593040,"avatar_url":"https://avatars2.githubusercontent.com/u/16593040?v=4","gravatar_id":"","url":"https://api.github.com/users/dhassaine","html_url":"https://github.com/dhassaine","followers_url":"https://api.github.com/users/dhassaine/followers","following_url":"https://api.github.com/users/dhassaine/following{/other_user}","gists_url":"https://api.github.com/users/dhassaine/gists{/gist_id}","starred_url":"https://api.github.com/users/dhassaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhassaine/subscriptions","organizations_url":"https://api.github.com/users/dhassaine/orgs","repos_url":"https://api.github.com/users/dhassaine/repos","events_url":"https://api.github.com/users/dhassaine/events{/privacy}","received_events_url":"https://api.github.com/users/dhassaine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhassaine/reduxless","description":"look ma.. no redux","fork":false,"url":"https://api.github.com/repos/dhassaine/reduxless","forks_url":"https://api.github.com/repos/dhassaine/reduxless/forks","keys_url":"https://api.github.com/repos/dhassaine/reduxless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhassaine/reduxless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhassaine/reduxless/teams","hooks_url":"https://api.github.com/repos/dhassaine/reduxless/hooks","issue_events_url":"https://api.github.com/repos/dhassaine/reduxless/issues/events{/number}","events_url":"https://api.github.com/repos/dhassaine/reduxless/events","assignees_url":"https://api.github.com/repos/dhassaine/reduxless/assignees{/user}","branches_url":"https://api.github.com/repos/dhassaine/reduxless/branches{/branch}","tags_url":"https://api.github.com/repos/dhassaine/reduxless/tags","blobs_url":"https://api.github.com/repos/dhassaine/reduxless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhassaine/reduxless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhassaine/reduxless/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhassaine/reduxless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhassaine/reduxless/statuses/{sha}","languages_url":"https://api.github.com/repos/dhassaine/reduxless/languages","stargazers_url":"https://api.github.com/repos/dhassaine/reduxless/stargazers","contributors_url":"https://api.github.com/repos/dhassaine/reduxless/contributors","subscribers_url":"https://api.github.com/repos/dhassaine/reduxless/subscribers","subscription_url":"https://api.github.com/repos/dhassaine/reduxless/subscription","commits_url":"https://api.github.com/repos/dhassaine/reduxless/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhassaine/reduxless/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhassaine/reduxless/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhassaine/reduxless/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhassaine/reduxless/contents/{+path}","compare_url":"https://api.github.com/repos/dhassaine/reduxless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhassaine/reduxless/merges","archive_url":"https://api.github.com/repos/dhassaine/reduxless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhassaine/reduxless/downloads","issues_url":"https://api.github.com/repos/dhassaine/reduxless/issues{/number}","pulls_url":"https://api.github.com/repos/dhassaine/reduxless/pulls{/number}","milestones_url":"https://api.github.com/repos/dhassaine/reduxless/milestones{/number}","notifications_url":"https://api.github.com/repos/dhassaine/reduxless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhassaine/reduxless/labels{/name}","releases_url":"https://api.github.com/repos/dhassaine/reduxless/releases{/id}","deployments_url":"https://api.github.com/repos/dhassaine/reduxless/deployments","created_at":"2017-09-24T16:27:15Z","updated_at":"2017-12-10T13:38:22Z","pushed_at":"2018-02-07T14:14:28Z","git_url":"git://github.com/dhassaine/reduxless.git","ssh_url":"git@github.com:dhassaine/reduxless.git","clone_url":"https://github.com/dhassaine/reduxless.git","svn_url":"https://github.com/dhassaine/reduxless","homepage":"https://dhassaine.github.io/reduxless","size":330,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dhassaine/reduxless/pulls/40"},"html":{"href":"https://github.com/dhassaine/reduxless/pull/40"},"issue":{"href":"https://api.github.com/repos/dhassaine/reduxless/issues/40"},"comments":{"href":"https://api.github.com/repos/dhassaine/reduxless/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/dhassaine/reduxless/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/dhassaine/reduxless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhassaine/reduxless/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/dhassaine/reduxless/statuses/8db03bc30046b03314356bea70ad503c02be6265"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dhassaine"}}