{"action":"closed","number":595,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/595","id":229459557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDU5NTU3","html_url":"https://github.com/wireapp/wire-ios-data-model/pull/595","diff_url":"https://github.com/wireapp/wire-ios-data-model/pull/595.diff","patch_url":"https://github.com/wireapp/wire-ios-data-model/pull/595.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/595","number":595,"state":"closed","locked":false,"title":"Fix editing message with quote","user":{"login":"typfel","id":7156,"node_id":"MDQ6VXNlcjcxNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7156?v=4","gravatar_id":"","url":"https://api.github.com/users/typfel","html_url":"https://github.com/typfel","followers_url":"https://api.github.com/users/typfel/followers","following_url":"https://api.github.com/users/typfel/following{/other_user}","gists_url":"https://api.github.com/users/typfel/gists{/gist_id}","starred_url":"https://api.github.com/users/typfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typfel/subscriptions","organizations_url":"https://api.github.com/users/typfel/orgs","repos_url":"https://api.github.com/users/typfel/repos","events_url":"https://api.github.com/users/typfel/events{/privacy}","received_events_url":"https://api.github.com/users/typfel/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nWe were losing the quote when applying a message edit.\r\n\r\n### Causes\r\n\r\nAccording to the spec we do not allow users to edit the quote in a message, only the text can be edited. This means we should copy only text part of an edit but leave any existing quote as they are. We didn't do this but instead copied all the fields from the edit.\r\n\r\n### Solutions\r\n\r\nKeep the quote from the original message when applying a text edit.","created_at":"2018-11-08T18:06:36Z","updated_at":"2018-11-09T09:14:56Z","closed_at":"2018-11-09T09:14:56Z","merged_at":"2018-11-09T09:14:56Z","merge_commit_sha":"2f7def596ef8df8cabb0c5b193885fb378434f7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/595/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/595/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/595/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/489dbe6a431ba8ae426c5aa3575402fe1fc3009f","head":{"label":"wireapp:fix/editing-message-with-quote","ref":"fix/editing-message-with-quote","sha":"489dbe6a431ba8ae426c5aa3575402fe1fc3009f","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":57151009,"node_id":"MDEwOlJlcG9zaXRvcnk1NzE1MTAwOQ==","name":"wire-ios-data-model","full_name":"wireapp/wire-ios-data-model","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-ios-data-model","description":"Core Data model and entity classes","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-data-model","forks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/deployments","created_at":"2016-04-26T18:09:28Z","updated_at":"2018-11-07T14:51:46Z","pushed_at":"2018-11-09T09:14:56Z","git_url":"git://github.com/wireapp/wire-ios-data-model.git","ssh_url":"git@github.com:wireapp/wire-ios-data-model.git","clone_url":"https://github.com/wireapp/wire-ios-data-model.git","svn_url":"https://github.com/wireapp/wire-ios-data-model","homepage":"https://wire.com","size":11050,"stargazers_count":23,"watchers_count":23,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":9,"open_issues":1,"watchers":23,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"2db45682ca0400ade54fe815d981d9b0ee32715c","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":57151009,"node_id":"MDEwOlJlcG9zaXRvcnk1NzE1MTAwOQ==","name":"wire-ios-data-model","full_name":"wireapp/wire-ios-data-model","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-ios-data-model","description":"Core Data model and entity classes","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-data-model","forks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-data-model/deployments","created_at":"2016-04-26T18:09:28Z","updated_at":"2018-11-07T14:51:46Z","pushed_at":"2018-11-09T09:14:56Z","git_url":"git://github.com/wireapp/wire-ios-data-model.git","ssh_url":"git@github.com:wireapp/wire-ios-data-model.git","clone_url":"https://github.com/wireapp/wire-ios-data-model.git","svn_url":"https://github.com/wireapp/wire-ios-data-model","homepage":"https://wire.com","size":11050,"stargazers_count":23,"watchers_count":23,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":9,"open_issues":1,"watchers":23,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/595"},"html":{"href":"https://github.com/wireapp/wire-ios-data-model/pull/595"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/595"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-data-model/statuses/489dbe6a431ba8ae426c5aa3575402fe1fc3009f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wire-bot","id":20773876,"node_id":"MDQ6VXNlcjIwNzczODc2","avatar_url":"https://avatars3.githubusercontent.com/u/20773876?v=4","gravatar_id":"","url":"https://api.github.com/users/wire-bot","html_url":"https://github.com/wire-bot","followers_url":"https://api.github.com/users/wire-bot/followers","following_url":"https://api.github.com/users/wire-bot/following{/other_user}","gists_url":"https://api.github.com/users/wire-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wire-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wire-bot/subscriptions","organizations_url":"https://api.github.com/users/wire-bot/orgs","repos_url":"https://api.github.com/users/wire-bot/repos","events_url":"https://api.github.com/users/wire-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wire-bot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":131,"deletions":6,"changed_files":6}}
{"actor":{"display_login":"wire-bot"}}