{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/191562504","pull_request_review_id":124159241,"id":191562504,"diff_hunk":"@@ -0,0 +1,1213 @@\n+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n+!! Copyright (c) 2018, 2018 IBM Corp. and others\n+!!\n+!! This program and the accompanying materials are made available under\n+!! the terms of the Eclipse Public License 2.0 which accompanies this\n+!! distribution and is available at http://eclipse.org/legal/epl-2.0\n+!! or the Apache License, Version 2.0 which accompanies this distribution\n+!! and is available at https://www.apache.org/licenses/LICENSE-2.0.\n+!!\n+!! This Source Code may also be made available under the following Secondary\n+!! Licenses when the conditions for such availability set forth in the\n+!! Eclipse Public License, v. 2.0 are satisfied: GNU General Public License,\n+!! version 2 with the GNU Classpath Exception [1] and GNU General Public\n+!! License, version 2 with the OpenJDK Assembly Exception [2].\n+!!\n+!! [1] https://www.gnu.org/software/classpath/license.html\n+!! [2] http://openjdk.java.net/legal/assembly-exception.html\n+!!\n+!! SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception\n+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n+\n+!\t\tOpcode      \tBINARY  \tProperties               \t// {Specific} <variant> [comments]\n+! UNALLOCATED\n+\t\tbad         \t00000000\t-                        \t// [ invalid operation ]","path":"compiler/aarch64/codegen/ARM64Ops.ops","position":24,"original_position":24,"commit_id":"8292374eb920ae0830e30ddd2358caad89bf85e3","original_commit_id":"8292374eb920ae0830e30ddd2358caad89bf85e3","user":{"login":"JamesKingdon","id":26579150,"avatar_url":"https://avatars1.githubusercontent.com/u/26579150?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesKingdon","html_url":"https://github.com/JamesKingdon","followers_url":"https://api.github.com/users/JamesKingdon/followers","following_url":"https://api.github.com/users/JamesKingdon/following{/other_user}","gists_url":"https://api.github.com/users/JamesKingdon/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesKingdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesKingdon/subscriptions","organizations_url":"https://api.github.com/users/JamesKingdon/orgs","repos_url":"https://api.github.com/users/JamesKingdon/repos","events_url":"https://api.github.com/users/JamesKingdon/events{/privacy}","received_events_url":"https://api.github.com/users/JamesKingdon/received_events","type":"User","site_admin":false},"body":"Devin was talking about the use of 'bad' today for the 'break on entry' capability. If there is an instruction that works cleanly with gdb as a break-point, that gdb knows it can step past with 'continue' then perhaps we could use that here. I wonder if 'brk' does that?","created_at":"2018-05-29T20:27:09Z","updated_at":"2018-05-29T20:27:09Z","html_url":"https://github.com/eclipse/omr/pull/2600#discussion_r191562504","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/2600","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/191562504"},"html":{"href":"https://github.com/eclipse/omr/pull/2600#discussion_r191562504"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2600"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2600","id":191169043,"html_url":"https://github.com/eclipse/omr/pull/2600","diff_url":"https://github.com/eclipse/omr/pull/2600.diff","patch_url":"https://github.com/eclipse/omr/pull/2600.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2600","number":2600,"state":"open","locked":false,"title":"[WIP] AArch64: Binary Encoding","user":{"login":"jeanlego","id":9909445,"avatar_url":"https://avatars2.githubusercontent.com/u/9909445?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanlego","html_url":"https://github.com/jeanlego","followers_url":"https://api.github.com/users/jeanlego/followers","following_url":"https://api.github.com/users/jeanlego/following{/other_user}","gists_url":"https://api.github.com/users/jeanlego/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanlego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanlego/subscriptions","organizations_url":"https://api.github.com/users/jeanlego/orgs","repos_url":"https://api.github.com/users/jeanlego/repos","events_url":"https://api.github.com/users/jeanlego/events{/privacy}","received_events_url":"https://api.github.com/users/jeanlego/received_events","type":"User","site_admin":false},"body":"This implements the basic binary encoding extracted from ARM64\r\ndocumentation.\r\n\r\nissue: #2588\r\n\r\nSigned-off-by: jeanlego <jeanphilippe.legault@unb.ca>","created_at":"2018-05-29T14:38:53Z","updated_at":"2018-05-29T20:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"853a1e20d1d0d2181b010c1d9899e0ef1b94fb13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463261830,"url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/2600/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/2600/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2600/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/8292374eb920ae0830e30ddd2358caad89bf85e3","head":{"label":"CAS-Atlantic:aarch64_binary_encoding","ref":"aarch64_binary_encoding","sha":"8292374eb920ae0830e30ddd2358caad89bf85e3","user":{"login":"CAS-Atlantic","id":38439176,"avatar_url":"https://avatars1.githubusercontent.com/u/38439176?v=4","gravatar_id":"","url":"https://api.github.com/users/CAS-Atlantic","html_url":"https://github.com/CAS-Atlantic","followers_url":"https://api.github.com/users/CAS-Atlantic/followers","following_url":"https://api.github.com/users/CAS-Atlantic/following{/other_user}","gists_url":"https://api.github.com/users/CAS-Atlantic/gists{/gist_id}","starred_url":"https://api.github.com/users/CAS-Atlantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAS-Atlantic/subscriptions","organizations_url":"https://api.github.com/users/CAS-Atlantic/orgs","repos_url":"https://api.github.com/users/CAS-Atlantic/repos","events_url":"https://api.github.com/users/CAS-Atlantic/events{/privacy}","received_events_url":"https://api.github.com/users/CAS-Atlantic/received_events","type":"Organization","site_admin":false},"repo":{"id":129790328,"name":"omr","full_name":"CAS-Atlantic/omr","owner":{"login":"CAS-Atlantic","id":38439176,"avatar_url":"https://avatars1.githubusercontent.com/u/38439176?v=4","gravatar_id":"","url":"https://api.github.com/users/CAS-Atlantic","html_url":"https://github.com/CAS-Atlantic","followers_url":"https://api.github.com/users/CAS-Atlantic/followers","following_url":"https://api.github.com/users/CAS-Atlantic/following{/other_user}","gists_url":"https://api.github.com/users/CAS-Atlantic/gists{/gist_id}","starred_url":"https://api.github.com/users/CAS-Atlantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAS-Atlantic/subscriptions","organizations_url":"https://api.github.com/users/CAS-Atlantic/orgs","repos_url":"https://api.github.com/users/CAS-Atlantic/repos","events_url":"https://api.github.com/users/CAS-Atlantic/events{/privacy}","received_events_url":"https://api.github.com/users/CAS-Atlantic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CAS-Atlantic/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/CAS-Atlantic/omr","forks_url":"https://api.github.com/repos/CAS-Atlantic/omr/forks","keys_url":"https://api.github.com/repos/CAS-Atlantic/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CAS-Atlantic/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CAS-Atlantic/omr/teams","hooks_url":"https://api.github.com/repos/CAS-Atlantic/omr/hooks","issue_events_url":"https://api.github.com/repos/CAS-Atlantic/omr/issues/events{/number}","events_url":"https://api.github.com/repos/CAS-Atlantic/omr/events","assignees_url":"https://api.github.com/repos/CAS-Atlantic/omr/assignees{/user}","branches_url":"https://api.github.com/repos/CAS-Atlantic/omr/branches{/branch}","tags_url":"https://api.github.com/repos/CAS-Atlantic/omr/tags","blobs_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CAS-Atlantic/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/CAS-Atlantic/omr/languages","stargazers_url":"https://api.github.com/repos/CAS-Atlantic/omr/stargazers","contributors_url":"https://api.github.com/repos/CAS-Atlantic/omr/contributors","subscribers_url":"https://api.github.com/repos/CAS-Atlantic/omr/subscribers","subscription_url":"https://api.github.com/repos/CAS-Atlantic/omr/subscription","commits_url":"https://api.github.com/repos/CAS-Atlantic/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/CAS-Atlantic/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/CAS-Atlantic/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/CAS-Atlantic/omr/contents/{+path}","compare_url":"https://api.github.com/repos/CAS-Atlantic/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CAS-Atlantic/omr/merges","archive_url":"https://api.github.com/repos/CAS-Atlantic/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CAS-Atlantic/omr/downloads","issues_url":"https://api.github.com/repos/CAS-Atlantic/omr/issues{/number}","pulls_url":"https://api.github.com/repos/CAS-Atlantic/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/CAS-Atlantic/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/CAS-Atlantic/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CAS-Atlantic/omr/labels{/name}","releases_url":"https://api.github.com/repos/CAS-Atlantic/omr/releases{/id}","deployments_url":"https://api.github.com/repos/CAS-Atlantic/omr/deployments","created_at":"2018-04-16T18:48:01Z","updated_at":"2018-05-29T19:31:10Z","pushed_at":"2018-05-29T19:31:09Z","git_url":"git://github.com/CAS-Atlantic/omr.git","ssh_url":"git@github.com:CAS-Atlantic/omr.git","clone_url":"https://github.com/CAS-Atlantic/omr.git","svn_url":"https://github.com/CAS-Atlantic/omr","homepage":"http://www.eclipse.org/omr","size":24480,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"b4755f99f7410e2671ace6cda67598802446edb9","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-05-29T18:43:09Z","pushed_at":"2018-05-29T19:03:24Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":24292,"stargazers_count":487,"watchers_count":487,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":453,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":217,"open_issues":453,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2600"},"html":{"href":"https://github.com/eclipse/omr/pull/2600"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/2600"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/2600/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2600/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2600/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/8292374eb920ae0830e30ddd2358caad89bf85e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JamesKingdon"}}