{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/190547687","pull_request_review_id":122944490,"id":190547687,"diff_hunk":"@@ -624,10 +622,18 @@ func setMasterNetworkDefaults(a *api.Properties, isUpgrade bool) {\n \tif a.MasterProfile == nil {\n \t\treturn\n \t}\n-\n-\t// Set default Distro to Ubuntu\n-\tif a.MasterProfile.Distro == \"\" {\n-\t\ta.MasterProfile.Distro = api.Ubuntu\n+\to := a.OrchestratorProfile\n+\t// set default Distro based on orchestrator\n+\tswitch o.OrchestratorType {\n+\tcase api.OpenShift:\n+\t\tif a.MasterProfile.Distro == \"\" {\n+\t\t\ta.MasterProfile.Distro = api.RHEL","path":"pkg/acsengine/defaults.go","position":38,"original_position":38,"commit_id":"d67fcf06a28dcb604ec8f4b19bfb6310b344ef17","original_commit_id":"d67fcf06a28dcb604ec8f4b19bfb6310b344ef17","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Instead of `api.RHEL` default to `api.OpenShift39RHEL`.","created_at":"2018-05-24T11:08:58Z","updated_at":"2018-05-24T11:08:59Z","html_url":"https://github.com/Azure/acs-engine/pull/3020#discussion_r190547687","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3020","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/190547687"},"html":{"href":"https://github.com/Azure/acs-engine/pull/3020#discussion_r190547687"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3020"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/3020","id":189203770,"html_url":"https://github.com/Azure/acs-engine/pull/3020","diff_url":"https://github.com/Azure/acs-engine/pull/3020.diff","patch_url":"https://github.com/Azure/acs-engine/pull/3020.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/3020","number":3020,"state":"open","locked":false,"title":"add default distro for agents.","user":{"login":"mjudeikis","id":3225744,"avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"body":"If you generate template for Openshift now without distro specified (as per docs section in https://github.com/Azure/acs-engine/blob/master/docs/openshift/deploy.md), you will get agent distro as Ubuntu and masters as RHEL. ","created_at":"2018-05-19T19:47:28Z","updated_at":"2018-05-24T11:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1a63636ae07a17365f2b643bbaebe0db1a8591e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":936451056,"url":"https://api.github.com/repos/Azure/acs-engine/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3020/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3020/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/3020/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/d67fcf06a28dcb604ec8f4b19bfb6310b344ef17","head":{"label":"mjudeikis:default_distro","ref":"default_distro","sha":"d67fcf06a28dcb604ec8f4b19bfb6310b344ef17","user":{"login":"mjudeikis","id":3225744,"avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"repo":{"id":130977948,"name":"acs-engine","full_name":"mjudeikis/acs-engine","owner":{"login":"mjudeikis","id":3225744,"avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjudeikis/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/mjudeikis/acs-engine","forks_url":"https://api.github.com/repos/mjudeikis/acs-engine/forks","keys_url":"https://api.github.com/repos/mjudeikis/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjudeikis/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjudeikis/acs-engine/teams","hooks_url":"https://api.github.com/repos/mjudeikis/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/mjudeikis/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/mjudeikis/acs-engine/events","assignees_url":"https://api.github.com/repos/mjudeikis/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/mjudeikis/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/mjudeikis/acs-engine/tags","blobs_url":"https://api.github.com/repos/mjudeikis/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjudeikis/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjudeikis/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjudeikis/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjudeikis/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/mjudeikis/acs-engine/languages","stargazers_url":"https://api.github.com/repos/mjudeikis/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/mjudeikis/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/mjudeikis/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/mjudeikis/acs-engine/subscription","commits_url":"https://api.github.com/repos/mjudeikis/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjudeikis/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjudeikis/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjudeikis/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjudeikis/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/mjudeikis/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjudeikis/acs-engine/merges","archive_url":"https://api.github.com/repos/mjudeikis/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjudeikis/acs-engine/downloads","issues_url":"https://api.github.com/repos/mjudeikis/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/mjudeikis/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/mjudeikis/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/mjudeikis/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjudeikis/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/mjudeikis/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/mjudeikis/acs-engine/deployments","created_at":"2018-04-25T08:51:47Z","updated_at":"2018-04-25T08:51:52Z","pushed_at":"2018-05-24T10:51:11Z","git_url":"git://github.com/mjudeikis/acs-engine.git","ssh_url":"git@github.com:mjudeikis/acs-engine.git","clone_url":"https://github.com/mjudeikis/acs-engine.git","svn_url":"https://github.com/mjudeikis/acs-engine","homepage":"","size":69745,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"5c5bba85c75130eb7f82df31e2a5c4a97a4feda2","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-05-23T23:43:58Z","pushed_at":"2018-05-24T10:51:12Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":79988,"stargazers_count":807,"watchers_count":807,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":526,"mirror_url":null,"archived":false,"open_issues_count":504,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":526,"open_issues":504,"watchers":807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3020"},"html":{"href":"https://github.com/Azure/acs-engine/pull/3020"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/3020"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/3020/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3020/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3020/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/d67fcf06a28dcb604ec8f4b19bfb6310b344ef17"}},"author_association":"NONE"}}
{"actor":{"display_login":"kargakis"}}