{"action":"created","issue":{"url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/67","repository_url":"https://api.github.com/repos/jeyvison/liferay-portal","labels_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/67/comments","events_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/67/events","html_url":"https://github.com/jeyvison/liferay-portal/pull/67","id":332803011,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTk3MTI2","number":67,"title":"LPS-82502 Overlapping Calendar Events","user":{"login":"IstvanD","id":6039187,"node_id":"MDQ6VXNlcjYwMzkxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6039187?v=4","gravatar_id":"","url":"https://api.github.com/users/IstvanD","html_url":"https://github.com/IstvanD","followers_url":"https://api.github.com/users/IstvanD/followers","following_url":"https://api.github.com/users/IstvanD/following{/other_user}","gists_url":"https://api.github.com/users/IstvanD/gists{/gist_id}","starred_url":"https://api.github.com/users/IstvanD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IstvanD/subscriptions","organizations_url":"https://api.github.com/users/IstvanD/orgs","repos_url":"https://api.github.com/users/IstvanD/repos","events_url":"https://api.github.com/users/IstvanD/events{/privacy}","received_events_url":"https://api.github.com/users/IstvanD/received_events","type":"User","site_admin":false},"labels":[{"id":877120916,"node_id":"MDU6TGFiZWw4NzcxMjA5MTY=","url":"https://api.github.com/repos/jeyvison/liferay-portal/labels/ci:test%20-%20failure","name":"ci:test - failure","color":"fccdcc","default":false},{"id":955665166,"node_id":"MDU6TGFiZWw5NTU2NjUxNjY=","url":"https://api.github.com/repos/jeyvison/liferay-portal/labels/ci:test:relevant%20-%20success","name":"ci:test:relevant - success","color":"c7e8cb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-15T14:43:44Z","updated_at":"2018-06-26T08:11:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jeyvison/liferay-portal/pulls/67","html_url":"https://github.com/jeyvison/liferay-portal/pull/67","diff_url":"https://github.com/jeyvison/liferay-portal/pull/67.diff","patch_url":"https://github.com/jeyvison/liferay-portal/pull/67.patch"},"body":"Hello @jeyvison \r\n\r\nCould you please review this pull request for the Calendar portlet?\r\n\r\nThis fixes an issue when two events just start one after another, but one of the event is still overlapping the other in the scheduler view.\r\n\r\nIf event1 starts at, say, 11:53, and ends at 12:00, it will be covered entirely by event2 which start at 12:00.\r\nNo matter how small is the time frame of event1, the minimum size of the event's rectangle is of a half hour event.\r\n\r\nThe event's rectangle height cannot be shortened because the name label would hang over the frame.\r\n\r\nNormally, if an event is overlapped by a later event, the later event's width will be reduced half a column.\r\nHowever, in the above case, event2's width will not be reduced, since it starts just after event1 ended.\r\n\r\nThe intersection detection logic is implemented in the `intersects()` function in **aui-scheduler-view-day.js**\r\nThe approach I used for solving the issue is to override the function in `scheduler_models.js` where `SchedulerEvent` is extended, by extending the timeframe of the event (endDate + 30 minutes) whom with other event's are compared for collision.\r\n\r\nThank you and best regards,\r\nIstván"},"comment":{"url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/comments/400220061","html_url":"https://github.com/jeyvison/liferay-portal/pull/67#issuecomment-400220061","issue_url":"https://api.github.com/repos/jeyvison/liferay-portal/issues/67","id":400220061,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIyMDA2MQ==","user":{"login":"hudakl","id":998211,"node_id":"MDQ6VXNlcjk5ODIxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/998211?v=4","gravatar_id":"","url":"https://api.github.com/users/hudakl","html_url":"https://github.com/hudakl","followers_url":"https://api.github.com/users/hudakl/followers","following_url":"https://api.github.com/users/hudakl/following{/other_user}","gists_url":"https://api.github.com/users/hudakl/gists{/gist_id}","starred_url":"https://api.github.com/users/hudakl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hudakl/subscriptions","organizations_url":"https://api.github.com/users/hudakl/orgs","repos_url":"https://api.github.com/users/hudakl/repos","events_url":"https://api.github.com/users/hudakl/events{/privacy}","received_events_url":"https://api.github.com/users/hudakl/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T08:11:09Z","updated_at":"2018-06-26T08:11:09Z","author_association":"NONE","body":"Hi @natocesarrego,\r\n\r\nWe discussed the possibility of shortening the event's height, but it would be too short to be correctly readable. If we are talking about very short duration it would even be hard to click on it.\r\n\r\nThat's why I decided to check if the two events overlapped with the half hour later start-time as well (considering that the minimum height fits a half hour period). During my tests I worked with three minutes long events, like in this specific use-case and the solution worked.\r\n\r\nFurthermore, I checked the behavior in Google Calendar and it works like our calendar after the fix is applied.\r\n\r\nConsidering these, is the solution acceptable?\r\n\r\nThank you,\r\nLaci"}}
{"actor":{"display_login":"hudakl"}}