{"action":"created","comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/219013878","pull_request_review_id":157082581,"id":219013878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTAxMzg3OA==","diff_hunk":"@@ -369,20 +369,22 @@ sub is_tftp_ready {\n     my $mnip = shift;\n     $mnip = shift if (($mnip) && ($mnip =~ /probe_utils/));\n     my $tftpdir = shift;\n+    my $test_dir = $tftpdir . \"/tftptest/\";\n+    system(\"mkdir -p $test_dir\");\n \n-    rename(\"/$tftpdir/tftptestt.tmp\", \"/$tftpdir/tftptestt.tmp.old\") if (-e \"/$tftpdir/tftptestt.tmp\");\n+    rename(\"/$test_dir/tftptestt.tmp\", \"/$test_dir/tftptestt.tmp.old\") if (-e \"/$test_dir/tftptestt.tmp\");\n     rename(\"./tftptestt.tmp\", \"./tftptestt.tmp.old\") if (-e \"./tftptestt.tmp\");\n \n-    system(\"touch /$tftpdir/tftptestt.tmp\");\n-    my $output = `tftp -4 -v $mnip  -c get tftptestt.tmp`;\n+    system(\"touch /$test_dir/tftptestt.tmp\");\n+    my $output = `tftp $mnip  -c get /tftptest/tftptestt.tmp 2>&1`;","path":"xCAT-probe/lib/perl/probe_utils.pm","position":14,"original_position":14,"commit_id":"3b8efb38fee58d068ce6d1a86e212a0c47f7776b","original_commit_id":"3b8efb38fee58d068ce6d1a86e212a0c47f7776b","user":{"login":"robin2008","id":13726882,"node_id":"MDQ6VXNlcjEzNzI2ODgy","avatar_url":"https://avatars0.githubusercontent.com/u/13726882?v=4","gravatar_id":"","url":"https://api.github.com/users/robin2008","html_url":"https://github.com/robin2008","followers_url":"https://api.github.com/users/robin2008/followers","following_url":"https://api.github.com/users/robin2008/following{/other_user}","gists_url":"https://api.github.com/users/robin2008/gists{/gist_id}","starred_url":"https://api.github.com/users/robin2008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robin2008/subscriptions","organizations_url":"https://api.github.com/users/robin2008/orgs","repos_url":"https://api.github.com/users/robin2008/repos","events_url":"https://api.github.com/users/robin2008/events{/privacy}","received_events_url":"https://api.github.com/users/robin2008/received_events","type":"User","site_admin":false},"body":"why not to remove `-4 -v` here?  Just keep them.","created_at":"2018-09-20T01:49:51Z","updated_at":"2018-09-20T01:49:51Z","html_url":"https://github.com/xcat2/xcat-core/pull/5639#discussion_r219013878","pull_request_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/219013878"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/5639#discussion_r219013878"},"pull_request":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639"}}},"pull_request":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639","id":216228529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjI4NTI5","html_url":"https://github.com/xcat2/xcat-core/pull/5639","diff_url":"https://github.com/xcat2/xcat-core/pull/5639.diff","patch_url":"https://github.com/xcat2/xcat-core/pull/5639.patch","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/5639","number":5639,"state":"open","locked":false,"title":"fix issue 5633, enhance check tftp service","user":{"login":"xuweibj","id":15208204,"node_id":"MDQ6VXNlcjE1MjA4MjA0","avatar_url":"https://avatars0.githubusercontent.com/u/15208204?v=4","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"body":"### The PR is to fix issue _#5633_\r\n\r\n### The modification include\r\n\r\n1. Use ``tftp $mnip  -c get /tftptest/tftptestt.tmp`` check tftp service\r\n2. ``ps`` check whether has tftp process by xcat, it not, add to warning msg.\r\n\r\n### The UT result\r\n```\r\n# xcatprobe xcatmn\r\n[mn]: Checking all xCAT daemons are running...                                                                    [ OK ]\r\n[mn]: Checking xcatd can receive command request...                                                               [ OK ]\r\n[mn]: Checking 'site' table is configured...                                                                      [ OK ]\r\n[mn]: No interface provided by '-i' option, detected site table IP attribute 10.3.17.21, checking xCAT configur...[WARN]\r\n[mn]: If this is incorrect, rerun with -i <ifname> option                                                         [WARN]\r\n[mn]: Checking provision network is configured...                                                                 [ OK ]\r\n[mn]: Checking 'passwd' table is configured...                                                                    [ OK ]\r\n[mn]: Checking important directories(installdir,tftpdir) are configured...                                        [ OK ]\r\n[mn]: Checking SELinux is disabled...                                                                             [ OK ]\r\n[mn]: Checking HTTP service is configured...                                                                      [ OK ]\r\n[mn]: Checking TFTP service is configured...                                                                      [FAIL]\r\n[mn]: TFTP service isn't ready on 10.3.17.21, please stop tftp service and start it by restart xcatd\r\n[mn]: Checking DNS service is configured...                                                                       [ OK ]\r\n[mn]: Checking DHCP service is configured...                                                                      [ OK ]\r\n.....\r\n=================================== SUMMARY ====================================\r\n[MN]: Checking on MN...                                                                                           [FAIL]\r\n    No interface provided by '-i' option, detected site table IP attribute 10.3.17.21, checking xCAT configurat...[WARN]\r\n    If this is incorrect, rerun with -i <ifname> option                                                           [WARN]\r\n    Checking TFTP service is configured...                                                                        [FAIL]\r\n        TFTP service isn't ready on 10.3.17.21, please stop tftp service and start it by restart xcatd\r\n```\r\n\r\n","created_at":"2018-09-18T08:47:42Z","updated_at":"2018-09-20T01:49:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ea81b1da98b1d879b6216b18152ee561cb848cd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hu-weihua","id":7370626,"node_id":"MDQ6VXNlcjczNzA2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7370626?v=4","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":390408061,"node_id":"MDU6TGFiZWwzOTA0MDgwNjE=","url":"https://api.github.com/repos/xcat2/xcat-core/labels/component:xcatprobe","name":"component:xcatprobe","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/41","html_url":"https://github.com/xcat2/xcat-core/milestone/41","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/41/labels","id":3538202,"node_id":"MDk6TWlsZXN0b25lMzUzODIwMg==","number":41,"title":"2.14.4","description":"","creator":{"login":"zet809","id":8222144,"node_id":"MDQ6VXNlcjgyMjIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8222144?v=4","gravatar_id":"","url":"https://api.github.com/users/zet809","html_url":"https://github.com/zet809","followers_url":"https://api.github.com/users/zet809/followers","following_url":"https://api.github.com/users/zet809/following{/other_user}","gists_url":"https://api.github.com/users/zet809/gists{/gist_id}","starred_url":"https://api.github.com/users/zet809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zet809/subscriptions","organizations_url":"https://api.github.com/users/zet809/orgs","repos_url":"https://api.github.com/users/zet809/repos","events_url":"https://api.github.com/users/zet809/events{/privacy}","received_events_url":"https://api.github.com/users/zet809/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":53,"state":"open","created_at":"2018-08-01T06:44:28Z","updated_at":"2018-09-20T01:36:13Z","due_on":"2018-10-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639/commits","review_comments_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639/comments","review_comment_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/5639/comments","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/3b8efb38fee58d068ce6d1a86e212a0c47f7776b","head":{"label":"xuweibj:I5633","ref":"I5633","sha":"3b8efb38fee58d068ce6d1a86e212a0c47f7776b","user":{"login":"xuweibj","id":15208204,"node_id":"MDQ6VXNlcjE1MjA4MjA0","avatar_url":"https://avatars0.githubusercontent.com/u/15208204?v=4","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"repo":{"id":45444036,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQ0NDAzNg==","name":"xcat-core","full_name":"xuweibj/xcat-core","private":false,"owner":{"login":"xuweibj","id":15208204,"node_id":"MDQ6VXNlcjE1MjA4MjA0","avatar_url":"https://avatars0.githubusercontent.com/u/15208204?v=4","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xuweibj/xcat-core","description":"Code repo for xCAT core packages","fork":true,"url":"https://api.github.com/repos/xuweibj/xcat-core","forks_url":"https://api.github.com/repos/xuweibj/xcat-core/forks","keys_url":"https://api.github.com/repos/xuweibj/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuweibj/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuweibj/xcat-core/teams","hooks_url":"https://api.github.com/repos/xuweibj/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xuweibj/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xuweibj/xcat-core/events","assignees_url":"https://api.github.com/repos/xuweibj/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xuweibj/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xuweibj/xcat-core/tags","blobs_url":"https://api.github.com/repos/xuweibj/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuweibj/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuweibj/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuweibj/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuweibj/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xuweibj/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xuweibj/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xuweibj/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xuweibj/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xuweibj/xcat-core/subscription","commits_url":"https://api.github.com/repos/xuweibj/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuweibj/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuweibj/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuweibj/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuweibj/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xuweibj/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuweibj/xcat-core/merges","archive_url":"https://api.github.com/repos/xuweibj/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuweibj/xcat-core/downloads","issues_url":"https://api.github.com/repos/xuweibj/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xuweibj/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xuweibj/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xuweibj/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuweibj/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xuweibj/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xuweibj/xcat-core/deployments","created_at":"2015-11-03T05:30:52Z","updated_at":"2018-09-18T07:04:26Z","pushed_at":"2018-09-19T01:31:00Z","git_url":"git://github.com/xuweibj/xcat-core.git","ssh_url":"git@github.com:xuweibj/xcat-core.git","clone_url":"https://github.com/xuweibj/xcat-core.git","svn_url":"https://github.com/xuweibj/xcat-core","homepage":null,"size":199663,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcat2:master","ref":"master","sha":"4164dd2dc9501fa0b17f6f812bbec7b6118e707a","user":{"login":"xcat2","id":10124414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTI0NDE0","avatar_url":"https://avatars3.githubusercontent.com/u/10124414?v=4","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"repo":{"id":27747508,"node_id":"MDEwOlJlcG9zaXRvcnkyNzc0NzUwOA==","name":"xcat-core","full_name":"xcat2/xcat-core","private":false,"owner":{"login":"xcat2","id":10124414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTI0NDE0","avatar_url":"https://avatars3.githubusercontent.com/u/10124414?v=4","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xcat2/xcat-core","description":"Code repo for xCAT core packages","fork":false,"url":"https://api.github.com/repos/xcat2/xcat-core","forks_url":"https://api.github.com/repos/xcat2/xcat-core/forks","keys_url":"https://api.github.com/repos/xcat2/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcat2/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcat2/xcat-core/teams","hooks_url":"https://api.github.com/repos/xcat2/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xcat2/xcat-core/events","assignees_url":"https://api.github.com/repos/xcat2/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xcat2/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xcat2/xcat-core/tags","blobs_url":"https://api.github.com/repos/xcat2/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcat2/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcat2/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcat2/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xcat2/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xcat2/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xcat2/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xcat2/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xcat2/xcat-core/subscription","commits_url":"https://api.github.com/repos/xcat2/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcat2/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcat2/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xcat2/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcat2/xcat-core/merges","archive_url":"https://api.github.com/repos/xcat2/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcat2/xcat-core/downloads","issues_url":"https://api.github.com/repos/xcat2/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xcat2/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xcat2/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xcat2/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcat2/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xcat2/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xcat2/xcat-core/deployments","created_at":"2014-12-09T03:21:50Z","updated_at":"2018-09-20T01:36:18Z","pushed_at":"2018-09-20T01:36:13Z","git_url":"git://github.com/xcat2/xcat-core.git","ssh_url":"git@github.com:xcat2/xcat-core.git","clone_url":"https://github.com/xcat2/xcat-core.git","svn_url":"https://github.com/xcat2/xcat-core","homepage":null,"size":200684,"stargazers_count":137,"watchers_count":137,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":189,"license":null,"forks":113,"open_issues":189,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/5639"},"issue":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/5639"},"comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/5639/comments"},"review_comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639/comments"},"review_comment":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/5639/commits"},"statuses":{"href":"https://api.github.com/repos/xcat2/xcat-core/statuses/3b8efb38fee58d068ce6d1a86e212a0c47f7776b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robin2008"}}