{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/comments/221411341","pull_request_review_id":160061305,"id":221411341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQxMTM0MQ==","diff_hunk":"@@ -27,20 +35,30 @@\n \t\t\tSystem.err.println(NAMESPACE_CONNECTION_STRING_ENVIRONMENT_VARIABLE_NAME + \" environment variable not set. Tests will not be able to connect to to any service bus entity.\");\n \t\t}\n \t\tnamespaceConnectionStringBuilder = new ConnectionStringBuilder(namespaceConnectionString);\n+\n+\t\t// Read proxy settings - proxy settings can still be set even if tests are not set to run with a proxy\n+        runWithProxy = Boolean.valueOf(System.getenv(RUN_WITH_PROXY_ENV_VAR));\n+        proxyHostName = System.getenv(PROXY_HOSTNAME_ENV_VAR);\n+        proxyPort = System.getenv(PROXY_PORT_ENV_VAR) == null ?\n+                        0 : Integer.valueOf(System.getenv(PROXY_PORT_ENV_VAR));\n \t}\n \t\n \tpublic static URI getNamespaceEndpointURI()\n     {\n         return namespaceConnectionStringBuilder.getEndpoint();\n     }\n-    \n-    public static ClientSettings getClientSettings()\n-    {\n-        if (Boolean.valueOf(System.getenv(RUN_WITH_PROXY_ENV_VAR))) {\n-            return TestUtils.getProxyClientSettings();\n-        } else {\n-            return Util.getClientSettingsFromConnectionStringBuilder(namespaceConnectionStringBuilder);\n+\n+    public static String getNamespaceConnectionString() { return namespaceConnectionString; }","path":"azure-servicebus/src/test/java/com/microsoft/azure/servicebus/TestUtils.java","position":50,"original_position":50,"commit_id":"79476d100a9af6159f3a172b12993ef9962b9b04","original_commit_id":"79476d100a9af6159f3a172b12993ef9962b9b04","user":{"login":"yvgopal","id":13388125,"node_id":"MDQ6VXNlcjEzMzg4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/13388125?v=4","gravatar_id":"","url":"https://api.github.com/users/yvgopal","html_url":"https://github.com/yvgopal","followers_url":"https://api.github.com/users/yvgopal/followers","following_url":"https://api.github.com/users/yvgopal/following{/other_user}","gists_url":"https://api.github.com/users/yvgopal/gists{/gist_id}","starred_url":"https://api.github.com/users/yvgopal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvgopal/subscriptions","organizations_url":"https://api.github.com/users/yvgopal/orgs","repos_url":"https://api.github.com/users/yvgopal/repos","events_url":"https://api.github.com/users/yvgopal/events{/privacy}","received_events_url":"https://api.github.com/users/yvgopal/received_events","type":"User","site_admin":false},"body":">getNamespaceConnectionString [](start = 25, length = 28)\r\n\r\nProbably not required,as tests using this method are also not required.","created_at":"2018-09-29T01:45:07Z","updated_at":"2018-09-29T01:45:07Z","html_url":"https://github.com/Azure/azure-service-bus-java/pull/285#discussion_r221411341","pull_request_url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/comments/221411341"},"html":{"href":"https://github.com/Azure/azure-service-bus-java/pull/285#discussion_r221411341"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285","id":219115099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTE1MDk5","html_url":"https://github.com/Azure/azure-service-bus-java/pull/285","diff_url":"https://github.com/Azure/azure-service-bus-java/pull/285.diff","patch_url":"https://github.com/Azure/azure-service-bus-java/pull/285.patch","issue_url":"https://api.github.com/repos/Azure/azure-service-bus-java/issues/285","number":285,"state":"open","locked":false,"title":"Proxy update","user":{"login":"lee0c","id":13122293,"node_id":"MDQ6VXNlcjEzMTIyMjkz","avatar_url":"https://avatars2.githubusercontent.com/u/13122293?v=4","gravatar_id":"","url":"https://api.github.com/users/lee0c","html_url":"https://github.com/lee0c","followers_url":"https://api.github.com/users/lee0c/followers","following_url":"https://api.github.com/users/lee0c/following{/other_user}","gists_url":"https://api.github.com/users/lee0c/gists{/gist_id}","starred_url":"https://api.github.com/users/lee0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee0c/subscriptions","organizations_url":"https://api.github.com/users/lee0c/orgs","repos_url":"https://api.github.com/users/lee0c/repos","events_url":"https://api.github.com/users/lee0c/events{/privacy}","received_events_url":"https://api.github.com/users/lee0c/received_events","type":"User","site_admin":false},"body":"## Description\r\nUpdate to proxy support to align with updates to Event Hubs proxy support.\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n- [ x ] **I have read the [contribution guidelines](./CONTRIBUTING.md).**\r\n- [ x ] Title of the pull request is clear and informative.\r\n- [ x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR.\r\n- [ x ] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).\r\n- [ x ] If applicable, the public code is properly documented.\r\n- [ x ] Pull request includes test coverage for the included changes.\r\n- [ x ] The code builds without any errors.","created_at":"2018-09-29T00:58:54Z","updated_at":"2018-09-29T01:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f72110e266f4824c562d8df6ac1b17623862cb40","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nemakam","id":24926699,"node_id":"MDQ6VXNlcjI0OTI2Njk5","avatar_url":"https://avatars1.githubusercontent.com/u/24926699?v=4","gravatar_id":"","url":"https://api.github.com/users/nemakam","html_url":"https://github.com/nemakam","followers_url":"https://api.github.com/users/nemakam/followers","following_url":"https://api.github.com/users/nemakam/following{/other_user}","gists_url":"https://api.github.com/users/nemakam/gists{/gist_id}","starred_url":"https://api.github.com/users/nemakam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemakam/subscriptions","organizations_url":"https://api.github.com/users/nemakam/orgs","repos_url":"https://api.github.com/users/nemakam/repos","events_url":"https://api.github.com/users/nemakam/events{/privacy}","received_events_url":"https://api.github.com/users/nemakam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-java/issues/285/comments","statuses_url":"https://api.github.com/repos/Azure/azure-service-bus-java/statuses/79476d100a9af6159f3a172b12993ef9962b9b04","head":{"label":"lee0c:proxy-update","ref":"proxy-update","sha":"79476d100a9af6159f3a172b12993ef9962b9b04","user":{"login":"lee0c","id":13122293,"node_id":"MDQ6VXNlcjEzMTIyMjkz","avatar_url":"https://avatars2.githubusercontent.com/u/13122293?v=4","gravatar_id":"","url":"https://api.github.com/users/lee0c","html_url":"https://github.com/lee0c","followers_url":"https://api.github.com/users/lee0c/followers","following_url":"https://api.github.com/users/lee0c/following{/other_user}","gists_url":"https://api.github.com/users/lee0c/gists{/gist_id}","starred_url":"https://api.github.com/users/lee0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee0c/subscriptions","organizations_url":"https://api.github.com/users/lee0c/orgs","repos_url":"https://api.github.com/users/lee0c/repos","events_url":"https://api.github.com/users/lee0c/events{/privacy}","received_events_url":"https://api.github.com/users/lee0c/received_events","type":"User","site_admin":false},"repo":{"id":145771052,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NzEwNTI=","name":"azure-service-bus-java","full_name":"lee0c/azure-service-bus-java","private":false,"owner":{"login":"lee0c","id":13122293,"node_id":"MDQ6VXNlcjEzMTIyMjkz","avatar_url":"https://avatars2.githubusercontent.com/u/13122293?v=4","gravatar_id":"","url":"https://api.github.com/users/lee0c","html_url":"https://github.com/lee0c","followers_url":"https://api.github.com/users/lee0c/followers","following_url":"https://api.github.com/users/lee0c/following{/other_user}","gists_url":"https://api.github.com/users/lee0c/gists{/gist_id}","starred_url":"https://api.github.com/users/lee0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lee0c/subscriptions","organizations_url":"https://api.github.com/users/lee0c/orgs","repos_url":"https://api.github.com/users/lee0c/repos","events_url":"https://api.github.com/users/lee0c/events{/privacy}","received_events_url":"https://api.github.com/users/lee0c/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lee0c/azure-service-bus-java","description":"☁️ Java client library for Azure Service Bus","fork":true,"url":"https://api.github.com/repos/lee0c/azure-service-bus-java","forks_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/forks","keys_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/teams","hooks_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/hooks","issue_events_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/issues/events{/number}","events_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/events","assignees_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/assignees{/user}","branches_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/branches{/branch}","tags_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/tags","blobs_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/statuses/{sha}","languages_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/languages","stargazers_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/stargazers","contributors_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/contributors","subscribers_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/subscribers","subscription_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/subscription","commits_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/contents/{+path}","compare_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/merges","archive_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/downloads","issues_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/issues{/number}","pulls_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/pulls{/number}","milestones_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/milestones{/number}","notifications_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/labels{/name}","releases_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/releases{/id}","deployments_url":"https://api.github.com/repos/lee0c/azure-service-bus-java/deployments","created_at":"2018-08-22T22:50:25Z","updated_at":"2018-08-22T22:50:27Z","pushed_at":"2018-09-29T00:56:50Z","git_url":"git://github.com/lee0c/azure-service-bus-java.git","ssh_url":"git@github.com:lee0c/azure-service-bus-java.git","clone_url":"https://github.com/lee0c/azure-service-bus-java.git","svn_url":"https://github.com/lee0c/azure-service-bus-java","homepage":"https://azure.microsoft.com/services/service-bus","size":12033,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"c30bb987de218db751f48795e80aa10bba90e398","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":73309646,"node_id":"MDEwOlJlcG9zaXRvcnk3MzMwOTY0Ng==","name":"azure-service-bus-java","full_name":"Azure/azure-service-bus-java","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-service-bus-java","description":"☁️ Java client library for Azure Service Bus","fork":false,"url":"https://api.github.com/repos/Azure/azure-service-bus-java","forks_url":"https://api.github.com/repos/Azure/azure-service-bus-java/forks","keys_url":"https://api.github.com/repos/Azure/azure-service-bus-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-service-bus-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-service-bus-java/teams","hooks_url":"https://api.github.com/repos/Azure/azure-service-bus-java/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-service-bus-java/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-service-bus-java/events","assignees_url":"https://api.github.com/repos/Azure/azure-service-bus-java/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-service-bus-java/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-service-bus-java/tags","blobs_url":"https://api.github.com/repos/Azure/azure-service-bus-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-service-bus-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-service-bus-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-service-bus-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-service-bus-java/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-service-bus-java/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-service-bus-java/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-service-bus-java/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-service-bus-java/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-service-bus-java/subscription","commits_url":"https://api.github.com/repos/Azure/azure-service-bus-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-service-bus-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-service-bus-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-service-bus-java/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-service-bus-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-service-bus-java/merges","archive_url":"https://api.github.com/repos/Azure/azure-service-bus-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-service-bus-java/downloads","issues_url":"https://api.github.com/repos/Azure/azure-service-bus-java/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-service-bus-java/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-service-bus-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-service-bus-java/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-service-bus-java/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-service-bus-java/deployments","created_at":"2016-11-09T18:21:56Z","updated_at":"2018-09-26T22:20:47Z","pushed_at":"2018-09-29T00:58:55Z","git_url":"git://github.com/Azure/azure-service-bus-java.git","ssh_url":"git@github.com:Azure/azure-service-bus-java.git","clone_url":"https://github.com/Azure/azure-service-bus-java.git","svn_url":"https://github.com/Azure/azure-service-bus-java","homepage":"https://azure.microsoft.com/services/service-bus","size":1406,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":30,"watchers":34,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285"},"html":{"href":"https://github.com/Azure/azure-service-bus-java/pull/285"},"issue":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/issues/285"},"comments":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-service-bus-java/statuses/79476d100a9af6159f3a172b12993ef9962b9b04"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yvgopal"}}