{"action":"created","issue":{"url":"https://api.github.com/repos/throneteki/throneteki/issues/2167","repository_url":"https://api.github.com/repos/throneteki/throneteki","labels_url":"https://api.github.com/repos/throneteki/throneteki/issues/2167/labels{/name}","comments_url":"https://api.github.com/repos/throneteki/throneteki/issues/2167/comments","events_url":"https://api.github.com/repos/throneteki/throneteki/issues/2167/events","html_url":"https://github.com/throneteki/throneteki/pull/2167","id":352641583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTAyOTg2","number":2167,"title":"Check maximums for non-event abilities","user":{"login":"ystros","id":145077,"node_id":"MDQ6VXNlcjE0NTA3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/145077?v=4","gravatar_id":"","url":"https://api.github.com/users/ystros","html_url":"https://github.com/ystros","followers_url":"https://api.github.com/users/ystros/followers","following_url":"https://api.github.com/users/ystros/following{/other_user}","gists_url":"https://api.github.com/users/ystros/gists{/gist_id}","starred_url":"https://api.github.com/users/ystros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystros/subscriptions","organizations_url":"https://api.github.com/users/ystros/orgs","repos_url":"https://api.github.com/users/ystros/repos","events_url":"https://api.github.com/users/ystros/events{/privacy}","received_events_url":"https://api.github.com/users/ystros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-21T17:39:06Z","updated_at":"2018-08-22T14:44:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/throneteki/throneteki/pulls/2167","html_url":"https://github.com/throneteki/throneteki/pull/2167","diff_url":"https://github.com/throneteki/throneteki/pull/2167.diff","patch_url":"https://github.com/throneteki/throneteki/pull/2167.patch"},"body":"Previously, only abilities on event cards were being checked for\r\nmaximums, and it was being done as a cost. This led to a bug where the\r\nmax on character / attachment abilities would not be properly enforced.\r\nThe timing would also have been incorrect in the case of the cost being\r\ncancelled (Drowned God Fanatic).\r\n\r\nNow, maximums are enforced when requirements for the ability are\r\nchecked, and marked as used at the same time as limits. This should\r\nensure that Drowned God Fanatic is properly limited to once per round."},"comment":{"url":"https://api.github.com/repos/throneteki/throneteki/issues/comments/415057613","html_url":"https://github.com/throneteki/throneteki/pull/2167#issuecomment-415057613","issue_url":"https://api.github.com/repos/throneteki/throneteki/issues/2167","id":415057613,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTA1NzYxMw==","user":{"login":"ystros","id":145077,"node_id":"MDQ6VXNlcjE0NTA3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/145077?v=4","gravatar_id":"","url":"https://api.github.com/users/ystros","html_url":"https://github.com/ystros","followers_url":"https://api.github.com/users/ystros/followers","following_url":"https://api.github.com/users/ystros/following{/other_user}","gists_url":"https://api.github.com/users/ystros/gists{/gist_id}","starred_url":"https://api.github.com/users/ystros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ystros/subscriptions","organizations_url":"https://api.github.com/users/ystros/orgs","repos_url":"https://api.github.com/users/ystros/repos","events_url":"https://api.github.com/users/ystros/events{/privacy}","received_events_url":"https://api.github.com/users/ystros/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T14:44:34Z","updated_at":"2018-08-22T14:44:34Z","author_association":"CONTRIBUTOR","body":"Correct - limits are already marked as used at step 6 in the code. This PR moves using maxima to the same place. So saving vs costs + limits or maxima will have the correct behavior (once we allow saves vs costs)"}}
{"actor":{"display_login":"ystros"}}