{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/202827775","pull_request_review_id":137600948,"id":202827775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjgyNzc3NQ==","diff_hunk":"@@ -299,8 +299,7 @@ public bool Equals(CopyOnWritePropertyDictionary<T> other)\n         /// </summary>\n         bool IDictionary<string, T>.ContainsKey(string key)\n         {\n-            T discard;\n-            return ((IDictionary<string, T>)this).TryGetValue(key, out discard);\n+            return ((IDictionary<string, T>)this).TryGetValue(key, out _);","path":"src/Build/Collections/CopyOnWritePropertyDictionary.cs","position":null,"original_position":6,"commit_id":"e53212415f197398ae440f075e7dd00abf569272","original_commit_id":"4352948f927097a9e4ea4eeba508c5ac64bf40d2","user":{"login":"MeikTranel","id":6466560,"node_id":"MDQ6VXNlcjY0NjY1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6466560?v=4","gravatar_id":"","url":"https://api.github.com/users/MeikTranel","html_url":"https://github.com/MeikTranel","followers_url":"https://api.github.com/users/MeikTranel/followers","following_url":"https://api.github.com/users/MeikTranel/following{/other_user}","gists_url":"https://api.github.com/users/MeikTranel/gists{/gist_id}","starred_url":"https://api.github.com/users/MeikTranel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeikTranel/subscriptions","organizations_url":"https://api.github.com/users/MeikTranel/orgs","repos_url":"https://api.github.com/users/MeikTranel/repos","events_url":"https://api.github.com/users/MeikTranel/events{/privacy}","received_events_url":"https://api.github.com/users/MeikTranel/received_events","type":"User","site_admin":false},"body":"@cdmihai although it is kind of pointless because the hint @rainersigwald was totally right and improves this further than just the avoided allocation of discard...\r\nwhat happens with the discard underscore in terms of IL? does it just completely avoid the allocation?","created_at":"2018-07-16T21:17:36Z","updated_at":"2018-07-16T21:17:37Z","html_url":"https://github.com/Microsoft/msbuild/pull/3516#discussion_r202827775","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/202827775"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3516#discussion_r202827775"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516","id":201504519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTA0NTE5","html_url":"https://github.com/Microsoft/msbuild/pull/3516","diff_url":"https://github.com/Microsoft/msbuild/pull/3516.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/3516.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3516","number":3516,"state":"open","locked":false,"title":"Unqualified metadata case sensitivity fix","user":{"login":"MeikTranel","id":6466560,"node_id":"MDQ6VXNlcjY0NjY1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6466560?v=4","gravatar_id":"","url":"https://api.github.com/users/MeikTranel","html_url":"https://github.com/MeikTranel","followers_url":"https://api.github.com/users/MeikTranel/followers","following_url":"https://api.github.com/users/MeikTranel/following{/other_user}","gists_url":"https://api.github.com/users/MeikTranel/gists{/gist_id}","starred_url":"https://api.github.com/users/MeikTranel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeikTranel/subscriptions","organizations_url":"https://api.github.com/users/MeikTranel/orgs","repos_url":"https://api.github.com/users/MeikTranel/repos","events_url":"https://api.github.com/users/MeikTranel/events{/privacy}","received_events_url":"https://api.github.com/users/MeikTranel/received_events","type":"User","site_admin":false},"body":"_(This is my first PR in a microsoft repository (or any popular repository for that matter)... so any feedback would be greatly appreciated.)_\r\n\r\nThis PR attempts to fix #2870 \r\n\r\nNote: I wasn't sure were exactly to put the tests. I hope i haven't missed it quite as much 😄 ","created_at":"2018-07-15T16:09:04Z","updated_at":"2018-07-16T21:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c0111d5d92f7ce600c6ccf8969e7b317507b86a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3516/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/e53212415f197398ae440f075e7dd00abf569272","head":{"label":"MeikTranel:UnqualifiedMetadataCaseSensitivityFix","ref":"UnqualifiedMetadataCaseSensitivityFix","sha":"e53212415f197398ae440f075e7dd00abf569272","user":{"login":"MeikTranel","id":6466560,"node_id":"MDQ6VXNlcjY0NjY1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6466560?v=4","gravatar_id":"","url":"https://api.github.com/users/MeikTranel","html_url":"https://github.com/MeikTranel","followers_url":"https://api.github.com/users/MeikTranel/followers","following_url":"https://api.github.com/users/MeikTranel/following{/other_user}","gists_url":"https://api.github.com/users/MeikTranel/gists{/gist_id}","starred_url":"https://api.github.com/users/MeikTranel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeikTranel/subscriptions","organizations_url":"https://api.github.com/users/MeikTranel/orgs","repos_url":"https://api.github.com/users/MeikTranel/repos","events_url":"https://api.github.com/users/MeikTranel/events{/privacy}","received_events_url":"https://api.github.com/users/MeikTranel/received_events","type":"User","site_admin":false},"repo":{"id":139276913,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyNzY5MTM=","name":"msbuild","full_name":"MeikTranel/msbuild","owner":{"login":"MeikTranel","id":6466560,"node_id":"MDQ6VXNlcjY0NjY1NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6466560?v=4","gravatar_id":"","url":"https://api.github.com/users/MeikTranel","html_url":"https://github.com/MeikTranel","followers_url":"https://api.github.com/users/MeikTranel/followers","following_url":"https://api.github.com/users/MeikTranel/following{/other_user}","gists_url":"https://api.github.com/users/MeikTranel/gists{/gist_id}","starred_url":"https://api.github.com/users/MeikTranel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeikTranel/subscriptions","organizations_url":"https://api.github.com/users/MeikTranel/orgs","repos_url":"https://api.github.com/users/MeikTranel/repos","events_url":"https://api.github.com/users/MeikTranel/events{/privacy}","received_events_url":"https://api.github.com/users/MeikTranel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MeikTranel/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/MeikTranel/msbuild","forks_url":"https://api.github.com/repos/MeikTranel/msbuild/forks","keys_url":"https://api.github.com/repos/MeikTranel/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MeikTranel/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MeikTranel/msbuild/teams","hooks_url":"https://api.github.com/repos/MeikTranel/msbuild/hooks","issue_events_url":"https://api.github.com/repos/MeikTranel/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/MeikTranel/msbuild/events","assignees_url":"https://api.github.com/repos/MeikTranel/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/MeikTranel/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/MeikTranel/msbuild/tags","blobs_url":"https://api.github.com/repos/MeikTranel/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MeikTranel/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MeikTranel/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/MeikTranel/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MeikTranel/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/MeikTranel/msbuild/languages","stargazers_url":"https://api.github.com/repos/MeikTranel/msbuild/stargazers","contributors_url":"https://api.github.com/repos/MeikTranel/msbuild/contributors","subscribers_url":"https://api.github.com/repos/MeikTranel/msbuild/subscribers","subscription_url":"https://api.github.com/repos/MeikTranel/msbuild/subscription","commits_url":"https://api.github.com/repos/MeikTranel/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/MeikTranel/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/MeikTranel/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/MeikTranel/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/MeikTranel/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/MeikTranel/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MeikTranel/msbuild/merges","archive_url":"https://api.github.com/repos/MeikTranel/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MeikTranel/msbuild/downloads","issues_url":"https://api.github.com/repos/MeikTranel/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/MeikTranel/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/MeikTranel/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/MeikTranel/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MeikTranel/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/MeikTranel/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/MeikTranel/msbuild/deployments","created_at":"2018-06-30T20:13:00Z","updated_at":"2018-07-15T15:45:29Z","pushed_at":"2018-07-16T21:14:13Z","git_url":"git://github.com/MeikTranel/msbuild.git","ssh_url":"git@github.com:MeikTranel/msbuild.git","clone_url":"https://github.com/MeikTranel/msbuild.git","svn_url":"https://github.com/MeikTranel/msbuild","homepage":null,"size":28614,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"fc13d08cac0717707002a04b49970e3f6243ba54","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"node_id":"MDEwOlJlcG9zaXRvcnkzMjA1MTg5MA==","name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2018-07-16T20:02:24Z","pushed_at":"2018-07-16T21:14:15Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":28671,"stargazers_count":3540,"watchers_count":3540,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":783,"mirror_url":null,"archived":false,"open_issues_count":873,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":783,"open_issues":873,"watchers":3540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3516"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3516"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3516/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3516/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/e53212415f197398ae440f075e7dd00abf569272"}},"author_association":"NONE"}}
{"actor":{"display_login":"MeikTranel"}}