{"action":"created","issue":{"url":"https://api.github.com/repos/rubenv/angular-gettext/issues/350","repository_url":"https://api.github.com/repos/rubenv/angular-gettext","labels_url":"https://api.github.com/repos/rubenv/angular-gettext/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/rubenv/angular-gettext/issues/350/comments","events_url":"https://api.github.com/repos/rubenv/angular-gettext/issues/350/events","html_url":"https://github.com/rubenv/angular-gettext/pull/350","id":300932666,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcxODg1MzY1","number":350,"title":"Fix for #348: XSS vulnerability in getString method","user":{"login":"anx-ckreuzberger","id":18396259,"node_id":"MDQ6VXNlcjE4Mzk2MjU5","avatar_url":"https://avatars2.githubusercontent.com/u/18396259?v=4","gravatar_id":"","url":"https://api.github.com/users/anx-ckreuzberger","html_url":"https://github.com/anx-ckreuzberger","followers_url":"https://api.github.com/users/anx-ckreuzberger/followers","following_url":"https://api.github.com/users/anx-ckreuzberger/following{/other_user}","gists_url":"https://api.github.com/users/anx-ckreuzberger/gists{/gist_id}","starred_url":"https://api.github.com/users/anx-ckreuzberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anx-ckreuzberger/subscriptions","organizations_url":"https://api.github.com/users/anx-ckreuzberger/orgs","repos_url":"https://api.github.com/users/anx-ckreuzberger/repos","events_url":"https://api.github.com/users/anx-ckreuzberger/events{/privacy}","received_events_url":"https://api.github.com/users/anx-ckreuzberger/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-28T08:30:17Z","updated_at":"2018-07-02T08:53:55Z","closed_at":"2018-07-02T08:26:41Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rubenv/angular-gettext/pulls/350","html_url":"https://github.com/rubenv/angular-gettext/pull/350","diff_url":"https://github.com/rubenv/angular-gettext/pull/350.diff","patch_url":"https://github.com/rubenv/angular-gettext/pull/350.patch"},"body":"I have added a failing test for the XSS vulnerability and a possible way to fix it.\r\n\r\nThe main point of this commit is: ``getString`` must not use $interpolate, this is really dangerous... (I had to adapt two existing unit tests for this).\r\n\r\nInstead, we let $compile handle it in the update() method, and we pass a sub-scope to it."},"comment":{"url":"https://api.github.com/repos/rubenv/angular-gettext/issues/comments/401719804","html_url":"https://github.com/rubenv/angular-gettext/pull/350#issuecomment-401719804","issue_url":"https://api.github.com/repos/rubenv/angular-gettext/issues/350","id":401719804,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTcxOTgwNA==","user":{"login":"rubenv","id":42904,"node_id":"MDQ6VXNlcjQyOTA0","avatar_url":"https://avatars0.githubusercontent.com/u/42904?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenv","html_url":"https://github.com/rubenv","followers_url":"https://api.github.com/users/rubenv/followers","following_url":"https://api.github.com/users/rubenv/following{/other_user}","gists_url":"https://api.github.com/users/rubenv/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenv/subscriptions","organizations_url":"https://api.github.com/users/rubenv/orgs","repos_url":"https://api.github.com/users/rubenv/repos","events_url":"https://api.github.com/users/rubenv/events{/privacy}","received_events_url":"https://api.github.com/users/rubenv/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T08:53:55Z","updated_at":"2018-07-02T08:53:55Z","author_association":"OWNER","body":"Published to NPM as `2.4.0`. Many many thanks and apologies again for the delay!"}}
{"actor":{"display_login":"rubenv"}}