{"action":"opened","number":3450,"pull_request":{"url":"https://api.github.com/repos/octobercms/october/pulls/3450","id":174956795,"html_url":"https://github.com/octobercms/october/pull/3450","diff_url":"https://github.com/octobercms/october/pull/3450.diff","patch_url":"https://github.com/octobercms/october/pull/3450.patch","issue_url":"https://api.github.com/repos/octobercms/october/issues/3450","number":3450,"state":"open","locked":false,"title":"Update ImportModel.php","user":{"login":"mcharytoniuk","id":1286785,"avatar_url":"https://avatars2.githubusercontent.com/u/1286785?v=4","gravatar_id":"","url":"https://api.github.com/users/mcharytoniuk","html_url":"https://github.com/mcharytoniuk","followers_url":"https://api.github.com/users/mcharytoniuk/followers","following_url":"https://api.github.com/users/mcharytoniuk/following{/other_user}","gists_url":"https://api.github.com/users/mcharytoniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharytoniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharytoniuk/subscriptions","organizations_url":"https://api.github.com/users/mcharytoniuk/orgs","repos_url":"https://api.github.com/users/mcharytoniuk/repos","events_url":"https://api.github.com/users/mcharytoniuk/events{/privacy}","received_events_url":"https://api.github.com/users/mcharytoniuk/received_events","type":"User","site_admin":false},"body":"While importing over 250k records ImportModel kept running into various problems. One of them was too big memory usage - `ImportModel` loaded the complete file upfront (`$reader->fetchAll()`). Simple one-line change to `$reader->fetch()` makes `ImportModel` import CSV file row-by-row and returning an iterator which limits memory usage and allows data to be imported. This change optimizes memory usage and allows much simpler importing of larger files.","created_at":"2018-03-14T13:36:08Z","updated_at":"2018-03-14T13:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/octobercms/october/pulls/3450/commits","review_comments_url":"https://api.github.com/repos/octobercms/october/pulls/3450/comments","review_comment_url":"https://api.github.com/repos/octobercms/october/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octobercms/october/issues/3450/comments","statuses_url":"https://api.github.com/repos/octobercms/october/statuses/d0c67dc658ba800e812c91ce48349c83beac1388","head":{"label":"mcharytoniuk:patch-1","ref":"patch-1","sha":"d0c67dc658ba800e812c91ce48349c83beac1388","user":{"login":"mcharytoniuk","id":1286785,"avatar_url":"https://avatars2.githubusercontent.com/u/1286785?v=4","gravatar_id":"","url":"https://api.github.com/users/mcharytoniuk","html_url":"https://github.com/mcharytoniuk","followers_url":"https://api.github.com/users/mcharytoniuk/followers","following_url":"https://api.github.com/users/mcharytoniuk/following{/other_user}","gists_url":"https://api.github.com/users/mcharytoniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharytoniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharytoniuk/subscriptions","organizations_url":"https://api.github.com/users/mcharytoniuk/orgs","repos_url":"https://api.github.com/users/mcharytoniuk/repos","events_url":"https://api.github.com/users/mcharytoniuk/events{/privacy}","received_events_url":"https://api.github.com/users/mcharytoniuk/received_events","type":"User","site_admin":false},"repo":{"id":125216990,"name":"october","full_name":"mcharytoniuk/october","owner":{"login":"mcharytoniuk","id":1286785,"avatar_url":"https://avatars2.githubusercontent.com/u/1286785?v=4","gravatar_id":"","url":"https://api.github.com/users/mcharytoniuk","html_url":"https://github.com/mcharytoniuk","followers_url":"https://api.github.com/users/mcharytoniuk/followers","following_url":"https://api.github.com/users/mcharytoniuk/following{/other_user}","gists_url":"https://api.github.com/users/mcharytoniuk/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharytoniuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharytoniuk/subscriptions","organizations_url":"https://api.github.com/users/mcharytoniuk/orgs","repos_url":"https://api.github.com/users/mcharytoniuk/repos","events_url":"https://api.github.com/users/mcharytoniuk/events{/privacy}","received_events_url":"https://api.github.com/users/mcharytoniuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcharytoniuk/october","description":"Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.","fork":true,"url":"https://api.github.com/repos/mcharytoniuk/october","forks_url":"https://api.github.com/repos/mcharytoniuk/october/forks","keys_url":"https://api.github.com/repos/mcharytoniuk/october/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcharytoniuk/october/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcharytoniuk/october/teams","hooks_url":"https://api.github.com/repos/mcharytoniuk/october/hooks","issue_events_url":"https://api.github.com/repos/mcharytoniuk/october/issues/events{/number}","events_url":"https://api.github.com/repos/mcharytoniuk/october/events","assignees_url":"https://api.github.com/repos/mcharytoniuk/october/assignees{/user}","branches_url":"https://api.github.com/repos/mcharytoniuk/october/branches{/branch}","tags_url":"https://api.github.com/repos/mcharytoniuk/october/tags","blobs_url":"https://api.github.com/repos/mcharytoniuk/october/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcharytoniuk/october/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcharytoniuk/october/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcharytoniuk/october/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcharytoniuk/october/statuses/{sha}","languages_url":"https://api.github.com/repos/mcharytoniuk/october/languages","stargazers_url":"https://api.github.com/repos/mcharytoniuk/october/stargazers","contributors_url":"https://api.github.com/repos/mcharytoniuk/october/contributors","subscribers_url":"https://api.github.com/repos/mcharytoniuk/october/subscribers","subscription_url":"https://api.github.com/repos/mcharytoniuk/october/subscription","commits_url":"https://api.github.com/repos/mcharytoniuk/october/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcharytoniuk/october/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcharytoniuk/october/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcharytoniuk/october/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcharytoniuk/october/contents/{+path}","compare_url":"https://api.github.com/repos/mcharytoniuk/october/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcharytoniuk/october/merges","archive_url":"https://api.github.com/repos/mcharytoniuk/october/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcharytoniuk/october/downloads","issues_url":"https://api.github.com/repos/mcharytoniuk/october/issues{/number}","pulls_url":"https://api.github.com/repos/mcharytoniuk/october/pulls{/number}","milestones_url":"https://api.github.com/repos/mcharytoniuk/october/milestones{/number}","notifications_url":"https://api.github.com/repos/mcharytoniuk/october/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcharytoniuk/october/labels{/name}","releases_url":"https://api.github.com/repos/mcharytoniuk/october/releases{/id}","deployments_url":"https://api.github.com/repos/mcharytoniuk/october/deployments","created_at":"2018-03-14T13:30:28Z","updated_at":"2018-03-14T13:30:33Z","pushed_at":"2018-03-14T13:35:08Z","git_url":"git://github.com/mcharytoniuk/october.git","ssh_url":"git@github.com:mcharytoniuk/october.git","clone_url":"https://github.com/mcharytoniuk/october.git","svn_url":"https://github.com/mcharytoniuk/october","homepage":"http://octobercms.com/","size":31130,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"octobercms:develop","ref":"develop","sha":"7a6f1d3c85afd66b5e05ae3f6314e7974091e66c","user":{"login":"octobercms","id":5554805,"avatar_url":"https://avatars3.githubusercontent.com/u/5554805?v=4","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"repo":{"id":14732311,"name":"october","full_name":"octobercms/october","owner":{"login":"octobercms","id":5554805,"avatar_url":"https://avatars3.githubusercontent.com/u/5554805?v=4","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octobercms/october","description":"Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.","fork":false,"url":"https://api.github.com/repos/octobercms/october","forks_url":"https://api.github.com/repos/octobercms/october/forks","keys_url":"https://api.github.com/repos/octobercms/october/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octobercms/october/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octobercms/october/teams","hooks_url":"https://api.github.com/repos/octobercms/october/hooks","issue_events_url":"https://api.github.com/repos/octobercms/october/issues/events{/number}","events_url":"https://api.github.com/repos/octobercms/october/events","assignees_url":"https://api.github.com/repos/octobercms/october/assignees{/user}","branches_url":"https://api.github.com/repos/octobercms/october/branches{/branch}","tags_url":"https://api.github.com/repos/octobercms/october/tags","blobs_url":"https://api.github.com/repos/octobercms/october/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octobercms/october/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octobercms/october/git/refs{/sha}","trees_url":"https://api.github.com/repos/octobercms/october/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octobercms/october/statuses/{sha}","languages_url":"https://api.github.com/repos/octobercms/october/languages","stargazers_url":"https://api.github.com/repos/octobercms/october/stargazers","contributors_url":"https://api.github.com/repos/octobercms/october/contributors","subscribers_url":"https://api.github.com/repos/octobercms/october/subscribers","subscription_url":"https://api.github.com/repos/octobercms/october/subscription","commits_url":"https://api.github.com/repos/octobercms/october/commits{/sha}","git_commits_url":"https://api.github.com/repos/octobercms/october/git/commits{/sha}","comments_url":"https://api.github.com/repos/octobercms/october/comments{/number}","issue_comment_url":"https://api.github.com/repos/octobercms/october/issues/comments{/number}","contents_url":"https://api.github.com/repos/octobercms/october/contents/{+path}","compare_url":"https://api.github.com/repos/octobercms/october/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octobercms/october/merges","archive_url":"https://api.github.com/repos/octobercms/october/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octobercms/october/downloads","issues_url":"https://api.github.com/repos/octobercms/october/issues{/number}","pulls_url":"https://api.github.com/repos/octobercms/october/pulls{/number}","milestones_url":"https://api.github.com/repos/octobercms/october/milestones{/number}","notifications_url":"https://api.github.com/repos/octobercms/october/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octobercms/october/labels{/name}","releases_url":"https://api.github.com/repos/octobercms/october/releases{/id}","deployments_url":"https://api.github.com/repos/octobercms/october/deployments","created_at":"2013-11-26T23:30:43Z","updated_at":"2018-03-14T12:47:14Z","pushed_at":"2018-03-13T09:16:02Z","git_url":"git://github.com/octobercms/october.git","ssh_url":"git@github.com:octobercms/october.git","clone_url":"https://github.com/octobercms/october.git","svn_url":"https://github.com/octobercms/october","homepage":"http://octobercms.com/","size":31130,"stargazers_count":6785,"watchers_count":6785,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1679,"mirror_url":null,"archived":false,"open_issues_count":271,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1679,"open_issues":271,"watchers":6785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octobercms/october/pulls/3450"},"html":{"href":"https://github.com/octobercms/october/pull/3450"},"issue":{"href":"https://api.github.com/repos/octobercms/october/issues/3450"},"comments":{"href":"https://api.github.com/repos/octobercms/october/issues/3450/comments"},"review_comments":{"href":"https://api.github.com/repos/octobercms/october/pulls/3450/comments"},"review_comment":{"href":"https://api.github.com/repos/octobercms/october/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octobercms/october/pulls/3450/commits"},"statuses":{"href":"https://api.github.com/repos/octobercms/october/statuses/d0c67dc658ba800e812c91ce48349c83beac1388"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mcharytoniuk"}}