{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/dmd/issues/8270","repository_url":"https://api.github.com/repos/dlang/dmd","labels_url":"https://api.github.com/repos/dlang/dmd/issues/8270/labels{/name}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8270/comments","events_url":"https://api.github.com/repos/dlang/dmd/issues/8270/events","html_url":"https://github.com/dlang/dmd/pull/8270","id":324744125,"number":8270,"title":"dinterpret.d: move public interface to top of file","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"labels":[{"id":761038261,"url":"https://api.github.com/repos/dlang/dmd/labels/Easy%20Review","name":"Easy Review","color":"0e8a16","default":false},{"id":806268296,"url":"https://api.github.com/repos/dlang/dmd/labels/Refactoring","name":"Refactoring","color":"15db6b","default":false},{"id":502721241,"url":"https://api.github.com/repos/dlang/dmd/labels/auto-merge","name":"auto-merge","color":"d3d3d3","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-20T21:28:08Z","updated_at":"2018-05-23T12:44:27Z","closed_at":"2018-05-21T06:37:10Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8270","html_url":"https://github.com/dlang/dmd/pull/8270","diff_url":"https://github.com/dlang/dmd/pull/8270.diff","patch_url":"https://github.com/dlang/dmd/pull/8270.patch"},"body":"C/C++ code tends to fall an inverted pattern, with the private code on top and the public at the bottom. This comes about because of no forward referencing.\r\n\r\nBut D has forward referencing, so the public interface should be at the top of the file and everything else \"below the fold\" which is completely hidden from other modules."},"comment":{"url":"https://api.github.com/repos/dlang/dmd/issues/comments/391332824","html_url":"https://github.com/dlang/dmd/pull/8270#issuecomment-391332824","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8270","id":391332824,"user":{"login":"nemanja-boric-sociomantic","id":7437552,"avatar_url":"https://avatars2.githubusercontent.com/u/7437552?v=4","gravatar_id":"","url":"https://api.github.com/users/nemanja-boric-sociomantic","html_url":"https://github.com/nemanja-boric-sociomantic","followers_url":"https://api.github.com/users/nemanja-boric-sociomantic/followers","following_url":"https://api.github.com/users/nemanja-boric-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/nemanja-boric-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/nemanja-boric-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemanja-boric-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/nemanja-boric-sociomantic/orgs","repos_url":"https://api.github.com/users/nemanja-boric-sociomantic/repos","events_url":"https://api.github.com/users/nemanja-boric-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/nemanja-boric-sociomantic/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T12:44:27Z","updated_at":"2018-05-23T12:44:27Z","author_association":"CONTRIBUTOR","body":"A suggestion unrelated to the changes done: if your PR has only one commit, instead of writing the description in the github's PR description, you can include it into the commit's body and GitHub will automatically populate the PR description with it. That way the information is included in the git repository as well."}}
{"actor":{"display_login":"nemanja-boric-sociomantic"}}