{"action":"created","issue":{"url":"https://api.github.com/repos/chyh1990/yaml-rust/issues/117","repository_url":"https://api.github.com/repos/chyh1990/yaml-rust","labels_url":"https://api.github.com/repos/chyh1990/yaml-rust/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/chyh1990/yaml-rust/issues/117/comments","events_url":"https://api.github.com/repos/chyh1990/yaml-rust/issues/117/events","html_url":"https://github.com/chyh1990/yaml-rust/pull/117","id":390589631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MzE5MDU5","number":117,"title":"Support `Null` and `NULL` as defined by Core schema","user":{"login":"thibaultdelor","id":693797,"node_id":"MDQ6VXNlcjY5Mzc5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/693797?v=4","gravatar_id":"","url":"https://api.github.com/users/thibaultdelor","html_url":"https://github.com/thibaultdelor","followers_url":"https://api.github.com/users/thibaultdelor/followers","following_url":"https://api.github.com/users/thibaultdelor/following{/other_user}","gists_url":"https://api.github.com/users/thibaultdelor/gists{/gist_id}","starred_url":"https://api.github.com/users/thibaultdelor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thibaultdelor/subscriptions","organizations_url":"https://api.github.com/users/thibaultdelor/orgs","repos_url":"https://api.github.com/users/thibaultdelor/repos","events_url":"https://api.github.com/users/thibaultdelor/events{/privacy}","received_events_url":"https://api.github.com/users/thibaultdelor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T09:29:35Z","updated_at":"2018-12-13T10:11:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/chyh1990/yaml-rust/pulls/117","html_url":"https://github.com/chyh1990/yaml-rust/pull/117","diff_url":"https://github.com/chyh1990/yaml-rust/pull/117.diff","patch_url":"https://github.com/chyh1990/yaml-rust/pull/117.patch"},"body":"According to specification recommended schema, when dealing with null, you can either:\r\n\r\n - accept only `null` according to the [yaml json schema](https://yaml.org/spec/1.2/spec.html#id2803362)\r\n - ` null | Null | NULL | ~` according to the [yaml core schema](https://yaml.org/spec/1.2/spec.html#id2805071)\r\n\r\nWhen emitting `null` you should always emit the canonical form which is `null`.\r\n\r\nAt the moment `yaml-rust` accept only `null` and `~`  and emit `~` which was the [Yaml 1.1 spec](https://yaml.org/type/null.html). (I believe it was changed for compatibility reason with JSON)\r\n\r\nThis PR makes it compatible with the yaml 1.2 core schema by adding support for `Null` and `NULL` and emitting `null`.\r\n\r\n(Build is broken at the moment, See fix in https://github.com/chyh1990/yaml-rust/pull/116)"},"comment":{"url":"https://api.github.com/repos/chyh1990/yaml-rust/issues/comments/446913405","html_url":"https://github.com/chyh1990/yaml-rust/pull/117#issuecomment-446913405","issue_url":"https://api.github.com/repos/chyh1990/yaml-rust/issues/117","id":446913405,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjkxMzQwNQ==","user":{"login":"thibaultdelor","id":693797,"node_id":"MDQ6VXNlcjY5Mzc5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/693797?v=4","gravatar_id":"","url":"https://api.github.com/users/thibaultdelor","html_url":"https://github.com/thibaultdelor","followers_url":"https://api.github.com/users/thibaultdelor/followers","following_url":"https://api.github.com/users/thibaultdelor/following{/other_user}","gists_url":"https://api.github.com/users/thibaultdelor/gists{/gist_id}","starred_url":"https://api.github.com/users/thibaultdelor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thibaultdelor/subscriptions","organizations_url":"https://api.github.com/users/thibaultdelor/orgs","repos_url":"https://api.github.com/users/thibaultdelor/repos","events_url":"https://api.github.com/users/thibaultdelor/events{/privacy}","received_events_url":"https://api.github.com/users/thibaultdelor/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T10:11:07Z","updated_at":"2018-12-13T10:11:07Z","author_association":"NONE","body":"@dtolnay @chyh1990 ping"}}
{"actor":{"display_login":"thibaultdelor"}}