{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/comments/189506269","pull_request_review_id":121696497,"id":189506269,"diff_hunk":"@@ -95,13 +98,19 @@ export function values(specifiedAxis: Axis, model: UnitModel, fieldDef: FieldDef\n     });\n   }\n \n-  if (!vals && fieldDef.bin && fieldDef.type === QUANTITATIVE) {\n-    const domain = model.scaleDomain(channel);\n-    if (domain && domain !== 'unaggregated' && !isSelectionDomain(domain)) { // explicit value\n-      return vals;\n+  if (!vals && fieldDef.type === QUANTITATIVE) {\n+    if (fieldDef.bin) {\n+      const domain = model.scaleDomain(channel);\n+      if (domain && domain !== 'unaggregated' && !isSelectionDomain(domain)) { // explicit value\n+        return vals;\n+      }\n+      const signal = model.getName(`${binToString(fieldDef.bin)}_${fieldDef.field}_bins`);\n+      return {signal: `sequence(${signal}.start, ${signal}.stop + ${signal}.step, ${signal}.step)`};\n+    }\n+    if (specifiedAxis.tickStep) {\n+      const step = specifiedAxis.tickStep;\n+      return {signal: `sequence(domain('${channel}')[0], domain('${channel}')[1] + 1, ${step})`};","path":"src/compile/axis/properties.ts","position":34,"original_position":34,"commit_id":"7d9c334c854624d523c8ed90061f383d96333164","original_commit_id":"7d9c334c854624d523c8ed90061f383d96333164","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars1.githubusercontent.com/u/111269?v=4","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"> `+ 1 `\r\n\r\n`+ ${step}` ?","created_at":"2018-05-21T06:44:19Z","updated_at":"2018-05-21T06:48:13Z","html_url":"https://github.com/vega/vega-lite/pull/3783#discussion_r189506269","pull_request_url":"https://api.github.com/repos/vega/vega-lite/pulls/3783","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments/189506269"},"html":{"href":"https://github.com/vega/vega-lite/pull/3783#discussion_r189506269"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3783"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/3783","id":189294089,"html_url":"https://github.com/vega/vega-lite/pull/3783","diff_url":"https://github.com/vega/vega-lite/pull/3783.diff","patch_url":"https://github.com/vega/vega-lite/pull/3783.patch","issue_url":"https://api.github.com/repos/vega/vega-lite/issues/3783","number":3783,"state":"open","locked":false,"title":"implement tickStep and update unit tests","user":{"login":"sirahd","id":16433906,"avatar_url":"https://avatars3.githubusercontent.com/u/16433906?v=4","gravatar_id":"","url":"https://api.github.com/users/sirahd","html_url":"https://github.com/sirahd","followers_url":"https://api.github.com/users/sirahd/followers","following_url":"https://api.github.com/users/sirahd/following{/other_user}","gists_url":"https://api.github.com/users/sirahd/gists{/gist_id}","starred_url":"https://api.github.com/users/sirahd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirahd/subscriptions","organizations_url":"https://api.github.com/users/sirahd/orgs","repos_url":"https://api.github.com/users/sirahd/repos","events_url":"https://api.github.com/users/sirahd/events{/privacy}","received_events_url":"https://api.github.com/users/sirahd/received_events","type":"User","site_admin":false},"body":"- `tickStep` will auto-generate:\r\n    - `tickCount` = `\"signal\": \"(domain('channel')[1] - domain('channel')[0]) / tickStep + 1\"`\r\n    - `values` = `\"signal\": \"sequence(domain('channel')[0], domain('channel')[1] + 1, 2)\"`","created_at":"2018-05-21T06:33:35Z","updated_at":"2018-05-21T06:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54b280a42cbc611af503ef74bbc02af2e0e8b4f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-lite/pulls/3783/commits","review_comments_url":"https://api.github.com/repos/vega/vega-lite/pulls/3783/comments","review_comment_url":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-lite/issues/3783/comments","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/7d9c334c854624d523c8ed90061f383d96333164","head":{"label":"vega:sh/tickstep","ref":"sh/tickstep","sha":"7d9c334c854624d523c8ed90061f383d96333164","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A concise grammar of interactive graphics, built on Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2018-05-21T06:42:15Z","pushed_at":"2018-05-21T06:33:36Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":79126,"stargazers_count":1279,"watchers_count":1279,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":164,"open_issues":196,"watchers":1279,"default_branch":"master"}},"base":{"label":"vega:feature/prebin","ref":"feature/prebin","sha":"b232c35a43446aad9bb73e45cda842639d338520","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A concise grammar of interactive graphics, built on Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2018-05-21T06:42:15Z","pushed_at":"2018-05-21T06:33:36Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":79126,"stargazers_count":1279,"watchers_count":1279,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":164,"open_issues":196,"watchers":1279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3783"},"html":{"href":"https://github.com/vega/vega-lite/pull/3783"},"issue":{"href":"https://api.github.com/repos/vega/vega-lite/issues/3783"},"comments":{"href":"https://api.github.com/repos/vega/vega-lite/issues/3783/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3783/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3783/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-lite/statuses/7d9c334c854624d523c8ed90061f383d96333164"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kanitw"}}