{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments/179781317","pull_request_review_id":110092447,"id":179781317,"diff_hunk":"@@ -270,6 +270,7 @@ coreos:\n             {{end -}}\n \n             [Service]\n+            Type=simple","path":"core/controlplane/config/templates/cloud-config-etcd","position":4,"original_position":4,"commit_id":"e05563249601773f1cc34d4e42e81e3a682a28fd","original_commit_id":"e05563249601773f1cc34d4e42e81e3a682a28fd","user":{"login":"davidmccormick","id":1453938,"avatar_url":"https://avatars1.githubusercontent.com/u/1453938?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmccormick","html_url":"https://github.com/davidmccormick","followers_url":"https://api.github.com/users/davidmccormick/followers","following_url":"https://api.github.com/users/davidmccormick/following{/other_user}","gists_url":"https://api.github.com/users/davidmccormick/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmccormick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmccormick/subscriptions","organizations_url":"https://api.github.com/users/davidmccormick/orgs","repos_url":"https://api.github.com/users/davidmccormick/repos","events_url":"https://api.github.com/users/davidmccormick/events{/privacy}","received_events_url":"https://api.github.com/users/davidmccormick/received_events","type":"User","site_admin":false},"body":"Yes, no problem - I keep on adding it for my testing as my clusters fail to spin up properly without manual intervention. :)\r\n","created_at":"2018-04-06T14:48:14Z","updated_at":"2018-04-06T14:48:14Z","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1220#discussion_r179781317","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments/179781317"},"html":{"href":"https://github.com/kubernetes-incubator/kube-aws/pull/1220#discussion_r179781317"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220"}},"in_reply_to_id":179771183},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220","id":179415286,"html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1220","diff_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1220.diff","patch_url":"https://github.com/kubernetes-incubator/kube-aws/pull/1220.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1220","number":1220,"state":"open","locked":false,"title":"Make sure that servers roll when there are data changes","user":{"login":"davidmccormick","id":1453938,"avatar_url":"https://avatars1.githubusercontent.com/u/1453938?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmccormick","html_url":"https://github.com/davidmccormick","followers_url":"https://api.github.com/users/davidmccormick/followers","following_url":"https://api.github.com/users/davidmccormick/following{/other_user}","gists_url":"https://api.github.com/users/davidmccormick/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmccormick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmccormick/subscriptions","organizations_url":"https://api.github.com/users/davidmccormick/orgs","repos_url":"https://api.github.com/users/davidmccormick/repos","events_url":"https://api.github.com/users/davidmccormick/events{/privacy}","received_events_url":"https://api.github.com/users/davidmccormick/received_events","type":"User","site_admin":false},"body":"Please see issue https://github.com/kubernetes-incubator/kube-aws/issues/1218 for a description of the problem - which is that nodes are not rolling when purely cluster.yaml changes are being made, only when there are changes to the templates.\r\n\r\nThis pull request shows that it is possible to insert a fingerprint into the 'instance' userdata which will trigger rolls where the templates haven't changed but selected features have changed in the cluster.yaml. \r\n\r\nAs part of this change, I've made the nodes, controllers and etcd servers all act the same in how they load their data and call out for cloud-formation stack details.","created_at":"2018-04-04T14:47:42Z","updated_at":"2018-04-06T14:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bfb0671fb99f262083b91149759f86aa6d6fb72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":561748249,"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":759013453,"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1220/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/statuses/e05563249601773f1cc34d4e42e81e3a682a28fd","head":{"label":"HotelsDotCom:feature/RUN-1050-hash-cloud-config","ref":"feature/RUN-1050-hash-cloud-config","sha":"e05563249601773f1cc34d4e42e81e3a682a28fd","user":{"login":"HotelsDotCom","id":8900689,"avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"repo":{"id":78134810,"name":"kube-aws","full_name":"HotelsDotCom/kube-aws","owner":{"login":"HotelsDotCom","id":8900689,"avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HotelsDotCom/kube-aws","description":"CoreOS Kubernetes on AWS","fork":true,"url":"https://api.github.com/repos/HotelsDotCom/kube-aws","forks_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/forks","keys_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/teams","hooks_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/hooks","issue_events_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/issues/events{/number}","events_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/events","assignees_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/assignees{/user}","branches_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/branches{/branch}","tags_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/tags","blobs_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/languages","stargazers_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/stargazers","contributors_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/contributors","subscribers_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/subscribers","subscription_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/subscription","commits_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/contents/{+path}","compare_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/merges","archive_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/downloads","issues_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/issues{/number}","pulls_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/labels{/name}","releases_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/releases{/id}","deployments_url":"https://api.github.com/repos/HotelsDotCom/kube-aws/deployments","created_at":"2017-01-05T17:45:25Z","updated_at":"2018-04-05T11:08:56Z","pushed_at":"2018-04-06T13:37:00Z","git_url":"git://github.com/HotelsDotCom/kube-aws.git","ssh_url":"git@github.com:HotelsDotCom/kube-aws.git","clone_url":"https://github.com/HotelsDotCom/kube-aws.git","svn_url":"https://github.com/HotelsDotCom/kube-aws","homepage":null,"size":38967,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"548bb386dd14dbee7d9c9fc012e2b3a4fe5c6b75","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":70860688,"name":"kube-aws","full_name":"kubernetes-incubator/kube-aws","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kube-aws","description":"Kubernetes on AWS","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws","forks_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/deployments","created_at":"2016-10-14T00:57:33Z","updated_at":"2018-04-06T12:22:53Z","pushed_at":"2018-04-06T14:41:27Z","git_url":"git://github.com/kubernetes-incubator/kube-aws.git","ssh_url":"git@github.com:kubernetes-incubator/kube-aws.git","clone_url":"https://github.com/kubernetes-incubator/kube-aws.git","svn_url":"https://github.com/kubernetes-incubator/kube-aws","homepage":"","size":37251,"stargazers_count":686,"watchers_count":686,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":192,"open_issues":248,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220"},"html":{"href":"https://github.com/kubernetes-incubator/kube-aws/pull/1220"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1220"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/1220/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/1220/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kube-aws/statuses/e05563249601773f1cc34d4e42e81e3a682a28fd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidmccormick"}}