{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/Docusaurus/issues/477","repository_url":"https://api.github.com/repos/facebook/Docusaurus","labels_url":"https://api.github.com/repos/facebook/Docusaurus/issues/477/labels{/name}","comments_url":"https://api.github.com/repos/facebook/Docusaurus/issues/477/comments","events_url":"https://api.github.com/repos/facebook/Docusaurus/issues/477/events","html_url":"https://github.com/facebook/Docusaurus/pull/477","id":300989896,"number":477,"title":"Add missing i18n support in header link","user":{"login":"cheercroaker","id":18077405,"avatar_url":"https://avatars1.githubusercontent.com/u/18077405?v=4","gravatar_id":"","url":"https://api.github.com/users/cheercroaker","html_url":"https://github.com/cheercroaker","followers_url":"https://api.github.com/users/cheercroaker/followers","following_url":"https://api.github.com/users/cheercroaker/following{/other_user}","gists_url":"https://api.github.com/users/cheercroaker/gists{/gist_id}","starred_url":"https://api.github.com/users/cheercroaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheercroaker/subscriptions","organizations_url":"https://api.github.com/users/cheercroaker/orgs","repos_url":"https://api.github.com/users/cheercroaker/repos","events_url":"https://api.github.com/users/cheercroaker/events{/privacy}","received_events_url":"https://api.github.com/users/cheercroaker/received_events","type":"User","site_admin":false},"labels":[{"id":630651545,"url":"https://api.github.com/repos/facebook/Docusaurus/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false},{"id":796471977,"url":"https://api.github.com/repos/facebook/Docusaurus/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-28T11:32:13Z","updated_at":"2018-02-28T16:52:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/facebook/Docusaurus/pulls/477","html_url":"https://github.com/facebook/Docusaurus/pull/477","diff_url":"https://github.com/facebook/Docusaurus/pull/477.diff","patch_url":"https://github.com/facebook/Docusaurus/pull/477.patch"},"body":"Hello and thank you for this project!\r\n\r\n## Motivation\r\n\r\nI have noticed that the link to go to the \"main\" page in the navigation header (the one in the upper-left corner, with the header icon) was always targeting the page in the default—`en`—language, even if localization is enabled and another language was selected (e.f. `fr`).\r\nI think this is something that has been forgotten as I expected the link to take the currently selected language into account.\r\n\r\n### Have you read the [Contributing Guidelines on pull requests](https://github.com/facebook/Docusaurus/blob/master/CONTRIBUTING.md#pull-requests)?\r\n\r\nYes.\r\n\r\nAs this is a very small modification, I quickly tried to set up a local working environment to be able to run \"prettier\" and \"Jest tests\", but could not get it working within a 2 mn time box so I admit I skipped those steps.\r\nI made sure the line was still < 80 characters (which was not before I read the Contributing Guidelines) and had the right number of spaces for indentation though.\r\nDisclaimer: I am not a JavaScript/JSX developer.\r\n\r\n## Test Plan\r\n\r\n1. Have a site with translation enabled and at least another language in addition to English.\r\n\r\n2. Go to the main page of the site\r\n\r\n3. Change language with the drop-down on the upper-right corner\r\n\r\n4. Check that the link to the main page in the upper-left corner,—in the navigation header, the one with the header icon—correctly targets the main page in the selected language\r\n\r\n## Related PRs\r\n\r\nNone (as far as I've looked for).\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/Docusaurus/issues/comments/369304518","html_url":"https://github.com/facebook/Docusaurus/pull/477#issuecomment-369304518","issue_url":"https://api.github.com/repos/facebook/Docusaurus/issues/477","id":369304518,"user":{"login":"cheercroaker","id":18077405,"avatar_url":"https://avatars1.githubusercontent.com/u/18077405?v=4","gravatar_id":"","url":"https://api.github.com/users/cheercroaker","html_url":"https://github.com/cheercroaker","followers_url":"https://api.github.com/users/cheercroaker/followers","following_url":"https://api.github.com/users/cheercroaker/following{/other_user}","gists_url":"https://api.github.com/users/cheercroaker/gists{/gist_id}","starred_url":"https://api.github.com/users/cheercroaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheercroaker/subscriptions","organizations_url":"https://api.github.com/users/cheercroaker/orgs","repos_url":"https://api.github.com/users/cheercroaker/repos","events_url":"https://api.github.com/users/cheercroaker/events{/privacy}","received_events_url":"https://api.github.com/users/cheercroaker/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T16:52:57Z","updated_at":"2018-02-28T16:52:57Z","author_association":"NONE","body":"ci/circleci test initially failed because of the prettier check, so I finally was able to run prettier locally to format the file according to the formatting rules.\r\n\r\n(`npm run prettier` does not work on my configuration, it's saying `No such file or directory: 'format:source'`,—whether I use npm or yarn directly—so I searched a bit more and found I could do `npm run format:source` directly after having installed prettier and to format the file with it, hence my second commit)"}}
{"actor":{"display_login":"cheercroaker"}}