{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/215863609","pull_request_review_id":153223438,"id":215863609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTg2MzYwOQ==","diff_hunk":"@@ -337,6 +339,25 @@ void main() {\n     });\n   }\n \n+  testWidgets('Arrow icon aligns with the edge of button when expanded', (WidgetTester tester) async {\n+    final Key buttonKey = new UniqueKey();\n+\n+    Widget build() =>\n+        buildFrame(buttonKey: buttonKey, value: 'two', isExpanded: true);\n+\n+    await tester.pumpWidget(build());\n+    final RenderBox buttonBox = tester.renderObject(find.byKey(buttonKey));\n+    assert(buttonBox.attached);\n+\n+    final RenderBox arrowIcon =\n+        tester.renderObject(find.byIcon(Icons.arrow_drop_down));","path":"packages/flutter/test/material/dropdown_test.dart","position":31,"original_position":31,"commit_id":"5e48471404f356061d9cfc9dd2cd4b3a3c19d54d","original_commit_id":"5e48471404f356061d9cfc9dd2cd4b3a3c19d54d","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"definitely don't wrap this since it hides that this code is basically identical to line 349","created_at":"2018-09-07T07:02:27Z","updated_at":"2018-09-07T07:02:27Z","html_url":"https://github.com/flutter/flutter/pull/21515#discussion_r215863609","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/21515","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/215863609"},"html":{"href":"https://github.com/flutter/flutter/pull/21515#discussion_r215863609"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21515"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/21515","id":213760620,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzYwNjIw","html_url":"https://github.com/flutter/flutter/pull/21515","diff_url":"https://github.com/flutter/flutter/pull/21515.diff","patch_url":"https://github.com/flutter/flutter/pull/21515.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/21515","number":21515,"state":"open","locked":false,"title":"Expand DropdownButton based on isExpanded flag","user":{"login":"mklim","id":4615911,"node_id":"MDQ6VXNlcjQ2MTU5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4615911?v=4","gravatar_id":"","url":"https://api.github.com/users/mklim","html_url":"https://github.com/mklim","followers_url":"https://api.github.com/users/mklim/followers","following_url":"https://api.github.com/users/mklim/following{/other_user}","gists_url":"https://api.github.com/users/mklim/gists{/gist_id}","starred_url":"https://api.github.com/users/mklim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklim/subscriptions","organizations_url":"https://api.github.com/users/mklim/orgs","repos_url":"https://api.github.com/users/mklim/repos","events_url":"https://api.github.com/users/mklim/events{/privacy}","received_events_url":"https://api.github.com/users/mklim/received_events","type":"User","site_admin":false},"body":"Fixes #13135, #16606","created_at":"2018-09-06T21:50:13Z","updated_at":"2018-09-07T07:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9768f2e74fa1895e4070df2608819b709ce9f1b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"HansMuller","id":1377460,"node_id":"MDQ6VXNlcjEzNzc0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1377460?v=4","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/21515/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/21515/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/21515/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/5e48471404f356061d9cfc9dd2cd4b3a3c19d54d","head":{"label":"mklim:dropdown","ref":"dropdown","sha":"5e48471404f356061d9cfc9dd2cd4b3a3c19d54d","user":{"login":"mklim","id":4615911,"node_id":"MDQ6VXNlcjQ2MTU5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4615911?v=4","gravatar_id":"","url":"https://api.github.com/users/mklim","html_url":"https://github.com/mklim","followers_url":"https://api.github.com/users/mklim/followers","following_url":"https://api.github.com/users/mklim/following{/other_user}","gists_url":"https://api.github.com/users/mklim/gists{/gist_id}","starred_url":"https://api.github.com/users/mklim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklim/subscriptions","organizations_url":"https://api.github.com/users/mklim/orgs","repos_url":"https://api.github.com/users/mklim/repos","events_url":"https://api.github.com/users/mklim/events{/privacy}","received_events_url":"https://api.github.com/users/mklim/received_events","type":"User","site_admin":false},"repo":{"id":146655741,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NTU3NDE=","name":"flutter","full_name":"mklim/flutter","owner":{"login":"mklim","id":4615911,"node_id":"MDQ6VXNlcjQ2MTU5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4615911?v=4","gravatar_id":"","url":"https://api.github.com/users/mklim","html_url":"https://github.com/mklim","followers_url":"https://api.github.com/users/mklim/followers","following_url":"https://api.github.com/users/mklim/following{/other_user}","gists_url":"https://api.github.com/users/mklim/gists{/gist_id}","starred_url":"https://api.github.com/users/mklim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklim/subscriptions","organizations_url":"https://api.github.com/users/mklim/orgs","repos_url":"https://api.github.com/users/mklim/repos","events_url":"https://api.github.com/users/mklim/events{/privacy}","received_events_url":"https://api.github.com/users/mklim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mklim/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/mklim/flutter","forks_url":"https://api.github.com/repos/mklim/flutter/forks","keys_url":"https://api.github.com/repos/mklim/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mklim/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mklim/flutter/teams","hooks_url":"https://api.github.com/repos/mklim/flutter/hooks","issue_events_url":"https://api.github.com/repos/mklim/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/mklim/flutter/events","assignees_url":"https://api.github.com/repos/mklim/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/mklim/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/mklim/flutter/tags","blobs_url":"https://api.github.com/repos/mklim/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mklim/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mklim/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mklim/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mklim/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/mklim/flutter/languages","stargazers_url":"https://api.github.com/repos/mklim/flutter/stargazers","contributors_url":"https://api.github.com/repos/mklim/flutter/contributors","subscribers_url":"https://api.github.com/repos/mklim/flutter/subscribers","subscription_url":"https://api.github.com/repos/mklim/flutter/subscription","commits_url":"https://api.github.com/repos/mklim/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mklim/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mklim/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mklim/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mklim/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/mklim/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mklim/flutter/merges","archive_url":"https://api.github.com/repos/mklim/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mklim/flutter/downloads","issues_url":"https://api.github.com/repos/mklim/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/mklim/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/mklim/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/mklim/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mklim/flutter/labels{/name}","releases_url":"https://api.github.com/repos/mklim/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/mklim/flutter/deployments","created_at":"2018-08-29T20:35:47Z","updated_at":"2018-09-06T17:23:15Z","pushed_at":"2018-09-06T22:09:36Z","git_url":"git://github.com/mklim/flutter.git","ssh_url":"git@github.com:mklim/flutter.git","clone_url":"https://github.com/mklim/flutter.git","svn_url":"https://github.com/mklim/flutter","homepage":"https://flutter.io","size":45533,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"e2167b9f531bb4b608b32de2fcbd29b0ee84c54d","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-09-07T07:00:10Z","pushed_at":"2018-09-07T06:08:29Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":45568,"stargazers_count":36752,"watchers_count":36752,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3433,"mirror_url":null,"archived":false,"open_issues_count":3731,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3433,"open_issues":3731,"watchers":36752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21515"},"html":{"href":"https://github.com/flutter/flutter/pull/21515"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/21515"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/21515/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21515/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21515/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/5e48471404f356061d9cfc9dd2cd4b3a3c19d54d"}},"author_association":"NONE"}}
{"actor":{"display_login":"Hixie"}}