{"action":"created","comment":{"url":"https://api.github.com/repos/poetapp/node/pulls/comments/219943515","pull_request_review_id":158238510,"id":219943515,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk0MzUxNQ==","diff_hunk":"@@ -31,6 +31,7 @@ export class Router {\n   private readonly koa = new Koa()\n   private readonly koaRouter = new KoaRouter()\n   private readonly workController: WorkController\n+  private server: any","path":"src/API/Router.ts","position":4,"original_position":4,"commit_id":"e9516f8de20f7e1055628ae5a248dcc9b09c4644","original_commit_id":"165fceb0c6c0387834c377dc506d9f702625a488","user":{"login":"kennylavender","id":5175120,"node_id":"MDQ6VXNlcjUxNzUxMjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5175120?v=4","gravatar_id":"","url":"https://api.github.com/users/kennylavender","html_url":"https://github.com/kennylavender","followers_url":"https://api.github.com/users/kennylavender/followers","following_url":"https://api.github.com/users/kennylavender/following{/other_user}","gists_url":"https://api.github.com/users/kennylavender/gists{/gist_id}","starred_url":"https://api.github.com/users/kennylavender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennylavender/subscriptions","organizations_url":"https://api.github.com/users/kennylavender/orgs","repos_url":"https://api.github.com/users/kennylavender/repos","events_url":"https://api.github.com/users/kennylavender/events{/privacy}","received_events_url":"https://api.github.com/users/kennylavender/received_events","type":"User","site_admin":false},"body":"koa.server.listen() returns a node Http server\r\n\r\n```\r\nimport * as Http from 'http'\r\n```\r\n\r\n```\r\nprivate server: Http.Server\r\n```","created_at":"2018-09-24T18:34:59Z","updated_at":"2018-09-24T18:34:59Z","html_url":"https://github.com/poetapp/node/pull/476#discussion_r219943515","pull_request_url":"https://api.github.com/repos/poetapp/node/pulls/476","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/poetapp/node/pulls/comments/219943515"},"html":{"href":"https://github.com/poetapp/node/pull/476#discussion_r219943515"},"pull_request":{"href":"https://api.github.com/repos/poetapp/node/pulls/476"}},"in_reply_to_id":219892843},"pull_request":{"url":"https://api.github.com/repos/poetapp/node/pulls/476","id":217517873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTE3ODcz","html_url":"https://github.com/poetapp/node/pull/476","diff_url":"https://github.com/poetapp/node/pull/476.diff","patch_url":"https://github.com/poetapp/node/pull/476.patch","issue_url":"https://api.github.com/repos/poetapp/node/issues/476","number":476,"state":"open","locked":false,"title":"adds stop functionality to app","user":{"login":"warrenv","id":30159,"node_id":"MDQ6VXNlcjMwMTU5","avatar_url":"https://avatars1.githubusercontent.com/u/30159?v=4","gravatar_id":"","url":"https://api.github.com/users/warrenv","html_url":"https://github.com/warrenv","followers_url":"https://api.github.com/users/warrenv/followers","following_url":"https://api.github.com/users/warrenv/following{/other_user}","gists_url":"https://api.github.com/users/warrenv/gists{/gist_id}","starred_url":"https://api.github.com/users/warrenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrenv/subscriptions","organizations_url":"https://api.github.com/users/warrenv/orgs","repos_url":"https://api.github.com/users/warrenv/repos","events_url":"https://api.github.com/users/warrenv/events{/privacy}","received_events_url":"https://api.github.com/users/warrenv/received_events","type":"User","site_admin":false},"body":"\r\n\r\n[PR Process](https://github.com/poetapp/documentation/blob/master/process/pr-review.md#pr-process) - [PR Review Checklist](https://github.com/poetapp/documentation/blob/master/process/pr-review.md#pr-review-checklist)\r\n\r\n### Release\r\n Semantic release is enabled for this repository. Make sure you follow the right commit message convention. \r\n We're using semantic-release's default — [Angular Commit Message Conventions](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines).\r\n\r\n## Description of Changes\r\n\r\nFixes #475\r\n\r\nPreviously, there was no way to gracefully shutdown the app.\r\n\r\nThis commit adds `stop()` functions to `main()` in `src/index.ts` (and\r\nother modules as necessary) which cause the nodejs event loop to exit.\r\n\r\nThis refactor is necessary in order to control the startup configuration\r\n(ports, database name, etc) inside integration and functional tests. It\r\nalso helps conserve resources in backend services by cleanly shutting\r\ndown connections.","created_at":"2018-09-23T16:25:23Z","updated_at":"2018-09-24T18:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fa291dce1fe949e8009228cea6a970860a04596","assignee":{"login":"warrenv","id":30159,"node_id":"MDQ6VXNlcjMwMTU5","avatar_url":"https://avatars1.githubusercontent.com/u/30159?v=4","gravatar_id":"","url":"https://api.github.com/users/warrenv","html_url":"https://github.com/warrenv","followers_url":"https://api.github.com/users/warrenv/followers","following_url":"https://api.github.com/users/warrenv/following{/other_user}","gists_url":"https://api.github.com/users/warrenv/gists{/gist_id}","starred_url":"https://api.github.com/users/warrenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrenv/subscriptions","organizations_url":"https://api.github.com/users/warrenv/orgs","repos_url":"https://api.github.com/users/warrenv/repos","events_url":"https://api.github.com/users/warrenv/events{/privacy}","received_events_url":"https://api.github.com/users/warrenv/received_events","type":"User","site_admin":false},"assignees":[{"login":"warrenv","id":30159,"node_id":"MDQ6VXNlcjMwMTU5","avatar_url":"https://avatars1.githubusercontent.com/u/30159?v=4","gravatar_id":"","url":"https://api.github.com/users/warrenv","html_url":"https://github.com/warrenv","followers_url":"https://api.github.com/users/warrenv/followers","following_url":"https://api.github.com/users/warrenv/following{/other_user}","gists_url":"https://api.github.com/users/warrenv/gists{/gist_id}","starred_url":"https://api.github.com/users/warrenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrenv/subscriptions","organizations_url":"https://api.github.com/users/warrenv/orgs","repos_url":"https://api.github.com/users/warrenv/repos","events_url":"https://api.github.com/users/warrenv/events{/privacy}","received_events_url":"https://api.github.com/users/warrenv/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wzalazar","id":5795257,"node_id":"MDQ6VXNlcjU3OTUyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/5795257?v=4","gravatar_id":"","url":"https://api.github.com/users/wzalazar","html_url":"https://github.com/wzalazar","followers_url":"https://api.github.com/users/wzalazar/followers","following_url":"https://api.github.com/users/wzalazar/following{/other_user}","gists_url":"https://api.github.com/users/wzalazar/gists{/gist_id}","starred_url":"https://api.github.com/users/wzalazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzalazar/subscriptions","organizations_url":"https://api.github.com/users/wzalazar/orgs","repos_url":"https://api.github.com/users/wzalazar/repos","events_url":"https://api.github.com/users/wzalazar/events{/privacy}","received_events_url":"https://api.github.com/users/wzalazar/received_events","type":"User","site_admin":false},{"login":"geoffturk","id":32190662,"node_id":"MDQ6VXNlcjMyMTkwNjYy","avatar_url":"https://avatars3.githubusercontent.com/u/32190662?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffturk","html_url":"https://github.com/geoffturk","followers_url":"https://api.github.com/users/geoffturk/followers","following_url":"https://api.github.com/users/geoffturk/following{/other_user}","gists_url":"https://api.github.com/users/geoffturk/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffturk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffturk/subscriptions","organizations_url":"https://api.github.com/users/geoffturk/orgs","repos_url":"https://api.github.com/users/geoffturk/repos","events_url":"https://api.github.com/users/geoffturk/events{/privacy}","received_events_url":"https://api.github.com/users/geoffturk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poetapp/node/pulls/476/commits","review_comments_url":"https://api.github.com/repos/poetapp/node/pulls/476/comments","review_comment_url":"https://api.github.com/repos/poetapp/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poetapp/node/issues/476/comments","statuses_url":"https://api.github.com/repos/poetapp/node/statuses/e9516f8de20f7e1055628ae5a248dcc9b09c4644","head":{"label":"poetapp:add_stop_functionality","ref":"add_stop_functionality","sha":"e9516f8de20f7e1055628ae5a248dcc9b09c4644","user":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"repo":{"id":108142666,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNDI2NjY=","name":"node","full_name":"poetapp/node","private":false,"owner":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poetapp/node","description":"The Po.et Node allows you to timestamp documents in a decentralized manner.","fork":false,"url":"https://api.github.com/repos/poetapp/node","forks_url":"https://api.github.com/repos/poetapp/node/forks","keys_url":"https://api.github.com/repos/poetapp/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poetapp/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poetapp/node/teams","hooks_url":"https://api.github.com/repos/poetapp/node/hooks","issue_events_url":"https://api.github.com/repos/poetapp/node/issues/events{/number}","events_url":"https://api.github.com/repos/poetapp/node/events","assignees_url":"https://api.github.com/repos/poetapp/node/assignees{/user}","branches_url":"https://api.github.com/repos/poetapp/node/branches{/branch}","tags_url":"https://api.github.com/repos/poetapp/node/tags","blobs_url":"https://api.github.com/repos/poetapp/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poetapp/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poetapp/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/poetapp/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poetapp/node/statuses/{sha}","languages_url":"https://api.github.com/repos/poetapp/node/languages","stargazers_url":"https://api.github.com/repos/poetapp/node/stargazers","contributors_url":"https://api.github.com/repos/poetapp/node/contributors","subscribers_url":"https://api.github.com/repos/poetapp/node/subscribers","subscription_url":"https://api.github.com/repos/poetapp/node/subscription","commits_url":"https://api.github.com/repos/poetapp/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/poetapp/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/poetapp/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/poetapp/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/poetapp/node/contents/{+path}","compare_url":"https://api.github.com/repos/poetapp/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poetapp/node/merges","archive_url":"https://api.github.com/repos/poetapp/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poetapp/node/downloads","issues_url":"https://api.github.com/repos/poetapp/node/issues{/number}","pulls_url":"https://api.github.com/repos/poetapp/node/pulls{/number}","milestones_url":"https://api.github.com/repos/poetapp/node/milestones{/number}","notifications_url":"https://api.github.com/repos/poetapp/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poetapp/node/labels{/name}","releases_url":"https://api.github.com/repos/poetapp/node/releases{/id}","deployments_url":"https://api.github.com/repos/poetapp/node/deployments","created_at":"2017-10-24T14:58:14Z","updated_at":"2018-09-24T15:51:02Z","pushed_at":"2018-09-24T16:57:33Z","git_url":"git://github.com/poetapp/node.git","ssh_url":"git@github.com:poetapp/node.git","clone_url":"https://github.com/poetapp/node.git","svn_url":"https://github.com/poetapp/node","homepage":"","size":3202,"stargazers_count":142,"watchers_count":142,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":64,"watchers":142,"default_branch":"master"}},"base":{"label":"poetapp:master","ref":"master","sha":"9ea71ad86f92c1685f30bc54f4ac7e27b3df0a7e","user":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"repo":{"id":108142666,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNDI2NjY=","name":"node","full_name":"poetapp/node","private":false,"owner":{"login":"poetapp","id":24881331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODgxMzMx","avatar_url":"https://avatars0.githubusercontent.com/u/24881331?v=4","gravatar_id":"","url":"https://api.github.com/users/poetapp","html_url":"https://github.com/poetapp","followers_url":"https://api.github.com/users/poetapp/followers","following_url":"https://api.github.com/users/poetapp/following{/other_user}","gists_url":"https://api.github.com/users/poetapp/gists{/gist_id}","starred_url":"https://api.github.com/users/poetapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poetapp/subscriptions","organizations_url":"https://api.github.com/users/poetapp/orgs","repos_url":"https://api.github.com/users/poetapp/repos","events_url":"https://api.github.com/users/poetapp/events{/privacy}","received_events_url":"https://api.github.com/users/poetapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/poetapp/node","description":"The Po.et Node allows you to timestamp documents in a decentralized manner.","fork":false,"url":"https://api.github.com/repos/poetapp/node","forks_url":"https://api.github.com/repos/poetapp/node/forks","keys_url":"https://api.github.com/repos/poetapp/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poetapp/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poetapp/node/teams","hooks_url":"https://api.github.com/repos/poetapp/node/hooks","issue_events_url":"https://api.github.com/repos/poetapp/node/issues/events{/number}","events_url":"https://api.github.com/repos/poetapp/node/events","assignees_url":"https://api.github.com/repos/poetapp/node/assignees{/user}","branches_url":"https://api.github.com/repos/poetapp/node/branches{/branch}","tags_url":"https://api.github.com/repos/poetapp/node/tags","blobs_url":"https://api.github.com/repos/poetapp/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poetapp/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poetapp/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/poetapp/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poetapp/node/statuses/{sha}","languages_url":"https://api.github.com/repos/poetapp/node/languages","stargazers_url":"https://api.github.com/repos/poetapp/node/stargazers","contributors_url":"https://api.github.com/repos/poetapp/node/contributors","subscribers_url":"https://api.github.com/repos/poetapp/node/subscribers","subscription_url":"https://api.github.com/repos/poetapp/node/subscription","commits_url":"https://api.github.com/repos/poetapp/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/poetapp/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/poetapp/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/poetapp/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/poetapp/node/contents/{+path}","compare_url":"https://api.github.com/repos/poetapp/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poetapp/node/merges","archive_url":"https://api.github.com/repos/poetapp/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poetapp/node/downloads","issues_url":"https://api.github.com/repos/poetapp/node/issues{/number}","pulls_url":"https://api.github.com/repos/poetapp/node/pulls{/number}","milestones_url":"https://api.github.com/repos/poetapp/node/milestones{/number}","notifications_url":"https://api.github.com/repos/poetapp/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poetapp/node/labels{/name}","releases_url":"https://api.github.com/repos/poetapp/node/releases{/id}","deployments_url":"https://api.github.com/repos/poetapp/node/deployments","created_at":"2017-10-24T14:58:14Z","updated_at":"2018-09-24T15:51:02Z","pushed_at":"2018-09-24T16:57:33Z","git_url":"git://github.com/poetapp/node.git","ssh_url":"git@github.com:poetapp/node.git","clone_url":"https://github.com/poetapp/node.git","svn_url":"https://github.com/poetapp/node","homepage":"","size":3202,"stargazers_count":142,"watchers_count":142,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":64,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poetapp/node/pulls/476"},"html":{"href":"https://github.com/poetapp/node/pull/476"},"issue":{"href":"https://api.github.com/repos/poetapp/node/issues/476"},"comments":{"href":"https://api.github.com/repos/poetapp/node/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/poetapp/node/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/poetapp/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poetapp/node/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/poetapp/node/statuses/e9516f8de20f7e1055628ae5a248dcc9b09c4644"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kennylavender"}}