{"action":"created","comment":{"url":"https://api.github.com/repos/docker/cli/pulls/comments/172908470","pull_request_review_id":102007322,"id":172908470,"diff_hunk":"@@ -161,12 +161,16 @@ COPY data /data\n // TestRunBuildFromLocalGitHubDirNonExistingRepo tests that build contexts\n // starting with `github.com/` are special-cased, and the build command attempts\n // to clone the remote repo.\n+// TODO: test \"context selection\" logic directly when runBuild is refactored\n+// to support testing (ex: docker/cli#294)","path":"cli/command/image/build_test.go","position":32,"original_position":32,"commit_id":"e15b208e9688efa0e0caba36d8e8e631a3a46374","original_commit_id":"e15b208e9688efa0e0caba36d8e8e631a3a46374","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Needs a rebase now?","created_at":"2018-03-07T16:49:41Z","updated_at":"2018-03-07T16:52:43Z","html_url":"https://github.com/docker/cli/pull/921#discussion_r172908470","pull_request_url":"https://api.github.com/repos/docker/cli/pulls/921","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/comments/172908470"},"html":{"href":"https://github.com/docker/cli/pull/921#discussion_r172908470"},"pull_request":{"href":"https://api.github.com/repos/docker/cli/pulls/921"}}},"pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/921","id":173280810,"html_url":"https://github.com/docker/cli/pull/921","diff_url":"https://github.com/docker/cli/pull/921.diff","patch_url":"https://github.com/docker/cli/pull/921.patch","issue_url":"https://api.github.com/repos/docker/cli/issues/921","number":921,"state":"open","locked":false,"title":"testing: Use canonical asserts","user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars1.githubusercontent.com/u/442180?v=4","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"body":"Branched from #920 \r\n\r\ngrep/sed/perl commands are included in the git commit message.","created_at":"2018-03-06T21:05:05Z","updated_at":"2018-03-07T16:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36bea5c57e8419754abfd8959dcf77c5952f4390","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":585916071,"url":"https://api.github.com/repos/docker/cli/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/docker/cli/pulls/921/commits","review_comments_url":"https://api.github.com/repos/docker/cli/pulls/921/comments","review_comment_url":"https://api.github.com/repos/docker/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/cli/issues/921/comments","statuses_url":"https://api.github.com/repos/docker/cli/statuses/e15b208e9688efa0e0caba36d8e8e631a3a46374","head":{"label":"dnephin:use-canonical-imports","ref":"use-canonical-imports","sha":"e15b208e9688efa0e0caba36d8e8e631a3a46374","user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars1.githubusercontent.com/u/442180?v=4","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"repo":{"id":88645941,"name":"cli","full_name":"dnephin/cli","owner":{"login":"dnephin","id":442180,"avatar_url":"https://avatars1.githubusercontent.com/u/442180?v=4","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnephin/cli","description":"The Docker CLI","fork":true,"url":"https://api.github.com/repos/dnephin/cli","forks_url":"https://api.github.com/repos/dnephin/cli/forks","keys_url":"https://api.github.com/repos/dnephin/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnephin/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnephin/cli/teams","hooks_url":"https://api.github.com/repos/dnephin/cli/hooks","issue_events_url":"https://api.github.com/repos/dnephin/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dnephin/cli/events","assignees_url":"https://api.github.com/repos/dnephin/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dnephin/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dnephin/cli/tags","blobs_url":"https://api.github.com/repos/dnephin/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnephin/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnephin/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnephin/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnephin/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dnephin/cli/languages","stargazers_url":"https://api.github.com/repos/dnephin/cli/stargazers","contributors_url":"https://api.github.com/repos/dnephin/cli/contributors","subscribers_url":"https://api.github.com/repos/dnephin/cli/subscribers","subscription_url":"https://api.github.com/repos/dnephin/cli/subscription","commits_url":"https://api.github.com/repos/dnephin/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnephin/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnephin/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnephin/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnephin/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dnephin/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnephin/cli/merges","archive_url":"https://api.github.com/repos/dnephin/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnephin/cli/downloads","issues_url":"https://api.github.com/repos/dnephin/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dnephin/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dnephin/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dnephin/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnephin/cli/labels{/name}","releases_url":"https://api.github.com/repos/dnephin/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dnephin/cli/deployments","created_at":"2017-04-18T16:17:25Z","updated_at":"2017-04-18T16:17:27Z","pushed_at":"2018-03-07T16:37:29Z","git_url":"git://github.com/dnephin/cli.git","ssh_url":"git@github.com:dnephin/cli.git","clone_url":"https://github.com/dnephin/cli.git","svn_url":"https://github.com/dnephin/cli","homepage":null,"size":17056,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"0c75f522b61d99ff6f634035263248a6c39af267","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":88013053,"name":"cli","full_name":"docker/cli","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/cli","description":"The Docker CLI","fork":false,"url":"https://api.github.com/repos/docker/cli","forks_url":"https://api.github.com/repos/docker/cli/forks","keys_url":"https://api.github.com/repos/docker/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/cli/teams","hooks_url":"https://api.github.com/repos/docker/cli/hooks","issue_events_url":"https://api.github.com/repos/docker/cli/issues/events{/number}","events_url":"https://api.github.com/repos/docker/cli/events","assignees_url":"https://api.github.com/repos/docker/cli/assignees{/user}","branches_url":"https://api.github.com/repos/docker/cli/branches{/branch}","tags_url":"https://api.github.com/repos/docker/cli/tags","blobs_url":"https://api.github.com/repos/docker/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/cli/languages","stargazers_url":"https://api.github.com/repos/docker/cli/stargazers","contributors_url":"https://api.github.com/repos/docker/cli/contributors","subscribers_url":"https://api.github.com/repos/docker/cli/subscribers","subscription_url":"https://api.github.com/repos/docker/cli/subscription","commits_url":"https://api.github.com/repos/docker/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/cli/contents/{+path}","compare_url":"https://api.github.com/repos/docker/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/cli/merges","archive_url":"https://api.github.com/repos/docker/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/cli/downloads","issues_url":"https://api.github.com/repos/docker/cli/issues{/number}","pulls_url":"https://api.github.com/repos/docker/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/cli/labels{/name}","releases_url":"https://api.github.com/repos/docker/cli/releases{/id}","deployments_url":"https://api.github.com/repos/docker/cli/deployments","created_at":"2017-04-12T05:27:42Z","updated_at":"2018-03-07T13:27:40Z","pushed_at":"2018-03-07T13:22:53Z","git_url":"git://github.com/docker/cli.git","ssh_url":"git@github.com:docker/cli.git","clone_url":"https://github.com/docker/cli.git","svn_url":"https://github.com/docker/cli","homepage":null,"size":16905,"stargazers_count":546,"watchers_count":546,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":362,"open_issues":181,"watchers":546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/921"},"html":{"href":"https://github.com/docker/cli/pull/921"},"issue":{"href":"https://api.github.com/repos/docker/cli/issues/921"},"comments":{"href":"https://api.github.com/repos/docker/cli/issues/921/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/cli/pulls/921/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/cli/pulls/921/commits"},"statuses":{"href":"https://api.github.com/repos/docker/cli/statuses/e15b208e9688efa0e0caba36d8e8e631a3a46374"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thaJeztah"}}