{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali/pulls/comments/235027095","pull_request_review_id":176796994,"id":235027095,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTAyNzA5NQ==","diff_hunk":"@@ -220,11 +261,16 @@ func GetIstioAPI(resourceType string) string {\n }\n \n // DeleteIstioConfigDetail deletes the given Istio resource\n-func (in *IstioConfigService) DeleteIstioConfigDetail(api, namespace, resourceType, name string) (err error) {\n+func (in *IstioConfigService) DeleteIstioConfigDetail(api, namespace, resourceType, resourceSubtype, name string) (err error) {","path":"business/istio_config.go","position":133,"original_position":133,"commit_id":"33ff557adcbe6ce0deeabe419f76b6b78695e0f5","original_commit_id":"b132a8c53654bce9f9e7622d54f8ab1894776349","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"+1\r\nIt was missing; I've added in the next commit.","created_at":"2018-11-20T14:39:31Z","updated_at":"2018-11-20T14:39:31Z","html_url":"https://github.com/kiali/kiali/pull/666#discussion_r235027095","pull_request_url":"https://api.github.com/repos/kiali/kiali/pulls/666","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments/235027095"},"html":{"href":"https://github.com/kiali/kiali/pull/666#discussion_r235027095"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali/pulls/666"}},"in_reply_to_id":234951178},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/666","id":231175021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTc1MDIx","html_url":"https://github.com/kiali/kiali/pull/666","diff_url":"https://github.com/kiali/kiali/pull/666.diff","patch_url":"https://github.com/kiali/kiali/pull/666.patch","issue_url":"https://api.github.com/repos/kiali/kiali/issues/666","number":666,"state":"open","locked":false,"title":"KIALI-1947 Split Istio Rules from Adapters/Templates","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"body":"** Describe the change **\r\n\r\nHandle Adapters/Templates as independent object from Istio Rules as a previous step to edit them.\r\n\r\n** Issue reference **\r\n\r\nhttps://issues.jboss.org/browse/KIALI-1947\r\n\r\n** Backwards incompatible? **\r\n\r\nYes, changes in the API.\r\n\r\nAlso this PR needs an update in the UI project to update the changes.\r\n\r\n\r\n","created_at":"2018-11-15T12:19:45Z","updated_at":"2018-11-20T14:39:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d29ee31773b8a84895d6e04f0d3fc3f785cfdd7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":828917230,"node_id":"MDU6TGFiZWw4Mjg5MTcyMzA=","url":"https://api.github.com/repos/kiali/kiali/labels/do%20not%20merge","name":"do not merge","color":"fc9492","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali/pulls/666/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali/pulls/666/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/666/comments","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/33ff557adcbe6ce0deeabe419f76b6b78695e0f5","head":{"label":"lucasponce:split-istio-rules","ref":"split-istio-rules","sha":"33ff557adcbe6ce0deeabe419f76b6b78695e0f5","user":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"repo":{"id":120277582,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNzc1ODI=","name":"kiali","full_name":"lucasponce/kiali","private":false,"owner":{"login":"lucasponce","id":1662329,"node_id":"MDQ6VXNlcjE2NjIzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1662329?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasponce","html_url":"https://github.com/lucasponce","followers_url":"https://api.github.com/users/lucasponce/followers","following_url":"https://api.github.com/users/lucasponce/following{/other_user}","gists_url":"https://api.github.com/users/lucasponce/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasponce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasponce/subscriptions","organizations_url":"https://api.github.com/users/lucasponce/orgs","repos_url":"https://api.github.com/users/lucasponce/repos","events_url":"https://api.github.com/users/lucasponce/events{/privacy}","received_events_url":"https://api.github.com/users/lucasponce/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lucasponce/kiali","description":null,"fork":true,"url":"https://api.github.com/repos/lucasponce/kiali","forks_url":"https://api.github.com/repos/lucasponce/kiali/forks","keys_url":"https://api.github.com/repos/lucasponce/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucasponce/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucasponce/kiali/teams","hooks_url":"https://api.github.com/repos/lucasponce/kiali/hooks","issue_events_url":"https://api.github.com/repos/lucasponce/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/lucasponce/kiali/events","assignees_url":"https://api.github.com/repos/lucasponce/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/lucasponce/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/lucasponce/kiali/tags","blobs_url":"https://api.github.com/repos/lucasponce/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucasponce/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucasponce/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucasponce/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucasponce/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/lucasponce/kiali/languages","stargazers_url":"https://api.github.com/repos/lucasponce/kiali/stargazers","contributors_url":"https://api.github.com/repos/lucasponce/kiali/contributors","subscribers_url":"https://api.github.com/repos/lucasponce/kiali/subscribers","subscription_url":"https://api.github.com/repos/lucasponce/kiali/subscription","commits_url":"https://api.github.com/repos/lucasponce/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucasponce/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucasponce/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucasponce/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucasponce/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/lucasponce/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucasponce/kiali/merges","archive_url":"https://api.github.com/repos/lucasponce/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucasponce/kiali/downloads","issues_url":"https://api.github.com/repos/lucasponce/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/lucasponce/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/lucasponce/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/lucasponce/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucasponce/kiali/labels{/name}","releases_url":"https://api.github.com/repos/lucasponce/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/lucasponce/kiali/deployments","created_at":"2018-02-05T08:42:11Z","updated_at":"2018-11-20T07:34:26Z","pushed_at":"2018-11-20T14:38:10Z","git_url":"git://github.com/lucasponce/kiali.git","ssh_url":"git@github.com:lucasponce/kiali.git","clone_url":"https://github.com/lucasponce/kiali.git","svn_url":"https://github.com/lucasponce/kiali","homepage":null,"size":16341,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"8ab5add6802a86704eebe6a476e7b23a93d65431","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120181748,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxODE3NDg=","name":"kiali","full_name":"kiali/kiali","private":false,"owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiali/kiali","description":"Kiali project, observability for the Istio service mesh","fork":false,"url":"https://api.github.com/repos/kiali/kiali","forks_url":"https://api.github.com/repos/kiali/kiali/forks","keys_url":"https://api.github.com/repos/kiali/kiali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali/teams","hooks_url":"https://api.github.com/repos/kiali/kiali/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali/events","assignees_url":"https://api.github.com/repos/kiali/kiali/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali/tags","blobs_url":"https://api.github.com/repos/kiali/kiali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali/subscription","commits_url":"https://api.github.com/repos/kiali/kiali/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali/merges","archive_url":"https://api.github.com/repos/kiali/kiali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali/downloads","issues_url":"https://api.github.com/repos/kiali/kiali/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali/deployments","created_at":"2018-02-04T12:11:57Z","updated_at":"2018-11-20T13:04:47Z","pushed_at":"2018-11-20T14:38:11Z","git_url":"git://github.com/kiali/kiali.git","ssh_url":"git@github.com:kiali/kiali.git","clone_url":"https://github.com/kiali/kiali.git","svn_url":"https://github.com/kiali/kiali","homepage":"https://www.kiali.io","size":16283,"stargazers_count":517,"watchers_count":517,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":31,"watchers":517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali/pulls/666"},"html":{"href":"https://github.com/kiali/kiali/pull/666"},"issue":{"href":"https://api.github.com/repos/kiali/kiali/issues/666"},"comments":{"href":"https://api.github.com/repos/kiali/kiali/issues/666/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali/pulls/666/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali/pulls/666/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali/statuses/33ff557adcbe6ce0deeabe419f76b6b78695e0f5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucasponce"}}