{"action":"created","comment":{"url":"https://api.github.com/repos/magenta-aps/mox/pulls/comments/186338077","pull_request_review_id":117895289,"id":186338077,"diff_hunk":"@@ -13,6 +6,7 @@ addopts = --cov=oio_rest --cov-report=xml --cov-branch --junitxml=tests.xml\n ignore = N999\n select = E,D,F,W,C,T,N,H\n exclude =\n-        oio_rest/settings.py\n+        settings.py\n         .eggs,\n-        venv*\n+        .python-test","path":"oio_rest/setup.cfg","position":19,"original_position":19,"commit_id":"76c3da55a3781a1a05d88a44b903b06a99044469","original_commit_id":"101e83d70af8c4c5509f2cbf62e04540d69c3387","user":{"login":"istherepie","id":12992622,"avatar_url":"https://avatars3.githubusercontent.com/u/12992622?v=4","gravatar_id":"","url":"https://api.github.com/users/istherepie","html_url":"https://github.com/istherepie","followers_url":"https://api.github.com/users/istherepie/followers","following_url":"https://api.github.com/users/istherepie/following{/other_user}","gists_url":"https://api.github.com/users/istherepie/gists{/gist_id}","starred_url":"https://api.github.com/users/istherepie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istherepie/subscriptions","organizations_url":"https://api.github.com/users/istherepie/orgs","repos_url":"https://api.github.com/users/istherepie/repos","events_url":"https://api.github.com/users/istherepie/events{/privacy}","received_events_url":"https://api.github.com/users/istherepie/received_events","type":"User","site_admin":false},"body":"No justification - it was a matter of choosing a naming scheme that would less likely collide with any other virtual environments on a given system.\r\nWhat name for the (TEST) virtual environment would you prefer ?","created_at":"2018-05-07T06:42:39Z","updated_at":"2018-05-07T06:42:39Z","html_url":"https://github.com/magenta-aps/mox/pull/44#discussion_r186338077","pull_request_url":"https://api.github.com/repos/magenta-aps/mox/pulls/44","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/magenta-aps/mox/pulls/comments/186338077"},"html":{"href":"https://github.com/magenta-aps/mox/pull/44#discussion_r186338077"},"pull_request":{"href":"https://api.github.com/repos/magenta-aps/mox/pulls/44"}},"in_reply_to_id":186075278},"pull_request":{"url":"https://api.github.com/repos/magenta-aps/mox/pulls/44","id":185739022,"html_url":"https://github.com/magenta-aps/mox/pull/44","diff_url":"https://github.com/magenta-aps/mox/pull/44.diff","patch_url":"https://github.com/magenta-aps/mox/pull/44.patch","issue_url":"https://api.github.com/repos/magenta-aps/mox/issues/44","number":44,"state":"open","locked":false,"title":"Feature/18459 install script replacement","user":{"login":"istherepie","id":12992622,"avatar_url":"https://avatars3.githubusercontent.com/u/12992622?v=4","gravatar_id":"","url":"https://api.github.com/users/istherepie","html_url":"https://github.com/istherepie","followers_url":"https://api.github.com/users/istherepie/followers","following_url":"https://api.github.com/users/istherepie/following{/other_user}","gists_url":"https://api.github.com/users/istherepie/gists{/gist_id}","starred_url":"https://api.github.com/users/istherepie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istherepie/subscriptions","organizations_url":"https://api.github.com/users/istherepie/orgs","repos_url":"https://api.github.com/users/istherepie/repos","events_url":"https://api.github.com/users/istherepie/events{/privacy}","received_events_url":"https://api.github.com/users/istherepie/received_events","type":"User","site_admin":false},"body":"This replaces the legacy installer.\r\n\r\nPlease note that this is an early pull request, \r\nthe installer works but needs finetuning. \r\nHowever the changes fix certain coupling issues in the external deployment process.\r\n\r\nNext step is to merge with the python 3 changes (Install process will break and needs minor fixing)","created_at":"2018-05-03T14:41:38Z","updated_at":"2018-05-07T06:42:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f87a8fb8d9def06fff6e07b8e93734e6e97cb30","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cmoesgaard","id":1827127,"avatar_url":"https://avatars3.githubusercontent.com/u/1827127?v=4","gravatar_id":"","url":"https://api.github.com/users/cmoesgaard","html_url":"https://github.com/cmoesgaard","followers_url":"https://api.github.com/users/cmoesgaard/followers","following_url":"https://api.github.com/users/cmoesgaard/following{/other_user}","gists_url":"https://api.github.com/users/cmoesgaard/gists{/gist_id}","starred_url":"https://api.github.com/users/cmoesgaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmoesgaard/subscriptions","organizations_url":"https://api.github.com/users/cmoesgaard/orgs","repos_url":"https://api.github.com/users/cmoesgaard/repos","events_url":"https://api.github.com/users/cmoesgaard/events{/privacy}","received_events_url":"https://api.github.com/users/cmoesgaard/received_events","type":"User","site_admin":false},{"login":"agger-magenta","id":4435559,"avatar_url":"https://avatars3.githubusercontent.com/u/4435559?v=4","gravatar_id":"","url":"https://api.github.com/users/agger-magenta","html_url":"https://github.com/agger-magenta","followers_url":"https://api.github.com/users/agger-magenta/followers","following_url":"https://api.github.com/users/agger-magenta/following{/other_user}","gists_url":"https://api.github.com/users/agger-magenta/gists{/gist_id}","starred_url":"https://api.github.com/users/agger-magenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agger-magenta/subscriptions","organizations_url":"https://api.github.com/users/agger-magenta/orgs","repos_url":"https://api.github.com/users/agger-magenta/repos","events_url":"https://api.github.com/users/agger-magenta/events{/privacy}","received_events_url":"https://api.github.com/users/agger-magenta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magenta-aps/mox/pulls/44/commits","review_comments_url":"https://api.github.com/repos/magenta-aps/mox/pulls/44/comments","review_comment_url":"https://api.github.com/repos/magenta-aps/mox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magenta-aps/mox/issues/44/comments","statuses_url":"https://api.github.com/repos/magenta-aps/mox/statuses/76c3da55a3781a1a05d88a44b903b06a99044469","head":{"label":"magenta-aps:feature/18459_install_script_replacement","ref":"feature/18459_install_script_replacement","sha":"76c3da55a3781a1a05d88a44b903b06a99044469","user":{"login":"magenta-aps","id":996271,"avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"repo":{"id":29537185,"name":"mox","full_name":"magenta-aps/mox","owner":{"login":"magenta-aps","id":996271,"avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magenta-aps/mox","description":"MOX Actual State database","fork":false,"url":"https://api.github.com/repos/magenta-aps/mox","forks_url":"https://api.github.com/repos/magenta-aps/mox/forks","keys_url":"https://api.github.com/repos/magenta-aps/mox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magenta-aps/mox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magenta-aps/mox/teams","hooks_url":"https://api.github.com/repos/magenta-aps/mox/hooks","issue_events_url":"https://api.github.com/repos/magenta-aps/mox/issues/events{/number}","events_url":"https://api.github.com/repos/magenta-aps/mox/events","assignees_url":"https://api.github.com/repos/magenta-aps/mox/assignees{/user}","branches_url":"https://api.github.com/repos/magenta-aps/mox/branches{/branch}","tags_url":"https://api.github.com/repos/magenta-aps/mox/tags","blobs_url":"https://api.github.com/repos/magenta-aps/mox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magenta-aps/mox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magenta-aps/mox/git/refs{/sha}","trees_url":"https://api.github.com/repos/magenta-aps/mox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magenta-aps/mox/statuses/{sha}","languages_url":"https://api.github.com/repos/magenta-aps/mox/languages","stargazers_url":"https://api.github.com/repos/magenta-aps/mox/stargazers","contributors_url":"https://api.github.com/repos/magenta-aps/mox/contributors","subscribers_url":"https://api.github.com/repos/magenta-aps/mox/subscribers","subscription_url":"https://api.github.com/repos/magenta-aps/mox/subscription","commits_url":"https://api.github.com/repos/magenta-aps/mox/commits{/sha}","git_commits_url":"https://api.github.com/repos/magenta-aps/mox/git/commits{/sha}","comments_url":"https://api.github.com/repos/magenta-aps/mox/comments{/number}","issue_comment_url":"https://api.github.com/repos/magenta-aps/mox/issues/comments{/number}","contents_url":"https://api.github.com/repos/magenta-aps/mox/contents/{+path}","compare_url":"https://api.github.com/repos/magenta-aps/mox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magenta-aps/mox/merges","archive_url":"https://api.github.com/repos/magenta-aps/mox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magenta-aps/mox/downloads","issues_url":"https://api.github.com/repos/magenta-aps/mox/issues{/number}","pulls_url":"https://api.github.com/repos/magenta-aps/mox/pulls{/number}","milestones_url":"https://api.github.com/repos/magenta-aps/mox/milestones{/number}","notifications_url":"https://api.github.com/repos/magenta-aps/mox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magenta-aps/mox/labels{/name}","releases_url":"https://api.github.com/repos/magenta-aps/mox/releases{/id}","deployments_url":"https://api.github.com/repos/magenta-aps/mox/deployments","created_at":"2015-01-20T15:41:49Z","updated_at":"2018-04-10T11:40:18Z","pushed_at":"2018-05-07T06:02:24Z","git_url":"git://github.com/magenta-aps/mox.git","ssh_url":"git@github.com:magenta-aps/mox.git","clone_url":"https://github.com/magenta-aps/mox.git","svn_url":"https://github.com/magenta-aps/mox","homepage":"https://mox.readthedocs.io","size":40867,"stargazers_count":8,"watchers_count":8,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1,"open_issues":14,"watchers":8,"default_branch":"master"}},"base":{"label":"magenta-aps:development","ref":"development","sha":"f97e6bbf3c2327df3682d3a7824372be9edd07f2","user":{"login":"magenta-aps","id":996271,"avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"repo":{"id":29537185,"name":"mox","full_name":"magenta-aps/mox","owner":{"login":"magenta-aps","id":996271,"avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magenta-aps/mox","description":"MOX Actual State database","fork":false,"url":"https://api.github.com/repos/magenta-aps/mox","forks_url":"https://api.github.com/repos/magenta-aps/mox/forks","keys_url":"https://api.github.com/repos/magenta-aps/mox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magenta-aps/mox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magenta-aps/mox/teams","hooks_url":"https://api.github.com/repos/magenta-aps/mox/hooks","issue_events_url":"https://api.github.com/repos/magenta-aps/mox/issues/events{/number}","events_url":"https://api.github.com/repos/magenta-aps/mox/events","assignees_url":"https://api.github.com/repos/magenta-aps/mox/assignees{/user}","branches_url":"https://api.github.com/repos/magenta-aps/mox/branches{/branch}","tags_url":"https://api.github.com/repos/magenta-aps/mox/tags","blobs_url":"https://api.github.com/repos/magenta-aps/mox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magenta-aps/mox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magenta-aps/mox/git/refs{/sha}","trees_url":"https://api.github.com/repos/magenta-aps/mox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magenta-aps/mox/statuses/{sha}","languages_url":"https://api.github.com/repos/magenta-aps/mox/languages","stargazers_url":"https://api.github.com/repos/magenta-aps/mox/stargazers","contributors_url":"https://api.github.com/repos/magenta-aps/mox/contributors","subscribers_url":"https://api.github.com/repos/magenta-aps/mox/subscribers","subscription_url":"https://api.github.com/repos/magenta-aps/mox/subscription","commits_url":"https://api.github.com/repos/magenta-aps/mox/commits{/sha}","git_commits_url":"https://api.github.com/repos/magenta-aps/mox/git/commits{/sha}","comments_url":"https://api.github.com/repos/magenta-aps/mox/comments{/number}","issue_comment_url":"https://api.github.com/repos/magenta-aps/mox/issues/comments{/number}","contents_url":"https://api.github.com/repos/magenta-aps/mox/contents/{+path}","compare_url":"https://api.github.com/repos/magenta-aps/mox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magenta-aps/mox/merges","archive_url":"https://api.github.com/repos/magenta-aps/mox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magenta-aps/mox/downloads","issues_url":"https://api.github.com/repos/magenta-aps/mox/issues{/number}","pulls_url":"https://api.github.com/repos/magenta-aps/mox/pulls{/number}","milestones_url":"https://api.github.com/repos/magenta-aps/mox/milestones{/number}","notifications_url":"https://api.github.com/repos/magenta-aps/mox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magenta-aps/mox/labels{/name}","releases_url":"https://api.github.com/repos/magenta-aps/mox/releases{/id}","deployments_url":"https://api.github.com/repos/magenta-aps/mox/deployments","created_at":"2015-01-20T15:41:49Z","updated_at":"2018-04-10T11:40:18Z","pushed_at":"2018-05-07T06:02:24Z","git_url":"git://github.com/magenta-aps/mox.git","ssh_url":"git@github.com:magenta-aps/mox.git","clone_url":"https://github.com/magenta-aps/mox.git","svn_url":"https://github.com/magenta-aps/mox","homepage":"https://mox.readthedocs.io","size":40867,"stargazers_count":8,"watchers_count":8,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1,"open_issues":14,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magenta-aps/mox/pulls/44"},"html":{"href":"https://github.com/magenta-aps/mox/pull/44"},"issue":{"href":"https://api.github.com/repos/magenta-aps/mox/issues/44"},"comments":{"href":"https://api.github.com/repos/magenta-aps/mox/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/magenta-aps/mox/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/magenta-aps/mox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magenta-aps/mox/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/magenta-aps/mox/statuses/76c3da55a3781a1a05d88a44b903b06a99044469"}},"author_association":"NONE"}}
{"actor":{"display_login":"istherepie"}}