{"action":"created","issue":{"url":"https://api.github.com/repos/amaabca/ama_styles/issues/90","repository_url":"https://api.github.com/repos/amaabca/ama_styles","labels_url":"https://api.github.com/repos/amaabca/ama_styles/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/amaabca/ama_styles/issues/90/comments","events_url":"https://api.github.com/repos/amaabca/ama_styles/issues/90/events","html_url":"https://github.com/amaabca/ama_styles/pull/90","id":318945662,"number":90,"title":"VSTS-9877 - Redeem Reward Dollars","user":{"login":"jessedoyle","id":6474230,"avatar_url":"https://avatars2.githubusercontent.com/u/6474230?v=4","gravatar_id":"","url":"https://api.github.com/users/jessedoyle","html_url":"https://github.com/jessedoyle","followers_url":"https://api.github.com/users/jessedoyle/followers","following_url":"https://api.github.com/users/jessedoyle/following{/other_user}","gists_url":"https://api.github.com/users/jessedoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/jessedoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessedoyle/subscriptions","organizations_url":"https://api.github.com/users/jessedoyle/orgs","repos_url":"https://api.github.com/users/jessedoyle/repos","events_url":"https://api.github.com/users/jessedoyle/events{/privacy}","received_events_url":"https://api.github.com/users/jessedoyle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-30T16:08:34Z","updated_at":"2018-05-01T16:16:29Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/amaabca/ama_styles/pulls/90","html_url":"https://github.com/amaabca/ama_styles/pull/90","diff_url":"https://github.com/amaabca/ama_styles/pull/90.diff","patch_url":"https://github.com/amaabca/ama_styles/pull/90.patch"},"body":":art::elephant:\r\n\r\n* Losslessly compress all image assets using https://kraken.io.\r\n  This reduced net asset size by approx. 24 percent.\r\n* Add in 1 and 2x variants of images for POS reward dollar\r\n  redemption.\r\n* Bump minor version.\r\n* Remove `new_framework_defaults` file from the spec dummy app\r\n  config. New versions of Rails no longer define these override\r\n  methods on ActiveSupport.\r\n* Require `foundation_rails` >= 6.4.3.0 to ensure compatibility\r\n  with JS/CSS for foundation.\r\n* Fix a deprecation warning about explicit references to\r\n  `$offcanvas-size`. As we aren't referencing this variable in\r\n  our own SCSS, it's fine to remove the definition.\r\n\r\n## Optimization Results\r\n\r\n<img width=\"1082\" alt=\"screen shot 2018-04-30 at 10 03 56 am\" src=\"https://user-images.githubusercontent.com/6474230/39437482-35a525f2-4c5e-11e8-89a7-672c320e8512.png\">\r\n\r\n## New Images\r\n\r\n### Admin Tasks\r\n\r\n![admintasks](https://user-images.githubusercontent.com/6474230/39437510-48ed689a-4c5e-11e8-8042-625369074c3f.png)\r\n\r\n### Redeem Reward Dollars\r\n\r\n![redeemrewarddollars](https://user-images.githubusercontent.com/6474230/39437537-62b17d84-4c5e-11e8-900e-85a278335d3d.png)\r\n\r\nSEE: https://amaabca.visualstudio.com/registries_backlog/_workitems/edit/9877\r\n\r\n### PR Review Checklist\r\nTo be completed by the person who opens the PR. Use strikethroughs for items that are not applicable in list.\r\n- [X] I have reviewed my own PR to check syntax & logic, removed unnecessary/old code, made sure everything aligns with our style guide and BEM.\r\n- ~[ ] I've added new components to the style guide (or have a PR in to add them).~\r\n- [X] Any applicable version numbers have been updated.\r\n- [X] I've tested on mobile, tablet, and desktop, as well as across all of the browsers we support.\r\n- [X] I've proof-read all text for legibility, proper grammar, punctuation, and capitalization (titlecase).\r\n- [X] I have written a detailed PR message explaining what is being changed and why\r\n- [X] I’ve linked to any relevant VSTS tickets\r\n- [X] I’ve added the appropriate review symbols to my PR - (elephant) for dev review, (art) for design\r\n"},"comment":{"url":"https://api.github.com/repos/amaabca/ama_styles/issues/comments/385712735","html_url":"https://github.com/amaabca/ama_styles/pull/90#issuecomment-385712735","issue_url":"https://api.github.com/repos/amaabca/ama_styles/issues/90","id":385712735,"user":{"login":"DaveAMA","id":27693833,"avatar_url":"https://avatars2.githubusercontent.com/u/27693833?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveAMA","html_url":"https://github.com/DaveAMA","followers_url":"https://api.github.com/users/DaveAMA/followers","following_url":"https://api.github.com/users/DaveAMA/following{/other_user}","gists_url":"https://api.github.com/users/DaveAMA/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveAMA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveAMA/subscriptions","organizations_url":"https://api.github.com/users/DaveAMA/orgs","repos_url":"https://api.github.com/users/DaveAMA/repos","events_url":"https://api.github.com/users/DaveAMA/events{/privacy}","received_events_url":"https://api.github.com/users/DaveAMA/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T16:16:29Z","updated_at":"2018-05-01T16:16:29Z","author_association":"CONTRIBUTOR","body":"📖 "}}
{"actor":{"display_login":"DaveAMA"}}