{"action":"created","comment":{"url":"https://api.github.com/repos/psi4/psi4/pulls/comments/211057064","pull_request_review_id":147410928,"id":211057064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA1NzA2NA==","diff_hunk":"@@ -33,6 +33,8 @@\n #include \"psi4/libmints/basisset.h\"\n #include \"psi4/libmints/wavefunction.h\"\n #include \"psi4/libpsi4util/PsiOutStream.h\"\n+#include \"psi4/lib3index/dfhelper.h\"","path":"psi4/src/psi4/fisapt/fisapt.h","position":4,"original_position":4,"commit_id":"012bf2be9d8b86ef21a384de9138d62803cc33a7","original_commit_id":"012bf2be9d8b86ef21a384de9138d62803cc33a7","user":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"body":"Can you forward declare the class by adding `class DFHelper::DFHelper` around line 44 instead of including this header?","created_at":"2018-08-18T00:11:42Z","updated_at":"2018-08-18T00:12:13Z","html_url":"https://github.com/psi4/psi4/pull/1140#discussion_r211057064","pull_request_url":"https://api.github.com/repos/psi4/psi4/pulls/1140","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/psi4/psi4/pulls/comments/211057064"},"html":{"href":"https://github.com/psi4/psi4/pull/1140#discussion_r211057064"},"pull_request":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1140"}}},"pull_request":{"url":"https://api.github.com/repos/psi4/psi4/pulls/1140","id":209259110,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjU5MTEw","html_url":"https://github.com/psi4/psi4/pull/1140","diff_url":"https://github.com/psi4/psi4/pull/1140.diff","patch_url":"https://github.com/psi4/psi4/pull/1140.patch","issue_url":"https://api.github.com/repos/psi4/psi4/issues/1140","number":1140,"state":"open","locked":false,"title":"Remove initialization of DFHelper object in fisapt fexch and find.","user":{"login":"obrien951","id":28900775,"node_id":"MDQ6VXNlcjI4OTAwNzc1","avatar_url":"https://avatars2.githubusercontent.com/u/28900775?v=4","gravatar_id":"","url":"https://api.github.com/users/obrien951","html_url":"https://github.com/obrien951","followers_url":"https://api.github.com/users/obrien951/followers","following_url":"https://api.github.com/users/obrien951/following{/other_user}","gists_url":"https://api.github.com/users/obrien951/gists{/gist_id}","starred_url":"https://api.github.com/users/obrien951/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrien951/subscriptions","organizations_url":"https://api.github.com/users/obrien951/orgs","repos_url":"https://api.github.com/users/obrien951/repos","events_url":"https://api.github.com/users/obrien951/events{/privacy}","received_events_url":"https://api.github.com/users/obrien951/received_events","type":"User","site_admin":false},"body":"## Description\r\nRemoves initialization of DFHelper object in fexch and find by having a dfh object as member data.\r\n\r\n## Todos\r\nNotable points (developer or user-interest) that this PR has or will accomplish.\r\n- [x] Circumvents recalculation of molecular integrals in the fisapt package.\r\n- [x] Provides a corresponding speed-up \r\n\r\n## Checklist\r\n- [x] [All or relevant fraction of full tests run](http://psicode.org/psi4manual/master/build_planning.html#how-to-run-a-subset-of-tests)\r\n\r\n## Status\r\n- [x] Ready for review\r\n- [x] Ready for merge\r\n","created_at":"2018-08-17T21:13:43Z","updated_at":"2018-08-18T00:12:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8eaa69c9aa96fdafe8be5804b6b23ec316d9fc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/psi4/psi4/pulls/1140/commits","review_comments_url":"https://api.github.com/repos/psi4/psi4/pulls/1140/comments","review_comment_url":"https://api.github.com/repos/psi4/psi4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/psi4/psi4/issues/1140/comments","statuses_url":"https://api.github.com/repos/psi4/psi4/statuses/012bf2be9d8b86ef21a384de9138d62803cc33a7","head":{"label":"obrien951:fisapt_dfh_inits","ref":"fisapt_dfh_inits","sha":"012bf2be9d8b86ef21a384de9138d62803cc33a7","user":{"login":"obrien951","id":28900775,"node_id":"MDQ6VXNlcjI4OTAwNzc1","avatar_url":"https://avatars2.githubusercontent.com/u/28900775?v=4","gravatar_id":"","url":"https://api.github.com/users/obrien951","html_url":"https://github.com/obrien951","followers_url":"https://api.github.com/users/obrien951/followers","following_url":"https://api.github.com/users/obrien951/following{/other_user}","gists_url":"https://api.github.com/users/obrien951/gists{/gist_id}","starred_url":"https://api.github.com/users/obrien951/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrien951/subscriptions","organizations_url":"https://api.github.com/users/obrien951/orgs","repos_url":"https://api.github.com/users/obrien951/repos","events_url":"https://api.github.com/users/obrien951/events{/privacy}","received_events_url":"https://api.github.com/users/obrien951/received_events","type":"User","site_admin":false},"repo":{"id":92325299,"node_id":"MDEwOlJlcG9zaXRvcnk5MjMyNTI5OQ==","name":"psi4","full_name":"obrien951/psi4","owner":{"login":"obrien951","id":28900775,"node_id":"MDQ6VXNlcjI4OTAwNzc1","avatar_url":"https://avatars2.githubusercontent.com/u/28900775?v=4","gravatar_id":"","url":"https://api.github.com/users/obrien951","html_url":"https://github.com/obrien951","followers_url":"https://api.github.com/users/obrien951/followers","following_url":"https://api.github.com/users/obrien951/following{/other_user}","gists_url":"https://api.github.com/users/obrien951/gists{/gist_id}","starred_url":"https://api.github.com/users/obrien951/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obrien951/subscriptions","organizations_url":"https://api.github.com/users/obrien951/orgs","repos_url":"https://api.github.com/users/obrien951/repos","events_url":"https://api.github.com/users/obrien951/events{/privacy}","received_events_url":"https://api.github.com/users/obrien951/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obrien951/psi4","description":"Open-Source Quantum Chemistry – an electronic structure package in C++ driven by Python","fork":true,"url":"https://api.github.com/repos/obrien951/psi4","forks_url":"https://api.github.com/repos/obrien951/psi4/forks","keys_url":"https://api.github.com/repos/obrien951/psi4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obrien951/psi4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obrien951/psi4/teams","hooks_url":"https://api.github.com/repos/obrien951/psi4/hooks","issue_events_url":"https://api.github.com/repos/obrien951/psi4/issues/events{/number}","events_url":"https://api.github.com/repos/obrien951/psi4/events","assignees_url":"https://api.github.com/repos/obrien951/psi4/assignees{/user}","branches_url":"https://api.github.com/repos/obrien951/psi4/branches{/branch}","tags_url":"https://api.github.com/repos/obrien951/psi4/tags","blobs_url":"https://api.github.com/repos/obrien951/psi4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obrien951/psi4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obrien951/psi4/git/refs{/sha}","trees_url":"https://api.github.com/repos/obrien951/psi4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obrien951/psi4/statuses/{sha}","languages_url":"https://api.github.com/repos/obrien951/psi4/languages","stargazers_url":"https://api.github.com/repos/obrien951/psi4/stargazers","contributors_url":"https://api.github.com/repos/obrien951/psi4/contributors","subscribers_url":"https://api.github.com/repos/obrien951/psi4/subscribers","subscription_url":"https://api.github.com/repos/obrien951/psi4/subscription","commits_url":"https://api.github.com/repos/obrien951/psi4/commits{/sha}","git_commits_url":"https://api.github.com/repos/obrien951/psi4/git/commits{/sha}","comments_url":"https://api.github.com/repos/obrien951/psi4/comments{/number}","issue_comment_url":"https://api.github.com/repos/obrien951/psi4/issues/comments{/number}","contents_url":"https://api.github.com/repos/obrien951/psi4/contents/{+path}","compare_url":"https://api.github.com/repos/obrien951/psi4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obrien951/psi4/merges","archive_url":"https://api.github.com/repos/obrien951/psi4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obrien951/psi4/downloads","issues_url":"https://api.github.com/repos/obrien951/psi4/issues{/number}","pulls_url":"https://api.github.com/repos/obrien951/psi4/pulls{/number}","milestones_url":"https://api.github.com/repos/obrien951/psi4/milestones{/number}","notifications_url":"https://api.github.com/repos/obrien951/psi4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obrien951/psi4/labels{/name}","releases_url":"https://api.github.com/repos/obrien951/psi4/releases{/id}","deployments_url":"https://api.github.com/repos/obrien951/psi4/deployments","created_at":"2017-05-24T18:44:40Z","updated_at":"2018-06-25T21:18:11Z","pushed_at":"2018-08-17T21:08:37Z","git_url":"git://github.com/obrien951/psi4.git","ssh_url":"git@github.com:obrien951/psi4.git","clone_url":"https://github.com/obrien951/psi4.git","svn_url":"https://github.com/obrien951/psi4","homepage":"http://psicode.org","size":84891,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"psi4:master","ref":"master","sha":"02382298f1691b9919f7b9eff639b8414c378998","user":{"login":"psi4","id":2636883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzY4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2636883?v=4","gravatar_id":"","url":"https://api.github.com/users/psi4","html_url":"https://github.com/psi4","followers_url":"https://api.github.com/users/psi4/followers","following_url":"https://api.github.com/users/psi4/following{/other_user}","gists_url":"https://api.github.com/users/psi4/gists{/gist_id}","starred_url":"https://api.github.com/users/psi4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi4/subscriptions","organizations_url":"https://api.github.com/users/psi4/orgs","repos_url":"https://api.github.com/users/psi4/repos","events_url":"https://api.github.com/users/psi4/events{/privacy}","received_events_url":"https://api.github.com/users/psi4/received_events","type":"Organization","site_admin":false},"repo":{"id":9174469,"node_id":"MDEwOlJlcG9zaXRvcnk5MTc0NDY5","name":"psi4","full_name":"psi4/psi4","owner":{"login":"psi4","id":2636883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzY4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2636883?v=4","gravatar_id":"","url":"https://api.github.com/users/psi4","html_url":"https://github.com/psi4","followers_url":"https://api.github.com/users/psi4/followers","following_url":"https://api.github.com/users/psi4/following{/other_user}","gists_url":"https://api.github.com/users/psi4/gists{/gist_id}","starred_url":"https://api.github.com/users/psi4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi4/subscriptions","organizations_url":"https://api.github.com/users/psi4/orgs","repos_url":"https://api.github.com/users/psi4/repos","events_url":"https://api.github.com/users/psi4/events{/privacy}","received_events_url":"https://api.github.com/users/psi4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/psi4/psi4","description":"Open-Source Quantum Chemistry – an electronic structure package in C++ driven by Python","fork":false,"url":"https://api.github.com/repos/psi4/psi4","forks_url":"https://api.github.com/repos/psi4/psi4/forks","keys_url":"https://api.github.com/repos/psi4/psi4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psi4/psi4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psi4/psi4/teams","hooks_url":"https://api.github.com/repos/psi4/psi4/hooks","issue_events_url":"https://api.github.com/repos/psi4/psi4/issues/events{/number}","events_url":"https://api.github.com/repos/psi4/psi4/events","assignees_url":"https://api.github.com/repos/psi4/psi4/assignees{/user}","branches_url":"https://api.github.com/repos/psi4/psi4/branches{/branch}","tags_url":"https://api.github.com/repos/psi4/psi4/tags","blobs_url":"https://api.github.com/repos/psi4/psi4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psi4/psi4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psi4/psi4/git/refs{/sha}","trees_url":"https://api.github.com/repos/psi4/psi4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psi4/psi4/statuses/{sha}","languages_url":"https://api.github.com/repos/psi4/psi4/languages","stargazers_url":"https://api.github.com/repos/psi4/psi4/stargazers","contributors_url":"https://api.github.com/repos/psi4/psi4/contributors","subscribers_url":"https://api.github.com/repos/psi4/psi4/subscribers","subscription_url":"https://api.github.com/repos/psi4/psi4/subscription","commits_url":"https://api.github.com/repos/psi4/psi4/commits{/sha}","git_commits_url":"https://api.github.com/repos/psi4/psi4/git/commits{/sha}","comments_url":"https://api.github.com/repos/psi4/psi4/comments{/number}","issue_comment_url":"https://api.github.com/repos/psi4/psi4/issues/comments{/number}","contents_url":"https://api.github.com/repos/psi4/psi4/contents/{+path}","compare_url":"https://api.github.com/repos/psi4/psi4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psi4/psi4/merges","archive_url":"https://api.github.com/repos/psi4/psi4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psi4/psi4/downloads","issues_url":"https://api.github.com/repos/psi4/psi4/issues{/number}","pulls_url":"https://api.github.com/repos/psi4/psi4/pulls{/number}","milestones_url":"https://api.github.com/repos/psi4/psi4/milestones{/number}","notifications_url":"https://api.github.com/repos/psi4/psi4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psi4/psi4/labels{/name}","releases_url":"https://api.github.com/repos/psi4/psi4/releases{/id}","deployments_url":"https://api.github.com/repos/psi4/psi4/deployments","created_at":"2013-04-02T16:21:04Z","updated_at":"2018-08-17T14:29:06Z","pushed_at":"2018-08-17T23:27:48Z","git_url":"git://github.com/psi4/psi4.git","ssh_url":"git@github.com:psi4/psi4.git","clone_url":"https://github.com/psi4/psi4.git","svn_url":"https://github.com/psi4/psi4","homepage":"http://psicode.org","size":84894,"stargazers_count":233,"watchers_count":233,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":190,"open_issues":81,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1140"},"html":{"href":"https://github.com/psi4/psi4/pull/1140"},"issue":{"href":"https://api.github.com/repos/psi4/psi4/issues/1140"},"comments":{"href":"https://api.github.com/repos/psi4/psi4/issues/1140/comments"},"review_comments":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1140/comments"},"review_comment":{"href":"https://api.github.com/repos/psi4/psi4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1140/commits"},"statuses":{"href":"https://api.github.com/repos/psi4/psi4/statuses/012bf2be9d8b86ef21a384de9138d62803cc33a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgasmith"}}