{"action":"created","comment":{"url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/comments/234659233","pull_request_review_id":176347412,"id":234659233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDY1OTIzMw==","diff_hunk":"@@ -17,7 +17,7 @@\n     ->setWorkerMethod('start')\n     ->setName('Retry Requester')\n     ->setCronExpression('* * * * *')\n-    ->setCanWorkInParallel(false)\n+    ->setCanWorkInParallel(true)\n     ->setDefaultImportance(10)\n     ->setScheduleLimit(50)","path":"UseCase45/bin/setup-worker.php","position":null,"original_position":7,"commit_id":"71b7aa4b2be3a1a42838d0a17f3d27aebb305b1a","original_commit_id":"00b13effa93473d52108a6774c85c49769408b5f","user":{"login":"rhift","id":1008958,"node_id":"MDQ6VXNlcjEwMDg5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1008958?v=4","gravatar_id":"","url":"https://api.github.com/users/rhift","html_url":"https://github.com/rhift","followers_url":"https://api.github.com/users/rhift/followers","following_url":"https://api.github.com/users/rhift/following{/other_user}","gists_url":"https://api.github.com/users/rhift/gists{/gist_id}","starred_url":"https://api.github.com/users/rhift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhift/subscriptions","organizations_url":"https://api.github.com/users/rhift/orgs","repos_url":"https://api.github.com/users/rhift/repos","events_url":"https://api.github.com/users/rhift/events{/privacy}","received_events_url":"https://api.github.com/users/rhift/received_events","type":"User","site_admin":false},"body":"good catch, flipping it reflects the use case, ty!","created_at":"2018-11-19T15:20:54Z","updated_at":"2018-11-19T15:20:54Z","html_url":"https://github.com/neighborhoods/KojoFitness/pull/16#discussion_r234659233","pull_request_url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/comments/234659233"},"html":{"href":"https://github.com/neighborhoods/KojoFitness/pull/16#discussion_r234659233"},"pull_request":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16"}},"in_reply_to_id":234653225},"pull_request":{"url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16","id":231831180,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODMxMTgw","html_url":"https://github.com/neighborhoods/KojoFitness/pull/16","diff_url":"https://github.com/neighborhoods/KojoFitness/pull/16.diff","patch_url":"https://github.com/neighborhoods/KojoFitness/pull/16.patch","issue_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/16","number":16,"state":"open","locked":false,"title":"Update setup-worker.php","user":{"login":"rhift","id":1008958,"node_id":"MDQ6VXNlcjEwMDg5NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1008958?v=4","gravatar_id":"","url":"https://api.github.com/users/rhift","html_url":"https://github.com/rhift","followers_url":"https://api.github.com/users/rhift/followers","following_url":"https://api.github.com/users/rhift/following{/other_user}","gists_url":"https://api.github.com/users/rhift/gists{/gist_id}","starred_url":"https://api.github.com/users/rhift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhift/subscriptions","organizations_url":"https://api.github.com/users/rhift/orgs","repos_url":"https://api.github.com/users/rhift/repos","events_url":"https://api.github.com/users/rhift/events{/privacy}","received_events_url":"https://api.github.com/users/rhift/received_events","type":"User","site_admin":false},"body":"Set `can_work_in_parallel` to `true` when `schedule_limit` is not equal to one.\r\n\r\nI think that we probably want to do one of the following:\r\n1. Remove `can_work_in_parallel` in the future and instead just inspect `schedule_limit` if there are no use cases for keeping scheduled jobs that must be run in sequence.\r\n2. Change the behavior of the `Selector` to be less aggressive about sending `Command`s for help if it hasn't already validated that there are no other types of `Job`s to be worked that don't have an acquired mutex AND have `can_work_in_parallel` as `false`, i.e. - there are truly no other workable `Job\\Type`s.\r\n\r\nAs of this writing I prefer (1) because it's less complicated and I can't think of a use case that isn't already solved by some pattern in user space, but I want us to think about it.\r\n\r\ncc @arielallon ","created_at":"2018-11-19T01:28:56Z","updated_at":"2018-11-19T15:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9b81fc4d975ee9610e54d0d63b9f61e48258a20","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexberryman","id":1881846,"node_id":"MDQ6VXNlcjE4ODE4NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1881846?v=4","gravatar_id":"","url":"https://api.github.com/users/alexberryman","html_url":"https://github.com/alexberryman","followers_url":"https://api.github.com/users/alexberryman/followers","following_url":"https://api.github.com/users/alexberryman/following{/other_user}","gists_url":"https://api.github.com/users/alexberryman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexberryman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexberryman/subscriptions","organizations_url":"https://api.github.com/users/alexberryman/orgs","repos_url":"https://api.github.com/users/alexberryman/repos","events_url":"https://api.github.com/users/alexberryman/events{/privacy}","received_events_url":"https://api.github.com/users/alexberryman/received_events","type":"User","site_admin":false},{"login":"p-mucha","id":32273336,"node_id":"MDQ6VXNlcjMyMjczMzM2","avatar_url":"https://avatars1.githubusercontent.com/u/32273336?v=4","gravatar_id":"","url":"https://api.github.com/users/p-mucha","html_url":"https://github.com/p-mucha","followers_url":"https://api.github.com/users/p-mucha/followers","following_url":"https://api.github.com/users/p-mucha/following{/other_user}","gists_url":"https://api.github.com/users/p-mucha/gists{/gist_id}","starred_url":"https://api.github.com/users/p-mucha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-mucha/subscriptions","organizations_url":"https://api.github.com/users/p-mucha/orgs","repos_url":"https://api.github.com/users/p-mucha/repos","events_url":"https://api.github.com/users/p-mucha/events{/privacy}","received_events_url":"https://api.github.com/users/p-mucha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16/commits","review_comments_url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16/comments","review_comment_url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/16/comments","statuses_url":"https://api.github.com/repos/neighborhoods/KojoFitness/statuses/71b7aa4b2be3a1a42838d0a17f3d27aebb305b1a","head":{"label":"neighborhoods:bugfix/use-case-45-job-type-definition","ref":"bugfix/use-case-45-job-type-definition","sha":"71b7aa4b2be3a1a42838d0a17f3d27aebb305b1a","user":{"login":"neighborhoods","id":8584765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODQ3NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8584765?v=4","gravatar_id":"","url":"https://api.github.com/users/neighborhoods","html_url":"https://github.com/neighborhoods","followers_url":"https://api.github.com/users/neighborhoods/followers","following_url":"https://api.github.com/users/neighborhoods/following{/other_user}","gists_url":"https://api.github.com/users/neighborhoods/gists{/gist_id}","starred_url":"https://api.github.com/users/neighborhoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neighborhoods/subscriptions","organizations_url":"https://api.github.com/users/neighborhoods/orgs","repos_url":"https://api.github.com/users/neighborhoods/repos","events_url":"https://api.github.com/users/neighborhoods/events{/privacy}","received_events_url":"https://api.github.com/users/neighborhoods/received_events","type":"Organization","site_admin":false},"repo":{"id":142911304,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MTEzMDQ=","name":"KojoFitness","full_name":"neighborhoods/KojoFitness","private":false,"owner":{"login":"neighborhoods","id":8584765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODQ3NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8584765?v=4","gravatar_id":"","url":"https://api.github.com/users/neighborhoods","html_url":"https://github.com/neighborhoods","followers_url":"https://api.github.com/users/neighborhoods/followers","following_url":"https://api.github.com/users/neighborhoods/following{/other_user}","gists_url":"https://api.github.com/users/neighborhoods/gists{/gist_id}","starred_url":"https://api.github.com/users/neighborhoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neighborhoods/subscriptions","organizations_url":"https://api.github.com/users/neighborhoods/orgs","repos_url":"https://api.github.com/users/neighborhoods/repos","events_url":"https://api.github.com/users/neighborhoods/events{/privacy}","received_events_url":"https://api.github.com/users/neighborhoods/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neighborhoods/KojoFitness","description":"Fitness functions for Kōjō.","fork":false,"url":"https://api.github.com/repos/neighborhoods/KojoFitness","forks_url":"https://api.github.com/repos/neighborhoods/KojoFitness/forks","keys_url":"https://api.github.com/repos/neighborhoods/KojoFitness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neighborhoods/KojoFitness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neighborhoods/KojoFitness/teams","hooks_url":"https://api.github.com/repos/neighborhoods/KojoFitness/hooks","issue_events_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/events{/number}","events_url":"https://api.github.com/repos/neighborhoods/KojoFitness/events","assignees_url":"https://api.github.com/repos/neighborhoods/KojoFitness/assignees{/user}","branches_url":"https://api.github.com/repos/neighborhoods/KojoFitness/branches{/branch}","tags_url":"https://api.github.com/repos/neighborhoods/KojoFitness/tags","blobs_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/refs{/sha}","trees_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neighborhoods/KojoFitness/statuses/{sha}","languages_url":"https://api.github.com/repos/neighborhoods/KojoFitness/languages","stargazers_url":"https://api.github.com/repos/neighborhoods/KojoFitness/stargazers","contributors_url":"https://api.github.com/repos/neighborhoods/KojoFitness/contributors","subscribers_url":"https://api.github.com/repos/neighborhoods/KojoFitness/subscribers","subscription_url":"https://api.github.com/repos/neighborhoods/KojoFitness/subscription","commits_url":"https://api.github.com/repos/neighborhoods/KojoFitness/commits{/sha}","git_commits_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/commits{/sha}","comments_url":"https://api.github.com/repos/neighborhoods/KojoFitness/comments{/number}","issue_comment_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/comments{/number}","contents_url":"https://api.github.com/repos/neighborhoods/KojoFitness/contents/{+path}","compare_url":"https://api.github.com/repos/neighborhoods/KojoFitness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neighborhoods/KojoFitness/merges","archive_url":"https://api.github.com/repos/neighborhoods/KojoFitness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neighborhoods/KojoFitness/downloads","issues_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues{/number}","pulls_url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls{/number}","milestones_url":"https://api.github.com/repos/neighborhoods/KojoFitness/milestones{/number}","notifications_url":"https://api.github.com/repos/neighborhoods/KojoFitness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neighborhoods/KojoFitness/labels{/name}","releases_url":"https://api.github.com/repos/neighborhoods/KojoFitness/releases{/id}","deployments_url":"https://api.github.com/repos/neighborhoods/KojoFitness/deployments","created_at":"2018-07-30T18:09:50Z","updated_at":"2018-11-10T17:28:52Z","pushed_at":"2018-11-19T15:20:16Z","git_url":"git://github.com/neighborhoods/KojoFitness.git","ssh_url":"git@github.com:neighborhoods/KojoFitness.git","clone_url":"https://github.com/neighborhoods/KojoFitness.git","svn_url":"https://github.com/neighborhoods/KojoFitness","homepage":"","size":132,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"4.x"}},"base":{"label":"neighborhoods:4.x","ref":"4.x","sha":"a7ea597698383abc08843a6601a86c7be45f859d","user":{"login":"neighborhoods","id":8584765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODQ3NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8584765?v=4","gravatar_id":"","url":"https://api.github.com/users/neighborhoods","html_url":"https://github.com/neighborhoods","followers_url":"https://api.github.com/users/neighborhoods/followers","following_url":"https://api.github.com/users/neighborhoods/following{/other_user}","gists_url":"https://api.github.com/users/neighborhoods/gists{/gist_id}","starred_url":"https://api.github.com/users/neighborhoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neighborhoods/subscriptions","organizations_url":"https://api.github.com/users/neighborhoods/orgs","repos_url":"https://api.github.com/users/neighborhoods/repos","events_url":"https://api.github.com/users/neighborhoods/events{/privacy}","received_events_url":"https://api.github.com/users/neighborhoods/received_events","type":"Organization","site_admin":false},"repo":{"id":142911304,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MTEzMDQ=","name":"KojoFitness","full_name":"neighborhoods/KojoFitness","private":false,"owner":{"login":"neighborhoods","id":8584765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1ODQ3NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8584765?v=4","gravatar_id":"","url":"https://api.github.com/users/neighborhoods","html_url":"https://github.com/neighborhoods","followers_url":"https://api.github.com/users/neighborhoods/followers","following_url":"https://api.github.com/users/neighborhoods/following{/other_user}","gists_url":"https://api.github.com/users/neighborhoods/gists{/gist_id}","starred_url":"https://api.github.com/users/neighborhoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neighborhoods/subscriptions","organizations_url":"https://api.github.com/users/neighborhoods/orgs","repos_url":"https://api.github.com/users/neighborhoods/repos","events_url":"https://api.github.com/users/neighborhoods/events{/privacy}","received_events_url":"https://api.github.com/users/neighborhoods/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neighborhoods/KojoFitness","description":"Fitness functions for Kōjō.","fork":false,"url":"https://api.github.com/repos/neighborhoods/KojoFitness","forks_url":"https://api.github.com/repos/neighborhoods/KojoFitness/forks","keys_url":"https://api.github.com/repos/neighborhoods/KojoFitness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neighborhoods/KojoFitness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neighborhoods/KojoFitness/teams","hooks_url":"https://api.github.com/repos/neighborhoods/KojoFitness/hooks","issue_events_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/events{/number}","events_url":"https://api.github.com/repos/neighborhoods/KojoFitness/events","assignees_url":"https://api.github.com/repos/neighborhoods/KojoFitness/assignees{/user}","branches_url":"https://api.github.com/repos/neighborhoods/KojoFitness/branches{/branch}","tags_url":"https://api.github.com/repos/neighborhoods/KojoFitness/tags","blobs_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/refs{/sha}","trees_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neighborhoods/KojoFitness/statuses/{sha}","languages_url":"https://api.github.com/repos/neighborhoods/KojoFitness/languages","stargazers_url":"https://api.github.com/repos/neighborhoods/KojoFitness/stargazers","contributors_url":"https://api.github.com/repos/neighborhoods/KojoFitness/contributors","subscribers_url":"https://api.github.com/repos/neighborhoods/KojoFitness/subscribers","subscription_url":"https://api.github.com/repos/neighborhoods/KojoFitness/subscription","commits_url":"https://api.github.com/repos/neighborhoods/KojoFitness/commits{/sha}","git_commits_url":"https://api.github.com/repos/neighborhoods/KojoFitness/git/commits{/sha}","comments_url":"https://api.github.com/repos/neighborhoods/KojoFitness/comments{/number}","issue_comment_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/comments{/number}","contents_url":"https://api.github.com/repos/neighborhoods/KojoFitness/contents/{+path}","compare_url":"https://api.github.com/repos/neighborhoods/KojoFitness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neighborhoods/KojoFitness/merges","archive_url":"https://api.github.com/repos/neighborhoods/KojoFitness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neighborhoods/KojoFitness/downloads","issues_url":"https://api.github.com/repos/neighborhoods/KojoFitness/issues{/number}","pulls_url":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls{/number}","milestones_url":"https://api.github.com/repos/neighborhoods/KojoFitness/milestones{/number}","notifications_url":"https://api.github.com/repos/neighborhoods/KojoFitness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neighborhoods/KojoFitness/labels{/name}","releases_url":"https://api.github.com/repos/neighborhoods/KojoFitness/releases{/id}","deployments_url":"https://api.github.com/repos/neighborhoods/KojoFitness/deployments","created_at":"2018-07-30T18:09:50Z","updated_at":"2018-11-10T17:28:52Z","pushed_at":"2018-11-19T15:20:16Z","git_url":"git://github.com/neighborhoods/KojoFitness.git","ssh_url":"git@github.com:neighborhoods/KojoFitness.git","clone_url":"https://github.com/neighborhoods/KojoFitness.git","svn_url":"https://github.com/neighborhoods/KojoFitness","homepage":"","size":132,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16"},"html":{"href":"https://github.com/neighborhoods/KojoFitness/pull/16"},"issue":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/16"},"comments":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/neighborhoods/KojoFitness/statuses/71b7aa4b2be3a1a42838d0a17f3d27aebb305b1a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rhift"}}