{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/206618457","pull_request_review_id":142065346,"id":206618457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjYxODQ1Nw==","diff_hunk":"@@ -98,11 +89,17 @@ function genericQueryCacheTests(): void {\n     );\n   }\n \n+  let persistence: Persistence;\n   beforeEach(async () => {\n+    persistence = await persistencePromise();\n     cache = new TestQueryCache(persistence, persistence.getQueryCache());\n     await cache.start();\n   });\n \n+  afterEach(async () => {\n+    persistence.shutdown(/* deletaData= */ true);","path":"packages/firestore/test/unit/local/query_cache.test.ts","position":null,"original_position":62,"commit_id":"9e570c87326061f957d2ece60ebb0db1493fe369","original_commit_id":"80a24598ccbc5aa1c51a8dac2f8808f1b4b31d47","user":{"login":"gsoltis","id":418301,"node_id":"MDQ6VXNlcjQxODMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false},"body":"This was apparently a load-bearing typo. CI has been failing since I fixed it...","created_at":"2018-07-31T17:35:37Z","updated_at":"2018-07-31T17:35:37Z","html_url":"https://github.com/firebase/firebase-js-sdk/pull/1047#discussion_r206618457","pull_request_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments/206618457"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/1047#discussion_r206618457"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047"}},"in_reply_to_id":206359786},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047","id":203978405,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTc4NDA1","html_url":"https://github.com/firebase/firebase-js-sdk/pull/1047","diff_url":"https://github.com/firebase/firebase-js-sdk/pull/1047.diff","patch_url":"https://github.com/firebase/firebase-js-sdk/pull/1047.patch","issue_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1047","number":1047,"state":"open","locked":false,"title":"Add a type parameter to Persistence","user":{"login":"gsoltis","id":418301,"node_id":"MDQ6VXNlcjQxODMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false},"body":"Adds a type parameter to `Persistence` to specify the transaction type. Threads the parameter through where necessary. The end result is being able to remove some casts and adds the ability to add persistence-layer-specific fields to transactions in a type-safe manner.\r\n\r\nNo behavior changes are intended.","created_at":"2018-07-25T22:14:22Z","updated_at":"2018-07-31T17:35:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96201a094a0aecee21b136b41cda131d4bc9fa51","assignee":{"login":"gsoltis","id":418301,"node_id":"MDQ6VXNlcjQxODMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false},"assignees":[{"login":"gsoltis","id":418301,"node_id":"MDQ6VXNlcjQxODMwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/418301?v=4","gravatar_id":"","url":"https://api.github.com/users/gsoltis","html_url":"https://github.com/gsoltis","followers_url":"https://api.github.com/users/gsoltis/followers","following_url":"https://api.github.com/users/gsoltis/following{/other_user}","gists_url":"https://api.github.com/users/gsoltis/gists{/gist_id}","starred_url":"https://api.github.com/users/gsoltis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsoltis/subscriptions","organizations_url":"https://api.github.com/users/gsoltis/orgs","repos_url":"https://api.github.com/users/gsoltis/repos","events_url":"https://api.github.com/users/gsoltis/events{/privacy}","received_events_url":"https://api.github.com/users/gsoltis/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wilhuff","id":10249104,"node_id":"MDQ6VXNlcjEwMjQ5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/10249104?v=4","gravatar_id":"","url":"https://api.github.com/users/wilhuff","html_url":"https://github.com/wilhuff","followers_url":"https://api.github.com/users/wilhuff/followers","following_url":"https://api.github.com/users/wilhuff/following{/other_user}","gists_url":"https://api.github.com/users/wilhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhuff/subscriptions","organizations_url":"https://api.github.com/users/wilhuff/orgs","repos_url":"https://api.github.com/users/wilhuff/repos","events_url":"https://api.github.com/users/wilhuff/events{/privacy}","received_events_url":"https://api.github.com/users/wilhuff/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1047/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/9e570c87326061f957d2ece60ebb0db1493fe369","head":{"label":"firebase:gsoltis/typed_transactions","ref":"gsoltis/typed_transactions","sha":"9e570c87326061f957d2ece60ebb0db1493fe369","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI5MDQ4Mw==","name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-07-31T15:45:45Z","pushed_at":"2018-07-31T17:24:09Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":16061,"stargazers_count":1275,"watchers_count":1275,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":179,"open_issues":148,"watchers":1275,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"1f25d0dff5f7b5379cdb666ff9fc5cf42fb53c79","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89290483,"node_id":"MDEwOlJlcG9zaXRvcnk4OTI5MDQ4Mw==","name":"firebase-js-sdk","full_name":"firebase/firebase-js-sdk","owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/firebase-js-sdk","description":"Firebase Javascript SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-js-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-js-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-js-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-js-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-js-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-js-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-js-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-js-sdk/deployments","created_at":"2017-04-24T21:52:11Z","updated_at":"2018-07-31T15:45:45Z","pushed_at":"2018-07-31T17:24:09Z","git_url":"git://github.com/firebase/firebase-js-sdk.git","ssh_url":"git@github.com:firebase/firebase-js-sdk.git","clone_url":"https://github.com/firebase/firebase-js-sdk.git","svn_url":"https://github.com/firebase/firebase-js-sdk","homepage":"https://firebase.google.com/docs/web/setup","size":16061,"stargazers_count":1275,"watchers_count":1275,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":179,"open_issues":148,"watchers":1275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047"},"html":{"href":"https://github.com/firebase/firebase-js-sdk/pull/1047"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1047"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/issues/1047/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/pulls/1047/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-js-sdk/statuses/9e570c87326061f957d2ece60ebb0db1493fe369"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gsoltis"}}