{"action":"created","issue":{"url":"https://api.github.com/repos/luanpotter/audioplayer/issues/11","repository_url":"https://api.github.com/repos/luanpotter/audioplayer","labels_url":"https://api.github.com/repos/luanpotter/audioplayer/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/luanpotter/audioplayer/issues/11/comments","events_url":"https://api.github.com/repos/luanpotter/audioplayer/issues/11/events","html_url":"https://github.com/luanpotter/audioplayer/issues/11","id":308729472,"number":11,"title":"MediaPlayer gets cleaned up after every completion (Android)","user":{"login":"FelschR","id":3314323,"avatar_url":"https://avatars2.githubusercontent.com/u/3314323?v=4","gravatar_id":"","url":"https://api.github.com/users/FelschR","html_url":"https://github.com/FelschR","followers_url":"https://api.github.com/users/FelschR/followers","following_url":"https://api.github.com/users/FelschR/following{/other_user}","gists_url":"https://api.github.com/users/FelschR/gists{/gist_id}","starred_url":"https://api.github.com/users/FelschR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelschR/subscriptions","organizations_url":"https://api.github.com/users/FelschR/orgs","repos_url":"https://api.github.com/users/FelschR/repos","events_url":"https://api.github.com/users/FelschR/events{/privacy}","received_events_url":"https://api.github.com/users/FelschR/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-26T20:47:43Z","updated_at":"2018-04-01T19:50:02Z","closed_at":null,"author_association":"NONE","body":"In the callback of the completion event of the Android MediaPlayer the MediaPlayer instance is being removed from the mediaPlayers hashmap:\r\nhttps://github.com/luanpotter/audioplayer/blob/f67a3a219c6dd3eed9dc820dbfe95ff6ba24cce0/android/src/main/java/bz/rxla/audioplayer/AudioplayerPlugin.java#L79-L84\r\n\r\nIs there any reason for this?\r\n\r\nIt seems that if play is called again that a new instance will be created. But why not reuse it?"},"comment":{"url":"https://api.github.com/repos/luanpotter/audioplayer/issues/comments/377812040","html_url":"https://github.com/luanpotter/audioplayer/issues/11#issuecomment-377812040","issue_url":"https://api.github.com/repos/luanpotter/audioplayer/issues/11","id":377812040,"user":{"login":"luanpotter","id":882703,"avatar_url":"https://avatars0.githubusercontent.com/u/882703?v=4","gravatar_id":"","url":"https://api.github.com/users/luanpotter","html_url":"https://github.com/luanpotter","followers_url":"https://api.github.com/users/luanpotter/followers","following_url":"https://api.github.com/users/luanpotter/following{/other_user}","gists_url":"https://api.github.com/users/luanpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/luanpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luanpotter/subscriptions","organizations_url":"https://api.github.com/users/luanpotter/orgs","repos_url":"https://api.github.com/users/luanpotter/repos","events_url":"https://api.github.com/users/luanpotter/events{/privacy}","received_events_url":"https://api.github.com/users/luanpotter/received_events","type":"User","site_admin":false},"created_at":"2018-04-01T19:50:01Z","updated_at":"2018-04-01T19:50:01Z","author_association":"OWNER","body":"It seems that this behavior was introduced on #7 by @the4thfloor as part of an awesome refactoring related to UI blocking; I wonder if there is a reason for that, or if it was just a slip. What do you guys think? If it is the case, simply removing this line 84 will be better? If so, I'd be glad to merge a PR.\r\n\r\nThanks for your contributions and sorry for the delay!"}}
{"actor":{"display_login":"luanpotter"}}