{"action":"created","comment":{"url":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments/232229335","pull_request_review_id":173379795,"id":232229335,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjIyOTMzNQ==","diff_hunk":"@@ -65,19 +65,20 @@ defmodule OMG.Watcher.Integration.InvalidExitTest do\n         alice.addr\n       )\n \n-    {:ok, %{\"status\" => \"0x1\"}} = Eth.WaitFor.eth_receipt(txhash, @timeout)\n-\n-    Process.sleep(1_000)\n+    # TODO: make event payload testing approximate not exact, so that we needn't parse\n+    {:ok, %{\"status\" => \"0x1\", \"blockNumber\" => \"0x\" <> eth_height}} = Eth.WaitFor.eth_receipt(txhash, @timeout)\n+    {eth_height, \"\"} = Integer.parse(eth_height, 16)\n \n     invalid_exit_event =\n       Client.encode(%Event.InvalidExit{\n         amount: 10,\n         currency: @eth,\n         owner: alice.addr,\n-        utxo_pos: utxo_pos\n+        utxo_pos: utxo_pos,\n+        eth_height: eth_height\n       })\n \n-    assert_push(\"invalid_exit\", ^invalid_exit_event)\n+    assert_push(\"invalid_exit\", ^invalid_exit_event, 5_000)","path":"apps/omg_watcher/test/integration/invalid_exit_test.exs","position":22,"original_position":22,"commit_id":"65ddc2467e0828240b2b2ed8d1b43dc5bfb557d9","original_commit_id":"65ddc2467e0828240b2b2ed8d1b43dc5bfb557d9","user":{"login":"pdobacz","id":5735525,"node_id":"MDQ6VXNlcjU3MzU1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5735525?v=4","gravatar_id":"","url":"https://api.github.com/users/pdobacz","html_url":"https://github.com/pdobacz","followers_url":"https://api.github.com/users/pdobacz/followers","following_url":"https://api.github.com/users/pdobacz/following{/other_user}","gists_url":"https://api.github.com/users/pdobacz/gists{/gist_id}","starred_url":"https://api.github.com/users/pdobacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdobacz/subscriptions","organizations_url":"https://api.github.com/users/pdobacz/orgs","repos_url":"https://api.github.com/users/pdobacz/repos","events_url":"https://api.github.com/users/pdobacz/events{/privacy}","received_events_url":"https://api.github.com/users/pdobacz/received_events","type":"User","site_admin":false},"body":"only here we don't know how long to wait exactly, so the custom timeout is useful to not wait anything extra. In other cases, we're waiting on other things (a particular child block validation, `BlockGetter` stopping) so the timeout is not necessary.","created_at":"2018-11-09T11:56:04Z","updated_at":"2018-11-09T11:56:04Z","html_url":"https://github.com/omisego/elixir-omg/pull/265#discussion_r232229335","pull_request_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/265","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments/232229335"},"html":{"href":"https://github.com/omisego/elixir-omg/pull/265#discussion_r232229335"},"pull_request":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/265"}},"in_reply_to_id":232175751},"pull_request":{"url":"https://api.github.com/repos/omisego/elixir-omg/pulls/265","id":229425895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDI1ODk1","html_url":"https://github.com/omisego/elixir-omg/pull/265","diff_url":"https://github.com/omisego/elixir-omg/pull/265.diff","patch_url":"https://github.com/omisego/elixir-omg/pull/265.patch","issue_url":"https://api.github.com/repos/omisego/elixir-omg/issues/265","number":265,"state":"open","locked":false,"title":"Feature/omg 306 spend on finalization","user":{"login":"pdobacz","id":5735525,"node_id":"MDQ6VXNlcjU3MzU1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5735525?v=4","gravatar_id":"","url":"https://api.github.com/users/pdobacz","html_url":"https://github.com/pdobacz","followers_url":"https://api.github.com/users/pdobacz/followers","following_url":"https://api.github.com/users/pdobacz/following{/other_user}","gists_url":"https://api.github.com/users/pdobacz/gists{/gist_id}","starred_url":"https://api.github.com/users/pdobacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdobacz/subscriptions","organizations_url":"https://api.github.com/users/pdobacz/orgs","repos_url":"https://api.github.com/users/pdobacz/repos","events_url":"https://api.github.com/users/pdobacz/events{/privacy}","received_events_url":"https://api.github.com/users/pdobacz/received_events","type":"User","site_admin":false},"body":"This is a first of series of PRs. I need to punt some tidies (as enumerated in numerous) and fixes to let this through and become a building block for MoreVP","created_at":"2018-11-08T16:20:19Z","updated_at":"2018-11-09T11:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1561cbeecc940f0b6b6b8a66f00e7f5108ffc0a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/265/commits","review_comments_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/265/comments","review_comment_url":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/issues/265/comments","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/65ddc2467e0828240b2b2ed8d1b43dc5bfb557d9","head":{"label":"omisego:feature/OMG-306_spend_on_finalization","ref":"feature/OMG-306_spend_on_finalization","sha":"65ddc2467e0828240b2b2ed8d1b43dc5bfb557d9","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":123528600,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Mjg2MDA=","name":"elixir-omg","full_name":"omisego/elixir-omg","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/elixir-omg","description":null,"fork":false,"url":"https://api.github.com/repos/omisego/elixir-omg","forks_url":"https://api.github.com/repos/omisego/elixir-omg/forks","keys_url":"https://api.github.com/repos/omisego/elixir-omg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/elixir-omg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/elixir-omg/teams","hooks_url":"https://api.github.com/repos/omisego/elixir-omg/hooks","issue_events_url":"https://api.github.com/repos/omisego/elixir-omg/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/elixir-omg/events","assignees_url":"https://api.github.com/repos/omisego/elixir-omg/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/elixir-omg/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/elixir-omg/tags","blobs_url":"https://api.github.com/repos/omisego/elixir-omg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/elixir-omg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/elixir-omg/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/elixir-omg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/elixir-omg/languages","stargazers_url":"https://api.github.com/repos/omisego/elixir-omg/stargazers","contributors_url":"https://api.github.com/repos/omisego/elixir-omg/contributors","subscribers_url":"https://api.github.com/repos/omisego/elixir-omg/subscribers","subscription_url":"https://api.github.com/repos/omisego/elixir-omg/subscription","commits_url":"https://api.github.com/repos/omisego/elixir-omg/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/elixir-omg/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/elixir-omg/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/elixir-omg/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/elixir-omg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/elixir-omg/merges","archive_url":"https://api.github.com/repos/omisego/elixir-omg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/elixir-omg/downloads","issues_url":"https://api.github.com/repos/omisego/elixir-omg/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/elixir-omg/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/elixir-omg/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/elixir-omg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/elixir-omg/labels{/name}","releases_url":"https://api.github.com/repos/omisego/elixir-omg/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/elixir-omg/deployments","created_at":"2018-03-02T04:05:24Z","updated_at":"2018-11-09T07:23:30Z","pushed_at":"2018-11-09T11:30:03Z","git_url":"git://github.com/omisego/elixir-omg.git","ssh_url":"git@github.com:omisego/elixir-omg.git","clone_url":"https://github.com/omisego/elixir-omg.git","svn_url":"https://github.com/omisego/elixir-omg","homepage":null,"size":5823,"stargazers_count":107,"watchers_count":107,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":9,"watchers":107,"default_branch":"develop"}},"base":{"label":"omisego:develop","ref":"develop","sha":"9c8a5003561b996bf4fcce29686280dba8b8e30e","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":123528600,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Mjg2MDA=","name":"elixir-omg","full_name":"omisego/elixir-omg","private":false,"owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/omisego/elixir-omg","description":null,"fork":false,"url":"https://api.github.com/repos/omisego/elixir-omg","forks_url":"https://api.github.com/repos/omisego/elixir-omg/forks","keys_url":"https://api.github.com/repos/omisego/elixir-omg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/elixir-omg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/elixir-omg/teams","hooks_url":"https://api.github.com/repos/omisego/elixir-omg/hooks","issue_events_url":"https://api.github.com/repos/omisego/elixir-omg/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/elixir-omg/events","assignees_url":"https://api.github.com/repos/omisego/elixir-omg/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/elixir-omg/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/elixir-omg/tags","blobs_url":"https://api.github.com/repos/omisego/elixir-omg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/elixir-omg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/elixir-omg/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/elixir-omg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/elixir-omg/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/elixir-omg/languages","stargazers_url":"https://api.github.com/repos/omisego/elixir-omg/stargazers","contributors_url":"https://api.github.com/repos/omisego/elixir-omg/contributors","subscribers_url":"https://api.github.com/repos/omisego/elixir-omg/subscribers","subscription_url":"https://api.github.com/repos/omisego/elixir-omg/subscription","commits_url":"https://api.github.com/repos/omisego/elixir-omg/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/elixir-omg/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/elixir-omg/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/elixir-omg/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/elixir-omg/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/elixir-omg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/elixir-omg/merges","archive_url":"https://api.github.com/repos/omisego/elixir-omg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/elixir-omg/downloads","issues_url":"https://api.github.com/repos/omisego/elixir-omg/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/elixir-omg/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/elixir-omg/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/elixir-omg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/elixir-omg/labels{/name}","releases_url":"https://api.github.com/repos/omisego/elixir-omg/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/elixir-omg/deployments","created_at":"2018-03-02T04:05:24Z","updated_at":"2018-11-09T07:23:30Z","pushed_at":"2018-11-09T11:30:03Z","git_url":"git://github.com/omisego/elixir-omg.git","ssh_url":"git@github.com:omisego/elixir-omg.git","clone_url":"https://github.com/omisego/elixir-omg.git","svn_url":"https://github.com/omisego/elixir-omg","homepage":null,"size":5823,"stargazers_count":107,"watchers_count":107,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":9,"watchers":107,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/265"},"html":{"href":"https://github.com/omisego/elixir-omg/pull/265"},"issue":{"href":"https://api.github.com/repos/omisego/elixir-omg/issues/265"},"comments":{"href":"https://api.github.com/repos/omisego/elixir-omg/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omisego/elixir-omg/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/omisego/elixir-omg/statuses/65ddc2467e0828240b2b2ed8d1b43dc5bfb557d9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pdobacz"}}