{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/rpc_component/pulls/comments/208187377","pull_request_review_id":143944204,"id":208187377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE4NzM3Nw==","diff_hunk":"@@ -134,20 +135,59 @@ def is_version_ids_unique(releases):\n     }\n )\n \n-component_metadata_schema = Schema(\n+dependencies_schema = Schema(\n     {\n-        \"dependencies\": And(\n+        Optional(\"dependencies\"): And(\n             [\n                 {\n                     \"name\": And(str, len),\n                     \"constraints\": constraints_schema,\n                 },\n             ],\n             is_value_unique(\"name\"),\n+        )\n+    }\n+)\n+\n+artifacts_file_schema = Schema(\n+    {\n+        \"type\": \"file\",\n+        \"source\": And(str, len),\n+        Optional(\"dest\"): And(str, len),\n+        Optional(\"expire_after\"): And(str, len)\n+    }\n+)\n+\n+artifacts_log_schema = Schema(\n+    {\n+        \"type\": \"log\",\n+        \"source\": And(str, len)\n+    }\n+)\n+\n+artifacts_schema = Schema(\n+    {\n+        Optional(\"artifacts\"): And(\n+            [\n+                Or(artifacts_file_schema, artifacts_log_schema, None)","path":"rpc_component/schemata.py","position":45,"original_position":45,"commit_id":"faed3ff57d767b58734638071b2f068c469577cd","original_commit_id":"059a5a492f82d0990aeb995417a7158e8f59d07e","user":{"login":"odyssey4me","id":2152106,"node_id":"MDQ6VXNlcjIxNTIxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2152106?v=4","gravatar_id":"","url":"https://api.github.com/users/odyssey4me","html_url":"https://github.com/odyssey4me","followers_url":"https://api.github.com/users/odyssey4me/followers","following_url":"https://api.github.com/users/odyssey4me/following{/other_user}","gists_url":"https://api.github.com/users/odyssey4me/gists{/gist_id}","starred_url":"https://api.github.com/users/odyssey4me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyssey4me/subscriptions","organizations_url":"https://api.github.com/users/odyssey4me/orgs","repos_url":"https://api.github.com/users/odyssey4me/repos","events_url":"https://api.github.com/users/odyssey4me/events{/privacy}","received_events_url":"https://api.github.com/users/odyssey4me/received_events","type":"User","site_admin":false},"body":"``None`` is to allow for the list to be empty, this this is to cater for:\r\n\r\n```yaml\r\nartifacts: []\r\n```","created_at":"2018-08-07T11:04:24Z","updated_at":"2018-08-07T11:04:25Z","html_url":"https://github.com/rcbops/rpc_component/pull/6#discussion_r208187377","pull_request_url":"https://api.github.com/repos/rcbops/rpc_component/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc_component/pulls/comments/208187377"},"html":{"href":"https://github.com/rcbops/rpc_component/pull/6#discussion_r208187377"},"pull_request":{"href":"https://api.github.com/repos/rcbops/rpc_component/pulls/6"}},"in_reply_to_id":208155591},"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc_component/pulls/6","id":205128969,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTI4OTY5","html_url":"https://github.com/rcbops/rpc_component/pull/6","diff_url":"https://github.com/rcbops/rpc_component/pull/6.diff","patch_url":"https://github.com/rcbops/rpc_component/pull/6.patch","issue_url":"https://api.github.com/repos/rcbops/rpc_component/issues/6","number":6,"state":"open","locked":false,"title":"Add schema for new artifact upload configuration","user":{"login":"odyssey4me","id":2152106,"node_id":"MDQ6VXNlcjIxNTIxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2152106?v=4","gravatar_id":"","url":"https://api.github.com/users/odyssey4me","html_url":"https://github.com/odyssey4me","followers_url":"https://api.github.com/users/odyssey4me/followers","following_url":"https://api.github.com/users/odyssey4me/following{/other_user}","gists_url":"https://api.github.com/users/odyssey4me/gists{/gist_id}","starred_url":"https://api.github.com/users/odyssey4me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyssey4me/subscriptions","organizations_url":"https://api.github.com/users/odyssey4me/orgs","repos_url":"https://api.github.com/users/odyssey4me/repos","events_url":"https://api.github.com/users/odyssey4me/events{/privacy}","received_events_url":"https://api.github.com/users/odyssey4me/received_events","type":"User","site_admin":false},"body":"In order to facilitate in-repo configuration of artifacts\r\nto be uploaded from jobs, we add the schema validation and\r\nappropriate tests for the new 'artifacts' key and the two\r\ninitial types: 'log' and 'file'.\r\n\r\nIssue: [RE-1325](https://rpc-openstack.atlassian.net/browse/RE-1325)","created_at":"2018-07-31T14:18:25Z","updated_at":"2018-08-07T11:04:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01ec8055819d581ec5447708e6d6e45318a50dc3","assignee":{"login":"odyssey4me","id":2152106,"node_id":"MDQ6VXNlcjIxNTIxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2152106?v=4","gravatar_id":"","url":"https://api.github.com/users/odyssey4me","html_url":"https://github.com/odyssey4me","followers_url":"https://api.github.com/users/odyssey4me/followers","following_url":"https://api.github.com/users/odyssey4me/following{/other_user}","gists_url":"https://api.github.com/users/odyssey4me/gists{/gist_id}","starred_url":"https://api.github.com/users/odyssey4me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyssey4me/subscriptions","organizations_url":"https://api.github.com/users/odyssey4me/orgs","repos_url":"https://api.github.com/users/odyssey4me/repos","events_url":"https://api.github.com/users/odyssey4me/events{/privacy}","received_events_url":"https://api.github.com/users/odyssey4me/received_events","type":"User","site_admin":false},"assignees":[{"login":"odyssey4me","id":2152106,"node_id":"MDQ6VXNlcjIxNTIxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2152106?v=4","gravatar_id":"","url":"https://api.github.com/users/odyssey4me","html_url":"https://github.com/odyssey4me","followers_url":"https://api.github.com/users/odyssey4me/followers","following_url":"https://api.github.com/users/odyssey4me/following{/other_user}","gists_url":"https://api.github.com/users/odyssey4me/gists{/gist_id}","starred_url":"https://api.github.com/users/odyssey4me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyssey4me/subscriptions","organizations_url":"https://api.github.com/users/odyssey4me/orgs","repos_url":"https://api.github.com/users/odyssey4me/repos","events_url":"https://api.github.com/users/odyssey4me/events{/privacy}","received_events_url":"https://api.github.com/users/odyssey4me/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/rpc_component/pulls/6/commits","review_comments_url":"https://api.github.com/repos/rcbops/rpc_component/pulls/6/comments","review_comment_url":"https://api.github.com/repos/rcbops/rpc_component/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/rpc_component/issues/6/comments","statuses_url":"https://api.github.com/repos/rcbops/rpc_component/statuses/faed3ff57d767b58734638071b2f068c469577cd","head":{"label":"odyssey4me:RE-1325","ref":"RE-1325","sha":"faed3ff57d767b58734638071b2f068c469577cd","user":{"login":"odyssey4me","id":2152106,"node_id":"MDQ6VXNlcjIxNTIxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2152106?v=4","gravatar_id":"","url":"https://api.github.com/users/odyssey4me","html_url":"https://github.com/odyssey4me","followers_url":"https://api.github.com/users/odyssey4me/followers","following_url":"https://api.github.com/users/odyssey4me/following{/other_user}","gists_url":"https://api.github.com/users/odyssey4me/gists{/gist_id}","starred_url":"https://api.github.com/users/odyssey4me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyssey4me/subscriptions","organizations_url":"https://api.github.com/users/odyssey4me/orgs","repos_url":"https://api.github.com/users/odyssey4me/repos","events_url":"https://api.github.com/users/odyssey4me/events{/privacy}","received_events_url":"https://api.github.com/users/odyssey4me/received_events","type":"User","site_admin":false},"repo":{"id":142446088,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NDYwODg=","name":"rpc_component","full_name":"odyssey4me/rpc_component","owner":{"login":"odyssey4me","id":2152106,"node_id":"MDQ6VXNlcjIxNTIxMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2152106?v=4","gravatar_id":"","url":"https://api.github.com/users/odyssey4me","html_url":"https://github.com/odyssey4me","followers_url":"https://api.github.com/users/odyssey4me/followers","following_url":"https://api.github.com/users/odyssey4me/following{/other_user}","gists_url":"https://api.github.com/users/odyssey4me/gists{/gist_id}","starred_url":"https://api.github.com/users/odyssey4me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odyssey4me/subscriptions","organizations_url":"https://api.github.com/users/odyssey4me/orgs","repos_url":"https://api.github.com/users/odyssey4me/repos","events_url":"https://api.github.com/users/odyssey4me/events{/privacy}","received_events_url":"https://api.github.com/users/odyssey4me/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/odyssey4me/rpc_component","description":null,"fork":true,"url":"https://api.github.com/repos/odyssey4me/rpc_component","forks_url":"https://api.github.com/repos/odyssey4me/rpc_component/forks","keys_url":"https://api.github.com/repos/odyssey4me/rpc_component/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odyssey4me/rpc_component/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odyssey4me/rpc_component/teams","hooks_url":"https://api.github.com/repos/odyssey4me/rpc_component/hooks","issue_events_url":"https://api.github.com/repos/odyssey4me/rpc_component/issues/events{/number}","events_url":"https://api.github.com/repos/odyssey4me/rpc_component/events","assignees_url":"https://api.github.com/repos/odyssey4me/rpc_component/assignees{/user}","branches_url":"https://api.github.com/repos/odyssey4me/rpc_component/branches{/branch}","tags_url":"https://api.github.com/repos/odyssey4me/rpc_component/tags","blobs_url":"https://api.github.com/repos/odyssey4me/rpc_component/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odyssey4me/rpc_component/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odyssey4me/rpc_component/git/refs{/sha}","trees_url":"https://api.github.com/repos/odyssey4me/rpc_component/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odyssey4me/rpc_component/statuses/{sha}","languages_url":"https://api.github.com/repos/odyssey4me/rpc_component/languages","stargazers_url":"https://api.github.com/repos/odyssey4me/rpc_component/stargazers","contributors_url":"https://api.github.com/repos/odyssey4me/rpc_component/contributors","subscribers_url":"https://api.github.com/repos/odyssey4me/rpc_component/subscribers","subscription_url":"https://api.github.com/repos/odyssey4me/rpc_component/subscription","commits_url":"https://api.github.com/repos/odyssey4me/rpc_component/commits{/sha}","git_commits_url":"https://api.github.com/repos/odyssey4me/rpc_component/git/commits{/sha}","comments_url":"https://api.github.com/repos/odyssey4me/rpc_component/comments{/number}","issue_comment_url":"https://api.github.com/repos/odyssey4me/rpc_component/issues/comments{/number}","contents_url":"https://api.github.com/repos/odyssey4me/rpc_component/contents/{+path}","compare_url":"https://api.github.com/repos/odyssey4me/rpc_component/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odyssey4me/rpc_component/merges","archive_url":"https://api.github.com/repos/odyssey4me/rpc_component/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odyssey4me/rpc_component/downloads","issues_url":"https://api.github.com/repos/odyssey4me/rpc_component/issues{/number}","pulls_url":"https://api.github.com/repos/odyssey4me/rpc_component/pulls{/number}","milestones_url":"https://api.github.com/repos/odyssey4me/rpc_component/milestones{/number}","notifications_url":"https://api.github.com/repos/odyssey4me/rpc_component/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odyssey4me/rpc_component/labels{/name}","releases_url":"https://api.github.com/repos/odyssey4me/rpc_component/releases{/id}","deployments_url":"https://api.github.com/repos/odyssey4me/rpc_component/deployments","created_at":"2018-07-26T13:39:07Z","updated_at":"2018-07-26T13:39:09Z","pushed_at":"2018-08-02T12:07:16Z","git_url":"git://github.com/odyssey4me/rpc_component.git","ssh_url":"git@github.com:odyssey4me/rpc_component.git","clone_url":"https://github.com/odyssey4me/rpc_component.git","svn_url":"https://github.com/odyssey4me/rpc_component","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rcbops:master","ref":"master","sha":"9684bcf1744d62988538f141fb98af0dd6b2500c","user":{"login":"rcbops","id":1153548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1153548?v=4","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":134390796,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzOTA3OTY=","name":"rpc_component","full_name":"rcbops/rpc_component","owner":{"login":"rcbops","id":1153548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1153548?v=4","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc_component","description":null,"fork":false,"url":"https://api.github.com/repos/rcbops/rpc_component","forks_url":"https://api.github.com/repos/rcbops/rpc_component/forks","keys_url":"https://api.github.com/repos/rcbops/rpc_component/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc_component/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc_component/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc_component/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc_component/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc_component/events","assignees_url":"https://api.github.com/repos/rcbops/rpc_component/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc_component/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc_component/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc_component/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc_component/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc_component/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc_component/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc_component/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc_component/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc_component/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc_component/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc_component/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc_component/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc_component/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc_component/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc_component/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc_component/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc_component/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc_component/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc_component/merges","archive_url":"https://api.github.com/repos/rcbops/rpc_component/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc_component/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc_component/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc_component/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc_component/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc_component/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc_component/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc_component/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc_component/deployments","created_at":"2018-05-22T09:19:18Z","updated_at":"2018-07-31T08:35:47Z","pushed_at":"2018-08-02T12:07:17Z","git_url":"git://github.com/rcbops/rpc_component.git","ssh_url":"git@github.com:rcbops/rpc_component.git","clone_url":"https://github.com/rcbops/rpc_component.git","svn_url":"https://github.com/rcbops/rpc_component","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc_component/pulls/6"},"html":{"href":"https://github.com/rcbops/rpc_component/pull/6"},"issue":{"href":"https://api.github.com/repos/rcbops/rpc_component/issues/6"},"comments":{"href":"https://api.github.com/repos/rcbops/rpc_component/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/rpc_component/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/rpc_component/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/rpc_component/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/rpc_component/statuses/faed3ff57d767b58734638071b2f068c469577cd"}},"author_association":"NONE"}}
{"actor":{"display_login":"odyssey4me"}}