{"action":"created","issue":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/125","repository_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits","labels_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/125/comments","events_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/125/events","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/pull/125","id":251865459,"number":125,"title":"set FitsFactory.useHierarch to true","user":{"login":"olebole","id":397223,"avatar_url":"https://avatars0.githubusercontent.com/u/397223?v=4","gravatar_id":"","url":"https://api.github.com/users/olebole","html_url":"https://github.com/olebole","followers_url":"https://api.github.com/users/olebole/followers","following_url":"https://api.github.com/users/olebole/following{/other_user}","gists_url":"https://api.github.com/users/olebole/gists{/gist_id}","starred_url":"https://api.github.com/users/olebole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olebole/subscriptions","organizations_url":"https://api.github.com/users/olebole/orgs","repos_url":"https://api.github.com/users/olebole/repos","events_url":"https://api.github.com/users/olebole/events{/privacy}","received_events_url":"https://api.github.com/users/olebole/received_events","type":"User","site_admin":false},"labels":[{"id":171513569,"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"ritchieGitHub","id":9456779,"avatar_url":"https://avatars3.githubusercontent.com/u/9456779?v=4","gravatar_id":"","url":"https://api.github.com/users/ritchieGitHub","html_url":"https://github.com/ritchieGitHub","followers_url":"https://api.github.com/users/ritchieGitHub/followers","following_url":"https://api.github.com/users/ritchieGitHub/following{/other_user}","gists_url":"https://api.github.com/users/ritchieGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchieGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchieGitHub/subscriptions","organizations_url":"https://api.github.com/users/ritchieGitHub/orgs","repos_url":"https://api.github.com/users/ritchieGitHub/repos","events_url":"https://api.github.com/users/ritchieGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/ritchieGitHub/received_events","type":"User","site_admin":false},"assignees":[{"login":"ritchieGitHub","id":9456779,"avatar_url":"https://avatars3.githubusercontent.com/u/9456779?v=4","gravatar_id":"","url":"https://api.github.com/users/ritchieGitHub","html_url":"https://github.com/ritchieGitHub","followers_url":"https://api.github.com/users/ritchieGitHub/followers","following_url":"https://api.github.com/users/ritchieGitHub/following{/other_user}","gists_url":"https://api.github.com/users/ritchieGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchieGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchieGitHub/subscriptions","organizations_url":"https://api.github.com/users/ritchieGitHub/orgs","repos_url":"https://api.github.com/users/ritchieGitHub/repos","events_url":"https://api.github.com/users/ritchieGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/ritchieGitHub/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/milestones/13","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/milestone/13","labels_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/milestones/13/labels","id":2488159,"number":13,"title":"1.15.3","description":"Maintenance release ","creator":{"login":"ritchieGitHub","id":9456779,"avatar_url":"https://avatars3.githubusercontent.com/u/9456779?v=4","gravatar_id":"","url":"https://api.github.com/users/ritchieGitHub","html_url":"https://github.com/ritchieGitHub","followers_url":"https://api.github.com/users/ritchieGitHub/followers","following_url":"https://api.github.com/users/ritchieGitHub/following{/other_user}","gists_url":"https://api.github.com/users/ritchieGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchieGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchieGitHub/subscriptions","organizations_url":"https://api.github.com/users/ritchieGitHub/orgs","repos_url":"https://api.github.com/users/ritchieGitHub/repos","events_url":"https://api.github.com/users/ritchieGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/ritchieGitHub/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":3,"state":"open","created_at":"2017-04-28T12:46:47Z","updated_at":"2017-10-08T06:00:29Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2017-08-22T07:41:31Z","updated_at":"2018-03-05T06:03:25Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/pulls/125","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/pull/125","diff_url":"https://github.com/nom-tam-fits/nom-tam-fits/pull/125.diff","patch_url":"https://github.com/nom-tam-fits/nom-tam-fits/pull/125.patch"},"body":"This is a forwarding followup of the short discussion in commit [fd527d6](https://github.com/Starlink/starjava/commit/fd527d661efe04b05b368051df2bf6a6aa7329c3#commitcomment-23745202) from @mbtaylor:\r\n\r\n> Change the static setting that determines whether the `nom.tam.fits` libraries recognise the [ESO HIERARCH convention for hierarchical FITS keywords](https://fits.gsfc.nasa.gov/registry/hierarch_keyword.html) from false (which is how it is configured by default) to true.\r\n> \r\n> This setting is required to make the hierarchical variant of the WideFits convention work (see [`uk.ac.starlink.fits.WideFits`](https://github.com/Starlink/starjava/blob/master/fits/src/main/uk/ac/starlink/fits/WideFits.java)). There's no way in the nom.tam.fits API to configure HIERARCH-use on a per-call basis, so we have to modify the static setting.\r\n> \r\n> This will affect other `nom.tam.fits`-dependent code using this library. An alternative would be to set this only when the hierarch convention is potentially or actually in use, but that gets messier,\r\n> since it would still affect other code running in the same JVM, but in less predictable ways.\r\n> \r\n> So following this change, STIL FITS handling will pick up `HIERARCH` per-table headers which it previously ignored.\r\n\r\nI looks that there is no real drawback when enabling this."},"comment":{"url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/comments/370318628","html_url":"https://github.com/nom-tam-fits/nom-tam-fits/pull/125#issuecomment-370318628","issue_url":"https://api.github.com/repos/nom-tam-fits/nom-tam-fits/issues/125","id":370318628,"user":{"login":"ritchieGitHub","id":9456779,"avatar_url":"https://avatars3.githubusercontent.com/u/9456779?v=4","gravatar_id":"","url":"https://api.github.com/users/ritchieGitHub","html_url":"https://github.com/ritchieGitHub","followers_url":"https://api.github.com/users/ritchieGitHub/followers","following_url":"https://api.github.com/users/ritchieGitHub/following{/other_user}","gists_url":"https://api.github.com/users/ritchieGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchieGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchieGitHub/subscriptions","organizations_url":"https://api.github.com/users/ritchieGitHub/orgs","repos_url":"https://api.github.com/users/ritchieGitHub/repos","events_url":"https://api.github.com/users/ritchieGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/ritchieGitHub/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T06:03:25Z","updated_at":"2018-03-05T06:03:25Z","author_association":"OWNER","body":"Sorry for the delay ... I was on a very long trip -> offline for a few Months ;-)\r\nI will try to restart the comming weekend"}}
{"actor":{"display_login":"ritchieGitHub"}}