{"action":"created","comment":{"url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/comments/176224235","pull_request_review_id":105890757,"id":176224235,"diff_hunk":"@@ -1,11 +1,38 @@\n-\\subsection{Development Model}\n+\\subsection{Development Model}\\label{sec:development}\n \n-Lots of small repositories.\n+To enable concurrent development across all six LSST sites, the LSST development team uses a decentralized development model based on the Git version control system\\footnote{\\url{https://git-scm.com/}}.\n+[TODO: describe in terms of Agile values?]\n \n-Feature branches associated with Jira tickets.\n+\\subsubsection{Version Control}\\label{sec:git}\\label{sec:subversion}\n \n-Branch protection.\n+[TODO: why did LSST switch from Subversion to Git?]\n \n-Rebase before merging.\n+\\subsubsection{Code Organization}\\label{sec:git_repositories}\n+\n+The data management system is divided into several hundred individual Git repositories, hosted on GitHub\\footnote{\\url{http://github.com/}}.\n+Each repository corresponds to one code package, and\n+all but a handful of repositories usually have at most one developer working on them at a time.\n+Isolating code in small repositories minimizes the need for developers to frequently download code updates, something the Git framework requires whenever developers make concurrent changes to the \\texttt{master} branch of the same repository.\n+Representing each package by an independent repository also makes it easy to formalize and track inter-package dependencies using tools like EUPS (\\autoref{sec:eups}).\n+\n+\\subsubsection{The LSST Workflow}\\label{sec:dev_workflow}\n+\n+LSST software development is based on the shared repository model:\n+work is done on branches of a single repository rather than on user forks.\n+Development work is associated with a Jira ticket (\\autoref{sec:jira_ticket}), and\n+keeping all work in a shared repository makes it easier to link code changes to their corresponding Jira tickets.\n+[TODO: why is that important? I assume it has something to do with earned value tracking]\n+\n+All work associated with a specific Jira ticket is done on a feature branch named after that ticket.\n+Developers must test their branch as part of the full data management system (\\autoref{sec:jenkins}) before the code is considered ready to review or merge.\n+GitHub pull requests from the ticket branch to \\texttt{master} are used for code review, but not to merge the code.","path":"git.tex","position":33,"original_position":33,"commit_id":"5ac840b61d449e77bb7f44ff64347a3c69347d27","original_commit_id":"5ac840b61d449e77bb7f44ff64347a3c69347d27","user":{"login":"timj","id":60622,"avatar_url":"https://avatars1.githubusercontent.com/u/60622?v=4","gravatar_id":"","url":"https://api.github.com/users/timj","html_url":"https://github.com/timj","followers_url":"https://api.github.com/users/timj/followers","following_url":"https://api.github.com/users/timj/following{/other_user}","gists_url":"https://api.github.com/users/timj/gists{/gist_id}","starred_url":"https://api.github.com/users/timj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timj/subscriptions","organizations_url":"https://api.github.com/users/timj/orgs","repos_url":"https://api.github.com/users/timj/repos","events_url":"https://api.github.com/users/timj/events{/privacy}","received_events_url":"https://api.github.com/users/timj/received_events","type":"User","site_admin":false},"body":"Yes. Need to fix. Branch protections let us do that without breaking policy. I thought I had made that change when I updated the branch protection docs in developer guide (and I demonstrated to @ktlim that it worked) but I obviously need to edit the dev guide.","created_at":"2018-03-21T20:18:18Z","updated_at":"2018-03-21T20:18:18Z","html_url":"https://github.com/lsst-dm/spie-2018-dm-practices/pull/5#discussion_r176224235","pull_request_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/comments/176224235"},"html":{"href":"https://github.com/lsst-dm/spie-2018-dm-practices/pull/5#discussion_r176224235"},"pull_request":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5"}},"in_reply_to_id":176211153},"pull_request":{"url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5","id":176582201,"html_url":"https://github.com/lsst-dm/spie-2018-dm-practices/pull/5","diff_url":"https://github.com/lsst-dm/spie-2018-dm-practices/pull/5.diff","patch_url":"https://github.com/lsst-dm/spie-2018-dm-practices/pull/5.patch","issue_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/5","number":5,"state":"open","locked":false,"title":"DM-13843","user":{"login":"kfindeisen","id":8508260,"avatar_url":"https://avatars3.githubusercontent.com/u/8508260?v=4","gravatar_id":"","url":"https://api.github.com/users/kfindeisen","html_url":"https://github.com/kfindeisen","followers_url":"https://api.github.com/users/kfindeisen/followers","following_url":"https://api.github.com/users/kfindeisen/following{/other_user}","gists_url":"https://api.github.com/users/kfindeisen/gists{/gist_id}","starred_url":"https://api.github.com/users/kfindeisen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfindeisen/subscriptions","organizations_url":"https://api.github.com/users/kfindeisen/orgs","repos_url":"https://api.github.com/users/kfindeisen/repos","events_url":"https://api.github.com/users/kfindeisen/events{/privacy}","received_events_url":"https://api.github.com/users/kfindeisen/received_events","type":"User","site_admin":false},"body":"Here's a first draft of the Development Model section of the paper. Unfortunately, while I can describe what we do, I had to guess at which advantages/disadvantages actually motivated our workflow (the only sources I could find were the Developer Guide and RFC-21). So the text will probably require a fair bit of editing by somebody with a more manager-y perspective.","created_at":"2018-03-21T19:13:36Z","updated_at":"2018-03-21T20:18:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7259833df17351b6dde83cc054bd9a36facd51cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5/commits","review_comments_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5/comments","review_comment_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/5/comments","statuses_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/statuses/5ac840b61d449e77bb7f44ff64347a3c69347d27","head":{"label":"lsst-dm:tickets/DM-13843","ref":"tickets/DM-13843","sha":"5ac840b61d449e77bb7f44ff64347a3c69347d27","user":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"repo":{"id":124927041,"name":"spie-2018-dm-practices","full_name":"lsst-dm/spie-2018-dm-practices","owner":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-dm/spie-2018-dm-practices","description":"SPIE 2018 Paper: LSST data management software development practices and tools","fork":false,"url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices","forks_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/forks","keys_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/teams","hooks_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/hooks","issue_events_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/events","assignees_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/tags","blobs_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/languages","stargazers_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/stargazers","contributors_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/contributors","subscribers_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/subscribers","subscription_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/subscription","commits_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/merges","archive_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/downloads","issues_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/labels{/name}","releases_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/deployments","created_at":"2018-03-12T17:36:37Z","updated_at":"2018-03-19T23:23:17Z","pushed_at":"2018-03-21T19:13:36Z","git_url":"git://github.com/lsst-dm/spie-2018-dm-practices.git","ssh_url":"git@github.com:lsst-dm/spie-2018-dm-practices.git","clone_url":"https://github.com/lsst-dm/spie-2018-dm-practices.git","svn_url":"https://github.com/lsst-dm/spie-2018-dm-practices","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst-dm:master","ref":"master","sha":"d1045add387025e3a430d657bf5df7fe8ccfe666","user":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"repo":{"id":124927041,"name":"spie-2018-dm-practices","full_name":"lsst-dm/spie-2018-dm-practices","owner":{"login":"lsst-dm","id":10968870,"avatar_url":"https://avatars1.githubusercontent.com/u/10968870?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst-dm","html_url":"https://github.com/lsst-dm","followers_url":"https://api.github.com/users/lsst-dm/followers","following_url":"https://api.github.com/users/lsst-dm/following{/other_user}","gists_url":"https://api.github.com/users/lsst-dm/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst-dm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst-dm/subscriptions","organizations_url":"https://api.github.com/users/lsst-dm/orgs","repos_url":"https://api.github.com/users/lsst-dm/repos","events_url":"https://api.github.com/users/lsst-dm/events{/privacy}","received_events_url":"https://api.github.com/users/lsst-dm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst-dm/spie-2018-dm-practices","description":"SPIE 2018 Paper: LSST data management software development practices and tools","fork":false,"url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices","forks_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/forks","keys_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/teams","hooks_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/hooks","issue_events_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/events{/number}","events_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/events","assignees_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/assignees{/user}","branches_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/branches{/branch}","tags_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/tags","blobs_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/languages","stargazers_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/stargazers","contributors_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/contributors","subscribers_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/subscribers","subscription_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/subscription","commits_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/contents/{+path}","compare_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/merges","archive_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/downloads","issues_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues{/number}","pulls_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/labels{/name}","releases_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/releases{/id}","deployments_url":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/deployments","created_at":"2018-03-12T17:36:37Z","updated_at":"2018-03-19T23:23:17Z","pushed_at":"2018-03-21T19:13:36Z","git_url":"git://github.com/lsst-dm/spie-2018-dm-practices.git","ssh_url":"git@github.com:lsst-dm/spie-2018-dm-practices.git","clone_url":"https://github.com/lsst-dm/spie-2018-dm-practices.git","svn_url":"https://github.com/lsst-dm/spie-2018-dm-practices","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5"},"html":{"href":"https://github.com/lsst-dm/spie-2018-dm-practices/pull/5"},"issue":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/5"},"comments":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/lsst-dm/spie-2018-dm-practices/statuses/5ac840b61d449e77bb7f44ff64347a3c69347d27"}},"author_association":"NONE"}}
{"actor":{"display_login":"timj"}}