{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/nodejs-firestore/issues/294","repository_url":"https://api.github.com/repos/googleapis/nodejs-firestore","labels_url":"https://api.github.com/repos/googleapis/nodejs-firestore/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/nodejs-firestore/issues/294/comments","events_url":"https://api.github.com/repos/googleapis/nodejs-firestore/issues/294/events","html_url":"https://github.com/googleapis/nodejs-firestore/pull/294","id":345323300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTA2NDc3","number":294,"title":"Manually editing .d.ts files to use 'string' for large numbers","user":{"login":"schmidt-sebastian","id":19397744,"node_id":"MDQ6VXNlcjE5Mzk3NzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/19397744?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidt-sebastian","html_url":"https://github.com/schmidt-sebastian","followers_url":"https://api.github.com/users/schmidt-sebastian/followers","following_url":"https://api.github.com/users/schmidt-sebastian/following{/other_user}","gists_url":"https://api.github.com/users/schmidt-sebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidt-sebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidt-sebastian/subscriptions","organizations_url":"https://api.github.com/users/schmidt-sebastian/orgs","repos_url":"https://api.github.com/users/schmidt-sebastian/repos","events_url":"https://api.github.com/users/schmidt-sebastian/events{/privacy}","received_events_url":"https://api.github.com/users/schmidt-sebastian/received_events","type":"User","site_admin":false},"labels":[{"id":706673830,"node_id":"MDU6TGFiZWw3MDY2NzM4MzA=","url":"https://api.github.com/repos/googleapis/nodejs-firestore/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"assignees":[{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-27T18:27:02Z","updated_at":"2018-08-02T16:46:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-firestore/pulls/294","html_url":"https://github.com/googleapis/nodejs-firestore/pull/294","diff_url":"https://github.com/googleapis/nodejs-firestore/pull/294.diff","patch_url":"https://github.com/googleapis/nodejs-firestore/pull/294.patch"},"body":"This changes the Proto type for large numbers to the type we use in code. `pbjs` uses `number|Long`, but we use `number|string`.\r\n\r\nI wasn't able to find the right setting in `pbjs` to make it generate the right settings. There is `--force-long ` but no `--force-string`, and I much rather deal with strings in the API than with the Long type (we also use strings in the Web Firestore SDK)"},"comment":{"url":"https://api.github.com/repos/googleapis/nodejs-firestore/issues/comments/409993002","html_url":"https://github.com/googleapis/nodejs-firestore/pull/294#issuecomment-409993002","issue_url":"https://api.github.com/repos/googleapis/nodejs-firestore/issues/294","id":409993002,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTk5MzAwMg==","user":{"login":"schmidt-sebastian","id":19397744,"node_id":"MDQ6VXNlcjE5Mzk3NzQ0","avatar_url":"https://avatars3.githubusercontent.com/u/19397744?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidt-sebastian","html_url":"https://github.com/schmidt-sebastian","followers_url":"https://api.github.com/users/schmidt-sebastian/followers","following_url":"https://api.github.com/users/schmidt-sebastian/following{/other_user}","gists_url":"https://api.github.com/users/schmidt-sebastian/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidt-sebastian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidt-sebastian/subscriptions","organizations_url":"https://api.github.com/users/schmidt-sebastian/orgs","repos_url":"https://api.github.com/users/schmidt-sebastian/repos","events_url":"https://api.github.com/users/schmidt-sebastian/events{/privacy}","received_events_url":"https://api.github.com/users/schmidt-sebastian/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T16:46:57Z","updated_at":"2018-08-02T16:46:57Z","author_association":"CONTRIBUTOR","body":"PTAL @JustinBeckwith  Thanks :)"}}
{"actor":{"display_login":"schmidt-sebastian"}}