{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/188231117","pull_request_review_id":120163656,"id":188231117,"diff_hunk":"@@ -2674,17 +2674,7 @@ on_name_appeared (GDBusConnection *connection,\n {\n   CockpitDBusJson *self = COCKPIT_DBUS_JSON (user_data);\n \n-  g_object_ref (self);\n-\n-  if (!self->default_appeared)","path":"src/bridge/cockpitdbusjson.c","position":6,"original_position":6,"commit_id":"a6f75209cdcd35522fe0608dbd2615acf4a32f98","original_commit_id":"a6f75209cdcd35522fe0608dbd2615acf4a32f98","user":{"login":"allisonkarlitskaya","id":36541154,"avatar_url":"https://avatars2.githubusercontent.com/u/36541154?v=4","gravatar_id":"","url":"https://api.github.com/users/allisonkarlitskaya","html_url":"https://github.com/allisonkarlitskaya","followers_url":"https://api.github.com/users/allisonkarlitskaya/followers","following_url":"https://api.github.com/users/allisonkarlitskaya/following{/other_user}","gists_url":"https://api.github.com/users/allisonkarlitskaya/gists{/gist_id}","starred_url":"https://api.github.com/users/allisonkarlitskaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allisonkarlitskaya/subscriptions","organizations_url":"https://api.github.com/users/allisonkarlitskaya/orgs","repos_url":"https://api.github.com/users/allisonkarlitskaya/repos","events_url":"https://api.github.com/users/allisonkarlitskaya/events{/privacy}","received_events_url":"https://api.github.com/users/allisonkarlitskaya/received_events","type":"User","site_admin":false},"body":"Please also remove the variable from the struct, since it is now unused.","created_at":"2018-05-15T09:59:56Z","updated_at":"2018-05-15T09:59:56Z","html_url":"https://github.com/cockpit-project/cockpit/pull/9125#discussion_r188231117","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/188231117"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/9125#discussion_r188231117"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125","id":186359958,"html_url":"https://github.com/cockpit-project/cockpit/pull/9125","diff_url":"https://github.com/cockpit-project/cockpit/pull/9125.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/9125.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9125","number":9125,"state":"open","locked":false,"title":"bridge: Don't close dbus channels for unknown names","user":{"login":"larskarlitski","id":1221707,"avatar_url":"https://avatars0.githubusercontent.com/u/1221707?v=4","gravatar_id":"","url":"https://api.github.com/users/larskarlitski","html_url":"https://github.com/larskarlitski","followers_url":"https://api.github.com/users/larskarlitski/followers","following_url":"https://api.github.com/users/larskarlitski/following{/other_user}","gists_url":"https://api.github.com/users/larskarlitski/gists{/gist_id}","starred_url":"https://api.github.com/users/larskarlitski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskarlitski/subscriptions","organizations_url":"https://api.github.com/users/larskarlitski/orgs","repos_url":"https://api.github.com/users/larskarlitski/repos","events_url":"https://api.github.com/users/larskarlitski/events{/privacy}","received_events_url":"https://api.github.com/users/larskarlitski/received_events","type":"User","site_admin":false},"body":"Creating a dbus-json3 channel with a name that is not on the bus results\r\nin the channel being closed immediately with a \"not-found\" error. That's\r\ninconsistent behavior, because one can create such a client when the\r\nname is available and the client continues to work when it disappears\r\nand comes back.\r\n\r\nRemove that restriction by not closing the channel on unknown names.\r\nThis is also how the similar function g_bus_watch_name() (which is used\r\nin the bridge) works.","created_at":"2018-05-07T13:59:19Z","updated_at":"2018-05-15T09:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a069e7d5f0c5217b80b6851e6e0745cb239dc98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":88467047,"url":"https://api.github.com/repos/cockpit-project/cockpit/labels/needswork","name":"needswork","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9125/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/a6f75209cdcd35522fe0608dbd2615acf4a32f98","head":{"label":"larskarlitski:dbus-no-name","ref":"dbus-no-name","sha":"a6f75209cdcd35522fe0608dbd2615acf4a32f98","user":{"login":"larskarlitski","id":1221707,"avatar_url":"https://avatars0.githubusercontent.com/u/1221707?v=4","gravatar_id":"","url":"https://api.github.com/users/larskarlitski","html_url":"https://github.com/larskarlitski","followers_url":"https://api.github.com/users/larskarlitski/followers","following_url":"https://api.github.com/users/larskarlitski/following{/other_user}","gists_url":"https://api.github.com/users/larskarlitski/gists{/gist_id}","starred_url":"https://api.github.com/users/larskarlitski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskarlitski/subscriptions","organizations_url":"https://api.github.com/users/larskarlitski/orgs","repos_url":"https://api.github.com/users/larskarlitski/repos","events_url":"https://api.github.com/users/larskarlitski/events{/privacy}","received_events_url":"https://api.github.com/users/larskarlitski/received_events","type":"User","site_admin":false},"repo":{"id":52787188,"name":"cockpit","full_name":"larskarlitski/cockpit","owner":{"login":"larskarlitski","id":1221707,"avatar_url":"https://avatars0.githubusercontent.com/u/1221707?v=4","gravatar_id":"","url":"https://api.github.com/users/larskarlitski","html_url":"https://github.com/larskarlitski","followers_url":"https://api.github.com/users/larskarlitski/followers","following_url":"https://api.github.com/users/larskarlitski/following{/other_user}","gists_url":"https://api.github.com/users/larskarlitski/gists{/gist_id}","starred_url":"https://api.github.com/users/larskarlitski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larskarlitski/subscriptions","organizations_url":"https://api.github.com/users/larskarlitski/orgs","repos_url":"https://api.github.com/users/larskarlitski/repos","events_url":"https://api.github.com/users/larskarlitski/events{/privacy}","received_events_url":"https://api.github.com/users/larskarlitski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/larskarlitski/cockpit","description":"Cockpit, a user interface for Linux servers","fork":true,"url":"https://api.github.com/repos/larskarlitski/cockpit","forks_url":"https://api.github.com/repos/larskarlitski/cockpit/forks","keys_url":"https://api.github.com/repos/larskarlitski/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larskarlitski/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larskarlitski/cockpit/teams","hooks_url":"https://api.github.com/repos/larskarlitski/cockpit/hooks","issue_events_url":"https://api.github.com/repos/larskarlitski/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/larskarlitski/cockpit/events","assignees_url":"https://api.github.com/repos/larskarlitski/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/larskarlitski/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/larskarlitski/cockpit/tags","blobs_url":"https://api.github.com/repos/larskarlitski/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larskarlitski/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larskarlitski/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/larskarlitski/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larskarlitski/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/larskarlitski/cockpit/languages","stargazers_url":"https://api.github.com/repos/larskarlitski/cockpit/stargazers","contributors_url":"https://api.github.com/repos/larskarlitski/cockpit/contributors","subscribers_url":"https://api.github.com/repos/larskarlitski/cockpit/subscribers","subscription_url":"https://api.github.com/repos/larskarlitski/cockpit/subscription","commits_url":"https://api.github.com/repos/larskarlitski/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/larskarlitski/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/larskarlitski/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/larskarlitski/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/larskarlitski/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/larskarlitski/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larskarlitski/cockpit/merges","archive_url":"https://api.github.com/repos/larskarlitski/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larskarlitski/cockpit/downloads","issues_url":"https://api.github.com/repos/larskarlitski/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/larskarlitski/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/larskarlitski/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/larskarlitski/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larskarlitski/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/larskarlitski/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/larskarlitski/cockpit/deployments","created_at":"2016-02-29T11:47:08Z","updated_at":"2016-06-29T08:10:52Z","pushed_at":"2018-05-09T17:03:10Z","git_url":"git://github.com/larskarlitski/cockpit.git","ssh_url":"git@github.com:larskarlitski/cockpit.git","clone_url":"https://github.com/larskarlitski/cockpit.git","svn_url":"https://github.com/larskarlitski/cockpit","homepage":"http://www.cockpit-project.org/","size":47156,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"c7d2f361394254afde2741ffeb23748d1da9f7b3","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2018-05-15T08:03:38Z","pushed_at":"2018-05-15T09:44:22Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":47920,"stargazers_count":3213,"watchers_count":3213,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"archived":false,"open_issues_count":582,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":403,"open_issues":582,"watchers":3213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/9125"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/9125"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/9125/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9125/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/a6f75209cdcd35522fe0608dbd2615acf4a32f98"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"allisonkarlitskaya"}}