{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/240596254","pull_request_review_id":183658395,"id":240596254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU5NjI1NA==","diff_hunk":"@@ -951,6 +974,11 @@ void ESP8266::_oob_busy()\n         MBED_ERROR(MBED_MAKE_ERROR(MBED_MODULE_DRIVER, MBED_ERROR_CODE_ENOMSG), \\\n                    \"ESP8266::_oob_busy() AT timeout\\n\");\n     }\n+    if (!_busy)","path":"components/wifi/esp8266-driver/ESP8266/ESP8266.cpp","position":56,"original_position":56,"commit_id":"efb7ebefa8755aec42f84d9e1afdc8c05328f073","original_commit_id":"efb7ebefa8755aec42f84d9e1afdc8c05328f073","user":{"login":"michalpasztamobica","id":42799877,"node_id":"MDQ6VXNlcjQyNzk5ODc3","avatar_url":"https://avatars0.githubusercontent.com/u/42799877?v=4","gravatar_id":"","url":"https://api.github.com/users/michalpasztamobica","html_url":"https://github.com/michalpasztamobica","followers_url":"https://api.github.com/users/michalpasztamobica/followers","following_url":"https://api.github.com/users/michalpasztamobica/following{/other_user}","gists_url":"https://api.github.com/users/michalpasztamobica/gists{/gist_id}","starred_url":"https://api.github.com/users/michalpasztamobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalpasztamobica/subscriptions","organizations_url":"https://api.github.com/users/michalpasztamobica/orgs","repos_url":"https://api.github.com/users/michalpasztamobica/repos","events_url":"https://api.github.com/users/michalpasztamobica/events{/privacy}","received_events_url":"https://api.github.com/users/michalpasztamobica/received_events","type":"User","site_admin":false},"body":"If we abort here then do we need to set the 1/10s timeout?","created_at":"2018-12-11T12:49:50Z","updated_at":"2018-12-11T12:49:50Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/9051#discussion_r240596254","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/240596254"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/9051#discussion_r240596254"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051"}},"in_reply_to_id":240592537},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051","id":237659158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjU5MTU4","html_url":"https://github.com/ARMmbed/mbed-os/pull/9051","diff_url":"https://github.com/ARMmbed/mbed-os/pull/9051.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/9051.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9051","number":9051,"state":"open","locked":false,"title":"ESP8266 send returns WOULD_BLOCK error when busy","user":{"login":"michalpasztamobica","id":42799877,"node_id":"MDQ6VXNlcjQyNzk5ODc3","avatar_url":"https://avatars0.githubusercontent.com/u/42799877?v=4","gravatar_id":"","url":"https://api.github.com/users/michalpasztamobica","html_url":"https://github.com/michalpasztamobica","followers_url":"https://api.github.com/users/michalpasztamobica/followers","following_url":"https://api.github.com/users/michalpasztamobica/following{/other_user}","gists_url":"https://api.github.com/users/michalpasztamobica/gists{/gist_id}","starred_url":"https://api.github.com/users/michalpasztamobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalpasztamobica/subscriptions","organizations_url":"https://api.github.com/users/michalpasztamobica/orgs","repos_url":"https://api.github.com/users/michalpasztamobica/repos","events_url":"https://api.github.com/users/michalpasztamobica/events{/privacy}","received_events_url":"https://api.github.com/users/michalpasztamobica/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nIn case ESP8266 reports \"busy\" status we need to return WOULD_BLOCK error from the send function.\r\n\r\n### Pull request type\r\n\r\n    [x] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-12-11T12:21:56Z","updated_at":"2018-12-11T12:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab960f0cd2cd86ee53d7b881bb9890ab42bd200","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SeppoTakalo","id":3104794,"node_id":"MDQ6VXNlcjMxMDQ3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3104794?v=4","gravatar_id":"","url":"https://api.github.com/users/SeppoTakalo","html_url":"https://github.com/SeppoTakalo","followers_url":"https://api.github.com/users/SeppoTakalo/followers","following_url":"https://api.github.com/users/SeppoTakalo/following{/other_user}","gists_url":"https://api.github.com/users/SeppoTakalo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeppoTakalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeppoTakalo/subscriptions","organizations_url":"https://api.github.com/users/SeppoTakalo/orgs","repos_url":"https://api.github.com/users/SeppoTakalo/repos","events_url":"https://api.github.com/users/SeppoTakalo/events{/privacy}","received_events_url":"https://api.github.com/users/SeppoTakalo/received_events","type":"User","site_admin":false},{"login":"VeijoPesonen","id":33285290,"node_id":"MDQ6VXNlcjMzMjg1Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/33285290?v=4","gravatar_id":"","url":"https://api.github.com/users/VeijoPesonen","html_url":"https://github.com/VeijoPesonen","followers_url":"https://api.github.com/users/VeijoPesonen/followers","following_url":"https://api.github.com/users/VeijoPesonen/following{/other_user}","gists_url":"https://api.github.com/users/VeijoPesonen/gists{/gist_id}","starred_url":"https://api.github.com/users/VeijoPesonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeijoPesonen/subscriptions","organizations_url":"https://api.github.com/users/VeijoPesonen/orgs","repos_url":"https://api.github.com/users/VeijoPesonen/repos","events_url":"https://api.github.com/users/VeijoPesonen/events{/privacy}","received_events_url":"https://api.github.com/users/VeijoPesonen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9051/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/efb7ebefa8755aec42f84d9e1afdc8c05328f073","head":{"label":"michalpasztamobica:esp8266_busy_signal","ref":"esp8266_busy_signal","sha":"efb7ebefa8755aec42f84d9e1afdc8c05328f073","user":{"login":"michalpasztamobica","id":42799877,"node_id":"MDQ6VXNlcjQyNzk5ODc3","avatar_url":"https://avatars0.githubusercontent.com/u/42799877?v=4","gravatar_id":"","url":"https://api.github.com/users/michalpasztamobica","html_url":"https://github.com/michalpasztamobica","followers_url":"https://api.github.com/users/michalpasztamobica/followers","following_url":"https://api.github.com/users/michalpasztamobica/following{/other_user}","gists_url":"https://api.github.com/users/michalpasztamobica/gists{/gist_id}","starred_url":"https://api.github.com/users/michalpasztamobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalpasztamobica/subscriptions","organizations_url":"https://api.github.com/users/michalpasztamobica/orgs","repos_url":"https://api.github.com/users/michalpasztamobica/repos","events_url":"https://api.github.com/users/michalpasztamobica/events{/privacy}","received_events_url":"https://api.github.com/users/michalpasztamobica/received_events","type":"User","site_admin":false},"repo":{"id":148453836,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0NTM4MzY=","name":"mbed-os","full_name":"michalpasztamobica/mbed-os","private":false,"owner":{"login":"michalpasztamobica","id":42799877,"node_id":"MDQ6VXNlcjQyNzk5ODc3","avatar_url":"https://avatars0.githubusercontent.com/u/42799877?v=4","gravatar_id":"","url":"https://api.github.com/users/michalpasztamobica","html_url":"https://github.com/michalpasztamobica","followers_url":"https://api.github.com/users/michalpasztamobica/followers","following_url":"https://api.github.com/users/michalpasztamobica/following{/other_user}","gists_url":"https://api.github.com/users/michalpasztamobica/gists{/gist_id}","starred_url":"https://api.github.com/users/michalpasztamobica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalpasztamobica/subscriptions","organizations_url":"https://api.github.com/users/michalpasztamobica/orgs","repos_url":"https://api.github.com/users/michalpasztamobica/repos","events_url":"https://api.github.com/users/michalpasztamobica/events{/privacy}","received_events_url":"https://api.github.com/users/michalpasztamobica/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michalpasztamobica/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/michalpasztamobica/mbed-os","forks_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/forks","keys_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/teams","hooks_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/events","assignees_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/tags","blobs_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/languages","stargazers_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/subscription","commits_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/merges","archive_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/downloads","issues_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/michalpasztamobica/mbed-os/deployments","created_at":"2018-09-12T09:16:45Z","updated_at":"2018-12-07T08:51:43Z","pushed_at":"2018-12-11T12:06:53Z","git_url":"git://github.com/michalpasztamobica/mbed-os.git","ssh_url":"git@github.com:michalpasztamobica/mbed-os.git","clone_url":"https://github.com/michalpasztamobica/mbed-os.git","svn_url":"https://github.com/michalpasztamobica/mbed-os","homepage":"https://mbed.com","size":249693,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"85a741ec787bea87bb9267b6716ebaaf52cdf264","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-12-11T11:30:56Z","pushed_at":"2018-12-11T12:29:12Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":250955,"stargazers_count":2102,"watchers_count":2102,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1701,"mirror_url":null,"archived":false,"open_issues_count":428,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1701,"open_issues":428,"watchers":2102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/9051"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9051"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9051/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9051/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/efb7ebefa8755aec42f84d9e1afdc8c05328f073"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michalpasztamobica"}}