{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/177188747","pull_request_review_id":107019182,"id":177188747,"diff_hunk":"@@ -0,0 +1,148 @@\n+package org.opentestsystem.rdw.reporting.common.model;\n+\n+import java.util.Set;\n+\n+import static com.google.common.collect.Sets.newHashSet;\n+\n+/**\n+ * This class represents student exam result filters for aggregate reports.\n+ */\n+public class AggregateReportFilters {","path":"common/src/main/java/org/opentestsystem/rdw/reporting/common/model/AggregateReportFilters.java","position":10,"original_position":10,"commit_id":"78ee96d082c66d62307b8678bf335df266f1722c","original_commit_id":"78ee96d082c66d62307b8678bf335df266f1722c","user":{"login":"wtritch","id":617828,"avatar_url":"https://avatars3.githubusercontent.com/u/617828?v=4","gravatar_id":"","url":"https://api.github.com/users/wtritch","html_url":"https://github.com/wtritch","followers_url":"https://api.github.com/users/wtritch/followers","following_url":"https://api.github.com/users/wtritch/following{/other_user}","gists_url":"https://api.github.com/users/wtritch/gists{/gist_id}","starred_url":"https://api.github.com/users/wtritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtritch/subscriptions","organizations_url":"https://api.github.com/users/wtritch/orgs","repos_url":"https://api.github.com/users/wtritch/repos","events_url":"https://api.github.com/users/wtritch/events{/privacy}","received_events_url":"https://api.github.com/users/wtritch/received_events","type":"User","site_admin":false},"body":"As @agorina recommended, I broke filters out of flat properties on a ReportQuery and into a re-usable filter-set class.","created_at":"2018-03-26T18:23:58Z","updated_at":"2018-03-26T18:23:58Z","html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1139#discussion_r177188747","pull_request_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/177188747"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/1139#discussion_r177188747"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139"}}},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139","id":177527973,"html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1139","diff_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1139.diff","patch_url":"https://github.com/SmarterApp/RDW_Reporting/pull/1139.patch","issue_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1139","number":1139,"state":"open","locked":false,"title":"Refactor the ReportQuery object for re-use in both basic and filtered…","user":{"login":"wtritch","id":617828,"avatar_url":"https://avatars3.githubusercontent.com/u/617828?v=4","gravatar_id":"","url":"https://api.github.com/users/wtritch","html_url":"https://github.com/wtritch","followers_url":"https://api.github.com/users/wtritch/followers","following_url":"https://api.github.com/users/wtritch/following{/other_user}","gists_url":"https://api.github.com/users/wtritch/gists{/gist_id}","starred_url":"https://api.github.com/users/wtritch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtritch/subscriptions","organizations_url":"https://api.github.com/users/wtritch/orgs","repos_url":"https://api.github.com/users/wtritch/repos","events_url":"https://api.github.com/users/wtritch/events{/privacy}","received_events_url":"https://api.github.com/users/wtritch/received_events","type":"User","site_admin":false},"body":"… dimension aggregate report requests.\r\n\r\nThis PR lays the groundwork for supporting two Aggregate Report requests:\r\n1. The existing request method with a single set of filters and 1..n Dimension drill-downs defined as DimensionTypes\r\n2. The upcoming request method with 1..n Dimension drill-downs defined as named sets of filters\r\n\r\nPlease check out the new models BasicAggregateReportQuery (1.) and FilteredDimensionReportQuery (2.)\r\n\r\nNotice that I've deprecated and plan to leave the current ReportQuery representation class in the code-base to help with deserializing soon-to-be-legacy AggregateReportRequest#reportQuery instances as NewAggregateReportRequest#query instances.","created_at":"2018-03-26T18:22:20Z","updated_at":"2018-03-26T18:23:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26e7ab020d086c879f5e509feda89b18b1eeae9e","assignee":{"login":"jtreuting","id":341584,"avatar_url":"https://avatars0.githubusercontent.com/u/341584?v=4","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtreuting","id":341584,"avatar_url":"https://avatars0.githubusercontent.com/u/341584?v=4","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},{"login":"malaffoon","id":5097710,"avatar_url":"https://avatars0.githubusercontent.com/u/5097710?v=4","gravatar_id":"","url":"https://api.github.com/users/malaffoon","html_url":"https://github.com/malaffoon","followers_url":"https://api.github.com/users/malaffoon/followers","following_url":"https://api.github.com/users/malaffoon/following{/other_user}","gists_url":"https://api.github.com/users/malaffoon/gists{/gist_id}","starred_url":"https://api.github.com/users/malaffoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malaffoon/subscriptions","organizations_url":"https://api.github.com/users/malaffoon/orgs","repos_url":"https://api.github.com/users/malaffoon/repos","events_url":"https://api.github.com/users/malaffoon/events{/privacy}","received_events_url":"https://api.github.com/users/malaffoon/received_events","type":"User","site_admin":false},{"login":"agorina","id":16457484,"avatar_url":"https://avatars2.githubusercontent.com/u/16457484?v=4","gravatar_id":"","url":"https://api.github.com/users/agorina","html_url":"https://github.com/agorina","followers_url":"https://api.github.com/users/agorina/followers","following_url":"https://api.github.com/users/agorina/following{/other_user}","gists_url":"https://api.github.com/users/agorina/gists{/gist_id}","starred_url":"https://api.github.com/users/agorina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agorina/subscriptions","organizations_url":"https://api.github.com/users/agorina/orgs","repos_url":"https://api.github.com/users/agorina/repos","events_url":"https://api.github.com/users/agorina/events{/privacy}","received_events_url":"https://api.github.com/users/agorina/received_events","type":"User","site_admin":false},{"login":"esotrope","id":23462925,"avatar_url":"https://avatars3.githubusercontent.com/u/23462925?v=4","gravatar_id":"","url":"https://api.github.com/users/esotrope","html_url":"https://github.com/esotrope","followers_url":"https://api.github.com/users/esotrope/followers","following_url":"https://api.github.com/users/esotrope/following{/other_user}","gists_url":"https://api.github.com/users/esotrope/gists{/gist_id}","starred_url":"https://api.github.com/users/esotrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esotrope/subscriptions","organizations_url":"https://api.github.com/users/esotrope/orgs","repos_url":"https://api.github.com/users/esotrope/repos","events_url":"https://api.github.com/users/esotrope/events{/privacy}","received_events_url":"https://api.github.com/users/esotrope/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1139/comments","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/78ee96d082c66d62307b8678bf335df266f1722c","head":{"label":"SmarterApp:feature/refactor-report-query-for-reuse","ref":"feature/refactor-report-query-for-reuse","sha":"78ee96d082c66d62307b8678bf335df266f1722c","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2018-03-23T23:59:17Z","pushed_at":"2018-03-26T18:22:21Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":23584,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"cf9f6e38a780814562ac2badd4173b0cc9cb93a2","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2018-03-23T23:59:17Z","pushed_at":"2018-03-26T18:22:21Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":23584,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/1139"},"issue":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1139"},"comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/78ee96d082c66d62307b8678bf335df266f1722c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wtritch"}}