{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34651","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34651/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34651/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34651/events","html_url":"https://github.com/NixOS/nixpkgs/pull/34651","id":294652704,"number":34651,"title":"R: add libcxx to default LDFLAGS and CPPFLAGS on Darwin","user":{"login":"mnacamura","id":45770,"avatar_url":"https://avatars0.githubusercontent.com/u/45770?v=4","gravatar_id":"","url":"https://api.github.com/users/mnacamura","html_url":"https://github.com/mnacamura","followers_url":"https://api.github.com/users/mnacamura/followers","following_url":"https://api.github.com/users/mnacamura/following{/other_user}","gists_url":"https://api.github.com/users/mnacamura/gists{/gist_id}","starred_url":"https://api.github.com/users/mnacamura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnacamura/subscriptions","organizations_url":"https://api.github.com/users/mnacamura/orgs","repos_url":"https://api.github.com/users/mnacamura/repos","events_url":"https://api.github.com/users/mnacamura/events{/privacy}","received_events_url":"https://api.github.com/users/mnacamura/received_events","type":"User","site_admin":false},"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-06T07:04:26Z","updated_at":"2018-02-06T22:20:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34651","html_url":"https://github.com/NixOS/nixpkgs/pull/34651","diff_url":"https://github.com/NixOS/nixpkgs/pull/34651.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/34651.patch"},"body":"###### Motivation for this change\r\n\r\nI am not sure this is the best solution for #34615 but it is sufficient to change LDFLAGS and CPPFLAGS in `lib/R/etc/Makeconf`:\r\n```diff\r\n@@ -15,7 +15,7 @@\r\n CC = /nix/store/cslvigh4a1656g9z9j1ndvzalx7v2s4k-clang-wrapper-4.0.1/bin/cc\r\n CFLAGS = -g -O2 $(LTO)\r\n CPICFLAGS = -fPIC\r\n-CPPFLAGS = \r\n+CPPFLAGS = -isystem /nix/store/942hw6bhnppjqy7szdyfrr0fiiaj7818-libc++-4.0.1/include/c++/v1\r\n CXX = /nix/store/cslvigh4a1656g9z9j1ndvzalx7v2s4k-clang-wrapper-4.0.1/bin/c++ \r\n CXXCPP = $(CXX) -E\r\n CXXFLAGS = -g -O2 $(LTO)\r\n@@ -78,7 +78,7 @@\r\n ## needed by R CMD config\r\n LIBnn = lib\r\n LIBTOOL = $(SHELL) \"$(R_HOME)/bin/libtool\"\r\n-LDFLAGS = \r\n+LDFLAGS = -L/nix/store/942hw6bhnppjqy7szdyfrr0fiiaj7818-libc++-4.0.1/lib\r\n LTO = \r\n ## needed to build applications linking to static libR\r\n MAIN_LD = $(CC)\r\n```\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/363584746","html_url":"https://github.com/NixOS/nixpkgs/pull/34651#issuecomment-363584746","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34651","id":363584746,"user":{"login":"GrahamcOfBorg","id":25447658,"avatar_url":"https://avatars2.githubusercontent.com/u/25447658?v=4","gravatar_id":"","url":"https://api.github.com/users/GrahamcOfBorg","html_url":"https://github.com/GrahamcOfBorg","followers_url":"https://api.github.com/users/GrahamcOfBorg/followers","following_url":"https://api.github.com/users/GrahamcOfBorg/following{/other_user}","gists_url":"https://api.github.com/users/GrahamcOfBorg/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamcOfBorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamcOfBorg/subscriptions","organizations_url":"https://api.github.com/users/GrahamcOfBorg/orgs","repos_url":"https://api.github.com/users/GrahamcOfBorg/repos","events_url":"https://api.github.com/users/GrahamcOfBorg/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamcOfBorg/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T22:20:44Z","updated_at":"2018-02-06T22:20:44Z","author_association":"NONE","body":"Failure on aarch64-linux [(full log)](https://logs.nix.gsc.io/?key=nixos/nixpkgs.34651&attempt_id=c558591b-477b-488a-a822-cfaa4bdad631)\n\n<details><summary>Partial log (click to expand)</summary><p>\n\n```\nerror: while evaluating the attribute 'buildInputs' of the derivation 'R-3.4.3' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:148:11:\nwhile evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u172b02' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:148:11:\nwhile evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix:148:11:\nNo bootstrap for system\n```\n</p></details>\n\n"}}
{"actor":{"display_login":"GrahamcOfBorg"}}