{"action":"created","comment":{"url":"https://api.github.com/repos/magenta-aps/mora/pulls/comments/212255047","pull_request_review_id":148835839,"id":212255047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjI1NTA0Nw==","diff_hunk":"@@ -118,6 +118,19 @@ def to_lora_time(s):\n         return dt.isoformat()\n \n \n+def adjust_end_date(dt):","path":"mora/util.py","position":4,"original_position":4,"commit_id":"3daf405f2bbc107a538e410f3f1145051da50d9e","original_commit_id":"3daf405f2bbc107a538e410f3f1145051da50d9e","user":{"login":"cmoesgaard","id":1827127,"node_id":"MDQ6VXNlcjE4MjcxMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1827127?v=4","gravatar_id":"","url":"https://api.github.com/users/cmoesgaard","html_url":"https://github.com/cmoesgaard","followers_url":"https://api.github.com/users/cmoesgaard/followers","following_url":"https://api.github.com/users/cmoesgaard/following{/other_user}","gists_url":"https://api.github.com/users/cmoesgaard/gists{/gist_id}","starred_url":"https://api.github.com/users/cmoesgaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmoesgaard/subscriptions","organizations_url":"https://api.github.com/users/cmoesgaard/orgs","repos_url":"https://api.github.com/users/cmoesgaard/repos","events_url":"https://api.github.com/users/cmoesgaard/events{/privacy}","received_events_url":"https://api.github.com/users/cmoesgaard/received_events","type":"User","site_admin":false},"body":"We should also make sure to note that similar related time logic exists in the UI code.","created_at":"2018-08-23T10:13:57Z","updated_at":"2018-08-23T10:17:34Z","html_url":"https://github.com/magenta-aps/mora/pull/137#discussion_r212255047","pull_request_url":"https://api.github.com/repos/magenta-aps/mora/pulls/137","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/magenta-aps/mora/pulls/comments/212255047"},"html":{"href":"https://github.com/magenta-aps/mora/pull/137#discussion_r212255047"},"pull_request":{"href":"https://api.github.com/repos/magenta-aps/mora/pulls/137"}},"in_reply_to_id":212249686},"pull_request":{"url":"https://api.github.com/repos/magenta-aps/mora/pulls/137","id":210367782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzY3Nzgy","html_url":"https://github.com/magenta-aps/mora/pull/137","diff_url":"https://github.com/magenta-aps/mora/pull/137.diff","patch_url":"https://github.com/magenta-aps/mora/pull/137.patch","issue_url":"https://api.github.com/repos/magenta-aps/mora/issues/137","number":137,"state":"open","locked":false,"title":"#23559 end times","user":{"login":"danchr","id":59300,"node_id":"MDQ6VXNlcjU5MzAw","avatar_url":"https://avatars3.githubusercontent.com/u/59300?v=4","gravatar_id":"","url":"https://api.github.com/users/danchr","html_url":"https://github.com/danchr","followers_url":"https://api.github.com/users/danchr/followers","following_url":"https://api.github.com/users/danchr/following{/other_user}","gists_url":"https://api.github.com/users/danchr/gists{/gist_id}","starred_url":"https://api.github.com/users/danchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danchr/subscriptions","organizations_url":"https://api.github.com/users/danchr/orgs","repos_url":"https://api.github.com/users/danchr/repos","events_url":"https://api.github.com/users/danchr/events{/privacy}","received_events_url":"https://api.github.com/users/danchr/received_events","type":"User","site_admin":false},"body":"This adjusts end times so that the frontend renders them properly, i.e. inclusive rather than exclusive.\r\n\r\nThe incorrect behaviour:\r\n![screenshot-adbee5b2-1b32-410b-85fc-f7a67a7be75c](https://user-images.githubusercontent.com/59300/44513784-ab231400-a6be-11e8-98f9-a4382979e51c.png)\r\n","created_at":"2018-08-23T08:24:25Z","updated_at":"2018-08-23T10:17:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magenta-aps/mora/pulls/137/commits","review_comments_url":"https://api.github.com/repos/magenta-aps/mora/pulls/137/comments","review_comment_url":"https://api.github.com/repos/magenta-aps/mora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magenta-aps/mora/issues/137/comments","statuses_url":"https://api.github.com/repos/magenta-aps/mora/statuses/3daf405f2bbc107a538e410f3f1145051da50d9e","head":{"label":"magenta-aps:feature/23559_end_times","ref":"feature/23559_end_times","sha":"3daf405f2bbc107a538e410f3f1145051da50d9e","user":{"login":"magenta-aps","id":996271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjI3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"repo":{"id":90602092,"node_id":"MDEwOlJlcG9zaXRvcnk5MDYwMjA5Mg==","name":"mora","full_name":"magenta-aps/mora","owner":{"login":"magenta-aps","id":996271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjI3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magenta-aps/mora","description":"OS2MO 2.0 — MO + LoRa","fork":false,"url":"https://api.github.com/repos/magenta-aps/mora","forks_url":"https://api.github.com/repos/magenta-aps/mora/forks","keys_url":"https://api.github.com/repos/magenta-aps/mora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magenta-aps/mora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magenta-aps/mora/teams","hooks_url":"https://api.github.com/repos/magenta-aps/mora/hooks","issue_events_url":"https://api.github.com/repos/magenta-aps/mora/issues/events{/number}","events_url":"https://api.github.com/repos/magenta-aps/mora/events","assignees_url":"https://api.github.com/repos/magenta-aps/mora/assignees{/user}","branches_url":"https://api.github.com/repos/magenta-aps/mora/branches{/branch}","tags_url":"https://api.github.com/repos/magenta-aps/mora/tags","blobs_url":"https://api.github.com/repos/magenta-aps/mora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magenta-aps/mora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magenta-aps/mora/git/refs{/sha}","trees_url":"https://api.github.com/repos/magenta-aps/mora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magenta-aps/mora/statuses/{sha}","languages_url":"https://api.github.com/repos/magenta-aps/mora/languages","stargazers_url":"https://api.github.com/repos/magenta-aps/mora/stargazers","contributors_url":"https://api.github.com/repos/magenta-aps/mora/contributors","subscribers_url":"https://api.github.com/repos/magenta-aps/mora/subscribers","subscription_url":"https://api.github.com/repos/magenta-aps/mora/subscription","commits_url":"https://api.github.com/repos/magenta-aps/mora/commits{/sha}","git_commits_url":"https://api.github.com/repos/magenta-aps/mora/git/commits{/sha}","comments_url":"https://api.github.com/repos/magenta-aps/mora/comments{/number}","issue_comment_url":"https://api.github.com/repos/magenta-aps/mora/issues/comments{/number}","contents_url":"https://api.github.com/repos/magenta-aps/mora/contents/{+path}","compare_url":"https://api.github.com/repos/magenta-aps/mora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magenta-aps/mora/merges","archive_url":"https://api.github.com/repos/magenta-aps/mora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magenta-aps/mora/downloads","issues_url":"https://api.github.com/repos/magenta-aps/mora/issues{/number}","pulls_url":"https://api.github.com/repos/magenta-aps/mora/pulls{/number}","milestones_url":"https://api.github.com/repos/magenta-aps/mora/milestones{/number}","notifications_url":"https://api.github.com/repos/magenta-aps/mora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magenta-aps/mora/labels{/name}","releases_url":"https://api.github.com/repos/magenta-aps/mora/releases{/id}","deployments_url":"https://api.github.com/repos/magenta-aps/mora/deployments","created_at":"2017-05-08T08:05:11Z","updated_at":"2018-08-20T13:52:51Z","pushed_at":"2018-08-23T08:24:26Z","git_url":"git://github.com/magenta-aps/mora.git","ssh_url":"git@github.com:magenta-aps/mora.git","clone_url":"https://github.com/magenta-aps/mora.git","svn_url":"https://github.com/magenta-aps/mora","homepage":"https://mora.readthedocs.io","size":9812,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":17,"watchers":1,"default_branch":"development"}},"base":{"label":"magenta-aps:development","ref":"development","sha":"c3b53ad5796993c9493d26b3d6074809d840efdb","user":{"login":"magenta-aps","id":996271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjI3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"repo":{"id":90602092,"node_id":"MDEwOlJlcG9zaXRvcnk5MDYwMjA5Mg==","name":"mora","full_name":"magenta-aps/mora","owner":{"login":"magenta-aps","id":996271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NjI3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/996271?v=4","gravatar_id":"","url":"https://api.github.com/users/magenta-aps","html_url":"https://github.com/magenta-aps","followers_url":"https://api.github.com/users/magenta-aps/followers","following_url":"https://api.github.com/users/magenta-aps/following{/other_user}","gists_url":"https://api.github.com/users/magenta-aps/gists{/gist_id}","starred_url":"https://api.github.com/users/magenta-aps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magenta-aps/subscriptions","organizations_url":"https://api.github.com/users/magenta-aps/orgs","repos_url":"https://api.github.com/users/magenta-aps/repos","events_url":"https://api.github.com/users/magenta-aps/events{/privacy}","received_events_url":"https://api.github.com/users/magenta-aps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magenta-aps/mora","description":"OS2MO 2.0 — MO + LoRa","fork":false,"url":"https://api.github.com/repos/magenta-aps/mora","forks_url":"https://api.github.com/repos/magenta-aps/mora/forks","keys_url":"https://api.github.com/repos/magenta-aps/mora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magenta-aps/mora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magenta-aps/mora/teams","hooks_url":"https://api.github.com/repos/magenta-aps/mora/hooks","issue_events_url":"https://api.github.com/repos/magenta-aps/mora/issues/events{/number}","events_url":"https://api.github.com/repos/magenta-aps/mora/events","assignees_url":"https://api.github.com/repos/magenta-aps/mora/assignees{/user}","branches_url":"https://api.github.com/repos/magenta-aps/mora/branches{/branch}","tags_url":"https://api.github.com/repos/magenta-aps/mora/tags","blobs_url":"https://api.github.com/repos/magenta-aps/mora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magenta-aps/mora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magenta-aps/mora/git/refs{/sha}","trees_url":"https://api.github.com/repos/magenta-aps/mora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magenta-aps/mora/statuses/{sha}","languages_url":"https://api.github.com/repos/magenta-aps/mora/languages","stargazers_url":"https://api.github.com/repos/magenta-aps/mora/stargazers","contributors_url":"https://api.github.com/repos/magenta-aps/mora/contributors","subscribers_url":"https://api.github.com/repos/magenta-aps/mora/subscribers","subscription_url":"https://api.github.com/repos/magenta-aps/mora/subscription","commits_url":"https://api.github.com/repos/magenta-aps/mora/commits{/sha}","git_commits_url":"https://api.github.com/repos/magenta-aps/mora/git/commits{/sha}","comments_url":"https://api.github.com/repos/magenta-aps/mora/comments{/number}","issue_comment_url":"https://api.github.com/repos/magenta-aps/mora/issues/comments{/number}","contents_url":"https://api.github.com/repos/magenta-aps/mora/contents/{+path}","compare_url":"https://api.github.com/repos/magenta-aps/mora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magenta-aps/mora/merges","archive_url":"https://api.github.com/repos/magenta-aps/mora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magenta-aps/mora/downloads","issues_url":"https://api.github.com/repos/magenta-aps/mora/issues{/number}","pulls_url":"https://api.github.com/repos/magenta-aps/mora/pulls{/number}","milestones_url":"https://api.github.com/repos/magenta-aps/mora/milestones{/number}","notifications_url":"https://api.github.com/repos/magenta-aps/mora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magenta-aps/mora/labels{/name}","releases_url":"https://api.github.com/repos/magenta-aps/mora/releases{/id}","deployments_url":"https://api.github.com/repos/magenta-aps/mora/deployments","created_at":"2017-05-08T08:05:11Z","updated_at":"2018-08-20T13:52:51Z","pushed_at":"2018-08-23T08:24:26Z","git_url":"git://github.com/magenta-aps/mora.git","ssh_url":"git@github.com:magenta-aps/mora.git","clone_url":"https://github.com/magenta-aps/mora.git","svn_url":"https://github.com/magenta-aps/mora","homepage":"https://mora.readthedocs.io","size":9812,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":17,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/magenta-aps/mora/pulls/137"},"html":{"href":"https://github.com/magenta-aps/mora/pull/137"},"issue":{"href":"https://api.github.com/repos/magenta-aps/mora/issues/137"},"comments":{"href":"https://api.github.com/repos/magenta-aps/mora/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/magenta-aps/mora/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/magenta-aps/mora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magenta-aps/mora/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/magenta-aps/mora/statuses/3daf405f2bbc107a538e410f3f1145051da50d9e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cmoesgaard"}}