{"action":"created","issue":{"url":"https://api.github.com/repos/poanetwork/blockscout/issues/769","repository_url":"https://api.github.com/repos/poanetwork/blockscout","labels_url":"https://api.github.com/repos/poanetwork/blockscout/issues/769/labels{/name}","comments_url":"https://api.github.com/repos/poanetwork/blockscout/issues/769/comments","events_url":"https://api.github.com/repos/poanetwork/blockscout/issues/769/events","html_url":"https://github.com/poanetwork/blockscout/pull/769","id":362209759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTg5MjA3","number":769,"title":"690 live update scroll","user":{"login":"jimmay5469","id":781752,"node_id":"MDQ6VXNlcjc4MTc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/781752?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmay5469","html_url":"https://github.com/jimmay5469","followers_url":"https://api.github.com/users/jimmay5469/followers","following_url":"https://api.github.com/users/jimmay5469/following{/other_user}","gists_url":"https://api.github.com/users/jimmay5469/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmay5469/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmay5469/subscriptions","organizations_url":"https://api.github.com/users/jimmay5469/orgs","repos_url":"https://api.github.com/users/jimmay5469/repos","events_url":"https://api.github.com/users/jimmay5469/events{/privacy}","received_events_url":"https://api.github.com/users/jimmay5469/received_events","type":"User","site_admin":false},"labels":[{"id":859573185,"node_id":"MDU6TGFiZWw4NTk1NzMxODU=","url":"https://api.github.com/repos/poanetwork/blockscout/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":995399849,"node_id":"MDU6TGFiZWw5OTUzOTk4NDk=","url":"https://api.github.com/repos/poanetwork/blockscout/labels/ready%20for%20review","name":"ready for review","color":"f274f0","default":false}],"state":"open","locked":false,"assignee":{"login":"jimmay5469","id":781752,"node_id":"MDQ6VXNlcjc4MTc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/781752?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmay5469","html_url":"https://github.com/jimmay5469","followers_url":"https://api.github.com/users/jimmay5469/followers","following_url":"https://api.github.com/users/jimmay5469/following{/other_user}","gists_url":"https://api.github.com/users/jimmay5469/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmay5469/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmay5469/subscriptions","organizations_url":"https://api.github.com/users/jimmay5469/orgs","repos_url":"https://api.github.com/users/jimmay5469/repos","events_url":"https://api.github.com/users/jimmay5469/events{/privacy}","received_events_url":"https://api.github.com/users/jimmay5469/received_events","type":"User","site_admin":false},"assignees":[{"login":"jimmay5469","id":781752,"node_id":"MDQ6VXNlcjc4MTc1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/781752?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmay5469","html_url":"https://github.com/jimmay5469","followers_url":"https://api.github.com/users/jimmay5469/followers","following_url":"https://api.github.com/users/jimmay5469/following{/other_user}","gists_url":"https://api.github.com/users/jimmay5469/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmay5469/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmay5469/subscriptions","organizations_url":"https://api.github.com/users/jimmay5469/orgs","repos_url":"https://api.github.com/users/jimmay5469/repos","events_url":"https://api.github.com/users/jimmay5469/events{/privacy}","received_events_url":"https://api.github.com/users/jimmay5469/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-20T14:17:03Z","updated_at":"2018-09-20T15:36:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/poanetwork/blockscout/pulls/769","html_url":"https://github.com/poanetwork/blockscout/pull/769","diff_url":"https://github.com/poanetwork/blockscout/pull/769.diff","patch_url":"https://github.com/poanetwork/blockscout/pull/769.patch"},"body":"Resolves: #690\r\n\r\n## Motivation\r\n\r\nWhen you are scrolled down into a list that live updates, maintain scroll position within the list as items are added above. This way list items will not move out from under your mouse as you try to click them and new items are coming in.\r\n\r\n## Changelog\r\n\r\n### Enhancements\r\n* Add a javascript prepend helper which maintains scroll position within the list."},"comment":{"url":"https://api.github.com/repos/poanetwork/blockscout/issues/comments/423229707","html_url":"https://github.com/poanetwork/blockscout/pull/769#issuecomment-423229707","issue_url":"https://api.github.com/repos/poanetwork/blockscout/issues/769","id":423229707,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzIyOTcwNw==","user":{"login":"acravenho","id":17620007,"node_id":"MDQ6VXNlcjE3NjIwMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/17620007?v=4","gravatar_id":"","url":"https://api.github.com/users/acravenho","html_url":"https://github.com/acravenho","followers_url":"https://api.github.com/users/acravenho/followers","following_url":"https://api.github.com/users/acravenho/following{/other_user}","gists_url":"https://api.github.com/users/acravenho/gists{/gist_id}","starred_url":"https://api.github.com/users/acravenho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acravenho/subscriptions","organizations_url":"https://api.github.com/users/acravenho/orgs","repos_url":"https://api.github.com/users/acravenho/repos","events_url":"https://api.github.com/users/acravenho/events{/privacy}","received_events_url":"https://api.github.com/users/acravenho/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T15:36:04Z","updated_at":"2018-09-20T15:36:04Z","author_association":"MEMBER","body":"@jimmay5469 I received the following error while sitting on the page:\r\n\r\n```\r\n11:33:56.644 application=phoenix [error] an exception was raised:\r\n    ** (FunctionClauseError) no function clause matching in BlockScoutWeb.TransactionChannel.join/3\r\n        (block_scout_web) lib/block_scout_web/channels/transaction_channel.ex:12: BlockScoutWeb.TransactionChannel.join(\"transactions:0x922bdd8b5e42d290f0fb883c33cc3f9ac391a10ef14048810d0de29d48166360\", %{}, %Phoenix.Socket{assigns: %{locale: \"en\"}, channel: BlockScoutWeb.TransactionChannel, channel_pid: #PID<0.21492.0>, endpoint: BlockScoutWeb.Endpoint, handler: BlockScoutWeb.UserSocket, id: nil, join_ref: \"28\", joined: false, private: %{log_handle_in: :debug, log_join: :info}, pubsub_server: BlockScoutWeb.PubSub, ref: nil, serializer: Phoenix.Transports.V2.WebSocketSerializer, topic: \"transactions:0x922bdd8b5e42d290f0fb883c33cc3f9ac391a10ef14048810d0de29d48166360\", transport: Phoenix.Transports.WebSocket, transport_name: :websocket, transport_pid: #PID<0.2165.0>, vsn: \"2.0.0\"})\r\n        (phoenix) lib/phoenix/channel/server.ex:188: Phoenix.Channel.Server.init/1\r\n        (stdlib) gen_server.erl:374: :gen_server.init_it/2\r\n        (stdlib) gen_server.erl:342: :gen_server.init_it/6\r\n        (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3\r\n```\r\n\r\nIt feels really good though. I like not having the transactions and blocks not moving while trying to highlight them. I would suggest moving the target area up slightly. "}}
{"actor":{"display_login":"acravenho"}}