{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments/239365297","pull_request_review_id":182128637,"id":239365297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTM2NTI5Nw==","diff_hunk":"@@ -135,11 +135,18 @@ private async Task<byte[]> ProcessLoraMessage(LoRaMessageWrapper loraMessage)\n                             fullPayload.port = fportUp;\r\n                             fullPayload.fcnt = fcntup;\r\n \r\n-                            if (isAckFromDevice)\r\n+                           // ACK from device or no decoder set in LoRa Device Twin. Simply return decryptedMessage\r\n+                            if (isAckFromDevice || String.IsNullOrEmpty(loraDeviceInfo.SensorDecoder))\r\n                             {\r\n+                                if (String.IsNullOrEmpty(loraDeviceInfo.SensorDecoder))\r\n+                                {\r\n+                                    Logger.Log(loraDeviceInfo.DevEUI, $\"no decoder set in device twin. port: {fportUp}\", Logger.LoggingLevel.Info);\r","path":"LoRaEngine/modules/LoRaWanNetworkSrvModule/LoRaWan.NetworkServer/MessageProcessor.cs","position":null,"original_position":10,"commit_id":"ea0dc739af8643ea50b9254b8f9e97b43e8b15cc","original_commit_id":"a2b8c2bcf221ed21c9f37195781f87af397e953f","user":{"login":"fbeltrao","id":227765,"node_id":"MDQ6VXNlcjIyNzc2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/227765?v=4","gravatar_id":"","url":"https://api.github.com/users/fbeltrao","html_url":"https://github.com/fbeltrao","followers_url":"https://api.github.com/users/fbeltrao/followers","following_url":"https://api.github.com/users/fbeltrao/following{/other_user}","gists_url":"https://api.github.com/users/fbeltrao/gists{/gist_id}","starred_url":"https://api.github.com/users/fbeltrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbeltrao/subscriptions","organizations_url":"https://api.github.com/users/fbeltrao/orgs","repos_url":"https://api.github.com/users/fbeltrao/repos","events_url":"https://api.github.com/users/fbeltrao/events{/privacy}","received_events_url":"https://api.github.com/users/fbeltrao/received_events","type":"User","site_admin":false},"body":"Shouldn't we then change the log level if we find a decoder too? Logging the decoder used (with and without one) should be in the same log level, right?\r\n\r\nMoreover, if we change the logging level we need to fix the integration test that is using this log information for assertion","created_at":"2018-12-06T08:38:53Z","updated_at":"2018-12-06T08:40:03Z","html_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/52#discussion_r239365297","pull_request_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments/239365297"},"html":{"href":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/52#discussion_r239365297"},"pull_request":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52"}},"in_reply_to_id":239360517},"pull_request":{"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52","id":236441245,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NDQxMjQ1","html_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/52","diff_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/52.diff","patch_url":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/52.patch","issue_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/52","number":52,"state":"open","locked":false,"title":"Update MessageProcessor.cs to fix bug 798","user":{"login":"TechPreacher","id":841949,"node_id":"MDQ6VXNlcjg0MTk0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/841949?v=4","gravatar_id":"","url":"https://api.github.com/users/TechPreacher","html_url":"https://github.com/TechPreacher","followers_url":"https://api.github.com/users/TechPreacher/followers","following_url":"https://api.github.com/users/TechPreacher/following{/other_user}","gists_url":"https://api.github.com/users/TechPreacher/gists{/gist_id}","starred_url":"https://api.github.com/users/TechPreacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechPreacher/subscriptions","organizations_url":"https://api.github.com/users/TechPreacher/orgs","repos_url":"https://api.github.com/users/TechPreacher/repos","events_url":"https://api.github.com/users/TechPreacher/events{/privacy}","received_events_url":"https://api.github.com/users/TechPreacher/received_events","type":"User","site_admin":false},"body":"Now correctly accepts all of the following loraDeviceInfo.SensorDecoder:\r\n- empty / null: Just return base64 decoded payload data\r\n- local decoder name\r\n- external decoder container url\r\n","created_at":"2018-12-06T08:12:45Z","updated_at":"2018-12-06T08:40:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c62222bd96c7fdac141dd2a8c5fafe96632bf283","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fbeltrao","id":227765,"node_id":"MDQ6VXNlcjIyNzc2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/227765?v=4","gravatar_id":"","url":"https://api.github.com/users/fbeltrao","html_url":"https://github.com/fbeltrao","followers_url":"https://api.github.com/users/fbeltrao/followers","following_url":"https://api.github.com/users/fbeltrao/following{/other_user}","gists_url":"https://api.github.com/users/fbeltrao/gists{/gist_id}","starred_url":"https://api.github.com/users/fbeltrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbeltrao/subscriptions","organizations_url":"https://api.github.com/users/fbeltrao/orgs","repos_url":"https://api.github.com/users/fbeltrao/repos","events_url":"https://api.github.com/users/fbeltrao/events{/privacy}","received_events_url":"https://api.github.com/users/fbeltrao/received_events","type":"User","site_admin":false},{"login":"Mandur","id":8555833,"node_id":"MDQ6VXNlcjg1NTU4MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8555833?v=4","gravatar_id":"","url":"https://api.github.com/users/Mandur","html_url":"https://github.com/Mandur","followers_url":"https://api.github.com/users/Mandur/followers","following_url":"https://api.github.com/users/Mandur/following{/other_user}","gists_url":"https://api.github.com/users/Mandur/gists{/gist_id}","starred_url":"https://api.github.com/users/Mandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mandur/subscriptions","organizations_url":"https://api.github.com/users/Mandur/orgs","repos_url":"https://api.github.com/users/Mandur/repos","events_url":"https://api.github.com/users/Mandur/events{/privacy}","received_events_url":"https://api.github.com/users/Mandur/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52/commits","review_comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52/comments","review_comment_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/52/comments","statuses_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/ea0dc739af8643ea50b9254b8f9e97b43e8b15cc","head":{"label":"Azure:sac-dev-bug798","ref":"sac-dev-bug798","sha":"ea0dc739af8643ea50b9254b8f9e97b43e8b15cc","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":145098743,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwOTg3NDM=","name":"iotedge-lorawan-starterkit","full_name":"Azure/iotedge-lorawan-starterkit","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/iotedge-lorawan-starterkit","description":"Experimental sample implementation of LoRaWAN components to connect LoRaWAN antenna gateway running IoT Edge directly with Azure IoT.","fork":false,"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit","forks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/forks","keys_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/teams","hooks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/hooks","issue_events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/events","assignees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/tags","blobs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/languages","stargazers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/stargazers","contributors_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contributors","subscribers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscribers","subscription_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscription","commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/merges","archive_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/downloads","issues_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/labels{/name}","releases_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/deployments","created_at":"2018-08-17T09:09:35Z","updated_at":"2018-11-27T14:05:57Z","pushed_at":"2018-12-06T08:39:53Z","git_url":"git://github.com/Azure/iotedge-lorawan-starterkit.git","ssh_url":"git@github.com:Azure/iotedge-lorawan-starterkit.git","clone_url":"https://github.com/Azure/iotedge-lorawan-starterkit.git","svn_url":"https://github.com/Azure/iotedge-lorawan-starterkit","homepage":null,"size":9777,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":2,"watchers":13,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"405d80a87c4a5c2d487d423772154d4a81d7c734","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":145098743,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwOTg3NDM=","name":"iotedge-lorawan-starterkit","full_name":"Azure/iotedge-lorawan-starterkit","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/iotedge-lorawan-starterkit","description":"Experimental sample implementation of LoRaWAN components to connect LoRaWAN antenna gateway running IoT Edge directly with Azure IoT.","fork":false,"url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit","forks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/forks","keys_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/teams","hooks_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/hooks","issue_events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/events","assignees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/tags","blobs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/languages","stargazers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/stargazers","contributors_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contributors","subscribers_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscribers","subscription_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/subscription","commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/merges","archive_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/downloads","issues_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/labels{/name}","releases_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/deployments","created_at":"2018-08-17T09:09:35Z","updated_at":"2018-11-27T14:05:57Z","pushed_at":"2018-12-06T08:39:53Z","git_url":"git://github.com/Azure/iotedge-lorawan-starterkit.git","ssh_url":"git@github.com:Azure/iotedge-lorawan-starterkit.git","clone_url":"https://github.com/Azure/iotedge-lorawan-starterkit.git","svn_url":"https://github.com/Azure/iotedge-lorawan-starterkit","homepage":null,"size":9777,"stargazers_count":13,"watchers_count":13,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52"},"html":{"href":"https://github.com/Azure/iotedge-lorawan-starterkit/pull/52"},"issue":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/52"},"comments":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/iotedge-lorawan-starterkit/statuses/ea0dc739af8643ea50b9254b8f9e97b43e8b15cc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fbeltrao"}}