{"action":"created","comment":{"url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments/215615445","pull_request_review_id":152908440,"id":215615445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTYxNTQ0NQ==","diff_hunk":"@@ -695,82 +700,66 @@ void Dlg_MemBookmark::ExportJSON()\n \n     if (m_vBookmarks.size() == 0)\n     {\n-        MessageBox(nullptr, _T(\"No bookmarks to save: please create a bookmark before attempting to save.\"), _T(\"Error!\"), MB_OK);\n+        MessageBox(nullptr, _T(\"No bookmarks to save: please create a bookmark before attempting to save.\"),\n+                   _T(\"Error!\"), MB_OK);\n         return;\n     }\n \n-    std::string defaultDir = g_sHomeDir + RA_DIR_BOOKMARKS;\n-\n-    CComPtr<IFileSaveDialog> pDlg;\n-\n-    HRESULT hr;\n-    if (SUCCEEDED(hr = CoCreateInstance(CLSID_FileSaveDialog, nullptr, CLSCTX_ALL, IID_IFileSaveDialog, reinterpret_cast<void**>(&pDlg))))","path":"src/RA_Dlg_MemBookmark.cpp","position":76,"original_position":76,"commit_id":"902434320d6fea3df1a7c5c3db57ea28dd072958","original_commit_id":"902434320d6fea3df1a7c5c3db57ea28dd072958","user":{"login":"Jamiras","id":32680403,"node_id":"MDQ6VXNlcjMyNjgwNDAz","avatar_url":"https://avatars1.githubusercontent.com/u/32680403?v=4","gravatar_id":"","url":"https://api.github.com/users/Jamiras","html_url":"https://github.com/Jamiras","followers_url":"https://api.github.com/users/Jamiras/followers","following_url":"https://api.github.com/users/Jamiras/following{/other_user}","gists_url":"https://api.github.com/users/Jamiras/gists{/gist_id}","starred_url":"https://api.github.com/users/Jamiras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jamiras/subscriptions","organizations_url":"https://api.github.com/users/Jamiras/orgs","repos_url":"https://api.github.com/users/Jamiras/repos","events_url":"https://api.github.com/users/Jamiras/events{/privacy}","received_events_url":"https://api.github.com/users/Jamiras/received_events","type":"User","site_admin":false},"body":"Similar comment here. I suspect this wasn't working on XP before: https://github.com/RetroAchievements/RAIntegration/blob/610021460e6a1d4aa42f5892cd31240f7cde5e6d/src/RA_Dlg_MemBookmark.cpp#L710","created_at":"2018-09-06T13:00:52Z","updated_at":"2018-09-06T13:04:57Z","html_url":"https://github.com/RetroAchievements/RAIntegration/pull/103#discussion_r215615445","pull_request_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments/215615445"},"html":{"href":"https://github.com/RetroAchievements/RAIntegration/pull/103#discussion_r215615445"},"pull_request":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103"}}},"pull_request":{"url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103","id":213492629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDkyNjI5","html_url":"https://github.com/RetroAchievements/RAIntegration/pull/103","diff_url":"https://github.com/RetroAchievements/RAIntegration/pull/103.diff","patch_url":"https://github.com/RetroAchievements/RAIntegration/pull/103.patch","issue_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/103","number":103,"state":"open","locked":false,"title":"Use Windows XP Compatible CommDlg APIs","user":{"login":"SyrianBallaS","id":18649925,"node_id":"MDQ6VXNlcjE4NjQ5OTI1","avatar_url":"https://avatars2.githubusercontent.com/u/18649925?v=4","gravatar_id":"","url":"https://api.github.com/users/SyrianBallaS","html_url":"https://github.com/SyrianBallaS","followers_url":"https://api.github.com/users/SyrianBallaS/followers","following_url":"https://api.github.com/users/SyrianBallaS/following{/other_user}","gists_url":"https://api.github.com/users/SyrianBallaS/gists{/gist_id}","starred_url":"https://api.github.com/users/SyrianBallaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyrianBallaS/subscriptions","organizations_url":"https://api.github.com/users/SyrianBallaS/orgs","repos_url":"https://api.github.com/users/SyrianBallaS/repos","events_url":"https://api.github.com/users/SyrianBallaS/events{/privacy}","received_events_url":"https://api.github.com/users/SyrianBallaS/received_events","type":"User","site_admin":false},"body":"So there's been recent discussions about stuff being broken for XP. I noticed some of the CommDlg (Common Dialog Library) Interfaces used were for Windows Vista and later. Not 100% sure if this is absolutely the best way, but I'm certain this works and is better than what was here before regarding requirements.\r\n\r\nWhat this does is use CommDlg APIs that can be used with Windows XP (some of them even Windows 2000). The COM APIs not changed by this PR are already supported by XP.\r\n\r\nBreakdown:\r\n- `IFileOpenDialog/IFileSaveDialog `w/ `OPENFILENAME`\r\n   - With `GetOpenFileName/GetSaveFileName`\r\n- When choosing the ROM Directory in the game scanner it uses `OLE `w/ `BROWSEINFO`.\r\n   - I chose to use OLE to prevent a deadlock (docs recommended it because it initializes OLE and COM)\r\n   - Uses a callback to get it to work faster.\r\n- Replaced the `_COMDLG_FILTERSPEC `(needs at least Vista) with a straight file filter\r\n   - Files can be loaded and saved in `.json` format as well.\r\n\r\nOther Stuff:\r\n- `RA_Leaderboard `failed a runtime check during the unit tests in debug mode. I noticed it didn't have a `virtual destructor` despite having `virtual methods`. Making the destructor virtual got rid of the runtime error.\r\n   - You either need a public virtual or protected non-virtual destructor if you want virtual methods but it seems unnecessary if it isn't going to be derived.\r\n- Delibrately didn't change some stuff that will be by merging #94 .\r\n\r\nProblems Noticed:\r\n- The parser seems to broken when scanning game library files (those giant json files RACache/Data) in `RA_Dlg_GameLibrary `(Should be resolved after merging #94)\r\n   - It either fails a debug assert or throws an exception (release mode)","created_at":"2018-09-06T04:32:32Z","updated_at":"2018-09-06T13:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"467a172a6f8b60a87ac85d27c57100e302edc677","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103/commits","review_comments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103/comments","review_comment_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/103/comments","statuses_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/statuses/902434320d6fea3df1a7c5c3db57ea28dd072958","head":{"label":"SyrianBallaS:commdlg_xp","ref":"commdlg_xp","sha":"902434320d6fea3df1a7c5c3db57ea28dd072958","user":{"login":"SyrianBallaS","id":18649925,"node_id":"MDQ6VXNlcjE4NjQ5OTI1","avatar_url":"https://avatars2.githubusercontent.com/u/18649925?v=4","gravatar_id":"","url":"https://api.github.com/users/SyrianBallaS","html_url":"https://github.com/SyrianBallaS","followers_url":"https://api.github.com/users/SyrianBallaS/followers","following_url":"https://api.github.com/users/SyrianBallaS/following{/other_user}","gists_url":"https://api.github.com/users/SyrianBallaS/gists{/gist_id}","starred_url":"https://api.github.com/users/SyrianBallaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyrianBallaS/subscriptions","organizations_url":"https://api.github.com/users/SyrianBallaS/orgs","repos_url":"https://api.github.com/users/SyrianBallaS/repos","events_url":"https://api.github.com/users/SyrianBallaS/events{/privacy}","received_events_url":"https://api.github.com/users/SyrianBallaS/received_events","type":"User","site_admin":false},"repo":{"id":129931605,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MzE2MDU=","name":"RAIntegration","full_name":"SyrianBallaS/RAIntegration","owner":{"login":"SyrianBallaS","id":18649925,"node_id":"MDQ6VXNlcjE4NjQ5OTI1","avatar_url":"https://avatars2.githubusercontent.com/u/18649925?v=4","gravatar_id":"","url":"https://api.github.com/users/SyrianBallaS","html_url":"https://github.com/SyrianBallaS","followers_url":"https://api.github.com/users/SyrianBallaS/followers","following_url":"https://api.github.com/users/SyrianBallaS/following{/other_user}","gists_url":"https://api.github.com/users/SyrianBallaS/gists{/gist_id}","starred_url":"https://api.github.com/users/SyrianBallaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyrianBallaS/subscriptions","organizations_url":"https://api.github.com/users/SyrianBallaS/orgs","repos_url":"https://api.github.com/users/SyrianBallaS/repos","events_url":"https://api.github.com/users/SyrianBallaS/events{/privacy}","received_events_url":"https://api.github.com/users/SyrianBallaS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SyrianBallaS/RAIntegration","description":"The DLL responsible to integrate emulators with RetroAchievements.org","fork":true,"url":"https://api.github.com/repos/SyrianBallaS/RAIntegration","forks_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/forks","keys_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/teams","hooks_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/hooks","issue_events_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/events","assignees_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/tags","blobs_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/languages","stargazers_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/stargazers","contributors_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/contributors","subscribers_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/subscribers","subscription_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/subscription","commits_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/merges","archive_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/downloads","issues_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/labels{/name}","releases_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/SyrianBallaS/RAIntegration/deployments","created_at":"2018-04-17T16:09:30Z","updated_at":"2018-09-03T20:24:39Z","pushed_at":"2018-09-06T04:30:25Z","git_url":"git://github.com/SyrianBallaS/RAIntegration.git","ssh_url":"git@github.com:SyrianBallaS/RAIntegration.git","clone_url":"https://github.com/SyrianBallaS/RAIntegration.git","svn_url":"https://github.com/SyrianBallaS/RAIntegration","homepage":"http://retroachievements.org","size":3063,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RetroAchievements:master","ref":"master","sha":"d9030bd9a87b556bc12630591716d0e89f076f1a","user":{"login":"RetroAchievements","id":5411318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTEzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5411318?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroAchievements","html_url":"https://github.com/RetroAchievements","followers_url":"https://api.github.com/users/RetroAchievements/followers","following_url":"https://api.github.com/users/RetroAchievements/following{/other_user}","gists_url":"https://api.github.com/users/RetroAchievements/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroAchievements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroAchievements/subscriptions","organizations_url":"https://api.github.com/users/RetroAchievements/orgs","repos_url":"https://api.github.com/users/RetroAchievements/repos","events_url":"https://api.github.com/users/RetroAchievements/events{/privacy}","received_events_url":"https://api.github.com/users/RetroAchievements/received_events","type":"Organization","site_admin":false},"repo":{"id":129603848,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk2MDM4NDg=","name":"RAIntegration","full_name":"RetroAchievements/RAIntegration","owner":{"login":"RetroAchievements","id":5411318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MTEzMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5411318?v=4","gravatar_id":"","url":"https://api.github.com/users/RetroAchievements","html_url":"https://github.com/RetroAchievements","followers_url":"https://api.github.com/users/RetroAchievements/followers","following_url":"https://api.github.com/users/RetroAchievements/following{/other_user}","gists_url":"https://api.github.com/users/RetroAchievements/gists{/gist_id}","starred_url":"https://api.github.com/users/RetroAchievements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetroAchievements/subscriptions","organizations_url":"https://api.github.com/users/RetroAchievements/orgs","repos_url":"https://api.github.com/users/RetroAchievements/repos","events_url":"https://api.github.com/users/RetroAchievements/events{/privacy}","received_events_url":"https://api.github.com/users/RetroAchievements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RetroAchievements/RAIntegration","description":"The DLL responsible to integrate emulators with RetroAchievements.org","fork":false,"url":"https://api.github.com/repos/RetroAchievements/RAIntegration","forks_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/forks","keys_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/teams","hooks_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/hooks","issue_events_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/events","assignees_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/tags","blobs_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/languages","stargazers_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/stargazers","contributors_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/contributors","subscribers_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/subscribers","subscription_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/subscription","commits_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/merges","archive_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/downloads","issues_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/labels{/name}","releases_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/RetroAchievements/RAIntegration/deployments","created_at":"2018-04-15T11:33:17Z","updated_at":"2018-08-31T19:29:34Z","pushed_at":"2018-09-06T04:32:32Z","git_url":"git://github.com/RetroAchievements/RAIntegration.git","ssh_url":"git@github.com:RetroAchievements/RAIntegration.git","clone_url":"https://github.com/RetroAchievements/RAIntegration.git","svn_url":"https://github.com/RetroAchievements/RAIntegration","homepage":"http://retroachievements.org","size":2698,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":35,"license":null,"forks":4,"open_issues":35,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103"},"html":{"href":"https://github.com/RetroAchievements/RAIntegration/pull/103"},"issue":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/103"},"comments":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/RetroAchievements/RAIntegration/statuses/902434320d6fea3df1a7c5c3db57ea28dd072958"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Jamiras"}}