{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/180063421","pull_request_review_id":110417130,"id":180063421,"diff_hunk":"@@ -0,0 +1,196 @@\n+/*\n+ * Copyright (C) 2018 TypeFox and others.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0\n+ */\n+\n+import { inject, injectable, postConstruct } from 'inversify';\n+import { ILogger } from '@theia/core/lib/common/logger';\n+import { StorageService } from '@theia/core/lib/browser/storage-service';\n+import { Disposable, DisposableCollection } from '@theia/core/lib/common/disposable';\n+import { FrontendApplicationContribution } from '@theia/core/lib/browser/frontend-application';\n+import { Command, CommandContribution, CommandRegistry } from '@theia/core/lib/common/command';\n+import { KeybindingContribution, KeybindingRegistry } from '@theia/core/lib/browser/keybinding';\n+import { MenuContribution, MenuModelRegistry, MAIN_MENU_BAR } from '@theia/core/lib/common/menu';\n+import { EditorWidget } from './editor-widget';\n+import { EditorManager } from './editor-manager';\n+import { TextEditor, Position, Range, TextDocumentChangeEvent } from './editor';\n+import { NavigationLocation } from './navigation/navigation-location';\n+import { NavigationLocationService } from './navigation/navigation-location-service';\n+\n+@injectable()\n+export class EditorNavigationContribution implements Disposable, MenuContribution, CommandContribution, KeybindingContribution, FrontendApplicationContribution {","path":"packages/editor/src/browser/editor-navigation-contribution.ts","position":23,"original_position":23,"commit_id":"48931e5c95c923330b81f9c8a6f5250add2f9f44","original_commit_id":"48931e5c95c923330b81f9c8a6f5250add2f9f44","user":{"login":"kittaakos","id":1405703,"avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"body":"👍 Sure, as I said, I am OK with both, if you feel it is better, we can do it. It's a minor work.","created_at":"2018-04-09T11:24:47Z","updated_at":"2018-04-09T11:24:47Z","html_url":"https://github.com/theia-ide/theia/pull/1649#discussion_r180063421","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/1649","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/180063421"},"html":{"href":"https://github.com/theia-ide/theia/pull/1649#discussion_r180063421"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1649"}},"in_reply_to_id":180039281},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/1649","id":179387615,"html_url":"https://github.com/theia-ide/theia/pull/1649","diff_url":"https://github.com/theia-ide/theia/pull/1649.diff","patch_url":"https://github.com/theia-ide/theia/pull/1649.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/1649","number":1649,"state":"open","locked":false,"title":"GH-73: Implemented editor navigation history.","user":{"login":"kittaakos","id":1405703,"avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"body":"Notes:\r\n - Currently, a location does not get removed when the corresponding file resource is deleted. That would require introducing `@theia/filesystem` in `@theia/editor`.\r\n - When an editor has multiple selections, the navigation service handles only the first content change.\r\n\r\nCloses #73.\r\n\r\nSigned-off-by: Akos Kitta <kittaakos@gmail.com>","created_at":"2018-04-04T13:18:53Z","updated_at":"2018-04-09T11:24:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c8f7f96408b7b854140b2ebba9600063f6f3bb6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/1649/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/1649/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/1649/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/48931e5c95c923330b81f9c8a6f5250add2f9f44","head":{"label":"theia-ide:GH-73","ref":"GH-73","sha":"48931e5c95c923330b81f9c8a6f5250add2f9f44","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-04-09T10:15:34Z","pushed_at":"2018-04-08T16:26:24Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":70263,"stargazers_count":652,"watchers_count":652,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":347,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":113,"open_issues":347,"watchers":652,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"a69e9750bec52efe70db8b3ac5ea581a3d8ba878","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-04-09T10:15:34Z","pushed_at":"2018-04-08T16:26:24Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":70263,"stargazers_count":652,"watchers_count":652,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":347,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":113,"open_issues":347,"watchers":652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1649"},"html":{"href":"https://github.com/theia-ide/theia/pull/1649"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/1649"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/1649/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1649/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/1649/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/48931e5c95c923330b81f9c8a6f5250add2f9f44"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kittaakos"}}