{"action":"created","issue":{"url":"https://api.github.com/repos/anowell/pam-rs/issues/4","repository_url":"https://api.github.com/repos/anowell/pam-rs","labels_url":"https://api.github.com/repos/anowell/pam-rs/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/anowell/pam-rs/issues/4/comments","events_url":"https://api.github.com/repos/anowell/pam-rs/issues/4/events","html_url":"https://github.com/anowell/pam-rs/pull/4","id":394856334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDgxNjUw","number":4,"title":"Conv fixes","user":{"login":"holycleugh","id":43256343,"node_id":"MDQ6VXNlcjQzMjU2MzQz","avatar_url":"https://avatars0.githubusercontent.com/u/43256343?v=4","gravatar_id":"","url":"https://api.github.com/users/holycleugh","html_url":"https://github.com/holycleugh","followers_url":"https://api.github.com/users/holycleugh/followers","following_url":"https://api.github.com/users/holycleugh/following{/other_user}","gists_url":"https://api.github.com/users/holycleugh/gists{/gist_id}","starred_url":"https://api.github.com/users/holycleugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holycleugh/subscriptions","organizations_url":"https://api.github.com/users/holycleugh/orgs","repos_url":"https://api.github.com/users/holycleugh/repos","events_url":"https://api.github.com/users/holycleugh/events{/privacy}","received_events_url":"https://api.github.com/users/holycleugh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-30T08:41:26Z","updated_at":"2019-01-01T20:07:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/anowell/pam-rs/pulls/4","html_url":"https://github.com/anowell/pam-rs/pull/4","diff_url":"https://github.com/anowell/pam-rs/pull/4.diff","patch_url":"https://github.com/anowell/pam-rs/pull/4.patch"},"body":"Hi,\r\nThanks for the great project! I was looking for resources on making my own pam module with rust and came across `pam-rs`.\r\n\r\nI made some small fixes here, one where prompts weren't being displayed due to a lifetime issue (you alluded to this issue in a comment) and one where the module was segfaulting with conv styles that didn't return a response.\r\n\r\nI'm pretty new with rust so I'm totally open to any suggestions you have!"},"comment":{"url":"https://api.github.com/repos/anowell/pam-rs/issues/comments/450753756","html_url":"https://github.com/anowell/pam-rs/pull/4#issuecomment-450753756","issue_url":"https://api.github.com/repos/anowell/pam-rs/issues/4","id":450753756,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDc1Mzc1Ng==","user":{"login":"anowell","id":2629687,"node_id":"MDQ6VXNlcjI2Mjk2ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/2629687?v=4","gravatar_id":"","url":"https://api.github.com/users/anowell","html_url":"https://github.com/anowell","followers_url":"https://api.github.com/users/anowell/followers","following_url":"https://api.github.com/users/anowell/following{/other_user}","gists_url":"https://api.github.com/users/anowell/gists{/gist_id}","starred_url":"https://api.github.com/users/anowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anowell/subscriptions","organizations_url":"https://api.github.com/users/anowell/orgs","repos_url":"https://api.github.com/users/anowell/repos","events_url":"https://api.github.com/users/anowell/events{/privacy}","received_events_url":"https://api.github.com/users/anowell/received_events","type":"User","site_admin":false},"created_at":"2019-01-01T20:07:40Z","updated_at":"2019-01-01T20:07:40Z","author_association":"OWNER","body":"Thanks. This looks good. The `CString` `as_ptr` is a good catch that I think has burned me once before too. As for the possible `null` ptr, I could be persuaded either way though adding a null check sounds like a good safe idea in general. Either way, I'll go ahead and metge this PR as is."}}
{"actor":{"display_login":"anowell"}}