{"action":"closed","number":117,"pull_request":{"url":"https://api.github.com/repos/confluentinc/rest-utils/pulls/117","id":216066675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDY2Njc1","html_url":"https://github.com/confluentinc/rest-utils/pull/117","diff_url":"https://github.com/confluentinc/rest-utils/pull/117.diff","patch_url":"https://github.com/confluentinc/rest-utils/pull/117.patch","issue_url":"https://api.github.com/repos/confluentinc/rest-utils/issues/117","number":117,"state":"closed","locked":false,"title":"fix authentication breaking CORS preflight requests","user":{"login":"xvrl","id":815147,"node_id":"MDQ6VXNlcjgxNTE0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/815147?v=4","gravatar_id":"","url":"https://api.github.com/users/xvrl","html_url":"https://github.com/xvrl","followers_url":"https://api.github.com/users/xvrl/followers","following_url":"https://api.github.com/users/xvrl/following{/other_user}","gists_url":"https://api.github.com/users/xvrl/gists{/gist_id}","starred_url":"https://api.github.com/users/xvrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvrl/subscriptions","organizations_url":"https://api.github.com/users/xvrl/orgs","repos_url":"https://api.github.com/users/xvrl/repos","events_url":"https://api.github.com/users/xvrl/events{/privacy}","received_events_url":"https://api.github.com/users/xvrl/received_events","type":"User","site_admin":false},"body":"* disable authentication for OPTIONS requests when CORS is enabled\r\n* do not forward CORS preflight requests down the filter chain\r\n\r\nNote: regular OPTIONS requests without CORS preflight headers will still\r\nbe forwarded down the filter chain, so this would break applications\r\nthat require authentication for those requests. I don't think we have\r\nany application explicitly handling OPTIONS requests, so the risk should\r\nbe low.","created_at":"2018-09-17T18:04:28Z","updated_at":"2018-09-19T00:01:12Z","closed_at":"2018-09-19T00:01:11Z","merged_at":"2018-09-19T00:01:11Z","merge_commit_sha":"0fc8a8e027c9ded16d8be5b1d4c33b3c8b731187","assignee":null,"assignees":[],"requested_reviewers":[{"login":"norwood","id":2636399,"node_id":"MDQ6VXNlcjI2MzYzOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2636399?v=4","gravatar_id":"","url":"https://api.github.com/users/norwood","html_url":"https://github.com/norwood","followers_url":"https://api.github.com/users/norwood/followers","following_url":"https://api.github.com/users/norwood/following{/other_user}","gists_url":"https://api.github.com/users/norwood/gists{/gist_id}","starred_url":"https://api.github.com/users/norwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norwood/subscriptions","organizations_url":"https://api.github.com/users/norwood/orgs","repos_url":"https://api.github.com/users/norwood/repos","events_url":"https://api.github.com/users/norwood/events{/privacy}","received_events_url":"https://api.github.com/users/norwood/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/rest-utils/pulls/117/commits","review_comments_url":"https://api.github.com/repos/confluentinc/rest-utils/pulls/117/comments","review_comment_url":"https://api.github.com/repos/confluentinc/rest-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/rest-utils/issues/117/comments","statuses_url":"https://api.github.com/repos/confluentinc/rest-utils/statuses/5c9e14641f276a77a16332d27da826869f84148f","head":{"label":"xvrl:disable-auth-cors-preflight","ref":"disable-auth-cors-preflight","sha":"5c9e14641f276a77a16332d27da826869f84148f","user":{"login":"xvrl","id":815147,"node_id":"MDQ6VXNlcjgxNTE0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/815147?v=4","gravatar_id":"","url":"https://api.github.com/users/xvrl","html_url":"https://github.com/xvrl","followers_url":"https://api.github.com/users/xvrl/followers","following_url":"https://api.github.com/users/xvrl/following{/other_user}","gists_url":"https://api.github.com/users/xvrl/gists{/gist_id}","starred_url":"https://api.github.com/users/xvrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvrl/subscriptions","organizations_url":"https://api.github.com/users/xvrl/orgs","repos_url":"https://api.github.com/users/xvrl/repos","events_url":"https://api.github.com/users/xvrl/events{/privacy}","received_events_url":"https://api.github.com/users/xvrl/received_events","type":"User","site_admin":false},"repo":{"id":68409269,"node_id":"MDEwOlJlcG9zaXRvcnk2ODQwOTI2OQ==","name":"rest-utils","full_name":"xvrl/rest-utils","private":false,"owner":{"login":"xvrl","id":815147,"node_id":"MDQ6VXNlcjgxNTE0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/815147?v=4","gravatar_id":"","url":"https://api.github.com/users/xvrl","html_url":"https://github.com/xvrl","followers_url":"https://api.github.com/users/xvrl/followers","following_url":"https://api.github.com/users/xvrl/following{/other_user}","gists_url":"https://api.github.com/users/xvrl/gists{/gist_id}","starred_url":"https://api.github.com/users/xvrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvrl/subscriptions","organizations_url":"https://api.github.com/users/xvrl/orgs","repos_url":"https://api.github.com/users/xvrl/repos","events_url":"https://api.github.com/users/xvrl/events{/privacy}","received_events_url":"https://api.github.com/users/xvrl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xvrl/rest-utils","description":"Utilities and a small framework for building REST services with Jersey, Jackson, and Jetty.","fork":true,"url":"https://api.github.com/repos/xvrl/rest-utils","forks_url":"https://api.github.com/repos/xvrl/rest-utils/forks","keys_url":"https://api.github.com/repos/xvrl/rest-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xvrl/rest-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xvrl/rest-utils/teams","hooks_url":"https://api.github.com/repos/xvrl/rest-utils/hooks","issue_events_url":"https://api.github.com/repos/xvrl/rest-utils/issues/events{/number}","events_url":"https://api.github.com/repos/xvrl/rest-utils/events","assignees_url":"https://api.github.com/repos/xvrl/rest-utils/assignees{/user}","branches_url":"https://api.github.com/repos/xvrl/rest-utils/branches{/branch}","tags_url":"https://api.github.com/repos/xvrl/rest-utils/tags","blobs_url":"https://api.github.com/repos/xvrl/rest-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xvrl/rest-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xvrl/rest-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/xvrl/rest-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xvrl/rest-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/xvrl/rest-utils/languages","stargazers_url":"https://api.github.com/repos/xvrl/rest-utils/stargazers","contributors_url":"https://api.github.com/repos/xvrl/rest-utils/contributors","subscribers_url":"https://api.github.com/repos/xvrl/rest-utils/subscribers","subscription_url":"https://api.github.com/repos/xvrl/rest-utils/subscription","commits_url":"https://api.github.com/repos/xvrl/rest-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/xvrl/rest-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/xvrl/rest-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/xvrl/rest-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/xvrl/rest-utils/contents/{+path}","compare_url":"https://api.github.com/repos/xvrl/rest-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xvrl/rest-utils/merges","archive_url":"https://api.github.com/repos/xvrl/rest-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xvrl/rest-utils/downloads","issues_url":"https://api.github.com/repos/xvrl/rest-utils/issues{/number}","pulls_url":"https://api.github.com/repos/xvrl/rest-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/xvrl/rest-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/xvrl/rest-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xvrl/rest-utils/labels{/name}","releases_url":"https://api.github.com/repos/xvrl/rest-utils/releases{/id}","deployments_url":"https://api.github.com/repos/xvrl/rest-utils/deployments","created_at":"2016-09-16T19:32:11Z","updated_at":"2016-09-16T19:32:12Z","pushed_at":"2018-09-17T18:15:34Z","git_url":"git://github.com/xvrl/rest-utils.git","ssh_url":"git@github.com:xvrl/rest-utils.git","clone_url":"https://github.com/xvrl/rest-utils.git","svn_url":"https://github.com/xvrl/rest-utils","homepage":null,"size":430,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"c1555a05638b85f6d0d7da9b9389572d7c9c6217","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":27883327,"node_id":"MDEwOlJlcG9zaXRvcnkyNzg4MzMyNw==","name":"rest-utils","full_name":"confluentinc/rest-utils","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/rest-utils","description":"Utilities and a small framework for building REST services with Jersey, Jackson, and Jetty.","fork":false,"url":"https://api.github.com/repos/confluentinc/rest-utils","forks_url":"https://api.github.com/repos/confluentinc/rest-utils/forks","keys_url":"https://api.github.com/repos/confluentinc/rest-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/rest-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/rest-utils/teams","hooks_url":"https://api.github.com/repos/confluentinc/rest-utils/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/rest-utils/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/rest-utils/events","assignees_url":"https://api.github.com/repos/confluentinc/rest-utils/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/rest-utils/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/rest-utils/tags","blobs_url":"https://api.github.com/repos/confluentinc/rest-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/rest-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/rest-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/rest-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/rest-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/rest-utils/languages","stargazers_url":"https://api.github.com/repos/confluentinc/rest-utils/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/rest-utils/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/rest-utils/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/rest-utils/subscription","commits_url":"https://api.github.com/repos/confluentinc/rest-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/rest-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/rest-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/rest-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/rest-utils/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/rest-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/rest-utils/merges","archive_url":"https://api.github.com/repos/confluentinc/rest-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/rest-utils/downloads","issues_url":"https://api.github.com/repos/confluentinc/rest-utils/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/rest-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/rest-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/rest-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/rest-utils/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/rest-utils/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/rest-utils/deployments","created_at":"2014-12-11T17:33:16Z","updated_at":"2018-09-14T23:40:35Z","pushed_at":"2018-09-19T00:01:11Z","git_url":"git://github.com/confluentinc/rest-utils.git","ssh_url":"git@github.com:confluentinc/rest-utils.git","clone_url":"https://github.com/confluentinc/rest-utils.git","svn_url":"https://github.com/confluentinc/rest-utils","homepage":null,"size":573,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":116,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":116,"open_issues":17,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/rest-utils/pulls/117"},"html":{"href":"https://github.com/confluentinc/rest-utils/pull/117"},"issue":{"href":"https://api.github.com/repos/confluentinc/rest-utils/issues/117"},"comments":{"href":"https://api.github.com/repos/confluentinc/rest-utils/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/rest-utils/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/rest-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/rest-utils/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/rest-utils/statuses/5c9e14641f276a77a16332d27da826869f84148f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"xvrl","id":815147,"node_id":"MDQ6VXNlcjgxNTE0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/815147?v=4","gravatar_id":"","url":"https://api.github.com/users/xvrl","html_url":"https://github.com/xvrl","followers_url":"https://api.github.com/users/xvrl/followers","following_url":"https://api.github.com/users/xvrl/following{/other_user}","gists_url":"https://api.github.com/users/xvrl/gists{/gist_id}","starred_url":"https://api.github.com/users/xvrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvrl/subscriptions","organizations_url":"https://api.github.com/users/xvrl/orgs","repos_url":"https://api.github.com/users/xvrl/repos","events_url":"https://api.github.com/users/xvrl/events{/privacy}","received_events_url":"https://api.github.com/users/xvrl/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":53,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"xvrl"}}