{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/232017913","pull_request_review_id":173116952,"id":232017913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjAxNzkxMw==","diff_hunk":"@@ -699,20 +699,38 @@ public class Result\n             public const int SuccessCode = 0;\r\n             public const int GenericFailureCode = 1;\r\n \r\n-            public Result(string output, string errors, int returnCode)\r\n+            public Result(string stdout, string stderr, int exitCode)\r\n             {\r\n-                this.Output = output;\r\n-                this.Errors = errors;\r\n-                this.ReturnCode = returnCode;\r\n+                this.Output = stdout;\r\n+                this.Errors = stderr;\r\n+                this.ExitCode = exitCode;\r\n             }\r\n \r\n             public string Output { get; }\r\n             public string Errors { get; }\r\n-            public int ReturnCode { get; }\r\n+            public int ExitCode { get; }\r\n \r\n-            public bool HasErrors\r\n+            public bool ExitCodeIsSuccess\r\n             {\r\n-                get { return this.ReturnCode != SuccessCode; }\r\n+                get { return this.ExitCode == Result.SuccessCode; }\r\n+            }\r\n+\r\n+            public bool ExitCodeIsFailure\r\n+            {\r\n+                get { return !this.ExitCodeIsSuccess; }\r\n+            }\r\n+\r\n+            public bool StderrContainsErrors()\r\n+            {\r\n+                if (!string.IsNullOrWhiteSpace(this.Errors))\r\n+                {\r\n+                    return !this.Errors\r\n+                         .Trim()\r\n+                         .Split('\\n')\r","path":"GVFS/GVFS.Common/Git/GitProcess.cs","position":92,"original_position":92,"commit_id":"de21ea08ffdd3c96bd84ff0fd970df929210f0bb","original_commit_id":"de21ea08ffdd3c96bd84ff0fd970df929210f0bb","user":{"login":"sanoursa","id":8729434,"node_id":"MDQ6VXNlcjg3Mjk0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8729434?v=4","gravatar_id":"","url":"https://api.github.com/users/sanoursa","html_url":"https://github.com/sanoursa","followers_url":"https://api.github.com/users/sanoursa/followers","following_url":"https://api.github.com/users/sanoursa/following{/other_user}","gists_url":"https://api.github.com/users/sanoursa/gists{/gist_id}","starred_url":"https://api.github.com/users/sanoursa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanoursa/subscriptions","organizations_url":"https://api.github.com/users/sanoursa/orgs","repos_url":"https://api.github.com/users/sanoursa/repos","events_url":"https://api.github.com/users/sanoursa/events{/privacy}","received_events_url":"https://api.github.com/users/sanoursa/received_events","type":"User","site_admin":false},"body":"Should we specify `StringSplitOptions.RemoveEmptyEntries` here? Otherwise a blank line between warning messages would cause us to return false here, right?","created_at":"2018-11-08T18:50:34Z","updated_at":"2018-11-08T18:51:55Z","html_url":"https://github.com/Microsoft/VFSForGit/pull/478#discussion_r232017913","pull_request_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments/232017913"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/478#discussion_r232017913"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478","id":228797717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Nzk3NzE3","html_url":"https://github.com/Microsoft/VFSForGit/pull/478","diff_url":"https://github.com/Microsoft/VFSForGit/pull/478.diff","patch_url":"https://github.com/Microsoft/VFSForGit/pull/478.patch","issue_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/478","number":478,"state":"open","locked":false,"title":"Ignore non-zero exit codes when calling `git config` and all lines on stderr are prefixed 'warning'","user":{"login":"jrbriggs","id":1819344,"node_id":"MDQ6VXNlcjE4MTkzNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1819344?v=4","gravatar_id":"","url":"https://api.github.com/users/jrbriggs","html_url":"https://github.com/jrbriggs","followers_url":"https://api.github.com/users/jrbriggs/followers","following_url":"https://api.github.com/users/jrbriggs/following{/other_user}","gists_url":"https://api.github.com/users/jrbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbriggs/subscriptions","organizations_url":"https://api.github.com/users/jrbriggs/orgs","repos_url":"https://api.github.com/users/jrbriggs/repos","events_url":"https://api.github.com/users/jrbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/jrbriggs/received_events","type":"User","site_admin":false},"body":"This addresses #471 ","created_at":"2018-11-06T18:51:48Z","updated_at":"2018-11-08T18:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78de0788b1edfb6741ac3b734ca2063020cb7fb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478/commits","review_comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478/comments","review_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/478/comments","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/de21ea08ffdd3c96bd84ff0fd970df929210f0bb","head":{"label":"jrbriggs:config-warning","ref":"config-warning","sha":"de21ea08ffdd3c96bd84ff0fd970df929210f0bb","user":{"login":"jrbriggs","id":1819344,"node_id":"MDQ6VXNlcjE4MTkzNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1819344?v=4","gravatar_id":"","url":"https://api.github.com/users/jrbriggs","html_url":"https://github.com/jrbriggs","followers_url":"https://api.github.com/users/jrbriggs/followers","following_url":"https://api.github.com/users/jrbriggs/following{/other_user}","gists_url":"https://api.github.com/users/jrbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbriggs/subscriptions","organizations_url":"https://api.github.com/users/jrbriggs/orgs","repos_url":"https://api.github.com/users/jrbriggs/repos","events_url":"https://api.github.com/users/jrbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/jrbriggs/received_events","type":"User","site_admin":false},"repo":{"id":144336582,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzMzY1ODI=","name":"VFSForGit","full_name":"jrbriggs/VFSForGit","private":false,"owner":{"login":"jrbriggs","id":1819344,"node_id":"MDQ6VXNlcjE4MTkzNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1819344?v=4","gravatar_id":"","url":"https://api.github.com/users/jrbriggs","html_url":"https://github.com/jrbriggs","followers_url":"https://api.github.com/users/jrbriggs/followers","following_url":"https://api.github.com/users/jrbriggs/following{/other_user}","gists_url":"https://api.github.com/users/jrbriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbriggs/subscriptions","organizations_url":"https://api.github.com/users/jrbriggs/orgs","repos_url":"https://api.github.com/users/jrbriggs/repos","events_url":"https://api.github.com/users/jrbriggs/events{/privacy}","received_events_url":"https://api.github.com/users/jrbriggs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jrbriggs/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":true,"url":"https://api.github.com/repos/jrbriggs/VFSForGit","forks_url":"https://api.github.com/repos/jrbriggs/VFSForGit/forks","keys_url":"https://api.github.com/repos/jrbriggs/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrbriggs/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrbriggs/VFSForGit/teams","hooks_url":"https://api.github.com/repos/jrbriggs/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/jrbriggs/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/jrbriggs/VFSForGit/events","assignees_url":"https://api.github.com/repos/jrbriggs/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/jrbriggs/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/jrbriggs/VFSForGit/tags","blobs_url":"https://api.github.com/repos/jrbriggs/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrbriggs/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrbriggs/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrbriggs/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrbriggs/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/jrbriggs/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/jrbriggs/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/jrbriggs/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/jrbriggs/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/jrbriggs/VFSForGit/subscription","commits_url":"https://api.github.com/repos/jrbriggs/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrbriggs/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrbriggs/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrbriggs/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrbriggs/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/jrbriggs/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrbriggs/VFSForGit/merges","archive_url":"https://api.github.com/repos/jrbriggs/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrbriggs/VFSForGit/downloads","issues_url":"https://api.github.com/repos/jrbriggs/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/jrbriggs/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/jrbriggs/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/jrbriggs/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrbriggs/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/jrbriggs/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/jrbriggs/VFSForGit/deployments","created_at":"2018-08-10T22:11:28Z","updated_at":"2018-10-30T21:42:56Z","pushed_at":"2018-11-08T16:57:49Z","git_url":"git://github.com/jrbriggs/VFSForGit.git","ssh_url":"git@github.com:jrbriggs/VFSForGit.git","clone_url":"https://github.com/jrbriggs/VFSForGit.git","svn_url":"https://github.com/jrbriggs/VFSForGit","homepage":"https://gvfs.io/","size":3401,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"37b57bb77f4dfd9a4dd863b80293e018b63bf4d8","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":80058269,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA1ODI2OQ==","name":"VFSForGit","full_name":"Microsoft/VFSForGit","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/VFSForGit","description":"Virtual File System for Git: Enable Git at Enterprise Scale","fork":false,"url":"https://api.github.com/repos/Microsoft/VFSForGit","forks_url":"https://api.github.com/repos/Microsoft/VFSForGit/forks","keys_url":"https://api.github.com/repos/Microsoft/VFSForGit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/VFSForGit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/VFSForGit/teams","hooks_url":"https://api.github.com/repos/Microsoft/VFSForGit/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/VFSForGit/events","assignees_url":"https://api.github.com/repos/Microsoft/VFSForGit/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/VFSForGit/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/tags","blobs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/VFSForGit/languages","stargazers_url":"https://api.github.com/repos/Microsoft/VFSForGit/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/VFSForGit/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/VFSForGit/subscription","commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/VFSForGit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/VFSForGit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/VFSForGit/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/VFSForGit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/VFSForGit/merges","archive_url":"https://api.github.com/repos/Microsoft/VFSForGit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/VFSForGit/downloads","issues_url":"https://api.github.com/repos/Microsoft/VFSForGit/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/VFSForGit/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/VFSForGit/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/VFSForGit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/VFSForGit/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/VFSForGit/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/VFSForGit/deployments","created_at":"2017-01-25T21:10:29Z","updated_at":"2018-11-08T16:31:41Z","pushed_at":"2018-11-08T18:47:28Z","git_url":"git://github.com/Microsoft/VFSForGit.git","ssh_url":"git@github.com:Microsoft/VFSForGit.git","clone_url":"https://github.com/Microsoft/VFSForGit.git","svn_url":"https://github.com/Microsoft/VFSForGit","homepage":"https://gvfs.io/","size":3401,"stargazers_count":4381,"watchers_count":4381,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":294,"open_issues":138,"watchers":4381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478"},"html":{"href":"https://github.com/Microsoft/VFSForGit/pull/478"},"issue":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/478"},"comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/VFSForGit/statuses/de21ea08ffdd3c96bd84ff0fd970df929210f0bb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sanoursa"}}