{"action":"opened","number":515,"pull_request":{"url":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/515","id":214438936,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDM4OTM2","html_url":"https://github.com/TuringLang/Turing.jl/pull/515","diff_url":"https://github.com/TuringLang/Turing.jl/pull/515.diff","patch_url":"https://github.com/TuringLang/Turing.jl/pull/515.patch","issue_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues/515","number":515,"state":"open","locked":false,"title":"[WIP] Tidy up AD interface + remove cleandual! and realpart!. Do not merge.","user":{"login":"willtebbutt","id":3628294,"node_id":"MDQ6VXNlcjM2MjgyOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3628294?v=4","gravatar_id":"","url":"https://api.github.com/users/willtebbutt","html_url":"https://github.com/willtebbutt","followers_url":"https://api.github.com/users/willtebbutt/followers","following_url":"https://api.github.com/users/willtebbutt/following{/other_user}","gists_url":"https://api.github.com/users/willtebbutt/gists{/gist_id}","starred_url":"https://api.github.com/users/willtebbutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willtebbutt/subscriptions","organizations_url":"https://api.github.com/users/willtebbutt/orgs","repos_url":"https://api.github.com/users/willtebbutt/repos","events_url":"https://api.github.com/users/willtebbutt/events{/privacy}","received_events_url":"https://api.github.com/users/willtebbutt/received_events","type":"User","site_admin":false},"body":"This PR does quite a few things. Firstly, it moves `sghmc` and `sgld` over to using the new `gradient` interface, and resolves an interesting bug that that threw up.\r\n\r\nThe second important thing is that it improves `gradient` by ensuring that it has no side-effects, and cleans up after itself. In particular it ensures that all tracking information is removed from `vi.vals`. This enables the satisfactory resolution of #509 and further enables the complete removal of `realpart`, as we're no longer carrying around which appears to concerned precisely the removal of tracking information.\r\n\r\nThere are also a few formatting fixes that I undertook whenever significant modifications were made to a file.\r\n\r\nThere remain a couple of loose ends to tie up, and I would advise against merging this until #513 is merged anyway to avoid clashes.","created_at":"2018-09-10T20:45:52Z","updated_at":"2018-09-10T20:45:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/515/commits","review_comments_url":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/515/comments","review_comment_url":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues/515/comments","statuses_url":"https://api.github.com/repos/TuringLang/Turing.jl/statuses/d9d2f9e5cca753b1021b3a9c4b91e01544524298","head":{"label":"TuringLang:wct/sghmc-ad","ref":"wct/sghmc-ad","sha":"d9d2f9e5cca753b1021b3a9c4b91e01544524298","user":{"login":"TuringLang","id":26261527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjYxNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/26261527?v=4","gravatar_id":"","url":"https://api.github.com/users/TuringLang","html_url":"https://github.com/TuringLang","followers_url":"https://api.github.com/users/TuringLang/followers","following_url":"https://api.github.com/users/TuringLang/following{/other_user}","gists_url":"https://api.github.com/users/TuringLang/gists{/gist_id}","starred_url":"https://api.github.com/users/TuringLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuringLang/subscriptions","organizations_url":"https://api.github.com/users/TuringLang/orgs","repos_url":"https://api.github.com/users/TuringLang/repos","events_url":"https://api.github.com/users/TuringLang/events{/privacy}","received_events_url":"https://api.github.com/users/TuringLang/received_events","type":"Organization","site_admin":false},"repo":{"id":57377821,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM3NzgyMQ==","name":"Turing.jl","full_name":"TuringLang/Turing.jl","owner":{"login":"TuringLang","id":26261527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjYxNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/26261527?v=4","gravatar_id":"","url":"https://api.github.com/users/TuringLang","html_url":"https://github.com/TuringLang","followers_url":"https://api.github.com/users/TuringLang/followers","following_url":"https://api.github.com/users/TuringLang/following{/other_user}","gists_url":"https://api.github.com/users/TuringLang/gists{/gist_id}","starred_url":"https://api.github.com/users/TuringLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuringLang/subscriptions","organizations_url":"https://api.github.com/users/TuringLang/orgs","repos_url":"https://api.github.com/users/TuringLang/repos","events_url":"https://api.github.com/users/TuringLang/events{/privacy}","received_events_url":"https://api.github.com/users/TuringLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TuringLang/Turing.jl","description":"The Turing language for probabilistic programming","fork":false,"url":"https://api.github.com/repos/TuringLang/Turing.jl","forks_url":"https://api.github.com/repos/TuringLang/Turing.jl/forks","keys_url":"https://api.github.com/repos/TuringLang/Turing.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TuringLang/Turing.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TuringLang/Turing.jl/teams","hooks_url":"https://api.github.com/repos/TuringLang/Turing.jl/hooks","issue_events_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues/events{/number}","events_url":"https://api.github.com/repos/TuringLang/Turing.jl/events","assignees_url":"https://api.github.com/repos/TuringLang/Turing.jl/assignees{/user}","branches_url":"https://api.github.com/repos/TuringLang/Turing.jl/branches{/branch}","tags_url":"https://api.github.com/repos/TuringLang/Turing.jl/tags","blobs_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TuringLang/Turing.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/TuringLang/Turing.jl/languages","stargazers_url":"https://api.github.com/repos/TuringLang/Turing.jl/stargazers","contributors_url":"https://api.github.com/repos/TuringLang/Turing.jl/contributors","subscribers_url":"https://api.github.com/repos/TuringLang/Turing.jl/subscribers","subscription_url":"https://api.github.com/repos/TuringLang/Turing.jl/subscription","commits_url":"https://api.github.com/repos/TuringLang/Turing.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/TuringLang/Turing.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/TuringLang/Turing.jl/contents/{+path}","compare_url":"https://api.github.com/repos/TuringLang/Turing.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TuringLang/Turing.jl/merges","archive_url":"https://api.github.com/repos/TuringLang/Turing.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TuringLang/Turing.jl/downloads","issues_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues{/number}","pulls_url":"https://api.github.com/repos/TuringLang/Turing.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/TuringLang/Turing.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/TuringLang/Turing.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TuringLang/Turing.jl/labels{/name}","releases_url":"https://api.github.com/repos/TuringLang/Turing.jl/releases{/id}","deployments_url":"https://api.github.com/repos/TuringLang/Turing.jl/deployments","created_at":"2016-04-29T10:51:43Z","updated_at":"2018-09-09T11:34:51Z","pushed_at":"2018-09-10T20:30:53Z","git_url":"git://github.com/TuringLang/Turing.jl.git","ssh_url":"git@github.com:TuringLang/Turing.jl.git","clone_url":"https://github.com/TuringLang/Turing.jl.git","svn_url":"https://github.com/TuringLang/Turing.jl","homepage":"http://turing.ml","size":14991,"stargazers_count":276,"watchers_count":276,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":94,"watchers":276,"default_branch":"master"}},"base":{"label":"TuringLang:master","ref":"master","sha":"2553364532d121b65967c2307dfc479382a06cad","user":{"login":"TuringLang","id":26261527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjYxNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/26261527?v=4","gravatar_id":"","url":"https://api.github.com/users/TuringLang","html_url":"https://github.com/TuringLang","followers_url":"https://api.github.com/users/TuringLang/followers","following_url":"https://api.github.com/users/TuringLang/following{/other_user}","gists_url":"https://api.github.com/users/TuringLang/gists{/gist_id}","starred_url":"https://api.github.com/users/TuringLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuringLang/subscriptions","organizations_url":"https://api.github.com/users/TuringLang/orgs","repos_url":"https://api.github.com/users/TuringLang/repos","events_url":"https://api.github.com/users/TuringLang/events{/privacy}","received_events_url":"https://api.github.com/users/TuringLang/received_events","type":"Organization","site_admin":false},"repo":{"id":57377821,"node_id":"MDEwOlJlcG9zaXRvcnk1NzM3NzgyMQ==","name":"Turing.jl","full_name":"TuringLang/Turing.jl","owner":{"login":"TuringLang","id":26261527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjYxNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/26261527?v=4","gravatar_id":"","url":"https://api.github.com/users/TuringLang","html_url":"https://github.com/TuringLang","followers_url":"https://api.github.com/users/TuringLang/followers","following_url":"https://api.github.com/users/TuringLang/following{/other_user}","gists_url":"https://api.github.com/users/TuringLang/gists{/gist_id}","starred_url":"https://api.github.com/users/TuringLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuringLang/subscriptions","organizations_url":"https://api.github.com/users/TuringLang/orgs","repos_url":"https://api.github.com/users/TuringLang/repos","events_url":"https://api.github.com/users/TuringLang/events{/privacy}","received_events_url":"https://api.github.com/users/TuringLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TuringLang/Turing.jl","description":"The Turing language for probabilistic programming","fork":false,"url":"https://api.github.com/repos/TuringLang/Turing.jl","forks_url":"https://api.github.com/repos/TuringLang/Turing.jl/forks","keys_url":"https://api.github.com/repos/TuringLang/Turing.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TuringLang/Turing.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TuringLang/Turing.jl/teams","hooks_url":"https://api.github.com/repos/TuringLang/Turing.jl/hooks","issue_events_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues/events{/number}","events_url":"https://api.github.com/repos/TuringLang/Turing.jl/events","assignees_url":"https://api.github.com/repos/TuringLang/Turing.jl/assignees{/user}","branches_url":"https://api.github.com/repos/TuringLang/Turing.jl/branches{/branch}","tags_url":"https://api.github.com/repos/TuringLang/Turing.jl/tags","blobs_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TuringLang/Turing.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/TuringLang/Turing.jl/languages","stargazers_url":"https://api.github.com/repos/TuringLang/Turing.jl/stargazers","contributors_url":"https://api.github.com/repos/TuringLang/Turing.jl/contributors","subscribers_url":"https://api.github.com/repos/TuringLang/Turing.jl/subscribers","subscription_url":"https://api.github.com/repos/TuringLang/Turing.jl/subscription","commits_url":"https://api.github.com/repos/TuringLang/Turing.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/TuringLang/Turing.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/TuringLang/Turing.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/TuringLang/Turing.jl/contents/{+path}","compare_url":"https://api.github.com/repos/TuringLang/Turing.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TuringLang/Turing.jl/merges","archive_url":"https://api.github.com/repos/TuringLang/Turing.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TuringLang/Turing.jl/downloads","issues_url":"https://api.github.com/repos/TuringLang/Turing.jl/issues{/number}","pulls_url":"https://api.github.com/repos/TuringLang/Turing.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/TuringLang/Turing.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/TuringLang/Turing.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TuringLang/Turing.jl/labels{/name}","releases_url":"https://api.github.com/repos/TuringLang/Turing.jl/releases{/id}","deployments_url":"https://api.github.com/repos/TuringLang/Turing.jl/deployments","created_at":"2016-04-29T10:51:43Z","updated_at":"2018-09-09T11:34:51Z","pushed_at":"2018-09-10T20:30:53Z","git_url":"git://github.com/TuringLang/Turing.jl.git","ssh_url":"git@github.com:TuringLang/Turing.jl.git","clone_url":"https://github.com/TuringLang/Turing.jl.git","svn_url":"https://github.com/TuringLang/Turing.jl","homepage":"http://turing.ml","size":14991,"stargazers_count":276,"watchers_count":276,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":94,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/515"},"html":{"href":"https://github.com/TuringLang/Turing.jl/pull/515"},"issue":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/issues/515"},"comments":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/TuringLang/Turing.jl/statuses/d9d2f9e5cca753b1021b3a9c4b91e01544524298"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":578,"deletions":527,"changed_files":20}}
{"actor":{"display_login":"willtebbutt"}}