{"action":"created","issue":{"url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/issues/12","repository_url":"https://api.github.com/repos/lulibrary/alma-webhook-handler","labels_url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/issues/12/comments","events_url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/issues/12/events","html_url":"https://github.com/lulibrary/alma-webhook-handler/pull/12","id":313644528,"number":12,"title":"Loan due date topic publish","user":{"login":"DomBelcher","id":11499597,"avatar_url":"https://avatars2.githubusercontent.com/u/11499597?v=4","gravatar_id":"","url":"https://api.github.com/users/DomBelcher","html_url":"https://github.com/DomBelcher","followers_url":"https://api.github.com/users/DomBelcher/followers","following_url":"https://api.github.com/users/DomBelcher/following{/other_user}","gists_url":"https://api.github.com/users/DomBelcher/gists{/gist_id}","starred_url":"https://api.github.com/users/DomBelcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomBelcher/subscriptions","organizations_url":"https://api.github.com/users/DomBelcher/orgs","repos_url":"https://api.github.com/users/DomBelcher/repos","events_url":"https://api.github.com/users/DomBelcher/events{/privacy}","received_events_url":"https://api.github.com/users/DomBelcher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-12T09:23:44Z","updated_at":"2018-04-12T09:40:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/pulls/12","html_url":"https://github.com/lulibrary/alma-webhook-handler/pull/12","diff_url":"https://github.com/lulibrary/alma-webhook-handler/pull/12.diff","patch_url":"https://github.com/lulibrary/alma-webhook-handler/pull/12.patch"},"body":"This handles webhook events from alma with type LOAN_DUE_DATE.\r\n\r\nThis creates an SNS topic for these events, and updates the lambda to publish the data for these events to this SNS topic when the webhook events are received.\r\n\r\nThis also adds tests for the eventTopicData Map object, and fixes a bug where the topic arn was not being set correctly"},"comment":{"url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/issues/comments/380742168","html_url":"https://github.com/lulibrary/alma-webhook-handler/pull/12#issuecomment-380742168","issue_url":"https://api.github.com/repos/lulibrary/alma-webhook-handler/issues/12","id":380742168,"user":{"login":"DomBelcher","id":11499597,"avatar_url":"https://avatars2.githubusercontent.com/u/11499597?v=4","gravatar_id":"","url":"https://api.github.com/users/DomBelcher","html_url":"https://github.com/DomBelcher","followers_url":"https://api.github.com/users/DomBelcher/followers","following_url":"https://api.github.com/users/DomBelcher/following{/other_user}","gists_url":"https://api.github.com/users/DomBelcher/gists{/gist_id}","starred_url":"https://api.github.com/users/DomBelcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomBelcher/subscriptions","organizations_url":"https://api.github.com/users/DomBelcher/orgs","repos_url":"https://api.github.com/users/DomBelcher/repos","events_url":"https://api.github.com/users/DomBelcher/events{/privacy}","received_events_url":"https://api.github.com/users/DomBelcher/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T09:40:37Z","updated_at":"2018-04-12T09:40:37Z","author_association":"CONTRIBUTOR","body":"The data body is just dumped straight onto the topic - my thinking was we don't know what data future consumers of the topic would require so it didn't make sense to cut data out of it\r\n\r\nThere's no test specifically for the LOAN_DUE_DATE event passing in the correct data, could add one in - given that all events are handled the same except for being published to a different topic, is the only thing that needs to be checked that the correct topic ARN is used for each event?"}}
{"actor":{"display_login":"DomBelcher"}}