{"action":"created","issue":{"url":"https://api.github.com/repos/openscad/openscad/issues/2479","repository_url":"https://api.github.com/repos/openscad/openscad","labels_url":"https://api.github.com/repos/openscad/openscad/issues/2479/labels{/name}","comments_url":"https://api.github.com/repos/openscad/openscad/issues/2479/comments","events_url":"https://api.github.com/repos/openscad/openscad/issues/2479/events","html_url":"https://github.com/openscad/openscad/pull/2479","id":358167426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDA1ODY3","number":2479,"title":"adding a \"design default values\" parameter set","user":{"login":"MichaelPFrey","id":24962768,"node_id":"MDQ6VXNlcjI0OTYyNzY4","avatar_url":"https://avatars2.githubusercontent.com/u/24962768?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelPFrey","html_url":"https://github.com/MichaelPFrey","followers_url":"https://api.github.com/users/MichaelPFrey/followers","following_url":"https://api.github.com/users/MichaelPFrey/following{/other_user}","gists_url":"https://api.github.com/users/MichaelPFrey/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelPFrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelPFrey/subscriptions","organizations_url":"https://api.github.com/users/MichaelPFrey/orgs","repos_url":"https://api.github.com/users/MichaelPFrey/repos","events_url":"https://api.github.com/users/MichaelPFrey/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelPFrey/received_events","type":"User","site_admin":false},"labels":[{"id":430934974,"node_id":"MDU6TGFiZWw0MzA5MzQ5NzQ=","url":"https://api.github.com/repos/openscad/openscad/labels/Customizer","name":"Customizer","color":"c5def5","default":false},{"id":535540510,"node_id":"MDU6TGFiZWw1MzU1NDA1MTA=","url":"https://api.github.com/repos/openscad/openscad/labels/Work%20In%20Progress","name":"Work In Progress","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-07T18:28:44Z","updated_at":"2018-09-08T06:08:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openscad/openscad/pulls/2479","html_url":"https://github.com/openscad/openscad/pull/2479","diff_url":"https://github.com/openscad/openscad/pull/2479.diff","patch_url":"https://github.com/openscad/openscad/pull/2479.patch"},"body":"   * adding a \"design default values\" parameter set. \r\n   * Always reset to the \"design default values\" before applying any preset.\r\n      -> this should prevent various issues like variables from one parameter set being transferred to an other parameter set that those not have the specific parameter has not set."},"comment":{"url":"https://api.github.com/repos/openscad/openscad/issues/comments/419616488","html_url":"https://github.com/openscad/openscad/pull/2479#issuecomment-419616488","issue_url":"https://api.github.com/repos/openscad/openscad/issues/2479","id":419616488,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTYxNjQ4OA==","user":{"login":"MichaelPFrey","id":24962768,"node_id":"MDQ6VXNlcjI0OTYyNzY4","avatar_url":"https://avatars2.githubusercontent.com/u/24962768?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelPFrey","html_url":"https://github.com/MichaelPFrey","followers_url":"https://api.github.com/users/MichaelPFrey/followers","following_url":"https://api.github.com/users/MichaelPFrey/following{/other_user}","gists_url":"https://api.github.com/users/MichaelPFrey/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelPFrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelPFrey/subscriptions","organizations_url":"https://api.github.com/users/MichaelPFrey/orgs","repos_url":"https://api.github.com/users/MichaelPFrey/repos","events_url":"https://api.github.com/users/MichaelPFrey/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelPFrey/received_events","type":"User","site_admin":false},"created_at":"2018-09-08T06:08:22Z","updated_at":"2018-09-08T06:08:22Z","author_association":"CONTRIBUTOR","body":" MichaelAtOz:\r\n> Is the default set something that needs to be saved to work?\r\n\r\nIt does not need to be saved.\r\nIt is just always there on the top of the list of presets [in the List index 0].\r\n\r\nThe implementation is simple: Set all entries to the default value, then apply the selected preset.\r\n\r\n\"design default values\" [in the List index 0] (feel free to suggest a better name) is not a real preset.\r\nSo, it sets all entries to the default value, sees that it is preset index 0 and those nothing.\r\n\r\nIt pretty much behaves just like an other preset.\r\n\r\nThere are a few quirks with this implantation:\r\n   * Changes to the scad source code apply to the \"design default values\" only after \"Preview\"\r\n      * upps... testing that, I realize that it crashes when I change the scad source file\r\n   * the \"reset\" button does not work for \"design default values\"  yet\r\n\r\nAnd when I am already on it:\r\n   * the \"reset\" button should have a tool tip explaining that it \"resets the currently selected preset\"\r\n   * at a few comments to explain what each method does (the naming is getting confusing)\r\n\r\nwell, back to work"}}
{"actor":{"display_login":"MichaelPFrey"}}