{"action":"created","issue":{"url":"https://api.github.com/repos/googlei18n/fontmake/issues/445","repository_url":"https://api.github.com/repos/googlei18n/fontmake","labels_url":"https://api.github.com/repos/googlei18n/fontmake/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/googlei18n/fontmake/issues/445/comments","events_url":"https://api.github.com/repos/googlei18n/fontmake/issues/445/events","html_url":"https://github.com/googlei18n/fontmake/issues/445","id":332488787,"node_id":"MDU6SXNzdWUzMzI0ODg3ODc=","number":445,"title":"fontmake fails compiling FiraCode","user":{"login":"jamesgk","id":988758,"node_id":"MDQ6VXNlcjk4ODc1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/988758?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesgk","html_url":"https://github.com/jamesgk","followers_url":"https://api.github.com/users/jamesgk/followers","following_url":"https://api.github.com/users/jamesgk/following{/other_user}","gists_url":"https://api.github.com/users/jamesgk/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesgk/subscriptions","organizations_url":"https://api.github.com/users/jamesgk/orgs","repos_url":"https://api.github.com/users/jamesgk/repos","events_url":"https://api.github.com/users/jamesgk/events{/privacy}","received_events_url":"https://api.github.com/users/jamesgk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-14T17:07:33Z","updated_at":"2018-09-16T18:52:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900777.\r\n\r\nWhen compiling https://github.com/tonsky/FiraCode, the following error occurs:\r\n\r\n```\r\n$ fontmake -g FiraCode.glyphs\r\nINFO:fontmake.font_project:Building master UFOs and designspace from Glyphs source\r\nINFO:glyphsLib.parser:Parsing .glyphs file\r\nINFO:glyphsLib:Loading to UFOs\r\nINFO:glyphsLib.util:Writing master_ufo/FiraCode-Regular.ufo\r\nINFO:glyphsLib.util:Writing master_ufo/FiraCode-Bold.ufo\r\nINFO:fontmake.font_project:Building OTFs\r\nINFO:fontmake.font_project:Decomposing glyphs for FiraCode-Regular\r\nINFO:fontmake.font_project:Decomposing glyphs for FiraCode-Bold\r\nINFO:fontmake.font_project:Removing overlaps for FiraCode-Regular\r\nINFO:fontmake.font_project:Removing overlaps for FiraCode-Bold\r\nINFO:fontmake.font_project:Saving OTF for FiraCode-Regular\r\nWARNING:ufo2ft.outlineCompiler:The copyright was normalized for storage in the CFF table and consequently some characters were dropped: 'Copyright Copyright 2015 by Nikita Prokopov'\r\nTraceback (most recent call last):\r\n  File \"/usr/bin/fontmake\", line 11, in <module>\r\n    load_entry_point('fontmake==1.4.0', 'console_scripts', 'fontmake')()\r\n...\r\n  File \"/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py\", line 458, in <listcomp>\r\n    return [l.build() for l in lookups]\r\n  File \"/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py\", line 1168, in build\r\n    self.setBacktrackCoverage_(prefix, st)\r\n  File \"/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py\", line 1088, in setBacktrackCoverage_\r\n    coverage = otl.buildCoverage(p, self.glyphMap)\r\n  File \"/usr/lib/python3/dist-packages/fontTools/otlLib/builder.py\", line 11, in buildCoverage\r\n    self.glyphs = sorted(glyphs, key=glyphMap.__getitem__)\r\nKeyError: ''\r\n```\r\n\r\nI dug into this a bit and I believe fontmake is tripping up on this feature source:\r\n\r\n```\r\nlookup brace_period {\r\n  ignore sub braceleft \\\\period' \\\\period;\r\n  ignore sub \\\\period \\\\period' braceright;\r\n  sub braceleft \\\\period' by \\\\bullet;\r\n  sub \\\\period' braceright by \\\\bullet;\r\n} brace_period;\r\n```\r\n\r\nWhich is found in the Glyphs source. Is this valid OT feature syntax? Should these double backslashes be ignored?"},"comment":{"url":"https://api.github.com/repos/googlei18n/fontmake/issues/comments/421812434","html_url":"https://github.com/googlei18n/fontmake/issues/445#issuecomment-421812434","issue_url":"https://api.github.com/repos/googlei18n/fontmake/issues/445","id":421812434,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTgxMjQzNA==","user":{"login":"fabiangreffrath","id":6449237,"node_id":"MDQ6VXNlcjY0NDkyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6449237?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiangreffrath","html_url":"https://github.com/fabiangreffrath","followers_url":"https://api.github.com/users/fabiangreffrath/followers","following_url":"https://api.github.com/users/fabiangreffrath/following{/other_user}","gists_url":"https://api.github.com/users/fabiangreffrath/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiangreffrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiangreffrath/subscriptions","organizations_url":"https://api.github.com/users/fabiangreffrath/orgs","repos_url":"https://api.github.com/users/fabiangreffrath/repos","events_url":"https://api.github.com/users/fabiangreffrath/events{/privacy}","received_events_url":"https://api.github.com/users/fabiangreffrath/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T18:52:03Z","updated_at":"2018-09-16T18:52:03Z","author_association":"NONE","body":"Great, thanks!\r\n"}}
{"actor":{"display_login":"fabiangreffrath"}}