{"action":"created","issue":{"url":"https://api.github.com/repos/cmcaine/tridactyl/issues/326","repository_url":"https://api.github.com/repos/cmcaine/tridactyl","labels_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/326/comments","events_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/326/events","html_url":"https://github.com/cmcaine/tridactyl/pull/326","id":302036737,"number":326,"title":"Fix #266","user":{"login":"glacambre","id":11534587,"avatar_url":"https://avatars2.githubusercontent.com/u/11534587?v=4","gravatar_id":"","url":"https://api.github.com/users/glacambre","html_url":"https://github.com/glacambre","followers_url":"https://api.github.com/users/glacambre/followers","following_url":"https://api.github.com/users/glacambre/following{/other_user}","gists_url":"https://api.github.com/users/glacambre/gists{/gist_id}","starred_url":"https://api.github.com/users/glacambre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glacambre/subscriptions","organizations_url":"https://api.github.com/users/glacambre/orgs","repos_url":"https://api.github.com/users/glacambre/repos","events_url":"https://api.github.com/users/glacambre/events{/privacy}","received_events_url":"https://api.github.com/users/glacambre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-03T22:11:14Z","updated_at":"2018-03-05T18:22:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cmcaine/tridactyl/pulls/326","html_url":"https://github.com/cmcaine/tridactyl/pull/326","diff_url":"https://github.com/cmcaine/tridactyl/pull/326.diff","patch_url":"https://github.com/cmcaine/tridactyl/pull/326.patch"},"body":"This fixes https://github.com/cmcaine/tridactyl/issues/266\r\nThis is done by hijacking the page's `HTMLElement.prototype.focus()` function. I am not very satisfied with this solution but it's the only way I found to reliably prevent autofocus, merely using event listeners for focus/focusin events didn't cut it.\r\n\r\nWe already had a whole discussion about hijacking functions which can be found here: https://github.com/cmcaine/tridactyl/pull/225 . The gist of it is that security currently isn't negatively impacted by hijacking functions, although this might not be true once WebComponents are implemented, hence we need to follow their implementation in Firefox closely and re-evaluate the situation once it lands in Firefox Nightly.\r\n"},"comment":{"url":"https://api.github.com/repos/cmcaine/tridactyl/issues/comments/370514021","html_url":"https://github.com/cmcaine/tridactyl/pull/326#issuecomment-370514021","issue_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/326","id":370514021,"user":{"login":"glacambre","id":11534587,"avatar_url":"https://avatars2.githubusercontent.com/u/11534587?v=4","gravatar_id":"","url":"https://api.github.com/users/glacambre","html_url":"https://github.com/glacambre","followers_url":"https://api.github.com/users/glacambre/followers","following_url":"https://api.github.com/users/glacambre/following{/other_user}","gists_url":"https://api.github.com/users/glacambre/gists{/gist_id}","starred_url":"https://api.github.com/users/glacambre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glacambre/subscriptions","organizations_url":"https://api.github.com/users/glacambre/orgs","repos_url":"https://api.github.com/users/glacambre/repos","events_url":"https://api.github.com/users/glacambre/events{/privacy}","received_events_url":"https://api.github.com/users/glacambre/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T18:22:27Z","updated_at":"2018-03-05T18:22:27Z","author_association":"CONTRIBUTOR","body":"I implemented the two changes you suggested. Thank you for reviewing my code! :)"}}
{"actor":{"display_login":"glacambre"}}