{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/181915278","pull_request_review_id":112624020,"id":181915278,"diff_hunk":"@@ -175,13 +161,29 @@ - (void)viewWillAppear:(BOOL)animated {\n     // We need to make sure the table is refreshed\n     // and the size updated when we appear because\n     // a new host could have been added by the user.\n-    \n+    [self setupBrandingForNavBar];\n     [self.tableView reloadData];\n     [self resizeContentForPopover];\n     // style navigiation bar\n     [super viewWillAppear:animated];\n }\n \n+- (void)setupBrandingForNavBar {\n+    [self.navigationController.navigationBar setTranslucent:false];","path":"libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Login/LoginHost/SFSDKLoginHostListViewController.m","position":34,"original_position":34,"commit_id":"be83e258fe0feb76c72a37a092ead81ba3114b5a","original_commit_id":"be83e258fe0feb76c72a37a092ead81ba3114b5a","user":{"login":"bhariharan","id":1820287,"avatar_url":"https://avatars1.githubusercontent.com/u/1820287?v=4","gravatar_id":"","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"body":"Why are we setting translucent to false?","created_at":"2018-04-16T23:34:02Z","updated_at":"2018-04-16T23:34:02Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2496#discussion_r181915278","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/181915278"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2496#discussion_r181915278"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496","id":182010957,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2496","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2496.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2496.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2496","number":2496,"state":"open","locked":false,"title":"Fix login host list nav bar color issue","user":{"login":"harry528tt","id":6765813,"avatar_url":"https://avatars1.githubusercontent.com/u/6765813?v=4","gravatar_id":"","url":"https://api.github.com/users/harry528tt","html_url":"https://github.com/harry528tt","followers_url":"https://api.github.com/users/harry528tt/followers","following_url":"https://api.github.com/users/harry528tt/following{/other_user}","gists_url":"https://api.github.com/users/harry528tt/gists{/gist_id}","starred_url":"https://api.github.com/users/harry528tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harry528tt/subscriptions","organizations_url":"https://api.github.com/users/harry528tt/orgs","repos_url":"https://api.github.com/users/harry528tt/repos","events_url":"https://api.github.com/users/harry528tt/events{/privacy}","received_events_url":"https://api.github.com/users/harry528tt/received_events","type":"User","site_admin":false},"body":"@trooper2013 @bhariharan \r\nWe've seen an branding issue happened on the \"Choose Connection\" page. \r\nAfter looking into it, I found the issue can be solved by moving the setting up branding part from viewDidLoad() into viewWillAppear().","created_at":"2018-04-16T23:03:09Z","updated_at":"2018-04-16T23:34:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d92b6e80830d7bba7ab5a6ec9c47282906fafe5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2496/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/be83e258fe0feb76c72a37a092ead81ba3114b5a","head":{"label":"harry528tt:dev-upstream","ref":"dev-upstream","sha":"be83e258fe0feb76c72a37a092ead81ba3114b5a","user":{"login":"harry528tt","id":6765813,"avatar_url":"https://avatars1.githubusercontent.com/u/6765813?v=4","gravatar_id":"","url":"https://api.github.com/users/harry528tt","html_url":"https://github.com/harry528tt","followers_url":"https://api.github.com/users/harry528tt/followers","following_url":"https://api.github.com/users/harry528tt/following{/other_user}","gists_url":"https://api.github.com/users/harry528tt/gists{/gist_id}","starred_url":"https://api.github.com/users/harry528tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harry528tt/subscriptions","organizations_url":"https://api.github.com/users/harry528tt/orgs","repos_url":"https://api.github.com/users/harry528tt/repos","events_url":"https://api.github.com/users/harry528tt/events{/privacy}","received_events_url":"https://api.github.com/users/harry528tt/received_events","type":"User","site_admin":false},"repo":{"id":96368271,"name":"SalesforceMobileSDK-iOS","full_name":"harry528tt/SalesforceMobileSDK-iOS","owner":{"login":"harry528tt","id":6765813,"avatar_url":"https://avatars1.githubusercontent.com/u/6765813?v=4","gravatar_id":"","url":"https://api.github.com/users/harry528tt","html_url":"https://github.com/harry528tt","followers_url":"https://api.github.com/users/harry528tt/followers","following_url":"https://api.github.com/users/harry528tt/following{/other_user}","gists_url":"https://api.github.com/users/harry528tt/gists{/gist_id}","starred_url":"https://api.github.com/users/harry528tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harry528tt/subscriptions","organizations_url":"https://api.github.com/users/harry528tt/orgs","repos_url":"https://api.github.com/users/harry528tt/repos","events_url":"https://api.github.com/users/harry528tt/events{/privacy}","received_events_url":"https://api.github.com/users/harry528tt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harry528tt/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":true,"url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/harry528tt/SalesforceMobileSDK-iOS/deployments","created_at":"2017-07-05T23:10:18Z","updated_at":"2017-07-05T23:10:22Z","pushed_at":"2018-04-16T23:01:04Z","git_url":"git://github.com/harry528tt/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:harry528tt/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/harry528tt/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/harry528tt/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":374997,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:dev","ref":"dev","sha":"d242959446d6830d73d51a3a0b7ce7301e308f7d","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2338086,"name":"SalesforceMobileSDK-iOS","full_name":"forcedotcom/SalesforceMobileSDK-iOS","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/deployments","created_at":"2011-09-06T23:13:57Z","updated_at":"2018-04-06T21:24:09Z","pushed_at":"2018-04-16T23:03:10Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":388603,"stargazers_count":378,"watchers_count":378,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":309,"open_issues":15,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2496"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2496"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2496/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2496/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/be83e258fe0feb76c72a37a092ead81ba3114b5a"}},"author_association":"NONE"}}
{"actor":{"display_login":"bhariharan"}}