{"action":"created","comment":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments/214401644","pull_request_review_id":151457880,"id":214401644,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQwMTY0NA==","diff_hunk":"@@ -0,0 +1,25 @@\n+<?php\n+/**\n+ * @author Alexander Kim <alexander.k@vanillaforums.com>\n+ * @copyright 2009-2018 Vanilla Forums Inc.\n+ * @license GPLv2\n+ */\n+\n+namespace Garden;\n+\n+/**\n+ * For classes that need to cache some static values and configs.\n+ *\n+ */\n+trait TwigTrait {","path":"library/Garden/TwigTrait.php","position":14,"original_position":14,"commit_id":"ff02c1fcc76ef7766d07fa5001462b4a7488fd76","original_commit_id":"ff02c1fcc76ef7766d07fa5001462b4a7488fd76","user":{"login":"initvector","id":1390241,"node_id":"MDQ6VXNlcjEzOTAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1390241?v=4","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false},"body":"Could name of the trait and its properties be less specific to Twig? I'm not altogether opposed to hardcoding the usage of Twig in the body of these methods, but the next time Vanilla switches templating engines, it'd be nice if we we could swap out the guts of these methods without the need to also rename traits and methods for every class using this trait.","created_at":"2018-08-31T16:03:16Z","updated_at":"2018-08-31T16:03:17Z","html_url":"https://github.com/vanilla/vanilla/pull/7699#discussion_r214401644","pull_request_url":"https://api.github.com/repos/vanilla/vanilla/pulls/7699","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments/214401644"},"html":{"href":"https://github.com/vanilla/vanilla/pull/7699#discussion_r214401644"},"pull_request":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/7699"}}},"pull_request":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/7699","id":212136080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTM2MDgw","html_url":"https://github.com/vanilla/vanilla/pull/7699","diff_url":"https://github.com/vanilla/vanilla/pull/7699.diff","patch_url":"https://github.com/vanilla/vanilla/pull/7699.patch","issue_url":"https://api.github.com/repos/vanilla/vanilla/issues/7699","number":7699,"state":"open","locked":false,"title":"New base controller empty class and TwigTrait initializer","user":{"login":"alex-mtl","id":15682507,"node_id":"MDQ6VXNlcjE1NjgyNTA3","avatar_url":"https://avatars0.githubusercontent.com/u/15682507?v=4","gravatar_id":"","url":"https://api.github.com/users/alex-mtl","html_url":"https://github.com/alex-mtl","followers_url":"https://api.github.com/users/alex-mtl/followers","following_url":"https://api.github.com/users/alex-mtl/following{/other_user}","gists_url":"https://api.github.com/users/alex-mtl/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mtl/subscriptions","organizations_url":"https://api.github.com/users/alex-mtl/orgs","repos_url":"https://api.github.com/users/alex-mtl/repos","events_url":"https://api.github.com/users/alex-mtl/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mtl/received_events","type":"User","site_admin":false},"body":"Garden\\Controller and Garden\\TwigTrait are set (for Knowledgebase)\r\nFixes: #7682 ","created_at":"2018-08-30T16:18:32Z","updated_at":"2018-08-31T16:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa7e6b97be07703a42f9af8e659cedadf7c59c09","assignee":{"login":"initvector","id":1390241,"node_id":"MDQ6VXNlcjEzOTAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1390241?v=4","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false},"assignees":[{"login":"initvector","id":1390241,"node_id":"MDQ6VXNlcjEzOTAyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1390241?v=4","gravatar_id":"","url":"https://api.github.com/users/initvector","html_url":"https://github.com/initvector","followers_url":"https://api.github.com/users/initvector/followers","following_url":"https://api.github.com/users/initvector/following{/other_user}","gists_url":"https://api.github.com/users/initvector/gists{/gist_id}","starred_url":"https://api.github.com/users/initvector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initvector/subscriptions","organizations_url":"https://api.github.com/users/initvector/orgs","repos_url":"https://api.github.com/users/initvector/repos","events_url":"https://api.github.com/users/initvector/events{/privacy}","received_events_url":"https://api.github.com/users/initvector/received_events","type":"User","site_admin":false},{"login":"charrondev","id":1770056,"node_id":"MDQ6VXNlcjE3NzAwNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1770056?v=4","gravatar_id":"","url":"https://api.github.com/users/charrondev","html_url":"https://github.com/charrondev","followers_url":"https://api.github.com/users/charrondev/followers","following_url":"https://api.github.com/users/charrondev/following{/other_user}","gists_url":"https://api.github.com/users/charrondev/gists{/gist_id}","starred_url":"https://api.github.com/users/charrondev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charrondev/subscriptions","organizations_url":"https://api.github.com/users/charrondev/orgs","repos_url":"https://api.github.com/users/charrondev/repos","events_url":"https://api.github.com/users/charrondev/events{/privacy}","received_events_url":"https://api.github.com/users/charrondev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vanilla/vanilla/pulls/7699/commits","review_comments_url":"https://api.github.com/repos/vanilla/vanilla/pulls/7699/comments","review_comment_url":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vanilla/vanilla/issues/7699/comments","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/ff02c1fcc76ef7766d07fa5001462b4a7488fd76","head":{"label":"vanilla:feature/controller-7682","ref":"feature/controller-7682","sha":"ff02c1fcc76ef7766d07fa5001462b4a7488fd76","user":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"node_id":"MDEwOlJlcG9zaXRvcnkyMzIzOTA=","name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/vanilla/deployments","created_at":"2009-06-21T01:41:25Z","updated_at":"2018-08-30T20:33:50Z","pushed_at":"2018-08-31T15:37:34Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"https://open.vanillaforums.com","size":93567,"stargazers_count":1843,"watchers_count":1843,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":654,"mirror_url":null,"archived":false,"open_issues_count":644,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":654,"open_issues":644,"watchers":1843,"default_branch":"master"}},"base":{"label":"vanilla:master","ref":"master","sha":"5b9b8485babb4b6081da5f061c29e7ef627dcad6","user":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"repo":{"id":232390,"node_id":"MDEwOlJlcG9zaXRvcnkyMzIzOTA=","name":"vanilla","full_name":"vanilla/vanilla","owner":{"login":"vanilla","id":7443552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NDM1NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7443552?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla","html_url":"https://github.com/vanilla","followers_url":"https://api.github.com/users/vanilla/followers","following_url":"https://api.github.com/users/vanilla/following{/other_user}","gists_url":"https://api.github.com/users/vanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla/subscriptions","organizations_url":"https://api.github.com/users/vanilla/orgs","repos_url":"https://api.github.com/users/vanilla/repos","events_url":"https://api.github.com/users/vanilla/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vanilla/vanilla","description":"Vanilla is a powerfully simple discussion forum you can easily customize to make as unique as your community.","fork":false,"url":"https://api.github.com/repos/vanilla/vanilla","forks_url":"https://api.github.com/repos/vanilla/vanilla/forks","keys_url":"https://api.github.com/repos/vanilla/vanilla/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanilla/vanilla/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanilla/vanilla/teams","hooks_url":"https://api.github.com/repos/vanilla/vanilla/hooks","issue_events_url":"https://api.github.com/repos/vanilla/vanilla/issues/events{/number}","events_url":"https://api.github.com/repos/vanilla/vanilla/events","assignees_url":"https://api.github.com/repos/vanilla/vanilla/assignees{/user}","branches_url":"https://api.github.com/repos/vanilla/vanilla/branches{/branch}","tags_url":"https://api.github.com/repos/vanilla/vanilla/tags","blobs_url":"https://api.github.com/repos/vanilla/vanilla/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanilla/vanilla/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanilla/vanilla/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanilla/vanilla/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanilla/vanilla/statuses/{sha}","languages_url":"https://api.github.com/repos/vanilla/vanilla/languages","stargazers_url":"https://api.github.com/repos/vanilla/vanilla/stargazers","contributors_url":"https://api.github.com/repos/vanilla/vanilla/contributors","subscribers_url":"https://api.github.com/repos/vanilla/vanilla/subscribers","subscription_url":"https://api.github.com/repos/vanilla/vanilla/subscription","commits_url":"https://api.github.com/repos/vanilla/vanilla/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanilla/vanilla/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanilla/vanilla/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanilla/vanilla/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanilla/vanilla/contents/{+path}","compare_url":"https://api.github.com/repos/vanilla/vanilla/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanilla/vanilla/merges","archive_url":"https://api.github.com/repos/vanilla/vanilla/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanilla/vanilla/downloads","issues_url":"https://api.github.com/repos/vanilla/vanilla/issues{/number}","pulls_url":"https://api.github.com/repos/vanilla/vanilla/pulls{/number}","milestones_url":"https://api.github.com/repos/vanilla/vanilla/milestones{/number}","notifications_url":"https://api.github.com/repos/vanilla/vanilla/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanilla/vanilla/labels{/name}","releases_url":"https://api.github.com/repos/vanilla/vanilla/releases{/id}","deployments_url":"https://api.github.com/repos/vanilla/vanilla/deployments","created_at":"2009-06-21T01:41:25Z","updated_at":"2018-08-30T20:33:50Z","pushed_at":"2018-08-31T15:37:34Z","git_url":"git://github.com/vanilla/vanilla.git","ssh_url":"git@github.com:vanilla/vanilla.git","clone_url":"https://github.com/vanilla/vanilla.git","svn_url":"https://github.com/vanilla/vanilla","homepage":"https://open.vanillaforums.com","size":93567,"stargazers_count":1843,"watchers_count":1843,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":654,"mirror_url":null,"archived":false,"open_issues_count":644,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":654,"open_issues":644,"watchers":1843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/7699"},"html":{"href":"https://github.com/vanilla/vanilla/pull/7699"},"issue":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/7699"},"comments":{"href":"https://api.github.com/repos/vanilla/vanilla/issues/7699/comments"},"review_comments":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/7699/comments"},"review_comment":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vanilla/vanilla/pulls/7699/commits"},"statuses":{"href":"https://api.github.com/repos/vanilla/vanilla/statuses/ff02c1fcc76ef7766d07fa5001462b4a7488fd76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"initvector"}}