{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/219581633","pull_request_review_id":157799988,"id":219581633,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTU4MTYzMw==","diff_hunk":"@@ -197,10 +197,6 @@ def install_bundle(self, bundle):\n             self.msg = \"Bundle %s installed\" % bundle\n             return\n \n-        if self.rc == 18:\n-            self.msg = \"Bundle name %s is invalid\" % bundle","path":"lib/ansible/modules/packaging/os/swupd.py","position":5,"original_position":5,"commit_id":"99d4ea25056d5f2dd9c7f50a78c10c7045211242","original_commit_id":"99d4ea25056d5f2dd9c7f50a78c10c7045211242","user":{"login":"s-hertel","id":19572925,"node_id":"MDQ6VXNlcjE5NTcyOTI1","avatar_url":"https://avatars2.githubusercontent.com/u/19572925?v=4","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"body":"Was this message less accurate than the one being set now (\"Failed to install bundle %s\" % bundle) if self.rc == 18?","created_at":"2018-09-21T18:03:15Z","updated_at":"2018-09-21T18:03:15Z","html_url":"https://github.com/ansible/ansible/pull/45993#discussion_r219581633","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/45993","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/219581633"},"html":{"href":"https://github.com/ansible/ansible/pull/45993#discussion_r219581633"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/45993"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/45993","id":217350612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzUwNjEy","html_url":"https://github.com/ansible/ansible/pull/45993","diff_url":"https://github.com/ansible/ansible/pull/45993.diff","patch_url":"https://github.com/ansible/ansible/pull/45993.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/45993","number":45993,"state":"open","locked":false,"title":"swupd: fail in case of an incorrect bundle","user":{"login":"dedekind","id":885786,"node_id":"MDQ6VXNlcjg4NTc4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/885786?v=4","gravatar_id":"","url":"https://api.github.com/users/dedekind","html_url":"https://github.com/dedekind","followers_url":"https://api.github.com/users/dedekind/followers","following_url":"https://api.github.com/users/dedekind/following{/other_user}","gists_url":"https://api.github.com/users/dedekind/gists{/gist_id}","starred_url":"https://api.github.com/users/dedekind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedekind/subscriptions","organizations_url":"https://api.github.com/users/dedekind/orgs","repos_url":"https://api.github.com/users/dedekind/repos","events_url":"https://api.github.com/users/dedekind/events{/privacy}","received_events_url":"https://api.github.com/users/dedekind/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nThe ClearLinux OS uses 'swupd' package manager, which is supported by ansible's 'swupd' module.\r\nUnlike other package modules like 'yum' and 'dnf', the 'swupd' module does not fail when an non-existing module is specified.\r\n\r\nFor example:\r\n\r\npackage:\r\n  state: latest\r\n  name: xxxx\r\n\r\nWill fail for Fedora or CentOS, but will succeed for ClearLinux. This is inconsistent.\r\n\r\nThis pull request changes swupd behaviour and makes it fail when the bundle does not exist.\r\n\r\n##### ISSUE TYPE\r\n- Bugfix Pull Request\r\n\r\nIn my opinion this a bug.\r\n\r\n##### COMPONENT NAME\r\nswupd\r\n\r\n##### ANSIBLE VERSION\r\nAll versions. I verified 2.4, 2.7, and 2.8dev (tip of devel).","created_at":"2018-09-21T17:26:13Z","updated_at":"2018-09-21T18:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a49b6bcc98ee604d64dcbd5befd663592bfd8fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":513652538,"node_id":"MDU6TGFiZWw1MTM2NTI1Mzg=","url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":503572087,"node_id":"MDU6TGFiZWw1MDM1NzIwODc=","url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":970086458,"node_id":"MDU6TGFiZWw5NzAwODY0NTg=","url":"https://api.github.com/repos/ansible/ansible/labels/small_patch","name":"small_patch","color":"ededed","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/45993/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/45993/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/45993/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/99d4ea25056d5f2dd9c7f50a78c10c7045211242","head":{"label":"dedekind:swupd_fail_on_bad_bundle_name","ref":"swupd_fail_on_bad_bundle_name","sha":"99d4ea25056d5f2dd9c7f50a78c10c7045211242","user":{"login":"dedekind","id":885786,"node_id":"MDQ6VXNlcjg4NTc4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/885786?v=4","gravatar_id":"","url":"https://api.github.com/users/dedekind","html_url":"https://github.com/dedekind","followers_url":"https://api.github.com/users/dedekind/followers","following_url":"https://api.github.com/users/dedekind/following{/other_user}","gists_url":"https://api.github.com/users/dedekind/gists{/gist_id}","starred_url":"https://api.github.com/users/dedekind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedekind/subscriptions","organizations_url":"https://api.github.com/users/dedekind/orgs","repos_url":"https://api.github.com/users/dedekind/repos","events_url":"https://api.github.com/users/dedekind/events{/privacy}","received_events_url":"https://api.github.com/users/dedekind/received_events","type":"User","site_admin":false},"repo":{"id":149793544,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk3OTM1NDQ=","name":"ansible","full_name":"dedekind/ansible","private":false,"owner":{"login":"dedekind","id":885786,"node_id":"MDQ6VXNlcjg4NTc4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/885786?v=4","gravatar_id":"","url":"https://api.github.com/users/dedekind","html_url":"https://github.com/dedekind","followers_url":"https://api.github.com/users/dedekind/followers","following_url":"https://api.github.com/users/dedekind/following{/other_user}","gists_url":"https://api.github.com/users/dedekind/gists{/gist_id}","starred_url":"https://api.github.com/users/dedekind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedekind/subscriptions","organizations_url":"https://api.github.com/users/dedekind/orgs","repos_url":"https://api.github.com/users/dedekind/repos","events_url":"https://api.github.com/users/dedekind/events{/privacy}","received_events_url":"https://api.github.com/users/dedekind/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dedekind/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":true,"url":"https://api.github.com/repos/dedekind/ansible","forks_url":"https://api.github.com/repos/dedekind/ansible/forks","keys_url":"https://api.github.com/repos/dedekind/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedekind/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedekind/ansible/teams","hooks_url":"https://api.github.com/repos/dedekind/ansible/hooks","issue_events_url":"https://api.github.com/repos/dedekind/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/dedekind/ansible/events","assignees_url":"https://api.github.com/repos/dedekind/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/dedekind/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/dedekind/ansible/tags","blobs_url":"https://api.github.com/repos/dedekind/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedekind/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedekind/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedekind/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedekind/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/dedekind/ansible/languages","stargazers_url":"https://api.github.com/repos/dedekind/ansible/stargazers","contributors_url":"https://api.github.com/repos/dedekind/ansible/contributors","subscribers_url":"https://api.github.com/repos/dedekind/ansible/subscribers","subscription_url":"https://api.github.com/repos/dedekind/ansible/subscription","commits_url":"https://api.github.com/repos/dedekind/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedekind/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedekind/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedekind/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedekind/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/dedekind/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedekind/ansible/merges","archive_url":"https://api.github.com/repos/dedekind/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedekind/ansible/downloads","issues_url":"https://api.github.com/repos/dedekind/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/dedekind/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/dedekind/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/dedekind/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedekind/ansible/labels{/name}","releases_url":"https://api.github.com/repos/dedekind/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/dedekind/ansible/deployments","created_at":"2018-09-21T17:05:46Z","updated_at":"2018-09-21T17:06:20Z","pushed_at":"2018-09-21T17:19:58Z","git_url":"git://github.com/dedekind/ansible.git","ssh_url":"git@github.com:dedekind/ansible.git","clone_url":"https://github.com/dedekind/ansible.git","svn_url":"https://github.com/dedekind/ansible","homepage":"https://www.ansible.com/","size":141493,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"d3d1ff799022e65fd6df28925a7b3194efcf0d91","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-09-21T16:54:23Z","pushed_at":"2018-09-21T17:47:26Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":141493,"stargazers_count":32663,"watchers_count":32663,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12869,"mirror_url":null,"archived":false,"open_issues_count":5417,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":12869,"open_issues":5417,"watchers":32663,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/45993"},"html":{"href":"https://github.com/ansible/ansible/pull/45993"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/45993"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/45993/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/45993/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/45993/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/99d4ea25056d5f2dd9c7f50a78c10c7045211242"}},"author_association":"NONE"}}
{"actor":{"display_login":"s-hertel"}}