{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/171230908","pull_request_review_id":100045647,"id":171230908,"diff_hunk":"@@ -369,6 +412,82 @@\n     </variablelist>\n   </refsect1>\n \n+  <refsect1>\n+    <title>Compatibility with <citerefentry><refentrytitle>resolvconf</refentrytitle><manvolnum>8</manvolnum></citerefentry></title>\n+\n+    <para><command>systemd-resolve</command> is a multi-call binary. When invoked as <literal>resolvconf</literal>\n+    (generally achieved by means of a symbolic link of this name to the <command>systemd-resolve</command> binary) it\n+    is run in a limited <citerefentry><refentrytitle>resolvconf</refentrytitle><manvolnum>8</manvolnum></citerefentry>\n+    compatibility mode. It accepts mostly the same arguments and pushes all data into\n+    <citerefentry><refentrytitle>systemd-resolved.service</refentrytitle><manvolnum>8</manvolnum></citerefentry>,\n+    similar to how <option>--set-dns=</option> and <option>--set-domain=</option> operate. Note that\n+    <command>systemd-resolved.service</command> is the only supported backend, which is different from other\n+    implementations of this command. Note that not all operations supported by other implementations are supported\n+    natively. Specifically:</para>\n+\n+    <variablelist>\n+      <varlistentry>\n+        <term><option>-a</option></term>\n+        <listitem><para>Registers per-interface DNS configuration data with\n+        <command>systemd-resolved</command>. Expects a network interface name as only command line argument. Reads\n+        <citerefentry><refentrytitle>resolv.conf</refentrytitle><manvolnum>5</manvolnum></citerefentry> compatible DNS\n+        configuration data from its standard input. Relevant fields are <literal>nameserver</literal> and\n+        <literal>domain</literal>/<literal>search</literal>. This command is mostly identical to invoking\n+        <command>systemd-resolve</command> with a combination of <option>--set-dns=</option> and\n+        <option>--set-domain=</option>.</para></listitem>\n+      </varlistentry>\n+\n+      <varlistentry>\n+        <term><option>-d</option></term>\n+        <listitem><para>Unregisters per-interface DNS configuration data with <command>systemd-resolved</command>. This\n+        command is mostly identical to invoking <command>systemd-resolve</command> with\n+        <option>--revert</option>.</para></listitem>\n+      </varlistentry>\n+\n+      <varlistentry>\n+        <term><option>-f</option></term>\n+\n+        <listitem><para>When specified <option>-a</option> and <option>-d</option> will not complain about missing\n+        network interfaces and will silently execute no operation in that case.</para></listitem>\n+      </varlistentry>\n+\n+      <varlistentry>\n+        <term><option>-x</option></term>\n+\n+        <listitem><para>This switch for \"exclusive\" operation is supported only partially. It is mapped to an\n+        additional configured search domain of <literal>~.</literal> — i.e. ensures that DNS traffic is preferably\n+        routed to the DNS servers on this interface, unless there are other, more specific domains configured on other\n+        interfaces.</para></listitem>\n+      </varlistentry>\n+\n+      <varlistentry>\n+        <term><option>-m</option></term>\n+        <term><option>-p</option></term>\n+\n+        <listitem><para>These switches are not supported and are silently ignored.</para></listitem>\n+      </varlistentry>\n+\n+      <varlistentry>\n+        <term><option>-u</option></term>\n+        <term><option>-I</option></term>\n+        <term><option>-i</option></term>\n+        <term><option>-l</option></term>","path":"man/systemd-resolve.xml","position":122,"original_position":122,"commit_id":"1c359de5828a3b34243abb296ea8bfaac5d9ff79","original_commit_id":"1c359de5828a3b34243abb296ea8bfaac5d9ff79","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"I think providing the API for 3rd party tools to hook into is priority, and I figure that's mostly -a and -d. OTOH -l is mostly user-facing, and we do have \"systemd-resolve --status\" covering that already (and without the skewedness because resolved's and resolvconf's concept don't match 100%). \r\n\r\nThat said, I think we can totally add support for that later on, if people want that (and apparently they do, as you have just shown). But I think it's just the cherry on top, and not not necessary to make the basic functionality work.\r\n\r\nOr to say this differently: a PR adding support for that on top of this once it's merged would be very welcome!","created_at":"2018-02-28T12:37:01Z","updated_at":"2018-02-28T12:37:01Z","html_url":"https://github.com/systemd/systemd/pull/8296#discussion_r171230908","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/8296","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/171230908"},"html":{"href":"https://github.com/systemd/systemd/pull/8296#discussion_r171230908"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8296"}},"in_reply_to_id":171215541},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/8296","id":171752373,"html_url":"https://github.com/systemd/systemd/pull/8296","diff_url":"https://github.com/systemd/systemd/pull/8296.diff","patch_url":"https://github.com/systemd/systemd/pull/8296.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8296","number":8296,"state":"open","locked":false,"title":"resolvconf(8) compat interface, reallocarray() coccinellication and other minor stuff","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-27T18:53:12Z","updated_at":"2018-02-28T12:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07601d09a972a1aa7916188759004518a29ba94c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":779041864,"url":"https://api.github.com/repos/systemd/systemd/labels/coccinelle","name":"coccinelle","color":"d84574","default":false},{"id":221925707,"url":"https://api.github.com/repos/systemd/systemd/labels/pid1","name":"pid1","color":"c7def8","default":false},{"id":219550421,"url":"https://api.github.com/repos/systemd/systemd/labels/resolve","name":"resolve","color":"d4c5f9","default":false},{"id":240084662,"url":"https://api.github.com/repos/systemd/systemd/labels/tree-wide","name":"tree-wide","color":"c7def8","default":false},{"id":396136297,"url":"https://api.github.com/repos/systemd/systemd/labels/units","name":"units","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/8296/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/8296/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8296/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/1c359de5828a3b34243abb296ea8bfaac5d9ff79","head":{"label":"poettering:resolvconf","ref":"resolvconf","sha":"1c359de5828a3b34243abb296ea8bfaac5d9ff79","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"repo":{"id":37097921,"name":"systemd","full_name":"poettering/systemd","owner":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poettering/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/poettering/systemd","forks_url":"https://api.github.com/repos/poettering/systemd/forks","keys_url":"https://api.github.com/repos/poettering/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poettering/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poettering/systemd/teams","hooks_url":"https://api.github.com/repos/poettering/systemd/hooks","issue_events_url":"https://api.github.com/repos/poettering/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/poettering/systemd/events","assignees_url":"https://api.github.com/repos/poettering/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/poettering/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/poettering/systemd/tags","blobs_url":"https://api.github.com/repos/poettering/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poettering/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poettering/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/poettering/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poettering/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/poettering/systemd/languages","stargazers_url":"https://api.github.com/repos/poettering/systemd/stargazers","contributors_url":"https://api.github.com/repos/poettering/systemd/contributors","subscribers_url":"https://api.github.com/repos/poettering/systemd/subscribers","subscription_url":"https://api.github.com/repos/poettering/systemd/subscription","commits_url":"https://api.github.com/repos/poettering/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/poettering/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/poettering/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/poettering/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/poettering/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/poettering/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poettering/systemd/merges","archive_url":"https://api.github.com/repos/poettering/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poettering/systemd/downloads","issues_url":"https://api.github.com/repos/poettering/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/poettering/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/poettering/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/poettering/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poettering/systemd/labels{/name}","releases_url":"https://api.github.com/repos/poettering/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/poettering/systemd/deployments","created_at":"2015-06-08T23:07:59Z","updated_at":"2018-02-26T00:59:57Z","pushed_at":"2018-02-28T11:11:42Z","git_url":"git://github.com/poettering/systemd.git","ssh_url":"git@github.com:poettering/systemd.git","clone_url":"https://github.com/poettering/systemd.git","svn_url":"https://github.com/poettering/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":86356,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":2,"open_issues":0,"watchers":10,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"8c89cb5a506e902d1774b288a850ac640f187148","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"🐧 ⚙️ – systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-02-27T14:29:07Z","pushed_at":"2018-02-28T12:18:15Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"https://www.freedesktop.org/wiki/Software/systemd/","size":86270,"stargazers_count":2846,"watchers_count":2846,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1159,"mirror_url":null,"archived":false,"open_issues_count":872,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1159,"open_issues":872,"watchers":2846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8296"},"html":{"href":"https://github.com/systemd/systemd/pull/8296"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/8296"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/8296/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8296/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8296/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/1c359de5828a3b34243abb296ea8bfaac5d9ff79"}},"author_association":"OWNER"}}
{"actor":{"display_login":"poettering"}}