{"action":"created","issue":{"url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9240","repository_url":"https://api.github.com/repos/cockpit-project/cockpit","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9240/labels{/name}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9240/comments","events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9240/events","html_url":"https://github.com/cockpit-project/cockpit/pull/9240","id":326524238,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTg4NjI4","number":9240,"title":"machines: Add LibvirtDBus provider","user":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"labels":[{"id":88467047,"node_id":"MDU6TGFiZWw4ODQ2NzA0Nw==","url":"https://api.github.com/repos/cockpit-project/cockpit/labels/needswork","name":"needswork","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-25T13:28:20Z","updated_at":"2018-08-31T13:28:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/9240","html_url":"https://github.com/cockpit-project/cockpit/pull/9240","diff_url":"https://github.com/cockpit-project/cockpit/pull/9240.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/9240.patch"},"body":"This patch series is rewriting https://github.com/martinpitt/cockpit/commit/329e62340ce9c2a6e8a7774b82677c8f294c503b and implements a second provider for Libvirt using Libvirt's D-Bus API (https://github.com/libvirt/libvirt-dbus/).\r\nSince there is a lot of code that can be reused from libvirt.es6 file in the new provider, all reusable functions where moved to libvirt-common.es6 file to avoid code duplicity.\r\n\r\nChecklist:\r\n\r\n- [ ] use DBus in `ovirt/provider.es6` if available (so same story as for `pkg/machines`)\r\n- [x] integration tests (refactor recent check-machines and check-ovirt tests to run ones for each of the providers)\r\n- [x] user documentation to install libvirt-dbus\r\n- [x] farther refactor to share as much as possible between libvirt.es6 and libvirt-dbus.es6\r\n- [x] adjust dependencies to `libvirt-dbus | libvirt-client` ?\r\n"},"comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments/417664100","html_url":"https://github.com/cockpit-project/cockpit/pull/9240#issuecomment-417664100","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/9240","id":417664100,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzY2NDEwMA==","user":{"login":"KKoukiou","id":14921356,"node_id":"MDQ6VXNlcjE0OTIxMzU2","avatar_url":"https://avatars1.githubusercontent.com/u/14921356?v=4","gravatar_id":"","url":"https://api.github.com/users/KKoukiou","html_url":"https://github.com/KKoukiou","followers_url":"https://api.github.com/users/KKoukiou/followers","following_url":"https://api.github.com/users/KKoukiou/following{/other_user}","gists_url":"https://api.github.com/users/KKoukiou/gists{/gist_id}","starred_url":"https://api.github.com/users/KKoukiou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KKoukiou/subscriptions","organizations_url":"https://api.github.com/users/KKoukiou/orgs","repos_url":"https://api.github.com/users/KKoukiou/repos","events_url":"https://api.github.com/users/KKoukiou/events{/privacy}","received_events_url":"https://api.github.com/users/KKoukiou/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T13:28:55Z","updated_at":"2018-08-31T13:28:55Z","author_association":"CONTRIBUTOR","body":"@martinpitt So the cockpit-machine package on debian depends on libvirt-daemon-system which internally depends on libvirt-clients. I think putting one more line there (libvirt-dbus or lbivirt-clients) will results in libvirt-dbus never being installed since libvirt-cilents dependency is brought by libvirt-daemon-system.\r\nAlso libvirt-dbus implementation still need lbivirt-clients because some operations still use virsh. aka creating VM. @mareklibra had implemented a shell script for VM creation/installation which he was called from javascript, and I didn't discard it's usage yet in libvirt-dbus implementation. So I basically need libvirt-client package in cockpit-machines libvirt-dbus implmentation as well."}}
{"actor":{"display_login":"KKoukiou"}}