{"action":"created","comment":{"url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/comments/200806223","pull_request_review_id":135197783,"id":200806223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgwNjIyMw==","diff_hunk":"@@ -0,0 +1,61 @@\n+pragma solidity ^0.4.22;\n+\n+// to enable Params passing to constructor and method\n+pragma experimental ABIEncoderV2;\n+\n+import \"@thetta/core/contracts/DaoBase.sol\";\n+import \"@thetta/core/contracts/tokens/StdDaoToken.sol\";\n+\n+import \"./DevZenDaoTestable.sol\";\n+\n+contract DevZenDaoFactoryTestable {","path":"contracts/3-DevZenDao/DevZenDaoFactoryTestable.sol","position":11,"original_position":11,"commit_id":"41aede88ff595061ca0d59cbb79cdbc1d9ee81ef","original_commit_id":"41aede88ff595061ca0d59cbb79cdbc1d9ee81ef","user":{"login":"AnthonyAkentiev","id":1623033,"node_id":"MDQ6VXNlcjE2MjMwMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1623033?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyAkentiev","html_url":"https://github.com/AnthonyAkentiev","followers_url":"https://api.github.com/users/AnthonyAkentiev/followers","following_url":"https://api.github.com/users/AnthonyAkentiev/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyAkentiev/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyAkentiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyAkentiev/subscriptions","organizations_url":"https://api.github.com/users/AnthonyAkentiev/orgs","repos_url":"https://api.github.com/users/AnthonyAkentiev/repos","events_url":"https://api.github.com/users/AnthonyAkentiev/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyAkentiev/received_events","type":"User","site_admin":false},"body":"Вот этот контракт не понял для чего.\r\nВроде бы в DevZenDaoFactory все методы были открыты свободно для всех.\r\nТо есть их можно напрямую было тестировать.\r\n\r\nДумаю, что нужно убрать DevZenDaoFactoryTestable и оставить только *DevZenFactory*","created_at":"2018-07-07T08:27:34Z","updated_at":"2018-07-07T08:29:31Z","html_url":"https://github.com/Thetta/DAO-Templates/pull/15#discussion_r200806223","pull_request_url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/comments/200806223"},"html":{"href":"https://github.com/Thetta/DAO-Templates/pull/15#discussion_r200806223"},"pull_request":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15","id":199858959,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODU4OTU5","html_url":"https://github.com/Thetta/DAO-Templates/pull/15","diff_url":"https://github.com/Thetta/DAO-Templates/pull/15.diff","patch_url":"https://github.com/Thetta/DAO-Templates/pull/15.patch","issue_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues/15","number":15,"state":"open","locked":false,"title":"#9, #10, #14","user":{"login":"ryzhak","id":6339689,"node_id":"MDQ6VXNlcjYzMzk2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/6339689?v=4","gravatar_id":"","url":"https://api.github.com/users/ryzhak","html_url":"https://github.com/ryzhak","followers_url":"https://api.github.com/users/ryzhak/followers","following_url":"https://api.github.com/users/ryzhak/following{/other_user}","gists_url":"https://api.github.com/users/ryzhak/gists{/gist_id}","starred_url":"https://api.github.com/users/ryzhak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryzhak/subscriptions","organizations_url":"https://api.github.com/users/ryzhak/orgs","repos_url":"https://api.github.com/users/ryzhak/repos","events_url":"https://api.github.com/users/ryzhak/events{/privacy}","received_events_url":"https://api.github.com/users/ryzhak/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-06T22:21:28Z","updated_at":"2018-07-07T08:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9b5b6a5f02a019c65f225c4bf27b0584d65232a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15/commits","review_comments_url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15/comments","review_comment_url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues/15/comments","statuses_url":"https://api.github.com/repos/Thetta/DAO-Templates/statuses/41aede88ff595061ca0d59cbb79cdbc1d9ee81ef","head":{"label":"Thetta:dev-ryzhak","ref":"dev-ryzhak","sha":"41aede88ff595061ca0d59cbb79cdbc1d9ee81ef","user":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"repo":{"id":138147479,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNDc0Nzk=","name":"DAO-Templates","full_name":"Thetta/DAO-Templates","owner":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Thetta/DAO-Templates","description":"DAO Templates are built on top of Thetta DAO Framework","fork":false,"url":"https://api.github.com/repos/Thetta/DAO-Templates","forks_url":"https://api.github.com/repos/Thetta/DAO-Templates/forks","keys_url":"https://api.github.com/repos/Thetta/DAO-Templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thetta/DAO-Templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thetta/DAO-Templates/teams","hooks_url":"https://api.github.com/repos/Thetta/DAO-Templates/hooks","issue_events_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues/events{/number}","events_url":"https://api.github.com/repos/Thetta/DAO-Templates/events","assignees_url":"https://api.github.com/repos/Thetta/DAO-Templates/assignees{/user}","branches_url":"https://api.github.com/repos/Thetta/DAO-Templates/branches{/branch}","tags_url":"https://api.github.com/repos/Thetta/DAO-Templates/tags","blobs_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thetta/DAO-Templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Thetta/DAO-Templates/languages","stargazers_url":"https://api.github.com/repos/Thetta/DAO-Templates/stargazers","contributors_url":"https://api.github.com/repos/Thetta/DAO-Templates/contributors","subscribers_url":"https://api.github.com/repos/Thetta/DAO-Templates/subscribers","subscription_url":"https://api.github.com/repos/Thetta/DAO-Templates/subscription","commits_url":"https://api.github.com/repos/Thetta/DAO-Templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thetta/DAO-Templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thetta/DAO-Templates/contents/{+path}","compare_url":"https://api.github.com/repos/Thetta/DAO-Templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thetta/DAO-Templates/merges","archive_url":"https://api.github.com/repos/Thetta/DAO-Templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thetta/DAO-Templates/downloads","issues_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues{/number}","pulls_url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Thetta/DAO-Templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Thetta/DAO-Templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thetta/DAO-Templates/labels{/name}","releases_url":"https://api.github.com/repos/Thetta/DAO-Templates/releases{/id}","deployments_url":"https://api.github.com/repos/Thetta/DAO-Templates/deployments","created_at":"2018-06-21T09:13:09Z","updated_at":"2018-07-06T10:08:50Z","pushed_at":"2018-07-06T22:27:10Z","git_url":"git://github.com/Thetta/DAO-Templates.git","ssh_url":"git@github.com:Thetta/DAO-Templates.git","clone_url":"https://github.com/Thetta/DAO-Templates.git","svn_url":"https://github.com/Thetta/DAO-Templates","homepage":"","size":182,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"Thetta:master","ref":"master","sha":"5594ca3e92ac8d9b8ba8ad1b4bdc574b146d0b30","user":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"repo":{"id":138147479,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNDc0Nzk=","name":"DAO-Templates","full_name":"Thetta/DAO-Templates","owner":{"login":"Thetta","id":32595561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNTk1NTYx","avatar_url":"https://avatars0.githubusercontent.com/u/32595561?v=4","gravatar_id":"","url":"https://api.github.com/users/Thetta","html_url":"https://github.com/Thetta","followers_url":"https://api.github.com/users/Thetta/followers","following_url":"https://api.github.com/users/Thetta/following{/other_user}","gists_url":"https://api.github.com/users/Thetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Thetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thetta/subscriptions","organizations_url":"https://api.github.com/users/Thetta/orgs","repos_url":"https://api.github.com/users/Thetta/repos","events_url":"https://api.github.com/users/Thetta/events{/privacy}","received_events_url":"https://api.github.com/users/Thetta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Thetta/DAO-Templates","description":"DAO Templates are built on top of Thetta DAO Framework","fork":false,"url":"https://api.github.com/repos/Thetta/DAO-Templates","forks_url":"https://api.github.com/repos/Thetta/DAO-Templates/forks","keys_url":"https://api.github.com/repos/Thetta/DAO-Templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thetta/DAO-Templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thetta/DAO-Templates/teams","hooks_url":"https://api.github.com/repos/Thetta/DAO-Templates/hooks","issue_events_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues/events{/number}","events_url":"https://api.github.com/repos/Thetta/DAO-Templates/events","assignees_url":"https://api.github.com/repos/Thetta/DAO-Templates/assignees{/user}","branches_url":"https://api.github.com/repos/Thetta/DAO-Templates/branches{/branch}","tags_url":"https://api.github.com/repos/Thetta/DAO-Templates/tags","blobs_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thetta/DAO-Templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Thetta/DAO-Templates/languages","stargazers_url":"https://api.github.com/repos/Thetta/DAO-Templates/stargazers","contributors_url":"https://api.github.com/repos/Thetta/DAO-Templates/contributors","subscribers_url":"https://api.github.com/repos/Thetta/DAO-Templates/subscribers","subscription_url":"https://api.github.com/repos/Thetta/DAO-Templates/subscription","commits_url":"https://api.github.com/repos/Thetta/DAO-Templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thetta/DAO-Templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thetta/DAO-Templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thetta/DAO-Templates/contents/{+path}","compare_url":"https://api.github.com/repos/Thetta/DAO-Templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thetta/DAO-Templates/merges","archive_url":"https://api.github.com/repos/Thetta/DAO-Templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thetta/DAO-Templates/downloads","issues_url":"https://api.github.com/repos/Thetta/DAO-Templates/issues{/number}","pulls_url":"https://api.github.com/repos/Thetta/DAO-Templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Thetta/DAO-Templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Thetta/DAO-Templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thetta/DAO-Templates/labels{/name}","releases_url":"https://api.github.com/repos/Thetta/DAO-Templates/releases{/id}","deployments_url":"https://api.github.com/repos/Thetta/DAO-Templates/deployments","created_at":"2018-06-21T09:13:09Z","updated_at":"2018-07-06T10:08:50Z","pushed_at":"2018-07-06T22:27:10Z","git_url":"git://github.com/Thetta/DAO-Templates.git","ssh_url":"git@github.com:Thetta/DAO-Templates.git","clone_url":"https://github.com/Thetta/DAO-Templates.git","svn_url":"https://github.com/Thetta/DAO-Templates","homepage":"","size":182,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15"},"html":{"href":"https://github.com/Thetta/DAO-Templates/pull/15"},"issue":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/issues/15"},"comments":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/Thetta/DAO-Templates/statuses/41aede88ff595061ca0d59cbb79cdbc1d9ee81ef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AnthonyAkentiev"}}