{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/2824","repository_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/2824/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/2824/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/2824/events","html_url":"https://github.com/rust-lang-nursery/rustfmt/issues/2824","id":338043701,"node_id":"MDU6SXNzdWUzMzgwNDM3MDE=","number":2824,"title":"cargo fmt breaks pyo3","user":{"login":"konstin","id":6826232,"node_id":"MDQ6VXNlcjY4MjYyMzI=","avatar_url":"https://avatars2.githubusercontent.com/u/6826232?v=4","gravatar_id":"","url":"https://api.github.com/users/konstin","html_url":"https://github.com/konstin","followers_url":"https://api.github.com/users/konstin/followers","following_url":"https://api.github.com/users/konstin/following{/other_user}","gists_url":"https://api.github.com/users/konstin/gists{/gist_id}","starred_url":"https://api.github.com/users/konstin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konstin/subscriptions","organizations_url":"https://api.github.com/users/konstin/orgs","repos_url":"https://api.github.com/users/konstin/repos","events_url":"https://api.github.com/users/konstin/events{/privacy}","received_events_url":"https://api.github.com/users/konstin/received_events","type":"User","site_admin":false},"labels":[{"id":184396193,"node_id":"MDU6TGFiZWwxODQzOTYxOTM=","url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-03T20:28:26Z","updated_at":"2018-07-04T09:21:28Z","closed_at":null,"author_association":"NONE","body":"rusfmt breaks [pyo3](https://github.com/pyo3/pyo3) in the sense that it doesn't build after running `cargo fmt`.\r\n\r\nReproducing:\r\n```shell\r\ngit clone https://github.com/pyo3/pyo3\r\ncd pyo3\r\ngit checkout 68c14a5707dd92ceef7619c0a5444cefcc78a0f6 # Recent, but fixed commit\r\ncargo build # Fine\r\ncargo fmt\r\ncargo build # Broken\r\n```\r\n\r\nThe last command results in a conflicting implementations error, even though only the formatting should have changed:\r\n\r\n```\r\nerror[E0119]: conflicting implementations of trait `python::IntoPyDictPointer` for type `()`:\r\n   --> src/objects/dict.rs:247:1\r\n    |\r\n247 | / impl<K, V, I> IntoPyDictPointer for I\r\n248 | | where\r\n249 | |     K: ToPyObject,\r\n250 | |     V: ToPyObject,\r\n...   |\r\n260 | |     }\r\n261 | | }\r\n    | |_^ conflicting implementation for `()`\r\n    | \r\n   ::: src/noargs.rs:61:1\r\n    |\r\n61  |   impl IntoPyDictPointer for () {\r\n    |   ----------------------------- first implementation here\r\n    |\r\n    = note: upstream crates may add new impl of trait `std::iter::Iterator` for type `()` in future versions\r\n```\r\n\r\nVersions:\r\n * `cargo fmt --version`: rustfmt 0.8.2-nightly (87edd75 2018-06-22)\r\n * `rustc --version`: rustc 1.28.0-nightly (e3bf634e0 2018-06-28)"},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/comments/402419769","html_url":"https://github.com/rust-lang-nursery/rustfmt/issues/2824#issuecomment-402419769","issue_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/2824","id":402419769,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjQxOTc2OQ==","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T09:21:28Z","updated_at":"2018-07-04T09:21:28Z","author_association":"MEMBER","body":"(Never mind my question, I have reproduced locally.)"}}
{"actor":{"display_login":"nikomatsakis"}}