{"action":"opened","number":315,"pull_request":{"url":"https://api.github.com/repos/pelias/schema/pulls/315","id":215117074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTE3MDc0","html_url":"https://github.com/pelias/schema/pull/315","diff_url":"https://github.com/pelias/schema/pull/315.diff","patch_url":"https://github.com/pelias/schema/pull/315.patch","issue_url":"https://api.github.com/repos/pelias/schema/issues/315","number":315,"state":"open","locked":false,"title":"feat(test): Use test running binary to catch errors","user":{"login":"orangejulius","id":111716,"node_id":"MDQ6VXNlcjExMTcxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/111716?v=4","gravatar_id":"","url":"https://api.github.com/users/orangejulius","html_url":"https://github.com/orangejulius","followers_url":"https://api.github.com/users/orangejulius/followers","following_url":"https://api.github.com/users/orangejulius/following{/other_user}","gists_url":"https://api.github.com/users/orangejulius/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejulius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejulius/subscriptions","organizations_url":"https://api.github.com/users/orangejulius/orgs","repos_url":"https://api.github.com/users/orangejulius/repos","events_url":"https://api.github.com/users/orangejulius/events{/privacy}","received_events_url":"https://api.github.com/users/orangejulius/received_events","type":"User","site_admin":false},"body":"The way we were running our unit tests does not catch fatal errors in the unit test run, even though they return non-zero status codes.\r\n\r\nBy using a dedicated script to run the tests, with the `pipefail` option, we can catch them.\r\n\r\nConnects https://github.com/pelias/pelias/issues/744","created_at":"2018-09-12T22:43:14Z","updated_at":"2018-09-12T22:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pelias/schema/pulls/315/commits","review_comments_url":"https://api.github.com/repos/pelias/schema/pulls/315/comments","review_comment_url":"https://api.github.com/repos/pelias/schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pelias/schema/issues/315/comments","statuses_url":"https://api.github.com/repos/pelias/schema/statuses/f06faf34fe678ffbd12debf95cb77fd8ef2d6d04","head":{"label":"pelias:safely-run-tests","ref":"safely-run-tests","sha":"f06faf34fe678ffbd12debf95cb77fd8ef2d6d04","user":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"repo":{"id":22148545,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE0ODU0NQ==","name":"schema","full_name":"pelias/schema","owner":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pelias/schema","description":"elasticsearch schema files and tooling","fork":false,"url":"https://api.github.com/repos/pelias/schema","forks_url":"https://api.github.com/repos/pelias/schema/forks","keys_url":"https://api.github.com/repos/pelias/schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelias/schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelias/schema/teams","hooks_url":"https://api.github.com/repos/pelias/schema/hooks","issue_events_url":"https://api.github.com/repos/pelias/schema/issues/events{/number}","events_url":"https://api.github.com/repos/pelias/schema/events","assignees_url":"https://api.github.com/repos/pelias/schema/assignees{/user}","branches_url":"https://api.github.com/repos/pelias/schema/branches{/branch}","tags_url":"https://api.github.com/repos/pelias/schema/tags","blobs_url":"https://api.github.com/repos/pelias/schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelias/schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelias/schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelias/schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelias/schema/statuses/{sha}","languages_url":"https://api.github.com/repos/pelias/schema/languages","stargazers_url":"https://api.github.com/repos/pelias/schema/stargazers","contributors_url":"https://api.github.com/repos/pelias/schema/contributors","subscribers_url":"https://api.github.com/repos/pelias/schema/subscribers","subscription_url":"https://api.github.com/repos/pelias/schema/subscription","commits_url":"https://api.github.com/repos/pelias/schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelias/schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelias/schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelias/schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelias/schema/contents/{+path}","compare_url":"https://api.github.com/repos/pelias/schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelias/schema/merges","archive_url":"https://api.github.com/repos/pelias/schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelias/schema/downloads","issues_url":"https://api.github.com/repos/pelias/schema/issues{/number}","pulls_url":"https://api.github.com/repos/pelias/schema/pulls{/number}","milestones_url":"https://api.github.com/repos/pelias/schema/milestones{/number}","notifications_url":"https://api.github.com/repos/pelias/schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelias/schema/labels{/name}","releases_url":"https://api.github.com/repos/pelias/schema/releases{/id}","deployments_url":"https://api.github.com/repos/pelias/schema/deployments","created_at":"2014-07-23T13:10:42Z","updated_at":"2018-09-11T23:24:59Z","pushed_at":"2018-09-12T22:24:36Z","git_url":"git://github.com/pelias/schema.git","ssh_url":"git@github.com:pelias/schema.git","clone_url":"https://github.com/pelias/schema.git","svn_url":"https://github.com/pelias/schema","homepage":null,"size":536,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":18,"watchers":19,"default_branch":"master"}},"base":{"label":"pelias:master","ref":"master","sha":"a55818e21518e69ebe8769eea830371f650c3c03","user":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"repo":{"id":22148545,"node_id":"MDEwOlJlcG9zaXRvcnkyMjE0ODU0NQ==","name":"schema","full_name":"pelias/schema","owner":{"login":"pelias","id":8240367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDAzNjc=","avatar_url":"https://avatars3.githubusercontent.com/u/8240367?v=4","gravatar_id":"","url":"https://api.github.com/users/pelias","html_url":"https://github.com/pelias","followers_url":"https://api.github.com/users/pelias/followers","following_url":"https://api.github.com/users/pelias/following{/other_user}","gists_url":"https://api.github.com/users/pelias/gists{/gist_id}","starred_url":"https://api.github.com/users/pelias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelias/subscriptions","organizations_url":"https://api.github.com/users/pelias/orgs","repos_url":"https://api.github.com/users/pelias/repos","events_url":"https://api.github.com/users/pelias/events{/privacy}","received_events_url":"https://api.github.com/users/pelias/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pelias/schema","description":"elasticsearch schema files and tooling","fork":false,"url":"https://api.github.com/repos/pelias/schema","forks_url":"https://api.github.com/repos/pelias/schema/forks","keys_url":"https://api.github.com/repos/pelias/schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelias/schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelias/schema/teams","hooks_url":"https://api.github.com/repos/pelias/schema/hooks","issue_events_url":"https://api.github.com/repos/pelias/schema/issues/events{/number}","events_url":"https://api.github.com/repos/pelias/schema/events","assignees_url":"https://api.github.com/repos/pelias/schema/assignees{/user}","branches_url":"https://api.github.com/repos/pelias/schema/branches{/branch}","tags_url":"https://api.github.com/repos/pelias/schema/tags","blobs_url":"https://api.github.com/repos/pelias/schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelias/schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelias/schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelias/schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelias/schema/statuses/{sha}","languages_url":"https://api.github.com/repos/pelias/schema/languages","stargazers_url":"https://api.github.com/repos/pelias/schema/stargazers","contributors_url":"https://api.github.com/repos/pelias/schema/contributors","subscribers_url":"https://api.github.com/repos/pelias/schema/subscribers","subscription_url":"https://api.github.com/repos/pelias/schema/subscription","commits_url":"https://api.github.com/repos/pelias/schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelias/schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelias/schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelias/schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelias/schema/contents/{+path}","compare_url":"https://api.github.com/repos/pelias/schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelias/schema/merges","archive_url":"https://api.github.com/repos/pelias/schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelias/schema/downloads","issues_url":"https://api.github.com/repos/pelias/schema/issues{/number}","pulls_url":"https://api.github.com/repos/pelias/schema/pulls{/number}","milestones_url":"https://api.github.com/repos/pelias/schema/milestones{/number}","notifications_url":"https://api.github.com/repos/pelias/schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelias/schema/labels{/name}","releases_url":"https://api.github.com/repos/pelias/schema/releases{/id}","deployments_url":"https://api.github.com/repos/pelias/schema/deployments","created_at":"2014-07-23T13:10:42Z","updated_at":"2018-09-11T23:24:59Z","pushed_at":"2018-09-12T22:24:36Z","git_url":"git://github.com/pelias/schema.git","ssh_url":"git@github.com:pelias/schema.git","clone_url":"https://github.com/pelias/schema.git","svn_url":"https://github.com/pelias/schema","homepage":null,"size":536,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":18,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pelias/schema/pulls/315"},"html":{"href":"https://github.com/pelias/schema/pull/315"},"issue":{"href":"https://api.github.com/repos/pelias/schema/issues/315"},"comments":{"href":"https://api.github.com/repos/pelias/schema/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/pelias/schema/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/pelias/schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pelias/schema/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/pelias/schema/statuses/f06faf34fe678ffbd12debf95cb77fd8ef2d6d04"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"orangejulius"}}