{"action":"closed","number":1636,"pull_request":{"url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1636","id":203850489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODUwNDg5","html_url":"https://github.com/Yoast/YoastSEO.js/pull/1636","diff_url":"https://github.com/Yoast/YoastSEO.js/pull/1636.diff","patch_url":"https://github.com/Yoast/YoastSEO.js/pull/1636.patch","issue_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1636","number":1636,"state":"closed","locked":false,"title":"Search keyphrase and synonym word forms in text","user":{"login":"nataliashitova","id":36954173,"node_id":"MDQ6VXNlcjM2OTU0MTcz","avatar_url":"https://avatars0.githubusercontent.com/u/36954173?v=4","gravatar_id":"","url":"https://api.github.com/users/nataliashitova","html_url":"https://github.com/nataliashitova","followers_url":"https://api.github.com/users/nataliashitova/followers","following_url":"https://api.github.com/users/nataliashitova/following{/other_user}","gists_url":"https://api.github.com/users/nataliashitova/gists{/gist_id}","starred_url":"https://api.github.com/users/nataliashitova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nataliashitova/subscriptions","organizations_url":"https://api.github.com/users/nataliashitova/orgs","repos_url":"https://api.github.com/users/nataliashitova/repos","events_url":"https://api.github.com/users/nataliashitova/events{/privacy}","received_events_url":"https://api.github.com/users/nataliashitova/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nThis PR can be summarized in the following changelog entry:\r\n\r\n* no user-facing changes\r\n\r\n## Relevant technical choices:\r\n\r\n* For completeness, the function returns the number of words matched, % of words from the keyphrase that matched in the text and whether keyphrase or synonym was matched in the text. It might be that later some of these can be deprecated.\r\n\r\n## Test instructions\r\n\r\nThis PR can be tested by following these steps:\r\n\r\n* Add more specs to `findKeywordFormsInStringSpec.js`\r\n\r\nFixes #1634 \r\n","created_at":"2018-07-25T14:10:29Z","updated_at":"2018-07-26T13:51:39Z","closed_at":"2018-07-26T13:51:39Z","merged_at":"2018-07-26T13:51:39Z","merge_commit_sha":"53ccc4213d0b0f19bca379253db60b29fb8bc299","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1636/commits","review_comments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1636/comments","review_comment_url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1636/comments","statuses_url":"https://api.github.com/repos/Yoast/YoastSEO.js/statuses/b86431ded6c589b42dc7958bccfed9d65a4b2cb4","head":{"label":"Yoast:stories/1634-search-keyword-forms","ref":"stories/1634-search-keyword-forms","sha":"b86431ded6c589b42dc7958bccfed9d65a4b2cb4","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":32734884,"node_id":"MDEwOlJlcG9zaXRvcnkzMjczNDg4NA==","name":"YoastSEO.js","full_name":"Yoast/YoastSEO.js","owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/YoastSEO.js","description":"Analyze content on a page and give SEO feedback as well as render a snippet preview.","fork":false,"url":"https://api.github.com/repos/Yoast/YoastSEO.js","forks_url":"https://api.github.com/repos/Yoast/YoastSEO.js/forks","keys_url":"https://api.github.com/repos/Yoast/YoastSEO.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/YoastSEO.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/YoastSEO.js/teams","hooks_url":"https://api.github.com/repos/Yoast/YoastSEO.js/hooks","issue_events_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/YoastSEO.js/events","assignees_url":"https://api.github.com/repos/Yoast/YoastSEO.js/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/YoastSEO.js/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/YoastSEO.js/tags","blobs_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/YoastSEO.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/YoastSEO.js/languages","stargazers_url":"https://api.github.com/repos/Yoast/YoastSEO.js/stargazers","contributors_url":"https://api.github.com/repos/Yoast/YoastSEO.js/contributors","subscribers_url":"https://api.github.com/repos/Yoast/YoastSEO.js/subscribers","subscription_url":"https://api.github.com/repos/Yoast/YoastSEO.js/subscription","commits_url":"https://api.github.com/repos/Yoast/YoastSEO.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/YoastSEO.js/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/YoastSEO.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/YoastSEO.js/merges","archive_url":"https://api.github.com/repos/Yoast/YoastSEO.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/YoastSEO.js/downloads","issues_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/YoastSEO.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/YoastSEO.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/YoastSEO.js/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/YoastSEO.js/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/deployments","created_at":"2015-03-23T13:50:16Z","updated_at":"2018-07-24T12:24:30Z","pushed_at":"2018-07-26T13:51:39Z","git_url":"git://github.com/Yoast/YoastSEO.js.git","ssh_url":"git@github.com:Yoast/YoastSEO.js.git","clone_url":"https://github.com/Yoast/YoastSEO.js.git","svn_url":"https://github.com/Yoast/YoastSEO.js","homepage":"","size":16174,"stargazers_count":228,"watchers_count":228,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":59,"open_issues":329,"watchers":228,"default_branch":"develop"}},"base":{"label":"Yoast:feature/morphology","ref":"feature/morphology","sha":"ba9425fe8ebbf36836b5e9ead2d1f900042447e2","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":32734884,"node_id":"MDEwOlJlcG9zaXRvcnkzMjczNDg4NA==","name":"YoastSEO.js","full_name":"Yoast/YoastSEO.js","owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/YoastSEO.js","description":"Analyze content on a page and give SEO feedback as well as render a snippet preview.","fork":false,"url":"https://api.github.com/repos/Yoast/YoastSEO.js","forks_url":"https://api.github.com/repos/Yoast/YoastSEO.js/forks","keys_url":"https://api.github.com/repos/Yoast/YoastSEO.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/YoastSEO.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/YoastSEO.js/teams","hooks_url":"https://api.github.com/repos/Yoast/YoastSEO.js/hooks","issue_events_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/YoastSEO.js/events","assignees_url":"https://api.github.com/repos/Yoast/YoastSEO.js/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/YoastSEO.js/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/YoastSEO.js/tags","blobs_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/YoastSEO.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/YoastSEO.js/languages","stargazers_url":"https://api.github.com/repos/Yoast/YoastSEO.js/stargazers","contributors_url":"https://api.github.com/repos/Yoast/YoastSEO.js/contributors","subscribers_url":"https://api.github.com/repos/Yoast/YoastSEO.js/subscribers","subscription_url":"https://api.github.com/repos/Yoast/YoastSEO.js/subscription","commits_url":"https://api.github.com/repos/Yoast/YoastSEO.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/YoastSEO.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/YoastSEO.js/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/YoastSEO.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/YoastSEO.js/merges","archive_url":"https://api.github.com/repos/Yoast/YoastSEO.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/YoastSEO.js/downloads","issues_url":"https://api.github.com/repos/Yoast/YoastSEO.js/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/YoastSEO.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/YoastSEO.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/YoastSEO.js/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/YoastSEO.js/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/YoastSEO.js/deployments","created_at":"2015-03-23T13:50:16Z","updated_at":"2018-07-24T12:24:30Z","pushed_at":"2018-07-26T13:51:39Z","git_url":"git://github.com/Yoast/YoastSEO.js.git","ssh_url":"git@github.com:Yoast/YoastSEO.js.git","clone_url":"https://github.com/Yoast/YoastSEO.js.git","svn_url":"https://github.com/Yoast/YoastSEO.js","homepage":"","size":16174,"stargazers_count":228,"watchers_count":228,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":329,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":59,"open_issues":329,"watchers":228,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1636"},"html":{"href":"https://github.com/Yoast/YoastSEO.js/pull/1636"},"issue":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1636"},"comments":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/issues/1636/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1636/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/pulls/1636/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/YoastSEO.js/statuses/b86431ded6c589b42dc7958bccfed9d65a4b2cb4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"manuelaugustin","id":27805437,"node_id":"MDQ6VXNlcjI3ODA1NDM3","avatar_url":"https://avatars1.githubusercontent.com/u/27805437?v=4","gravatar_id":"","url":"https://api.github.com/users/manuelaugustin","html_url":"https://github.com/manuelaugustin","followers_url":"https://api.github.com/users/manuelaugustin/followers","following_url":"https://api.github.com/users/manuelaugustin/following{/other_user}","gists_url":"https://api.github.com/users/manuelaugustin/gists{/gist_id}","starred_url":"https://api.github.com/users/manuelaugustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuelaugustin/subscriptions","organizations_url":"https://api.github.com/users/manuelaugustin/orgs","repos_url":"https://api.github.com/users/manuelaugustin/repos","events_url":"https://api.github.com/users/manuelaugustin/events{/privacy}","received_events_url":"https://api.github.com/users/manuelaugustin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":368,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"manuelaugustin"}}