{"action":"created","comment":{"url":"https://api.github.com/repos/jetstack/tarmak/pulls/comments/228245636","pull_request_review_id":168464935,"id":228245636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI0NTYzNg==","diff_hunk":"@@ -39,11 +39,15 @@\n     require => Exec[\"${service_name}-systemctl-daemon-reload\"],\n   }\n \n-  $trigger_cmd = \"systemctl start ${service_name}.service\"\n+  if $run_exec {","path":"puppet/modules/vault_client/manifests/cert_service.pp","position":19,"original_position":19,"commit_id":"01851c25fcaa6996ccdaf8f1ada31ba480c61195","original_commit_id":"01851c25fcaa6996ccdaf8f1ada31ba480c61195","user":{"login":"JoshVanL","id":15893072,"node_id":"MDQ6VXNlcjE1ODkzMDcy","avatar_url":"https://avatars1.githubusercontent.com/u/15893072?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshVanL","html_url":"https://github.com/JoshVanL","followers_url":"https://api.github.com/users/JoshVanL/followers","following_url":"https://api.github.com/users/JoshVanL/following{/other_user}","gists_url":"https://api.github.com/users/JoshVanL/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshVanL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshVanL/subscriptions","organizations_url":"https://api.github.com/users/JoshVanL/orgs","repos_url":"https://api.github.com/users/JoshVanL/repos","events_url":"https://api.github.com/users/JoshVanL/events{/privacy}","received_events_url":"https://api.github.com/users/JoshVanL/received_events","type":"User","site_admin":false},"body":"Can we put the exec inside of the if instead of running a pointless /bin/true ?\r\n\r\n","created_at":"2018-10-25T16:28:56Z","updated_at":"2018-10-25T16:52:17Z","html_url":"https://github.com/jetstack/tarmak/pull/390#discussion_r228245636","pull_request_url":"https://api.github.com/repos/jetstack/tarmak/pulls/390","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/comments/228245636"},"html":{"href":"https://github.com/jetstack/tarmak/pull/390#discussion_r228245636"},"pull_request":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/jetstack/tarmak/pulls/390","id":205074679,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDc0Njc5","html_url":"https://github.com/jetstack/tarmak/pull/390","diff_url":"https://github.com/jetstack/tarmak/pull/390.diff","patch_url":"https://github.com/jetstack/tarmak/pull/390.patch","issue_url":"https://api.github.com/repos/jetstack/tarmak/issues/390","number":390,"state":"open","locked":false,"title":"Add separate Packer builder for Kubernetes workers","user":{"login":"MattiasGees","id":2216724,"node_id":"MDQ6VXNlcjIyMTY3MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2216724?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasGees","html_url":"https://github.com/MattiasGees","followers_url":"https://api.github.com/users/MattiasGees/followers","following_url":"https://api.github.com/users/MattiasGees/following{/other_user}","gists_url":"https://api.github.com/users/MattiasGees/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasGees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasGees/subscriptions","organizations_url":"https://api.github.com/users/MattiasGees/orgs","repos_url":"https://api.github.com/users/MattiasGees/repos","events_url":"https://api.github.com/users/MattiasGees/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasGees/received_events","type":"User","site_admin":false},"body":"\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nWe want to decrease the provision time when a new Kubernetes worker nodes comes up. We do this by creating a separate Packer build for the Kubernetes workers. This will run the Puppet code during the Packer run and install and configure almost everything. On initial boot we will only need to run Puppet to configure the cluster specific settings.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #65 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nBuild Kubernetes workers AMIs\r\n```\r\n","created_at":"2018-07-31T11:02:50Z","updated_at":"2018-10-25T16:52:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4295f87f144325a241238fb15bc9184dea106ca2","assignee":{"login":"JoshVanL","id":15893072,"node_id":"MDQ6VXNlcjE1ODkzMDcy","avatar_url":"https://avatars1.githubusercontent.com/u/15893072?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshVanL","html_url":"https://github.com/JoshVanL","followers_url":"https://api.github.com/users/JoshVanL/followers","following_url":"https://api.github.com/users/JoshVanL/following{/other_user}","gists_url":"https://api.github.com/users/JoshVanL/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshVanL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshVanL/subscriptions","organizations_url":"https://api.github.com/users/JoshVanL/orgs","repos_url":"https://api.github.com/users/JoshVanL/repos","events_url":"https://api.github.com/users/JoshVanL/events{/privacy}","received_events_url":"https://api.github.com/users/JoshVanL/received_events","type":"User","site_admin":false},"assignees":[{"login":"JoshVanL","id":15893072,"node_id":"MDQ6VXNlcjE1ODkzMDcy","avatar_url":"https://avatars1.githubusercontent.com/u/15893072?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshVanL","html_url":"https://github.com/JoshVanL","followers_url":"https://api.github.com/users/JoshVanL/followers","following_url":"https://api.github.com/users/JoshVanL/following{/other_user}","gists_url":"https://api.github.com/users/JoshVanL/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshVanL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshVanL/subscriptions","organizations_url":"https://api.github.com/users/JoshVanL/orgs","repos_url":"https://api.github.com/users/JoshVanL/repos","events_url":"https://api.github.com/users/JoshVanL/events{/privacy}","received_events_url":"https://api.github.com/users/JoshVanL/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mattbates","id":2185766,"node_id":"MDQ6VXNlcjIxODU3NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2185766?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbates","html_url":"https://github.com/mattbates","followers_url":"https://api.github.com/users/mattbates/followers","following_url":"https://api.github.com/users/mattbates/following{/other_user}","gists_url":"https://api.github.com/users/mattbates/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbates/subscriptions","organizations_url":"https://api.github.com/users/mattbates/orgs","repos_url":"https://api.github.com/users/mattbates/repos","events_url":"https://api.github.com/users/mattbates/events{/privacy}","received_events_url":"https://api.github.com/users/mattbates/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1046845114,"node_id":"MDU6TGFiZWwxMDQ2ODQ1MTE0","url":"https://api.github.com/repos/jetstack/tarmak/labels/dco-signoff:%20yes","name":"dco-signoff: yes","color":"ededed","default":false},{"id":729324202,"node_id":"MDU6TGFiZWw3MjkzMjQyMDI=","url":"https://api.github.com/repos/jetstack/tarmak/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":729324245,"node_id":"MDU6TGFiZWw3MjkzMjQyNDU=","url":"https://api.github.com/repos/jetstack/tarmak/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/tarmak/pulls/390/commits","review_comments_url":"https://api.github.com/repos/jetstack/tarmak/pulls/390/comments","review_comment_url":"https://api.github.com/repos/jetstack/tarmak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/tarmak/issues/390/comments","statuses_url":"https://api.github.com/repos/jetstack/tarmak/statuses/01851c25fcaa6996ccdaf8f1ada31ba480c61195","head":{"label":"MattiasGees:feature/packer-builder","ref":"feature/packer-builder","sha":"01851c25fcaa6996ccdaf8f1ada31ba480c61195","user":{"login":"MattiasGees","id":2216724,"node_id":"MDQ6VXNlcjIyMTY3MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2216724?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasGees","html_url":"https://github.com/MattiasGees","followers_url":"https://api.github.com/users/MattiasGees/followers","following_url":"https://api.github.com/users/MattiasGees/following{/other_user}","gists_url":"https://api.github.com/users/MattiasGees/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasGees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasGees/subscriptions","organizations_url":"https://api.github.com/users/MattiasGees/orgs","repos_url":"https://api.github.com/users/MattiasGees/repos","events_url":"https://api.github.com/users/MattiasGees/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasGees/received_events","type":"User","site_admin":false},"repo":{"id":133013190,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMTMxOTA=","name":"tarmak","full_name":"MattiasGees/tarmak","private":false,"owner":{"login":"MattiasGees","id":2216724,"node_id":"MDQ6VXNlcjIyMTY3MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2216724?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiasGees","html_url":"https://github.com/MattiasGees","followers_url":"https://api.github.com/users/MattiasGees/followers","following_url":"https://api.github.com/users/MattiasGees/following{/other_user}","gists_url":"https://api.github.com/users/MattiasGees/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiasGees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiasGees/subscriptions","organizations_url":"https://api.github.com/users/MattiasGees/orgs","repos_url":"https://api.github.com/users/MattiasGees/repos","events_url":"https://api.github.com/users/MattiasGees/events{/privacy}","received_events_url":"https://api.github.com/users/MattiasGees/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MattiasGees/tarmak","description":"A toolkit for Kubernetes cluster provisioning and lifecycle management","fork":true,"url":"https://api.github.com/repos/MattiasGees/tarmak","forks_url":"https://api.github.com/repos/MattiasGees/tarmak/forks","keys_url":"https://api.github.com/repos/MattiasGees/tarmak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattiasGees/tarmak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattiasGees/tarmak/teams","hooks_url":"https://api.github.com/repos/MattiasGees/tarmak/hooks","issue_events_url":"https://api.github.com/repos/MattiasGees/tarmak/issues/events{/number}","events_url":"https://api.github.com/repos/MattiasGees/tarmak/events","assignees_url":"https://api.github.com/repos/MattiasGees/tarmak/assignees{/user}","branches_url":"https://api.github.com/repos/MattiasGees/tarmak/branches{/branch}","tags_url":"https://api.github.com/repos/MattiasGees/tarmak/tags","blobs_url":"https://api.github.com/repos/MattiasGees/tarmak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattiasGees/tarmak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattiasGees/tarmak/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattiasGees/tarmak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattiasGees/tarmak/statuses/{sha}","languages_url":"https://api.github.com/repos/MattiasGees/tarmak/languages","stargazers_url":"https://api.github.com/repos/MattiasGees/tarmak/stargazers","contributors_url":"https://api.github.com/repos/MattiasGees/tarmak/contributors","subscribers_url":"https://api.github.com/repos/MattiasGees/tarmak/subscribers","subscription_url":"https://api.github.com/repos/MattiasGees/tarmak/subscription","commits_url":"https://api.github.com/repos/MattiasGees/tarmak/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattiasGees/tarmak/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattiasGees/tarmak/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattiasGees/tarmak/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattiasGees/tarmak/contents/{+path}","compare_url":"https://api.github.com/repos/MattiasGees/tarmak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattiasGees/tarmak/merges","archive_url":"https://api.github.com/repos/MattiasGees/tarmak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattiasGees/tarmak/downloads","issues_url":"https://api.github.com/repos/MattiasGees/tarmak/issues{/number}","pulls_url":"https://api.github.com/repos/MattiasGees/tarmak/pulls{/number}","milestones_url":"https://api.github.com/repos/MattiasGees/tarmak/milestones{/number}","notifications_url":"https://api.github.com/repos/MattiasGees/tarmak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattiasGees/tarmak/labels{/name}","releases_url":"https://api.github.com/repos/MattiasGees/tarmak/releases{/id}","deployments_url":"https://api.github.com/repos/MattiasGees/tarmak/deployments","created_at":"2018-05-11T08:36:29Z","updated_at":"2018-10-24T11:36:00Z","pushed_at":"2018-10-25T15:27:54Z","git_url":"git://github.com/MattiasGees/tarmak.git","ssh_url":"git@github.com:MattiasGees/tarmak.git","clone_url":"https://github.com/MattiasGees/tarmak.git","svn_url":"https://github.com/MattiasGees/tarmak","homepage":"","size":89753,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"3be111d6ac9265378267863026b4cd542d08f951","user":{"login":"jetstack","id":13183983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTgzOTgz","avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":96748966,"node_id":"MDEwOlJlcG9zaXRvcnk5Njc0ODk2Ng==","name":"tarmak","full_name":"jetstack/tarmak","private":false,"owner":{"login":"jetstack","id":13183983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTgzOTgz","avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jetstack/tarmak","description":"A toolkit for Kubernetes cluster provisioning and lifecycle management","fork":false,"url":"https://api.github.com/repos/jetstack/tarmak","forks_url":"https://api.github.com/repos/jetstack/tarmak/forks","keys_url":"https://api.github.com/repos/jetstack/tarmak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/tarmak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/tarmak/teams","hooks_url":"https://api.github.com/repos/jetstack/tarmak/hooks","issue_events_url":"https://api.github.com/repos/jetstack/tarmak/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/tarmak/events","assignees_url":"https://api.github.com/repos/jetstack/tarmak/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/tarmak/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/tarmak/tags","blobs_url":"https://api.github.com/repos/jetstack/tarmak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/tarmak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/tarmak/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/tarmak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/tarmak/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/tarmak/languages","stargazers_url":"https://api.github.com/repos/jetstack/tarmak/stargazers","contributors_url":"https://api.github.com/repos/jetstack/tarmak/contributors","subscribers_url":"https://api.github.com/repos/jetstack/tarmak/subscribers","subscription_url":"https://api.github.com/repos/jetstack/tarmak/subscription","commits_url":"https://api.github.com/repos/jetstack/tarmak/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/tarmak/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/tarmak/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/tarmak/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/tarmak/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/tarmak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/tarmak/merges","archive_url":"https://api.github.com/repos/jetstack/tarmak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/tarmak/downloads","issues_url":"https://api.github.com/repos/jetstack/tarmak/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/tarmak/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/tarmak/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/tarmak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/tarmak/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/tarmak/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/tarmak/deployments","created_at":"2017-07-10T07:32:26Z","updated_at":"2018-10-24T19:22:18Z","pushed_at":"2018-10-25T15:38:59Z","git_url":"git://github.com/jetstack/tarmak.git","ssh_url":"git@github.com:jetstack/tarmak.git","clone_url":"https://github.com/jetstack/tarmak.git","svn_url":"https://github.com/jetstack/tarmak","homepage":"","size":89186,"stargazers_count":185,"watchers_count":185,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":31,"open_issues":147,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/390"},"html":{"href":"https://github.com/jetstack/tarmak/pull/390"},"issue":{"href":"https://api.github.com/repos/jetstack/tarmak/issues/390"},"comments":{"href":"https://api.github.com/repos/jetstack/tarmak/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/tarmak/statuses/01851c25fcaa6996ccdaf8f1ada31ba480c61195"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JoshVanL"}}