{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments/220220371","pull_request_review_id":158577494,"id":220220371,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDIyMDM3MQ==","diff_hunk":"@@ -152,4 +164,20 @@ describe(\"Answer Editor\", () => {\n     wrapper.find(MultipleChoiceAnswer).simulate(\"addOption\");\n     expect(mockMutations.onAddOption).toHaveBeenCalled();\n   });\n+\n+  it(\"should correctly calculate if date format includes value\", () => {\n+    const answer = {\n+      ...mockAnswer,\n+      type: DATE,\n+      properties: { format: \"mm/yyyy\" }\n+    };\n+    const instance = createWrapper({\n+      answer,\n+      ...mockMutations\n+    }).instance();\n+\n+    expect(instance.formatIncludes(\"dd\")(answer)).toEqual(false);","path":"src/components/AnswerEditor/answereditor.test.js","position":44,"original_position":44,"commit_id":"1bff8d4b1c10f29caebc98b848df13b85c6562e2","original_commit_id":"1bff8d4b1c10f29caebc98b848df13b85c6562e2","user":{"login":"tgandrews","id":180903,"node_id":"MDQ6VXNlcjE4MDkwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/180903?v=4","gravatar_id":"","url":"https://api.github.com/users/tgandrews","html_url":"https://github.com/tgandrews","followers_url":"https://api.github.com/users/tgandrews/followers","following_url":"https://api.github.com/users/tgandrews/following{/other_user}","gists_url":"https://api.github.com/users/tgandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/tgandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgandrews/subscriptions","organizations_url":"https://api.github.com/users/tgandrews/orgs","repos_url":"https://api.github.com/users/tgandrews/repos","events_url":"https://api.github.com/users/tgandrews/events{/privacy}","received_events_url":"https://api.github.com/users/tgandrews/received_events","type":"User","site_admin":false},"body":"Can we derive this another way as this is testing private API of the component not the expected output.","created_at":"2018-09-25T14:39:10Z","updated_at":"2018-09-25T14:39:10Z","html_url":"https://github.com/ONSdigital/eq-author/pull/442#discussion_r220220371","pull_request_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments/220220371"},"html":{"href":"https://github.com/ONSdigital/eq-author/pull/442#discussion_r220220371"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442","id":218005039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDA1MDM5","html_url":"https://github.com/ONSdigital/eq-author/pull/442","diff_url":"https://github.com/ONSdigital/eq-author/pull/442.diff","patch_url":"https://github.com/ONSdigital/eq-author/pull/442.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/442","number":442,"state":"open","locked":false,"title":"Add missing unit tests","user":{"login":"adammahmood","id":2471296,"node_id":"MDQ6VXNlcjI0NzEyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2471296?v=4","gravatar_id":"","url":"https://api.github.com/users/adammahmood","html_url":"https://github.com/adammahmood","followers_url":"https://api.github.com/users/adammahmood/followers","following_url":"https://api.github.com/users/adammahmood/following{/other_user}","gists_url":"https://api.github.com/users/adammahmood/gists{/gist_id}","starred_url":"https://api.github.com/users/adammahmood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammahmood/subscriptions","organizations_url":"https://api.github.com/users/adammahmood/orgs","repos_url":"https://api.github.com/users/adammahmood/repos","events_url":"https://api.github.com/users/adammahmood/events{/privacy}","received_events_url":"https://api.github.com/users/adammahmood/received_events","type":"User","site_admin":false},"body":"### What is the context of this PR?\r\n- Adds missing unit tests highlighted by our test coverage\r\n\r\n### How to review \r\n- Run tests","created_at":"2018-09-25T14:36:32Z","updated_at":"2018-09-25T14:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e42b7114fd59924010ec774f0d3b2f72019df747","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hamishtaplin","id":930398,"node_id":"MDQ6VXNlcjkzMDM5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/930398?v=4","gravatar_id":"","url":"https://api.github.com/users/hamishtaplin","html_url":"https://github.com/hamishtaplin","followers_url":"https://api.github.com/users/hamishtaplin/followers","following_url":"https://api.github.com/users/hamishtaplin/following{/other_user}","gists_url":"https://api.github.com/users/hamishtaplin/gists{/gist_id}","starred_url":"https://api.github.com/users/hamishtaplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hamishtaplin/subscriptions","organizations_url":"https://api.github.com/users/hamishtaplin/orgs","repos_url":"https://api.github.com/users/hamishtaplin/repos","events_url":"https://api.github.com/users/hamishtaplin/events{/privacy}","received_events_url":"https://api.github.com/users/hamishtaplin/received_events","type":"User","site_admin":false},{"login":"samiwel","id":4097796,"node_id":"MDQ6VXNlcjQwOTc3OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4097796?v=4","gravatar_id":"","url":"https://api.github.com/users/samiwel","html_url":"https://github.com/samiwel","followers_url":"https://api.github.com/users/samiwel/followers","following_url":"https://api.github.com/users/samiwel/following{/other_user}","gists_url":"https://api.github.com/users/samiwel/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwel/subscriptions","organizations_url":"https://api.github.com/users/samiwel/orgs","repos_url":"https://api.github.com/users/samiwel/repos","events_url":"https://api.github.com/users/samiwel/events{/privacy}","received_events_url":"https://api.github.com/users/samiwel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/442/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/1bff8d4b1c10f29caebc98b848df13b85c6562e2","head":{"label":"ONSdigital:586-improve-test-coverage-on-author","ref":"586-improve-test-coverage-on-author","sha":"1bff8d4b1c10f29caebc98b848df13b85c6562e2","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":82051674,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA1MTY3NA==","name":"eq-author","full_name":"ONSdigital/eq-author","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-author","description":"Author application","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author","forks_url":"https://api.github.com/repos/ONSdigital/eq-author/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author/deployments","created_at":"2017-02-15T11:06:14Z","updated_at":"2018-09-25T11:35:32Z","pushed_at":"2018-09-25T14:36:32Z","git_url":"git://github.com/ONSdigital/eq-author.git","ssh_url":"git@github.com:ONSdigital/eq-author.git","clone_url":"https://github.com/ONSdigital/eq-author.git","svn_url":"https://github.com/ONSdigital/eq-author","homepage":"https://staging-author.dev.eq.ons.digital/","size":4590,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"2b960ba9306b0c595263860a4e7084b5008c97e6","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":82051674,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA1MTY3NA==","name":"eq-author","full_name":"ONSdigital/eq-author","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-author","description":"Author application","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author","forks_url":"https://api.github.com/repos/ONSdigital/eq-author/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author/deployments","created_at":"2017-02-15T11:06:14Z","updated_at":"2018-09-25T11:35:32Z","pushed_at":"2018-09-25T14:36:32Z","git_url":"git://github.com/ONSdigital/eq-author.git","ssh_url":"git@github.com:ONSdigital/eq-author.git","clone_url":"https://github.com/ONSdigital/eq-author.git","svn_url":"https://github.com/ONSdigital/eq-author","homepage":"https://staging-author.dev.eq.ons.digital/","size":4590,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442"},"html":{"href":"https://github.com/ONSdigital/eq-author/pull/442"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-author/issues/442"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-author/statuses/1bff8d4b1c10f29caebc98b848df13b85c6562e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tgandrews"}}