{"action":"created","comment":{"url":"https://api.github.com/repos/PieterTack/polycap/pulls/comments/207833986","pull_request_review_id":143523746,"id":207833986,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgzMzk4Ng==","diff_hunk":"@@ -52,19 +52,19 @@ int main(int argc, char *argv[])\n \t\treturn 1;\n \t}\n \n-\t// Define energies\t\n-\tenergies = malloc(sizeof(double)*n_energies);\n-\tif(energies == NULL){\n-\t\tprintf(\"main: could not allocate memory for energies\\n\");\n-\t\treturn 1;\n-\t}\n-\tfor(i=0; i<n_energies; i++){\n-\t\tenergies[i] = 1.+0.1*i;\n-\t}\n+//\t// Define energies\t\n+//\tenergies = malloc(sizeof(double)*n_energies);\n+//\tif(energies == NULL){\n+//\t\tprintf(\"main: could not allocate memory for energies\\n\");\n+//\t\treturn 1;\n+//\t}\n+//\tfor(i=0; i<n_energies; i++){\n+//\t\tenergies[i] = 1.+0.1*i;\n+//\t}\n \n \t// Perform calculations\t\n \tprintf(\"Starting calculations...\\n\");\n-\tefficiencies = polycap_source_get_transmission_efficiencies(source, nthreads, n_energies, energies, n_photons, NULL, &error);\n+\tefficiencies = polycap_source_get_transmission_efficiencies(source, nthreads, source->n_energies, source->energies, n_photons, NULL, &error);","path":"src/main.c","position":null,"original_position":35,"commit_id":"c04ba78e045edcd19c86030ab0296d1a46f2f31f","original_commit_id":"de25f593d935c5a1a952906f5d223fd7011626f1","user":{"login":"tschoonj","id":65736,"node_id":"MDQ6VXNlcjY1NzM2","avatar_url":"https://avatars0.githubusercontent.com/u/65736?v=4","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"body":"Ik denk dat je best `n_energies` and `energies` uit `polycap_source_get_transmission_efficiencies ` haalt als argumenten want ze zitten toch al in `source`.","created_at":"2018-08-06T09:52:56Z","updated_at":"2018-08-06T09:52:56Z","html_url":"https://github.com/PieterTack/polycap/pull/39#discussion_r207833986","pull_request_url":"https://api.github.com/repos/PieterTack/polycap/pulls/39","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PieterTack/polycap/pulls/comments/207833986"},"html":{"href":"https://github.com/PieterTack/polycap/pull/39#discussion_r207833986"},"pull_request":{"href":"https://api.github.com/repos/PieterTack/polycap/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/PieterTack/polycap/pulls/39","id":198899601,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODk5NjAx","html_url":"https://github.com/PieterTack/polycap/pull/39","diff_url":"https://github.com/PieterTack/polycap/pull/39.diff","patch_url":"https://github.com/PieterTack/polycap/pull/39.patch","issue_url":"https://api.github.com/repos/PieterTack/polycap/issues/39","number":39,"state":"open","locked":false,"title":"Todos","user":{"login":"PieterTack","id":34742076,"node_id":"MDQ6VXNlcjM0NzQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/34742076?v=4","gravatar_id":"","url":"https://api.github.com/users/PieterTack","html_url":"https://github.com/PieterTack","followers_url":"https://api.github.com/users/PieterTack/followers","following_url":"https://api.github.com/users/PieterTack/following{/other_user}","gists_url":"https://api.github.com/users/PieterTack/gists{/gist_id}","starred_url":"https://api.github.com/users/PieterTack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PieterTack/subscriptions","organizations_url":"https://api.github.com/users/PieterTack/orgs","repos_url":"https://api.github.com/users/PieterTack/repos","events_url":"https://api.github.com/users/PieterTack/events{/privacy}","received_events_url":"https://api.github.com/users/PieterTack/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-03T09:18:25Z","updated_at":"2018-08-06T09:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df221d6f262b5c5b35a89278500d8bd8e7d3cbec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PieterTack/polycap/pulls/39/commits","review_comments_url":"https://api.github.com/repos/PieterTack/polycap/pulls/39/comments","review_comment_url":"https://api.github.com/repos/PieterTack/polycap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PieterTack/polycap/issues/39/comments","statuses_url":"https://api.github.com/repos/PieterTack/polycap/statuses/c04ba78e045edcd19c86030ab0296d1a46f2f31f","head":{"label":"PieterTack:todos","ref":"todos","sha":"c04ba78e045edcd19c86030ab0296d1a46f2f31f","user":{"login":"PieterTack","id":34742076,"node_id":"MDQ6VXNlcjM0NzQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/34742076?v=4","gravatar_id":"","url":"https://api.github.com/users/PieterTack","html_url":"https://github.com/PieterTack","followers_url":"https://api.github.com/users/PieterTack/followers","following_url":"https://api.github.com/users/PieterTack/following{/other_user}","gists_url":"https://api.github.com/users/PieterTack/gists{/gist_id}","starred_url":"https://api.github.com/users/PieterTack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PieterTack/subscriptions","organizations_url":"https://api.github.com/users/PieterTack/orgs","repos_url":"https://api.github.com/users/PieterTack/repos","events_url":"https://api.github.com/users/PieterTack/events{/privacy}","received_events_url":"https://api.github.com/users/PieterTack/received_events","type":"User","site_admin":false},"repo":{"id":115002448,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwMDI0NDg=","name":"polycap","full_name":"PieterTack/polycap","owner":{"login":"PieterTack","id":34742076,"node_id":"MDQ6VXNlcjM0NzQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/34742076?v=4","gravatar_id":"","url":"https://api.github.com/users/PieterTack","html_url":"https://github.com/PieterTack","followers_url":"https://api.github.com/users/PieterTack/followers","following_url":"https://api.github.com/users/PieterTack/following{/other_user}","gists_url":"https://api.github.com/users/PieterTack/gists{/gist_id}","starred_url":"https://api.github.com/users/PieterTack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PieterTack/subscriptions","organizations_url":"https://api.github.com/users/PieterTack/orgs","repos_url":"https://api.github.com/users/PieterTack/repos","events_url":"https://api.github.com/users/PieterTack/events{/privacy}","received_events_url":"https://api.github.com/users/PieterTack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PieterTack/polycap","description":"Polycapillary X-ray raytracing","fork":false,"url":"https://api.github.com/repos/PieterTack/polycap","forks_url":"https://api.github.com/repos/PieterTack/polycap/forks","keys_url":"https://api.github.com/repos/PieterTack/polycap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PieterTack/polycap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PieterTack/polycap/teams","hooks_url":"https://api.github.com/repos/PieterTack/polycap/hooks","issue_events_url":"https://api.github.com/repos/PieterTack/polycap/issues/events{/number}","events_url":"https://api.github.com/repos/PieterTack/polycap/events","assignees_url":"https://api.github.com/repos/PieterTack/polycap/assignees{/user}","branches_url":"https://api.github.com/repos/PieterTack/polycap/branches{/branch}","tags_url":"https://api.github.com/repos/PieterTack/polycap/tags","blobs_url":"https://api.github.com/repos/PieterTack/polycap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PieterTack/polycap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PieterTack/polycap/git/refs{/sha}","trees_url":"https://api.github.com/repos/PieterTack/polycap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PieterTack/polycap/statuses/{sha}","languages_url":"https://api.github.com/repos/PieterTack/polycap/languages","stargazers_url":"https://api.github.com/repos/PieterTack/polycap/stargazers","contributors_url":"https://api.github.com/repos/PieterTack/polycap/contributors","subscribers_url":"https://api.github.com/repos/PieterTack/polycap/subscribers","subscription_url":"https://api.github.com/repos/PieterTack/polycap/subscription","commits_url":"https://api.github.com/repos/PieterTack/polycap/commits{/sha}","git_commits_url":"https://api.github.com/repos/PieterTack/polycap/git/commits{/sha}","comments_url":"https://api.github.com/repos/PieterTack/polycap/comments{/number}","issue_comment_url":"https://api.github.com/repos/PieterTack/polycap/issues/comments{/number}","contents_url":"https://api.github.com/repos/PieterTack/polycap/contents/{+path}","compare_url":"https://api.github.com/repos/PieterTack/polycap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PieterTack/polycap/merges","archive_url":"https://api.github.com/repos/PieterTack/polycap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PieterTack/polycap/downloads","issues_url":"https://api.github.com/repos/PieterTack/polycap/issues{/number}","pulls_url":"https://api.github.com/repos/PieterTack/polycap/pulls{/number}","milestones_url":"https://api.github.com/repos/PieterTack/polycap/milestones{/number}","notifications_url":"https://api.github.com/repos/PieterTack/polycap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PieterTack/polycap/labels{/name}","releases_url":"https://api.github.com/repos/PieterTack/polycap/releases{/id}","deployments_url":"https://api.github.com/repos/PieterTack/polycap/deployments","created_at":"2017-12-21T12:15:30Z","updated_at":"2018-06-25T06:07:18Z","pushed_at":"2018-08-06T08:31:24Z","git_url":"git://github.com/PieterTack/polycap.git","ssh_url":"git@github.com:PieterTack/polycap.git","clone_url":"https://github.com/PieterTack/polycap.git","svn_url":"https://github.com/PieterTack/polycap","homepage":null,"size":1984,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"PieterTack:master","ref":"master","sha":"18620af470884ef9119a42e7842d65ca01a44ea4","user":{"login":"PieterTack","id":34742076,"node_id":"MDQ6VXNlcjM0NzQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/34742076?v=4","gravatar_id":"","url":"https://api.github.com/users/PieterTack","html_url":"https://github.com/PieterTack","followers_url":"https://api.github.com/users/PieterTack/followers","following_url":"https://api.github.com/users/PieterTack/following{/other_user}","gists_url":"https://api.github.com/users/PieterTack/gists{/gist_id}","starred_url":"https://api.github.com/users/PieterTack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PieterTack/subscriptions","organizations_url":"https://api.github.com/users/PieterTack/orgs","repos_url":"https://api.github.com/users/PieterTack/repos","events_url":"https://api.github.com/users/PieterTack/events{/privacy}","received_events_url":"https://api.github.com/users/PieterTack/received_events","type":"User","site_admin":false},"repo":{"id":115002448,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwMDI0NDg=","name":"polycap","full_name":"PieterTack/polycap","owner":{"login":"PieterTack","id":34742076,"node_id":"MDQ6VXNlcjM0NzQyMDc2","avatar_url":"https://avatars2.githubusercontent.com/u/34742076?v=4","gravatar_id":"","url":"https://api.github.com/users/PieterTack","html_url":"https://github.com/PieterTack","followers_url":"https://api.github.com/users/PieterTack/followers","following_url":"https://api.github.com/users/PieterTack/following{/other_user}","gists_url":"https://api.github.com/users/PieterTack/gists{/gist_id}","starred_url":"https://api.github.com/users/PieterTack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PieterTack/subscriptions","organizations_url":"https://api.github.com/users/PieterTack/orgs","repos_url":"https://api.github.com/users/PieterTack/repos","events_url":"https://api.github.com/users/PieterTack/events{/privacy}","received_events_url":"https://api.github.com/users/PieterTack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PieterTack/polycap","description":"Polycapillary X-ray raytracing","fork":false,"url":"https://api.github.com/repos/PieterTack/polycap","forks_url":"https://api.github.com/repos/PieterTack/polycap/forks","keys_url":"https://api.github.com/repos/PieterTack/polycap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PieterTack/polycap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PieterTack/polycap/teams","hooks_url":"https://api.github.com/repos/PieterTack/polycap/hooks","issue_events_url":"https://api.github.com/repos/PieterTack/polycap/issues/events{/number}","events_url":"https://api.github.com/repos/PieterTack/polycap/events","assignees_url":"https://api.github.com/repos/PieterTack/polycap/assignees{/user}","branches_url":"https://api.github.com/repos/PieterTack/polycap/branches{/branch}","tags_url":"https://api.github.com/repos/PieterTack/polycap/tags","blobs_url":"https://api.github.com/repos/PieterTack/polycap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PieterTack/polycap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PieterTack/polycap/git/refs{/sha}","trees_url":"https://api.github.com/repos/PieterTack/polycap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PieterTack/polycap/statuses/{sha}","languages_url":"https://api.github.com/repos/PieterTack/polycap/languages","stargazers_url":"https://api.github.com/repos/PieterTack/polycap/stargazers","contributors_url":"https://api.github.com/repos/PieterTack/polycap/contributors","subscribers_url":"https://api.github.com/repos/PieterTack/polycap/subscribers","subscription_url":"https://api.github.com/repos/PieterTack/polycap/subscription","commits_url":"https://api.github.com/repos/PieterTack/polycap/commits{/sha}","git_commits_url":"https://api.github.com/repos/PieterTack/polycap/git/commits{/sha}","comments_url":"https://api.github.com/repos/PieterTack/polycap/comments{/number}","issue_comment_url":"https://api.github.com/repos/PieterTack/polycap/issues/comments{/number}","contents_url":"https://api.github.com/repos/PieterTack/polycap/contents/{+path}","compare_url":"https://api.github.com/repos/PieterTack/polycap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PieterTack/polycap/merges","archive_url":"https://api.github.com/repos/PieterTack/polycap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PieterTack/polycap/downloads","issues_url":"https://api.github.com/repos/PieterTack/polycap/issues{/number}","pulls_url":"https://api.github.com/repos/PieterTack/polycap/pulls{/number}","milestones_url":"https://api.github.com/repos/PieterTack/polycap/milestones{/number}","notifications_url":"https://api.github.com/repos/PieterTack/polycap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PieterTack/polycap/labels{/name}","releases_url":"https://api.github.com/repos/PieterTack/polycap/releases{/id}","deployments_url":"https://api.github.com/repos/PieterTack/polycap/deployments","created_at":"2017-12-21T12:15:30Z","updated_at":"2018-06-25T06:07:18Z","pushed_at":"2018-08-06T08:31:24Z","git_url":"git://github.com/PieterTack/polycap.git","ssh_url":"git@github.com:PieterTack/polycap.git","clone_url":"https://github.com/PieterTack/polycap.git","svn_url":"https://github.com/PieterTack/polycap","homepage":null,"size":1984,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PieterTack/polycap/pulls/39"},"html":{"href":"https://github.com/PieterTack/polycap/pull/39"},"issue":{"href":"https://api.github.com/repos/PieterTack/polycap/issues/39"},"comments":{"href":"https://api.github.com/repos/PieterTack/polycap/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/PieterTack/polycap/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/PieterTack/polycap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PieterTack/polycap/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/PieterTack/polycap/statuses/c04ba78e045edcd19c86030ab0296d1a46f2f31f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tschoonj"}}