{"action":"created","comment":{"url":"https://api.github.com/repos/wellposed/numerical/pulls/comments/171972036","pull_request_review_id":100923980,"id":171972036,"diff_hunk":"@@ -17,10 +17,56 @@ import Test.Hspec\n unitTestShape :: Spec\n unitTestShape = describe \"unit tests for Shape\" $ do\n         specify \"foldl on shape\" $  S.foldl (+) 0 (1:* 2:* 3 :* Nil )  `shouldBe`   P.foldl   (+) 0  [1,2,3]\n+        specify \"foldl' on shape\" $ S.foldl' (+) 0 (1:* 2:* 3 :* Nil )  `shouldBe`   P.foldl (+) 0  [1,2,3]\n         specify \"foldr on shape\" $  S.foldr (+) 0 (1:* 2:* 3 :* Nil )  `shouldBe`   P.foldr  (+) 0  [1,2,3]\n         specify \"foldl1 on shape\" $  S.foldl1 (+) (1:* 2:* 3 :* Nil )  `shouldBe`   P.foldl1   (+)  [1,2,3]\n         specify \"foldr1 on shape\" $  S.foldr1 (+) (1:* 2:* 3 :* Nil )  `shouldBe`   P.foldr1  (+)  [1,2,3]\n \n+        specify \"== on Nil\" $ Nil == Nil `shouldBe` True\n+        specify \"== on identical shapes\" $ (1:* 2:* 3 :*  Nil) == (1:* 2:* 3 :*  Nil) `shouldBe` True\n+        specify \"== on different shapes\" $ (1:* 2:* 3 :*  Nil) == (1:* 2:* 2 :*  Nil) `shouldBe` False\n+\n+        specify \"fmap on Nil\" $ fmap (+1) Nil `shouldBe` Nil\n+        specify \"fmap on size n shape\" $ fmap (+1) (1 :* 3 :* Nil) `shouldBe` (2:* 4 :* Nil)\n+\n+        specify \"pure on Nil\" $ pure Nil `shouldBe` Nil\n+        specify \"pure on size 1\" $ (pure 1 :: Shape ('S 'Z) Int) `shouldBe` (1 :* Nil)\n+\n+        specify \"<*> with Nil should always be Nil\" $ Nil <*> Nil `shouldBe` Nil\n+        specify \"<*> with size 1 shape\" $ (+) <$> (1 :* Nil) <*> (2 :* Nil) `shouldBe` 3 :* Nil\n+\n+        specify \"traverse on Nil \" $ traverse Just Nil `shouldBe` Just Nil\n+        specify \"traverse on size 1 shape\" $ traverse (Just) (1 :* Nil) `shouldBe` Just (1:* Nil)\n+        specify \"traverse on size n shape\" $ traverse (Just) (1 :* 2 :* Nil) `shouldBe` Just (1 :* 2 :* Nil)\n+\n+        specify \"sequenceA on Nil\" $ sequenceA Nil `shouldBe` Nil\n+        specify \"sequenceA on size 1 shape\" $ sequenceA (Just 1 :* Nil) `shouldBe` Just (1 :* Nil)\n+        specify \"sequenceA on size n shape\" $ sequenceA (Just 1 :* Just 2 :* Nil) `shouldBe` Just (1 :* 2:*  Nil)\n+\n+        specify \"mapM on Nil\" $ mapM (Just) Nil `shouldBe` Just Nil\n+        specify \"mapM on size 1 shape\" $ mapM (Just) (1 :* Nil) `shouldBe` Just (1 :* Nil)\n+        specify \"mapM on size n shape\" $ mapM (Just) (1:* 2 :* Nil) `shouldBe` Just (1:* 2 :* Nil)\n+\n+        specify \"sequence on Nil\" $ do a <- sequence Nil ; a `shouldBe` Nil\n+        specify \"sequence on Size 1 shape\" $ sequence (Just 1 :* Nil) `shouldBe` Just (1 :* Nil)\n+        specify \"sequence on Size n shape\" $ sequence (Just 1 :* Just 2 :* Nil) `shouldBe` Just (1 :* 2 :* Nil)\n+\n+        specify \"map on shape\" $ S.map (+1) (1:* 2:* 3 :* Nil) `shouldBe` (2:* 3:* 4 :* Nil)\n+        specify \"map2 on shape\" $ S.map2 (+) (1:* 2:* 3 :* Nil) (2:* 3:* 4 :* Nil) `shouldBe` (3:* 5:* 7 :* Nil)\n+\n+        specify \"shapeToList on shape\" $ shapeToList (1:* 2:* 3 :*  Nil) `shouldBe` [1, 2, 3]\n+        specify \"shapeSize on shape\" $ shapeSize (1:* 2:* 3 :* Nil)  `shouldBe` length (shapeToList (1:* 2:* 3 :* Nil))\n+\n+        specify \"backwards traverse on shape\" $ backwards traverse (:[]) (1:* 2 :* Nil) `shouldBe` [(1:* 2 :* Nil)]\n+\n+        specify \"unShapeVector on shape\" $\n+          do a <- return (uvFromList [1:* 2:* Nil,2:* 3:* Nil,3:* 4:* Nil :: Shape (S (S Z)) Int])","path":"tests/NumericalUnit/Shape.hs","position":47,"original_position":47,"commit_id":"1de34fd7833b5b5974e01df78a6ec41ef1ce5f35","original_commit_id":"1de34fd7833b5b5974e01df78a6ec41ef1ce5f35","user":{"login":"cartazio","id":4290,"avatar_url":"https://avatars2.githubusercontent.com/u/4290?v=4","gravatar_id":"","url":"https://api.github.com/users/cartazio","html_url":"https://github.com/cartazio","followers_url":"https://api.github.com/users/cartazio/followers","following_url":"https://api.github.com/users/cartazio/following{/other_user}","gists_url":"https://api.github.com/users/cartazio/gists{/gist_id}","starred_url":"https://api.github.com/users/cartazio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartazio/subscriptions","organizations_url":"https://api.github.com/users/cartazio/orgs","repos_url":"https://api.github.com/users/cartazio/repos","events_url":"https://api.github.com/users/cartazio/events{/privacy}","received_events_url":"https://api.github.com/users/cartazio/received_events","type":"User","site_admin":false},"body":"heere I think we're testing the Unboxed representation of a sized list (aka shape) right? ","created_at":"2018-03-02T21:50:07Z","updated_at":"2018-03-02T21:51:05Z","html_url":"https://github.com/wellposed/numerical/pull/18#discussion_r171972036","pull_request_url":"https://api.github.com/repos/wellposed/numerical/pulls/18","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/wellposed/numerical/pulls/comments/171972036"},"html":{"href":"https://github.com/wellposed/numerical/pull/18#discussion_r171972036"},"pull_request":{"href":"https://api.github.com/repos/wellposed/numerical/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/wellposed/numerical/pulls/18","id":168614792,"html_url":"https://github.com/wellposed/numerical/pull/18","diff_url":"https://github.com/wellposed/numerical/pull/18.diff","patch_url":"https://github.com/wellposed/numerical/pull/18.patch","issue_url":"https://api.github.com/repos/wellposed/numerical/issues/18","number":18,"state":"open","locked":false,"title":"Added more unit tests around Shape","user":{"login":"ggranberry","id":5805744,"avatar_url":"https://avatars1.githubusercontent.com/u/5805744?v=4","gravatar_id":"","url":"https://api.github.com/users/ggranberry","html_url":"https://github.com/ggranberry","followers_url":"https://api.github.com/users/ggranberry/followers","following_url":"https://api.github.com/users/ggranberry/following{/other_user}","gists_url":"https://api.github.com/users/ggranberry/gists{/gist_id}","starred_url":"https://api.github.com/users/ggranberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggranberry/subscriptions","organizations_url":"https://api.github.com/users/ggranberry/orgs","repos_url":"https://api.github.com/users/ggranberry/repos","events_url":"https://api.github.com/users/ggranberry/events{/privacy}","received_events_url":"https://api.github.com/users/ggranberry/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-12T15:50:16Z","updated_at":"2018-03-02T21:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b13f50985307f25051374f38e3bc46473f8bf80b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wellposed/numerical/pulls/18/commits","review_comments_url":"https://api.github.com/repos/wellposed/numerical/pulls/18/comments","review_comment_url":"https://api.github.com/repos/wellposed/numerical/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellposed/numerical/issues/18/comments","statuses_url":"https://api.github.com/repos/wellposed/numerical/statuses/1de34fd7833b5b5974e01df78a6ec41ef1ce5f35","head":{"label":"ggranberry:ggranberry_unit_tests","ref":"ggranberry_unit_tests","sha":"1de34fd7833b5b5974e01df78a6ec41ef1ce5f35","user":{"login":"ggranberry","id":5805744,"avatar_url":"https://avatars1.githubusercontent.com/u/5805744?v=4","gravatar_id":"","url":"https://api.github.com/users/ggranberry","html_url":"https://github.com/ggranberry","followers_url":"https://api.github.com/users/ggranberry/followers","following_url":"https://api.github.com/users/ggranberry/following{/other_user}","gists_url":"https://api.github.com/users/ggranberry/gists{/gist_id}","starred_url":"https://api.github.com/users/ggranberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggranberry/subscriptions","organizations_url":"https://api.github.com/users/ggranberry/orgs","repos_url":"https://api.github.com/users/ggranberry/repos","events_url":"https://api.github.com/users/ggranberry/events{/privacy}","received_events_url":"https://api.github.com/users/ggranberry/received_events","type":"User","site_admin":false},"repo":{"id":121263411,"name":"numerical","full_name":"ggranberry/numerical","owner":{"login":"ggranberry","id":5805744,"avatar_url":"https://avatars1.githubusercontent.com/u/5805744?v=4","gravatar_id":"","url":"https://api.github.com/users/ggranberry","html_url":"https://github.com/ggranberry","followers_url":"https://api.github.com/users/ggranberry/followers","following_url":"https://api.github.com/users/ggranberry/following{/other_user}","gists_url":"https://api.github.com/users/ggranberry/gists{/gist_id}","starred_url":"https://api.github.com/users/ggranberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggranberry/subscriptions","organizations_url":"https://api.github.com/users/ggranberry/orgs","repos_url":"https://api.github.com/users/ggranberry/repos","events_url":"https://api.github.com/users/ggranberry/events{/privacy}","received_events_url":"https://api.github.com/users/ggranberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggranberry/numerical","description":"Numerical is the core library for Numerical Haskell","fork":true,"url":"https://api.github.com/repos/ggranberry/numerical","forks_url":"https://api.github.com/repos/ggranberry/numerical/forks","keys_url":"https://api.github.com/repos/ggranberry/numerical/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggranberry/numerical/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggranberry/numerical/teams","hooks_url":"https://api.github.com/repos/ggranberry/numerical/hooks","issue_events_url":"https://api.github.com/repos/ggranberry/numerical/issues/events{/number}","events_url":"https://api.github.com/repos/ggranberry/numerical/events","assignees_url":"https://api.github.com/repos/ggranberry/numerical/assignees{/user}","branches_url":"https://api.github.com/repos/ggranberry/numerical/branches{/branch}","tags_url":"https://api.github.com/repos/ggranberry/numerical/tags","blobs_url":"https://api.github.com/repos/ggranberry/numerical/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggranberry/numerical/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggranberry/numerical/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggranberry/numerical/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggranberry/numerical/statuses/{sha}","languages_url":"https://api.github.com/repos/ggranberry/numerical/languages","stargazers_url":"https://api.github.com/repos/ggranberry/numerical/stargazers","contributors_url":"https://api.github.com/repos/ggranberry/numerical/contributors","subscribers_url":"https://api.github.com/repos/ggranberry/numerical/subscribers","subscription_url":"https://api.github.com/repos/ggranberry/numerical/subscription","commits_url":"https://api.github.com/repos/ggranberry/numerical/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggranberry/numerical/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggranberry/numerical/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggranberry/numerical/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggranberry/numerical/contents/{+path}","compare_url":"https://api.github.com/repos/ggranberry/numerical/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggranberry/numerical/merges","archive_url":"https://api.github.com/repos/ggranberry/numerical/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggranberry/numerical/downloads","issues_url":"https://api.github.com/repos/ggranberry/numerical/issues{/number}","pulls_url":"https://api.github.com/repos/ggranberry/numerical/pulls{/number}","milestones_url":"https://api.github.com/repos/ggranberry/numerical/milestones{/number}","notifications_url":"https://api.github.com/repos/ggranberry/numerical/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggranberry/numerical/labels{/name}","releases_url":"https://api.github.com/repos/ggranberry/numerical/releases{/id}","deployments_url":"https://api.github.com/repos/ggranberry/numerical/deployments","created_at":"2018-02-12T15:24:26Z","updated_at":"2018-02-12T15:24:28Z","pushed_at":"2018-02-12T15:43:16Z","git_url":"git://github.com/ggranberry/numerical.git","ssh_url":"git@github.com:ggranberry/numerical.git","clone_url":"https://github.com/ggranberry/numerical.git","svn_url":"https://github.com/ggranberry/numerical","homepage":"","size":596,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wellposed:master","ref":"master","sha":"b402c7f7dfdb3a392745f43a51d641ef80c3c448","user":{"login":"wellposed","id":1852329,"avatar_url":"https://avatars2.githubusercontent.com/u/1852329?v=4","gravatar_id":"","url":"https://api.github.com/users/wellposed","html_url":"https://github.com/wellposed","followers_url":"https://api.github.com/users/wellposed/followers","following_url":"https://api.github.com/users/wellposed/following{/other_user}","gists_url":"https://api.github.com/users/wellposed/gists{/gist_id}","starred_url":"https://api.github.com/users/wellposed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellposed/subscriptions","organizations_url":"https://api.github.com/users/wellposed/orgs","repos_url":"https://api.github.com/users/wellposed/repos","events_url":"https://api.github.com/users/wellposed/events{/privacy}","received_events_url":"https://api.github.com/users/wellposed/received_events","type":"Organization","site_admin":false},"repo":{"id":17792839,"name":"numerical","full_name":"wellposed/numerical","owner":{"login":"wellposed","id":1852329,"avatar_url":"https://avatars2.githubusercontent.com/u/1852329?v=4","gravatar_id":"","url":"https://api.github.com/users/wellposed","html_url":"https://github.com/wellposed","followers_url":"https://api.github.com/users/wellposed/followers","following_url":"https://api.github.com/users/wellposed/following{/other_user}","gists_url":"https://api.github.com/users/wellposed/gists{/gist_id}","starred_url":"https://api.github.com/users/wellposed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellposed/subscriptions","organizations_url":"https://api.github.com/users/wellposed/orgs","repos_url":"https://api.github.com/users/wellposed/repos","events_url":"https://api.github.com/users/wellposed/events{/privacy}","received_events_url":"https://api.github.com/users/wellposed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellposed/numerical","description":"Numerical is the core library for Numerical Haskell","fork":false,"url":"https://api.github.com/repos/wellposed/numerical","forks_url":"https://api.github.com/repos/wellposed/numerical/forks","keys_url":"https://api.github.com/repos/wellposed/numerical/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellposed/numerical/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellposed/numerical/teams","hooks_url":"https://api.github.com/repos/wellposed/numerical/hooks","issue_events_url":"https://api.github.com/repos/wellposed/numerical/issues/events{/number}","events_url":"https://api.github.com/repos/wellposed/numerical/events","assignees_url":"https://api.github.com/repos/wellposed/numerical/assignees{/user}","branches_url":"https://api.github.com/repos/wellposed/numerical/branches{/branch}","tags_url":"https://api.github.com/repos/wellposed/numerical/tags","blobs_url":"https://api.github.com/repos/wellposed/numerical/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellposed/numerical/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellposed/numerical/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellposed/numerical/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellposed/numerical/statuses/{sha}","languages_url":"https://api.github.com/repos/wellposed/numerical/languages","stargazers_url":"https://api.github.com/repos/wellposed/numerical/stargazers","contributors_url":"https://api.github.com/repos/wellposed/numerical/contributors","subscribers_url":"https://api.github.com/repos/wellposed/numerical/subscribers","subscription_url":"https://api.github.com/repos/wellposed/numerical/subscription","commits_url":"https://api.github.com/repos/wellposed/numerical/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellposed/numerical/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellposed/numerical/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellposed/numerical/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellposed/numerical/contents/{+path}","compare_url":"https://api.github.com/repos/wellposed/numerical/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellposed/numerical/merges","archive_url":"https://api.github.com/repos/wellposed/numerical/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellposed/numerical/downloads","issues_url":"https://api.github.com/repos/wellposed/numerical/issues{/number}","pulls_url":"https://api.github.com/repos/wellposed/numerical/pulls{/number}","milestones_url":"https://api.github.com/repos/wellposed/numerical/milestones{/number}","notifications_url":"https://api.github.com/repos/wellposed/numerical/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellposed/numerical/labels{/name}","releases_url":"https://api.github.com/repos/wellposed/numerical/releases{/id}","deployments_url":"https://api.github.com/repos/wellposed/numerical/deployments","created_at":"2014-03-16T05:33:17Z","updated_at":"2018-02-14T04:48:58Z","pushed_at":"2018-02-12T15:50:17Z","git_url":"git://github.com/wellposed/numerical.git","ssh_url":"git@github.com:wellposed/numerical.git","clone_url":"https://github.com/wellposed/numerical.git","svn_url":"https://github.com/wellposed/numerical","homepage":"","size":595,"stargazers_count":117,"watchers_count":117,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":14,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellposed/numerical/pulls/18"},"html":{"href":"https://github.com/wellposed/numerical/pull/18"},"issue":{"href":"https://api.github.com/repos/wellposed/numerical/issues/18"},"comments":{"href":"https://api.github.com/repos/wellposed/numerical/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/wellposed/numerical/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/wellposed/numerical/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellposed/numerical/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/wellposed/numerical/statuses/1de34fd7833b5b5974e01df78a6ec41ef1ce5f35"}},"author_association":"NONE"}}
{"actor":{"display_login":"cartazio"}}