{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/5351","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/5351/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5351/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/5351/events","html_url":"https://github.com/apache/kafka/pull/5351","id":339686881,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjc4NTc4","number":5351,"title":"KAFKA-6999: Document read-write lock usage of caching enabled stores","user":{"login":"dongjinleekr","id":2375128,"node_id":"MDQ6VXNlcjIzNzUxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2375128?v=4","gravatar_id":"","url":"https://api.github.com/users/dongjinleekr","html_url":"https://github.com/dongjinleekr","followers_url":"https://api.github.com/users/dongjinleekr/followers","following_url":"https://api.github.com/users/dongjinleekr/following{/other_user}","gists_url":"https://api.github.com/users/dongjinleekr/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjinleekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjinleekr/subscriptions","organizations_url":"https://api.github.com/users/dongjinleekr/orgs","repos_url":"https://api.github.com/users/dongjinleekr/repos","events_url":"https://api.github.com/users/dongjinleekr/events{/privacy}","received_events_url":"https://api.github.com/users/dongjinleekr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-10T04:14:38Z","updated_at":"2018-07-10T04:16:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5351","html_url":"https://github.com/apache/kafka/pull/5351","diff_url":"https://github.com/apache/kafka/pull/5351.diff","patch_url":"https://github.com/apache/kafka/pull/5351.patch"},"body":"Add description for the deadlock vulnerability of `ReadOnlyKeyValueStore`."},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/403695046","html_url":"https://github.com/apache/kafka/pull/5351#issuecomment-403695046","issue_url":"https://api.github.com/repos/apache/kafka/issues/5351","id":403695046,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzY5NTA0Ng==","user":{"login":"dongjinleekr","id":2375128,"node_id":"MDQ6VXNlcjIzNzUxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2375128?v=4","gravatar_id":"","url":"https://api.github.com/users/dongjinleekr","html_url":"https://github.com/dongjinleekr","followers_url":"https://api.github.com/users/dongjinleekr/followers","following_url":"https://api.github.com/users/dongjinleekr/following{/other_user}","gists_url":"https://api.github.com/users/dongjinleekr/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjinleekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjinleekr/subscriptions","organizations_url":"https://api.github.com/users/dongjinleekr/orgs","repos_url":"https://api.github.com/users/dongjinleekr/repos","events_url":"https://api.github.com/users/dongjinleekr/events{/privacy}","received_events_url":"https://api.github.com/users/dongjinleekr/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T04:16:49Z","updated_at":"2018-07-10T04:16:49Z","author_association":"CONTRIBUTOR","body":"[Consulting ReadOnlyKeyValueStore from Processor can lead to deadlock (user mailing list)](http://mail-archives.apache.org/mod_mbox/kafka-users/201805.mbox/%3CD4660269-73A4-4D36-92D3-5432CA78F878@opentable.com%3E)\r\n\r\nThis is draft documentation for the pitfall described above. But, I have some questions:\r\n\r\n- Is it much better to make the comments boldface?\r\n- Do we need to add similar comments to `KeyValueStore`, which defines read/write functionality?\r\n- As of now, this problem occurs with cache-enabled `KeyValueStore` which is the default. Would it much better to add comments to the class or `Materialized#withCachingEnabled` method?"}}
{"actor":{"display_login":"dongjinleekr"}}