{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/181934620","pull_request_review_id":112645885,"id":181934620,"diff_hunk":"@@ -36,6 +37,8 @@ const char config_db_key_delimiter = '|';\n #define CONFIGDB_KEY_SEPARATOR \"|\"\n #define DEFAULT_KEY_SEPARATOR  \":\"\n \n+const int default_orch_pri = 0;","path":"orchagent/orch.h","position":12,"original_position":12,"commit_id":"b4af5dcce3826284b56b3571994e3f7c917f704f","original_commit_id":"b4af5dcce3826284b56b3571994e3f7c917f704f","user":{"login":"qiluo-msft","id":11406616,"avatar_url":"https://avatars1.githubusercontent.com/u/11406616?v=4","gravatar_id":"","url":"https://api.github.com/users/qiluo-msft","html_url":"https://github.com/qiluo-msft","followers_url":"https://api.github.com/users/qiluo-msft/followers","following_url":"https://api.github.com/users/qiluo-msft/following{/other_user}","gists_url":"https://api.github.com/users/qiluo-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/qiluo-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiluo-msft/subscriptions","organizations_url":"https://api.github.com/users/qiluo-msft/orgs","repos_url":"https://api.github.com/users/qiluo-msft/repos","events_url":"https://api.github.com/users/qiluo-msft/events{/privacy}","received_events_url":"https://api.github.com/users/qiluo-msft/received_events","type":"User","site_admin":false},"body":">default_orch_pri [](start = 10, length = 16)\r\n\r\nMove it to class local?","created_at":"2018-04-17T02:06:29Z","updated_at":"2018-04-17T02:06:30Z","html_url":"https://github.com/Azure/sonic-swss/pull/475#discussion_r181934620","pull_request_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/475","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/181934620"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/475#discussion_r181934620"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/475","id":182029761,"html_url":"https://github.com/Azure/sonic-swss/pull/475","diff_url":"https://github.com/Azure/sonic-swss/pull/475.diff","patch_url":"https://github.com/Azure/sonic-swss/pull/475.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss/issues/475","number":475,"state":"open","locked":false,"title":"[orchagent]: Use priorities in orchagent","user":{"login":"pavel-shirshov","id":13968565,"avatar_url":"https://avatars1.githubusercontent.com/u/13968565?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-shirshov","html_url":"https://github.com/pavel-shirshov","followers_url":"https://api.github.com/users/pavel-shirshov/followers","following_url":"https://api.github.com/users/pavel-shirshov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-shirshov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-shirshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-shirshov/subscriptions","organizations_url":"https://api.github.com/users/pavel-shirshov/orgs","repos_url":"https://api.github.com/users/pavel-shirshov/repos","events_url":"https://api.github.com/users/pavel-shirshov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-shirshov/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you have read and understood the contribution guildlines:\r\nhttps://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md\r\n\r\n1. Make sure your commit includes a signature generted with `git commit -s`\r\n2. Make sure your commit title follows the correct format: [component]: description\r\n3. Make sure your commit message contains enough details about the change and related tests\r\n4. Make sure your pull request adds related reviewers, asignees, labels\r\n\r\nPlease also provide the following information in this pull request:\r\n-->\r\n\r\n**What I did**\r\nI've added support of Selectable priorities for orchagent.\r\nI've put following priorities to orchagent tables:\r\n```\r\nAPP_PORT_TABLE_NAME = 45\r\nAPP_VLAN_TABLE_NAME = 42\r\nAPP_LAG_TABLE_NAME = 42\r\nAPP_VLAN_MEMBER_TABLE_NAME = 40\r\nAPP_LAG_MEMBER_TABLE_NAME = 40\r\nAPP_INTF_TABLE_NAME = 35\r\nAPP_NEIGH_TABLE_NAME= 30\r\nAPP_FDB_TABLE_NAME = 20\r\nAPP_ROUTE_TABLE_NAME = 5\r\n```\r\nAll other orchagent run with lowest priority which is 0.\r\n\r\n**Why I did it**\r\nTo prioritize messages inside of the orchagent message queue.\r\n\r\n**How I verified it**\r\nBuild swss and run it\r\n\r\n**Details if related**\r\n","created_at":"2018-04-17T01:38:01Z","updated_at":"2018-04-17T02:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e758d022dc4a2f3dbdcb97acdee5ed72cf5b9ac9","assignee":{"login":"pavel-shirshov","id":13968565,"avatar_url":"https://avatars1.githubusercontent.com/u/13968565?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-shirshov","html_url":"https://github.com/pavel-shirshov","followers_url":"https://api.github.com/users/pavel-shirshov/followers","following_url":"https://api.github.com/users/pavel-shirshov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-shirshov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-shirshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-shirshov/subscriptions","organizations_url":"https://api.github.com/users/pavel-shirshov/orgs","repos_url":"https://api.github.com/users/pavel-shirshov/repos","events_url":"https://api.github.com/users/pavel-shirshov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-shirshov/received_events","type":"User","site_admin":false},"assignees":[{"login":"pavel-shirshov","id":13968565,"avatar_url":"https://avatars1.githubusercontent.com/u/13968565?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-shirshov","html_url":"https://github.com/pavel-shirshov","followers_url":"https://api.github.com/users/pavel-shirshov/followers","following_url":"https://api.github.com/users/pavel-shirshov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-shirshov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-shirshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-shirshov/subscriptions","organizations_url":"https://api.github.com/users/pavel-shirshov/orgs","repos_url":"https://api.github.com/users/pavel-shirshov/repos","events_url":"https://api.github.com/users/pavel-shirshov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-shirshov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lguohan","id":2293967,"avatar_url":"https://avatars1.githubusercontent.com/u/2293967?v=4","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":338891657,"url":"https://api.github.com/repos/Azure/sonic-swss/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/475/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/475/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/issues/475/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/b4af5dcce3826284b56b3571994e3f7c917f704f","head":{"label":"pavel-shirshov:pavelsh/swss_pri","ref":"pavelsh/swss_pri","sha":"b4af5dcce3826284b56b3571994e3f7c917f704f","user":{"login":"pavel-shirshov","id":13968565,"avatar_url":"https://avatars1.githubusercontent.com/u/13968565?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-shirshov","html_url":"https://github.com/pavel-shirshov","followers_url":"https://api.github.com/users/pavel-shirshov/followers","following_url":"https://api.github.com/users/pavel-shirshov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-shirshov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-shirshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-shirshov/subscriptions","organizations_url":"https://api.github.com/users/pavel-shirshov/orgs","repos_url":"https://api.github.com/users/pavel-shirshov/repos","events_url":"https://api.github.com/users/pavel-shirshov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-shirshov/received_events","type":"User","site_admin":false},"repo":{"id":85760603,"name":"sonic-swss","full_name":"pavel-shirshov/sonic-swss","owner":{"login":"pavel-shirshov","id":13968565,"avatar_url":"https://avatars1.githubusercontent.com/u/13968565?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-shirshov","html_url":"https://github.com/pavel-shirshov","followers_url":"https://api.github.com/users/pavel-shirshov/followers","following_url":"https://api.github.com/users/pavel-shirshov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-shirshov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-shirshov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-shirshov/subscriptions","organizations_url":"https://api.github.com/users/pavel-shirshov/orgs","repos_url":"https://api.github.com/users/pavel-shirshov/repos","events_url":"https://api.github.com/users/pavel-shirshov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-shirshov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavel-shirshov/sonic-swss","description":"SONiC Switch State Service (SWSS)","fork":true,"url":"https://api.github.com/repos/pavel-shirshov/sonic-swss","forks_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/forks","keys_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/teams","hooks_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/events","assignees_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/tags","blobs_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/subscription","commits_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/merges","archive_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/downloads","issues_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/pavel-shirshov/sonic-swss/deployments","created_at":"2017-03-21T22:37:45Z","updated_at":"2017-03-21T22:37:48Z","pushed_at":"2018-04-17T01:09:39Z","git_url":"git://github.com/pavel-shirshov/sonic-swss.git","ssh_url":"git@github.com:pavel-shirshov/sonic-swss.git","clone_url":"https://github.com/pavel-shirshov/sonic-swss.git","svn_url":"https://github.com/pavel-shirshov/sonic-swss","homepage":"https://azure.github.io/SONiC","size":1462,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"880c1e9284a1737dfbb18ad5fa03d893482e4b18","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53515475,"name":"sonic-swss","full_name":"Azure/sonic-swss","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/sonic-swss","description":"SONiC Switch State Service (SwSS)","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss","forks_url":"https://api.github.com/repos/Azure/sonic-swss/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss/deployments","created_at":"2016-03-09T17:01:09Z","updated_at":"2018-04-16T20:36:43Z","pushed_at":"2018-04-17T01:38:02Z","git_url":"git://github.com/Azure/sonic-swss.git","ssh_url":"git@github.com:Azure/sonic-swss.git","clone_url":"https://github.com/Azure/sonic-swss.git","svn_url":"https://github.com/Azure/sonic-swss","homepage":"https://azure.github.io/SONiC","size":1414,"stargazers_count":32,"watchers_count":32,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":51,"open_issues":49,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/475"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/475"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/475"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss/statuses/b4af5dcce3826284b56b3571994e3f7c917f704f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qiluo-msft"}}