{"action":"created","issue":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1481","repository_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy","labels_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1481/labels{/name}","comments_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1481/comments","events_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1481/events","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1481","id":373898446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzIwMjY2","number":1481,"title":"Simplify service registration and resolution","user":{"login":"blairconrad","id":3275797,"node_id":"MDQ6VXNlcjMyNzU3OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3275797?v=4","gravatar_id":"","url":"https://api.github.com/users/blairconrad","html_url":"https://github.com/blairconrad","followers_url":"https://api.github.com/users/blairconrad/followers","following_url":"https://api.github.com/users/blairconrad/following{/other_user}","gists_url":"https://api.github.com/users/blairconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/blairconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blairconrad/subscriptions","organizations_url":"https://api.github.com/users/blairconrad/orgs","repos_url":"https://api.github.com/users/blairconrad/repos","events_url":"https://api.github.com/users/blairconrad/events{/privacy}","received_events_url":"https://api.github.com/users/blairconrad/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-25T11:21:27Z","updated_at":"2018-10-26T20:37:47Z","closed_at":"2018-10-26T20:37:39Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/pulls/1481","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1481","diff_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1481.diff","patch_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1481.patch"},"body":"Connects to #1478.\r\n\r\nWith this change:\r\n\r\n* services are registered as instances, not as delegates.\r\n* lambdas registered as factories have been replaced with local functions, for readability in stack traces:\r\n    ![image](https://user-images.githubusercontent.com/3275797/47496920-561e8e00-d826-11e8-9567-ed0cb1f91c94.png)\r\n* there's no more dictionary of services\r\n\r\nI made a million tiny commits while working. I'd've bunched them up, but didn't see any logic to how the services bunched together, so (mostly) converted one registration at a time, for readability. I'm happy to squash later.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/comments/433536288","html_url":"https://github.com/FakeItEasy/FakeItEasy/pull/1481#issuecomment-433536288","issue_url":"https://api.github.com/repos/FakeItEasy/FakeItEasy/issues/1481","id":433536288,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzUzNjI4OA==","user":{"login":"thomaslevesque","id":1864281,"node_id":"MDQ6VXNlcjE4NjQyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1864281?v=4","gravatar_id":"","url":"https://api.github.com/users/thomaslevesque","html_url":"https://github.com/thomaslevesque","followers_url":"https://api.github.com/users/thomaslevesque/followers","following_url":"https://api.github.com/users/thomaslevesque/following{/other_user}","gists_url":"https://api.github.com/users/thomaslevesque/gists{/gist_id}","starred_url":"https://api.github.com/users/thomaslevesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomaslevesque/subscriptions","organizations_url":"https://api.github.com/users/thomaslevesque/orgs","repos_url":"https://api.github.com/users/thomaslevesque/repos","events_url":"https://api.github.com/users/thomaslevesque/events{/privacy}","received_events_url":"https://api.github.com/users/thomaslevesque/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T20:37:47Z","updated_at":"2018-10-26T20:37:47Z","author_association":"MEMBER","body":"Thanks @blairconrad!"}}
{"actor":{"display_login":"thomaslevesque"}}