{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/970","repository_url":"https://api.github.com/repos/input-output-hk/daedalus","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/970/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/970/comments","events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/970/events","html_url":"https://github.com/input-output-hk/daedalus/pull/970","id":331193112,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTg0NDc0","number":970,"title":"[DDW-289] Properly handle Ada redemption screen in case there are no wallets","user":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"labels":[{"id":465480669,"node_id":"MDU6TGFiZWw0NjU0ODA2Njk=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/WIP","name":"WIP","color":"fbca04","default":false},{"id":455603673,"node_id":"MDU6TGFiZWw0NTU2MDM2NzM=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/feature","name":"feature","color":"0e8a16","default":false},{"id":962482865,"node_id":"MDU6TGFiZWw5NjI0ODI4NjU=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/release-0.11.0","name":"release-0.11.0","color":"a6e2ed","default":false}],"state":"open","locked":false,"assignee":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},{"login":"a-rukin","id":2539345,"node_id":"MDQ6VXNlcjI1MzkzNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/2539345?v=4","gravatar_id":"","url":"https://api.github.com/users/a-rukin","html_url":"https://github.com/a-rukin","followers_url":"https://api.github.com/users/a-rukin/followers","following_url":"https://api.github.com/users/a-rukin/following{/other_user}","gists_url":"https://api.github.com/users/a-rukin/gists{/gist_id}","starred_url":"https://api.github.com/users/a-rukin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-rukin/subscriptions","organizations_url":"https://api.github.com/users/a-rukin/orgs","repos_url":"https://api.github.com/users/a-rukin/repos","events_url":"https://api.github.com/users/a-rukin/events{/privacy}","received_events_url":"https://api.github.com/users/a-rukin/received_events","type":"User","site_admin":false},{"login":"darko-mijic","id":4280521,"node_id":"MDQ6VXNlcjQyODA1MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4280521?v=4","gravatar_id":"","url":"https://api.github.com/users/darko-mijic","html_url":"https://github.com/darko-mijic","followers_url":"https://api.github.com/users/darko-mijic/followers","following_url":"https://api.github.com/users/darko-mijic/following{/other_user}","gists_url":"https://api.github.com/users/darko-mijic/gists{/gist_id}","starred_url":"https://api.github.com/users/darko-mijic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darko-mijic/subscriptions","organizations_url":"https://api.github.com/users/darko-mijic/orgs","repos_url":"https://api.github.com/users/darko-mijic/repos","events_url":"https://api.github.com/users/darko-mijic/events{/privacy}","received_events_url":"https://api.github.com/users/darko-mijic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-06-11T13:39:08Z","updated_at":"2018-06-14T07:59:33Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/970","html_url":"https://github.com/input-output-hk/daedalus/pull/970","diff_url":"https://github.com/input-output-hk/daedalus/pull/970.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/970.patch"},"body":"This PR creates a screen for Ada redemption in case there are no wallets.\r\n\r\n## Todo:\r\n\r\n- [x] Create the screen based on [this solution](https://app.zeplin.io/project/57acfaa7436a750316161a8b/screen/5a86e931e6774c250a3b0f22).\r\n- [x] Provide English texts [@darko-mijic]\r\n- [x] Provide Japanese translations [**Hiroto**]\r\n- [x] Provide [final design](zpl.io/b6MQmxP) [@a-rukin]\r\n\r\n## Screenshots:\r\n\r\n![image](https://user-images.githubusercontent.com/1504716/41356719-d5b44e06-6efa-11e8-9016-4cd84575b2f3.png)\r\n![image](https://user-images.githubusercontent.com/1504716/41356683-c71d8664-6efa-11e8-8995-c6ff86a8c3ed.png)\r\n![image](https://user-images.githubusercontent.com/1504716/41356823-0ea9cb96-6efb-11e8-8794-5bd600f0d7ea.png)\r\n\r\n\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`npm run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`npm run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`npm run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`npm run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`npm run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `npm run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`npm run storybook`)\r\n- [ ] In case of npm dependency changes both `package-lock.json` and `yarn.lock` files are updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments/397206756","html_url":"https://github.com/input-output-hk/daedalus/pull/970#issuecomment-397206756","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/970","id":397206756,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzIwNjc1Ng==","user":{"login":"nikolaglumac","id":376611,"node_id":"MDQ6VXNlcjM3NjYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/376611?v=4","gravatar_id":"","url":"https://api.github.com/users/nikolaglumac","html_url":"https://github.com/nikolaglumac","followers_url":"https://api.github.com/users/nikolaglumac/followers","following_url":"https://api.github.com/users/nikolaglumac/following{/other_user}","gists_url":"https://api.github.com/users/nikolaglumac/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolaglumac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolaglumac/subscriptions","organizations_url":"https://api.github.com/users/nikolaglumac/orgs","repos_url":"https://api.github.com/users/nikolaglumac/repos","events_url":"https://api.github.com/users/nikolaglumac/events{/privacy}","received_events_url":"https://api.github.com/users/nikolaglumac/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T07:59:33Z","updated_at":"2018-06-14T07:59:33Z","author_association":"CONTRIBUTOR","body":"@daniloprates - bug confirmed. Something is wrong with the routes logic in your branch. If you have no wallets and you go to redemption page and then to add-wallets page it will show up the loading spinner without any content..."}}
{"actor":{"display_login":"nikolaglumac"}}