{"action":"created","issue":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/1289","repository_url":"https://api.github.com/repos/amethyst/amethyst","labels_url":"https://api.github.com/repos/amethyst/amethyst/issues/1289/labels{/name}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/1289/comments","events_url":"https://api.github.com/repos/amethyst/amethyst/issues/1289/events","html_url":"https://github.com/amethyst/amethyst/pull/1289","id":394195896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDAyNDI1","number":1289,"title":"Parallel Packet Processing","user":{"login":"TimonPost","id":19969910,"node_id":"MDQ6VXNlcjE5OTY5OTEw","avatar_url":"https://avatars3.githubusercontent.com/u/19969910?v=4","gravatar_id":"","url":"https://api.github.com/users/TimonPost","html_url":"https://github.com/TimonPost","followers_url":"https://api.github.com/users/TimonPost/followers","following_url":"https://api.github.com/users/TimonPost/following{/other_user}","gists_url":"https://api.github.com/users/TimonPost/gists{/gist_id}","starred_url":"https://api.github.com/users/TimonPost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimonPost/subscriptions","organizations_url":"https://api.github.com/users/TimonPost/orgs","repos_url":"https://api.github.com/users/TimonPost/repos","events_url":"https://api.github.com/users/TimonPost/events{/privacy}","received_events_url":"https://api.github.com/users/TimonPost/received_events","type":"User","site_admin":false},"labels":[{"id":803488704,"node_id":"MDU6TGFiZWw4MDM0ODg3MDQ=","url":"https://api.github.com/repos/amethyst/amethyst/labels/project:%20networking","name":"project: networking","color":"0e8a16","default":false},{"id":936102122,"node_id":"MDU6TGFiZWw5MzYxMDIxMjI=","url":"https://api.github.com/repos/amethyst/amethyst/labels/status:%20review%20comments","name":"status: review comments","color":"bfe5bf","default":false},{"id":302199478,"node_id":"MDU6TGFiZWwzMDIxOTk0Nzg=","url":"https://api.github.com/repos/amethyst/amethyst/labels/type:%20improvement","name":"type: improvement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-26T16:08:40Z","updated_at":"2018-12-27T21:03:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/1289","html_url":"https://github.com/amethyst/amethyst/pull/1289","diff_url":"https://github.com/amethyst/amethyst/pull/1289.diff","patch_url":"https://github.com/amethyst/amethyst/pull/1289.patch"},"body":"Removed any dependencies to specs by abstracting away all socket logic to the `Server` type. \r\n\r\nThe current network library does send and receiving in one thread. This could cause the program to not receive some packets at high server load when the thread is in the send loop. I moved the receiving logic and sending logic into separate threads so that we can receive and send in parallel.\r\n\r\n_A diagram of the implemented code:_\r\n![untitled diagram](https://user-images.githubusercontent.com/19969910/50450660-24887880-08e4-11e9-9509-4ec8697db561.png)\r\n\r\nI will now be going to work on error handling, so please be friendly and don't comment on `unwraps`.\r\n"},"comment":{"url":"https://api.github.com/repos/amethyst/amethyst/issues/comments/450230723","html_url":"https://github.com/amethyst/amethyst/pull/1289#issuecomment-450230723","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/1289","id":450230723,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDIzMDcyMw==","user":{"login":"LucioFranco","id":5758045,"node_id":"MDQ6VXNlcjU3NTgwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5758045?v=4","gravatar_id":"","url":"https://api.github.com/users/LucioFranco","html_url":"https://github.com/LucioFranco","followers_url":"https://api.github.com/users/LucioFranco/followers","following_url":"https://api.github.com/users/LucioFranco/following{/other_user}","gists_url":"https://api.github.com/users/LucioFranco/gists{/gist_id}","starred_url":"https://api.github.com/users/LucioFranco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucioFranco/subscriptions","organizations_url":"https://api.github.com/users/LucioFranco/orgs","repos_url":"https://api.github.com/users/LucioFranco/repos","events_url":"https://api.github.com/users/LucioFranco/events{/privacy}","received_events_url":"https://api.github.com/users/LucioFranco/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T21:03:08Z","updated_at":"2018-12-27T21:03:08Z","author_association":"MEMBER","body":"@udoprog @torkleyy If either of you have time to checkout https://github.com/amethyst/amethyst/pull/1289/commits/40fa2f29ab6ae5a2d36af2cee5be22358b2129a6 related to error handling."}}
{"actor":{"display_login":"LucioFranco"}}