{"action":"closed","number":476,"pull_request":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/476","id":175002366,"html_url":"https://github.com/xapi-project/xenopsd/pull/476","diff_url":"https://github.com/xapi-project/xenopsd/pull/476.diff","patch_url":"https://github.com/xapi-project/xenopsd/pull/476.patch","issue_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/476","number":476,"state":"closed","locked":false,"title":"CP-27114 cleanup /var/xen/qemu/root-<domid> for QEMU","user":{"login":"lindig","id":843617,"avatar_url":"https://avatars3.githubusercontent.com/u/843617?v=4","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"body":"This implements removing the /var/xen/qemu/root-<domid> directory hierarchy after QEMU finishes.\r\n\r\nCleanup code is now split:\r\n* Dm_Common.stop\r\n* Qemu_upstream_compat.Dm.stop - removes /var/xen/qemu/root-<domid>\r\n* Qemu_trad.Dm.stop - removes /var/xen/qemu/<pid>\r\n\r\nUnlike /var/xen/qemu/<pid>,  /var/xen/qemu/root-<domid> is not expected to be empty such that removal has to be recursive. New code for this resides in Xenops_utils.Unix.rm.\r\n\r\nThis has been tested with device models qemu-trad and qemu-upstream-compat.","created_at":"2018-03-14T15:56:47Z","updated_at":"2018-03-15T14:30:39Z","closed_at":"2018-03-15T14:30:39Z","merged_at":"2018-03-15T14:30:39Z","merge_commit_sha":"66ed2aeee0d3861d085a8164224f0002dab07609","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mg12","id":590521,"avatar_url":"https://avatars0.githubusercontent.com/u/590521?v=4","gravatar_id":"","url":"https://api.github.com/users/mg12","html_url":"https://github.com/mg12","followers_url":"https://api.github.com/users/mg12/followers","following_url":"https://api.github.com/users/mg12/following{/other_user}","gists_url":"https://api.github.com/users/mg12/gists{/gist_id}","starred_url":"https://api.github.com/users/mg12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg12/subscriptions","organizations_url":"https://api.github.com/users/mg12/orgs","repos_url":"https://api.github.com/users/mg12/repos","events_url":"https://api.github.com/users/mg12/events{/privacy}","received_events_url":"https://api.github.com/users/mg12/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/476/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/476/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/476/comments","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/c4f40c5ab5ed4c76e0ae6873a48cf211ff84aac2","head":{"label":"lindig:CP-27114","ref":"CP-27114","sha":"c4f40c5ab5ed4c76e0ae6873a48cf211ff84aac2","user":{"login":"lindig","id":843617,"avatar_url":"https://avatars3.githubusercontent.com/u/843617?v=4","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"repo":{"id":58365569,"name":"xenopsd","full_name":"lindig/xenopsd","owner":{"login":"lindig","id":843617,"avatar_url":"https://avatars3.githubusercontent.com/u/843617?v=4","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lindig/xenopsd","description":"XCP toolstack domain manager","fork":true,"url":"https://api.github.com/repos/lindig/xenopsd","forks_url":"https://api.github.com/repos/lindig/xenopsd/forks","keys_url":"https://api.github.com/repos/lindig/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lindig/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lindig/xenopsd/teams","hooks_url":"https://api.github.com/repos/lindig/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/lindig/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/lindig/xenopsd/events","assignees_url":"https://api.github.com/repos/lindig/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/lindig/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/lindig/xenopsd/tags","blobs_url":"https://api.github.com/repos/lindig/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lindig/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lindig/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lindig/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lindig/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/lindig/xenopsd/languages","stargazers_url":"https://api.github.com/repos/lindig/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/lindig/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/lindig/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/lindig/xenopsd/subscription","commits_url":"https://api.github.com/repos/lindig/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lindig/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lindig/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lindig/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lindig/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/lindig/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lindig/xenopsd/merges","archive_url":"https://api.github.com/repos/lindig/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lindig/xenopsd/downloads","issues_url":"https://api.github.com/repos/lindig/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/lindig/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/lindig/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/lindig/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lindig/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/lindig/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/lindig/xenopsd/deployments","created_at":"2016-05-09T09:39:49Z","updated_at":"2016-05-09T09:39:51Z","pushed_at":"2018-03-15T14:28:35Z","git_url":"git://github.com/lindig/xenopsd.git","ssh_url":"git@github.com:lindig/xenopsd.git","clone_url":"https://github.com/lindig/xenopsd.git","svn_url":"https://github.com/lindig/xenopsd","homepage":null,"size":32941,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:qemu-upstream","ref":"qemu-upstream","sha":"146813d1573eee4fbd2eceb998ce42f19bf5e37c","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":7563740,"name":"xenopsd","full_name":"xapi-project/xenopsd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xenopsd","description":"XCP toolstack domain manager","fork":false,"url":"https://api.github.com/repos/xapi-project/xenopsd","forks_url":"https://api.github.com/repos/xapi-project/xenopsd/forks","keys_url":"https://api.github.com/repos/xapi-project/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xenopsd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xenopsd/events","assignees_url":"https://api.github.com/repos/xapi-project/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xenopsd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xenopsd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xenopsd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xenopsd/merges","archive_url":"https://api.github.com/repos/xapi-project/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xenopsd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xenopsd/deployments","created_at":"2013-01-11T17:19:31Z","updated_at":"2018-03-14T16:04:24Z","pushed_at":"2018-03-15T14:30:39Z","git_url":"git://github.com/xapi-project/xenopsd.git","ssh_url":"git@github.com:xapi-project/xenopsd.git","clone_url":"https://github.com/xapi-project/xenopsd.git","svn_url":"https://github.com/xapi-project/xenopsd","homepage":null,"size":33126,"stargazers_count":7,"watchers_count":7,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":56,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/476"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/476"},"issue":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/476"},"comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xenopsd/statuses/c4f40c5ab5ed4c76e0ae6873a48cf211ff84aac2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lindig","id":843617,"avatar_url":"https://avatars3.githubusercontent.com/u/843617?v=4","gravatar_id":"","url":"https://api.github.com/users/lindig","html_url":"https://github.com/lindig","followers_url":"https://api.github.com/users/lindig/followers","following_url":"https://api.github.com/users/lindig/following{/other_user}","gists_url":"https://api.github.com/users/lindig/gists{/gist_id}","starred_url":"https://api.github.com/users/lindig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindig/subscriptions","organizations_url":"https://api.github.com/users/lindig/orgs","repos_url":"https://api.github.com/users/lindig/repos","events_url":"https://api.github.com/users/lindig/events{/privacy}","received_events_url":"https://api.github.com/users/lindig/received_events","type":"User","site_admin":false},"comments":2,"review_comments":9,"maintainer_can_modify":false,"commits":5,"additions":34,"deletions":16,"changed_files":2}}
{"actor":{"display_login":"lindig"}}