{"action":"closed","number":9902,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/9902","id":214382318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzgyMzE4","html_url":"https://github.com/sequelize/sequelize/pull/9902","diff_url":"https://github.com/sequelize/sequelize/pull/9902.diff","patch_url":"https://github.com/sequelize/sequelize/pull/9902.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/9902","number":9902,"state":"closed","locked":false,"title":"test: forward mocha options to individual scripts","user":{"login":"jedwards1211","id":1448194,"node_id":"MDQ6VXNlcjE0NDgxOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1448194?v=4","gravatar_id":"","url":"https://api.github.com/users/jedwards1211","html_url":"https://github.com/jedwards1211","followers_url":"https://api.github.com/users/jedwards1211/followers","following_url":"https://api.github.com/users/jedwards1211/following{/other_user}","gists_url":"https://api.github.com/users/jedwards1211/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards1211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards1211/subscriptions","organizations_url":"https://api.github.com/users/jedwards1211/orgs","repos_url":"https://api.github.com/users/jedwards1211/repos","events_url":"https://api.github.com/users/jedwards1211/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards1211/received_events","type":"User","site_admin":false},"body":"fix #9898\r\n\r\n@sushantdhiman although using `yarn` would be simpler, it might be a nasty surprise if any developers don't have it installed.  This is a slightly bigger change to package.json, but it doesn't require `yarn` and it supports passing mocha options to `npm` like `npm run test-unit-all -- --grep ignoreDuplicates --bail` as well.\r\n\r\n<!-- \r\nThanks for wanting to fix something on Sequelize - we already love you long time!\r\nPlease fill in the template below.\r\nIf unsure about something, just do as best as you're able.\r\n\r\nIf your PR only contains changes to documentation, you may skip the template below.\r\n-->\r\n\r\n### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] (NA) Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?\r\n- [x] (NA) Have you added new tests to prevent regressions?\r\n- [x] (NA) Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?\r\n- [x] Did you follow the commit message conventions explained in [CONTRIBUTING.md](https://github.com/sequelize/sequelize/blob/master/CONTRIBUTING.md)?\r\n\r\n<!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. -->\r\n\r\n### Description of change\r\n\r\n<!-- Please provide a description of the change here. -->\r\n\r\nI created a `run-test-scripts.js` script that distributes the arguments to each `npm run test-*` command, and use it in the package scripts.","created_at":"2018-09-10T17:05:53Z","updated_at":"2018-09-11T15:18:23Z","closed_at":"2018-09-11T15:18:22Z","merged_at":null,"merge_commit_sha":"af807fe7fe25fe25a2a3eccc107c1bd8f7d25704","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/9902/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/9902/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/9902/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/79775aa91806f63fa41360b8dfe6c1f44988b6d3","head":{"label":"jedwards1211:fix/mocha-options","ref":"fix/mocha-options","sha":"79775aa91806f63fa41360b8dfe6c1f44988b6d3","user":{"login":"jedwards1211","id":1448194,"node_id":"MDQ6VXNlcjE0NDgxOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1448194?v=4","gravatar_id":"","url":"https://api.github.com/users/jedwards1211","html_url":"https://github.com/jedwards1211","followers_url":"https://api.github.com/users/jedwards1211/followers","following_url":"https://api.github.com/users/jedwards1211/following{/other_user}","gists_url":"https://api.github.com/users/jedwards1211/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards1211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards1211/subscriptions","organizations_url":"https://api.github.com/users/jedwards1211/orgs","repos_url":"https://api.github.com/users/jedwards1211/repos","events_url":"https://api.github.com/users/jedwards1211/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards1211/received_events","type":"User","site_admin":false},"repo":{"id":106840766,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4NDA3NjY=","name":"sequelize","full_name":"jedwards1211/sequelize","owner":{"login":"jedwards1211","id":1448194,"node_id":"MDQ6VXNlcjE0NDgxOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1448194?v=4","gravatar_id":"","url":"https://api.github.com/users/jedwards1211","html_url":"https://github.com/jedwards1211","followers_url":"https://api.github.com/users/jedwards1211/followers","following_url":"https://api.github.com/users/jedwards1211/following{/other_user}","gists_url":"https://api.github.com/users/jedwards1211/gists{/gist_id}","starred_url":"https://api.github.com/users/jedwards1211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedwards1211/subscriptions","organizations_url":"https://api.github.com/users/jedwards1211/orgs","repos_url":"https://api.github.com/users/jedwards1211/repos","events_url":"https://api.github.com/users/jedwards1211/events{/privacy}","received_events_url":"https://api.github.com/users/jedwards1211/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jedwards1211/sequelize","description":"An easy-to-use multi SQL dialect ORM for Node.js","fork":true,"url":"https://api.github.com/repos/jedwards1211/sequelize","forks_url":"https://api.github.com/repos/jedwards1211/sequelize/forks","keys_url":"https://api.github.com/repos/jedwards1211/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedwards1211/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedwards1211/sequelize/teams","hooks_url":"https://api.github.com/repos/jedwards1211/sequelize/hooks","issue_events_url":"https://api.github.com/repos/jedwards1211/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/jedwards1211/sequelize/events","assignees_url":"https://api.github.com/repos/jedwards1211/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/jedwards1211/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/jedwards1211/sequelize/tags","blobs_url":"https://api.github.com/repos/jedwards1211/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedwards1211/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedwards1211/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedwards1211/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedwards1211/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/jedwards1211/sequelize/languages","stargazers_url":"https://api.github.com/repos/jedwards1211/sequelize/stargazers","contributors_url":"https://api.github.com/repos/jedwards1211/sequelize/contributors","subscribers_url":"https://api.github.com/repos/jedwards1211/sequelize/subscribers","subscription_url":"https://api.github.com/repos/jedwards1211/sequelize/subscription","commits_url":"https://api.github.com/repos/jedwards1211/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedwards1211/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedwards1211/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedwards1211/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedwards1211/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/jedwards1211/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedwards1211/sequelize/merges","archive_url":"https://api.github.com/repos/jedwards1211/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedwards1211/sequelize/downloads","issues_url":"https://api.github.com/repos/jedwards1211/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/jedwards1211/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/jedwards1211/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/jedwards1211/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedwards1211/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/jedwards1211/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/jedwards1211/sequelize/deployments","created_at":"2017-10-13T15:20:09Z","updated_at":"2017-10-13T15:20:14Z","pushed_at":"2018-09-10T17:03:01Z","git_url":"git://github.com/jedwards1211/sequelize.git","ssh_url":"git@github.com:jedwards1211/sequelize.git","clone_url":"https://github.com/jedwards1211/sequelize.git","svn_url":"https://github.com/jedwards1211/sequelize","homepage":"http://docs.sequelizejs.com","size":23030,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"ba0cb016c1bb13d32f4d51a1a48671eda0d3738c","user":{"login":"sequelize","id":3591786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTE3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/3591786?v=4","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"node_id":"MDEwOlJlcG9zaXRvcnk3OTAzNTk=","name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTE3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/3591786?v=4","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"An easy-to-use multi SQL dialect ORM for Node.js","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sequelize/sequelize/deployments","created_at":"2010-07-22T07:11:11Z","updated_at":"2018-09-11T11:59:50Z","pushed_at":"2018-09-11T14:05:19Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://docs.sequelizejs.com","size":23004,"stargazers_count":15788,"watchers_count":15788,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2606,"mirror_url":null,"archived":false,"open_issues_count":355,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2606,"open_issues":355,"watchers":15788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9902"},"html":{"href":"https://github.com/sequelize/sequelize/pull/9902"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/9902"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/9902/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9902/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/9902/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/79775aa91806f63fa41360b8dfe6c1f44988b6d3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":54,"deletions":21,"changed_files":2}}
{"actor":{"display_login":"jedwards1211"}}