{"action":"created","issue":{"url":"https://api.github.com/repos/lammps/lammps/issues/1013","repository_url":"https://api.github.com/repos/lammps/lammps","labels_url":"https://api.github.com/repos/lammps/lammps/issues/1013/labels{/name}","comments_url":"https://api.github.com/repos/lammps/lammps/issues/1013/comments","events_url":"https://api.github.com/repos/lammps/lammps/issues/1013/events","html_url":"https://github.com/lammps/lammps/pull/1013","id":343811653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzU2MjI3","number":1013,"title":"new MESSAGE package for client/server/coupling","user":{"login":"sjplimp","id":21087682,"node_id":"MDQ6VXNlcjIxMDg3Njgy","avatar_url":"https://avatars1.githubusercontent.com/u/21087682?v=4","gravatar_id":"","url":"https://api.github.com/users/sjplimp","html_url":"https://github.com/sjplimp","followers_url":"https://api.github.com/users/sjplimp/followers","following_url":"https://api.github.com/users/sjplimp/following{/other_user}","gists_url":"https://api.github.com/users/sjplimp/gists{/gist_id}","starred_url":"https://api.github.com/users/sjplimp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjplimp/subscriptions","organizations_url":"https://api.github.com/users/sjplimp/orgs","repos_url":"https://api.github.com/users/sjplimp/repos","events_url":"https://api.github.com/users/sjplimp/events{/privacy}","received_events_url":"https://api.github.com/users/sjplimp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rbberger","id":2828630,"node_id":"MDQ6VXNlcjI4Mjg2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2828630?v=4","gravatar_id":"","url":"https://api.github.com/users/rbberger","html_url":"https://github.com/rbberger","followers_url":"https://api.github.com/users/rbberger/followers","following_url":"https://api.github.com/users/rbberger/following{/other_user}","gists_url":"https://api.github.com/users/rbberger/gists{/gist_id}","starred_url":"https://api.github.com/users/rbberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbberger/subscriptions","organizations_url":"https://api.github.com/users/rbberger/orgs","repos_url":"https://api.github.com/users/rbberger/repos","events_url":"https://api.github.com/users/rbberger/events{/privacy}","received_events_url":"https://api.github.com/users/rbberger/received_events","type":"User","site_admin":false},"assignees":[{"login":"rbberger","id":2828630,"node_id":"MDQ6VXNlcjI4Mjg2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2828630?v=4","gravatar_id":"","url":"https://api.github.com/users/rbberger","html_url":"https://github.com/rbberger","followers_url":"https://api.github.com/users/rbberger/followers","following_url":"https://api.github.com/users/rbberger/following{/other_user}","gists_url":"https://api.github.com/users/rbberger/gists{/gist_id}","starred_url":"https://api.github.com/users/rbberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbberger/subscriptions","organizations_url":"https://api.github.com/users/rbberger/orgs","repos_url":"https://api.github.com/users/rbberger/repos","events_url":"https://api.github.com/users/rbberger/events{/privacy}","received_events_url":"https://api.github.com/users/rbberger/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/lammps/lammps/milestones/2","html_url":"https://github.com/lammps/lammps/milestone/2","labels_url":"https://api.github.com/repos/lammps/lammps/milestones/2/labels","id":3499619,"node_id":"MDk6TWlsZXN0b25lMzQ5OTYxOQ==","number":2,"title":"Stable Release Fall 2018","description":"","creator":{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":3,"state":"open","created_at":"2018-07-16T13:00:55Z","updated_at":"2018-08-28T19:28:44Z","due_on":"2018-12-10T08:00:00Z","closed_at":null},"comments":12,"created_at":"2018-07-23T22:00:52Z","updated_at":"2018-08-29T11:44:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lammps/lammps/pulls/1013","html_url":"https://github.com/lammps/lammps/pull/1013","diff_url":"https://github.com/lammps/lammps/pull/1013.diff","patch_url":"https://github.com/lammps/lammps/pull/1013.patch"},"body":"## Purpose\r\n\r\nNew MESSAGE package to allow LAMMPS to be used as either a client or server in client/server mode and be coupled to another code.  Examples for doing MD and MC (Monte Carlo) in this fashion,\r\nas well as wrapping VASP.\r\n\r\n## Author(s)\r\n\r\nSteve\r\n\r\n## Backward Compatibility\r\n\r\nShould be N/A.\r\n\r\n## Implementation Notes\r\n\r\n_Provide any relevant details about how the changes are implemented, how correctness was verified, how other features - if any - in LAMMPS are affected_\r\n\r\n## Post Submission Checklist\r\n\r\n_Please check the fields below as they are completed_\r\n- [ ] The feature or features in this pull request is complete\r\n- [ ] Suitable new documentation files and/or updates to the existing docs are included\r\n- [ ] One or more example input decks are included\r\n- [ ] The source code follows the LAMMPS formatting guidelines\r\n\r\n## Further Information, Files, and Links\r\n\r\n_Put any additional information here, attach relevant text or image files, and URLs to external sites (e.g. DOIs or webpages)_\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/lammps/lammps/issues/comments/416923396","html_url":"https://github.com/lammps/lammps/pull/1013#issuecomment-416923396","issue_url":"https://api.github.com/repos/lammps/lammps/issues/1013","id":416923396,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjkyMzM5Ng==","user":{"login":"rbberger","id":2828630,"node_id":"MDQ6VXNlcjI4Mjg2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2828630?v=4","gravatar_id":"","url":"https://api.github.com/users/rbberger","html_url":"https://github.com/rbberger","followers_url":"https://api.github.com/users/rbberger/followers","following_url":"https://api.github.com/users/rbberger/following{/other_user}","gists_url":"https://api.github.com/users/rbberger/gists{/gist_id}","starred_url":"https://api.github.com/users/rbberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbberger/subscriptions","organizations_url":"https://api.github.com/users/rbberger/orgs","repos_url":"https://api.github.com/users/rbberger/repos","events_url":"https://api.github.com/users/rbberger/events{/privacy}","received_events_url":"https://api.github.com/users/rbberger/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T11:44:54Z","updated_at":"2018-08-29T11:44:54Z","author_association":"MEMBER","body":"@sjplimp \r\n(0) please pull the latest changes\r\n\r\n(1)  cslib is built with CMake, otherwise, there would be link errors. I've now renamed the lib so it conforms to what you were doing in your Makefile. After running cmake & make, if you look at the build directory the library that gets created is called `libcsmpi.a` or `libcsnompi.a`, depending on if it is build with `-D BUILD_MPI=on` (default is on). If you build with `-D BUILD_LIB=on -D BUILD_SHARED_LIBS=on` it will be `libcsmpi.so` or `libcsnompi.so`.\r\n\r\n(2) `-mpi` might be confusing to users and implying to enable running with MPI support. It should be `--mpi-color`. Btw, `lmp -h` is missing the help output for that option.\r\n\r\n(3) message is a really bad name for a command, that doesn't send a message\r\n\r\n(4) Assuming LAMMPS is installed into `CMAKE_INSTALL_PREFIX` (or via DEB or RPM) and we add a few more files to that install, a  code like your COUPLE MC example could then be built with CMake with something like this:\r\n```cmake\r\n#CMakeLists.txt in examples/COUPLE/lammps_mc\r\noption(ENABLE_ZMQ \"Enable ZeroMQ support\" off)\r\n\r\nadd_executable(mc)\r\n\r\nif( ENABLE_ZMQ )\r\n   find_package(ZMQ)\r\n   include_directories(${ZMQ_INCLUDE_DIRS})\r\n   target_link_libraries(mc ${ZMQ_LIBRARIES})\r\nendif()\r\n\r\nfind_package(cslib)\r\ninclude_directories(${cslib_INCLUDE_DIRS})\r\ntarget_link_libraries(mc ${cslib_LIBRARIES})\r\n\r\ntarget_sources(mc mc.cpp random_park.cpp)\r\n```\r\nand\r\n```bash\r\nmkdir build\r\ncd build\r\ncmake ..\r\nmake\r\n```\r\nThis last point doesn't need to be solved now, I can add it later after the merge.\r\n"}}
{"actor":{"display_login":"rbberger"}}