{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments/173999771","pull_request_review_id":103279240,"id":173999771,"diff_hunk":"@@ -181,14 +181,17 @@ ngx_stream_lua_balancer_by_lua(ngx_conf_t *cf, ngx_command_t *cmd,\n \n         lscf->balancer.src = value[1];\n \n-        p = ngx_palloc(cf->pool, NGX_STREAM_LUA_INLINE_KEY_LEN + 1);\n+        p = ngx_palloc(cf->pool,\n+                 sizeof(\"balancer_by_lua\") + NGX_STREAM_LUA_INLINE_KEY_LEN + 1);","path":"src/ngx_stream_lua_balancer.c","position":115,"original_position":115,"commit_id":"60ac8e44eacec851d60403ff37817dbd39fb3d18","original_commit_id":"60ac8e44eacec851d60403ff37817dbd39fb3d18","user":{"login":"spacewander","id":4161644,"avatar_url":"https://avatars3.githubusercontent.com/u/4161644?v=4","gravatar_id":"","url":"https://api.github.com/users/spacewander","html_url":"https://github.com/spacewander","followers_url":"https://api.github.com/users/spacewander/followers","following_url":"https://api.github.com/users/spacewander/following{/other_user}","gists_url":"https://api.github.com/users/spacewander/gists{/gist_id}","starred_url":"https://api.github.com/users/spacewander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacewander/subscriptions","organizations_url":"https://api.github.com/users/spacewander/orgs","repos_url":"https://api.github.com/users/spacewander/repos","events_url":"https://api.github.com/users/spacewander/events{/privacy}","received_events_url":"https://api.github.com/users/spacewander/received_events","type":"User","site_admin":false},"body":"The http lua module doesn't have the same issue.\r\n\r\nhttps://github.com/openresty/lua-nginx-module/blob/master/src/ngx_http_lua_balancer.c#L176\r\n> p = ngx_palloc(cf->pool, sizeof(\"balancer_by_lua\") + NGX_HTTP_LUA_INLINE_KEY_LEN);","created_at":"2018-03-13T02:14:52Z","updated_at":"2018-03-13T02:14:52Z","html_url":"https://github.com/openresty/stream-lua-nginx-module/pull/97#discussion_r173999771","pull_request_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments/173999771"},"html":{"href":"https://github.com/openresty/stream-lua-nginx-module/pull/97#discussion_r173999771"},"pull_request":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97"}},"in_reply_to_id":173352472},"pull_request":{"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97","id":172635562,"html_url":"https://github.com/openresty/stream-lua-nginx-module/pull/97","diff_url":"https://github.com/openresty/stream-lua-nginx-module/pull/97.diff","patch_url":"https://github.com/openresty/stream-lua-nginx-module/pull/97.patch","issue_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/97","number":97,"state":"open","locked":false,"title":"synchronized to meta-lua-nginx-module #b947ca1 and fixed failing tests.","user":{"login":"dndx","id":1131072,"avatar_url":"https://avatars2.githubusercontent.com/u/1131072?v=4","gravatar_id":"","url":"https://api.github.com/users/dndx","html_url":"https://github.com/dndx","followers_url":"https://api.github.com/users/dndx/followers","following_url":"https://api.github.com/users/dndx/following{/other_user}","gists_url":"https://api.github.com/users/dndx/gists{/gist_id}","starred_url":"https://api.github.com/users/dndx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dndx/subscriptions","organizations_url":"https://api.github.com/users/dndx/orgs","repos_url":"https://api.github.com/users/dndx/repos","events_url":"https://api.github.com/users/dndx/events{/privacy}","received_events_url":"https://api.github.com/users/dndx/received_events","type":"User","site_admin":false},"body":"Changes were generated from https://github.com/openresty/meta-lua-nginx-module/pull/26 using latest `mini-tt2.pl`.","created_at":"2018-03-03T00:19:45Z","updated_at":"2018-03-13T02:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e17cfb66ebae3355608173d0eeff3d2337715d5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"agentzh","id":56241,"avatar_url":"https://avatars1.githubusercontent.com/u/56241?v=4","gravatar_id":"","url":"https://api.github.com/users/agentzh","html_url":"https://github.com/agentzh","followers_url":"https://api.github.com/users/agentzh/followers","following_url":"https://api.github.com/users/agentzh/following{/other_user}","gists_url":"https://api.github.com/users/agentzh/gists{/gist_id}","starred_url":"https://api.github.com/users/agentzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentzh/subscriptions","organizations_url":"https://api.github.com/users/agentzh/orgs","repos_url":"https://api.github.com/users/agentzh/repos","events_url":"https://api.github.com/users/agentzh/events{/privacy}","received_events_url":"https://api.github.com/users/agentzh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97/commits","review_comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97/comments","review_comment_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/97/comments","statuses_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/60ac8e44eacec851d60403ff37817dbd39fb3d18","head":{"label":"openresty:datong/update","ref":"datong/update","sha":"60ac8e44eacec851d60403ff37817dbd39fb3d18","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars1.githubusercontent.com/u/7390180?v=4","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":49554190,"name":"stream-lua-nginx-module","full_name":"openresty/stream-lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars1.githubusercontent.com/u/7390180?v=4","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/stream-lua-nginx-module","description":"Embed the power of Lua into NGINX TCP/UDP servers","fork":false,"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/deployments","created_at":"2016-01-13T06:23:38Z","updated_at":"2018-03-13T01:33:23Z","pushed_at":"2018-03-03T00:19:45Z","git_url":"git://github.com/openresty/stream-lua-nginx-module.git","ssh_url":"git@github.com:openresty/stream-lua-nginx-module.git","clone_url":"https://github.com/openresty/stream-lua-nginx-module.git","svn_url":"https://github.com/openresty/stream-lua-nginx-module","homepage":"","size":765,"stargazers_count":375,"watchers_count":375,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":102,"open_issues":15,"watchers":375,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"d4757341ef2e5ec7faa4224c7830386f32bddd6a","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars1.githubusercontent.com/u/7390180?v=4","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":49554190,"name":"stream-lua-nginx-module","full_name":"openresty/stream-lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars1.githubusercontent.com/u/7390180?v=4","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/stream-lua-nginx-module","description":"Embed the power of Lua into NGINX TCP/UDP servers","fork":false,"url":"https://api.github.com/repos/openresty/stream-lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/stream-lua-nginx-module/deployments","created_at":"2016-01-13T06:23:38Z","updated_at":"2018-03-13T01:33:23Z","pushed_at":"2018-03-03T00:19:45Z","git_url":"git://github.com/openresty/stream-lua-nginx-module.git","ssh_url":"git@github.com:openresty/stream-lua-nginx-module.git","clone_url":"https://github.com/openresty/stream-lua-nginx-module.git","svn_url":"https://github.com/openresty/stream-lua-nginx-module","homepage":"","size":765,"stargazers_count":375,"watchers_count":375,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":102,"open_issues":15,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97"},"html":{"href":"https://github.com/openresty/stream-lua-nginx-module/pull/97"},"issue":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/97"},"comments":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/stream-lua-nginx-module/statuses/60ac8e44eacec851d60403ff37817dbd39fb3d18"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spacewander"}}