{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5778","repository_url":"https://api.github.com/repos/Microsoft/visualfsharp","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5778/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5778/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5778/events","html_url":"https://github.com/Microsoft/visualfsharp/pull/5778","id":370784473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzg0MzM2","number":5778,"title":"Fix #5531","user":{"login":"realvictorprm","id":25414896,"node_id":"MDQ6VXNlcjI1NDE0ODk2","avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-16T20:24:23Z","updated_at":"2018-10-18T12:30:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/5778","html_url":"https://github.com/Microsoft/visualfsharp/pull/5778","diff_url":"https://github.com/Microsoft/visualfsharp/pull/5778.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/5778.patch"},"body":"This is a working fix for the example of #5531.\r\nHowever there are still some points open before I think it's a good idea to merge this:\r\n- [ ] Discuss the change of this proposal, is it OK to prefer overrides of methods and so ignore base implementations?\r\n- [x] Extend the check to the complete inheritance graph instead of a single \"look-back\"\r\n- [x] Only ignore a methinfo if the signature of both match (so respect different overloads)\r\n\r\n@dsyme It would be great if you could have a look whether this check is allowed at this location or should appear earlier."},"comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/430989987","html_url":"https://github.com/Microsoft/visualfsharp/pull/5778#issuecomment-430989987","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5778","id":430989987,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDk4OTk4Nw==","user":{"login":"realvictorprm","id":25414896,"node_id":"MDQ6VXNlcjI1NDE0ODk2","avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T12:30:20Z","updated_at":"2018-10-18T12:30:20Z","author_association":"CONTRIBUTOR","body":"I'll find out where this call can be added to apply the same effect as my current code + add tests for the change."}}
{"actor":{"display_login":"realvictorprm"}}