{"action":"created","issue":{"url":"https://api.github.com/repos/shrinerb/shrine/issues/300","repository_url":"https://api.github.com/repos/shrinerb/shrine","labels_url":"https://api.github.com/repos/shrinerb/shrine/issues/300/labels{/name}","comments_url":"https://api.github.com/repos/shrinerb/shrine/issues/300/comments","events_url":"https://api.github.com/repos/shrinerb/shrine/issues/300/events","html_url":"https://github.com/shrinerb/shrine/pull/300","id":365612935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDkyMzQ1","number":300,"title":"Add a note regarding S3 performance on storage folder structure","user":{"login":"hmistry","id":1156987,"node_id":"MDQ6VXNlcjExNTY5ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1156987?v=4","gravatar_id":"","url":"https://api.github.com/users/hmistry","html_url":"https://github.com/hmistry","followers_url":"https://api.github.com/users/hmistry/followers","following_url":"https://api.github.com/users/hmistry/following{/other_user}","gists_url":"https://api.github.com/users/hmistry/gists{/gist_id}","starred_url":"https://api.github.com/users/hmistry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmistry/subscriptions","organizations_url":"https://api.github.com/users/hmistry/orgs","repos_url":"https://api.github.com/users/hmistry/repos","events_url":"https://api.github.com/users/hmistry/events{/privacy}","received_events_url":"https://api.github.com/users/hmistry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-01T19:43:01Z","updated_at":"2018-10-01T22:39:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/shrinerb/shrine/pulls/300","html_url":"https://github.com/shrinerb/shrine/pull/300","diff_url":"https://github.com/shrinerb/shrine/pull/300.diff","patch_url":"https://github.com/shrinerb/shrine/pull/300.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/shrinerb/shrine/issues/comments/426087757","html_url":"https://github.com/shrinerb/shrine/pull/300#issuecomment-426087757","issue_url":"https://api.github.com/repos/shrinerb/shrine/issues/300","id":426087757,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjA4Nzc1Nw==","user":{"login":"janko-m","id":795488,"node_id":"MDQ6VXNlcjc5NTQ4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/795488?v=4","gravatar_id":"","url":"https://api.github.com/users/janko-m","html_url":"https://github.com/janko-m","followers_url":"https://api.github.com/users/janko-m/followers","following_url":"https://api.github.com/users/janko-m/following{/other_user}","gists_url":"https://api.github.com/users/janko-m/gists{/gist_id}","starred_url":"https://api.github.com/users/janko-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janko-m/subscriptions","organizations_url":"https://api.github.com/users/janko-m/orgs","repos_url":"https://api.github.com/users/janko-m/repos","events_url":"https://api.github.com/users/janko-m/events{/privacy}","received_events_url":"https://api.github.com/users/janko-m/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T22:39:26Z","updated_at":"2018-10-01T22:39:26Z","author_association":"MEMBER","body":"Thanks for the PR!\r\n\r\nI don't think it's necessary to have S3-specific guidelines in the `pretty_location` plugin documentation, especially because these are not related. I first thought they might be a little related, because Amazon S3 docs used to recommend inverting incrementing integers for better partitioning, but now this doesn't seem like a requirement anymore.\r\n\r\nIn the `Shrine::Storage::S3` documentation I would just note that there are per-prefix limits to req/s (maybe mentioning current limits), and recommend people to use prefixes if they need to scale further. \r\nAnyway, I think just loading the `pretty_location` plugin should do it."}}
{"actor":{"display_login":"janko-m"}}