{"action":"created","comment":{"url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments/233101120","pull_request_review_id":174441358,"id":233101120,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzEwMTEyMA==","diff_hunk":"@@ -98,13 +101,15 @@ public ServerConnector create(HttpsConnectorConfig config) {\n         private final ConfigurableUnwiseCharsEncoder unwiseCharEncoder;\n         private final Optional<SslContext> sslContext;\n         private final ResponseEnhancer responseEnhancer;\n+        private final RequestTracker requestTracker;\n \n         private ProxyConnector(HttpConnectorConfig config,\n                                NettyServerConfig serverConfig,\n                                MetricRegistry metrics,\n                                HttpErrorStatusListener errorStatusListener,\n                                String unwiseCharacters,\n-                               ResponseEnhancer responseEnhancer) {\n+                               ResponseEnhancer responseEnhancer,\n+                               Boolean requestTracking) {","path":"components/proxy/src/main/java/com/hotels/styx/proxy/ProxyConnectorFactory.java","position":70,"original_position":70,"commit_id":"1f18606530a45b1064b6450ea4d49cd0425d4186","original_commit_id":"1f18606530a45b1064b6450ea4d49cd0425d4186","user":{"login":"kvosper","id":5182059,"node_id":"MDQ6VXNlcjUxODIwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5182059?v=4","gravatar_id":"","url":"https://api.github.com/users/kvosper","html_url":"https://github.com/kvosper","followers_url":"https://api.github.com/users/kvosper/followers","following_url":"https://api.github.com/users/kvosper/following{/other_user}","gists_url":"https://api.github.com/users/kvosper/gists{/gist_id}","starred_url":"https://api.github.com/users/kvosper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvosper/subscriptions","organizations_url":"https://api.github.com/users/kvosper/orgs","repos_url":"https://api.github.com/users/kvosper/repos","events_url":"https://api.github.com/users/kvosper/events{/privacy}","received_events_url":"https://api.github.com/users/kvosper/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n                               boolean requestTracking) {\r\n```","created_at":"2018-11-13T15:55:16Z","updated_at":"2018-11-13T15:59:14Z","html_url":"https://github.com/HotelsDotCom/styx/pull/341#discussion_r233101120","pull_request_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments/233101120"},"html":{"href":"https://github.com/HotelsDotCom/styx/pull/341#discussion_r233101120"},"pull_request":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341","id":230526064,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTI2MDY0","html_url":"https://github.com/HotelsDotCom/styx/pull/341","diff_url":"https://github.com/HotelsDotCom/styx/pull/341.diff","patch_url":"https://github.com/HotelsDotCom/styx/pull/341.patch","issue_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/341","number":341,"state":"open","locked":false,"title":"Add a config option to enable/disable the request tracking feature.","user":{"login":"mikkokar","id":4540183,"node_id":"MDQ6VXNlcjQ1NDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/4540183?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkokar","html_url":"https://github.com/mikkokar","followers_url":"https://api.github.com/users/mikkokar/followers","following_url":"https://api.github.com/users/mikkokar/following{/other_user}","gists_url":"https://api.github.com/users/mikkokar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkokar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkokar/subscriptions","organizations_url":"https://api.github.com/users/mikkokar/orgs","repos_url":"https://api.github.com/users/mikkokar/repos","events_url":"https://api.github.com/users/mikkokar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkokar/received_events","type":"User","site_admin":false},"body":"This adds a new Styx configuration option `requestTracking` to enable or disable the new request tracking feature. It takes a boolean value `true` to enable and `false` to disable the feature. It defaults to `false`.\r\n","created_at":"2018-11-13T15:47:32Z","updated_at":"2018-11-13T15:59:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd620c0323b5650f966994c2e58bdab52343ed89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dvlato","id":25137038,"node_id":"MDQ6VXNlcjI1MTM3MDM4","avatar_url":"https://avatars0.githubusercontent.com/u/25137038?v=4","gravatar_id":"","url":"https://api.github.com/users/dvlato","html_url":"https://github.com/dvlato","followers_url":"https://api.github.com/users/dvlato/followers","following_url":"https://api.github.com/users/dvlato/following{/other_user}","gists_url":"https://api.github.com/users/dvlato/gists{/gist_id}","starred_url":"https://api.github.com/users/dvlato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvlato/subscriptions","organizations_url":"https://api.github.com/users/dvlato/orgs","repos_url":"https://api.github.com/users/dvlato/repos","events_url":"https://api.github.com/users/dvlato/events{/privacy}","received_events_url":"https://api.github.com/users/dvlato/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341/commits","review_comments_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341/comments","review_comment_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/341/comments","statuses_url":"https://api.github.com/repos/HotelsDotCom/styx/statuses/1f18606530a45b1064b6450ea4d49cd0425d4186","head":{"label":"mikkokar:request-tracker-optional-feature","ref":"request-tracker-optional-feature","sha":"1f18606530a45b1064b6450ea4d49cd0425d4186","user":{"login":"mikkokar","id":4540183,"node_id":"MDQ6VXNlcjQ1NDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/4540183?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkokar","html_url":"https://github.com/mikkokar","followers_url":"https://api.github.com/users/mikkokar/followers","following_url":"https://api.github.com/users/mikkokar/following{/other_user}","gists_url":"https://api.github.com/users/mikkokar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkokar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkokar/subscriptions","organizations_url":"https://api.github.com/users/mikkokar/orgs","repos_url":"https://api.github.com/users/mikkokar/repos","events_url":"https://api.github.com/users/mikkokar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkokar/received_events","type":"User","site_admin":false},"repo":{"id":107119976,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMTk5NzY=","name":"styx","full_name":"mikkokar/styx","private":false,"owner":{"login":"mikkokar","id":4540183,"node_id":"MDQ6VXNlcjQ1NDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/4540183?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkokar","html_url":"https://github.com/mikkokar","followers_url":"https://api.github.com/users/mikkokar/followers","following_url":"https://api.github.com/users/mikkokar/following{/other_user}","gists_url":"https://api.github.com/users/mikkokar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkokar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkokar/subscriptions","organizations_url":"https://api.github.com/users/mikkokar/orgs","repos_url":"https://api.github.com/users/mikkokar/repos","events_url":"https://api.github.com/users/mikkokar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkokar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikkokar/styx","description":"Programmable, asynchronous, event-based reverse proxy for JVM.","fork":true,"url":"https://api.github.com/repos/mikkokar/styx","forks_url":"https://api.github.com/repos/mikkokar/styx/forks","keys_url":"https://api.github.com/repos/mikkokar/styx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikkokar/styx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikkokar/styx/teams","hooks_url":"https://api.github.com/repos/mikkokar/styx/hooks","issue_events_url":"https://api.github.com/repos/mikkokar/styx/issues/events{/number}","events_url":"https://api.github.com/repos/mikkokar/styx/events","assignees_url":"https://api.github.com/repos/mikkokar/styx/assignees{/user}","branches_url":"https://api.github.com/repos/mikkokar/styx/branches{/branch}","tags_url":"https://api.github.com/repos/mikkokar/styx/tags","blobs_url":"https://api.github.com/repos/mikkokar/styx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikkokar/styx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikkokar/styx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikkokar/styx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikkokar/styx/statuses/{sha}","languages_url":"https://api.github.com/repos/mikkokar/styx/languages","stargazers_url":"https://api.github.com/repos/mikkokar/styx/stargazers","contributors_url":"https://api.github.com/repos/mikkokar/styx/contributors","subscribers_url":"https://api.github.com/repos/mikkokar/styx/subscribers","subscription_url":"https://api.github.com/repos/mikkokar/styx/subscription","commits_url":"https://api.github.com/repos/mikkokar/styx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikkokar/styx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikkokar/styx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikkokar/styx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikkokar/styx/contents/{+path}","compare_url":"https://api.github.com/repos/mikkokar/styx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikkokar/styx/merges","archive_url":"https://api.github.com/repos/mikkokar/styx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikkokar/styx/downloads","issues_url":"https://api.github.com/repos/mikkokar/styx/issues{/number}","pulls_url":"https://api.github.com/repos/mikkokar/styx/pulls{/number}","milestones_url":"https://api.github.com/repos/mikkokar/styx/milestones{/number}","notifications_url":"https://api.github.com/repos/mikkokar/styx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikkokar/styx/labels{/name}","releases_url":"https://api.github.com/repos/mikkokar/styx/releases{/id}","deployments_url":"https://api.github.com/repos/mikkokar/styx/deployments","created_at":"2017-10-16T11:45:05Z","updated_at":"2018-11-02T12:15:10Z","pushed_at":"2018-11-13T15:44:26Z","git_url":"git://github.com/mikkokar/styx.git","ssh_url":"git@github.com:mikkokar/styx.git","clone_url":"https://github.com/mikkokar/styx.git","svn_url":"https://github.com/mikkokar/styx","homepage":"","size":4212,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HotelsDotCom:master","ref":"master","sha":"aa825f8e070c88e1fd98c087bd73e38faa7a4c45","user":{"login":"HotelsDotCom","id":8900689,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDA2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"repo":{"id":106841635,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4NDE2MzU=","name":"styx","full_name":"HotelsDotCom/styx","private":false,"owner":{"login":"HotelsDotCom","id":8900689,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MDA2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/8900689?v=4","gravatar_id":"","url":"https://api.github.com/users/HotelsDotCom","html_url":"https://github.com/HotelsDotCom","followers_url":"https://api.github.com/users/HotelsDotCom/followers","following_url":"https://api.github.com/users/HotelsDotCom/following{/other_user}","gists_url":"https://api.github.com/users/HotelsDotCom/gists{/gist_id}","starred_url":"https://api.github.com/users/HotelsDotCom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HotelsDotCom/subscriptions","organizations_url":"https://api.github.com/users/HotelsDotCom/orgs","repos_url":"https://api.github.com/users/HotelsDotCom/repos","events_url":"https://api.github.com/users/HotelsDotCom/events{/privacy}","received_events_url":"https://api.github.com/users/HotelsDotCom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HotelsDotCom/styx","description":"Programmable, asynchronous, event-based reverse proxy for JVM.","fork":false,"url":"https://api.github.com/repos/HotelsDotCom/styx","forks_url":"https://api.github.com/repos/HotelsDotCom/styx/forks","keys_url":"https://api.github.com/repos/HotelsDotCom/styx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HotelsDotCom/styx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HotelsDotCom/styx/teams","hooks_url":"https://api.github.com/repos/HotelsDotCom/styx/hooks","issue_events_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/events{/number}","events_url":"https://api.github.com/repos/HotelsDotCom/styx/events","assignees_url":"https://api.github.com/repos/HotelsDotCom/styx/assignees{/user}","branches_url":"https://api.github.com/repos/HotelsDotCom/styx/branches{/branch}","tags_url":"https://api.github.com/repos/HotelsDotCom/styx/tags","blobs_url":"https://api.github.com/repos/HotelsDotCom/styx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HotelsDotCom/styx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HotelsDotCom/styx/git/refs{/sha}","trees_url":"https://api.github.com/repos/HotelsDotCom/styx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HotelsDotCom/styx/statuses/{sha}","languages_url":"https://api.github.com/repos/HotelsDotCom/styx/languages","stargazers_url":"https://api.github.com/repos/HotelsDotCom/styx/stargazers","contributors_url":"https://api.github.com/repos/HotelsDotCom/styx/contributors","subscribers_url":"https://api.github.com/repos/HotelsDotCom/styx/subscribers","subscription_url":"https://api.github.com/repos/HotelsDotCom/styx/subscription","commits_url":"https://api.github.com/repos/HotelsDotCom/styx/commits{/sha}","git_commits_url":"https://api.github.com/repos/HotelsDotCom/styx/git/commits{/sha}","comments_url":"https://api.github.com/repos/HotelsDotCom/styx/comments{/number}","issue_comment_url":"https://api.github.com/repos/HotelsDotCom/styx/issues/comments{/number}","contents_url":"https://api.github.com/repos/HotelsDotCom/styx/contents/{+path}","compare_url":"https://api.github.com/repos/HotelsDotCom/styx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HotelsDotCom/styx/merges","archive_url":"https://api.github.com/repos/HotelsDotCom/styx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HotelsDotCom/styx/downloads","issues_url":"https://api.github.com/repos/HotelsDotCom/styx/issues{/number}","pulls_url":"https://api.github.com/repos/HotelsDotCom/styx/pulls{/number}","milestones_url":"https://api.github.com/repos/HotelsDotCom/styx/milestones{/number}","notifications_url":"https://api.github.com/repos/HotelsDotCom/styx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HotelsDotCom/styx/labels{/name}","releases_url":"https://api.github.com/repos/HotelsDotCom/styx/releases{/id}","deployments_url":"https://api.github.com/repos/HotelsDotCom/styx/deployments","created_at":"2017-10-13T15:27:53Z","updated_at":"2018-11-13T13:50:22Z","pushed_at":"2018-11-13T15:47:32Z","git_url":"git://github.com/HotelsDotCom/styx.git","ssh_url":"git@github.com:HotelsDotCom/styx.git","clone_url":"https://github.com/HotelsDotCom/styx.git","svn_url":"https://github.com/HotelsDotCom/styx","homepage":"","size":3640,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":24,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341"},"html":{"href":"https://github.com/HotelsDotCom/styx/pull/341"},"issue":{"href":"https://api.github.com/repos/HotelsDotCom/styx/issues/341"},"comments":{"href":"https://api.github.com/repos/HotelsDotCom/styx/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HotelsDotCom/styx/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/HotelsDotCom/styx/statuses/1f18606530a45b1064b6450ea4d49cd0425d4186"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kvosper"}}