{"action":"created","issue":{"url":"https://api.github.com/repos/src-d/lookout/issues/135","repository_url":"https://api.github.com/repos/src-d/lookout","labels_url":"https://api.github.com/repos/src-d/lookout/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/src-d/lookout/issues/135/comments","events_url":"https://api.github.com/repos/src-d/lookout/issues/135/events","html_url":"https://github.com/src-d/lookout/pull/135","id":350352986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjIzMzUx","number":135,"title":"SDK Integration tests on macOS","user":{"login":"carlosms","id":1469173,"node_id":"MDQ6VXNlcjE0NjkxNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1469173?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosms","html_url":"https://github.com/carlosms","followers_url":"https://api.github.com/users/carlosms/followers","following_url":"https://api.github.com/users/carlosms/following{/other_user}","gists_url":"https://api.github.com/users/carlosms/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosms/subscriptions","organizations_url":"https://api.github.com/users/carlosms/orgs","repos_url":"https://api.github.com/users/carlosms/repos","events_url":"https://api.github.com/users/carlosms/events{/privacy}","received_events_url":"https://api.github.com/users/carlosms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-14T09:39:38Z","updated_at":"2018-08-14T11:45:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/src-d/lookout/pulls/135","html_url":"https://github.com/src-d/lookout/pull/135","diff_url":"https://github.com/src-d/lookout/pull/135.diff","patch_url":"https://github.com/src-d/lookout/pull/135.patch"},"body":"Fix #105.\r\n\r\nI refactored the existing `main.go` to be a go test. This way we can use the `short` flag, and other nice things like `-timeout`, `-run` individual tests, etc.\r\n\r\nIf you guys agree I'd like to refactor `server-test/main.go` to be a test also, and use testing assertions in `util/cmdtest`.\r\n\r\nFor travis the condition is not `if: branch = master` because for PRs that is the base branch name, so it would run for every PR against master."},"comment":{"url":"https://api.github.com/repos/src-d/lookout/issues/comments/412844756","html_url":"https://github.com/src-d/lookout/pull/135#issuecomment-412844756","issue_url":"https://api.github.com/repos/src-d/lookout/issues/135","id":412844756,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjg0NDc1Ng==","user":{"login":"smacker","id":406916,"node_id":"MDQ6VXNlcjQwNjkxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/406916?v=4","gravatar_id":"","url":"https://api.github.com/users/smacker","html_url":"https://github.com/smacker","followers_url":"https://api.github.com/users/smacker/followers","following_url":"https://api.github.com/users/smacker/following{/other_user}","gists_url":"https://api.github.com/users/smacker/gists{/gist_id}","starred_url":"https://api.github.com/users/smacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smacker/subscriptions","organizations_url":"https://api.github.com/users/smacker/orgs","repos_url":"https://api.github.com/users/smacker/repos","events_url":"https://api.github.com/users/smacker/events{/privacy}","received_events_url":"https://api.github.com/users/smacker/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T11:45:58Z","updated_at":"2018-08-14T11:45:58Z","author_association":"MEMBER","body":"I have doubts about using test package for integration tests.\r\n\r\n`-integration` tag doesn't really work in real life.\r\n\r\n```\r\n$ go test -integration ./...\r\nflag provided but not defined: -integration\r\n```\r\n\r\n\r\nWe can't use almost any flags here, like `-parallel`, `-timeout`.\r\nThe only one that will work `-run regexp`. Most of other fill just fail tests which is kind of unexpected when you run `go test`.\r\n\r\nOverall I think running them using `go test` is confusing. "}}
{"actor":{"display_login":"smacker"}}