{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/192582227","pull_request_review_id":125388320,"id":192582227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU4MjIyNw==","diff_hunk":"@@ -0,0 +1,87 @@\n+/**\n+ * @copyright  Copyright (C) 2005 - 2018 Open Source Matters, Inc. All rights reserved.\n+ * @license    GNU General Public License version 2 or later; see LICENSE.txt\n+ */\n+\n+((customElements) => {\n+  'use strict';\n+\n+  class JoomlaToolbarButton extends HTMLElement {\n+\n+    // Attribute getters\n+    get task() {return this.getAttribute('task');}\n+    get listSelection() {return this.hasAttribute('list-selection');}\n+    get form() {return this.getAttribute('form');}","path":"build/webcomponents/js/toolbar-button/toolbar-button.js","position":14,"original_position":14,"commit_id":"88f508c57acf57bdb0aca3ae45d52b91e005163e","original_commit_id":"88f508c57acf57bdb0aca3ae45d52b91e005163e","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Requires a space after '{'               block-spacing<br>Requires a space before '}'              block-spacing","created_at":"2018-06-03T08:51:00Z","updated_at":"2018-06-03T08:51:01Z","html_url":"https://github.com/joomla/joomla-cms/pull/20650#discussion_r192582227","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/192582227"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/20650#discussion_r192582227"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650","id":192205674,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjA1Njc0","html_url":"https://github.com/joomla/joomla-cms/pull/20650","diff_url":"https://github.com/joomla/joomla-cms/pull/20650.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20650.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20650","number":20650,"state":"open","locked":false,"title":"[4.0][RFC] Custom Element: Joomla! Toolbar button","user":{"login":"Fedik","id":1568198,"node_id":"MDQ6VXNlcjE1NjgxOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1568198?v=4","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"body":"This is redo of #19635 \r\n\r\nThis patch add `<joomla-toolbar-button/>` custom element, to standard toolbar button.\r\nIt allow us to move most of inline onclick=\"\" to separate file.\r\n\r\nCurrently it only for `StandardButton`.\r\n\r\n### Testing Instructions\r\nClick the toolbar buttons here and there, and make sure all works as expected, as before the patch.\r\n\r\n\r\n\r\nping @dgrammatiko @wilsonge ","created_at":"2018-06-02T16:24:55Z","updated_at":"2018-06-03T08:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b40a17149fcd64086669ef1d045d912e0efb65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false},{"id":31297684,"node_id":"MDU6TGFiZWwzMTI5NzY4NA==","url":"https://api.github.com/repos/joomla/joomla-cms/labels/Request%20for%20Comment","name":"Request for Comment","color":"02d7e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20650/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/88f508c57acf57bdb0aca3ae45d52b91e005163e","head":{"label":"Fedik:toolbar-button2","ref":"toolbar-button2","sha":"88f508c57acf57bdb0aca3ae45d52b91e005163e","user":{"login":"Fedik","id":1568198,"node_id":"MDQ6VXNlcjE1NjgxOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1568198?v=4","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"repo":{"id":7179494,"node_id":"MDEwOlJlcG9zaXRvcnk3MTc5NDk0","name":"joomla-cms","full_name":"Fedik/joomla-cms","owner":{"login":"Fedik","id":1568198,"node_id":"MDQ6VXNlcjE1NjgxOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1568198?v=4","gravatar_id":"","url":"https://api.github.com/users/Fedik","html_url":"https://github.com/Fedik","followers_url":"https://api.github.com/users/Fedik/followers","following_url":"https://api.github.com/users/Fedik/following{/other_user}","gists_url":"https://api.github.com/users/Fedik/gists{/gist_id}","starred_url":"https://api.github.com/users/Fedik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fedik/subscriptions","organizations_url":"https://api.github.com/users/Fedik/orgs","repos_url":"https://api.github.com/users/Fedik/repos","events_url":"https://api.github.com/users/Fedik/events{/privacy}","received_events_url":"https://api.github.com/users/Fedik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fedik/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Fedik/joomla-cms","forks_url":"https://api.github.com/repos/Fedik/joomla-cms/forks","keys_url":"https://api.github.com/repos/Fedik/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fedik/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fedik/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Fedik/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Fedik/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Fedik/joomla-cms/events","assignees_url":"https://api.github.com/repos/Fedik/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Fedik/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Fedik/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Fedik/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fedik/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fedik/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fedik/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fedik/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Fedik/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Fedik/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Fedik/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Fedik/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Fedik/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Fedik/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fedik/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fedik/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fedik/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fedik/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Fedik/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fedik/joomla-cms/merges","archive_url":"https://api.github.com/repos/Fedik/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fedik/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Fedik/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Fedik/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Fedik/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Fedik/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fedik/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Fedik/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Fedik/joomla-cms/deployments","created_at":"2012-12-15T13:09:18Z","updated_at":"2018-01-09T18:07:35Z","pushed_at":"2018-06-03T08:50:43Z","git_url":"git://github.com/Fedik/joomla-cms.git","ssh_url":"git@github.com:Fedik/joomla-cms.git","clone_url":"https://github.com/Fedik/joomla-cms.git","svn_url":"https://github.com/Fedik/joomla-cms","homepage":"http://joomla.org","size":237551,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"55cd3bba6637bfab468f4e9eef8b9d770a33eb48","user":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY0OTA4","name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-06-02T21:33:27Z","pushed_at":"2018-06-03T08:50:45Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":235503,"stargazers_count":2747,"watchers_count":2747,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2698,"mirror_url":null,"archived":false,"open_issues_count":814,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2698,"open_issues":814,"watchers":2747,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/20650"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/20650"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/20650/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20650/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/88f508c57acf57bdb0aca3ae45d52b91e005163e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}