{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments/226705064","pull_request_review_id":166599258,"id":226705064,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjcwNTA2NA==","diff_hunk":"@@ -20,6 +21,8 @@ const (\n type OdoSettings struct {\n \t// Controls if an update notification is shown or not\n \tUpdateNotification *bool `json:\"updatenotification,omitempty\"`\n+\t// Holds the prefix part of generated random application name\n+\tPrefix *string `json:\"prefix,omitempty\"`","path":"pkg/config/config.go","position":22,"original_position":13,"commit_id":"7ee45337c9b0287c1b705311458c3dbc481e60b9","original_commit_id":"57a653f04a4e4703a58649d167e0887f9b8a9da3","user":{"login":"anmolbabu","id":3525639,"node_id":"MDQ6VXNlcjM1MjU2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3525639?v=4","gravatar_id":"","url":"https://api.github.com/users/anmolbabu","html_url":"https://github.com/anmolbabu","followers_url":"https://api.github.com/users/anmolbabu/followers","following_url":"https://api.github.com/users/anmolbabu/following{/other_user}","gists_url":"https://api.github.com/users/anmolbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/anmolbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmolbabu/subscriptions","organizations_url":"https://api.github.com/users/anmolbabu/orgs","repos_url":"https://api.github.com/users/anmolbabu/repos","events_url":"https://api.github.com/users/anmolbabu/events{/privacy}","received_events_url":"https://api.github.com/users/anmolbabu/received_events","type":"User","site_admin":false},"body":"Would AutoGenNamePrefix be good enough?","created_at":"2018-10-19T16:22:56Z","updated_at":"2018-10-19T16:22:56Z","html_url":"https://github.com/redhat-developer/odo/pull/741#discussion_r226705064","pull_request_url":"https://api.github.com/repos/redhat-developer/odo/pulls/741","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments/226705064"},"html":{"href":"https://github.com/redhat-developer/odo/pull/741#discussion_r226705064"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/741"}},"in_reply_to_id":219466945},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/odo/pulls/741","id":215785739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Nzg1NzM5","html_url":"https://github.com/redhat-developer/odo/pull/741","diff_url":"https://github.com/redhat-developer/odo/pull/741.diff","patch_url":"https://github.com/redhat-developer/odo/pull/741.patch","issue_url":"https://api.github.com/repos/redhat-developer/odo/issues/741","number":741,"state":"open","locked":false,"title":"Provision configurable generation of app and component names making them non-mandatory to be passed","user":{"login":"anmolbabu","id":3525639,"node_id":"MDQ6VXNlcjM1MjU2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3525639?v=4","gravatar_id":"","url":"https://api.github.com/users/anmolbabu","html_url":"https://github.com/anmolbabu","followers_url":"https://api.github.com/users/anmolbabu/followers","following_url":"https://api.github.com/users/anmolbabu/following{/other_user}","gists_url":"https://api.github.com/users/anmolbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/anmolbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmolbabu/subscriptions","organizations_url":"https://api.github.com/users/anmolbabu/orgs","repos_url":"https://api.github.com/users/anmolbabu/repos","events_url":"https://api.github.com/users/anmolbabu/events{/privacy}","received_events_url":"https://api.github.com/users/anmolbabu/received_events","type":"User","site_admin":false},"body":"Provision configurable generation of app and component names making them non-mandatory to be passed\r\n    \r\nBy default(in absence of prefix in config being overriden) app and component\r\nnames will be named after the directory from which `odo app create` and\r\n`odo create` components are used along with a random 4 char length string as\r\nunique suffix. However, if the prefix in config is overriden by user, the same\r\nwill be used instead of fetching any directory/path names along with the random\r\n4 char length string unique suffix..\r\nThis is achieved as follows:\r\n1. For component create, in absence of `prefix` being overriden by user in the\r\nodo config:\r\n   a. If component is created from git, the git url's ending part which\r\n      is the repository name is used for app and compoennt names. For,\r\n      component name, additionally we use component type also.\r\n      case 1: Component creation in absence of an app\r\n        app name: ${repo_name}-${random_4_char_str}\r\n        component name: ${repo_name}-${component_type}-${random_4_char_str}\r\n      case 2: App exists already\r\n        component name: ${repo_name}-${component_type}-${random_4_char_str}\r\n   b. If component is created from local source, the last part of source path,\r\n      which is the source directory, is used for app and compoennt names. For,\r\n      component name, additionally we use component type also.\r\n      case 1: Component creation in absence of an app\r\n        app name: ${src_dir_name}-${random_4_char_str}\r\n        component name: ${src_dir_name}-${component_type}-${random_4_char_str}\r\n      case 2: App exists already\r\n        component name: ${src_dir_name}-${component_type}-${random_4_char_str}\r\n   c. If component is created from binary, the binary name excluding its extension\r\n      is used for app and compoennt names. For component name, additionally we use\r\n      component type also.\r\n      case 1: Component creation in absence of an app\r\n        app name: ${binary_name}-${random_4_char_str}\r\n        component name: ${binary_name}-${component_type}-${random_4_char_str}\r\n      case 2: App exists already\r\n        component name: ${binary_name}-${component_type}-${random_4_char_str}\r\n2. For app create, in absence of `prefix` being overriden by user in the\r\nodo config:\r\n    app name: ${current-dir}-${random_4_char_str}\r\n3. For app create in case of prefix in config being overriden,\r\n    app name: ${prefix}-${random_4_char_str}\r\n4. For component create, in case of a configured prefix,\r\n    app name: ${prefix}-${random_4_char_str}\r\n    component name: ${prefix}-${component_type}-${random_4_char_str}\r\n\r\nfixes #216\r\nSigned-off-by: anmolbabu <anmolbudugutta@gmail.com>\r\n","created_at":"2018-09-15T19:35:10Z","updated_at":"2018-10-19T16:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ac51881f895359605d5c0fed10b1f40154eb713","assignee":{"login":"anmolbabu","id":3525639,"node_id":"MDQ6VXNlcjM1MjU2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3525639?v=4","gravatar_id":"","url":"https://api.github.com/users/anmolbabu","html_url":"https://github.com/anmolbabu","followers_url":"https://api.github.com/users/anmolbabu/followers","following_url":"https://api.github.com/users/anmolbabu/following{/other_user}","gists_url":"https://api.github.com/users/anmolbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/anmolbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmolbabu/subscriptions","organizations_url":"https://api.github.com/users/anmolbabu/orgs","repos_url":"https://api.github.com/users/anmolbabu/repos","events_url":"https://api.github.com/users/anmolbabu/events{/privacy}","received_events_url":"https://api.github.com/users/anmolbabu/received_events","type":"User","site_admin":false},"assignees":[{"login":"anmolbabu","id":3525639,"node_id":"MDQ6VXNlcjM1MjU2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3525639?v=4","gravatar_id":"","url":"https://api.github.com/users/anmolbabu","html_url":"https://github.com/anmolbabu","followers_url":"https://api.github.com/users/anmolbabu/followers","following_url":"https://api.github.com/users/anmolbabu/following{/other_user}","gists_url":"https://api.github.com/users/anmolbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/anmolbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmolbabu/subscriptions","organizations_url":"https://api.github.com/users/anmolbabu/orgs","repos_url":"https://api.github.com/users/anmolbabu/repos","events_url":"https://api.github.com/users/anmolbabu/events{/privacy}","received_events_url":"https://api.github.com/users/anmolbabu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jorgemoralespou","id":78350,"node_id":"MDQ6VXNlcjc4MzUw","avatar_url":"https://avatars0.githubusercontent.com/u/78350?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgemoralespou","html_url":"https://github.com/jorgemoralespou","followers_url":"https://api.github.com/users/jorgemoralespou/followers","following_url":"https://api.github.com/users/jorgemoralespou/following{/other_user}","gists_url":"https://api.github.com/users/jorgemoralespou/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgemoralespou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgemoralespou/subscriptions","organizations_url":"https://api.github.com/users/jorgemoralespou/orgs","repos_url":"https://api.github.com/users/jorgemoralespou/repos","events_url":"https://api.github.com/users/jorgemoralespou/events{/privacy}","received_events_url":"https://api.github.com/users/jorgemoralespou/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/odo/pulls/741/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/odo/pulls/741/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/odo/issues/741/comments","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/7ee45337c9b0287c1b705311458c3dbc481e60b9","head":{"label":"anmolbabu:fixes#216","ref":"fixes#216","sha":"7ee45337c9b0287c1b705311458c3dbc481e60b9","user":{"login":"anmolbabu","id":3525639,"node_id":"MDQ6VXNlcjM1MjU2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3525639?v=4","gravatar_id":"","url":"https://api.github.com/users/anmolbabu","html_url":"https://github.com/anmolbabu","followers_url":"https://api.github.com/users/anmolbabu/followers","following_url":"https://api.github.com/users/anmolbabu/following{/other_user}","gists_url":"https://api.github.com/users/anmolbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/anmolbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmolbabu/subscriptions","organizations_url":"https://api.github.com/users/anmolbabu/orgs","repos_url":"https://api.github.com/users/anmolbabu/repos","events_url":"https://api.github.com/users/anmolbabu/events{/privacy}","received_events_url":"https://api.github.com/users/anmolbabu/received_events","type":"User","site_admin":false},"repo":{"id":141098025,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEwOTgwMjU=","name":"odo","full_name":"anmolbabu/odo","private":false,"owner":{"login":"anmolbabu","id":3525639,"node_id":"MDQ6VXNlcjM1MjU2Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3525639?v=4","gravatar_id":"","url":"https://api.github.com/users/anmolbabu","html_url":"https://github.com/anmolbabu","followers_url":"https://api.github.com/users/anmolbabu/followers","following_url":"https://api.github.com/users/anmolbabu/following{/other_user}","gists_url":"https://api.github.com/users/anmolbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/anmolbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmolbabu/subscriptions","organizations_url":"https://api.github.com/users/anmolbabu/orgs","repos_url":"https://api.github.com/users/anmolbabu/repos","events_url":"https://api.github.com/users/anmolbabu/events{/privacy}","received_events_url":"https://api.github.com/users/anmolbabu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anmolbabu/odo","description":"OpenShift Command line for Developers","fork":true,"url":"https://api.github.com/repos/anmolbabu/odo","forks_url":"https://api.github.com/repos/anmolbabu/odo/forks","keys_url":"https://api.github.com/repos/anmolbabu/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anmolbabu/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anmolbabu/odo/teams","hooks_url":"https://api.github.com/repos/anmolbabu/odo/hooks","issue_events_url":"https://api.github.com/repos/anmolbabu/odo/issues/events{/number}","events_url":"https://api.github.com/repos/anmolbabu/odo/events","assignees_url":"https://api.github.com/repos/anmolbabu/odo/assignees{/user}","branches_url":"https://api.github.com/repos/anmolbabu/odo/branches{/branch}","tags_url":"https://api.github.com/repos/anmolbabu/odo/tags","blobs_url":"https://api.github.com/repos/anmolbabu/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anmolbabu/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anmolbabu/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/anmolbabu/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anmolbabu/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/anmolbabu/odo/languages","stargazers_url":"https://api.github.com/repos/anmolbabu/odo/stargazers","contributors_url":"https://api.github.com/repos/anmolbabu/odo/contributors","subscribers_url":"https://api.github.com/repos/anmolbabu/odo/subscribers","subscription_url":"https://api.github.com/repos/anmolbabu/odo/subscription","commits_url":"https://api.github.com/repos/anmolbabu/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/anmolbabu/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/anmolbabu/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/anmolbabu/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/anmolbabu/odo/contents/{+path}","compare_url":"https://api.github.com/repos/anmolbabu/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anmolbabu/odo/merges","archive_url":"https://api.github.com/repos/anmolbabu/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anmolbabu/odo/downloads","issues_url":"https://api.github.com/repos/anmolbabu/odo/issues{/number}","pulls_url":"https://api.github.com/repos/anmolbabu/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/anmolbabu/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/anmolbabu/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anmolbabu/odo/labels{/name}","releases_url":"https://api.github.com/repos/anmolbabu/odo/releases{/id}","deployments_url":"https://api.github.com/repos/anmolbabu/odo/deployments","created_at":"2018-07-16T06:50:21Z","updated_at":"2018-10-06T09:52:59Z","pushed_at":"2018-10-19T15:02:39Z","git_url":"git://github.com/anmolbabu/odo.git","ssh_url":"git@github.com:anmolbabu/odo.git","clone_url":"https://github.com/anmolbabu/odo.git","svn_url":"https://github.com/anmolbabu/odo","homepage":"","size":92451,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"65b5bed832c8d307059c7ae66e9d37d2a10fa041","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":118630356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2MzAzNTY=","name":"odo","full_name":"redhat-developer/odo","private":false,"owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redhat-developer/odo","description":"OpenShift Command line for Developers","fork":false,"url":"https://api.github.com/repos/redhat-developer/odo","forks_url":"https://api.github.com/repos/redhat-developer/odo/forks","keys_url":"https://api.github.com/repos/redhat-developer/odo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/odo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/odo/teams","hooks_url":"https://api.github.com/repos/redhat-developer/odo/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/odo/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/odo/events","assignees_url":"https://api.github.com/repos/redhat-developer/odo/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/odo/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/odo/tags","blobs_url":"https://api.github.com/repos/redhat-developer/odo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/odo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/odo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/odo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/odo/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/odo/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/odo/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/odo/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/odo/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/odo/subscription","commits_url":"https://api.github.com/repos/redhat-developer/odo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/odo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/odo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/odo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/odo/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/odo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/odo/merges","archive_url":"https://api.github.com/repos/redhat-developer/odo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/odo/downloads","issues_url":"https://api.github.com/repos/redhat-developer/odo/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/odo/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/odo/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/odo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/odo/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/odo/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/odo/deployments","created_at":"2018-01-23T15:36:17Z","updated_at":"2018-10-18T14:00:05Z","pushed_at":"2018-10-19T15:58:54Z","git_url":"git://github.com/redhat-developer/odo.git","ssh_url":"git@github.com:redhat-developer/odo.git","clone_url":"https://github.com/redhat-developer/odo.git","svn_url":"https://github.com/redhat-developer/odo","homepage":"","size":92345,"stargazers_count":239,"watchers_count":239,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":150,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/741"},"html":{"href":"https://github.com/redhat-developer/odo/pull/741"},"issue":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/741"},"comments":{"href":"https://api.github.com/repos/redhat-developer/odo/issues/741/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/741/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/odo/pulls/741/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/odo/statuses/7ee45337c9b0287c1b705311458c3dbc481e60b9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anmolbabu"}}