{"action":"created","comment":{"url":"https://api.github.com/repos/openscad/openscad/pulls/comments/230255683","pull_request_review_id":170952153,"id":230255683,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDI1NTY4Mw==","diff_hunk":"@@ -766,6 +767,25 @@ build_hidapi()\n   cp hidapi/hidapi.h \"$DEPLOYDIR\"/include/hidapi/\n }\n \n+build_lib3mf()\n+{\n+  version=$1\n+\n+  echo \"Building lib3mf\" $version \"...\"\n+  cd $BASEDIR/src\n+  rm -rf lib3mf-$version\n+  if [ ! -f $version.tar.gz ]; then\n+    curl -LO https://github.com/3MFConsortium/lib3mf/archive/$version.tar.gz\n+  fi\n+  tar xzf $version.tar.gz\n+  cd lib3mf-$version\n+  CXXFLAGS=\"$CXXSTDFLAGS\" make CC=cc CXX=c++ LD=c++ LDFLAGS=\"$LDSTDFLAGS\" -j\"$NUMCPU\" -C Project/Lib3MFGCC\n+  make -j\"$NUMCPU\" -C Project/Lib3MFGCC install INSTALL_ROOT=$DEPLOYDIR\n+#  install_name_tool -id @rpath/libCGAL.dylib $DEPLOYDIR/lib/libCGAL.dylib\n+#  install_name_tool -id @rpath/libCGAL_Core.dylib $DEPLOYDIR/lib/libCGAL_Core.dylib\n+#  install_name_tool -change libCGAL.11.dylib @rpath/libCGAL.dylib $DEPLOYDIR/lib/libCGAL_Core.dylib","path":"scripts/macosx-build-dependencies.sh","position":28,"original_position":28,"commit_id":"2b73b60a99b58c63ca59a6464048034f2a9b2fbf","original_commit_id":"2b73b60a99b58c63ca59a6464048034f2a9b2fbf","user":{"login":"kintel","id":186094,"node_id":"MDQ6VXNlcjE4NjA5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/186094?v=4","gravatar_id":"","url":"https://api.github.com/users/kintel","html_url":"https://github.com/kintel","followers_url":"https://api.github.com/users/kintel/followers","following_url":"https://api.github.com/users/kintel/following{/other_user}","gists_url":"https://api.github.com/users/kintel/gists{/gist_id}","starred_url":"https://api.github.com/users/kintel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kintel/subscriptions","organizations_url":"https://api.github.com/users/kintel/orgs","repos_url":"https://api.github.com/users/kintel/repos","events_url":"https://api.github.com/users/kintel/events{/privacy}","received_events_url":"https://api.github.com/users/kintel/received_events","type":"User","site_admin":false},"body":"Note to self: Have a look at this","created_at":"2018-11-02T02:33:13Z","updated_at":"2018-11-02T02:47:08Z","html_url":"https://github.com/openscad/openscad/pull/1802#discussion_r230255683","pull_request_url":"https://api.github.com/repos/openscad/openscad/pulls/1802","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openscad/openscad/pulls/comments/230255683"},"html":{"href":"https://github.com/openscad/openscad/pull/1802#discussion_r230255683"},"pull_request":{"href":"https://api.github.com/repos/openscad/openscad/pulls/1802"}}},"pull_request":{"url":"https://api.github.com/repos/openscad/openscad/pulls/1802","id":85905035,"node_id":"MDExOlB1bGxSZXF1ZXN0ODU5MDUwMzU=","html_url":"https://github.com/openscad/openscad/pull/1802","diff_url":"https://github.com/openscad/openscad/pull/1802.diff","patch_url":"https://github.com/openscad/openscad/pull/1802.patch","issue_url":"https://api.github.com/repos/openscad/openscad/issues/1802","number":1802,"state":"open","locked":false,"title":"3mf Import/Export","user":{"login":"t-paul","id":1330241,"node_id":"MDQ6VXNlcjEzMzAyNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1330241?v=4","gravatar_id":"","url":"https://api.github.com/users/t-paul","html_url":"https://github.com/t-paul","followers_url":"https://api.github.com/users/t-paul/followers","following_url":"https://api.github.com/users/t-paul/following{/other_user}","gists_url":"https://api.github.com/users/t-paul/gists{/gist_id}","starred_url":"https://api.github.com/users/t-paul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-paul/subscriptions","organizations_url":"https://api.github.com/users/t-paul/orgs","repos_url":"https://api.github.com/users/t-paul/repos","events_url":"https://api.github.com/users/t-paul/events{/privacy}","received_events_url":"https://api.github.com/users/t-paul/received_events","type":"User","site_admin":false},"body":"This adds import and export for the [3MF file format](http://www.3mf.io/) using [lib3mf](https://github.com/3MFConsortium/lib3mf).\n\nSee also #1331.\n\nToDo:\n- [x] Mark as experimental feature\n- [x] Build on Travis Ubuntu 12.04 and 14.04\n- [x] Build on Travis OSX / homebrew (using openscad/homebrew-tap repo)\n- [x] Mac release build (macosx_build_dependencies.sh)\n- [x] Update MXE build (currently stuck, it builds on MXE but using the library crashes)\n- [x] Add patch to MXE build ([MinGW issue](https://sourceforge.net/p/mingw-w64/bugs/565/) - wcstof crashes with endPtr == nullptr)\n- [x] The build system should fail (or at least warn) if lib3mf wasn't found at qmake time.\n- [x] Add \"export-import\" tests (see #1822), similar to how we handle other bidirectional formats, e.g. `add_cmdline_test(offpngtest EXE ${PYTHON_EXECUTABLE} SCRIPT ${CMAKE_SOURCE_DIR}/export_import_pngtest.py ARGS --openscad=${OPENSCAD_BINPATH} --format=OFF --render EXPECTEDDIR monotonepngtest SUFFIX png FILES ${EXPORT3D_TEST_FILES})`\n","created_at":"2016-09-20T03:22:15Z","updated_at":"2018-11-02T02:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4c646d84c60a7792ca6fe4fa46d83f991eb75eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":484673683,"node_id":"MDU6TGFiZWw0ODQ2NzM2ODM=","url":"https://api.github.com/repos/openscad/openscad/labels/Needs%20minor%20work","name":"Needs minor work","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openscad/openscad/pulls/1802/commits","review_comments_url":"https://api.github.com/repos/openscad/openscad/pulls/1802/comments","review_comment_url":"https://api.github.com/repos/openscad/openscad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openscad/openscad/issues/1802/comments","statuses_url":"https://api.github.com/repos/openscad/openscad/statuses/2b73b60a99b58c63ca59a6464048034f2a9b2fbf","head":{"label":"openscad:3mf-import-export","ref":"3mf-import-export","sha":"2b73b60a99b58c63ca59a6464048034f2a9b2fbf","user":{"login":"openscad","id":466370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjM3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/466370?v=4","gravatar_id":"","url":"https://api.github.com/users/openscad","html_url":"https://github.com/openscad","followers_url":"https://api.github.com/users/openscad/followers","following_url":"https://api.github.com/users/openscad/following{/other_user}","gists_url":"https://api.github.com/users/openscad/gists{/gist_id}","starred_url":"https://api.github.com/users/openscad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscad/subscriptions","organizations_url":"https://api.github.com/users/openscad/orgs","repos_url":"https://api.github.com/users/openscad/repos","events_url":"https://api.github.com/users/openscad/events{/privacy}","received_events_url":"https://api.github.com/users/openscad/received_events","type":"Organization","site_admin":false},"repo":{"id":1049088,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MDg4","name":"openscad","full_name":"openscad/openscad","private":false,"owner":{"login":"openscad","id":466370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjM3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/466370?v=4","gravatar_id":"","url":"https://api.github.com/users/openscad","html_url":"https://github.com/openscad","followers_url":"https://api.github.com/users/openscad/followers","following_url":"https://api.github.com/users/openscad/following{/other_user}","gists_url":"https://api.github.com/users/openscad/gists{/gist_id}","starred_url":"https://api.github.com/users/openscad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscad/subscriptions","organizations_url":"https://api.github.com/users/openscad/orgs","repos_url":"https://api.github.com/users/openscad/repos","events_url":"https://api.github.com/users/openscad/events{/privacy}","received_events_url":"https://api.github.com/users/openscad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openscad/openscad","description":"OpenSCAD - The Programmers Solid 3D CAD Modeller  ","fork":false,"url":"https://api.github.com/repos/openscad/openscad","forks_url":"https://api.github.com/repos/openscad/openscad/forks","keys_url":"https://api.github.com/repos/openscad/openscad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openscad/openscad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openscad/openscad/teams","hooks_url":"https://api.github.com/repos/openscad/openscad/hooks","issue_events_url":"https://api.github.com/repos/openscad/openscad/issues/events{/number}","events_url":"https://api.github.com/repos/openscad/openscad/events","assignees_url":"https://api.github.com/repos/openscad/openscad/assignees{/user}","branches_url":"https://api.github.com/repos/openscad/openscad/branches{/branch}","tags_url":"https://api.github.com/repos/openscad/openscad/tags","blobs_url":"https://api.github.com/repos/openscad/openscad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openscad/openscad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openscad/openscad/git/refs{/sha}","trees_url":"https://api.github.com/repos/openscad/openscad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openscad/openscad/statuses/{sha}","languages_url":"https://api.github.com/repos/openscad/openscad/languages","stargazers_url":"https://api.github.com/repos/openscad/openscad/stargazers","contributors_url":"https://api.github.com/repos/openscad/openscad/contributors","subscribers_url":"https://api.github.com/repos/openscad/openscad/subscribers","subscription_url":"https://api.github.com/repos/openscad/openscad/subscription","commits_url":"https://api.github.com/repos/openscad/openscad/commits{/sha}","git_commits_url":"https://api.github.com/repos/openscad/openscad/git/commits{/sha}","comments_url":"https://api.github.com/repos/openscad/openscad/comments{/number}","issue_comment_url":"https://api.github.com/repos/openscad/openscad/issues/comments{/number}","contents_url":"https://api.github.com/repos/openscad/openscad/contents/{+path}","compare_url":"https://api.github.com/repos/openscad/openscad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openscad/openscad/merges","archive_url":"https://api.github.com/repos/openscad/openscad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openscad/openscad/downloads","issues_url":"https://api.github.com/repos/openscad/openscad/issues{/number}","pulls_url":"https://api.github.com/repos/openscad/openscad/pulls{/number}","milestones_url":"https://api.github.com/repos/openscad/openscad/milestones{/number}","notifications_url":"https://api.github.com/repos/openscad/openscad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openscad/openscad/labels{/name}","releases_url":"https://api.github.com/repos/openscad/openscad/releases{/id}","deployments_url":"https://api.github.com/repos/openscad/openscad/deployments","created_at":"2010-11-03T20:25:33Z","updated_at":"2018-11-01T23:58:04Z","pushed_at":"2018-11-01T21:06:31Z","git_url":"git://github.com/openscad/openscad.git","ssh_url":"git@github.com:openscad/openscad.git","clone_url":"https://github.com/openscad/openscad.git","svn_url":"https://github.com/openscad/openscad","homepage":"openscad.org","size":57857,"stargazers_count":2320,"watchers_count":2320,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":586,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":586,"open_issues":615,"watchers":2320,"default_branch":"master"}},"base":{"label":"openscad:master","ref":"master","sha":"a1f1bd502ca633984ff5c7483df046bb63568211","user":{"login":"openscad","id":466370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjM3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/466370?v=4","gravatar_id":"","url":"https://api.github.com/users/openscad","html_url":"https://github.com/openscad","followers_url":"https://api.github.com/users/openscad/followers","following_url":"https://api.github.com/users/openscad/following{/other_user}","gists_url":"https://api.github.com/users/openscad/gists{/gist_id}","starred_url":"https://api.github.com/users/openscad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscad/subscriptions","organizations_url":"https://api.github.com/users/openscad/orgs","repos_url":"https://api.github.com/users/openscad/repos","events_url":"https://api.github.com/users/openscad/events{/privacy}","received_events_url":"https://api.github.com/users/openscad/received_events","type":"Organization","site_admin":false},"repo":{"id":1049088,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MDg4","name":"openscad","full_name":"openscad/openscad","private":false,"owner":{"login":"openscad","id":466370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjM3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/466370?v=4","gravatar_id":"","url":"https://api.github.com/users/openscad","html_url":"https://github.com/openscad","followers_url":"https://api.github.com/users/openscad/followers","following_url":"https://api.github.com/users/openscad/following{/other_user}","gists_url":"https://api.github.com/users/openscad/gists{/gist_id}","starred_url":"https://api.github.com/users/openscad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscad/subscriptions","organizations_url":"https://api.github.com/users/openscad/orgs","repos_url":"https://api.github.com/users/openscad/repos","events_url":"https://api.github.com/users/openscad/events{/privacy}","received_events_url":"https://api.github.com/users/openscad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openscad/openscad","description":"OpenSCAD - The Programmers Solid 3D CAD Modeller  ","fork":false,"url":"https://api.github.com/repos/openscad/openscad","forks_url":"https://api.github.com/repos/openscad/openscad/forks","keys_url":"https://api.github.com/repos/openscad/openscad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openscad/openscad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openscad/openscad/teams","hooks_url":"https://api.github.com/repos/openscad/openscad/hooks","issue_events_url":"https://api.github.com/repos/openscad/openscad/issues/events{/number}","events_url":"https://api.github.com/repos/openscad/openscad/events","assignees_url":"https://api.github.com/repos/openscad/openscad/assignees{/user}","branches_url":"https://api.github.com/repos/openscad/openscad/branches{/branch}","tags_url":"https://api.github.com/repos/openscad/openscad/tags","blobs_url":"https://api.github.com/repos/openscad/openscad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openscad/openscad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openscad/openscad/git/refs{/sha}","trees_url":"https://api.github.com/repos/openscad/openscad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openscad/openscad/statuses/{sha}","languages_url":"https://api.github.com/repos/openscad/openscad/languages","stargazers_url":"https://api.github.com/repos/openscad/openscad/stargazers","contributors_url":"https://api.github.com/repos/openscad/openscad/contributors","subscribers_url":"https://api.github.com/repos/openscad/openscad/subscribers","subscription_url":"https://api.github.com/repos/openscad/openscad/subscription","commits_url":"https://api.github.com/repos/openscad/openscad/commits{/sha}","git_commits_url":"https://api.github.com/repos/openscad/openscad/git/commits{/sha}","comments_url":"https://api.github.com/repos/openscad/openscad/comments{/number}","issue_comment_url":"https://api.github.com/repos/openscad/openscad/issues/comments{/number}","contents_url":"https://api.github.com/repos/openscad/openscad/contents/{+path}","compare_url":"https://api.github.com/repos/openscad/openscad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openscad/openscad/merges","archive_url":"https://api.github.com/repos/openscad/openscad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openscad/openscad/downloads","issues_url":"https://api.github.com/repos/openscad/openscad/issues{/number}","pulls_url":"https://api.github.com/repos/openscad/openscad/pulls{/number}","milestones_url":"https://api.github.com/repos/openscad/openscad/milestones{/number}","notifications_url":"https://api.github.com/repos/openscad/openscad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openscad/openscad/labels{/name}","releases_url":"https://api.github.com/repos/openscad/openscad/releases{/id}","deployments_url":"https://api.github.com/repos/openscad/openscad/deployments","created_at":"2010-11-03T20:25:33Z","updated_at":"2018-11-01T23:58:04Z","pushed_at":"2018-11-01T21:06:31Z","git_url":"git://github.com/openscad/openscad.git","ssh_url":"git@github.com:openscad/openscad.git","clone_url":"https://github.com/openscad/openscad.git","svn_url":"https://github.com/openscad/openscad","homepage":"openscad.org","size":57857,"stargazers_count":2320,"watchers_count":2320,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":586,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":586,"open_issues":615,"watchers":2320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openscad/openscad/pulls/1802"},"html":{"href":"https://github.com/openscad/openscad/pull/1802"},"issue":{"href":"https://api.github.com/repos/openscad/openscad/issues/1802"},"comments":{"href":"https://api.github.com/repos/openscad/openscad/issues/1802/comments"},"review_comments":{"href":"https://api.github.com/repos/openscad/openscad/pulls/1802/comments"},"review_comment":{"href":"https://api.github.com/repos/openscad/openscad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openscad/openscad/pulls/1802/commits"},"statuses":{"href":"https://api.github.com/repos/openscad/openscad/statuses/2b73b60a99b58c63ca59a6464048034f2a9b2fbf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kintel"}}