{"action":"created","comment":{"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments/173203322","pull_request_review_id":102353052,"id":173203322,"diff_hunk":"@@ -233,27 +234,32 @@ def run(argv=None):\n   processed_variant_factory = processed_variant.ProcessedVariantFactory(\n       header_fields,\n       known_args.split_alternate_allele_info_fields,\n-      known_args.annotation_fields)\n+      known_args.annotation_fields,\n+      metrics_util.CounterFactory())","path":"gcp_variant_transforms/vcf_to_bq.py","position":14,"original_position":14,"commit_id":"73ad0e39196882ec68e980facc259e25b9e87381","original_commit_id":"6e8f6a2ff5e0ab14172b28e1168ec92dff8b572f","user":{"login":"arostamianfar","id":11234335,"avatar_url":"https://avatars2.githubusercontent.com/u/11234335?v=4","gravatar_id":"","url":"https://api.github.com/users/arostamianfar","html_url":"https://github.com/arostamianfar","followers_url":"https://api.github.com/users/arostamianfar/followers","following_url":"https://api.github.com/users/arostamianfar/following{/other_user}","gists_url":"https://api.github.com/users/arostamianfar/gists{/gist_id}","starred_url":"https://api.github.com/users/arostamianfar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arostamianfar/subscriptions","organizations_url":"https://api.github.com/users/arostamianfar/orgs","repos_url":"https://api.github.com/users/arostamianfar/repos","events_url":"https://api.github.com/users/arostamianfar/events{/privacy}","received_events_url":"https://api.github.com/users/arostamianfar/received_events","type":"User","site_admin":false},"body":"Thanks for sharing the doc. Sorry I missed it originally. I like the factory design pattern and now see your point about keeping the constructor light. I'd still prefer to create one instance of the factory and passing that in to any module that wants to use counters (instead of each module creating their own instance in the method call), but feel free to leave as is for now.","created_at":"2018-03-08T16:01:08Z","updated_at":"2018-03-08T16:27:14Z","html_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/125#discussion_r173203322","pull_request_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments/173203322"},"html":{"href":"https://github.com/googlegenomics/gcp-variant-transforms/pull/125#discussion_r173203322"},"pull_request":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125"}},"in_reply_to_id":172737767},"pull_request":{"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125","id":172074250,"html_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/125","diff_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/125.diff","patch_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/125.patch","issue_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/125","number":125,"state":"open","locked":false,"title":"Adds counters to processed_variant and creates a wrapper for Beam counters.","user":{"login":"bashir2","id":11869543,"avatar_url":"https://avatars3.githubusercontent.com/u/11869543?v=4","gravatar_id":"","url":"https://api.github.com/users/bashir2","html_url":"https://github.com/bashir2","followers_url":"https://api.github.com/users/bashir2/followers","following_url":"https://api.github.com/users/bashir2/following{/other_user}","gists_url":"https://api.github.com/users/bashir2/gists{/gist_id}","starred_url":"https://api.github.com/users/bashir2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashir2/subscriptions","organizations_url":"https://api.github.com/users/bashir2/orgs","repos_url":"https://api.github.com/users/bashir2/repos","events_url":"https://api.github.com/users/bashir2/events{/privacy}","received_events_url":"https://api.github.com/users/bashir2/received_events","type":"User","site_admin":false},"body":"Tested:\r\nNew unit-tests added; ran integration test; also ran manually on the platinum set (for performance).\r\n\r\nIssue #81 ","created_at":"2018-02-28T21:13:46Z","updated_at":"2018-03-08T16:27:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74d4cbe107684d156478ad54c0366c23c736f554","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125/commits","review_comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125/comments","review_comment_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/125/comments","statuses_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/73ad0e39196882ec68e980facc259e25b9e87381","head":{"label":"bashir2:alt_annotation_review","ref":"alt_annotation_review","sha":"73ad0e39196882ec68e980facc259e25b9e87381","user":{"login":"bashir2","id":11869543,"avatar_url":"https://avatars3.githubusercontent.com/u/11869543?v=4","gravatar_id":"","url":"https://api.github.com/users/bashir2","html_url":"https://github.com/bashir2","followers_url":"https://api.github.com/users/bashir2/followers","following_url":"https://api.github.com/users/bashir2/following{/other_user}","gists_url":"https://api.github.com/users/bashir2/gists{/gist_id}","starred_url":"https://api.github.com/users/bashir2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashir2/subscriptions","organizations_url":"https://api.github.com/users/bashir2/orgs","repos_url":"https://api.github.com/users/bashir2/repos","events_url":"https://api.github.com/users/bashir2/events{/privacy}","received_events_url":"https://api.github.com/users/bashir2/received_events","type":"User","site_admin":false},"repo":{"id":116989416,"name":"gcp-variant-transforms","full_name":"bashir2/gcp-variant-transforms","owner":{"login":"bashir2","id":11869543,"avatar_url":"https://avatars3.githubusercontent.com/u/11869543?v=4","gravatar_id":"","url":"https://api.github.com/users/bashir2","html_url":"https://github.com/bashir2","followers_url":"https://api.github.com/users/bashir2/followers","following_url":"https://api.github.com/users/bashir2/following{/other_user}","gists_url":"https://api.github.com/users/bashir2/gists{/gist_id}","starred_url":"https://api.github.com/users/bashir2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bashir2/subscriptions","organizations_url":"https://api.github.com/users/bashir2/orgs","repos_url":"https://api.github.com/users/bashir2/repos","events_url":"https://api.github.com/users/bashir2/events{/privacy}","received_events_url":"https://api.github.com/users/bashir2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bashir2/gcp-variant-transforms","description":"GCP Variant Transforms","fork":true,"url":"https://api.github.com/repos/bashir2/gcp-variant-transforms","forks_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/forks","keys_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/teams","hooks_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/hooks","issue_events_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/issues/events{/number}","events_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/events","assignees_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/assignees{/user}","branches_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/branches{/branch}","tags_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/tags","blobs_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/statuses/{sha}","languages_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/languages","stargazers_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/stargazers","contributors_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/contributors","subscribers_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/subscribers","subscription_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/subscription","commits_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/contents/{+path}","compare_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/merges","archive_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/downloads","issues_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/issues{/number}","pulls_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/pulls{/number}","milestones_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/milestones{/number}","notifications_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/labels{/name}","releases_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/releases{/id}","deployments_url":"https://api.github.com/repos/bashir2/gcp-variant-transforms/deployments","created_at":"2018-01-10T17:32:23Z","updated_at":"2018-01-10T17:32:25Z","pushed_at":"2018-03-08T08:06:46Z","git_url":"git://github.com/bashir2/gcp-variant-transforms.git","ssh_url":"git@github.com:bashir2/gcp-variant-transforms.git","clone_url":"https://github.com/bashir2/gcp-variant-transforms.git","svn_url":"https://github.com/bashir2/gcp-variant-transforms","homepage":null,"size":623,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlegenomics:master","ref":"master","sha":"b8a6c8c70f7b93efdd86f4c2380990985faf3a9d","user":{"login":"googlegenomics","id":7434120,"avatar_url":"https://avatars2.githubusercontent.com/u/7434120?v=4","gravatar_id":"","url":"https://api.github.com/users/googlegenomics","html_url":"https://github.com/googlegenomics","followers_url":"https://api.github.com/users/googlegenomics/followers","following_url":"https://api.github.com/users/googlegenomics/following{/other_user}","gists_url":"https://api.github.com/users/googlegenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/googlegenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlegenomics/subscriptions","organizations_url":"https://api.github.com/users/googlegenomics/orgs","repos_url":"https://api.github.com/users/googlegenomics/repos","events_url":"https://api.github.com/users/googlegenomics/events{/privacy}","received_events_url":"https://api.github.com/users/googlegenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":110025283,"name":"gcp-variant-transforms","full_name":"googlegenomics/gcp-variant-transforms","owner":{"login":"googlegenomics","id":7434120,"avatar_url":"https://avatars2.githubusercontent.com/u/7434120?v=4","gravatar_id":"","url":"https://api.github.com/users/googlegenomics","html_url":"https://github.com/googlegenomics","followers_url":"https://api.github.com/users/googlegenomics/followers","following_url":"https://api.github.com/users/googlegenomics/following{/other_user}","gists_url":"https://api.github.com/users/googlegenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/googlegenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlegenomics/subscriptions","organizations_url":"https://api.github.com/users/googlegenomics/orgs","repos_url":"https://api.github.com/users/googlegenomics/repos","events_url":"https://api.github.com/users/googlegenomics/events{/privacy}","received_events_url":"https://api.github.com/users/googlegenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlegenomics/gcp-variant-transforms","description":"GCP Variant Transforms","fork":false,"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms","forks_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/forks","keys_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/teams","hooks_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/hooks","issue_events_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/events{/number}","events_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/events","assignees_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/assignees{/user}","branches_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/branches{/branch}","tags_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/tags","blobs_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/{sha}","languages_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/languages","stargazers_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/stargazers","contributors_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/contributors","subscribers_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/subscribers","subscription_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/subscription","commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/contents/{+path}","compare_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/merges","archive_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/downloads","issues_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues{/number}","pulls_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls{/number}","milestones_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/milestones{/number}","notifications_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/labels{/name}","releases_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/releases{/id}","deployments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/deployments","created_at":"2017-11-08T20:12:08Z","updated_at":"2018-03-06T23:05:24Z","pushed_at":"2018-03-08T15:35:48Z","git_url":"git://github.com/googlegenomics/gcp-variant-transforms.git","ssh_url":"git@github.com:googlegenomics/gcp-variant-transforms.git","clone_url":"https://github.com/googlegenomics/gcp-variant-transforms.git","svn_url":"https://github.com/googlegenomics/gcp-variant-transforms","homepage":null,"size":543,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":43,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125"},"html":{"href":"https://github.com/googlegenomics/gcp-variant-transforms/pull/125"},"issue":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/125"},"comments":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/73ad0e39196882ec68e980facc259e25b9e87381"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arostamianfar"}}