{"action":"created","comment":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/172520059","pull_request_review_id":101548272,"id":172520059,"diff_hunk":"@@ -224,7 +239,7 @@ public void initParam(Object obj) {\n \t\tgetChkParseGit().setSelected(param.isParseGit());\r\n \t\tgetComboHandleParameters().setSelectedItem(param.getHandleParameters());\r\n \t\tgetHandleODataSpecificParameters().setSelected(param.isHandleODataParametersVisited());\r\n-\r\n+\t\tgetIrrelevantUrlParameters().setText(param.getIrrelevantUrlParametersAsString());\r","path":"src/org/zaproxy/zap/extension/spider/OptionsSpiderPanel.java","position":48,"original_position":48,"commit_id":"76fb6c1f063619b9a0aee9e9316ac72cc0e0d798","original_commit_id":"76fb6c1f063619b9a0aee9e9316ac72cc0e0d798","user":{"login":"thc202","id":4639210,"avatar_url":"https://avatars0.githubusercontent.com/u/4639210?v=4","gravatar_id":"","url":"https://api.github.com/users/thc202","html_url":"https://github.com/thc202","followers_url":"https://api.github.com/users/thc202/followers","following_url":"https://api.github.com/users/thc202/following{/other_user}","gists_url":"https://api.github.com/users/thc202/gists{/gist_id}","starred_url":"https://api.github.com/users/thc202/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thc202/subscriptions","organizations_url":"https://api.github.com/users/thc202/orgs","repos_url":"https://api.github.com/users/thc202/repos","events_url":"https://api.github.com/users/thc202/events{/privacy}","received_events_url":"https://api.github.com/users/thc202/received_events","type":"User","site_admin":false},"body":"The undoable edits should be discarded (also after saving).","created_at":"2018-03-06T13:49:22Z","updated_at":"2018-03-06T13:57:40Z","html_url":"https://github.com/zaproxy/zaproxy/pull/4398#discussion_r172520059","pull_request_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments/172520059"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/4398#discussion_r172520059"},"pull_request":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398"}}},"pull_request":{"url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398","id":169223937,"html_url":"https://github.com/zaproxy/zaproxy/pull/4398","diff_url":"https://github.com/zaproxy/zaproxy/pull/4398.diff","patch_url":"https://github.com/zaproxy/zaproxy/pull/4398.patch","issue_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/4398","number":4398,"state":"open","locked":false,"title":"ZAP-4388: Allow to configure the irrelevant parameters for the Spider","user":{"login":"AleksandrPea","id":11192279,"avatar_url":"https://avatars3.githubusercontent.com/u/11192279?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksandrPea","html_url":"https://github.com/AleksandrPea","followers_url":"https://api.github.com/users/AleksandrPea/followers","following_url":"https://api.github.com/users/AleksandrPea/following{/other_user}","gists_url":"https://api.github.com/users/AleksandrPea/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksandrPea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksandrPea/subscriptions","organizations_url":"https://api.github.com/users/AleksandrPea/orgs","repos_url":"https://api.github.com/users/AleksandrPea/repos","events_url":"https://api.github.com/users/AleksandrPea/events{/privacy}","received_events_url":"https://api.github.com/users/AleksandrPea/received_events","type":"User","site_admin":false},"body":"This PR is related to issue [4388](https://github.com/zaproxy/zaproxy/issues/4388).\r\n\r\n* Added irrelevantParameters property to `SpiderParam`.\r\n* Tweaked URLCanonicalizer to take into account irrelevant parameters. \r\n* Made changes on UI side to allow custom configuration for irrelevant parameters.\r\n\r\nSpider options screenshot:\r\n![selection_001](https://user-images.githubusercontent.com/11192279/36228387-c9231896-11dc-11e8-8c3e-3988cdf28384.png)\r\n\r\nSpider dialog screenshot:\r\n![selection_002](https://user-images.githubusercontent.com/11192279/36228445-e0bbabb2-11dc-11e8-8040-2b00c4d1c3cf.png)\r\n\r\nPlease, review:\r\n@thc202\r\n","created_at":"2018-02-14T21:15:38Z","updated_at":"2018-03-06T13:57:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"122341fe3b8218f1c1ef47ee489858a095d62840","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":220536002,"url":"https://api.github.com/repos/zaproxy/zaproxy/labels/Type-Task","name":"Type-Task","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398/commits","review_comments_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398/comments","review_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/4398/comments","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/76fb6c1f063619b9a0aee9e9316ac72cc0e0d798","head":{"label":"AleksandrPea:ZAP-4388_Allow_to_configure_irrelevant_parameters_Spider","ref":"ZAP-4388_Allow_to_configure_irrelevant_parameters_Spider","sha":"76fb6c1f063619b9a0aee9e9316ac72cc0e0d798","user":{"login":"AleksandrPea","id":11192279,"avatar_url":"https://avatars3.githubusercontent.com/u/11192279?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksandrPea","html_url":"https://github.com/AleksandrPea","followers_url":"https://api.github.com/users/AleksandrPea/followers","following_url":"https://api.github.com/users/AleksandrPea/following{/other_user}","gists_url":"https://api.github.com/users/AleksandrPea/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksandrPea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksandrPea/subscriptions","organizations_url":"https://api.github.com/users/AleksandrPea/orgs","repos_url":"https://api.github.com/users/AleksandrPea/repos","events_url":"https://api.github.com/users/AleksandrPea/events{/privacy}","received_events_url":"https://api.github.com/users/AleksandrPea/received_events","type":"User","site_admin":false},"repo":{"id":121498426,"name":"zaproxy","full_name":"AleksandrPea/zaproxy","owner":{"login":"AleksandrPea","id":11192279,"avatar_url":"https://avatars3.githubusercontent.com/u/11192279?v=4","gravatar_id":"","url":"https://api.github.com/users/AleksandrPea","html_url":"https://github.com/AleksandrPea","followers_url":"https://api.github.com/users/AleksandrPea/followers","following_url":"https://api.github.com/users/AleksandrPea/following{/other_user}","gists_url":"https://api.github.com/users/AleksandrPea/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksandrPea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksandrPea/subscriptions","organizations_url":"https://api.github.com/users/AleksandrPea/orgs","repos_url":"https://api.github.com/users/AleksandrPea/repos","events_url":"https://api.github.com/users/AleksandrPea/events{/privacy}","received_events_url":"https://api.github.com/users/AleksandrPea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AleksandrPea/zaproxy","description":"The OWASP ZAP core project","fork":true,"url":"https://api.github.com/repos/AleksandrPea/zaproxy","forks_url":"https://api.github.com/repos/AleksandrPea/zaproxy/forks","keys_url":"https://api.github.com/repos/AleksandrPea/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AleksandrPea/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AleksandrPea/zaproxy/teams","hooks_url":"https://api.github.com/repos/AleksandrPea/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/AleksandrPea/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/AleksandrPea/zaproxy/events","assignees_url":"https://api.github.com/repos/AleksandrPea/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/AleksandrPea/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/AleksandrPea/zaproxy/tags","blobs_url":"https://api.github.com/repos/AleksandrPea/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AleksandrPea/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AleksandrPea/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/AleksandrPea/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AleksandrPea/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/AleksandrPea/zaproxy/languages","stargazers_url":"https://api.github.com/repos/AleksandrPea/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/AleksandrPea/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/AleksandrPea/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/AleksandrPea/zaproxy/subscription","commits_url":"https://api.github.com/repos/AleksandrPea/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/AleksandrPea/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/AleksandrPea/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/AleksandrPea/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/AleksandrPea/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/AleksandrPea/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AleksandrPea/zaproxy/merges","archive_url":"https://api.github.com/repos/AleksandrPea/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AleksandrPea/zaproxy/downloads","issues_url":"https://api.github.com/repos/AleksandrPea/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/AleksandrPea/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/AleksandrPea/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/AleksandrPea/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AleksandrPea/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/AleksandrPea/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/AleksandrPea/zaproxy/deployments","created_at":"2018-02-14T10:32:38Z","updated_at":"2018-02-14T10:32:46Z","pushed_at":"2018-02-15T11:48:07Z","git_url":"git://github.com/AleksandrPea/zaproxy.git","ssh_url":"git@github.com:AleksandrPea/zaproxy.git","clone_url":"https://github.com/AleksandrPea/zaproxy.git","svn_url":"https://github.com/AleksandrPea/zaproxy","homepage":null,"size":173338,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"zaproxy:develop","ref":"develop","sha":"c8c4295b92ad828c8bfd11d3cc3784029229fd87","user":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":36817565,"name":"zaproxy","full_name":"zaproxy/zaproxy","owner":{"login":"zaproxy","id":6716868,"avatar_url":"https://avatars2.githubusercontent.com/u/6716868?v=4","gravatar_id":"","url":"https://api.github.com/users/zaproxy","html_url":"https://github.com/zaproxy","followers_url":"https://api.github.com/users/zaproxy/followers","following_url":"https://api.github.com/users/zaproxy/following{/other_user}","gists_url":"https://api.github.com/users/zaproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/zaproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaproxy/subscriptions","organizations_url":"https://api.github.com/users/zaproxy/orgs","repos_url":"https://api.github.com/users/zaproxy/repos","events_url":"https://api.github.com/users/zaproxy/events{/privacy}","received_events_url":"https://api.github.com/users/zaproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zaproxy/zaproxy","description":"The OWASP ZAP core project","fork":false,"url":"https://api.github.com/repos/zaproxy/zaproxy","forks_url":"https://api.github.com/repos/zaproxy/zaproxy/forks","keys_url":"https://api.github.com/repos/zaproxy/zaproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zaproxy/zaproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zaproxy/zaproxy/teams","hooks_url":"https://api.github.com/repos/zaproxy/zaproxy/hooks","issue_events_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/events{/number}","events_url":"https://api.github.com/repos/zaproxy/zaproxy/events","assignees_url":"https://api.github.com/repos/zaproxy/zaproxy/assignees{/user}","branches_url":"https://api.github.com/repos/zaproxy/zaproxy/branches{/branch}","tags_url":"https://api.github.com/repos/zaproxy/zaproxy/tags","blobs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zaproxy/zaproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zaproxy/zaproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zaproxy/zaproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zaproxy/zaproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/zaproxy/zaproxy/languages","stargazers_url":"https://api.github.com/repos/zaproxy/zaproxy/stargazers","contributors_url":"https://api.github.com/repos/zaproxy/zaproxy/contributors","subscribers_url":"https://api.github.com/repos/zaproxy/zaproxy/subscribers","subscription_url":"https://api.github.com/repos/zaproxy/zaproxy/subscription","commits_url":"https://api.github.com/repos/zaproxy/zaproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zaproxy/zaproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zaproxy/zaproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zaproxy/zaproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zaproxy/zaproxy/contents/{+path}","compare_url":"https://api.github.com/repos/zaproxy/zaproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zaproxy/zaproxy/merges","archive_url":"https://api.github.com/repos/zaproxy/zaproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zaproxy/zaproxy/downloads","issues_url":"https://api.github.com/repos/zaproxy/zaproxy/issues{/number}","pulls_url":"https://api.github.com/repos/zaproxy/zaproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/zaproxy/zaproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/zaproxy/zaproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zaproxy/zaproxy/labels{/name}","releases_url":"https://api.github.com/repos/zaproxy/zaproxy/releases{/id}","deployments_url":"https://api.github.com/repos/zaproxy/zaproxy/deployments","created_at":"2015-06-03T16:55:01Z","updated_at":"2018-03-06T13:35:49Z","pushed_at":"2018-03-06T13:47:25Z","git_url":"git://github.com/zaproxy/zaproxy.git","ssh_url":"git@github.com:zaproxy/zaproxy.git","clone_url":"https://github.com/zaproxy/zaproxy.git","svn_url":"https://github.com/zaproxy/zaproxy","homepage":null,"size":174476,"stargazers_count":3623,"watchers_count":3623,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":712,"mirror_url":null,"archived":false,"open_issues_count":598,"license":null,"forks":712,"open_issues":598,"watchers":3623,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398"},"html":{"href":"https://github.com/zaproxy/zaproxy/pull/4398"},"issue":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/4398"},"comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/issues/4398/comments"},"review_comments":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398/comments"},"review_comment":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zaproxy/zaproxy/pulls/4398/commits"},"statuses":{"href":"https://api.github.com/repos/zaproxy/zaproxy/statuses/76fb6c1f063619b9a0aee9e9316ac72cc0e0d798"}},"author_association":"NONE"}}
{"actor":{"display_login":"thc202"}}