{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/comments/212684015","pull_request_review_id":149372817,"id":212684015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY4NDAxNQ==","diff_hunk":"@@ -0,0 +1,53 @@\n+import * as React from 'react';\n+import { get } from 'lodash';\n+\n+import { HoverablePopover } from '@spinnaker/core';\n+import './manifestLabels.less';\n+\n+export interface IManifestQosProps {\n+  manifest?: {\n+    status?: {\n+      qosClass?: string\n+    }\n+  };\n+}\n+\n+export class ManifestQos extends React.Component<IManifestQosProps> {\n+  private qosClass(): string {\n+    return get(this.props, ['manifest', 'status', 'qosClass'], 'Unknown');\n+  }\n+\n+  private qosStyle(): string {\n+    const qosClass = this.qosClass();\n+    if (qosClass === 'Guaranteed') {","path":"app/scripts/modules/kubernetes/src/v2/manifest/ManifestQos.tsx","position":23,"original_position":22,"commit_id":"a7bcc2384269a1f585acd5b799b61d578e687875","original_commit_id":"e948adc6c0d123af6af2988913909f987feba1e0","user":{"login":"lwander","id":4874941,"node_id":"MDQ6VXNlcjQ4NzQ5NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"The QOS classes are arguably a niche configuration property, as they are never directly expressed by the user but instead a property of how resource requests are set. In the case where a user knows that they have selected a QOS tier that involves their pod getting evicted, I don't see a warning color as being surprisng/harmful. In the case where a user (and I'm guessing this is the common non-operator user) sees the QOS tier, it's helpful to highlight a common misconfiguration pattern. After all, BestEffort is the lowest guarantee of stability, but also the default class when no special configuration has been made.","created_at":"2018-08-24T16:29:57Z","updated_at":"2018-08-24T16:29:57Z","html_url":"https://github.com/spinnaker/deck/pull/5654#discussion_r212684015","pull_request_url":"https://api.github.com/repos/spinnaker/deck/pulls/5654","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments/212684015"},"html":{"href":"https://github.com/spinnaker/deck/pull/5654#discussion_r212684015"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5654"}},"in_reply_to_id":212443299},"pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/5654","id":210558704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTU4NzA0","html_url":"https://github.com/spinnaker/deck/pull/5654","diff_url":"https://github.com/spinnaker/deck/pull/5654.diff","patch_url":"https://github.com/spinnaker/deck/pull/5654.patch","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/5654","number":5654,"state":"closed","locked":false,"title":"feat(provider/kubernetes): container metrics & QOS tier","user":{"login":"lwander","id":4874941,"node_id":"MDQ6VXNlcjQ4NzQ5NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"![qos](https://user-images.githubusercontent.com/4874941/44548761-fd7b2980-a6ec-11e8-8498-54b58a1bf530.png)\r\n\r\n![resources](https://user-images.githubusercontent.com/4874941/44548762-feac5680-a6ec-11e8-982b-774c47ebd5aa.png)\r\n\r\nhttps://github.com/spinnaker/spinnaker/issues/3230\r\n","created_at":"2018-08-23T19:56:20Z","updated_at":"2018-08-24T16:29:57Z","closed_at":"2018-08-24T14:34:55Z","merged_at":"2018-08-24T14:34:55Z","merge_commit_sha":"5eefc939b451066e919b295e62d45048946832af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1017406583,"node_id":"MDU6TGFiZWwxMDE3NDA2NTgz","url":"https://api.github.com/repos/spinnaker/deck/labels/target-release/1.10","name":"target-release/1.10","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/deck/pulls/5654/commits","review_comments_url":"https://api.github.com/repos/spinnaker/deck/pulls/5654/comments","review_comment_url":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/5654/comments","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/a7bcc2384269a1f585acd5b799b61d578e687875","head":{"label":"lwander:metrics-qos","ref":"metrics-qos","sha":"a7bcc2384269a1f585acd5b799b61d578e687875","user":{"login":"lwander","id":4874941,"node_id":"MDQ6VXNlcjQ4NzQ5NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"repo":{"id":47214623,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIxNDYyMw==","name":"deck","full_name":"lwander/deck","owner":{"login":"lwander","id":4874941,"node_id":"MDQ6VXNlcjQ4NzQ5NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lwander/deck","description":"Management UI for Spinnaker","fork":true,"url":"https://api.github.com/repos/lwander/deck","forks_url":"https://api.github.com/repos/lwander/deck/forks","keys_url":"https://api.github.com/repos/lwander/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lwander/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lwander/deck/teams","hooks_url":"https://api.github.com/repos/lwander/deck/hooks","issue_events_url":"https://api.github.com/repos/lwander/deck/issues/events{/number}","events_url":"https://api.github.com/repos/lwander/deck/events","assignees_url":"https://api.github.com/repos/lwander/deck/assignees{/user}","branches_url":"https://api.github.com/repos/lwander/deck/branches{/branch}","tags_url":"https://api.github.com/repos/lwander/deck/tags","blobs_url":"https://api.github.com/repos/lwander/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lwander/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lwander/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/lwander/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lwander/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/lwander/deck/languages","stargazers_url":"https://api.github.com/repos/lwander/deck/stargazers","contributors_url":"https://api.github.com/repos/lwander/deck/contributors","subscribers_url":"https://api.github.com/repos/lwander/deck/subscribers","subscription_url":"https://api.github.com/repos/lwander/deck/subscription","commits_url":"https://api.github.com/repos/lwander/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/lwander/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/lwander/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/lwander/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/lwander/deck/contents/{+path}","compare_url":"https://api.github.com/repos/lwander/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lwander/deck/merges","archive_url":"https://api.github.com/repos/lwander/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lwander/deck/downloads","issues_url":"https://api.github.com/repos/lwander/deck/issues{/number}","pulls_url":"https://api.github.com/repos/lwander/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/lwander/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/lwander/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lwander/deck/labels{/name}","releases_url":"https://api.github.com/repos/lwander/deck/releases{/id}","deployments_url":"https://api.github.com/repos/lwander/deck/deployments","created_at":"2015-12-01T20:12:35Z","updated_at":"2017-11-28T18:00:03Z","pushed_at":"2018-08-24T15:17:23Z","git_url":"git://github.com/lwander/deck.git","ssh_url":"git@github.com:lwander/deck.git","clone_url":"https://github.com/lwander/deck.git","svn_url":"https://github.com/lwander/deck","homepage":"","size":38451,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"7dcf8c84c1bf4deca67a3fea8b9a4e6f1252a7d9","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21953642,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk1MzY0Mg==","name":"deck","full_name":"spinnaker/deck","owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/deck","description":"Management UI for Spinnaker","fork":false,"url":"https://api.github.com/repos/spinnaker/deck","forks_url":"https://api.github.com/repos/spinnaker/deck/forks","keys_url":"https://api.github.com/repos/spinnaker/deck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/deck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/deck/teams","hooks_url":"https://api.github.com/repos/spinnaker/deck/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/deck/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/deck/events","assignees_url":"https://api.github.com/repos/spinnaker/deck/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/deck/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/deck/tags","blobs_url":"https://api.github.com/repos/spinnaker/deck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/deck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/deck/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/deck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/deck/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/deck/languages","stargazers_url":"https://api.github.com/repos/spinnaker/deck/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/deck/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/deck/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/deck/subscription","commits_url":"https://api.github.com/repos/spinnaker/deck/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/deck/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/deck/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/deck/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/deck/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/deck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/deck/merges","archive_url":"https://api.github.com/repos/spinnaker/deck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/deck/downloads","issues_url":"https://api.github.com/repos/spinnaker/deck/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/deck/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/deck/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/deck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/deck/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/deck/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/deck/deployments","created_at":"2014-07-17T18:51:00Z","updated_at":"2018-08-24T15:16:49Z","pushed_at":"2018-08-24T16:24:41Z","git_url":"git://github.com/spinnaker/deck.git","ssh_url":"git@github.com:spinnaker/deck.git","clone_url":"https://github.com/spinnaker/deck.git","svn_url":"https://github.com/spinnaker/deck","homepage":"","size":32867,"stargazers_count":152,"watchers_count":152,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":359,"open_issues":5,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5654"},"html":{"href":"https://github.com/spinnaker/deck/pull/5654"},"issue":{"href":"https://api.github.com/repos/spinnaker/deck/issues/5654"},"comments":{"href":"https://api.github.com/repos/spinnaker/deck/issues/5654/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5654/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/deck/pulls/5654/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/deck/statuses/a7bcc2384269a1f585acd5b799b61d578e687875"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lwander"}}