{"action":"opened","issue":{"url":"https://api.github.com/repos/bitnami/bitnami-docker-laravel/issues/90","repository_url":"https://api.github.com/repos/bitnami/bitnami-docker-laravel","labels_url":"https://api.github.com/repos/bitnami/bitnami-docker-laravel/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/bitnami/bitnami-docker-laravel/issues/90/comments","events_url":"https://api.github.com/repos/bitnami/bitnami-docker-laravel/issues/90/events","html_url":"https://github.com/bitnami/bitnami-docker-laravel/issues/90","id":351164346,"node_id":"MDU6SXNzdWUzNTExNjQzNDY=","number":90,"title":"Unnecessary update","user":{"login":"balintsera","id":8377085,"node_id":"MDQ6VXNlcjgzNzcwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8377085?v=4","gravatar_id":"","url":"https://api.github.com/users/balintsera","html_url":"https://github.com/balintsera","followers_url":"https://api.github.com/users/balintsera/followers","following_url":"https://api.github.com/users/balintsera/following{/other_user}","gists_url":"https://api.github.com/users/balintsera/gists{/gist_id}","starred_url":"https://api.github.com/users/balintsera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balintsera/subscriptions","organizations_url":"https://api.github.com/users/balintsera/orgs","repos_url":"https://api.github.com/users/balintsera/repos","events_url":"https://api.github.com/users/balintsera/events{/privacy}","received_events_url":"https://api.github.com/users/balintsera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-16T11:27:28Z","updated_at":"2018-08-16T11:27:28Z","closed_at":null,"author_association":"NONE","body":"First of all, thank you for this image! \r\n\r\nhttps://github.com/bitnami/bitnami-docker-laravel/blob/20b52f8252e827a1c2fb8bc4d12ebb0476593b3e/5/rootfs/app-entrypoint.sh#L20\r\n\r\nThis function checks whether the package.json file is edited since the last init session but Composer has a lock file so its more convenient to just run a `composer install`. \r\n\r\nThis will\r\n\r\n1. look for a composer.lock file. This file has every dependency locked to a specific version so it installs/reverts the contents of the vendor directory to these versions\r\n\r\n2. if the lock file is missing, `composer install` installs the higher versions of all the packages according to the version controls that can be found in composer.json.\r\n\r\nSo there is no need to run composer update unless the user deliberately want to update all of the packages.\r\n\r\nIt can results in unintended updates in every environment. \r\n\r\nSo I suggest to just run `composer install`. If the developer wants to update the packages, she/he can do it by running the update command in the container. \r\n\r\nAm I missed something important? Should I submit a merge request with this?\r\n\r\n\r\n"}}
{"actor":{"display_login":"balintsera"}}