{"action":"created","comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments/188475221","pull_request_review_id":120461097,"id":188475221,"diff_hunk":"@@ -1750,6 +1801,25 @@ void Daemon::ApiImpl::CryptoRequestQueue::handleFinishedRequest(\n             }\n             break;\n         }\n+        case QueryLockStatusRequest: {\n+            Result result = request->outParams.size()\n+                    ? request->outParams.takeFirst().value<Result>()\n+                    : Result(Result::UnknownError,\n+                             QLatin1String(\"Unable to determine result of QueryLockStatusRequest request\"));\n+            if (result.code() == Result::Pending) {\n+                // shouldn't happen!\n+                qCWarning(lcSailfishCryptoDaemon) << \"QueryLockStatusRequest:\" << request->requestId << \"finished as pending!\";\n+                *completed = true;\n+            } else {\n+                bool locked = request->outParams.size()\n+                        ? request->outParams.takeFirst().value<bool>()\n+                        : true;\n+                request->connection.send(request->message.createReply() << QVariant::fromValue<Result>(result)\n+                                                                        << QVariant::fromValue<bool>(locked));\n+                *completed = true;","path":"daemon/CryptoImpl/crypto.cpp","position":98,"original_position":98,"commit_id":"25a9deb285296b2a423655a271926036f222875e","original_commit_id":"25a9deb285296b2a423655a271926036f222875e","user":{"login":"chriadam","id":2569776,"avatar_url":"https://avatars1.githubusercontent.com/u/2569776?v=4","gravatar_id":"","url":"https://api.github.com/users/chriadam","html_url":"https://github.com/chriadam","followers_url":"https://api.github.com/users/chriadam/followers","following_url":"https://api.github.com/users/chriadam/following{/other_user}","gists_url":"https://api.github.com/users/chriadam/gists{/gist_id}","starred_url":"https://api.github.com/users/chriadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriadam/subscriptions","organizations_url":"https://api.github.com/users/chriadam/orgs","repos_url":"https://api.github.com/users/chriadam/repos","events_url":"https://api.github.com/users/chriadam/events{/privacy}","received_events_url":"https://api.github.com/users/chriadam/received_events","type":"User","site_admin":false},"body":"will fix","created_at":"2018-05-16T00:34:34Z","updated_at":"2018-05-16T00:34:34Z","html_url":"https://github.com/sailfishos/sailfish-secrets/pull/103#discussion_r188475221","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments/188475221"},"html":{"href":"https://github.com/sailfishos/sailfish-secrets/pull/103#discussion_r188475221"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103"}},"in_reply_to_id":188184331},"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103","id":188006873,"html_url":"https://github.com/sailfishos/sailfish-secrets/pull/103","diff_url":"https://github.com/sailfishos/sailfish-secrets/pull/103.diff","patch_url":"https://github.com/sailfishos/sailfish-secrets/pull/103.patch","issue_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/103","number":103,"state":"open","locked":false,"title":"[sailfish-secrets] Add QueryLockStatus operation to LockCodeRequest. Contributes to JB#36797","user":{"login":"chriadam","id":2569776,"avatar_url":"https://avatars1.githubusercontent.com/u/2569776?v=4","gravatar_id":"","url":"https://api.github.com/users/chriadam","html_url":"https://github.com/chriadam","followers_url":"https://api.github.com/users/chriadam/followers","following_url":"https://api.github.com/users/chriadam/following{/other_user}","gists_url":"https://api.github.com/users/chriadam/gists{/gist_id}","starred_url":"https://api.github.com/users/chriadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriadam/subscriptions","organizations_url":"https://api.github.com/users/chriadam/orgs","repos_url":"https://api.github.com/users/chriadam/repos","events_url":"https://api.github.com/users/chriadam/events{/privacy}","received_events_url":"https://api.github.com/users/chriadam/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-15T03:48:56Z","updated_at":"2018-05-16T00:34:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412f766c421a34d5cece85ff5f29f1a877fcd2e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103/commits","review_comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103/comments","review_comment_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/103/comments","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/25a9deb285296b2a423655a271926036f222875e","head":{"label":"sailfishos:checklockstate","ref":"checklockstate","sha":"25a9deb285296b2a423655a271926036f222875e","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":109001458,"name":"sailfish-secrets","full_name":"sailfishos/sailfish-secrets","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-secrets","description":null,"fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-secrets","forks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/deployments","created_at":"2017-10-31T13:43:11Z","updated_at":"2018-05-15T04:19:10Z","pushed_at":"2018-05-15T07:22:20Z","git_url":"git://github.com/sailfishos/sailfish-secrets.git","ssh_url":"git@github.com:sailfishos/sailfish-secrets.git","clone_url":"https://github.com/sailfishos/sailfish-secrets.git","svn_url":"https://github.com/sailfishos/sailfish-secrets","homepage":null,"size":2101,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4,"open_issues":18,"watchers":15,"default_branch":"master"}},"base":{"label":"sailfishos:master","ref":"master","sha":"6fac4ea0f948500785cb7d9f712f9fca1005e020","user":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":109001458,"name":"sailfish-secrets","full_name":"sailfishos/sailfish-secrets","owner":{"login":"sailfishos","id":6198659,"avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sailfishos/sailfish-secrets","description":null,"fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-secrets","forks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-secrets/deployments","created_at":"2017-10-31T13:43:11Z","updated_at":"2018-05-15T04:19:10Z","pushed_at":"2018-05-15T07:22:20Z","git_url":"git://github.com/sailfishos/sailfish-secrets.git","ssh_url":"git@github.com:sailfishos/sailfish-secrets.git","clone_url":"https://github.com/sailfishos/sailfish-secrets.git","svn_url":"https://github.com/sailfishos/sailfish-secrets","homepage":null,"size":2101,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4,"open_issues":18,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103"},"html":{"href":"https://github.com/sailfishos/sailfish-secrets/pull/103"},"issue":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/103"},"comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/sailfishos/sailfish-secrets/statuses/25a9deb285296b2a423655a271926036f222875e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chriadam"}}