{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/13405","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/13405/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/13405/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/13405/events","html_url":"https://github.com/fastlane/fastlane/pull/13405","id":362350975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDk1NzE4","number":13405,"title":"Add support for multiple storage and encryption providers to fastlane match","user":{"login":"KrauseFx","id":869950,"node_id":"MDQ6VXNlcjg2OTk1MA==","avatar_url":"https://avatars2.githubusercontent.com/u/869950?v=4","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"labels":[{"id":560541068,"node_id":"MDU6TGFiZWw1NjA1NDEwNjg=","url":"https://api.github.com/repos/fastlane/fastlane/labels/cla:%20no","name":"cla: no","color":"b60205","default":false},{"id":315718149,"node_id":"MDU6TGFiZWwzMTU3MTgxNDk=","url":"https://api.github.com/repos/fastlane/fastlane/labels/tool:%20match","name":"tool: match","color":"fad8c7","default":false},{"id":179066153,"node_id":"MDU6TGFiZWwxNzkwNjYxNTM=","url":"https://api.github.com/repos/fastlane/fastlane/labels/type:%20feature","name":"type: feature","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-20T20:23:25Z","updated_at":"2018-10-02T20:20:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/13405","html_url":"https://github.com/fastlane/fastlane/pull/13405","diff_url":"https://github.com/fastlane/fastlane/pull/13405.diff","patch_url":"https://github.com/fastlane/fastlane/pull/13405.patch"},"body":"### Open tasks 🎉 🍾 \r\n\r\n- [x] Refactor match to support multiple implementations and ensure git based implementation still works\r\n- [x] Clearly separate the storage from the encryption\r\n- [x] Unify creating the `README.md` of the repo (if necessary)\r\n- [x] Resolve all open `# TODO`s\r\n- [x] Ensure the `change_password` command still works as expected for git based storage\r\n- [x] Ensure the `nuke` command still works as expected for all storage providers\r\n- [x] Ensure the `decrypt` command still works as expected for all storage providers\r\n- [x] Ensure we don't use `:workspace` any where any more\r\n- [x] Update tests\r\n- [x] Never call `Storage::GitStorage.new` or `Encryption::OpenSSL.new` directly\r\n\r\n## Separate PR\r\n- [ ] Unify creating the `match_version` file\r\n- [ ] When running `fastlane match decrypt`, is it expected that the `/var/...` folder is printed out as the exported repo?\r\n- [ ] Automatically load all available implementations for the `Match::Storage::` and `Match::Encryption::` namespace to allow it to be extensible\r\n- [ ] Offer a migrator between the various storage providers (separate PR)\r\n- [ ] Update docs\r\n\t- [ ] Update docs.fastlane.tools guide\r\n\t- [ ] Update main _match_ README"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/426415755","html_url":"https://github.com/fastlane/fastlane/pull/13405#issuecomment-426415755","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/13405","id":426415755,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjQxNTc1NQ==","user":{"login":"janpio","id":183673,"node_id":"MDQ6VXNlcjE4MzY3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/183673?v=4","gravatar_id":"","url":"https://api.github.com/users/janpio","html_url":"https://github.com/janpio","followers_url":"https://api.github.com/users/janpio/followers","following_url":"https://api.github.com/users/janpio/following{/other_user}","gists_url":"https://api.github.com/users/janpio/gists{/gist_id}","starred_url":"https://api.github.com/users/janpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpio/subscriptions","organizations_url":"https://api.github.com/users/janpio/orgs","repos_url":"https://api.github.com/users/janpio/repos","events_url":"https://api.github.com/users/janpio/events{/privacy}","received_events_url":"https://api.github.com/users/janpio/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T20:20:12Z","updated_at":"2018-10-02T20:20:12Z","author_association":"COLLABORATOR","body":"Et voila, passes on Windows. \r\n\r\n(Lines 118 in this file indicates that there is other code that will not work in Windows as well - but this will have to be resolved in another PR)"}}
{"actor":{"display_login":"janpio"}}