{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/Xkeeper0/smb2/pulls/12","id":226395607,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Mzk1NjA3","html_url":"https://github.com/Xkeeper0/smb2/pull/12","diff_url":"https://github.com/Xkeeper0/smb2/pull/12.diff","patch_url":"https://github.com/Xkeeper0/smb2/pull/12.patch","issue_url":"https://api.github.com/repos/Xkeeper0/smb2/issues/12","number":12,"state":"closed","locked":false,"title":"Expand music pointers","user":{"login":"kmck","id":1398194,"node_id":"MDQ6VXNlcjEzOTgxOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1398194?v=4","gravatar_id":"","url":"https://api.github.com/users/kmck","html_url":"https://github.com/kmck","followers_url":"https://api.github.com/users/kmck/followers","following_url":"https://api.github.com/users/kmck/following{/other_user}","gists_url":"https://api.github.com/users/kmck/gists{/gist_id}","starred_url":"https://api.github.com/users/kmck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmck/subscriptions","organizations_url":"https://api.github.com/users/kmck/orgs","repos_url":"https://api.github.com/users/kmck/repos","events_url":"https://api.github.com/users/kmck/events{/privacy}","received_events_url":"https://api.github.com/users/kmck/received_events","type":"User","site_admin":false},"body":"In the vanilla game, music pointers are a 1-byte offset. This effectively caps the size of the music header table, which is one of the reasons that the share-`$00`-with-the-next-table thing exists, and why including the prototype underground music also required shortening the ending.\r\n\r\nI added another lookup table so that now we can point to absolute addresses for the music headers, allowing for less restrictive music expansion.\r\n\r\nThis also includes some additional cleanup of some of the flagged music logic and splits some of the segment files that have variations rather than having flags inside. I split the `PROTOTYPE_MUSIC` flag to allow granular control of the prototype instruments, starman, underground, and ending music variations.\r\n\r\nFinally, I updated the macro to allow an explicit DPCM channel and tidied up some of the related workarounds/comments for the prototype music.\r\n\r\n✨ **Bonus** ✨ \r\n\r\nI fixed some formatting in the 1-1 area 2 level data.","created_at":"2018-10-28T20:36:39Z","updated_at":"2018-11-04T06:53:15Z","closed_at":"2018-11-04T06:53:15Z","merged_at":"2018-11-04T06:53:15Z","merge_commit_sha":"169ba8fbcddf9254075c402190c4df449565bd93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Xkeeper0/smb2/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Xkeeper0/smb2/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Xkeeper0/smb2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Xkeeper0/smb2/issues/12/comments","statuses_url":"https://api.github.com/repos/Xkeeper0/smb2/statuses/7f1e1015c6ba7a11eaaf0d7cf18f1f4b0c8b2cf9","head":{"label":"kmck:master","ref":"master","sha":"7f1e1015c6ba7a11eaaf0d7cf18f1f4b0c8b2cf9","user":{"login":"kmck","id":1398194,"node_id":"MDQ6VXNlcjEzOTgxOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1398194?v=4","gravatar_id":"","url":"https://api.github.com/users/kmck","html_url":"https://github.com/kmck","followers_url":"https://api.github.com/users/kmck/followers","following_url":"https://api.github.com/users/kmck/following{/other_user}","gists_url":"https://api.github.com/users/kmck/gists{/gist_id}","starred_url":"https://api.github.com/users/kmck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmck/subscriptions","organizations_url":"https://api.github.com/users/kmck/orgs","repos_url":"https://api.github.com/users/kmck/repos","events_url":"https://api.github.com/users/kmck/events{/privacy}","received_events_url":"https://api.github.com/users/kmck/received_events","type":"User","site_admin":false},"repo":{"id":138066065,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwNjYwNjU=","name":"smb2","full_name":"kmck/smb2","private":false,"owner":{"login":"kmck","id":1398194,"node_id":"MDQ6VXNlcjEzOTgxOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1398194?v=4","gravatar_id":"","url":"https://api.github.com/users/kmck","html_url":"https://github.com/kmck","followers_url":"https://api.github.com/users/kmck/followers","following_url":"https://api.github.com/users/kmck/following{/other_user}","gists_url":"https://api.github.com/users/kmck/gists{/gist_id}","starred_url":"https://api.github.com/users/kmck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmck/subscriptions","organizations_url":"https://api.github.com/users/kmck/orgs","repos_url":"https://api.github.com/users/kmck/repos","events_url":"https://api.github.com/users/kmck/events{/privacy}","received_events_url":"https://api.github.com/users/kmck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kmck/smb2","description":"Super Mario Bros. 2, discombobulated","fork":true,"url":"https://api.github.com/repos/kmck/smb2","forks_url":"https://api.github.com/repos/kmck/smb2/forks","keys_url":"https://api.github.com/repos/kmck/smb2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmck/smb2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmck/smb2/teams","hooks_url":"https://api.github.com/repos/kmck/smb2/hooks","issue_events_url":"https://api.github.com/repos/kmck/smb2/issues/events{/number}","events_url":"https://api.github.com/repos/kmck/smb2/events","assignees_url":"https://api.github.com/repos/kmck/smb2/assignees{/user}","branches_url":"https://api.github.com/repos/kmck/smb2/branches{/branch}","tags_url":"https://api.github.com/repos/kmck/smb2/tags","blobs_url":"https://api.github.com/repos/kmck/smb2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmck/smb2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmck/smb2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmck/smb2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmck/smb2/statuses/{sha}","languages_url":"https://api.github.com/repos/kmck/smb2/languages","stargazers_url":"https://api.github.com/repos/kmck/smb2/stargazers","contributors_url":"https://api.github.com/repos/kmck/smb2/contributors","subscribers_url":"https://api.github.com/repos/kmck/smb2/subscribers","subscription_url":"https://api.github.com/repos/kmck/smb2/subscription","commits_url":"https://api.github.com/repos/kmck/smb2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmck/smb2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmck/smb2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmck/smb2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmck/smb2/contents/{+path}","compare_url":"https://api.github.com/repos/kmck/smb2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmck/smb2/merges","archive_url":"https://api.github.com/repos/kmck/smb2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmck/smb2/downloads","issues_url":"https://api.github.com/repos/kmck/smb2/issues{/number}","pulls_url":"https://api.github.com/repos/kmck/smb2/pulls{/number}","milestones_url":"https://api.github.com/repos/kmck/smb2/milestones{/number}","notifications_url":"https://api.github.com/repos/kmck/smb2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmck/smb2/labels{/name}","releases_url":"https://api.github.com/repos/kmck/smb2/releases{/id}","deployments_url":"https://api.github.com/repos/kmck/smb2/deployments","created_at":"2018-06-20T17:40:22Z","updated_at":"2018-11-03T20:28:37Z","pushed_at":"2018-11-03T20:28:35Z","git_url":"git://github.com/kmck/smb2.git","ssh_url":"git@github.com:kmck/smb2.git","clone_url":"https://github.com/kmck/smb2.git","svn_url":"https://github.com/kmck/smb2","homepage":"https://discord.gg/TsWMMeV","size":2884,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Xkeeper0:master","ref":"master","sha":"9fc44a7ce32188b1f16f43e24614453113af1649","user":{"login":"Xkeeper0","id":1077535,"node_id":"MDQ6VXNlcjEwNzc1MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1077535?v=4","gravatar_id":"","url":"https://api.github.com/users/Xkeeper0","html_url":"https://github.com/Xkeeper0","followers_url":"https://api.github.com/users/Xkeeper0/followers","following_url":"https://api.github.com/users/Xkeeper0/following{/other_user}","gists_url":"https://api.github.com/users/Xkeeper0/gists{/gist_id}","starred_url":"https://api.github.com/users/Xkeeper0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xkeeper0/subscriptions","organizations_url":"https://api.github.com/users/Xkeeper0/orgs","repos_url":"https://api.github.com/users/Xkeeper0/repos","events_url":"https://api.github.com/users/Xkeeper0/events{/privacy}","received_events_url":"https://api.github.com/users/Xkeeper0/received_events","type":"User","site_admin":false},"repo":{"id":123884484,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM4ODQ0ODQ=","name":"smb2","full_name":"Xkeeper0/smb2","private":false,"owner":{"login":"Xkeeper0","id":1077535,"node_id":"MDQ6VXNlcjEwNzc1MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1077535?v=4","gravatar_id":"","url":"https://api.github.com/users/Xkeeper0","html_url":"https://github.com/Xkeeper0","followers_url":"https://api.github.com/users/Xkeeper0/followers","following_url":"https://api.github.com/users/Xkeeper0/following{/other_user}","gists_url":"https://api.github.com/users/Xkeeper0/gists{/gist_id}","starred_url":"https://api.github.com/users/Xkeeper0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xkeeper0/subscriptions","organizations_url":"https://api.github.com/users/Xkeeper0/orgs","repos_url":"https://api.github.com/users/Xkeeper0/repos","events_url":"https://api.github.com/users/Xkeeper0/events{/privacy}","received_events_url":"https://api.github.com/users/Xkeeper0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Xkeeper0/smb2","description":"Super Mario Bros. 2, discombobulated","fork":false,"url":"https://api.github.com/repos/Xkeeper0/smb2","forks_url":"https://api.github.com/repos/Xkeeper0/smb2/forks","keys_url":"https://api.github.com/repos/Xkeeper0/smb2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xkeeper0/smb2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xkeeper0/smb2/teams","hooks_url":"https://api.github.com/repos/Xkeeper0/smb2/hooks","issue_events_url":"https://api.github.com/repos/Xkeeper0/smb2/issues/events{/number}","events_url":"https://api.github.com/repos/Xkeeper0/smb2/events","assignees_url":"https://api.github.com/repos/Xkeeper0/smb2/assignees{/user}","branches_url":"https://api.github.com/repos/Xkeeper0/smb2/branches{/branch}","tags_url":"https://api.github.com/repos/Xkeeper0/smb2/tags","blobs_url":"https://api.github.com/repos/Xkeeper0/smb2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xkeeper0/smb2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xkeeper0/smb2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xkeeper0/smb2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xkeeper0/smb2/statuses/{sha}","languages_url":"https://api.github.com/repos/Xkeeper0/smb2/languages","stargazers_url":"https://api.github.com/repos/Xkeeper0/smb2/stargazers","contributors_url":"https://api.github.com/repos/Xkeeper0/smb2/contributors","subscribers_url":"https://api.github.com/repos/Xkeeper0/smb2/subscribers","subscription_url":"https://api.github.com/repos/Xkeeper0/smb2/subscription","commits_url":"https://api.github.com/repos/Xkeeper0/smb2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xkeeper0/smb2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xkeeper0/smb2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xkeeper0/smb2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xkeeper0/smb2/contents/{+path}","compare_url":"https://api.github.com/repos/Xkeeper0/smb2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xkeeper0/smb2/merges","archive_url":"https://api.github.com/repos/Xkeeper0/smb2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xkeeper0/smb2/downloads","issues_url":"https://api.github.com/repos/Xkeeper0/smb2/issues{/number}","pulls_url":"https://api.github.com/repos/Xkeeper0/smb2/pulls{/number}","milestones_url":"https://api.github.com/repos/Xkeeper0/smb2/milestones{/number}","notifications_url":"https://api.github.com/repos/Xkeeper0/smb2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xkeeper0/smb2/labels{/name}","releases_url":"https://api.github.com/repos/Xkeeper0/smb2/releases{/id}","deployments_url":"https://api.github.com/repos/Xkeeper0/smb2/deployments","created_at":"2018-03-05T07:55:44Z","updated_at":"2018-10-28T02:22:36Z","pushed_at":"2018-11-04T06:53:15Z","git_url":"git://github.com/Xkeeper0/smb2.git","ssh_url":"git@github.com:Xkeeper0/smb2.git","clone_url":"https://github.com/Xkeeper0/smb2.git","svn_url":"https://github.com/Xkeeper0/smb2","homepage":"https://discord.gg/TsWMMeV","size":2835,"stargazers_count":25,"watchers_count":25,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Xkeeper0/smb2/pulls/12"},"html":{"href":"https://github.com/Xkeeper0/smb2/pull/12"},"issue":{"href":"https://api.github.com/repos/Xkeeper0/smb2/issues/12"},"comments":{"href":"https://api.github.com/repos/Xkeeper0/smb2/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Xkeeper0/smb2/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Xkeeper0/smb2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Xkeeper0/smb2/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Xkeeper0/smb2/statuses/7f1e1015c6ba7a11eaaf0d7cf18f1f4b0c8b2cf9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Xkeeper0","id":1077535,"node_id":"MDQ6VXNlcjEwNzc1MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1077535?v=4","gravatar_id":"","url":"https://api.github.com/users/Xkeeper0","html_url":"https://github.com/Xkeeper0","followers_url":"https://api.github.com/users/Xkeeper0/followers","following_url":"https://api.github.com/users/Xkeeper0/following{/other_user}","gists_url":"https://api.github.com/users/Xkeeper0/gists{/gist_id}","starred_url":"https://api.github.com/users/Xkeeper0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xkeeper0/subscriptions","organizations_url":"https://api.github.com/users/Xkeeper0/orgs","repos_url":"https://api.github.com/users/Xkeeper0/repos","events_url":"https://api.github.com/users/Xkeeper0/events{/privacy}","received_events_url":"https://api.github.com/users/Xkeeper0/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":757,"deletions":183,"changed_files":17}}
{"actor":{"display_login":"Xkeeper0"}}