{"action":"created","issue":{"url":"https://api.github.com/repos/dracula/vim/issues/76","repository_url":"https://api.github.com/repos/dracula/vim","labels_url":"https://api.github.com/repos/dracula/vim/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/dracula/vim/issues/76/comments","events_url":"https://api.github.com/repos/dracula/vim/issues/76/events","html_url":"https://github.com/dracula/vim/pull/76","id":317816082,"number":76,"title":"Always set background colour when running gui.","user":{"login":"siwatts","id":14802483,"avatar_url":"https://avatars2.githubusercontent.com/u/14802483?v=4","gravatar_id":"","url":"https://api.github.com/users/siwatts","html_url":"https://github.com/siwatts","followers_url":"https://api.github.com/users/siwatts/followers","following_url":"https://api.github.com/users/siwatts/following{/other_user}","gists_url":"https://api.github.com/users/siwatts/gists{/gist_id}","starred_url":"https://api.github.com/users/siwatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siwatts/subscriptions","organizations_url":"https://api.github.com/users/siwatts/orgs","repos_url":"https://api.github.com/users/siwatts/repos","events_url":"https://api.github.com/users/siwatts/events{/privacy}","received_events_url":"https://api.github.com/users/siwatts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-25T22:29:19Z","updated_at":"2018-04-26T22:13:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dracula/vim/pulls/76","html_url":"https://github.com/dracula/vim/pull/76","diff_url":"https://github.com/dracula/vim/pull/76.diff","patch_url":"https://github.com/dracula/vim/pull/76.patch"},"body":"Setting 'g:dracula_colorterm' to '0' to get a transparent background in the terminal also sets the gui background to 'none' and breaks gvim. (The gvim background ends up white).\r\n\r\nChanged the call to the Normal highlight group to always set the background colour if the gui is running, regardless of the terminal setting.\r\n"},"comment":{"url":"https://api.github.com/repos/dracula/vim/issues/comments/384805285","html_url":"https://github.com/dracula/vim/pull/76#issuecomment-384805285","issue_url":"https://api.github.com/repos/dracula/vim/issues/76","id":384805285,"user":{"login":"benknoble","id":22802209,"avatar_url":"https://avatars3.githubusercontent.com/u/22802209?v=4","gravatar_id":"","url":"https://api.github.com/users/benknoble","html_url":"https://github.com/benknoble","followers_url":"https://api.github.com/users/benknoble/followers","following_url":"https://api.github.com/users/benknoble/following{/other_user}","gists_url":"https://api.github.com/users/benknoble/gists{/gist_id}","starred_url":"https://api.github.com/users/benknoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benknoble/subscriptions","organizations_url":"https://api.github.com/users/benknoble/orgs","repos_url":"https://api.github.com/users/benknoble/repos","events_url":"https://api.github.com/users/benknoble/events{/privacy}","received_events_url":"https://api.github.com/users/benknoble/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T22:13:54Z","updated_at":"2018-04-26T22:13:54Z","author_association":"MEMBER","body":"@dsifford Agreed about unnecessary abstraction.\r\n\r\nMy point here was more one of readability and maintainability. That three case diagram might actually be useful to have as documentation, and it wasn't 100% evident from reading the code (the logic for it is *just* complicated enough to make me scratch my head).\r\n\r\nAt any rate, has my approval."}}
{"actor":{"display_login":"benknoble"}}