{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/katdal/pulls/comments/227654081","pull_request_review_id":167743777,"id":227654081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzY1NDA4MQ==","diff_hunk":"@@ -87,6 +152,13 @@ def add_applycal_sensors(cache, attrs, freqs):\n                      for (ant_idx, ant) in enumerate(cal_ants)}\n     if not cal_input_map:\n         return\n+    try:\n+        cal_spw = SpectralWindow(attrs['cal_center_freq'], None,\n+                                 attrs['cal_n_chans'], sideband=1,\n+                                 bandwidth=attrs['cal_bandwidth'])\n+        cal_freqs = cal_spw.channel_freqs\n+    except KeyError:\n+        return","path":"katdal/applycal.py","position":162,"original_position":136,"commit_id":"8c01c945b37e4f706b575dec6100db90602b1ef1","original_commit_id":"b5456a2dddd2f1dad44e6e8130843e3ea37c2013","user":{"login":"bmerry","id":1963944,"node_id":"MDQ6VXNlcjE5NjM5NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1963944?v=4","gravatar_id":"","url":"https://api.github.com/users/bmerry","html_url":"https://github.com/bmerry","followers_url":"https://api.github.com/users/bmerry/followers","following_url":"https://api.github.com/users/bmerry/following{/other_user}","gists_url":"https://api.github.com/users/bmerry/gists{/gist_id}","starred_url":"https://api.github.com/users/bmerry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmerry/subscriptions","organizations_url":"https://api.github.com/users/bmerry/orgs","repos_url":"https://api.github.com/users/bmerry/repos","events_url":"https://api.github.com/users/bmerry/events{/privacy}","received_events_url":"https://api.github.com/users/bmerry/received_events","type":"User","site_admin":false},"body":"I'm happy with option 1, because the semantic is consistently \"if I didn't find enough information to apply cal, proceed without it\", whether that's because there is no cal information (cal_input_map is empty) or it is incomplete.","created_at":"2018-10-24T06:17:44Z","updated_at":"2018-10-24T06:17:44Z","html_url":"https://github.com/ska-sa/katdal/pull/195#discussion_r227654081","pull_request_url":"https://api.github.com/repos/ska-sa/katdal/pulls/195","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/comments/227654081"},"html":{"href":"https://github.com/ska-sa/katdal/pull/195#discussion_r227654081"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/195"}},"in_reply_to_id":226939909},"pull_request":{"url":"https://api.github.com/repos/ska-sa/katdal/pulls/195","id":224226386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjI2Mzg2","html_url":"https://github.com/ska-sa/katdal/pull/195","diff_url":"https://github.com/ska-sa/katdal/pull/195.diff","patch_url":"https://github.com/ska-sa/katdal/pull/195.patch","issue_url":"https://api.github.com/repos/ska-sa/katdal/issues/195","number":195,"state":"open","locked":false,"title":"Make L1: bandpass","user":{"login":"ludwigschwardt","id":392144,"node_id":"MDQ6VXNlcjM5MjE0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/392144?v=4","gravatar_id":"","url":"https://api.github.com/users/ludwigschwardt","html_url":"https://github.com/ludwigschwardt","followers_url":"https://api.github.com/users/ludwigschwardt/followers","following_url":"https://api.github.com/users/ludwigschwardt/following{/other_user}","gists_url":"https://api.github.com/users/ludwigschwardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwigschwardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwigschwardt/subscriptions","organizations_url":"https://api.github.com/users/ludwigschwardt/orgs","repos_url":"https://api.github.com/users/ludwigschwardt/repos","events_url":"https://api.github.com/users/ludwigschwardt/events{/privacy}","received_events_url":"https://api.github.com/users/ludwigschwardt/received_events","type":"User","site_admin":false},"body":"The bandpass solutions are linearly interpolated from the cal frequencies onto the visibility frequencies, across any invalid channels with NaNs (unless all channels are bad). There is no\r\ninterpolation over time.\r\n\r\nThis still uses the complex interpolator introduced in ska-sa/katsdppipelines#117, but this will soon be reworked to operate on magnitude + unwrapped phase directly.","created_at":"2018-10-19T09:36:51Z","updated_at":"2018-10-24T06:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9a87fed44b851742346a6d43d35cd31f43290a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/katdal/pulls/195/commits","review_comments_url":"https://api.github.com/repos/ska-sa/katdal/pulls/195/comments","review_comment_url":"https://api.github.com/repos/ska-sa/katdal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/katdal/issues/195/comments","statuses_url":"https://api.github.com/repos/ska-sa/katdal/statuses/8c01c945b37e4f706b575dec6100db90602b1ef1","head":{"label":"ska-sa:make-l1-bandpass","ref":"make-l1-bandpass","sha":"8c01c945b37e4f706b575dec6100db90602b1ef1","user":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":12869013,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2OTAxMw==","name":"katdal","full_name":"ska-sa/katdal","private":false,"owner":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ska-sa/katdal","description":"Data access library for the MeerKAT project","fork":false,"url":"https://api.github.com/repos/ska-sa/katdal","forks_url":"https://api.github.com/repos/ska-sa/katdal/forks","keys_url":"https://api.github.com/repos/ska-sa/katdal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katdal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katdal/teams","hooks_url":"https://api.github.com/repos/ska-sa/katdal/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katdal/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katdal/events","assignees_url":"https://api.github.com/repos/ska-sa/katdal/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katdal/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katdal/tags","blobs_url":"https://api.github.com/repos/ska-sa/katdal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katdal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katdal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katdal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katdal/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katdal/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katdal/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katdal/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katdal/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katdal/subscription","commits_url":"https://api.github.com/repos/ska-sa/katdal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katdal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katdal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katdal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katdal/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katdal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katdal/merges","archive_url":"https://api.github.com/repos/ska-sa/katdal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katdal/downloads","issues_url":"https://api.github.com/repos/ska-sa/katdal/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katdal/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katdal/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katdal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katdal/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katdal/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katdal/deployments","created_at":"2013-09-16T14:12:17Z","updated_at":"2018-10-22T08:23:33Z","pushed_at":"2018-10-23T10:30:39Z","git_url":"git://github.com/ska-sa/katdal.git","ssh_url":"git@github.com:ska-sa/katdal.git","clone_url":"https://github.com/ska-sa/katdal.git","svn_url":"https://github.com/ska-sa/katdal","homepage":"","size":1418,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"271aa1678bdd86a7eb8923fa211b566d1537cdc5","user":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":12869013,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2OTAxMw==","name":"katdal","full_name":"ska-sa/katdal","private":false,"owner":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ska-sa/katdal","description":"Data access library for the MeerKAT project","fork":false,"url":"https://api.github.com/repos/ska-sa/katdal","forks_url":"https://api.github.com/repos/ska-sa/katdal/forks","keys_url":"https://api.github.com/repos/ska-sa/katdal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katdal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katdal/teams","hooks_url":"https://api.github.com/repos/ska-sa/katdal/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katdal/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katdal/events","assignees_url":"https://api.github.com/repos/ska-sa/katdal/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katdal/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katdal/tags","blobs_url":"https://api.github.com/repos/ska-sa/katdal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katdal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katdal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katdal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katdal/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katdal/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katdal/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katdal/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katdal/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katdal/subscription","commits_url":"https://api.github.com/repos/ska-sa/katdal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katdal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katdal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katdal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katdal/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katdal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katdal/merges","archive_url":"https://api.github.com/repos/ska-sa/katdal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katdal/downloads","issues_url":"https://api.github.com/repos/ska-sa/katdal/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katdal/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katdal/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katdal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katdal/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katdal/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katdal/deployments","created_at":"2013-09-16T14:12:17Z","updated_at":"2018-10-22T08:23:33Z","pushed_at":"2018-10-23T10:30:39Z","git_url":"git://github.com/ska-sa/katdal.git","ssh_url":"git@github.com:ska-sa/katdal.git","clone_url":"https://github.com/ska-sa/katdal.git","svn_url":"https://github.com/ska-sa/katdal","homepage":"","size":1418,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/195"},"html":{"href":"https://github.com/ska-sa/katdal/pull/195"},"issue":{"href":"https://api.github.com/repos/ska-sa/katdal/issues/195"},"comments":{"href":"https://api.github.com/repos/ska-sa/katdal/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/katdal/statuses/8c01c945b37e4f706b575dec6100db90602b1ef1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmerry"}}