{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11886","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11886/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11886/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11886/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11886","id":387896068,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Mjg0MzY1","number":11886,"title":"scripts: extract_dts_includes: Add simple defines for i2c/spi children","user":{"login":"galak","id":16417047,"node_id":"MDQ6VXNlcjE2NDE3MDQ3","avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false},"labels":[{"id":807706246,"node_id":"MDU6TGFiZWw4MDc3MDYyNDY=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/DNM","name":"DNM","color":"b60205","default":false},{"id":700909632,"node_id":"MDU6TGFiZWw3MDA5MDk2MzI=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Device%20Tree","name":"area: Device Tree","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-12-05T18:52:13Z","updated_at":"2018-12-08T23:58:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/11886","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11886","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11886.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11886.patch"},"body":"To simply and reduce what one has to do in a fixup file for i2c & spi\r\ndevices, we generate aliased defines based on just the compatible name.\r\nFor now we make the assumption that there is only one sensor of a given\r\ncompatible in the system (which is how all I2C & SPI client drivers are\r\ncurrently).\r\n\r\nSigned-off-by: Kumar Gala <kumar.gala@linaro.org>"},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/445499171","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/11886#issuecomment-445499171","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/11886","id":445499171,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTQ5OTE3MQ==","user":{"login":"pabigot","id":964298,"node_id":"MDQ6VXNlcjk2NDI5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/964298?v=4","gravatar_id":"","url":"https://api.github.com/users/pabigot","html_url":"https://github.com/pabigot","followers_url":"https://api.github.com/users/pabigot/followers","following_url":"https://api.github.com/users/pabigot/following{/other_user}","gists_url":"https://api.github.com/users/pabigot/gists{/gist_id}","starred_url":"https://api.github.com/users/pabigot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabigot/subscriptions","organizations_url":"https://api.github.com/users/pabigot/orgs","repos_url":"https://api.github.com/users/pabigot/repos","events_url":"https://api.github.com/users/pabigot/events{/privacy}","received_events_url":"https://api.github.com/users/pabigot/received_events","type":"User","site_admin":false},"created_at":"2018-12-08T23:58:24Z","updated_at":"2018-12-08T23:58:24Z","author_association":"COLLABORATOR","body":"> That's the main problem with this PR, we're going for a quick win without working out the concept.\r\n\r\nI don't disagree.  Lacking sufficient information on the detailed design for code generation my goal is short-term relief of the dts_fixup pain we're already experiencing, so at least we get *some* shared experience with where we're heading before the tooling shows up.\r\n\r\n> This PR is (re-)using part of the code which is responsible for generating aliases, i.e. it's relying on the fact that defines generated for aliases are prefixed with compatible string. If we changed that this PR would break.\r\n\r\nNo, this PR proposed adding a third prefix that did not include alias, just compatible.  Since it won't work, we'd have to fall back to one of the two solutions that are already in the baseline: the legacy alias-only prefix that doesn't include `DT_`, or the newer `DT_` + compatible + alias one.  Which I would really like to see changed to remove `compatible`, as both you and I have proposed."}}
{"actor":{"display_login":"pabigot"}}