{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/235889153","pull_request_review_id":177859935,"id":235889153,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTg4OTE1Mw==","diff_hunk":"@@ -0,0 +1,36 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.table.functions;\n+\n+/**\n+ * Defines an implicit conversion method (distinct) that converts {@link AggregateFunction}s into\n+ * {@link DistinctAgg} Expressions.\n+ */\n+public class DistinctAggregateFunction<T, ACC> {","path":"flink-libraries/flink-table-common/src/main/java/org/apache/flink/table/functions/DistinctAggregateFunction.java","position":25,"original_position":25,"commit_id":"6c88682f6388d0c2d99f347ed47ddf73c8dee08b","original_commit_id":"6c88682f6388d0c2d99f347ed47ddf73c8dee08b","user":{"login":"twalthr","id":5746567,"node_id":"MDQ6VXNlcjU3NDY1Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5746567?v=4","gravatar_id":"","url":"https://api.github.com/users/twalthr","html_url":"https://github.com/twalthr","followers_url":"https://api.github.com/users/twalthr/followers","following_url":"https://api.github.com/users/twalthr/following{/other_user}","gists_url":"https://api.github.com/users/twalthr/gists{/gist_id}","starred_url":"https://api.github.com/users/twalthr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalthr/subscriptions","organizations_url":"https://api.github.com/users/twalthr/orgs","repos_url":"https://api.github.com/users/twalthr/repos","events_url":"https://api.github.com/users/twalthr/events{/privacy}","received_events_url":"https://api.github.com/users/twalthr/received_events","type":"User","site_admin":false},"body":"This class is not public API and should not be part of {{flink-table-common}}.","created_at":"2018-11-23T09:54:45Z","updated_at":"2018-11-23T09:59:17Z","html_url":"https://github.com/apache/flink/pull/7059#discussion_r235889153","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/7059","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/235889153"},"html":{"href":"https://github.com/apache/flink/pull/7059#discussion_r235889153"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/7059"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/7059","id":229364802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzY0ODAy","html_url":"https://github.com/apache/flink/pull/7059","diff_url":"https://github.com/apache/flink/pull/7059.diff","patch_url":"https://github.com/apache/flink/pull/7059.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/7059","number":7059,"state":"open","locked":false,"title":"[FLINK-10689][table] Port UDFs in Table API extension points to flink-table-common","user":{"login":"xueyumusic","id":95261,"node_id":"MDQ6VXNlcjk1MjYx","avatar_url":"https://avatars1.githubusercontent.com/u/95261?v=4","gravatar_id":"","url":"https://api.github.com/users/xueyumusic","html_url":"https://github.com/xueyumusic","followers_url":"https://api.github.com/users/xueyumusic/followers","following_url":"https://api.github.com/users/xueyumusic/following{/other_user}","gists_url":"https://api.github.com/users/xueyumusic/gists{/gist_id}","starred_url":"https://api.github.com/users/xueyumusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xueyumusic/subscriptions","organizations_url":"https://api.github.com/users/xueyumusic/orgs","repos_url":"https://api.github.com/users/xueyumusic/repos","events_url":"https://api.github.com/users/xueyumusic/events{/privacy}","received_events_url":"https://api.github.com/users/xueyumusic/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nThis PR tries to port UDFs interfaces of TableApi extension points to flink-table-common in java. Right now  it ports UserDefinedFunction, ScalarFunction, TableFunction, AggregateFunction, DistinctAggregateFunction in org.apache.flink.table.functions execpt FunctionService and TemporalTableFunction. FunctionService and TemporalTableFunction may be could be ported following.\r\n\r\n\r\n## Brief change log\r\n\r\n*(for example:)*\r\n  - *port several scala file in org.apache.flink.table.functions to java *\r\n\r\n## Verifying this change\r\n\r\nThis change is a code refactor with existed tests.\r\n\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (no)\r\n  - If yes, how is the feature documented? (not documented)\r\n","created_at":"2018-11-08T13:30:18Z","updated_at":"2018-11-23T09:59:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1ddaf1cfbf010fd84ff64d383ccd525193486d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/7059/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/7059/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/7059/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/6c88682f6388d0c2d99f347ed47ddf73c8dee08b","head":{"label":"xueyumusic:table-common-function","ref":"table-common-function","sha":"6c88682f6388d0c2d99f347ed47ddf73c8dee08b","user":{"login":"xueyumusic","id":95261,"node_id":"MDQ6VXNlcjk1MjYx","avatar_url":"https://avatars1.githubusercontent.com/u/95261?v=4","gravatar_id":"","url":"https://api.github.com/users/xueyumusic","html_url":"https://github.com/xueyumusic","followers_url":"https://api.github.com/users/xueyumusic/followers","following_url":"https://api.github.com/users/xueyumusic/following{/other_user}","gists_url":"https://api.github.com/users/xueyumusic/gists{/gist_id}","starred_url":"https://api.github.com/users/xueyumusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xueyumusic/subscriptions","organizations_url":"https://api.github.com/users/xueyumusic/orgs","repos_url":"https://api.github.com/users/xueyumusic/repos","events_url":"https://api.github.com/users/xueyumusic/events{/privacy}","received_events_url":"https://api.github.com/users/xueyumusic/received_events","type":"User","site_admin":false},"repo":{"id":137833131,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4MzMxMzE=","name":"flink","full_name":"xueyumusic/flink","private":false,"owner":{"login":"xueyumusic","id":95261,"node_id":"MDQ6VXNlcjk1MjYx","avatar_url":"https://avatars1.githubusercontent.com/u/95261?v=4","gravatar_id":"","url":"https://api.github.com/users/xueyumusic","html_url":"https://github.com/xueyumusic","followers_url":"https://api.github.com/users/xueyumusic/followers","following_url":"https://api.github.com/users/xueyumusic/following{/other_user}","gists_url":"https://api.github.com/users/xueyumusic/gists{/gist_id}","starred_url":"https://api.github.com/users/xueyumusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xueyumusic/subscriptions","organizations_url":"https://api.github.com/users/xueyumusic/orgs","repos_url":"https://api.github.com/users/xueyumusic/repos","events_url":"https://api.github.com/users/xueyumusic/events{/privacy}","received_events_url":"https://api.github.com/users/xueyumusic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xueyumusic/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/xueyumusic/flink","forks_url":"https://api.github.com/repos/xueyumusic/flink/forks","keys_url":"https://api.github.com/repos/xueyumusic/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xueyumusic/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xueyumusic/flink/teams","hooks_url":"https://api.github.com/repos/xueyumusic/flink/hooks","issue_events_url":"https://api.github.com/repos/xueyumusic/flink/issues/events{/number}","events_url":"https://api.github.com/repos/xueyumusic/flink/events","assignees_url":"https://api.github.com/repos/xueyumusic/flink/assignees{/user}","branches_url":"https://api.github.com/repos/xueyumusic/flink/branches{/branch}","tags_url":"https://api.github.com/repos/xueyumusic/flink/tags","blobs_url":"https://api.github.com/repos/xueyumusic/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xueyumusic/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xueyumusic/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/xueyumusic/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xueyumusic/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/xueyumusic/flink/languages","stargazers_url":"https://api.github.com/repos/xueyumusic/flink/stargazers","contributors_url":"https://api.github.com/repos/xueyumusic/flink/contributors","subscribers_url":"https://api.github.com/repos/xueyumusic/flink/subscribers","subscription_url":"https://api.github.com/repos/xueyumusic/flink/subscription","commits_url":"https://api.github.com/repos/xueyumusic/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/xueyumusic/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/xueyumusic/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/xueyumusic/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/xueyumusic/flink/contents/{+path}","compare_url":"https://api.github.com/repos/xueyumusic/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xueyumusic/flink/merges","archive_url":"https://api.github.com/repos/xueyumusic/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xueyumusic/flink/downloads","issues_url":"https://api.github.com/repos/xueyumusic/flink/issues{/number}","pulls_url":"https://api.github.com/repos/xueyumusic/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/xueyumusic/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/xueyumusic/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xueyumusic/flink/labels{/name}","releases_url":"https://api.github.com/repos/xueyumusic/flink/releases{/id}","deployments_url":"https://api.github.com/repos/xueyumusic/flink/deployments","created_at":"2018-06-19T03:00:32Z","updated_at":"2018-06-19T03:00:59Z","pushed_at":"2018-11-20T08:26:44Z","git_url":"git://github.com/xueyumusic/flink.git","ssh_url":"git@github.com:xueyumusic/flink.git","clone_url":"https://github.com/xueyumusic/flink.git","svn_url":"https://github.com/xueyumusic/flink","homepage":null,"size":167264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2190c6d5bda2465993bae1d1486bf259a8c5a0ee","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-11-23T09:09:30Z","pushed_at":"2018-11-23T03:12:33Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":170402,"stargazers_count":4981,"watchers_count":4981,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3156,"mirror_url":null,"archived":false,"open_issues_count":397,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3156,"open_issues":397,"watchers":4981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/7059"},"html":{"href":"https://github.com/apache/flink/pull/7059"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/7059"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/7059/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/7059/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/7059/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/6c88682f6388d0c2d99f347ed47ddf73c8dee08b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"twalthr"}}