{"action":"opened","number":24621,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24621","id":233307228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzA3MjI4","html_url":"https://github.com/nodejs/node/pull/24621","diff_url":"https://github.com/nodejs/node/pull/24621.diff","patch_url":"https://github.com/nodejs/node/pull/24621.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24621","number":24621,"state":"open","locked":false,"title":"test: fix arguments order in `assert.strictEqual`","user":{"login":"na9amura","id":4410504,"node_id":"MDQ6VXNlcjQ0MTA1MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4410504?v=4","gravatar_id":"","url":"https://api.github.com/users/na9amura","html_url":"https://github.com/na9amura","followers_url":"https://api.github.com/users/na9amura/followers","following_url":"https://api.github.com/users/na9amura/following{/other_user}","gists_url":"https://api.github.com/users/na9amura/gists{/gist_id}","starred_url":"https://api.github.com/users/na9amura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/na9amura/subscriptions","organizations_url":"https://api.github.com/users/na9amura/orgs","repos_url":"https://api.github.com/users/na9amura/repos","events_url":"https://api.github.com/users/na9amura/events{/privacy}","received_events_url":"https://api.github.com/users/na9amura/received_events","type":"User","site_admin":false},"body":"fix arguments order to be `assert.strictEqual(actual, expected)`\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-11-24T08:05:43Z","updated_at":"2018-11-24T08:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24621/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24621/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24621/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/e3ccd2657700b4ce50c2b5f7374f4c0f5af1ed60","head":{"label":"na9amura:fix-strict-equal-arguments","ref":"fix-strict-equal-arguments","sha":"e3ccd2657700b4ce50c2b5f7374f4c0f5af1ed60","user":{"login":"na9amura","id":4410504,"node_id":"MDQ6VXNlcjQ0MTA1MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4410504?v=4","gravatar_id":"","url":"https://api.github.com/users/na9amura","html_url":"https://github.com/na9amura","followers_url":"https://api.github.com/users/na9amura/followers","following_url":"https://api.github.com/users/na9amura/following{/other_user}","gists_url":"https://api.github.com/users/na9amura/gists{/gist_id}","starred_url":"https://api.github.com/users/na9amura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/na9amura/subscriptions","organizations_url":"https://api.github.com/users/na9amura/orgs","repos_url":"https://api.github.com/users/na9amura/repos","events_url":"https://api.github.com/users/na9amura/events{/privacy}","received_events_url":"https://api.github.com/users/na9amura/received_events","type":"User","site_admin":false},"repo":{"id":158907811,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg5MDc4MTE=","name":"node","full_name":"na9amura/node","private":false,"owner":{"login":"na9amura","id":4410504,"node_id":"MDQ6VXNlcjQ0MTA1MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4410504?v=4","gravatar_id":"","url":"https://api.github.com/users/na9amura","html_url":"https://github.com/na9amura","followers_url":"https://api.github.com/users/na9amura/followers","following_url":"https://api.github.com/users/na9amura/following{/other_user}","gists_url":"https://api.github.com/users/na9amura/gists{/gist_id}","starred_url":"https://api.github.com/users/na9amura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/na9amura/subscriptions","organizations_url":"https://api.github.com/users/na9amura/orgs","repos_url":"https://api.github.com/users/na9amura/repos","events_url":"https://api.github.com/users/na9amura/events{/privacy}","received_events_url":"https://api.github.com/users/na9amura/received_events","type":"User","site_admin":false},"html_url":"https://github.com/na9amura/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/na9amura/node","forks_url":"https://api.github.com/repos/na9amura/node/forks","keys_url":"https://api.github.com/repos/na9amura/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/na9amura/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/na9amura/node/teams","hooks_url":"https://api.github.com/repos/na9amura/node/hooks","issue_events_url":"https://api.github.com/repos/na9amura/node/issues/events{/number}","events_url":"https://api.github.com/repos/na9amura/node/events","assignees_url":"https://api.github.com/repos/na9amura/node/assignees{/user}","branches_url":"https://api.github.com/repos/na9amura/node/branches{/branch}","tags_url":"https://api.github.com/repos/na9amura/node/tags","blobs_url":"https://api.github.com/repos/na9amura/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/na9amura/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/na9amura/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/na9amura/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/na9amura/node/statuses/{sha}","languages_url":"https://api.github.com/repos/na9amura/node/languages","stargazers_url":"https://api.github.com/repos/na9amura/node/stargazers","contributors_url":"https://api.github.com/repos/na9amura/node/contributors","subscribers_url":"https://api.github.com/repos/na9amura/node/subscribers","subscription_url":"https://api.github.com/repos/na9amura/node/subscription","commits_url":"https://api.github.com/repos/na9amura/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/na9amura/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/na9amura/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/na9amura/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/na9amura/node/contents/{+path}","compare_url":"https://api.github.com/repos/na9amura/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/na9amura/node/merges","archive_url":"https://api.github.com/repos/na9amura/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/na9amura/node/downloads","issues_url":"https://api.github.com/repos/na9amura/node/issues{/number}","pulls_url":"https://api.github.com/repos/na9amura/node/pulls{/number}","milestones_url":"https://api.github.com/repos/na9amura/node/milestones{/number}","notifications_url":"https://api.github.com/repos/na9amura/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/na9amura/node/labels{/name}","releases_url":"https://api.github.com/repos/na9amura/node/releases{/id}","deployments_url":"https://api.github.com/repos/na9amura/node/deployments","created_at":"2018-11-24T06:09:46Z","updated_at":"2018-11-24T06:10:12Z","pushed_at":"2018-11-24T08:04:06Z","git_url":"git://github.com/na9amura/node.git","ssh_url":"git@github.com:na9amura/node.git","clone_url":"https://github.com/na9amura/node.git","svn_url":"https://github.com/na9amura/node","homepage":"https://nodejs.org","size":434467,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e2140697aa095ac3dfc469c759e3f26edea6c08f","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-24T08:00:55Z","pushed_at":"2018-11-24T08:05:30Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":434499,"stargazers_count":55679,"watchers_count":55679,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12269,"mirror_url":null,"archived":false,"open_issues_count":819,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12269,"open_issues":819,"watchers":55679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24621"},"html":{"href":"https://github.com/nodejs/node/pull/24621"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24621"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24621/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24621/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24621/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/e3ccd2657700b4ce50c2b5f7374f4c0f5af1ed60"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"na9amura"}}