{"action":"closed","number":159,"pull_request":{"url":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/159","id":210525531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTI1NTMx","html_url":"https://github.com/DockYard/ember-in-viewport/pull/159","diff_url":"https://github.com/DockYard/ember-in-viewport/pull/159.diff","patch_url":"https://github.com/DockYard/ember-in-viewport/pull/159.patch","issue_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/159","number":159,"state":"closed","locked":false,"title":" Do not cancel rAF as this effects other elements that are observed","user":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"body":"If there are many elements on the page, rAF `cancel` effects other observed elements.  This was just a minor optimization but the downsides of this outweigh those benefits.\r\n\r\nReverting for now but need to revisit.\r\n\r\nRef #145 #152 \r\n\r\nclose #154 ","created_at":"2018-08-23T17:46:43Z","updated_at":"2018-08-23T18:08:12Z","closed_at":"2018-08-23T18:08:12Z","merged_at":"2018-08-23T18:08:11Z","merge_commit_sha":"090e47c6d7f9c8cef3140fc40e5e96384f850a64","assignee":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"assignees":[{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":199071423,"node_id":"MDU6TGFiZWwxOTkwNzE0MjM=","url":"https://api.github.com/repos/DockYard/ember-in-viewport/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/159/commits","review_comments_url":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/159/comments","review_comment_url":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/159/comments","statuses_url":"https://api.github.com/repos/DockYard/ember-in-viewport/statuses/a14ba8db7b03a80c5e3d3f02fcd5614879d23d11","head":{"label":"DockYard:sn/fix-raf-cancel","ref":"sn/fix-raf-cancel","sha":"a14ba8db7b03a80c5e3d3f02fcd5614879d23d11","user":{"login":"DockYard","id":873981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3Mzk4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/873981?v=4","gravatar_id":"","url":"https://api.github.com/users/DockYard","html_url":"https://github.com/DockYard","followers_url":"https://api.github.com/users/DockYard/followers","following_url":"https://api.github.com/users/DockYard/following{/other_user}","gists_url":"https://api.github.com/users/DockYard/gists{/gist_id}","starred_url":"https://api.github.com/users/DockYard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DockYard/subscriptions","organizations_url":"https://api.github.com/users/DockYard/orgs","repos_url":"https://api.github.com/users/DockYard/repos","events_url":"https://api.github.com/users/DockYard/events{/privacy}","received_events_url":"https://api.github.com/users/DockYard/received_events","type":"Organization","site_admin":false},"repo":{"id":33871338,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg3MTMzOA==","name":"ember-in-viewport","full_name":"DockYard/ember-in-viewport","owner":{"login":"DockYard","id":873981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3Mzk4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/873981?v=4","gravatar_id":"","url":"https://api.github.com/users/DockYard","html_url":"https://github.com/DockYard","followers_url":"https://api.github.com/users/DockYard/followers","following_url":"https://api.github.com/users/DockYard/following{/other_user}","gists_url":"https://api.github.com/users/DockYard/gists{/gist_id}","starred_url":"https://api.github.com/users/DockYard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DockYard/subscriptions","organizations_url":"https://api.github.com/users/DockYard/orgs","repos_url":"https://api.github.com/users/DockYard/repos","events_url":"https://api.github.com/users/DockYard/events{/privacy}","received_events_url":"https://api.github.com/users/DockYard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DockYard/ember-in-viewport","description":"Detect if an Ember View or Component is in the viewport @ 60FPS","fork":false,"url":"https://api.github.com/repos/DockYard/ember-in-viewport","forks_url":"https://api.github.com/repos/DockYard/ember-in-viewport/forks","keys_url":"https://api.github.com/repos/DockYard/ember-in-viewport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DockYard/ember-in-viewport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DockYard/ember-in-viewport/teams","hooks_url":"https://api.github.com/repos/DockYard/ember-in-viewport/hooks","issue_events_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/events{/number}","events_url":"https://api.github.com/repos/DockYard/ember-in-viewport/events","assignees_url":"https://api.github.com/repos/DockYard/ember-in-viewport/assignees{/user}","branches_url":"https://api.github.com/repos/DockYard/ember-in-viewport/branches{/branch}","tags_url":"https://api.github.com/repos/DockYard/ember-in-viewport/tags","blobs_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/refs{/sha}","trees_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DockYard/ember-in-viewport/statuses/{sha}","languages_url":"https://api.github.com/repos/DockYard/ember-in-viewport/languages","stargazers_url":"https://api.github.com/repos/DockYard/ember-in-viewport/stargazers","contributors_url":"https://api.github.com/repos/DockYard/ember-in-viewport/contributors","subscribers_url":"https://api.github.com/repos/DockYard/ember-in-viewport/subscribers","subscription_url":"https://api.github.com/repos/DockYard/ember-in-viewport/subscription","commits_url":"https://api.github.com/repos/DockYard/ember-in-viewport/commits{/sha}","git_commits_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/commits{/sha}","comments_url":"https://api.github.com/repos/DockYard/ember-in-viewport/comments{/number}","issue_comment_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/comments{/number}","contents_url":"https://api.github.com/repos/DockYard/ember-in-viewport/contents/{+path}","compare_url":"https://api.github.com/repos/DockYard/ember-in-viewport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DockYard/ember-in-viewport/merges","archive_url":"https://api.github.com/repos/DockYard/ember-in-viewport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DockYard/ember-in-viewport/downloads","issues_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues{/number}","pulls_url":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls{/number}","milestones_url":"https://api.github.com/repos/DockYard/ember-in-viewport/milestones{/number}","notifications_url":"https://api.github.com/repos/DockYard/ember-in-viewport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DockYard/ember-in-viewport/labels{/name}","releases_url":"https://api.github.com/repos/DockYard/ember-in-viewport/releases{/id}","deployments_url":"https://api.github.com/repos/DockYard/ember-in-viewport/deployments","created_at":"2015-04-13T13:51:50Z","updated_at":"2018-08-22T16:28:18Z","pushed_at":"2018-08-23T18:08:11Z","git_url":"git://github.com/DockYard/ember-in-viewport.git","ssh_url":"git@github.com:DockYard/ember-in-viewport.git","clone_url":"https://github.com/DockYard/ember-in-viewport.git","svn_url":"https://github.com/DockYard/ember-in-viewport","homepage":"","size":572,"stargazers_count":208,"watchers_count":208,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":11,"watchers":208,"default_branch":"master"}},"base":{"label":"DockYard:master","ref":"master","sha":"1e35c02fb3c41ad0ef04e799dc78ca11fb74c487","user":{"login":"DockYard","id":873981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3Mzk4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/873981?v=4","gravatar_id":"","url":"https://api.github.com/users/DockYard","html_url":"https://github.com/DockYard","followers_url":"https://api.github.com/users/DockYard/followers","following_url":"https://api.github.com/users/DockYard/following{/other_user}","gists_url":"https://api.github.com/users/DockYard/gists{/gist_id}","starred_url":"https://api.github.com/users/DockYard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DockYard/subscriptions","organizations_url":"https://api.github.com/users/DockYard/orgs","repos_url":"https://api.github.com/users/DockYard/repos","events_url":"https://api.github.com/users/DockYard/events{/privacy}","received_events_url":"https://api.github.com/users/DockYard/received_events","type":"Organization","site_admin":false},"repo":{"id":33871338,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg3MTMzOA==","name":"ember-in-viewport","full_name":"DockYard/ember-in-viewport","owner":{"login":"DockYard","id":873981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3Mzk4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/873981?v=4","gravatar_id":"","url":"https://api.github.com/users/DockYard","html_url":"https://github.com/DockYard","followers_url":"https://api.github.com/users/DockYard/followers","following_url":"https://api.github.com/users/DockYard/following{/other_user}","gists_url":"https://api.github.com/users/DockYard/gists{/gist_id}","starred_url":"https://api.github.com/users/DockYard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DockYard/subscriptions","organizations_url":"https://api.github.com/users/DockYard/orgs","repos_url":"https://api.github.com/users/DockYard/repos","events_url":"https://api.github.com/users/DockYard/events{/privacy}","received_events_url":"https://api.github.com/users/DockYard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DockYard/ember-in-viewport","description":"Detect if an Ember View or Component is in the viewport @ 60FPS","fork":false,"url":"https://api.github.com/repos/DockYard/ember-in-viewport","forks_url":"https://api.github.com/repos/DockYard/ember-in-viewport/forks","keys_url":"https://api.github.com/repos/DockYard/ember-in-viewport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DockYard/ember-in-viewport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DockYard/ember-in-viewport/teams","hooks_url":"https://api.github.com/repos/DockYard/ember-in-viewport/hooks","issue_events_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/events{/number}","events_url":"https://api.github.com/repos/DockYard/ember-in-viewport/events","assignees_url":"https://api.github.com/repos/DockYard/ember-in-viewport/assignees{/user}","branches_url":"https://api.github.com/repos/DockYard/ember-in-viewport/branches{/branch}","tags_url":"https://api.github.com/repos/DockYard/ember-in-viewport/tags","blobs_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/refs{/sha}","trees_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DockYard/ember-in-viewport/statuses/{sha}","languages_url":"https://api.github.com/repos/DockYard/ember-in-viewport/languages","stargazers_url":"https://api.github.com/repos/DockYard/ember-in-viewport/stargazers","contributors_url":"https://api.github.com/repos/DockYard/ember-in-viewport/contributors","subscribers_url":"https://api.github.com/repos/DockYard/ember-in-viewport/subscribers","subscription_url":"https://api.github.com/repos/DockYard/ember-in-viewport/subscription","commits_url":"https://api.github.com/repos/DockYard/ember-in-viewport/commits{/sha}","git_commits_url":"https://api.github.com/repos/DockYard/ember-in-viewport/git/commits{/sha}","comments_url":"https://api.github.com/repos/DockYard/ember-in-viewport/comments{/number}","issue_comment_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/comments{/number}","contents_url":"https://api.github.com/repos/DockYard/ember-in-viewport/contents/{+path}","compare_url":"https://api.github.com/repos/DockYard/ember-in-viewport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DockYard/ember-in-viewport/merges","archive_url":"https://api.github.com/repos/DockYard/ember-in-viewport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DockYard/ember-in-viewport/downloads","issues_url":"https://api.github.com/repos/DockYard/ember-in-viewport/issues{/number}","pulls_url":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls{/number}","milestones_url":"https://api.github.com/repos/DockYard/ember-in-viewport/milestones{/number}","notifications_url":"https://api.github.com/repos/DockYard/ember-in-viewport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DockYard/ember-in-viewport/labels{/name}","releases_url":"https://api.github.com/repos/DockYard/ember-in-viewport/releases{/id}","deployments_url":"https://api.github.com/repos/DockYard/ember-in-viewport/deployments","created_at":"2015-04-13T13:51:50Z","updated_at":"2018-08-22T16:28:18Z","pushed_at":"2018-08-23T18:08:11Z","git_url":"git://github.com/DockYard/ember-in-viewport.git","ssh_url":"git@github.com:DockYard/ember-in-viewport.git","clone_url":"https://github.com/DockYard/ember-in-viewport.git","svn_url":"https://github.com/DockYard/ember-in-viewport","homepage":"","size":572,"stargazers_count":208,"watchers_count":208,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":63,"open_issues":11,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/159"},"html":{"href":"https://github.com/DockYard/ember-in-viewport/pull/159"},"issue":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/159"},"comments":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/DockYard/ember-in-viewport/statuses/a14ba8db7b03a80c5e3d3f02fcd5614879d23d11"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"snewcomer","id":7374640,"node_id":"MDQ6VXNlcjczNzQ2NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7374640?v=4","gravatar_id":"","url":"https://api.github.com/users/snewcomer","html_url":"https://github.com/snewcomer","followers_url":"https://api.github.com/users/snewcomer/followers","following_url":"https://api.github.com/users/snewcomer/following{/other_user}","gists_url":"https://api.github.com/users/snewcomer/gists{/gist_id}","starred_url":"https://api.github.com/users/snewcomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snewcomer/subscriptions","organizations_url":"https://api.github.com/users/snewcomer/orgs","repos_url":"https://api.github.com/users/snewcomer/repos","events_url":"https://api.github.com/users/snewcomer/events{/privacy}","received_events_url":"https://api.github.com/users/snewcomer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":1,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"snewcomer"}}