{"action":"created","comment":{"url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/comments/211058219","pull_request_review_id":147412204,"id":211058219,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA1ODIxOQ==","diff_hunk":"@@ -31,6 +31,12 @@ def transpose(a, axes):\n def einsum(equation, *operands):\n     \"\"\"Variadic version of torch.einsum to match numpy api.\n     \"\"\"\n+    # rename symbols to support PyTorch 0.4.1 and earlier,\n+    # which allow only symbols a-z.\n+    symbols = sorted(set(equation) - set(',->'))","path":"opt_einsum/backends/torch.py","position":15,"original_position":15,"commit_id":"a24dfe0580e90a2c0d0542724a66a546dd3da5e0","original_commit_id":"a24dfe0580e90a2c0d0542724a66a546dd3da5e0","user":{"login":"fritzo","id":648532,"node_id":"MDQ6VXNlcjY0ODUzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/648532?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzo","html_url":"https://github.com/fritzo","followers_url":"https://api.github.com/users/fritzo/followers","following_url":"https://api.github.com/users/fritzo/following{/other_user}","gists_url":"https://api.github.com/users/fritzo/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzo/subscriptions","organizations_url":"https://api.github.com/users/fritzo/orgs","repos_url":"https://api.github.com/users/fritzo/repos","events_url":"https://api.github.com/users/fritzo/events{/privacy}","received_events_url":"https://api.github.com/users/fritzo/received_events","type":"User","site_admin":false},"body":"The advantage of not throwing is that this will continue to work when PyTorch fixes their einsum to allow more symbols. I'd rather let their current implementation throw.","created_at":"2018-08-18T00:28:54Z","updated_at":"2018-08-18T00:28:54Z","html_url":"https://github.com/dgasmith/opt_einsum/pull/41#discussion_r211058219","pull_request_url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/comments/211058219"},"html":{"href":"https://github.com/dgasmith/opt_einsum/pull/41#discussion_r211058219"},"pull_request":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41"}},"in_reply_to_id":211057793},"pull_request":{"url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41","id":209277264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Mjc3MjY0","html_url":"https://github.com/dgasmith/opt_einsum/pull/41","diff_url":"https://github.com/dgasmith/opt_einsum/pull/41.diff","patch_url":"https://github.com/dgasmith/opt_einsum/pull/41.patch","issue_url":"https://api.github.com/repos/dgasmith/opt_einsum/issues/41","number":41,"state":"open","locked":false,"title":"Rename symbols to support torch.einsum","user":{"login":"fritzo","id":648532,"node_id":"MDQ6VXNlcjY0ODUzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/648532?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzo","html_url":"https://github.com/fritzo","followers_url":"https://api.github.com/users/fritzo/followers","following_url":"https://api.github.com/users/fritzo/following{/other_user}","gists_url":"https://api.github.com/users/fritzo/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzo/subscriptions","organizations_url":"https://api.github.com/users/fritzo/orgs","repos_url":"https://api.github.com/users/fritzo/repos","events_url":"https://api.github.com/users/fritzo/events{/privacy}","received_events_url":"https://api.github.com/users/fritzo/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis renames symbols to support PyTorch 0.4.1 which supports only symbols a-z. This is useful when the overall computation has more than 26 dimensions but any single contraction requires only 26 or fewer dimensions.\r\n\r\n## Questions\r\n- [ ] Do other backends work? I have only tested PyTorch. If other backends don't work, I'll simply limit the test to the PyTorch backend.\r\n\r\n## Status\r\n- [x] Ready to merge as soon as tests pass\r\n\r\n## Tested\r\n\r\n- Added a test with non-lowercase symbols\r\n- Tested that this works in an application using Pyro https://github.com/uber/pyro/pull/1313","created_at":"2018-08-17T23:12:53Z","updated_at":"2018-08-18T00:28:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"072013101a26e86a5c13947026d88332b3229465","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jcmgray","id":8982598,"node_id":"MDQ6VXNlcjg5ODI1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/8982598?v=4","gravatar_id":"","url":"https://api.github.com/users/jcmgray","html_url":"https://github.com/jcmgray","followers_url":"https://api.github.com/users/jcmgray/followers","following_url":"https://api.github.com/users/jcmgray/following{/other_user}","gists_url":"https://api.github.com/users/jcmgray/gists{/gist_id}","starred_url":"https://api.github.com/users/jcmgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcmgray/subscriptions","organizations_url":"https://api.github.com/users/jcmgray/orgs","repos_url":"https://api.github.com/users/jcmgray/repos","events_url":"https://api.github.com/users/jcmgray/events{/privacy}","received_events_url":"https://api.github.com/users/jcmgray/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41/commits","review_comments_url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41/comments","review_comment_url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dgasmith/opt_einsum/issues/41/comments","statuses_url":"https://api.github.com/repos/dgasmith/opt_einsum/statuses/a24dfe0580e90a2c0d0542724a66a546dd3da5e0","head":{"label":"fritzo:torch-rename","ref":"torch-rename","sha":"a24dfe0580e90a2c0d0542724a66a546dd3da5e0","user":{"login":"fritzo","id":648532,"node_id":"MDQ6VXNlcjY0ODUzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/648532?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzo","html_url":"https://github.com/fritzo","followers_url":"https://api.github.com/users/fritzo/followers","following_url":"https://api.github.com/users/fritzo/following{/other_user}","gists_url":"https://api.github.com/users/fritzo/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzo/subscriptions","organizations_url":"https://api.github.com/users/fritzo/orgs","repos_url":"https://api.github.com/users/fritzo/repos","events_url":"https://api.github.com/users/fritzo/events{/privacy}","received_events_url":"https://api.github.com/users/fritzo/received_events","type":"User","site_admin":false},"repo":{"id":145172512,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNzI1MTI=","name":"opt_einsum","full_name":"fritzo/opt_einsum","owner":{"login":"fritzo","id":648532,"node_id":"MDQ6VXNlcjY0ODUzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/648532?v=4","gravatar_id":"","url":"https://api.github.com/users/fritzo","html_url":"https://github.com/fritzo","followers_url":"https://api.github.com/users/fritzo/followers","following_url":"https://api.github.com/users/fritzo/following{/other_user}","gists_url":"https://api.github.com/users/fritzo/gists{/gist_id}","starred_url":"https://api.github.com/users/fritzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fritzo/subscriptions","organizations_url":"https://api.github.com/users/fritzo/orgs","repos_url":"https://api.github.com/users/fritzo/repos","events_url":"https://api.github.com/users/fritzo/events{/privacy}","received_events_url":"https://api.github.com/users/fritzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fritzo/opt_einsum","description":"⚡️Optimizing numpy's einsum function with order optimization and GPU support.","fork":true,"url":"https://api.github.com/repos/fritzo/opt_einsum","forks_url":"https://api.github.com/repos/fritzo/opt_einsum/forks","keys_url":"https://api.github.com/repos/fritzo/opt_einsum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fritzo/opt_einsum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fritzo/opt_einsum/teams","hooks_url":"https://api.github.com/repos/fritzo/opt_einsum/hooks","issue_events_url":"https://api.github.com/repos/fritzo/opt_einsum/issues/events{/number}","events_url":"https://api.github.com/repos/fritzo/opt_einsum/events","assignees_url":"https://api.github.com/repos/fritzo/opt_einsum/assignees{/user}","branches_url":"https://api.github.com/repos/fritzo/opt_einsum/branches{/branch}","tags_url":"https://api.github.com/repos/fritzo/opt_einsum/tags","blobs_url":"https://api.github.com/repos/fritzo/opt_einsum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fritzo/opt_einsum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fritzo/opt_einsum/git/refs{/sha}","trees_url":"https://api.github.com/repos/fritzo/opt_einsum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fritzo/opt_einsum/statuses/{sha}","languages_url":"https://api.github.com/repos/fritzo/opt_einsum/languages","stargazers_url":"https://api.github.com/repos/fritzo/opt_einsum/stargazers","contributors_url":"https://api.github.com/repos/fritzo/opt_einsum/contributors","subscribers_url":"https://api.github.com/repos/fritzo/opt_einsum/subscribers","subscription_url":"https://api.github.com/repos/fritzo/opt_einsum/subscription","commits_url":"https://api.github.com/repos/fritzo/opt_einsum/commits{/sha}","git_commits_url":"https://api.github.com/repos/fritzo/opt_einsum/git/commits{/sha}","comments_url":"https://api.github.com/repos/fritzo/opt_einsum/comments{/number}","issue_comment_url":"https://api.github.com/repos/fritzo/opt_einsum/issues/comments{/number}","contents_url":"https://api.github.com/repos/fritzo/opt_einsum/contents/{+path}","compare_url":"https://api.github.com/repos/fritzo/opt_einsum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fritzo/opt_einsum/merges","archive_url":"https://api.github.com/repos/fritzo/opt_einsum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fritzo/opt_einsum/downloads","issues_url":"https://api.github.com/repos/fritzo/opt_einsum/issues{/number}","pulls_url":"https://api.github.com/repos/fritzo/opt_einsum/pulls{/number}","milestones_url":"https://api.github.com/repos/fritzo/opt_einsum/milestones{/number}","notifications_url":"https://api.github.com/repos/fritzo/opt_einsum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fritzo/opt_einsum/labels{/name}","releases_url":"https://api.github.com/repos/fritzo/opt_einsum/releases{/id}","deployments_url":"https://api.github.com/repos/fritzo/opt_einsum/deployments","created_at":"2018-08-17T22:43:52Z","updated_at":"2018-08-17T22:43:54Z","pushed_at":"2018-08-17T23:07:54Z","git_url":"git://github.com/fritzo/opt_einsum.git","ssh_url":"git@github.com:fritzo/opt_einsum.git","clone_url":"https://github.com/fritzo/opt_einsum.git","svn_url":"https://github.com/fritzo/opt_einsum","homepage":"http://optimized-einsum.readthedocs.io","size":522,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dgasmith:master","ref":"master","sha":"7ef12a570ce2ba4b02a08cbe94e8cae02dd343be","user":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"repo":{"id":27930623,"node_id":"MDEwOlJlcG9zaXRvcnkyNzkzMDYyMw==","name":"opt_einsum","full_name":"dgasmith/opt_einsum","owner":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgasmith/opt_einsum","description":"⚡️Optimizing numpy's einsum function with order optimization and GPU support.","fork":false,"url":"https://api.github.com/repos/dgasmith/opt_einsum","forks_url":"https://api.github.com/repos/dgasmith/opt_einsum/forks","keys_url":"https://api.github.com/repos/dgasmith/opt_einsum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgasmith/opt_einsum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgasmith/opt_einsum/teams","hooks_url":"https://api.github.com/repos/dgasmith/opt_einsum/hooks","issue_events_url":"https://api.github.com/repos/dgasmith/opt_einsum/issues/events{/number}","events_url":"https://api.github.com/repos/dgasmith/opt_einsum/events","assignees_url":"https://api.github.com/repos/dgasmith/opt_einsum/assignees{/user}","branches_url":"https://api.github.com/repos/dgasmith/opt_einsum/branches{/branch}","tags_url":"https://api.github.com/repos/dgasmith/opt_einsum/tags","blobs_url":"https://api.github.com/repos/dgasmith/opt_einsum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgasmith/opt_einsum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgasmith/opt_einsum/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgasmith/opt_einsum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgasmith/opt_einsum/statuses/{sha}","languages_url":"https://api.github.com/repos/dgasmith/opt_einsum/languages","stargazers_url":"https://api.github.com/repos/dgasmith/opt_einsum/stargazers","contributors_url":"https://api.github.com/repos/dgasmith/opt_einsum/contributors","subscribers_url":"https://api.github.com/repos/dgasmith/opt_einsum/subscribers","subscription_url":"https://api.github.com/repos/dgasmith/opt_einsum/subscription","commits_url":"https://api.github.com/repos/dgasmith/opt_einsum/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgasmith/opt_einsum/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgasmith/opt_einsum/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgasmith/opt_einsum/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgasmith/opt_einsum/contents/{+path}","compare_url":"https://api.github.com/repos/dgasmith/opt_einsum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgasmith/opt_einsum/merges","archive_url":"https://api.github.com/repos/dgasmith/opt_einsum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgasmith/opt_einsum/downloads","issues_url":"https://api.github.com/repos/dgasmith/opt_einsum/issues{/number}","pulls_url":"https://api.github.com/repos/dgasmith/opt_einsum/pulls{/number}","milestones_url":"https://api.github.com/repos/dgasmith/opt_einsum/milestones{/number}","notifications_url":"https://api.github.com/repos/dgasmith/opt_einsum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgasmith/opt_einsum/labels{/name}","releases_url":"https://api.github.com/repos/dgasmith/opt_einsum/releases{/id}","deployments_url":"https://api.github.com/repos/dgasmith/opt_einsum/deployments","created_at":"2014-12-12T17:31:24Z","updated_at":"2018-08-17T01:32:08Z","pushed_at":"2018-08-17T23:12:54Z","git_url":"git://github.com/dgasmith/opt_einsum.git","ssh_url":"git@github.com:dgasmith/opt_einsum.git","clone_url":"https://github.com/dgasmith/opt_einsum.git","svn_url":"https://github.com/dgasmith/opt_einsum","homepage":"http://optimized-einsum.readthedocs.io","size":519,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":4,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41"},"html":{"href":"https://github.com/dgasmith/opt_einsum/pull/41"},"issue":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/issues/41"},"comments":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/dgasmith/opt_einsum/statuses/a24dfe0580e90a2c0d0542724a66a546dd3da5e0"}},"author_association":"NONE"}}
{"actor":{"display_login":"fritzo"}}