{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/212934091","pull_request_review_id":149661445,"id":212934091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjkzNDA5MQ==","diff_hunk":"@@ -1,5 +1,11 @@\n-<ng-form name=\"$ctrl.form\">\n-  <div class=\"radio\" ng-class=\"{ 'has-error' : ($ctrl.validationTrigger && $ctrl.form.$invalid) || !$ctrl.valid }\" data-bh-currency-select>\n+<fieldset\n+  ng-form=\"CurrencySelectForm\"\n+  novalidate\n+  bh-currency-select>","path":"client/src/modules/templates/bhCurrencySelect.tmpl.html","position":null,"original_position":6,"commit_id":"f7c3f27c004b4581ca46487eedcac06c3718e5e4","original_commit_id":"e1d4778077facfee296cdc7a3005e046e43aabe4","user":{"login":"jmcameron","id":62145,"node_id":"MDQ6VXNlcjYyMTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/62145?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"body":"Ok, pushed a fix to this.  Lets see if it works!","created_at":"2018-08-27T10:37:48Z","updated_at":"2018-08-27T10:37:48Z","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/3075#discussion_r212934091","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/212934091"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/3075#discussion_r212934091"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075"}},"in_reply_to_id":212932164},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075","id":210510589,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTEwNTg5","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/3075","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/3075.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/3075.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/3075","number":3075,"state":"open","locked":false,"title":"Fixes to error handling for Cash and CashFlowByService reports","user":{"login":"jmcameron","id":62145,"node_id":"MDQ6VXNlcjYyMTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/62145?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"body":"Fixed error handling for cash-box selection and date interval input fields.   Updated cash_report and cashflowByService reports to use the improved error handling.\r\n\r\nNOTE:  \r\nAll uses of the **bh-date-interval** input field must insert\r\n        required=\"true\"'\r\nin the directive to get the error handling to properly handle missing From/To dates -- only do this if both the fields are both required.     By putting required=\"true\" in the directive, the missing field data check is done on the client side rather than the server side (which gives error messages that are not very helpful).    The checks on the server side are still there in server/controllers/finance/reports/cashReport/index.js and should be kept as a final check.\r\n\r\n-Jonathan C","created_at":"2018-08-23T16:46:31Z","updated_at":"2018-08-27T10:37:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f29cd8b9f0374f7c5858e9983a0c1d2f5dbbee84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/3075/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/f7c3f27c004b4581ca46487eedcac06c3718e5e4","head":{"label":"jmcameron:master","ref":"master","sha":"f7c3f27c004b4581ca46487eedcac06c3718e5e4","user":{"login":"jmcameron","id":62145,"node_id":"MDQ6VXNlcjYyMTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/62145?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"repo":{"id":131452535,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE0NTI1MzU=","name":"bhima-2.X","full_name":"jmcameron/bhima-2.X","owner":{"login":"jmcameron","id":62145,"node_id":"MDQ6VXNlcjYyMTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/62145?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcameron","html_url":"https://github.com/jmcameron","followers_url":"https://api.github.com/users/jmcameron/followers","following_url":"https://api.github.com/users/jmcameron/following{/other_user}","gists_url":"https://api.github.com/users/jmcameron/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcameron/subscriptions","organizations_url":"https://api.github.com/users/jmcameron/orgs","repos_url":"https://api.github.com/users/jmcameron/repos","events_url":"https://api.github.com/users/jmcameron/events{/privacy}","received_events_url":"https://api.github.com/users/jmcameron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmcameron/bhima-2.X","description":"A hospital information management application for rural Congolese hospitals","fork":true,"url":"https://api.github.com/repos/jmcameron/bhima-2.X","forks_url":"https://api.github.com/repos/jmcameron/bhima-2.X/forks","keys_url":"https://api.github.com/repos/jmcameron/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcameron/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcameron/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/jmcameron/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/jmcameron/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/jmcameron/bhima-2.X/events","assignees_url":"https://api.github.com/repos/jmcameron/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/jmcameron/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/jmcameron/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/jmcameron/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcameron/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcameron/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcameron/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcameron/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcameron/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/jmcameron/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/jmcameron/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/jmcameron/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/jmcameron/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/jmcameron/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcameron/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcameron/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcameron/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmcameron/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/jmcameron/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcameron/bhima-2.X/merges","archive_url":"https://api.github.com/repos/jmcameron/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcameron/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/jmcameron/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/jmcameron/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcameron/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcameron/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcameron/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/jmcameron/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/jmcameron/bhima-2.X/deployments","created_at":"2018-04-28T23:53:53Z","updated_at":"2018-08-27T10:37:21Z","pushed_at":"2018-08-27T10:37:19Z","git_url":"git://github.com/jmcameron/bhima-2.X.git","ssh_url":"git@github.com:jmcameron/bhima-2.X.git","clone_url":"https://github.com/jmcameron/bhima-2.X.git","svn_url":"https://github.com/jmcameron/bhima-2.X","homepage":"","size":15184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"c234a89cb5f62e88601da9e76c482037dbc79cc3","user":{"login":"IMA-WorldHealth","id":5330583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA1ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5330583?v=4","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA1MjY2OQ==","name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA1ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5330583?v=4","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A hospital information management application for rural Congolese hospitals","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2018-08-26T12:18:12Z","pushed_at":"2018-08-27T10:37:20Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":"","size":15271,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":49,"open_issues":266,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/3075"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/3075"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/3075/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/3075/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/f7c3f27c004b4581ca46487eedcac06c3718e5e4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jmcameron"}}