{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/iid-verify/pulls/comments/212640310","pull_request_review_id":149318686,"id":212640310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY0MDMxMA==","diff_hunk":"@@ -0,0 +1,29 @@\n+BENCH_ITER=10\n+\n+.PHONY: clangfmt\n+clangfmt:\n+\n+\n+.PHONY: memtests\n+memtests: src/verify.c src/tests.c\n+\tclang -g $? -o ./$@ -Wall -Wextra -Werror -lcrypto -lefence -DEXTRA_DEBUG -DBENCH_ITER=$(BENCH_ITER)\n+\tvalgrind --read-var-info=yes --track-origins=yes --leak-check=full ./$@","path":"Makefile","position":10,"original_position":10,"commit_id":"15bc823e475affe7c56d4bd987bb3dd161b4a1fc","original_commit_id":"15bc823e475affe7c56d4bd987bb3dd161b4a1fc","user":{"login":"jhford","id":607353,"node_id":"MDQ6VXNlcjYwNzM1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"body":"neat!  I'll look into those and see if they work with the code or at least get an idea of what's required.","created_at":"2018-08-24T14:09:17Z","updated_at":"2018-08-24T14:09:17Z","html_url":"https://github.com/taskcluster/iid-verify/pull/1#discussion_r212640310","pull_request_url":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/iid-verify/pulls/comments/212640310"},"html":{"href":"https://github.com/taskcluster/iid-verify/pull/1#discussion_r212640310"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1"}},"in_reply_to_id":206346636},"pull_request":{"url":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1","id":199005091,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDA1MDkx","html_url":"https://github.com/taskcluster/iid-verify/pull/1","diff_url":"https://github.com/taskcluster/iid-verify/pull/1.diff","patch_url":"https://github.com/taskcluster/iid-verify/pull/1.patch","issue_url":"https://api.github.com/repos/taskcluster/iid-verify/issues/1","number":1,"state":"open","locked":false,"title":"First version","user":{"login":"jhford","id":607353,"node_id":"MDQ6VXNlcjYwNzM1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"body":"This is a library which does verification of Amazon EC2 Instance Identity Documents.  We're taking this approach instead of using the openssl command line application because it's faster and more reliable.  Instead of having to create/delete temporary files for the openssl command line program to read, we're storing the documents in memory and passing those directly to the verification routines.\r\n\r\nThere are a few levels of tests:\r\n\r\n* C tests which verify that the `src/verify.c` and `src/verify.h` program are implemented correctly.\r\n  * written in `src/tests.c`\r\n  * run with and without electric fence and valgrind\r\n  * do not leak\r\n* Javascript tests which verify the higher level interface as well as the binding source `src/module.c`\r\n  * There's a set of tests which go through and flip each bit independently of the document and the cryptographic portions of the pubkey and pkcs7 file, one bit at a time.  This is to verify that even a single bit flip anywhere in the document will result in a failing validation\r\n* Bash tests which are just double checking that what is valid on the command line program is also valid in our program\r\n\r\nThese should run on linux, but it's possible they also run on Mac.  I don't know of any reasons off the top of my head why they wouldn't work on Windows, but compatibility there is not a concern.  Oh, and this is *way* faster than using the cli openssl, since there's no process creation or file i/o management overhead.\r\n\r\nThis is also my first N-API module and I'm not an expert in C, but I think I've done this right.","created_at":"2018-07-03T15:37:25Z","updated_at":"2018-08-24T14:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceb7167af1bd0a8924a3425bcb2259ffd9b4210f","assignee":{"login":"jhford","id":607353,"node_id":"MDQ6VXNlcjYwNzM1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhford","id":607353,"node_id":"MDQ6VXNlcjYwNzM1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1/commits","review_comments_url":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1/comments","review_comment_url":"https://api.github.com/repos/taskcluster/iid-verify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/iid-verify/issues/1/comments","statuses_url":"https://api.github.com/repos/taskcluster/iid-verify/statuses/15bc823e475affe7c56d4bd987bb3dd161b4a1fc","head":{"label":"taskcluster:first-version","ref":"first-version","sha":"15bc823e475affe7c56d4bd987bb3dd161b4a1fc","user":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":139603584,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MDM1ODQ=","name":"iid-verify","full_name":"taskcluster/iid-verify","owner":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/iid-verify","description":"Verify Amazon EC2 Instance Identity Documents","fork":false,"url":"https://api.github.com/repos/taskcluster/iid-verify","forks_url":"https://api.github.com/repos/taskcluster/iid-verify/forks","keys_url":"https://api.github.com/repos/taskcluster/iid-verify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/iid-verify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/iid-verify/teams","hooks_url":"https://api.github.com/repos/taskcluster/iid-verify/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/iid-verify/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/iid-verify/events","assignees_url":"https://api.github.com/repos/taskcluster/iid-verify/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/iid-verify/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/iid-verify/tags","blobs_url":"https://api.github.com/repos/taskcluster/iid-verify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/iid-verify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/iid-verify/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/iid-verify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/iid-verify/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/iid-verify/languages","stargazers_url":"https://api.github.com/repos/taskcluster/iid-verify/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/iid-verify/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/iid-verify/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/iid-verify/subscription","commits_url":"https://api.github.com/repos/taskcluster/iid-verify/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/iid-verify/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/iid-verify/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/iid-verify/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/iid-verify/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/iid-verify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/iid-verify/merges","archive_url":"https://api.github.com/repos/taskcluster/iid-verify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/iid-verify/downloads","issues_url":"https://api.github.com/repos/taskcluster/iid-verify/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/iid-verify/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/iid-verify/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/iid-verify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/iid-verify/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/iid-verify/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/iid-verify/deployments","created_at":"2018-07-03T15:29:31Z","updated_at":"2018-07-03T15:30:23Z","pushed_at":"2018-07-25T09:41:50Z","git_url":"git://github.com/taskcluster/iid-verify.git","ssh_url":"git@github.com:taskcluster/iid-verify.git","clone_url":"https://github.com/taskcluster/iid-verify.git","svn_url":"https://github.com/taskcluster/iid-verify","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"a4e780ef8020d8707c0807e3359d95d882d3e1fb","user":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":139603584,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MDM1ODQ=","name":"iid-verify","full_name":"taskcluster/iid-verify","owner":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/iid-verify","description":"Verify Amazon EC2 Instance Identity Documents","fork":false,"url":"https://api.github.com/repos/taskcluster/iid-verify","forks_url":"https://api.github.com/repos/taskcluster/iid-verify/forks","keys_url":"https://api.github.com/repos/taskcluster/iid-verify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/iid-verify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/iid-verify/teams","hooks_url":"https://api.github.com/repos/taskcluster/iid-verify/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/iid-verify/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/iid-verify/events","assignees_url":"https://api.github.com/repos/taskcluster/iid-verify/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/iid-verify/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/iid-verify/tags","blobs_url":"https://api.github.com/repos/taskcluster/iid-verify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/iid-verify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/iid-verify/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/iid-verify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/iid-verify/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/iid-verify/languages","stargazers_url":"https://api.github.com/repos/taskcluster/iid-verify/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/iid-verify/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/iid-verify/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/iid-verify/subscription","commits_url":"https://api.github.com/repos/taskcluster/iid-verify/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/iid-verify/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/iid-verify/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/iid-verify/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/iid-verify/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/iid-verify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/iid-verify/merges","archive_url":"https://api.github.com/repos/taskcluster/iid-verify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/iid-verify/downloads","issues_url":"https://api.github.com/repos/taskcluster/iid-verify/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/iid-verify/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/iid-verify/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/iid-verify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/iid-verify/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/iid-verify/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/iid-verify/deployments","created_at":"2018-07-03T15:29:31Z","updated_at":"2018-07-03T15:30:23Z","pushed_at":"2018-07-25T09:41:50Z","git_url":"git://github.com/taskcluster/iid-verify.git","ssh_url":"git@github.com:taskcluster/iid-verify.git","clone_url":"https://github.com/taskcluster/iid-verify.git","svn_url":"https://github.com/taskcluster/iid-verify","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1"},"html":{"href":"https://github.com/taskcluster/iid-verify/pull/1"},"issue":{"href":"https://api.github.com/repos/taskcluster/iid-verify/issues/1"},"comments":{"href":"https://api.github.com/repos/taskcluster/iid-verify/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/iid-verify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/iid-verify/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/iid-verify/statuses/15bc823e475affe7c56d4bd987bb3dd161b4a1fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhford"}}