{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/165346700","pull_request_review_id":93268976,"id":165346700,"diff_hunk":"@@ -0,0 +1,216 @@\n+/*\n+Copyright 2017 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package v1alpha1\n+\n+import (\n+\tmetav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+\t\"k8s.io/apimachinery/pkg/runtime\"\n+)\n+\n+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object\n+// +genclient:nonNamespaced\n+\n+// BulkRequest contains a single request to bulk api.\n+type BulkRequest struct {\n+\tmetav1.TypeMeta `json:\",inline\"`\n+\n+\t// Opaque identifier used to match requests and responses.\n+\t// +optional\n+\tRequestID string `json:\"requestId,omitempty\" protobuf:\"bytes,1,opt,name=requestId\"`\n+\n+\t// Starts new watch.\n+\t// +optional\n+\tWatch *WatchOperation `json:\"watch,omitempty\" protobuf:\"bytes,2,opt,name=watch\"`\n+\n+\t// Starts new watch.\n+\t// +optional\n+\tWatchList *WatchListOperation `json:\"watchList,omitempty\" protobuf:\"bytes,3,opt,name=watchList\"`\n+\n+\t// Stops existing watch.\n+\t// +optional\n+\tStopWatch *StopWatchOperation `json:\"stopWatch,omitempty\" protobuf:\"bytes,4,opt,name=stopWatch\"`\n+\n+\t// Gets list of items.\n+\t// +optional\n+\tList *ListOperation `json:\"list,omitempty\" protobuf:\"bytes,5,opt,name=list\"`","path":"staging/src/k8s.io/api/bulk/v1alpha1/types.go","position":48,"original_position":49,"commit_id":"d77cea8e330c78846177092c2ea5caa986b3e98a","original_commit_id":"7a191c32de244126fa28d5aa76bd088400314248","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"Yes - that makes more sense in this case.","created_at":"2018-02-01T12:52:05Z","updated_at":"2018-02-01T12:54:11Z","html_url":"https://github.com/kubernetes/kubernetes/pull/57792#discussion_r165346700","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/165346700"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/57792#discussion_r165346700"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792"}},"in_reply_to_id":161682508},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792","id":160907441,"html_url":"https://github.com/kubernetes/kubernetes/pull/57792","diff_url":"https://github.com/kubernetes/kubernetes/pull/57792.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/57792.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57792","number":57792,"state":"open","locked":false,"title":"Bulk watch API - experimental implementation","user":{"login":"anjensan","id":1098755,"avatar_url":"https://avatars0.githubusercontent.com/u/1098755?v=4","gravatar_id":"","url":"https://api.github.com/users/anjensan","html_url":"https://github.com/anjensan","followers_url":"https://api.github.com/users/anjensan/followers","following_url":"https://api.github.com/users/anjensan/following{/other_user}","gists_url":"https://api.github.com/users/anjensan/gists{/gist_id}","starred_url":"https://api.github.com/users/anjensan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjensan/subscriptions","organizations_url":"https://api.github.com/users/anjensan/orgs","repos_url":"https://api.github.com/users/anjensan/repos","events_url":"https://api.github.com/users/anjensan/events{/privacy}","received_events_url":"https://api.github.com/users/anjensan/received_events","type":"User","site_admin":false},"body":"Adds experimental/prototype implementation for Bulk Watch\r\nMore details can be found here https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/bulk_watch.md\r\n\r\nThis implementation does not include tests and differ with original proposal in several aspects.\r\n- Endpoint url is just '/bulk' for simplicity of initial implementation. Also this API is very special, so it might be wrong to put it directly into '/apis' group.\r\n- List/Get operations are also implemented.\r\n- Client can mix Watch/List/Get operations in the same ws connection.\r\n- POST-based version of endpoint is also implemented (POST to the same url /bulk). The only unsupported operation is 'StopWatch'.\r\n- Instead of ws-channels direct tagging with 'WatchID' is used (and single text-based channel). User should provide unique string during watch creation and all watch events will contain the same ID. Also this ID is used for unwatching.\r\n- Two separate request messages (Watch & WatchList) are used for subscription to single resource or list of resources. Single Watch can be optimized later (reuse the same underlying Watcher for all single-resource object).\r\n- Aggregator is supported. apiserver chaining should also work (with some limitations).\r\n- Bulk api is disabled by default (there is startup flag).\r\n\r\n\r\n","created_at":"2018-01-03T13:07:43Z","updated_at":"2018-02-01T12:54:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44fcbf08dfc16d8208dddee763bde8b0aeede0b5","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"assignees":[{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/57792/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d77cea8e330c78846177092c2ea5caa986b3e98a","head":{"label":"anjensan:bulk-watch","ref":"bulk-watch","sha":"d77cea8e330c78846177092c2ea5caa986b3e98a","user":{"login":"anjensan","id":1098755,"avatar_url":"https://avatars0.githubusercontent.com/u/1098755?v=4","gravatar_id":"","url":"https://api.github.com/users/anjensan","html_url":"https://github.com/anjensan","followers_url":"https://api.github.com/users/anjensan/followers","following_url":"https://api.github.com/users/anjensan/following{/other_user}","gists_url":"https://api.github.com/users/anjensan/gists{/gist_id}","starred_url":"https://api.github.com/users/anjensan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjensan/subscriptions","organizations_url":"https://api.github.com/users/anjensan/orgs","repos_url":"https://api.github.com/users/anjensan/repos","events_url":"https://api.github.com/users/anjensan/events{/privacy}","received_events_url":"https://api.github.com/users/anjensan/received_events","type":"User","site_admin":false},"repo":{"id":97463567,"name":"kubernetes","full_name":"anjensan/kubernetes","owner":{"login":"anjensan","id":1098755,"avatar_url":"https://avatars0.githubusercontent.com/u/1098755?v=4","gravatar_id":"","url":"https://api.github.com/users/anjensan","html_url":"https://github.com/anjensan","followers_url":"https://api.github.com/users/anjensan/followers","following_url":"https://api.github.com/users/anjensan/following{/other_user}","gists_url":"https://api.github.com/users/anjensan/gists{/gist_id}","starred_url":"https://api.github.com/users/anjensan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjensan/subscriptions","organizations_url":"https://api.github.com/users/anjensan/orgs","repos_url":"https://api.github.com/users/anjensan/repos","events_url":"https://api.github.com/users/anjensan/events{/privacy}","received_events_url":"https://api.github.com/users/anjensan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anjensan/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/anjensan/kubernetes","forks_url":"https://api.github.com/repos/anjensan/kubernetes/forks","keys_url":"https://api.github.com/repos/anjensan/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anjensan/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anjensan/kubernetes/teams","hooks_url":"https://api.github.com/repos/anjensan/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/anjensan/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/anjensan/kubernetes/events","assignees_url":"https://api.github.com/repos/anjensan/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/anjensan/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/anjensan/kubernetes/tags","blobs_url":"https://api.github.com/repos/anjensan/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anjensan/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anjensan/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/anjensan/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anjensan/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/anjensan/kubernetes/languages","stargazers_url":"https://api.github.com/repos/anjensan/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/anjensan/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/anjensan/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/anjensan/kubernetes/subscription","commits_url":"https://api.github.com/repos/anjensan/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/anjensan/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/anjensan/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/anjensan/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/anjensan/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/anjensan/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anjensan/kubernetes/merges","archive_url":"https://api.github.com/repos/anjensan/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anjensan/kubernetes/downloads","issues_url":"https://api.github.com/repos/anjensan/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/anjensan/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/anjensan/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/anjensan/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anjensan/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/anjensan/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/anjensan/kubernetes/deployments","created_at":"2017-07-17T10:19:01Z","updated_at":"2017-07-17T10:19:40Z","pushed_at":"2018-01-30T17:37:54Z","git_url":"git://github.com/anjensan/kubernetes.git","ssh_url":"git@github.com:anjensan/kubernetes.git","clone_url":"https://github.com/anjensan/kubernetes.git","svn_url":"https://github.com/anjensan/kubernetes","homepage":"http://kubernetes.io","size":525188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5f6e12793b48912e23206e555421e68054254669","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-01T12:33:28Z","pushed_at":"2018-02-01T12:51:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":749389,"stargazers_count":31986,"watchers_count":31986,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11325,"mirror_url":null,"archived":false,"open_issues_count":5315,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11325,"open_issues":5315,"watchers":31986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/57792"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/57792"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/57792/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/57792/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d77cea8e330c78846177092c2ea5caa986b3e98a"}},"author_association":"NONE"}}
{"actor":{"display_login":"wojtek-t"}}