{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/177637157","pull_request_review_id":107542896,"id":177637157,"diff_hunk":"@@ -280,12 +280,10 @@ mergeBatchInputs(ArrayRef<const Job *> jobs,\n   return false;\n }\n \n-/// Debugging only: return whether the set of \\p jobs is an ordered subsequence\n-/// of the sequence of top-level input files in the \\c Compilation \\p C.\n-static bool\n-jobsAreSubsequenceOfCompilationInputs(ArrayRef<const Job *> jobs,\n-                                      Compilation &C) {\n-  llvm::SmallVector<const Job *, 16> sortedJobs;\n+static void sortJobsToMatchCompilationInputs(ArrayRef<const Job *> jobs,\n+                                             llvm::SmallVectorImpl<const Job *> &sortedJobs,","path":"lib/Driver/ToolChain.cpp","position":11,"original_position":11,"commit_id":"ed6c599d077137582f023f219a8edda1328ee08b","original_commit_id":"ed6c599d077137582f023f219a8edda1328ee08b","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"body":"That's a nice function name. Is there a comment anywhere explaining *why* we want the order to match the inputs?","created_at":"2018-03-28T04:39:26Z","updated_at":"2018-03-28T04:39:26Z","html_url":"https://github.com/apple/swift/pull/15531#discussion_r177637157","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/15531","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/177637157"},"html":{"href":"https://github.com/apple/swift/pull/15531#discussion_r177637157"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/15531"}},"in_reply_to_id":177282149},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/15531","id":177608275,"html_url":"https://github.com/apple/swift/pull/15531","diff_url":"https://github.com/apple/swift/pull/15531.diff","patch_url":"https://github.com/apple/swift/pull/15531.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/15531","number":15531,"state":"open","locked":false,"title":"[BatchMode] Sort batch inputs rather than asserting; they are not always sorted.","user":{"login":"graydon","id":14097,"avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"body":"Some jobs sent to batch mode's helper function for batching are queued by out-of-order actions like flushed deferred jobs, or jobs discovered by traversing the dependency graph. These are not in an order that's a subsequence of the top-level compilation input sequence. Rather than asserting that they are, as we did before, we change to just forcibly sorting the jobs into the right order.","created_at":"2018-03-27T01:21:36Z","updated_at":"2018-03-28T04:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40fc183dcd7a6197f7589738e2f4006d7e107544","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/15531/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/15531/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/15531/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/ed6c599d077137582f023f219a8edda1328ee08b","head":{"label":"graydon:sort-jobs-dont-assert","ref":"sort-jobs-dont-assert","sha":"ed6c599d077137582f023f219a8edda1328ee08b","user":{"login":"graydon","id":14097,"avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"repo":{"id":66865548,"name":"swift","full_name":"graydon/swift","owner":{"login":"graydon","id":14097,"avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/graydon/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/graydon/swift","forks_url":"https://api.github.com/repos/graydon/swift/forks","keys_url":"https://api.github.com/repos/graydon/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graydon/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graydon/swift/teams","hooks_url":"https://api.github.com/repos/graydon/swift/hooks","issue_events_url":"https://api.github.com/repos/graydon/swift/issues/events{/number}","events_url":"https://api.github.com/repos/graydon/swift/events","assignees_url":"https://api.github.com/repos/graydon/swift/assignees{/user}","branches_url":"https://api.github.com/repos/graydon/swift/branches{/branch}","tags_url":"https://api.github.com/repos/graydon/swift/tags","blobs_url":"https://api.github.com/repos/graydon/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graydon/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graydon/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/graydon/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graydon/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/graydon/swift/languages","stargazers_url":"https://api.github.com/repos/graydon/swift/stargazers","contributors_url":"https://api.github.com/repos/graydon/swift/contributors","subscribers_url":"https://api.github.com/repos/graydon/swift/subscribers","subscription_url":"https://api.github.com/repos/graydon/swift/subscription","commits_url":"https://api.github.com/repos/graydon/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/graydon/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/graydon/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/graydon/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/graydon/swift/contents/{+path}","compare_url":"https://api.github.com/repos/graydon/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graydon/swift/merges","archive_url":"https://api.github.com/repos/graydon/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graydon/swift/downloads","issues_url":"https://api.github.com/repos/graydon/swift/issues{/number}","pulls_url":"https://api.github.com/repos/graydon/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/graydon/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/graydon/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graydon/swift/labels{/name}","releases_url":"https://api.github.com/repos/graydon/swift/releases{/id}","deployments_url":"https://api.github.com/repos/graydon/swift/deployments","created_at":"2016-08-29T17:37:10Z","updated_at":"2018-01-28T06:12:47Z","pushed_at":"2018-03-27T01:19:22Z","git_url":"git://github.com/graydon/swift.git","ssh_url":"git@github.com:graydon/swift.git","clone_url":"https://github.com/graydon/swift.git","svn_url":"https://github.com/graydon/swift","homepage":"https://swift.org/","size":267634,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"aa10174fb16345281ec41dcf7e055ffc0954800e","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-03-28T04:00:35Z","pushed_at":"2018-03-28T04:07:11Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":275358,"stargazers_count":43121,"watchers_count":43121,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6773,"mirror_url":null,"archived":false,"open_issues_count":301,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6773,"open_issues":301,"watchers":43121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/15531"},"html":{"href":"https://github.com/apple/swift/pull/15531"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/15531"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/15531/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/15531/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/15531/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/ed6c599d077137582f023f219a8edda1328ee08b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidungar"}}