{"action":"created","issue":{"url":"https://api.github.com/repos/brave/brave-browser/issues/2279","repository_url":"https://api.github.com/repos/brave/brave-browser","labels_url":"https://api.github.com/repos/brave/brave-browser/issues/2279/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-browser/issues/2279/comments","events_url":"https://api.github.com/repos/brave/brave-browser/issues/2279/events","html_url":"https://github.com/brave/brave-browser/pull/2279","id":385616698,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTQ0Mzc4","number":2279,"title":"add network audit whitelist entries for crlset PR","user":{"login":"diracdeltas","id":549654,"node_id":"MDQ6VXNlcjU0OTY1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-29T08:14:54Z","updated_at":"2018-11-29T18:12:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/brave/brave-browser/pulls/2279","html_url":"https://github.com/brave/brave-browser/pull/2279","diff_url":"https://github.com/brave/brave-browser/pull/2279.diff","patch_url":"https://github.com/brave/brave-browser/pull/2279.patch"},"body":"fix https://github.com/brave/brave-browser/issues/2271\r\n\r\ntest step: `npm run network-audit` should pass\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- Verified that these changes build without errors on\r\n  - [ ] Windows\r\n  - [x] macOS\r\n  - [ ] Linux\r\n- Verified that these changes pass automated tests (`npm test brave_unit_tests && npm test brave_browser_tests`) on\r\n  - [ ] Windows\r\n  - [ ] macOS\r\n  - [ ] Linux\r\n- [x] Ran `git rebase master` (if needed).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Requested a security/privacy review as needed.\r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions.\r\n"},"comment":{"url":"https://api.github.com/repos/brave/brave-browser/issues/comments/442936397","html_url":"https://github.com/brave/brave-browser/pull/2279#issuecomment-442936397","issue_url":"https://api.github.com/repos/brave/brave-browser/issues/2279","id":442936397,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjkzNjM5Nw==","user":{"login":"diracdeltas","id":549654,"node_id":"MDQ6VXNlcjU0OTY1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/549654?v=4","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T18:12:20Z","updated_at":"2018-11-29T18:12:20Z","author_association":"MEMBER","body":"yup i will open a follow up\n\nOn Thu, Nov 29, 2018 at 10:02 Brian R. Bondy <notifications@github.com>\nwrote:\n\n> *@bbondy* commented on this pull request.\n> ------------------------------\n>\n> In lib/whitelistedUrlPrefixes.js\n> <https://github.com/brave/brave-browser/pull/2279#discussion_r237596454>:\n>\n> > @@ -2,13 +2,19 @@\n>  module.exports = [\n>    'https://update.googleapis.com/service/update2', // allowed because it 307's to go-updater.brave.com. should never actually connect to googleapis.com.\n>    'https://safebrowsing.googleapis.com/v4/threatListUpdates', // allowed because it 307's to safebrowsing.brave.com\n> +  'http://redirector.gvt1.com/edgedl/release2/chrome_component/', // allowed because it 307's to crlset2.brave.com\n> +  'https://redirector.gvt1.com/edgedl/release2/chrome_component/', // allowed because it 307's to crlset2.brave.com\n> +  'http://dl.google.com/release2/chrome_component/', // allowed because it 307's to crlset1.brave.com\n> +  'https://dl.google.com/release2/chrome_component/', // allowed because it 307's to crlset1.brave.com\n>\n> Would it be possible to ensure these are actually 307s as a follow-up?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/brave/brave-browser/pull/2279#pullrequestreview-179935355>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAhjFlCPQs2nUy6Wo-kpsfNXqwzMIBTnks5u0CEugaJpZM4Y5Jk4>\n> .\n>\n"}}
{"actor":{"display_login":"diracdeltas"}}