{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70460","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70460/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70460/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70460/events","html_url":"https://github.com/kubernetes/kubernetes/issues/70460","id":375746403,"node_id":"MDU6SXNzdWUzNzU3NDY0MDM=","number":70460,"title":"Plugin watcher panics when ophaned plugin socket exists in plugin discovery directory","user":{"login":"davidz627","id":5459214,"node_id":"MDQ6VXNlcjU0NTkyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},"labels":[{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"assignees":[{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-10-31T00:11:44Z","updated_at":"2018-10-31T04:46:23Z","closed_at":null,"author_association":"COLLABORATOR","body":"The Kubelet panics in a loop when it tries to send a request on that channel. It should not panic.\r\n```\r\npanic: send on closed channel\r\nOct 30 22:54:13 e2e-test-dyzz-minion-group-6h4b kubelet[23947]: goroutine 1235 [running]:\r\nOct 30 22:54:13 e2e-test-dyzz-minion-group-6h4b kubelet[23947]: k8s.io/kubernetes/pkg/kubelet/util/pluginwatcher.(*Watcher).traversePluginDir.func1.1(0xc00051d380, 0xc001ce1200, 0x36)\r\nOct 30 22:54:13 e2e-test-dyzz-minion-group-6h4b kubelet[23947]:         /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubelet/util/pluginwatcher/plugin_watcher.go:191 +0x68\r\nOct 30 22:54:13 e2e-test-dyzz-minion-group-6h4b kubelet[23947]: created by k8s.io/kubernetes/pkg/kubelet/util/pluginwatcher.(*Watcher).traversePluginDir.func1\r\nOct 30 22:54:13 e2e-test-dyzz-minion-group-6h4b kubelet[23947]:         /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubelet/util/pluginwatcher/plugin_watcher.go:190 +0x1ad\r\n```\r\n\r\n**How to reproduce it (as minimally and precisely as possible)**:\r\n- create socket that is closed: `sudo mkfifo /var/lib/kubelet/plugins/fake-reg.sock` (fifo is not exactly the same as a standard registration socket but for purpose of repro I think it hits the same codepath)\r\n- Observe panic\r\n\r\n**Anything else we need to know?**:\r\nThis happens during usage of Kubernetes when some device tries to do registration but crashes and fails to clean up its sockets.\r\n\r\n/kind bug\r\n/sig node\r\n/cc @yujuhong "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/434559673","html_url":"https://github.com/kubernetes/kubernetes/issues/70460#issuecomment-434559673","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70460","id":434559673,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDU1OTY3Mw==","user":{"login":"vikaschoudhary16","id":11936386,"node_id":"MDQ6VXNlcjExOTM2Mzg2","avatar_url":"https://avatars3.githubusercontent.com/u/11936386?v=4","gravatar_id":"","url":"https://api.github.com/users/vikaschoudhary16","html_url":"https://github.com/vikaschoudhary16","followers_url":"https://api.github.com/users/vikaschoudhary16/followers","following_url":"https://api.github.com/users/vikaschoudhary16/following{/other_user}","gists_url":"https://api.github.com/users/vikaschoudhary16/gists{/gist_id}","starred_url":"https://api.github.com/users/vikaschoudhary16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikaschoudhary16/subscriptions","organizations_url":"https://api.github.com/users/vikaschoudhary16/orgs","repos_url":"https://api.github.com/users/vikaschoudhary16/repos","events_url":"https://api.github.com/users/vikaschoudhary16/events{/privacy}","received_events_url":"https://api.github.com/users/vikaschoudhary16/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T04:46:23Z","updated_at":"2018-10-31T04:46:23Z","author_association":"MEMBER","body":"taking a look, thanks!"}}
{"actor":{"display_login":"vikaschoudhary16"}}