{"action":"created","issue":{"url":"https://api.github.com/repos/bupa-digital/shades/issues/7","repository_url":"https://api.github.com/repos/bupa-digital/shades","labels_url":"https://api.github.com/repos/bupa-digital/shades/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/bupa-digital/shades/issues/7/comments","events_url":"https://api.github.com/repos/bupa-digital/shades/issues/7/events","html_url":"https://github.com/bupa-digital/shades/pull/7","id":317704720,"number":7,"title":"Some quick edits","user":{"login":"JoshRosenstein","id":32781407,"avatar_url":"https://avatars1.githubusercontent.com/u/32781407?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshRosenstein","html_url":"https://github.com/JoshRosenstein","followers_url":"https://api.github.com/users/JoshRosenstein/followers","following_url":"https://api.github.com/users/JoshRosenstein/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosenstein/subscriptions","organizations_url":"https://api.github.com/users/JoshRosenstein/orgs","repos_url":"https://api.github.com/users/JoshRosenstein/repos","events_url":"https://api.github.com/users/JoshRosenstein/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosenstein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-25T16:33:54Z","updated_at":"2018-05-23T01:15:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bupa-digital/shades/pulls/7","html_url":"https://github.com/bupa-digital/shades/pull/7","diff_url":"https://github.com/bupa-digital/shades/pull/7.diff","patch_url":"https://github.com/bupa-digital/shades/pull/7.patch"},"body":"1 Issue and 1 Feature.\r\nThe issue: when you refactored, you changed the pattern match reducer method to use R.pick, in order to not have to re-pick the value from the matchers. This causes the reduceWhileInvalid function to loop through the new object (intersectedMatchers) , which ends up executing style rules by names alphabetically, rather than order of the rules themselves. Before the refactor you used the intersection function, i first reverted to that, but then found out later it actually had the same issue if the props giving a different order array if props order changes. So i made a custom intersection function. And now the style result should not change if the props Order changes.\r\nHeres a custom Intersection Repl: https://goo.gl/6b3dWm\r\nparseRules Repl: https://goo.gl/7tEcJV\r\n\r\nThe Feature is self-explained, allows users to create matched rule functions that has props as an optional second argument. This allows more flexibility for other custom wrapper functions.\r\n"},"comment":{"url":"https://api.github.com/repos/bupa-digital/shades/issues/comments/391189454","html_url":"https://github.com/bupa-digital/shades/pull/7#issuecomment-391189454","issue_url":"https://api.github.com/repos/bupa-digital/shades/issues/7","id":391189454,"user":{"login":"MiracleBlue","id":23368,"avatar_url":"https://avatars2.githubusercontent.com/u/23368?v=4","gravatar_id":"","url":"https://api.github.com/users/MiracleBlue","html_url":"https://github.com/MiracleBlue","followers_url":"https://api.github.com/users/MiracleBlue/followers","following_url":"https://api.github.com/users/MiracleBlue/following{/other_user}","gists_url":"https://api.github.com/users/MiracleBlue/gists{/gist_id}","starred_url":"https://api.github.com/users/MiracleBlue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiracleBlue/subscriptions","organizations_url":"https://api.github.com/users/MiracleBlue/orgs","repos_url":"https://api.github.com/users/MiracleBlue/repos","events_url":"https://api.github.com/users/MiracleBlue/events{/privacy}","received_events_url":"https://api.github.com/users/MiracleBlue/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T01:15:54Z","updated_at":"2018-05-23T01:15:54Z","author_association":"MEMBER","body":"@JoshRosenstein Thanks heaps!  That means a lot!  Please let me know if the new syntax also solves the prop ordering issue you raised as well.  I'll be making the new release shortly, I've just finished writing the new documentation.  Here goes :)"}}
{"actor":{"display_login":"MiracleBlue"}}