{"action":"created","issue":{"url":"https://api.github.com/repos/eggjs/egg-core/issues/195","repository_url":"https://api.github.com/repos/eggjs/egg-core","labels_url":"https://api.github.com/repos/eggjs/egg-core/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/eggjs/egg-core/issues/195/comments","events_url":"https://api.github.com/repos/eggjs/egg-core/issues/195/events","html_url":"https://github.com/eggjs/egg-core/pull/195","id":396127088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDE2MzM3","number":195,"title":"Refactor: Add/remove some comments and move validation checks","user":{"login":"Maledong","id":40081831,"node_id":"MDQ6VXNlcjQwMDgxODMx","avatar_url":"https://avatars0.githubusercontent.com/u/40081831?v=4","gravatar_id":"","url":"https://api.github.com/users/Maledong","html_url":"https://github.com/Maledong","followers_url":"https://api.github.com/users/Maledong/followers","following_url":"https://api.github.com/users/Maledong/following{/other_user}","gists_url":"https://api.github.com/users/Maledong/gists{/gist_id}","starred_url":"https://api.github.com/users/Maledong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maledong/subscriptions","organizations_url":"https://api.github.com/users/Maledong/orgs","repos_url":"https://api.github.com/users/Maledong/repos","events_url":"https://api.github.com/users/Maledong/events{/privacy}","received_events_url":"https://api.github.com/users/Maledong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2019-01-05T03:02:38Z","updated_at":"2019-01-05T04:08:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/eggjs/egg-core/pulls/195","html_url":"https://github.com/eggjs/egg-core/pull/195","diff_url":"https://github.com/eggjs/egg-core/pull/195.diff","patch_url":"https://github.com/eggjs/egg-core/pull/195.patch"},"body":"**1) '.gitignore':**\r\nIgnore the 'package-lock.json', we don't need to submit it.\r\n\r\n**2) egg.js:**\r\n2.1) Remove '*' in the snippet of comments for '@example'.\r\n2.2) Move 'is.function' validation rule directly into egg.js from\r\nlifecycle.js, because we can do checks for the first time.\r\n\r\n**3) egg.test.js:**\r\nChange some error messages so as to show what's error clearly.\r\n\r\n---\r\n- [X] `npm test` passes\r\n- [ ] tests and/or benchmarks are included\r\n- [X] documentation is changed or added\r\n- [X] commit message follows commit guidelines"},"comment":{"url":"https://api.github.com/repos/eggjs/egg-core/issues/comments/451625840","html_url":"https://github.com/eggjs/egg-core/pull/195#issuecomment-451625840","issue_url":"https://api.github.com/repos/eggjs/egg-core/issues/195","id":451625840,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTYyNTg0MA==","user":{"login":"Maledong","id":40081831,"node_id":"MDQ6VXNlcjQwMDgxODMx","avatar_url":"https://avatars0.githubusercontent.com/u/40081831?v=4","gravatar_id":"","url":"https://api.github.com/users/Maledong","html_url":"https://github.com/Maledong","followers_url":"https://api.github.com/users/Maledong/followers","following_url":"https://api.github.com/users/Maledong/following{/other_user}","gists_url":"https://api.github.com/users/Maledong/gists{/gist_id}","starred_url":"https://api.github.com/users/Maledong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maledong/subscriptions","organizations_url":"https://api.github.com/users/Maledong/orgs","repos_url":"https://api.github.com/users/Maledong/repos","events_url":"https://api.github.com/users/Maledong/events{/privacy}","received_events_url":"https://api.github.com/users/Maledong/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T04:08:25Z","updated_at":"2019-01-05T04:08:25Z","author_association":"MEMBER","body":"I'll try to fix this pending in the unit test:\r\n![image](https://user-images.githubusercontent.com/40081831/50720156-992c9580-10e2-11e9-8ece-3d6df9ab784f.png)\r\n"}}
{"actor":{"display_login":"Maledong"}}