{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/coltonriedel/cracl/pulls/5","id":224352267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzUyMjY3","html_url":"https://github.com/coltonriedel/cracl/pull/5","diff_url":"https://github.com/coltonriedel/cracl/pull/5.diff","patch_url":"https://github.com/coltonriedel/cracl/pull/5.patch","issue_url":"https://api.github.com/repos/coltonriedel/cracl/issues/5","number":5,"state":"open","locked":false,"title":"Heap use after free bug fix","user":{"login":"coltonriedel","id":15242664,"node_id":"MDQ6VXNlcjE1MjQyNjY0","avatar_url":"https://avatars2.githubusercontent.com/u/15242664?v=4","gravatar_id":"","url":"https://api.github.com/users/coltonriedel","html_url":"https://github.com/coltonriedel","followers_url":"https://api.github.com/users/coltonriedel/followers","following_url":"https://api.github.com/users/coltonriedel/following{/other_user}","gists_url":"https://api.github.com/users/coltonriedel/gists{/gist_id}","starred_url":"https://api.github.com/users/coltonriedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltonriedel/subscriptions","organizations_url":"https://api.github.com/users/coltonriedel/orgs","repos_url":"https://api.github.com/users/coltonriedel/repos","events_url":"https://api.github.com/users/coltonriedel/events{/privacy}","received_events_url":"https://api.github.com/users/coltonriedel/received_events","type":"User","site_admin":false},"body":"Rewrite ublox buffer_messages function to add more robust parsing and also avoid the use of device::read(size_t). Use of read(size_t), or possibly the interleaving with read_byte, was causing the heap use after free bug. \r\n\r\nHeap use after free issue seems resolved, but new issue arises in that memory footprint grows without bound. It has probably always been an issue, but not noticed, and also previously much slower due to the bulk reads (as opposed to hundreds of more single byte reads). Possibly related to completion handlers in boost - need to investigate proper long term use of a boost io_service object. \r\n\r\nShould run fine, but grow to around 20GB in 24hours if not killed by the kernel first.","created_at":"2018-10-19T17:04:42Z","updated_at":"2018-10-19T17:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coltonriedel/cracl/pulls/5/commits","review_comments_url":"https://api.github.com/repos/coltonriedel/cracl/pulls/5/comments","review_comment_url":"https://api.github.com/repos/coltonriedel/cracl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coltonriedel/cracl/issues/5/comments","statuses_url":"https://api.github.com/repos/coltonriedel/cracl/statuses/fb4a5d60e03ecb1d4fd5af6e0050bcb0711c96cb","head":{"label":"coltonriedel:heap_free","ref":"heap_free","sha":"fb4a5d60e03ecb1d4fd5af6e0050bcb0711c96cb","user":{"login":"coltonriedel","id":15242664,"node_id":"MDQ6VXNlcjE1MjQyNjY0","avatar_url":"https://avatars2.githubusercontent.com/u/15242664?v=4","gravatar_id":"","url":"https://api.github.com/users/coltonriedel","html_url":"https://github.com/coltonriedel","followers_url":"https://api.github.com/users/coltonriedel/followers","following_url":"https://api.github.com/users/coltonriedel/following{/other_user}","gists_url":"https://api.github.com/users/coltonriedel/gists{/gist_id}","starred_url":"https://api.github.com/users/coltonriedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltonriedel/subscriptions","organizations_url":"https://api.github.com/users/coltonriedel/orgs","repos_url":"https://api.github.com/users/coltonriedel/repos","events_url":"https://api.github.com/users/coltonriedel/events{/privacy}","received_events_url":"https://api.github.com/users/coltonriedel/received_events","type":"User","site_admin":false},"repo":{"id":108030697,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwMzA2OTc=","name":"cracl","full_name":"coltonriedel/cracl","private":false,"owner":{"login":"coltonriedel","id":15242664,"node_id":"MDQ6VXNlcjE1MjQyNjY0","avatar_url":"https://avatars2.githubusercontent.com/u/15242664?v=4","gravatar_id":"","url":"https://api.github.com/users/coltonriedel","html_url":"https://github.com/coltonriedel","followers_url":"https://api.github.com/users/coltonriedel/followers","following_url":"https://api.github.com/users/coltonriedel/following{/other_user}","gists_url":"https://api.github.com/users/coltonriedel/gists{/gist_id}","starred_url":"https://api.github.com/users/coltonriedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltonriedel/subscriptions","organizations_url":"https://api.github.com/users/coltonriedel/orgs","repos_url":"https://api.github.com/users/coltonriedel/repos","events_url":"https://api.github.com/users/coltonriedel/events{/privacy}","received_events_url":"https://api.github.com/users/coltonriedel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coltonriedel/cracl","description":"Common Receiver And Clock Library","fork":false,"url":"https://api.github.com/repos/coltonriedel/cracl","forks_url":"https://api.github.com/repos/coltonriedel/cracl/forks","keys_url":"https://api.github.com/repos/coltonriedel/cracl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coltonriedel/cracl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coltonriedel/cracl/teams","hooks_url":"https://api.github.com/repos/coltonriedel/cracl/hooks","issue_events_url":"https://api.github.com/repos/coltonriedel/cracl/issues/events{/number}","events_url":"https://api.github.com/repos/coltonriedel/cracl/events","assignees_url":"https://api.github.com/repos/coltonriedel/cracl/assignees{/user}","branches_url":"https://api.github.com/repos/coltonriedel/cracl/branches{/branch}","tags_url":"https://api.github.com/repos/coltonriedel/cracl/tags","blobs_url":"https://api.github.com/repos/coltonriedel/cracl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coltonriedel/cracl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coltonriedel/cracl/git/refs{/sha}","trees_url":"https://api.github.com/repos/coltonriedel/cracl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coltonriedel/cracl/statuses/{sha}","languages_url":"https://api.github.com/repos/coltonriedel/cracl/languages","stargazers_url":"https://api.github.com/repos/coltonriedel/cracl/stargazers","contributors_url":"https://api.github.com/repos/coltonriedel/cracl/contributors","subscribers_url":"https://api.github.com/repos/coltonriedel/cracl/subscribers","subscription_url":"https://api.github.com/repos/coltonriedel/cracl/subscription","commits_url":"https://api.github.com/repos/coltonriedel/cracl/commits{/sha}","git_commits_url":"https://api.github.com/repos/coltonriedel/cracl/git/commits{/sha}","comments_url":"https://api.github.com/repos/coltonriedel/cracl/comments{/number}","issue_comment_url":"https://api.github.com/repos/coltonriedel/cracl/issues/comments{/number}","contents_url":"https://api.github.com/repos/coltonriedel/cracl/contents/{+path}","compare_url":"https://api.github.com/repos/coltonriedel/cracl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coltonriedel/cracl/merges","archive_url":"https://api.github.com/repos/coltonriedel/cracl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coltonriedel/cracl/downloads","issues_url":"https://api.github.com/repos/coltonriedel/cracl/issues{/number}","pulls_url":"https://api.github.com/repos/coltonriedel/cracl/pulls{/number}","milestones_url":"https://api.github.com/repos/coltonriedel/cracl/milestones{/number}","notifications_url":"https://api.github.com/repos/coltonriedel/cracl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coltonriedel/cracl/labels{/name}","releases_url":"https://api.github.com/repos/coltonriedel/cracl/releases{/id}","deployments_url":"https://api.github.com/repos/coltonriedel/cracl/deployments","created_at":"2017-10-23T19:40:46Z","updated_at":"2018-09-22T17:00:29Z","pushed_at":"2018-10-19T16:53:37Z","git_url":"git://github.com/coltonriedel/cracl.git","ssh_url":"git@github.com:coltonriedel/cracl.git","clone_url":"https://github.com/coltonriedel/cracl.git","svn_url":"https://github.com/coltonriedel/cracl","homepage":"","size":69,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"coltonriedel:master","ref":"master","sha":"ac70cf11ae8c201c7d607d63b89cbb8ab659021e","user":{"login":"coltonriedel","id":15242664,"node_id":"MDQ6VXNlcjE1MjQyNjY0","avatar_url":"https://avatars2.githubusercontent.com/u/15242664?v=4","gravatar_id":"","url":"https://api.github.com/users/coltonriedel","html_url":"https://github.com/coltonriedel","followers_url":"https://api.github.com/users/coltonriedel/followers","following_url":"https://api.github.com/users/coltonriedel/following{/other_user}","gists_url":"https://api.github.com/users/coltonriedel/gists{/gist_id}","starred_url":"https://api.github.com/users/coltonriedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltonriedel/subscriptions","organizations_url":"https://api.github.com/users/coltonriedel/orgs","repos_url":"https://api.github.com/users/coltonriedel/repos","events_url":"https://api.github.com/users/coltonriedel/events{/privacy}","received_events_url":"https://api.github.com/users/coltonriedel/received_events","type":"User","site_admin":false},"repo":{"id":108030697,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwMzA2OTc=","name":"cracl","full_name":"coltonriedel/cracl","private":false,"owner":{"login":"coltonriedel","id":15242664,"node_id":"MDQ6VXNlcjE1MjQyNjY0","avatar_url":"https://avatars2.githubusercontent.com/u/15242664?v=4","gravatar_id":"","url":"https://api.github.com/users/coltonriedel","html_url":"https://github.com/coltonriedel","followers_url":"https://api.github.com/users/coltonriedel/followers","following_url":"https://api.github.com/users/coltonriedel/following{/other_user}","gists_url":"https://api.github.com/users/coltonriedel/gists{/gist_id}","starred_url":"https://api.github.com/users/coltonriedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coltonriedel/subscriptions","organizations_url":"https://api.github.com/users/coltonriedel/orgs","repos_url":"https://api.github.com/users/coltonriedel/repos","events_url":"https://api.github.com/users/coltonriedel/events{/privacy}","received_events_url":"https://api.github.com/users/coltonriedel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coltonriedel/cracl","description":"Common Receiver And Clock Library","fork":false,"url":"https://api.github.com/repos/coltonriedel/cracl","forks_url":"https://api.github.com/repos/coltonriedel/cracl/forks","keys_url":"https://api.github.com/repos/coltonriedel/cracl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coltonriedel/cracl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coltonriedel/cracl/teams","hooks_url":"https://api.github.com/repos/coltonriedel/cracl/hooks","issue_events_url":"https://api.github.com/repos/coltonriedel/cracl/issues/events{/number}","events_url":"https://api.github.com/repos/coltonriedel/cracl/events","assignees_url":"https://api.github.com/repos/coltonriedel/cracl/assignees{/user}","branches_url":"https://api.github.com/repos/coltonriedel/cracl/branches{/branch}","tags_url":"https://api.github.com/repos/coltonriedel/cracl/tags","blobs_url":"https://api.github.com/repos/coltonriedel/cracl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coltonriedel/cracl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coltonriedel/cracl/git/refs{/sha}","trees_url":"https://api.github.com/repos/coltonriedel/cracl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coltonriedel/cracl/statuses/{sha}","languages_url":"https://api.github.com/repos/coltonriedel/cracl/languages","stargazers_url":"https://api.github.com/repos/coltonriedel/cracl/stargazers","contributors_url":"https://api.github.com/repos/coltonriedel/cracl/contributors","subscribers_url":"https://api.github.com/repos/coltonriedel/cracl/subscribers","subscription_url":"https://api.github.com/repos/coltonriedel/cracl/subscription","commits_url":"https://api.github.com/repos/coltonriedel/cracl/commits{/sha}","git_commits_url":"https://api.github.com/repos/coltonriedel/cracl/git/commits{/sha}","comments_url":"https://api.github.com/repos/coltonriedel/cracl/comments{/number}","issue_comment_url":"https://api.github.com/repos/coltonriedel/cracl/issues/comments{/number}","contents_url":"https://api.github.com/repos/coltonriedel/cracl/contents/{+path}","compare_url":"https://api.github.com/repos/coltonriedel/cracl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coltonriedel/cracl/merges","archive_url":"https://api.github.com/repos/coltonriedel/cracl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coltonriedel/cracl/downloads","issues_url":"https://api.github.com/repos/coltonriedel/cracl/issues{/number}","pulls_url":"https://api.github.com/repos/coltonriedel/cracl/pulls{/number}","milestones_url":"https://api.github.com/repos/coltonriedel/cracl/milestones{/number}","notifications_url":"https://api.github.com/repos/coltonriedel/cracl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coltonriedel/cracl/labels{/name}","releases_url":"https://api.github.com/repos/coltonriedel/cracl/releases{/id}","deployments_url":"https://api.github.com/repos/coltonriedel/cracl/deployments","created_at":"2017-10-23T19:40:46Z","updated_at":"2018-09-22T17:00:29Z","pushed_at":"2018-10-19T16:53:37Z","git_url":"git://github.com/coltonriedel/cracl.git","ssh_url":"git@github.com:coltonriedel/cracl.git","clone_url":"https://github.com/coltonriedel/cracl.git","svn_url":"https://github.com/coltonriedel/cracl","homepage":"","size":69,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coltonriedel/cracl/pulls/5"},"html":{"href":"https://github.com/coltonriedel/cracl/pull/5"},"issue":{"href":"https://api.github.com/repos/coltonriedel/cracl/issues/5"},"comments":{"href":"https://api.github.com/repos/coltonriedel/cracl/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/coltonriedel/cracl/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/coltonriedel/cracl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coltonriedel/cracl/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/coltonriedel/cracl/statuses/fb4a5d60e03ecb1d4fd5af6e0050bcb0711c96cb"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":110,"deletions":73,"changed_files":4}}
{"actor":{"display_login":"coltonriedel"}}