{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/204083759","pull_request_review_id":139106479,"id":204083759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA4Mzc1OQ==","diff_hunk":"@@ -22,6 +22,8 @@\n \n extern git_mutex git__mwindow_mutex;\n \n+size_t git_indexer__max_objects = (size_t)-1;","path":"src/indexer.c","position":4,"original_position":4,"commit_id":"b3ca817e2822610292efe8ac5e8950931855dd7a","original_commit_id":"b3ca817e2822610292efe8ac5e8950931855dd7a","user":{"login":"ethomson","id":1130014,"node_id":"MDQ6VXNlcjExMzAwMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1130014?v=4","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"body":"Got it, thanks.","created_at":"2018-07-20T15:32:44Z","updated_at":"2018-07-20T15:32:44Z","html_url":"https://github.com/libgit2/libgit2/pull/4721#discussion_r204083759","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4721","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/204083759"},"html":{"href":"https://github.com/libgit2/libgit2/pull/4721#discussion_r204083759"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4721"}},"in_reply_to_id":204024881},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/4721","id":200721930,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzIxOTMw","html_url":"https://github.com/libgit2/libgit2/pull/4721","diff_url":"https://github.com/libgit2/libgit2/pull/4721.diff","patch_url":"https://github.com/libgit2/libgit2/pull/4721.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/4721","number":4721,"state":"open","locked":false,"title":"Add a configurable limit to the max pack size that will be indexed","user":{"login":"nelhage","id":16725,"node_id":"MDQ6VXNlcjE2NzI1","avatar_url":"https://avatars3.githubusercontent.com/u/16725?v=4","gravatar_id":"","url":"https://api.github.com/users/nelhage","html_url":"https://github.com/nelhage","followers_url":"https://api.github.com/users/nelhage/followers","following_url":"https://api.github.com/users/nelhage/following{/other_user}","gists_url":"https://api.github.com/users/nelhage/gists{/gist_id}","starred_url":"https://api.github.com/users/nelhage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelhage/subscriptions","organizations_url":"https://api.github.com/users/nelhage/orgs","repos_url":"https://api.github.com/users/nelhage/repos","events_url":"https://api.github.com/users/nelhage/events{/privacy}","received_events_url":"https://api.github.com/users/nelhage/received_events","type":"User","site_admin":false},"body":"This is needed in order for https://github.com/google/oss-fuzz/pull/1604 to not [immediately OOM](https://github.com/google/oss-fuzz/pull/1604#issuecomment-403991802) with a ~32GB allocation.\r\n\r\nThe existing code enforces a hard limit of 2³² objects, which may be acceptable as a general default, but is too large for the fuzzer's memory limits.\r\n\r\nI'm very open to other approaches (should there be a configurable limit that the fuzzer configures?) but I'm throwing up a PR with the simplest fix I could find in order to start a discussion.","created_at":"2018-07-11T14:34:22Z","updated_at":"2018-07-20T15:32:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94b25e0668c357af85c253c3f61ca9736bbc78c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4721/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4721/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/4721/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/b3ca817e2822610292efe8ac5e8950931855dd7a","head":{"label":"nelhage:max-objects","ref":"max-objects","sha":"b3ca817e2822610292efe8ac5e8950931855dd7a","user":{"login":"nelhage","id":16725,"node_id":"MDQ6VXNlcjE2NzI1","avatar_url":"https://avatars3.githubusercontent.com/u/16725?v=4","gravatar_id":"","url":"https://api.github.com/users/nelhage","html_url":"https://github.com/nelhage","followers_url":"https://api.github.com/users/nelhage/followers","following_url":"https://api.github.com/users/nelhage/following{/other_user}","gists_url":"https://api.github.com/users/nelhage/gists{/gist_id}","starred_url":"https://api.github.com/users/nelhage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelhage/subscriptions","organizations_url":"https://api.github.com/users/nelhage/orgs","repos_url":"https://api.github.com/users/nelhage/repos","events_url":"https://api.github.com/users/nelhage/events{/privacy}","received_events_url":"https://api.github.com/users/nelhage/received_events","type":"User","site_admin":false},"repo":{"id":2753900,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUzOTAw","name":"libgit2","full_name":"nelhage/libgit2","owner":{"login":"nelhage","id":16725,"node_id":"MDQ6VXNlcjE2NzI1","avatar_url":"https://avatars3.githubusercontent.com/u/16725?v=4","gravatar_id":"","url":"https://api.github.com/users/nelhage","html_url":"https://github.com/nelhage","followers_url":"https://api.github.com/users/nelhage/followers","following_url":"https://api.github.com/users/nelhage/following{/other_user}","gists_url":"https://api.github.com/users/nelhage/gists{/gist_id}","starred_url":"https://api.github.com/users/nelhage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelhage/subscriptions","organizations_url":"https://api.github.com/users/nelhage/orgs","repos_url":"https://api.github.com/users/nelhage/repos","events_url":"https://api.github.com/users/nelhage/events{/privacy}","received_events_url":"https://api.github.com/users/nelhage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nelhage/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/nelhage/libgit2","forks_url":"https://api.github.com/repos/nelhage/libgit2/forks","keys_url":"https://api.github.com/repos/nelhage/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelhage/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelhage/libgit2/teams","hooks_url":"https://api.github.com/repos/nelhage/libgit2/hooks","issue_events_url":"https://api.github.com/repos/nelhage/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/nelhage/libgit2/events","assignees_url":"https://api.github.com/repos/nelhage/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/nelhage/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/nelhage/libgit2/tags","blobs_url":"https://api.github.com/repos/nelhage/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelhage/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelhage/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelhage/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelhage/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/nelhage/libgit2/languages","stargazers_url":"https://api.github.com/repos/nelhage/libgit2/stargazers","contributors_url":"https://api.github.com/repos/nelhage/libgit2/contributors","subscribers_url":"https://api.github.com/repos/nelhage/libgit2/subscribers","subscription_url":"https://api.github.com/repos/nelhage/libgit2/subscription","commits_url":"https://api.github.com/repos/nelhage/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelhage/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelhage/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelhage/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelhage/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/nelhage/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelhage/libgit2/merges","archive_url":"https://api.github.com/repos/nelhage/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelhage/libgit2/downloads","issues_url":"https://api.github.com/repos/nelhage/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/nelhage/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/nelhage/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/nelhage/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelhage/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/nelhage/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/nelhage/libgit2/deployments","created_at":"2011-11-11T04:53:51Z","updated_at":"2018-06-24T20:41:38Z","pushed_at":"2018-07-19T14:24:18Z","git_url":"git://github.com/nelhage/libgit2.git","ssh_url":"git@github.com:nelhage/libgit2.git","clone_url":"https://github.com/nelhage/libgit2.git","svn_url":"https://github.com/nelhage/libgit2","homepage":"http://libgit2.github.com","size":24538,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"development"}},"base":{"label":"libgit2:master","ref":"master","sha":"6dfc8bc2499db78eae4e29dd121c75121f0e8baf","user":{"login":"libgit2","id":394745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE2NjI=","name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"A cross-platform, linkable library implementation of Git that you can use in your application.","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2018-07-20T11:07:09Z","pushed_at":"2018-07-20T15:27:49Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"https://libgit2.org/","size":38734,"stargazers_count":6550,"watchers_count":6550,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1663,"mirror_url":null,"archived":false,"open_issues_count":264,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1663,"open_issues":264,"watchers":6550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4721"},"html":{"href":"https://github.com/libgit2/libgit2/pull/4721"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4721"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4721/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4721/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4721/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/b3ca817e2822610292efe8ac5e8950931855dd7a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ethomson"}}