{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/206013539","pull_request_review_id":141390563,"id":206013539,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjAxMzUzOQ==","diff_hunk":"@@ -534,6 +583,85 @@ impl fmt::Debug for Lease {\n     }\n }\n \n+/// A remote lease, it can only be derived by `Lease`. It will be sent\n+/// to the local read thread, so name it remote. If Lease expires, the remote must\n+/// expire too.\n+#[derive(Debug)]\n+pub struct RemoteLease {","path":"src/raftstore/store/util.rs","position":109,"original_position":109,"commit_id":"61def7a1d1f577c83ab2d9857a9e38a8e2c66ec7","original_commit_id":"61def7a1d1f577c83ab2d9857a9e38a8e2c66ec7","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"There is only one function needs to clone `RemoteLease`, and I dont it clonable. ","created_at":"2018-07-30T04:40:38Z","updated_at":"2018-07-30T04:40:38Z","html_url":"https://github.com/pingcap/tikv/pull/2639#discussion_r206013539","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/2639","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/206013539"},"html":{"href":"https://github.com/pingcap/tikv/pull/2639#discussion_r206013539"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2639"}},"in_reply_to_id":205828017},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/2639","id":160863751,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYwODYzNzUx","html_url":"https://github.com/pingcap/tikv/pull/2639","diff_url":"https://github.com/pingcap/tikv/pull/2639.diff","patch_url":"https://github.com/pingcap/tikv/pull/2639.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/2639","number":2639,"state":"open","locked":false,"title":"Handle read requests in the local read thread","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"This is the final PR for the local read thread. It adds a router, the thread, and others. \r\n \r\nClose #2518 ","created_at":"2018-01-03T08:15:23Z","updated_at":"2018-07-30T04:40:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f807539f859f30810c4de2e9e9b5bde11fce060c","assignee":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"assignees":[{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/pingcap/tikv/milestones/9","html_url":"https://github.com/pingcap/tikv/milestone/9","labels_url":"https://api.github.com/repos/pingcap/tikv/milestones/9/labels","id":3006472,"node_id":"MDk6TWlsZXN0b25lMzAwNjQ3Mg==","number":9,"title":"2018 Q1","description":"Guarantee stability and get the performance limitation.","creator":{"login":"siddontang","id":1080370,"node_id":"MDQ6VXNlcjEwODAzNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1080370?v=4","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":18,"state":"open","created_at":"2018-01-02T07:50:17Z","updated_at":"2018-04-25T02:00:47Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/2639/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/2639/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/2639/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/61def7a1d1f577c83ab2d9857a9e38a8e2c66ec7","head":{"label":"overvenus:reader","ref":"reader","sha":"61def7a1d1f577c83ab2d9857a9e38a8e2c66ec7","user":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"repo":{"id":58031891,"node_id":"MDEwOlJlcG9zaXRvcnk1ODAzMTg5MQ==","name":"tikv","full_name":"overvenus/tikv","owner":{"login":"overvenus","id":2150711,"node_id":"MDQ6VXNlcjIxNTA3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2150711?v=4","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/overvenus/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/overvenus/tikv","forks_url":"https://api.github.com/repos/overvenus/tikv/forks","keys_url":"https://api.github.com/repos/overvenus/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overvenus/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overvenus/tikv/teams","hooks_url":"https://api.github.com/repos/overvenus/tikv/hooks","issue_events_url":"https://api.github.com/repos/overvenus/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/overvenus/tikv/events","assignees_url":"https://api.github.com/repos/overvenus/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/overvenus/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/overvenus/tikv/tags","blobs_url":"https://api.github.com/repos/overvenus/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overvenus/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overvenus/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/overvenus/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overvenus/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/overvenus/tikv/languages","stargazers_url":"https://api.github.com/repos/overvenus/tikv/stargazers","contributors_url":"https://api.github.com/repos/overvenus/tikv/contributors","subscribers_url":"https://api.github.com/repos/overvenus/tikv/subscribers","subscription_url":"https://api.github.com/repos/overvenus/tikv/subscription","commits_url":"https://api.github.com/repos/overvenus/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/overvenus/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/overvenus/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/overvenus/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/overvenus/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/overvenus/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overvenus/tikv/merges","archive_url":"https://api.github.com/repos/overvenus/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overvenus/tikv/downloads","issues_url":"https://api.github.com/repos/overvenus/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/overvenus/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/overvenus/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/overvenus/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overvenus/tikv/labels{/name}","releases_url":"https://api.github.com/repos/overvenus/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/overvenus/tikv/deployments","created_at":"2016-05-04T07:29:33Z","updated_at":"2018-07-22T14:06:45Z","pushed_at":"2018-07-30T03:19:13Z","git_url":"git://github.com/overvenus/tikv.git","ssh_url":"git@github.com:overvenus/tikv.git","clone_url":"https://github.com/overvenus/tikv.git","svn_url":"https://github.com/overvenus/tikv","homepage":"","size":14290,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"483f929d11f009f23d6d2e210af085739a13ffa3","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"node_id":"MDEwOlJlcG9zaXRvcnk0ODgzMzkxMA==","name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-07-30T01:41:41Z","pushed_at":"2018-07-30T04:30:03Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":14492,"stargazers_count":3417,"watchers_count":3417,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":443,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":443,"open_issues":228,"watchers":3417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2639"},"html":{"href":"https://github.com/pingcap/tikv/pull/2639"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/2639"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/2639/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2639/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2639/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/61def7a1d1f577c83ab2d9857a9e38a8e2c66ec7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"overvenus"}}