{"action":"created","issue":{"url":"https://api.github.com/repos/labgrid-project/labgrid/issues/284","repository_url":"https://api.github.com/repos/labgrid-project/labgrid","labels_url":"https://api.github.com/repos/labgrid-project/labgrid/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/labgrid-project/labgrid/issues/284/comments","events_url":"https://api.github.com/repos/labgrid-project/labgrid/issues/284/events","html_url":"https://github.com/labgrid-project/labgrid/pull/284","id":338540243,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDQ0MDY2","number":284,"title":"docker: Fixes #260. Integrate separate docker repo into labgrid repo","user":{"login":"krevsbech","id":15629886,"node_id":"MDQ6VXNlcjE1NjI5ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/15629886?v=4","gravatar_id":"","url":"https://api.github.com/users/krevsbech","html_url":"https://github.com/krevsbech","followers_url":"https://api.github.com/users/krevsbech/followers","following_url":"https://api.github.com/users/krevsbech/following{/other_user}","gists_url":"https://api.github.com/users/krevsbech/gists{/gist_id}","starred_url":"https://api.github.com/users/krevsbech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krevsbech/subscriptions","organizations_url":"https://api.github.com/users/krevsbech/orgs","repos_url":"https://api.github.com/users/krevsbech/repos","events_url":"https://api.github.com/users/krevsbech/events{/privacy}","received_events_url":"https://api.github.com/users/krevsbech/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-05T11:45:51Z","updated_at":"2018-09-13T07:13:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/labgrid-project/labgrid/pulls/284","html_url":"https://github.com/labgrid-project/labgrid/pull/284","diff_url":"https://github.com/labgrid-project/labgrid/pull/284.diff","patch_url":"https://github.com/labgrid-project/labgrid/pull/284.patch"},"body":"As proposed in issue #260 integrate the docker images into the project.\r\nThis enable regression testing of the python setup files as docker hub can\r\nbe configured to automatically build upon commit in the Labgrid repo.\r\n\r\nSigned-off-by: Kasper Revsbech <krev@triax.com>"},"comment":{"url":"https://api.github.com/repos/labgrid-project/labgrid/issues/comments/420907444","html_url":"https://github.com/labgrid-project/labgrid/pull/284#issuecomment-420907444","issue_url":"https://api.github.com/repos/labgrid-project/labgrid/issues/284","id":420907444,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDkwNzQ0NA==","user":{"login":"krevsbech","id":15629886,"node_id":"MDQ6VXNlcjE1NjI5ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/15629886?v=4","gravatar_id":"","url":"https://api.github.com/users/krevsbech","html_url":"https://github.com/krevsbech","followers_url":"https://api.github.com/users/krevsbech/followers","following_url":"https://api.github.com/users/krevsbech/following{/other_user}","gists_url":"https://api.github.com/users/krevsbech/gists{/gist_id}","starred_url":"https://api.github.com/users/krevsbech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krevsbech/subscriptions","organizations_url":"https://api.github.com/users/krevsbech/orgs","repos_url":"https://api.github.com/users/krevsbech/repos","events_url":"https://api.github.com/users/krevsbech/events{/privacy}","received_events_url":"https://api.github.com/users/krevsbech/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T07:13:02Z","updated_at":"2018-09-13T07:13:02Z","author_association":"NONE","body":"> Having the Dokerfile in the labgrid repository makes it much simpler to fork the whole toolchain of modifying labgrid and have a Docker image built automatically.\r\n> \r\n> Having Dockerfile in repository also makes it much more likely that a Docker image can be built with an old version. When (not if) changes are made to labgrid that requires changes to Dockerfile, it is crucial to have them in same repository.\r\n> \r\n> Finally, having Dockerfile in labgrid projects will allow future work of using that as an integrated part of labgrid CI, so that changes that break Docker images are caught before they are merged.\r\n> \r\n> Keeping Dockerfile out of main repo just not gain you anything positive, other than giving different people merge power over different parts of the project (which is IMHO not entirely a good thing). Keep in mind that anybody will able to change labgrid, including the Dockerfile. Just fork it and do whatever you like. It is open source after all :)\r\n\r\nFor me the main motivation is the one that breaking changes will be found pre pr, and that we can even define that a successful docker build is a part of your PR checks. Then as @esben  mention there is a description of how to \"run\" the framework that is versioned along the framework. \r\n\r\nRegarding the maintenance your are right that I don't have a commit bit in the main repository and should not have one. But as a all PR's are public I can still review and so can other people with an \"opinion\" as @esben "}}
{"actor":{"display_login":"krevsbech"}}