{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/issues/541","repository_url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet","labels_url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/issues/541/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/issues/541/comments","events_url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/issues/541/events","html_url":"https://github.com/Azure/azure-service-bus-dotnet/issues/541","id":346044944,"node_id":"MDU6SXNzdWUzNDYwNDQ5NDQ=","number":541,"title":"MessageExtensions is used for Diagnostics and not general extensibility ","user":{"login":"SeanFeldman","id":1309622,"node_id":"MDQ6VXNlcjEzMDk2MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1309622?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"labels":[{"id":906427292,"node_id":"MDU6TGFiZWw5MDY0MjcyOTI=","url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/labels/breaking%20change","name":"breaking change","color":"d93f0b","default":false},{"id":478483028,"node_id":"MDU6TGFiZWw0Nzg0ODMwMjg=","url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":478483030,"node_id":"MDU6TGFiZWw0Nzg0ODMwMzA=","url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-31T05:54:14Z","updated_at":"2018-07-31T21:27:06Z","closed_at":null,"author_association":"COLLABORATOR","body":"The class [`MessageExtensions`](https://github.com/SeanFeldman/azure-service-bus-dotnet/blob/6f144e91310dcc7bd37aba4e8aebd535d13fa31a/src/Microsoft.Azure.ServiceBus/Extensions/MessageDiagnosticsExtensions.cs#L10) is used for diagnostics (the name of the file is accurate), but is named incorrectly. Diagnostics extensions should be moved to its own designated class to allow general `Message` extensions to be added via `MessageExtensions`.\r\n\r\nSince existing `MessageExtensions` class is public, this would need to be done in the next major as it will be a breaking change.\r\n\r\nCan be handled along with #542"},"comment":{"url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/issues/comments/409373544","html_url":"https://github.com/Azure/azure-service-bus-dotnet/issues/541#issuecomment-409373544","issue_url":"https://api.github.com/repos/Azure/azure-service-bus-dotnet/issues/541","id":409373544,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTM3MzU0NA==","user":{"login":"SeanFeldman","id":1309622,"node_id":"MDQ6VXNlcjEzMDk2MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1309622?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T21:27:06Z","updated_at":"2018-07-31T21:27:06Z","author_association":"COLLABORATOR","body":"I'm asking because asking for help when it's not the time will cause PR hang out there and become outdated, causing unnecessary friction as a result of conflicts with other PRs operating on the same files/classes."}}
{"actor":{"display_login":"SeanFeldman"}}