{"action":"created","issue":{"url":"https://api.github.com/repos/tock/tock/issues/977","repository_url":"https://api.github.com/repos/tock/tock","labels_url":"https://api.github.com/repos/tock/tock/issues/977/labels{/name}","comments_url":"https://api.github.com/repos/tock/tock/issues/977/comments","events_url":"https://api.github.com/repos/tock/tock/issues/977/events","html_url":"https://github.com/tock/tock/pull/977","id":330850240,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzU2OTI1","number":977,"title":"kernel: move main to main.rs","user":{"login":"bradjc","id":1467890,"node_id":"MDQ6VXNlcjE0Njc4OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1467890?v=4","gravatar_id":"","url":"https://api.github.com/users/bradjc","html_url":"https://github.com/bradjc","followers_url":"https://api.github.com/users/bradjc/followers","following_url":"https://api.github.com/users/bradjc/following{/other_user}","gists_url":"https://api.github.com/users/bradjc/gists{/gist_id}","starred_url":"https://api.github.com/users/bradjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradjc/subscriptions","organizations_url":"https://api.github.com/users/bradjc/orgs","repos_url":"https://api.github.com/users/bradjc/repos","events_url":"https://api.github.com/users/bradjc/events{/privacy}","received_events_url":"https://api.github.com/users/bradjc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-09T03:54:06Z","updated_at":"2018-06-14T15:59:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tock/tock/pulls/977","html_url":"https://github.com/tock/tock/pull/977","diff_url":"https://github.com/tock/tock/pull/977.diff","patch_url":"https://github.com/tock/tock/pull/977.patch"},"body":"### Pull Request Overview\r\n\r\n`main()` was in lib.rs, which was a little tricky to find. Also `do_process()` in sched.rs had to be public, but is only called in one place. This merges the two, so all scheduling and main loop code is in the same place, and renames the file to main.rs so it is obvious where everything starts.\r\n\r\n\r\n\r\n### Testing Strategy\r\n\r\nThis pull request was tested by compiling.\r\n\r\n\r\n### TODO or Help Wanted\r\n\r\nI think this is easier to understand, but there may be good reasons to leave it as it was.\r\n\r\n\r\n### Documentation Updated\r\n\r\n- [x] Kernel: Updated the relevant files in `/docs`, or no updates are required.\r\n- [x] Userland: Added/updated the application README, if needed.\r\n\r\n### Formatting\r\n\r\n- [x] Ran `make formatall`.\r\n"},"comment":{"url":"https://api.github.com/repos/tock/tock/issues/comments/397347303","html_url":"https://github.com/tock/tock/pull/977#issuecomment-397347303","issue_url":"https://api.github.com/repos/tock/tock/issues/977","id":397347303,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzM0NzMwMw==","user":{"login":"ppannuto","id":339422,"node_id":"MDQ6VXNlcjMzOTQyMg==","avatar_url":"https://avatars2.githubusercontent.com/u/339422?v=4","gravatar_id":"","url":"https://api.github.com/users/ppannuto","html_url":"https://github.com/ppannuto","followers_url":"https://api.github.com/users/ppannuto/followers","following_url":"https://api.github.com/users/ppannuto/following{/other_user}","gists_url":"https://api.github.com/users/ppannuto/gists{/gist_id}","starred_url":"https://api.github.com/users/ppannuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppannuto/subscriptions","organizations_url":"https://api.github.com/users/ppannuto/orgs","repos_url":"https://api.github.com/users/ppannuto/repos","events_url":"https://api.github.com/users/ppannuto/events{/privacy}","received_events_url":"https://api.github.com/users/ppannuto/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T15:59:10Z","updated_at":"2018-06-14T15:59:10Z","author_association":"MEMBER","body":"That sounds like a good plan to me.\nOn Thu, Jun 14, 2018 at 14:37 Brad Campbell <notifications@github.com>\nwrote:\n\n> Really there are maybe three issues here:\n>\n>    1. Where should the function currently called main be?\n>    2. What should the function currently called main be named?\n>    3. What should the file that the function currently called main is in\n>    be named?\n>\n> I'm most invested in moving main out of lib.rs since I find that to be\n> confusing, non descriptive, and inconsistent with our other crates.\n>\n> Therefore, I propose:\n>\n>    - Moving the function currently called main to sched.rs.\n>    - Renaming the function currently called main to kernel_loop.\n>    - Leaving the filename of sched.rs as is.\n>\n> Thoughts?\n>\n> —\n> You are receiving this because you commented.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/tock/tock/pull/977#issuecomment-397318843>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAUt3vtsy-ZM8S85fBJqRXANYBsor3gxks5t8nUPgaJpZM4UhKbG>\n> .\n>\n"}}
{"actor":{"display_login":"ppannuto"}}