{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/224269806","pull_request_review_id":163021554,"id":224269806,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI2OTgwNg==","diff_hunk":"@@ -1543,7 +1543,12 @@ OPTION(rgw_reshard_thread_interval, OPT_U32) // maximum time between rounds of r\n OPTION(rgw_acl_grants_max_num, OPT_INT) // According to AWS S3(http://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html), An ACL can have up to 100 grants.\n OPTION(rgw_cors_rules_max_num, OPT_INT) // According to AWS S3(http://docs.aws.amazon.com/AmazonS3/latest/dev/cors.html), An cors can have up to 100 rules.\n OPTION(rgw_delete_multi_obj_max_num, OPT_INT) // According to AWS S3(https://docs.aws.amazon.com/AmazonS3/latest/dev/DeletingObjects.html), Amazon S3 also provides the Multi-Object Delete API that you can use to delete up to 1000 objects in a single HTTP request.\n-OPTION(rgw_website_routing_rules_max_num, OPT_INT) // According to AWS S3, An website routing config can have up to 50 rules.\n+OPTION(rgw_website_routing_rules_max_num, OPT_INT) // According to AWS S3, An website routing config can have up to 50 rules.  \n+  \n+OPTION(rgw_sts_entry, OPT_STR)","path":"src/common/legacy_config_opts.h","position":7,"original_position":7,"commit_id":"4768023f4ceeb34de0a40cc542e7d121fc65f531","original_commit_id":"4768023f4ceeb34de0a40cc542e7d121fc65f531","user":{"login":"mattbenjamin","id":301287,"node_id":"MDQ6VXNlcjMwMTI4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/301287?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"body":"hmm.  did you add htis?  maybe this is a bad merge?","created_at":"2018-10-10T23:07:40Z","updated_at":"2018-10-10T23:08:04Z","html_url":"https://github.com/ceph/ceph/pull/24500#discussion_r224269806","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/24500","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/224269806"},"html":{"href":"https://github.com/ceph/ceph/pull/24500#discussion_r224269806"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24500"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24500","id":221508244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTA4MjQ0","html_url":"https://github.com/ceph/ceph/pull/24500","diff_url":"https://github.com/ceph/ceph/pull/24500.diff","patch_url":"https://github.com/ceph/ceph/pull/24500.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24500","number":24500,"state":"open","locked":false,"title":"Radosgw: Distributed Data Cache","user":{"login":"maniaabdi","id":4215223,"node_id":"MDQ6VXNlcjQyMTUyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4215223?v=4","gravatar_id":"","url":"https://api.github.com/users/maniaabdi","html_url":"https://github.com/maniaabdi","followers_url":"https://api.github.com/users/maniaabdi/followers","following_url":"https://api.github.com/users/maniaabdi/following{/other_user}","gists_url":"https://api.github.com/users/maniaabdi/gists{/gist_id}","starred_url":"https://api.github.com/users/maniaabdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniaabdi/subscriptions","organizations_url":"https://api.github.com/users/maniaabdi/orgs","repos_url":"https://api.github.com/users/maniaabdi/repos","events_url":"https://api.github.com/users/maniaabdi/events{/privacy}","received_events_url":"https://api.github.com/users/maniaabdi/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for opening a pull request!  Here are some tips on creating\r\na well formatted contribution.\r\n\r\nPlease give your pull request a title like \"[component]: [short description]\"\r\n\r\nThis is the format for commit messages:\r\n\r\n\"\"\"\r\n[component]: [short description]\r\n\r\n[A longer multiline description]\r\n\r\nFixes: [ticket URL on tracker.ceph.com, create one if necessary]\r\nSigned-off-by: [Your Name] <[your email]>\r\n\"\"\"\r\n\r\nThe Signed-off-by line is important, and it is your certification that\r\nyour contributions satisfy the Developers Certificate or Origin.  For\r\nmore detail, see SubmittingPatches.rst.\r\n\r\nThe component is the short name of a major daemon or subsystem,\r\nsomething like \"mon\", \"osd\", \"mds\", \"rbd, \"rgw\", etc. For ceph-mgr modules,\r\ngive the component as \"mgr/<module name>\" rather than a path into pybind.\r\n\r\nFor more examples, simply use \"git log\" and look at some historical commits.\r\n\r\nThis was just a quick overview.  More information for contributors is available here:\r\nhttps://raw.githubusercontent.com/ceph/ceph/master/SubmittingPatches.rst\r\n\r\n-->\r\n\r\n- [x] References tracker ticket\r\n- [x] Updates documentation if necessary\r\n- [x] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-10-09T16:36:52Z","updated_at":"2018-10-10T23:08:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc4767fd619fb5ae6fdbe85d4a089ef2f3de64e2","assignee":{"login":"mattbenjamin","id":301287,"node_id":"MDQ6VXNlcjMwMTI4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/301287?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattbenjamin","id":301287,"node_id":"MDQ6VXNlcjMwMTI4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/301287?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774006,"node_id":"MDU6TGFiZWwxMzQ3NzQwMDY=","url":"https://api.github.com/repos/ceph/ceph/labels/feature","name":"feature","color":"00ff24","default":false},{"id":144329618,"node_id":"MDU6TGFiZWwxNDQzMjk2MTg=","url":"https://api.github.com/repos/ceph/ceph/labels/rgw","name":"rgw","color":"00ffe4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/24500/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/24500/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24500/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/4768023f4ceeb34de0a40cc542e7d121fc65f531","head":{"label":"maniaabdi:rgw_datacache","ref":"rgw_datacache","sha":"4768023f4ceeb34de0a40cc542e7d121fc65f531","user":{"login":"maniaabdi","id":4215223,"node_id":"MDQ6VXNlcjQyMTUyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4215223?v=4","gravatar_id":"","url":"https://api.github.com/users/maniaabdi","html_url":"https://github.com/maniaabdi","followers_url":"https://api.github.com/users/maniaabdi/followers","following_url":"https://api.github.com/users/maniaabdi/following{/other_user}","gists_url":"https://api.github.com/users/maniaabdi/gists{/gist_id}","starred_url":"https://api.github.com/users/maniaabdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniaabdi/subscriptions","organizations_url":"https://api.github.com/users/maniaabdi/orgs","repos_url":"https://api.github.com/users/maniaabdi/repos","events_url":"https://api.github.com/users/maniaabdi/events{/privacy}","received_events_url":"https://api.github.com/users/maniaabdi/received_events","type":"User","site_admin":false},"repo":{"id":149803116,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk4MDMxMTY=","name":"ceph","full_name":"maniaabdi/ceph","private":false,"owner":{"login":"maniaabdi","id":4215223,"node_id":"MDQ6VXNlcjQyMTUyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4215223?v=4","gravatar_id":"","url":"https://api.github.com/users/maniaabdi","html_url":"https://github.com/maniaabdi","followers_url":"https://api.github.com/users/maniaabdi/followers","following_url":"https://api.github.com/users/maniaabdi/following{/other_user}","gists_url":"https://api.github.com/users/maniaabdi/gists{/gist_id}","starred_url":"https://api.github.com/users/maniaabdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniaabdi/subscriptions","organizations_url":"https://api.github.com/users/maniaabdi/orgs","repos_url":"https://api.github.com/users/maniaabdi/repos","events_url":"https://api.github.com/users/maniaabdi/events{/privacy}","received_events_url":"https://api.github.com/users/maniaabdi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/maniaabdi/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/maniaabdi/ceph","forks_url":"https://api.github.com/repos/maniaabdi/ceph/forks","keys_url":"https://api.github.com/repos/maniaabdi/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maniaabdi/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maniaabdi/ceph/teams","hooks_url":"https://api.github.com/repos/maniaabdi/ceph/hooks","issue_events_url":"https://api.github.com/repos/maniaabdi/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/maniaabdi/ceph/events","assignees_url":"https://api.github.com/repos/maniaabdi/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/maniaabdi/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/maniaabdi/ceph/tags","blobs_url":"https://api.github.com/repos/maniaabdi/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maniaabdi/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maniaabdi/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/maniaabdi/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maniaabdi/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/maniaabdi/ceph/languages","stargazers_url":"https://api.github.com/repos/maniaabdi/ceph/stargazers","contributors_url":"https://api.github.com/repos/maniaabdi/ceph/contributors","subscribers_url":"https://api.github.com/repos/maniaabdi/ceph/subscribers","subscription_url":"https://api.github.com/repos/maniaabdi/ceph/subscription","commits_url":"https://api.github.com/repos/maniaabdi/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/maniaabdi/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/maniaabdi/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/maniaabdi/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/maniaabdi/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/maniaabdi/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maniaabdi/ceph/merges","archive_url":"https://api.github.com/repos/maniaabdi/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maniaabdi/ceph/downloads","issues_url":"https://api.github.com/repos/maniaabdi/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/maniaabdi/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/maniaabdi/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/maniaabdi/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maniaabdi/ceph/labels{/name}","releases_url":"https://api.github.com/repos/maniaabdi/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/maniaabdi/ceph/deployments","created_at":"2018-09-21T18:34:39Z","updated_at":"2018-09-22T00:24:30Z","pushed_at":"2018-10-09T16:38:31Z","git_url":"git://github.com/maniaabdi/ceph.git","ssh_url":"git@github.com:maniaabdi/ceph.git","clone_url":"https://github.com/maniaabdi/ceph.git","svn_url":"https://github.com/maniaabdi/ceph","homepage":"http://ceph.com","size":316391,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"13af4b52f7f3b9ba33ccfb766b958840a1c13b78","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-10-10T22:32:21Z","pushed_at":"2018-10-10T23:07:33Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":319635,"stargazers_count":5149,"watchers_count":5149,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2683,"mirror_url":null,"archived":false,"open_issues_count":770,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2683,"open_issues":770,"watchers":5149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24500"},"html":{"href":"https://github.com/ceph/ceph/pull/24500"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/24500"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/24500/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24500/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/24500/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/4768023f4ceeb34de0a40cc542e7d121fc65f531"}},"author_association":"NONE"}}
{"actor":{"display_login":"mattbenjamin"}}