{"action":"opened","issue":{"url":"https://api.github.com/repos/shankj3/ocelot/issues/137","repository_url":"https://api.github.com/repos/shankj3/ocelot","labels_url":"https://api.github.com/repos/shankj3/ocelot/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/shankj3/ocelot/issues/137/comments","events_url":"https://api.github.com/repos/shankj3/ocelot/issues/137/events","html_url":"https://github.com/shankj3/ocelot/issues/137","id":384473641,"node_id":"MDU6SXNzdWUzODQ0NzM2NDE=","number":137,"title":"clean up vcs type string conversion in flags","user":{"login":"shankj3","id":11891205,"node_id":"MDQ6VXNlcjExODkxMjA1","avatar_url":"https://avatars3.githubusercontent.com/u/11891205?v=4","gravatar_id":"","url":"https://api.github.com/users/shankj3","html_url":"https://github.com/shankj3","followers_url":"https://api.github.com/users/shankj3/followers","following_url":"https://api.github.com/users/shankj3/following{/other_user}","gists_url":"https://api.github.com/users/shankj3/gists{/gist_id}","starred_url":"https://api.github.com/users/shankj3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankj3/subscriptions","organizations_url":"https://api.github.com/users/shankj3/orgs","repos_url":"https://api.github.com/users/shankj3/repos","events_url":"https://api.github.com/users/shankj3/events{/privacy}","received_events_url":"https://api.github.com/users/shankj3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-26T19:21:23Z","updated_at":"2018-11-26T19:21:23Z","closed_at":null,"author_association":"OWNER","body":"```golang\r\noh.VcsType, err = protobuf.VcsTypeStringToSubCredType(oh.VcsTypeStr)\r\n```\r\n\r\n\r\n^^^ this is v. messy. we should consider instead adding methods to CredType && SubCredType to be able to parse strings etc, and that could be used all over the place in the client to clean up some similar conversion code\r\n\r\nref: #130  -- [comment](https://github.com/shankj3/ocelot/pull/130/files/593821c9f0d217b4448b28253930983c2058c339#r234816360)"}}
{"actor":{"display_login":"shankj3"}}