{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments/191621851","pull_request_review_id":124226641,"id":191621851,"diff_hunk":"@@ -0,0 +1,83 @@\n+/*\n+Copyright 2018 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package e2e\n+\n+import (\n+\t\"path/filepath\"\n+\n+\t\"github.com/kubernetes-sigs/kubebuilder/test/e2e/framework\"\n+)\n+\n+// runtime config specified to run e2e tests\n+type config struct {\n+\tdomain              string\n+\tgroup               string\n+\tversion             string\n+\tkind                string\n+\tinstallName         string\n+\tnamespace           string\n+\tcontrollerImageName string\n+\tworkDir             string\n+}\n+\n+// initConfig init with a random suffix for test config stuff,\n+// to avoid conflict when running tests synchronously.\n+func initConfig(testSuffix string) *config {\n+\ttestGroup := \"bar\" + testSuffix\n+\tinstallName := \"kube\" + testGroup + testSuffix\n+\ttestNamespace := installName + \"-system\"\n+\n+\treturn &config{\n+\t\tdomain:              \"example.com\" + testSuffix,\n+\t\tgroup:               testGroup,\n+\t\tversion:             \"v1alpha1\",\n+\t\tkind:                \"Foo\" + testSuffix,\n+\t\tinstallName:         installName,\n+\t\tnamespace:           testNamespace,\n+\t\tcontrollerImageName: \"gcr.io/kubeships/controller-manager:\" + testSuffix,","path":"test/e2e/config.go","position":51,"original_position":51,"commit_id":"a5c5dd9f63e3c1edff38a309758630a426abc722","original_commit_id":"a5c5dd9f63e3c1edff38a309758630a426abc722","user":{"login":"lichuqiang","id":12265352,"avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"body":"ah, sorry, here I just copy it from the user guide without much thinking.\r\nIn fact the name won't affect anything, as we don't perform image push in the test (as I think it has nothing to do with the project itself).\r\nLet me rename it to something that won't make people confused.","created_at":"2018-05-30T01:42:46Z","updated_at":"2018-05-30T01:42:47Z","html_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/229#discussion_r191621851","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments/191621851"},"html":{"href":"https://github.com/kubernetes-sigs/kubebuilder/pull/229#discussion_r191621851"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229"}},"in_reply_to_id":191562723},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229","id":190727486,"html_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/229","diff_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/229.diff","patch_url":"https://github.com/kubernetes-sigs/kubebuilder/pull/229.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/229","number":229,"state":"open","locked":false,"title":"Add e2e test for kubebuilder","user":{"login":"lichuqiang","id":12265352,"avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"body":"Fix: https://github.com/kubernetes-sigs/kubebuilder/issues/166\r\n\r\nthe PR\r\n- add e2e framework\r\n- add test case to cover main workflow\r\n\r\nTODO: \r\n-  (in separate PRs) add more tests to cover edge-cases\r\n\r\n/assign @droot @pwittrock ","created_at":"2018-05-26T05:59:30Z","updated_at":"2018-05-30T01:42:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"929fadc93063421da997d2701853fad2e95ba6ec","assignee":{"login":"droot","id":172029,"avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"assignees":[{"login":"droot","id":172029,"avatar_url":"https://avatars3.githubusercontent.com/u/172029?v=4","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":867761741,"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":874385392,"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/229/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/statuses/a5c5dd9f63e3c1edff38a309758630a426abc722","head":{"label":"lichuqiang:e2e","ref":"e2e","sha":"a5c5dd9f63e3c1edff38a309758630a426abc722","user":{"login":"lichuqiang","id":12265352,"avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"repo":{"id":132974783,"name":"kubebuilder","full_name":"lichuqiang/kubebuilder","owner":{"login":"lichuqiang","id":12265352,"avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lichuqiang/kubebuilder","description":"Kubebuilder","fork":true,"url":"https://api.github.com/repos/lichuqiang/kubebuilder","forks_url":"https://api.github.com/repos/lichuqiang/kubebuilder/forks","keys_url":"https://api.github.com/repos/lichuqiang/kubebuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lichuqiang/kubebuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lichuqiang/kubebuilder/teams","hooks_url":"https://api.github.com/repos/lichuqiang/kubebuilder/hooks","issue_events_url":"https://api.github.com/repos/lichuqiang/kubebuilder/issues/events{/number}","events_url":"https://api.github.com/repos/lichuqiang/kubebuilder/events","assignees_url":"https://api.github.com/repos/lichuqiang/kubebuilder/assignees{/user}","branches_url":"https://api.github.com/repos/lichuqiang/kubebuilder/branches{/branch}","tags_url":"https://api.github.com/repos/lichuqiang/kubebuilder/tags","blobs_url":"https://api.github.com/repos/lichuqiang/kubebuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lichuqiang/kubebuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lichuqiang/kubebuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/lichuqiang/kubebuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lichuqiang/kubebuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/lichuqiang/kubebuilder/languages","stargazers_url":"https://api.github.com/repos/lichuqiang/kubebuilder/stargazers","contributors_url":"https://api.github.com/repos/lichuqiang/kubebuilder/contributors","subscribers_url":"https://api.github.com/repos/lichuqiang/kubebuilder/subscribers","subscription_url":"https://api.github.com/repos/lichuqiang/kubebuilder/subscription","commits_url":"https://api.github.com/repos/lichuqiang/kubebuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/lichuqiang/kubebuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/lichuqiang/kubebuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/lichuqiang/kubebuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/lichuqiang/kubebuilder/contents/{+path}","compare_url":"https://api.github.com/repos/lichuqiang/kubebuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lichuqiang/kubebuilder/merges","archive_url":"https://api.github.com/repos/lichuqiang/kubebuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lichuqiang/kubebuilder/downloads","issues_url":"https://api.github.com/repos/lichuqiang/kubebuilder/issues{/number}","pulls_url":"https://api.github.com/repos/lichuqiang/kubebuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/lichuqiang/kubebuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/lichuqiang/kubebuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lichuqiang/kubebuilder/labels{/name}","releases_url":"https://api.github.com/repos/lichuqiang/kubebuilder/releases{/id}","deployments_url":"https://api.github.com/repos/lichuqiang/kubebuilder/deployments","created_at":"2018-05-11T01:47:57Z","updated_at":"2018-05-22T03:13:48Z","pushed_at":"2018-05-26T05:45:51Z","git_url":"git://github.com/lichuqiang/kubebuilder.git","ssh_url":"git@github.com:lichuqiang/kubebuilder.git","clone_url":"https://github.com/lichuqiang/kubebuilder.git","svn_url":"https://github.com/lichuqiang/kubebuilder","homepage":null,"size":54971,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"6fd526965e63b4e01fefd9ff99d948e75d1295cd","user":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":125275487,"name":"kubebuilder","full_name":"kubernetes-sigs/kubebuilder","owner":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/kubebuilder","description":"Kubebuilder","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder","forks_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/deployments","created_at":"2018-03-14T21:26:14Z","updated_at":"2018-05-29T15:20:31Z","pushed_at":"2018-05-29T22:03:22Z","git_url":"git://github.com/kubernetes-sigs/kubebuilder.git","ssh_url":"git@github.com:kubernetes-sigs/kubebuilder.git","clone_url":"https://github.com/kubernetes-sigs/kubebuilder.git","svn_url":"https://github.com/kubernetes-sigs/kubebuilder","homepage":null,"size":54955,"stargazers_count":112,"watchers_count":112,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":24,"open_issues":25,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229"},"html":{"href":"https://github.com/kubernetes-sigs/kubebuilder/pull/229"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/229"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/kubebuilder/statuses/a5c5dd9f63e3c1edff38a309758630a426abc722"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lichuqiang"}}