{"action":"created","issue":{"url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug/issues/2","repository_url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug","labels_url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug/issues/2/comments","events_url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug/issues/2/events","html_url":"https://github.com/NamelessCoder/typo3-cms-fluid-debug/issues/2","id":295496793,"number":2,"title":"Feature Suggestion: custom breakpoint condition","user":{"login":"cvigano","id":572338,"avatar_url":"https://avatars1.githubusercontent.com/u/572338?v=4","gravatar_id":"","url":"https://api.github.com/users/cvigano","html_url":"https://github.com/cvigano","followers_url":"https://api.github.com/users/cvigano/followers","following_url":"https://api.github.com/users/cvigano/following{/other_user}","gists_url":"https://api.github.com/users/cvigano/gists{/gist_id}","starred_url":"https://api.github.com/users/cvigano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvigano/subscriptions","organizations_url":"https://api.github.com/users/cvigano/orgs","repos_url":"https://api.github.com/users/cvigano/repos","events_url":"https://api.github.com/users/cvigano/events{/privacy}","received_events_url":"https://api.github.com/users/cvigano/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-08T12:38:29Z","updated_at":"2018-02-08T14:43:31Z","closed_at":"2018-02-08T14:18:24Z","author_association":"NONE","body":"This extension is really great and helping a lot. What I'm missing from working with PhpStorm's system of breakpoint condition is the ability to define a condition upon which the breakpoint triggers.\r\n\r\nNow, my idea is that we can optionally pass a condition function as an argument to `f:debug` which get's called when set to which the context of `DebugViewHelper::breakPoint` is passed, so that in theory the condition function is able to check on all the variables that are available in `DebugViewHelper::breakPoint`.\r\n\r\nIs a feature like that even possible? I'm not even sure. But I think it would help a lot :grinning:."},"comment":{"url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug/issues/comments/364132463","html_url":"https://github.com/NamelessCoder/typo3-cms-fluid-debug/issues/2#issuecomment-364132463","issue_url":"https://api.github.com/repos/NamelessCoder/typo3-cms-fluid-debug/issues/2","id":364132463,"user":{"login":"NamelessCoder","id":2228052,"avatar_url":"https://avatars3.githubusercontent.com/u/2228052?v=4","gravatar_id":"","url":"https://api.github.com/users/NamelessCoder","html_url":"https://github.com/NamelessCoder","followers_url":"https://api.github.com/users/NamelessCoder/followers","following_url":"https://api.github.com/users/NamelessCoder/following{/other_user}","gists_url":"https://api.github.com/users/NamelessCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/NamelessCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NamelessCoder/subscriptions","organizations_url":"https://api.github.com/users/NamelessCoder/orgs","repos_url":"https://api.github.com/users/NamelessCoder/repos","events_url":"https://api.github.com/users/NamelessCoder/events{/privacy}","received_events_url":"https://api.github.com/users/NamelessCoder/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T14:43:31Z","updated_at":"2018-02-08T14:43:31Z","author_association":"OWNER","body":"If by internal state you mean things like what is in the ViewHelperVariableContainer or RenderingContext, but not accessible in the template layer itself, then I'm afraid there's no easy way to do that from the template layer. The best choice then would be to set your break point in either of the override classes and have your IDE set the breakpoints. Then you would only need to find that class and set `break=\"0\"` on `f:debug.break` to disable the automatic breaking in favour of your own, conditional breaks. IMHO it is fine to have to put breakpoints in third-party code; since you wouldn't have to edit it to get it done.\r\n\r\nNote though that it may make more sense to debug in the TemplateParser, TemplateCompiler, ViewHelperResolver or other if your need for detail and precision is high. When you debug via the template you are debugging on a separated state; you have limited access to the state of the TemplateParser for example.\r\n\r\nHope I'm not missing anything... my logic is that breakpoint control is only necessary if you already use xdebug + IDE and if you do, breakpoints can be easily set anywhere in framework or vendor code without needing to configure your runtime to call a certain method."}}
{"actor":{"display_login":"NamelessCoder"}}