{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/180329037","pull_request_review_id":110729552,"id":180329037,"diff_hunk":"@@ -281,20 +283,29 @@ void remove_asmt::process_instruction(\n void remove_asmt::process_function(\n   goto_functionst::goto_functiont &goto_function)\n {\n+  bool did_something=false;\n+\n   Forall_goto_program_instructions(it, goto_function.body)\n   {\n     if(it->is_other() && it->code.get_statement()==ID_asm)\n     {\n       goto_programt tmp_dest;\n       process_instruction(*it, tmp_dest);\n       it->make_skip();\n+      did_something=true;\n \n       goto_programt::targett next=it;\n       next++;\n \n       goto_function.body.destructive_insert(next, tmp_dest);\n     }\n   }\n+\n+  if(did_something)\n+  {\n+    remove_skip(goto_function.body);","path":"src/goto-programs/remove_asm.cpp","position":33,"original_position":33,"commit_id":"dc6df01da2933a1a81927e7477d6d1dc96bccaba","original_commit_id":"dc6df01da2933a1a81927e7477d6d1dc96bccaba","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"body":"I think this would be unusual -- from what I've seen elsewhere, passes usually leave skips intact and then the driver program is expected to do one big `remove_skip` at a time of its choosing. This is especially useful in that it means the driver program can assume most passes do not alter location numbers.","created_at":"2018-04-10T08:05:58Z","updated_at":"2018-04-10T08:05:59Z","html_url":"https://github.com/diffblue/cbmc/pull/2029#discussion_r180329037","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2029","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/180329037"},"html":{"href":"https://github.com/diffblue/cbmc/pull/2029#discussion_r180329037"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2029"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/2029","id":180390682,"html_url":"https://github.com/diffblue/cbmc/pull/2029","diff_url":"https://github.com/diffblue/cbmc/pull/2029.diff","patch_url":"https://github.com/diffblue/cbmc/pull/2029.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/2029","number":2029,"state":"open","locked":false,"title":"goto-instrument: Remove inline asm before doing various operations","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"body":"If mutations such as expanding function pointers have been performed, then\r\nremoving inline asm is reasonable as well.","created_at":"2018-04-09T18:32:18Z","updated_at":"2018-04-10T08:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef10130eac82a6a58387240d58a307ac3df9c25d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false},{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},{"login":"martin-cs","id":5333188,"avatar_url":"https://avatars0.githubusercontent.com/u/5333188?v=4","gravatar_id":"","url":"https://api.github.com/users/martin-cs","html_url":"https://github.com/martin-cs","followers_url":"https://api.github.com/users/martin-cs/followers","following_url":"https://api.github.com/users/martin-cs/following{/other_user}","gists_url":"https://api.github.com/users/martin-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-cs/subscriptions","organizations_url":"https://api.github.com/users/martin-cs/orgs","repos_url":"https://api.github.com/users/martin-cs/repos","events_url":"https://api.github.com/users/martin-cs/events{/privacy}","received_events_url":"https://api.github.com/users/martin-cs/received_events","type":"User","site_admin":false},{"login":"chrisr-diffblue","id":32060010,"avatar_url":"https://avatars2.githubusercontent.com/u/32060010?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisr-diffblue","html_url":"https://github.com/chrisr-diffblue","followers_url":"https://api.github.com/users/chrisr-diffblue/followers","following_url":"https://api.github.com/users/chrisr-diffblue/following{/other_user}","gists_url":"https://api.github.com/users/chrisr-diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisr-diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisr-diffblue/subscriptions","organizations_url":"https://api.github.com/users/chrisr-diffblue/orgs","repos_url":"https://api.github.com/users/chrisr-diffblue/repos","events_url":"https://api.github.com/users/chrisr-diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/chrisr-diffblue/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2029/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/2029/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/2029/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/dc6df01da2933a1a81927e7477d6d1dc96bccaba","head":{"label":"tautschnig:remove-asm","ref":"remove-asm","sha":"dc6df01da2933a1a81927e7477d6d1dc96bccaba","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"repo":{"id":52358391,"name":"cbmc","full_name":"tautschnig/cbmc","owner":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tautschnig/cbmc","description":null,"fork":true,"url":"https://api.github.com/repos/tautschnig/cbmc","forks_url":"https://api.github.com/repos/tautschnig/cbmc/forks","keys_url":"https://api.github.com/repos/tautschnig/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tautschnig/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tautschnig/cbmc/teams","hooks_url":"https://api.github.com/repos/tautschnig/cbmc/hooks","issue_events_url":"https://api.github.com/repos/tautschnig/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/tautschnig/cbmc/events","assignees_url":"https://api.github.com/repos/tautschnig/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/tautschnig/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/tautschnig/cbmc/tags","blobs_url":"https://api.github.com/repos/tautschnig/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tautschnig/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tautschnig/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tautschnig/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tautschnig/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/tautschnig/cbmc/languages","stargazers_url":"https://api.github.com/repos/tautschnig/cbmc/stargazers","contributors_url":"https://api.github.com/repos/tautschnig/cbmc/contributors","subscribers_url":"https://api.github.com/repos/tautschnig/cbmc/subscribers","subscription_url":"https://api.github.com/repos/tautschnig/cbmc/subscription","commits_url":"https://api.github.com/repos/tautschnig/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tautschnig/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tautschnig/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tautschnig/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/tautschnig/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/tautschnig/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tautschnig/cbmc/merges","archive_url":"https://api.github.com/repos/tautschnig/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tautschnig/cbmc/downloads","issues_url":"https://api.github.com/repos/tautschnig/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/tautschnig/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/tautschnig/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/tautschnig/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tautschnig/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/tautschnig/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/tautschnig/cbmc/deployments","created_at":"2016-02-23T12:48:00Z","updated_at":"2016-02-23T12:48:14Z","pushed_at":"2018-04-10T07:46:38Z","git_url":"git://github.com/tautschnig/cbmc.git","ssh_url":"git@github.com:tautschnig/cbmc.git","clone_url":"https://github.com/tautschnig/cbmc.git","svn_url":"https://github.com/tautschnig/cbmc","homepage":null,"size":50115,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"28c076bf6cf8537fa884ccd1a727dc2b13706d6b","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2018-04-09T19:49:51Z","pushed_at":"2018-04-10T07:46:49Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":29782,"stargazers_count":109,"watchers_count":109,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":351,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":91,"open_issues":351,"watchers":109,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2029"},"html":{"href":"https://github.com/diffblue/cbmc/pull/2029"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/2029"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/2029/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2029/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/2029/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/dc6df01da2933a1a81927e7477d6d1dc96bccaba"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"smowton"}}