{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/193187867","pull_request_review_id":126111395,"id":193187867,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzE4Nzg2Nw==","diff_hunk":"@@ -853,6 +853,11 @@ Status CompactionPicker::SanitizeCompactionInputFilesForAllLevels(\n       }\n     }\n   }\n+  if (RangeOverlapWithCompaction(smallestkey, largestkey, output_level)) {","path":"db/compaction_picker.cc","position":4,"original_position":4,"commit_id":"9e7cb30c9e0ee87e8f148b4bc7fcd2a2c847f1c7","original_commit_id":"9e7cb30c9e0ee87e8f148b4bc7fcd2a2c847f1c7","user":{"login":"ajkr","id":4780362,"node_id":"MDQ6VXNlcjQ3ODAzNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4780362?v=4","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"body":"It's a weird edge case, where the input files' key range is in a gap between files that are pending compaction to the same output level. The pending compaction merges the input files and can produce output files that cover the gap.","created_at":"2018-06-05T19:09:52Z","updated_at":"2018-06-05T19:09:52Z","html_url":"https://github.com/facebook/rocksdb/pull/3926#discussion_r193187867","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3926","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/193187867"},"html":{"href":"https://github.com/facebook/rocksdb/pull/3926#discussion_r193187867"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3926"}},"in_reply_to_id":193170780},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/3926","id":191640456,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjQwNDU2","html_url":"https://github.com/facebook/rocksdb/pull/3926","diff_url":"https://github.com/facebook/rocksdb/pull/3926.diff","patch_url":"https://github.com/facebook/rocksdb/pull/3926.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/3926","number":3926,"state":"open","locked":false,"title":"Check conflict at output level in CompactFiles","user":{"login":"ajkr","id":4780362,"node_id":"MDQ6VXNlcjQ3ODAzNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4780362?v=4","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"body":"CompactFiles checked whether the existing files conflicted with the chosen compaction. But it missed checking whether future files would conflict, i.e., when another compaction was simultaneously writing new files to the same range at the same output level.\r\n\r\nTest Plan:\r\n\r\n- exposed the bug in a test case, verified it works after this fix","created_at":"2018-05-31T04:22:29Z","updated_at":"2018-06-05T19:09:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c86b86a89e207a2c27a0f1ecf13fa4bba0be2523","assignee":null,"assignees":[],"requested_reviewers":[{"login":"siying","id":5334567,"node_id":"MDQ6VXNlcjUzMzQ1Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/5334567?v=4","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3926/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/3926/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/3926/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/9e7cb30c9e0ee87e8f148b4bc7fcd2a2c847f1c7","head":{"label":"ajkr:fix-compact-files-overlap","ref":"fix-compact-files-overlap","sha":"9e7cb30c9e0ee87e8f148b4bc7fcd2a2c847f1c7","user":{"login":"ajkr","id":4780362,"node_id":"MDQ6VXNlcjQ3ODAzNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4780362?v=4","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"repo":{"id":69681666,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY4MTY2Ng==","name":"rocksdb","full_name":"ajkr/rocksdb","owner":{"login":"ajkr","id":4780362,"node_id":"MDQ6VXNlcjQ3ODAzNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4780362?v=4","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajkr/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/ajkr/rocksdb","forks_url":"https://api.github.com/repos/ajkr/rocksdb/forks","keys_url":"https://api.github.com/repos/ajkr/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajkr/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajkr/rocksdb/teams","hooks_url":"https://api.github.com/repos/ajkr/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/ajkr/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/ajkr/rocksdb/events","assignees_url":"https://api.github.com/repos/ajkr/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/ajkr/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/ajkr/rocksdb/tags","blobs_url":"https://api.github.com/repos/ajkr/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajkr/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajkr/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajkr/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajkr/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ajkr/rocksdb/languages","stargazers_url":"https://api.github.com/repos/ajkr/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/ajkr/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/ajkr/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/ajkr/rocksdb/subscription","commits_url":"https://api.github.com/repos/ajkr/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajkr/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajkr/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajkr/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajkr/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/ajkr/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajkr/rocksdb/merges","archive_url":"https://api.github.com/repos/ajkr/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajkr/rocksdb/downloads","issues_url":"https://api.github.com/repos/ajkr/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/ajkr/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ajkr/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ajkr/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajkr/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/ajkr/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/ajkr/rocksdb/deployments","created_at":"2016-09-30T16:09:32Z","updated_at":"2016-09-30T16:09:37Z","pushed_at":"2018-06-04T21:00:35Z","git_url":"git://github.com/ajkr/rocksdb.git","ssh_url":"git@github.com:ajkr/rocksdb.git","clone_url":"https://github.com/ajkr/rocksdb.git","svn_url":"https://github.com/ajkr/rocksdb","homepage":"http://rocksdb.org","size":138517,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"727eb881a56d75299cb180199a74673041c8d3c8","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM0Mzk1","name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2018-06-05T18:43:53Z","pushed_at":"2018-06-05T18:43:35Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":114591,"stargazers_count":10691,"watchers_count":10691,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2343,"mirror_url":null,"archived":false,"open_issues_count":207,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2343,"open_issues":207,"watchers":10691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3926"},"html":{"href":"https://github.com/facebook/rocksdb/pull/3926"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/3926"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/3926/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3926/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/3926/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/9e7cb30c9e0ee87e8f148b4bc7fcd2a2c847f1c7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajkr"}}