{"action":"created","issue":{"url":"https://api.github.com/repos/ciena/afkak/issues/28","repository_url":"https://api.github.com/repos/ciena/afkak","labels_url":"https://api.github.com/repos/ciena/afkak/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/ciena/afkak/issues/28/comments","events_url":"https://api.github.com/repos/ciena/afkak/issues/28/events","html_url":"https://github.com/ciena/afkak/pull/28","id":347454326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDc1MTI2","number":28,"title":"Handled retrial failure until max delay hitten due to OffsetOutOfRangeError by setting _fetch_offset to OFFSET_EARLIEST.","user":{"login":"zsuzhengdu","id":1986459,"node_id":"MDQ6VXNlcjE5ODY0NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1986459?v=4","gravatar_id":"","url":"https://api.github.com/users/zsuzhengdu","html_url":"https://github.com/zsuzhengdu","followers_url":"https://api.github.com/users/zsuzhengdu/followers","following_url":"https://api.github.com/users/zsuzhengdu/following{/other_user}","gists_url":"https://api.github.com/users/zsuzhengdu/gists{/gist_id}","starred_url":"https://api.github.com/users/zsuzhengdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsuzhengdu/subscriptions","organizations_url":"https://api.github.com/users/zsuzhengdu/orgs","repos_url":"https://api.github.com/users/zsuzhengdu/repos","events_url":"https://api.github.com/users/zsuzhengdu/events{/privacy}","received_events_url":"https://api.github.com/users/zsuzhengdu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-08-03T16:08:12Z","updated_at":"2018-10-24T06:51:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ciena/afkak/pulls/28","html_url":"https://github.com/ciena/afkak/pull/28","diff_url":"https://github.com/ciena/afkak/pull/28.diff","patch_url":"https://github.com/ciena/afkak/pull/28.patch"},"body":"Inspired by https://github.com/dpkp/kafka-python/blob/1937ce59b4706b44091bb536a9b810ae657c3225/kafka/context.py#L169-L178\r\n\r\nAn offset fetch request will be triggered after setting the `_fetch_offset` to `EARLIEST`\r\n```\r\n if (self._fetch_offset == OFFSET_EARLIEST or\r\n                self._fetch_offset == OFFSET_LATEST):\r\n            # We need to fetch the offset for our topic/partition\r\n            offset_request = OffsetRequest(\r\n                self.topic, self.partition, self._fetch_offset, 1)\r\n            self._request_d = self.client.send_offset_request([offset_request])\r\n            self._request_d.addCallbacks(\r\n                self._handle_offset_response, self._handle_offset_error)\r\n```"},"comment":{"url":"https://api.github.com/repos/ciena/afkak/issues/comments/432534302","html_url":"https://github.com/ciena/afkak/pull/28#issuecomment-432534302","issue_url":"https://api.github.com/repos/ciena/afkak/issues/28","id":432534302,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjUzNDMwMg==","user":{"login":"twm","id":43662,"node_id":"MDQ6VXNlcjQzNjYy","avatar_url":"https://avatars2.githubusercontent.com/u/43662?v=4","gravatar_id":"","url":"https://api.github.com/users/twm","html_url":"https://github.com/twm","followers_url":"https://api.github.com/users/twm/followers","following_url":"https://api.github.com/users/twm/following{/other_user}","gists_url":"https://api.github.com/users/twm/gists{/gist_id}","starred_url":"https://api.github.com/users/twm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twm/subscriptions","organizations_url":"https://api.github.com/users/twm/orgs","repos_url":"https://api.github.com/users/twm/repos","events_url":"https://api.github.com/users/twm/events{/privacy}","received_events_url":"https://api.github.com/users/twm/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T06:51:00Z","updated_at":"2018-10-24T06:51:00Z","author_association":"COLLABORATOR","body":"Hi @zsuzhengdu, I'm sorry it has taken me so long to get to this. I don't have time for a full review at the moment, but I did a skim and have a few notes:\r\n\r\n1. This feature addition merits an entry in the changelog.\r\n2. There are two new behaviors here &mdash; earliest and latest &mdash; but only one new test. We need all these new paths to be covered.\r\n3. It seems like we could use the existing constants `OFFSET_EARLIEST` and `OFFSET_LATEST` for the values passed to `auto_offset_reset`. `'fail'` could be represented by ``None``.\r\n\r\nThanks for your patience!"}}
{"actor":{"display_login":"twm"}}