{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/3","id":242417005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDE3MDA1","html_url":"https://github.com/IGRSoft/IGRFilterCombine/pull/3","diff_url":"https://github.com/IGRSoft/IGRFilterCombine/pull/3.diff","patch_url":"https://github.com/IGRSoft/IGRFilterCombine/pull/3.patch","issue_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues/3","number":3,"state":"open","locked":false,"title":"avoid crashing: when filter combine is already deinitialized, but still processing (weak==nil)","user":{"login":"elisar4","id":1868219,"node_id":"MDQ6VXNlcjE4NjgyMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1868219?v=4","gravatar_id":"","url":"https://api.github.com/users/elisar4","html_url":"https://github.com/elisar4","followers_url":"https://api.github.com/users/elisar4/followers","following_url":"https://api.github.com/users/elisar4/following{/other_user}","gists_url":"https://api.github.com/users/elisar4/gists{/gist_id}","starred_url":"https://api.github.com/users/elisar4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elisar4/subscriptions","organizations_url":"https://api.github.com/users/elisar4/orgs","repos_url":"https://api.github.com/users/elisar4/repos","events_url":"https://api.github.com/users/elisar4/events{/privacy}","received_events_url":"https://api.github.com/users/elisar4/received_events","type":"User","site_admin":false},"body":"I am getting crashed while doing simple steps:\r\n1) I have 2 view controllers first is main, second is filter controller\r\n2) present filter controller from main controller\r\n3) previews of filters are starting processing\r\n4) before processing complete click \"close\" button to dismiss filter controller\r\n5) callback \"processedPreviewImagesCompletion\" or \"processedImagesCompletion\" will now crash the app, when processing finished, because filter controller is already deallocated\r\n\r\nThe same issue could appear in all other callbacks with weak. These two are the most commonly used and with this commit it will not crash the app anymore.","created_at":"2019-01-05T03:17:29Z","updated_at":"2019-01-05T03:17:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/3/commits","review_comments_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/3/comments","review_comment_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues/3/comments","statuses_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/statuses/c668eeadb483cfea1e6a4d8d9884ceb11b5484b6","head":{"label":"elisar4:master","ref":"master","sha":"c668eeadb483cfea1e6a4d8d9884ceb11b5484b6","user":{"login":"elisar4","id":1868219,"node_id":"MDQ6VXNlcjE4NjgyMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1868219?v=4","gravatar_id":"","url":"https://api.github.com/users/elisar4","html_url":"https://github.com/elisar4","followers_url":"https://api.github.com/users/elisar4/followers","following_url":"https://api.github.com/users/elisar4/following{/other_user}","gists_url":"https://api.github.com/users/elisar4/gists{/gist_id}","starred_url":"https://api.github.com/users/elisar4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elisar4/subscriptions","organizations_url":"https://api.github.com/users/elisar4/orgs","repos_url":"https://api.github.com/users/elisar4/repos","events_url":"https://api.github.com/users/elisar4/events{/privacy}","received_events_url":"https://api.github.com/users/elisar4/received_events","type":"User","site_admin":false},"repo":{"id":164175048,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQxNzUwNDg=","name":"IGRFilterCombine","full_name":"elisar4/IGRFilterCombine","private":false,"owner":{"login":"elisar4","id":1868219,"node_id":"MDQ6VXNlcjE4NjgyMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1868219?v=4","gravatar_id":"","url":"https://api.github.com/users/elisar4","html_url":"https://github.com/elisar4","followers_url":"https://api.github.com/users/elisar4/followers","following_url":"https://api.github.com/users/elisar4/following{/other_user}","gists_url":"https://api.github.com/users/elisar4/gists{/gist_id}","starred_url":"https://api.github.com/users/elisar4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elisar4/subscriptions","organizations_url":"https://api.github.com/users/elisar4/orgs","repos_url":"https://api.github.com/users/elisar4/repos","events_url":"https://api.github.com/users/elisar4/events{/privacy}","received_events_url":"https://api.github.com/users/elisar4/received_events","type":"User","site_admin":false},"html_url":"https://github.com/elisar4/IGRFilterCombine","description":"Manager of Instagram filters","fork":true,"url":"https://api.github.com/repos/elisar4/IGRFilterCombine","forks_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/forks","keys_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/teams","hooks_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/hooks","issue_events_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/issues/events{/number}","events_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/events","assignees_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/assignees{/user}","branches_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/branches{/branch}","tags_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/tags","blobs_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/git/refs{/sha}","trees_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/statuses/{sha}","languages_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/languages","stargazers_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/stargazers","contributors_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/contributors","subscribers_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/subscribers","subscription_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/subscription","commits_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/commits{/sha}","git_commits_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/git/commits{/sha}","comments_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/comments{/number}","issue_comment_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/issues/comments{/number}","contents_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/contents/{+path}","compare_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/merges","archive_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/downloads","issues_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/issues{/number}","pulls_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/pulls{/number}","milestones_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/milestones{/number}","notifications_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/labels{/name}","releases_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/releases{/id}","deployments_url":"https://api.github.com/repos/elisar4/IGRFilterCombine/deployments","created_at":"2019-01-05T02:37:38Z","updated_at":"2019-01-05T03:03:16Z","pushed_at":"2019-01-05T03:03:14Z","git_url":"git://github.com/elisar4/IGRFilterCombine.git","ssh_url":"git@github.com:elisar4/IGRFilterCombine.git","clone_url":"https://github.com/elisar4/IGRFilterCombine.git","svn_url":"https://github.com/elisar4/IGRFilterCombine","homepage":"https://igrsoft.com","size":983,"stargazers_count":0,"watchers_count":0,"language":"GLSL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IGRSoft:master","ref":"master","sha":"5273d7e17e8be9b672586bf17bc59897492b99e4","user":{"login":"IGRSoft","id":6031155,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMzExNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6031155?v=4","gravatar_id":"","url":"https://api.github.com/users/IGRSoft","html_url":"https://github.com/IGRSoft","followers_url":"https://api.github.com/users/IGRSoft/followers","following_url":"https://api.github.com/users/IGRSoft/following{/other_user}","gists_url":"https://api.github.com/users/IGRSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/IGRSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IGRSoft/subscriptions","organizations_url":"https://api.github.com/users/IGRSoft/orgs","repos_url":"https://api.github.com/users/IGRSoft/repos","events_url":"https://api.github.com/users/IGRSoft/events{/privacy}","received_events_url":"https://api.github.com/users/IGRSoft/received_events","type":"Organization","site_admin":false},"repo":{"id":80917735,"node_id":"MDEwOlJlcG9zaXRvcnk4MDkxNzczNQ==","name":"IGRFilterCombine","full_name":"IGRSoft/IGRFilterCombine","private":false,"owner":{"login":"IGRSoft","id":6031155,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMzExNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6031155?v=4","gravatar_id":"","url":"https://api.github.com/users/IGRSoft","html_url":"https://github.com/IGRSoft","followers_url":"https://api.github.com/users/IGRSoft/followers","following_url":"https://api.github.com/users/IGRSoft/following{/other_user}","gists_url":"https://api.github.com/users/IGRSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/IGRSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IGRSoft/subscriptions","organizations_url":"https://api.github.com/users/IGRSoft/orgs","repos_url":"https://api.github.com/users/IGRSoft/repos","events_url":"https://api.github.com/users/IGRSoft/events{/privacy}","received_events_url":"https://api.github.com/users/IGRSoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IGRSoft/IGRFilterCombine","description":"Manager of Instagram filters","fork":false,"url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine","forks_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/forks","keys_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/teams","hooks_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/hooks","issue_events_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues/events{/number}","events_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/events","assignees_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/assignees{/user}","branches_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/branches{/branch}","tags_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/tags","blobs_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/git/refs{/sha}","trees_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/statuses/{sha}","languages_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/languages","stargazers_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/stargazers","contributors_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/contributors","subscribers_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/subscribers","subscription_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/subscription","commits_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/commits{/sha}","git_commits_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/git/commits{/sha}","comments_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/comments{/number}","issue_comment_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues/comments{/number}","contents_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/contents/{+path}","compare_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/merges","archive_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/downloads","issues_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues{/number}","pulls_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls{/number}","milestones_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/milestones{/number}","notifications_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/labels{/name}","releases_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/releases{/id}","deployments_url":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/deployments","created_at":"2017-02-04T12:22:57Z","updated_at":"2018-08-31T02:59:15Z","pushed_at":"2018-06-16T19:17:32Z","git_url":"git://github.com/IGRSoft/IGRFilterCombine.git","ssh_url":"git@github.com:IGRSoft/IGRFilterCombine.git","clone_url":"https://github.com/IGRSoft/IGRFilterCombine.git","svn_url":"https://github.com/IGRSoft/IGRFilterCombine","homepage":"https://igrsoft.com","size":983,"stargazers_count":12,"watchers_count":12,"language":"GLSL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/3"},"html":{"href":"https://github.com/IGRSoft/IGRFilterCombine/pull/3"},"issue":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues/3"},"comments":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/IGRSoft/IGRFilterCombine/statuses/c668eeadb483cfea1e6a4d8d9884ceb11b5484b6"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"elisar4"}}