{"action":"closed","issue":{"url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/62","repository_url":"https://api.github.com/repos/readium/r2-streamer-swift","labels_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/62/comments","events_url":"https://api.github.com/repos/readium/r2-streamer-swift/issues/62/events","html_url":"https://github.com/readium/r2-streamer-swift/issues/62","id":332076065,"node_id":"MDU6SXNzdWUzMzIwNzYwNjU=","number":62,"title":"Inject user settings in non-FXL HTML resources","user":{"login":"HadrienGardeur","id":90989,"node_id":"MDQ6VXNlcjkwOTg5","avatar_url":"https://avatars2.githubusercontent.com/u/90989?v=4","gravatar_id":"","url":"https://api.github.com/users/HadrienGardeur","html_url":"https://github.com/HadrienGardeur","followers_url":"https://api.github.com/users/HadrienGardeur/followers","following_url":"https://api.github.com/users/HadrienGardeur/following{/other_user}","gists_url":"https://api.github.com/users/HadrienGardeur/gists{/gist_id}","starred_url":"https://api.github.com/users/HadrienGardeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadrienGardeur/subscriptions","organizations_url":"https://api.github.com/users/HadrienGardeur/orgs","repos_url":"https://api.github.com/users/HadrienGardeur/repos","events_url":"https://api.github.com/users/HadrienGardeur/events{/privacy}","received_events_url":"https://api.github.com/users/HadrienGardeur/received_events","type":"User","site_admin":false},"labels":[{"id":521843349,"node_id":"MDU6TGFiZWw1MjE4NDMzNDk=","url":"https://api.github.com/repos/readium/r2-streamer-swift/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-06-13T16:41:32Z","updated_at":"2018-07-07T21:06:48Z","closed_at":"2018-07-07T21:06:48Z","author_association":"NONE","body":"Based on the work on a new user settings model, we'll also need to start injecting them as well at a streamer level.\r\n\r\nAs far as I can tell, this will only be the case for non-FXL resources, which means that before anything is injected we'll need to check:\r\n- if a specific resource is marked as FXL (in `properties`)\r\n- if the overall publication is marked as FXL\r\n\r\nIf we don't have a link-level helper for that, this would be a good time to implement something (for instance `link.fxl?` that returns a boolean).\r\n\r\nOnce we've established that a resource is HTML and non-FXL, we can then proceed to injecting these user settings.\r\n\r\nI'll let @JayPanoz chime in on the best way of injecting these CSS Custom Properties but basically:\r\n- we'll use `name` for the CSS property name\r\n- and we'll use `value` for the CSS property value\r\n\r\nSerializing this to CSS Custom Properties should be fairly trivial."}}
{"actor":{"display_login":"aferditamuriqi"}}