{"action":"created","issue":{"url":"https://api.github.com/repos/Blazemeter/apiritif/issues/14","repository_url":"https://api.github.com/repos/Blazemeter/apiritif","labels_url":"https://api.github.com/repos/Blazemeter/apiritif/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/Blazemeter/apiritif/issues/14/comments","events_url":"https://api.github.com/repos/Blazemeter/apiritif/issues/14/events","html_url":"https://github.com/Blazemeter/apiritif/pull/14","id":316506227,"number":14,"title":"Variables templating","user":{"login":"3dgiordano","id":797057,"avatar_url":"https://avatars3.githubusercontent.com/u/797057?v=4","gravatar_id":"","url":"https://api.github.com/users/3dgiordano","html_url":"https://github.com/3dgiordano","followers_url":"https://api.github.com/users/3dgiordano/followers","following_url":"https://api.github.com/users/3dgiordano/following{/other_user}","gists_url":"https://api.github.com/users/3dgiordano/gists{/gist_id}","starred_url":"https://api.github.com/users/3dgiordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3dgiordano/subscriptions","organizations_url":"https://api.github.com/users/3dgiordano/orgs","repos_url":"https://api.github.com/users/3dgiordano/repos","events_url":"https://api.github.com/users/3dgiordano/events{/privacy}","received_events_url":"https://api.github.com/users/3dgiordano/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-21T16:39:39Z","updated_at":"2018-04-27T18:54:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Blazemeter/apiritif/pulls/14","html_url":"https://github.com/Blazemeter/apiritif/pull/14","diff_url":"https://github.com/Blazemeter/apiritif/pull/14.diff","patch_url":"https://github.com/Blazemeter/apiritif/pull/14.patch"},"body":"Hi guys\r\n\r\nI am working on a proposal to incorporate the use of variables into selenium, which can also be used with apiritif in the rest of the functionalities in the future.\r\n\r\nI show you an example of use\r\n\r\nimport apiritif\r\n\r\napiritif.variables = {\"h\": \"Hello\", \"w\": \"World\"}\r\nprint(apiritif.apply(\"${h} ${w}! ${no_match_and_is_ok}\"))\r\n\r\nI used to have a version with the same approach of generating the variable \"vars\" in a global way, but when trying to go to the next level, manipulating them generated a code too verbose, and I opted for this approach that allows to hide complexity and generate simpler code.\r\n\r\nIf the proposal is accepted, I will be able to continue with the improvements that I intend to propose to the generation of selenium with nose using the new apiritif, and we could incorporate the improvements to the apiritif code generator.\r\n"},"comment":{"url":"https://api.github.com/repos/Blazemeter/apiritif/issues/comments/385062434","html_url":"https://github.com/Blazemeter/apiritif/pull/14#issuecomment-385062434","issue_url":"https://api.github.com/repos/Blazemeter/apiritif/issues/14","id":385062434,"user":{"login":"3dgiordano","id":797057,"avatar_url":"https://avatars3.githubusercontent.com/u/797057?v=4","gravatar_id":"","url":"https://api.github.com/users/3dgiordano","html_url":"https://github.com/3dgiordano","followers_url":"https://api.github.com/users/3dgiordano/followers","following_url":"https://api.github.com/users/3dgiordano/following{/other_user}","gists_url":"https://api.github.com/users/3dgiordano/gists{/gist_id}","starred_url":"https://api.github.com/users/3dgiordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3dgiordano/subscriptions","organizations_url":"https://api.github.com/users/3dgiordano/orgs","repos_url":"https://api.github.com/users/3dgiordano/repos","events_url":"https://api.github.com/users/3dgiordano/events{/privacy}","received_events_url":"https://api.github.com/users/3dgiordano/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T18:54:10Z","updated_at":"2018-04-27T18:54:10Z","author_association":"NONE","body":"Hi @undera \r\nThank you for your comments\r\n\r\nI agree with apiritif as a library, I am not saying otherwise. If you think the proposal is not right, simply tell me what I should take into consideration to collaborate with ideas with all of you.\r\n\r\nI find it very good in what @greyfenrir is working on, maybe what I have done can supplement or collaborate with the work they are doing and we can do something together without generating friction.\r\n\r\nCurrently there is no forum or slack for developers and collaborators to taurus (that I know), the current seems more assigned to user support. \r\nIf there is one, maybe it would be good to incorporate it into the development guide.\r\nhttps://github.com/Blazemeter/taurus/blob/master/site/dat/docs/DeveloperGuide.md\r\nAs in other communities, it is necessary to have a place where developers can communicate and collaborate with each other.\r\n\r\nRelated to the commands, no problem, each change will have its PR and each one its associated documentation and changelog (as in my previous collaborations).\r\n \r\nRelated to the overlap, it's not a problem for me, my job is to create quick prototypes of things not planned or implemented. The ideas that evolve, I have to collaborate to the source (rewrite and create proposals, can be accepted or not, I have it clear and that is beyond of my control)\r\n\r\nPlease, tell me how I can help, how I can communicate with all devs in a better way to collaborate and not generate friction.\r\n"}}
{"actor":{"display_login":"3dgiordano"}}