{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/nrf-rs/nrf52/pulls/5","id":211310686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzEwNjg2","html_url":"https://github.com/nrf-rs/nrf52/pull/5","diff_url":"https://github.com/nrf-rs/nrf52/pull/5.diff","patch_url":"https://github.com/nrf-rs/nrf52/pull/5.patch","issue_url":"https://api.github.com/repos/nrf-rs/nrf52/issues/5","number":5,"state":"closed","locked":false,"title":"add nrf52-hal-common crate","user":{"login":"wez","id":117777,"node_id":"MDQ6VXNlcjExNzc3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/117777?v=4","gravatar_id":"","url":"https://api.github.com/users/wez","html_url":"https://github.com/wez","followers_url":"https://api.github.com/users/wez/followers","following_url":"https://api.github.com/users/wez/following{/other_user}","gists_url":"https://api.github.com/users/wez/gists{/gist_id}","starred_url":"https://api.github.com/users/wez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wez/subscriptions","organizations_url":"https://api.github.com/users/wez/orgs","repos_url":"https://api.github.com/users/wez/repos","events_url":"https://api.github.com/users/wez/events{/privacy}","received_events_url":"https://api.github.com/users/wez/received_events","type":"User","site_admin":false},"body":"This commit takes what I believe to be the lowest maintenance approach\r\nto sharing a common implementation between two device crates.\r\n\r\nThe common crate has a set of features that cause the underlying\r\nsvd2rust generated device crate to be imported as `target_device`.\r\nThe implementation in that crate then targets `target_device` rather\r\nthan directly using either `nrf52` or `nrf523840`.\r\n\r\nThis avoids littering the module with conditional code and/or macros.\r\n\r\nThe consuming hal crates re-export the items from the common crate\r\nand augment with any other additional functionality.\r\n\r\nOne downside to this approach is that the `nrf-hal-common` crate cannot\r\nbe successfully compiled when multiple targets are built.  This is\r\nfine in practice but does mean that building in a workspace will\r\nfail when that workspace enables multiple devices.\r\n\r\nFor that reason this commit adjusts the travis config to build the\r\ncrates individually.\r\n\r\nRefs: https://github.com/jamesmunns/nrf52-hal/issues/9","created_at":"2018-08-28T06:07:05Z","updated_at":"2018-09-13T09:36:55Z","closed_at":"2018-09-13T09:36:55Z","merged_at":"2018-09-13T09:36:55Z","merge_commit_sha":"68628abfe9dec4c01e9d9a74cd471c66a0ad2425","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jscarrott","id":1215953,"node_id":"MDQ6VXNlcjEyMTU5NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1215953?v=4","gravatar_id":"","url":"https://api.github.com/users/jscarrott","html_url":"https://github.com/jscarrott","followers_url":"https://api.github.com/users/jscarrott/followers","following_url":"https://api.github.com/users/jscarrott/following{/other_user}","gists_url":"https://api.github.com/users/jscarrott/gists{/gist_id}","starred_url":"https://api.github.com/users/jscarrott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jscarrott/subscriptions","organizations_url":"https://api.github.com/users/jscarrott/orgs","repos_url":"https://api.github.com/users/jscarrott/repos","events_url":"https://api.github.com/users/jscarrott/events{/privacy}","received_events_url":"https://api.github.com/users/jscarrott/received_events","type":"User","site_admin":false},{"login":"jamesmunns","id":2097964,"node_id":"MDQ6VXNlcjIwOTc5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2097964?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmunns","html_url":"https://github.com/jamesmunns","followers_url":"https://api.github.com/users/jamesmunns/followers","following_url":"https://api.github.com/users/jamesmunns/following{/other_user}","gists_url":"https://api.github.com/users/jamesmunns/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmunns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmunns/subscriptions","organizations_url":"https://api.github.com/users/jamesmunns/orgs","repos_url":"https://api.github.com/users/jamesmunns/repos","events_url":"https://api.github.com/users/jamesmunns/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmunns/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nrf-rs/nrf52/pulls/5/commits","review_comments_url":"https://api.github.com/repos/nrf-rs/nrf52/pulls/5/comments","review_comment_url":"https://api.github.com/repos/nrf-rs/nrf52/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nrf-rs/nrf52/issues/5/comments","statuses_url":"https://api.github.com/repos/nrf-rs/nrf52/statuses/99e0d8a31b94f66a09154a627a4bfee272f9139a","head":{"label":"nrf-rs:common","ref":"common","sha":"99e0d8a31b94f66a09154a627a4bfee272f9139a","user":{"login":"nrf-rs","id":42665441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjY1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/42665441?v=4","gravatar_id":"","url":"https://api.github.com/users/nrf-rs","html_url":"https://github.com/nrf-rs","followers_url":"https://api.github.com/users/nrf-rs/followers","following_url":"https://api.github.com/users/nrf-rs/following{/other_user}","gists_url":"https://api.github.com/users/nrf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/nrf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrf-rs/subscriptions","organizations_url":"https://api.github.com/users/nrf-rs/orgs","repos_url":"https://api.github.com/users/nrf-rs/repos","events_url":"https://api.github.com/users/nrf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/nrf-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":145948665,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5NDg2NjU=","name":"nrf52","full_name":"nrf-rs/nrf52","owner":{"login":"nrf-rs","id":42665441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjY1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/42665441?v=4","gravatar_id":"","url":"https://api.github.com/users/nrf-rs","html_url":"https://github.com/nrf-rs","followers_url":"https://api.github.com/users/nrf-rs/followers","following_url":"https://api.github.com/users/nrf-rs/following{/other_user}","gists_url":"https://api.github.com/users/nrf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/nrf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrf-rs/subscriptions","organizations_url":"https://api.github.com/users/nrf-rs/orgs","repos_url":"https://api.github.com/users/nrf-rs/repos","events_url":"https://api.github.com/users/nrf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/nrf-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nrf-rs/nrf52","description":"A Rust HAL for the nrf52 family of devices","fork":false,"url":"https://api.github.com/repos/nrf-rs/nrf52","forks_url":"https://api.github.com/repos/nrf-rs/nrf52/forks","keys_url":"https://api.github.com/repos/nrf-rs/nrf52/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrf-rs/nrf52/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrf-rs/nrf52/teams","hooks_url":"https://api.github.com/repos/nrf-rs/nrf52/hooks","issue_events_url":"https://api.github.com/repos/nrf-rs/nrf52/issues/events{/number}","events_url":"https://api.github.com/repos/nrf-rs/nrf52/events","assignees_url":"https://api.github.com/repos/nrf-rs/nrf52/assignees{/user}","branches_url":"https://api.github.com/repos/nrf-rs/nrf52/branches{/branch}","tags_url":"https://api.github.com/repos/nrf-rs/nrf52/tags","blobs_url":"https://api.github.com/repos/nrf-rs/nrf52/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrf-rs/nrf52/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrf-rs/nrf52/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrf-rs/nrf52/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrf-rs/nrf52/statuses/{sha}","languages_url":"https://api.github.com/repos/nrf-rs/nrf52/languages","stargazers_url":"https://api.github.com/repos/nrf-rs/nrf52/stargazers","contributors_url":"https://api.github.com/repos/nrf-rs/nrf52/contributors","subscribers_url":"https://api.github.com/repos/nrf-rs/nrf52/subscribers","subscription_url":"https://api.github.com/repos/nrf-rs/nrf52/subscription","commits_url":"https://api.github.com/repos/nrf-rs/nrf52/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrf-rs/nrf52/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrf-rs/nrf52/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrf-rs/nrf52/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrf-rs/nrf52/contents/{+path}","compare_url":"https://api.github.com/repos/nrf-rs/nrf52/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrf-rs/nrf52/merges","archive_url":"https://api.github.com/repos/nrf-rs/nrf52/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrf-rs/nrf52/downloads","issues_url":"https://api.github.com/repos/nrf-rs/nrf52/issues{/number}","pulls_url":"https://api.github.com/repos/nrf-rs/nrf52/pulls{/number}","milestones_url":"https://api.github.com/repos/nrf-rs/nrf52/milestones{/number}","notifications_url":"https://api.github.com/repos/nrf-rs/nrf52/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrf-rs/nrf52/labels{/name}","releases_url":"https://api.github.com/repos/nrf-rs/nrf52/releases{/id}","deployments_url":"https://api.github.com/repos/nrf-rs/nrf52/deployments","created_at":"2018-08-24T05:58:32Z","updated_at":"2018-09-12T13:30:29Z","pushed_at":"2018-09-13T09:36:55Z","git_url":"git://github.com/nrf-rs/nrf52.git","ssh_url":"git@github.com:nrf-rs/nrf52.git","clone_url":"https://github.com/nrf-rs/nrf52.git","svn_url":"https://github.com/nrf-rs/nrf52","homepage":null,"size":69,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":13,"watchers":2,"default_branch":"master"}},"base":{"label":"nrf-rs:master","ref":"master","sha":"49b06a5cbbc655a1a795cd765abd972ba7c71d0b","user":{"login":"nrf-rs","id":42665441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjY1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/42665441?v=4","gravatar_id":"","url":"https://api.github.com/users/nrf-rs","html_url":"https://github.com/nrf-rs","followers_url":"https://api.github.com/users/nrf-rs/followers","following_url":"https://api.github.com/users/nrf-rs/following{/other_user}","gists_url":"https://api.github.com/users/nrf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/nrf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrf-rs/subscriptions","organizations_url":"https://api.github.com/users/nrf-rs/orgs","repos_url":"https://api.github.com/users/nrf-rs/repos","events_url":"https://api.github.com/users/nrf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/nrf-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":145948665,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5NDg2NjU=","name":"nrf52","full_name":"nrf-rs/nrf52","owner":{"login":"nrf-rs","id":42665441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjY1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/42665441?v=4","gravatar_id":"","url":"https://api.github.com/users/nrf-rs","html_url":"https://github.com/nrf-rs","followers_url":"https://api.github.com/users/nrf-rs/followers","following_url":"https://api.github.com/users/nrf-rs/following{/other_user}","gists_url":"https://api.github.com/users/nrf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/nrf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrf-rs/subscriptions","organizations_url":"https://api.github.com/users/nrf-rs/orgs","repos_url":"https://api.github.com/users/nrf-rs/repos","events_url":"https://api.github.com/users/nrf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/nrf-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nrf-rs/nrf52","description":"A Rust HAL for the nrf52 family of devices","fork":false,"url":"https://api.github.com/repos/nrf-rs/nrf52","forks_url":"https://api.github.com/repos/nrf-rs/nrf52/forks","keys_url":"https://api.github.com/repos/nrf-rs/nrf52/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrf-rs/nrf52/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrf-rs/nrf52/teams","hooks_url":"https://api.github.com/repos/nrf-rs/nrf52/hooks","issue_events_url":"https://api.github.com/repos/nrf-rs/nrf52/issues/events{/number}","events_url":"https://api.github.com/repos/nrf-rs/nrf52/events","assignees_url":"https://api.github.com/repos/nrf-rs/nrf52/assignees{/user}","branches_url":"https://api.github.com/repos/nrf-rs/nrf52/branches{/branch}","tags_url":"https://api.github.com/repos/nrf-rs/nrf52/tags","blobs_url":"https://api.github.com/repos/nrf-rs/nrf52/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrf-rs/nrf52/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrf-rs/nrf52/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrf-rs/nrf52/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrf-rs/nrf52/statuses/{sha}","languages_url":"https://api.github.com/repos/nrf-rs/nrf52/languages","stargazers_url":"https://api.github.com/repos/nrf-rs/nrf52/stargazers","contributors_url":"https://api.github.com/repos/nrf-rs/nrf52/contributors","subscribers_url":"https://api.github.com/repos/nrf-rs/nrf52/subscribers","subscription_url":"https://api.github.com/repos/nrf-rs/nrf52/subscription","commits_url":"https://api.github.com/repos/nrf-rs/nrf52/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrf-rs/nrf52/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrf-rs/nrf52/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrf-rs/nrf52/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrf-rs/nrf52/contents/{+path}","compare_url":"https://api.github.com/repos/nrf-rs/nrf52/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrf-rs/nrf52/merges","archive_url":"https://api.github.com/repos/nrf-rs/nrf52/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrf-rs/nrf52/downloads","issues_url":"https://api.github.com/repos/nrf-rs/nrf52/issues{/number}","pulls_url":"https://api.github.com/repos/nrf-rs/nrf52/pulls{/number}","milestones_url":"https://api.github.com/repos/nrf-rs/nrf52/milestones{/number}","notifications_url":"https://api.github.com/repos/nrf-rs/nrf52/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrf-rs/nrf52/labels{/name}","releases_url":"https://api.github.com/repos/nrf-rs/nrf52/releases{/id}","deployments_url":"https://api.github.com/repos/nrf-rs/nrf52/deployments","created_at":"2018-08-24T05:58:32Z","updated_at":"2018-09-12T13:30:29Z","pushed_at":"2018-09-13T09:36:55Z","git_url":"git://github.com/nrf-rs/nrf52.git","ssh_url":"git@github.com:nrf-rs/nrf52.git","clone_url":"https://github.com/nrf-rs/nrf52.git","svn_url":"https://github.com/nrf-rs/nrf52","homepage":null,"size":69,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nrf-rs/nrf52/pulls/5"},"html":{"href":"https://github.com/nrf-rs/nrf52/pull/5"},"issue":{"href":"https://api.github.com/repos/nrf-rs/nrf52/issues/5"},"comments":{"href":"https://api.github.com/repos/nrf-rs/nrf52/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/nrf-rs/nrf52/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/nrf-rs/nrf52/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nrf-rs/nrf52/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/nrf-rs/nrf52/statuses/99e0d8a31b94f66a09154a627a4bfee272f9139a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hannobraun","id":85732,"node_id":"MDQ6VXNlcjg1NzMy","avatar_url":"https://avatars2.githubusercontent.com/u/85732?v=4","gravatar_id":"","url":"https://api.github.com/users/hannobraun","html_url":"https://github.com/hannobraun","followers_url":"https://api.github.com/users/hannobraun/followers","following_url":"https://api.github.com/users/hannobraun/following{/other_user}","gists_url":"https://api.github.com/users/hannobraun/gists{/gist_id}","starred_url":"https://api.github.com/users/hannobraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannobraun/subscriptions","organizations_url":"https://api.github.com/users/hannobraun/orgs","repos_url":"https://api.github.com/users/hannobraun/repos","events_url":"https://api.github.com/users/hannobraun/events{/privacy}","received_events_url":"https://api.github.com/users/hannobraun/received_events","type":"User","site_admin":false},"comments":4,"review_comments":9,"maintainer_can_modify":false,"commits":2,"additions":113,"deletions":704,"changed_files":18}}
{"actor":{"display_login":"hannobraun"}}