{"action":"closed","number":942,"pull_request":{"url":"https://api.github.com/repos/flowable/flowable-engine/pulls/942","id":178944723,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4OTQ0NzIz","html_url":"https://github.com/flowable/flowable-engine/pull/942","diff_url":"https://github.com/flowable/flowable-engine/pull/942.diff","patch_url":"https://github.com/flowable/flowable-engine/pull/942.patch","issue_url":"https://api.github.com/repos/flowable/flowable-engine/issues/942","number":942,"state":"closed","locked":false,"title":" Upgrade to Spring Framework 5.0.8 and Spring Security 5.0.7","user":{"login":"PascalSchumacher","id":2707245,"node_id":"MDQ6VXNlcjI3MDcyNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2707245?v=4","gravatar_id":"","url":"https://api.github.com/users/PascalSchumacher","html_url":"https://github.com/PascalSchumacher","followers_url":"https://api.github.com/users/PascalSchumacher/followers","following_url":"https://api.github.com/users/PascalSchumacher/following{/other_user}","gists_url":"https://api.github.com/users/PascalSchumacher/gists{/gist_id}","starred_url":"https://api.github.com/users/PascalSchumacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PascalSchumacher/subscriptions","organizations_url":"https://api.github.com/users/PascalSchumacher/orgs","repos_url":"https://api.github.com/users/PascalSchumacher/repos","events_url":"https://api.github.com/users/PascalSchumacher/events{/privacy}","received_events_url":"https://api.github.com/users/PascalSchumacher/received_events","type":"User","site_admin":false},"body":"To make this possible the Java Persistence API has to be updated to version 2.1. This in turn requires an update of Hibernate (5.2.16) and the replacement of OpenJPA with Hibernate because no version of OpenJPA supports API 2.1.\r\n\r\n`org.springframework.security.authentication.dao.SystemWideSaltSource` was removed in Spring Security 5, therefore `org.flowable.idm.spring.authentication.SpringSaltProvider` was removed.\r\n\r\n`org.springframework.security.crypto.password.PasswordEncoder` was removed in Spring Security 5, therefore its usage in `org.flowable.idm.spring.authentication.SpringEncoder` was removed.\r\n\r\nNative OpenJPA support was dropped in Spring 5, so the flowable-spring JPASpringTest test class was changed to use Hibernate instead.\r\n\r\nTo fix tests in flowable-content-rest and flowable-dmn-rest `NoOpPasswordEncoder` was added to the test configuration of these modules.\r\n\r\nFlowable-rest hibernate test dependencies were updated to match Hibernate-Core 5.2.16.\r\n\r\nMule does not support Spring Security 5 yet, so the Spring Security version was overridden to make tests pass.\r\n\r\nFlowable-jms-spring-executor was upgraded to JMS-API version 2.0.1, because Spring 5 requires JMS 2.0+.","created_at":"2018-04-02T22:03:16Z","updated_at":"2018-08-16T09:11:41Z","closed_at":"2018-08-16T09:11:41Z","merged_at":"2018-08-16T09:11:41Z","merge_commit_sha":"9d4fc9730a452e0c7e9585ec1f4bcef52b81b225","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flowable/flowable-engine/pulls/942/commits","review_comments_url":"https://api.github.com/repos/flowable/flowable-engine/pulls/942/comments","review_comment_url":"https://api.github.com/repos/flowable/flowable-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flowable/flowable-engine/issues/942/comments","statuses_url":"https://api.github.com/repos/flowable/flowable-engine/statuses/599e4a3359cdf2e5034094042bbf0802b526dcb2","head":{"label":"PascalSchumacher:update_to_spring_5","ref":"update_to_spring_5","sha":"599e4a3359cdf2e5034094042bbf0802b526dcb2","user":{"login":"PascalSchumacher","id":2707245,"node_id":"MDQ6VXNlcjI3MDcyNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2707245?v=4","gravatar_id":"","url":"https://api.github.com/users/PascalSchumacher","html_url":"https://github.com/PascalSchumacher","followers_url":"https://api.github.com/users/PascalSchumacher/followers","following_url":"https://api.github.com/users/PascalSchumacher/following{/other_user}","gists_url":"https://api.github.com/users/PascalSchumacher/gists{/gist_id}","starred_url":"https://api.github.com/users/PascalSchumacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PascalSchumacher/subscriptions","organizations_url":"https://api.github.com/users/PascalSchumacher/orgs","repos_url":"https://api.github.com/users/PascalSchumacher/repos","events_url":"https://api.github.com/users/PascalSchumacher/events{/privacy}","received_events_url":"https://api.github.com/users/PascalSchumacher/received_events","type":"User","site_admin":false},"repo":{"id":102761397,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3NjEzOTc=","name":"flowable-engine","full_name":"PascalSchumacher/flowable-engine","owner":{"login":"PascalSchumacher","id":2707245,"node_id":"MDQ6VXNlcjI3MDcyNDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2707245?v=4","gravatar_id":"","url":"https://api.github.com/users/PascalSchumacher","html_url":"https://github.com/PascalSchumacher","followers_url":"https://api.github.com/users/PascalSchumacher/followers","following_url":"https://api.github.com/users/PascalSchumacher/following{/other_user}","gists_url":"https://api.github.com/users/PascalSchumacher/gists{/gist_id}","starred_url":"https://api.github.com/users/PascalSchumacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PascalSchumacher/subscriptions","organizations_url":"https://api.github.com/users/PascalSchumacher/orgs","repos_url":"https://api.github.com/users/PascalSchumacher/repos","events_url":"https://api.github.com/users/PascalSchumacher/events{/privacy}","received_events_url":"https://api.github.com/users/PascalSchumacher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PascalSchumacher/flowable-engine","description":"A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.","fork":true,"url":"https://api.github.com/repos/PascalSchumacher/flowable-engine","forks_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/forks","keys_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/teams","hooks_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/hooks","issue_events_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/issues/events{/number}","events_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/events","assignees_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/assignees{/user}","branches_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/branches{/branch}","tags_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/tags","blobs_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/languages","stargazers_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/stargazers","contributors_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/contributors","subscribers_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/subscribers","subscription_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/subscription","commits_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/contents/{+path}","compare_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/merges","archive_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/downloads","issues_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/issues{/number}","pulls_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/labels{/name}","releases_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/releases{/id}","deployments_url":"https://api.github.com/repos/PascalSchumacher/flowable-engine/deployments","created_at":"2017-09-07T16:36:24Z","updated_at":"2018-05-28T11:06:49Z","pushed_at":"2018-08-15T19:23:48Z","git_url":"git://github.com/PascalSchumacher/flowable-engine.git","ssh_url":"git@github.com:PascalSchumacher/flowable-engine.git","clone_url":"https://github.com/PascalSchumacher/flowable-engine.git","svn_url":"https://github.com/PascalSchumacher/flowable-engine","homepage":"http://www.flowable.org","size":127738,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flowable:master","ref":"master","sha":"ac11540968cbec65de7ab13408d68a8287331cc0","user":{"login":"flowable","id":22557067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTU3MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/22557067?v=4","gravatar_id":"","url":"https://api.github.com/users/flowable","html_url":"https://github.com/flowable","followers_url":"https://api.github.com/users/flowable/followers","following_url":"https://api.github.com/users/flowable/following{/other_user}","gists_url":"https://api.github.com/users/flowable/gists{/gist_id}","starred_url":"https://api.github.com/users/flowable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowable/subscriptions","organizations_url":"https://api.github.com/users/flowable/orgs","repos_url":"https://api.github.com/users/flowable/repos","events_url":"https://api.github.com/users/flowable/events{/privacy}","received_events_url":"https://api.github.com/users/flowable/received_events","type":"Organization","site_admin":false},"repo":{"id":70780002,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc4MDAwMg==","name":"flowable-engine","full_name":"flowable/flowable-engine","owner":{"login":"flowable","id":22557067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTU3MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/22557067?v=4","gravatar_id":"","url":"https://api.github.com/users/flowable","html_url":"https://github.com/flowable","followers_url":"https://api.github.com/users/flowable/followers","following_url":"https://api.github.com/users/flowable/following{/other_user}","gists_url":"https://api.github.com/users/flowable/gists{/gist_id}","starred_url":"https://api.github.com/users/flowable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flowable/subscriptions","organizations_url":"https://api.github.com/users/flowable/orgs","repos_url":"https://api.github.com/users/flowable/repos","events_url":"https://api.github.com/users/flowable/events{/privacy}","received_events_url":"https://api.github.com/users/flowable/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flowable/flowable-engine","description":"A compact and highly efficient workflow and Business Process Management (BPM) platform for developers, system admins and business users.","fork":false,"url":"https://api.github.com/repos/flowable/flowable-engine","forks_url":"https://api.github.com/repos/flowable/flowable-engine/forks","keys_url":"https://api.github.com/repos/flowable/flowable-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flowable/flowable-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flowable/flowable-engine/teams","hooks_url":"https://api.github.com/repos/flowable/flowable-engine/hooks","issue_events_url":"https://api.github.com/repos/flowable/flowable-engine/issues/events{/number}","events_url":"https://api.github.com/repos/flowable/flowable-engine/events","assignees_url":"https://api.github.com/repos/flowable/flowable-engine/assignees{/user}","branches_url":"https://api.github.com/repos/flowable/flowable-engine/branches{/branch}","tags_url":"https://api.github.com/repos/flowable/flowable-engine/tags","blobs_url":"https://api.github.com/repos/flowable/flowable-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flowable/flowable-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flowable/flowable-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flowable/flowable-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flowable/flowable-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flowable/flowable-engine/languages","stargazers_url":"https://api.github.com/repos/flowable/flowable-engine/stargazers","contributors_url":"https://api.github.com/repos/flowable/flowable-engine/contributors","subscribers_url":"https://api.github.com/repos/flowable/flowable-engine/subscribers","subscription_url":"https://api.github.com/repos/flowable/flowable-engine/subscription","commits_url":"https://api.github.com/repos/flowable/flowable-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flowable/flowable-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flowable/flowable-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flowable/flowable-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flowable/flowable-engine/contents/{+path}","compare_url":"https://api.github.com/repos/flowable/flowable-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flowable/flowable-engine/merges","archive_url":"https://api.github.com/repos/flowable/flowable-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flowable/flowable-engine/downloads","issues_url":"https://api.github.com/repos/flowable/flowable-engine/issues{/number}","pulls_url":"https://api.github.com/repos/flowable/flowable-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flowable/flowable-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flowable/flowable-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flowable/flowable-engine/labels{/name}","releases_url":"https://api.github.com/repos/flowable/flowable-engine/releases{/id}","deployments_url":"https://api.github.com/repos/flowable/flowable-engine/deployments","created_at":"2016-10-13T07:21:43Z","updated_at":"2018-08-16T02:17:08Z","pushed_at":"2018-08-16T09:11:41Z","git_url":"git://github.com/flowable/flowable-engine.git","ssh_url":"git@github.com:flowable/flowable-engine.git","clone_url":"https://github.com/flowable/flowable-engine.git","svn_url":"https://github.com/flowable/flowable-engine","homepage":"https://www.flowable.org","size":128268,"stargazers_count":962,"watchers_count":962,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":350,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":350,"open_issues":100,"watchers":962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flowable/flowable-engine/pulls/942"},"html":{"href":"https://github.com/flowable/flowable-engine/pull/942"},"issue":{"href":"https://api.github.com/repos/flowable/flowable-engine/issues/942"},"comments":{"href":"https://api.github.com/repos/flowable/flowable-engine/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/flowable/flowable-engine/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/flowable/flowable-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flowable/flowable-engine/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/flowable/flowable-engine/statuses/599e4a3359cdf2e5034094042bbf0802b526dcb2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"filiphr","id":6012094,"node_id":"MDQ6VXNlcjYwMTIwOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6012094?v=4","gravatar_id":"","url":"https://api.github.com/users/filiphr","html_url":"https://github.com/filiphr","followers_url":"https://api.github.com/users/filiphr/followers","following_url":"https://api.github.com/users/filiphr/following{/other_user}","gists_url":"https://api.github.com/users/filiphr/gists{/gist_id}","starred_url":"https://api.github.com/users/filiphr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiphr/subscriptions","organizations_url":"https://api.github.com/users/filiphr/orgs","repos_url":"https://api.github.com/users/filiphr/repos","events_url":"https://api.github.com/users/filiphr/events{/privacy}","received_events_url":"https://api.github.com/users/filiphr/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":164,"deletions":245,"changed_files":32}}
{"actor":{"display_login":"filiphr"}}