{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/169476676","pull_request_review_id":98009165,"id":169476676,"diff_hunk":"@@ -52,7 +58,298 @@ def profiler_set_state(state='stop'):\n     state2int = {'stop': 0, 'run': 1}\n     check_call(_LIB.MXSetProfilerState(ctypes.c_int(state2int[state])))\n \n-def dump_profile():","path":"python/mxnet/profiler.py","position":53,"original_position":53,"commit_id":"73f0642499a609c17e73e9d3fba7d1b8f181e556","original_commit_id":"02ff4fc86ce70d8536c7372da9509a9c9aae2fe8","user":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars1.githubusercontent.com/u/11234557?v=4","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-02-20T22:09:51Z","updated_at":"2018-02-20T22:09:51Z","html_url":"https://github.com/apache/incubator-mxnet/pull/8972#discussion_r169476676","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/169476676"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/8972#discussion_r169476676"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972"}},"in_reply_to_id":168574121},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972","id":156828753,"html_url":"https://github.com/apache/incubator-mxnet/pull/8972","diff_url":"https://github.com/apache/incubator-mxnet/pull/8972.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/8972.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/8972","number":8972,"state":"open","locked":false,"title":"Profiling enhancements, python API, vtune and chrome tracing objects, etc.","user":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars1.githubusercontent.com/u/11234557?v=4","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"body":"@piiswrong \r\n@tqchen \r\n## Description ##\r\n\r\n1. Continuous, asynchronous profile dumping\r\n\r\n2. VTune objects: Counter, Task, Event, Frame, Instant-Mark (see screen shot)\r\n  - All available from C++ and python \r\n  - Equivalents also available in chrome://tracing screen (see screen shot)\r\n  - With Vtune, you get separate call stack paths for events and tasks, including hot spots down to the line of code\r\n\r\n3. Memory usage profiling (CPU and GPU)\r\n\r\n4. C API Profiling\r\n\r\n5. Individual Operator Profiling\r\n\r\n6. More granular profiling config (Symbolic ops, All ops, API, Memory, etc)\r\n\r\n7. VTune profiling tools\r\n\r\nScreen shots:\r\n\r\nVTune (note API domain/task grouping, operator task grouping, API and memory counters, etc.)\r\n![vtune](https://user-images.githubusercontent.com/11234557/33683094-984f8960-da7e-11e7-8c9e-9bd91a054a5d.png)\r\n\r\nChrome tracing:  (note category/API grouping, operator grouping, API and memory counters, etc.)\r\n![chrome_tracing](https://user-images.githubusercontent.com/11234557/33683128-b0ccc9b2-da7e-11e7-98f2-4d121f2f76af.png)\r\n\r\n![zoomchrome](https://user-images.githubusercontent.com/11234557/33686946-579e58e4-da8b-11e7-82c7-d4d797c61fdc.png)\r\n\r\n## Checklist ##\r\n### Essentials ###\r\n- [ ] Passed code style checking (`make lint`)\r\n- [ ] Changes are complete (i.e. I finished coding on this PR)\r\n- [ ] All changes have test coverage\r\n- [ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. \r\n- [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [ ] Feature1, tests, (and when applicable, API doc)\r\n- [ ] Feature2, tests, (and when applicable, API doc)\r\n\r\n## Comments ##\r\n- If this change is a backward incompatible change, why must this change be made.\r\n- Interesting edge cases to note here\r\n","created_at":"2017-12-06T20:15:38Z","updated_at":"2018-02-20T22:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69eabee13ea7ef00a900857b0b1af08bcf465477","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yzhliu","id":631860,"avatar_url":"https://avatars1.githubusercontent.com/u/631860?v=4","gravatar_id":"","url":"https://api.github.com/users/yzhliu","html_url":"https://github.com/yzhliu","followers_url":"https://api.github.com/users/yzhliu/followers","following_url":"https://api.github.com/users/yzhliu/following{/other_user}","gists_url":"https://api.github.com/users/yzhliu/gists{/gist_id}","starred_url":"https://api.github.com/users/yzhliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yzhliu/subscriptions","organizations_url":"https://api.github.com/users/yzhliu/orgs","repos_url":"https://api.github.com/users/yzhliu/repos","events_url":"https://api.github.com/users/yzhliu/events{/privacy}","received_events_url":"https://api.github.com/users/yzhliu/received_events","type":"User","site_admin":false},{"login":"thirdwing","id":1547093,"avatar_url":"https://avatars2.githubusercontent.com/u/1547093?v=4","gravatar_id":"","url":"https://api.github.com/users/thirdwing","html_url":"https://github.com/thirdwing","followers_url":"https://api.github.com/users/thirdwing/followers","following_url":"https://api.github.com/users/thirdwing/following{/other_user}","gists_url":"https://api.github.com/users/thirdwing/gists{/gist_id}","starred_url":"https://api.github.com/users/thirdwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thirdwing/subscriptions","organizations_url":"https://api.github.com/users/thirdwing/orgs","repos_url":"https://api.github.com/users/thirdwing/repos","events_url":"https://api.github.com/users/thirdwing/events{/privacy}","received_events_url":"https://api.github.com/users/thirdwing/received_events","type":"User","site_admin":false},{"login":"szha","id":2626883,"avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/apache/incubator-mxnet/milestones/2","html_url":"https://github.com/apache/incubator-mxnet/milestone/2","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones/2/labels","id":1779345,"number":2,"title":"v0.7.1","description":null,"creator":{"login":"tqchen","id":2577440,"avatar_url":"https://avatars3.githubusercontent.com/u/2577440?v=4","gravatar_id":"","url":"https://api.github.com/users/tqchen","html_url":"https://github.com/tqchen","followers_url":"https://api.github.com/users/tqchen/followers","following_url":"https://api.github.com/users/tqchen/following{/other_user}","gists_url":"https://api.github.com/users/tqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tqchen/subscriptions","organizations_url":"https://api.github.com/users/tqchen/orgs","repos_url":"https://api.github.com/users/tqchen/repos","events_url":"https://api.github.com/users/tqchen/events{/privacy}","received_events_url":"https://api.github.com/users/tqchen/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2016-05-20T17:17:24Z","updated_at":"2018-01-26T21:27:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/8972/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/73f0642499a609c17e73e9d3fba7d1b8f181e556","head":{"label":"cjolivier01:profile","ref":"profile","sha":"73f0642499a609c17e73e9d3fba7d1b8f181e556","user":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars1.githubusercontent.com/u/11234557?v=4","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"repo":{"id":86836111,"name":"mxnet","full_name":"cjolivier01/mxnet","owner":{"login":"cjolivier01","id":11234557,"avatar_url":"https://avatars1.githubusercontent.com/u/11234557?v=4","gravatar_id":"","url":"https://api.github.com/users/cjolivier01","html_url":"https://github.com/cjolivier01","followers_url":"https://api.github.com/users/cjolivier01/followers","following_url":"https://api.github.com/users/cjolivier01/following{/other_user}","gists_url":"https://api.github.com/users/cjolivier01/gists{/gist_id}","starred_url":"https://api.github.com/users/cjolivier01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjolivier01/subscriptions","organizations_url":"https://api.github.com/users/cjolivier01/orgs","repos_url":"https://api.github.com/users/cjolivier01/repos","events_url":"https://api.github.com/users/cjolivier01/events{/privacy}","received_events_url":"https://api.github.com/users/cjolivier01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjolivier01/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/cjolivier01/mxnet","forks_url":"https://api.github.com/repos/cjolivier01/mxnet/forks","keys_url":"https://api.github.com/repos/cjolivier01/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjolivier01/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjolivier01/mxnet/teams","hooks_url":"https://api.github.com/repos/cjolivier01/mxnet/hooks","issue_events_url":"https://api.github.com/repos/cjolivier01/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/cjolivier01/mxnet/events","assignees_url":"https://api.github.com/repos/cjolivier01/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/cjolivier01/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/cjolivier01/mxnet/tags","blobs_url":"https://api.github.com/repos/cjolivier01/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjolivier01/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjolivier01/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjolivier01/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjolivier01/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/cjolivier01/mxnet/languages","stargazers_url":"https://api.github.com/repos/cjolivier01/mxnet/stargazers","contributors_url":"https://api.github.com/repos/cjolivier01/mxnet/contributors","subscribers_url":"https://api.github.com/repos/cjolivier01/mxnet/subscribers","subscription_url":"https://api.github.com/repos/cjolivier01/mxnet/subscription","commits_url":"https://api.github.com/repos/cjolivier01/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjolivier01/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjolivier01/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjolivier01/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjolivier01/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/cjolivier01/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjolivier01/mxnet/merges","archive_url":"https://api.github.com/repos/cjolivier01/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjolivier01/mxnet/downloads","issues_url":"https://api.github.com/repos/cjolivier01/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/cjolivier01/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/cjolivier01/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/cjolivier01/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjolivier01/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/cjolivier01/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/cjolivier01/mxnet/deployments","created_at":"2017-03-31T15:52:37Z","updated_at":"2017-04-18T02:24:57Z","pushed_at":"2018-02-20T20:02:08Z","git_url":"git://github.com/cjolivier01/mxnet.git","ssh_url":"git@github.com:cjolivier01/mxnet.git","clone_url":"https://github.com/cjolivier01/mxnet.git","svn_url":"https://github.com/cjolivier01/mxnet","homepage":"http://mxnet.io","size":35375,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"af0c3b4e9bcb41734375470f965bba3c5731b1d0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-02-20T20:51:31Z","pushed_at":"2018-02-20T21:21:59Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"http://mxnet.io","size":33276,"stargazers_count":13105,"watchers_count":13105,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4818,"mirror_url":null,"archived":false,"open_issues_count":822,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4818,"open_issues":822,"watchers":13105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/8972"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/8972"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/8972/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8972/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/73f0642499a609c17e73e9d3fba7d1b8f181e556"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cjolivier01"}}