{"action":"closed","number":837,"pull_request":{"url":"https://api.github.com/repos/garris/BackstopJS/pulls/837","id":208114692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTE0Njky","html_url":"https://github.com/garris/BackstopJS/pull/837","diff_url":"https://github.com/garris/BackstopJS/pull/837.diff","patch_url":"https://github.com/garris/BackstopJS/pull/837.patch","issue_url":"https://api.github.com/repos/garris/BackstopJS/issues/837","number":837,"state":"closed","locked":false,"title":"Docker support on configuration file","user":{"login":"brendonbarreto","id":11650374,"node_id":"MDQ6VXNlcjExNjUwMzc0","avatar_url":"https://avatars2.githubusercontent.com/u/11650374?v=4","gravatar_id":"","url":"https://api.github.com/users/brendonbarreto","html_url":"https://github.com/brendonbarreto","followers_url":"https://api.github.com/users/brendonbarreto/followers","following_url":"https://api.github.com/users/brendonbarreto/following{/other_user}","gists_url":"https://api.github.com/users/brendonbarreto/gists{/gist_id}","starred_url":"https://api.github.com/users/brendonbarreto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendonbarreto/subscriptions","organizations_url":"https://api.github.com/users/brendonbarreto/orgs","repos_url":"https://api.github.com/users/brendonbarreto/repos","events_url":"https://api.github.com/users/brendonbarreto/events{/privacy}","received_events_url":"https://api.github.com/users/brendonbarreto/received_events","type":"User","site_admin":false},"body":"With this PR, user can run with docker by adding `docker: true` on configuration file. I don't know if this is the best solution but it worked for me. \r\n\r\n@garris The only difference between running with `--docker` and `docker: true` is this:\r\n\r\n```js\r\nconst passAlongArgs = process.argv\r\n                  .slice(3)\r\n                  .join('\" \"') // in case of spaces in a command\r\n                  .replace(/--docker/, '--moby');\r\n```\r\nThe `DOCKER_COMMAND` will be without `--moby`. Should I be worried about this?\r\n\r\nfixes https://github.com/garris/BackstopJS/issues/834","created_at":"2018-08-13T21:53:02Z","updated_at":"2018-08-15T10:15:10Z","closed_at":"2018-08-15T10:15:10Z","merged_at":null,"merge_commit_sha":"c195b2e05a8436b51884f2b2839fdfc6ce77effe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/garris/BackstopJS/pulls/837/commits","review_comments_url":"https://api.github.com/repos/garris/BackstopJS/pulls/837/comments","review_comment_url":"https://api.github.com/repos/garris/BackstopJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/garris/BackstopJS/issues/837/comments","statuses_url":"https://api.github.com/repos/garris/BackstopJS/statuses/7f56bd62b7ac24cea93a7c72be0d454d3c17d159","head":{"label":"brendonbarreto:docker-on-configuration-file","ref":"docker-on-configuration-file","sha":"7f56bd62b7ac24cea93a7c72be0d454d3c17d159","user":{"login":"brendonbarreto","id":11650374,"node_id":"MDQ6VXNlcjExNjUwMzc0","avatar_url":"https://avatars2.githubusercontent.com/u/11650374?v=4","gravatar_id":"","url":"https://api.github.com/users/brendonbarreto","html_url":"https://github.com/brendonbarreto","followers_url":"https://api.github.com/users/brendonbarreto/followers","following_url":"https://api.github.com/users/brendonbarreto/following{/other_user}","gists_url":"https://api.github.com/users/brendonbarreto/gists{/gist_id}","starred_url":"https://api.github.com/users/brendonbarreto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendonbarreto/subscriptions","organizations_url":"https://api.github.com/users/brendonbarreto/orgs","repos_url":"https://api.github.com/users/brendonbarreto/repos","events_url":"https://api.github.com/users/brendonbarreto/events{/privacy}","received_events_url":"https://api.github.com/users/brendonbarreto/received_events","type":"User","site_admin":false},"repo":{"id":144600514,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MDA1MTQ=","name":"BackstopJS","full_name":"brendonbarreto/BackstopJS","owner":{"login":"brendonbarreto","id":11650374,"node_id":"MDQ6VXNlcjExNjUwMzc0","avatar_url":"https://avatars2.githubusercontent.com/u/11650374?v=4","gravatar_id":"","url":"https://api.github.com/users/brendonbarreto","html_url":"https://github.com/brendonbarreto","followers_url":"https://api.github.com/users/brendonbarreto/followers","following_url":"https://api.github.com/users/brendonbarreto/following{/other_user}","gists_url":"https://api.github.com/users/brendonbarreto/gists{/gist_id}","starred_url":"https://api.github.com/users/brendonbarreto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendonbarreto/subscriptions","organizations_url":"https://api.github.com/users/brendonbarreto/orgs","repos_url":"https://api.github.com/users/brendonbarreto/repos","events_url":"https://api.github.com/users/brendonbarreto/events{/privacy}","received_events_url":"https://api.github.com/users/brendonbarreto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brendonbarreto/BackstopJS","description":"Catch CSS curve balls.","fork":true,"url":"https://api.github.com/repos/brendonbarreto/BackstopJS","forks_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/forks","keys_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/teams","hooks_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/hooks","issue_events_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/issues/events{/number}","events_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/events","assignees_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/assignees{/user}","branches_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/branches{/branch}","tags_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/tags","blobs_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/statuses/{sha}","languages_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/languages","stargazers_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/stargazers","contributors_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/contributors","subscribers_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/subscribers","subscription_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/subscription","commits_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/contents/{+path}","compare_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/merges","archive_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/downloads","issues_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/issues{/number}","pulls_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/pulls{/number}","milestones_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/milestones{/number}","notifications_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/labels{/name}","releases_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/releases{/id}","deployments_url":"https://api.github.com/repos/brendonbarreto/BackstopJS/deployments","created_at":"2018-08-13T15:43:31Z","updated_at":"2018-08-13T15:43:34Z","pushed_at":"2018-08-13T21:44:06Z","git_url":"git://github.com/brendonbarreto/BackstopJS.git","ssh_url":"git@github.com:brendonbarreto/BackstopJS.git","clone_url":"https://github.com/brendonbarreto/BackstopJS.git","svn_url":"https://github.com/brendonbarreto/BackstopJS","homepage":"","size":43985,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"garris:master","ref":"master","sha":"e4046dd2e291a25c60de16100fdcc010b5d04450","user":{"login":"garris","id":447033,"node_id":"MDQ6VXNlcjQ0NzAzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/447033?v=4","gravatar_id":"","url":"https://api.github.com/users/garris","html_url":"https://github.com/garris","followers_url":"https://api.github.com/users/garris/followers","following_url":"https://api.github.com/users/garris/following{/other_user}","gists_url":"https://api.github.com/users/garris/gists{/gist_id}","starred_url":"https://api.github.com/users/garris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garris/subscriptions","organizations_url":"https://api.github.com/users/garris/orgs","repos_url":"https://api.github.com/users/garris/repos","events_url":"https://api.github.com/users/garris/events{/privacy}","received_events_url":"https://api.github.com/users/garris/received_events","type":"User","site_admin":false},"repo":{"id":25268795,"node_id":"MDEwOlJlcG9zaXRvcnkyNTI2ODc5NQ==","name":"BackstopJS","full_name":"garris/BackstopJS","owner":{"login":"garris","id":447033,"node_id":"MDQ6VXNlcjQ0NzAzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/447033?v=4","gravatar_id":"","url":"https://api.github.com/users/garris","html_url":"https://github.com/garris","followers_url":"https://api.github.com/users/garris/followers","following_url":"https://api.github.com/users/garris/following{/other_user}","gists_url":"https://api.github.com/users/garris/gists{/gist_id}","starred_url":"https://api.github.com/users/garris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garris/subscriptions","organizations_url":"https://api.github.com/users/garris/orgs","repos_url":"https://api.github.com/users/garris/repos","events_url":"https://api.github.com/users/garris/events{/privacy}","received_events_url":"https://api.github.com/users/garris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garris/BackstopJS","description":"Catch CSS curve balls.","fork":false,"url":"https://api.github.com/repos/garris/BackstopJS","forks_url":"https://api.github.com/repos/garris/BackstopJS/forks","keys_url":"https://api.github.com/repos/garris/BackstopJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garris/BackstopJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garris/BackstopJS/teams","hooks_url":"https://api.github.com/repos/garris/BackstopJS/hooks","issue_events_url":"https://api.github.com/repos/garris/BackstopJS/issues/events{/number}","events_url":"https://api.github.com/repos/garris/BackstopJS/events","assignees_url":"https://api.github.com/repos/garris/BackstopJS/assignees{/user}","branches_url":"https://api.github.com/repos/garris/BackstopJS/branches{/branch}","tags_url":"https://api.github.com/repos/garris/BackstopJS/tags","blobs_url":"https://api.github.com/repos/garris/BackstopJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garris/BackstopJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garris/BackstopJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/garris/BackstopJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garris/BackstopJS/statuses/{sha}","languages_url":"https://api.github.com/repos/garris/BackstopJS/languages","stargazers_url":"https://api.github.com/repos/garris/BackstopJS/stargazers","contributors_url":"https://api.github.com/repos/garris/BackstopJS/contributors","subscribers_url":"https://api.github.com/repos/garris/BackstopJS/subscribers","subscription_url":"https://api.github.com/repos/garris/BackstopJS/subscription","commits_url":"https://api.github.com/repos/garris/BackstopJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/garris/BackstopJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/garris/BackstopJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/garris/BackstopJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/garris/BackstopJS/contents/{+path}","compare_url":"https://api.github.com/repos/garris/BackstopJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garris/BackstopJS/merges","archive_url":"https://api.github.com/repos/garris/BackstopJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garris/BackstopJS/downloads","issues_url":"https://api.github.com/repos/garris/BackstopJS/issues{/number}","pulls_url":"https://api.github.com/repos/garris/BackstopJS/pulls{/number}","milestones_url":"https://api.github.com/repos/garris/BackstopJS/milestones{/number}","notifications_url":"https://api.github.com/repos/garris/BackstopJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garris/BackstopJS/labels{/name}","releases_url":"https://api.github.com/repos/garris/BackstopJS/releases{/id}","deployments_url":"https://api.github.com/repos/garris/BackstopJS/deployments","created_at":"2014-10-15T18:56:07Z","updated_at":"2018-08-15T09:55:02Z","pushed_at":"2018-08-15T06:17:43Z","git_url":"git://github.com/garris/BackstopJS.git","ssh_url":"git@github.com:garris/BackstopJS.git","clone_url":"https://github.com/garris/BackstopJS.git","svn_url":"https://github.com/garris/BackstopJS","homepage":"","size":43850,"stargazers_count":3478,"watchers_count":3478,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":330,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":330,"open_issues":248,"watchers":3478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/garris/BackstopJS/pulls/837"},"html":{"href":"https://github.com/garris/BackstopJS/pull/837"},"issue":{"href":"https://api.github.com/repos/garris/BackstopJS/issues/837"},"comments":{"href":"https://api.github.com/repos/garris/BackstopJS/issues/837/comments"},"review_comments":{"href":"https://api.github.com/repos/garris/BackstopJS/pulls/837/comments"},"review_comment":{"href":"https://api.github.com/repos/garris/BackstopJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/garris/BackstopJS/pulls/837/commits"},"statuses":{"href":"https://api.github.com/repos/garris/BackstopJS/statuses/7f56bd62b7ac24cea93a7c72be0d454d3c17d159"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"brendonbarreto"}}