{"push_id":2487440645,"size":3,"distinct_size":1,"ref":"refs/heads/use-zendesk-155037639-2","head":"3fdac01a0d64fd014add4808e4349ea884ad2b9e","before":"a303fb5f88257d3f996659394cf770fde1fecc80","commits":[{"sha":"17d52f21f3efce9f6b5f7cab10a201d6df1948ff","author":{"name":"Hector Rivas Gandara","email":"6bc6982ad72571e22ef415a9cd638e7c6cc52469@digital.cabinet-office.gov.uk"},"message":"Move ContactUs form validation to a form object\n\nThis way we decouple the backend logic from the UI validation\nand it will be much easier add new backends, like zendesk.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-product-page/commits/17d52f21f3efce9f6b5f7cab10a201d6df1948ff"},{"sha":"5525ade8bf543f8d39ed916ba103c85a53e58caa","author":{"name":"Hector Rivas Gandara","email":"6bc6982ad72571e22ef415a9cd638e7c6cc52469@digital.cabinet-office.gov.uk"},"message":"Create contactus/signup tickets in Zendesk\n\nWe are planing to move from Deskpro to Zendesk and we want\nthe product page to create tickets in Zendesk.\n\nIn this commit we use the official Zendesk API ruby client[1].\n\nWe can use this library directly, no need for a model. The validation\nwill happen in each corresponding Form object.\n\nWe allow use one backend or other by checking the environment variable\n`USE_ZENDESK=true`. We can later decommission the Deskpro code as\nneeded.\n\nWe test both backends using rspec.shared_examples.\n\nWe additionally move the initialisation of the `ENV[]` variables to\nthe main `spec_helper.rb` file. Currently they are in the root\nscope for each file and change global variable, so they are\nactually executed multiple times when each file is loaded.\n\n[1] https://github.com/zendesk/zendesk_api_client_rb","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-product-page/commits/5525ade8bf543f8d39ed916ba103c85a53e58caa"},{"sha":"3fdac01a0d64fd014add4808e4349ea884ad2b9e","author":{"name":"Hector Rivas Gandara","email":"6bc6982ad72571e22ef415a9cd638e7c6cc52469@digital.cabinet-office.gov.uk"},"message":"Remove all the DeskPro references\n\nWe won't use it anymore","distinct":true,"url":"https://api.github.com/repos/alphagov/paas-product-page/commits/3fdac01a0d64fd014add4808e4349ea884ad2b9e"}]}
{"actor":{"display_login":"keymon"}}