{"action":"created","comment":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/comments/232937301","pull_request_review_id":174240642,"id":232937301,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjkzNzMwMQ==","diff_hunk":"@@ -220,10 +220,10 @@ protected function getContextualUrl($node, $context)\n             if ('collection' === $type && !$this->collectionsEnabled) {\n                 $type = 'record';\n             }\n-            $url = $this->getUrlFromRouteCache($type, $node->id);\n+            $url = $this->getUrlFromRouteCache($type, urlencode($node->id));","path":"module/VuFind/src/VuFind/Hierarchy/TreeRenderer/JSTree.php","position":null,"original_position":5,"commit_id":"b878b944f291eb449e72bc6de0eaebd15357ee0c","original_commit_id":"ab817461de0898a703b442e6326d0814722685cf","user":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"body":"Not intentional, I moved encoding to getUrlFromRouteCache.","created_at":"2018-11-13T08:34:23Z","updated_at":"2018-11-13T08:34:23Z","html_url":"https://github.com/vufind-org/vufind/pull/1266#discussion_r232937301","pull_request_url":"https://api.github.com/repos/vufind-org/vufind/pulls/1266","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/comments/232937301"},"html":{"href":"https://github.com/vufind-org/vufind/pull/1266#discussion_r232937301"},"pull_request":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1266"}},"in_reply_to_id":232687892},"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/1266","id":230065357,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDY1MzU3","html_url":"https://github.com/vufind-org/vufind/pull/1266","diff_url":"https://github.com/vufind-org/vufind/pull/1266.diff","patch_url":"https://github.com/vufind-org/vufind/pull/1266.patch","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/1266","number":1266,"state":"open","locked":false,"title":"Url encode record id in hierarchy tree links.","user":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-12T09:21:42Z","updated_at":"2018-11-13T08:34:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"328566b8fbf6b602c07012e40095d3a6311494df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vufind-org/vufind/pulls/1266/commits","review_comments_url":"https://api.github.com/repos/vufind-org/vufind/pulls/1266/comments","review_comment_url":"https://api.github.com/repos/vufind-org/vufind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/1266/comments","statuses_url":"https://api.github.com/repos/vufind-org/vufind/statuses/b878b944f291eb449e72bc6de0eaebd15357ee0c","head":{"label":"samuli:encode-record-id-in-hierachy-tree-links","ref":"encode-record-id-in-hierachy-tree-links","sha":"b878b944f291eb449e72bc6de0eaebd15357ee0c","user":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"repo":{"id":29350003,"node_id":"MDEwOlJlcG9zaXRvcnkyOTM1MDAwMw==","name":"NDL-VuFind2","full_name":"samuli/NDL-VuFind2","private":false,"owner":{"login":"samuli","id":3889,"node_id":"MDQ6VXNlcjM4ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/3889?v=4","gravatar_id":"","url":"https://api.github.com/users/samuli","html_url":"https://github.com/samuli","followers_url":"https://api.github.com/users/samuli/followers","following_url":"https://api.github.com/users/samuli/following{/other_user}","gists_url":"https://api.github.com/users/samuli/gists{/gist_id}","starred_url":"https://api.github.com/users/samuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuli/subscriptions","organizations_url":"https://api.github.com/users/samuli/orgs","repos_url":"https://api.github.com/users/samuli/repos","events_url":"https://api.github.com/users/samuli/events{/privacy}","received_events_url":"https://api.github.com/users/samuli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/samuli/NDL-VuFind2","description":"NDL VuFind 2 implementation, work in progress","fork":true,"url":"https://api.github.com/repos/samuli/NDL-VuFind2","forks_url":"https://api.github.com/repos/samuli/NDL-VuFind2/forks","keys_url":"https://api.github.com/repos/samuli/NDL-VuFind2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuli/NDL-VuFind2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuli/NDL-VuFind2/teams","hooks_url":"https://api.github.com/repos/samuli/NDL-VuFind2/hooks","issue_events_url":"https://api.github.com/repos/samuli/NDL-VuFind2/issues/events{/number}","events_url":"https://api.github.com/repos/samuli/NDL-VuFind2/events","assignees_url":"https://api.github.com/repos/samuli/NDL-VuFind2/assignees{/user}","branches_url":"https://api.github.com/repos/samuli/NDL-VuFind2/branches{/branch}","tags_url":"https://api.github.com/repos/samuli/NDL-VuFind2/tags","blobs_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuli/NDL-VuFind2/statuses/{sha}","languages_url":"https://api.github.com/repos/samuli/NDL-VuFind2/languages","stargazers_url":"https://api.github.com/repos/samuli/NDL-VuFind2/stargazers","contributors_url":"https://api.github.com/repos/samuli/NDL-VuFind2/contributors","subscribers_url":"https://api.github.com/repos/samuli/NDL-VuFind2/subscribers","subscription_url":"https://api.github.com/repos/samuli/NDL-VuFind2/subscription","commits_url":"https://api.github.com/repos/samuli/NDL-VuFind2/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuli/NDL-VuFind2/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuli/NDL-VuFind2/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuli/NDL-VuFind2/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuli/NDL-VuFind2/contents/{+path}","compare_url":"https://api.github.com/repos/samuli/NDL-VuFind2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuli/NDL-VuFind2/merges","archive_url":"https://api.github.com/repos/samuli/NDL-VuFind2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuli/NDL-VuFind2/downloads","issues_url":"https://api.github.com/repos/samuli/NDL-VuFind2/issues{/number}","pulls_url":"https://api.github.com/repos/samuli/NDL-VuFind2/pulls{/number}","milestones_url":"https://api.github.com/repos/samuli/NDL-VuFind2/milestones{/number}","notifications_url":"https://api.github.com/repos/samuli/NDL-VuFind2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuli/NDL-VuFind2/labels{/name}","releases_url":"https://api.github.com/repos/samuli/NDL-VuFind2/releases{/id}","deployments_url":"https://api.github.com/repos/samuli/NDL-VuFind2/deployments","created_at":"2015-01-16T13:42:11Z","updated_at":"2018-10-25T06:32:36Z","pushed_at":"2018-11-13T08:14:22Z","git_url":"git://github.com/samuli/NDL-VuFind2.git","ssh_url":"git@github.com:samuli/NDL-VuFind2.git","clone_url":"https://github.com/samuli/NDL-VuFind2.git","svn_url":"https://github.com/samuli/NDL-VuFind2","homepage":"","size":360186,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vufind-org:master","ref":"master","sha":"fdf7978e9878655c2f60174a0e4d323678c25262","user":{"login":"vufind-org","id":5072328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5072328?v=4","gravatar_id":"","url":"https://api.github.com/users/vufind-org","html_url":"https://github.com/vufind-org","followers_url":"https://api.github.com/users/vufind-org/followers","following_url":"https://api.github.com/users/vufind-org/following{/other_user}","gists_url":"https://api.github.com/users/vufind-org/gists{/gist_id}","starred_url":"https://api.github.com/users/vufind-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vufind-org/subscriptions","organizations_url":"https://api.github.com/users/vufind-org/orgs","repos_url":"https://api.github.com/users/vufind-org/repos","events_url":"https://api.github.com/users/vufind-org/events{/privacy}","received_events_url":"https://api.github.com/users/vufind-org/received_events","type":"Organization","site_admin":false},"repo":{"id":11680792,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MDc5Mg==","name":"vufind","full_name":"vufind-org/vufind","private":false,"owner":{"login":"vufind-org","id":5072328,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzIzMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5072328?v=4","gravatar_id":"","url":"https://api.github.com/users/vufind-org","html_url":"https://github.com/vufind-org","followers_url":"https://api.github.com/users/vufind-org/followers","following_url":"https://api.github.com/users/vufind-org/following{/other_user}","gists_url":"https://api.github.com/users/vufind-org/gists{/gist_id}","starred_url":"https://api.github.com/users/vufind-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vufind-org/subscriptions","organizations_url":"https://api.github.com/users/vufind-org/orgs","repos_url":"https://api.github.com/users/vufind-org/repos","events_url":"https://api.github.com/users/vufind-org/events{/privacy}","received_events_url":"https://api.github.com/users/vufind-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vufind-org/vufind","description":"A library resource discovery portal designed and developed for libraries by libraries","fork":false,"url":"https://api.github.com/repos/vufind-org/vufind","forks_url":"https://api.github.com/repos/vufind-org/vufind/forks","keys_url":"https://api.github.com/repos/vufind-org/vufind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vufind-org/vufind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vufind-org/vufind/teams","hooks_url":"https://api.github.com/repos/vufind-org/vufind/hooks","issue_events_url":"https://api.github.com/repos/vufind-org/vufind/issues/events{/number}","events_url":"https://api.github.com/repos/vufind-org/vufind/events","assignees_url":"https://api.github.com/repos/vufind-org/vufind/assignees{/user}","branches_url":"https://api.github.com/repos/vufind-org/vufind/branches{/branch}","tags_url":"https://api.github.com/repos/vufind-org/vufind/tags","blobs_url":"https://api.github.com/repos/vufind-org/vufind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vufind-org/vufind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vufind-org/vufind/git/refs{/sha}","trees_url":"https://api.github.com/repos/vufind-org/vufind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vufind-org/vufind/statuses/{sha}","languages_url":"https://api.github.com/repos/vufind-org/vufind/languages","stargazers_url":"https://api.github.com/repos/vufind-org/vufind/stargazers","contributors_url":"https://api.github.com/repos/vufind-org/vufind/contributors","subscribers_url":"https://api.github.com/repos/vufind-org/vufind/subscribers","subscription_url":"https://api.github.com/repos/vufind-org/vufind/subscription","commits_url":"https://api.github.com/repos/vufind-org/vufind/commits{/sha}","git_commits_url":"https://api.github.com/repos/vufind-org/vufind/git/commits{/sha}","comments_url":"https://api.github.com/repos/vufind-org/vufind/comments{/number}","issue_comment_url":"https://api.github.com/repos/vufind-org/vufind/issues/comments{/number}","contents_url":"https://api.github.com/repos/vufind-org/vufind/contents/{+path}","compare_url":"https://api.github.com/repos/vufind-org/vufind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vufind-org/vufind/merges","archive_url":"https://api.github.com/repos/vufind-org/vufind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vufind-org/vufind/downloads","issues_url":"https://api.github.com/repos/vufind-org/vufind/issues{/number}","pulls_url":"https://api.github.com/repos/vufind-org/vufind/pulls{/number}","milestones_url":"https://api.github.com/repos/vufind-org/vufind/milestones{/number}","notifications_url":"https://api.github.com/repos/vufind-org/vufind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vufind-org/vufind/labels{/name}","releases_url":"https://api.github.com/repos/vufind-org/vufind/releases{/id}","deployments_url":"https://api.github.com/repos/vufind-org/vufind/deployments","created_at":"2013-07-26T08:05:45Z","updated_at":"2018-11-09T17:59:09Z","pushed_at":"2018-11-13T08:14:23Z","git_url":"git://github.com/vufind-org/vufind.git","ssh_url":"git@github.com:vufind-org/vufind.git","clone_url":"https://github.com/vufind-org/vufind.git","svn_url":"https://github.com/vufind-org/vufind","homepage":null,"size":333423,"stargazers_count":154,"watchers_count":154,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":239,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":239,"open_issues":27,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1266"},"html":{"href":"https://github.com/vufind-org/vufind/pull/1266"},"issue":{"href":"https://api.github.com/repos/vufind-org/vufind/issues/1266"},"comments":{"href":"https://api.github.com/repos/vufind-org/vufind/issues/1266/comments"},"review_comments":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1266/comments"},"review_comment":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vufind-org/vufind/pulls/1266/commits"},"statuses":{"href":"https://api.github.com/repos/vufind-org/vufind/statuses/b878b944f291eb449e72bc6de0eaebd15357ee0c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samuli"}}