{"action":"created","issue":{"url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/214","repository_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3","labels_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/214/labels{/name}","comments_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/214/comments","events_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/214/events","html_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/214","id":330073576,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTcyNDY0","number":214,"title":"Updated JigsawSetupDialog's general tab according to new designs","user":{"login":"chrisryancombs","id":22353448,"node_id":"MDQ6VXNlcjIyMzUzNDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/22353448?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisryancombs","html_url":"https://github.com/chrisryancombs","followers_url":"https://api.github.com/users/chrisryancombs/followers","following_url":"https://api.github.com/users/chrisryancombs/following{/other_user}","gists_url":"https://api.github.com/users/chrisryancombs/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisryancombs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisryancombs/subscriptions","organizations_url":"https://api.github.com/users/chrisryancombs/orgs","repos_url":"https://api.github.com/users/chrisryancombs/repos","events_url":"https://api.github.com/users/chrisryancombs/events{/privacy}","received_events_url":"https://api.github.com/users/chrisryancombs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-07T00:06:30Z","updated_at":"2018-06-12T18:56:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/pulls/214","html_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/214","diff_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/214.diff","patch_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/214.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/comments/396697067","html_url":"https://github.com/USGS-Astrogeology/ISIS3/pull/214#issuecomment-396697067","issue_url":"https://api.github.com/repos/USGS-Astrogeology/ISIS3/issues/214","id":396697067,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjY5NzA2Nw==","user":{"login":"ihumphrey-usgs","id":22845804,"node_id":"MDQ6VXNlcjIyODQ1ODA0","avatar_url":"https://avatars1.githubusercontent.com/u/22845804?v=4","gravatar_id":"","url":"https://api.github.com/users/ihumphrey-usgs","html_url":"https://github.com/ihumphrey-usgs","followers_url":"https://api.github.com/users/ihumphrey-usgs/followers","following_url":"https://api.github.com/users/ihumphrey-usgs/following{/other_user}","gists_url":"https://api.github.com/users/ihumphrey-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ihumphrey-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihumphrey-usgs/subscriptions","organizations_url":"https://api.github.com/users/ihumphrey-usgs/orgs","repos_url":"https://api.github.com/users/ihumphrey-usgs/repos","events_url":"https://api.github.com/users/ihumphrey-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/ihumphrey-usgs/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T18:56:29Z","updated_at":"2018-06-12T18:56:29Z","author_association":"CONTRIBUTOR","body":"@chrisryancombs @kledmundson \r\n\r\n**High-level Review:**\r\n\r\nThe validators for **Global Apriori Point Sigmas** are a bit confusing.\r\nWhen you first open JigsawSetup, the two line edits for \"Latitude\" and \"Longitude\" are empty and have a white background.\r\nIf you put a huge number into \"Latitude\", it turns red (suggested an invalid value). The \"OK\" button at the bottom of the dialog becomes inactive and unclickable. \r\nIf you remove the number so that the dialog is empty again, it is still red, preventing the user from clicking \"OK\".\r\n\r\nThe above behavior occurs with all of the line edits for the \"General\" tab, except for the \"Output Control Net\" line edit. This could be confusing if the user sets a value and changes it to an invalid value, and they don't know why it's invalid (i.e. they don't know the valid ranges).\r\n\r\n---\r\n\r\nI'm not sure what the best solution is for this, but here are some ideas:\r\n* Have a tooltip (a hover text) that shows the allowable range for the line edits.\r\n* Have a tooltip that shows the default value for the line edits.\r\n* Have default values for some of the line edits:\r\n    * Does it make sense for all the the line edits to have default values? For example, is the default value of the \"Latitude\" line edit an unset value or 0.0 (or something like that)?\r\n* Consider changing the type of the line edits:\r\n    * Maximum iterations could be a QSpinBox\r\n    * Latitude / Longitude could be QDoubleSpinBox\r\n    * Outlier Rejection Sigma Multiplier could be a QDoubleSpinBox\r\n    * Maximum Likelihood Estimations could be QDoubleSpinBox\r\n    * etc. since QSpinBox can enforce ranges easily\r\n"}}
{"actor":{"display_login":"ihumphrey-usgs"}}