{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/5529","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/5529/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/5529/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/5529/events","html_url":"https://github.com/kubernetes/charts/pull/5529","id":322391361,"number":5529,"title":"stable/prometheus: restore headless svcs, reverting breaking change to the default values","user":{"login":"kujenga","id":4854867,"avatar_url":"https://avatars2.githubusercontent.com/u/4854867?v=4","gravatar_id":"","url":"https://api.github.com/users/kujenga","html_url":"https://github.com/kujenga","followers_url":"https://api.github.com/users/kujenga/followers","following_url":"https://api.github.com/users/kujenga/following{/other_user}","gists_url":"https://api.github.com/users/kujenga/gists{/gist_id}","starred_url":"https://api.github.com/users/kujenga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kujenga/subscriptions","organizations_url":"https://api.github.com/users/kujenga/orgs","repos_url":"https://api.github.com/users/kujenga/repos","events_url":"https://api.github.com/users/kujenga/events{/privacy}","received_events_url":"https://api.github.com/users/kujenga/received_events","type":"User","site_admin":false},"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-11T18:26:26Z","updated_at":"2018-05-11T18:26:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/5529","html_url":"https://github.com/kubernetes/charts/pull/5529","diff_url":"https://github.com/kubernetes/charts/pull/5529.diff","patch_url":"https://github.com/kubernetes/charts/pull/5529.patch"},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis commit reverts a breaking change that was introduced in the\r\nfollowing PR: https://github.com/kubernetes/charts/pull/4915\r\n\r\nThe problems caused by this change are described in the following GitHub\r\nissue: https://github.com/kubernetes/charts/issues/5128\r\n\r\nThe root of the problem is that the `clusterIP` field on services is not\r\nmutable, so a simple helm upgrade is not sufficient to handle this type\r\nof change. Furthermore, since these are overridable values, users who\r\nhave a specific use case for making the services non-headless can do so\r\nin their overrides for the chart installation.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\nCloses https://github.com/kubernetes/charts/issues/5128\r\n\r\n**Special notes for your reviewer**:\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/charts/issues/comments/388447077","html_url":"https://github.com/kubernetes/charts/pull/5529#issuecomment-388447077","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/5529","id":388447077,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T18:26:34Z","updated_at":"2018-05-11T18:26:34Z","author_association":"CONTRIBUTOR","body":"Hi @kujenga. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}