{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/203048256","pull_request_review_id":137860937,"id":203048256,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzA0ODI1Ng==","diff_hunk":"@@ -1,128 +0,0 @@\n-// Unless explicitly stated otherwise all files in this repository are licensed // under the Apache License Version 2.0.\n-// This product includes software developed at Datadog (https://www.datadoghq.com/).\n-// Copyright 2018 Datadog, Inc.\n-\n-//\n-// NOTE: This module contains a feature in development that is NOT supported.\n-//\n-\n-package percentile\n-\n-import (\n-\t\"bytes\"\n-\t\"encoding/json\"\n-\t\"expvar\"\n-\n-\tagentpayload \"github.com/DataDog/agent-payload/gogen\"\n-\t\"github.com/DataDog/datadog-agent/pkg/aggregator/ckey\"\n-\t\"github.com/DataDog/datadog-agent/pkg/serializer/marshaler\"\n-\t\"github.com/gogo/protobuf/proto\"\n-)\n-\n-var sketchSeriesExpvar = expvar.NewMap(\"SketchSeries\")\n-\n-// Sketch represents a quantile sketch at a specific time\n-type Sketch struct {\n-\tTimestamp int64   `json:\"timestamp\"`\n-\tSketch    GKArray `json:\"qsketch\"`\n-}\n-\n-// SketchSeries holds an array of sketches.\n-type SketchSeries struct {\n-\tName       string          `json:\"metric\"`\n-\tTags       []string        `json:\"tags\"`\n-\tHost       string          `json:\"host\"`\n-\tInterval   int64           `json:\"interval\"`\n-\tSketches   []Sketch        `json:\"sketches\"`\n-\tContextKey ckey.ContextKey `json:\"-\"`\n-}\n-\n-// SketchSeriesList represents a list of SketchSeries ready to be serialized\n-type SketchSeriesList []*SketchSeries\n-\n-// NoSketchError is the error returned when not enough samples have been\n-//submitted to generate a sketch\n-type NoSketchError struct{}\n-\n-func (e NoSketchError) Error() string {\n-\treturn \"Not enough samples to generate sketches\"\n-}\n-\n-func marshalSketch(sketches []Sketch) []agentpayload.SketchPayload_Sketch_Distribution {\n-\tsketchesPayload := []agentpayload.SketchPayload_Sketch_Distribution{}\n-\n-\tfor _, s := range sketches {\n-\t\tgk := s.Sketch\n-\t\tv, g, delta := marshalEntries(gk.Entries)\n-\t\tsketchesPayload = append(sketchesPayload,\n-\t\t\tagentpayload.SketchPayload_Sketch_Distribution{\n-\t\t\t\tTs:    s.Timestamp,\n-\t\t\t\tCnt:   int64(gk.Count),\n-\t\t\t\tMin:   gk.Min,\n-\t\t\t\tMax:   gk.Max,\n-\t\t\t\tAvg:   gk.Avg,\n-\t\t\t\tSum:   gk.Sum,\n-\t\t\t\tV:     v,\n-\t\t\t\tG:     g,\n-\t\t\t\tDelta: delta,\n-\t\t\t\tBuf:   gk.Incoming,\n-\t\t\t})\n-\t}\n-\treturn sketchesPayload\n-}\n-\n-// Marshal serializes sketch series using protocol buffers\n-func (sl SketchSeriesList) Marshal() ([]byte, error) {\n-\tpayload := &agentpayload.SketchPayload{\n-\t\tSketches: []agentpayload.SketchPayload_Sketch{},\n-\t\tMetadata: agentpayload.CommonMetadata{},","path":"pkg/metrics/percentile/sketch_series.go","position":78,"original_position":78,"commit_id":"96d3c552ace314fe0fa617d8392b3e9d9b20ac30","original_commit_id":"28863ac29fbbdb52baac74bf61313472c99f1bc4","user":{"login":"jbarciauskas","id":310837,"node_id":"MDQ6VXNlcjMxMDgzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/310837?v=4","gravatar_id":"","url":"https://api.github.com/users/jbarciauskas","html_url":"https://github.com/jbarciauskas","followers_url":"https://api.github.com/users/jbarciauskas/followers","following_url":"https://api.github.com/users/jbarciauskas/following{/other_user}","gists_url":"https://api.github.com/users/jbarciauskas/gists{/gist_id}","starred_url":"https://api.github.com/users/jbarciauskas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbarciauskas/subscriptions","organizations_url":"https://api.github.com/users/jbarciauskas/orgs","repos_url":"https://api.github.com/users/jbarciauskas/repos","events_url":"https://api.github.com/users/jbarciauskas/events{/privacy}","received_events_url":"https://api.github.com/users/jbarciauskas/received_events","type":"User","site_admin":false},"body":"FWIW, looks like this is what's done everywhere. 😬 \r\n","created_at":"2018-07-17T14:38:09Z","updated_at":"2018-07-17T14:38:09Z","html_url":"https://github.com/DataDog/datadog-agent/pull/2013#discussion_r203048256","pull_request_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/203048256"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/2013#discussion_r203048256"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013"}},"in_reply_to_id":202897548},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013","id":201801856,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODAxODU2","html_url":"https://github.com/DataDog/datadog-agent/pull/2013","diff_url":"https://github.com/DataDog/datadog-agent/pull/2013.diff","patch_url":"https://github.com/DataDog/datadog-agent/pull/2013.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/2013","number":2013,"state":"open","locked":false,"title":"[wip] use dogsketch","user":{"login":"GeorgeErickson","id":262165,"node_id":"MDQ6VXNlcjI2MjE2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/262165?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeErickson","html_url":"https://github.com/GeorgeErickson","followers_url":"https://api.github.com/users/GeorgeErickson/followers","following_url":"https://api.github.com/users/GeorgeErickson/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeErickson/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeErickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeErickson/subscriptions","organizations_url":"https://api.github.com/users/GeorgeErickson/orgs","repos_url":"https://api.github.com/users/GeorgeErickson/repos","events_url":"https://api.github.com/users/GeorgeErickson/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeErickson/received_events","type":"User","site_admin":false},"body":"# TODO\r\n- [ ] write a release note so CI passes\r\n- [ ] write a Marshal method\r\n\r\n\r\n### What does this PR do?\r\n\r\nA brief description of the change being made with this pull request.\r\n\r\n### Motivation\r\n\r\nWhat inspired you to submit this pull request?\r\n\r\n### Additional Notes\r\n\r\nAnything else we should know when reviewing?\r\n\r\n","created_at":"2018-07-17T01:35:51Z","updated_at":"2018-07-17T14:38:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"740fd44f755a9c153a4532af247ebf21f2a064c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"agent-core","id":1224133,"node_id":"MDQ6VGVhbTEyMjQxMzM=","slug":"agent-core","description":"(formerly Croissant) Core Infra Agent and Agent packaging","privacy":"closed","url":"https://api.github.com/teams/1224133","members_url":"https://api.github.com/teams/1224133/members{/member}","repositories_url":"https://api.github.com/teams/1224133/repos","permission":"pull"},{"name":"Sandwich","id":2149645,"node_id":"MDQ6VGVhbTIxNDk2NDU=","slug":"sandwich","description":"sciencing the data","privacy":"closed","url":"https://api.github.com/teams/2149645","members_url":"https://api.github.com/teams/2149645/members{/member}","repositories_url":"https://api.github.com/teams/2149645/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/2013/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/96d3c552ace314fe0fa617d8392b3e9d9b20ac30","head":{"label":"DataDog:gee.dogsketch","ref":"gee.dogsketch","sha":"96d3c552ace314fe0fa617d8392b3e9d9b20ac30","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDczOQ==","name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2018-07-17T13:13:45Z","pushed_at":"2018-07-17T14:35:10Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":25939,"stargazers_count":204,"watchers_count":204,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":114,"watchers":204,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"6764d874d77be96313f1b079247d46c7f944339a","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3MDczOQ==","name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2018-07-17T13:13:45Z","pushed_at":"2018-07-17T14:35:10Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":25939,"stargazers_count":204,"watchers_count":204,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":114,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/2013"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/2013"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/2013/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/2013/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-agent/statuses/96d3c552ace314fe0fa617d8392b3e9d9b20ac30"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jbarciauskas"}}