{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/1757","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/1757/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1757/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/1757/events","html_url":"https://github.com/ocaml/ocaml/pull/1757","id":320012112,"number":1757,"title":"Style the html manual, changing type and layout","user":{"login":"charlesetc","id":5167293,"avatar_url":"https://avatars1.githubusercontent.com/u/5167293?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesetc","html_url":"https://github.com/charlesetc","followers_url":"https://api.github.com/users/charlesetc/followers","following_url":"https://api.github.com/users/charlesetc/following{/other_user}","gists_url":"https://api.github.com/users/charlesetc/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesetc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesetc/subscriptions","organizations_url":"https://api.github.com/users/charlesetc/orgs","repos_url":"https://api.github.com/users/charlesetc/repos","events_url":"https://api.github.com/users/charlesetc/events{/privacy}","received_events_url":"https://api.github.com/users/charlesetc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T17:29:43Z","updated_at":"2018-05-03T17:35:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1757","html_url":"https://github.com/ocaml/ocaml/pull/1757","diff_url":"https://github.com/ocaml/ocaml/pull/1757.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1757.patch"},"body":"Hi!\r\n\r\nSo this commit makes major visual changes to the OCaml manual. I'm very happy to take any feedback and make changes.\r\n\r\nI've got [a preview up](http://preview_docs.narwhal.space/index.html) of these changes. This is compared to [the current version](https://caml.inria.fr/pub/docs/manual-ocaml/).\r\n\r\nThe header font is [Fira Sans](https://mozilla.github.io/Fira/). I checked it into this repository, so the font would be served from OCaml's servers. There is an argument to be made for using Google Fonts instead, since it can make things faster through caching. I'd be interested in hearing what people think about that.\r\n\r\nThe only \"hack\" here is the following snippet:\r\n```\r\n\\newstyle{body >\r\n          div:first-child >\r\n          span:first-child >\r\n          span:first-child}{\r\n    font-family: \"Fira Sans\", sans-serif;\r\n}\r\n```\r\n\r\nWhich selects the \"The OCaml System Release 4.08 ...\" heading to make it a different font. Unfortunately there's no id or class by which to select this — if anyone knows how to add one that'd be awesome!\r\n\r\nIn reference to the recent change (https://github.com/ocaml/ocaml/commit/49abafc5872f6be347cdb72a8a4ecccd229b6118) of the manual, this keeps the max-width for the body, but adds a `margin: auto` so that the body is centered. I think this looks slightly better and also more like the current manual. On small screens, when max-width doesn't apply, this also adds a percentage padding. You can go to [preview_docs.narwhal.space](http://preview_docs.narwhal.space) on a phone to see how it looks.\r\n\r\nAnyways, I'm glad to make any changes people see fit :cactus: "},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/386375762","html_url":"https://github.com/ocaml/ocaml/pull/1757#issuecomment-386375762","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1757","id":386375762,"user":{"login":"xavierleroy","id":3845810,"avatar_url":"https://avatars0.githubusercontent.com/u/3845810?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T17:35:39Z","updated_at":"2018-05-03T17:35:39Z","author_association":"CONTRIBUTOR","body":"I'm glad to see efforts to improve the look and legibility of the online manual.  However something is very wrong with the OCaml code snippets, e.g. the first example of section 1.1, `1+2*3`.  The original rendering has colors and a `#` prompt to distinguish input from output.  The new style has none of that and is unreadable."}}
{"actor":{"display_login":"xavierleroy"}}