{"push_id":2549478297,"size":60,"distinct_size":15,"ref":"refs/heads/helm-readiness-zipkin","head":"411048ee42e447298e29bdefe13dca38ca31fbb3","before":"1296b1d11eaeefc498f31e17c11518f98fcad625","commits":[{"sha":"48561b4fe44d6d156c5c06a868d6183f61dbfeeb","author":{"name":"Andra Cismaru","email":"06fa6c834067b31554f18ea30405afa12da4a7ab@users.noreply.github.com"},"message":"Generate inboundPorts for the init container (#5070)\n\n* Adde list of container ports to the injected inbound ports\r\n\r\n* Add support for helm\r\n\r\n* [test pr] check if 503s and other known bugs are fixed\r\n\r\nremoving the t.Skip()\r\n\r\nShould fail in CI until we have a fix\r\n\r\n* prune old version resources that no longer exist (#5107)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nprune old version resources that no longer exist\r\n\r\n* [vendor-change] CloudWatch Mixer adapter (#4617)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\n[vendor-change] CloudWatch Mixer adapter\r\n\r\nAdding an adapter to send metrics to cloudwatch\r\n\r\n* Enable Ingress/Egress gateways in Helm for bookinfo demos (#5120)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nEnable Ingress/Egress gateways in Helm for bookinfo demos\r\n\r\n* Consume labeled multicluster secrets on startup (#5117)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nConsume labeled multicluster secrets on startup\r\n\r\nThis patch when run against istio.yaml or istio-auth.yaml\r\nruns in the new config mode using only labels rather than\r\nconfigmaps.  The configmap functionality can be removed in\r\n0.9.\r\n\r\n* Add a linter check to make sure types.go are generated. (#5110)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAdd a linter check to make sure types.go are generated.\r\n\r\naddresses https://github.com/istio/istio/issues/4418\r\n\r\n* Remove outdated manifests from install/kubernetes (#4882)\r\n\r\n* Remove orig_ manifests\r\n\r\n* Remove istio-mixer-validator and istio-mixer-with-health-check manifests\r\n\r\n* Remove unwanted manifests before archiving\r\n\r\n* Remove istio-sidecar-injector.yaml from install/README.md\r\n\r\n* Remove *one-namespace*.yaml from install/README.md\r\n\r\n* Make helm-generated manifests overwrite updateVersion_orig.sh manifests\r\n\r\n* Add support for per-metric namespace configuration to prom config (#5112)\r\n\r\n* Adding CI workflow for checking vendor diff (#5051)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAdding CI workflow for checking vendor diff\r\n\r\nThis aims to help ensure that a PR contains the correct vendor change,\r\nby running `dep ensure` and seeing if git detects any changes.\r\n\r\n* Introduce galley/pkg/server (#4974)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nIntroduce galley/pkg/server\r\n\r\ngalley/pkg/server implements logic performs both CRD synchronization, along with resource synchronization operations. The resource synchronizers are started/stopped as CRDs (of interest) are added/deleted.\r\n\r\n* [vendor change] Add metrics command to istioctl experimental cli (#4945)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\n[vendor change] Add metrics command to istioctl experimental cli\r\n\r\nThis PR adds a new command for retrieving service-level metrics\r\nfor services within an Istio service mesh. In combination with\r\nthe `watch` command, this tool may be used to display a rudimentary\r\nservice dashboard from the commandline.\r\n\r\nThis command requires the deployment of a prometheus instance for\r\nmonitoring the mesh. It discovers a prometheus pod, establishes a\r\nport-forward to that pod, and executes a series of queries to extract\r\nthe metrics for display.\r\n\r\nCurrently, this command pulls all metrics from the current time, \r\ncalculating rates and latencies over a time window of 1 minute. In \r\nthe future, it will be possible to add support for flexible time\r\nwindows.\r\n\r\nExample usage (bookinfo example):\r\n\r\n```\r\n$ istioctl experimental metrics productpage reviews ratings details\r\nproductpage:\r\n  Total RPS:     7.872870\r\n  Error RPS:     0.000000\r\n  P50 Latency:   40ms\r\n  P90 Latency:   80ms\r\n  P99 Latency:   98ms\r\nreviews:\r\n  Total RPS:     7.909235\r\n  Error RPS:     0.000000\r\n  P50 Latency:   4ms\r\n  P90 Latency:   9ms\r\n  P99 Latency:   21ms\r\nratings:\r\n  Total RPS:     5.309187\r\n  Error RPS:     0.000000\r\n  P50 Latency:   2ms\r\n  P90 Latency:   4ms\r\n  P99 Latency:   4ms\r\ndetails:\r\n  Total RPS:     7.872870\r\n  Error RPS:     0.000000\r\n  P50 Latency:   3ms\r\n  P90 Latency:   38ms\r\n  P99 Latency:   48ms\r\n``` \r\n\r\nThis tool is intended primarily to aid with debugging, as discovering\r\nwhat is happening with a mesh and/or a particular service can be somewhat\r\ncumbersome.\r\n\r\nReviewers: please let me know if there is a more appropriate place for \r\nsuch a tool and if there is more/different information that you think\r\nis relevant to display for a service.\r\n\r\nVendor PR: https://github.com/istio/vendor-istio/pull/58\r\n\r\n* unset IFS, minor fix for perf setup (#5124)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nunset IFS, minor fix for perf setup\r\n\r\n* perf setup update: add grafana, misc fixes (#5028)\r\n\r\n* need git pull --tags to get latest_release movement, use DUR variable for duration\r\n\r\n* Add grafana ingress\r\n\r\nDoesn’t work because of mixer/telemetry split yet but almost\r\n\r\nAlso had to disable mtls for grafana - this should be the default\r\n\r\n* Add annotation for no mtls in helm template\r\n\r\n* From 0.8 prometheus is already in the yaml\r\n\r\nSee #5111\r\n\r\n* Assert requried circle CI envs in ci2gubernator (#5137)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAssert requried circle CI envs in ci2gubernator\r\n\r\nThere has been cases where tests on circle failed when calling ci2gubernator because `CIRCLE_PR_NUMBER` unbound. This PR asserts the existence of the circle ci envs required by ci2gubernator and resort to no op if any of those is not defined.\r\n\r\n* Add Mixer perf tests that includes the RPC path. (#5013)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAdd Mixer perf tests that includes the RPC path.\r\n\r\nThe perf tests included two sets of tests (proper v.s. with _R2 suffix).\r\nThe tests with _R2 suffix was for testing runtime2 implementation.\r\n\r\nNow that there is only one runtime, repurposing some of the tests to\r\ninclude the gRpc layer as well.\r\n\r\n* verify 200 status code in addition to header value (#5163)\r\n\r\n* Add/Update Mixer e2e tests to cover more attributes sent from Envoy. (#5152)\r\n\r\n* Add/Update Mixer e2e tests to cover more attributes sent from Envoy.\r\n\r\n* Fix indent.\r\n\r\n* Assorted bug fixes for 0.8 (#5133)\r\n\r\n* assorted bug fixes\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>\r\n\r\n* lint\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>\r\n\r\n* Updated zipkin to 2.7 for istio. (#5155)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nUpdated zipkin to 2.7 for istio.\r\n\r\nThis is a follow up PR for https://github.com/istio/istio/pull/4726\r\n\r\n/cc @ldemailly\r\n\r\n* fix path for go 1.10 on perf vm (#5168)\r\n\r\n* Move mixer filter to per_filter_config (#5073)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nMove mixer filter to per_filter_config\r\n\r\nMove the per route mixer filter config from the metadata field to per_filter_config and turn it into a ServiceConfig proto.\r\n\r\n* Enable test\r\n\r\n* [vendor change] Add B3 codec to Jaeger tracer to enable mixer trace to be included in… (#5116)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\n[vendor change] Add B3 codec to Jaeger tracer to enable mixer trace to be included in…\r\n\r\n… the application trace - and extended zipkin test to check for the mixer span\r\n\r\nInstalls the B3 codec into the Jaeger tracer to enable B3 headers to be understood and therefore associate any spans with the existing application trace.\r\n\r\nThe PR also updates the zipkin e2e test to check that the mixer spans are included in the application trace instance. \r\n\r\nOnce an initial review of the PR has been approved I'll commit the vendor change - using \"dep ensure\"? Locally this has resulted in a number of dependencies being deleted under `vendor/k8s.io/client-go/`.\r\n\r\nSigned-off-by: Gary Brown <gary@brownuk.com>\r\n\r\n* remove prometheus from release archives (#5150)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nremove prometheus from release archives\r\n\r\n* Add Galley command-line flags \"server\" and \"purge\" (#4977)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAdd Galley command-line flags \"server\" and \"purge\"\r\n\r\nAdd command-line flags for server and purge commands.\r\n\r\n* Simplify the auth test\r\n\r\nThanks Andra for pointing out that version should fail/work the same as\r\nusing pod IP directly as the destination container never sees the\r\noriginal cluster IP\r\n\r\n* adds guard for kube client (#5140)\r\n\r\n* adds guard for kube client\r\n\r\n- there may not always be one, especially in\r\nthe case of CF.\r\n- made CF case more explicit\r\n\r\n* ci2gubernator: stop checking for unset variables\r\n\r\n* Fix single endpoint pilot ads look up (#5165)\r\n\r\n* Add an experiment subcommand rbac to istioctl. (#5093)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAdd an experiment subcommand rbac to istioctl.\r\n\r\nThe subcommand is used to interact with Istio RBAC policies, this PR\r\nadds the basic interface and the actual logic will be added in a later\r\nPR.\r\n\r\nSee #4856.\r\n\r\n* Fixing race test failure in TestAdsEds (#5161)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nFixing race test failure in TestAdsEds\r\n\r\nintroduced by https://github.com/istio/istio/pull/4694\r\naddresses #4235\r\n\r\n* v1alpha1 to v1alpha3 rule conversion tool bug fixes and subset merging (#5178)\r\n\r\n* v1 to v3 conversion enhancements and tests\r\n\r\n* Handle DestinationPolicy w/o labels\r\n\r\n* Remove AddJwtAuth (#5194)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nRemove AddJwtAuth\r\n\r\nThere is a compile error.\r\n# istio.io/istio/mixer/test/client/env\r\n../../../../../mixer/test/client/env/mixer_filter_config.go:167:47: undefined: client.JWT\r\n../../../../../mixer/test/client/env/mixer_filter_config.go:168:21: mfConf.PerRouteConf.EndUserAuthnSpec undefined (type *client.ServiceConfig has no field or method EndUserAuthnSpec)\r\n../../../../../mixer/test/client/env/mixer_filter_config.go:168:42: undefined: client.EndUserAuthenticationPolicySpec\r\n../../../../../mixer/test/client/env/mixer_filter_config.go:169:21: mfConf.PerRouteConf.EndUserAuthnSpec undefined (type *client.ServiceConfig has no field or method EndUserAuthnSpec)\r\n\r\nRemove AddJwtAuth function.\r\n\r\ncc @diemtvu\r\n\r\n* Skip bad routes instead of erroring (#5183)\r\n\r\n* Skip bad routes instead of erroring\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>\r\n\r\n* nits\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>\r\n\r\n* final nits\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>\r\n\r\n* fix rules\r\n\r\n* BlackHole with a capital H\r\n\r\n* validate clusters false\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>\r\n\r\n* Fetch/cache/refresh JWT public key, construct localJwks in sidecar filter config (#5061)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nFetch/cache/refresh JWT public key, construct localJwks in sidecar filter config\r\n\r\nhttps://github.com/istio/istio/issues/4917\r\n\r\nThis PR includes \r\n1. fetch JWT public key, and cache the key.\r\n2. key rotation - a refresher job refresh key periodically.\r\n3. use the key to construct localJwks in sidecar filter config.\r\n\r\n* Introduce dynamic proto3 encoder (#5122)\r\n\r\n* WIP commit\r\n\r\n* Remove dead code\r\n\r\n* Rearrange code\r\n\r\n* split code into encoderUtil\r\n\r\n* Everything except ENUM\r\n\r\n* use protoc 3.5.1 to ensure json names are generated\r\n\r\n* expose internal funcs\r\n\r\n* WIP3. all dynamic and static elementry types. No repeated or packed\r\n\r\n* support packed static primitive types\r\n\r\n* use switch in place of if\r\n\r\n* primitives with eval and packed repeated\r\n\r\n* all primitives with expressions\r\n\r\n* add test with enum constants and expressions\r\n\r\n* add expressions in repeated fields\r\n\r\n* Refactor 2\r\n\r\n* linter checks\r\n\r\n* fix linter2\r\n\r\n* split encoder and builder\r\n\r\n* rename eval to primitive\r\n\r\n* add all dynamic tests\r\n\r\n* Add dependency for messagediff\r\n\r\n* add full dynamic test\r\n\r\n* update comment\r\n\r\n* fix linter error\r\n\r\n* Update vendor. Add messagediff.v1 for test verification\r\n\r\n* add all positive tests\r\n\r\n* improve test coverage\r\n\r\n* remove updated to lang.compiled\r\n\r\n* fix linter error\r\n\r\n* handle float64 inputs for integers\r\n\r\n* Builder.Build() takes msgName and data\r\n\r\n* WIP2\r\n\r\n* review comments\r\n\r\n* review comments\r\n\r\n* rename messagediff to diff\r\n\r\n* add more tests\r\n\r\n* Update deps\r\n\r\n* improve test coverage\r\n\r\n* add log message while skipping fields\r\n\r\n* increase test coverage\r\n\r\n* update dep status\r\n\r\n* Add more files to gitignore (#5198)\r\n\r\n* Fix Mixer dashboard CPU reporting (#5145)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nFix Mixer dashboard CPU reporting\r\n\r\nA previous PR seems to have accidentally removed the \"rate\" component of\r\nthe CPU calculations for the Mixer Dashboard. This results in an ever-increasing\r\nCPU graph.\r\n\r\nThis PR restores a proper rate-based display for CPU calculation. It also\r\nrenames the jobs in the Prometheus config to better align with the split\r\nfrom Mixer to Istio-Telemetry and Istio-Mixer (providing easier to understand\r\ntracking between cAdvisor metrics and the self-reported metrics.\r\n\r\nThis PR should be cherry-picked onto the 0.8 branch.\r\n\r\n* fix nil reference error when mock server fails to start (#5216)\r\n\r\n* [WIP] refactor bookinfo to use different gateway definitions for envoy v1/routing v1alpha1 and envoy v2/routing v1alpha3  (#5113)\r\n\r\n* restrict the tests to either v1alpha1 or v1alpha3\r\n\r\n* move applying defaultRules into setUpDefaultRouting\r\n\r\n* extract Ingress (Gateway) definition from bookinfo.yaml\r\n\r\nit is different for v1alpha1 and v1alpha3\r\n\r\n* make the gateway rule first in defaultRules, so it will be applied first\r\n\r\n* fixed wrong variable names in mixer tests\r\n\r\n* fixed the location of bookinfo gateway yaml\r\n\r\n* fixed wrong variable in mixer test\r\n\r\n* add missing spec and name to destination-policy-reviews\r\n\r\n* remove comment line in samples/bookinfo/routing/bookinfo-gateway.yaml\r\n\r\n* add port 9080 to the new bookinfo gateway\r\n\r\n* remove using a special destination rule for reviews\r\n\r\n* refactor GetIngress to make it reusable for GetIngressGateway\r\n\r\nextract functions for getting Kubernetes Ingress and NodePort\r\n\r\n* remove a shadowing variable\r\n\r\n* refactor GetIngressPod, add GetIngressGateway\r\n\r\n* add IngressGateway() to framework Kube\r\n\r\n* added using IngressGateway() of framework Kube in bookinfo e2e tests\r\n\r\n* use load balancer ingress IP to get the IP of the nodeport\r\n\r\n* use ingress IP for nodeport\r\n\r\n* remove commented out line\r\n\r\n* fixed getting the ingress as the IP for a NodePort\r\n\r\n* Revert \"fixed getting the ingress as the IP for a NodePort\"\r\n\r\nThis reverts commit 594e58d9ae9d7eb4374979b21795f0a945abdc3d.\r\n\r\n* Revert \"use ingress IP for nodeport\"\r\n\r\nThis reverts commit 333b80f92e12aef938b8ef8d576074c8a3a2ab57.\r\n\r\n* Revert \"use load balancer ingress IP to get the IP of the nodeport\"\r\n\r\nThis reverts commit 3c138e4819bc5cc41f3e74b9f4fd6371c103bbe8.\r\n\r\n* add generate_yaml-envoyv2_transition_loadbalancer_ingressgateway\r\n\r\nto generate istio configurations without ingress and with ingressgateway as\r\na LoadBalancer service\r\n\r\n* use generate_yaml-envoyv2_transition_loadbalancer_ingressgateway in test/local/noauth/e2e_bookinfo_envoyv2\r\n\r\n* added LoadBalancerServiceType and NodePortServiceType constants\r\n\r\n* rewrote the ingress related logic\r\n\r\nuse LoadBalancer type for non-local and NodePort for local tests\r\n\r\n* lint fixes\r\n\r\n* fix lint errors\r\n\r\n* *sync.Locker -> sync.Locker, use interface instead of a pointer to interface\r\n\r\n* refactor: extract getServicePort() from getServiceNodePort()\r\n\r\n* add isKubernetesIngress flag to tests/util.GetIngress()\r\n\r\n* fix the destination port in the virtual service of the gateway\r\n\r\n* Revert \"add isKubernetesIngress flag to tests/util.GetIngress()\"\r\n\r\nThis reverts commit 8dbe13cc4b0d69c0790a96c1d82c749a2c91dcae.\r\n\r\n* set different retry values for LoadBalancer and NodePort\r\n\r\naccording to the original implementation\r\n\r\n* fix logging message\r\n\r\n* fix a typo\r\n\r\n* Introduce pkg/ctrlz, Istio's introspection package. (#5123)\r\n\r\n* Introduce pkg/ctrlz, Istio's introspection package.\r\n\r\nProcesses that integrate with ControlZ open up a port that enables operators\r\nto connect with a web browser and interact with the process. Through the browser,\r\nthe operator can adjust logging scope levels, see the process' command-line arguments\r\nand envirinment variables, see statistics about heap use, and more.\r\n\r\nIntegration with ControlZ is nominally two line deal for processes. Optionally,\r\nprocesses can extend the base ControlZ UI and integrate their own screens into the\r\nmain UI.\r\n\r\nIn addition to the browser interface, there is a REST API enabling access to all\r\nthe same things that the UI shows.\r\n\r\nMixer is integrated with ControlZ but doesn't currently have custom UI. We should\r\nintegrate ControlZ with our other server components in due time.\r\n\r\n* Add myself to owners. (#5039)\r\n\r\n* pod Ip is actually required\r\n\r\nService vip doesn’t exist for non existent port and we need a non\r\nexistent port to get the bad routing behavior\r\n\r\n* Expose image of each istio component for istio chart. (#5222)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nExpose image of each istio component for istio chart.\r\n\r\nMake `image` for each Istio component be configurable. \r\nThis is useful in case that users build or retag Istio image.\r\n\r\n/cc @gyliu513 @linsun @sdake\r\n\r\n* Undoing accidental merge to master\r\n\r\n* Adding zone/region node labeling if missing (#5164)\r\n\r\n* Fixing missing INSTANCE_IP\r\n\r\n* Fix yaml error\r\n\r\n* Rename v1alpha3.ExternalSerivce to v1alpha3.ServiceEntry (#5195)\r\n\r\n* first pass renaming v1alpha3.ExternalSerivce to v1alpha3.ServiceEntry\r\n\r\n* rename ServiceEntry.Discovery to ServiceEntry.Resolution\r\n\r\n* update vendor to latest istio/api\r\n\r\n* fix cloudfoundry copilot e2e test (#5188)\r\n\r\n* initial changes to fix both pilot endpoints\r\n\r\n* they now should be curl'ing the right things\r\n\r\nproperly booting an envoy with dynamic\r\ntemplate now\r\n\r\nnew port name for building listeners\r\n\r\nInclude port for Cloud Foundry services\r\n\r\n* Building listeners now requires named ports.\r\n\r\n* always run cloudfoundry tests\r\n\r\n* moves cloudfoundry circleci test to own run\r\n\r\n* adds cloudfoundry test to all\r\n\r\n* want to just use default env vars\r\n\r\n* need GOPATH/bin on path for envoy\r\n\r\n* switch to defaults which uses da container\r\n\r\n* disable zipkin test in pilot\r\n\r\n* add missing clusters to ads mesh response (#5221)\r\n\r\n* e2e test for JWT authn policy (#5144)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\ne2e test for JWT authn policy\r\n\r\nhttps://github.com/istio/istio/issues/5078\r\n\r\n1. JWT token used here expires in year 2132 (borrowed from https://github.com/istio/proxy/blob/master/src/envoy/http/jwt_auth/sample/correct_jwt). \r\n2. will add another e2e test for fetching JWT public key scenario after https://github.com/istio/istio/pull/5061 is in.\r\n\r\n* Set listeners h2 max streams to override nghttp2 client default of 100 (#5232)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nSet listeners h2 max streams to override nghttp2 client default of 100\r\n\r\nReference issue: https://github.com/envoyproxy/envoy/issues/3076\r\nSigned-off-by: Kuat Yessenov <kuat@google.com>\r\n\r\n* Enable ControlZ to fetch the current process' known logging scopes. (#5245)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nEnable ControlZ to fetch the current process' known logging scopes.\r\n\r\n* Add more parameters to sidecar injector helm template (#5044)\r\n\r\nAutomatic merge from submit-queue.\r\n\r\nAdd enableCoreDump and policy parameters to sidecar injector helm template\r\n\r\n* Fixing fallout of renames in earlier commit + restore auth for e2e-simple on circle (#5241)\r\n\r\n* Fixing fallout of renames in earlier commit\r\n\r\n* Re fixing lost fix that e2e-simple should run with auth\r\n\r\nTechnically it should run with both auth and no auth like on prow but\r\nif it runs only 1 mode it should be with auth\r\n\r\n* follow output log pattern for cloudfoundry e2e test (#5234)\r\n\r\n- and tee to a new file so it doesn't overwrite\r\n\r\n* bootstrapv2: Stop using deprecated cluster_names (#5225)\r\n\r\nUsing cluster_names in GRPC resource config is deprecated:\r\nhttps://github.com/envoyproxy/envoy/commit/ad02e4ac036be359c435d33c987501477c648020\r\n\r\nSigned-off-by: Romain Lenglet <romain@covalent.io>\r\n\r\n* Address a few causes of Gateway/Filterchain failures (#5185)\r\n\r\n* Sort HTTP route virtual hosts before sending listeners to Envoy.\r\nListeners with multiple filter chains containing HTTP filters require\r\nthat the HTTP filters have consistent ordering due to how Envoy computes\r\nupdates.\r\n\r\n* don't respond with empty listeners\r\n\r\n* address review comments\r\n\r\n* fix linter\r\n\r\n* linters, once more\r\n\r\n* use configurable paths for envoy and envoy config locations (#5248)\r\n\r\n* re-add istioctl unit tests to Makefile (#5205)\r\n\r\n* re-add istioctl unit tests to Makefile\r\n\r\nhttps://github.com/istio/istio/pull/3820 moved istioctl out of pilot\r\nsubdirectory but forgot to re-add istioctl unit tests to top-level\r\nMakefile. Fix that problem and also the currently broken tests.\r\n\r\n* add missing test data\r\n\r\n* return an error when Envoy fails to start (#5251)\r\n\r\nmixer and backend should also do this, but that involves slightly more\r\nwork.","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/48561b4fe44d6d156c5c06a868d6183f61dbfeeb"},{"sha":"5a6b22fcdc875b5f7208374ff5b18abc9b2e1e2b","author":{"name":"Lin Sun","email":"438379232d6dc5f33cfee1346246b887b66cf53a@us.ibm.com"},"message":"change bookinfo test to use helm install  (#5114)\n\n* add helm testing\r\n\r\n* adding a few supporting methods for helm\r\n\r\n* test: modify to invoke helm install\r\n\r\n* Revert \"test: modify to invoke helm install\"\r\n\r\nThis reverts commit 0083f3c361acba49700a8a20e03b6cffab9c27f1.\r\n\r\n* adding a few function to install tiller\r\n\r\n* add pod name in log\r\n\r\n* customize values for helm install\r\n\r\n* try enable helm installer\r\n\r\n* change to the right time\r\n\r\n* fix build issue\r\n\r\n* fix build issue\r\n\r\n* set correct helm path and params\r\n\r\n* fix e-2-e error in helm dry run\r\n\r\n* use the correct install dir\r\n\r\n* use the correct namespace for the testing","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/5a6b22fcdc875b5f7208374ff5b18abc9b2e1e2b"},{"sha":"02595b657f37608f81cbabafcd6519caecf916bd","author":{"name":"Serguei Bezverkhi","email":"c33ca6227aebfb54a1e138877913c69b58e15edc@cisco.com"},"message":"Pilot crash in pushEDS function (#5266)\n\n* Crash fix\r\n\r\n* Adjusting the fix","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/02595b657f37608f81cbabafcd6519caecf916bd"},{"sha":"66d5226b3b3a53bc01f54c4c1ec318250a0e433e","author":{"name":"Quanjie Lin","email":"36744ff002d0a0185c8072a94f628646aec85a3c@users.noreply.github.com"},"message":"check in https://github.com/istio/istio/pull/5238 to 0.8 branch  (#5261)\n\nAutomatic merge from submit-queue.\n\ncheck in https://github.com/istio/istio/pull/5238 to 0.8 branch \n\ncheck in https://github.com/istio/istio/pull/5238 to 0.8 branch, which is required for jwt authn policy to work in v2.","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/66d5226b3b3a53bc01f54c4c1ec318250a0e433e"},{"sha":"977e94290cd223c627ecfe05cb0c1f9476a39e9a","author":{"name":"Vadim Eisenberg","email":"de108c8a47802ed442b2fec1eb9755429bf0a59a@il.ibm.com"},"message":"fix bookinfo v1alpha3 version migration test (#5224)\n\n* added printing unexpected version in version migration tests\r\n\r\n* print the diffs with the compared versions in case migration test fails\r\n\r\n* apply default rules after every bookinfo test\r\n\r\nin v1alpha3 there is no rule precendence, a new rule just deletes the old one\r\nthere is no possibility to have two rules on the same host\r\n\r\n* apply all the default rules instead of only allRule after each test","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/977e94290cd223c627ecfe05cb0c1f9476a39e9a"},{"sha":"447ec5a777e81cf2ae617623e88966647baee063","author":{"name":"Costin Manolache","email":"17d9fd322ff493103892809c3f7b52a32813af76@gmail.com"},"message":"Merge circleci fix from master (#5313)","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/447ec5a777e81cf2ae617623e88966647baee063"},{"sha":"241e0ac4779600949474970f47a1ef01bd25e74a","author":{"name":"Serguei Bezverkhi","email":"c33ca6227aebfb54a1e138877913c69b58e15edc@cisco.com"},"message":"hostname assign  error (#5285)\n\n* Crash fix\r\n\r\n* Adjusting the fix\r\n\r\n* fixing Hostname assignement\r\n\r\n* Fix collateral from the change\r\n\r\n* Adding inbound to if","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/241e0ac4779600949474970f47a1ef01bd25e74a"},{"sha":"764d47d4f616aa5df6e9c64689476055a0bae5da","author":{"name":"Diem Vu","email":"e473ad0e03fddb0a0b25342ec767275640b4f3be@users.noreply.github.com"},"message":"Enable mTLS for pilot e2e tests (#5268)\n\n* Enable mTLS for pilot e2e tests\r\n\r\n* Change generate_yaml-envoyv2_transition to output to istio-auth.yaml as test is in auth enabled mode\r\n\r\n* Add grpc ports to containerPort list as inboundPorts are limitted by these since https://github.com/istio/istio/pull/5070\r\n\r\n* Disable rbac e2e test as it crash when authn enabled.\r\n\r\n* Disable egressgateway when mTLS enable.","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/764d47d4f616aa5df6e9c64689476055a0bae5da"},{"sha":"3fffebac188b20ede3f45a8f1d645c8da87f6bfa","author":{"name":"Alexey Baranov","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@kotiki.cc"},"message":"Use consul node address as a backup when filtering service instances (#4195)","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/3fffebac188b20ede3f45a8f1d645c8da87f6bfa"},{"sha":"cc30eb6e4b887b6b3ea09c246f4d77d64c4c11e4","author":{"name":"Yanwei Pan","email":"ca8b0603cc93a3c31ccb66c5cf998103794dffce@gmail.com"},"message":"Fix error when running minikube (#4502)\n\nThere will be error like this if this field is missing:\r\nObject 'Kind' is missing in ...","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/cc30eb6e4b887b6b3ea09c246f4d77d64c4c11e4"},{"sha":"d266a5ce4bb16d25867b3e145399a7f61e58739c","author":{"name":"Morven Cao","email":"1649f2d7de2cb6766166e981eb4b36350700171d@cn.ibm.com"},"message":"Delete custom resources before uninstalling chart. (#5279)","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/d266a5ce4bb16d25867b3e145399a7f61e58739c"},{"sha":"0387791d4e82643cf13c55584fd00df6791ae46e","author":{"name":"Tao Li","email":"987f63d71cb58dfa60dc24d37627ddde34940db7@gmail.com"},"message":"Improve the script to generate jwt (#5297)\n\n* Fix doc\r\n\r\n* Revert code change to pass test","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/0387791d4e82643cf13c55584fd00df6791ae46e"},{"sha":"613ac8c8c893a2c72a44651e042386ab58d26b13","author":{"name":"Piotr Sikora","email":"ba6f3a1a6d7e1ecae91b31e93969cc392fbd0fdd@google.com"},"message":"Make metrics command ready for web scale. (#5289)\n\nThis change makes the output denser and easier to read.\r\n\r\nExample usage (bookinfo example):\r\n\r\n$ istioctl experimental metrics productpage reviews ratings details\r\n    SERVICE    TOTAL RPS    ERROR RPS  P50 LATENCY  P90 LATENCY  P99 LATENCY\r\nproductpage        7.873        0.000         40ms         80ms         98ms\r\n    reviews        7.909        0.000          4ms          9ms         21ms\r\n    ratings        5.309        0.000          2ms          4ms          4ms\r\n    details        7.873        0.000          3ms         38ms         48ms\r\n\r\nSigned-off-by: Piotr Sikora <piotrsikora@google.com>","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/613ac8c8c893a2c72a44651e042386ab58d26b13"},{"sha":"a0fc2a9f867bd08dc132fb5b26ca417327546600","author":{"name":"Vadim Eisenberg","email":"de108c8a47802ed442b2fec1eb9755429bf0a59a@il.ibm.com"},"message":"prevent mixing istio-ingressgateway and istio-ingress in proxy config (#5326)\n\n* use env.Mesh.IngressService instead of hardcoded string\r\n\r\n* add definition of IngressService to the mock mesh in the proxy config test\r\n\r\n* add dot to prefix comparison of Ingress Service","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/a0fc2a9f867bd08dc132fb5b26ca417327546600"},{"sha":"f0948905114d4ab777f608b360ed7627a5e8b8b7","author":{"name":"Wayne Zhang","email":"bc786b8a4d6362cffdb954a38777b93c3461fd92@gmail.com"},"message":"Update proxy sha to latest in release-0.8 (#5314)\n\n* Update proxy sha to latest.\r\n\r\n* update to newer proxy sha","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/f0948905114d4ab777f608b360ed7627a5e8b8b7"},{"sha":"9dad2c30a6ffc43c99fa39a3893c418afcb738ee","author":{"name":"Pengyuan Bian","email":"76396737fcbd11a9d297f444a38bd6ee229a2c75@users.noreply.github.com"},"message":"Include bookinfo gateway definition into upgrade e2e test. (#5316)","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/9dad2c30a6ffc43c99fa39a3893c418afcb738ee"},{"sha":"7071d84f48d0e3ccda1ddc323032dfb6dee11827","author":{"name":"Charles Xu","email":"04644c3367f0de6b32720c9063b16c604c394a41@google.com"},"message":"Add all circle ci tests to testgrid (#5184)","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/7071d84f48d0e3ccda1ddc323032dfb6dee11827"},{"sha":"6d9d3bceea257d67601b3567215ba21418201594","author":{"name":"Jason Young","email":"4d4ca925c8b73aa5aad67d6fad386934d41a917c@google.com"},"message":"use client-go's default client config loading rules (#5336)","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/6d9d3bceea257d67601b3567215ba21418201594"},{"sha":"f6397f1688bfa67fef25e9fb5180e61161dc0d59","author":{"name":"Diem Vu","email":"e473ad0e03fddb0a0b25342ec767275640b4f3be@users.noreply.github.com"},"message":"Fix egressgateway e2e test when mTLS enable. (#5333)\n\n* Change service entry for egressgateway to b, which is in the mesh, so that test works when authn is enabled.\r\n\r\n* Disable mTLS for service t so it can be used as fake external service.\r\n\r\n* Add missing policy yaml.\r\n\r\n* Add comment to explain the purpose of authn policy for egressgateway test.\r\n\r\n* Revert accidental revert.\r\n\r\n* Correct fix: disable mTLS for egressgateway instead.\r\n\r\n* Correct authn policy yaml file.\r\n\r\n* Correct policy target name.","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/f6397f1688bfa67fef25e9fb5180e61161dc0d59"},{"sha":"bc4567c37cb4505586e3aba26fa2d2c3651bfd49","author":{"name":"Kuat","email":"9681e6f6a261259b66f03880a9050a427f4eecaa@users.noreply.github.com"},"message":"bugfix: tracing operations for mixer sidecar (#5362)\n\n* Update envoy_telemetry.yaml.tmpl\r\n\r\n* Update envoy_policy.yaml.tmpl","distinct":false,"url":"https://api.github.com/repos/zchee/istio/commits/bc4567c37cb4505586e3aba26fa2d2c3651bfd49"}]}
{"actor":{"display_login":"zchee"}}