{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/3770","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3770/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3770/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3770/events","html_url":"https://github.com/apache/incubator-airflow/pull/3770","id":351935120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzgwMTU0","number":3770,"title":"[AIRFLOW-3281] Fix Kubernetes operator with git-sync","user":{"login":"odracci","id":281767,"node_id":"MDQ6VXNlcjI4MTc2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/281767?v=4","gravatar_id":"","url":"https://api.github.com/users/odracci","html_url":"https://github.com/odracci","followers_url":"https://api.github.com/users/odracci/followers","following_url":"https://api.github.com/users/odracci/following{/other_user}","gists_url":"https://api.github.com/users/odracci/gists{/gist_id}","starred_url":"https://api.github.com/users/odracci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odracci/subscriptions","organizations_url":"https://api.github.com/users/odracci/orgs","repos_url":"https://api.github.com/users/odracci/repos","events_url":"https://api.github.com/users/odracci/events{/privacy}","received_events_url":"https://api.github.com/users/odracci/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-08-19T21:16:08Z","updated_at":"2018-11-05T18:43:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3770","html_url":"https://github.com/apache/incubator-airflow/pull/3770","diff_url":"https://github.com/apache/incubator-airflow/pull/3770.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3770.patch"},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n  - https://issues.apache.org/jira/browse/AIRFLOW-3281\r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\nCurrently the implementation of git-sync is broken because:\r\n- git-sync clones the repository in /tmp and not in airflow-dags volume\r\n- git-sync add a link to point to the revision required but it is not\r\ntaken into account in AIRFLOW__CORE__DAGS_FOLDER\r\n\r\nDags/logs hostPath volume has been added (needed if airflow run in\r\nkubernetes in local environment)\r\n\r\nIn this PR I also removed `worker_dags_folder` config because IMO is redundant. In fact is possible to define it in `dags_folder` using a specific `airflow-configmap` for the workers\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\nTo avoid false positive in CI `load_examples` is set to `False`\r\notherwise DAGs from `airflow/example_dags` are always loaded. In this\r\nway is possible to test `import` in DAGs.\r\n\r\nTo do so `KubernetesExecutorTest` now uses a specific folder `airflowexample_dags_kubernetes` to run test instead of `airflow/example_dags` and the DAG `example_kubernetes_annotation` imports a an external module\r\n\r\n### Commits\r\n\r\n- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n  1. Subject is separated from body by a blank line\r\n  1. Subject is limited to 50 characters (not including Jira issue reference)\r\n  1. Subject does not end with a period\r\n  1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n  1. Body wraps at 72 characters\r\n  1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [ ] In case of new functionality, my PR adds documentation that describes how to use it.\r\n  - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n### Code Quality\r\n\r\n- [ ] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/435987410","html_url":"https://github.com/apache/incubator-airflow/pull/3770#issuecomment-435987410","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3770","id":435987410,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTk4NzQxMA==","user":{"login":"Fokko","id":1134248,"node_id":"MDQ6VXNlcjExMzQyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1134248?v=4","gravatar_id":"","url":"https://api.github.com/users/Fokko","html_url":"https://github.com/Fokko","followers_url":"https://api.github.com/users/Fokko/followers","following_url":"https://api.github.com/users/Fokko/following{/other_user}","gists_url":"https://api.github.com/users/Fokko/gists{/gist_id}","starred_url":"https://api.github.com/users/Fokko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fokko/subscriptions","organizations_url":"https://api.github.com/users/Fokko/orgs","repos_url":"https://api.github.com/users/Fokko/repos","events_url":"https://api.github.com/users/Fokko/events{/privacy}","received_events_url":"https://api.github.com/users/Fokko/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T18:43:10Z","updated_at":"2018-11-05T18:43:10Z","author_association":"CONTRIBUTOR","body":"@odracci Can you rebase?\r\n\r\n@dimberman Final thoughts?"}}
{"actor":{"display_login":"Fokko"}}