{"action":"created","issue":{"url":"https://api.github.com/repos/logicoffee/carta_tournaments/issues/9","repository_url":"https://api.github.com/repos/logicoffee/carta_tournaments","labels_url":"https://api.github.com/repos/logicoffee/carta_tournaments/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/logicoffee/carta_tournaments/issues/9/comments","events_url":"https://api.github.com/repos/logicoffee/carta_tournaments/issues/9/events","html_url":"https://github.com/logicoffee/carta_tournaments/pull/9","id":384273799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTEzMjM1","number":9,"title":"Static pages","user":{"login":"logicoffee","id":38097603,"node_id":"MDQ6VXNlcjM4MDk3NjAz","avatar_url":"https://avatars1.githubusercontent.com/u/38097603?v=4","gravatar_id":"","url":"https://api.github.com/users/logicoffee","html_url":"https://github.com/logicoffee","followers_url":"https://api.github.com/users/logicoffee/followers","following_url":"https://api.github.com/users/logicoffee/following{/other_user}","gists_url":"https://api.github.com/users/logicoffee/gists{/gist_id}","starred_url":"https://api.github.com/users/logicoffee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logicoffee/subscriptions","organizations_url":"https://api.github.com/users/logicoffee/orgs","repos_url":"https://api.github.com/users/logicoffee/repos","events_url":"https://api.github.com/users/logicoffee/events{/privacy}","received_events_url":"https://api.github.com/users/logicoffee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-26T10:50:06Z","updated_at":"2018-11-28T08:10:21Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/logicoffee/carta_tournaments/pulls/9","html_url":"https://github.com/logicoffee/carta_tournaments/pull/9","diff_url":"https://github.com/logicoffee/carta_tournaments/pull/9.diff","patch_url":"https://github.com/logicoffee/carta_tournaments/pull/9.patch"},"body":"大会名をベタ書きしているところを修正しました.\r\n\r\n今回は1大会だけを扱うので, `this_tournament`というヘルパーメソッドを用意し, ルートページでもヘッダーでも大会名を表示できるようにしました.\r\n\r\n大会情報ページ`static_pages#info`は今後`tournament#show`にそのまま使えるような実装にしました.\r\n大会情報のうち空欄になっているものは, データベース上に保持するかどうか迷っています.\r\n各選手には, メーリスで流れる大会情報や, 全日協のページを見てもらうというのでも良さそうです.\r\n\r\nここまで実装していて疑問に感じたのは, `tournament_classes`の初期データをどのように与えるかです.\r\n環境変数にHashを保存できるのかと調べてみると, 文字列として保存したものをRails側でパースする, という方法がでてきました.\r\nこのような方法で行うのがよいのでしょうか？"},"comment":{"url":"https://api.github.com/repos/logicoffee/carta_tournaments/issues/comments/442356617","html_url":"https://github.com/logicoffee/carta_tournaments/pull/9#issuecomment-442356617","issue_url":"https://api.github.com/repos/logicoffee/carta_tournaments/issues/9","id":442356617,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjM1NjYxNw==","user":{"login":"yubessy","id":5637746,"node_id":"MDQ6VXNlcjU2Mzc3NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5637746?v=4","gravatar_id":"","url":"https://api.github.com/users/yubessy","html_url":"https://github.com/yubessy","followers_url":"https://api.github.com/users/yubessy/followers","following_url":"https://api.github.com/users/yubessy/following{/other_user}","gists_url":"https://api.github.com/users/yubessy/gists{/gist_id}","starred_url":"https://api.github.com/users/yubessy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yubessy/subscriptions","organizations_url":"https://api.github.com/users/yubessy/orgs","repos_url":"https://api.github.com/users/yubessy/repos","events_url":"https://api.github.com/users/yubessy/events{/privacy}","received_events_url":"https://api.github.com/users/yubessy/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T08:10:21Z","updated_at":"2018-11-28T08:10:21Z","author_association":"COLLABORATOR","body":"> 各選手には, メーリスで流れる大会情報や, 全日協のページを見てもらうというのでも良さそうです.\r\n\r\nこれでそんなに不便はないと思うのでこれで行きましょう。\r\n逆にもし締切日のような情報が案内と食い違ってたりすると混乱を招く恐れもあるので。\r\n\r\n> ここまで実装していて疑問に感じたのは, tournament_classesの初期データをどのように与えるかです.\r\n\r\n環境変数だと構造化データを保持するのは少しやりにくいので、YAMLか何かから読み込んでDBレコードを生成するスクリプト (Rake Task) を書いておくとかでどうでしょう"}}
{"actor":{"display_login":"yubessy"}}