{"action":"closed","number":33291,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/33291","id":199145776,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTQ1Nzc2","html_url":"https://github.com/rails/rails/pull/33291","diff_url":"https://github.com/rails/rails/pull/33291.diff","patch_url":"https://github.com/rails/rails/pull/33291.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/33291","number":33291,"state":"closed","locked":false,"title":"new_framework_defaults_5_2.rb is incompatible with load_default \"5.2\"","user":{"login":"yskkin","id":5965113,"node_id":"MDQ6VXNlcjU5NjUxMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5965113?v=4","gravatar_id":"","url":"https://api.github.com/users/yskkin","html_url":"https://github.com/yskkin","followers_url":"https://api.github.com/users/yskkin/followers","following_url":"https://api.github.com/users/yskkin/following{/other_user}","gists_url":"https://api.github.com/users/yskkin/gists{/gist_id}","starred_url":"https://api.github.com/users/yskkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yskkin/subscriptions","organizations_url":"https://api.github.com/users/yskkin/orgs","repos_url":"https://api.github.com/users/yskkin/repos","events_url":"https://api.github.com/users/yskkin/events{/privacy}","received_events_url":"https://api.github.com/users/yskkin/received_events","type":"User","site_admin":false},"body":"`load_default \"5.2\"` sets\r\n`Rails.application.config.action_view.form_with_generates_ids` to true\r\nbut new_framework_defaults_5_2.rb does not mention about it.\r\n\r\nrefs 36ac675d2af5838c81afbd7c95b2e403e6366ba5","created_at":"2018-07-04T05:59:01Z","updated_at":"2018-07-04T16:15:30Z","closed_at":"2018-07-04T16:15:30Z","merged_at":"2018-07-04T16:15:30Z","merge_commit_sha":"6ba94405efa971b03a2516a27d0306fd214cf64f","assignee":{"login":"kamipo","id":12642,"node_id":"MDQ6VXNlcjEyNjQy","avatar_url":"https://avatars0.githubusercontent.com/u/12642?v=4","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false},"assignees":[{"login":"kamipo","id":12642,"node_id":"MDQ6VXNlcjEyNjQy","avatar_url":"https://avatars0.githubusercontent.com/u/12642?v=4","gravatar_id":"","url":"https://api.github.com/users/kamipo","html_url":"https://github.com/kamipo","followers_url":"https://api.github.com/users/kamipo/followers","following_url":"https://api.github.com/users/kamipo/following{/other_user}","gists_url":"https://api.github.com/users/kamipo/gists{/gist_id}","starred_url":"https://api.github.com/users/kamipo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamipo/subscriptions","organizations_url":"https://api.github.com/users/kamipo/orgs","repos_url":"https://api.github.com/users/kamipo/repos","events_url":"https://api.github.com/users/kamipo/events{/privacy}","received_events_url":"https://api.github.com/users/kamipo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/33291/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/33291/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/33291/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/fd7b6845d2f0780377bcc06f5e615b9e32d2fa3b","head":{"label":"yskkin:form_with_generates_ids","ref":"form_with_generates_ids","sha":"fd7b6845d2f0780377bcc06f5e615b9e32d2fa3b","user":{"login":"yskkin","id":5965113,"node_id":"MDQ6VXNlcjU5NjUxMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5965113?v=4","gravatar_id":"","url":"https://api.github.com/users/yskkin","html_url":"https://github.com/yskkin","followers_url":"https://api.github.com/users/yskkin/followers","following_url":"https://api.github.com/users/yskkin/following{/other_user}","gists_url":"https://api.github.com/users/yskkin/gists{/gist_id}","starred_url":"https://api.github.com/users/yskkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yskkin/subscriptions","organizations_url":"https://api.github.com/users/yskkin/orgs","repos_url":"https://api.github.com/users/yskkin/repos","events_url":"https://api.github.com/users/yskkin/events{/privacy}","received_events_url":"https://api.github.com/users/yskkin/received_events","type":"User","site_admin":false},"repo":{"id":103800863,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM4MDA4NjM=","name":"rails","full_name":"yskkin/rails","owner":{"login":"yskkin","id":5965113,"node_id":"MDQ6VXNlcjU5NjUxMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5965113?v=4","gravatar_id":"","url":"https://api.github.com/users/yskkin","html_url":"https://github.com/yskkin","followers_url":"https://api.github.com/users/yskkin/followers","following_url":"https://api.github.com/users/yskkin/following{/other_user}","gists_url":"https://api.github.com/users/yskkin/gists{/gist_id}","starred_url":"https://api.github.com/users/yskkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yskkin/subscriptions","organizations_url":"https://api.github.com/users/yskkin/orgs","repos_url":"https://api.github.com/users/yskkin/repos","events_url":"https://api.github.com/users/yskkin/events{/privacy}","received_events_url":"https://api.github.com/users/yskkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yskkin/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/yskkin/rails","forks_url":"https://api.github.com/repos/yskkin/rails/forks","keys_url":"https://api.github.com/repos/yskkin/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yskkin/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yskkin/rails/teams","hooks_url":"https://api.github.com/repos/yskkin/rails/hooks","issue_events_url":"https://api.github.com/repos/yskkin/rails/issues/events{/number}","events_url":"https://api.github.com/repos/yskkin/rails/events","assignees_url":"https://api.github.com/repos/yskkin/rails/assignees{/user}","branches_url":"https://api.github.com/repos/yskkin/rails/branches{/branch}","tags_url":"https://api.github.com/repos/yskkin/rails/tags","blobs_url":"https://api.github.com/repos/yskkin/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yskkin/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yskkin/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/yskkin/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yskkin/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/yskkin/rails/languages","stargazers_url":"https://api.github.com/repos/yskkin/rails/stargazers","contributors_url":"https://api.github.com/repos/yskkin/rails/contributors","subscribers_url":"https://api.github.com/repos/yskkin/rails/subscribers","subscription_url":"https://api.github.com/repos/yskkin/rails/subscription","commits_url":"https://api.github.com/repos/yskkin/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/yskkin/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/yskkin/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/yskkin/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/yskkin/rails/contents/{+path}","compare_url":"https://api.github.com/repos/yskkin/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yskkin/rails/merges","archive_url":"https://api.github.com/repos/yskkin/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yskkin/rails/downloads","issues_url":"https://api.github.com/repos/yskkin/rails/issues{/number}","pulls_url":"https://api.github.com/repos/yskkin/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/yskkin/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/yskkin/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yskkin/rails/labels{/name}","releases_url":"https://api.github.com/repos/yskkin/rails/releases{/id}","deployments_url":"https://api.github.com/repos/yskkin/rails/deployments","created_at":"2017-09-17T03:40:49Z","updated_at":"2018-03-31T13:00:29Z","pushed_at":"2018-07-04T05:57:05Z","git_url":"git://github.com/yskkin/rails.git","ssh_url":"git@github.com:yskkin/rails.git","clone_url":"https://github.com/yskkin/rails.git","svn_url":"https://github.com/yskkin/rails","homepage":"http://rubyonrails.org","size":162562,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:5-2-stable","ref":"5-2-stable","sha":"2edd67eec55d5f8dfde0af6fdb7ce166135f8526","user":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"node_id":"MDEwOlJlcG9zaXRvcnk4NTE0","name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjM=","avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2018-07-04T14:54:40Z","pushed_at":"2018-07-04T16:15:29Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":164245,"stargazers_count":40086,"watchers_count":40086,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16173,"mirror_url":null,"archived":false,"open_issues_count":1130,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16173,"open_issues":1130,"watchers":40086,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/33291"},"html":{"href":"https://github.com/rails/rails/pull/33291"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/33291"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/33291/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/33291/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/33291/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/fd7b6845d2f0780377bcc06f5e615b9e32d2fa3b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kaspth","id":350807,"node_id":"MDQ6VXNlcjM1MDgwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/350807?v=4","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"kaspth"}}