{"action":"created","issue":{"url":"https://api.github.com/repos/wireapp/wire-ios/issues/3021","repository_url":"https://api.github.com/repos/wireapp/wire-ios","labels_url":"https://api.github.com/repos/wireapp/wire-ios/issues/3021/labels{/name}","comments_url":"https://api.github.com/repos/wireapp/wire-ios/issues/3021/comments","events_url":"https://api.github.com/repos/wireapp/wire-ios/issues/3021/events","html_url":"https://github.com/wireapp/wire-ios/pull/3021","id":389704575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjMzMDEz","number":3021,"title":"ZIOS-10991: Disable liking ephemeral messages","user":{"login":"alexaubry","id":16192914,"node_id":"MDQ6VXNlcjE2MTkyOTE0","avatar_url":"https://avatars2.githubusercontent.com/u/16192914?v=4","gravatar_id":"","url":"https://api.github.com/users/alexaubry","html_url":"https://github.com/alexaubry","followers_url":"https://api.github.com/users/alexaubry/followers","following_url":"https://api.github.com/users/alexaubry/following{/other_user}","gists_url":"https://api.github.com/users/alexaubry/gists{/gist_id}","starred_url":"https://api.github.com/users/alexaubry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexaubry/subscriptions","organizations_url":"https://api.github.com/users/alexaubry/orgs","repos_url":"https://api.github.com/users/alexaubry/repos","events_url":"https://api.github.com/users/alexaubry/events{/privacy}","received_events_url":"https://api.github.com/users/alexaubry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-11T10:53:37Z","updated_at":"2018-12-11T11:08:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios/pulls/3021","html_url":"https://github.com/wireapp/wire-ios/pull/3021","diff_url":"https://github.com/wireapp/wire-ios/pull/3021.diff","patch_url":"https://github.com/wireapp/wire-ios/pull/3021.patch"},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nIt was possible to like an ephemeral message by double tapping the message cell.\r\n\r\n### Causes\r\n\r\nIn the message cell, we were not checking if the message could be liked when performing the action.\r\n\r\n### Solutions\r\n\r\nMove the double tap action handling to the action controller, in a similar way to the single tap action.\r\n\r\n### Notes\r\n\r\nThis PR also includes the fixes from https://github.com/wireapp/wire-ios-data-model/pull/633 regarding liking a read message."},"comment":{"url":"https://api.github.com/repos/wireapp/wire-ios/issues/comments/446164164","html_url":"https://github.com/wireapp/wire-ios/pull/3021#issuecomment-446164164","issue_url":"https://api.github.com/repos/wireapp/wire-ios/issues/3021","id":446164164,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjE2NDE2NA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T11:08:04Z","updated_at":"2018-12-11T11:08:04Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/wireapp/wire-ios/pull/3021?src=pr&el=h1) Report\n> Merging [#3021](https://codecov.io/gh/wireapp/wire-ios/pull/3021?src=pr&el=desc) into [develop](https://codecov.io/gh/wireapp/wire-ios/commit/3f6a22bfef88e2a743ff3a42742c45abe0ab22cf?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `37.5%`.\n\n\n```diff\n@@            Coverage Diff             @@\n##           develop   #3021      +/-   ##\n==========================================\n+ Coverage    49.79%   49.8%   +<.01%     \n==========================================\n  Files          917     917              \n  Lines        47995   47994       -1     \n==========================================\n+ Hits         23901   23905       +4     \n+ Misses       24094   24089       -5\n```\n"}}
{"actor":{"display_login":"codecov-io"}}