{"action":"created","comment":{"url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/comments/191006274","pull_request_review_id":123509035,"id":191006274,"diff_hunk":"@@ -438,6 +287,17 @@ function New-WhiskeyProGetUniversalPackage\n         Copy-ToPackage -Path $TaskParameter['ThirdPartyPath'] -AsThirdPartyItem\r\n     }\r\n \r\n+    $badChars = [IO.Path]::GetInvalidFileNameChars() | ForEach-Object { [regex]::Escape($_) }\r\n+    $fixRegex = '[{0}]' -f ($badChars -join '')\r\n+    $fileName = '{0}.{1}.upack' -f $name,($version.SemVer2NoBuildMetadata -replace $fixRegex,'-')\r\n+\r\n+    $outFile = Join-Path -Path $TaskContext.OutputDirectory -ChildPath $fileName\r\n+\r\n+    Write-WhiskeyVerbose -Context $TaskContext -Message $fileName\r","path":"Whiskey/Tasks/New-WhiskeyProGetUniversalPackage.ps1","position":491,"original_position":491,"commit_id":"87c4936349ba4149f63abd8088e3bf8d0bdadebe","original_commit_id":"87c4936349ba4149f63abd8088e3bf8d0bdadebe","user":{"login":"splatteredbits","id":1082153,"avatar_url":"https://avatars1.githubusercontent.com/u/1082153?v=4","gravatar_id":"","url":"https://api.github.com/users/splatteredbits","html_url":"https://github.com/splatteredbits","followers_url":"https://api.github.com/users/splatteredbits/followers","following_url":"https://api.github.com/users/splatteredbits/following{/other_user}","gists_url":"https://api.github.com/users/splatteredbits/gists{/gist_id}","starred_url":"https://api.github.com/users/splatteredbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splatteredbits/subscriptions","organizations_url":"https://api.github.com/users/splatteredbits/orgs","repos_url":"https://api.github.com/users/splatteredbits/repos","events_url":"https://api.github.com/users/splatteredbits/events{/privacy}","received_events_url":"https://api.github.com/users/splatteredbits/received_events","type":"User","site_admin":false},"body":"No. Forgot about that Write-WhiskeyInfo. Just remoe the `tree` command output.","created_at":"2018-05-25T20:48:18Z","updated_at":"2018-05-25T20:48:18Z","html_url":"https://github.com/webmd-health-services/Whiskey/pull/171#discussion_r191006274","pull_request_url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/comments/191006274"},"html":{"href":"https://github.com/webmd-health-services/Whiskey/pull/171#discussion_r191006274"},"pull_request":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171"}},"in_reply_to_id":190998143},"pull_request":{"url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171","id":190644018,"html_url":"https://github.com/webmd-health-services/Whiskey/pull/171","diff_url":"https://github.com/webmd-health-services/Whiskey/pull/171.diff","patch_url":"https://github.com/webmd-health-services/Whiskey/pull/171.patch","issue_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/171","number":171,"state":"open","locked":false,"title":"Feature/custom upack metadata","user":{"login":"jlariono","id":30190605,"avatar_url":"https://avatars3.githubusercontent.com/u/30190605?v=4","gravatar_id":"","url":"https://api.github.com/users/jlariono","html_url":"https://github.com/jlariono","followers_url":"https://api.github.com/users/jlariono/followers","following_url":"https://api.github.com/users/jlariono/following{/other_user}","gists_url":"https://api.github.com/users/jlariono/gists{/gist_id}","starred_url":"https://api.github.com/users/jlariono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlariono/subscriptions","organizations_url":"https://api.github.com/users/jlariono/orgs","repos_url":"https://api.github.com/users/jlariono/repos","events_url":"https://api.github.com/users/jlariono/events{/privacy}","received_events_url":"https://api.github.com/users/jlariono/received_events","type":"User","site_admin":false},"body":"* Added `ManifestProperties` property to `ProGetUniversalPackage` task for setting custom upack.json metadata\r\n* Improved `ProGetUniversalPackage` task verbose messages","created_at":"2018-05-25T16:54:08Z","updated_at":"2018-05-25T20:48:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fce2f4e931beaeccd7a8b3d7d352751e0469482e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jeffprice6","id":26151533,"avatar_url":"https://avatars2.githubusercontent.com/u/26151533?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffprice6","html_url":"https://github.com/jeffprice6","followers_url":"https://api.github.com/users/jeffprice6/followers","following_url":"https://api.github.com/users/jeffprice6/following{/other_user}","gists_url":"https://api.github.com/users/jeffprice6/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffprice6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffprice6/subscriptions","organizations_url":"https://api.github.com/users/jeffprice6/orgs","repos_url":"https://api.github.com/users/jeffprice6/repos","events_url":"https://api.github.com/users/jeffprice6/events{/privacy}","received_events_url":"https://api.github.com/users/jeffprice6/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171/commits","review_comments_url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171/comments","review_comment_url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/171/comments","statuses_url":"https://api.github.com/repos/webmd-health-services/Whiskey/statuses/87c4936349ba4149f63abd8088e3bf8d0bdadebe","head":{"label":"webmd-health-services:feature/custom-upack-metadata","ref":"feature/custom-upack-metadata","sha":"87c4936349ba4149f63abd8088e3bf8d0bdadebe","user":{"login":"webmd-health-services","id":29462096,"avatar_url":"https://avatars3.githubusercontent.com/u/29462096?v=4","gravatar_id":"","url":"https://api.github.com/users/webmd-health-services","html_url":"https://github.com/webmd-health-services","followers_url":"https://api.github.com/users/webmd-health-services/followers","following_url":"https://api.github.com/users/webmd-health-services/following{/other_user}","gists_url":"https://api.github.com/users/webmd-health-services/gists{/gist_id}","starred_url":"https://api.github.com/users/webmd-health-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmd-health-services/subscriptions","organizations_url":"https://api.github.com/users/webmd-health-services/orgs","repos_url":"https://api.github.com/users/webmd-health-services/repos","events_url":"https://api.github.com/users/webmd-health-services/events{/privacy}","received_events_url":"https://api.github.com/users/webmd-health-services/received_events","type":"Organization","site_admin":false},"repo":{"id":95602988,"name":"Whiskey","full_name":"webmd-health-services/Whiskey","owner":{"login":"webmd-health-services","id":29462096,"avatar_url":"https://avatars3.githubusercontent.com/u/29462096?v=4","gravatar_id":"","url":"https://api.github.com/users/webmd-health-services","html_url":"https://github.com/webmd-health-services","followers_url":"https://api.github.com/users/webmd-health-services/followers","following_url":"https://api.github.com/users/webmd-health-services/following{/other_user}","gists_url":"https://api.github.com/users/webmd-health-services/gists{/gist_id}","starred_url":"https://api.github.com/users/webmd-health-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmd-health-services/subscriptions","organizations_url":"https://api.github.com/users/webmd-health-services/orgs","repos_url":"https://api.github.com/users/webmd-health-services/repos","events_url":"https://api.github.com/users/webmd-health-services/events{/privacy}","received_events_url":"https://api.github.com/users/webmd-health-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webmd-health-services/Whiskey","description":null,"fork":false,"url":"https://api.github.com/repos/webmd-health-services/Whiskey","forks_url":"https://api.github.com/repos/webmd-health-services/Whiskey/forks","keys_url":"https://api.github.com/repos/webmd-health-services/Whiskey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmd-health-services/Whiskey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmd-health-services/Whiskey/teams","hooks_url":"https://api.github.com/repos/webmd-health-services/Whiskey/hooks","issue_events_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/events{/number}","events_url":"https://api.github.com/repos/webmd-health-services/Whiskey/events","assignees_url":"https://api.github.com/repos/webmd-health-services/Whiskey/assignees{/user}","branches_url":"https://api.github.com/repos/webmd-health-services/Whiskey/branches{/branch}","tags_url":"https://api.github.com/repos/webmd-health-services/Whiskey/tags","blobs_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmd-health-services/Whiskey/statuses/{sha}","languages_url":"https://api.github.com/repos/webmd-health-services/Whiskey/languages","stargazers_url":"https://api.github.com/repos/webmd-health-services/Whiskey/stargazers","contributors_url":"https://api.github.com/repos/webmd-health-services/Whiskey/contributors","subscribers_url":"https://api.github.com/repos/webmd-health-services/Whiskey/subscribers","subscription_url":"https://api.github.com/repos/webmd-health-services/Whiskey/subscription","commits_url":"https://api.github.com/repos/webmd-health-services/Whiskey/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmd-health-services/Whiskey/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmd-health-services/Whiskey/contents/{+path}","compare_url":"https://api.github.com/repos/webmd-health-services/Whiskey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmd-health-services/Whiskey/merges","archive_url":"https://api.github.com/repos/webmd-health-services/Whiskey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmd-health-services/Whiskey/downloads","issues_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues{/number}","pulls_url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls{/number}","milestones_url":"https://api.github.com/repos/webmd-health-services/Whiskey/milestones{/number}","notifications_url":"https://api.github.com/repos/webmd-health-services/Whiskey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmd-health-services/Whiskey/labels{/name}","releases_url":"https://api.github.com/repos/webmd-health-services/Whiskey/releases{/id}","deployments_url":"https://api.github.com/repos/webmd-health-services/Whiskey/deployments","created_at":"2017-06-27T21:37:29Z","updated_at":"2018-05-23T22:18:24Z","pushed_at":"2018-05-25T16:54:09Z","git_url":"git://github.com/webmd-health-services/Whiskey.git","ssh_url":"git@github.com:webmd-health-services/Whiskey.git","clone_url":"https://github.com/webmd-health-services/Whiskey.git","svn_url":"https://github.com/webmd-health-services/Whiskey","homepage":null,"size":5674,"stargazers_count":7,"watchers_count":7,"language":"PowerShell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":1,"open_issues":16,"watchers":7,"default_branch":"develop"}},"base":{"label":"webmd-health-services:develop","ref":"develop","sha":"d213a798d7d9fd2512610a2017a83a3de1a3fa99","user":{"login":"webmd-health-services","id":29462096,"avatar_url":"https://avatars3.githubusercontent.com/u/29462096?v=4","gravatar_id":"","url":"https://api.github.com/users/webmd-health-services","html_url":"https://github.com/webmd-health-services","followers_url":"https://api.github.com/users/webmd-health-services/followers","following_url":"https://api.github.com/users/webmd-health-services/following{/other_user}","gists_url":"https://api.github.com/users/webmd-health-services/gists{/gist_id}","starred_url":"https://api.github.com/users/webmd-health-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmd-health-services/subscriptions","organizations_url":"https://api.github.com/users/webmd-health-services/orgs","repos_url":"https://api.github.com/users/webmd-health-services/repos","events_url":"https://api.github.com/users/webmd-health-services/events{/privacy}","received_events_url":"https://api.github.com/users/webmd-health-services/received_events","type":"Organization","site_admin":false},"repo":{"id":95602988,"name":"Whiskey","full_name":"webmd-health-services/Whiskey","owner":{"login":"webmd-health-services","id":29462096,"avatar_url":"https://avatars3.githubusercontent.com/u/29462096?v=4","gravatar_id":"","url":"https://api.github.com/users/webmd-health-services","html_url":"https://github.com/webmd-health-services","followers_url":"https://api.github.com/users/webmd-health-services/followers","following_url":"https://api.github.com/users/webmd-health-services/following{/other_user}","gists_url":"https://api.github.com/users/webmd-health-services/gists{/gist_id}","starred_url":"https://api.github.com/users/webmd-health-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmd-health-services/subscriptions","organizations_url":"https://api.github.com/users/webmd-health-services/orgs","repos_url":"https://api.github.com/users/webmd-health-services/repos","events_url":"https://api.github.com/users/webmd-health-services/events{/privacy}","received_events_url":"https://api.github.com/users/webmd-health-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webmd-health-services/Whiskey","description":null,"fork":false,"url":"https://api.github.com/repos/webmd-health-services/Whiskey","forks_url":"https://api.github.com/repos/webmd-health-services/Whiskey/forks","keys_url":"https://api.github.com/repos/webmd-health-services/Whiskey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmd-health-services/Whiskey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmd-health-services/Whiskey/teams","hooks_url":"https://api.github.com/repos/webmd-health-services/Whiskey/hooks","issue_events_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/events{/number}","events_url":"https://api.github.com/repos/webmd-health-services/Whiskey/events","assignees_url":"https://api.github.com/repos/webmd-health-services/Whiskey/assignees{/user}","branches_url":"https://api.github.com/repos/webmd-health-services/Whiskey/branches{/branch}","tags_url":"https://api.github.com/repos/webmd-health-services/Whiskey/tags","blobs_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmd-health-services/Whiskey/statuses/{sha}","languages_url":"https://api.github.com/repos/webmd-health-services/Whiskey/languages","stargazers_url":"https://api.github.com/repos/webmd-health-services/Whiskey/stargazers","contributors_url":"https://api.github.com/repos/webmd-health-services/Whiskey/contributors","subscribers_url":"https://api.github.com/repos/webmd-health-services/Whiskey/subscribers","subscription_url":"https://api.github.com/repos/webmd-health-services/Whiskey/subscription","commits_url":"https://api.github.com/repos/webmd-health-services/Whiskey/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmd-health-services/Whiskey/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmd-health-services/Whiskey/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmd-health-services/Whiskey/contents/{+path}","compare_url":"https://api.github.com/repos/webmd-health-services/Whiskey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmd-health-services/Whiskey/merges","archive_url":"https://api.github.com/repos/webmd-health-services/Whiskey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmd-health-services/Whiskey/downloads","issues_url":"https://api.github.com/repos/webmd-health-services/Whiskey/issues{/number}","pulls_url":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls{/number}","milestones_url":"https://api.github.com/repos/webmd-health-services/Whiskey/milestones{/number}","notifications_url":"https://api.github.com/repos/webmd-health-services/Whiskey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmd-health-services/Whiskey/labels{/name}","releases_url":"https://api.github.com/repos/webmd-health-services/Whiskey/releases{/id}","deployments_url":"https://api.github.com/repos/webmd-health-services/Whiskey/deployments","created_at":"2017-06-27T21:37:29Z","updated_at":"2018-05-23T22:18:24Z","pushed_at":"2018-05-25T16:54:09Z","git_url":"git://github.com/webmd-health-services/Whiskey.git","ssh_url":"git@github.com:webmd-health-services/Whiskey.git","clone_url":"https://github.com/webmd-health-services/Whiskey.git","svn_url":"https://github.com/webmd-health-services/Whiskey","homepage":null,"size":5674,"stargazers_count":7,"watchers_count":7,"language":"PowerShell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":1,"open_issues":16,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171"},"html":{"href":"https://github.com/webmd-health-services/Whiskey/pull/171"},"issue":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/171"},"comments":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/webmd-health-services/Whiskey/statuses/87c4936349ba4149f63abd8088e3bf8d0bdadebe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"splatteredbits"}}