{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/comments/176578586","pull_request_review_id":106309661,"id":176578586,"diff_hunk":"@@ -132,16 +133,14 @@ func newUpgrade(api *ssp.Client, log logs, now time.Time, cal cal, stack *ssp.St\n \n func schedule(api *ssp.Client, log logs, now time.Time, cal cal, envs envDataList) (uuid.UUID, error) {\n \tid := uuid.New()\n-\tnonProds := envs.filter(func(ed *envData) bool {\n-\t\treturn ed.Environment.Usage != ssp.UsageProduction && ed.needsUpgrade()\n-\t})\n-\tprods := envs.filter(func(ed *envData) bool {\n-\t\treturn ed.Environment.Usage == ssp.UsageProduction && ed.needsUpgrade()\n+\tenvList := envs.filter(func(ed *envData) bool {\n+\t\treturn ed.needsUpgrade()\n \t})\n \n+\tsort.Sort(ByType(envList))\n \tvar earliestProdStart time.Time","path":"cmd/autoupgrader/scheduler.go","position":22,"original_position":22,"commit_id":"67cfaf5ea772a2a22786db10dcc59f6f9cc1eb25","original_commit_id":"67cfaf5ea772a2a22786db10dcc59f6f9cc1eb25","user":{"login":"mateusz","id":118653,"avatar_url":"https://avatars2.githubusercontent.com/u/118653?v=4","gravatar_id":"","url":"https://api.github.com/users/mateusz","html_url":"https://github.com/mateusz","followers_url":"https://api.github.com/users/mateusz/followers","following_url":"https://api.github.com/users/mateusz/following{/other_user}","gists_url":"https://api.github.com/users/mateusz/gists{/gist_id}","starred_url":"https://api.github.com/users/mateusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mateusz/subscriptions","organizations_url":"https://api.github.com/users/mateusz/orgs","repos_url":"https://api.github.com/users/mateusz/repos","events_url":"https://api.github.com/users/mateusz/events{/privacy}","received_events_url":"https://api.github.com/users/mateusz/received_events","type":"User","site_admin":false},"body":"This is badly named now.","created_at":"2018-03-22T21:31:51Z","updated_at":"2018-03-22T21:31:52Z","html_url":"https://github.com/silverstripeltd/ssp-agents/pull/16#discussion_r176578586","pull_request_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/comments/176578586"},"html":{"href":"https://github.com/silverstripeltd/ssp-agents/pull/16#discussion_r176578586"},"pull_request":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16","id":175376921,"html_url":"https://github.com/silverstripeltd/ssp-agents/pull/16","diff_url":"https://github.com/silverstripeltd/ssp-agents/pull/16.diff","patch_url":"https://github.com/silverstripeltd/ssp-agents/pull/16.patch","issue_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/16","number":16,"state":"open","locked":false,"title":"Sort functionality to sort environment list with prod last","user":{"login":"stojg","id":485130,"avatar_url":"https://avatars3.githubusercontent.com/u/485130?v=4","gravatar_id":"","url":"https://api.github.com/users/stojg","html_url":"https://github.com/stojg","followers_url":"https://api.github.com/users/stojg/followers","following_url":"https://api.github.com/users/stojg/following{/other_user}","gists_url":"https://api.github.com/users/stojg/gists{/gist_id}","starred_url":"https://api.github.com/users/stojg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stojg/subscriptions","organizations_url":"https://api.github.com/users/stojg/orgs","repos_url":"https://api.github.com/users/stojg/repos","events_url":"https://api.github.com/users/stojg/events{/privacy}","received_events_url":"https://api.github.com/users/stojg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-15T20:58:01Z","updated_at":"2018-03-22T21:31:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85e92a926812bbad2b578fab9dc167367883cc6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16/commits","review_comments_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16/comments","review_comment_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/16/comments","statuses_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/statuses/67cfaf5ea772a2a22786db10dcc59f6f9cc1eb25","head":{"label":"silverstripeltd:envlist-sorter","ref":"envlist-sorter","sha":"67cfaf5ea772a2a22786db10dcc59f6f9cc1eb25","user":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"repo":{"id":109742674,"name":"ssp-agents","full_name":"silverstripeltd/ssp-agents","owner":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripeltd/ssp-agents","description":null,"fork":false,"url":"https://api.github.com/repos/silverstripeltd/ssp-agents","forks_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/forks","keys_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/teams","hooks_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/hooks","issue_events_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/events","assignees_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/tags","blobs_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/languages","stargazers_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/stargazers","contributors_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/contributors","subscribers_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/subscribers","subscription_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/subscription","commits_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/merges","archive_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/downloads","issues_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/labels{/name}","releases_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/deployments","created_at":"2017-11-06T19:53:49Z","updated_at":"2017-12-04T03:38:30Z","pushed_at":"2018-03-15T20:58:02Z","git_url":"git://github.com/silverstripeltd/ssp-agents.git","ssh_url":"git@github.com:silverstripeltd/ssp-agents.git","clone_url":"https://github.com/silverstripeltd/ssp-agents.git","svn_url":"https://github.com/silverstripeltd/ssp-agents","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripeltd:master","ref":"master","sha":"01bec0e51ae4b41ab5f290ad305eb5772f6d16f7","user":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"repo":{"id":109742674,"name":"ssp-agents","full_name":"silverstripeltd/ssp-agents","owner":{"login":"silverstripeltd","id":13305531,"avatar_url":"https://avatars0.githubusercontent.com/u/13305531?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripeltd","html_url":"https://github.com/silverstripeltd","followers_url":"https://api.github.com/users/silverstripeltd/followers","following_url":"https://api.github.com/users/silverstripeltd/following{/other_user}","gists_url":"https://api.github.com/users/silverstripeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripeltd/subscriptions","organizations_url":"https://api.github.com/users/silverstripeltd/orgs","repos_url":"https://api.github.com/users/silverstripeltd/repos","events_url":"https://api.github.com/users/silverstripeltd/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripeltd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripeltd/ssp-agents","description":null,"fork":false,"url":"https://api.github.com/repos/silverstripeltd/ssp-agents","forks_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/forks","keys_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/teams","hooks_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/hooks","issue_events_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/events","assignees_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/tags","blobs_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/languages","stargazers_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/stargazers","contributors_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/contributors","subscribers_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/subscribers","subscription_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/subscription","commits_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/merges","archive_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/downloads","issues_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/labels{/name}","releases_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripeltd/ssp-agents/deployments","created_at":"2017-11-06T19:53:49Z","updated_at":"2017-12-04T03:38:30Z","pushed_at":"2018-03-15T20:58:02Z","git_url":"git://github.com/silverstripeltd/ssp-agents.git","ssh_url":"git@github.com:silverstripeltd/ssp-agents.git","clone_url":"https://github.com/silverstripeltd/ssp-agents.git","svn_url":"https://github.com/silverstripeltd/ssp-agents","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16"},"html":{"href":"https://github.com/silverstripeltd/ssp-agents/pull/16"},"issue":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/16"},"comments":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripeltd/ssp-agents/statuses/67cfaf5ea772a2a22786db10dcc59f6f9cc1eb25"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mateusz"}}