{"action":"created","comment":{"url":"https://api.github.com/repos/gosukiwi/alerter/pulls/comments/213947192","pull_request_review_id":150890640,"id":213947192,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzk0NzE5Mg==","diff_hunk":"@@ -120,35 +133,86 @@\n             conf = { 'text' : conf };\n         }\n \n-        activeAlerts += 1;\n+        ++activeAlerts;\n \n         options = extend(defaults, conf);\n \n         container = document.createElement('div');\n \n-        if(options.orientation === 'left') {\n+        if (options.id)   {\n+            if (typeof options.id === 'string') {\n+                container.id = options.id;\n+            }\n+            else {\n+                return console.error('Bad id.');\n+            }\n+        }\n+\n+        if (options.cssClassName)   {","path":"alerter.js","position":137,"original_position":137,"commit_id":"441bef66b286919e5e4abd463758c1582e4d8836","original_commit_id":"441bef66b286919e5e4abd463758c1582e4d8836","user":{"login":"IasoDigital","id":31987036,"node_id":"MDQ6VXNlcjMxOTg3MDM2","avatar_url":"https://avatars1.githubusercontent.com/u/31987036?v=4","gravatar_id":"","url":"https://api.github.com/users/IasoDigital","html_url":"https://github.com/IasoDigital","followers_url":"https://api.github.com/users/IasoDigital/followers","following_url":"https://api.github.com/users/IasoDigital/following{/other_user}","gists_url":"https://api.github.com/users/IasoDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/IasoDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IasoDigital/subscriptions","organizations_url":"https://api.github.com/users/IasoDigital/orgs","repos_url":"https://api.github.com/users/IasoDigital/repos","events_url":"https://api.github.com/users/IasoDigital/events{/privacy}","received_events_url":"https://api.github.com/users/IasoDigital/received_events","type":"User","site_admin":false},"body":"Ignore it on invalid classname is a good solution. I'll do that.\r\n","created_at":"2018-08-30T08:37:42Z","updated_at":"2018-08-30T08:37:42Z","html_url":"https://github.com/gosukiwi/alerter/pull/3#discussion_r213947192","pull_request_url":"https://api.github.com/repos/gosukiwi/alerter/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gosukiwi/alerter/pulls/comments/213947192"},"html":{"href":"https://github.com/gosukiwi/alerter/pull/3#discussion_r213947192"},"pull_request":{"href":"https://api.github.com/repos/gosukiwi/alerter/pulls/3"}},"in_reply_to_id":213707019},"pull_request":{"url":"https://api.github.com/repos/gosukiwi/alerter/pulls/3","id":211709645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzA5NjQ1","html_url":"https://github.com/gosukiwi/alerter/pull/3","diff_url":"https://github.com/gosukiwi/alerter/pull/3.diff","patch_url":"https://github.com/gosukiwi/alerter/pull/3.patch","issue_url":"https://api.github.com/repos/gosukiwi/alerter/issues/3","number":3,"state":"open","locked":false,"title":"Configuration updated and error handling/logging added","user":{"login":"IasoDigital","id":31987036,"node_id":"MDQ6VXNlcjMxOTg3MDM2","avatar_url":"https://avatars1.githubusercontent.com/u/31987036?v=4","gravatar_id":"","url":"https://api.github.com/users/IasoDigital","html_url":"https://github.com/IasoDigital","followers_url":"https://api.github.com/users/IasoDigital/followers","following_url":"https://api.github.com/users/IasoDigital/following{/other_user}","gists_url":"https://api.github.com/users/IasoDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/IasoDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IasoDigital/subscriptions","organizations_url":"https://api.github.com/users/IasoDigital/orgs","repos_url":"https://api.github.com/users/IasoDigital/repos","events_url":"https://api.github.com/users/IasoDigital/events{/privacy}","received_events_url":"https://api.github.com/users/IasoDigital/received_events","type":"User","site_admin":false},"body":"New parameters:\r\nid\r\ncssClassName\r\nStyles array\r\nclickCallback\r\nxOrientation\r\nyOrientation\r\n\r\nStyle precedence : Styles array > id > cssClassName\r\n\r\nRenamed parameters :\r\ncallback => fadeOutCallback","created_at":"2018-08-29T10:49:52Z","updated_at":"2018-08-30T08:37:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e217e67998de6ccf1e8884b5745f7b836def400","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gosukiwi/alerter/pulls/3/commits","review_comments_url":"https://api.github.com/repos/gosukiwi/alerter/pulls/3/comments","review_comment_url":"https://api.github.com/repos/gosukiwi/alerter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gosukiwi/alerter/issues/3/comments","statuses_url":"https://api.github.com/repos/gosukiwi/alerter/statuses/441bef66b286919e5e4abd463758c1582e4d8836","head":{"label":"IasoDigital:master","ref":"master","sha":"441bef66b286919e5e4abd463758c1582e4d8836","user":{"login":"IasoDigital","id":31987036,"node_id":"MDQ6VXNlcjMxOTg3MDM2","avatar_url":"https://avatars1.githubusercontent.com/u/31987036?v=4","gravatar_id":"","url":"https://api.github.com/users/IasoDigital","html_url":"https://github.com/IasoDigital","followers_url":"https://api.github.com/users/IasoDigital/followers","following_url":"https://api.github.com/users/IasoDigital/following{/other_user}","gists_url":"https://api.github.com/users/IasoDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/IasoDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IasoDigital/subscriptions","organizations_url":"https://api.github.com/users/IasoDigital/orgs","repos_url":"https://api.github.com/users/IasoDigital/repos","events_url":"https://api.github.com/users/IasoDigital/events{/privacy}","received_events_url":"https://api.github.com/users/IasoDigital/received_events","type":"User","site_admin":false},"repo":{"id":146575948,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY1NzU5NDg=","name":"alerter","full_name":"IasoDigital/alerter","owner":{"login":"IasoDigital","id":31987036,"node_id":"MDQ6VXNlcjMxOTg3MDM2","avatar_url":"https://avatars1.githubusercontent.com/u/31987036?v=4","gravatar_id":"","url":"https://api.github.com/users/IasoDigital","html_url":"https://github.com/IasoDigital","followers_url":"https://api.github.com/users/IasoDigital/followers","following_url":"https://api.github.com/users/IasoDigital/following{/other_user}","gists_url":"https://api.github.com/users/IasoDigital/gists{/gist_id}","starred_url":"https://api.github.com/users/IasoDigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IasoDigital/subscriptions","organizations_url":"https://api.github.com/users/IasoDigital/orgs","repos_url":"https://api.github.com/users/IasoDigital/repos","events_url":"https://api.github.com/users/IasoDigital/events{/privacy}","received_events_url":"https://api.github.com/users/IasoDigital/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IasoDigital/alerter","description":"Non-obstrusive vanilla-javascript stackable alerts","fork":true,"url":"https://api.github.com/repos/IasoDigital/alerter","forks_url":"https://api.github.com/repos/IasoDigital/alerter/forks","keys_url":"https://api.github.com/repos/IasoDigital/alerter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IasoDigital/alerter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IasoDigital/alerter/teams","hooks_url":"https://api.github.com/repos/IasoDigital/alerter/hooks","issue_events_url":"https://api.github.com/repos/IasoDigital/alerter/issues/events{/number}","events_url":"https://api.github.com/repos/IasoDigital/alerter/events","assignees_url":"https://api.github.com/repos/IasoDigital/alerter/assignees{/user}","branches_url":"https://api.github.com/repos/IasoDigital/alerter/branches{/branch}","tags_url":"https://api.github.com/repos/IasoDigital/alerter/tags","blobs_url":"https://api.github.com/repos/IasoDigital/alerter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IasoDigital/alerter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IasoDigital/alerter/git/refs{/sha}","trees_url":"https://api.github.com/repos/IasoDigital/alerter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IasoDigital/alerter/statuses/{sha}","languages_url":"https://api.github.com/repos/IasoDigital/alerter/languages","stargazers_url":"https://api.github.com/repos/IasoDigital/alerter/stargazers","contributors_url":"https://api.github.com/repos/IasoDigital/alerter/contributors","subscribers_url":"https://api.github.com/repos/IasoDigital/alerter/subscribers","subscription_url":"https://api.github.com/repos/IasoDigital/alerter/subscription","commits_url":"https://api.github.com/repos/IasoDigital/alerter/commits{/sha}","git_commits_url":"https://api.github.com/repos/IasoDigital/alerter/git/commits{/sha}","comments_url":"https://api.github.com/repos/IasoDigital/alerter/comments{/number}","issue_comment_url":"https://api.github.com/repos/IasoDigital/alerter/issues/comments{/number}","contents_url":"https://api.github.com/repos/IasoDigital/alerter/contents/{+path}","compare_url":"https://api.github.com/repos/IasoDigital/alerter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IasoDigital/alerter/merges","archive_url":"https://api.github.com/repos/IasoDigital/alerter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IasoDigital/alerter/downloads","issues_url":"https://api.github.com/repos/IasoDigital/alerter/issues{/number}","pulls_url":"https://api.github.com/repos/IasoDigital/alerter/pulls{/number}","milestones_url":"https://api.github.com/repos/IasoDigital/alerter/milestones{/number}","notifications_url":"https://api.github.com/repos/IasoDigital/alerter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IasoDigital/alerter/labels{/name}","releases_url":"https://api.github.com/repos/IasoDigital/alerter/releases{/id}","deployments_url":"https://api.github.com/repos/IasoDigital/alerter/deployments","created_at":"2018-08-29T09:20:00Z","updated_at":"2018-08-29T10:47:50Z","pushed_at":"2018-08-29T10:47:49Z","git_url":"git://github.com/IasoDigital/alerter.git","ssh_url":"git@github.com:IasoDigital/alerter.git","clone_url":"https://github.com/IasoDigital/alerter.git","svn_url":"https://github.com/IasoDigital/alerter","homepage":"","size":15,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gosukiwi:master","ref":"master","sha":"157bf34e4bf07703d2b41e89ff2e9b02a122be91","user":{"login":"gosukiwi","id":161972,"node_id":"MDQ6VXNlcjE2MTk3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/161972?v=4","gravatar_id":"","url":"https://api.github.com/users/gosukiwi","html_url":"https://github.com/gosukiwi","followers_url":"https://api.github.com/users/gosukiwi/followers","following_url":"https://api.github.com/users/gosukiwi/following{/other_user}","gists_url":"https://api.github.com/users/gosukiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/gosukiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosukiwi/subscriptions","organizations_url":"https://api.github.com/users/gosukiwi/orgs","repos_url":"https://api.github.com/users/gosukiwi/repos","events_url":"https://api.github.com/users/gosukiwi/events{/privacy}","received_events_url":"https://api.github.com/users/gosukiwi/received_events","type":"User","site_admin":false},"repo":{"id":7035602,"node_id":"MDEwOlJlcG9zaXRvcnk3MDM1NjAy","name":"alerter","full_name":"gosukiwi/alerter","owner":{"login":"gosukiwi","id":161972,"node_id":"MDQ6VXNlcjE2MTk3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/161972?v=4","gravatar_id":"","url":"https://api.github.com/users/gosukiwi","html_url":"https://github.com/gosukiwi","followers_url":"https://api.github.com/users/gosukiwi/followers","following_url":"https://api.github.com/users/gosukiwi/following{/other_user}","gists_url":"https://api.github.com/users/gosukiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/gosukiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosukiwi/subscriptions","organizations_url":"https://api.github.com/users/gosukiwi/orgs","repos_url":"https://api.github.com/users/gosukiwi/repos","events_url":"https://api.github.com/users/gosukiwi/events{/privacy}","received_events_url":"https://api.github.com/users/gosukiwi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gosukiwi/alerter","description":"Non-obstrusive vanilla-javascript stackable alerts","fork":false,"url":"https://api.github.com/repos/gosukiwi/alerter","forks_url":"https://api.github.com/repos/gosukiwi/alerter/forks","keys_url":"https://api.github.com/repos/gosukiwi/alerter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosukiwi/alerter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosukiwi/alerter/teams","hooks_url":"https://api.github.com/repos/gosukiwi/alerter/hooks","issue_events_url":"https://api.github.com/repos/gosukiwi/alerter/issues/events{/number}","events_url":"https://api.github.com/repos/gosukiwi/alerter/events","assignees_url":"https://api.github.com/repos/gosukiwi/alerter/assignees{/user}","branches_url":"https://api.github.com/repos/gosukiwi/alerter/branches{/branch}","tags_url":"https://api.github.com/repos/gosukiwi/alerter/tags","blobs_url":"https://api.github.com/repos/gosukiwi/alerter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosukiwi/alerter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosukiwi/alerter/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosukiwi/alerter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosukiwi/alerter/statuses/{sha}","languages_url":"https://api.github.com/repos/gosukiwi/alerter/languages","stargazers_url":"https://api.github.com/repos/gosukiwi/alerter/stargazers","contributors_url":"https://api.github.com/repos/gosukiwi/alerter/contributors","subscribers_url":"https://api.github.com/repos/gosukiwi/alerter/subscribers","subscription_url":"https://api.github.com/repos/gosukiwi/alerter/subscription","commits_url":"https://api.github.com/repos/gosukiwi/alerter/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosukiwi/alerter/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosukiwi/alerter/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosukiwi/alerter/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosukiwi/alerter/contents/{+path}","compare_url":"https://api.github.com/repos/gosukiwi/alerter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosukiwi/alerter/merges","archive_url":"https://api.github.com/repos/gosukiwi/alerter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosukiwi/alerter/downloads","issues_url":"https://api.github.com/repos/gosukiwi/alerter/issues{/number}","pulls_url":"https://api.github.com/repos/gosukiwi/alerter/pulls{/number}","milestones_url":"https://api.github.com/repos/gosukiwi/alerter/milestones{/number}","notifications_url":"https://api.github.com/repos/gosukiwi/alerter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosukiwi/alerter/labels{/name}","releases_url":"https://api.github.com/repos/gosukiwi/alerter/releases{/id}","deployments_url":"https://api.github.com/repos/gosukiwi/alerter/deployments","created_at":"2012-12-06T12:54:13Z","updated_at":"2018-08-28T07:25:58Z","pushed_at":"2018-08-29T10:49:52Z","git_url":"git://github.com/gosukiwi/alerter.git","ssh_url":"git@github.com:gosukiwi/alerter.git","clone_url":"https://github.com/gosukiwi/alerter.git","svn_url":"https://github.com/gosukiwi/alerter","homepage":"","size":11,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gosukiwi/alerter/pulls/3"},"html":{"href":"https://github.com/gosukiwi/alerter/pull/3"},"issue":{"href":"https://api.github.com/repos/gosukiwi/alerter/issues/3"},"comments":{"href":"https://api.github.com/repos/gosukiwi/alerter/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/gosukiwi/alerter/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/gosukiwi/alerter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gosukiwi/alerter/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/gosukiwi/alerter/statuses/441bef66b286919e5e4abd463758c1582e4d8836"}},"author_association":"NONE"}}
{"actor":{"display_login":"IasoDigital"}}