{"action":"opened","number":39,"pull_request":{"url":"https://api.github.com/repos/innogames/openfl/pulls/39","id":199455955,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDU1OTU1","html_url":"https://github.com/innogames/openfl/pull/39","diff_url":"https://github.com/innogames/openfl/pull/39.diff","patch_url":"https://github.com/innogames/openfl/pull/39.patch","issue_url":"https://api.github.com/repos/innogames/openfl/issues/39","number":39,"state":"open","locked":false,"title":"handle alpha properly for GlowFilter and DropShadowFilter","user":{"login":"nadako","id":49749,"node_id":"MDQ6VXNlcjQ5NzQ5","avatar_url":"https://avatars0.githubusercontent.com/u/49749?v=4","gravatar_id":"","url":"https://api.github.com/users/nadako","html_url":"https://github.com/nadako","followers_url":"https://api.github.com/users/nadako/followers","following_url":"https://api.github.com/users/nadako/following{/other_user}","gists_url":"https://api.github.com/users/nadako/gists{/gist_id}","starred_url":"https://api.github.com/users/nadako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadako/subscriptions","organizations_url":"https://api.github.com/users/nadako/orgs","repos_url":"https://api.github.com/users/nadako/repos","events_url":"https://api.github.com/users/nadako/events{/privacy}","received_events_url":"https://api.github.com/users/nadako/received_events","type":"User","site_admin":false},"body":"I _think_ this is the correct way the `alpha` parameter should be treated.\r\n\r\nWhat was there before:\r\n - For `DropShadowFilter`, the `__alpha` value wasn't used at all, and instead it tried to get the alpha from the color and then add it to the image. But since the color is just `RGB`, the `a` value would always end up being `0`, so no effect at all.\r\n - For `GlowFilter`, the `__alpha` value was added to the image, so if we e.g. have `0.5` alpha in the filter and `0.5` alpha in the image, the resulting pixel would be fully opaque.\r\n\r\nWhat is there now:\r\n - Both filters use `__alpha` for actually substracting the alpha value from the image, so e.g. if we have a source alpha of `0.75` and the filter alpha of `0.5`, the resulting pixel will have alpha value of `0.25`.\r\n\r\nThis sounds correct to me and seems to fix our glow filter issues.","created_at":"2018-07-05T12:36:16Z","updated_at":"2018-07-05T12:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/innogames/openfl/pulls/39/commits","review_comments_url":"https://api.github.com/repos/innogames/openfl/pulls/39/comments","review_comment_url":"https://api.github.com/repos/innogames/openfl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/innogames/openfl/issues/39/comments","statuses_url":"https://api.github.com/repos/innogames/openfl/statuses/97ecb2eb0e7f56d0792715bdfd8060a35c8344a2","head":{"label":"innogames:filter_alpha","ref":"filter_alpha","sha":"97ecb2eb0e7f56d0792715bdfd8060a35c8344a2","user":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"repo":{"id":88423138,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQyMzEzOA==","name":"openfl","full_name":"innogames/openfl","owner":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/innogames/openfl","description":"The \"Open Flash Library\" for fast 2D development","fork":true,"url":"https://api.github.com/repos/innogames/openfl","forks_url":"https://api.github.com/repos/innogames/openfl/forks","keys_url":"https://api.github.com/repos/innogames/openfl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/innogames/openfl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/innogames/openfl/teams","hooks_url":"https://api.github.com/repos/innogames/openfl/hooks","issue_events_url":"https://api.github.com/repos/innogames/openfl/issues/events{/number}","events_url":"https://api.github.com/repos/innogames/openfl/events","assignees_url":"https://api.github.com/repos/innogames/openfl/assignees{/user}","branches_url":"https://api.github.com/repos/innogames/openfl/branches{/branch}","tags_url":"https://api.github.com/repos/innogames/openfl/tags","blobs_url":"https://api.github.com/repos/innogames/openfl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/innogames/openfl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/innogames/openfl/git/refs{/sha}","trees_url":"https://api.github.com/repos/innogames/openfl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/innogames/openfl/statuses/{sha}","languages_url":"https://api.github.com/repos/innogames/openfl/languages","stargazers_url":"https://api.github.com/repos/innogames/openfl/stargazers","contributors_url":"https://api.github.com/repos/innogames/openfl/contributors","subscribers_url":"https://api.github.com/repos/innogames/openfl/subscribers","subscription_url":"https://api.github.com/repos/innogames/openfl/subscription","commits_url":"https://api.github.com/repos/innogames/openfl/commits{/sha}","git_commits_url":"https://api.github.com/repos/innogames/openfl/git/commits{/sha}","comments_url":"https://api.github.com/repos/innogames/openfl/comments{/number}","issue_comment_url":"https://api.github.com/repos/innogames/openfl/issues/comments{/number}","contents_url":"https://api.github.com/repos/innogames/openfl/contents/{+path}","compare_url":"https://api.github.com/repos/innogames/openfl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/innogames/openfl/merges","archive_url":"https://api.github.com/repos/innogames/openfl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/innogames/openfl/downloads","issues_url":"https://api.github.com/repos/innogames/openfl/issues{/number}","pulls_url":"https://api.github.com/repos/innogames/openfl/pulls{/number}","milestones_url":"https://api.github.com/repos/innogames/openfl/milestones{/number}","notifications_url":"https://api.github.com/repos/innogames/openfl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/innogames/openfl/labels{/name}","releases_url":"https://api.github.com/repos/innogames/openfl/releases{/id}","deployments_url":"https://api.github.com/repos/innogames/openfl/deployments","created_at":"2017-04-16T15:36:14Z","updated_at":"2018-07-04T11:53:17Z","pushed_at":"2018-07-05T12:23:17Z","git_url":"git://github.com/innogames/openfl.git","ssh_url":"git@github.com:innogames/openfl.git","clone_url":"https://github.com/innogames/openfl.git","svn_url":"https://github.com/innogames/openfl","homepage":"http://www.openfl.org","size":19635,"stargazers_count":2,"watchers_count":2,"language":"Haxe","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"innogames:develop","ref":"develop","sha":"d57784e162ae4e9efb221a54ba16c1ccf0756de7","user":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"repo":{"id":88423138,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQyMzEzOA==","name":"openfl","full_name":"innogames/openfl","owner":{"login":"innogames","id":1314968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTQ5Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1314968?v=4","gravatar_id":"","url":"https://api.github.com/users/innogames","html_url":"https://github.com/innogames","followers_url":"https://api.github.com/users/innogames/followers","following_url":"https://api.github.com/users/innogames/following{/other_user}","gists_url":"https://api.github.com/users/innogames/gists{/gist_id}","starred_url":"https://api.github.com/users/innogames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/innogames/subscriptions","organizations_url":"https://api.github.com/users/innogames/orgs","repos_url":"https://api.github.com/users/innogames/repos","events_url":"https://api.github.com/users/innogames/events{/privacy}","received_events_url":"https://api.github.com/users/innogames/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/innogames/openfl","description":"The \"Open Flash Library\" for fast 2D development","fork":true,"url":"https://api.github.com/repos/innogames/openfl","forks_url":"https://api.github.com/repos/innogames/openfl/forks","keys_url":"https://api.github.com/repos/innogames/openfl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/innogames/openfl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/innogames/openfl/teams","hooks_url":"https://api.github.com/repos/innogames/openfl/hooks","issue_events_url":"https://api.github.com/repos/innogames/openfl/issues/events{/number}","events_url":"https://api.github.com/repos/innogames/openfl/events","assignees_url":"https://api.github.com/repos/innogames/openfl/assignees{/user}","branches_url":"https://api.github.com/repos/innogames/openfl/branches{/branch}","tags_url":"https://api.github.com/repos/innogames/openfl/tags","blobs_url":"https://api.github.com/repos/innogames/openfl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/innogames/openfl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/innogames/openfl/git/refs{/sha}","trees_url":"https://api.github.com/repos/innogames/openfl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/innogames/openfl/statuses/{sha}","languages_url":"https://api.github.com/repos/innogames/openfl/languages","stargazers_url":"https://api.github.com/repos/innogames/openfl/stargazers","contributors_url":"https://api.github.com/repos/innogames/openfl/contributors","subscribers_url":"https://api.github.com/repos/innogames/openfl/subscribers","subscription_url":"https://api.github.com/repos/innogames/openfl/subscription","commits_url":"https://api.github.com/repos/innogames/openfl/commits{/sha}","git_commits_url":"https://api.github.com/repos/innogames/openfl/git/commits{/sha}","comments_url":"https://api.github.com/repos/innogames/openfl/comments{/number}","issue_comment_url":"https://api.github.com/repos/innogames/openfl/issues/comments{/number}","contents_url":"https://api.github.com/repos/innogames/openfl/contents/{+path}","compare_url":"https://api.github.com/repos/innogames/openfl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/innogames/openfl/merges","archive_url":"https://api.github.com/repos/innogames/openfl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/innogames/openfl/downloads","issues_url":"https://api.github.com/repos/innogames/openfl/issues{/number}","pulls_url":"https://api.github.com/repos/innogames/openfl/pulls{/number}","milestones_url":"https://api.github.com/repos/innogames/openfl/milestones{/number}","notifications_url":"https://api.github.com/repos/innogames/openfl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/innogames/openfl/labels{/name}","releases_url":"https://api.github.com/repos/innogames/openfl/releases{/id}","deployments_url":"https://api.github.com/repos/innogames/openfl/deployments","created_at":"2017-04-16T15:36:14Z","updated_at":"2018-07-04T11:53:17Z","pushed_at":"2018-07-05T12:23:17Z","git_url":"git://github.com/innogames/openfl.git","ssh_url":"git@github.com:innogames/openfl.git","clone_url":"https://github.com/innogames/openfl.git","svn_url":"https://github.com/innogames/openfl","homepage":"http://www.openfl.org","size":19635,"stargazers_count":2,"watchers_count":2,"language":"Haxe","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/innogames/openfl/pulls/39"},"html":{"href":"https://github.com/innogames/openfl/pull/39"},"issue":{"href":"https://api.github.com/repos/innogames/openfl/issues/39"},"comments":{"href":"https://api.github.com/repos/innogames/openfl/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/innogames/openfl/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/innogames/openfl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/innogames/openfl/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/innogames/openfl/statuses/97ecb2eb0e7f56d0792715bdfd8060a35c8344a2"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"nadako"}}