{"action":"created","issue":{"url":"https://api.github.com/repos/alipay/sofa-mosn/issues/325","repository_url":"https://api.github.com/repos/alipay/sofa-mosn","labels_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/325/labels{/name}","comments_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/325/comments","events_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/325/events","html_url":"https://github.com/alipay/sofa-mosn/pull/325","id":373344046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1Mjk0NzE3","number":325,"title":"add mixer filter in mosn","user":{"login":"lichuang","id":1998569,"node_id":"MDQ6VXNlcjE5OTg1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/1998569?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuang","html_url":"https://github.com/lichuang","followers_url":"https://api.github.com/users/lichuang/followers","following_url":"https://api.github.com/users/lichuang/following{/other_user}","gists_url":"https://api.github.com/users/lichuang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuang/subscriptions","organizations_url":"https://api.github.com/users/lichuang/orgs","repos_url":"https://api.github.com/users/lichuang/repos","events_url":"https://api.github.com/users/lichuang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-24T07:35:36Z","updated_at":"2018-10-24T08:11:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alipay/sofa-mosn/pulls/325","html_url":"https://github.com/alipay/sofa-mosn/pull/325","diff_url":"https://github.com/alipay/sofa-mosn/pull/325.diff","patch_url":"https://github.com/alipay/sofa-mosn/pull/325.patch"},"body":"### Issues associated with this PR\r\n\r\nadd mixer filter in mosn, it will send mixer report request to istio telemetry.\r\n\r\n### Sign the CLA\r\nMake sure you have signed the [CLA](https://www.clahub.com/agreements/alipay/sofa-mosn)\r\n\r\n### Solutions\r\nAdd a streamfilter mixer,every time endStream log the request it will collect requset attributes, and send reports to telemetry batch(per 1s or per 1000 byte, by default).\r\n\r\n### UT result\r\nadd attribute_compressor_test UT test,all success.\r\n\r\n### Benchmark\r\nattribute_compressor benchmark retult:\r\n\r\ngoos: darwin\r\ngoarch: amd64\r\npkg: github.com/alipay/sofa-mosn/pkg/istio/mixerclient\r\nBenchmarkCompress-4        \t   50000\t     27505 ns/op\r\nBenchmarkBatchCompress-4   \t  500000\t      2713 ns/op\r\nPASS\r\nok  \tgithub.com/alipay/sofa-mosn/pkg/istio/mixerclient\t3.983s\r\n\r\n### Code Style\r\n+ Make sure `Goimports` has run\r\n+ Show `Golint` result\r\n"},"comment":{"url":"https://api.github.com/repos/alipay/sofa-mosn/issues/comments/432556552","html_url":"https://github.com/alipay/sofa-mosn/pull/325#issuecomment-432556552","issue_url":"https://api.github.com/repos/alipay/sofa-mosn/issues/325","id":432556552,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjU1NjU1Mg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-24T08:11:05Z","updated_at":"2018-10-24T08:11:05Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=h1) Report\n> Merging [#325](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=desc) into [master](https://codecov.io/gh/alipay/sofa-mosn/commit/cc602a613f59969027087aec312a4027888fe162?src=pr&el=desc) will **decrease** coverage by `0.16%`.\n> The diff coverage is `47.51%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/alipay/sofa-mosn/pull/325/graphs/tree.svg?width=650&token=o0ua4ib09v&height=150&src=pr)](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #325      +/-   ##\n==========================================\n- Coverage   52.85%   52.69%   -0.17%     \n==========================================\n  Files          90       95       +5     \n  Lines       10281    10550     +269     \n==========================================\n+ Hits         5434     5559     +125     \n- Misses       4285     4427     +142     \n- Partials      562      564       +2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pkg/types/route.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL3JvdXRlLmdv) | `0% <ø> (ø)` | :arrow_up: |\n| [pkg/istio/mixerclient/report\\_batch.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2lzdGlvL21peGVyY2xpZW50L3JlcG9ydF9iYXRjaC5nbw==) | `0% <0%> (ø)` | |\n| [pkg/config/parser.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9wYXJzZXIuZ28=) | `50.28% <0%> (-3.71%)` | :arrow_down: |\n| [pkg/upstream/cluster/clusteradapter.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL3Vwc3RyZWFtL2NsdXN0ZXIvY2x1c3RlcmFkYXB0ZXIuZ28=) | `55.55% <0%> (-4.45%)` | :arrow_down: |\n| [pkg/istio/mixerclient/client.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2lzdGlvL21peGVyY2xpZW50L2NsaWVudC5nbw==) | `0% <0%> (ø)` | |\n| [pkg/filter/factory.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2ZpbHRlci9mYWN0b3J5Lmdv) | `70.96% <10%> (-29.04%)` | :arrow_down: |\n| [pkg/istio/mixerclient/global\\_dictionary.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2lzdGlvL21peGVyY2xpZW50L2dsb2JhbF9kaWN0aW9uYXJ5Lmdv) | `100% <100%> (ø)` | |\n| [pkg/router/routeruleimpl.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL3JvdXRlci9yb3V0ZXJ1bGVpbXBsLmdv) | `51.56% <33.33%> (-0.44%)` | :arrow_down: |\n| [pkg/istio/mixerclient/mixer\\_client\\_manager.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2lzdGlvL21peGVyY2xpZW50L21peGVyX2NsaWVudF9tYW5hZ2VyLmdv) | `41.02% <41.02%> (ø)` | |\n| [pkg/config/convertxds.go](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb252ZXJ0eGRzLmdv) | `34.88% <57.57%> (+0.58%)` | :arrow_up: |\n| ... and [6 more](https://codecov.io/gh/alipay/sofa-mosn/pull/325/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=footer). Last update [cc602a6...c5f8a03](https://codecov.io/gh/alipay/sofa-mosn/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}