{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/cafejojo/schaapi/pulls/199","id":192256519,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjU2NTE5","html_url":"https://github.com/cafejojo/schaapi/pull/199","diff_url":"https://github.com/cafejojo/schaapi/pull/199.diff","patch_url":"https://github.com/cafejojo/schaapi/pull/199.patch","issue_url":"https://api.github.com/repos/cafejojo/schaapi/issues/199","number":199,"state":"closed","locked":false,"title":"Fix Detekt rule violations","user":{"login":"gandreadis","id":5272244,"node_id":"MDQ6VXNlcjUyNzIyNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5272244?v=4","gravatar_id":"","url":"https://api.github.com/users/gandreadis","html_url":"https://github.com/gandreadis","followers_url":"https://api.github.com/users/gandreadis/followers","following_url":"https://api.github.com/users/gandreadis/following{/other_user}","gists_url":"https://api.github.com/users/gandreadis/gists{/gist_id}","starred_url":"https://api.github.com/users/gandreadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandreadis/subscriptions","organizations_url":"https://api.github.com/users/gandreadis/orgs","repos_url":"https://api.github.com/users/gandreadis/repos","events_url":"https://api.github.com/users/gandreadis/events{/privacy}","received_events_url":"https://api.github.com/users/gandreadis/received_events","type":"User","site_admin":false},"body":"No idea how they got into `master`, but they did, so here are my fixes for them. I agree with the rule preferring 'to' expressions over 'Pair' statements - feel free to disagree, however.\r\n\r\nI did not agree with the 'MandatoryBracesIfStatements' rule. Seeing as we don't consistently follow it in the rest of the codebase, either, I turned it off in `detekt.yml`.\r\n\r\nNote: This build will likely fail until #200 is merged, as there still remains a failing Windows-test on this branch.","created_at":"2018-06-03T16:50:10Z","updated_at":"2018-06-04T08:08:44Z","closed_at":"2018-06-04T08:08:44Z","merged_at":"2018-06-04T08:08:43Z","merge_commit_sha":"8a7f38124907f89110924399e1ec146b2f2e02de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":935926222,"node_id":"MDU6TGFiZWw5MzU5MjYyMjI=","url":"https://api.github.com/repos/cafejojo/schaapi/labels/code%20quality","name":"code quality","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/199/commits","review_comments_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/199/comments","review_comment_url":"https://api.github.com/repos/cafejojo/schaapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cafejojo/schaapi/issues/199/comments","statuses_url":"https://api.github.com/repos/cafejojo/schaapi/statuses/0a0d2448476ffd76ca5586bf49e47dc11a61b105","head":{"label":"cafejojo:detekt-fixes","ref":"detekt-fixes","sha":"0a0d2448476ffd76ca5586bf49e47dc11a61b105","user":{"login":"cafejojo","id":38208512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjA4NTEy","avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"repo":{"id":130986816,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5ODY4MTY=","name":"schaapi","full_name":"cafejojo/schaapi","owner":{"login":"cafejojo","id":38208512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjA4NTEy","avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cafejojo/schaapi","description":"🐑 Safe Changes for APIs","fork":false,"url":"https://api.github.com/repos/cafejojo/schaapi","forks_url":"https://api.github.com/repos/cafejojo/schaapi/forks","keys_url":"https://api.github.com/repos/cafejojo/schaapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cafejojo/schaapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cafejojo/schaapi/teams","hooks_url":"https://api.github.com/repos/cafejojo/schaapi/hooks","issue_events_url":"https://api.github.com/repos/cafejojo/schaapi/issues/events{/number}","events_url":"https://api.github.com/repos/cafejojo/schaapi/events","assignees_url":"https://api.github.com/repos/cafejojo/schaapi/assignees{/user}","branches_url":"https://api.github.com/repos/cafejojo/schaapi/branches{/branch}","tags_url":"https://api.github.com/repos/cafejojo/schaapi/tags","blobs_url":"https://api.github.com/repos/cafejojo/schaapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cafejojo/schaapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cafejojo/schaapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cafejojo/schaapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cafejojo/schaapi/statuses/{sha}","languages_url":"https://api.github.com/repos/cafejojo/schaapi/languages","stargazers_url":"https://api.github.com/repos/cafejojo/schaapi/stargazers","contributors_url":"https://api.github.com/repos/cafejojo/schaapi/contributors","subscribers_url":"https://api.github.com/repos/cafejojo/schaapi/subscribers","subscription_url":"https://api.github.com/repos/cafejojo/schaapi/subscription","commits_url":"https://api.github.com/repos/cafejojo/schaapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cafejojo/schaapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cafejojo/schaapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cafejojo/schaapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cafejojo/schaapi/contents/{+path}","compare_url":"https://api.github.com/repos/cafejojo/schaapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cafejojo/schaapi/merges","archive_url":"https://api.github.com/repos/cafejojo/schaapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cafejojo/schaapi/downloads","issues_url":"https://api.github.com/repos/cafejojo/schaapi/issues{/number}","pulls_url":"https://api.github.com/repos/cafejojo/schaapi/pulls{/number}","milestones_url":"https://api.github.com/repos/cafejojo/schaapi/milestones{/number}","notifications_url":"https://api.github.com/repos/cafejojo/schaapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cafejojo/schaapi/labels{/name}","releases_url":"https://api.github.com/repos/cafejojo/schaapi/releases{/id}","deployments_url":"https://api.github.com/repos/cafejojo/schaapi/deployments","created_at":"2018-04-25T10:00:57Z","updated_at":"2018-06-01T12:01:56Z","pushed_at":"2018-06-04T08:08:43Z","git_url":"git://github.com/cafejojo/schaapi.git","ssh_url":"git@github.com:cafejojo/schaapi.git","clone_url":"https://github.com/cafejojo/schaapi.git","svn_url":"https://github.com/cafejojo/schaapi","homepage":"https://cafejojo.org/schaapi","size":10293,"stargazers_count":6,"watchers_count":6,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":8,"watchers":6,"default_branch":"master"}},"base":{"label":"cafejojo:master","ref":"master","sha":"dcc2ac75aacd211b93439e4cfa090a48c092ae70","user":{"login":"cafejojo","id":38208512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjA4NTEy","avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"repo":{"id":130986816,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5ODY4MTY=","name":"schaapi","full_name":"cafejojo/schaapi","owner":{"login":"cafejojo","id":38208512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjA4NTEy","avatar_url":"https://avatars3.githubusercontent.com/u/38208512?v=4","gravatar_id":"","url":"https://api.github.com/users/cafejojo","html_url":"https://github.com/cafejojo","followers_url":"https://api.github.com/users/cafejojo/followers","following_url":"https://api.github.com/users/cafejojo/following{/other_user}","gists_url":"https://api.github.com/users/cafejojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cafejojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cafejojo/subscriptions","organizations_url":"https://api.github.com/users/cafejojo/orgs","repos_url":"https://api.github.com/users/cafejojo/repos","events_url":"https://api.github.com/users/cafejojo/events{/privacy}","received_events_url":"https://api.github.com/users/cafejojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cafejojo/schaapi","description":"🐑 Safe Changes for APIs","fork":false,"url":"https://api.github.com/repos/cafejojo/schaapi","forks_url":"https://api.github.com/repos/cafejojo/schaapi/forks","keys_url":"https://api.github.com/repos/cafejojo/schaapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cafejojo/schaapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cafejojo/schaapi/teams","hooks_url":"https://api.github.com/repos/cafejojo/schaapi/hooks","issue_events_url":"https://api.github.com/repos/cafejojo/schaapi/issues/events{/number}","events_url":"https://api.github.com/repos/cafejojo/schaapi/events","assignees_url":"https://api.github.com/repos/cafejojo/schaapi/assignees{/user}","branches_url":"https://api.github.com/repos/cafejojo/schaapi/branches{/branch}","tags_url":"https://api.github.com/repos/cafejojo/schaapi/tags","blobs_url":"https://api.github.com/repos/cafejojo/schaapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cafejojo/schaapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cafejojo/schaapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cafejojo/schaapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cafejojo/schaapi/statuses/{sha}","languages_url":"https://api.github.com/repos/cafejojo/schaapi/languages","stargazers_url":"https://api.github.com/repos/cafejojo/schaapi/stargazers","contributors_url":"https://api.github.com/repos/cafejojo/schaapi/contributors","subscribers_url":"https://api.github.com/repos/cafejojo/schaapi/subscribers","subscription_url":"https://api.github.com/repos/cafejojo/schaapi/subscription","commits_url":"https://api.github.com/repos/cafejojo/schaapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cafejojo/schaapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cafejojo/schaapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cafejojo/schaapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cafejojo/schaapi/contents/{+path}","compare_url":"https://api.github.com/repos/cafejojo/schaapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cafejojo/schaapi/merges","archive_url":"https://api.github.com/repos/cafejojo/schaapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cafejojo/schaapi/downloads","issues_url":"https://api.github.com/repos/cafejojo/schaapi/issues{/number}","pulls_url":"https://api.github.com/repos/cafejojo/schaapi/pulls{/number}","milestones_url":"https://api.github.com/repos/cafejojo/schaapi/milestones{/number}","notifications_url":"https://api.github.com/repos/cafejojo/schaapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cafejojo/schaapi/labels{/name}","releases_url":"https://api.github.com/repos/cafejojo/schaapi/releases{/id}","deployments_url":"https://api.github.com/repos/cafejojo/schaapi/deployments","created_at":"2018-04-25T10:00:57Z","updated_at":"2018-06-01T12:01:56Z","pushed_at":"2018-06-04T08:08:43Z","git_url":"git://github.com/cafejojo/schaapi.git","ssh_url":"git@github.com:cafejojo/schaapi.git","clone_url":"https://github.com/cafejojo/schaapi.git","svn_url":"https://github.com/cafejojo/schaapi","homepage":"https://cafejojo.org/schaapi","size":10293,"stargazers_count":6,"watchers_count":6,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":8,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/199"},"html":{"href":"https://github.com/cafejojo/schaapi/pull/199"},"issue":{"href":"https://api.github.com/repos/cafejojo/schaapi/issues/199"},"comments":{"href":"https://api.github.com/repos/cafejojo/schaapi/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cafejojo/schaapi/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/cafejojo/schaapi/statuses/0a0d2448476ffd76ca5586bf49e47dc11a61b105"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"FWDekker","id":13442533,"node_id":"MDQ6VXNlcjEzNDQyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/13442533?v=4","gravatar_id":"","url":"https://api.github.com/users/FWDekker","html_url":"https://github.com/FWDekker","followers_url":"https://api.github.com/users/FWDekker/followers","following_url":"https://api.github.com/users/FWDekker/following{/other_user}","gists_url":"https://api.github.com/users/FWDekker/gists{/gist_id}","starred_url":"https://api.github.com/users/FWDekker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FWDekker/subscriptions","organizations_url":"https://api.github.com/users/FWDekker/orgs","repos_url":"https://api.github.com/users/FWDekker/repos","events_url":"https://api.github.com/users/FWDekker/events{/privacy}","received_events_url":"https://api.github.com/users/FWDekker/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":13,"deletions":11,"changed_files":7}}
{"actor":{"display_login":"FWDekker"}}