{"action":"created","comment":{"url":"https://api.github.com/repos/leanprover/mathlib/pulls/comments/217880027","pull_request_review_id":155708182,"id":217880027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg4MDAyNw==","diff_hunk":"@@ -177,11 +177,23 @@ def equiv_pempty (h : α → false) : α ≃ pempty :=\n def false_equiv_pempty : false ≃ pempty :=\n equiv_pempty _root_.id\n \n+def empty_equiv_pempty : empty ≃ pempty :=\n+equiv_pempty $ empty.rec _\n+\n+def pempty_equiv_empty : pempty ≃ empty :=","path":"data/equiv/basic.lean","position":7,"original_position":7,"commit_id":"c50ae476330cd5f7a774ba24019477677d35a6d0","original_commit_id":"217dbb3caef868548f4eb978282f233def3f4d6f","user":{"login":"kckennylau","id":17786901,"node_id":"MDQ6VXNlcjE3Nzg2OTAx","avatar_url":"https://avatars1.githubusercontent.com/u/17786901?v=4","gravatar_id":"","url":"https://api.github.com/users/kckennylau","html_url":"https://github.com/kckennylau","followers_url":"https://api.github.com/users/kckennylau/followers","following_url":"https://api.github.com/users/kckennylau/following{/other_user}","gists_url":"https://api.github.com/users/kckennylau/gists{/gist_id}","starred_url":"https://api.github.com/users/kckennylau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kckennylau/subscriptions","organizations_url":"https://api.github.com/users/kckennylau/orgs","repos_url":"https://api.github.com/users/kckennylau/repos","events_url":"https://api.github.com/users/kckennylau/events{/privacy}","received_events_url":"https://api.github.com/users/kckennylau/received_events","type":"User","site_admin":false},"body":"@digama0 what do you think?","created_at":"2018-09-15T08:52:19Z","updated_at":"2018-09-15T08:52:19Z","html_url":"https://github.com/leanprover/mathlib/pull/345#discussion_r217880027","pull_request_url":"https://api.github.com/repos/leanprover/mathlib/pulls/345","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/comments/217880027"},"html":{"href":"https://github.com/leanprover/mathlib/pull/345#discussion_r217880027"},"pull_request":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/345"}},"in_reply_to_id":217712672},"pull_request":{"url":"https://api.github.com/repos/leanprover/mathlib/pulls/345","id":215242482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjQyNDgy","html_url":"https://github.com/leanprover/mathlib/pull/345","diff_url":"https://github.com/leanprover/mathlib/pull/345.diff","patch_url":"https://github.com/leanprover/mathlib/pull/345.patch","issue_url":"https://api.github.com/repos/leanprover/mathlib/issues/345","number":345,"state":"open","locked":false,"title":"dimension theorem","user":{"login":"kckennylau","id":17786901,"node_id":"MDQ6VXNlcjE3Nzg2OTAx","avatar_url":"https://avatars1.githubusercontent.com/u/17786901?v=4","gravatar_id":"","url":"https://api.github.com/users/kckennylau","html_url":"https://github.com/kckennylau","followers_url":"https://api.github.com/users/kckennylau/followers","following_url":"https://api.github.com/users/kckennylau/following{/other_user}","gists_url":"https://api.github.com/users/kckennylau/gists{/gist_id}","starred_url":"https://api.github.com/users/kckennylau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kckennylau/subscriptions","organizations_url":"https://api.github.com/users/kckennylau/orgs","repos_url":"https://api.github.com/users/kckennylau/repos","events_url":"https://api.github.com/users/kckennylau/events{/privacy}","received_events_url":"https://api.github.com/users/kckennylau/received_events","type":"User","site_admin":false},"body":"TO CONTRIBUTORS:\r\n\r\nMake sure you have:\r\n\r\n * [ ] reviewed and applied the coding style: [coding](./docs/style.md), [naming](./docs/naming.md)\r\n * [ ] for tactics:\r\n     * [ ] added or adapted documentation in [tactics.md](./docs/tactics.md)\r\n     * [ ] write an example of use of the new feature in [tactics.lean](./tests/tactics.lean)\r\n  * [ ] make sure definitions and lemmas are put in the right files\r\n  * [ ] make sure definitions and lemmas are not redundant\r\n\r\nFor reviewers: [code review check list](./docs/code-review.md)\r\n","created_at":"2018-09-13T10:55:45Z","updated_at":"2018-09-15T08:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61622f6a9f2f1f4a177f43f4e5463f71f2dc07e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/leanprover/mathlib/pulls/345/commits","review_comments_url":"https://api.github.com/repos/leanprover/mathlib/pulls/345/comments","review_comment_url":"https://api.github.com/repos/leanprover/mathlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leanprover/mathlib/issues/345/comments","statuses_url":"https://api.github.com/repos/leanprover/mathlib/statuses/c50ae476330cd5f7a774ba24019477677d35a6d0","head":{"label":"leanprover-community:basis","ref":"basis","sha":"c50ae476330cd5f7a774ba24019477677d35a6d0","user":{"login":"leanprover-community","id":41703605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNzAzNjA1","avatar_url":"https://avatars3.githubusercontent.com/u/41703605?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover-community","html_url":"https://github.com/leanprover-community","followers_url":"https://api.github.com/users/leanprover-community/followers","following_url":"https://api.github.com/users/leanprover-community/following{/other_user}","gists_url":"https://api.github.com/users/leanprover-community/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover-community/subscriptions","organizations_url":"https://api.github.com/users/leanprover-community/orgs","repos_url":"https://api.github.com/users/leanprover-community/repos","events_url":"https://api.github.com/users/leanprover-community/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover-community/received_events","type":"Organization","site_admin":false},"repo":{"id":143964213,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NjQyMTM=","name":"mathlib","full_name":"leanprover-community/mathlib","owner":{"login":"leanprover-community","id":41703605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNzAzNjA1","avatar_url":"https://avatars3.githubusercontent.com/u/41703605?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover-community","html_url":"https://github.com/leanprover-community","followers_url":"https://api.github.com/users/leanprover-community/followers","following_url":"https://api.github.com/users/leanprover-community/following{/other_user}","gists_url":"https://api.github.com/users/leanprover-community/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover-community/subscriptions","organizations_url":"https://api.github.com/users/leanprover-community/orgs","repos_url":"https://api.github.com/users/leanprover-community/repos","events_url":"https://api.github.com/users/leanprover-community/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leanprover-community/mathlib","description":"Lean mathematical components library","fork":true,"url":"https://api.github.com/repos/leanprover-community/mathlib","forks_url":"https://api.github.com/repos/leanprover-community/mathlib/forks","keys_url":"https://api.github.com/repos/leanprover-community/mathlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leanprover-community/mathlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leanprover-community/mathlib/teams","hooks_url":"https://api.github.com/repos/leanprover-community/mathlib/hooks","issue_events_url":"https://api.github.com/repos/leanprover-community/mathlib/issues/events{/number}","events_url":"https://api.github.com/repos/leanprover-community/mathlib/events","assignees_url":"https://api.github.com/repos/leanprover-community/mathlib/assignees{/user}","branches_url":"https://api.github.com/repos/leanprover-community/mathlib/branches{/branch}","tags_url":"https://api.github.com/repos/leanprover-community/mathlib/tags","blobs_url":"https://api.github.com/repos/leanprover-community/mathlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leanprover-community/mathlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leanprover-community/mathlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/leanprover-community/mathlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leanprover-community/mathlib/statuses/{sha}","languages_url":"https://api.github.com/repos/leanprover-community/mathlib/languages","stargazers_url":"https://api.github.com/repos/leanprover-community/mathlib/stargazers","contributors_url":"https://api.github.com/repos/leanprover-community/mathlib/contributors","subscribers_url":"https://api.github.com/repos/leanprover-community/mathlib/subscribers","subscription_url":"https://api.github.com/repos/leanprover-community/mathlib/subscription","commits_url":"https://api.github.com/repos/leanprover-community/mathlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/leanprover-community/mathlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/leanprover-community/mathlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/leanprover-community/mathlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/leanprover-community/mathlib/contents/{+path}","compare_url":"https://api.github.com/repos/leanprover-community/mathlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leanprover-community/mathlib/merges","archive_url":"https://api.github.com/repos/leanprover-community/mathlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leanprover-community/mathlib/downloads","issues_url":"https://api.github.com/repos/leanprover-community/mathlib/issues{/number}","pulls_url":"https://api.github.com/repos/leanprover-community/mathlib/pulls{/number}","milestones_url":"https://api.github.com/repos/leanprover-community/mathlib/milestones{/number}","notifications_url":"https://api.github.com/repos/leanprover-community/mathlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leanprover-community/mathlib/labels{/name}","releases_url":"https://api.github.com/repos/leanprover-community/mathlib/releases{/id}","deployments_url":"https://api.github.com/repos/leanprover-community/mathlib/deployments","created_at":"2018-08-08T05:15:22Z","updated_at":"2018-09-15T02:04:32Z","pushed_at":"2018-09-15T08:42:59Z","git_url":"git://github.com/leanprover-community/mathlib.git","ssh_url":"git@github.com:leanprover-community/mathlib.git","clone_url":"https://github.com/leanprover-community/mathlib.git","svn_url":"https://github.com/leanprover-community/mathlib","homepage":"","size":4636,"stargazers_count":2,"watchers_count":2,"language":"Lean","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"leanprover:master","ref":"master","sha":"120635628368ec261e031cefc6d30e0304088b03","user":{"login":"leanprover","id":7233018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"repo":{"id":97922418,"node_id":"MDEwOlJlcG9zaXRvcnk5NzkyMjQxOA==","name":"mathlib","full_name":"leanprover/mathlib","owner":{"login":"leanprover","id":7233018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leanprover/mathlib","description":"Lean mathematical components library","fork":false,"url":"https://api.github.com/repos/leanprover/mathlib","forks_url":"https://api.github.com/repos/leanprover/mathlib/forks","keys_url":"https://api.github.com/repos/leanprover/mathlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leanprover/mathlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leanprover/mathlib/teams","hooks_url":"https://api.github.com/repos/leanprover/mathlib/hooks","issue_events_url":"https://api.github.com/repos/leanprover/mathlib/issues/events{/number}","events_url":"https://api.github.com/repos/leanprover/mathlib/events","assignees_url":"https://api.github.com/repos/leanprover/mathlib/assignees{/user}","branches_url":"https://api.github.com/repos/leanprover/mathlib/branches{/branch}","tags_url":"https://api.github.com/repos/leanprover/mathlib/tags","blobs_url":"https://api.github.com/repos/leanprover/mathlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leanprover/mathlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leanprover/mathlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/leanprover/mathlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leanprover/mathlib/statuses/{sha}","languages_url":"https://api.github.com/repos/leanprover/mathlib/languages","stargazers_url":"https://api.github.com/repos/leanprover/mathlib/stargazers","contributors_url":"https://api.github.com/repos/leanprover/mathlib/contributors","subscribers_url":"https://api.github.com/repos/leanprover/mathlib/subscribers","subscription_url":"https://api.github.com/repos/leanprover/mathlib/subscription","commits_url":"https://api.github.com/repos/leanprover/mathlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/leanprover/mathlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/leanprover/mathlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/leanprover/mathlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/leanprover/mathlib/contents/{+path}","compare_url":"https://api.github.com/repos/leanprover/mathlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leanprover/mathlib/merges","archive_url":"https://api.github.com/repos/leanprover/mathlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leanprover/mathlib/downloads","issues_url":"https://api.github.com/repos/leanprover/mathlib/issues{/number}","pulls_url":"https://api.github.com/repos/leanprover/mathlib/pulls{/number}","milestones_url":"https://api.github.com/repos/leanprover/mathlib/milestones{/number}","notifications_url":"https://api.github.com/repos/leanprover/mathlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leanprover/mathlib/labels{/name}","releases_url":"https://api.github.com/repos/leanprover/mathlib/releases{/id}","deployments_url":"https://api.github.com/repos/leanprover/mathlib/deployments","created_at":"2017-07-21T08:02:10Z","updated_at":"2018-09-14T12:58:04Z","pushed_at":"2018-09-15T08:43:01Z","git_url":"git://github.com/leanprover/mathlib.git","ssh_url":"git@github.com:leanprover/mathlib.git","clone_url":"https://github.com/leanprover/mathlib.git","svn_url":"https://github.com/leanprover/mathlib","homepage":"","size":4327,"stargazers_count":62,"watchers_count":62,"language":"Lean","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":34,"open_issues":31,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/345"},"html":{"href":"https://github.com/leanprover/mathlib/pull/345"},"issue":{"href":"https://api.github.com/repos/leanprover/mathlib/issues/345"},"comments":{"href":"https://api.github.com/repos/leanprover/mathlib/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/leanprover/mathlib/statuses/c50ae476330cd5f7a774ba24019477677d35a6d0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kckennylau"}}