{"action":"created","issue":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/3413","repository_url":"https://api.github.com/repos/material-components/material-components-ios","labels_url":"https://api.github.com/repos/material-components/material-components-ios/issues/3413/labels{/name}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/3413/comments","events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/3413/events","html_url":"https://github.com/material-components/material-components-ios/pull/3413","id":316058292,"number":3413,"title":"[BottomSheet] [3/3] Fix layout issues with bottom sheets containing scroll views","user":{"login":"bhamiltoncx","id":671827,"avatar_url":"https://avatars3.githubusercontent.com/u/671827?v=4","gravatar_id":"","url":"https://api.github.com/users/bhamiltoncx","html_url":"https://github.com/bhamiltoncx","followers_url":"https://api.github.com/users/bhamiltoncx/followers","following_url":"https://api.github.com/users/bhamiltoncx/following{/other_user}","gists_url":"https://api.github.com/users/bhamiltoncx/gists{/gist_id}","starred_url":"https://api.github.com/users/bhamiltoncx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhamiltoncx/subscriptions","organizations_url":"https://api.github.com/users/bhamiltoncx/orgs","repos_url":"https://api.github.com/users/bhamiltoncx/repos","events_url":"https://api.github.com/users/bhamiltoncx/events{/privacy}","received_events_url":"https://api.github.com/users/bhamiltoncx/received_events","type":"User","site_admin":false},"labels":[{"id":339228516,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/Blocked","name":"Blocked","color":"000000","default":false},{"id":666268722,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/[BottomSheet]","name":"[BottomSheet]","color":"eeeeee","default":false},{"id":273191333,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"1e8e3e","default":false},{"id":742203285,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/kokoru:run","name":"kokoru:run","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"assignees":[{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-04-19T22:08:39Z","updated_at":"2018-05-22T21:28:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/3413","html_url":"https://github.com/material-components/material-components-ios/pull/3413","diff_url":"https://github.com/material-components/material-components-ios/pull/3413.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/3413.patch"},"body":"`MDCBottomSheetController` had a few subtle issues when the content view controller\r\ncontained a scroll view.\r\n\r\nContained scroll views always had their height set to the maximum\r\nheight of the `MDCSheetContainerView`, which might be larger than the\r\ncontained scroll view's content size.\r\n\r\nWith this PR, we ensure we never make the contained scroll view height\r\nlarger than the larger of (content size, desired sheet height).\r\n\r\nTest Plan: Added new application-hosted tests to reproduce the\r\nissues. I confirmed they failed before this PR and passed after. Ran\r\ntests with:\r\n\r\n  ./.kokoro --target //components/BottomSheet/...\r\n"},"comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments/391146888","html_url":"https://github.com/material-components/material-components-ios/pull/3413#issuecomment-391146888","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/3413","id":391146888,"user":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T21:28:40Z","updated_at":"2018-05-22T21:28:40Z","author_association":"MEMBER","body":"Run MDC catalog, then run the bottom sheet primary demo."}}
{"actor":{"display_login":"jverkoey"}}