{"action":"closed","number":6639,"pull_request":{"url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/6639","id":169318521,"html_url":"https://github.com/HippieStation/HippieStation/pull/6639","diff_url":"https://github.com/HippieStation/HippieStation/pull/6639.diff","patch_url":"https://github.com/HippieStation/HippieStation/pull/6639.patch","issue_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/6639","number":6639,"state":"closed","locked":false,"title":"[MIRROR] Support stations with multiple z-levels","user":{"login":"HonkBot","id":25598968,"avatar_url":"https://avatars0.githubusercontent.com/u/25598968?v=4","gravatar_id":"","url":"https://api.github.com/users/HonkBot","html_url":"https://github.com/HonkBot","followers_url":"https://api.github.com/users/HonkBot/followers","following_url":"https://api.github.com/users/HonkBot/following{/other_user}","gists_url":"https://api.github.com/users/HonkBot/gists{/gist_id}","starred_url":"https://api.github.com/users/HonkBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HonkBot/subscriptions","organizations_url":"https://api.github.com/users/HonkBot/orgs","repos_url":"https://api.github.com/users/HonkBot/repos","events_url":"https://api.github.com/users/HonkBot/events{/privacy}","received_events_url":"https://api.github.com/users/HonkBot/received_events","type":"User","site_admin":false},"body":"Original PR: https://github.com/tgstation/tgstation/pull/35339\n--------------------\n:cl:\r\nrefactor: Map initialization now supports stations with multiple z-levels.\r\nfix: The map reader no longer sometimes expands the world size inappropriately.\r\ntweak: Pride's Mirror's destination has become less predictable.\r\n/:cl:\r\n\r\nContinuation of #34633, pursuant to completing the port of #32037. Big and probably deserves some actual scrutiny but things seem to be working in my tests and all the debug output checks out.\r\n\r\nDone:\r\n* **Support multi-z station maps**, planetstation here we come\r\n* Load Lavaland and Reebe dynamically\r\n* Allow any mix of multiple z-levels in one `.dmm` and multiple `.dmm` files\r\n* Remove the last of the `ZLEVEL_` defines\r\n* Allow map json files to specify traits for their maps\r\n* Use traits to configure which levels are up/down relative to each other (ladders, chasms)\r\n* Use traits to configure space linkage (transitions) rather than a separate config\r\n\r\nFuture work:\r\n* Final tweaks to support multi-z mining zones and away missions\r\n* Coordinate with DB folk to decide if default ordering of z-levels should be changed\r\n* Migrate z-level lists in `GLOB` and subsystems to vars on `datum/space_level` for ease of maintenance\r\n* Heap-allocation of z-levels and subregions, related deallocation and clearing\r\n\r\nOutput of \"Debug Z-Levels\" on a station map with three of them:\r\n![image](https://user-images.githubusercontent.com/222630/35788893-2228a64c-09ed-11e8-80a9-b425675ce821.png)\r\n","created_at":"2018-02-15T09:21:49Z","updated_at":"2018-02-15T18:00:02Z","closed_at":"2018-02-15T18:00:02Z","merged_at":"2018-02-15T18:00:02Z","merge_commit_sha":"a15cc0096e04f854e240b3d8471b53a75238b0dd","assignee":{"login":"praisenarsie","id":31222036,"avatar_url":"https://avatars0.githubusercontent.com/u/31222036?v=4","gravatar_id":"","url":"https://api.github.com/users/praisenarsie","html_url":"https://github.com/praisenarsie","followers_url":"https://api.github.com/users/praisenarsie/followers","following_url":"https://api.github.com/users/praisenarsie/following{/other_user}","gists_url":"https://api.github.com/users/praisenarsie/gists{/gist_id}","starred_url":"https://api.github.com/users/praisenarsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praisenarsie/subscriptions","organizations_url":"https://api.github.com/users/praisenarsie/orgs","repos_url":"https://api.github.com/users/praisenarsie/repos","events_url":"https://api.github.com/users/praisenarsie/events{/privacy}","received_events_url":"https://api.github.com/users/praisenarsie/received_events","type":"User","site_admin":false},"assignees":[{"login":"praisenarsie","id":31222036,"avatar_url":"https://avatars0.githubusercontent.com/u/31222036?v=4","gravatar_id":"","url":"https://api.github.com/users/praisenarsie","html_url":"https://github.com/praisenarsie","followers_url":"https://api.github.com/users/praisenarsie/followers","following_url":"https://api.github.com/users/praisenarsie/following{/other_user}","gists_url":"https://api.github.com/users/praisenarsie/gists{/gist_id}","starred_url":"https://api.github.com/users/praisenarsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praisenarsie/subscriptions","organizations_url":"https://api.github.com/users/praisenarsie/orgs","repos_url":"https://api.github.com/users/praisenarsie/repos","events_url":"https://api.github.com/users/praisenarsie/events{/privacy}","received_events_url":"https://api.github.com/users/praisenarsie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":626170747,"url":"https://api.github.com/repos/HippieStation/HippieStation/labels/Fix","name":"Fix","color":"00bbdd","default":false},{"id":626170160,"url":"https://api.github.com/repos/HippieStation/HippieStation/labels/Map%20Edit","name":"Map Edit","color":"eb6420","default":false},{"id":626170188,"url":"https://api.github.com/repos/HippieStation/HippieStation/labels/Refactor","name":"Refactor","color":"FF9933","default":false},{"id":626170749,"url":"https://api.github.com/repos/HippieStation/HippieStation/labels/Tweak","name":"Tweak","color":"e99695","default":false},{"id":558466759,"url":"https://api.github.com/repos/HippieStation/HippieStation/labels/Upstream%20PR%20Merged","name":"Upstream PR Merged","color":"6f42c1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/6639/commits","review_comments_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/6639/comments","review_comment_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/6639/comments","statuses_url":"https://api.github.com/repos/HippieStation/HippieStation/statuses/0272df7f445de8e53e728c0887dc91c95c4f64ca","head":{"label":"HippieStation:upstream-merge-35339","ref":"upstream-merge-35339","sha":"0272df7f445de8e53e728c0887dc91c95c4f64ca","user":{"login":"HippieStation","id":25507626,"avatar_url":"https://avatars1.githubusercontent.com/u/25507626?v=4","gravatar_id":"","url":"https://api.github.com/users/HippieStation","html_url":"https://github.com/HippieStation","followers_url":"https://api.github.com/users/HippieStation/followers","following_url":"https://api.github.com/users/HippieStation/following{/other_user}","gists_url":"https://api.github.com/users/HippieStation/gists{/gist_id}","starred_url":"https://api.github.com/users/HippieStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HippieStation/subscriptions","organizations_url":"https://api.github.com/users/HippieStation/orgs","repos_url":"https://api.github.com/users/HippieStation/repos","events_url":"https://api.github.com/users/HippieStation/events{/privacy}","received_events_url":"https://api.github.com/users/HippieStation/received_events","type":"Organization","site_admin":false},"repo":{"id":84665083,"name":"HippieStation","full_name":"HippieStation/HippieStation","owner":{"login":"HippieStation","id":25507626,"avatar_url":"https://avatars1.githubusercontent.com/u/25507626?v=4","gravatar_id":"","url":"https://api.github.com/users/HippieStation","html_url":"https://github.com/HippieStation","followers_url":"https://api.github.com/users/HippieStation/followers","following_url":"https://api.github.com/users/HippieStation/following{/other_user}","gists_url":"https://api.github.com/users/HippieStation/gists{/gist_id}","starred_url":"https://api.github.com/users/HippieStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HippieStation/subscriptions","organizations_url":"https://api.github.com/users/HippieStation/orgs","repos_url":"https://api.github.com/users/HippieStation/repos","events_url":"https://api.github.com/users/HippieStation/events{/privacy}","received_events_url":"https://api.github.com/users/HippieStation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HippieStation/HippieStation","description":"The Hippie Station branch of SS13","fork":true,"url":"https://api.github.com/repos/HippieStation/HippieStation","forks_url":"https://api.github.com/repos/HippieStation/HippieStation/forks","keys_url":"https://api.github.com/repos/HippieStation/HippieStation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HippieStation/HippieStation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HippieStation/HippieStation/teams","hooks_url":"https://api.github.com/repos/HippieStation/HippieStation/hooks","issue_events_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/events{/number}","events_url":"https://api.github.com/repos/HippieStation/HippieStation/events","assignees_url":"https://api.github.com/repos/HippieStation/HippieStation/assignees{/user}","branches_url":"https://api.github.com/repos/HippieStation/HippieStation/branches{/branch}","tags_url":"https://api.github.com/repos/HippieStation/HippieStation/tags","blobs_url":"https://api.github.com/repos/HippieStation/HippieStation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HippieStation/HippieStation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HippieStation/HippieStation/git/refs{/sha}","trees_url":"https://api.github.com/repos/HippieStation/HippieStation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HippieStation/HippieStation/statuses/{sha}","languages_url":"https://api.github.com/repos/HippieStation/HippieStation/languages","stargazers_url":"https://api.github.com/repos/HippieStation/HippieStation/stargazers","contributors_url":"https://api.github.com/repos/HippieStation/HippieStation/contributors","subscribers_url":"https://api.github.com/repos/HippieStation/HippieStation/subscribers","subscription_url":"https://api.github.com/repos/HippieStation/HippieStation/subscription","commits_url":"https://api.github.com/repos/HippieStation/HippieStation/commits{/sha}","git_commits_url":"https://api.github.com/repos/HippieStation/HippieStation/git/commits{/sha}","comments_url":"https://api.github.com/repos/HippieStation/HippieStation/comments{/number}","issue_comment_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/comments{/number}","contents_url":"https://api.github.com/repos/HippieStation/HippieStation/contents/{+path}","compare_url":"https://api.github.com/repos/HippieStation/HippieStation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HippieStation/HippieStation/merges","archive_url":"https://api.github.com/repos/HippieStation/HippieStation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HippieStation/HippieStation/downloads","issues_url":"https://api.github.com/repos/HippieStation/HippieStation/issues{/number}","pulls_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls{/number}","milestones_url":"https://api.github.com/repos/HippieStation/HippieStation/milestones{/number}","notifications_url":"https://api.github.com/repos/HippieStation/HippieStation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HippieStation/HippieStation/labels{/name}","releases_url":"https://api.github.com/repos/HippieStation/HippieStation/releases{/id}","deployments_url":"https://api.github.com/repos/HippieStation/HippieStation/deployments","created_at":"2017-03-11T16:47:28Z","updated_at":"2018-02-05T17:17:10Z","pushed_at":"2018-02-15T18:00:02Z","git_url":"git://github.com/HippieStation/HippieStation.git","ssh_url":"git@github.com:HippieStation/HippieStation.git","clone_url":"https://github.com/HippieStation/HippieStation.git","svn_url":"https://github.com/HippieStation/HippieStation","homepage":"https://hippiestation.com/","size":1134453,"stargazers_count":15,"watchers_count":15,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":48,"open_issues":89,"watchers":15,"default_branch":"master"}},"base":{"label":"HippieStation:master","ref":"master","sha":"398b8e3a8f5f046e85285384d9dd6ac664b14ac8","user":{"login":"HippieStation","id":25507626,"avatar_url":"https://avatars1.githubusercontent.com/u/25507626?v=4","gravatar_id":"","url":"https://api.github.com/users/HippieStation","html_url":"https://github.com/HippieStation","followers_url":"https://api.github.com/users/HippieStation/followers","following_url":"https://api.github.com/users/HippieStation/following{/other_user}","gists_url":"https://api.github.com/users/HippieStation/gists{/gist_id}","starred_url":"https://api.github.com/users/HippieStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HippieStation/subscriptions","organizations_url":"https://api.github.com/users/HippieStation/orgs","repos_url":"https://api.github.com/users/HippieStation/repos","events_url":"https://api.github.com/users/HippieStation/events{/privacy}","received_events_url":"https://api.github.com/users/HippieStation/received_events","type":"Organization","site_admin":false},"repo":{"id":84665083,"name":"HippieStation","full_name":"HippieStation/HippieStation","owner":{"login":"HippieStation","id":25507626,"avatar_url":"https://avatars1.githubusercontent.com/u/25507626?v=4","gravatar_id":"","url":"https://api.github.com/users/HippieStation","html_url":"https://github.com/HippieStation","followers_url":"https://api.github.com/users/HippieStation/followers","following_url":"https://api.github.com/users/HippieStation/following{/other_user}","gists_url":"https://api.github.com/users/HippieStation/gists{/gist_id}","starred_url":"https://api.github.com/users/HippieStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HippieStation/subscriptions","organizations_url":"https://api.github.com/users/HippieStation/orgs","repos_url":"https://api.github.com/users/HippieStation/repos","events_url":"https://api.github.com/users/HippieStation/events{/privacy}","received_events_url":"https://api.github.com/users/HippieStation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HippieStation/HippieStation","description":"The Hippie Station branch of SS13","fork":true,"url":"https://api.github.com/repos/HippieStation/HippieStation","forks_url":"https://api.github.com/repos/HippieStation/HippieStation/forks","keys_url":"https://api.github.com/repos/HippieStation/HippieStation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HippieStation/HippieStation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HippieStation/HippieStation/teams","hooks_url":"https://api.github.com/repos/HippieStation/HippieStation/hooks","issue_events_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/events{/number}","events_url":"https://api.github.com/repos/HippieStation/HippieStation/events","assignees_url":"https://api.github.com/repos/HippieStation/HippieStation/assignees{/user}","branches_url":"https://api.github.com/repos/HippieStation/HippieStation/branches{/branch}","tags_url":"https://api.github.com/repos/HippieStation/HippieStation/tags","blobs_url":"https://api.github.com/repos/HippieStation/HippieStation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HippieStation/HippieStation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HippieStation/HippieStation/git/refs{/sha}","trees_url":"https://api.github.com/repos/HippieStation/HippieStation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HippieStation/HippieStation/statuses/{sha}","languages_url":"https://api.github.com/repos/HippieStation/HippieStation/languages","stargazers_url":"https://api.github.com/repos/HippieStation/HippieStation/stargazers","contributors_url":"https://api.github.com/repos/HippieStation/HippieStation/contributors","subscribers_url":"https://api.github.com/repos/HippieStation/HippieStation/subscribers","subscription_url":"https://api.github.com/repos/HippieStation/HippieStation/subscription","commits_url":"https://api.github.com/repos/HippieStation/HippieStation/commits{/sha}","git_commits_url":"https://api.github.com/repos/HippieStation/HippieStation/git/commits{/sha}","comments_url":"https://api.github.com/repos/HippieStation/HippieStation/comments{/number}","issue_comment_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/comments{/number}","contents_url":"https://api.github.com/repos/HippieStation/HippieStation/contents/{+path}","compare_url":"https://api.github.com/repos/HippieStation/HippieStation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HippieStation/HippieStation/merges","archive_url":"https://api.github.com/repos/HippieStation/HippieStation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HippieStation/HippieStation/downloads","issues_url":"https://api.github.com/repos/HippieStation/HippieStation/issues{/number}","pulls_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls{/number}","milestones_url":"https://api.github.com/repos/HippieStation/HippieStation/milestones{/number}","notifications_url":"https://api.github.com/repos/HippieStation/HippieStation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HippieStation/HippieStation/labels{/name}","releases_url":"https://api.github.com/repos/HippieStation/HippieStation/releases{/id}","deployments_url":"https://api.github.com/repos/HippieStation/HippieStation/deployments","created_at":"2017-03-11T16:47:28Z","updated_at":"2018-02-05T17:17:10Z","pushed_at":"2018-02-15T18:00:02Z","git_url":"git://github.com/HippieStation/HippieStation.git","ssh_url":"git@github.com:HippieStation/HippieStation.git","clone_url":"https://github.com/HippieStation/HippieStation.git","svn_url":"https://github.com/HippieStation/HippieStation","homepage":"https://hippiestation.com/","size":1134453,"stargazers_count":15,"watchers_count":15,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":48,"open_issues":89,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/6639"},"html":{"href":"https://github.com/HippieStation/HippieStation/pull/6639"},"issue":{"href":"https://api.github.com/repos/HippieStation/HippieStation/issues/6639"},"comments":{"href":"https://api.github.com/repos/HippieStation/HippieStation/issues/6639/comments"},"review_comments":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/6639/comments"},"review_comment":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/6639/commits"},"statuses":{"href":"https://api.github.com/repos/HippieStation/HippieStation/statuses/0272df7f445de8e53e728c0887dc91c95c4f64ca"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Carbonhell","id":11891037,"avatar_url":"https://avatars0.githubusercontent.com/u/11891037?v=4","gravatar_id":"","url":"https://api.github.com/users/Carbonhell","html_url":"https://github.com/Carbonhell","followers_url":"https://api.github.com/users/Carbonhell/followers","following_url":"https://api.github.com/users/Carbonhell/following{/other_user}","gists_url":"https://api.github.com/users/Carbonhell/gists{/gist_id}","starred_url":"https://api.github.com/users/Carbonhell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carbonhell/subscriptions","organizations_url":"https://api.github.com/users/Carbonhell/orgs","repos_url":"https://api.github.com/users/Carbonhell/repos","events_url":"https://api.github.com/users/Carbonhell/events{/privacy}","received_events_url":"https://api.github.com/users/Carbonhell/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":277,"deletions":196872,"changed_files":25}}
{"actor":{"display_login":"Carbonhell"}}