{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/glow/pulls/comments/223916225","pull_request_review_id":163161116,"id":223916225,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzkxNjIyNQ==","diff_hunk":"@@ -4124,6 +4124,50 @@ TEST_P(Operator, QuantizeSimple) {\n   EXPECT_NEAR(RH.at({0, 0}), 21.0, 0.001);\n }\n \n+/// Check that convertTo node works properly from float16_t to float.\n+TEST_P(InterpOnly, ConvertToFloat16ToFloat) {\n+  auto *A = mod_.createPlaceholder(ElemKind::FloatTy, {20, 13}, \"A\", false);\n+  auto inputHandle = ctx_.allocate(A)->getHandle<float_t>();","path":"tests/unittests/OperatorTest.cpp","position":null,"original_position":7,"commit_id":"e6c19143783db1c53f58ab99c47f5aeeb002aefc","original_commit_id":"130bc239b90c7fbe59c9d21d296c03cba3c549fd","user":{"login":"qcolombet","id":15787733,"node_id":"MDQ6VXNlcjE1Nzg3NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/15787733?v=4","gravatar_id":"","url":"https://api.github.com/users/qcolombet","html_url":"https://github.com/qcolombet","followers_url":"https://api.github.com/users/qcolombet/followers","following_url":"https://api.github.com/users/qcolombet/following{/other_user}","gists_url":"https://api.github.com/users/qcolombet/gists{/gist_id}","starred_url":"https://api.github.com/users/qcolombet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qcolombet/subscriptions","organizations_url":"https://api.github.com/users/qcolombet/orgs","repos_url":"https://api.github.com/users/qcolombet/repos","events_url":"https://api.github.com/users/qcolombet/events{/privacy}","received_events_url":"https://api.github.com/users/qcolombet/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-10-10T01:58:52Z","updated_at":"2018-10-10T01:58:52Z","html_url":"https://github.com/pytorch/glow/pull/1820#discussion_r223916225","pull_request_url":"https://api.github.com/repos/pytorch/glow/pulls/1820","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments/223916225"},"html":{"href":"https://github.com/pytorch/glow/pull/1820#discussion_r223916225"},"pull_request":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1820"}},"in_reply_to_id":223909674},"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/1820","id":221593046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTkzMDQ2","html_url":"https://github.com/pytorch/glow/pull/1820","diff_url":"https://github.com/pytorch/glow/pull/1820.diff","patch_url":"https://github.com/pytorch/glow/pull/1820.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/1820","number":1820,"state":"open","locked":false,"title":"[Graph&IR] Add a ConvertTo node","user":{"login":"qcolombet","id":15787733,"node_id":"MDQ6VXNlcjE1Nzg3NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/15787733?v=4","gravatar_id":"","url":"https://api.github.com/users/qcolombet","html_url":"https://github.com/qcolombet","followers_url":"https://api.github.com/users/qcolombet/followers","following_url":"https://api.github.com/users/qcolombet/following{/other_user}","gists_url":"https://api.github.com/users/qcolombet/gists{/gist_id}","starred_url":"https://api.github.com/users/qcolombet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qcolombet/subscriptions","organizations_url":"https://api.github.com/users/qcolombet/orgs","repos_url":"https://api.github.com/users/qcolombet/repos","events_url":"https://api.github.com/users/qcolombet/events{/privacy}","received_events_url":"https://api.github.com/users/qcolombet/received_events","type":"User","site_admin":false},"body":"*Description*\r\nThis node/instruction represents a type conversion (a.k.a. a cast)\r\nfrom the input type to the output type.\r\nThe shape of the input and output type must be identical, only the\r\nelement type is allowed to change.\r\n\r\nThis node will allow us to represent type conversions when converting\r\na graph from one type to another.\r\n\r\nThis patch adds the support for this node in the interpreter and\r\nteaches the differentiation mechanism how to deal with ConvertTo\r\nnode.\r\n\r\nNote: We could technically introduce different nodes for the different\r\nconversion (e.g., fpext, fptrunc, inttofp, and so on) since this\r\nnode would have different interpretation based on the input and output\r\ntypes. Right now, we decided not to do that because we expect this\r\nnode to not hit any backends. In particular, this node is only\r\naccessible through the C++ API.\r\n\r\n*Testing*\r\nAdded tests.\r\n\r\nRelated to #1312.","created_at":"2018-10-09T21:33:52Z","updated_at":"2018-10-10T01:58:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"763a7bb3a8f346cdad7aef7d4c130944a123113d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/1820/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/1820/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/1820/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/e6c19143783db1c53f58ab99c47f5aeeb002aefc","head":{"label":"qcolombet:convertto_node","ref":"convertto_node","sha":"e6c19143783db1c53f58ab99c47f5aeeb002aefc","user":{"login":"qcolombet","id":15787733,"node_id":"MDQ6VXNlcjE1Nzg3NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/15787733?v=4","gravatar_id":"","url":"https://api.github.com/users/qcolombet","html_url":"https://github.com/qcolombet","followers_url":"https://api.github.com/users/qcolombet/followers","following_url":"https://api.github.com/users/qcolombet/following{/other_user}","gists_url":"https://api.github.com/users/qcolombet/gists{/gist_id}","starred_url":"https://api.github.com/users/qcolombet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qcolombet/subscriptions","organizations_url":"https://api.github.com/users/qcolombet/orgs","repos_url":"https://api.github.com/users/qcolombet/repos","events_url":"https://api.github.com/users/qcolombet/events{/privacy}","received_events_url":"https://api.github.com/users/qcolombet/received_events","type":"User","site_admin":false},"repo":{"id":135468105,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NjgxMDU=","name":"glow","full_name":"qcolombet/glow","private":false,"owner":{"login":"qcolombet","id":15787733,"node_id":"MDQ6VXNlcjE1Nzg3NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/15787733?v=4","gravatar_id":"","url":"https://api.github.com/users/qcolombet","html_url":"https://github.com/qcolombet","followers_url":"https://api.github.com/users/qcolombet/followers","following_url":"https://api.github.com/users/qcolombet/following{/other_user}","gists_url":"https://api.github.com/users/qcolombet/gists{/gist_id}","starred_url":"https://api.github.com/users/qcolombet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qcolombet/subscriptions","organizations_url":"https://api.github.com/users/qcolombet/orgs","repos_url":"https://api.github.com/users/qcolombet/repos","events_url":"https://api.github.com/users/qcolombet/events{/privacy}","received_events_url":"https://api.github.com/users/qcolombet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qcolombet/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/qcolombet/glow","forks_url":"https://api.github.com/repos/qcolombet/glow/forks","keys_url":"https://api.github.com/repos/qcolombet/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qcolombet/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qcolombet/glow/teams","hooks_url":"https://api.github.com/repos/qcolombet/glow/hooks","issue_events_url":"https://api.github.com/repos/qcolombet/glow/issues/events{/number}","events_url":"https://api.github.com/repos/qcolombet/glow/events","assignees_url":"https://api.github.com/repos/qcolombet/glow/assignees{/user}","branches_url":"https://api.github.com/repos/qcolombet/glow/branches{/branch}","tags_url":"https://api.github.com/repos/qcolombet/glow/tags","blobs_url":"https://api.github.com/repos/qcolombet/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qcolombet/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qcolombet/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/qcolombet/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qcolombet/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/qcolombet/glow/languages","stargazers_url":"https://api.github.com/repos/qcolombet/glow/stargazers","contributors_url":"https://api.github.com/repos/qcolombet/glow/contributors","subscribers_url":"https://api.github.com/repos/qcolombet/glow/subscribers","subscription_url":"https://api.github.com/repos/qcolombet/glow/subscription","commits_url":"https://api.github.com/repos/qcolombet/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/qcolombet/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/qcolombet/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/qcolombet/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/qcolombet/glow/contents/{+path}","compare_url":"https://api.github.com/repos/qcolombet/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qcolombet/glow/merges","archive_url":"https://api.github.com/repos/qcolombet/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qcolombet/glow/downloads","issues_url":"https://api.github.com/repos/qcolombet/glow/issues{/number}","pulls_url":"https://api.github.com/repos/qcolombet/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/qcolombet/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/qcolombet/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qcolombet/glow/labels{/name}","releases_url":"https://api.github.com/repos/qcolombet/glow/releases{/id}","deployments_url":"https://api.github.com/repos/qcolombet/glow/deployments","created_at":"2018-05-30T16:12:06Z","updated_at":"2018-09-28T00:16:57Z","pushed_at":"2018-10-10T01:58:31Z","git_url":"git://github.com/qcolombet/glow.git","ssh_url":"git@github.com:qcolombet/glow.git","clone_url":"https://github.com/qcolombet/glow.git","svn_url":"https://github.com/qcolombet/glow","homepage":null,"size":9413,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"15672d4681da096c2efca663d55b267f8279bda0","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-10-10T01:53:04Z","pushed_at":"2018-10-10T01:58:33Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":9341,"stargazers_count":906,"watchers_count":906,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":118,"open_issues":66,"watchers":906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1820"},"html":{"href":"https://github.com/pytorch/glow/pull/1820"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/1820"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/1820/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1820/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1820/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/e6c19143783db1c53f58ab99c47f5aeeb002aefc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qcolombet"}}