{"push_id":2825372340,"size":1,"distinct_size":1,"ref":"refs/heads/joinreader-opt","head":"34a81ffda01689379dd2c42554aaa136761616b6","before":"27eb13996f275199982c1aeedfe09f59d8f6991c","commits":[{"sha":"34a81ffda01689379dd2c42554aaa136761616b6","author":{"name":"Jordan Lewis","email":"d6a9c9ceebab0a60eea8692fb0aa04be2d19ee67@gmail.com"},"message":"distsqlrun: bugfixes/perf change to joinReader\n\nPreviously, joinReader used pretty-printed string keys to correlate its\ninput rows with its looked-up rows. This was incorrect and inefficient.\n\nNow, it uses bytes keys like everything else. Also, fix a bug that\ncaused partial key creation from EncDatums on tables with interleaves to\npanic and/or return incorrect results.\n\n```\nname                      old time/op    new time/op    delta\nJoinReader/rows=16-24        135µs ± 2%      88µs ± 1%  -35.18%  (p=0.000 n=10+9)\nJoinReader/rows=256-24      1.55ms ± 0%    0.82ms ± 1%  -47.10%  (p=0.000 n=10+10)\nJoinReader/rows=4096-24     42.3ms ± 0%    30.9ms ± 1%  -26.94%  (p=0.000 n=10+10)\nJoinReader/rows=65536-24     5.13s ± 1%     5.01s ± 1%   -2.40%  (p=0.000 n=10+10)\n\nname                      old speed      new speed      delta\nJoinReader/rows=16-24     2.85MB/s ± 1%  4.38MB/s ± 1%  +54.00%  (p=0.000 n=9+9)\nJoinReader/rows=256-24    3.95MB/s ± 1%  7.47MB/s ± 1%  +88.99%  (p=0.000 n=10+10)\nJoinReader/rows=4096-24   2.33MB/s ± 1%  3.18MB/s ± 1%  +36.77%  (p=0.000 n=10+10)\nJoinReader/rows=65536-24   310kB/s ± 0%   310kB/s ± 0%     ~     (all equal)\n\nname                      old alloc/op   new alloc/op   delta\nJoinReader/rows=16-24       40.4kB ± 1%    28.1kB ± 1%  -30.40%  (p=0.000 n=10+10)\nJoinReader/rows=256-24       390kB ± 0%     200kB ± 0%  -48.77%  (p=0.000 n=8+8)\nJoinReader/rows=4096-24     5.96MB ± 0%    2.93MB ± 0%  -50.87%  (p=0.000 n=9+8)\nJoinReader/rows=65536-24    99.3MB ± 6%    50.7MB ± 6%  -48.92%  (p=0.000 n=10+10)\n\nname                      old allocs/op  new allocs/op  delta\nJoinReader/rows=16-24          646 ± 0%       323 ± 0%  -50.08%  (p=0.000 n=10+10)\nJoinReader/rows=256-24       8.77k ± 0%     3.64k ± 0%  -58.55%  (p=0.000 n=10+8)\nJoinReader/rows=4096-24       139k ± 0%       57k ± 0%  -58.97%  (p=0.000 n=9+8)\nJoinReader/rows=65536-24     2.24M ± 1%     0.92M ± 3%  -58.68%  (p=0.000 n=9+9)\n```\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/jordanlewis/cockroach/commits/34a81ffda01689379dd2c42554aaa136761616b6"}]}
{"actor":{"display_login":"jordanlewis"}}