{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/38","id":214050418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDUwNDE4","html_url":"https://github.com/OpenRA/openrauseraccounts/pull/38","diff_url":"https://github.com/OpenRA/openrauseraccounts/pull/38.diff","patch_url":"https://github.com/OpenRA/openrauseraccounts/pull/38.patch","issue_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues/38","number":38,"state":"closed","locked":false,"title":"Acp badges rewrite","user":{"login":"matjaeck","id":37185497,"node_id":"MDQ6VXNlcjM3MTg1NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/37185497?v=4","gravatar_id":"","url":"https://api.github.com/users/matjaeck","html_url":"https://github.com/matjaeck","followers_url":"https://api.github.com/users/matjaeck/followers","following_url":"https://api.github.com/users/matjaeck/following{/other_user}","gists_url":"https://api.github.com/users/matjaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/matjaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matjaeck/subscriptions","organizations_url":"https://api.github.com/users/matjaeck/orgs","repos_url":"https://api.github.com/users/matjaeck/repos","events_url":"https://api.github.com/users/matjaeck/events{/privacy}","received_events_url":"https://api.github.com/users/matjaeck/received_events","type":"User","site_admin":false},"body":"A full rewrite of the ACP badges module with changes to the template and most language keys. The module info has also been changed which probably requires to delete the extension data to be safe. Otherwise the changes to the module info will break phpbb. We will have to repeat this for the foreseeable changes of the UCP module info too. Reason for the module info changes are foreseeable problems when adding more modules.\r\n\r\nNotable changes in `badges_module.php`:\r\n- Actions are parameters sent via GET that define a context for POST submits\r\n- Define a context for adding badges/ badge types in a GET request instead of using a POST submit to show the form.\r\n- Switch over `modes` and switch over `action` for each. Define submits within the actions.\r\n- Remove most `SELECT COUNT(*) ` queries\r\n- Fix some errors where $u_action was not defined correctly and would refer to wrong actions / parameters (the \"Return to last page\" link does not work everywhere as intended.)\r\n\r\nI restructured the code quite heavily so the diff is not really helpful I fear. \r\n","created_at":"2018-09-07T22:06:13Z","updated_at":"2018-12-02T22:00:17Z","closed_at":"2018-12-02T22:00:17Z","merged_at":null,"merge_commit_sha":"5e8bcc2d67485c2e5e3b44f2321d2e5b11b3b5cc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/38/commits","review_comments_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/38/comments","review_comment_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues/38/comments","statuses_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/statuses/f82559c232499b75f0b55b1aa932eaa6f8f282bf","head":{"label":"matjaeck:acp-badges-rewrite","ref":"acp-badges-rewrite","sha":"f82559c232499b75f0b55b1aa932eaa6f8f282bf","user":{"login":"matjaeck","id":37185497,"node_id":"MDQ6VXNlcjM3MTg1NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/37185497?v=4","gravatar_id":"","url":"https://api.github.com/users/matjaeck","html_url":"https://github.com/matjaeck","followers_url":"https://api.github.com/users/matjaeck/followers","following_url":"https://api.github.com/users/matjaeck/following{/other_user}","gists_url":"https://api.github.com/users/matjaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/matjaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matjaeck/subscriptions","organizations_url":"https://api.github.com/users/matjaeck/orgs","repos_url":"https://api.github.com/users/matjaeck/repos","events_url":"https://api.github.com/users/matjaeck/events{/privacy}","received_events_url":"https://api.github.com/users/matjaeck/received_events","type":"User","site_admin":false},"repo":{"id":142691541,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2OTE1NDE=","name":"openrauseraccounts","full_name":"matjaeck/openrauseraccounts","private":false,"owner":{"login":"matjaeck","id":37185497,"node_id":"MDQ6VXNlcjM3MTg1NDk3","avatar_url":"https://avatars2.githubusercontent.com/u/37185497?v=4","gravatar_id":"","url":"https://api.github.com/users/matjaeck","html_url":"https://github.com/matjaeck","followers_url":"https://api.github.com/users/matjaeck/followers","following_url":"https://api.github.com/users/matjaeck/following{/other_user}","gists_url":"https://api.github.com/users/matjaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/matjaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matjaeck/subscriptions","organizations_url":"https://api.github.com/users/matjaeck/orgs","repos_url":"https://api.github.com/users/matjaeck/repos","events_url":"https://api.github.com/users/matjaeck/events{/privacy}","received_events_url":"https://api.github.com/users/matjaeck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matjaeck/openrauseraccounts","description":null,"fork":true,"url":"https://api.github.com/repos/matjaeck/openrauseraccounts","forks_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/forks","keys_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/teams","hooks_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/hooks","issue_events_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/issues/events{/number}","events_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/events","assignees_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/assignees{/user}","branches_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/branches{/branch}","tags_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/tags","blobs_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/statuses/{sha}","languages_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/languages","stargazers_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/stargazers","contributors_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/contributors","subscribers_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/subscribers","subscription_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/subscription","commits_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/contents/{+path}","compare_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/merges","archive_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/downloads","issues_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/issues{/number}","pulls_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/pulls{/number}","milestones_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/milestones{/number}","notifications_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/labels{/name}","releases_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/releases{/id}","deployments_url":"https://api.github.com/repos/matjaeck/openrauseraccounts/deployments","created_at":"2018-07-28T16:12:11Z","updated_at":"2018-09-05T12:42:10Z","pushed_at":"2018-10-09T18:07:25Z","git_url":"git://github.com/matjaeck/openrauseraccounts.git","ssh_url":"git@github.com:matjaeck/openrauseraccounts.git","clone_url":"https://github.com/matjaeck/openrauseraccounts.git","svn_url":"https://github.com/matjaeck/openrauseraccounts","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenRA:master","ref":"master","sha":"3201df98e25c0f49902c002afd80c6c89f2dfff6","user":{"login":"OpenRA","id":409046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTA0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":136327708,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzMjc3MDg=","name":"openrauseraccounts","full_name":"OpenRA/openrauseraccounts","private":false,"owner":{"login":"OpenRA","id":409046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwOTA0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenRA/openrauseraccounts","description":null,"fork":false,"url":"https://api.github.com/repos/OpenRA/openrauseraccounts","forks_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/forks","keys_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/teams","hooks_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/events","assignees_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/tags","blobs_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/languages","stargazers_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/subscription","commits_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/merges","archive_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/downloads","issues_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/openrauseraccounts/deployments","created_at":"2018-06-06T12:47:24Z","updated_at":"2018-08-10T07:09:41Z","pushed_at":"2018-10-09T18:07:26Z","git_url":"git://github.com/OpenRA/openrauseraccounts.git","ssh_url":"git@github.com:OpenRA/openrauseraccounts.git","clone_url":"https://github.com/OpenRA/openrauseraccounts.git","svn_url":"https://github.com/OpenRA/openrauseraccounts","homepage":null,"size":31,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/38"},"html":{"href":"https://github.com/OpenRA/openrauseraccounts/pull/38"},"issue":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues/38"},"comments":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/openrauseraccounts/statuses/f82559c232499b75f0b55b1aa932eaa6f8f282bf"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":658,"deletions":835,"changed_files":7}}
{"actor":{"display_login":"matjaeck"}}