{"action":"created","comment":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/comments/178740310","pull_request_review_id":108846321,"id":178740310,"diff_hunk":"@@ -54,65 +59,157 @@ def initialize\n       config_param :key, :string\n       desc \"The regular expression.\"\n       config_param :pattern do |value|\n-        if value.start_with?(\"/\") and value.end_with(\"/\")\n+        if value.start_with?(\"/\") and value.end_with?(\"/\")\n           Regexp.compile(value[1..-2])\n         else\n           Regexp.compile(value)\n         end\n       end\n     end\n \n-    # for test\n-    attr_reader :_regexps\n-    attr_reader :_excludes\n+    config_section :and, param_name: :and_conditions, multi: true do\n+      config_section :regexp, param_name: :regexps, multi: true do\n+        desc \"The field name to which the regular expression is applied.\"\n+        config_param :key, :string\n+        desc \"The regular expression.\"\n+        config_param :pattern do |value|\n+          if value.start_with?(\"/\") and value.end_with?(\"/\")","path":"lib/fluent/plugin/filter_grep.rb","position":40,"original_position":40,"commit_id":"fd719a5ce3570a5e2f2b8f8f37eb6ce9ffcd1a00","original_commit_id":"fd719a5ce3570a5e2f2b8f8f37eb6ce9ffcd1a00","user":{"login":"okkez","id":33111,"avatar_url":"https://avatars1.githubusercontent.com/u/33111?v=4","gravatar_id":"","url":"https://api.github.com/users/okkez","html_url":"https://github.com/okkez","followers_url":"https://api.github.com/users/okkez/followers","following_url":"https://api.github.com/users/okkez/following{/other_user}","gists_url":"https://api.github.com/users/okkez/gists{/gist_id}","starred_url":"https://api.github.com/users/okkez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkez/subscriptions","organizations_url":"https://api.github.com/users/okkez/orgs","repos_url":"https://api.github.com/users/okkez/repos","events_url":"https://api.github.com/users/okkez/events{/privacy}","received_events_url":"https://api.github.com/users/okkez/received_events","type":"User","site_admin":false},"body":"Sure, I will write a patch for this.","created_at":"2018-04-03T07:56:09Z","updated_at":"2018-04-03T07:56:09Z","html_url":"https://github.com/fluent/fluentd/pull/1897#discussion_r178740310","pull_request_url":"https://api.github.com/repos/fluent/fluentd/pulls/1897","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments/178740310"},"html":{"href":"https://github.com/fluent/fluentd/pull/1897#discussion_r178740310"},"pull_request":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1897"}},"in_reply_to_id":178730491},"pull_request":{"url":"https://api.github.com/repos/fluent/fluentd/pulls/1897","id":175188090,"html_url":"https://github.com/fluent/fluentd/pull/1897","diff_url":"https://github.com/fluent/fluentd/pull/1897.diff","patch_url":"https://github.com/fluent/fluentd/pull/1897.patch","issue_url":"https://api.github.com/repos/fluent/fluentd/issues/1897","number":1897,"state":"open","locked":false,"title":"Support and/or section","user":{"login":"okkez","id":33111,"avatar_url":"https://avatars1.githubusercontent.com/u/33111?v=4","gravatar_id":"","url":"https://api.github.com/users/okkez","html_url":"https://github.com/okkez","followers_url":"https://api.github.com/users/okkez/followers","following_url":"https://api.github.com/users/okkez/following{/other_user}","gists_url":"https://api.github.com/users/okkez/gists{/gist_id}","starred_url":"https://api.github.com/users/okkez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkez/subscriptions","organizations_url":"https://api.github.com/users/okkez/orgs","repos_url":"https://api.github.com/users/okkez/repos","events_url":"https://api.github.com/users/okkez/events{/privacy}","received_events_url":"https://api.github.com/users/okkez/received_events","type":"User","site_admin":false},"body":"For example:\n\n    <filter>\n      @type grep\n      <and>\n        <regexp>\n          key level\n          pattern ^WARN|ERROR$\n        </regexp>\n        <regexp>\n          key method\n          pattern ^GET$\n        </regexp>\n      </and>\n    </filter>\n\nFor more details, see test code\n\nSee #1858","created_at":"2018-03-15T09:17:43Z","updated_at":"2018-04-03T07:56:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b06fb60da1383f62ab0b78117890517b03e294c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fluent/fluentd/pulls/1897/commits","review_comments_url":"https://api.github.com/repos/fluent/fluentd/pulls/1897/comments","review_comment_url":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluent/fluentd/issues/1897/comments","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/fd719a5ce3570a5e2f2b8f8f37eb6ce9ffcd1a00","head":{"label":"okkez:support-and-or","ref":"support-and-or","sha":"fd719a5ce3570a5e2f2b8f8f37eb6ce9ffcd1a00","user":{"login":"okkez","id":33111,"avatar_url":"https://avatars1.githubusercontent.com/u/33111?v=4","gravatar_id":"","url":"https://api.github.com/users/okkez","html_url":"https://github.com/okkez","followers_url":"https://api.github.com/users/okkez/followers","following_url":"https://api.github.com/users/okkez/following{/other_user}","gists_url":"https://api.github.com/users/okkez/gists{/gist_id}","starred_url":"https://api.github.com/users/okkez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkez/subscriptions","organizations_url":"https://api.github.com/users/okkez/orgs","repos_url":"https://api.github.com/users/okkez/repos","events_url":"https://api.github.com/users/okkez/events{/privacy}","received_events_url":"https://api.github.com/users/okkez/received_events","type":"User","site_admin":false},"repo":{"id":41343501,"name":"fluentd","full_name":"okkez/fluentd","owner":{"login":"okkez","id":33111,"avatar_url":"https://avatars1.githubusercontent.com/u/33111?v=4","gravatar_id":"","url":"https://api.github.com/users/okkez","html_url":"https://github.com/okkez","followers_url":"https://api.github.com/users/okkez/followers","following_url":"https://api.github.com/users/okkez/following{/other_user}","gists_url":"https://api.github.com/users/okkez/gists{/gist_id}","starred_url":"https://api.github.com/users/okkez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkez/subscriptions","organizations_url":"https://api.github.com/users/okkez/orgs","repos_url":"https://api.github.com/users/okkez/repos","events_url":"https://api.github.com/users/okkez/events{/privacy}","received_events_url":"https://api.github.com/users/okkez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/okkez/fluentd","description":"Fluentd data collector","fork":true,"url":"https://api.github.com/repos/okkez/fluentd","forks_url":"https://api.github.com/repos/okkez/fluentd/forks","keys_url":"https://api.github.com/repos/okkez/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okkez/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okkez/fluentd/teams","hooks_url":"https://api.github.com/repos/okkez/fluentd/hooks","issue_events_url":"https://api.github.com/repos/okkez/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/okkez/fluentd/events","assignees_url":"https://api.github.com/repos/okkez/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/okkez/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/okkez/fluentd/tags","blobs_url":"https://api.github.com/repos/okkez/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okkez/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okkez/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/okkez/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okkez/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/okkez/fluentd/languages","stargazers_url":"https://api.github.com/repos/okkez/fluentd/stargazers","contributors_url":"https://api.github.com/repos/okkez/fluentd/contributors","subscribers_url":"https://api.github.com/repos/okkez/fluentd/subscribers","subscription_url":"https://api.github.com/repos/okkez/fluentd/subscription","commits_url":"https://api.github.com/repos/okkez/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/okkez/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/okkez/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/okkez/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/okkez/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/okkez/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okkez/fluentd/merges","archive_url":"https://api.github.com/repos/okkez/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okkez/fluentd/downloads","issues_url":"https://api.github.com/repos/okkez/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/okkez/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/okkez/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/okkez/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okkez/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/okkez/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/okkez/fluentd/deployments","created_at":"2015-08-25T04:47:23Z","updated_at":"2018-03-27T08:10:12Z","pushed_at":"2018-04-03T00:03:35Z","git_url":"git://github.com/okkez/fluentd.git","ssh_url":"git@github.com:okkez/fluentd.git","clone_url":"https://github.com/okkez/fluentd.git","svn_url":"https://github.com/okkez/fluentd","homepage":"http://www.fluentd.org/","size":14992,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fluent:master","ref":"master","sha":"b999f807768e72659951f412fa8c9a6fa2bcdc2c","user":{"login":"fluent","id":859518,"avatar_url":"https://avatars0.githubusercontent.com/u/859518?v=4","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"repo":{"id":1918677,"name":"fluentd","full_name":"fluent/fluentd","owner":{"login":"fluent","id":859518,"avatar_url":"https://avatars0.githubusercontent.com/u/859518?v=4","gravatar_id":"","url":"https://api.github.com/users/fluent","html_url":"https://github.com/fluent","followers_url":"https://api.github.com/users/fluent/followers","following_url":"https://api.github.com/users/fluent/following{/other_user}","gists_url":"https://api.github.com/users/fluent/gists{/gist_id}","starred_url":"https://api.github.com/users/fluent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluent/subscriptions","organizations_url":"https://api.github.com/users/fluent/orgs","repos_url":"https://api.github.com/users/fluent/repos","events_url":"https://api.github.com/users/fluent/events{/privacy}","received_events_url":"https://api.github.com/users/fluent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fluent/fluentd","description":"Fluentd: Unified Logging Layer (project under CNCF)","fork":false,"url":"https://api.github.com/repos/fluent/fluentd","forks_url":"https://api.github.com/repos/fluent/fluentd/forks","keys_url":"https://api.github.com/repos/fluent/fluentd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluent/fluentd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluent/fluentd/teams","hooks_url":"https://api.github.com/repos/fluent/fluentd/hooks","issue_events_url":"https://api.github.com/repos/fluent/fluentd/issues/events{/number}","events_url":"https://api.github.com/repos/fluent/fluentd/events","assignees_url":"https://api.github.com/repos/fluent/fluentd/assignees{/user}","branches_url":"https://api.github.com/repos/fluent/fluentd/branches{/branch}","tags_url":"https://api.github.com/repos/fluent/fluentd/tags","blobs_url":"https://api.github.com/repos/fluent/fluentd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluent/fluentd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluent/fluentd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluent/fluentd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluent/fluentd/statuses/{sha}","languages_url":"https://api.github.com/repos/fluent/fluentd/languages","stargazers_url":"https://api.github.com/repos/fluent/fluentd/stargazers","contributors_url":"https://api.github.com/repos/fluent/fluentd/contributors","subscribers_url":"https://api.github.com/repos/fluent/fluentd/subscribers","subscription_url":"https://api.github.com/repos/fluent/fluentd/subscription","commits_url":"https://api.github.com/repos/fluent/fluentd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluent/fluentd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluent/fluentd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluent/fluentd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluent/fluentd/contents/{+path}","compare_url":"https://api.github.com/repos/fluent/fluentd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluent/fluentd/merges","archive_url":"https://api.github.com/repos/fluent/fluentd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluent/fluentd/downloads","issues_url":"https://api.github.com/repos/fluent/fluentd/issues{/number}","pulls_url":"https://api.github.com/repos/fluent/fluentd/pulls{/number}","milestones_url":"https://api.github.com/repos/fluent/fluentd/milestones{/number}","notifications_url":"https://api.github.com/repos/fluent/fluentd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluent/fluentd/labels{/name}","releases_url":"https://api.github.com/repos/fluent/fluentd/releases{/id}","deployments_url":"https://api.github.com/repos/fluent/fluentd/deployments","created_at":"2011-06-19T08:41:40Z","updated_at":"2018-04-03T07:07:45Z","pushed_at":"2018-04-03T06:37:11Z","git_url":"git://github.com/fluent/fluentd.git","ssh_url":"git@github.com:fluent/fluentd.git","clone_url":"https://github.com/fluent/fluentd.git","svn_url":"https://github.com/fluent/fluentd","homepage":"https://www.fluentd.org/","size":15534,"stargazers_count":6194,"watchers_count":6194,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":744,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":744,"open_issues":140,"watchers":6194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1897"},"html":{"href":"https://github.com/fluent/fluentd/pull/1897"},"issue":{"href":"https://api.github.com/repos/fluent/fluentd/issues/1897"},"comments":{"href":"https://api.github.com/repos/fluent/fluentd/issues/1897/comments"},"review_comments":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1897/comments"},"review_comment":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluent/fluentd/pulls/1897/commits"},"statuses":{"href":"https://api.github.com/repos/fluent/fluentd/statuses/fd719a5ce3570a5e2f2b8f8f37eb6ce9ffcd1a00"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"okkez"}}