{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/issues/14","repository_url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins","labels_url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/issues/14/comments","events_url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/issues/14/events","html_url":"https://github.com/kubevirt/kubernetes-device-plugins/issues/14","id":299356558,"node_id":"MDU6SXNzdWUyOTkzNTY1NTg=","number":14,"title":"The plugins are missing tests","user":{"login":"mpolednik","id":2596342,"node_id":"MDQ6VXNlcjI1OTYzNDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2596342?v=4","gravatar_id":"","url":"https://api.github.com/users/mpolednik","html_url":"https://github.com/mpolednik","followers_url":"https://api.github.com/users/mpolednik/followers","following_url":"https://api.github.com/users/mpolednik/following{/other_user}","gists_url":"https://api.github.com/users/mpolednik/gists{/gist_id}","starred_url":"https://api.github.com/users/mpolednik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpolednik/subscriptions","organizations_url":"https://api.github.com/users/mpolednik/orgs","repos_url":"https://api.github.com/users/mpolednik/repos","events_url":"https://api.github.com/users/mpolednik/events{/privacy}","received_events_url":"https://api.github.com/users/mpolednik/received_events","type":"User","site_admin":false},"labels":[{"id":1080257592,"node_id":"MDU6TGFiZWwxMDgwMjU3NTky","url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/labels/lifecycle/rotten","name":"lifecycle/rotten","color":"604460","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-22T13:36:43Z","updated_at":"2018-12-15T08:42:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently, there are no tests for the plugin themselves and only simple test for manager. This should be our top priority, as having untested code handle devices in the system is extremely dangerous.\r\n\r\nGeneral ideas:\r\n\r\n* let's consider gomega/ginkgo for BDD (depends on setup/teardown complexity compared to gotest)\r\n* mock Kubelet's device plugin gRPC API to have properly tested manager code\r\n* have unit + functional tests of the plugins (subject to hw requirements) "},"comment":{"url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/issues/comments/447550652","html_url":"https://github.com/kubevirt/kubernetes-device-plugins/issues/14#issuecomment-447550652","issue_url":"https://api.github.com/repos/kubevirt/kubernetes-device-plugins/issues/14","id":447550652,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzU1MDY1Mg==","user":{"login":"kubevirt-bot","id":25687724,"node_id":"MDQ6VXNlcjI1Njg3NzI0","avatar_url":"https://avatars2.githubusercontent.com/u/25687724?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt-bot","html_url":"https://github.com/kubevirt-bot","followers_url":"https://api.github.com/users/kubevirt-bot/followers","following_url":"https://api.github.com/users/kubevirt-bot/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt-bot/subscriptions","organizations_url":"https://api.github.com/users/kubevirt-bot/orgs","repos_url":"https://api.github.com/users/kubevirt-bot/repos","events_url":"https://api.github.com/users/kubevirt-bot/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt-bot/received_events","type":"User","site_admin":false},"created_at":"2018-12-15T08:42:46Z","updated_at":"2018-12-15T08:42:46Z","author_association":"NONE","body":"@kubevirt-bot: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubevirt/kubernetes-device-plugins/issues/14#issuecomment-447550650):\n\n>Rotten issues close after 30d of inactivity.\n>Reopen the issue with `/reopen`.\n>Mark the issue as fresh with `/remove-lifecycle rotten`.\n>\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>"}}
{"actor":{"display_login":"kubevirt-bot"}}