{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/23056","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/23056/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23056/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/23056/events","html_url":"https://github.com/nodejs/node/pull/23056","id":363122958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjM4MzY1","number":23056,"title":"assert: improve the strict equal messages","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"labels":[{"id":155267445,"node_id":"MDU6TGFiZWwxNTUyNjc0NDU=","url":"https://api.github.com/repos/nodejs/node/labels/assert","name":"assert","color":"d4c5f9","default":false},{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-09-24T12:23:47Z","updated_at":"2018-09-27T11:34:40Z","closed_at":"2018-09-27T11:34:41Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23056","html_url":"https://github.com/nodejs/node/pull/23056","diff_url":"https://github.com/nodejs/node/pull/23056.diff","patch_url":"https://github.com/nodejs/node/pull/23056.patch"},"body":"In case reference (un)equal objects fail in assertion, it should be\r\nclear that it is about the reference equality and not about the\r\nobject properties. This is fixed by improving the message in such\r\ncases.\r\n\r\nRefs: https://github.com/nodejs/node/issues/22763\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/425057257","html_url":"https://github.com/nodejs/node/pull/23056#issuecomment-425057257","issue_url":"https://api.github.com/repos/nodejs/node/issues/23056","id":425057257,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTA1NzI1Nw==","user":{"login":"BridgeAR","id":8822573,"node_id":"MDQ6VXNlcjg4MjI1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T11:34:40Z","updated_at":"2018-09-27T11:34:40Z","author_association":"MEMBER","body":"Landed in be26c761146db8357653df345e505a624b2153da and b8a8eedf3280f3825812d3f8f0554a186396c9dc."}}
{"actor":{"display_login":"BridgeAR"}}