{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/bolt/pulls/comments/178389106","pull_request_review_id":108447264,"id":178389106,"diff_hunk":"@@ -511,7 +511,7 @@ def execute(options)\n           options[:task_options]['nodes'] = options[:nodes].join(',')\n         end\n         executor = Bolt::Executor.new(config, options[:noop], true)\n-        result = pal.run_plan(options[:object], options[:task_options], executor, inventory)\n+        result = pal.run_plan(options[:object], options[:task_options], executor, inventory, puppetdb_client)","path":"lib/bolt/cli.rb","position":26,"original_position":5,"commit_id":"b6b7bfb3c49264d909430936016531eba83ecde1","original_commit_id":"0cee6cc115980a16f4bb1b1fe0b8a2979168045d","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars0.githubusercontent.com/u/8162496?v=4","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"I don't think we want to always fail if puppetdb isn't configured. This delays errors until use, which seems like the only viable UX.","created_at":"2018-03-30T21:42:35Z","updated_at":"2018-03-30T21:42:35Z","html_url":"https://github.com/puppetlabs/bolt/pull/369#discussion_r178389106","pull_request_url":"https://api.github.com/repos/puppetlabs/bolt/pulls/369","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/bolt/pulls/comments/178389106"},"html":{"href":"https://github.com/puppetlabs/bolt/pull/369#discussion_r178389106"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/bolt/pulls/369"}},"in_reply_to_id":178384102},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/bolt/pulls/369","id":178632233,"html_url":"https://github.com/puppetlabs/bolt/pull/369","diff_url":"https://github.com/puppetlabs/bolt/pull/369.diff","patch_url":"https://github.com/puppetlabs/bolt/pull/369.patch","issue_url":"https://api.github.com/repos/puppetlabs/bolt/issues/369","number":369,"state":"open","locked":false,"title":"(maint) Add spec tests for the puppetdb_fact plan","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars0.githubusercontent.com/u/8162496?v=4","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Note that it places expectations on the executor directly. The\r\n`puppetdb_fact` method may move out of the executor directly, so we\r\ndon't add an explicit helper to BoltSpec::Plans.","created_at":"2018-03-30T20:45:00Z","updated_at":"2018-03-30T21:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6701bdfbdc27d75c5610a05aa2213d0c8cc53e18","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adreyer","id":503750,"avatar_url":"https://avatars1.githubusercontent.com/u/503750?v=4","gravatar_id":"","url":"https://api.github.com/users/adreyer","html_url":"https://github.com/adreyer","followers_url":"https://api.github.com/users/adreyer/followers","following_url":"https://api.github.com/users/adreyer/following{/other_user}","gists_url":"https://api.github.com/users/adreyer/gists{/gist_id}","starred_url":"https://api.github.com/users/adreyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adreyer/subscriptions","organizations_url":"https://api.github.com/users/adreyer/orgs","repos_url":"https://api.github.com/users/adreyer/repos","events_url":"https://api.github.com/users/adreyer/events{/privacy}","received_events_url":"https://api.github.com/users/adreyer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/bolt/pulls/369/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/bolt/pulls/369/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/bolt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/bolt/issues/369/comments","statuses_url":"https://api.github.com/repos/puppetlabs/bolt/statuses/b6b7bfb3c49264d909430936016531eba83ecde1","head":{"label":"MikaelSmith:plan-test-puppetdb_fact","ref":"plan-test-puppetdb_fact","sha":"b6b7bfb3c49264d909430936016531eba83ecde1","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars0.githubusercontent.com/u/8162496?v=4","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":106455068,"name":"bolt","full_name":"MikaelSmith/bolt","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars0.githubusercontent.com/u/8162496?v=4","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/bolt","description":"Execute commands remotely over SSH and WinRM","fork":true,"url":"https://api.github.com/repos/MikaelSmith/bolt","forks_url":"https://api.github.com/repos/MikaelSmith/bolt/forks","keys_url":"https://api.github.com/repos/MikaelSmith/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/bolt/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/bolt/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/bolt/events","assignees_url":"https://api.github.com/repos/MikaelSmith/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/bolt/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/bolt/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/bolt/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/bolt/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/bolt/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/bolt/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikaelSmith/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/bolt/merges","archive_url":"https://api.github.com/repos/MikaelSmith/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/bolt/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/bolt/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/MikaelSmith/bolt/deployments","created_at":"2017-10-10T18:23:34Z","updated_at":"2017-10-10T18:23:36Z","pushed_at":"2018-03-30T21:39:48Z","git_url":"git://github.com/MikaelSmith/bolt.git","ssh_url":"git@github.com:MikaelSmith/bolt.git","clone_url":"https://github.com/MikaelSmith/bolt.git","svn_url":"https://github.com/MikaelSmith/bolt","homepage":null,"size":1564,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"f618a3157ba281306bd3df3e10eb15e649c37d45","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":99991450,"name":"bolt","full_name":"puppetlabs/bolt","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/bolt","description":"Execute commands remotely over SSH and WinRM","fork":false,"url":"https://api.github.com/repos/puppetlabs/bolt","forks_url":"https://api.github.com/repos/puppetlabs/bolt/forks","keys_url":"https://api.github.com/repos/puppetlabs/bolt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/bolt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/bolt/teams","hooks_url":"https://api.github.com/repos/puppetlabs/bolt/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/bolt/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/bolt/events","assignees_url":"https://api.github.com/repos/puppetlabs/bolt/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/bolt/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/bolt/tags","blobs_url":"https://api.github.com/repos/puppetlabs/bolt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/bolt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/bolt/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/bolt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/bolt/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/bolt/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/bolt/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/bolt/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/bolt/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/bolt/subscription","commits_url":"https://api.github.com/repos/puppetlabs/bolt/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/bolt/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/bolt/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/bolt/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/bolt/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/bolt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/bolt/merges","archive_url":"https://api.github.com/repos/puppetlabs/bolt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/bolt/downloads","issues_url":"https://api.github.com/repos/puppetlabs/bolt/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/bolt/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/bolt/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/bolt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/bolt/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/bolt/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/bolt/deployments","created_at":"2017-08-11T04:26:56Z","updated_at":"2018-03-30T19:05:04Z","pushed_at":"2018-03-30T21:39:50Z","git_url":"git://github.com/puppetlabs/bolt.git","ssh_url":"git@github.com:puppetlabs/bolt.git","clone_url":"https://github.com/puppetlabs/bolt.git","svn_url":"https://github.com/puppetlabs/bolt","homepage":null,"size":1639,"stargazers_count":133,"watchers_count":133,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":48,"open_issues":14,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/bolt/pulls/369"},"html":{"href":"https://github.com/puppetlabs/bolt/pull/369"},"issue":{"href":"https://api.github.com/repos/puppetlabs/bolt/issues/369"},"comments":{"href":"https://api.github.com/repos/puppetlabs/bolt/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/bolt/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/bolt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/bolt/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/bolt/statuses/b6b7bfb3c49264d909430936016531eba83ecde1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MikaelSmith"}}