{"action":"created","comment":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments/234514624","pull_request_review_id":176168186,"id":234514624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDUxNDYyNA==","diff_hunk":"@@ -40,62 +40,70 @@ class Image16 : public IImage16, public ImageIO\n     Image16(int width, int height);\n     ~Image16();\n \n-    Image16*             copy();\n+    Image16* copy() const;\n \n-    Image8*              to8();\n-    Imagefloat*          tofloat();\n+    Image8* to8() const;\n+    Imagefloat* tofloat() const;\n \n-    virtual void         getStdImage(ColorTemp ctemp, int tran, Imagefloat* image, PreviewProps pp);\n+    virtual void getStdImage(const ColorTemp &ctemp, int tran, Imagefloat* image, PreviewProps pp) const;\n \n-    virtual const char*  getType() const\n+    virtual const char* getType() const\n     {\n         return sImage16;\n     }\n-    virtual int          getBPS()\n+    virtual int getBPS() const\n     {\n         return 8 * sizeof(unsigned short);\n     }\n-    virtual void         getScanline(int row, unsigned char* buffer, int bps, bool isFloat = false);\n-    virtual void         setScanline(int row, unsigned char* buffer, int bps, unsigned int numSamples);\n+    virtual void getScanline(int row, unsigned char* buffer, int bps, bool isFloat = false) const;\n+    virtual void setScanline(int row, unsigned char* buffer, int bps, unsigned int numSamples);\n \n     // functions inherited from IImage16:\n-    virtual MyMutex&     getMutex()\n+    virtual MyMutex& getMutex()\n     {\n         return mutex();","path":"rtengine/image16.h","position":34,"original_position":34,"commit_id":"512adf5b62c797b646741777e9eedb1b35563e18","original_commit_id":"512adf5b62c797b646741777e9eedb1b35563e18","user":{"login":"Floessie","id":10133457,"node_id":"MDQ6VXNlcjEwMTMzNDU3","avatar_url":"https://avatars3.githubusercontent.com/u/10133457?v=4","gravatar_id":"","url":"https://api.github.com/users/Floessie","html_url":"https://github.com/Floessie","followers_url":"https://api.github.com/users/Floessie/followers","following_url":"https://api.github.com/users/Floessie/following{/other_user}","gists_url":"https://api.github.com/users/Floessie/gists{/gist_id}","starred_url":"https://api.github.com/users/Floessie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Floessie/subscriptions","organizations_url":"https://api.github.com/users/Floessie/orgs","repos_url":"https://api.github.com/users/Floessie/repos","events_url":"https://api.github.com/users/Floessie/events{/privacy}","received_events_url":"https://api.github.com/users/Floessie/received_events","type":"User","site_admin":false},"body":"Hmm, I don't get this one (at least from the diff): Are we returning a temporary here, or is that some non-intuitive `operator ()`? And why non-const?","created_at":"2018-11-19T07:27:41Z","updated_at":"2018-11-19T07:51:49Z","html_url":"https://github.com/Beep6581/RawTherapee/pull/4992#discussion_r234514624","pull_request_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments/234514624"},"html":{"href":"https://github.com/Beep6581/RawTherapee/pull/4992#discussion_r234514624"},"pull_request":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992"}}},"pull_request":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992","id":231792463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzkyNDYz","html_url":"https://github.com/Beep6581/RawTherapee/pull/4992","diff_url":"https://github.com/Beep6581/RawTherapee/pull/4992.diff","patch_url":"https://github.com/Beep6581/RawTherapee/pull/4992.patch","issue_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4992","number":4992,"state":"open","locked":false,"title":"Review of image classes interfaces","user":{"login":"heckflosse","id":13733487,"node_id":"MDQ6VXNlcjEzNzMzNDg3","avatar_url":"https://avatars3.githubusercontent.com/u/13733487?v=4","gravatar_id":"","url":"https://api.github.com/users/heckflosse","html_url":"https://github.com/heckflosse","followers_url":"https://api.github.com/users/heckflosse/followers","following_url":"https://api.github.com/users/heckflosse/following{/other_user}","gists_url":"https://api.github.com/users/heckflosse/gists{/gist_id}","starred_url":"https://api.github.com/users/heckflosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heckflosse/subscriptions","organizations_url":"https://api.github.com/users/heckflosse/orgs","repos_url":"https://api.github.com/users/heckflosse/repos","events_url":"https://api.github.com/users/heckflosse/events{/privacy}","received_events_url":"https://api.github.com/users/heckflosse/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-18T14:43:57Z","updated_at":"2018-11-19T07:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2023b6210535ef4b34ee28a89bca291a501cb25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/milestones/5","html_url":"https://github.com/Beep6581/RawTherapee/milestone/5","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/milestones/5/labels","id":2916765,"node_id":"MDk6TWlsZXN0b25lMjkxNjc2NQ==","number":5,"title":"v5.5","description":"","creator":{"login":"Beep6581","id":5844619,"node_id":"MDQ6VXNlcjU4NDQ2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5844619?v=4","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":152,"state":"open","created_at":"2017-11-16T10:41:19Z","updated_at":"2018-11-18T17:29:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992/commits","review_comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992/comments","review_comment_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4992/comments","statuses_url":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/512adf5b62c797b646741777e9eedb1b35563e18","head":{"label":"Beep6581:review-image-classes","ref":"review-image-classes","sha":"512adf5b62c797b646741777e9eedb1b35563e18","user":{"login":"Beep6581","id":5844619,"node_id":"MDQ6VXNlcjU4NDQ2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5844619?v=4","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"repo":{"id":40539005,"node_id":"MDEwOlJlcG9zaXRvcnk0MDUzOTAwNQ==","name":"RawTherapee","full_name":"Beep6581/RawTherapee","private":false,"owner":{"login":"Beep6581","id":5844619,"node_id":"MDQ6VXNlcjU4NDQ2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5844619?v=4","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Beep6581/RawTherapee","description":"A powerful cross-platform raw photo processing program","fork":false,"url":"https://api.github.com/repos/Beep6581/RawTherapee","forks_url":"https://api.github.com/repos/Beep6581/RawTherapee/forks","keys_url":"https://api.github.com/repos/Beep6581/RawTherapee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beep6581/RawTherapee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beep6581/RawTherapee/teams","hooks_url":"https://api.github.com/repos/Beep6581/RawTherapee/hooks","issue_events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/events{/number}","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/events","assignees_url":"https://api.github.com/repos/Beep6581/RawTherapee/assignees{/user}","branches_url":"https://api.github.com/repos/Beep6581/RawTherapee/branches{/branch}","tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/tags","blobs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/{sha}","languages_url":"https://api.github.com/repos/Beep6581/RawTherapee/languages","stargazers_url":"https://api.github.com/repos/Beep6581/RawTherapee/stargazers","contributors_url":"https://api.github.com/repos/Beep6581/RawTherapee/contributors","subscribers_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscribers","subscription_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscription","commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beep6581/RawTherapee/contents/{+path}","compare_url":"https://api.github.com/repos/Beep6581/RawTherapee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beep6581/RawTherapee/merges","archive_url":"https://api.github.com/repos/Beep6581/RawTherapee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beep6581/RawTherapee/downloads","issues_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues{/number}","pulls_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls{/number}","milestones_url":"https://api.github.com/repos/Beep6581/RawTherapee/milestones{/number}","notifications_url":"https://api.github.com/repos/Beep6581/RawTherapee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/labels{/name}","releases_url":"https://api.github.com/repos/Beep6581/RawTherapee/releases{/id}","deployments_url":"https://api.github.com/repos/Beep6581/RawTherapee/deployments","created_at":"2015-08-11T11:54:01Z","updated_at":"2018-11-19T06:52:26Z","pushed_at":"2018-11-19T01:55:45Z","git_url":"git://github.com/Beep6581/RawTherapee.git","ssh_url":"git@github.com:Beep6581/RawTherapee.git","clone_url":"https://github.com/Beep6581/RawTherapee.git","svn_url":"https://github.com/Beep6581/RawTherapee","homepage":"http://rawtherapee.com/","size":142312,"stargazers_count":657,"watchers_count":657,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":628,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":128,"open_issues":628,"watchers":657,"default_branch":"dev"}},"base":{"label":"Beep6581:dev","ref":"dev","sha":"99c8b6061513742e048bb723e24444d11008521c","user":{"login":"Beep6581","id":5844619,"node_id":"MDQ6VXNlcjU4NDQ2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5844619?v=4","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"repo":{"id":40539005,"node_id":"MDEwOlJlcG9zaXRvcnk0MDUzOTAwNQ==","name":"RawTherapee","full_name":"Beep6581/RawTherapee","private":false,"owner":{"login":"Beep6581","id":5844619,"node_id":"MDQ6VXNlcjU4NDQ2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5844619?v=4","gravatar_id":"","url":"https://api.github.com/users/Beep6581","html_url":"https://github.com/Beep6581","followers_url":"https://api.github.com/users/Beep6581/followers","following_url":"https://api.github.com/users/Beep6581/following{/other_user}","gists_url":"https://api.github.com/users/Beep6581/gists{/gist_id}","starred_url":"https://api.github.com/users/Beep6581/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beep6581/subscriptions","organizations_url":"https://api.github.com/users/Beep6581/orgs","repos_url":"https://api.github.com/users/Beep6581/repos","events_url":"https://api.github.com/users/Beep6581/events{/privacy}","received_events_url":"https://api.github.com/users/Beep6581/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Beep6581/RawTherapee","description":"A powerful cross-platform raw photo processing program","fork":false,"url":"https://api.github.com/repos/Beep6581/RawTherapee","forks_url":"https://api.github.com/repos/Beep6581/RawTherapee/forks","keys_url":"https://api.github.com/repos/Beep6581/RawTherapee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Beep6581/RawTherapee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Beep6581/RawTherapee/teams","hooks_url":"https://api.github.com/repos/Beep6581/RawTherapee/hooks","issue_events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/events{/number}","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/events","assignees_url":"https://api.github.com/repos/Beep6581/RawTherapee/assignees{/user}","branches_url":"https://api.github.com/repos/Beep6581/RawTherapee/branches{/branch}","tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/tags","blobs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/refs{/sha}","trees_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/{sha}","languages_url":"https://api.github.com/repos/Beep6581/RawTherapee/languages","stargazers_url":"https://api.github.com/repos/Beep6581/RawTherapee/stargazers","contributors_url":"https://api.github.com/repos/Beep6581/RawTherapee/contributors","subscribers_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscribers","subscription_url":"https://api.github.com/repos/Beep6581/RawTherapee/subscription","commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/commits{/sha}","git_commits_url":"https://api.github.com/repos/Beep6581/RawTherapee/git/commits{/sha}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/comments{/number}","issue_comment_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments{/number}","contents_url":"https://api.github.com/repos/Beep6581/RawTherapee/contents/{+path}","compare_url":"https://api.github.com/repos/Beep6581/RawTherapee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Beep6581/RawTherapee/merges","archive_url":"https://api.github.com/repos/Beep6581/RawTherapee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Beep6581/RawTherapee/downloads","issues_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues{/number}","pulls_url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls{/number}","milestones_url":"https://api.github.com/repos/Beep6581/RawTherapee/milestones{/number}","notifications_url":"https://api.github.com/repos/Beep6581/RawTherapee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/labels{/name}","releases_url":"https://api.github.com/repos/Beep6581/RawTherapee/releases{/id}","deployments_url":"https://api.github.com/repos/Beep6581/RawTherapee/deployments","created_at":"2015-08-11T11:54:01Z","updated_at":"2018-11-19T06:52:26Z","pushed_at":"2018-11-19T01:55:45Z","git_url":"git://github.com/Beep6581/RawTherapee.git","ssh_url":"git@github.com:Beep6581/RawTherapee.git","clone_url":"https://github.com/Beep6581/RawTherapee.git","svn_url":"https://github.com/Beep6581/RawTherapee","homepage":"http://rawtherapee.com/","size":142312,"stargazers_count":657,"watchers_count":657,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":628,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":128,"open_issues":628,"watchers":657,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992"},"html":{"href":"https://github.com/Beep6581/RawTherapee/pull/4992"},"issue":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4992"},"comments":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/issues/4992/comments"},"review_comments":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992/comments"},"review_comment":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/4992/commits"},"statuses":{"href":"https://api.github.com/repos/Beep6581/RawTherapee/statuses/512adf5b62c797b646741777e9eedb1b35563e18"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Floessie"}}