{"action":"opened","number":3322,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3322","id":194104483,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTA0NDgz","html_url":"https://github.com/codice/ddf/pull/3322","diff_url":"https://github.com/codice/ddf/pull/3322.diff","patch_url":"https://github.com/codice/ddf/pull/3322.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3322","number":3322,"state":"open","locked":false,"title":"DDF-3884 Terminates DDF if any security policy file is malformed.","user":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nPrints the name of the failing policy file to the command line and executes a hard system exit.\r\n\r\nThis prevents the system from initializing in an unsecured state.\r\n\r\n#### Who is reviewing it? \r\n@brjeter @blen-desta \r\n\r\n#### Select relevant component teams: \r\n@codice/security \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here. If you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n@rzwiefel\r\n@stustison\r\n\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nEdit any policy file in the `security` directory to make it badly formatted. Attempt to start the server. It should exit immediately, printing the name of the invalid file to the command line.\r\n\r\nWill fail fast on the first badly formatted file it encounters.\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-3884](https://codice.atlassian.net/browse/DDF-3884)\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-06-11T21:10:40Z","updated_at":"2018-06-11T21:10:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},"assignees":[{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},{"login":"rzwiefel","id":9013416,"node_id":"MDQ6VXNlcjkwMTM0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9013416?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3322/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3322/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3322/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/2b74321f12d19131b365898252c224b1ce62fa4e","head":{"label":"coyotesqrl:DDF-3884","ref":"DDF-3884","sha":"2b74321f12d19131b365898252c224b1ce62fa4e","user":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"repo":{"id":64254932,"node_id":"MDEwOlJlcG9zaXRvcnk2NDI1NDkzMg==","name":"ddf","full_name":"coyotesqrl/ddf","owner":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coyotesqrl/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/coyotesqrl/ddf","forks_url":"https://api.github.com/repos/coyotesqrl/ddf/forks","keys_url":"https://api.github.com/repos/coyotesqrl/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coyotesqrl/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coyotesqrl/ddf/teams","hooks_url":"https://api.github.com/repos/coyotesqrl/ddf/hooks","issue_events_url":"https://api.github.com/repos/coyotesqrl/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/coyotesqrl/ddf/events","assignees_url":"https://api.github.com/repos/coyotesqrl/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/coyotesqrl/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/coyotesqrl/ddf/tags","blobs_url":"https://api.github.com/repos/coyotesqrl/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coyotesqrl/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coyotesqrl/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/coyotesqrl/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coyotesqrl/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/coyotesqrl/ddf/languages","stargazers_url":"https://api.github.com/repos/coyotesqrl/ddf/stargazers","contributors_url":"https://api.github.com/repos/coyotesqrl/ddf/contributors","subscribers_url":"https://api.github.com/repos/coyotesqrl/ddf/subscribers","subscription_url":"https://api.github.com/repos/coyotesqrl/ddf/subscription","commits_url":"https://api.github.com/repos/coyotesqrl/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/coyotesqrl/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/coyotesqrl/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/coyotesqrl/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/coyotesqrl/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/coyotesqrl/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coyotesqrl/ddf/merges","archive_url":"https://api.github.com/repos/coyotesqrl/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coyotesqrl/ddf/downloads","issues_url":"https://api.github.com/repos/coyotesqrl/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/coyotesqrl/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/coyotesqrl/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/coyotesqrl/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coyotesqrl/ddf/labels{/name}","releases_url":"https://api.github.com/repos/coyotesqrl/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/coyotesqrl/ddf/deployments","created_at":"2016-07-26T21:09:49Z","updated_at":"2016-07-26T21:10:03Z","pushed_at":"2018-06-11T21:06:47Z","git_url":"git://github.com/coyotesqrl/ddf.git","ssh_url":"git@github.com:coyotesqrl/ddf.git","clone_url":"https://github.com/coyotesqrl/ddf.git","svn_url":"https://github.com/coyotesqrl/ddf","homepage":"http://ddf.codice.org","size":330154,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"4939ec7ee655e1db8df9ec7ee97b36f4f015c343","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-06-08T21:43:10Z","pushed_at":"2018-06-11T19:50:35Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":391426,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":145,"open_issues":32,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3322"},"html":{"href":"https://github.com/codice/ddf/pull/3322"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3322"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3322/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3322/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3322/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/2b74321f12d19131b365898252c224b1ce62fa4e"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"coyotesqrl"}}