{"action":"created","comment":{"url":"https://api.github.com/repos/webhintio/hint/pulls/comments/219998649","pull_request_review_id":158307153,"id":219998649,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk5ODY0OQ==","diff_hunk":"@@ -63,20 +65,22 @@ export class Connector implements IConnector {\n     private _redirects = new RedirectManager();\n     /** A collection of requests with their initial data. */\n     private _pendingResponseReceived: Array<Function>;\n+    /** Collection of */\n+    private _finishedRequests: Map<string, { reject: Function; resolve: Function }>;\n     /** List of all the tabs used by the connector. */\n     private _tabs = [];\n     /** Tells if a favicon of a page has been downloaded from a link tag. */\n     private _faviconLoaded: boolean = false;\n     /** The amount of time before an event is going to be timedout. */\n     private _timeout: number;\n     /** Browser PID */\n-    private pid: number;\n+    private _pid: number;\n     private _targetNetworkData: NetworkData;\n     private launcher: ILauncher;","path":"packages/utils-debugging-protocol-common/src/debugging-protocol-connector.ts","position":34,"original_position":34,"commit_id":"e53f6a33d41750a1e0fd5258dcbc1435fbd9175e","original_commit_id":"e53f6a33d41750a1e0fd5258dcbc1435fbd9175e","user":{"login":"molant","id":606594,"node_id":"MDQ6VXNlcjYwNjU5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/606594?v=4","gravatar_id":"","url":"https://api.github.com/users/molant","html_url":"https://github.com/molant","followers_url":"https://api.github.com/users/molant/followers","following_url":"https://api.github.com/users/molant/following{/other_user}","gists_url":"https://api.github.com/users/molant/gists{/gist_id}","starred_url":"https://api.github.com/users/molant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molant/subscriptions","organizations_url":"https://api.github.com/users/molant/orgs","repos_url":"https://api.github.com/users/molant/repos","events_url":"https://api.github.com/users/molant/events{/privacy}","received_events_url":"https://api.github.com/users/molant/received_events","type":"User","site_admin":false},"body":"Probably a leftover from when I was cherry-picking. It should have a `_`","created_at":"2018-09-24T21:41:34Z","updated_at":"2018-09-24T21:41:35Z","html_url":"https://github.com/webhintio/hint/pull/1337#discussion_r219998649","pull_request_url":"https://api.github.com/repos/webhintio/hint/pulls/1337","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/webhintio/hint/pulls/comments/219998649"},"html":{"href":"https://github.com/webhintio/hint/pull/1337#discussion_r219998649"},"pull_request":{"href":"https://api.github.com/repos/webhintio/hint/pulls/1337"}},"in_reply_to_id":219992522},"pull_request":{"url":"https://api.github.com/repos/webhintio/hint/pulls/1337","id":217773857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzczODU3","html_url":"https://github.com/webhintio/hint/pull/1337","diff_url":"https://github.com/webhintio/hint/pull/1337.diff","patch_url":"https://github.com/webhintio/hint/pull/1337.patch","issue_url":"https://api.github.com/repos/webhintio/hint/issues/1337","number":1337,"state":"open","locked":false,"title":"Fix/multiple things","user":{"login":"molant","id":606594,"node_id":"MDQ6VXNlcjYwNjU5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/606594?v=4","gravatar_id":"","url":"https://api.github.com/users/molant","html_url":"https://github.com/molant","followers_url":"https://api.github.com/users/molant/followers","following_url":"https://api.github.com/users/molant/following{/other_user}","gists_url":"https://api.github.com/users/molant/gists{/gist_id}","starred_url":"https://api.github.com/users/molant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molant/subscriptions","organizations_url":"https://api.github.com/users/molant/orgs","repos_url":"https://api.github.com/users/molant/repos","events_url":"https://api.github.com/users/molant/events{/privacy}","received_events_url":"https://api.github.com/users/molant/received_events","type":"User","site_admin":false},"body":"<!--\r\n\r\nRead our pull request guide:\r\nhttps://webhint.io/docs/contributor-guide/getting-started/pull-requests/\r\n\r\nFor the following items put an \"x\" between the square brackets\r\n(i.e. [x]) if you completed the associated item.\r\n\r\n-->\r\n\r\n## Pull request checklist\r\n\r\nMake sure you:\r\n\r\n- [x] Signed the [Contributor License Agreement](https://cla.js.foundation/webhintio/hint)\r\n- [x] Followed the [commit message guidelines](https://webhint.io/docs/contributor-guide/getting-started/pull-requests/#commit-messages)\r\n\r\nFor non-trivial changes, please make sure you also:\r\n\r\n- ~~Added/Updated related documentation.~~\r\n- ~~Added/Updated related tests.~~\r\n\r\n## Short description of the change(s)\r\n\r\n* Convert to text base64 text based responses\r\n* Fix a location issue with `jsdom` depending on the version pulled\r\n* Some coding improvements in `debugging-protocol`: some types, prefix private properties with `_` \r\n* Fix truncated responses in `debugging-protocol`\r\n\r\n<!--\r\n\r\nIf this is a non-trivial change, include information such as what\r\nbenefits this change brings as well as possible drawbacks.\r\n\r\nIf this fixes an existing issue, include the relevant issue number(s).\r\n\r\nThank you for taking the time to open this PR!\r\n\r\n-->\r\n","created_at":"2018-09-24T20:11:58Z","updated_at":"2018-09-24T21:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7be31753aca715718ac75438a2383e852721456","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alrra","id":1223565,"node_id":"MDQ6VXNlcjEyMjM1NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1223565?v=4","gravatar_id":"","url":"https://api.github.com/users/alrra","html_url":"https://github.com/alrra","followers_url":"https://api.github.com/users/alrra/followers","following_url":"https://api.github.com/users/alrra/following{/other_user}","gists_url":"https://api.github.com/users/alrra/gists{/gist_id}","starred_url":"https://api.github.com/users/alrra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrra/subscriptions","organizations_url":"https://api.github.com/users/alrra/orgs","repos_url":"https://api.github.com/users/alrra/repos","events_url":"https://api.github.com/users/alrra/events{/privacy}","received_events_url":"https://api.github.com/users/alrra/received_events","type":"User","site_admin":false},{"login":"sarvaje","id":1581288,"node_id":"MDQ6VXNlcjE1ODEyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1581288?v=4","gravatar_id":"","url":"https://api.github.com/users/sarvaje","html_url":"https://github.com/sarvaje","followers_url":"https://api.github.com/users/sarvaje/followers","following_url":"https://api.github.com/users/sarvaje/following{/other_user}","gists_url":"https://api.github.com/users/sarvaje/gists{/gist_id}","starred_url":"https://api.github.com/users/sarvaje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarvaje/subscriptions","organizations_url":"https://api.github.com/users/sarvaje/orgs","repos_url":"https://api.github.com/users/sarvaje/repos","events_url":"https://api.github.com/users/sarvaje/events{/privacy}","received_events_url":"https://api.github.com/users/sarvaje/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webhintio/hint/pulls/1337/commits","review_comments_url":"https://api.github.com/repos/webhintio/hint/pulls/1337/comments","review_comment_url":"https://api.github.com/repos/webhintio/hint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webhintio/hint/issues/1337/comments","statuses_url":"https://api.github.com/repos/webhintio/hint/statuses/e53f6a33d41750a1e0fd5258dcbc1435fbd9175e","head":{"label":"molant:fix/multiple-things","ref":"fix/multiple-things","sha":"e53f6a33d41750a1e0fd5258dcbc1435fbd9175e","user":{"login":"molant","id":606594,"node_id":"MDQ6VXNlcjYwNjU5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/606594?v=4","gravatar_id":"","url":"https://api.github.com/users/molant","html_url":"https://github.com/molant","followers_url":"https://api.github.com/users/molant/followers","following_url":"https://api.github.com/users/molant/following{/other_user}","gists_url":"https://api.github.com/users/molant/gists{/gist_id}","starred_url":"https://api.github.com/users/molant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molant/subscriptions","organizations_url":"https://api.github.com/users/molant/orgs","repos_url":"https://api.github.com/users/molant/repos","events_url":"https://api.github.com/users/molant/events{/privacy}","received_events_url":"https://api.github.com/users/molant/received_events","type":"User","site_admin":false},"repo":{"id":94958400,"node_id":"MDEwOlJlcG9zaXRvcnk5NDk1ODQwMA==","name":"hint","full_name":"molant/hint","private":false,"owner":{"login":"molant","id":606594,"node_id":"MDQ6VXNlcjYwNjU5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/606594?v=4","gravatar_id":"","url":"https://api.github.com/users/molant","html_url":"https://github.com/molant","followers_url":"https://api.github.com/users/molant/followers","following_url":"https://api.github.com/users/molant/following{/other_user}","gists_url":"https://api.github.com/users/molant/gists{/gist_id}","starred_url":"https://api.github.com/users/molant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molant/subscriptions","organizations_url":"https://api.github.com/users/molant/orgs","repos_url":"https://api.github.com/users/molant/repos","events_url":"https://api.github.com/users/molant/events{/privacy}","received_events_url":"https://api.github.com/users/molant/received_events","type":"User","site_admin":false},"html_url":"https://github.com/molant/hint","description":null,"fork":true,"url":"https://api.github.com/repos/molant/hint","forks_url":"https://api.github.com/repos/molant/hint/forks","keys_url":"https://api.github.com/repos/molant/hint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molant/hint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molant/hint/teams","hooks_url":"https://api.github.com/repos/molant/hint/hooks","issue_events_url":"https://api.github.com/repos/molant/hint/issues/events{/number}","events_url":"https://api.github.com/repos/molant/hint/events","assignees_url":"https://api.github.com/repos/molant/hint/assignees{/user}","branches_url":"https://api.github.com/repos/molant/hint/branches{/branch}","tags_url":"https://api.github.com/repos/molant/hint/tags","blobs_url":"https://api.github.com/repos/molant/hint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molant/hint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molant/hint/git/refs{/sha}","trees_url":"https://api.github.com/repos/molant/hint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molant/hint/statuses/{sha}","languages_url":"https://api.github.com/repos/molant/hint/languages","stargazers_url":"https://api.github.com/repos/molant/hint/stargazers","contributors_url":"https://api.github.com/repos/molant/hint/contributors","subscribers_url":"https://api.github.com/repos/molant/hint/subscribers","subscription_url":"https://api.github.com/repos/molant/hint/subscription","commits_url":"https://api.github.com/repos/molant/hint/commits{/sha}","git_commits_url":"https://api.github.com/repos/molant/hint/git/commits{/sha}","comments_url":"https://api.github.com/repos/molant/hint/comments{/number}","issue_comment_url":"https://api.github.com/repos/molant/hint/issues/comments{/number}","contents_url":"https://api.github.com/repos/molant/hint/contents/{+path}","compare_url":"https://api.github.com/repos/molant/hint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molant/hint/merges","archive_url":"https://api.github.com/repos/molant/hint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molant/hint/downloads","issues_url":"https://api.github.com/repos/molant/hint/issues{/number}","pulls_url":"https://api.github.com/repos/molant/hint/pulls{/number}","milestones_url":"https://api.github.com/repos/molant/hint/milestones{/number}","notifications_url":"https://api.github.com/repos/molant/hint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molant/hint/labels{/name}","releases_url":"https://api.github.com/repos/molant/hint/releases{/id}","deployments_url":"https://api.github.com/repos/molant/hint/deployments","created_at":"2017-06-21T03:20:07Z","updated_at":"2018-09-24T05:43:26Z","pushed_at":"2018-09-24T21:08:19Z","git_url":"git://github.com/molant/hint.git","ssh_url":"git@github.com:molant/hint.git","clone_url":"https://github.com/molant/hint.git","svn_url":"https://github.com/molant/hint","homepage":"https://webhint.io","size":11437,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"webhintio:master","ref":"master","sha":"6dcde52bc2508078f4ae93b181a0da5d02a1be0a","user":{"login":"webhintio","id":25042266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDQyMjY2","avatar_url":"https://avatars0.githubusercontent.com/u/25042266?v=4","gravatar_id":"","url":"https://api.github.com/users/webhintio","html_url":"https://github.com/webhintio","followers_url":"https://api.github.com/users/webhintio/followers","following_url":"https://api.github.com/users/webhintio/following{/other_user}","gists_url":"https://api.github.com/users/webhintio/gists{/gist_id}","starred_url":"https://api.github.com/users/webhintio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webhintio/subscriptions","organizations_url":"https://api.github.com/users/webhintio/orgs","repos_url":"https://api.github.com/users/webhintio/repos","events_url":"https://api.github.com/users/webhintio/events{/privacy}","received_events_url":"https://api.github.com/users/webhintio/received_events","type":"Organization","site_admin":false},"repo":{"id":82211360,"node_id":"MDEwOlJlcG9zaXRvcnk4MjIxMTM2MA==","name":"hint","full_name":"webhintio/hint","private":false,"owner":{"login":"webhintio","id":25042266,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDQyMjY2","avatar_url":"https://avatars0.githubusercontent.com/u/25042266?v=4","gravatar_id":"","url":"https://api.github.com/users/webhintio","html_url":"https://github.com/webhintio","followers_url":"https://api.github.com/users/webhintio/followers","following_url":"https://api.github.com/users/webhintio/following{/other_user}","gists_url":"https://api.github.com/users/webhintio/gists{/gist_id}","starred_url":"https://api.github.com/users/webhintio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webhintio/subscriptions","organizations_url":"https://api.github.com/users/webhintio/orgs","repos_url":"https://api.github.com/users/webhintio/repos","events_url":"https://api.github.com/users/webhintio/events{/privacy}","received_events_url":"https://api.github.com/users/webhintio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webhintio/hint","description":"💡 A hinting engine for the web","fork":false,"url":"https://api.github.com/repos/webhintio/hint","forks_url":"https://api.github.com/repos/webhintio/hint/forks","keys_url":"https://api.github.com/repos/webhintio/hint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webhintio/hint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webhintio/hint/teams","hooks_url":"https://api.github.com/repos/webhintio/hint/hooks","issue_events_url":"https://api.github.com/repos/webhintio/hint/issues/events{/number}","events_url":"https://api.github.com/repos/webhintio/hint/events","assignees_url":"https://api.github.com/repos/webhintio/hint/assignees{/user}","branches_url":"https://api.github.com/repos/webhintio/hint/branches{/branch}","tags_url":"https://api.github.com/repos/webhintio/hint/tags","blobs_url":"https://api.github.com/repos/webhintio/hint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webhintio/hint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webhintio/hint/git/refs{/sha}","trees_url":"https://api.github.com/repos/webhintio/hint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webhintio/hint/statuses/{sha}","languages_url":"https://api.github.com/repos/webhintio/hint/languages","stargazers_url":"https://api.github.com/repos/webhintio/hint/stargazers","contributors_url":"https://api.github.com/repos/webhintio/hint/contributors","subscribers_url":"https://api.github.com/repos/webhintio/hint/subscribers","subscription_url":"https://api.github.com/repos/webhintio/hint/subscription","commits_url":"https://api.github.com/repos/webhintio/hint/commits{/sha}","git_commits_url":"https://api.github.com/repos/webhintio/hint/git/commits{/sha}","comments_url":"https://api.github.com/repos/webhintio/hint/comments{/number}","issue_comment_url":"https://api.github.com/repos/webhintio/hint/issues/comments{/number}","contents_url":"https://api.github.com/repos/webhintio/hint/contents/{+path}","compare_url":"https://api.github.com/repos/webhintio/hint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webhintio/hint/merges","archive_url":"https://api.github.com/repos/webhintio/hint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webhintio/hint/downloads","issues_url":"https://api.github.com/repos/webhintio/hint/issues{/number}","pulls_url":"https://api.github.com/repos/webhintio/hint/pulls{/number}","milestones_url":"https://api.github.com/repos/webhintio/hint/milestones{/number}","notifications_url":"https://api.github.com/repos/webhintio/hint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webhintio/hint/labels{/name}","releases_url":"https://api.github.com/repos/webhintio/hint/releases{/id}","deployments_url":"https://api.github.com/repos/webhintio/hint/deployments","created_at":"2017-02-16T18:15:31Z","updated_at":"2018-09-24T20:38:19Z","pushed_at":"2018-09-24T21:08:20Z","git_url":"git://github.com/webhintio/hint.git","ssh_url":"git@github.com:webhintio/hint.git","clone_url":"https://github.com/webhintio/hint.git","svn_url":"https://github.com/webhintio/hint","homepage":"https://webhint.io/","size":11240,"stargazers_count":1863,"watchers_count":1863,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":115,"open_issues":54,"watchers":1863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webhintio/hint/pulls/1337"},"html":{"href":"https://github.com/webhintio/hint/pull/1337"},"issue":{"href":"https://api.github.com/repos/webhintio/hint/issues/1337"},"comments":{"href":"https://api.github.com/repos/webhintio/hint/issues/1337/comments"},"review_comments":{"href":"https://api.github.com/repos/webhintio/hint/pulls/1337/comments"},"review_comment":{"href":"https://api.github.com/repos/webhintio/hint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webhintio/hint/pulls/1337/commits"},"statuses":{"href":"https://api.github.com/repos/webhintio/hint/statuses/e53f6a33d41750a1e0fd5258dcbc1435fbd9175e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"molant"}}