{"action":"closed","issue":{"url":"https://api.github.com/repos/ocramz/sparse-linear-algebra/issues/42","repository_url":"https://api.github.com/repos/ocramz/sparse-linear-algebra","labels_url":"https://api.github.com/repos/ocramz/sparse-linear-algebra/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/ocramz/sparse-linear-algebra/issues/42/comments","events_url":"https://api.github.com/repos/ocramz/sparse-linear-algebra/issues/42/events","html_url":"https://github.com/ocramz/sparse-linear-algebra/issues/42","id":286112255,"number":42,"title":"Incorrect bounds checking.","user":{"login":"GregorySchwartz","id":2490088,"avatar_url":"https://avatars3.githubusercontent.com/u/2490088?v=4","gravatar_id":"","url":"https://api.github.com/users/GregorySchwartz","html_url":"https://github.com/GregorySchwartz","followers_url":"https://api.github.com/users/GregorySchwartz/followers","following_url":"https://api.github.com/users/GregorySchwartz/following{/other_user}","gists_url":"https://api.github.com/users/GregorySchwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/GregorySchwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregorySchwartz/subscriptions","organizations_url":"https://api.github.com/users/GregorySchwartz/orgs","repos_url":"https://api.github.com/users/GregorySchwartz/repos","events_url":"https://api.github.com/users/GregorySchwartz/events{/privacy}","received_events_url":"https://api.github.com/users/GregorySchwartz/received_events","type":"User","site_admin":false},"labels":[{"id":438091928,"url":"https://api.github.com/repos/ocramz/sparse-linear-algebra/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"ocramz","id":5902760,"avatar_url":"https://avatars1.githubusercontent.com/u/5902760?v=4","gravatar_id":"","url":"https://api.github.com/users/ocramz","html_url":"https://github.com/ocramz","followers_url":"https://api.github.com/users/ocramz/followers","following_url":"https://api.github.com/users/ocramz/following{/other_user}","gists_url":"https://api.github.com/users/ocramz/gists{/gist_id}","starred_url":"https://api.github.com/users/ocramz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocramz/subscriptions","organizations_url":"https://api.github.com/users/ocramz/orgs","repos_url":"https://api.github.com/users/ocramz/repos","events_url":"https://api.github.com/users/ocramz/events{/privacy}","received_events_url":"https://api.github.com/users/ocramz/received_events","type":"User","site_admin":false},"assignees":[{"login":"ocramz","id":5902760,"avatar_url":"https://avatars1.githubusercontent.com/u/5902760?v=4","gravatar_id":"","url":"https://api.github.com/users/ocramz","html_url":"https://github.com/ocramz","followers_url":"https://api.github.com/users/ocramz/followers","following_url":"https://api.github.com/users/ocramz/following{/other_user}","gists_url":"https://api.github.com/users/ocramz/gists{/gist_id}","starred_url":"https://api.github.com/users/ocramz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocramz/subscriptions","organizations_url":"https://api.github.com/users/ocramz/orgs","repos_url":"https://api.github.com/users/ocramz/repos","events_url":"https://api.github.com/users/ocramz/events{/privacy}","received_events_url":"https://api.github.com/users/ocramz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-01-04T21:02:48Z","updated_at":"2018-04-27T09:30:38Z","closed_at":"2018-04-27T09:30:38Z","author_association":"CONTRIBUTOR","body":"```\r\nPrelude Data.Sparse.Common> x = (fromListSV 4 [(2,3)] :: SpVector Double)\r\nPrelude Data.Sparse.Common> y = (fromListSV 4 [(0,3)] :: SpVector Double)\r\nPrelude Data.Sparse.Common> fromRowsL [x, y]\r\n*** Exception: insertRowSM : incompatible dimensions (2,4)\r\nCallStack (from HasCallStack):\r\n  error, called at src/Data/Sparse/Common.hs:79:17 in sparse-linear-algebra-0.2.9.8-GSb8IwES68r5Fh6hC5eCZ9:Data.Sparse.Common\r\n```\r\n\r\nHere, `x` and `y` are rows with the same dimension, so from the name I would think that `fromRowsL [x, y]` would result in a 2x4 matrix. Further evidence:\r\n\r\n```\r\nPrelude Data.Sparse.Common> m\r\nSM ( 2 rows, 4 columns ) , 8 NZ ( density 100.000 % ) [(0,[(0,0.0),(1,0.0),(2,3.0),(3,0.0)]),(1,[(0,3.0),(1,0.0),(2,0.0),(3,0.0)])]\r\nPrelude Data.Sparse.Common> fromRowsL $ toRowsL m\r\n*** Exception: insertRowSM : incompatible dimensions (2,4)\r\nCallStack (from HasCallStack):\r\n  error, called at src/Data/Sparse/Common.hs:79:17 in sparse-linear-algebra-0.2.9.8-GSb8IwES68r5Fh6hC5eCZ9:Data.Sparse.Common\r\n```\r\n\r\n`toColsL` and `fromColsL` both work it seems.\r\n  "}}
{"actor":{"display_login":"ocramz"}}