{"action":"created","issue":{"url":"https://api.github.com/repos/pypa/pip/issues/5819","repository_url":"https://api.github.com/repos/pypa/pip","labels_url":"https://api.github.com/repos/pypa/pip/issues/5819/labels{/name}","comments_url":"https://api.github.com/repos/pypa/pip/issues/5819/comments","events_url":"https://api.github.com/repos/pypa/pip/issues/5819/events","html_url":"https://github.com/pypa/pip/pull/5819","id":364345896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTU1MTA3","number":5819,"title":"HTMLPage cleanup and egg_info_matches fix","user":{"login":"uranusjr","id":605277,"node_id":"MDQ6VXNlcjYwNTI3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/605277?v=4","gravatar_id":"","url":"https://api.github.com/users/uranusjr","html_url":"https://github.com/uranusjr","followers_url":"https://api.github.com/users/uranusjr/followers","following_url":"https://api.github.com/users/uranusjr/following{/other_user}","gists_url":"https://api.github.com/users/uranusjr/gists{/gist_id}","starred_url":"https://api.github.com/users/uranusjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uranusjr/subscriptions","organizations_url":"https://api.github.com/users/uranusjr/orgs","repos_url":"https://api.github.com/users/uranusjr/repos","events_url":"https://api.github.com/users/uranusjr/events{/privacy}","received_events_url":"https://api.github.com/users/uranusjr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-27T07:48:32Z","updated_at":"2018-09-27T16:19:20Z","closed_at":"2018-09-27T14:21:23Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pypa/pip/pulls/5819","html_url":"https://github.com/pypa/pip/pull/5819","diff_url":"https://github.com/pypa/pip/pull/5819.diff","patch_url":"https://github.com/pypa/pip/pull/5819.patch"},"body":"My first baby steps toward #5800.\r\n\r\nIt seems the `skip_archives` argument is never specified from any call sites (only one, actually, in `PackageFinder._get_page()`), so the block is always run. I simply removed the check.\r\n\r\n`egg_info_matches` was discussed in https://github.com/pypa/pip/issues/5800#issuecomment-424774495. This function is used in two places, `PackageFinder._link_package_versions()` and `wheel.WheelBuilder.build()`. The former always passes a real `search_name`, so the branch is only reachable by the latter. `WheelBuilder` does not actually use the return value, however, only checks whether it is None, so the bug does not affect anything in pip currently."},"comment":{"url":"https://api.github.com/repos/pypa/pip/issues/comments/425154681","html_url":"https://github.com/pypa/pip/pull/5819#issuecomment-425154681","issue_url":"https://api.github.com/repos/pypa/pip/issues/5819","id":425154681,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTE1NDY4MQ==","user":{"login":"uranusjr","id":605277,"node_id":"MDQ6VXNlcjYwNTI3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/605277?v=4","gravatar_id":"","url":"https://api.github.com/users/uranusjr","html_url":"https://github.com/uranusjr","followers_url":"https://api.github.com/users/uranusjr/followers","following_url":"https://api.github.com/users/uranusjr/following{/other_user}","gists_url":"https://api.github.com/users/uranusjr/gists{/gist_id}","starred_url":"https://api.github.com/users/uranusjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uranusjr/subscriptions","organizations_url":"https://api.github.com/users/uranusjr/orgs","repos_url":"https://api.github.com/users/uranusjr/repos","events_url":"https://api.github.com/users/uranusjr/events{/privacy}","received_events_url":"https://api.github.com/users/uranusjr/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T16:19:20Z","updated_at":"2018-09-27T16:19:20Z","author_association":"MEMBER","body":"I’ll prepare another PR with a couple of simple unit tests around `egg_info_matches` (currently there is none)."}}
{"actor":{"display_login":"uranusjr"}}