{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/198277557","pull_request_review_id":132180444,"id":198277557,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI3NzU1Nw==","diff_hunk":"@@ -821,14 +829,19 @@ def post(self, request):\n             self.retire_entitlement_support_detail(user)\n \n             # Retire misc. models that may contain PII of this user\n-            SoftwareSecurePhotoVerification.retire_user(user.id)\n             PendingEmailChange.delete_by_user_value(user, field='user')\n             UserOrgTag.delete_by_user_value(user, field='user')\n \n             # Retire any objects linked to the user via their original email\n             CourseEnrollmentAllowed.delete_by_user_value(original_email, field='email')\n             UnregisteredLearnerCohortAssignments.delete_by_user_value(original_email, field='email')\n \n+            # This signal allows code in higher points of LMS to retire the user as necessary\n+            USER_RETIRE_LMS_CRITICAL.send(sender=self.__class__, user=user)\n+\n+            # TODO: Password Reset links - https://openedx.atlassian.net/browse/PLAT-2104\n+            # TODO: Delete OAuth2 records - https://openedx.atlassian.net/browse/EDUCATOR-2703","path":"openedx/core/djangoapps/user_api/accounts/views.py","position":128,"original_position":128,"commit_id":"7ce4fb6972ab98756f944be5f3a5abfe18515778","original_commit_id":"7ce4fb6972ab98756f944be5f3a5abfe18515778","user":{"login":"pwnage101","id":85151,"node_id":"MDQ6VXNlcjg1MTUx","avatar_url":"https://avatars1.githubusercontent.com/u/85151?v=4","gravatar_id":"","url":"https://api.github.com/users/pwnage101","html_url":"https://github.com/pwnage101","followers_url":"https://api.github.com/users/pwnage101/followers","following_url":"https://api.github.com/users/pwnage101/following{/other_user}","gists_url":"https://api.github.com/users/pwnage101/gists{/gist_id}","starred_url":"https://api.github.com/users/pwnage101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwnage101/subscriptions","organizations_url":"https://api.github.com/users/pwnage101/orgs","repos_url":"https://api.github.com/users/pwnage101/repos","events_url":"https://api.github.com/users/pwnage101/events{/privacy}","received_events_url":"https://api.github.com/users/pwnage101/received_events","type":"User","site_admin":false},"body":"What's meant by these TODO comments?  They both link to completed tasks.","created_at":"2018-06-26T19:58:44Z","updated_at":"2018-06-26T19:59:14Z","html_url":"https://github.com/edx/edx-platform/pull/18423#discussion_r198277557","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/18423","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/198277557"},"html":{"href":"https://github.com/edx/edx-platform/pull/18423#discussion_r198277557"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18423"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/18423","id":196253053,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjUzMDUz","html_url":"https://github.com/edx/edx-platform/pull/18423","diff_url":"https://github.com/edx/edx-platform/pull/18423.diff","patch_url":"https://github.com/edx/edx-platform/pull/18423.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/18423","number":18423,"state":"open","locked":false,"title":"Refactor retirement endpoints to isolate Sailthru and respect boundaries","user":{"login":"bmedx","id":24231382,"node_id":"MDQ6VXNlcjI0MjMxMzgy","avatar_url":"https://avatars3.githubusercontent.com/u/24231382?v=4","gravatar_id":"","url":"https://api.github.com/users/bmedx","html_url":"https://github.com/bmedx","followers_url":"https://api.github.com/users/bmedx/followers","following_url":"https://api.github.com/users/bmedx/following{/other_user}","gists_url":"https://api.github.com/users/bmedx/gists{/gist_id}","starred_url":"https://api.github.com/users/bmedx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmedx/subscriptions","organizations_url":"https://api.github.com/users/bmedx/orgs","repos_url":"https://api.github.com/users/bmedx/repos","events_url":"https://api.github.com/users/bmedx/events{/privacy}","received_events_url":"https://api.github.com/users/bmedx/received_events","type":"User","site_admin":false},"body":"- Change retire mailings endpoint to use new USER_RETIRE_THIRD_PARTY_MAILINGS signal, currently only used by Sailthru retirement\r\n- Move USER_RETIRE_MAILINGS signal firing to the LMS misc endpoint\r\n- Remove duplicate clearing of UserOrgTags\r\n- Remove LMS imports in openedx/core and update usage to use new USER_RETIRE_LMS_CRITICAL and USER_RETIRE_LMS_MISC signals\r\n- Add testing for new signal handlers and app registration for the LMS survey app","created_at":"2018-06-20T19:49:20Z","updated_at":"2018-06-26T19:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b55a4767f89d48daddc63994e0ed97e16ac2e4a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"macdiesel","id":67862,"node_id":"MDQ6VXNlcjY3ODYy","avatar_url":"https://avatars3.githubusercontent.com/u/67862?v=4","gravatar_id":"","url":"https://api.github.com/users/macdiesel","html_url":"https://github.com/macdiesel","followers_url":"https://api.github.com/users/macdiesel/followers","following_url":"https://api.github.com/users/macdiesel/following{/other_user}","gists_url":"https://api.github.com/users/macdiesel/gists{/gist_id}","starred_url":"https://api.github.com/users/macdiesel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macdiesel/subscriptions","organizations_url":"https://api.github.com/users/macdiesel/orgs","repos_url":"https://api.github.com/users/macdiesel/repos","events_url":"https://api.github.com/users/macdiesel/events{/privacy}","received_events_url":"https://api.github.com/users/macdiesel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/18423/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/18423/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/18423/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/7ce4fb6972ab98756f944be5f3a5abfe18515778","head":{"label":"edx:bmedx/retirement_endpoint_refactor","ref":"bmedx/retirement_endpoint_refactor","sha":"7ce4fb6972ab98756f944be5f3a5abfe18515778","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2018-06-26T17:18:11Z","pushed_at":"2018-06-26T19:53:57Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":941251,"stargazers_count":3737,"watchers_count":3737,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2100,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2100,"open_issues":217,"watchers":3737,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"646c297dc16ef2de9fe0df3a6882ae67dea54d7c","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2018-06-26T17:18:11Z","pushed_at":"2018-06-26T19:53:57Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":941251,"stargazers_count":3737,"watchers_count":3737,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2100,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2100,"open_issues":217,"watchers":3737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18423"},"html":{"href":"https://github.com/edx/edx-platform/pull/18423"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/18423"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/18423/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18423/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18423/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/7ce4fb6972ab98756f944be5f3a5abfe18515778"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pwnage101"}}