{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/sitl_gazebo/issues/243","repository_url":"https://api.github.com/repos/PX4/sitl_gazebo","labels_url":"https://api.github.com/repos/PX4/sitl_gazebo/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/PX4/sitl_gazebo/issues/243/comments","events_url":"https://api.github.com/repos/PX4/sitl_gazebo/issues/243/events","html_url":"https://github.com/PX4/sitl_gazebo/pull/243","id":378517843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MjA1OTA3","number":243,"title":"Set CMAKE_CXX_STANDARD so cmake does not duplicate std setting","user":{"login":"jacobschloss","id":2883354,"node_id":"MDQ6VXNlcjI4ODMzNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2883354?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobschloss","html_url":"https://github.com/jacobschloss","followers_url":"https://api.github.com/users/jacobschloss/followers","following_url":"https://api.github.com/users/jacobschloss/following{/other_user}","gists_url":"https://api.github.com/users/jacobschloss/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobschloss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobschloss/subscriptions","organizations_url":"https://api.github.com/users/jacobschloss/orgs","repos_url":"https://api.github.com/users/jacobschloss/repos","events_url":"https://api.github.com/users/jacobschloss/events{/privacy}","received_events_url":"https://api.github.com/users/jacobschloss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T23:45:12Z","updated_at":"2018-11-08T00:01:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/PX4/sitl_gazebo/pulls/243","html_url":"https://github.com/PX4/sitl_gazebo/pull/243","diff_url":"https://github.com/PX4/sitl_gazebo/pull/243.diff","patch_url":"https://github.com/PX4/sitl_gazebo/pull/243.patch"},"body":"The current CMake scripts cause 3 different language standards to be set when building. One by cmake/EnableC++XX.cmake, one by gazebo, and a default one that CMake will append.\r\n\r\nNeither the language standards that EnableC++XX.cmake set nor that were in GAZEBO_CXX_FLAGS were actually being used, since cmake's was last on the arguments.\r\n\r\nBefore this patch c++17, c++11, and gnu++14 is set at the same time.\r\n\r\n> /usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -Dmav_msgs_EXPORTS -isystem /usr/include/gazebo-9 -isystem /usr/include/bullet -isystem /usr/include/simbody -isystem /usr/include/sdformat-6.0 -isystem /usr/include/ignition/math4 -isystem /usr/include/OGRE -isystem /usr/include/OGRE/Terrain -isystem /usr/include/OGRE/Paging -isystem /usr/include/ignition/transport4 -isystem /usr/include/ignition/msgs1 -isystem /usr/include/ignition/common1 -isystem /usr/include/ignition/fuel_tools1 -I/home/jschloss/firmware/Tools/sitl_gazebo/include -I/home/jschloss/firmware/build/posix_sitl_default/build_gazebo -I/usr/include/eigen3 -I/usr/include/eigen3/eigen3 -I/usr/include/gazebo-9/gazebo/msgs -I/home/jschloss/firmware/mavlink/include -I/usr/include/Paging -isystem /usr/include/opencv -I/home/jschloss/firmware/Tools/sitl_gazebo/external/OpticalFlow/include -isystem /usr/include/uuid -isystem /usr/include/x86_64-linux-gnu  **-std=c++17 -std=c++11** -Wno-deprecated-declarations -fPIC   -I/usr/include/uuid -I/usr/include/x86_64-linux-gnu **-std=gnu++14** -o CMakeFiles/mav_msgs.dir/CommandMotorSpeed.pb.cc.o -c /home/jschloss/firmware/build/posix_sitl_default/build_gazebo/CommandMotorSpeed.pb.cc\r\n\r\n\r\nAfter this patch, only gnu++1z is set.\r\n\r\n> /usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -Dmav_msgs_EXPORTS -isystem /usr/include/gazebo-9 -isystem /usr/include/bullet -isystem /usr/include/simbody -isystem /usr/include/sdformat-6.0 -isystem /usr/include/ignition/math4 -isystem /usr/include/OGRE -isystem /usr/include/OGRE/Terrain -isystem /usr/include/OGRE/Paging -isystem /usr/include/ignition/transport4 -isystem /usr/include/ignition/msgs1 -isystem /usr/include/ignition/common1 -isystem /usr/include/ignition/fuel_tools1 -I/home/jschloss/firmware/Tools/sitl_gazebo/include -I/home/jschloss/firmware/build/posix_sitl_default/build_gazebo -I/usr/include/eigen3 -I/usr/include/eigen3/eigen3 -I/usr/include/gazebo-9/gazebo/msgs -I/home/jschloss/firmware/mavlink/include -I/usr/include/Paging -isystem /usr/include/opencv -I/home/jschloss/firmware/Tools/sitl_gazebo/external/OpticalFlow/include -isystem /usr/include/uuid -isystem /usr/include/x86_64-linux-gnu  -Wno-deprecated-declarations -fPIC   -I/usr/include/uuid -I/usr/include/x86_64-linux-gnu **-std=gnu++1z** -o CMakeFiles/mav_msgs.dir/CommandMotorSpeed.pb.cc.o -c /home/jschloss/firmware/build/posix_sitl_default/build_gazebo/CommandMotorSpeed.pb.cc\r\n"},"comment":{"url":"https://api.github.com/repos/PX4/sitl_gazebo/issues/comments/436823154","html_url":"https://github.com/PX4/sitl_gazebo/pull/243#issuecomment-436823154","issue_url":"https://api.github.com/repos/PX4/sitl_gazebo/issues/243","id":436823154,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjgyMzE1NA==","user":{"login":"TSC21","id":5048656,"node_id":"MDQ6VXNlcjUwNDg2NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5048656?v=4","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T00:01:54Z","updated_at":"2018-11-08T00:01:54Z","author_association":"MEMBER","body":"@jacobschloss this fails for Gazebo7 (Ubuntu 16.04) - https://travis-ci.org/PX4/sitl_gazebo/jobs/452151932"}}
{"actor":{"display_login":"TSC21"}}