{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/205221676","pull_request_review_id":140449535,"id":205221676,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTIyMTY3Ng==","diff_hunk":"@@ -59,6 +60,11 @@ oppia.directive('stateContentEditor', [\n \n           var saveContent = function() {\n             stateContentService.saveDisplayedValue();\n+            if (!$scope.isQuestion()) {","path":"core/templates/dev/head/pages/exploration_editor/editor_tab/StateContentEditorDirective.js","position":34,"original_position":34,"commit_id":"645a17473dc3c0f8578fac47aef1c73189241150","original_commit_id":"645a17473dc3c0f8578fac47aef1c73189241150","user":{"login":"aks681","id":22347970,"node_id":"MDQ6VXNlcjIyMzQ3OTcw","avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"body":"Ok, yeah, that sounds good. Will do that. In that case, the passing of ExplorationStatesService to the directive would also be not needed. ","created_at":"2018-07-25T18:44:21Z","updated_at":"2018-07-25T18:44:21Z","html_url":"https://github.com/oppia/oppia/pull/5367#discussion_r205221676","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/5367","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/205221676"},"html":{"href":"https://github.com/oppia/oppia/pull/5367#discussion_r205221676"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5367"}},"in_reply_to_id":205203183},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/5367","id":203821770,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODIxNzcw","html_url":"https://github.com/oppia/oppia/pull/5367","diff_url":"https://github.com/oppia/oppia/pull/5367.diff","patch_url":"https://github.com/oppia/oppia/pull/5367.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/5367","number":5367,"state":"open","locked":false,"title":"[WIP] Create reusable question editor directive","user":{"login":"aks681","id":22347970,"node_id":"MDQ6VXNlcjIyMzQ3OTcw","avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"body":"This is still in progress. Just wanted to know if I am proceeding in the right direction.\r\n\r\nCurrently:\r\n- A createDefaultQuestionStateData() function is added to QuestionObjectFactory (removed the NEW_STATE_TEMPLATE passed in from backend and made it a constant in constants.js).\r\n\r\n- As far as refactoring the state editor, removed dependence on exploration exclusive services for state content editor, and I can confirm it works with no console errors for question editor currently, when lines related to ExplorationStatesService in EditorServices are removed. They are kept  currently since other state editor directives still use it and hence ExplorationStatesService can be completely removed from EditorServices only after this PR is completed.","created_at":"2018-07-25T12:32:53Z","updated_at":"2018-07-25T18:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb44ce5cfaab376718e35971e7a8ffaa721bd64b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/5367/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/5367/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/5367/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/645a17473dc3c0f8578fac47aef1c73189241150","head":{"label":"aks681:question-editor-directive","ref":"question-editor-directive","sha":"645a17473dc3c0f8578fac47aef1c73189241150","user":{"login":"aks681","id":22347970,"node_id":"MDQ6VXNlcjIyMzQ3OTcw","avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"repo":{"id":112202645,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyMDI2NDU=","name":"oppia","full_name":"aks681/oppia","owner":{"login":"aks681","id":22347970,"node_id":"MDQ6VXNlcjIyMzQ3OTcw","avatar_url":"https://avatars3.githubusercontent.com/u/22347970?v=4","gravatar_id":"","url":"https://api.github.com/users/aks681","html_url":"https://github.com/aks681","followers_url":"https://api.github.com/users/aks681/followers","following_url":"https://api.github.com/users/aks681/following{/other_user}","gists_url":"https://api.github.com/users/aks681/gists{/gist_id}","starred_url":"https://api.github.com/users/aks681/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aks681/subscriptions","organizations_url":"https://api.github.com/users/aks681/orgs","repos_url":"https://api.github.com/users/aks681/repos","events_url":"https://api.github.com/users/aks681/events{/privacy}","received_events_url":"https://api.github.com/users/aks681/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aks681/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/aks681/oppia","forks_url":"https://api.github.com/repos/aks681/oppia/forks","keys_url":"https://api.github.com/repos/aks681/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aks681/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aks681/oppia/teams","hooks_url":"https://api.github.com/repos/aks681/oppia/hooks","issue_events_url":"https://api.github.com/repos/aks681/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/aks681/oppia/events","assignees_url":"https://api.github.com/repos/aks681/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/aks681/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/aks681/oppia/tags","blobs_url":"https://api.github.com/repos/aks681/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aks681/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aks681/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/aks681/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aks681/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/aks681/oppia/languages","stargazers_url":"https://api.github.com/repos/aks681/oppia/stargazers","contributors_url":"https://api.github.com/repos/aks681/oppia/contributors","subscribers_url":"https://api.github.com/repos/aks681/oppia/subscribers","subscription_url":"https://api.github.com/repos/aks681/oppia/subscription","commits_url":"https://api.github.com/repos/aks681/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/aks681/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/aks681/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/aks681/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/aks681/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/aks681/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aks681/oppia/merges","archive_url":"https://api.github.com/repos/aks681/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aks681/oppia/downloads","issues_url":"https://api.github.com/repos/aks681/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/aks681/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/aks681/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/aks681/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aks681/oppia/labels{/name}","releases_url":"https://api.github.com/repos/aks681/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/aks681/oppia/deployments","created_at":"2017-11-27T13:56:34Z","updated_at":"2018-07-24T18:23:42Z","pushed_at":"2018-07-25T12:44:03Z","git_url":"git://github.com/aks681/oppia.git","ssh_url":"git@github.com:aks681/oppia.git","clone_url":"https://github.com/aks681/oppia.git","svn_url":"https://github.com/aks681/oppia","homepage":"https://www.oppia.org","size":105447,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"df912ebf9b5ab4531d14c23fec9103eb0494283c","user":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"node_id":"MDEwOlJlcG9zaXRvcnk0MDY4NzU2Mw==","name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjIwMjMw","avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2018-07-25T17:51:49Z","pushed_at":"2018-07-25T17:51:14Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":105797,"stargazers_count":701,"watchers_count":701,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":658,"mirror_url":null,"archived":false,"open_issues_count":337,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":658,"open_issues":337,"watchers":701,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5367"},"html":{"href":"https://github.com/oppia/oppia/pull/5367"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/5367"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/5367/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5367/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/5367/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/645a17473dc3c0f8578fac47aef1c73189241150"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aks681"}}