{"action":"created","issue":{"url":"https://api.github.com/repos/nrwl/nx/issues/752","repository_url":"https://api.github.com/repos/nrwl/nx","labels_url":"https://api.github.com/repos/nrwl/nx/issues/752/labels{/name}","comments_url":"https://api.github.com/repos/nrwl/nx/issues/752/comments","events_url":"https://api.github.com/repos/nrwl/nx/issues/752/events","html_url":"https://github.com/nrwl/nx/issues/752","id":356976994,"node_id":"MDU6SXNzdWUzNTY5NzY5OTQ=","number":752,"title":"question: jest and jasmine","user":{"login":"skydever","id":15961578,"node_id":"MDQ6VXNlcjE1OTYxNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/15961578?v=4","gravatar_id":"","url":"https://api.github.com/users/skydever","html_url":"https://github.com/skydever","followers_url":"https://api.github.com/users/skydever/followers","following_url":"https://api.github.com/users/skydever/following{/other_user}","gists_url":"https://api.github.com/users/skydever/gists{/gist_id}","starred_url":"https://api.github.com/users/skydever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skydever/subscriptions","organizations_url":"https://api.github.com/users/skydever/orgs","repos_url":"https://api.github.com/users/skydever/repos","events_url":"https://api.github.com/users/skydever/events{/privacy}","received_events_url":"https://api.github.com/users/skydever/received_events","type":"User","site_admin":false},"labels":[{"id":666969772,"node_id":"MDU6TGFiZWw2NjY5Njk3NzI=","url":"https://api.github.com/repos/nrwl/nx/labels/type:%20question","name":"type: question","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-04T21:08:27Z","updated_at":"2018-09-11T14:49:57Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I am new to jest and I use a custom jest integration for my tests at the moment, but will switch to the new nrwl jest integration in the next few days. 👍 for that! \r\n\r\nMy tests are compatible with jest, but I am wondering what would happen if I use jasmine specific code - as far as I understood the situation mostly all jasmine code is compatible with jest (you could use [jest-codemods](https://github.com/skovhus/jest-codemods)), but sooner or later you could end up in a situation where you use jasmine-only code.\r\n\r\nRemoving jasmine in general is not an option because the e2e tests are still using jasmine, when I got that right. Removing [karma-jasmine](https://www.npmjs.com/package/karma-jasmine) and [karma-jasmine-html-reporter](https://www.npmjs.com/package/karma-jasmine-html-reporter) should be possible? Are the non-e2e tests still using jasmine typings (ts setup that the ide is using), and unit tests are using jest typings? Any opinion on that topic would be very useful to me."},"comment":{"url":"https://api.github.com/repos/nrwl/nx/issues/comments/420301565","html_url":"https://github.com/nrwl/nx/issues/752#issuecomment-420301565","issue_url":"https://api.github.com/repos/nrwl/nx/issues/752","id":420301565,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDMwMTU2NQ==","user":{"login":"FrozenPandaz","id":8104246,"node_id":"MDQ6VXNlcjgxMDQyNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/8104246?v=4","gravatar_id":"","url":"https://api.github.com/users/FrozenPandaz","html_url":"https://github.com/FrozenPandaz","followers_url":"https://api.github.com/users/FrozenPandaz/followers","following_url":"https://api.github.com/users/FrozenPandaz/following{/other_user}","gists_url":"https://api.github.com/users/FrozenPandaz/gists{/gist_id}","starred_url":"https://api.github.com/users/FrozenPandaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrozenPandaz/subscriptions","organizations_url":"https://api.github.com/users/FrozenPandaz/orgs","repos_url":"https://api.github.com/users/FrozenPandaz/repos","events_url":"https://api.github.com/users/FrozenPandaz/events{/privacy}","received_events_url":"https://api.github.com/users/FrozenPandaz/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T14:49:57Z","updated_at":"2018-09-11T14:49:57Z","author_association":"CONTRIBUTOR","body":"The `e2e` tests are still using `jasmine` typings so keep those. `karma` related dependencies should be safe to remove _if_ you are using `jest` throughout your whole workspace. For now, we will keep these dependencies as part of the generated workspace so users can use both karma or slowly migrate their code to use jest.\r\n\r\nkarma dependencies:\r\n* karma\r\n* karma-chrome-launcher\r\n* karma-coverage-istanbul-reporter\r\n* karma-jasmine karma-jasmine-html-reporter\r\n\r\nRemove with yarn:\r\n```\r\nyarn remove karma karma-chrome-launcher karma-coverage-istanbul-reporter karma-jasmine karma-jasmine-html-reporter\r\n```"}}
{"actor":{"display_login":"FrozenPandaz"}}