{"action":"created","issue":{"url":"https://api.github.com/repos/khanlou/Promise/issues/32","repository_url":"https://api.github.com/repos/khanlou/Promise","labels_url":"https://api.github.com/repos/khanlou/Promise/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/khanlou/Promise/issues/32/comments","events_url":"https://api.github.com/repos/khanlou/Promise/issues/32/events","html_url":"https://github.com/khanlou/Promise/issues/32","id":296789813,"number":32,"title":"error: invalid target name at 'PromiseTests'; name of non-test targets cannot end in 'Tests'","user":{"login":"isaac-weisberg","id":36449887,"avatar_url":"https://avatars0.githubusercontent.com/u/36449887?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac-weisberg","html_url":"https://github.com/isaac-weisberg","followers_url":"https://api.github.com/users/isaac-weisberg/followers","following_url":"https://api.github.com/users/isaac-weisberg/following{/other_user}","gists_url":"https://api.github.com/users/isaac-weisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac-weisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac-weisberg/subscriptions","organizations_url":"https://api.github.com/users/isaac-weisberg/orgs","repos_url":"https://api.github.com/users/isaac-weisberg/repos","events_url":"https://api.github.com/users/isaac-weisberg/events{/privacy}","received_events_url":"https://api.github.com/users/isaac-weisberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-13T15:59:46Z","updated_at":"2018-02-15T12:05:49Z","closed_at":null,"author_association":"NONE","body":"## Expected Behavior\r\n\r\n1. Clone khanlou/Promise\r\n2. Build khanlou/Promise\r\n3. Build library\r\n4. Link library against khanlou/Promise\r\n\r\n## Current Behavior\r\n\r\n```\r\n$ swift build\r\nUpdating https://github.com/khanlou/Promise.git\r\nCloning https://github.com/khanlou/Promise.git\r\nResolving https://github.com/khanlou/Promise.git at 2.0.1\r\nerror: invalid target name at 'PromiseTests'; name of non-test targets cannot end in 'Tests'\r\n```\r\n\r\n## Steps to Reproduce\r\n0. mkdir new_project && cd new_project\r\n1. swift package init --type library && swift build && swift test\r\n2. in Package.swift add [ .package(url: \"https://github.com/khanlou/Promise.git\", from: \"2.0.1\"), ] without sq. brackets to the array of dependencies declared as \" dependencies: [ ...... ] \"\r\n3. swift build\r\n\r\n## Context (Environment)\r\nswift-4.0.3-RELEASE-ubuntu16.10\r\nLubuntu 16.10 AMD64\r\n\r\n## Detailed Description\r\nThe issue makes impossible to build with and link against this library while maintaining project using Swift Package Manager. Was not tested on macOS."},"comment":{"url":"https://api.github.com/repos/khanlou/Promise/issues/comments/365907958","html_url":"https://github.com/khanlou/Promise/issues/32#issuecomment-365907958","issue_url":"https://api.github.com/repos/khanlou/Promise/issues/32","id":365907958,"user":{"login":"isaac-weisberg","id":36449887,"avatar_url":"https://avatars0.githubusercontent.com/u/36449887?v=4","gravatar_id":"","url":"https://api.github.com/users/isaac-weisberg","html_url":"https://github.com/isaac-weisberg","followers_url":"https://api.github.com/users/isaac-weisberg/followers","following_url":"https://api.github.com/users/isaac-weisberg/following{/other_user}","gists_url":"https://api.github.com/users/isaac-weisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/isaac-weisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaac-weisberg/subscriptions","organizations_url":"https://api.github.com/users/isaac-weisberg/orgs","repos_url":"https://api.github.com/users/isaac-weisberg/repos","events_url":"https://api.github.com/users/isaac-weisberg/events{/privacy}","received_events_url":"https://api.github.com/users/isaac-weisberg/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T12:05:49Z","updated_at":"2018-02-15T12:05:49Z","author_association":"NONE","body":"Although no one asked, I should also note that in \"Steps to Reproduce\" section I do add the **package dependency**, but I do not bother to add a **target dependency**, which seals module invisible, impossible to import, not found. Thus, in a case where the dependency is compile-able on Linux, the result of \"Steps to Reproduce\" would still not work."}}
{"actor":{"display_login":"isaac-weisberg"}}