{"action":"created","comment":{"url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/comments/165483377","pull_request_review_id":93430723,"id":165483377,"diff_hunk":"@@ -8,11 +9,6 @@ class Shards::NewPage < MainLayout\n   end\n \n   private def render(f : ShardForm)","path":"src/pages/shards/new_page.cr","position":9,"original_position":9,"commit_id":"b76b11f0bc3aa9b244311b01286eb25e7c9366c5","original_commit_id":"b76b11f0bc3aa9b244311b01286eb25e7c9366c5","user":{"login":"jdbann","id":1191840,"avatar_url":"https://avatars1.githubusercontent.com/u/1191840?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbann","html_url":"https://github.com/jdbann","followers_url":"https://api.github.com/users/jdbann/followers","following_url":"https://api.github.com/users/jdbann/following{/other_user}","gists_url":"https://api.github.com/users/jdbann/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbann/subscriptions","organizations_url":"https://api.github.com/users/jdbann/orgs","repos_url":"https://api.github.com/users/jdbann/repos","events_url":"https://api.github.com/users/jdbann/events{/privacy}","received_events_url":"https://api.github.com/users/jdbann/received_events","type":"User","site_admin":false},"body":"What do you think about extracting this whole private method to `Shards::ShardCreationForm`? I went with this typed render method because the form object's name is generally going to be the class already so it'll read nicely.","created_at":"2018-02-01T20:50:13Z","updated_at":"2018-02-01T20:58:18Z","html_url":"https://github.com/jdbann/crystal-toolbox/pull/21#discussion_r165483377","pull_request_url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/comments/165483377"},"html":{"href":"https://github.com/jdbann/crystal-toolbox/pull/21#discussion_r165483377"},"pull_request":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21","id":166408482,"html_url":"https://github.com/jdbann/crystal-toolbox/pull/21","diff_url":"https://github.com/jdbann/crystal-toolbox/pull/21.diff","patch_url":"https://github.com/jdbann/crystal-toolbox/pull/21.patch","issue_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/21","number":21,"state":"open","locked":false,"title":"Add category model and seeds","user":{"login":"edwardloveall","id":49549,"avatar_url":"https://avatars1.githubusercontent.com/u/49549?v=4","gravatar_id":"","url":"https://api.github.com/users/edwardloveall","html_url":"https://github.com/edwardloveall","followers_url":"https://api.github.com/users/edwardloveall/followers","following_url":"https://api.github.com/users/edwardloveall/following{/other_user}","gists_url":"https://api.github.com/users/edwardloveall/gists{/gist_id}","starred_url":"https://api.github.com/users/edwardloveall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwardloveall/subscriptions","organizations_url":"https://api.github.com/users/edwardloveall/orgs","repos_url":"https://api.github.com/users/edwardloveall/repos","events_url":"https://api.github.com/users/edwardloveall/events{/privacy}","received_events_url":"https://api.github.com/users/edwardloveall/received_events","type":"User","site_admin":false},"body":"A Category simply has a title. I chose \"title\" instead of \"name\" because the difference between the two can be very ambiguous. I tend to reserve \"name\" for if the thing I'm representing has a personality. Think Person, User, Pet, AutonomousCompanion. Everything else should have a title. The exception is if there's some preexisting model you need to adhere to that uses name.\r\n\r\nFor the actual seed categories, I made some modifications from the Awesome Crystal list. I didn't want categories that were not comparable. For example, you're probably not comparing third party APIs against each other as how popular the Github shard is has no effect on the Amazon S3 shard.\r\n\r\nFinally, each category must have a unique name, enforced by a uniqueness validation in the Category form.\r\n\r\nFixes #4","created_at":"2018-01-31T23:50:26Z","updated_at":"2018-02-01T20:58:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d65fe3549eed57f75afc0d6ba8f7cd7c058185e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21/commits","review_comments_url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21/comments","review_comment_url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/21/comments","statuses_url":"https://api.github.com/repos/jdbann/crystal-toolbox/statuses/b76b11f0bc3aa9b244311b01286eb25e7c9366c5","head":{"label":"jdbann:el-category-model","ref":"el-category-model","sha":"b76b11f0bc3aa9b244311b01286eb25e7c9366c5","user":{"login":"jdbann","id":1191840,"avatar_url":"https://avatars1.githubusercontent.com/u/1191840?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbann","html_url":"https://github.com/jdbann","followers_url":"https://api.github.com/users/jdbann/followers","following_url":"https://api.github.com/users/jdbann/following{/other_user}","gists_url":"https://api.github.com/users/jdbann/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbann/subscriptions","organizations_url":"https://api.github.com/users/jdbann/orgs","repos_url":"https://api.github.com/users/jdbann/repos","events_url":"https://api.github.com/users/jdbann/events{/privacy}","received_events_url":"https://api.github.com/users/jdbann/received_events","type":"User","site_admin":false},"repo":{"id":118163815,"name":"crystal-toolbox","full_name":"jdbann/crystal-toolbox","owner":{"login":"jdbann","id":1191840,"avatar_url":"https://avatars1.githubusercontent.com/u/1191840?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbann","html_url":"https://github.com/jdbann","followers_url":"https://api.github.com/users/jdbann/followers","following_url":"https://api.github.com/users/jdbann/following{/other_user}","gists_url":"https://api.github.com/users/jdbann/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbann/subscriptions","organizations_url":"https://api.github.com/users/jdbann/orgs","repos_url":"https://api.github.com/users/jdbann/repos","events_url":"https://api.github.com/users/jdbann/events{/privacy}","received_events_url":"https://api.github.com/users/jdbann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdbann/crystal-toolbox","description":null,"fork":false,"url":"https://api.github.com/repos/jdbann/crystal-toolbox","forks_url":"https://api.github.com/repos/jdbann/crystal-toolbox/forks","keys_url":"https://api.github.com/repos/jdbann/crystal-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbann/crystal-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbann/crystal-toolbox/teams","hooks_url":"https://api.github.com/repos/jdbann/crystal-toolbox/hooks","issue_events_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/jdbann/crystal-toolbox/events","assignees_url":"https://api.github.com/repos/jdbann/crystal-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/jdbann/crystal-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/jdbann/crystal-toolbox/tags","blobs_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbann/crystal-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbann/crystal-toolbox/languages","stargazers_url":"https://api.github.com/repos/jdbann/crystal-toolbox/stargazers","contributors_url":"https://api.github.com/repos/jdbann/crystal-toolbox/contributors","subscribers_url":"https://api.github.com/repos/jdbann/crystal-toolbox/subscribers","subscription_url":"https://api.github.com/repos/jdbann/crystal-toolbox/subscription","commits_url":"https://api.github.com/repos/jdbann/crystal-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbann/crystal-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdbann/crystal-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/jdbann/crystal-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbann/crystal-toolbox/merges","archive_url":"https://api.github.com/repos/jdbann/crystal-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbann/crystal-toolbox/downloads","issues_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbann/crystal-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbann/crystal-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbann/crystal-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/jdbann/crystal-toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/jdbann/crystal-toolbox/deployments","created_at":"2018-01-19T18:40:05Z","updated_at":"2018-01-24T20:43:20Z","pushed_at":"2018-02-01T19:16:25Z","git_url":"git://github.com/jdbann/crystal-toolbox.git","ssh_url":"git@github.com:jdbann/crystal-toolbox.git","clone_url":"https://github.com/jdbann/crystal-toolbox.git","svn_url":"https://github.com/jdbann/crystal-toolbox","homepage":null,"size":106,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"base":{"label":"jdbann:master","ref":"master","sha":"56f2b796258bee99bc79ea9a8238d73d62d387de","user":{"login":"jdbann","id":1191840,"avatar_url":"https://avatars1.githubusercontent.com/u/1191840?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbann","html_url":"https://github.com/jdbann","followers_url":"https://api.github.com/users/jdbann/followers","following_url":"https://api.github.com/users/jdbann/following{/other_user}","gists_url":"https://api.github.com/users/jdbann/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbann/subscriptions","organizations_url":"https://api.github.com/users/jdbann/orgs","repos_url":"https://api.github.com/users/jdbann/repos","events_url":"https://api.github.com/users/jdbann/events{/privacy}","received_events_url":"https://api.github.com/users/jdbann/received_events","type":"User","site_admin":false},"repo":{"id":118163815,"name":"crystal-toolbox","full_name":"jdbann/crystal-toolbox","owner":{"login":"jdbann","id":1191840,"avatar_url":"https://avatars1.githubusercontent.com/u/1191840?v=4","gravatar_id":"","url":"https://api.github.com/users/jdbann","html_url":"https://github.com/jdbann","followers_url":"https://api.github.com/users/jdbann/followers","following_url":"https://api.github.com/users/jdbann/following{/other_user}","gists_url":"https://api.github.com/users/jdbann/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbann/subscriptions","organizations_url":"https://api.github.com/users/jdbann/orgs","repos_url":"https://api.github.com/users/jdbann/repos","events_url":"https://api.github.com/users/jdbann/events{/privacy}","received_events_url":"https://api.github.com/users/jdbann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdbann/crystal-toolbox","description":null,"fork":false,"url":"https://api.github.com/repos/jdbann/crystal-toolbox","forks_url":"https://api.github.com/repos/jdbann/crystal-toolbox/forks","keys_url":"https://api.github.com/repos/jdbann/crystal-toolbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbann/crystal-toolbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbann/crystal-toolbox/teams","hooks_url":"https://api.github.com/repos/jdbann/crystal-toolbox/hooks","issue_events_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/events{/number}","events_url":"https://api.github.com/repos/jdbann/crystal-toolbox/events","assignees_url":"https://api.github.com/repos/jdbann/crystal-toolbox/assignees{/user}","branches_url":"https://api.github.com/repos/jdbann/crystal-toolbox/branches{/branch}","tags_url":"https://api.github.com/repos/jdbann/crystal-toolbox/tags","blobs_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbann/crystal-toolbox/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbann/crystal-toolbox/languages","stargazers_url":"https://api.github.com/repos/jdbann/crystal-toolbox/stargazers","contributors_url":"https://api.github.com/repos/jdbann/crystal-toolbox/contributors","subscribers_url":"https://api.github.com/repos/jdbann/crystal-toolbox/subscribers","subscription_url":"https://api.github.com/repos/jdbann/crystal-toolbox/subscription","commits_url":"https://api.github.com/repos/jdbann/crystal-toolbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbann/crystal-toolbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbann/crystal-toolbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdbann/crystal-toolbox/contents/{+path}","compare_url":"https://api.github.com/repos/jdbann/crystal-toolbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbann/crystal-toolbox/merges","archive_url":"https://api.github.com/repos/jdbann/crystal-toolbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbann/crystal-toolbox/downloads","issues_url":"https://api.github.com/repos/jdbann/crystal-toolbox/issues{/number}","pulls_url":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbann/crystal-toolbox/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbann/crystal-toolbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbann/crystal-toolbox/labels{/name}","releases_url":"https://api.github.com/repos/jdbann/crystal-toolbox/releases{/id}","deployments_url":"https://api.github.com/repos/jdbann/crystal-toolbox/deployments","created_at":"2018-01-19T18:40:05Z","updated_at":"2018-01-24T20:43:20Z","pushed_at":"2018-02-01T19:16:25Z","git_url":"git://github.com/jdbann/crystal-toolbox.git","ssh_url":"git@github.com:jdbann/crystal-toolbox.git","clone_url":"https://github.com/jdbann/crystal-toolbox.git","svn_url":"https://github.com/jdbann/crystal-toolbox","homepage":null,"size":106,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21"},"html":{"href":"https://github.com/jdbann/crystal-toolbox/pull/21"},"issue":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/21"},"comments":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/jdbann/crystal-toolbox/statuses/b76b11f0bc3aa9b244311b01286eb25e7c9366c5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jdbann"}}