{"action":"created","comment":{"url":"https://api.github.com/repos/raccoongang/askup/pulls/comments/203446418","pull_request_review_id":138337335,"id":203446418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQ0NjQxOA==","diff_hunk":"@@ -1583,21 +1575,15 @@ class TestSubscriptionsMailing(TestCase):\n \n     fixtures = ['groups', 'mockup_data']\n \n-    def setUp(self):\n-        \"\"\"\n-        Set up the test conditions.\n-        \"\"\"\n-        settings.DEBUG = False\n-\n     @client_user('student01', 'student01')\n     @patch('askup.utils.general.do_send_subscriptions_to_recipients')\n     def test_subscriptions_sending_no_actual_subscriptions(self, mock_do_send_subscriptions_to_recipients):\n         \"\"\"\n         Test subscriptions sending.\n         \"\"\"\n-        send_subscription_emails()\n         mock_do_send_subscriptions_to_recipients.return_value = None\n         mock_do_send_subscriptions_to_recipients.assert_not_called()","path":"askup/tests/test_functional/test_general.py","position":74,"original_position":47,"commit_id":"64de440fc1ccc303734fef8d3f36b59686e0409a","original_commit_id":"d5ca412e8f268d9ff710fbdfd68c57e183dcea2e","user":{"login":"elliottyates","id":8975317,"node_id":"MDQ6VXNlcjg5NzUzMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8975317?v=4","gravatar_id":"","url":"https://api.github.com/users/elliottyates","html_url":"https://github.com/elliottyates","followers_url":"https://api.github.com/users/elliottyates/followers","following_url":"https://api.github.com/users/elliottyates/following{/other_user}","gists_url":"https://api.github.com/users/elliottyates/gists{/gist_id}","starred_url":"https://api.github.com/users/elliottyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliottyates/subscriptions","organizations_url":"https://api.github.com/users/elliottyates/orgs","repos_url":"https://api.github.com/users/elliottyates/repos","events_url":"https://api.github.com/users/elliottyates/events{/privacy}","received_events_url":"https://api.github.com/users/elliottyates/received_events","type":"User","site_admin":false},"body":"@KhaimovMR `.assert_called()` does not work if it comes after the `send_subscription_emails()` call, which is good -- that's expected. So the test really needs to read:\r\n\r\n```\r\nsend_subscription_emails()\r\nmock_do_send_subscriptions_to_recipients.assert_not_called()\r\n```\r\n\r\n(the extra `return_value` step is irrelevant and can be omitted, both in this test case and the one below, `test_subscriptions_sending_with_subscriptions`)","created_at":"2018-07-18T16:30:03Z","updated_at":"2018-07-18T16:30:04Z","html_url":"https://github.com/raccoongang/askup/pull/69#discussion_r203446418","pull_request_url":"https://api.github.com/repos/raccoongang/askup/pulls/69","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/raccoongang/askup/pulls/comments/203446418"},"html":{"href":"https://github.com/raccoongang/askup/pull/69#discussion_r203446418"},"pull_request":{"href":"https://api.github.com/repos/raccoongang/askup/pulls/69"}},"in_reply_to_id":203434456},"pull_request":{"url":"https://api.github.com/repos/raccoongang/askup/pulls/69","id":202263366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjYzMzY2","html_url":"https://github.com/raccoongang/askup/pull/69","diff_url":"https://github.com/raccoongang/askup/pull/69.diff","patch_url":"https://github.com/raccoongang/askup/pull/69.patch","issue_url":"https://api.github.com/repos/raccoongang/askup/issues/69","number":69,"state":"closed","locked":false,"title":"Admin and Teacher My Questions section shown fix.","user":{"login":"KhaimovMR","id":2059742,"node_id":"MDQ6VXNlcjIwNTk3NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2059742?v=4","gravatar_id":"","url":"https://api.github.com/users/KhaimovMR","html_url":"https://github.com/KhaimovMR","followers_url":"https://api.github.com/users/KhaimovMR/followers","following_url":"https://api.github.com/users/KhaimovMR/following{/other_user}","gists_url":"https://api.github.com/users/KhaimovMR/gists{/gist_id}","starred_url":"https://api.github.com/users/KhaimovMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhaimovMR/subscriptions","organizations_url":"https://api.github.com/users/KhaimovMR/orgs","repos_url":"https://api.github.com/users/KhaimovMR/repos","events_url":"https://api.github.com/users/KhaimovMR/events{/privacy}","received_events_url":"https://api.github.com/users/KhaimovMR/received_events","type":"User","site_admin":false},"body":"https://youtrack.raccoongang.com/issue/AU-31","created_at":"2018-07-18T14:00:17Z","updated_at":"2018-07-18T16:30:04Z","closed_at":"2018-07-18T16:08:33Z","merged_at":"2018-07-18T16:08:33Z","merge_commit_sha":"d05b1e0213f4f8a63295a9408118b580c4764c42","assignee":{"login":"KhaimovMR","id":2059742,"node_id":"MDQ6VXNlcjIwNTk3NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2059742?v=4","gravatar_id":"","url":"https://api.github.com/users/KhaimovMR","html_url":"https://github.com/KhaimovMR","followers_url":"https://api.github.com/users/KhaimovMR/followers","following_url":"https://api.github.com/users/KhaimovMR/following{/other_user}","gists_url":"https://api.github.com/users/KhaimovMR/gists{/gist_id}","starred_url":"https://api.github.com/users/KhaimovMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhaimovMR/subscriptions","organizations_url":"https://api.github.com/users/KhaimovMR/orgs","repos_url":"https://api.github.com/users/KhaimovMR/repos","events_url":"https://api.github.com/users/KhaimovMR/events{/privacy}","received_events_url":"https://api.github.com/users/KhaimovMR/received_events","type":"User","site_admin":false},"assignees":[{"login":"KhaimovMR","id":2059742,"node_id":"MDQ6VXNlcjIwNTk3NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2059742?v=4","gravatar_id":"","url":"https://api.github.com/users/KhaimovMR","html_url":"https://github.com/KhaimovMR","followers_url":"https://api.github.com/users/KhaimovMR/followers","following_url":"https://api.github.com/users/KhaimovMR/following{/other_user}","gists_url":"https://api.github.com/users/KhaimovMR/gists{/gist_id}","starred_url":"https://api.github.com/users/KhaimovMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhaimovMR/subscriptions","organizations_url":"https://api.github.com/users/KhaimovMR/orgs","repos_url":"https://api.github.com/users/KhaimovMR/repos","events_url":"https://api.github.com/users/KhaimovMR/events{/privacy}","received_events_url":"https://api.github.com/users/KhaimovMR/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raccoongang/askup/pulls/69/commits","review_comments_url":"https://api.github.com/repos/raccoongang/askup/pulls/69/comments","review_comment_url":"https://api.github.com/repos/raccoongang/askup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raccoongang/askup/issues/69/comments","statuses_url":"https://api.github.com/repos/raccoongang/askup/statuses/64de440fc1ccc303734fef8d3f36b59686e0409a","head":{"label":"raccoongang:khaimovmr/admin-teacher-dashboard-fix","ref":"khaimovmr/admin-teacher-dashboard-fix","sha":"64de440fc1ccc303734fef8d3f36b59686e0409a","user":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"repo":{"id":114992882,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5OTI4ODI=","name":"askup","full_name":"raccoongang/askup","owner":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raccoongang/askup","description":null,"fork":false,"url":"https://api.github.com/repos/raccoongang/askup","forks_url":"https://api.github.com/repos/raccoongang/askup/forks","keys_url":"https://api.github.com/repos/raccoongang/askup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raccoongang/askup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raccoongang/askup/teams","hooks_url":"https://api.github.com/repos/raccoongang/askup/hooks","issue_events_url":"https://api.github.com/repos/raccoongang/askup/issues/events{/number}","events_url":"https://api.github.com/repos/raccoongang/askup/events","assignees_url":"https://api.github.com/repos/raccoongang/askup/assignees{/user}","branches_url":"https://api.github.com/repos/raccoongang/askup/branches{/branch}","tags_url":"https://api.github.com/repos/raccoongang/askup/tags","blobs_url":"https://api.github.com/repos/raccoongang/askup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raccoongang/askup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raccoongang/askup/git/refs{/sha}","trees_url":"https://api.github.com/repos/raccoongang/askup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raccoongang/askup/statuses/{sha}","languages_url":"https://api.github.com/repos/raccoongang/askup/languages","stargazers_url":"https://api.github.com/repos/raccoongang/askup/stargazers","contributors_url":"https://api.github.com/repos/raccoongang/askup/contributors","subscribers_url":"https://api.github.com/repos/raccoongang/askup/subscribers","subscription_url":"https://api.github.com/repos/raccoongang/askup/subscription","commits_url":"https://api.github.com/repos/raccoongang/askup/commits{/sha}","git_commits_url":"https://api.github.com/repos/raccoongang/askup/git/commits{/sha}","comments_url":"https://api.github.com/repos/raccoongang/askup/comments{/number}","issue_comment_url":"https://api.github.com/repos/raccoongang/askup/issues/comments{/number}","contents_url":"https://api.github.com/repos/raccoongang/askup/contents/{+path}","compare_url":"https://api.github.com/repos/raccoongang/askup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raccoongang/askup/merges","archive_url":"https://api.github.com/repos/raccoongang/askup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raccoongang/askup/downloads","issues_url":"https://api.github.com/repos/raccoongang/askup/issues{/number}","pulls_url":"https://api.github.com/repos/raccoongang/askup/pulls{/number}","milestones_url":"https://api.github.com/repos/raccoongang/askup/milestones{/number}","notifications_url":"https://api.github.com/repos/raccoongang/askup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raccoongang/askup/labels{/name}","releases_url":"https://api.github.com/repos/raccoongang/askup/releases{/id}","deployments_url":"https://api.github.com/repos/raccoongang/askup/deployments","created_at":"2017-12-21T10:20:17Z","updated_at":"2018-07-18T16:08:35Z","pushed_at":"2018-07-18T16:08:34Z","git_url":"git://github.com/raccoongang/askup.git","ssh_url":"git@github.com:raccoongang/askup.git","clone_url":"https://github.com/raccoongang/askup.git","svn_url":"https://github.com/raccoongang/askup","homepage":null,"size":1749,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"raccoongang:development","ref":"development","sha":"b2175914f4b696c716ca8b5c24e697e0da2974cc","user":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"repo":{"id":114992882,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5OTI4ODI=","name":"askup","full_name":"raccoongang/askup","owner":{"login":"raccoongang","id":11388447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg4NDQ3","avatar_url":"https://avatars0.githubusercontent.com/u/11388447?v=4","gravatar_id":"","url":"https://api.github.com/users/raccoongang","html_url":"https://github.com/raccoongang","followers_url":"https://api.github.com/users/raccoongang/followers","following_url":"https://api.github.com/users/raccoongang/following{/other_user}","gists_url":"https://api.github.com/users/raccoongang/gists{/gist_id}","starred_url":"https://api.github.com/users/raccoongang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raccoongang/subscriptions","organizations_url":"https://api.github.com/users/raccoongang/orgs","repos_url":"https://api.github.com/users/raccoongang/repos","events_url":"https://api.github.com/users/raccoongang/events{/privacy}","received_events_url":"https://api.github.com/users/raccoongang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raccoongang/askup","description":null,"fork":false,"url":"https://api.github.com/repos/raccoongang/askup","forks_url":"https://api.github.com/repos/raccoongang/askup/forks","keys_url":"https://api.github.com/repos/raccoongang/askup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raccoongang/askup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raccoongang/askup/teams","hooks_url":"https://api.github.com/repos/raccoongang/askup/hooks","issue_events_url":"https://api.github.com/repos/raccoongang/askup/issues/events{/number}","events_url":"https://api.github.com/repos/raccoongang/askup/events","assignees_url":"https://api.github.com/repos/raccoongang/askup/assignees{/user}","branches_url":"https://api.github.com/repos/raccoongang/askup/branches{/branch}","tags_url":"https://api.github.com/repos/raccoongang/askup/tags","blobs_url":"https://api.github.com/repos/raccoongang/askup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raccoongang/askup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raccoongang/askup/git/refs{/sha}","trees_url":"https://api.github.com/repos/raccoongang/askup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raccoongang/askup/statuses/{sha}","languages_url":"https://api.github.com/repos/raccoongang/askup/languages","stargazers_url":"https://api.github.com/repos/raccoongang/askup/stargazers","contributors_url":"https://api.github.com/repos/raccoongang/askup/contributors","subscribers_url":"https://api.github.com/repos/raccoongang/askup/subscribers","subscription_url":"https://api.github.com/repos/raccoongang/askup/subscription","commits_url":"https://api.github.com/repos/raccoongang/askup/commits{/sha}","git_commits_url":"https://api.github.com/repos/raccoongang/askup/git/commits{/sha}","comments_url":"https://api.github.com/repos/raccoongang/askup/comments{/number}","issue_comment_url":"https://api.github.com/repos/raccoongang/askup/issues/comments{/number}","contents_url":"https://api.github.com/repos/raccoongang/askup/contents/{+path}","compare_url":"https://api.github.com/repos/raccoongang/askup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raccoongang/askup/merges","archive_url":"https://api.github.com/repos/raccoongang/askup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raccoongang/askup/downloads","issues_url":"https://api.github.com/repos/raccoongang/askup/issues{/number}","pulls_url":"https://api.github.com/repos/raccoongang/askup/pulls{/number}","milestones_url":"https://api.github.com/repos/raccoongang/askup/milestones{/number}","notifications_url":"https://api.github.com/repos/raccoongang/askup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raccoongang/askup/labels{/name}","releases_url":"https://api.github.com/repos/raccoongang/askup/releases{/id}","deployments_url":"https://api.github.com/repos/raccoongang/askup/deployments","created_at":"2017-12-21T10:20:17Z","updated_at":"2018-07-18T16:08:35Z","pushed_at":"2018-07-18T16:08:34Z","git_url":"git://github.com/raccoongang/askup.git","ssh_url":"git@github.com:raccoongang/askup.git","clone_url":"https://github.com/raccoongang/askup.git","svn_url":"https://github.com/raccoongang/askup","homepage":null,"size":1749,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/raccoongang/askup/pulls/69"},"html":{"href":"https://github.com/raccoongang/askup/pull/69"},"issue":{"href":"https://api.github.com/repos/raccoongang/askup/issues/69"},"comments":{"href":"https://api.github.com/repos/raccoongang/askup/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/raccoongang/askup/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/raccoongang/askup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raccoongang/askup/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/raccoongang/askup/statuses/64de440fc1ccc303734fef8d3f36b59686e0409a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"elliottyates"}}