{"action":"closed","number":484,"pull_request":{"url":"https://api.github.com/repos/eBay/ebayui-core/pulls/484","id":233656341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjU2MzQx","html_url":"https://github.com/eBay/ebayui-core/pull/484","diff_url":"https://github.com/eBay/ebayui-core/pull/484.diff","patch_url":"https://github.com/eBay/ebayui-core/pull/484.patch","issue_url":"https://api.github.com/repos/eBay/ebayui-core/issues/484","number":484,"state":"closed","locked":false,"title":"Convert ebay-icon to be a split component.","user":{"login":"DylanPiercey","id":4985201,"node_id":"MDQ6VXNlcjQ5ODUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis resolves #483 by making the `ebay-icon` a split component. This just involved extracting the client side logic and the rendering logic into two files that can be sent independently.\r\n\r\n## References\r\nfixes #483 ","created_at":"2018-11-26T18:35:26Z","updated_at":"2018-11-27T19:03:32Z","closed_at":"2018-11-27T19:03:31Z","merged_at":"2018-11-27T19:03:31Z","merge_commit_sha":"dfae03d34c6fff203d8ad339c753225945daa8f9","assignee":{"login":"DylanPiercey","id":4985201,"node_id":"MDQ6VXNlcjQ5ODUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false},"assignees":[{"login":"DylanPiercey","id":4985201,"node_id":"MDQ6VXNlcjQ5ODUyMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4985201?v=4","gravatar_id":"","url":"https://api.github.com/users/DylanPiercey","html_url":"https://github.com/DylanPiercey","followers_url":"https://api.github.com/users/DylanPiercey/followers","following_url":"https://api.github.com/users/DylanPiercey/following{/other_user}","gists_url":"https://api.github.com/users/DylanPiercey/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanPiercey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanPiercey/subscriptions","organizations_url":"https://api.github.com/users/DylanPiercey/orgs","repos_url":"https://api.github.com/users/DylanPiercey/repos","events_url":"https://api.github.com/users/DylanPiercey/events{/privacy}","received_events_url":"https://api.github.com/users/DylanPiercey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/eBay/ebayui-core/milestones/21","html_url":"https://github.com/eBay/ebayui-core/milestone/21","labels_url":"https://api.github.com/repos/eBay/ebayui-core/milestones/21/labels","id":3832488,"node_id":"MDk6TWlsZXN0b25lMzgzMjQ4OA==","number":21,"title":"v1.3.0","description":"Badge. Textbox icons.","creator":{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":3,"state":"open","created_at":"2018-11-19T17:52:39Z","updated_at":"2018-11-27T19:03:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/484/commits","review_comments_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/484/comments","review_comment_url":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/issues/484/comments","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/24cade382011b027cb26858096cf4eb89b7819c4","head":{"label":"eBay:483-icon-ssr","ref":"483-icon-ssr","sha":"24cade382011b027cb26858096cf4eb89b7819c4","user":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":123346792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzNDY3OTI=","name":"ebayui-core","full_name":"eBay/ebayui-core","private":false,"owner":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eBay/ebayui-core","description":"Collection of core eBay widgets; considered to be the building blocks for all composite components, pages & apps.","fork":false,"url":"https://api.github.com/repos/eBay/ebayui-core","forks_url":"https://api.github.com/repos/eBay/ebayui-core/forks","keys_url":"https://api.github.com/repos/eBay/ebayui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/ebayui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/ebayui-core/teams","hooks_url":"https://api.github.com/repos/eBay/ebayui-core/hooks","issue_events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/ebayui-core/events","assignees_url":"https://api.github.com/repos/eBay/ebayui-core/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/ebayui-core/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/ebayui-core/tags","blobs_url":"https://api.github.com/repos/eBay/ebayui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/ebayui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/ebayui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/ebayui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/ebayui-core/languages","stargazers_url":"https://api.github.com/repos/eBay/ebayui-core/stargazers","contributors_url":"https://api.github.com/repos/eBay/ebayui-core/contributors","subscribers_url":"https://api.github.com/repos/eBay/ebayui-core/subscribers","subscription_url":"https://api.github.com/repos/eBay/ebayui-core/subscription","commits_url":"https://api.github.com/repos/eBay/ebayui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/ebayui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/ebayui-core/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/ebayui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/ebayui-core/merges","archive_url":"https://api.github.com/repos/eBay/ebayui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/ebayui-core/downloads","issues_url":"https://api.github.com/repos/eBay/ebayui-core/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/ebayui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/ebayui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/ebayui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/ebayui-core/labels{/name}","releases_url":"https://api.github.com/repos/eBay/ebayui-core/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/ebayui-core/deployments","created_at":"2018-02-28T21:51:53Z","updated_at":"2018-11-27T18:22:25Z","pushed_at":"2018-11-27T19:03:31Z","git_url":"git://github.com/eBay/ebayui-core.git","ssh_url":"git@github.com:eBay/ebayui-core.git","clone_url":"https://github.com/eBay/ebayui-core.git","svn_url":"https://github.com/eBay/ebayui-core","homepage":"","size":1576,"stargazers_count":72,"watchers_count":72,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":38,"watchers":72,"default_branch":"master"}},"base":{"label":"eBay:1.3.0","ref":"1.3.0","sha":"45e1075674e81475f045d7687e253979585677fd","user":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"repo":{"id":123346792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzNDY3OTI=","name":"ebayui-core","full_name":"eBay/ebayui-core","private":false,"owner":{"login":"eBay","id":3639281,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzkyODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3639281?v=4","gravatar_id":"","url":"https://api.github.com/users/eBay","html_url":"https://github.com/eBay","followers_url":"https://api.github.com/users/eBay/followers","following_url":"https://api.github.com/users/eBay/following{/other_user}","gists_url":"https://api.github.com/users/eBay/gists{/gist_id}","starred_url":"https://api.github.com/users/eBay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eBay/subscriptions","organizations_url":"https://api.github.com/users/eBay/orgs","repos_url":"https://api.github.com/users/eBay/repos","events_url":"https://api.github.com/users/eBay/events{/privacy}","received_events_url":"https://api.github.com/users/eBay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eBay/ebayui-core","description":"Collection of core eBay widgets; considered to be the building blocks for all composite components, pages & apps.","fork":false,"url":"https://api.github.com/repos/eBay/ebayui-core","forks_url":"https://api.github.com/repos/eBay/ebayui-core/forks","keys_url":"https://api.github.com/repos/eBay/ebayui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eBay/ebayui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eBay/ebayui-core/teams","hooks_url":"https://api.github.com/repos/eBay/ebayui-core/hooks","issue_events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/events{/number}","events_url":"https://api.github.com/repos/eBay/ebayui-core/events","assignees_url":"https://api.github.com/repos/eBay/ebayui-core/assignees{/user}","branches_url":"https://api.github.com/repos/eBay/ebayui-core/branches{/branch}","tags_url":"https://api.github.com/repos/eBay/ebayui-core/tags","blobs_url":"https://api.github.com/repos/eBay/ebayui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eBay/ebayui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eBay/ebayui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eBay/ebayui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eBay/ebayui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eBay/ebayui-core/languages","stargazers_url":"https://api.github.com/repos/eBay/ebayui-core/stargazers","contributors_url":"https://api.github.com/repos/eBay/ebayui-core/contributors","subscribers_url":"https://api.github.com/repos/eBay/ebayui-core/subscribers","subscription_url":"https://api.github.com/repos/eBay/ebayui-core/subscription","commits_url":"https://api.github.com/repos/eBay/ebayui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eBay/ebayui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eBay/ebayui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eBay/ebayui-core/contents/{+path}","compare_url":"https://api.github.com/repos/eBay/ebayui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eBay/ebayui-core/merges","archive_url":"https://api.github.com/repos/eBay/ebayui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eBay/ebayui-core/downloads","issues_url":"https://api.github.com/repos/eBay/ebayui-core/issues{/number}","pulls_url":"https://api.github.com/repos/eBay/ebayui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eBay/ebayui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eBay/ebayui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eBay/ebayui-core/labels{/name}","releases_url":"https://api.github.com/repos/eBay/ebayui-core/releases{/id}","deployments_url":"https://api.github.com/repos/eBay/ebayui-core/deployments","created_at":"2018-02-28T21:51:53Z","updated_at":"2018-11-27T18:22:25Z","pushed_at":"2018-11-27T19:03:31Z","git_url":"git://github.com/eBay/ebayui-core.git","ssh_url":"git@github.com:eBay/ebayui-core.git","clone_url":"https://github.com/eBay/ebayui-core.git","svn_url":"https://github.com/eBay/ebayui-core","homepage":"","size":1576,"stargazers_count":72,"watchers_count":72,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":29,"open_issues":38,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/484"},"html":{"href":"https://github.com/eBay/ebayui-core/pull/484"},"issue":{"href":"https://api.github.com/repos/eBay/ebayui-core/issues/484"},"comments":{"href":"https://api.github.com/repos/eBay/ebayui-core/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eBay/ebayui-core/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/eBay/ebayui-core/statuses/24cade382011b027cb26858096cf4eb89b7819c4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ianmcburnie","id":38065,"node_id":"MDQ6VXNlcjM4MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/38065?v=4","gravatar_id":"","url":"https://api.github.com/users/ianmcburnie","html_url":"https://github.com/ianmcburnie","followers_url":"https://api.github.com/users/ianmcburnie/followers","following_url":"https://api.github.com/users/ianmcburnie/following{/other_user}","gists_url":"https://api.github.com/users/ianmcburnie/gists{/gist_id}","starred_url":"https://api.github.com/users/ianmcburnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianmcburnie/subscriptions","organizations_url":"https://api.github.com/users/ianmcburnie/orgs","repos_url":"https://api.github.com/users/ianmcburnie/repos","events_url":"https://api.github.com/users/ianmcburnie/events{/privacy}","received_events_url":"https://api.github.com/users/ianmcburnie/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":34,"deletions":23,"changed_files":3}}
{"actor":{"display_login":"ianmcburnie"}}